summaryrefslogtreecommitdiff
path: root/src/shader_recompiler/ir_opt/ssa_rewrite_pass.cpp
diff options
context:
space:
mode:
authorGravatar FernandoS272021-04-03 01:48:39 +0200
committerGravatar ameerj2021-07-22 21:51:26 -0400
commitbaec84247fe815199595d9e8077b71f3b5c8317e (patch)
tree84195625ffb43922ba87b25296057bdeb9f22a2c /src/shader_recompiler/ir_opt/ssa_rewrite_pass.cpp
parentshader: Implement SR_LaneId (diff)
downloadyuzu-baec84247fe815199595d9e8077b71f3b5c8317e.tar.gz
yuzu-baec84247fe815199595d9e8077b71f3b5c8317e.tar.xz
yuzu-baec84247fe815199595d9e8077b71f3b5c8317e.zip
shader: Address Feedback
Diffstat (limited to 'src/shader_recompiler/ir_opt/ssa_rewrite_pass.cpp')
-rw-r--r--src/shader_recompiler/ir_opt/ssa_rewrite_pass.cpp50
1 files changed, 1 insertions, 49 deletions
diff --git a/src/shader_recompiler/ir_opt/ssa_rewrite_pass.cpp b/src/shader_recompiler/ir_opt/ssa_rewrite_pass.cpp
index 7dab33034..72d4abb77 100644
--- a/src/shader_recompiler/ir_opt/ssa_rewrite_pass.cpp
+++ b/src/shader_recompiler/ir_opt/ssa_rewrite_pass.cpp
@@ -38,10 +38,6 @@ struct ZeroFlagTag : FlagTag {};
38struct SignFlagTag : FlagTag {}; 38struct SignFlagTag : FlagTag {};
39struct CarryFlagTag : FlagTag {}; 39struct CarryFlagTag : FlagTag {};
40struct OverflowFlagTag : FlagTag {}; 40struct OverflowFlagTag : FlagTag {};
41struct FCSMFlagTag : FlagTag {};
42struct TAFlagTag : FlagTag {};
43struct TRFlagTag : FlagTag {};
44struct MXFlagTag : FlagTag {};
45 41
46struct GotoVariable : FlagTag { 42struct GotoVariable : FlagTag {
47 GotoVariable() = default; 43 GotoVariable() = default;
@@ -57,8 +53,7 @@ struct IndirectBranchVariable {
57}; 53};
58 54
59using Variant = std::variant<IR::Reg, IR::Pred, ZeroFlagTag, SignFlagTag, CarryFlagTag, 55using Variant = std::variant<IR::Reg, IR::Pred, ZeroFlagTag, SignFlagTag, CarryFlagTag,
60 OverflowFlagTag, FCSMFlagTag, TAFlagTag, TRFlagTag, MXFlagTag, 56 OverflowFlagTag, GotoVariable, IndirectBranchVariable>;
61 GotoVariable, IndirectBranchVariable>;
62using ValueMap = boost::container::flat_map<IR::Block*, IR::Value, std::less<IR::Block*>>; 57using ValueMap = boost::container::flat_map<IR::Block*, IR::Value, std::less<IR::Block*>>;
63 58
64struct DefTable { 59struct DefTable {
@@ -94,22 +89,6 @@ struct DefTable {
94 return overflow_flag; 89 return overflow_flag;
95 } 90 }
96 91
97 [[nodiscard]] ValueMap& operator[](FCSMFlagTag) noexcept {
98 return fcsm_flag;
99 }
100
101 [[nodiscard]] ValueMap& operator[](TAFlagTag) noexcept {
102 return ta_flag;
103 }
104
105 [[nodiscard]] ValueMap& operator[](TRFlagTag) noexcept {
106 return tr_flag;
107 }
108
109 [[nodiscard]] ValueMap& operator[](MXFlagTag) noexcept {
110 return mr_flag;
111 }
112
113 std::array<ValueMap, IR::NUM_USER_REGS> regs; 92 std::array<ValueMap, IR::NUM_USER_REGS> regs;
114 std::array<ValueMap, IR::NUM_USER_PREDS> preds; 93 std::array<ValueMap, IR::NUM_USER_PREDS> preds;
115 boost::container::flat_map<u32, ValueMap> goto_vars; 94 boost::container::flat_map<u32, ValueMap> goto_vars;
@@ -118,10 +97,6 @@ struct DefTable {
118 ValueMap sign_flag; 97 ValueMap sign_flag;
119 ValueMap carry_flag; 98 ValueMap carry_flag;
120 ValueMap overflow_flag; 99 ValueMap overflow_flag;
121 ValueMap fcsm_flag;
122 ValueMap ta_flag;
123 ValueMap tr_flag;
124 ValueMap mr_flag;
125}; 100};
126 101
127IR::Opcode UndefOpcode(IR::Reg) noexcept { 102IR::Opcode UndefOpcode(IR::Reg) noexcept {
@@ -272,18 +247,6 @@ void VisitInst(Pass& pass, IR::Block* block, IR::Inst& inst) {
272 case IR::Opcode::SetOFlag: 247 case IR::Opcode::SetOFlag:
273 pass.WriteVariable(OverflowFlagTag{}, block, inst.Arg(0)); 248 pass.WriteVariable(OverflowFlagTag{}, block, inst.Arg(0));
274 break; 249 break;
275 case IR::Opcode::SetFCSMFlag:
276 pass.WriteVariable(FCSMFlagTag{}, block, inst.Arg(0));
277 break;
278 case IR::Opcode::SetTAFlag:
279 pass.WriteVariable(TAFlagTag{}, block, inst.Arg(0));
280 break;
281 case IR::Opcode::SetTRFlag:
282 pass.WriteVariable(TRFlagTag{}, block, inst.Arg(0));
283 break;
284 case IR::Opcode::SetMXFlag:
285 pass.WriteVariable(MXFlagTag{}, block, inst.Arg(0));
286 break;
287 case IR::Opcode::GetRegister: 250 case IR::Opcode::GetRegister:
288 if (const IR::Reg reg{inst.Arg(0).Reg()}; reg != IR::Reg::RZ) { 251 if (const IR::Reg reg{inst.Arg(0).Reg()}; reg != IR::Reg::RZ) {
289 inst.ReplaceUsesWith(pass.ReadVariable(reg, block)); 252 inst.ReplaceUsesWith(pass.ReadVariable(reg, block));
@@ -312,17 +275,6 @@ void VisitInst(Pass& pass, IR::Block* block, IR::Inst& inst) {
312 case IR::Opcode::GetOFlag: 275 case IR::Opcode::GetOFlag:
313 inst.ReplaceUsesWith(pass.ReadVariable(OverflowFlagTag{}, block)); 276 inst.ReplaceUsesWith(pass.ReadVariable(OverflowFlagTag{}, block));
314 break; 277 break;
315 case IR::Opcode::GetFCSMFlag:
316 inst.ReplaceUsesWith(pass.ReadVariable(FCSMFlagTag{}, block));
317 break;
318 case IR::Opcode::GetTAFlag:
319 inst.ReplaceUsesWith(pass.ReadVariable(TAFlagTag{}, block));
320 break;
321 case IR::Opcode::GetTRFlag:
322 inst.ReplaceUsesWith(pass.ReadVariable(TRFlagTag{}, block));
323 break;
324 case IR::Opcode::GetMXFlag:
325 inst.ReplaceUsesWith(pass.ReadVariable(MXFlagTag{}, block));
326 break; 278 break;
327 default: 279 default:
328 break; 280 break;