Replace bunch of our string utilities with str library

7 files changed, 28 insertions, 62 deletions

diff --git a/ocicl.csv b/ocicl.csv
index 3918f74..ecc65f6 100644
--- a/ocicl.csv
+++ b/ocicl.csv
@@ -14,6 +14,7 @@ chipz, ghcr.io/ocicl/chipz@sha256:fae0fae0c93199ba57c92d9102245a55c8a2c12af4442e
 chunga, ghcr.io/ocicl/chunga@sha256:a2558d54ac5d4ccdbf49d7b51fcb074762d77e263ec67245f6d2928477b6d19a, chunga-20250814-1310e96/chunga.asd
 cl-base64, ghcr.io/ocicl/cl-base64@sha256:702412dbc1ed825e275fb23e22c29527eb786bf644e47c7621bf0dbb34e17c7e, cl-base64-20240503-80496b7/cl-base64.asd
 cl-base64-tests, ghcr.io/ocicl/cl-base64@sha256:702412dbc1ed825e275fb23e22c29527eb786bf644e47c7621bf0dbb34e17c7e, cl-base64-20240503-80496b7/cl-base64-tests.asd
+cl-change-case, ghcr.io/ocicl/cl-change-case@sha256:07b51346796724d063c8d2515dd7c63f5e8a3a9c0017bc429b0d1313e257fd78, cl-change-case-1.0/cl-change-case.asd
 cl-cookie, ghcr.io/ocicl/cl-cookie@sha256:85cd8aa7f1379d041fae9530609cd68d5214fb978bc87faa7fd9ad5ad7e08a83, cl-cookie-20240703-6bcb74a/cl-cookie.asd
 cl-cookie-test, ghcr.io/ocicl/cl-cookie@sha256:85cd8aa7f1379d041fae9530609cd68d5214fb978bc87faa7fd9ad5ad7e08a83, cl-cookie-20240703-6bcb74a/cl-cookie-test.asd
 cl-postgres_plus_local-time, ghcr.io/ocicl/local-time@sha256:15dc0e56d0ff55bd2a3c597e67be1c26bd0677c230a15ad5098c5207a9df5554, local-time-20250808-c28f38e/cl-postgres+local-time.asd
@@ -72,6 +73,8 @@ split-sequence, ghcr.io/ocicl/split-sequence@sha256:3a37662eedd99c42995587b9d443
 sqlite, ghcr.io/ocicl/sqlite@sha256:a7f80757e6ee13af06e2eeaeff1e079dba439d85ea5c7f68e262bccc40dcbd5c, cl-sqlite-0.2.1/sqlite.asd
 sqlite-tests, ghcr.io/ocicl/sqlite@sha256:a7f80757e6ee13af06e2eeaeff1e079dba439d85ea5c7f68e262bccc40dcbd5c, cl-sqlite-0.2.1/sqlite-tests.asd
 static-vectors, ghcr.io/ocicl/static-vectors@sha256:53e11e5689c3dbea6a3017760b55f052588003d774913539930ddc4330a69970, static-vectors-20240624-3d9d89b/static-vectors.asd
+str, ghcr.io/ocicl/str@sha256:685078f7554071268bca9e933392904940d6751077718a4aafaf3d0424003f26, cl-str-20250905-69ef8b4/str.asd
+str.test, ghcr.io/ocicl/str@sha256:685078f7554071268bca9e933392904940d6751077718a4aafaf3d0424003f26, cl-str-20250905-69ef8b4/str.test.asd
 string-case, ghcr.io/ocicl/string-case@sha256:9db2d4160b76ce1ed9f754d12f679c665593a9a436177d36380a1a8a176ec16a, string-case-20240503-718c761/string-case.asd
 swap-bytes, ghcr.io/ocicl/swap-bytes@sha256:06edc17deb0f27cdf6290689711ece670a8282dfd07b732a9adc541af1ce7ed6, swap-bytes-20240503-43ab141/swap-bytes.asd
 trivia, ghcr.io/ocicl/trivia@sha256:51db74757bc31ceaf3a643914a8ffa87825799097dea4912650e6ac62bed5209, trivia-20240904-4383dd8/trivia.asd
diff --git a/src/hash-tables.lisp b/src/hash-tables.lisp
index d3b66dd..84ffbfe 100644
--- a/src/hash-tables.lisp
+++ b/src/hash-tables.lisp
@@ -1,7 +1,7 @@
 ;; SPDX-License-Identifier: EUPL-1.2
 ;; SPDX-FileCopyrightText: 2025 Uko Kokņevičs <perkontevs@gmail.com>
 (defpackage :ukkoclot/hash-tables
-  (:documentation "Utilities for dealing with hash tables.")
+  (:documentation "Hash-table-oriented utilities.")
   (:use :c2cl)
   (:import-from :alexandria :with-gensyms)
   (:export :alist->hash-table :gethash-lazy :plist->hash-table))
diff --git a/src/main.lisp b/src/main.lisp
index 28c3801..5d3cf76 100644
--- a/src/main.lisp
+++ b/src/main.lisp
@@ -7,11 +7,11 @@
   (:import-from :com.dieggsy.f-string :enable-f-strings)
   (:import-from :log)
   (:import-from :serapeum :drop)
+  (:import-from :str)
   (:import-from :ukkoclot/db :with-db)
   (:import-from :ukkoclot/serializing :fixup-value)
   (:import-from :ukkoclot/state :make-bot :bot-config :bot-power-on)
-  (:import-from :ukkoclot/strings
-   :escape-xml :is-tg-whitespace :is-tg-whitespace-str :starts-with :starts-with-ignore-case)
+  (:import-from :ukkoclot/strings :escape-xml :is-tg-whitespace :is-tg-whitespace-str)
   (:local-nicknames
    (:jzon :com.inuoe.jzon))
   (:export :main))
@@ -70,7 +70,7 @@
 (defun on-callback-query (bot cb)
   (let ((data (callback-query-data cb)))
     (cond ((and data
-                (starts-with data "bbl:")
+                (str:starts-with-p "bbl:" data :ignore-case nil)
                 (= (user-id (callback-query-from cb))
                    (config-owner (bot-config bot))))
            (let ((bot-id (read-from-string data t nil :start 4)))
@@ -83,7 +83,7 @@
                                   :callback-query-id (callback-query-id cb)
                                   :text "OK"))
           ((and data
-                (starts-with data "bwl:")
+                (str:starts-with-p "bwl:" data :ignore-case nil)
                 (= (user-id (callback-query-from cb))
                    (config-owner (bot-config bot))))
            (let ((bot-id (read-from-string data t nil :start 4)))
@@ -161,7 +161,7 @@
           ((equal text ">:3")
            (reply-message bot msg "<b>&gt;:3</b>" :parse-mode html))
 
-          ((starts-with-ignore-case text "big ")
+          ((str:starts-with-p "big " text)
            (let ((the-text (drop 4 text)))
              (unless (is-tg-whitespace-str the-text)
                (reply-message bot msg
@@ -190,12 +190,12 @@
                           (or (message-reply-to-message msg) msg)
                           "dio cane"))
 
-          ((starts-with-ignore-case text "say ")
+          ((str:starts-with-p "say " text)
            (let ((the-text (drop 4 text)))
              (unless (is-tg-whitespace-str the-text)
                (reply-message bot msg the-text))))
 
-          ((starts-with-ignore-case text "tiny ")
+          ((str:starts-with-p "tiny " text)
            (let ((the-text (drop 5 text)))
              (unless (is-tg-whitespace-str the-text)
                (reply-message bot msg
diff --git a/src/serializing.lisp b/src/serializing.lisp
index 205190f..71b0fb2 100644
--- a/src/serializing.lisp
+++ b/src/serializing.lisp
@@ -3,7 +3,7 @@
 (defpackage :ukkoclot/serializing
   (:use :c2cl :iterate)
   (:import-from :log)
-  (:import-from :ukkoclot/strings :lisp->snake-case)
+  (:import-from :str)
   (:local-nicknames
    (:jzon :com.inuoe.jzon))
   (:export :fixup-args :fixup-value :parse-value :try-parse-value))
@@ -11,9 +11,7 @@
 
 (defun fixup-args (args)
   (iter (for (key . value) in args)
-        (collect
-            (cons (string-downcase (lisp->snake-case (symbol-name key)))
-                  (fixup-value value)))))
+        (collect (cons (str:snake-case key) (fixup-value value)))))
 
 (defgeneric fixup-value (value)
   (:documentation "Fixup outgoing *top-level* `value' before passing it to telegram.")
diff --git a/src/strings.lisp b/src/strings.lisp
index b1b4f00..eae8ec0 100644
--- a/src/strings.lisp
+++ b/src/strings.lisp
@@ -1,33 +1,30 @@
 ;; SPDX-License-Identifier: EUPL-1.2
 ;; SPDX-FileCopyrightText: 2025 Uko Kokņevičs <perkontevs@gmail.com>
 (defpackage :ukkoclot/strings
+  (:documentation "String-oriented utilities.")
   (:use :c2cl :iterate)
   (:import-from :cl-unicode :general-category)
   (:export
-   :ends-with
    :escape-xml
    :is-tg-whitespace
-   :is-tg-whitespace-str
-   :lisp->camel-case
-   :lisp->snake-case
-   :snake->lisp-case
-   :starts-with
-   :starts-with-ignore-case))
+   :is-tg-whitespace-str))
 (in-package :ukkoclot/strings)
 
 ;; These are very inefficient but I don't care until I profile
 
-(defun ends-with (str suffix)
-  (and (> (length str) (length suffix))
-       (string= str suffix :start1 (- (length str) (length suffix)))))
-
 (defun escape-xml (str &optional out)
+  "Escape special XML characters in the STR.
+
+OUT is the output stream or `nil' for outputting to a string."
   (if out
       (escape-xml% str out)
       (with-output-to-string (out)
         (escape-xml% str out))))
 
 (defun escape-xml% (str out)
+  "See `escape-xml'.
+
+OUT is always the stream."
   (loop for ch across str do
     (case ch
       (#\< (write-string "&lt;" out))
@@ -37,6 +34,7 @@
       (otherwise (write-char ch out)))))
 
 (defun is-tg-whitespace (ch)
+  "Checks if CH on its own would be considered whitespace by telegram."
   (let ((gc (general-category ch)))
     (or (string= gc "Zs")               ; Separator, space
         (string= gc "Zl")               ; Separator, line
@@ -45,39 +43,6 @@
         (= (char-code ch) #x2800))))    ; BRAILLE PATTERN BLANK
 
 (defun is-tg-whitespace-str (str)
+  "Checks if message containing just STR would be considered whitespace by telegram."
   (iter (for ch in-string str)
     (always (is-tg-whitespace ch))))
-
-(defun lisp->camel-case (str)
-  (with-output-to-string (out)
-    (let ((should-caps nil))
-      (iter (for ch in-string str)
-            (cond ((char= ch #\-)
-                   (setf should-caps t))
-                  (should-caps
-                   (write-char (char-upcase ch) out)
-                   (setf should-caps nil))
-                  (t
-                   (write-char (char-downcase ch) out)))))))
-
-(defun lisp->snake-case (str)
-  (with-output-to-string (out)
-    (loop for ch across str do
-      (case ch
-        (#\- (write-char #\_ out))
-        (otherwise (write-char ch out))))))
-
-(defun snake->lisp-case (str)
-  (with-output-to-string (out)
-    (loop for ch across str do
-      (case ch
-        (#\_ (write-char #\- out))
-        (otherwise (write-char ch out))))))
-
-(defun starts-with (str prefix)
-  (and (> (length str) (length prefix))
-       (string= str prefix :end1 (length prefix))))
-
-(defun starts-with-ignore-case (str prefix)
-  (and (> (length str) (length prefix))
-       (string-equal str prefix :end1 (length prefix))))
diff --git a/src/tg/method-macros.lisp b/src/tg/method-macros.lisp
index b924e15..0be6f00 100644
--- a/src/tg/method-macros.lisp
+++ b/src/tg/method-macros.lisp
@@ -6,8 +6,8 @@
   (:import-from :alexandria :with-gensyms)
   (:import-from :com.dieggsy.f-string :enable-f-strings)
   (:import-from :serapeum :take)
+  (:import-from :str)
   (:import-from :ukkoclot/state :bot)
-  (:import-from :ukkoclot/strings :ends-with :lisp->camel-case)
   (:import-from :ukkoclot/transport :do-call)
   (:export :define-tg-method))
 (in-package :ukkoclot/tg/method-macros)
@@ -36,8 +36,8 @@
           (collect (apply #'make-param param-spec))))
 
   (defun path-from-name (name)
-    (let ((str (lisp->camel-case (symbol-name name))))
-      (if (ends-with str "%")
+    (let ((str (str:camel-case name)))
+      (if (str:ends-with-p "%" str :ignore-case nil)
           (take (- (length str) 1) str)
           str)))
 
diff --git a/src/tg/type-macros.lisp b/src/tg/type-macros.lisp
index 5f99cba..75afab0 100644
--- a/src/tg/type-macros.lisp
+++ b/src/tg/type-macros.lisp
@@ -5,9 +5,9 @@
   (:use :c2cl :iterate)
   (:import-from :alexandria :with-gensyms)
   (:import-from :com.dieggsy.f-string :enable-f-strings)
+  (:import-from :str)
   (:import-from :ukkoclot/serializing :parse-value)
   (:import-from :ukkoclot/hash-tables :gethash-lazy)
-  (:import-from :ukkoclot/strings :lisp->snake-case)
   (:local-nicknames
    (:jzon :com.inuoe.jzon))
   (:export :define-tg-type))
@@ -39,7 +39,7 @@
     (intern (concatenate 'string (symbol-name name) "-" (symbol-name (field-name field)))))
 
   (defun field-hash-key (field)
-    (string-downcase (lisp->snake-case (symbol-name (field-name field)))))
+    (str:snake-case (field-name field)))
 
   (defun field-keyword (field)
     (intern (symbol-name (field-name field)) :keyword))