Don't save empty classes (#474)

Co-authored-by: ByMartrixx <bymartrixx@gmail.com>

1 files changed, 14 insertions, 0 deletions

diff --git a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/enigma/EnigmaMappingsWriter.java b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/enigma/EnigmaMappingsWriter.java
index cd00ef77..df1af912 100644
--- a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/enigma/EnigmaMappingsWriter.java
+++ b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/enigma/EnigmaMappingsWriter.java
@@ -26,6 +26,7 @@ import java.util.Collection;
 import java.util.Collections;
 import java.util.Objects;
 import java.util.concurrent.atomic.AtomicInteger;
+import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
 import javax.annotation.Nonnull;
@@ -78,6 +79,8 @@ public enum EnigmaMappingsWriter implements MappingsWriter {
 
                         applyDeletions(path, changedClasses, mappings, delta.getBaseMappings(), saveParameters.getFileNameFormat());
 
+                        changedClasses = changedClasses.stream().filter(entry -> !isClassEmpty(mappings, entry)).collect(Collectors.toList());
+
                         progress.init(changedClasses.size(), I18n.translate("progress.mappings.enigma_directory.writing"));
 
                         AtomicInteger steps = new AtomicInteger();
@@ -313,4 +316,15 @@ public enum EnigmaMappingsWriter implements MappingsWriter {
                 builder.append(line.trim());
                 return builder.toString();
         }
+
+        protected boolean isClassEmpty(EntryTree<EntryMapping> mappings, ClassEntry classEntry) {
+                Collection<Entry<?>> children = groupChildren(mappings.getChildren(classEntry));
+
+                EntryMapping classEntryMapping = mappings.get(classEntry);
+                return children.isEmpty() && (classEntryMapping == null || isMappingEmpty(classEntryMapping));
+        }
+
+        private boolean isMappingEmpty(EntryMapping mapping) {
+                return mapping.targetName() == null && mapping.accessModifier() == AccessModifier.UNCHANGED && mapping.javadoc() == null;
+        }
 }