From 54eafbaf172309d92c6b2c5069de23fc534dd2d2 Mon Sep 17 00:00:00 2001
From: Lioncash
Date: Mon, 13 Dec 2021 20:43:09 -0500
Subject: common/input: Remove unnecessary returns

Given these return void, these can be omitted.
---
 src/common/input.h | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

(limited to 'src/common')

diff --git a/src/common/input.h b/src/common/input.h
index 0b92449bc..848ad7b81 100644
--- a/src/common/input.h
+++ b/src/common/input.h
@@ -236,14 +236,10 @@ public:
     virtual ~InputDevice() = default;
 
     // Request input device to update if necessary
-    virtual void SoftUpdate() {
-        return;
-    }
+    virtual void SoftUpdate() {}
 
     // Force input device to update data regardless of the current state
-    virtual void ForceUpdate() {
-        return;
-    }
+    virtual void ForceUpdate() {}
 
     // Sets the function to be triggered when input changes
     void SetCallback(InputCallback callback_) {
-- 
cgit v1.2.3


From e05d2a70b24e550d67fcdd24aae7094ad41745f8 Mon Sep 17 00:00:00 2001
From: Lioncash
Date: Mon, 13 Dec 2021 21:09:28 -0500
Subject: common/input: Avoid numerous large copies of CallbackStatus

CallbackStatus instances aren't the cheapest things to copy around
(relative to everything else), given that they're currently 520 bytes in
size and are currently copied numerous times when callbacks are invoked.

Instead, we can pass the status by const reference to avoid all the
copying.
---
 src/common/input.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'src/common')

diff --git a/src/common/input.h b/src/common/input.h
index 848ad7b81..f775a4c01 100644
--- a/src/common/input.h
+++ b/src/common/input.h
@@ -227,7 +227,7 @@ struct CallbackStatus {
 
 // Triggered once every input change
 struct InputCallback {
-    std::function<void(CallbackStatus)> on_change;
+    std::function<void(const CallbackStatus&)> on_change;
 };
 
 /// An abstract class template for an input device (a button, an analog input, etc.).
@@ -247,7 +247,7 @@ public:
     }
 
     // Triggers the function set in the callback
-    void TriggerOnChange(CallbackStatus status) {
+    void TriggerOnChange(const CallbackStatus& status) {
         if (callback.on_change) {
             callback.on_change(status);
         }
-- 
cgit v1.2.3