diff options
Diffstat (limited to 'src')
257 files changed, 7190 insertions, 2456 deletions
diff --git a/src/android/app/build.gradle.kts b/src/android/app/build.gradle.kts index 84a3308b7..ac43d84b7 100644 --- a/src/android/app/build.gradle.kts +++ b/src/android/app/build.gradle.kts | |||
| @@ -27,7 +27,7 @@ android { | |||
| 27 | namespace = "org.yuzu.yuzu_emu" | 27 | namespace = "org.yuzu.yuzu_emu" |
| 28 | 28 | ||
| 29 | compileSdkVersion = "android-34" | 29 | compileSdkVersion = "android-34" |
| 30 | ndkVersion = "25.2.9519653" | 30 | ndkVersion = "26.1.10909125" |
| 31 | 31 | ||
| 32 | buildFeatures { | 32 | buildFeatures { |
| 33 | viewBinding = true | 33 | viewBinding = true |
| @@ -203,23 +203,23 @@ ktlint { | |||
| 203 | } | 203 | } |
| 204 | 204 | ||
| 205 | dependencies { | 205 | dependencies { |
| 206 | implementation("androidx.core:core-ktx:1.10.1") | 206 | implementation("androidx.core:core-ktx:1.12.0") |
| 207 | implementation("androidx.appcompat:appcompat:1.6.1") | 207 | implementation("androidx.appcompat:appcompat:1.6.1") |
| 208 | implementation("androidx.recyclerview:recyclerview:1.3.0") | 208 | implementation("androidx.recyclerview:recyclerview:1.3.1") |
| 209 | implementation("androidx.constraintlayout:constraintlayout:2.1.4") | 209 | implementation("androidx.constraintlayout:constraintlayout:2.1.4") |
| 210 | implementation("androidx.fragment:fragment-ktx:1.6.0") | 210 | implementation("androidx.fragment:fragment-ktx:1.6.1") |
| 211 | implementation("androidx.documentfile:documentfile:1.0.1") | 211 | implementation("androidx.documentfile:documentfile:1.0.1") |
| 212 | implementation("com.google.android.material:material:1.9.0") | 212 | implementation("com.google.android.material:material:1.9.0") |
| 213 | implementation("androidx.preference:preference:1.2.0") | 213 | implementation("androidx.preference:preference-ktx:1.2.1") |
| 214 | implementation("androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.1") | 214 | implementation("androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2") |
| 215 | implementation("io.coil-kt:coil:2.2.2") | 215 | implementation("io.coil-kt:coil:2.2.2") |
| 216 | implementation("androidx.core:core-splashscreen:1.0.1") | 216 | implementation("androidx.core:core-splashscreen:1.0.1") |
| 217 | implementation("androidx.window:window:1.2.0-beta03") | 217 | implementation("androidx.window:window:1.2.0-beta03") |
| 218 | implementation("org.ini4j:ini4j:0.5.4") | 218 | implementation("org.ini4j:ini4j:0.5.4") |
| 219 | implementation("androidx.constraintlayout:constraintlayout:2.1.4") | 219 | implementation("androidx.constraintlayout:constraintlayout:2.1.4") |
| 220 | implementation("androidx.swiperefreshlayout:swiperefreshlayout:1.1.0") | 220 | implementation("androidx.swiperefreshlayout:swiperefreshlayout:1.1.0") |
| 221 | implementation("androidx.navigation:navigation-fragment-ktx:2.6.0") | 221 | implementation("androidx.navigation:navigation-fragment-ktx:2.7.4") |
| 222 | implementation("androidx.navigation:navigation-ui-ktx:2.6.0") | 222 | implementation("androidx.navigation:navigation-ui-ktx:2.7.4") |
| 223 | implementation("info.debatty:java-string-similarity:2.0.0") | 223 | implementation("info.debatty:java-string-similarity:2.0.0") |
| 224 | implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.5.0") | 224 | implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.5.0") |
| 225 | } | 225 | } |
diff --git a/src/android/app/src/main/AndroidManifest.xml b/src/android/app/src/main/AndroidManifest.xml index 832c08e15..a67351727 100644 --- a/src/android/app/src/main/AndroidManifest.xml +++ b/src/android/app/src/main/AndroidManifest.xml | |||
| @@ -28,7 +28,6 @@ SPDX-License-Identifier: GPL-3.0-or-later | |||
| 28 | android:appCategory="game" | 28 | android:appCategory="game" |
| 29 | android:localeConfig="@xml/locales_config" | 29 | android:localeConfig="@xml/locales_config" |
| 30 | android:banner="@drawable/tv_banner" | 30 | android:banner="@drawable/tv_banner" |
| 31 | android:extractNativeLibs="true" | ||
| 32 | android:fullBackupContent="@xml/data_extraction_rules" | 31 | android:fullBackupContent="@xml/data_extraction_rules" |
| 33 | android:dataExtractionRules="@xml/data_extraction_rules_api_31" | 32 | android:dataExtractionRules="@xml/data_extraction_rules_api_31" |
| 34 | android:enableOnBackInvokedCallback="true"> | 33 | android:enableOnBackInvokedCallback="true"> |
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/NativeLibrary.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/NativeLibrary.kt index 6e39e542b..115f72710 100644 --- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/NativeLibrary.kt +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/NativeLibrary.kt | |||
| @@ -15,13 +15,9 @@ import androidx.annotation.Keep | |||
| 15 | import androidx.fragment.app.DialogFragment | 15 | import androidx.fragment.app.DialogFragment |
| 16 | import com.google.android.material.dialog.MaterialAlertDialogBuilder | 16 | import com.google.android.material.dialog.MaterialAlertDialogBuilder |
| 17 | import java.lang.ref.WeakReference | 17 | import java.lang.ref.WeakReference |
| 18 | import org.yuzu.yuzu_emu.YuzuApplication.Companion.appContext | ||
| 19 | import org.yuzu.yuzu_emu.activities.EmulationActivity | 18 | import org.yuzu.yuzu_emu.activities.EmulationActivity |
| 20 | import org.yuzu.yuzu_emu.utils.DocumentsTree.Companion.isNativePath | 19 | import org.yuzu.yuzu_emu.utils.DocumentsTree.Companion.isNativePath |
| 21 | import org.yuzu.yuzu_emu.utils.FileUtil.exists | 20 | import org.yuzu.yuzu_emu.utils.FileUtil |
| 22 | import org.yuzu.yuzu_emu.utils.FileUtil.getFileSize | ||
| 23 | import org.yuzu.yuzu_emu.utils.FileUtil.isDirectory | ||
| 24 | import org.yuzu.yuzu_emu.utils.FileUtil.openContentUri | ||
| 25 | import org.yuzu.yuzu_emu.utils.Log | 21 | import org.yuzu.yuzu_emu.utils.Log |
| 26 | import org.yuzu.yuzu_emu.utils.SerializableHelper.serializable | 22 | import org.yuzu.yuzu_emu.utils.SerializableHelper.serializable |
| 27 | 23 | ||
| @@ -75,7 +71,7 @@ object NativeLibrary { | |||
| 75 | return if (isNativePath(path!!)) { | 71 | return if (isNativePath(path!!)) { |
| 76 | YuzuApplication.documentsTree!!.openContentUri(path, openmode) | 72 | YuzuApplication.documentsTree!!.openContentUri(path, openmode) |
| 77 | } else { | 73 | } else { |
| 78 | openContentUri(appContext, path, openmode) | 74 | FileUtil.openContentUri(path, openmode) |
| 79 | } | 75 | } |
| 80 | } | 76 | } |
| 81 | 77 | ||
| @@ -85,7 +81,7 @@ object NativeLibrary { | |||
| 85 | return if (isNativePath(path!!)) { | 81 | return if (isNativePath(path!!)) { |
| 86 | YuzuApplication.documentsTree!!.getFileSize(path) | 82 | YuzuApplication.documentsTree!!.getFileSize(path) |
| 87 | } else { | 83 | } else { |
| 88 | getFileSize(appContext, path) | 84 | FileUtil.getFileSize(path) |
| 89 | } | 85 | } |
| 90 | } | 86 | } |
| 91 | 87 | ||
| @@ -95,7 +91,7 @@ object NativeLibrary { | |||
| 95 | return if (isNativePath(path!!)) { | 91 | return if (isNativePath(path!!)) { |
| 96 | YuzuApplication.documentsTree!!.exists(path) | 92 | YuzuApplication.documentsTree!!.exists(path) |
| 97 | } else { | 93 | } else { |
| 98 | exists(appContext, path) | 94 | FileUtil.exists(path) |
| 99 | } | 95 | } |
| 100 | } | 96 | } |
| 101 | 97 | ||
| @@ -105,7 +101,7 @@ object NativeLibrary { | |||
| 105 | return if (isNativePath(path!!)) { | 101 | return if (isNativePath(path!!)) { |
| 106 | YuzuApplication.documentsTree!!.isDirectory(path) | 102 | YuzuApplication.documentsTree!!.isDirectory(path) |
| 107 | } else { | 103 | } else { |
| 108 | isDirectory(appContext, path) | 104 | FileUtil.isDirectory(path) |
| 109 | } | 105 | } |
| 110 | } | 106 | } |
| 111 | 107 | ||
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/YuzuApplication.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/YuzuApplication.kt index 9561748cb..8c053670c 100644 --- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/YuzuApplication.kt +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/YuzuApplication.kt | |||
| @@ -47,7 +47,7 @@ class YuzuApplication : Application() { | |||
| 47 | application = this | 47 | application = this |
| 48 | documentsTree = DocumentsTree() | 48 | documentsTree = DocumentsTree() |
| 49 | DirectoryInitialization.start() | 49 | DirectoryInitialization.start() |
| 50 | GpuDriverHelper.initializeDriverParameters(applicationContext) | 50 | GpuDriverHelper.initializeDriverParameters() |
| 51 | NativeLibrary.logDeviceInfo() | 51 | NativeLibrary.logDeviceInfo() |
| 52 | 52 | ||
| 53 | createNotificationChannels() | 53 | createNotificationChannels() |
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/adapters/DriverAdapter.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/adapters/DriverAdapter.kt new file mode 100644 index 000000000..0e818cab9 --- /dev/null +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/adapters/DriverAdapter.kt | |||
| @@ -0,0 +1,117 @@ | |||
| 1 | // SPDX-FileCopyrightText: 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | package org.yuzu.yuzu_emu.adapters | ||
| 5 | |||
| 6 | import android.text.TextUtils | ||
| 7 | import android.view.LayoutInflater | ||
| 8 | import android.view.View | ||
| 9 | import android.view.ViewGroup | ||
| 10 | import androidx.recyclerview.widget.AsyncDifferConfig | ||
| 11 | import androidx.recyclerview.widget.DiffUtil | ||
| 12 | import androidx.recyclerview.widget.ListAdapter | ||
| 13 | import androidx.recyclerview.widget.RecyclerView | ||
| 14 | import org.yuzu.yuzu_emu.R | ||
| 15 | import org.yuzu.yuzu_emu.databinding.CardDriverOptionBinding | ||
| 16 | import org.yuzu.yuzu_emu.model.DriverViewModel | ||
| 17 | import org.yuzu.yuzu_emu.utils.GpuDriverHelper | ||
| 18 | import org.yuzu.yuzu_emu.utils.GpuDriverMetadata | ||
| 19 | |||
| 20 | class DriverAdapter(private val driverViewModel: DriverViewModel) : | ||
| 21 | ListAdapter<Pair<String, GpuDriverMetadata>, DriverAdapter.DriverViewHolder>( | ||
| 22 | AsyncDifferConfig.Builder(DiffCallback()).build() | ||
| 23 | ) { | ||
| 24 | override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): DriverViewHolder { | ||
| 25 | val binding = | ||
| 26 | CardDriverOptionBinding.inflate(LayoutInflater.from(parent.context), parent, false) | ||
| 27 | return DriverViewHolder(binding) | ||
| 28 | } | ||
| 29 | |||
| 30 | override fun getItemCount(): Int = currentList.size | ||
| 31 | |||
| 32 | override fun onBindViewHolder(holder: DriverViewHolder, position: Int) = | ||
| 33 | holder.bind(currentList[position]) | ||
| 34 | |||
| 35 | private fun onSelectDriver(position: Int) { | ||
| 36 | driverViewModel.setSelectedDriverIndex(position) | ||
| 37 | notifyItemChanged(driverViewModel.previouslySelectedDriver) | ||
| 38 | notifyItemChanged(driverViewModel.selectedDriver) | ||
| 39 | } | ||
| 40 | |||
| 41 | private fun onDeleteDriver(driverData: Pair<String, GpuDriverMetadata>, position: Int) { | ||
| 42 | if (driverViewModel.selectedDriver > position) { | ||
| 43 | driverViewModel.setSelectedDriverIndex(driverViewModel.selectedDriver - 1) | ||
| 44 | } | ||
| 45 | if (GpuDriverHelper.customDriverData == driverData.second) { | ||
| 46 | driverViewModel.setSelectedDriverIndex(0) | ||
| 47 | } | ||
| 48 | driverViewModel.driversToDelete.add(driverData.first) | ||
| 49 | driverViewModel.removeDriver(driverData) | ||
| 50 | notifyItemRemoved(position) | ||
| 51 | notifyItemChanged(driverViewModel.selectedDriver) | ||
| 52 | } | ||
| 53 | |||
| 54 | inner class DriverViewHolder(val binding: CardDriverOptionBinding) : | ||
| 55 | RecyclerView.ViewHolder(binding.root) { | ||
| 56 | private lateinit var driverData: Pair<String, GpuDriverMetadata> | ||
| 57 | |||
| 58 | fun bind(driverData: Pair<String, GpuDriverMetadata>) { | ||
| 59 | this.driverData = driverData | ||
| 60 | val driver = driverData.second | ||
| 61 | |||
| 62 | binding.apply { | ||
| 63 | radioButton.isChecked = driverViewModel.selectedDriver == bindingAdapterPosition | ||
| 64 | root.setOnClickListener { | ||
| 65 | onSelectDriver(bindingAdapterPosition) | ||
| 66 | } | ||
| 67 | buttonDelete.setOnClickListener { | ||
| 68 | onDeleteDriver(driverData, bindingAdapterPosition) | ||
| 69 | } | ||
| 70 | |||
| 71 | // Delay marquee by 3s | ||
| 72 | title.postDelayed( | ||
| 73 | { | ||
| 74 | title.isSelected = true | ||
| 75 | title.ellipsize = TextUtils.TruncateAt.MARQUEE | ||
| 76 | version.isSelected = true | ||
| 77 | version.ellipsize = TextUtils.TruncateAt.MARQUEE | ||
| 78 | description.isSelected = true | ||
| 79 | description.ellipsize = TextUtils.TruncateAt.MARQUEE | ||
| 80 | }, | ||
| 81 | 3000 | ||
| 82 | ) | ||
| 83 | if (driver.name == null) { | ||
| 84 | title.setText(R.string.system_gpu_driver) | ||
| 85 | description.text = "" | ||
| 86 | version.text = "" | ||
| 87 | version.visibility = View.GONE | ||
| 88 | description.visibility = View.GONE | ||
| 89 | buttonDelete.visibility = View.GONE | ||
| 90 | } else { | ||
| 91 | title.text = driver.name | ||
| 92 | version.text = driver.version | ||
| 93 | description.text = driver.description | ||
| 94 | version.visibility = View.VISIBLE | ||
| 95 | description.visibility = View.VISIBLE | ||
| 96 | buttonDelete.visibility = View.VISIBLE | ||
| 97 | } | ||
| 98 | } | ||
| 99 | } | ||
| 100 | } | ||
| 101 | |||
| 102 | private class DiffCallback : DiffUtil.ItemCallback<Pair<String, GpuDriverMetadata>>() { | ||
| 103 | override fun areItemsTheSame( | ||
| 104 | oldItem: Pair<String, GpuDriverMetadata>, | ||
| 105 | newItem: Pair<String, GpuDriverMetadata> | ||
| 106 | ): Boolean { | ||
| 107 | return oldItem.first == newItem.first | ||
| 108 | } | ||
| 109 | |||
| 110 | override fun areContentsTheSame( | ||
| 111 | oldItem: Pair<String, GpuDriverMetadata>, | ||
| 112 | newItem: Pair<String, GpuDriverMetadata> | ||
| 113 | ): Boolean { | ||
| 114 | return oldItem.second == newItem.second | ||
| 115 | } | ||
| 116 | } | ||
| 117 | } | ||
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/DriverManagerFragment.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/DriverManagerFragment.kt new file mode 100644 index 000000000..df21d74b2 --- /dev/null +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/DriverManagerFragment.kt | |||
| @@ -0,0 +1,186 @@ | |||
| 1 | // SPDX-FileCopyrightText: 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | package org.yuzu.yuzu_emu.fragments | ||
| 5 | |||
| 6 | import android.os.Bundle | ||
| 7 | import android.view.LayoutInflater | ||
| 8 | import android.view.View | ||
| 9 | import android.view.ViewGroup | ||
| 10 | import androidx.activity.result.contract.ActivityResultContracts | ||
| 11 | import androidx.core.view.ViewCompat | ||
| 12 | import androidx.core.view.WindowInsetsCompat | ||
| 13 | import androidx.core.view.updatePadding | ||
| 14 | import androidx.fragment.app.Fragment | ||
| 15 | import androidx.fragment.app.activityViewModels | ||
| 16 | import androidx.lifecycle.lifecycleScope | ||
| 17 | import androidx.navigation.findNavController | ||
| 18 | import androidx.recyclerview.widget.GridLayoutManager | ||
| 19 | import com.google.android.material.transition.MaterialSharedAxis | ||
| 20 | import kotlinx.coroutines.flow.collectLatest | ||
| 21 | import kotlinx.coroutines.launch | ||
| 22 | import org.yuzu.yuzu_emu.R | ||
| 23 | import org.yuzu.yuzu_emu.adapters.DriverAdapter | ||
| 24 | import org.yuzu.yuzu_emu.databinding.FragmentDriverManagerBinding | ||
| 25 | import org.yuzu.yuzu_emu.model.DriverViewModel | ||
| 26 | import org.yuzu.yuzu_emu.model.HomeViewModel | ||
| 27 | import org.yuzu.yuzu_emu.utils.FileUtil | ||
| 28 | import org.yuzu.yuzu_emu.utils.GpuDriverHelper | ||
| 29 | import java.io.File | ||
| 30 | import java.io.IOException | ||
| 31 | |||
| 32 | class DriverManagerFragment : Fragment() { | ||
| 33 | private var _binding: FragmentDriverManagerBinding? = null | ||
| 34 | private val binding get() = _binding!! | ||
| 35 | |||
| 36 | private val homeViewModel: HomeViewModel by activityViewModels() | ||
| 37 | private val driverViewModel: DriverViewModel by activityViewModels() | ||
| 38 | |||
| 39 | override fun onCreate(savedInstanceState: Bundle?) { | ||
| 40 | super.onCreate(savedInstanceState) | ||
| 41 | enterTransition = MaterialSharedAxis(MaterialSharedAxis.X, true) | ||
| 42 | returnTransition = MaterialSharedAxis(MaterialSharedAxis.X, false) | ||
| 43 | reenterTransition = MaterialSharedAxis(MaterialSharedAxis.X, false) | ||
| 44 | } | ||
| 45 | |||
| 46 | override fun onCreateView( | ||
| 47 | inflater: LayoutInflater, | ||
| 48 | container: ViewGroup?, | ||
| 49 | savedInstanceState: Bundle? | ||
| 50 | ): View { | ||
| 51 | _binding = FragmentDriverManagerBinding.inflate(inflater) | ||
| 52 | return binding.root | ||
| 53 | } | ||
| 54 | |||
| 55 | override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | ||
| 56 | super.onViewCreated(view, savedInstanceState) | ||
| 57 | homeViewModel.setNavigationVisibility(visible = false, animated = true) | ||
| 58 | homeViewModel.setStatusBarShadeVisibility(visible = false) | ||
| 59 | |||
| 60 | if (!driverViewModel.isInteractionAllowed) { | ||
| 61 | DriversLoadingDialogFragment().show( | ||
| 62 | childFragmentManager, | ||
| 63 | DriversLoadingDialogFragment.TAG | ||
| 64 | ) | ||
| 65 | } | ||
| 66 | |||
| 67 | binding.toolbarDrivers.setNavigationOnClickListener { | ||
| 68 | binding.root.findNavController().popBackStack() | ||
| 69 | } | ||
| 70 | |||
| 71 | binding.buttonInstall.setOnClickListener { | ||
| 72 | getDriver.launch(arrayOf("application/zip")) | ||
| 73 | } | ||
| 74 | |||
| 75 | binding.listDrivers.apply { | ||
| 76 | layoutManager = GridLayoutManager( | ||
| 77 | requireContext(), | ||
| 78 | resources.getInteger(R.integer.grid_columns) | ||
| 79 | ) | ||
| 80 | adapter = DriverAdapter(driverViewModel) | ||
| 81 | } | ||
| 82 | |||
| 83 | viewLifecycleOwner.lifecycleScope.apply { | ||
| 84 | launch { | ||
| 85 | driverViewModel.driverList.collectLatest { | ||
| 86 | (binding.listDrivers.adapter as DriverAdapter).submitList(it) | ||
| 87 | } | ||
| 88 | } | ||
| 89 | launch { | ||
| 90 | driverViewModel.newDriverInstalled.collect { | ||
| 91 | if (_binding != null && it) { | ||
| 92 | (binding.listDrivers.adapter as DriverAdapter).apply { | ||
| 93 | notifyItemChanged(driverViewModel.previouslySelectedDriver) | ||
| 94 | notifyItemChanged(driverViewModel.selectedDriver) | ||
| 95 | driverViewModel.setNewDriverInstalled(false) | ||
| 96 | } | ||
| 97 | } | ||
| 98 | } | ||
| 99 | } | ||
| 100 | } | ||
| 101 | |||
| 102 | setInsets() | ||
| 103 | } | ||
| 104 | |||
| 105 | // Start installing requested driver | ||
| 106 | override fun onStop() { | ||
| 107 | super.onStop() | ||
| 108 | driverViewModel.onCloseDriverManager() | ||
| 109 | } | ||
| 110 | |||
| 111 | private fun setInsets() = | ||
| 112 | ViewCompat.setOnApplyWindowInsetsListener( | ||
| 113 | binding.root | ||
| 114 | ) { _: View, windowInsets: WindowInsetsCompat -> | ||
| 115 | val barInsets = windowInsets.getInsets(WindowInsetsCompat.Type.systemBars()) | ||
| 116 | val cutoutInsets = windowInsets.getInsets(WindowInsetsCompat.Type.displayCutout()) | ||
| 117 | |||
| 118 | val leftInsets = barInsets.left + cutoutInsets.left | ||
| 119 | val rightInsets = barInsets.right + cutoutInsets.right | ||
| 120 | |||
| 121 | val mlpAppBar = binding.toolbarDrivers.layoutParams as ViewGroup.MarginLayoutParams | ||
| 122 | mlpAppBar.leftMargin = leftInsets | ||
| 123 | mlpAppBar.rightMargin = rightInsets | ||
| 124 | binding.toolbarDrivers.layoutParams = mlpAppBar | ||
| 125 | |||
| 126 | val mlplistDrivers = binding.listDrivers.layoutParams as ViewGroup.MarginLayoutParams | ||
| 127 | mlplistDrivers.leftMargin = leftInsets | ||
| 128 | mlplistDrivers.rightMargin = rightInsets | ||
| 129 | binding.listDrivers.layoutParams = mlplistDrivers | ||
| 130 | |||
| 131 | val fabSpacing = resources.getDimensionPixelSize(R.dimen.spacing_fab) | ||
| 132 | val mlpFab = | ||
| 133 | binding.buttonInstall.layoutParams as ViewGroup.MarginLayoutParams | ||
| 134 | mlpFab.leftMargin = leftInsets + fabSpacing | ||
| 135 | mlpFab.rightMargin = rightInsets + fabSpacing | ||
| 136 | mlpFab.bottomMargin = barInsets.bottom + fabSpacing | ||
| 137 | binding.buttonInstall.layoutParams = mlpFab | ||
| 138 | |||
| 139 | binding.listDrivers.updatePadding( | ||
| 140 | bottom = barInsets.bottom + | ||
| 141 | resources.getDimensionPixelSize(R.dimen.spacing_bottom_list_fab) | ||
| 142 | ) | ||
| 143 | |||
| 144 | windowInsets | ||
| 145 | } | ||
| 146 | |||
| 147 | private val getDriver = | ||
| 148 | registerForActivityResult(ActivityResultContracts.OpenDocument()) { result -> | ||
| 149 | if (result == null) { | ||
| 150 | return@registerForActivityResult | ||
| 151 | } | ||
| 152 | |||
| 153 | IndeterminateProgressDialogFragment.newInstance( | ||
| 154 | requireActivity(), | ||
| 155 | R.string.installing_driver, | ||
| 156 | false | ||
| 157 | ) { | ||
| 158 | val driverPath = | ||
| 159 | "${GpuDriverHelper.driverStoragePath}/${FileUtil.getFilename(result)}" | ||
| 160 | val driverFile = File(driverPath) | ||
| 161 | |||
| 162 | // Ignore file exceptions when a user selects an invalid zip | ||
| 163 | try { | ||
| 164 | if (!GpuDriverHelper.copyDriverToInternalStorage(result)) { | ||
| 165 | throw IOException("Driver failed validation!") | ||
| 166 | } | ||
| 167 | } catch (_: IOException) { | ||
| 168 | if (driverFile.exists()) { | ||
| 169 | driverFile.delete() | ||
| 170 | } | ||
| 171 | return@newInstance getString(R.string.select_gpu_driver_error) | ||
| 172 | } | ||
| 173 | |||
| 174 | val driverData = GpuDriverHelper.getMetadataFromZip(driverFile) | ||
| 175 | val driverInList = | ||
| 176 | driverViewModel.driverList.value.firstOrNull { it.second == driverData } | ||
| 177 | if (driverInList != null) { | ||
| 178 | return@newInstance getString(R.string.driver_already_installed) | ||
| 179 | } else { | ||
| 180 | driverViewModel.addDriver(Pair(driverPath, driverData)) | ||
| 181 | driverViewModel.setNewDriverInstalled(true) | ||
| 182 | } | ||
| 183 | return@newInstance Any() | ||
| 184 | }.show(childFragmentManager, IndeterminateProgressDialogFragment.TAG) | ||
| 185 | } | ||
| 186 | } | ||
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/DriversLoadingDialogFragment.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/DriversLoadingDialogFragment.kt new file mode 100644 index 000000000..f8c34346a --- /dev/null +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/DriversLoadingDialogFragment.kt | |||
| @@ -0,0 +1,75 @@ | |||
| 1 | // SPDX-FileCopyrightText: 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | package org.yuzu.yuzu_emu.fragments | ||
| 5 | |||
| 6 | import android.app.Dialog | ||
| 7 | import android.os.Bundle | ||
| 8 | import android.view.LayoutInflater | ||
| 9 | import android.view.View | ||
| 10 | import android.view.ViewGroup | ||
| 11 | import androidx.fragment.app.DialogFragment | ||
| 12 | import androidx.fragment.app.activityViewModels | ||
| 13 | import androidx.lifecycle.Lifecycle | ||
| 14 | import androidx.lifecycle.lifecycleScope | ||
| 15 | import androidx.lifecycle.repeatOnLifecycle | ||
| 16 | import com.google.android.material.dialog.MaterialAlertDialogBuilder | ||
| 17 | import kotlinx.coroutines.launch | ||
| 18 | import org.yuzu.yuzu_emu.R | ||
| 19 | import org.yuzu.yuzu_emu.databinding.DialogProgressBarBinding | ||
| 20 | import org.yuzu.yuzu_emu.model.DriverViewModel | ||
| 21 | |||
| 22 | class DriversLoadingDialogFragment : DialogFragment() { | ||
| 23 | private val driverViewModel: DriverViewModel by activityViewModels() | ||
| 24 | |||
| 25 | private lateinit var binding: DialogProgressBarBinding | ||
| 26 | |||
| 27 | override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { | ||
| 28 | binding = DialogProgressBarBinding.inflate(layoutInflater) | ||
| 29 | binding.progressBar.isIndeterminate = true | ||
| 30 | |||
| 31 | isCancelable = false | ||
| 32 | |||
| 33 | return MaterialAlertDialogBuilder(requireContext()) | ||
| 34 | .setTitle(R.string.loading) | ||
| 35 | .setView(binding.root) | ||
| 36 | .create() | ||
| 37 | } | ||
| 38 | |||
| 39 | override fun onCreateView( | ||
| 40 | inflater: LayoutInflater, | ||
| 41 | container: ViewGroup?, | ||
| 42 | savedInstanceState: Bundle? | ||
| 43 | ): View = binding.root | ||
| 44 | |||
| 45 | override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | ||
| 46 | super.onViewCreated(view, savedInstanceState) | ||
| 47 | viewLifecycleOwner.lifecycleScope.apply { | ||
| 48 | launch { | ||
| 49 | repeatOnLifecycle(Lifecycle.State.RESUMED) { | ||
| 50 | driverViewModel.areDriversLoading.collect { checkForDismiss() } | ||
| 51 | } | ||
| 52 | } | ||
| 53 | launch { | ||
| 54 | repeatOnLifecycle(Lifecycle.State.RESUMED) { | ||
| 55 | driverViewModel.isDriverReady.collect { checkForDismiss() } | ||
| 56 | } | ||
| 57 | } | ||
| 58 | launch { | ||
| 59 | repeatOnLifecycle(Lifecycle.State.RESUMED) { | ||
| 60 | driverViewModel.isDeletingDrivers.collect { checkForDismiss() } | ||
| 61 | } | ||
| 62 | } | ||
| 63 | } | ||
| 64 | } | ||
| 65 | |||
| 66 | private fun checkForDismiss() { | ||
| 67 | if (driverViewModel.isInteractionAllowed) { | ||
| 68 | dismiss() | ||
| 69 | } | ||
| 70 | } | ||
| 71 | |||
| 72 | companion object { | ||
| 73 | const val TAG = "DriversLoadingDialogFragment" | ||
| 74 | } | ||
| 75 | } | ||
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/EmulationFragment.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/EmulationFragment.kt index e6ad2aa77..598a9d42b 100644 --- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/EmulationFragment.kt +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/EmulationFragment.kt | |||
| @@ -39,6 +39,7 @@ import androidx.window.layout.WindowLayoutInfo | |||
| 39 | import com.google.android.material.dialog.MaterialAlertDialogBuilder | 39 | import com.google.android.material.dialog.MaterialAlertDialogBuilder |
| 40 | import com.google.android.material.slider.Slider | 40 | import com.google.android.material.slider.Slider |
| 41 | import kotlinx.coroutines.Dispatchers | 41 | import kotlinx.coroutines.Dispatchers |
| 42 | import kotlinx.coroutines.flow.collect | ||
| 42 | import kotlinx.coroutines.flow.collectLatest | 43 | import kotlinx.coroutines.flow.collectLatest |
| 43 | import kotlinx.coroutines.launch | 44 | import kotlinx.coroutines.launch |
| 44 | import org.yuzu.yuzu_emu.HomeNavigationDirections | 45 | import org.yuzu.yuzu_emu.HomeNavigationDirections |
| @@ -50,6 +51,7 @@ import org.yuzu.yuzu_emu.databinding.DialogOverlayAdjustBinding | |||
| 50 | import org.yuzu.yuzu_emu.databinding.FragmentEmulationBinding | 51 | import org.yuzu.yuzu_emu.databinding.FragmentEmulationBinding |
| 51 | import org.yuzu.yuzu_emu.features.settings.model.IntSetting | 52 | import org.yuzu.yuzu_emu.features.settings.model.IntSetting |
| 52 | import org.yuzu.yuzu_emu.features.settings.model.Settings | 53 | import org.yuzu.yuzu_emu.features.settings.model.Settings |
| 54 | import org.yuzu.yuzu_emu.model.DriverViewModel | ||
| 53 | import org.yuzu.yuzu_emu.model.Game | 55 | import org.yuzu.yuzu_emu.model.Game |
| 54 | import org.yuzu.yuzu_emu.model.EmulationViewModel | 56 | import org.yuzu.yuzu_emu.model.EmulationViewModel |
| 55 | import org.yuzu.yuzu_emu.overlay.InputOverlay | 57 | import org.yuzu.yuzu_emu.overlay.InputOverlay |
| @@ -70,6 +72,7 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback { | |||
| 70 | private lateinit var game: Game | 72 | private lateinit var game: Game |
| 71 | 73 | ||
| 72 | private val emulationViewModel: EmulationViewModel by activityViewModels() | 74 | private val emulationViewModel: EmulationViewModel by activityViewModels() |
| 75 | private val driverViewModel: DriverViewModel by activityViewModels() | ||
| 73 | 76 | ||
| 74 | private var isInFoldableLayout = false | 77 | private var isInFoldableLayout = false |
| 75 | 78 | ||
| @@ -299,6 +302,21 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback { | |||
| 299 | } | 302 | } |
| 300 | } | 303 | } |
| 301 | } | 304 | } |
| 305 | launch { | ||
| 306 | repeatOnLifecycle(Lifecycle.State.RESUMED) { | ||
| 307 | driverViewModel.isDriverReady.collect { | ||
| 308 | if (it && !emulationState.isRunning) { | ||
| 309 | if (!DirectoryInitialization.areDirectoriesReady) { | ||
| 310 | DirectoryInitialization.start() | ||
| 311 | } | ||
| 312 | |||
| 313 | updateScreenLayout() | ||
| 314 | |||
| 315 | emulationState.run(emulationActivity!!.isActivityRecreated) | ||
| 316 | } | ||
| 317 | } | ||
| 318 | } | ||
| 319 | } | ||
| 302 | } | 320 | } |
| 303 | } | 321 | } |
| 304 | 322 | ||
| @@ -332,17 +350,6 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback { | |||
| 332 | } | 350 | } |
| 333 | } | 351 | } |
| 334 | 352 | ||
| 335 | override fun onResume() { | ||
| 336 | super.onResume() | ||
| 337 | if (!DirectoryInitialization.areDirectoriesReady) { | ||
| 338 | DirectoryInitialization.start() | ||
| 339 | } | ||
| 340 | |||
| 341 | updateScreenLayout() | ||
| 342 | |||
| 343 | emulationState.run(emulationActivity!!.isActivityRecreated) | ||
| 344 | } | ||
| 345 | |||
| 346 | override fun onPause() { | 353 | override fun onPause() { |
| 347 | if (emulationState.isRunning && emulationActivity?.isInPictureInPictureMode != true) { | 354 | if (emulationState.isRunning && emulationActivity?.isInPictureInPictureMode != true) { |
| 348 | emulationState.pause() | 355 | emulationState.pause() |
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/HomeSettingsFragment.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/HomeSettingsFragment.kt index 8923c0ea2..f273c880a 100644 --- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/HomeSettingsFragment.kt +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/HomeSettingsFragment.kt | |||
| @@ -5,7 +5,6 @@ package org.yuzu.yuzu_emu.fragments | |||
| 5 | 5 | ||
| 6 | import android.Manifest | 6 | import android.Manifest |
| 7 | import android.content.ActivityNotFoundException | 7 | import android.content.ActivityNotFoundException |
| 8 | import android.content.DialogInterface | ||
| 9 | import android.content.Intent | 8 | import android.content.Intent |
| 10 | import android.content.pm.PackageManager | 9 | import android.content.pm.PackageManager |
| 11 | import android.os.Bundle | 10 | import android.os.Bundle |
| @@ -27,8 +26,7 @@ import androidx.fragment.app.Fragment | |||
| 27 | import androidx.fragment.app.activityViewModels | 26 | import androidx.fragment.app.activityViewModels |
| 28 | import androidx.navigation.findNavController | 27 | import androidx.navigation.findNavController |
| 29 | import androidx.navigation.fragment.findNavController | 28 | import androidx.navigation.fragment.findNavController |
| 30 | import androidx.recyclerview.widget.LinearLayoutManager | 29 | import androidx.recyclerview.widget.GridLayoutManager |
| 31 | import com.google.android.material.dialog.MaterialAlertDialogBuilder | ||
| 32 | import com.google.android.material.transition.MaterialSharedAxis | 30 | import com.google.android.material.transition.MaterialSharedAxis |
| 33 | import org.yuzu.yuzu_emu.BuildConfig | 31 | import org.yuzu.yuzu_emu.BuildConfig |
| 34 | import org.yuzu.yuzu_emu.HomeNavigationDirections | 32 | import org.yuzu.yuzu_emu.HomeNavigationDirections |
| @@ -37,6 +35,7 @@ import org.yuzu.yuzu_emu.adapters.HomeSettingAdapter | |||
| 37 | import org.yuzu.yuzu_emu.databinding.FragmentHomeSettingsBinding | 35 | import org.yuzu.yuzu_emu.databinding.FragmentHomeSettingsBinding |
| 38 | import org.yuzu.yuzu_emu.features.DocumentProvider | 36 | import org.yuzu.yuzu_emu.features.DocumentProvider |
| 39 | import org.yuzu.yuzu_emu.features.settings.model.Settings | 37 | import org.yuzu.yuzu_emu.features.settings.model.Settings |
| 38 | import org.yuzu.yuzu_emu.model.DriverViewModel | ||
| 40 | import org.yuzu.yuzu_emu.model.HomeSetting | 39 | import org.yuzu.yuzu_emu.model.HomeSetting |
| 41 | import org.yuzu.yuzu_emu.model.HomeViewModel | 40 | import org.yuzu.yuzu_emu.model.HomeViewModel |
| 42 | import org.yuzu.yuzu_emu.ui.main.MainActivity | 41 | import org.yuzu.yuzu_emu.ui.main.MainActivity |
| @@ -50,6 +49,7 @@ class HomeSettingsFragment : Fragment() { | |||
| 50 | private lateinit var mainActivity: MainActivity | 49 | private lateinit var mainActivity: MainActivity |
| 51 | 50 | ||
| 52 | private val homeViewModel: HomeViewModel by activityViewModels() | 51 | private val homeViewModel: HomeViewModel by activityViewModels() |
| 52 | private val driverViewModel: DriverViewModel by activityViewModels() | ||
| 53 | 53 | ||
| 54 | override fun onCreate(savedInstanceState: Bundle?) { | 54 | override fun onCreate(savedInstanceState: Bundle?) { |
| 55 | super.onCreate(savedInstanceState) | 55 | super.onCreate(savedInstanceState) |
| @@ -107,13 +107,17 @@ class HomeSettingsFragment : Fragment() { | |||
| 107 | ) | 107 | ) |
| 108 | add( | 108 | add( |
| 109 | HomeSetting( | 109 | HomeSetting( |
| 110 | R.string.install_gpu_driver, | 110 | R.string.gpu_driver_manager, |
| 111 | R.string.install_gpu_driver_description, | 111 | R.string.install_gpu_driver_description, |
| 112 | R.drawable.ic_exit, | 112 | R.drawable.ic_build, |
| 113 | { driverInstaller() }, | 113 | { |
| 114 | binding.root.findNavController() | ||
| 115 | .navigate(R.id.action_homeSettingsFragment_to_driverManagerFragment) | ||
| 116 | }, | ||
| 114 | { GpuDriverHelper.supportsCustomDriverLoading() }, | 117 | { GpuDriverHelper.supportsCustomDriverLoading() }, |
| 115 | R.string.custom_driver_not_supported, | 118 | R.string.custom_driver_not_supported, |
| 116 | R.string.custom_driver_not_supported_description | 119 | R.string.custom_driver_not_supported_description, |
| 120 | driverViewModel.selectedDriverMetadata | ||
| 117 | ) | 121 | ) |
| 118 | ) | 122 | ) |
| 119 | add( | 123 | add( |
| @@ -182,7 +186,8 @@ class HomeSettingsFragment : Fragment() { | |||
| 182 | } | 186 | } |
| 183 | 187 | ||
| 184 | binding.homeSettingsList.apply { | 188 | binding.homeSettingsList.apply { |
| 185 | layoutManager = LinearLayoutManager(requireContext()) | 189 | layoutManager = |
| 190 | GridLayoutManager(requireContext(), resources.getInteger(R.integer.grid_columns)) | ||
| 186 | adapter = HomeSettingAdapter( | 191 | adapter = HomeSettingAdapter( |
| 187 | requireActivity() as AppCompatActivity, | 192 | requireActivity() as AppCompatActivity, |
| 188 | viewLifecycleOwner, | 193 | viewLifecycleOwner, |
| @@ -292,31 +297,6 @@ class HomeSettingsFragment : Fragment() { | |||
| 292 | } | 297 | } |
| 293 | } | 298 | } |
| 294 | 299 | ||
| 295 | private fun driverInstaller() { | ||
| 296 | // Get the driver name for the dialog message. | ||
| 297 | var driverName = GpuDriverHelper.customDriverName | ||
| 298 | if (driverName == null) { | ||
| 299 | driverName = getString(R.string.system_gpu_driver) | ||
| 300 | } | ||
| 301 | |||
| 302 | MaterialAlertDialogBuilder(requireContext()) | ||
| 303 | .setTitle(getString(R.string.select_gpu_driver_title)) | ||
| 304 | .setMessage(driverName) | ||
| 305 | .setNegativeButton(android.R.string.cancel, null) | ||
| 306 | .setNeutralButton(R.string.select_gpu_driver_default) { _: DialogInterface?, _: Int -> | ||
| 307 | GpuDriverHelper.installDefaultDriver(requireContext()) | ||
| 308 | Toast.makeText( | ||
| 309 | requireContext(), | ||
| 310 | R.string.select_gpu_driver_use_default, | ||
| 311 | Toast.LENGTH_SHORT | ||
| 312 | ).show() | ||
| 313 | } | ||
| 314 | .setPositiveButton(R.string.select_gpu_driver_install) { _: DialogInterface?, _: Int -> | ||
| 315 | mainActivity.getDriver.launch(arrayOf("application/zip")) | ||
| 316 | } | ||
| 317 | .show() | ||
| 318 | } | ||
| 319 | |||
| 320 | private fun shareLog() { | 300 | private fun shareLog() { |
| 321 | val file = DocumentFile.fromSingleUri( | 301 | val file = DocumentFile.fromSingleUri( |
| 322 | mainActivity, | 302 | mainActivity, |
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/IndeterminateProgressDialogFragment.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/IndeterminateProgressDialogFragment.kt index f128deda8..7e467814d 100644 --- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/IndeterminateProgressDialogFragment.kt +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/IndeterminateProgressDialogFragment.kt | |||
| @@ -10,8 +10,8 @@ import android.view.View | |||
| 10 | import android.view.ViewGroup | 10 | import android.view.ViewGroup |
| 11 | import android.widget.Toast | 11 | import android.widget.Toast |
| 12 | import androidx.appcompat.app.AlertDialog | 12 | import androidx.appcompat.app.AlertDialog |
| 13 | import androidx.appcompat.app.AppCompatActivity | ||
| 14 | import androidx.fragment.app.DialogFragment | 13 | import androidx.fragment.app.DialogFragment |
| 14 | import androidx.fragment.app.FragmentActivity | ||
| 15 | import androidx.fragment.app.activityViewModels | 15 | import androidx.fragment.app.activityViewModels |
| 16 | import androidx.lifecycle.Lifecycle | 16 | import androidx.lifecycle.Lifecycle |
| 17 | import androidx.lifecycle.ViewModelProvider | 17 | import androidx.lifecycle.ViewModelProvider |
| @@ -78,6 +78,10 @@ class IndeterminateProgressDialogFragment : DialogFragment() { | |||
| 78 | requireActivity().supportFragmentManager, | 78 | requireActivity().supportFragmentManager, |
| 79 | MessageDialogFragment.TAG | 79 | MessageDialogFragment.TAG |
| 80 | ) | 80 | ) |
| 81 | |||
| 82 | else -> { | ||
| 83 | // Do nothing | ||
| 84 | } | ||
| 81 | } | 85 | } |
| 82 | taskViewModel.clear() | 86 | taskViewModel.clear() |
| 83 | } | 87 | } |
| @@ -115,7 +119,7 @@ class IndeterminateProgressDialogFragment : DialogFragment() { | |||
| 115 | private const val CANCELLABLE = "Cancellable" | 119 | private const val CANCELLABLE = "Cancellable" |
| 116 | 120 | ||
| 117 | fun newInstance( | 121 | fun newInstance( |
| 118 | activity: AppCompatActivity, | 122 | activity: FragmentActivity, |
| 119 | titleId: Int, | 123 | titleId: Int, |
| 120 | cancellable: Boolean = false, | 124 | cancellable: Boolean = false, |
| 121 | task: () -> Any | 125 | task: () -> Any |
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/model/DriverViewModel.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/model/DriverViewModel.kt new file mode 100644 index 000000000..62945ad65 --- /dev/null +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/model/DriverViewModel.kt | |||
| @@ -0,0 +1,158 @@ | |||
| 1 | // SPDX-FileCopyrightText: 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | package org.yuzu.yuzu_emu.model | ||
| 5 | |||
| 6 | import androidx.lifecycle.ViewModel | ||
| 7 | import androidx.lifecycle.viewModelScope | ||
| 8 | import kotlinx.coroutines.Dispatchers | ||
| 9 | import kotlinx.coroutines.flow.MutableStateFlow | ||
| 10 | import kotlinx.coroutines.flow.StateFlow | ||
| 11 | import kotlinx.coroutines.launch | ||
| 12 | import kotlinx.coroutines.withContext | ||
| 13 | import org.yuzu.yuzu_emu.R | ||
| 14 | import org.yuzu.yuzu_emu.YuzuApplication | ||
| 15 | import org.yuzu.yuzu_emu.utils.FileUtil | ||
| 16 | import org.yuzu.yuzu_emu.utils.GpuDriverHelper | ||
| 17 | import org.yuzu.yuzu_emu.utils.GpuDriverMetadata | ||
| 18 | import java.io.BufferedOutputStream | ||
| 19 | import java.io.File | ||
| 20 | |||
| 21 | class DriverViewModel : ViewModel() { | ||
| 22 | private val _areDriversLoading = MutableStateFlow(false) | ||
| 23 | val areDriversLoading: StateFlow<Boolean> get() = _areDriversLoading | ||
| 24 | |||
| 25 | private val _isDriverReady = MutableStateFlow(true) | ||
| 26 | val isDriverReady: StateFlow<Boolean> get() = _isDriverReady | ||
| 27 | |||
| 28 | private val _isDeletingDrivers = MutableStateFlow(false) | ||
| 29 | val isDeletingDrivers: StateFlow<Boolean> get() = _isDeletingDrivers | ||
| 30 | |||
| 31 | private val _driverList = MutableStateFlow(mutableListOf<Pair<String, GpuDriverMetadata>>()) | ||
| 32 | val driverList: StateFlow<MutableList<Pair<String, GpuDriverMetadata>>> get() = _driverList | ||
| 33 | |||
| 34 | var previouslySelectedDriver = 0 | ||
| 35 | var selectedDriver = -1 | ||
| 36 | |||
| 37 | private val _selectedDriverMetadata = | ||
| 38 | MutableStateFlow( | ||
| 39 | GpuDriverHelper.customDriverData.name | ||
| 40 | ?: YuzuApplication.appContext.getString(R.string.system_gpu_driver) | ||
| 41 | ) | ||
| 42 | val selectedDriverMetadata: StateFlow<String> get() = _selectedDriverMetadata | ||
| 43 | |||
| 44 | private val _newDriverInstalled = MutableStateFlow(false) | ||
| 45 | val newDriverInstalled: StateFlow<Boolean> get() = _newDriverInstalled | ||
| 46 | |||
| 47 | val driversToDelete = mutableListOf<String>() | ||
| 48 | |||
| 49 | val isInteractionAllowed | ||
| 50 | get() = !areDriversLoading.value && isDriverReady.value && !isDeletingDrivers.value | ||
| 51 | |||
| 52 | init { | ||
| 53 | _areDriversLoading.value = true | ||
| 54 | viewModelScope.launch { | ||
| 55 | withContext(Dispatchers.IO) { | ||
| 56 | val drivers = GpuDriverHelper.getDrivers() | ||
| 57 | val currentDriverMetadata = GpuDriverHelper.customDriverData | ||
| 58 | for (i in drivers.indices) { | ||
| 59 | if (drivers[i].second == currentDriverMetadata) { | ||
| 60 | setSelectedDriverIndex(i) | ||
| 61 | break | ||
| 62 | } | ||
| 63 | } | ||
| 64 | |||
| 65 | // If a user had installed a driver before the manager was implemented, this zips | ||
| 66 | // the installed driver to UserData/gpu_drivers/CustomDriver.zip so that it can | ||
| 67 | // be indexed and exported as expected. | ||
| 68 | if (selectedDriver == -1) { | ||
| 69 | val driverToSave = | ||
| 70 | File(GpuDriverHelper.driverStoragePath, "CustomDriver.zip") | ||
| 71 | driverToSave.createNewFile() | ||
| 72 | FileUtil.zipFromInternalStorage( | ||
| 73 | File(GpuDriverHelper.driverInstallationPath!!), | ||
| 74 | GpuDriverHelper.driverInstallationPath!!, | ||
| 75 | BufferedOutputStream(driverToSave.outputStream()) | ||
| 76 | ) | ||
| 77 | drivers.add(Pair(driverToSave.path, currentDriverMetadata)) | ||
| 78 | setSelectedDriverIndex(drivers.size - 1) | ||
| 79 | } | ||
| 80 | |||
| 81 | _driverList.value = drivers | ||
| 82 | _areDriversLoading.value = false | ||
| 83 | } | ||
| 84 | } | ||
| 85 | } | ||
| 86 | |||
| 87 | fun setSelectedDriverIndex(value: Int) { | ||
| 88 | if (selectedDriver != -1) { | ||
| 89 | previouslySelectedDriver = selectedDriver | ||
| 90 | } | ||
| 91 | selectedDriver = value | ||
| 92 | } | ||
| 93 | |||
| 94 | fun setNewDriverInstalled(value: Boolean) { | ||
| 95 | _newDriverInstalled.value = value | ||
| 96 | } | ||
| 97 | |||
| 98 | fun addDriver(driverData: Pair<String, GpuDriverMetadata>) { | ||
| 99 | val driverIndex = _driverList.value.indexOfFirst { it == driverData } | ||
| 100 | if (driverIndex == -1) { | ||
| 101 | setSelectedDriverIndex(_driverList.value.size) | ||
| 102 | _driverList.value.add(driverData) | ||
| 103 | _selectedDriverMetadata.value = driverData.second.name | ||
| 104 | ?: YuzuApplication.appContext.getString(R.string.system_gpu_driver) | ||
| 105 | } else { | ||
| 106 | setSelectedDriverIndex(driverIndex) | ||
| 107 | } | ||
| 108 | } | ||
| 109 | |||
| 110 | fun removeDriver(driverData: Pair<String, GpuDriverMetadata>) { | ||
| 111 | _driverList.value.remove(driverData) | ||
| 112 | } | ||
| 113 | |||
| 114 | fun onCloseDriverManager() { | ||
| 115 | _isDeletingDrivers.value = true | ||
| 116 | viewModelScope.launch { | ||
| 117 | withContext(Dispatchers.IO) { | ||
| 118 | driversToDelete.forEach { | ||
| 119 | val driver = File(it) | ||
| 120 | if (driver.exists()) { | ||
| 121 | driver.delete() | ||
| 122 | } | ||
| 123 | } | ||
| 124 | driversToDelete.clear() | ||
| 125 | _isDeletingDrivers.value = false | ||
| 126 | } | ||
| 127 | } | ||
| 128 | |||
| 129 | if (GpuDriverHelper.customDriverData == driverList.value[selectedDriver].second) { | ||
| 130 | return | ||
| 131 | } | ||
| 132 | |||
| 133 | _isDriverReady.value = false | ||
| 134 | viewModelScope.launch { | ||
| 135 | withContext(Dispatchers.IO) { | ||
| 136 | if (selectedDriver == 0) { | ||
| 137 | GpuDriverHelper.installDefaultDriver() | ||
| 138 | setDriverReady() | ||
| 139 | return@withContext | ||
| 140 | } | ||
| 141 | |||
| 142 | val driverToInstall = File(driverList.value[selectedDriver].first) | ||
| 143 | if (driverToInstall.exists()) { | ||
| 144 | GpuDriverHelper.installCustomDriver(driverToInstall) | ||
| 145 | } else { | ||
| 146 | GpuDriverHelper.installDefaultDriver() | ||
| 147 | } | ||
| 148 | setDriverReady() | ||
| 149 | } | ||
| 150 | } | ||
| 151 | } | ||
| 152 | |||
| 153 | private fun setDriverReady() { | ||
| 154 | _isDriverReady.value = true | ||
| 155 | _selectedDriverMetadata.value = GpuDriverHelper.customDriverData.name | ||
| 156 | ?: YuzuApplication.appContext.getString(R.string.system_gpu_driver) | ||
| 157 | } | ||
| 158 | } | ||
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/ui/main/MainActivity.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/ui/main/MainActivity.kt index 0fa5df5e5..233aa4101 100644 --- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/ui/main/MainActivity.kt +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/ui/main/MainActivity.kt | |||
| @@ -29,12 +29,10 @@ import androidx.navigation.fragment.NavHostFragment | |||
| 29 | import androidx.navigation.ui.setupWithNavController | 29 | import androidx.navigation.ui.setupWithNavController |
| 30 | import androidx.preference.PreferenceManager | 30 | import androidx.preference.PreferenceManager |
| 31 | import com.google.android.material.color.MaterialColors | 31 | import com.google.android.material.color.MaterialColors |
| 32 | import com.google.android.material.dialog.MaterialAlertDialogBuilder | ||
| 33 | import com.google.android.material.navigation.NavigationBarView | 32 | import com.google.android.material.navigation.NavigationBarView |
| 34 | import kotlinx.coroutines.CoroutineScope | 33 | import kotlinx.coroutines.CoroutineScope |
| 35 | import java.io.File | 34 | import java.io.File |
| 36 | import java.io.FilenameFilter | 35 | import java.io.FilenameFilter |
| 37 | import java.io.IOException | ||
| 38 | import kotlinx.coroutines.Dispatchers | 36 | import kotlinx.coroutines.Dispatchers |
| 39 | import kotlinx.coroutines.launch | 37 | import kotlinx.coroutines.launch |
| 40 | import kotlinx.coroutines.withContext | 38 | import kotlinx.coroutines.withContext |
| @@ -43,7 +41,6 @@ import org.yuzu.yuzu_emu.NativeLibrary | |||
| 43 | import org.yuzu.yuzu_emu.R | 41 | import org.yuzu.yuzu_emu.R |
| 44 | import org.yuzu.yuzu_emu.activities.EmulationActivity | 42 | import org.yuzu.yuzu_emu.activities.EmulationActivity |
| 45 | import org.yuzu.yuzu_emu.databinding.ActivityMainBinding | 43 | import org.yuzu.yuzu_emu.databinding.ActivityMainBinding |
| 46 | import org.yuzu.yuzu_emu.databinding.DialogProgressBarBinding | ||
| 47 | import org.yuzu.yuzu_emu.features.DocumentProvider | 44 | import org.yuzu.yuzu_emu.features.DocumentProvider |
| 48 | import org.yuzu.yuzu_emu.features.settings.model.Settings | 45 | import org.yuzu.yuzu_emu.features.settings.model.Settings |
| 49 | import org.yuzu.yuzu_emu.fragments.IndeterminateProgressDialogFragment | 46 | import org.yuzu.yuzu_emu.fragments.IndeterminateProgressDialogFragment |
| @@ -343,11 +340,10 @@ class MainActivity : AppCompatActivity(), ThemeProvider { | |||
| 343 | 340 | ||
| 344 | val dstPath = DirectoryInitialization.userDirectory + "/keys/" | 341 | val dstPath = DirectoryInitialization.userDirectory + "/keys/" |
| 345 | if (FileUtil.copyUriToInternalStorage( | 342 | if (FileUtil.copyUriToInternalStorage( |
| 346 | applicationContext, | ||
| 347 | result, | 343 | result, |
| 348 | dstPath, | 344 | dstPath, |
| 349 | "prod.keys" | 345 | "prod.keys" |
| 350 | ) | 346 | ) != null |
| 351 | ) { | 347 | ) { |
| 352 | if (NativeLibrary.reloadKeys()) { | 348 | if (NativeLibrary.reloadKeys()) { |
| 353 | Toast.makeText( | 349 | Toast.makeText( |
| @@ -446,11 +442,10 @@ class MainActivity : AppCompatActivity(), ThemeProvider { | |||
| 446 | 442 | ||
| 447 | val dstPath = DirectoryInitialization.userDirectory + "/keys/" | 443 | val dstPath = DirectoryInitialization.userDirectory + "/keys/" |
| 448 | if (FileUtil.copyUriToInternalStorage( | 444 | if (FileUtil.copyUriToInternalStorage( |
| 449 | applicationContext, | ||
| 450 | result, | 445 | result, |
| 451 | dstPath, | 446 | dstPath, |
| 452 | "key_retail.bin" | 447 | "key_retail.bin" |
| 453 | ) | 448 | ) != null |
| 454 | ) { | 449 | ) { |
| 455 | if (NativeLibrary.reloadKeys()) { | 450 | if (NativeLibrary.reloadKeys()) { |
| 456 | Toast.makeText( | 451 | Toast.makeText( |
| @@ -469,59 +464,6 @@ class MainActivity : AppCompatActivity(), ThemeProvider { | |||
| 469 | } | 464 | } |
| 470 | } | 465 | } |
| 471 | 466 | ||
| 472 | val getDriver = | ||
| 473 | registerForActivityResult(ActivityResultContracts.OpenDocument()) { result -> | ||
| 474 | if (result == null) { | ||
| 475 | return@registerForActivityResult | ||
| 476 | } | ||
| 477 | |||
| 478 | val takeFlags = | ||
| 479 | Intent.FLAG_GRANT_WRITE_URI_PERMISSION or Intent.FLAG_GRANT_READ_URI_PERMISSION | ||
| 480 | contentResolver.takePersistableUriPermission( | ||
| 481 | result, | ||
| 482 | takeFlags | ||
| 483 | ) | ||
| 484 | |||
| 485 | val progressBinding = DialogProgressBarBinding.inflate(layoutInflater) | ||
| 486 | progressBinding.progressBar.isIndeterminate = true | ||
| 487 | val installationDialog = MaterialAlertDialogBuilder(this) | ||
| 488 | .setTitle(R.string.installing_driver) | ||
| 489 | .setView(progressBinding.root) | ||
| 490 | .show() | ||
| 491 | |||
| 492 | lifecycleScope.launch { | ||
| 493 | withContext(Dispatchers.IO) { | ||
| 494 | // Ignore file exceptions when a user selects an invalid zip | ||
| 495 | try { | ||
| 496 | GpuDriverHelper.installCustomDriver(applicationContext, result) | ||
| 497 | } catch (_: IOException) { | ||
| 498 | } | ||
| 499 | |||
| 500 | withContext(Dispatchers.Main) { | ||
| 501 | installationDialog.dismiss() | ||
| 502 | |||
| 503 | val driverName = GpuDriverHelper.customDriverName | ||
| 504 | if (driverName != null) { | ||
| 505 | Toast.makeText( | ||
| 506 | applicationContext, | ||
| 507 | getString( | ||
| 508 | R.string.select_gpu_driver_install_success, | ||
| 509 | driverName | ||
| 510 | ), | ||
| 511 | Toast.LENGTH_SHORT | ||
| 512 | ).show() | ||
| 513 | } else { | ||
| 514 | Toast.makeText( | ||
| 515 | applicationContext, | ||
| 516 | R.string.select_gpu_driver_error, | ||
| 517 | Toast.LENGTH_LONG | ||
| 518 | ).show() | ||
| 519 | } | ||
| 520 | } | ||
| 521 | } | ||
| 522 | } | ||
| 523 | } | ||
| 524 | |||
| 525 | val installGameUpdate = registerForActivityResult( | 467 | val installGameUpdate = registerForActivityResult( |
| 526 | ActivityResultContracts.OpenMultipleDocuments() | 468 | ActivityResultContracts.OpenMultipleDocuments() |
| 527 | ) { documents: List<Uri> -> | 469 | ) { documents: List<Uri> -> |
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/DocumentsTree.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/DocumentsTree.kt index cf226ad94..eafcf9e42 100644 --- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/DocumentsTree.kt +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/DocumentsTree.kt | |||
| @@ -7,7 +7,6 @@ import android.net.Uri | |||
| 7 | import androidx.documentfile.provider.DocumentFile | 7 | import androidx.documentfile.provider.DocumentFile |
| 8 | import java.io.File | 8 | import java.io.File |
| 9 | import java.util.* | 9 | import java.util.* |
| 10 | import org.yuzu.yuzu_emu.YuzuApplication | ||
| 11 | import org.yuzu.yuzu_emu.model.MinimalDocumentFile | 10 | import org.yuzu.yuzu_emu.model.MinimalDocumentFile |
| 12 | 11 | ||
| 13 | class DocumentsTree { | 12 | class DocumentsTree { |
| @@ -22,7 +21,7 @@ class DocumentsTree { | |||
| 22 | 21 | ||
| 23 | fun openContentUri(filepath: String, openMode: String?): Int { | 22 | fun openContentUri(filepath: String, openMode: String?): Int { |
| 24 | val node = resolvePath(filepath) ?: return -1 | 23 | val node = resolvePath(filepath) ?: return -1 |
| 25 | return FileUtil.openContentUri(YuzuApplication.appContext, node.uri.toString(), openMode) | 24 | return FileUtil.openContentUri(node.uri.toString(), openMode) |
| 26 | } | 25 | } |
| 27 | 26 | ||
| 28 | fun getFileSize(filepath: String): Long { | 27 | fun getFileSize(filepath: String): Long { |
| @@ -30,7 +29,7 @@ class DocumentsTree { | |||
| 30 | return if (node == null || node.isDirectory) { | 29 | return if (node == null || node.isDirectory) { |
| 31 | 0 | 30 | 0 |
| 32 | } else { | 31 | } else { |
| 33 | FileUtil.getFileSize(YuzuApplication.appContext, node.uri.toString()) | 32 | FileUtil.getFileSize(node.uri.toString()) |
| 34 | } | 33 | } |
| 35 | } | 34 | } |
| 36 | 35 | ||
| @@ -67,7 +66,7 @@ class DocumentsTree { | |||
| 67 | * @param parent parent node of this level | 66 | * @param parent parent node of this level |
| 68 | */ | 67 | */ |
| 69 | private fun structTree(parent: DocumentsNode) { | 68 | private fun structTree(parent: DocumentsNode) { |
| 70 | val documents = FileUtil.listFiles(YuzuApplication.appContext, parent.uri!!) | 69 | val documents = FileUtil.listFiles(parent.uri!!) |
| 71 | for (document in documents) { | 70 | for (document in documents) { |
| 72 | val node = DocumentsNode(document) | 71 | val node = DocumentsNode(document) |
| 73 | node.parent = parent | 72 | node.parent = parent |
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/FileUtil.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/FileUtil.kt index c3f53f1c5..5ee74a52c 100644 --- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/FileUtil.kt +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/FileUtil.kt | |||
| @@ -3,7 +3,6 @@ | |||
| 3 | 3 | ||
| 4 | package org.yuzu.yuzu_emu.utils | 4 | package org.yuzu.yuzu_emu.utils |
| 5 | 5 | ||
| 6 | import android.content.Context | ||
| 7 | import android.database.Cursor | 6 | import android.database.Cursor |
| 8 | import android.net.Uri | 7 | import android.net.Uri |
| 9 | import android.provider.DocumentsContract | 8 | import android.provider.DocumentsContract |
| @@ -11,7 +10,6 @@ import androidx.documentfile.provider.DocumentFile | |||
| 11 | import kotlinx.coroutines.flow.StateFlow | 10 | import kotlinx.coroutines.flow.StateFlow |
| 12 | import java.io.BufferedInputStream | 11 | import java.io.BufferedInputStream |
| 13 | import java.io.File | 12 | import java.io.File |
| 14 | import java.io.FileOutputStream | ||
| 15 | import java.io.IOException | 13 | import java.io.IOException |
| 16 | import java.io.InputStream | 14 | import java.io.InputStream |
| 17 | import java.net.URLDecoder | 15 | import java.net.URLDecoder |
| @@ -21,6 +19,8 @@ import org.yuzu.yuzu_emu.YuzuApplication | |||
| 21 | import org.yuzu.yuzu_emu.model.MinimalDocumentFile | 19 | import org.yuzu.yuzu_emu.model.MinimalDocumentFile |
| 22 | import org.yuzu.yuzu_emu.model.TaskState | 20 | import org.yuzu.yuzu_emu.model.TaskState |
| 23 | import java.io.BufferedOutputStream | 21 | import java.io.BufferedOutputStream |
| 22 | import java.lang.NullPointerException | ||
| 23 | import java.nio.charset.StandardCharsets | ||
| 24 | import java.util.zip.ZipOutputStream | 24 | import java.util.zip.ZipOutputStream |
| 25 | 25 | ||
| 26 | object FileUtil { | 26 | object FileUtil { |
| @@ -29,6 +29,8 @@ object FileUtil { | |||
| 29 | const val APPLICATION_OCTET_STREAM = "application/octet-stream" | 29 | const val APPLICATION_OCTET_STREAM = "application/octet-stream" |
| 30 | const val TEXT_PLAIN = "text/plain" | 30 | const val TEXT_PLAIN = "text/plain" |
| 31 | 31 | ||
| 32 | private val context get() = YuzuApplication.appContext | ||
| 33 | |||
| 32 | /** | 34 | /** |
| 33 | * Create a file from directory with filename. | 35 | * Create a file from directory with filename. |
| 34 | * @param context Application context | 36 | * @param context Application context |
| @@ -36,11 +38,11 @@ object FileUtil { | |||
| 36 | * @param filename file display name. | 38 | * @param filename file display name. |
| 37 | * @return boolean | 39 | * @return boolean |
| 38 | */ | 40 | */ |
| 39 | fun createFile(context: Context?, directory: String?, filename: String): DocumentFile? { | 41 | fun createFile(directory: String?, filename: String): DocumentFile? { |
| 40 | var decodedFilename = filename | 42 | var decodedFilename = filename |
| 41 | try { | 43 | try { |
| 42 | val directoryUri = Uri.parse(directory) | 44 | val directoryUri = Uri.parse(directory) |
| 43 | val parent = DocumentFile.fromTreeUri(context!!, directoryUri) ?: return null | 45 | val parent = DocumentFile.fromTreeUri(context, directoryUri) ?: return null |
| 44 | decodedFilename = URLDecoder.decode(decodedFilename, DECODE_METHOD) | 46 | decodedFilename = URLDecoder.decode(decodedFilename, DECODE_METHOD) |
| 45 | var mimeType = APPLICATION_OCTET_STREAM | 47 | var mimeType = APPLICATION_OCTET_STREAM |
| 46 | if (decodedFilename.endsWith(".txt")) { | 48 | if (decodedFilename.endsWith(".txt")) { |
| @@ -56,16 +58,15 @@ object FileUtil { | |||
| 56 | 58 | ||
| 57 | /** | 59 | /** |
| 58 | * Create a directory from directory with filename. | 60 | * Create a directory from directory with filename. |
| 59 | * @param context Application context | ||
| 60 | * @param directory parent path for directory. | 61 | * @param directory parent path for directory. |
| 61 | * @param directoryName directory display name. | 62 | * @param directoryName directory display name. |
| 62 | * @return boolean | 63 | * @return boolean |
| 63 | */ | 64 | */ |
| 64 | fun createDir(context: Context?, directory: String?, directoryName: String?): DocumentFile? { | 65 | fun createDir(directory: String?, directoryName: String?): DocumentFile? { |
| 65 | var decodedDirectoryName = directoryName | 66 | var decodedDirectoryName = directoryName |
| 66 | try { | 67 | try { |
| 67 | val directoryUri = Uri.parse(directory) | 68 | val directoryUri = Uri.parse(directory) |
| 68 | val parent = DocumentFile.fromTreeUri(context!!, directoryUri) ?: return null | 69 | val parent = DocumentFile.fromTreeUri(context, directoryUri) ?: return null |
| 69 | decodedDirectoryName = URLDecoder.decode(decodedDirectoryName, DECODE_METHOD) | 70 | decodedDirectoryName = URLDecoder.decode(decodedDirectoryName, DECODE_METHOD) |
| 70 | val isExist = parent.findFile(decodedDirectoryName) | 71 | val isExist = parent.findFile(decodedDirectoryName) |
| 71 | return isExist ?: parent.createDirectory(decodedDirectoryName) | 72 | return isExist ?: parent.createDirectory(decodedDirectoryName) |
| @@ -77,13 +78,12 @@ object FileUtil { | |||
| 77 | 78 | ||
| 78 | /** | 79 | /** |
| 79 | * Open content uri and return file descriptor to JNI. | 80 | * Open content uri and return file descriptor to JNI. |
| 80 | * @param context Application context | ||
| 81 | * @param path Native content uri path | 81 | * @param path Native content uri path |
| 82 | * @param openMode will be one of "r", "r", "rw", "wa", "rwa" | 82 | * @param openMode will be one of "r", "r", "rw", "wa", "rwa" |
| 83 | * @return file descriptor | 83 | * @return file descriptor |
| 84 | */ | 84 | */ |
| 85 | @JvmStatic | 85 | @JvmStatic |
| 86 | fun openContentUri(context: Context, path: String, openMode: String?): Int { | 86 | fun openContentUri(path: String, openMode: String?): Int { |
| 87 | try { | 87 | try { |
| 88 | val uri = Uri.parse(path) | 88 | val uri = Uri.parse(path) |
| 89 | val parcelFileDescriptor = context.contentResolver.openFileDescriptor(uri, openMode!!) | 89 | val parcelFileDescriptor = context.contentResolver.openFileDescriptor(uri, openMode!!) |
| @@ -103,11 +103,10 @@ object FileUtil { | |||
| 103 | /** | 103 | /** |
| 104 | * Reference: https://stackoverflow.com/questions/42186820/documentfile-is-very-slow | 104 | * Reference: https://stackoverflow.com/questions/42186820/documentfile-is-very-slow |
| 105 | * This function will be faster than DoucmentFile.listFiles | 105 | * This function will be faster than DoucmentFile.listFiles |
| 106 | * @param context Application context | ||
| 107 | * @param uri Directory uri. | 106 | * @param uri Directory uri. |
| 108 | * @return CheapDocument lists. | 107 | * @return CheapDocument lists. |
| 109 | */ | 108 | */ |
| 110 | fun listFiles(context: Context, uri: Uri): Array<MinimalDocumentFile> { | 109 | fun listFiles(uri: Uri): Array<MinimalDocumentFile> { |
| 111 | val resolver = context.contentResolver | 110 | val resolver = context.contentResolver |
| 112 | val columns = arrayOf( | 111 | val columns = arrayOf( |
| 113 | DocumentsContract.Document.COLUMN_DOCUMENT_ID, | 112 | DocumentsContract.Document.COLUMN_DOCUMENT_ID, |
| @@ -145,7 +144,7 @@ object FileUtil { | |||
| 145 | * @param path Native content uri path | 144 | * @param path Native content uri path |
| 146 | * @return bool | 145 | * @return bool |
| 147 | */ | 146 | */ |
| 148 | fun exists(context: Context, path: String?): Boolean { | 147 | fun exists(path: String?): Boolean { |
| 149 | var c: Cursor? = null | 148 | var c: Cursor? = null |
| 150 | try { | 149 | try { |
| 151 | val mUri = Uri.parse(path) | 150 | val mUri = Uri.parse(path) |
| @@ -165,7 +164,7 @@ object FileUtil { | |||
| 165 | * @param path content uri path | 164 | * @param path content uri path |
| 166 | * @return bool | 165 | * @return bool |
| 167 | */ | 166 | */ |
| 168 | fun isDirectory(context: Context, path: String): Boolean { | 167 | fun isDirectory(path: String): Boolean { |
| 169 | val resolver = context.contentResolver | 168 | val resolver = context.contentResolver |
| 170 | val columns = arrayOf( | 169 | val columns = arrayOf( |
| 171 | DocumentsContract.Document.COLUMN_MIME_TYPE | 170 | DocumentsContract.Document.COLUMN_MIME_TYPE |
| @@ -210,10 +209,10 @@ object FileUtil { | |||
| 210 | return filename | 209 | return filename |
| 211 | } | 210 | } |
| 212 | 211 | ||
| 213 | fun getFilesName(context: Context, path: String): Array<String> { | 212 | fun getFilesName(path: String): Array<String> { |
| 214 | val uri = Uri.parse(path) | 213 | val uri = Uri.parse(path) |
| 215 | val files: MutableList<String> = ArrayList() | 214 | val files: MutableList<String> = ArrayList() |
| 216 | for (file in listFiles(context, uri)) { | 215 | for (file in listFiles(uri)) { |
| 217 | files.add(file.filename) | 216 | files.add(file.filename) |
| 218 | } | 217 | } |
| 219 | return files.toTypedArray() | 218 | return files.toTypedArray() |
| @@ -225,7 +224,7 @@ object FileUtil { | |||
| 225 | * @return long file size | 224 | * @return long file size |
| 226 | */ | 225 | */ |
| 227 | @JvmStatic | 226 | @JvmStatic |
| 228 | fun getFileSize(context: Context, path: String): Long { | 227 | fun getFileSize(path: String): Long { |
| 229 | val resolver = context.contentResolver | 228 | val resolver = context.contentResolver |
| 230 | val columns = arrayOf( | 229 | val columns = arrayOf( |
| 231 | DocumentsContract.Document.COLUMN_SIZE | 230 | DocumentsContract.Document.COLUMN_SIZE |
| @@ -245,44 +244,38 @@ object FileUtil { | |||
| 245 | return size | 244 | return size |
| 246 | } | 245 | } |
| 247 | 246 | ||
| 247 | /** | ||
| 248 | * Creates an input stream with a given [Uri] and copies its data to the given path. This will | ||
| 249 | * overwrite any pre-existing files. | ||
| 250 | * | ||
| 251 | * @param sourceUri The [Uri] to copy data from | ||
| 252 | * @param destinationParentPath Destination directory | ||
| 253 | * @param destinationFilename Optionally renames the file once copied | ||
| 254 | */ | ||
| 248 | fun copyUriToInternalStorage( | 255 | fun copyUriToInternalStorage( |
| 249 | context: Context, | 256 | sourceUri: Uri, |
| 250 | sourceUri: Uri?, | ||
| 251 | destinationParentPath: String, | 257 | destinationParentPath: String, |
| 252 | destinationFilename: String | 258 | destinationFilename: String = "" |
| 253 | ): Boolean { | 259 | ): File? = |
| 254 | var input: InputStream? = null | ||
| 255 | var output: FileOutputStream? = null | ||
| 256 | try { | 260 | try { |
| 257 | input = context.contentResolver.openInputStream(sourceUri!!) | 261 | val fileName = |
| 258 | output = FileOutputStream("$destinationParentPath/$destinationFilename") | 262 | if (destinationFilename == "") getFilename(sourceUri) else "/$destinationFilename" |
| 259 | val buffer = ByteArray(1024) | 263 | val inputStream = context.contentResolver.openInputStream(sourceUri)!! |
| 260 | var len: Int | 264 | |
| 261 | while (input!!.read(buffer).also { len = it } != -1) { | 265 | val destinationFile = File("$destinationParentPath$fileName") |
| 262 | output.write(buffer, 0, len) | 266 | if (destinationFile.exists()) { |
| 263 | } | 267 | destinationFile.delete() |
| 264 | output.flush() | ||
| 265 | return true | ||
| 266 | } catch (e: Exception) { | ||
| 267 | Log.error("[FileUtil]: Cannot copy file, error: " + e.message) | ||
| 268 | } finally { | ||
| 269 | if (input != null) { | ||
| 270 | try { | ||
| 271 | input.close() | ||
| 272 | } catch (e: IOException) { | ||
| 273 | Log.error("[FileUtil]: Cannot close input file, error: " + e.message) | ||
| 274 | } | ||
| 275 | } | 268 | } |
| 276 | if (output != null) { | 269 | |
| 277 | try { | 270 | destinationFile.outputStream().use { fos -> |
| 278 | output.close() | 271 | inputStream.use { it.copyTo(fos) } |
| 279 | } catch (e: IOException) { | ||
| 280 | Log.error("[FileUtil]: Cannot close output file, error: " + e.message) | ||
| 281 | } | ||
| 282 | } | 272 | } |
| 273 | destinationFile | ||
| 274 | } catch (e: IOException) { | ||
| 275 | null | ||
| 276 | } catch (e: NullPointerException) { | ||
| 277 | null | ||
| 283 | } | 278 | } |
| 284 | return false | ||
| 285 | } | ||
| 286 | 279 | ||
| 287 | /** | 280 | /** |
| 288 | * Extracts the given zip file into the given directory. | 281 | * Extracts the given zip file into the given directory. |
| @@ -368,4 +361,12 @@ object FileUtil { | |||
| 368 | return fileName.substring(fileName.lastIndexOf(".") + 1) | 361 | return fileName.substring(fileName.lastIndexOf(".") + 1) |
| 369 | .lowercase() | 362 | .lowercase() |
| 370 | } | 363 | } |
| 364 | |||
| 365 | @Throws(IOException::class) | ||
| 366 | fun getStringFromFile(file: File): String = | ||
| 367 | String(file.readBytes(), StandardCharsets.UTF_8) | ||
| 368 | |||
| 369 | @Throws(IOException::class) | ||
| 370 | fun getStringFromInputStream(stream: InputStream): String = | ||
| 371 | String(stream.readBytes(), StandardCharsets.UTF_8) | ||
| 371 | } | 372 | } |
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GameHelper.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GameHelper.kt index e0ee29c9b..9001ca9ab 100644 --- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GameHelper.kt +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GameHelper.kt | |||
| @@ -30,7 +30,7 @@ object GameHelper { | |||
| 30 | // Ensure keys are loaded so that ROM metadata can be decrypted. | 30 | // Ensure keys are loaded so that ROM metadata can be decrypted. |
| 31 | NativeLibrary.reloadKeys() | 31 | NativeLibrary.reloadKeys() |
| 32 | 32 | ||
| 33 | addGamesRecursive(games, FileUtil.listFiles(context, gamesUri), 3) | 33 | addGamesRecursive(games, FileUtil.listFiles(gamesUri), 3) |
| 34 | 34 | ||
| 35 | // Cache list of games found on disk | 35 | // Cache list of games found on disk |
| 36 | val serializedGames = mutableSetOf<String>() | 36 | val serializedGames = mutableSetOf<String>() |
| @@ -58,7 +58,7 @@ object GameHelper { | |||
| 58 | if (it.isDirectory) { | 58 | if (it.isDirectory) { |
| 59 | addGamesRecursive( | 59 | addGamesRecursive( |
| 60 | games, | 60 | games, |
| 61 | FileUtil.listFiles(YuzuApplication.appContext, it.uri), | 61 | FileUtil.listFiles(it.uri), |
| 62 | depth - 1 | 62 | depth - 1 |
| 63 | ) | 63 | ) |
| 64 | } else { | 64 | } else { |
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GpuDriverHelper.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GpuDriverHelper.kt index 1d4695a2a..f6882ce6c 100644 --- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GpuDriverHelper.kt +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GpuDriverHelper.kt | |||
| @@ -3,64 +3,33 @@ | |||
| 3 | 3 | ||
| 4 | package org.yuzu.yuzu_emu.utils | 4 | package org.yuzu.yuzu_emu.utils |
| 5 | 5 | ||
| 6 | import android.content.Context | ||
| 7 | import android.net.Uri | 6 | import android.net.Uri |
| 7 | import android.os.Build | ||
| 8 | import java.io.BufferedInputStream | 8 | import java.io.BufferedInputStream |
| 9 | import java.io.File | 9 | import java.io.File |
| 10 | import java.io.FileInputStream | ||
| 11 | import java.io.FileOutputStream | ||
| 12 | import java.io.IOException | 10 | import java.io.IOException |
| 13 | import java.util.zip.ZipInputStream | ||
| 14 | import org.yuzu.yuzu_emu.NativeLibrary | 11 | import org.yuzu.yuzu_emu.NativeLibrary |
| 15 | import org.yuzu.yuzu_emu.utils.FileUtil.copyUriToInternalStorage | 12 | import org.yuzu.yuzu_emu.YuzuApplication |
| 13 | import java.util.zip.ZipException | ||
| 14 | import java.util.zip.ZipFile | ||
| 16 | 15 | ||
| 17 | object GpuDriverHelper { | 16 | object GpuDriverHelper { |
| 18 | private const val META_JSON_FILENAME = "meta.json" | 17 | private const val META_JSON_FILENAME = "meta.json" |
| 19 | private const val DRIVER_INTERNAL_FILENAME = "gpu_driver.zip" | ||
| 20 | private var fileRedirectionPath: String? = null | 18 | private var fileRedirectionPath: String? = null |
| 21 | private var driverInstallationPath: String? = null | 19 | var driverInstallationPath: String? = null |
| 22 | private var hookLibPath: String? = null | 20 | private var hookLibPath: String? = null |
| 23 | 21 | ||
| 24 | @Throws(IOException::class) | 22 | val driverStoragePath get() = DirectoryInitialization.userDirectory!! + "/gpu_drivers/" |
| 25 | private fun unzip(zipFilePath: String, destDir: String) { | ||
| 26 | val dir = File(destDir) | ||
| 27 | |||
| 28 | // Create output directory if it doesn't exist | ||
| 29 | if (!dir.exists()) dir.mkdirs() | ||
| 30 | |||
| 31 | // Unpack the files. | ||
| 32 | val inputStream = FileInputStream(zipFilePath) | ||
| 33 | val zis = ZipInputStream(BufferedInputStream(inputStream)) | ||
| 34 | val buffer = ByteArray(1024) | ||
| 35 | var ze = zis.nextEntry | ||
| 36 | while (ze != null) { | ||
| 37 | val newFile = File(destDir, ze.name) | ||
| 38 | val canonicalPath = newFile.canonicalPath | ||
| 39 | if (!canonicalPath.startsWith(destDir + ze.name)) { | ||
| 40 | throw SecurityException("Zip file attempted path traversal! " + ze.name) | ||
| 41 | } | ||
| 42 | |||
| 43 | newFile.parentFile!!.mkdirs() | ||
| 44 | val fos = FileOutputStream(newFile) | ||
| 45 | var len: Int | ||
| 46 | while (zis.read(buffer).also { len = it } > 0) { | ||
| 47 | fos.write(buffer, 0, len) | ||
| 48 | } | ||
| 49 | fos.close() | ||
| 50 | zis.closeEntry() | ||
| 51 | ze = zis.nextEntry | ||
| 52 | } | ||
| 53 | zis.closeEntry() | ||
| 54 | } | ||
| 55 | 23 | ||
| 56 | fun initializeDriverParameters(context: Context) { | 24 | fun initializeDriverParameters() { |
| 57 | try { | 25 | try { |
| 58 | // Initialize the file redirection directory. | 26 | // Initialize the file redirection directory. |
| 59 | fileRedirectionPath = | 27 | fileRedirectionPath = YuzuApplication.appContext |
| 60 | context.getExternalFilesDir(null)!!.canonicalPath + "/gpu/vk_file_redirect/" | 28 | .getExternalFilesDir(null)!!.canonicalPath + "/gpu/vk_file_redirect/" |
| 61 | 29 | ||
| 62 | // Initialize the driver installation directory. | 30 | // Initialize the driver installation directory. |
| 63 | driverInstallationPath = context.filesDir.canonicalPath + "/gpu_driver/" | 31 | driverInstallationPath = YuzuApplication.appContext |
| 32 | .filesDir.canonicalPath + "/gpu_driver/" | ||
| 64 | } catch (e: IOException) { | 33 | } catch (e: IOException) { |
| 65 | throw RuntimeException(e) | 34 | throw RuntimeException(e) |
| 66 | } | 35 | } |
| @@ -69,68 +38,169 @@ object GpuDriverHelper { | |||
| 69 | initializeDirectories() | 38 | initializeDirectories() |
| 70 | 39 | ||
| 71 | // Initialize hook libraries directory. | 40 | // Initialize hook libraries directory. |
| 72 | hookLibPath = context.applicationInfo.nativeLibraryDir + "/" | 41 | hookLibPath = YuzuApplication.appContext.applicationInfo.nativeLibraryDir + "/" |
| 73 | 42 | ||
| 74 | // Initialize GPU driver. | 43 | // Initialize GPU driver. |
| 75 | NativeLibrary.initializeGpuDriver( | 44 | NativeLibrary.initializeGpuDriver( |
| 76 | hookLibPath, | 45 | hookLibPath, |
| 77 | driverInstallationPath, | 46 | driverInstallationPath, |
| 78 | customDriverLibraryName, | 47 | customDriverData.libraryName, |
| 79 | fileRedirectionPath | 48 | fileRedirectionPath |
| 80 | ) | 49 | ) |
| 81 | } | 50 | } |
| 82 | 51 | ||
| 83 | fun installDefaultDriver(context: Context) { | 52 | fun getDrivers(): MutableList<Pair<String, GpuDriverMetadata>> { |
| 53 | val driverZips = File(driverStoragePath).listFiles() | ||
| 54 | val drivers: MutableList<Pair<String, GpuDriverMetadata>> = | ||
| 55 | driverZips | ||
| 56 | ?.mapNotNull { | ||
| 57 | val metadata = getMetadataFromZip(it) | ||
| 58 | metadata.name?.let { _ -> Pair(it.path, metadata) } | ||
| 59 | } | ||
| 60 | ?.sortedByDescending { it: Pair<String, GpuDriverMetadata> -> it.second.name } | ||
| 61 | ?.distinct() | ||
| 62 | ?.toMutableList() ?: mutableListOf() | ||
| 63 | |||
| 64 | // TODO: Get system driver information | ||
| 65 | drivers.add(0, Pair("", GpuDriverMetadata())) | ||
| 66 | return drivers | ||
| 67 | } | ||
| 68 | |||
| 69 | fun installDefaultDriver() { | ||
| 84 | // Removing the installed driver will result in the backend using the default system driver. | 70 | // Removing the installed driver will result in the backend using the default system driver. |
| 85 | val driverInstallationDir = File(driverInstallationPath!!) | 71 | File(driverInstallationPath!!).deleteRecursively() |
| 86 | deleteRecursive(driverInstallationDir) | 72 | initializeDriverParameters() |
| 87 | initializeDriverParameters(context) | 73 | } |
| 74 | |||
| 75 | fun copyDriverToInternalStorage(driverUri: Uri): Boolean { | ||
| 76 | // Ensure we have directories. | ||
| 77 | initializeDirectories() | ||
| 78 | |||
| 79 | // Copy the zip file URI to user data | ||
| 80 | val copiedFile = | ||
| 81 | FileUtil.copyUriToInternalStorage(driverUri, driverStoragePath) ?: return false | ||
| 82 | |||
| 83 | // Validate driver | ||
| 84 | val metadata = getMetadataFromZip(copiedFile) | ||
| 85 | if (metadata.name == null) { | ||
| 86 | copiedFile.delete() | ||
| 87 | return false | ||
| 88 | } | ||
| 89 | |||
| 90 | if (metadata.minApi > Build.VERSION.SDK_INT) { | ||
| 91 | copiedFile.delete() | ||
| 92 | return false | ||
| 93 | } | ||
| 94 | return true | ||
| 88 | } | 95 | } |
| 89 | 96 | ||
| 90 | fun installCustomDriver(context: Context, driverPathUri: Uri?) { | 97 | /** |
| 98 | * Copies driver zip into user data directory so that it can be exported along with | ||
| 99 | * other user data and also unzipped into the installation directory | ||
| 100 | */ | ||
| 101 | fun installCustomDriver(driverUri: Uri): Boolean { | ||
| 91 | // Revert to system default in the event the specified driver is bad. | 102 | // Revert to system default in the event the specified driver is bad. |
| 92 | installDefaultDriver(context) | 103 | installDefaultDriver() |
| 93 | 104 | ||
| 94 | // Ensure we have directories. | 105 | // Ensure we have directories. |
| 95 | initializeDirectories() | 106 | initializeDirectories() |
| 96 | 107 | ||
| 97 | // Copy the zip file URI into our private storage. | 108 | // Copy the zip file URI to user data |
| 98 | copyUriToInternalStorage( | 109 | val copiedFile = |
| 99 | context, | 110 | FileUtil.copyUriToInternalStorage(driverUri, driverStoragePath) ?: return false |
| 100 | driverPathUri, | 111 | |
| 101 | driverInstallationPath!!, | 112 | // Validate driver |
| 102 | DRIVER_INTERNAL_FILENAME | 113 | val metadata = getMetadataFromZip(copiedFile) |
| 103 | ) | 114 | if (metadata.name == null) { |
| 115 | copiedFile.delete() | ||
| 116 | return false | ||
| 117 | } | ||
| 118 | |||
| 119 | if (metadata.minApi > Build.VERSION.SDK_INT) { | ||
| 120 | copiedFile.delete() | ||
| 121 | return false | ||
| 122 | } | ||
| 104 | 123 | ||
| 105 | // Unzip the driver. | 124 | // Unzip the driver. |
| 106 | try { | 125 | try { |
| 107 | unzip(driverInstallationPath + DRIVER_INTERNAL_FILENAME, driverInstallationPath!!) | 126 | FileUtil.unzipToInternalStorage( |
| 127 | BufferedInputStream(copiedFile.inputStream()), | ||
| 128 | File(driverInstallationPath!!) | ||
| 129 | ) | ||
| 108 | } catch (e: SecurityException) { | 130 | } catch (e: SecurityException) { |
| 109 | return | 131 | return false |
| 110 | } | 132 | } |
| 111 | 133 | ||
| 112 | // Initialize the driver parameters. | 134 | // Initialize the driver parameters. |
| 113 | initializeDriverParameters(context) | 135 | initializeDriverParameters() |
| 136 | |||
| 137 | return true | ||
| 114 | } | 138 | } |
| 115 | 139 | ||
| 116 | external fun supportsCustomDriverLoading(): Boolean | 140 | /** |
| 141 | * Unzips driver into installation directory | ||
| 142 | */ | ||
| 143 | fun installCustomDriver(driver: File): Boolean { | ||
| 144 | // Revert to system default in the event the specified driver is bad. | ||
| 145 | installDefaultDriver() | ||
| 117 | 146 | ||
| 118 | // Parse the custom driver metadata to retrieve the name. | 147 | // Ensure we have directories. |
| 119 | val customDriverName: String? | 148 | initializeDirectories() |
| 120 | get() { | 149 | |
| 121 | val metadata = GpuDriverMetadata(driverInstallationPath + META_JSON_FILENAME) | 150 | // Validate driver |
| 122 | return metadata.name | 151 | val metadata = getMetadataFromZip(driver) |
| 152 | if (metadata.name == null) { | ||
| 153 | driver.delete() | ||
| 154 | return false | ||
| 123 | } | 155 | } |
| 124 | 156 | ||
| 125 | // Parse the custom driver metadata to retrieve the library name. | 157 | // Unzip the driver to the private installation directory |
| 126 | private val customDriverLibraryName: String? | 158 | try { |
| 127 | get() { | 159 | FileUtil.unzipToInternalStorage( |
| 128 | // Parse the custom driver metadata to retrieve the library name. | 160 | BufferedInputStream(driver.inputStream()), |
| 129 | val metadata = GpuDriverMetadata(driverInstallationPath + META_JSON_FILENAME) | 161 | File(driverInstallationPath!!) |
| 130 | return metadata.libraryName | 162 | ) |
| 163 | } catch (e: SecurityException) { | ||
| 164 | return false | ||
| 131 | } | 165 | } |
| 132 | 166 | ||
| 133 | private fun initializeDirectories() { | 167 | // Initialize the driver parameters. |
| 168 | initializeDriverParameters() | ||
| 169 | |||
| 170 | return true | ||
| 171 | } | ||
| 172 | |||
| 173 | /** | ||
| 174 | * Takes in a zip file and reads the meta.json file for presentation to the UI | ||
| 175 | * | ||
| 176 | * @param driver Zip containing driver and meta.json file | ||
| 177 | * @return A non-null [GpuDriverMetadata] instance that may have null members | ||
| 178 | */ | ||
| 179 | fun getMetadataFromZip(driver: File): GpuDriverMetadata { | ||
| 180 | try { | ||
| 181 | ZipFile(driver).use { zf -> | ||
| 182 | val entries = zf.entries() | ||
| 183 | while (entries.hasMoreElements()) { | ||
| 184 | val entry = entries.nextElement() | ||
| 185 | if (!entry.isDirectory && entry.name.lowercase().contains(".json")) { | ||
| 186 | zf.getInputStream(entry).use { | ||
| 187 | return GpuDriverMetadata(it, entry.size) | ||
| 188 | } | ||
| 189 | } | ||
| 190 | } | ||
| 191 | } | ||
| 192 | } catch (_: ZipException) { | ||
| 193 | } | ||
| 194 | return GpuDriverMetadata() | ||
| 195 | } | ||
| 196 | |||
| 197 | external fun supportsCustomDriverLoading(): Boolean | ||
| 198 | |||
| 199 | // Parse the custom driver metadata to retrieve the name. | ||
| 200 | val customDriverData: GpuDriverMetadata | ||
| 201 | get() = GpuDriverMetadata(File(driverInstallationPath + META_JSON_FILENAME)) | ||
| 202 | |||
| 203 | fun initializeDirectories() { | ||
| 134 | // Ensure the file redirection directory exists. | 204 | // Ensure the file redirection directory exists. |
| 135 | val fileRedirectionDir = File(fileRedirectionPath!!) | 205 | val fileRedirectionDir = File(fileRedirectionPath!!) |
| 136 | if (!fileRedirectionDir.exists()) { | 206 | if (!fileRedirectionDir.exists()) { |
| @@ -141,14 +211,10 @@ object GpuDriverHelper { | |||
| 141 | if (!driverInstallationDir.exists()) { | 211 | if (!driverInstallationDir.exists()) { |
| 142 | driverInstallationDir.mkdirs() | 212 | driverInstallationDir.mkdirs() |
| 143 | } | 213 | } |
| 144 | } | 214 | // Ensure the driver storage directory exists |
| 145 | 215 | val driverStorageDirectory = File(driverStoragePath) | |
| 146 | private fun deleteRecursive(fileOrDirectory: File) { | 216 | if (!driverStorageDirectory.exists()) { |
| 147 | if (fileOrDirectory.isDirectory) { | 217 | driverStorageDirectory.mkdirs() |
| 148 | for (child in fileOrDirectory.listFiles()!!) { | ||
| 149 | deleteRecursive(child) | ||
| 150 | } | ||
| 151 | } | 218 | } |
| 152 | fileOrDirectory.delete() | ||
| 153 | } | 219 | } |
| 154 | } | 220 | } |
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GpuDriverMetadata.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GpuDriverMetadata.kt index a4e64070a..511a4171a 100644 --- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GpuDriverMetadata.kt +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GpuDriverMetadata.kt | |||
| @@ -4,29 +4,29 @@ | |||
| 4 | package org.yuzu.yuzu_emu.utils | 4 | package org.yuzu.yuzu_emu.utils |
| 5 | 5 | ||
| 6 | import java.io.IOException | 6 | import java.io.IOException |
| 7 | import java.nio.charset.StandardCharsets | ||
| 8 | import java.nio.file.Files | ||
| 9 | import java.nio.file.Paths | ||
| 10 | import org.json.JSONException | 7 | import org.json.JSONException |
| 11 | import org.json.JSONObject | 8 | import org.json.JSONObject |
| 9 | import java.io.File | ||
| 10 | import java.io.InputStream | ||
| 12 | 11 | ||
| 13 | class GpuDriverMetadata(metadataFilePath: String) { | 12 | class GpuDriverMetadata { |
| 14 | var name: String? = null | 13 | /** |
| 15 | var description: String? = null | 14 | * Tries to get driver metadata information from a meta.json [File] |
| 16 | var author: String? = null | 15 | * |
| 17 | var vendor: String? = null | 16 | * @param metadataFile meta.json file provided with a GPU driver |
| 18 | var driverVersion: String? = null | 17 | */ |
| 19 | var minApi = 0 | 18 | constructor(metadataFile: File) { |
| 20 | var libraryName: String? = null | 19 | if (metadataFile.length() > MAX_META_SIZE_BYTES) { |
| 20 | return | ||
| 21 | } | ||
| 21 | 22 | ||
| 22 | init { | ||
| 23 | try { | 23 | try { |
| 24 | val json = JSONObject(getStringFromFile(metadataFilePath)) | 24 | val json = JSONObject(FileUtil.getStringFromFile(metadataFile)) |
| 25 | name = json.getString("name") | 25 | name = json.getString("name") |
| 26 | description = json.getString("description") | 26 | description = json.getString("description") |
| 27 | author = json.getString("author") | 27 | author = json.getString("author") |
| 28 | vendor = json.getString("vendor") | 28 | vendor = json.getString("vendor") |
| 29 | driverVersion = json.getString("driverVersion") | 29 | version = json.getString("driverVersion") |
| 30 | minApi = json.getInt("minApi") | 30 | minApi = json.getInt("minApi") |
| 31 | libraryName = json.getString("libraryName") | 31 | libraryName = json.getString("libraryName") |
| 32 | } catch (e: JSONException) { | 32 | } catch (e: JSONException) { |
| @@ -36,12 +36,84 @@ class GpuDriverMetadata(metadataFilePath: String) { | |||
| 36 | } | 36 | } |
| 37 | } | 37 | } |
| 38 | 38 | ||
| 39 | companion object { | 39 | /** |
| 40 | @Throws(IOException::class) | 40 | * Tries to get driver metadata information from an input stream that's intended to be |
| 41 | private fun getStringFromFile(filePath: String): String { | 41 | * from a zip file |
| 42 | val path = Paths.get(filePath) | 42 | * |
| 43 | val bytes = Files.readAllBytes(path) | 43 | * @param metadataStream ZipEntry input stream |
| 44 | return String(bytes, StandardCharsets.UTF_8) | 44 | * @param size Size of the file in bytes |
| 45 | */ | ||
| 46 | constructor(metadataStream: InputStream, size: Long) { | ||
| 47 | if (size > MAX_META_SIZE_BYTES) { | ||
| 48 | return | ||
| 45 | } | 49 | } |
| 50 | |||
| 51 | try { | ||
| 52 | val json = JSONObject(FileUtil.getStringFromInputStream(metadataStream)) | ||
| 53 | name = json.getString("name") | ||
| 54 | description = json.getString("description") | ||
| 55 | author = json.getString("author") | ||
| 56 | vendor = json.getString("vendor") | ||
| 57 | version = json.getString("driverVersion") | ||
| 58 | minApi = json.getInt("minApi") | ||
| 59 | libraryName = json.getString("libraryName") | ||
| 60 | } catch (e: JSONException) { | ||
| 61 | // JSON is malformed, ignore and treat as unsupported metadata. | ||
| 62 | } catch (e: IOException) { | ||
| 63 | // File is inaccessible, ignore and treat as unsupported metadata. | ||
| 64 | } | ||
| 65 | } | ||
| 66 | |||
| 67 | /** | ||
| 68 | * Creates an empty metadata instance | ||
| 69 | */ | ||
| 70 | constructor() | ||
| 71 | |||
| 72 | override fun equals(other: Any?): Boolean { | ||
| 73 | if (other !is GpuDriverMetadata) { | ||
| 74 | return false | ||
| 75 | } | ||
| 76 | |||
| 77 | return other.name == name && | ||
| 78 | other.description == description && | ||
| 79 | other.author == author && | ||
| 80 | other.vendor == vendor && | ||
| 81 | other.version == version && | ||
| 82 | other.minApi == minApi && | ||
| 83 | other.libraryName == libraryName | ||
| 84 | } | ||
| 85 | |||
| 86 | override fun hashCode(): Int { | ||
| 87 | var result = name?.hashCode() ?: 0 | ||
| 88 | result = 31 * result + (description?.hashCode() ?: 0) | ||
| 89 | result = 31 * result + (author?.hashCode() ?: 0) | ||
| 90 | result = 31 * result + (vendor?.hashCode() ?: 0) | ||
| 91 | result = 31 * result + (version?.hashCode() ?: 0) | ||
| 92 | result = 31 * result + minApi | ||
| 93 | result = 31 * result + (libraryName?.hashCode() ?: 0) | ||
| 94 | return result | ||
| 95 | } | ||
| 96 | |||
| 97 | override fun toString(): String = | ||
| 98 | """ | ||
| 99 | Name - $name | ||
| 100 | Description - $description | ||
| 101 | Author - $author | ||
| 102 | Vendor - $vendor | ||
| 103 | Version - $version | ||
| 104 | Min API - $minApi | ||
| 105 | Library Name - $libraryName | ||
| 106 | """.trimMargin().trimIndent() | ||
| 107 | |||
| 108 | var name: String? = null | ||
| 109 | var description: String? = null | ||
| 110 | var author: String? = null | ||
| 111 | var vendor: String? = null | ||
| 112 | var version: String? = null | ||
| 113 | var minApi = 0 | ||
| 114 | var libraryName: String? = null | ||
| 115 | |||
| 116 | companion object { | ||
| 117 | private const val MAX_META_SIZE_BYTES = 500000 | ||
| 46 | } | 118 | } |
| 47 | } | 119 | } |
diff --git a/src/android/app/src/main/jni/native.cpp b/src/android/app/src/main/jni/native.cpp index 9cf71680c..598f4e8bf 100644 --- a/src/android/app/src/main/jni/native.cpp +++ b/src/android/app/src/main/jni/native.cpp | |||
| @@ -218,7 +218,6 @@ public: | |||
| 218 | return; | 218 | return; |
| 219 | } | 219 | } |
| 220 | m_window->OnSurfaceChanged(m_native_window); | 220 | m_window->OnSurfaceChanged(m_native_window); |
| 221 | m_system.Renderer().NotifySurfaceChanged(); | ||
| 222 | } | 221 | } |
| 223 | 222 | ||
| 224 | void ConfigureFilesystemProvider(const std::string& filepath) { | 223 | void ConfigureFilesystemProvider(const std::string& filepath) { |
diff --git a/src/android/app/src/main/res/drawable/ic_build.xml b/src/android/app/src/main/res/drawable/ic_build.xml new file mode 100644 index 000000000..91d52f1b8 --- /dev/null +++ b/src/android/app/src/main/res/drawable/ic_build.xml | |||
| @@ -0,0 +1,9 @@ | |||
| 1 | <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| 2 | android:width="24dp" | ||
| 3 | android:height="24dp" | ||
| 4 | android:viewportWidth="24" | ||
| 5 | android:viewportHeight="24"> | ||
| 6 | <path | ||
| 7 | android:fillColor="?attr/colorControlNormal" | ||
| 8 | android:pathData="M22.7,19l-9.1,-9.1c0.9,-2.3 0.4,-5 -1.5,-6.9 -2,-2 -5,-2.4 -7.4,-1.3L9,6 6,9 1.6,4.7C0.4,7.1 0.9,10.1 2.9,12.1c1.9,1.9 4.6,2.4 6.9,1.5l9.1,9.1c0.4,0.4 1,0.4 1.4,0l2.3,-2.3c0.5,-0.4 0.5,-1.1 0.1,-1.4z" /> | ||
| 9 | </vector> | ||
diff --git a/src/android/app/src/main/res/drawable/ic_delete.xml b/src/android/app/src/main/res/drawable/ic_delete.xml new file mode 100644 index 000000000..d26a79711 --- /dev/null +++ b/src/android/app/src/main/res/drawable/ic_delete.xml | |||
| @@ -0,0 +1,9 @@ | |||
| 1 | <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| 2 | android:width="24dp" | ||
| 3 | android:height="24dp" | ||
| 4 | android:viewportWidth="24" | ||
| 5 | android:viewportHeight="24"> | ||
| 6 | <path | ||
| 7 | android:fillColor="?attr/colorControlNormal" | ||
| 8 | android:pathData="M6,19c0,1.1 0.9,2 2,2h8c1.1,0 2,-0.9 2,-2V7H6v12zM19,4h-3.5l-1,-1h-5l-1,1H5v2h14V4z" /> | ||
| 9 | </vector> | ||
diff --git a/src/android/app/src/main/res/layout/card_driver_option.xml b/src/android/app/src/main/res/layout/card_driver_option.xml new file mode 100644 index 000000000..1dd9a6d7d --- /dev/null +++ b/src/android/app/src/main/res/layout/card_driver_option.xml | |||
| @@ -0,0 +1,89 @@ | |||
| 1 | <?xml version="1.0" encoding="utf-8"?> | ||
| 2 | <com.google.android.material.card.MaterialCardView xmlns:android="http://schemas.android.com/apk/res/android" | ||
| 3 | xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| 4 | xmlns:tools="http://schemas.android.com/tools" | ||
| 5 | style="?attr/materialCardViewOutlinedStyle" | ||
| 6 | android:layout_width="match_parent" | ||
| 7 | android:layout_height="wrap_content" | ||
| 8 | android:layout_marginHorizontal="16dp" | ||
| 9 | android:layout_marginVertical="12dp" | ||
| 10 | android:background="?attr/selectableItemBackground" | ||
| 11 | android:clickable="true" | ||
| 12 | android:focusable="true"> | ||
| 13 | |||
| 14 | <LinearLayout | ||
| 15 | android:layout_width="match_parent" | ||
| 16 | android:layout_height="wrap_content" | ||
| 17 | android:orientation="horizontal" | ||
| 18 | android:layout_gravity="center" | ||
| 19 | android:padding="16dp"> | ||
| 20 | |||
| 21 | <RadioButton | ||
| 22 | android:id="@+id/radio_button" | ||
| 23 | android:layout_width="wrap_content" | ||
| 24 | android:layout_height="wrap_content" | ||
| 25 | android:layout_gravity="center_vertical" | ||
| 26 | android:clickable="false" | ||
| 27 | android:checked="false" /> | ||
| 28 | |||
| 29 | <LinearLayout | ||
| 30 | android:layout_width="0dp" | ||
| 31 | android:layout_height="wrap_content" | ||
| 32 | android:layout_weight="1" | ||
| 33 | android:orientation="vertical" | ||
| 34 | android:layout_gravity="center_vertical"> | ||
| 35 | |||
| 36 | <com.google.android.material.textview.MaterialTextView | ||
| 37 | android:id="@+id/title" | ||
| 38 | style="@style/TextAppearance.Material3.TitleMedium" | ||
| 39 | android:layout_width="match_parent" | ||
| 40 | android:layout_height="wrap_content" | ||
| 41 | android:ellipsize="none" | ||
| 42 | android:marqueeRepeatLimit="marquee_forever" | ||
| 43 | android:requiresFadingEdge="horizontal" | ||
| 44 | android:singleLine="true" | ||
| 45 | android:textAlignment="viewStart" | ||
| 46 | tools:text="@string/select_gpu_driver_default" /> | ||
| 47 | |||
| 48 | <com.google.android.material.textview.MaterialTextView | ||
| 49 | android:id="@+id/version" | ||
| 50 | style="@style/TextAppearance.Material3.BodyMedium" | ||
| 51 | android:layout_width="match_parent" | ||
| 52 | android:layout_height="wrap_content" | ||
| 53 | android:layout_marginTop="6dp" | ||
| 54 | android:ellipsize="none" | ||
| 55 | android:marqueeRepeatLimit="marquee_forever" | ||
| 56 | android:requiresFadingEdge="horizontal" | ||
| 57 | android:singleLine="true" | ||
| 58 | android:textAlignment="viewStart" | ||
| 59 | tools:text="@string/install_gpu_driver_description" /> | ||
| 60 | |||
| 61 | <com.google.android.material.textview.MaterialTextView | ||
| 62 | android:id="@+id/description" | ||
| 63 | style="@style/TextAppearance.Material3.BodyMedium" | ||
| 64 | android:layout_width="match_parent" | ||
| 65 | android:layout_height="wrap_content" | ||
| 66 | android:layout_marginTop="6dp" | ||
| 67 | android:ellipsize="none" | ||
| 68 | android:marqueeRepeatLimit="marquee_forever" | ||
| 69 | android:requiresFadingEdge="horizontal" | ||
| 70 | android:singleLine="true" | ||
| 71 | android:textAlignment="viewStart" | ||
| 72 | tools:text="@string/install_gpu_driver_description" /> | ||
| 73 | |||
| 74 | </LinearLayout> | ||
| 75 | |||
| 76 | <Button | ||
| 77 | android:id="@+id/button_delete" | ||
| 78 | style="@style/Widget.Material3.Button.IconButton" | ||
| 79 | android:layout_width="wrap_content" | ||
| 80 | android:layout_height="wrap_content" | ||
| 81 | android:layout_gravity="center_vertical" | ||
| 82 | android:contentDescription="@string/delete" | ||
| 83 | android:tooltipText="@string/delete" | ||
| 84 | app:icon="@drawable/ic_delete" | ||
| 85 | app:iconTint="?attr/colorControlNormal" /> | ||
| 86 | |||
| 87 | </LinearLayout> | ||
| 88 | |||
| 89 | </com.google.android.material.card.MaterialCardView> | ||
diff --git a/src/android/app/src/main/res/layout/card_home_option.xml b/src/android/app/src/main/res/layout/card_home_option.xml index f9f1d89fb..6e8a232f9 100644 --- a/src/android/app/src/main/res/layout/card_home_option.xml +++ b/src/android/app/src/main/res/layout/card_home_option.xml | |||
| @@ -16,7 +16,8 @@ | |||
| 16 | <LinearLayout | 16 | <LinearLayout |
| 17 | android:id="@+id/option_layout" | 17 | android:id="@+id/option_layout" |
| 18 | android:layout_width="match_parent" | 18 | android:layout_width="match_parent" |
| 19 | android:layout_height="wrap_content"> | 19 | android:layout_height="wrap_content" |
| 20 | android:layout_gravity="center_vertical"> | ||
| 20 | 21 | ||
| 21 | <ImageView | 22 | <ImageView |
| 22 | android:id="@+id/option_icon" | 23 | android:id="@+id/option_icon" |
diff --git a/src/android/app/src/main/res/layout/fragment_driver_manager.xml b/src/android/app/src/main/res/layout/fragment_driver_manager.xml new file mode 100644 index 000000000..6cea2d164 --- /dev/null +++ b/src/android/app/src/main/res/layout/fragment_driver_manager.xml | |||
| @@ -0,0 +1,48 @@ | |||
| 1 | <?xml version="1.0" encoding="utf-8"?> | ||
| 2 | <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| 3 | xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| 4 | android:id="@+id/coordinator_licenses" | ||
| 5 | android:layout_width="match_parent" | ||
| 6 | android:layout_height="match_parent" | ||
| 7 | android:background="?attr/colorSurface"> | ||
| 8 | |||
| 9 | <androidx.coordinatorlayout.widget.CoordinatorLayout | ||
| 10 | android:layout_width="match_parent" | ||
| 11 | android:layout_height="match_parent"> | ||
| 12 | |||
| 13 | <com.google.android.material.appbar.AppBarLayout | ||
| 14 | android:id="@+id/appbar_drivers" | ||
| 15 | android:layout_width="match_parent" | ||
| 16 | android:layout_height="wrap_content" | ||
| 17 | android:fitsSystemWindows="true" | ||
| 18 | app:liftOnScrollTargetViewId="@id/list_drivers"> | ||
| 19 | |||
| 20 | <com.google.android.material.appbar.MaterialToolbar | ||
| 21 | android:id="@+id/toolbar_drivers" | ||
| 22 | android:layout_width="match_parent" | ||
| 23 | android:layout_height="?attr/actionBarSize" | ||
| 24 | app:navigationIcon="@drawable/ic_back" | ||
| 25 | app:title="@string/gpu_driver_manager" /> | ||
| 26 | |||
| 27 | </com.google.android.material.appbar.AppBarLayout> | ||
| 28 | |||
| 29 | <androidx.recyclerview.widget.RecyclerView | ||
| 30 | android:id="@+id/list_drivers" | ||
| 31 | android:layout_width="match_parent" | ||
| 32 | android:layout_height="match_parent" | ||
| 33 | android:clipToPadding="false" | ||
| 34 | app:layout_behavior="@string/appbar_scrolling_view_behavior" /> | ||
| 35 | |||
| 36 | </androidx.coordinatorlayout.widget.CoordinatorLayout> | ||
| 37 | |||
| 38 | <com.google.android.material.floatingactionbutton.ExtendedFloatingActionButton | ||
| 39 | android:id="@+id/button_install" | ||
| 40 | android:layout_width="wrap_content" | ||
| 41 | android:layout_height="wrap_content" | ||
| 42 | android:layout_gravity="bottom|end" | ||
| 43 | android:text="@string/install" | ||
| 44 | app:icon="@drawable/ic_add" | ||
| 45 | app:layout_constraintBottom_toBottomOf="parent" | ||
| 46 | app:layout_constraintEnd_toEndOf="parent" /> | ||
| 47 | |||
| 48 | </androidx.constraintlayout.widget.ConstraintLayout> | ||
diff --git a/src/android/app/src/main/res/navigation/home_navigation.xml b/src/android/app/src/main/res/navigation/home_navigation.xml index 2356b802b..82749359d 100644 --- a/src/android/app/src/main/res/navigation/home_navigation.xml +++ b/src/android/app/src/main/res/navigation/home_navigation.xml | |||
| @@ -22,6 +22,9 @@ | |||
| 22 | <action | 22 | <action |
| 23 | android:id="@+id/action_homeSettingsFragment_to_installableFragment" | 23 | android:id="@+id/action_homeSettingsFragment_to_installableFragment" |
| 24 | app:destination="@id/installableFragment" /> | 24 | app:destination="@id/installableFragment" /> |
| 25 | <action | ||
| 26 | android:id="@+id/action_homeSettingsFragment_to_driverManagerFragment" | ||
| 27 | app:destination="@id/driverManagerFragment" /> | ||
| 25 | </fragment> | 28 | </fragment> |
| 26 | 29 | ||
| 27 | <fragment | 30 | <fragment |
| @@ -95,5 +98,9 @@ | |||
| 95 | android:id="@+id/installableFragment" | 98 | android:id="@+id/installableFragment" |
| 96 | android:name="org.yuzu.yuzu_emu.fragments.InstallableFragment" | 99 | android:name="org.yuzu.yuzu_emu.fragments.InstallableFragment" |
| 97 | android:label="InstallableFragment" /> | 100 | android:label="InstallableFragment" /> |
| 101 | <fragment | ||
| 102 | android:id="@+id/driverManagerFragment" | ||
| 103 | android:name="org.yuzu.yuzu_emu.fragments.DriverManagerFragment" | ||
| 104 | android:label="DriverManagerFragment" /> | ||
| 98 | 105 | ||
| 99 | </navigation> | 106 | </navigation> |
diff --git a/src/android/app/src/main/res/values-de/strings.xml b/src/android/app/src/main/res/values-de/strings.xml index dd0f36392..72a47fbdb 100644 --- a/src/android/app/src/main/res/values-de/strings.xml +++ b/src/android/app/src/main/res/values-de/strings.xml | |||
| @@ -168,9 +168,7 @@ | |||
| 168 | <string name="select_gpu_driver_title">Möchtest du deinen aktuellen GPU-Treiber ersetzen?</string> | 168 | <string name="select_gpu_driver_title">Möchtest du deinen aktuellen GPU-Treiber ersetzen?</string> |
| 169 | <string name="select_gpu_driver_install">Installieren</string> | 169 | <string name="select_gpu_driver_install">Installieren</string> |
| 170 | <string name="select_gpu_driver_default">Standard</string> | 170 | <string name="select_gpu_driver_default">Standard</string> |
| 171 | <string name="select_gpu_driver_install_success">%s wurde installiert</string> | ||
| 172 | <string name="select_gpu_driver_use_default">Standard GPU-Treiber wird verwendet</string> | 171 | <string name="select_gpu_driver_use_default">Standard GPU-Treiber wird verwendet</string> |
| 173 | <string name="select_gpu_driver_error">Ungültiger Treiber ausgewählt, Standard-Treiber wird verwendet!</string> | ||
| 174 | <string name="system_gpu_driver">System GPU-Treiber</string> | 172 | <string name="system_gpu_driver">System GPU-Treiber</string> |
| 175 | <string name="installing_driver">Treiber wird installiert...</string> | 173 | <string name="installing_driver">Treiber wird installiert...</string> |
| 176 | 174 | ||
diff --git a/src/android/app/src/main/res/values-es/strings.xml b/src/android/app/src/main/res/values-es/strings.xml index d398f862f..e5bdd5889 100644 --- a/src/android/app/src/main/res/values-es/strings.xml +++ b/src/android/app/src/main/res/values-es/strings.xml | |||
| @@ -171,9 +171,7 @@ | |||
| 171 | <string name="select_gpu_driver_title">¿Quiere reemplazar el driver de GPU actual?</string> | 171 | <string name="select_gpu_driver_title">¿Quiere reemplazar el driver de GPU actual?</string> |
| 172 | <string name="select_gpu_driver_install">Instalar</string> | 172 | <string name="select_gpu_driver_install">Instalar</string> |
| 173 | <string name="select_gpu_driver_default">Predeterminado</string> | 173 | <string name="select_gpu_driver_default">Predeterminado</string> |
| 174 | <string name="select_gpu_driver_install_success">Instalado %s</string> | ||
| 175 | <string name="select_gpu_driver_use_default">Usando el driver de GPU por defecto </string> | 174 | <string name="select_gpu_driver_use_default">Usando el driver de GPU por defecto </string> |
| 176 | <string name="select_gpu_driver_error">¡Driver no válido, utilizando el predeterminado del sistema!</string> | ||
| 177 | <string name="system_gpu_driver">Driver GPU del sistema</string> | 175 | <string name="system_gpu_driver">Driver GPU del sistema</string> |
| 178 | <string name="installing_driver">Instalando driver...</string> | 176 | <string name="installing_driver">Instalando driver...</string> |
| 179 | 177 | ||
diff --git a/src/android/app/src/main/res/values-fr/strings.xml b/src/android/app/src/main/res/values-fr/strings.xml index a7abd9077..1e02828aa 100644 --- a/src/android/app/src/main/res/values-fr/strings.xml +++ b/src/android/app/src/main/res/values-fr/strings.xml | |||
| @@ -171,9 +171,7 @@ | |||
| 171 | <string name="select_gpu_driver_title">Souhaitez vous remplacer votre pilote actuel ?</string> | 171 | <string name="select_gpu_driver_title">Souhaitez vous remplacer votre pilote actuel ?</string> |
| 172 | <string name="select_gpu_driver_install">Installer</string> | 172 | <string name="select_gpu_driver_install">Installer</string> |
| 173 | <string name="select_gpu_driver_default">Défaut</string> | 173 | <string name="select_gpu_driver_default">Défaut</string> |
| 174 | <string name="select_gpu_driver_install_success">%s Installé</string> | ||
| 175 | <string name="select_gpu_driver_use_default">Utilisation du pilote de GPU par défaut</string> | 174 | <string name="select_gpu_driver_use_default">Utilisation du pilote de GPU par défaut</string> |
| 176 | <string name="select_gpu_driver_error">Pilote non valide sélectionné, utilisation du paramètre par défaut du système !</string> | ||
| 177 | <string name="system_gpu_driver">Pilote du GPU du système</string> | 175 | <string name="system_gpu_driver">Pilote du GPU du système</string> |
| 178 | <string name="installing_driver">Installation du pilote...</string> | 176 | <string name="installing_driver">Installation du pilote...</string> |
| 179 | 177 | ||
diff --git a/src/android/app/src/main/res/values-it/strings.xml b/src/android/app/src/main/res/values-it/strings.xml index b18161801..09c9345b0 100644 --- a/src/android/app/src/main/res/values-it/strings.xml +++ b/src/android/app/src/main/res/values-it/strings.xml | |||
| @@ -171,9 +171,7 @@ | |||
| 171 | <string name="select_gpu_driver_title">Vuoi sostituire il driver della tua GPU attuale?</string> | 171 | <string name="select_gpu_driver_title">Vuoi sostituire il driver della tua GPU attuale?</string> |
| 172 | <string name="select_gpu_driver_install">Installa</string> | 172 | <string name="select_gpu_driver_install">Installa</string> |
| 173 | <string name="select_gpu_driver_default">Predefinito</string> | 173 | <string name="select_gpu_driver_default">Predefinito</string> |
| 174 | <string name="select_gpu_driver_install_success">Installato%s</string> | ||
| 175 | <string name="select_gpu_driver_use_default">Utilizza il driver predefinito della GPU.</string> | 174 | <string name="select_gpu_driver_use_default">Utilizza il driver predefinito della GPU.</string> |
| 176 | <string name="select_gpu_driver_error">Il driver selezionato è invalido, è in utilizzo quello predefinito di sistema!</string> | ||
| 177 | <string name="system_gpu_driver">Driver GPU del sistema</string> | 175 | <string name="system_gpu_driver">Driver GPU del sistema</string> |
| 178 | <string name="installing_driver">Installando i driver...</string> | 176 | <string name="installing_driver">Installando i driver...</string> |
| 179 | 177 | ||
diff --git a/src/android/app/src/main/res/values-ja/strings.xml b/src/android/app/src/main/res/values-ja/strings.xml index 88fa5a0bb..a0ea78bef 100644 --- a/src/android/app/src/main/res/values-ja/strings.xml +++ b/src/android/app/src/main/res/values-ja/strings.xml | |||
| @@ -170,9 +170,7 @@ | |||
| 170 | <string name="select_gpu_driver_title">現在のGPUドライバーを置き換えますか?</string> | 170 | <string name="select_gpu_driver_title">現在のGPUドライバーを置き換えますか?</string> |
| 171 | <string name="select_gpu_driver_install">インストール</string> | 171 | <string name="select_gpu_driver_install">インストール</string> |
| 172 | <string name="select_gpu_driver_default">デフォルト</string> | 172 | <string name="select_gpu_driver_default">デフォルト</string> |
| 173 | <string name="select_gpu_driver_install_success">%s をインストールしました</string> | ||
| 174 | <string name="select_gpu_driver_use_default">デフォルトのGPUドライバーを使用します</string> | 173 | <string name="select_gpu_driver_use_default">デフォルトのGPUドライバーを使用します</string> |
| 175 | <string name="select_gpu_driver_error">選択されたドライバが無効なため、システムのデフォルトを使用します!</string> | ||
| 176 | <string name="system_gpu_driver">システムのGPUドライバ</string> | 174 | <string name="system_gpu_driver">システムのGPUドライバ</string> |
| 177 | <string name="installing_driver">インストール中…</string> | 175 | <string name="installing_driver">インストール中…</string> |
| 178 | 176 | ||
diff --git a/src/android/app/src/main/res/values-ko/strings.xml b/src/android/app/src/main/res/values-ko/strings.xml index 4b658255c..214f95706 100644 --- a/src/android/app/src/main/res/values-ko/strings.xml +++ b/src/android/app/src/main/res/values-ko/strings.xml | |||
| @@ -171,9 +171,7 @@ | |||
| 171 | <string name="select_gpu_driver_title">현재 사용 중인 GPU 드라이버를 교체하겠습니까?</string> | 171 | <string name="select_gpu_driver_title">현재 사용 중인 GPU 드라이버를 교체하겠습니까?</string> |
| 172 | <string name="select_gpu_driver_install">설치</string> | 172 | <string name="select_gpu_driver_install">설치</string> |
| 173 | <string name="select_gpu_driver_default">기본값</string> | 173 | <string name="select_gpu_driver_default">기본값</string> |
| 174 | <string name="select_gpu_driver_install_success">설치된 %s</string> | ||
| 175 | <string name="select_gpu_driver_use_default">기본 GPU 드라이버 사용</string> | 174 | <string name="select_gpu_driver_use_default">기본 GPU 드라이버 사용</string> |
| 176 | <string name="select_gpu_driver_error">시스템 기본값을 사용하여 잘못된 드라이버를 선택했습니다!</string> | ||
| 177 | <string name="system_gpu_driver">시스템 GPU 드라이버</string> | 175 | <string name="system_gpu_driver">시스템 GPU 드라이버</string> |
| 178 | <string name="installing_driver">드라이버 설치 중...</string> | 176 | <string name="installing_driver">드라이버 설치 중...</string> |
| 179 | 177 | ||
diff --git a/src/android/app/src/main/res/values-nb/strings.xml b/src/android/app/src/main/res/values-nb/strings.xml index dd602a389..5443cef42 100644 --- a/src/android/app/src/main/res/values-nb/strings.xml +++ b/src/android/app/src/main/res/values-nb/strings.xml | |||
| @@ -171,9 +171,7 @@ | |||
| 171 | <string name="select_gpu_driver_title">Ønsker du å bytte ut din nåværende GPU-driver?</string> | 171 | <string name="select_gpu_driver_title">Ønsker du å bytte ut din nåværende GPU-driver?</string> |
| 172 | <string name="select_gpu_driver_install">Installer</string> | 172 | <string name="select_gpu_driver_install">Installer</string> |
| 173 | <string name="select_gpu_driver_default">Standard</string> | 173 | <string name="select_gpu_driver_default">Standard</string> |
| 174 | <string name="select_gpu_driver_install_success">Installert %s</string> | ||
| 175 | <string name="select_gpu_driver_use_default">Bruk av standard GPU-driver</string> | 174 | <string name="select_gpu_driver_use_default">Bruk av standard GPU-driver</string> |
| 176 | <string name="select_gpu_driver_error">Ugyldig driver valgt, bruker systemstandard!</string> | ||
| 177 | <string name="system_gpu_driver">Systemets GPU-driver</string> | 175 | <string name="system_gpu_driver">Systemets GPU-driver</string> |
| 178 | <string name="installing_driver">Installerer driver...</string> | 176 | <string name="installing_driver">Installerer driver...</string> |
| 179 | 177 | ||
diff --git a/src/android/app/src/main/res/values-pl/strings.xml b/src/android/app/src/main/res/values-pl/strings.xml index 2fdd1f952..899e233d0 100644 --- a/src/android/app/src/main/res/values-pl/strings.xml +++ b/src/android/app/src/main/res/values-pl/strings.xml | |||
| @@ -171,9 +171,7 @@ | |||
| 171 | <string name="select_gpu_driver_title">Chcesz zastąpić obecny sterownik układu graficznego?</string> | 171 | <string name="select_gpu_driver_title">Chcesz zastąpić obecny sterownik układu graficznego?</string> |
| 172 | <string name="select_gpu_driver_install">Zainstaluj</string> | 172 | <string name="select_gpu_driver_install">Zainstaluj</string> |
| 173 | <string name="select_gpu_driver_default">Domyślne</string> | 173 | <string name="select_gpu_driver_default">Domyślne</string> |
| 174 | <string name="select_gpu_driver_install_success">Zainstalowano %s</string> | ||
| 175 | <string name="select_gpu_driver_use_default">Aktywny domyślny sterownik GPU</string> | 174 | <string name="select_gpu_driver_use_default">Aktywny domyślny sterownik GPU</string> |
| 176 | <string name="select_gpu_driver_error">Wybrano błędny sterownik, powrót do domyślnego. </string> | ||
| 177 | <string name="system_gpu_driver">Systemowy sterownik GPU</string> | 175 | <string name="system_gpu_driver">Systemowy sterownik GPU</string> |
| 178 | <string name="installing_driver">Instalowanie sterownika...</string> | 176 | <string name="installing_driver">Instalowanie sterownika...</string> |
| 179 | 177 | ||
diff --git a/src/android/app/src/main/res/values-pt-rBR/strings.xml b/src/android/app/src/main/res/values-pt-rBR/strings.xml index 2f26367fe..caa095364 100644 --- a/src/android/app/src/main/res/values-pt-rBR/strings.xml +++ b/src/android/app/src/main/res/values-pt-rBR/strings.xml | |||
| @@ -171,9 +171,7 @@ | |||
| 171 | <string name="select_gpu_driver_title">Queres substituir o driver do GPU atual? </string> | 171 | <string name="select_gpu_driver_title">Queres substituir o driver do GPU atual? </string> |
| 172 | <string name="select_gpu_driver_install">Instalar</string> | 172 | <string name="select_gpu_driver_install">Instalar</string> |
| 173 | <string name="select_gpu_driver_default">Padrão</string> | 173 | <string name="select_gpu_driver_default">Padrão</string> |
| 174 | <string name="select_gpu_driver_install_success">Instalado%s</string> | ||
| 175 | <string name="select_gpu_driver_use_default">Usar o driver padrão do GPU</string> | 174 | <string name="select_gpu_driver_use_default">Usar o driver padrão do GPU</string> |
| 176 | <string name="select_gpu_driver_error">Driver selecionado inválido, a usar o padrão do sistema!</string> | ||
| 177 | <string name="system_gpu_driver">Driver do GPU padrão</string> | 175 | <string name="system_gpu_driver">Driver do GPU padrão</string> |
| 178 | <string name="installing_driver">A instalar o Driver...</string> | 176 | <string name="installing_driver">A instalar o Driver...</string> |
| 179 | 177 | ||
diff --git a/src/android/app/src/main/res/values-pt-rPT/strings.xml b/src/android/app/src/main/res/values-pt-rPT/strings.xml index 4e1eb4cd7..0a1a47fbb 100644 --- a/src/android/app/src/main/res/values-pt-rPT/strings.xml +++ b/src/android/app/src/main/res/values-pt-rPT/strings.xml | |||
| @@ -171,9 +171,7 @@ | |||
| 171 | <string name="select_gpu_driver_title">Queres substituir o driver do GPU atual? </string> | 171 | <string name="select_gpu_driver_title">Queres substituir o driver do GPU atual? </string> |
| 172 | <string name="select_gpu_driver_install">Instalar</string> | 172 | <string name="select_gpu_driver_install">Instalar</string> |
| 173 | <string name="select_gpu_driver_default">Padrão</string> | 173 | <string name="select_gpu_driver_default">Padrão</string> |
| 174 | <string name="select_gpu_driver_install_success">Instalado%s</string> | ||
| 175 | <string name="select_gpu_driver_use_default">Usar o driver padrão do GPU</string> | 174 | <string name="select_gpu_driver_use_default">Usar o driver padrão do GPU</string> |
| 176 | <string name="select_gpu_driver_error">Driver selecionado inválido, a usar o padrão do sistema!</string> | ||
| 177 | <string name="system_gpu_driver">Driver do GPU padrão</string> | 175 | <string name="system_gpu_driver">Driver do GPU padrão</string> |
| 178 | <string name="installing_driver">A instalar o Driver...</string> | 176 | <string name="installing_driver">A instalar o Driver...</string> |
| 179 | 177 | ||
diff --git a/src/android/app/src/main/res/values-ru/strings.xml b/src/android/app/src/main/res/values-ru/strings.xml index f5695dc93..0bef035d6 100644 --- a/src/android/app/src/main/res/values-ru/strings.xml +++ b/src/android/app/src/main/res/values-ru/strings.xml | |||
| @@ -171,9 +171,7 @@ | |||
| 171 | <string name="select_gpu_driver_title">Хотите заменить текущий драйвер ГП?</string> | 171 | <string name="select_gpu_driver_title">Хотите заменить текущий драйвер ГП?</string> |
| 172 | <string name="select_gpu_driver_install">Установить</string> | 172 | <string name="select_gpu_driver_install">Установить</string> |
| 173 | <string name="select_gpu_driver_default">По умолчанию</string> | 173 | <string name="select_gpu_driver_default">По умолчанию</string> |
| 174 | <string name="select_gpu_driver_install_success">Установлено %s</string> | ||
| 175 | <string name="select_gpu_driver_use_default">Используется стандартный драйвер ГП </string> | 174 | <string name="select_gpu_driver_use_default">Используется стандартный драйвер ГП </string> |
| 176 | <string name="select_gpu_driver_error">Выбран неверный драйвер, используется стандартный системный!</string> | ||
| 177 | <string name="system_gpu_driver">Системный драйвер ГП</string> | 175 | <string name="system_gpu_driver">Системный драйвер ГП</string> |
| 178 | <string name="installing_driver">Установка драйвера...</string> | 176 | <string name="installing_driver">Установка драйвера...</string> |
| 179 | 177 | ||
diff --git a/src/android/app/src/main/res/values-uk/strings.xml b/src/android/app/src/main/res/values-uk/strings.xml index 061bc6f04..5b789ee98 100644 --- a/src/android/app/src/main/res/values-uk/strings.xml +++ b/src/android/app/src/main/res/values-uk/strings.xml | |||
| @@ -171,9 +171,7 @@ | |||
| 171 | <string name="select_gpu_driver_title">Хочете замінити поточний драйвер ГП?</string> | 171 | <string name="select_gpu_driver_title">Хочете замінити поточний драйвер ГП?</string> |
| 172 | <string name="select_gpu_driver_install">Встановити</string> | 172 | <string name="select_gpu_driver_install">Встановити</string> |
| 173 | <string name="select_gpu_driver_default">За замовчуванням</string> | 173 | <string name="select_gpu_driver_default">За замовчуванням</string> |
| 174 | <string name="select_gpu_driver_install_success">Встановлено %s</string> | ||
| 175 | <string name="select_gpu_driver_use_default">Використовується стандартний драйвер ГП</string> | 174 | <string name="select_gpu_driver_use_default">Використовується стандартний драйвер ГП</string> |
| 176 | <string name="select_gpu_driver_error">Обрано неправильний драйвер, використовується стандартний системний!</string> | ||
| 177 | <string name="system_gpu_driver">Системний драйвер ГП</string> | 175 | <string name="system_gpu_driver">Системний драйвер ГП</string> |
| 178 | <string name="installing_driver">Встановлення драйвера...</string> | 176 | <string name="installing_driver">Встановлення драйвера...</string> |
| 179 | 177 | ||
diff --git a/src/android/app/src/main/res/values-zh-rCN/strings.xml b/src/android/app/src/main/res/values-zh-rCN/strings.xml index fe6dd5eaa..c0e885751 100644 --- a/src/android/app/src/main/res/values-zh-rCN/strings.xml +++ b/src/android/app/src/main/res/values-zh-rCN/strings.xml | |||
| @@ -171,9 +171,7 @@ | |||
| 171 | <string name="select_gpu_driver_title">要取代您当前的 GPU 驱动程序吗?</string> | 171 | <string name="select_gpu_driver_title">要取代您当前的 GPU 驱动程序吗?</string> |
| 172 | <string name="select_gpu_driver_install">安装</string> | 172 | <string name="select_gpu_driver_install">安装</string> |
| 173 | <string name="select_gpu_driver_default">系统默认</string> | 173 | <string name="select_gpu_driver_default">系统默认</string> |
| 174 | <string name="select_gpu_driver_install_success">已安装 %s</string> | ||
| 175 | <string name="select_gpu_driver_use_default">使用默认 GPU 驱动程序</string> | 174 | <string name="select_gpu_driver_use_default">使用默认 GPU 驱动程序</string> |
| 176 | <string name="select_gpu_driver_error">选择的驱动程序无效,将使用系统默认的驱动程序!</string> | ||
| 177 | <string name="system_gpu_driver">系统 GPU 驱动程序</string> | 175 | <string name="system_gpu_driver">系统 GPU 驱动程序</string> |
| 178 | <string name="installing_driver">正在安装驱动程序…</string> | 176 | <string name="installing_driver">正在安装驱动程序…</string> |
| 179 | 177 | ||
diff --git a/src/android/app/src/main/res/values-zh-rTW/strings.xml b/src/android/app/src/main/res/values-zh-rTW/strings.xml index 9b3e54224..4a21bf893 100644 --- a/src/android/app/src/main/res/values-zh-rTW/strings.xml +++ b/src/android/app/src/main/res/values-zh-rTW/strings.xml | |||
| @@ -171,9 +171,7 @@ | |||
| 171 | <string name="select_gpu_driver_title">要取代您目前的 GPU 驅動程式嗎?</string> | 171 | <string name="select_gpu_driver_title">要取代您目前的 GPU 驅動程式嗎?</string> |
| 172 | <string name="select_gpu_driver_install">安裝</string> | 172 | <string name="select_gpu_driver_install">安裝</string> |
| 173 | <string name="select_gpu_driver_default">預設</string> | 173 | <string name="select_gpu_driver_default">預設</string> |
| 174 | <string name="select_gpu_driver_install_success">已安裝 %s</string> | ||
| 175 | <string name="select_gpu_driver_use_default">使用預設 GPU 驅動程式</string> | 174 | <string name="select_gpu_driver_use_default">使用預設 GPU 驅動程式</string> |
| 176 | <string name="select_gpu_driver_error">選取的驅動程式無效,將使用系統預設驅動程式!</string> | ||
| 177 | <string name="system_gpu_driver">系統 GPU 驅動程式</string> | 175 | <string name="system_gpu_driver">系統 GPU 驅動程式</string> |
| 178 | <string name="installing_driver">正在安裝驅動程式…</string> | 176 | <string name="installing_driver">正在安裝驅動程式…</string> |
| 179 | 177 | ||
diff --git a/src/android/app/src/main/res/values/dimens.xml b/src/android/app/src/main/res/values/dimens.xml index 7b2296d95..ef855ea6f 100644 --- a/src/android/app/src/main/res/values/dimens.xml +++ b/src/android/app/src/main/res/values/dimens.xml | |||
| @@ -13,6 +13,8 @@ | |||
| 13 | <dimen name="menu_width">256dp</dimen> | 13 | <dimen name="menu_width">256dp</dimen> |
| 14 | <dimen name="card_width">165dp</dimen> | 14 | <dimen name="card_width">165dp</dimen> |
| 15 | <dimen name="icon_inset">24dp</dimen> | 15 | <dimen name="icon_inset">24dp</dimen> |
| 16 | <dimen name="spacing_bottom_list_fab">72dp</dimen> | ||
| 17 | <dimen name="spacing_fab">24dp</dimen> | ||
| 16 | 18 | ||
| 17 | <dimen name="dialog_margin">20dp</dimen> | 19 | <dimen name="dialog_margin">20dp</dimen> |
| 18 | <dimen name="elevated_app_bar">3dp</dimen> | 20 | <dimen name="elevated_app_bar">3dp</dimen> |
diff --git a/src/android/app/src/main/res/values/strings.xml b/src/android/app/src/main/res/values/strings.xml index e51edf872..9e4854221 100644 --- a/src/android/app/src/main/res/values/strings.xml +++ b/src/android/app/src/main/res/values/strings.xml | |||
| @@ -72,6 +72,7 @@ | |||
| 72 | <string name="invalid_keys_error">Invalid encryption keys</string> | 72 | <string name="invalid_keys_error">Invalid encryption keys</string> |
| 73 | <string name="dumping_keys_quickstart_link">https://yuzu-emu.org/help/quickstart/#dumping-decryption-keys</string> | 73 | <string name="dumping_keys_quickstart_link">https://yuzu-emu.org/help/quickstart/#dumping-decryption-keys</string> |
| 74 | <string name="install_keys_failure_description">The selected file is incorrect or corrupt. Please redump your keys.</string> | 74 | <string name="install_keys_failure_description">The selected file is incorrect or corrupt. Please redump your keys.</string> |
| 75 | <string name="gpu_driver_manager">GPU Driver Manager</string> | ||
| 75 | <string name="install_gpu_driver">Install GPU driver</string> | 76 | <string name="install_gpu_driver">Install GPU driver</string> |
| 76 | <string name="install_gpu_driver_description">Install alternative drivers for potentially better performance or accuracy</string> | 77 | <string name="install_gpu_driver_description">Install alternative drivers for potentially better performance or accuracy</string> |
| 77 | <string name="advanced_settings">Advanced settings</string> | 78 | <string name="advanced_settings">Advanced settings</string> |
| @@ -234,15 +235,17 @@ | |||
| 234 | <string name="export_failed">Export failed</string> | 235 | <string name="export_failed">Export failed</string> |
| 235 | <string name="import_failed">Import failed</string> | 236 | <string name="import_failed">Import failed</string> |
| 236 | <string name="cancelling">Cancelling</string> | 237 | <string name="cancelling">Cancelling</string> |
| 238 | <string name="install">Install</string> | ||
| 239 | <string name="delete">Delete</string> | ||
| 237 | 240 | ||
| 238 | <!-- GPU driver installation --> | 241 | <!-- GPU driver installation --> |
| 239 | <string name="select_gpu_driver">Select GPU driver</string> | 242 | <string name="select_gpu_driver">Select GPU driver</string> |
| 240 | <string name="select_gpu_driver_title">Would you like to replace your current GPU driver?</string> | 243 | <string name="select_gpu_driver_title">Would you like to replace your current GPU driver?</string> |
| 241 | <string name="select_gpu_driver_install">Install</string> | 244 | <string name="select_gpu_driver_install">Install</string> |
| 242 | <string name="select_gpu_driver_default">Default</string> | 245 | <string name="select_gpu_driver_default">Default</string> |
| 243 | <string name="select_gpu_driver_install_success">Installed %s</string> | ||
| 244 | <string name="select_gpu_driver_use_default">Using default GPU driver</string> | 246 | <string name="select_gpu_driver_use_default">Using default GPU driver</string> |
| 245 | <string name="select_gpu_driver_error">Invalid driver selected, using system default!</string> | 247 | <string name="select_gpu_driver_error">Invalid driver selected</string> |
| 248 | <string name="driver_already_installed">Driver already installed</string> | ||
| 246 | <string name="system_gpu_driver">System GPU driver</string> | 249 | <string name="system_gpu_driver">System GPU driver</string> |
| 247 | <string name="installing_driver">Installing driver…</string> | 250 | <string name="installing_driver">Installing driver…</string> |
| 248 | 251 | ||
diff --git a/src/android/build.gradle.kts b/src/android/build.gradle.kts index 80f370c16..51e559321 100644 --- a/src/android/build.gradle.kts +++ b/src/android/build.gradle.kts | |||
| @@ -3,8 +3,8 @@ | |||
| 3 | 3 | ||
| 4 | // Top-level build file where you can add configuration options common to all sub-projects/modules. | 4 | // Top-level build file where you can add configuration options common to all sub-projects/modules. |
| 5 | plugins { | 5 | plugins { |
| 6 | id("com.android.application") version "8.0.2" apply false | 6 | id("com.android.application") version "8.1.2" apply false |
| 7 | id("com.android.library") version "8.0.2" apply false | 7 | id("com.android.library") version "8.1.2" apply false |
| 8 | id("org.jetbrains.kotlin.android") version "1.8.21" apply false | 8 | id("org.jetbrains.kotlin.android") version "1.8.21" apply false |
| 9 | } | 9 | } |
| 10 | 10 | ||
diff --git a/src/audio_core/adsp/apps/audio_renderer/audio_renderer.cpp b/src/audio_core/adsp/apps/audio_renderer/audio_renderer.cpp index 972d5e45b..ef301d8b4 100644 --- a/src/audio_core/adsp/apps/audio_renderer/audio_renderer.cpp +++ b/src/audio_core/adsp/apps/audio_renderer/audio_renderer.cpp | |||
| @@ -77,6 +77,7 @@ void AudioRenderer::Wait() { | |||
| 77 | "{}, got {}", | 77 | "{}, got {}", |
| 78 | Message::RenderResponse, msg); | 78 | Message::RenderResponse, msg); |
| 79 | } | 79 | } |
| 80 | PostDSPClearCommandBuffer(); | ||
| 80 | } | 81 | } |
| 81 | 82 | ||
| 82 | void AudioRenderer::Send(Direction dir, u32 message) { | 83 | void AudioRenderer::Send(Direction dir, u32 message) { |
| @@ -96,6 +97,14 @@ void AudioRenderer::SetCommandBuffer(s32 session_id, CpuAddr buffer, u64 size, u | |||
| 96 | command_buffers[session_id].reset_buffer = reset; | 97 | command_buffers[session_id].reset_buffer = reset; |
| 97 | } | 98 | } |
| 98 | 99 | ||
| 100 | void AudioRenderer::PostDSPClearCommandBuffer() noexcept { | ||
| 101 | for (auto& buffer : command_buffers) { | ||
| 102 | buffer.buffer = 0; | ||
| 103 | buffer.size = 0; | ||
| 104 | buffer.reset_buffer = false; | ||
| 105 | } | ||
| 106 | } | ||
| 107 | |||
| 99 | u32 AudioRenderer::GetRemainCommandCount(s32 session_id) const noexcept { | 108 | u32 AudioRenderer::GetRemainCommandCount(s32 session_id) const noexcept { |
| 100 | return command_buffers[session_id].remaining_command_count; | 109 | return command_buffers[session_id].remaining_command_count; |
| 101 | } | 110 | } |
diff --git a/src/audio_core/adsp/apps/audio_renderer/audio_renderer.h b/src/audio_core/adsp/apps/audio_renderer/audio_renderer.h index 85874d88a..57b89d9fe 100644 --- a/src/audio_core/adsp/apps/audio_renderer/audio_renderer.h +++ b/src/audio_core/adsp/apps/audio_renderer/audio_renderer.h | |||
| @@ -85,6 +85,8 @@ private: | |||
| 85 | */ | 85 | */ |
| 86 | void CreateSinkStreams(); | 86 | void CreateSinkStreams(); |
| 87 | 87 | ||
| 88 | void PostDSPClearCommandBuffer() noexcept; | ||
| 89 | |||
| 88 | /// Core system | 90 | /// Core system |
| 89 | Core::System& system; | 91 | Core::System& system; |
| 90 | /// The output sink the AudioRenderer will send samples to | 92 | /// The output sink the AudioRenderer will send samples to |
diff --git a/src/audio_core/sink/sink_stream.cpp b/src/audio_core/sink/sink_stream.cpp index 6081352a2..d66d04fae 100644 --- a/src/audio_core/sink/sink_stream.cpp +++ b/src/audio_core/sink/sink_stream.cpp | |||
| @@ -204,6 +204,10 @@ void SinkStream::ProcessAudioOutAndRender(std::span<s16> output_buffer, std::siz | |||
| 204 | // paused and we'll desync, so just play silence. | 204 | // paused and we'll desync, so just play silence. |
| 205 | if (system.IsPaused() || system.IsShuttingDown()) { | 205 | if (system.IsPaused() || system.IsShuttingDown()) { |
| 206 | if (system.IsShuttingDown()) { | 206 | if (system.IsShuttingDown()) { |
| 207 | { | ||
| 208 | std::scoped_lock lk{release_mutex}; | ||
| 209 | queued_buffers.store(0); | ||
| 210 | } | ||
| 207 | release_cv.notify_one(); | 211 | release_cv.notify_one(); |
| 208 | } | 212 | } |
| 209 | 213 | ||
diff --git a/src/common/CMakeLists.txt b/src/common/CMakeLists.txt index 416203c59..e216eb3de 100644 --- a/src/common/CMakeLists.txt +++ b/src/common/CMakeLists.txt | |||
| @@ -120,6 +120,8 @@ add_library(common STATIC | |||
| 120 | socket_types.h | 120 | socket_types.h |
| 121 | spin_lock.cpp | 121 | spin_lock.cpp |
| 122 | spin_lock.h | 122 | spin_lock.h |
| 123 | stb.cpp | ||
| 124 | stb.h | ||
| 123 | steady_clock.cpp | 125 | steady_clock.cpp |
| 124 | steady_clock.h | 126 | steady_clock.h |
| 125 | stream.cpp | 127 | stream.cpp |
| @@ -189,6 +191,14 @@ if(ARCHITECTURE_x86_64) | |||
| 189 | target_link_libraries(common PRIVATE xbyak::xbyak) | 191 | target_link_libraries(common PRIVATE xbyak::xbyak) |
| 190 | endif() | 192 | endif() |
| 191 | 193 | ||
| 194 | if (ARCHITECTURE_arm64 AND (ANDROID OR LINUX)) | ||
| 195 | target_sources(common | ||
| 196 | PRIVATE | ||
| 197 | arm64/native_clock.cpp | ||
| 198 | arm64/native_clock.h | ||
| 199 | ) | ||
| 200 | endif() | ||
| 201 | |||
| 192 | if (MSVC) | 202 | if (MSVC) |
| 193 | target_compile_definitions(common PRIVATE | 203 | target_compile_definitions(common PRIVATE |
| 194 | # The standard library doesn't provide any replacement for codecvt yet | 204 | # The standard library doesn't provide any replacement for codecvt yet |
| @@ -200,6 +210,8 @@ if (MSVC) | |||
| 200 | /we4254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data | 210 | /we4254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data |
| 201 | /we4800 # Implicit conversion from 'type' to bool. Possible information loss | 211 | /we4800 # Implicit conversion from 'type' to bool. Possible information loss |
| 202 | ) | 212 | ) |
| 213 | else() | ||
| 214 | set_source_files_properties(stb.cpp PROPERTIES COMPILE_OPTIONS "-Wno-implicit-fallthrough;-Wno-missing-declarations;-Wno-missing-field-initializers") | ||
| 203 | endif() | 215 | endif() |
| 204 | 216 | ||
| 205 | if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang") | 217 | if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang") |
| @@ -215,7 +227,7 @@ endif() | |||
| 215 | 227 | ||
| 216 | create_target_directory_groups(common) | 228 | create_target_directory_groups(common) |
| 217 | 229 | ||
| 218 | target_link_libraries(common PUBLIC Boost::context Boost::headers fmt::fmt microprofile Threads::Threads) | 230 | target_link_libraries(common PUBLIC Boost::context Boost::headers fmt::fmt microprofile stb::headers Threads::Threads) |
| 219 | target_link_libraries(common PRIVATE lz4::lz4 zstd::zstd LLVM::Demangle) | 231 | target_link_libraries(common PRIVATE lz4::lz4 zstd::zstd LLVM::Demangle) |
| 220 | 232 | ||
| 221 | if (ANDROID) | 233 | if (ANDROID) |
diff --git a/src/common/arm64/native_clock.cpp b/src/common/arm64/native_clock.cpp new file mode 100644 index 000000000..88fdba527 --- /dev/null +++ b/src/common/arm64/native_clock.cpp | |||
| @@ -0,0 +1,72 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #include "common/arm64/native_clock.h" | ||
| 5 | |||
| 6 | namespace Common::Arm64 { | ||
| 7 | |||
| 8 | namespace { | ||
| 9 | |||
| 10 | NativeClock::FactorType GetFixedPointFactor(u64 num, u64 den) { | ||
| 11 | return (static_cast<NativeClock::FactorType>(num) << 64) / den; | ||
| 12 | } | ||
| 13 | |||
| 14 | u64 MultiplyHigh(u64 m, NativeClock::FactorType factor) { | ||
| 15 | return static_cast<u64>((m * factor) >> 64); | ||
| 16 | } | ||
| 17 | |||
| 18 | } // namespace | ||
| 19 | |||
| 20 | NativeClock::NativeClock() { | ||
| 21 | const u64 host_cntfrq = GetHostCNTFRQ(); | ||
| 22 | ns_cntfrq_factor = GetFixedPointFactor(NsRatio::den, host_cntfrq); | ||
| 23 | us_cntfrq_factor = GetFixedPointFactor(UsRatio::den, host_cntfrq); | ||
| 24 | ms_cntfrq_factor = GetFixedPointFactor(MsRatio::den, host_cntfrq); | ||
| 25 | guest_cntfrq_factor = GetFixedPointFactor(CNTFRQ, host_cntfrq); | ||
| 26 | gputick_cntfrq_factor = GetFixedPointFactor(GPUTickFreq, host_cntfrq); | ||
| 27 | } | ||
| 28 | |||
| 29 | std::chrono::nanoseconds NativeClock::GetTimeNS() const { | ||
| 30 | return std::chrono::nanoseconds{MultiplyHigh(GetHostTicksElapsed(), ns_cntfrq_factor)}; | ||
| 31 | } | ||
| 32 | |||
| 33 | std::chrono::microseconds NativeClock::GetTimeUS() const { | ||
| 34 | return std::chrono::microseconds{MultiplyHigh(GetHostTicksElapsed(), us_cntfrq_factor)}; | ||
| 35 | } | ||
| 36 | |||
| 37 | std::chrono::milliseconds NativeClock::GetTimeMS() const { | ||
| 38 | return std::chrono::milliseconds{MultiplyHigh(GetHostTicksElapsed(), ms_cntfrq_factor)}; | ||
| 39 | } | ||
| 40 | |||
| 41 | u64 NativeClock::GetCNTPCT() const { | ||
| 42 | return MultiplyHigh(GetHostTicksElapsed(), guest_cntfrq_factor); | ||
| 43 | } | ||
| 44 | |||
| 45 | u64 NativeClock::GetGPUTick() const { | ||
| 46 | return MultiplyHigh(GetHostTicksElapsed(), gputick_cntfrq_factor); | ||
| 47 | } | ||
| 48 | |||
| 49 | u64 NativeClock::GetHostTicksNow() const { | ||
| 50 | u64 cntvct_el0 = 0; | ||
| 51 | asm volatile("dsb ish\n\t" | ||
| 52 | "mrs %[cntvct_el0], cntvct_el0\n\t" | ||
| 53 | "dsb ish\n\t" | ||
| 54 | : [cntvct_el0] "=r"(cntvct_el0)); | ||
| 55 | return cntvct_el0; | ||
| 56 | } | ||
| 57 | |||
| 58 | u64 NativeClock::GetHostTicksElapsed() const { | ||
| 59 | return GetHostTicksNow(); | ||
| 60 | } | ||
| 61 | |||
| 62 | bool NativeClock::IsNative() const { | ||
| 63 | return true; | ||
| 64 | } | ||
| 65 | |||
| 66 | u64 NativeClock::GetHostCNTFRQ() { | ||
| 67 | u64 cntfrq_el0 = 0; | ||
| 68 | asm("mrs %[cntfrq_el0], cntfrq_el0" : [cntfrq_el0] "=r"(cntfrq_el0)); | ||
| 69 | return cntfrq_el0; | ||
| 70 | } | ||
| 71 | |||
| 72 | } // namespace Common::Arm64 | ||
diff --git a/src/common/arm64/native_clock.h b/src/common/arm64/native_clock.h new file mode 100644 index 000000000..a28b419f2 --- /dev/null +++ b/src/common/arm64/native_clock.h | |||
| @@ -0,0 +1,47 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #pragma once | ||
| 5 | |||
| 6 | #include "common/wall_clock.h" | ||
| 7 | |||
| 8 | namespace Common::Arm64 { | ||
| 9 | |||
| 10 | class NativeClock final : public WallClock { | ||
| 11 | public: | ||
| 12 | explicit NativeClock(); | ||
| 13 | |||
| 14 | std::chrono::nanoseconds GetTimeNS() const override; | ||
| 15 | |||
| 16 | std::chrono::microseconds GetTimeUS() const override; | ||
| 17 | |||
| 18 | std::chrono::milliseconds GetTimeMS() const override; | ||
| 19 | |||
| 20 | u64 GetCNTPCT() const override; | ||
| 21 | |||
| 22 | u64 GetGPUTick() const override; | ||
| 23 | |||
| 24 | u64 GetHostTicksNow() const override; | ||
| 25 | |||
| 26 | u64 GetHostTicksElapsed() const override; | ||
| 27 | |||
| 28 | bool IsNative() const override; | ||
| 29 | |||
| 30 | static u64 GetHostCNTFRQ(); | ||
| 31 | |||
| 32 | public: | ||
| 33 | using FactorType = unsigned __int128; | ||
| 34 | |||
| 35 | FactorType GetGuestCNTFRQFactor() const { | ||
| 36 | return guest_cntfrq_factor; | ||
| 37 | } | ||
| 38 | |||
| 39 | private: | ||
| 40 | FactorType ns_cntfrq_factor; | ||
| 41 | FactorType us_cntfrq_factor; | ||
| 42 | FactorType ms_cntfrq_factor; | ||
| 43 | FactorType guest_cntfrq_factor; | ||
| 44 | FactorType gputick_cntfrq_factor; | ||
| 45 | }; | ||
| 46 | |||
| 47 | } // namespace Common::Arm64 | ||
diff --git a/src/common/common_funcs.h b/src/common/common_funcs.h index 0dad9338a..47d028d48 100644 --- a/src/common/common_funcs.h +++ b/src/common/common_funcs.h | |||
| @@ -39,8 +39,12 @@ | |||
| 39 | #define Crash() exit(1) | 39 | #define Crash() exit(1) |
| 40 | #endif | 40 | #endif |
| 41 | 41 | ||
| 42 | #define LTO_NOINLINE __attribute__((noinline)) | ||
| 43 | |||
| 42 | #else // _MSC_VER | 44 | #else // _MSC_VER |
| 43 | 45 | ||
| 46 | #define LTO_NOINLINE | ||
| 47 | |||
| 44 | // Locale Cross-Compatibility | 48 | // Locale Cross-Compatibility |
| 45 | #define locale_t _locale_t | 49 | #define locale_t _locale_t |
| 46 | 50 | ||
diff --git a/src/common/elf.h b/src/common/elf.h index 14a5e9597..0b728dc54 100644 --- a/src/common/elf.h +++ b/src/common/elf.h | |||
| @@ -211,6 +211,11 @@ struct Elf64_Rela { | |||
| 211 | Elf64_Sxword r_addend; /* Addend */ | 211 | Elf64_Sxword r_addend; /* Addend */ |
| 212 | }; | 212 | }; |
| 213 | 213 | ||
| 214 | /* RELR relocation table entry */ | ||
| 215 | |||
| 216 | using Elf32_Relr = Elf32_Word; | ||
| 217 | using Elf64_Relr = Elf64_Xword; | ||
| 218 | |||
| 214 | /* How to extract and insert information held in the r_info field. */ | 219 | /* How to extract and insert information held in the r_info field. */ |
| 215 | 220 | ||
| 216 | static inline u32 Elf32RelSymIndex(Elf32_Word r_info) { | 221 | static inline u32 Elf32RelSymIndex(Elf32_Word r_info) { |
| @@ -328,6 +333,9 @@ constexpr u32 ElfDtFiniArray = 26; /* Array with addresses of fini fct */ | |||
| 328 | constexpr u32 ElfDtInitArraySz = 27; /* Size in bytes of DT_INIT_ARRAY */ | 333 | constexpr u32 ElfDtInitArraySz = 27; /* Size in bytes of DT_INIT_ARRAY */ |
| 329 | constexpr u32 ElfDtFiniArraySz = 28; /* Size in bytes of DT_FINI_ARRAY */ | 334 | constexpr u32 ElfDtFiniArraySz = 28; /* Size in bytes of DT_FINI_ARRAY */ |
| 330 | constexpr u32 ElfDtSymtabShndx = 34; /* Address of SYMTAB_SHNDX section */ | 335 | constexpr u32 ElfDtSymtabShndx = 34; /* Address of SYMTAB_SHNDX section */ |
| 336 | constexpr u32 ElfDtRelrsz = 35; /* Size of RELR relative relocations */ | ||
| 337 | constexpr u32 ElfDtRelr = 36; /* Address of RELR relative relocations */ | ||
| 338 | constexpr u32 ElfDtRelrent = 37; /* Size of one RELR relative relocation */ | ||
| 331 | 339 | ||
| 332 | } // namespace ELF | 340 | } // namespace ELF |
| 333 | } // namespace Common | 341 | } // namespace Common |
diff --git a/src/common/fs/fs_paths.h b/src/common/fs/fs_paths.h index 1a3f6ab45..bcf447089 100644 --- a/src/common/fs/fs_paths.h +++ b/src/common/fs/fs_paths.h | |||
| @@ -19,10 +19,12 @@ | |||
| 19 | #define LOAD_DIR "load" | 19 | #define LOAD_DIR "load" |
| 20 | #define LOG_DIR "log" | 20 | #define LOG_DIR "log" |
| 21 | #define NAND_DIR "nand" | 21 | #define NAND_DIR "nand" |
| 22 | #define PLAY_TIME_DIR "play_time" | ||
| 22 | #define SCREENSHOTS_DIR "screenshots" | 23 | #define SCREENSHOTS_DIR "screenshots" |
| 23 | #define SDMC_DIR "sdmc" | 24 | #define SDMC_DIR "sdmc" |
| 24 | #define SHADER_DIR "shader" | 25 | #define SHADER_DIR "shader" |
| 25 | #define TAS_DIR "tas" | 26 | #define TAS_DIR "tas" |
| 27 | #define ICONS_DIR "icons" | ||
| 26 | 28 | ||
| 27 | // yuzu-specific files | 29 | // yuzu-specific files |
| 28 | 30 | ||
diff --git a/src/common/fs/path_util.cpp b/src/common/fs/path_util.cpp index fbac4d80c..0c4c88cde 100644 --- a/src/common/fs/path_util.cpp +++ b/src/common/fs/path_util.cpp | |||
| @@ -125,10 +125,12 @@ public: | |||
| 125 | GenerateYuzuPath(YuzuPath::LoadDir, yuzu_path / LOAD_DIR); | 125 | GenerateYuzuPath(YuzuPath::LoadDir, yuzu_path / LOAD_DIR); |
| 126 | GenerateYuzuPath(YuzuPath::LogDir, yuzu_path / LOG_DIR); | 126 | GenerateYuzuPath(YuzuPath::LogDir, yuzu_path / LOG_DIR); |
| 127 | GenerateYuzuPath(YuzuPath::NANDDir, yuzu_path / NAND_DIR); | 127 | GenerateYuzuPath(YuzuPath::NANDDir, yuzu_path / NAND_DIR); |
| 128 | GenerateYuzuPath(YuzuPath::PlayTimeDir, yuzu_path / PLAY_TIME_DIR); | ||
| 128 | GenerateYuzuPath(YuzuPath::ScreenshotsDir, yuzu_path / SCREENSHOTS_DIR); | 129 | GenerateYuzuPath(YuzuPath::ScreenshotsDir, yuzu_path / SCREENSHOTS_DIR); |
| 129 | GenerateYuzuPath(YuzuPath::SDMCDir, yuzu_path / SDMC_DIR); | 130 | GenerateYuzuPath(YuzuPath::SDMCDir, yuzu_path / SDMC_DIR); |
| 130 | GenerateYuzuPath(YuzuPath::ShaderDir, yuzu_path / SHADER_DIR); | 131 | GenerateYuzuPath(YuzuPath::ShaderDir, yuzu_path / SHADER_DIR); |
| 131 | GenerateYuzuPath(YuzuPath::TASDir, yuzu_path / TAS_DIR); | 132 | GenerateYuzuPath(YuzuPath::TASDir, yuzu_path / TAS_DIR); |
| 133 | GenerateYuzuPath(YuzuPath::IconsDir, yuzu_path / ICONS_DIR); | ||
| 132 | } | 134 | } |
| 133 | 135 | ||
| 134 | private: | 136 | private: |
diff --git a/src/common/fs/path_util.h b/src/common/fs/path_util.h index 036e475aa..2874ea738 100644 --- a/src/common/fs/path_util.h +++ b/src/common/fs/path_util.h | |||
| @@ -21,10 +21,12 @@ enum class YuzuPath { | |||
| 21 | LoadDir, // Where cheat/mod files are stored. | 21 | LoadDir, // Where cheat/mod files are stored. |
| 22 | LogDir, // Where log files are stored. | 22 | LogDir, // Where log files are stored. |
| 23 | NANDDir, // Where the emulated NAND is stored. | 23 | NANDDir, // Where the emulated NAND is stored. |
| 24 | PlayTimeDir, // Where play time data is stored. | ||
| 24 | ScreenshotsDir, // Where yuzu screenshots are stored. | 25 | ScreenshotsDir, // Where yuzu screenshots are stored. |
| 25 | SDMCDir, // Where the emulated SDMC is stored. | 26 | SDMCDir, // Where the emulated SDMC is stored. |
| 26 | ShaderDir, // Where shaders are stored. | 27 | ShaderDir, // Where shaders are stored. |
| 27 | TASDir, // Where TAS scripts are stored. | 28 | TASDir, // Where TAS scripts are stored. |
| 29 | IconsDir, // Where Icons for Windows shortcuts are stored. | ||
| 28 | }; | 30 | }; |
| 29 | 31 | ||
| 30 | /** | 32 | /** |
diff --git a/src/common/nvidia_flags.cpp b/src/common/nvidia_flags.cpp index 7ed7690ee..fa3747782 100644 --- a/src/common/nvidia_flags.cpp +++ b/src/common/nvidia_flags.cpp | |||
| @@ -25,6 +25,7 @@ void ConfigureNvidiaEnvironmentFlags() { | |||
| 25 | 25 | ||
| 26 | void(_putenv(fmt::format("__GL_SHADER_DISK_CACHE_PATH={}", windows_path_string).c_str())); | 26 | void(_putenv(fmt::format("__GL_SHADER_DISK_CACHE_PATH={}", windows_path_string).c_str())); |
| 27 | void(_putenv("__GL_SHADER_DISK_CACHE_SKIP_CLEANUP=1")); | 27 | void(_putenv("__GL_SHADER_DISK_CACHE_SKIP_CLEANUP=1")); |
| 28 | void(_putenv("__GL_THREADED_OPTIMIZATIONS=1")); | ||
| 28 | #endif | 29 | #endif |
| 29 | } | 30 | } |
| 30 | 31 | ||
diff --git a/src/common/polyfill_thread.h b/src/common/polyfill_thread.h index 41cbb9ed5..12e59a893 100644 --- a/src/common/polyfill_thread.h +++ b/src/common/polyfill_thread.h | |||
| @@ -15,12 +15,13 @@ | |||
| 15 | #include <condition_variable> | 15 | #include <condition_variable> |
| 16 | #include <stop_token> | 16 | #include <stop_token> |
| 17 | #include <thread> | 17 | #include <thread> |
| 18 | #include <utility> | ||
| 18 | 19 | ||
| 19 | namespace Common { | 20 | namespace Common { |
| 20 | 21 | ||
| 21 | template <typename Condvar, typename Lock, typename Pred> | 22 | template <typename Condvar, typename Lock, typename Pred> |
| 22 | void CondvarWait(Condvar& cv, std::unique_lock<Lock>& lk, std::stop_token token, Pred&& pred) { | 23 | void CondvarWait(Condvar& cv, std::unique_lock<Lock>& lk, std::stop_token token, Pred&& pred) { |
| 23 | cv.wait(lk, token, std::move(pred)); | 24 | cv.wait(lk, token, std::forward<Pred>(pred)); |
| 24 | } | 25 | } |
| 25 | 26 | ||
| 26 | template <typename Rep, typename Period> | 27 | template <typename Rep, typename Period> |
| @@ -109,7 +110,7 @@ public: | |||
| 109 | 110 | ||
| 110 | // Insert the callback. | 111 | // Insert the callback. |
| 111 | stop_state_callback ret = ++m_next_callback; | 112 | stop_state_callback ret = ++m_next_callback; |
| 112 | m_callbacks.emplace(ret, move(f)); | 113 | m_callbacks.emplace(ret, std::move(f)); |
| 113 | return ret; | 114 | return ret; |
| 114 | } | 115 | } |
| 115 | 116 | ||
| @@ -162,7 +163,7 @@ private: | |||
| 162 | friend class stop_source; | 163 | friend class stop_source; |
| 163 | template <typename Callback> | 164 | template <typename Callback> |
| 164 | friend class stop_callback; | 165 | friend class stop_callback; |
| 165 | stop_token(shared_ptr<polyfill::stop_state> stop_state) : m_stop_state(move(stop_state)) {} | 166 | stop_token(shared_ptr<polyfill::stop_state> stop_state) : m_stop_state(std::move(stop_state)) {} |
| 166 | 167 | ||
| 167 | private: | 168 | private: |
| 168 | shared_ptr<polyfill::stop_state> m_stop_state; | 169 | shared_ptr<polyfill::stop_state> m_stop_state; |
| @@ -198,7 +199,7 @@ public: | |||
| 198 | private: | 199 | private: |
| 199 | friend class jthread; | 200 | friend class jthread; |
| 200 | explicit stop_source(shared_ptr<polyfill::stop_state> stop_state) | 201 | explicit stop_source(shared_ptr<polyfill::stop_state> stop_state) |
| 201 | : m_stop_state(move(stop_state)) {} | 202 | : m_stop_state(std::move(stop_state)) {} |
| 202 | 203 | ||
| 203 | private: | 204 | private: |
| 204 | shared_ptr<polyfill::stop_state> m_stop_state; | 205 | shared_ptr<polyfill::stop_state> m_stop_state; |
| @@ -218,16 +219,16 @@ public: | |||
| 218 | C&& cb) noexcept(is_nothrow_constructible_v<Callback, C>) | 219 | C&& cb) noexcept(is_nothrow_constructible_v<Callback, C>) |
| 219 | : m_stop_state(st.m_stop_state) { | 220 | : m_stop_state(st.m_stop_state) { |
| 220 | if (m_stop_state) { | 221 | if (m_stop_state) { |
| 221 | m_callback = m_stop_state->insert_callback(move(cb)); | 222 | m_callback = m_stop_state->insert_callback(std::move(cb)); |
| 222 | } | 223 | } |
| 223 | } | 224 | } |
| 224 | template <typename C> | 225 | template <typename C> |
| 225 | requires constructible_from<Callback, C> | 226 | requires constructible_from<Callback, C> |
| 226 | explicit stop_callback(stop_token&& st, | 227 | explicit stop_callback(stop_token&& st, |
| 227 | C&& cb) noexcept(is_nothrow_constructible_v<Callback, C>) | 228 | C&& cb) noexcept(is_nothrow_constructible_v<Callback, C>) |
| 228 | : m_stop_state(move(st.m_stop_state)) { | 229 | : m_stop_state(std::move(st.m_stop_state)) { |
| 229 | if (m_stop_state) { | 230 | if (m_stop_state) { |
| 230 | m_callback = m_stop_state->insert_callback(move(cb)); | 231 | m_callback = m_stop_state->insert_callback(std::move(cb)); |
| 231 | } | 232 | } |
| 232 | } | 233 | } |
| 233 | ~stop_callback() { | 234 | ~stop_callback() { |
| @@ -260,7 +261,7 @@ public: | |||
| 260 | typename = enable_if_t<!is_same_v<remove_cvref_t<F>, jthread>>> | 261 | typename = enable_if_t<!is_same_v<remove_cvref_t<F>, jthread>>> |
| 261 | explicit jthread(F&& f, Args&&... args) | 262 | explicit jthread(F&& f, Args&&... args) |
| 262 | : m_stop_state(make_shared<polyfill::stop_state>()), | 263 | : m_stop_state(make_shared<polyfill::stop_state>()), |
| 263 | m_thread(make_thread(move(f), move(args)...)) {} | 264 | m_thread(make_thread(std::forward<F>(f), std::forward<Args>(args)...)) {} |
| 264 | 265 | ||
| 265 | ~jthread() { | 266 | ~jthread() { |
| 266 | if (joinable()) { | 267 | if (joinable()) { |
| @@ -317,9 +318,9 @@ private: | |||
| 317 | template <typename F, typename... Args> | 318 | template <typename F, typename... Args> |
| 318 | thread make_thread(F&& f, Args&&... args) { | 319 | thread make_thread(F&& f, Args&&... args) { |
| 319 | if constexpr (is_invocable_v<decay_t<F>, stop_token, decay_t<Args>...>) { | 320 | if constexpr (is_invocable_v<decay_t<F>, stop_token, decay_t<Args>...>) { |
| 320 | return thread(move(f), get_stop_token(), move(args)...); | 321 | return thread(std::forward<F>(f), get_stop_token(), std::forward<Args>(args)...); |
| 321 | } else { | 322 | } else { |
| 322 | return thread(move(f), move(args)...); | 323 | return thread(std::forward<F>(f), std::forward<Args>(args)...); |
| 323 | } | 324 | } |
| 324 | } | 325 | } |
| 325 | 326 | ||
diff --git a/src/common/settings.cpp b/src/common/settings.cpp index 3fde3cae6..98b43e49c 100644 --- a/src/common/settings.cpp +++ b/src/common/settings.cpp | |||
| @@ -45,6 +45,7 @@ SWITCHABLE(CpuAccuracy, true); | |||
| 45 | SWITCHABLE(FullscreenMode, true); | 45 | SWITCHABLE(FullscreenMode, true); |
| 46 | SWITCHABLE(GpuAccuracy, true); | 46 | SWITCHABLE(GpuAccuracy, true); |
| 47 | SWITCHABLE(Language, true); | 47 | SWITCHABLE(Language, true); |
| 48 | SWITCHABLE(MemoryLayout, true); | ||
| 48 | SWITCHABLE(NvdecEmulation, false); | 49 | SWITCHABLE(NvdecEmulation, false); |
| 49 | SWITCHABLE(Region, true); | 50 | SWITCHABLE(Region, true); |
| 50 | SWITCHABLE(RendererBackend, true); | 51 | SWITCHABLE(RendererBackend, true); |
| @@ -61,6 +62,10 @@ SWITCHABLE(u32, false); | |||
| 61 | SWITCHABLE(u8, false); | 62 | SWITCHABLE(u8, false); |
| 62 | SWITCHABLE(u8, true); | 63 | SWITCHABLE(u8, true); |
| 63 | 64 | ||
| 65 | // Used in UISettings | ||
| 66 | // TODO see if we can move this to uisettings.cpp | ||
| 67 | SWITCHABLE(ConfirmStop, true); | ||
| 68 | |||
| 64 | #undef SETTING | 69 | #undef SETTING |
| 65 | #undef SWITCHABLE | 70 | #undef SWITCHABLE |
| 66 | #endif | 71 | #endif |
diff --git a/src/common/settings.h b/src/common/settings.h index 6a3fe47c9..9317075f7 100644 --- a/src/common/settings.h +++ b/src/common/settings.h | |||
| @@ -67,6 +67,7 @@ SWITCHABLE(CpuAccuracy, true); | |||
| 67 | SWITCHABLE(FullscreenMode, true); | 67 | SWITCHABLE(FullscreenMode, true); |
| 68 | SWITCHABLE(GpuAccuracy, true); | 68 | SWITCHABLE(GpuAccuracy, true); |
| 69 | SWITCHABLE(Language, true); | 69 | SWITCHABLE(Language, true); |
| 70 | SWITCHABLE(MemoryLayout, true); | ||
| 70 | SWITCHABLE(NvdecEmulation, false); | 71 | SWITCHABLE(NvdecEmulation, false); |
| 71 | SWITCHABLE(Region, true); | 72 | SWITCHABLE(Region, true); |
| 72 | SWITCHABLE(RendererBackend, true); | 73 | SWITCHABLE(RendererBackend, true); |
| @@ -83,6 +84,10 @@ SWITCHABLE(u32, false); | |||
| 83 | SWITCHABLE(u8, false); | 84 | SWITCHABLE(u8, false); |
| 84 | SWITCHABLE(u8, true); | 85 | SWITCHABLE(u8, true); |
| 85 | 86 | ||
| 87 | // Used in UISettings | ||
| 88 | // TODO see if we can move this to uisettings.h | ||
| 89 | SWITCHABLE(ConfirmStop, true); | ||
| 90 | |||
| 86 | #undef SETTING | 91 | #undef SETTING |
| 87 | #undef SWITCHABLE | 92 | #undef SWITCHABLE |
| 88 | #endif | 93 | #endif |
diff --git a/src/common/settings_enums.h b/src/common/settings_enums.h index 815cafe15..11429d7a8 100644 --- a/src/common/settings_enums.h +++ b/src/common/settings_enums.h | |||
| @@ -133,6 +133,8 @@ ENUM(CpuAccuracy, Auto, Accurate, Unsafe, Paranoid); | |||
| 133 | 133 | ||
| 134 | ENUM(MemoryLayout, Memory_4Gb, Memory_6Gb, Memory_8Gb); | 134 | ENUM(MemoryLayout, Memory_4Gb, Memory_6Gb, Memory_8Gb); |
| 135 | 135 | ||
| 136 | ENUM(ConfirmStop, Ask_Always, Ask_Based_On_Game, Ask_Never); | ||
| 137 | |||
| 136 | ENUM(FullscreenMode, Borderless, Exclusive); | 138 | ENUM(FullscreenMode, Borderless, Exclusive); |
| 137 | 139 | ||
| 138 | ENUM(NvdecEmulation, Off, Cpu, Gpu); | 140 | ENUM(NvdecEmulation, Off, Cpu, Gpu); |
diff --git a/src/common/stb.cpp b/src/common/stb.cpp new file mode 100644 index 000000000..d3b16665d --- /dev/null +++ b/src/common/stb.cpp | |||
| @@ -0,0 +1,8 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #define STB_IMAGE_IMPLEMENTATION | ||
| 5 | #define STB_IMAGE_RESIZE_IMPLEMENTATION | ||
| 6 | #define STB_IMAGE_WRITE_IMPLEMENTATION | ||
| 7 | |||
| 8 | #include "common/stb.h" | ||
diff --git a/src/common/stb.h b/src/common/stb.h new file mode 100644 index 000000000..e5c197c11 --- /dev/null +++ b/src/common/stb.h | |||
| @@ -0,0 +1,8 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #pragma once | ||
| 5 | |||
| 6 | #include <stb_image.h> | ||
| 7 | #include <stb_image_resize.h> | ||
| 8 | #include <stb_image_write.h> | ||
diff --git a/src/common/string_util.cpp b/src/common/string_util.cpp index feab1653d..4c7aba3f5 100644 --- a/src/common/string_util.cpp +++ b/src/common/string_util.cpp | |||
| @@ -135,6 +135,11 @@ std::u16string UTF8ToUTF16(std::string_view input) { | |||
| 135 | return convert.from_bytes(input.data(), input.data() + input.size()); | 135 | return convert.from_bytes(input.data(), input.data() + input.size()); |
| 136 | } | 136 | } |
| 137 | 137 | ||
| 138 | std::u32string UTF8ToUTF32(std::string_view input) { | ||
| 139 | std::wstring_convert<std::codecvt_utf8<char32_t>, char32_t> convert; | ||
| 140 | return convert.from_bytes(input.data(), input.data() + input.size()); | ||
| 141 | } | ||
| 142 | |||
| 138 | #ifdef _WIN32 | 143 | #ifdef _WIN32 |
| 139 | static std::wstring CPToUTF16(u32 code_page, std::string_view input) { | 144 | static std::wstring CPToUTF16(u32 code_page, std::string_view input) { |
| 140 | const auto size = | 145 | const auto size = |
diff --git a/src/common/string_util.h b/src/common/string_util.h index c351f1a0c..9da1ca4e9 100644 --- a/src/common/string_util.h +++ b/src/common/string_util.h | |||
| @@ -38,6 +38,7 @@ bool SplitPath(const std::string& full_path, std::string* _pPath, std::string* _ | |||
| 38 | 38 | ||
| 39 | [[nodiscard]] std::string UTF16ToUTF8(std::u16string_view input); | 39 | [[nodiscard]] std::string UTF16ToUTF8(std::u16string_view input); |
| 40 | [[nodiscard]] std::u16string UTF8ToUTF16(std::string_view input); | 40 | [[nodiscard]] std::u16string UTF8ToUTF16(std::string_view input); |
| 41 | [[nodiscard]] std::u32string UTF8ToUTF32(std::string_view input); | ||
| 41 | 42 | ||
| 42 | #ifdef _WIN32 | 43 | #ifdef _WIN32 |
| 43 | [[nodiscard]] std::string UTF16ToUTF8(std::wstring_view input); | 44 | [[nodiscard]] std::string UTF16ToUTF8(std::wstring_view input); |
diff --git a/src/common/thread.cpp b/src/common/thread.cpp index 919e33af9..34cc1527b 100644 --- a/src/common/thread.cpp +++ b/src/common/thread.cpp | |||
| @@ -11,6 +11,7 @@ | |||
| 11 | #include <mach/mach.h> | 11 | #include <mach/mach.h> |
| 12 | #elif defined(_WIN32) | 12 | #elif defined(_WIN32) |
| 13 | #include <windows.h> | 13 | #include <windows.h> |
| 14 | #include "common/string_util.h" | ||
| 14 | #else | 15 | #else |
| 15 | #if defined(__Bitrig__) || defined(__DragonFly__) || defined(__FreeBSD__) || defined(__OpenBSD__) | 16 | #if defined(__Bitrig__) || defined(__DragonFly__) || defined(__FreeBSD__) || defined(__OpenBSD__) |
| 16 | #include <pthread_np.h> | 17 | #include <pthread_np.h> |
| @@ -82,29 +83,8 @@ void SetCurrentThreadPriority(ThreadPriority new_priority) { | |||
| 82 | #ifdef _MSC_VER | 83 | #ifdef _MSC_VER |
| 83 | 84 | ||
| 84 | // Sets the debugger-visible name of the current thread. | 85 | // Sets the debugger-visible name of the current thread. |
| 85 | // Uses trick documented in: | ||
| 86 | // https://docs.microsoft.com/en-us/visualstudio/debugger/how-to-set-a-thread-name-in-native-code | ||
| 87 | void SetCurrentThreadName(const char* name) { | 86 | void SetCurrentThreadName(const char* name) { |
| 88 | static const DWORD MS_VC_EXCEPTION = 0x406D1388; | 87 | SetThreadDescription(GetCurrentThread(), UTF8ToUTF16W(name).data()); |
| 89 | |||
| 90 | #pragma pack(push, 8) | ||
| 91 | struct THREADNAME_INFO { | ||
| 92 | DWORD dwType; // must be 0x1000 | ||
| 93 | LPCSTR szName; // pointer to name (in user addr space) | ||
| 94 | DWORD dwThreadID; // thread ID (-1=caller thread) | ||
| 95 | DWORD dwFlags; // reserved for future use, must be zero | ||
| 96 | } info; | ||
| 97 | #pragma pack(pop) | ||
| 98 | |||
| 99 | info.dwType = 0x1000; | ||
| 100 | info.szName = name; | ||
| 101 | info.dwThreadID = std::numeric_limits<DWORD>::max(); | ||
| 102 | info.dwFlags = 0; | ||
| 103 | |||
| 104 | __try { | ||
| 105 | RaiseException(MS_VC_EXCEPTION, 0, sizeof(info) / sizeof(ULONG_PTR), (ULONG_PTR*)&info); | ||
| 106 | } __except (EXCEPTION_CONTINUE_EXECUTION) { | ||
| 107 | } | ||
| 108 | } | 88 | } |
| 109 | 89 | ||
| 110 | #else // !MSVC_VER, so must be POSIX threads | 90 | #else // !MSVC_VER, so must be POSIX threads |
diff --git a/src/common/wall_clock.cpp b/src/common/wall_clock.cpp index 71e15ab4c..caca9a123 100644 --- a/src/common/wall_clock.cpp +++ b/src/common/wall_clock.cpp | |||
| @@ -10,6 +10,10 @@ | |||
| 10 | #include "common/x64/rdtsc.h" | 10 | #include "common/x64/rdtsc.h" |
| 11 | #endif | 11 | #endif |
| 12 | 12 | ||
| 13 | #if defined(ARCHITECTURE_arm64) && defined(__linux__) | ||
| 14 | #include "common/arm64/native_clock.h" | ||
| 15 | #endif | ||
| 16 | |||
| 13 | namespace Common { | 17 | namespace Common { |
| 14 | 18 | ||
| 15 | class StandardWallClock final : public WallClock { | 19 | class StandardWallClock final : public WallClock { |
| @@ -53,7 +57,7 @@ private: | |||
| 53 | }; | 57 | }; |
| 54 | 58 | ||
| 55 | std::unique_ptr<WallClock> CreateOptimalClock() { | 59 | std::unique_ptr<WallClock> CreateOptimalClock() { |
| 56 | #ifdef ARCHITECTURE_x86_64 | 60 | #if defined(ARCHITECTURE_x86_64) |
| 57 | const auto& caps = GetCPUCaps(); | 61 | const auto& caps = GetCPUCaps(); |
| 58 | 62 | ||
| 59 | if (caps.invariant_tsc && caps.tsc_frequency >= std::nano::den) { | 63 | if (caps.invariant_tsc && caps.tsc_frequency >= std::nano::den) { |
| @@ -64,6 +68,8 @@ std::unique_ptr<WallClock> CreateOptimalClock() { | |||
| 64 | // - Is not more precise than 1 GHz (1ns resolution) | 68 | // - Is not more precise than 1 GHz (1ns resolution) |
| 65 | return std::make_unique<StandardWallClock>(); | 69 | return std::make_unique<StandardWallClock>(); |
| 66 | } | 70 | } |
| 71 | #elif defined(ARCHITECTURE_arm64) && defined(__linux__) | ||
| 72 | return std::make_unique<Arm64::NativeClock>(); | ||
| 67 | #else | 73 | #else |
| 68 | return std::make_unique<StandardWallClock>(); | 74 | return std::make_unique<StandardWallClock>(); |
| 69 | #endif | 75 | #endif |
diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index e02ededfc..e4f499135 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt | |||
| @@ -466,14 +466,18 @@ add_library(core STATIC | |||
| 466 | hle/service/caps/caps_a.h | 466 | hle/service/caps/caps_a.h |
| 467 | hle/service/caps/caps_c.cpp | 467 | hle/service/caps/caps_c.cpp |
| 468 | hle/service/caps/caps_c.h | 468 | hle/service/caps/caps_c.h |
| 469 | hle/service/caps/caps_u.cpp | 469 | hle/service/caps/caps_manager.cpp |
| 470 | hle/service/caps/caps_u.h | 470 | hle/service/caps/caps_manager.h |
| 471 | hle/service/caps/caps_result.h | ||
| 471 | hle/service/caps/caps_sc.cpp | 472 | hle/service/caps/caps_sc.cpp |
| 472 | hle/service/caps/caps_sc.h | 473 | hle/service/caps/caps_sc.h |
| 473 | hle/service/caps/caps_ss.cpp | 474 | hle/service/caps/caps_ss.cpp |
| 474 | hle/service/caps/caps_ss.h | 475 | hle/service/caps/caps_ss.h |
| 475 | hle/service/caps/caps_su.cpp | 476 | hle/service/caps/caps_su.cpp |
| 476 | hle/service/caps/caps_su.h | 477 | hle/service/caps/caps_su.h |
| 478 | hle/service/caps/caps_types.h | ||
| 479 | hle/service/caps/caps_u.cpp | ||
| 480 | hle/service/caps/caps_u.h | ||
| 477 | hle/service/erpt/erpt.cpp | 481 | hle/service/erpt/erpt.cpp |
| 478 | hle/service/erpt/erpt.h | 482 | hle/service/erpt/erpt.h |
| 479 | hle/service/es/es.cpp | 483 | hle/service/es/es.cpp |
diff --git a/src/core/arm/arm_interface.cpp b/src/core/arm/arm_interface.cpp index 0c012f094..5e27dde58 100644 --- a/src/core/arm/arm_interface.cpp +++ b/src/core/arm/arm_interface.cpp | |||
| @@ -86,9 +86,9 @@ void ARM_Interface::SymbolicateBacktrace(Core::System& system, std::vector<Backt | |||
| 86 | 86 | ||
| 87 | std::map<std::string, Symbols::Symbols> symbols; | 87 | std::map<std::string, Symbols::Symbols> symbols; |
| 88 | for (const auto& module : modules) { | 88 | for (const auto& module : modules) { |
| 89 | symbols.insert_or_assign( | 89 | symbols.insert_or_assign(module.second, |
| 90 | module.second, Symbols::GetSymbols(module.first, system.ApplicationMemory(), | 90 | Symbols::GetSymbols(module.first, system.ApplicationMemory(), |
| 91 | system.ApplicationProcess()->Is64BitProcess())); | 91 | system.ApplicationProcess()->Is64Bit())); |
| 92 | } | 92 | } |
| 93 | 93 | ||
| 94 | for (auto& entry : out) { | 94 | for (auto& entry : out) { |
diff --git a/src/core/core.cpp b/src/core/core.cpp index 08cbb8978..14d6c8c27 100644 --- a/src/core/core.cpp +++ b/src/core/core.cpp | |||
| @@ -116,11 +116,8 @@ FileSys::VirtualFile GetGameFileFromPath(const FileSys::VirtualFilesystem& vfs, | |||
| 116 | } | 116 | } |
| 117 | } | 117 | } |
| 118 | 118 | ||
| 119 | if (concat.empty()) { | 119 | return FileSys::ConcatenatedVfsFile::MakeConcatenatedFile(dir->GetName(), |
| 120 | return nullptr; | 120 | std::move(concat)); |
| 121 | } | ||
| 122 | |||
| 123 | return FileSys::ConcatenatedVfsFile::MakeConcatenatedFile(concat, dir->GetName()); | ||
| 124 | } | 121 | } |
| 125 | 122 | ||
| 126 | if (Common::FS::IsDir(path)) { | 123 | if (Common::FS::IsDir(path)) { |
| @@ -312,17 +309,10 @@ struct System::Impl { | |||
| 312 | 309 | ||
| 313 | telemetry_session->AddInitialInfo(*app_loader, fs_controller, *content_provider); | 310 | telemetry_session->AddInitialInfo(*app_loader, fs_controller, *content_provider); |
| 314 | 311 | ||
| 315 | // Create a resource limit for the process. | ||
| 316 | const auto physical_memory_size = | ||
| 317 | kernel.MemoryManager().GetSize(Kernel::KMemoryManager::Pool::Application); | ||
| 318 | auto* resource_limit = Kernel::CreateResourceLimitForProcess(system, physical_memory_size); | ||
| 319 | |||
| 320 | // Create the process. | 312 | // Create the process. |
| 321 | auto main_process = Kernel::KProcess::Create(system.Kernel()); | 313 | auto main_process = Kernel::KProcess::Create(system.Kernel()); |
| 322 | ASSERT(Kernel::KProcess::Initialize(main_process, system, "main", | ||
| 323 | Kernel::KProcess::ProcessType::Userland, resource_limit) | ||
| 324 | .IsSuccess()); | ||
| 325 | Kernel::KProcess::Register(system.Kernel(), main_process); | 314 | Kernel::KProcess::Register(system.Kernel(), main_process); |
| 315 | kernel.AppendNewProcess(main_process); | ||
| 326 | kernel.MakeApplicationProcess(main_process); | 316 | kernel.MakeApplicationProcess(main_process); |
| 327 | const auto [load_result, load_parameters] = app_loader->Load(*main_process, system); | 317 | const auto [load_result, load_parameters] = app_loader->Load(*main_process, system); |
| 328 | if (load_result != Loader::ResultStatus::Success) { | 318 | if (load_result != Loader::ResultStatus::Success) { |
| @@ -421,6 +411,7 @@ struct System::Impl { | |||
| 421 | services->KillNVNFlinger(); | 411 | services->KillNVNFlinger(); |
| 422 | } | 412 | } |
| 423 | kernel.CloseServices(); | 413 | kernel.CloseServices(); |
| 414 | kernel.ShutdownCores(); | ||
| 424 | services.reset(); | 415 | services.reset(); |
| 425 | service_manager.reset(); | 416 | service_manager.reset(); |
| 426 | cheat_engine.reset(); | 417 | cheat_engine.reset(); |
| @@ -432,7 +423,6 @@ struct System::Impl { | |||
| 432 | gpu_core.reset(); | 423 | gpu_core.reset(); |
| 433 | host1x_core.reset(); | 424 | host1x_core.reset(); |
| 434 | perf_stats.reset(); | 425 | perf_stats.reset(); |
| 435 | kernel.ShutdownCores(); | ||
| 436 | cpu_manager.Shutdown(); | 426 | cpu_manager.Shutdown(); |
| 437 | debugger.reset(); | 427 | debugger.reset(); |
| 438 | kernel.Shutdown(); | 428 | kernel.Shutdown(); |
| @@ -1078,6 +1068,10 @@ void System::ApplySettings() { | |||
| 1078 | impl->RefreshTime(); | 1068 | impl->RefreshTime(); |
| 1079 | 1069 | ||
| 1080 | if (IsPoweredOn()) { | 1070 | if (IsPoweredOn()) { |
| 1071 | if (Settings::values.custom_rtc_enabled) { | ||
| 1072 | const s64 posix_time{Settings::values.custom_rtc.GetValue()}; | ||
| 1073 | GetTimeManager().UpdateLocalSystemClockTime(posix_time); | ||
| 1074 | } | ||
| 1081 | Renderer().RefreshBaseSettings(); | 1075 | Renderer().RefreshBaseSettings(); |
| 1082 | } | 1076 | } |
| 1083 | } | 1077 | } |
diff --git a/src/core/debugger/debugger.cpp b/src/core/debugger/debugger.cpp index a1589fecb..0e270eb50 100644 --- a/src/core/debugger/debugger.cpp +++ b/src/core/debugger/debugger.cpp | |||
| @@ -258,20 +258,20 @@ private: | |||
| 258 | Kernel::KScopedSchedulerLock sl{system.Kernel()}; | 258 | Kernel::KScopedSchedulerLock sl{system.Kernel()}; |
| 259 | 259 | ||
| 260 | // Put all threads to sleep on next scheduler round. | 260 | // Put all threads to sleep on next scheduler round. |
| 261 | for (auto* thread : ThreadList()) { | 261 | for (auto& thread : ThreadList()) { |
| 262 | thread->RequestSuspend(Kernel::SuspendType::Debug); | 262 | thread.RequestSuspend(Kernel::SuspendType::Debug); |
| 263 | } | 263 | } |
| 264 | } | 264 | } |
| 265 | 265 | ||
| 266 | void ResumeEmulation(Kernel::KThread* except = nullptr) { | 266 | void ResumeEmulation(Kernel::KThread* except = nullptr) { |
| 267 | // Wake up all threads. | 267 | // Wake up all threads. |
| 268 | for (auto* thread : ThreadList()) { | 268 | for (auto& thread : ThreadList()) { |
| 269 | if (thread == except) { | 269 | if (std::addressof(thread) == except) { |
| 270 | continue; | 270 | continue; |
| 271 | } | 271 | } |
| 272 | 272 | ||
| 273 | thread->SetStepState(Kernel::StepState::NotStepping); | 273 | thread.SetStepState(Kernel::StepState::NotStepping); |
| 274 | thread->Resume(Kernel::SuspendType::Debug); | 274 | thread.Resume(Kernel::SuspendType::Debug); |
| 275 | } | 275 | } |
| 276 | } | 276 | } |
| 277 | 277 | ||
| @@ -283,13 +283,17 @@ private: | |||
| 283 | } | 283 | } |
| 284 | 284 | ||
| 285 | void UpdateActiveThread() { | 285 | void UpdateActiveThread() { |
| 286 | const auto& threads{ThreadList()}; | 286 | auto& threads{ThreadList()}; |
| 287 | if (std::find(threads.begin(), threads.end(), state->active_thread) == threads.end()) { | 287 | for (auto& thread : threads) { |
| 288 | state->active_thread = threads.front(); | 288 | if (std::addressof(thread) == state->active_thread) { |
| 289 | // Thread is still alive, no need to update. | ||
| 290 | return; | ||
| 291 | } | ||
| 289 | } | 292 | } |
| 293 | state->active_thread = std::addressof(threads.front()); | ||
| 290 | } | 294 | } |
| 291 | 295 | ||
| 292 | const std::list<Kernel::KThread*>& ThreadList() { | 296 | Kernel::KProcess::ThreadList& ThreadList() { |
| 293 | return system.ApplicationProcess()->GetThreadList(); | 297 | return system.ApplicationProcess()->GetThreadList(); |
| 294 | } | 298 | } |
| 295 | 299 | ||
diff --git a/src/core/debugger/gdbstub.cpp b/src/core/debugger/gdbstub.cpp index e55831f27..6f5f5156b 100644 --- a/src/core/debugger/gdbstub.cpp +++ b/src/core/debugger/gdbstub.cpp | |||
| @@ -2,6 +2,8 @@ | |||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | 2 | // SPDX-License-Identifier: GPL-2.0-or-later |
| 3 | 3 | ||
| 4 | #include <atomic> | 4 | #include <atomic> |
| 5 | #include <codecvt> | ||
| 6 | #include <locale> | ||
| 5 | #include <numeric> | 7 | #include <numeric> |
| 6 | #include <optional> | 8 | #include <optional> |
| 7 | #include <thread> | 9 | #include <thread> |
| @@ -12,6 +14,7 @@ | |||
| 12 | #include "common/logging/log.h" | 14 | #include "common/logging/log.h" |
| 13 | #include "common/scope_exit.h" | 15 | #include "common/scope_exit.h" |
| 14 | #include "common/settings.h" | 16 | #include "common/settings.h" |
| 17 | #include "common/string_util.h" | ||
| 15 | #include "core/arm/arm_interface.h" | 18 | #include "core/arm/arm_interface.h" |
| 16 | #include "core/core.h" | 19 | #include "core/core.h" |
| 17 | #include "core/debugger/gdbstub.h" | 20 | #include "core/debugger/gdbstub.h" |
| @@ -68,10 +71,16 @@ static std::string EscapeGDB(std::string_view data) { | |||
| 68 | } | 71 | } |
| 69 | 72 | ||
| 70 | static std::string EscapeXML(std::string_view data) { | 73 | static std::string EscapeXML(std::string_view data) { |
| 74 | std::u32string converted = U"[Encoding error]"; | ||
| 75 | try { | ||
| 76 | converted = Common::UTF8ToUTF32(data); | ||
| 77 | } catch (std::range_error&) { | ||
| 78 | } | ||
| 79 | |||
| 71 | std::string escaped; | 80 | std::string escaped; |
| 72 | escaped.reserve(data.size()); | 81 | escaped.reserve(data.size()); |
| 73 | 82 | ||
| 74 | for (char c : data) { | 83 | for (char32_t c : converted) { |
| 75 | switch (c) { | 84 | switch (c) { |
| 76 | case '&': | 85 | case '&': |
| 77 | escaped += "&"; | 86 | escaped += "&"; |
| @@ -86,7 +95,11 @@ static std::string EscapeXML(std::string_view data) { | |||
| 86 | escaped += ">"; | 95 | escaped += ">"; |
| 87 | break; | 96 | break; |
| 88 | default: | 97 | default: |
| 89 | escaped += c; | 98 | if (c > 0x7f) { |
| 99 | escaped += fmt::format("&#{};", static_cast<u32>(c)); | ||
| 100 | } else { | ||
| 101 | escaped += static_cast<char>(c); | ||
| 102 | } | ||
| 90 | break; | 103 | break; |
| 91 | } | 104 | } |
| 92 | } | 105 | } |
| @@ -96,7 +109,7 @@ static std::string EscapeXML(std::string_view data) { | |||
| 96 | 109 | ||
| 97 | GDBStub::GDBStub(DebuggerBackend& backend_, Core::System& system_) | 110 | GDBStub::GDBStub(DebuggerBackend& backend_, Core::System& system_) |
| 98 | : DebuggerFrontend(backend_), system{system_} { | 111 | : DebuggerFrontend(backend_), system{system_} { |
| 99 | if (system.ApplicationProcess()->Is64BitProcess()) { | 112 | if (system.ApplicationProcess()->Is64Bit()) { |
| 100 | arch = std::make_unique<GDBStubA64>(); | 113 | arch = std::make_unique<GDBStubA64>(); |
| 101 | } else { | 114 | } else { |
| 102 | arch = std::make_unique<GDBStubA32>(); | 115 | arch = std::make_unique<GDBStubA32>(); |
| @@ -433,10 +446,10 @@ void GDBStub::HandleBreakpointRemove(std::string_view command) { | |||
| 433 | // See osdbg_thread_local_region.os.horizon.hpp and osdbg_thread_type.os.horizon.hpp | 446 | // See osdbg_thread_local_region.os.horizon.hpp and osdbg_thread_type.os.horizon.hpp |
| 434 | 447 | ||
| 435 | static std::optional<std::string> GetNameFromThreadType32(Core::Memory::Memory& memory, | 448 | static std::optional<std::string> GetNameFromThreadType32(Core::Memory::Memory& memory, |
| 436 | const Kernel::KThread* thread) { | 449 | const Kernel::KThread& thread) { |
| 437 | // Read thread type from TLS | 450 | // Read thread type from TLS |
| 438 | const VAddr tls_thread_type{memory.Read32(thread->GetTlsAddress() + 0x1fc)}; | 451 | const VAddr tls_thread_type{memory.Read32(thread.GetTlsAddress() + 0x1fc)}; |
| 439 | const VAddr argument_thread_type{thread->GetArgument()}; | 452 | const VAddr argument_thread_type{thread.GetArgument()}; |
| 440 | 453 | ||
| 441 | if (argument_thread_type && tls_thread_type != argument_thread_type) { | 454 | if (argument_thread_type && tls_thread_type != argument_thread_type) { |
| 442 | // Probably not created by nnsdk, no name available. | 455 | // Probably not created by nnsdk, no name available. |
| @@ -464,10 +477,10 @@ static std::optional<std::string> GetNameFromThreadType32(Core::Memory::Memory& | |||
| 464 | } | 477 | } |
| 465 | 478 | ||
| 466 | static std::optional<std::string> GetNameFromThreadType64(Core::Memory::Memory& memory, | 479 | static std::optional<std::string> GetNameFromThreadType64(Core::Memory::Memory& memory, |
| 467 | const Kernel::KThread* thread) { | 480 | const Kernel::KThread& thread) { |
| 468 | // Read thread type from TLS | 481 | // Read thread type from TLS |
| 469 | const VAddr tls_thread_type{memory.Read64(thread->GetTlsAddress() + 0x1f8)}; | 482 | const VAddr tls_thread_type{memory.Read64(thread.GetTlsAddress() + 0x1f8)}; |
| 470 | const VAddr argument_thread_type{thread->GetArgument()}; | 483 | const VAddr argument_thread_type{thread.GetArgument()}; |
| 471 | 484 | ||
| 472 | if (argument_thread_type && tls_thread_type != argument_thread_type) { | 485 | if (argument_thread_type && tls_thread_type != argument_thread_type) { |
| 473 | // Probably not created by nnsdk, no name available. | 486 | // Probably not created by nnsdk, no name available. |
| @@ -495,16 +508,16 @@ static std::optional<std::string> GetNameFromThreadType64(Core::Memory::Memory& | |||
| 495 | } | 508 | } |
| 496 | 509 | ||
| 497 | static std::optional<std::string> GetThreadName(Core::System& system, | 510 | static std::optional<std::string> GetThreadName(Core::System& system, |
| 498 | const Kernel::KThread* thread) { | 511 | const Kernel::KThread& thread) { |
| 499 | if (system.ApplicationProcess()->Is64BitProcess()) { | 512 | if (system.ApplicationProcess()->Is64Bit()) { |
| 500 | return GetNameFromThreadType64(system.ApplicationMemory(), thread); | 513 | return GetNameFromThreadType64(system.ApplicationMemory(), thread); |
| 501 | } else { | 514 | } else { |
| 502 | return GetNameFromThreadType32(system.ApplicationMemory(), thread); | 515 | return GetNameFromThreadType32(system.ApplicationMemory(), thread); |
| 503 | } | 516 | } |
| 504 | } | 517 | } |
| 505 | 518 | ||
| 506 | static std::string_view GetThreadWaitReason(const Kernel::KThread* thread) { | 519 | static std::string_view GetThreadWaitReason(const Kernel::KThread& thread) { |
| 507 | switch (thread->GetWaitReasonForDebugging()) { | 520 | switch (thread.GetWaitReasonForDebugging()) { |
| 508 | case Kernel::ThreadWaitReasonForDebugging::Sleep: | 521 | case Kernel::ThreadWaitReasonForDebugging::Sleep: |
| 509 | return "Sleep"; | 522 | return "Sleep"; |
| 510 | case Kernel::ThreadWaitReasonForDebugging::IPC: | 523 | case Kernel::ThreadWaitReasonForDebugging::IPC: |
| @@ -522,8 +535,8 @@ static std::string_view GetThreadWaitReason(const Kernel::KThread* thread) { | |||
| 522 | } | 535 | } |
| 523 | } | 536 | } |
| 524 | 537 | ||
| 525 | static std::string GetThreadState(const Kernel::KThread* thread) { | 538 | static std::string GetThreadState(const Kernel::KThread& thread) { |
| 526 | switch (thread->GetState()) { | 539 | switch (thread.GetState()) { |
| 527 | case Kernel::ThreadState::Initialized: | 540 | case Kernel::ThreadState::Initialized: |
| 528 | return "Initialized"; | 541 | return "Initialized"; |
| 529 | case Kernel::ThreadState::Waiting: | 542 | case Kernel::ThreadState::Waiting: |
| @@ -591,7 +604,7 @@ void GDBStub::HandleQuery(std::string_view command) { | |||
| 591 | const auto& threads = system.ApplicationProcess()->GetThreadList(); | 604 | const auto& threads = system.ApplicationProcess()->GetThreadList(); |
| 592 | std::vector<std::string> thread_ids; | 605 | std::vector<std::string> thread_ids; |
| 593 | for (const auto& thread : threads) { | 606 | for (const auto& thread : threads) { |
| 594 | thread_ids.push_back(fmt::format("{:x}", thread->GetThreadId())); | 607 | thread_ids.push_back(fmt::format("{:x}", thread.GetThreadId())); |
| 595 | } | 608 | } |
| 596 | SendReply(fmt::format("m{}", fmt::join(thread_ids, ","))); | 609 | SendReply(fmt::format("m{}", fmt::join(thread_ids, ","))); |
| 597 | } else if (command.starts_with("sThreadInfo")) { | 610 | } else if (command.starts_with("sThreadInfo")) { |
| @@ -603,14 +616,14 @@ void GDBStub::HandleQuery(std::string_view command) { | |||
| 603 | buffer += "<threads>"; | 616 | buffer += "<threads>"; |
| 604 | 617 | ||
| 605 | const auto& threads = system.ApplicationProcess()->GetThreadList(); | 618 | const auto& threads = system.ApplicationProcess()->GetThreadList(); |
| 606 | for (const auto* thread : threads) { | 619 | for (const auto& thread : threads) { |
| 607 | auto thread_name{GetThreadName(system, thread)}; | 620 | auto thread_name{GetThreadName(system, thread)}; |
| 608 | if (!thread_name) { | 621 | if (!thread_name) { |
| 609 | thread_name = fmt::format("Thread {:d}", thread->GetThreadId()); | 622 | thread_name = fmt::format("Thread {:d}", thread.GetThreadId()); |
| 610 | } | 623 | } |
| 611 | 624 | ||
| 612 | buffer += fmt::format(R"(<thread id="{:x}" core="{:d}" name="{}">{}</thread>)", | 625 | buffer += fmt::format(R"(<thread id="{:x}" core="{:d}" name="{}">{}</thread>)", |
| 613 | thread->GetThreadId(), thread->GetActiveCore(), | 626 | thread.GetThreadId(), thread.GetActiveCore(), |
| 614 | EscapeXML(*thread_name), GetThreadState(thread)); | 627 | EscapeXML(*thread_name), GetThreadState(thread)); |
| 615 | } | 628 | } |
| 616 | 629 | ||
| @@ -809,11 +822,13 @@ void GDBStub::HandleRcmd(const std::vector<u8>& command) { | |||
| 809 | const char i = True(mem_info.attribute & MemoryAttribute::IpcLocked) ? 'I' : '-'; | 822 | const char i = True(mem_info.attribute & MemoryAttribute::IpcLocked) ? 'I' : '-'; |
| 810 | const char d = True(mem_info.attribute & MemoryAttribute::DeviceShared) ? 'D' : '-'; | 823 | const char d = True(mem_info.attribute & MemoryAttribute::DeviceShared) ? 'D' : '-'; |
| 811 | const char u = True(mem_info.attribute & MemoryAttribute::Uncached) ? 'U' : '-'; | 824 | const char u = True(mem_info.attribute & MemoryAttribute::Uncached) ? 'U' : '-'; |
| 825 | const char p = | ||
| 826 | True(mem_info.attribute & MemoryAttribute::PermissionLocked) ? 'P' : '-'; | ||
| 812 | 827 | ||
| 813 | reply += | 828 | reply += fmt::format(" {:#012x} - {:#012x} {} {} {}{}{}{}{} [{}, {}]\n", |
| 814 | fmt::format(" {:#012x} - {:#012x} {} {} {}{}{}{} [{}, {}]\n", | 829 | mem_info.base_address, |
| 815 | mem_info.base_address, mem_info.base_address + mem_info.size - 1, | 830 | mem_info.base_address + mem_info.size - 1, perm, state, l, i, |
| 816 | perm, state, l, i, d, u, mem_info.ipc_count, mem_info.device_count); | 831 | d, u, p, mem_info.ipc_count, mem_info.device_count); |
| 817 | } | 832 | } |
| 818 | 833 | ||
| 819 | const uintptr_t next_address = mem_info.base_address + mem_info.size; | 834 | const uintptr_t next_address = mem_info.base_address + mem_info.size; |
| @@ -835,10 +850,10 @@ void GDBStub::HandleRcmd(const std::vector<u8>& command) { | |||
| 835 | } | 850 | } |
| 836 | 851 | ||
| 837 | Kernel::KThread* GDBStub::GetThreadByID(u64 thread_id) { | 852 | Kernel::KThread* GDBStub::GetThreadByID(u64 thread_id) { |
| 838 | const auto& threads{system.ApplicationProcess()->GetThreadList()}; | 853 | auto& threads{system.ApplicationProcess()->GetThreadList()}; |
| 839 | for (auto* thread : threads) { | 854 | for (auto& thread : threads) { |
| 840 | if (thread->GetThreadId() == thread_id) { | 855 | if (thread.GetThreadId() == thread_id) { |
| 841 | return thread; | 856 | return std::addressof(thread); |
| 842 | } | 857 | } |
| 843 | } | 858 | } |
| 844 | 859 | ||
diff --git a/src/core/file_sys/fsmitm_romfsbuild.cpp b/src/core/file_sys/fsmitm_romfsbuild.cpp index e39c7b62b..f1d3e4129 100644 --- a/src/core/file_sys/fsmitm_romfsbuild.cpp +++ b/src/core/file_sys/fsmitm_romfsbuild.cpp | |||
| @@ -107,62 +107,56 @@ static u64 romfs_get_hash_table_count(u64 num_entries) { | |||
| 107 | 107 | ||
| 108 | void RomFSBuildContext::VisitDirectory(VirtualDir romfs_dir, VirtualDir ext_dir, | 108 | void RomFSBuildContext::VisitDirectory(VirtualDir romfs_dir, VirtualDir ext_dir, |
| 109 | std::shared_ptr<RomFSBuildDirectoryContext> parent) { | 109 | std::shared_ptr<RomFSBuildDirectoryContext> parent) { |
| 110 | std::vector<std::shared_ptr<RomFSBuildDirectoryContext>> child_dirs; | 110 | for (auto& child_romfs_file : romfs_dir->GetFiles()) { |
| 111 | const auto name = child_romfs_file->GetName(); | ||
| 112 | const auto child = std::make_shared<RomFSBuildFileContext>(); | ||
| 113 | // Set child's path. | ||
| 114 | child->cur_path_ofs = parent->path_len + 1; | ||
| 115 | child->path_len = child->cur_path_ofs + static_cast<u32>(name.size()); | ||
| 116 | child->path = parent->path + "/" + name; | ||
| 117 | |||
| 118 | if (ext_dir != nullptr && ext_dir->GetFile(name + ".stub") != nullptr) { | ||
| 119 | continue; | ||
| 120 | } | ||
| 111 | 121 | ||
| 112 | const auto entries = romfs_dir->GetEntries(); | 122 | // Sanity check on path_len |
| 123 | ASSERT(child->path_len < FS_MAX_PATH); | ||
| 113 | 124 | ||
| 114 | for (const auto& kv : entries) { | 125 | child->source = std::move(child_romfs_file); |
| 115 | if (kv.second == VfsEntryType::Directory) { | ||
| 116 | const auto child = std::make_shared<RomFSBuildDirectoryContext>(); | ||
| 117 | // Set child's path. | ||
| 118 | child->cur_path_ofs = parent->path_len + 1; | ||
| 119 | child->path_len = child->cur_path_ofs + static_cast<u32>(kv.first.size()); | ||
| 120 | child->path = parent->path + "/" + kv.first; | ||
| 121 | 126 | ||
| 122 | if (ext_dir != nullptr && ext_dir->GetFile(kv.first + ".stub") != nullptr) { | 127 | if (ext_dir != nullptr) { |
| 123 | continue; | 128 | if (const auto ips = ext_dir->GetFile(name + ".ips")) { |
| 129 | if (auto patched = PatchIPS(child->source, ips)) { | ||
| 130 | child->source = std::move(patched); | ||
| 131 | } | ||
| 124 | } | 132 | } |
| 133 | } | ||
| 125 | 134 | ||
| 126 | // Sanity check on path_len | 135 | child->size = child->source->GetSize(); |
| 127 | ASSERT(child->path_len < FS_MAX_PATH); | ||
| 128 | |||
| 129 | if (AddDirectory(parent, child)) { | ||
| 130 | child_dirs.push_back(child); | ||
| 131 | } | ||
| 132 | } else { | ||
| 133 | const auto child = std::make_shared<RomFSBuildFileContext>(); | ||
| 134 | // Set child's path. | ||
| 135 | child->cur_path_ofs = parent->path_len + 1; | ||
| 136 | child->path_len = child->cur_path_ofs + static_cast<u32>(kv.first.size()); | ||
| 137 | child->path = parent->path + "/" + kv.first; | ||
| 138 | |||
| 139 | if (ext_dir != nullptr && ext_dir->GetFile(kv.first + ".stub") != nullptr) { | ||
| 140 | continue; | ||
| 141 | } | ||
| 142 | 136 | ||
| 143 | // Sanity check on path_len | 137 | AddFile(parent, child); |
| 144 | ASSERT(child->path_len < FS_MAX_PATH); | 138 | } |
| 145 | 139 | ||
| 146 | child->source = romfs_dir->GetFile(kv.first); | 140 | for (auto& child_romfs_dir : romfs_dir->GetSubdirectories()) { |
| 141 | const auto name = child_romfs_dir->GetName(); | ||
| 142 | const auto child = std::make_shared<RomFSBuildDirectoryContext>(); | ||
| 143 | // Set child's path. | ||
| 144 | child->cur_path_ofs = parent->path_len + 1; | ||
| 145 | child->path_len = child->cur_path_ofs + static_cast<u32>(name.size()); | ||
| 146 | child->path = parent->path + "/" + name; | ||
| 147 | 147 | ||
| 148 | if (ext_dir != nullptr) { | 148 | if (ext_dir != nullptr && ext_dir->GetFile(name + ".stub") != nullptr) { |
| 149 | if (const auto ips = ext_dir->GetFile(kv.first + ".ips")) { | 149 | continue; |
| 150 | if (auto patched = PatchIPS(child->source, ips)) { | 150 | } |
| 151 | child->source = std::move(patched); | ||
| 152 | } | ||
| 153 | } | ||
| 154 | } | ||
| 155 | 151 | ||
| 156 | child->size = child->source->GetSize(); | 152 | // Sanity check on path_len |
| 153 | ASSERT(child->path_len < FS_MAX_PATH); | ||
| 157 | 154 | ||
| 158 | AddFile(parent, child); | 155 | if (!AddDirectory(parent, child)) { |
| 156 | continue; | ||
| 159 | } | 157 | } |
| 160 | } | ||
| 161 | 158 | ||
| 162 | for (auto& child : child_dirs) { | 159 | auto child_ext_dir = ext_dir != nullptr ? ext_dir->GetSubdirectory(name) : nullptr; |
| 163 | auto subdir_name = std::string_view(child->path).substr(child->cur_path_ofs); | ||
| 164 | auto child_romfs_dir = romfs_dir->GetSubdirectory(subdir_name); | ||
| 165 | auto child_ext_dir = ext_dir != nullptr ? ext_dir->GetSubdirectory(subdir_name) : nullptr; | ||
| 166 | this->VisitDirectory(child_romfs_dir, child_ext_dir, child); | 160 | this->VisitDirectory(child_romfs_dir, child_ext_dir, child); |
| 167 | } | 161 | } |
| 168 | } | 162 | } |
| @@ -293,7 +287,7 @@ std::multimap<u64, VirtualFile> RomFSBuildContext::Build() { | |||
| 293 | 287 | ||
| 294 | cur_entry.name_size = name_size; | 288 | cur_entry.name_size = name_size; |
| 295 | 289 | ||
| 296 | out.emplace(cur_file->offset + ROMFS_FILEPARTITION_OFS, cur_file->source); | 290 | out.emplace(cur_file->offset + ROMFS_FILEPARTITION_OFS, std::move(cur_file->source)); |
| 297 | std::memcpy(file_table.data() + cur_file->entry_offset, &cur_entry, sizeof(RomFSFileEntry)); | 291 | std::memcpy(file_table.data() + cur_file->entry_offset, &cur_entry, sizeof(RomFSFileEntry)); |
| 298 | std::memset(file_table.data() + cur_file->entry_offset + sizeof(RomFSFileEntry), 0, | 292 | std::memset(file_table.data() + cur_file->entry_offset + sizeof(RomFSFileEntry), 0, |
| 299 | Common::AlignUp(cur_entry.name_size, 4)); | 293 | Common::AlignUp(cur_entry.name_size, 4)); |
diff --git a/src/core/file_sys/patch_manager.cpp b/src/core/file_sys/patch_manager.cpp index 8e475f25a..0bca05587 100644 --- a/src/core/file_sys/patch_manager.cpp +++ b/src/core/file_sys/patch_manager.cpp | |||
| @@ -377,16 +377,16 @@ static void ApplyLayeredFS(VirtualFile& romfs, u64 title_id, ContentRecordType t | |||
| 377 | 377 | ||
| 378 | auto romfs_dir = FindSubdirectoryCaseless(subdir, "romfs"); | 378 | auto romfs_dir = FindSubdirectoryCaseless(subdir, "romfs"); |
| 379 | if (romfs_dir != nullptr) | 379 | if (romfs_dir != nullptr) |
| 380 | layers.push_back(std::make_shared<CachedVfsDirectory>(romfs_dir)); | 380 | layers.emplace_back(std::make_shared<CachedVfsDirectory>(std::move(romfs_dir))); |
| 381 | 381 | ||
| 382 | auto ext_dir = FindSubdirectoryCaseless(subdir, "romfs_ext"); | 382 | auto ext_dir = FindSubdirectoryCaseless(subdir, "romfs_ext"); |
| 383 | if (ext_dir != nullptr) | 383 | if (ext_dir != nullptr) |
| 384 | layers_ext.push_back(std::make_shared<CachedVfsDirectory>(ext_dir)); | 384 | layers_ext.emplace_back(std::make_shared<CachedVfsDirectory>(std::move(ext_dir))); |
| 385 | 385 | ||
| 386 | if (type == ContentRecordType::HtmlDocument) { | 386 | if (type == ContentRecordType::HtmlDocument) { |
| 387 | auto manual_dir = FindSubdirectoryCaseless(subdir, "manual_html"); | 387 | auto manual_dir = FindSubdirectoryCaseless(subdir, "manual_html"); |
| 388 | if (manual_dir != nullptr) | 388 | if (manual_dir != nullptr) |
| 389 | layers.push_back(std::make_shared<CachedVfsDirectory>(manual_dir)); | 389 | layers.emplace_back(std::make_shared<CachedVfsDirectory>(std::move(manual_dir))); |
| 390 | } | 390 | } |
| 391 | } | 391 | } |
| 392 | 392 | ||
| @@ -400,7 +400,7 @@ static void ApplyLayeredFS(VirtualFile& romfs, u64 title_id, ContentRecordType t | |||
| 400 | return; | 400 | return; |
| 401 | } | 401 | } |
| 402 | 402 | ||
| 403 | layers.push_back(std::move(extracted)); | 403 | layers.emplace_back(std::move(extracted)); |
| 404 | 404 | ||
| 405 | auto layered = LayeredVfsDirectory::MakeLayeredDirectory(std::move(layers)); | 405 | auto layered = LayeredVfsDirectory::MakeLayeredDirectory(std::move(layers)); |
| 406 | if (layered == nullptr) { | 406 | if (layered == nullptr) { |
diff --git a/src/core/file_sys/program_metadata.cpp b/src/core/file_sys/program_metadata.cpp index f00479bd3..763a44fee 100644 --- a/src/core/file_sys/program_metadata.cpp +++ b/src/core/file_sys/program_metadata.cpp | |||
| @@ -5,6 +5,7 @@ | |||
| 5 | #include <vector> | 5 | #include <vector> |
| 6 | 6 | ||
| 7 | #include "common/logging/log.h" | 7 | #include "common/logging/log.h" |
| 8 | #include "common/scope_exit.h" | ||
| 8 | #include "core/file_sys/program_metadata.h" | 9 | #include "core/file_sys/program_metadata.h" |
| 9 | #include "core/file_sys/vfs.h" | 10 | #include "core/file_sys/vfs.h" |
| 10 | #include "core/loader/loader.h" | 11 | #include "core/loader/loader.h" |
| @@ -95,17 +96,24 @@ Loader::ResultStatus ProgramMetadata::Load(VirtualFile file) { | |||
| 95 | return Loader::ResultStatus::Success; | 96 | return Loader::ResultStatus::Success; |
| 96 | } | 97 | } |
| 97 | 98 | ||
| 99 | Loader::ResultStatus ProgramMetadata::Reload(VirtualFile file) { | ||
| 100 | const u64 original_program_id = aci_header.title_id; | ||
| 101 | SCOPE_EXIT({ aci_header.title_id = original_program_id; }); | ||
| 102 | |||
| 103 | return this->Load(file); | ||
| 104 | } | ||
| 105 | |||
| 98 | /*static*/ ProgramMetadata ProgramMetadata::GetDefault() { | 106 | /*static*/ ProgramMetadata ProgramMetadata::GetDefault() { |
| 99 | // Allow use of cores 0~3 and thread priorities 1~63. | 107 | // Allow use of cores 0~3 and thread priorities 16~63. |
| 100 | constexpr u32 default_thread_info_capability = 0x30007F7; | 108 | constexpr u32 default_thread_info_capability = 0x30043F7; |
| 101 | 109 | ||
| 102 | ProgramMetadata result; | 110 | ProgramMetadata result; |
| 103 | 111 | ||
| 104 | result.LoadManual( | 112 | result.LoadManual( |
| 105 | true /*is_64_bit*/, FileSys::ProgramAddressSpaceType::Is39Bit /*address_space*/, | 113 | true /*is_64_bit*/, FileSys::ProgramAddressSpaceType::Is39Bit /*address_space*/, |
| 106 | 0x2c /*main_thread_prio*/, 0 /*main_thread_core*/, 0x00100000 /*main_thread_stack_size*/, | 114 | 0x2c /*main_thread_prio*/, 0 /*main_thread_core*/, 0x100000 /*main_thread_stack_size*/, |
| 107 | 0 /*title_id*/, 0xFFFFFFFFFFFFFFFF /*filesystem_permissions*/, | 115 | 0 /*title_id*/, 0xFFFFFFFFFFFFFFFF /*filesystem_permissions*/, 0 /*system_resource_size*/, |
| 108 | 0x1FE00000 /*system_resource_size*/, {default_thread_info_capability} /*capabilities*/); | 116 | {default_thread_info_capability} /*capabilities*/); |
| 109 | 117 | ||
| 110 | return result; | 118 | return result; |
| 111 | } | 119 | } |
diff --git a/src/core/file_sys/program_metadata.h b/src/core/file_sys/program_metadata.h index 2e8960b07..76ee97d78 100644 --- a/src/core/file_sys/program_metadata.h +++ b/src/core/file_sys/program_metadata.h | |||
| @@ -56,6 +56,7 @@ public: | |||
| 56 | static ProgramMetadata GetDefault(); | 56 | static ProgramMetadata GetDefault(); |
| 57 | 57 | ||
| 58 | Loader::ResultStatus Load(VirtualFile file); | 58 | Loader::ResultStatus Load(VirtualFile file); |
| 59 | Loader::ResultStatus Reload(VirtualFile file); | ||
| 59 | 60 | ||
| 60 | /// Load from parameters instead of NPDM file, used for KIP | 61 | /// Load from parameters instead of NPDM file, used for KIP |
| 61 | void LoadManual(bool is_64_bit, ProgramAddressSpaceType address_space, s32 main_thread_prio, | 62 | void LoadManual(bool is_64_bit, ProgramAddressSpaceType address_space, s32 main_thread_prio, |
| @@ -72,6 +73,9 @@ public: | |||
| 72 | u64 GetFilesystemPermissions() const; | 73 | u64 GetFilesystemPermissions() const; |
| 73 | u32 GetSystemResourceSize() const; | 74 | u32 GetSystemResourceSize() const; |
| 74 | const KernelCapabilityDescriptors& GetKernelCapabilities() const; | 75 | const KernelCapabilityDescriptors& GetKernelCapabilities() const; |
| 76 | const std::array<u8, 0x10>& GetName() const { | ||
| 77 | return npdm_header.application_name; | ||
| 78 | } | ||
| 75 | 79 | ||
| 76 | void Print() const; | 80 | void Print() const; |
| 77 | 81 | ||
| @@ -163,14 +167,14 @@ private: | |||
| 163 | u32_le unk_size_2; | 167 | u32_le unk_size_2; |
| 164 | }; | 168 | }; |
| 165 | 169 | ||
| 166 | Header npdm_header; | 170 | Header npdm_header{}; |
| 167 | AciHeader aci_header; | 171 | AciHeader aci_header{}; |
| 168 | AcidHeader acid_header; | 172 | AcidHeader acid_header{}; |
| 169 | 173 | ||
| 170 | FileAccessControl acid_file_access; | 174 | FileAccessControl acid_file_access{}; |
| 171 | FileAccessHeader aci_file_access; | 175 | FileAccessHeader aci_file_access{}; |
| 172 | 176 | ||
| 173 | KernelCapabilityDescriptors aci_kernel_capabilities; | 177 | KernelCapabilityDescriptors aci_kernel_capabilities{}; |
| 174 | }; | 178 | }; |
| 175 | 179 | ||
| 176 | } // namespace FileSys | 180 | } // namespace FileSys |
diff --git a/src/core/file_sys/registered_cache.cpp b/src/core/file_sys/registered_cache.cpp index 04da93d5c..1cc77ad14 100644 --- a/src/core/file_sys/registered_cache.cpp +++ b/src/core/file_sys/registered_cache.cpp | |||
| @@ -322,7 +322,8 @@ VirtualFile RegisteredCache::OpenFileOrDirectoryConcat(const VirtualDir& open_di | |||
| 322 | return nullptr; | 322 | return nullptr; |
| 323 | } | 323 | } |
| 324 | 324 | ||
| 325 | return ConcatenatedVfsFile::MakeConcatenatedFile(concat, concat.front()->GetName()); | 325 | auto name = concat.front()->GetName(); |
| 326 | return ConcatenatedVfsFile::MakeConcatenatedFile(std::move(name), std::move(concat)); | ||
| 326 | } | 327 | } |
| 327 | 328 | ||
| 328 | VirtualFile RegisteredCache::GetFileAtID(NcaID id) const { | 329 | VirtualFile RegisteredCache::GetFileAtID(NcaID id) const { |
diff --git a/src/core/file_sys/romfs.cpp b/src/core/file_sys/romfs.cpp index 614da2130..1c580de57 100644 --- a/src/core/file_sys/romfs.cpp +++ b/src/core/file_sys/romfs.cpp | |||
| @@ -133,7 +133,7 @@ VirtualDir ExtractRomFS(VirtualFile file, RomFSExtractionType type) { | |||
| 133 | out = out->GetSubdirectories().front(); | 133 | out = out->GetSubdirectories().front(); |
| 134 | } | 134 | } |
| 135 | 135 | ||
| 136 | return std::make_shared<CachedVfsDirectory>(out); | 136 | return std::make_shared<CachedVfsDirectory>(std::move(out)); |
| 137 | } | 137 | } |
| 138 | 138 | ||
| 139 | VirtualFile CreateRomFS(VirtualDir dir, VirtualDir ext) { | 139 | VirtualFile CreateRomFS(VirtualDir dir, VirtualDir ext) { |
| @@ -141,8 +141,7 @@ VirtualFile CreateRomFS(VirtualDir dir, VirtualDir ext) { | |||
| 141 | return nullptr; | 141 | return nullptr; |
| 142 | 142 | ||
| 143 | RomFSBuildContext ctx{dir, ext}; | 143 | RomFSBuildContext ctx{dir, ext}; |
| 144 | auto file_map = ctx.Build(); | 144 | return ConcatenatedVfsFile::MakeConcatenatedFile(0, dir->GetName(), ctx.Build()); |
| 145 | return ConcatenatedVfsFile::MakeConcatenatedFile(0, file_map, dir->GetName()); | ||
| 146 | } | 145 | } |
| 147 | 146 | ||
| 148 | } // namespace FileSys | 147 | } // namespace FileSys |
diff --git a/src/core/file_sys/system_archive/system_version.cpp b/src/core/file_sys/system_archive/system_version.cpp index bd493ecca..e4751c2b4 100644 --- a/src/core/file_sys/system_archive/system_version.cpp +++ b/src/core/file_sys/system_archive/system_version.cpp | |||
| @@ -1,6 +1,7 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2019 yuzu Emulator Project | 1 | // SPDX-FileCopyrightText: Copyright 2019 yuzu Emulator Project |
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | 2 | // SPDX-License-Identifier: GPL-2.0-or-later |
| 3 | 3 | ||
| 4 | #include "common/logging/log.h" | ||
| 4 | #include "core/file_sys/system_archive/system_version.h" | 5 | #include "core/file_sys/system_archive/system_version.h" |
| 5 | #include "core/file_sys/vfs_vector.h" | 6 | #include "core/file_sys/vfs_vector.h" |
| 6 | #include "core/hle/api_version.h" | 7 | #include "core/hle/api_version.h" |
| @@ -12,6 +13,9 @@ std::string GetLongDisplayVersion() { | |||
| 12 | } | 13 | } |
| 13 | 14 | ||
| 14 | VirtualDir SystemVersion() { | 15 | VirtualDir SystemVersion() { |
| 16 | LOG_WARNING(Common_Filesystem, "called - Using hardcoded firmware version '{}'", | ||
| 17 | GetLongDisplayVersion()); | ||
| 18 | |||
| 15 | VirtualFile file = std::make_shared<VectorVfsFile>(std::vector<u8>(0x100), "file"); | 19 | VirtualFile file = std::make_shared<VectorVfsFile>(std::vector<u8>(0x100), "file"); |
| 16 | file->WriteObject(HLE::ApiVersion::HOS_VERSION_MAJOR, 0); | 20 | file->WriteObject(HLE::ApiVersion::HOS_VERSION_MAJOR, 0); |
| 17 | file->WriteObject(HLE::ApiVersion::HOS_VERSION_MINOR, 1); | 21 | file->WriteObject(HLE::ApiVersion::HOS_VERSION_MINOR, 1); |
diff --git a/src/core/file_sys/vfs_cached.cpp b/src/core/file_sys/vfs_cached.cpp index c3154ee81..7ee5300e5 100644 --- a/src/core/file_sys/vfs_cached.cpp +++ b/src/core/file_sys/vfs_cached.cpp | |||
| @@ -6,13 +6,13 @@ | |||
| 6 | 6 | ||
| 7 | namespace FileSys { | 7 | namespace FileSys { |
| 8 | 8 | ||
| 9 | CachedVfsDirectory::CachedVfsDirectory(VirtualDir& source_dir) | 9 | CachedVfsDirectory::CachedVfsDirectory(VirtualDir&& source_dir) |
| 10 | : name(source_dir->GetName()), parent(source_dir->GetParentDirectory()) { | 10 | : name(source_dir->GetName()), parent(source_dir->GetParentDirectory()) { |
| 11 | for (auto& dir : source_dir->GetSubdirectories()) { | 11 | for (auto& dir : source_dir->GetSubdirectories()) { |
| 12 | dirs.emplace(dir->GetName(), std::make_shared<CachedVfsDirectory>(dir)); | 12 | dirs.emplace(dir->GetName(), std::make_shared<CachedVfsDirectory>(std::move(dir))); |
| 13 | } | 13 | } |
| 14 | for (auto& file : source_dir->GetFiles()) { | 14 | for (auto& file : source_dir->GetFiles()) { |
| 15 | files.emplace(file->GetName(), file); | 15 | files.emplace(file->GetName(), std::move(file)); |
| 16 | } | 16 | } |
| 17 | } | 17 | } |
| 18 | 18 | ||
diff --git a/src/core/file_sys/vfs_cached.h b/src/core/file_sys/vfs_cached.h index 113acac12..1e5300784 100644 --- a/src/core/file_sys/vfs_cached.h +++ b/src/core/file_sys/vfs_cached.h | |||
| @@ -11,7 +11,7 @@ namespace FileSys { | |||
| 11 | 11 | ||
| 12 | class CachedVfsDirectory : public ReadOnlyVfsDirectory { | 12 | class CachedVfsDirectory : public ReadOnlyVfsDirectory { |
| 13 | public: | 13 | public: |
| 14 | CachedVfsDirectory(VirtualDir& source_directory); | 14 | CachedVfsDirectory(VirtualDir&& source_directory); |
| 15 | 15 | ||
| 16 | ~CachedVfsDirectory() override; | 16 | ~CachedVfsDirectory() override; |
| 17 | VirtualFile GetFile(std::string_view file_name) const override; | 17 | VirtualFile GetFile(std::string_view file_name) const override; |
diff --git a/src/core/file_sys/vfs_concat.cpp b/src/core/file_sys/vfs_concat.cpp index 311a59e5f..168b9cbec 100644 --- a/src/core/file_sys/vfs_concat.cpp +++ b/src/core/file_sys/vfs_concat.cpp | |||
| @@ -10,7 +10,7 @@ | |||
| 10 | 10 | ||
| 11 | namespace FileSys { | 11 | namespace FileSys { |
| 12 | 12 | ||
| 13 | ConcatenatedVfsFile::ConcatenatedVfsFile(ConcatenationMap&& concatenation_map_, std::string&& name_) | 13 | ConcatenatedVfsFile::ConcatenatedVfsFile(std::string&& name_, ConcatenationMap&& concatenation_map_) |
| 14 | : concatenation_map(std::move(concatenation_map_)), name(std::move(name_)) { | 14 | : concatenation_map(std::move(concatenation_map_)), name(std::move(name_)) { |
| 15 | DEBUG_ASSERT(this->VerifyContinuity()); | 15 | DEBUG_ASSERT(this->VerifyContinuity()); |
| 16 | } | 16 | } |
| @@ -30,8 +30,8 @@ bool ConcatenatedVfsFile::VerifyContinuity() const { | |||
| 30 | 30 | ||
| 31 | ConcatenatedVfsFile::~ConcatenatedVfsFile() = default; | 31 | ConcatenatedVfsFile::~ConcatenatedVfsFile() = default; |
| 32 | 32 | ||
| 33 | VirtualFile ConcatenatedVfsFile::MakeConcatenatedFile(const std::vector<VirtualFile>& files, | 33 | VirtualFile ConcatenatedVfsFile::MakeConcatenatedFile(std::string&& name, |
| 34 | std::string&& name) { | 34 | std::vector<VirtualFile>&& files) { |
| 35 | // Fold trivial cases. | 35 | // Fold trivial cases. |
| 36 | if (files.empty()) { | 36 | if (files.empty()) { |
| 37 | return nullptr; | 37 | return nullptr; |
| @@ -46,20 +46,21 @@ VirtualFile ConcatenatedVfsFile::MakeConcatenatedFile(const std::vector<VirtualF | |||
| 46 | u64 last_offset = 0; | 46 | u64 last_offset = 0; |
| 47 | 47 | ||
| 48 | for (auto& file : files) { | 48 | for (auto& file : files) { |
| 49 | const auto size = file->GetSize(); | ||
| 50 | |||
| 49 | concatenation_map.emplace_back(ConcatenationEntry{ | 51 | concatenation_map.emplace_back(ConcatenationEntry{ |
| 50 | .offset = last_offset, | 52 | .offset = last_offset, |
| 51 | .file = file, | 53 | .file = std::move(file), |
| 52 | }); | 54 | }); |
| 53 | 55 | ||
| 54 | last_offset += file->GetSize(); | 56 | last_offset += size; |
| 55 | } | 57 | } |
| 56 | 58 | ||
| 57 | return VirtualFile(new ConcatenatedVfsFile(std::move(concatenation_map), std::move(name))); | 59 | return VirtualFile(new ConcatenatedVfsFile(std::move(name), std::move(concatenation_map))); |
| 58 | } | 60 | } |
| 59 | 61 | ||
| 60 | VirtualFile ConcatenatedVfsFile::MakeConcatenatedFile(u8 filler_byte, | 62 | VirtualFile ConcatenatedVfsFile::MakeConcatenatedFile(u8 filler_byte, std::string&& name, |
| 61 | const std::multimap<u64, VirtualFile>& files, | 63 | std::multimap<u64, VirtualFile>&& files) { |
| 62 | std::string&& name) { | ||
| 63 | // Fold trivial cases. | 64 | // Fold trivial cases. |
| 64 | if (files.empty()) { | 65 | if (files.empty()) { |
| 65 | return nullptr; | 66 | return nullptr; |
| @@ -76,6 +77,8 @@ VirtualFile ConcatenatedVfsFile::MakeConcatenatedFile(u8 filler_byte, | |||
| 76 | 77 | ||
| 77 | // Iteration of a multimap is ordered, so offset will be strictly non-decreasing. | 78 | // Iteration of a multimap is ordered, so offset will be strictly non-decreasing. |
| 78 | for (auto& [offset, file] : files) { | 79 | for (auto& [offset, file] : files) { |
| 80 | const auto size = file->GetSize(); | ||
| 81 | |||
| 79 | if (offset > last_offset) { | 82 | if (offset > last_offset) { |
| 80 | concatenation_map.emplace_back(ConcatenationEntry{ | 83 | concatenation_map.emplace_back(ConcatenationEntry{ |
| 81 | .offset = last_offset, | 84 | .offset = last_offset, |
| @@ -85,13 +88,13 @@ VirtualFile ConcatenatedVfsFile::MakeConcatenatedFile(u8 filler_byte, | |||
| 85 | 88 | ||
| 86 | concatenation_map.emplace_back(ConcatenationEntry{ | 89 | concatenation_map.emplace_back(ConcatenationEntry{ |
| 87 | .offset = offset, | 90 | .offset = offset, |
| 88 | .file = file, | 91 | .file = std::move(file), |
| 89 | }); | 92 | }); |
| 90 | 93 | ||
| 91 | last_offset = offset + file->GetSize(); | 94 | last_offset = offset + size; |
| 92 | } | 95 | } |
| 93 | 96 | ||
| 94 | return VirtualFile(new ConcatenatedVfsFile(std::move(concatenation_map), std::move(name))); | 97 | return VirtualFile(new ConcatenatedVfsFile(std::move(name), std::move(concatenation_map))); |
| 95 | } | 98 | } |
| 96 | 99 | ||
| 97 | std::string ConcatenatedVfsFile::GetName() const { | 100 | std::string ConcatenatedVfsFile::GetName() const { |
diff --git a/src/core/file_sys/vfs_concat.h b/src/core/file_sys/vfs_concat.h index 6b329d545..cbddd12bd 100644 --- a/src/core/file_sys/vfs_concat.h +++ b/src/core/file_sys/vfs_concat.h | |||
| @@ -24,22 +24,20 @@ private: | |||
| 24 | }; | 24 | }; |
| 25 | using ConcatenationMap = std::vector<ConcatenationEntry>; | 25 | using ConcatenationMap = std::vector<ConcatenationEntry>; |
| 26 | 26 | ||
| 27 | explicit ConcatenatedVfsFile(std::vector<ConcatenationEntry>&& concatenation_map, | 27 | explicit ConcatenatedVfsFile(std::string&& name, |
| 28 | std::string&& name); | 28 | std::vector<ConcatenationEntry>&& concatenation_map); |
| 29 | bool VerifyContinuity() const; | 29 | bool VerifyContinuity() const; |
| 30 | 30 | ||
| 31 | public: | 31 | public: |
| 32 | ~ConcatenatedVfsFile() override; | 32 | ~ConcatenatedVfsFile() override; |
| 33 | 33 | ||
| 34 | /// Wrapper function to allow for more efficient handling of files.size() == 0, 1 cases. | 34 | /// Wrapper function to allow for more efficient handling of files.size() == 0, 1 cases. |
| 35 | static VirtualFile MakeConcatenatedFile(const std::vector<VirtualFile>& files, | 35 | static VirtualFile MakeConcatenatedFile(std::string&& name, std::vector<VirtualFile>&& files); |
| 36 | std::string&& name); | ||
| 37 | 36 | ||
| 38 | /// Convenience function that turns a map of offsets to files into a concatenated file, filling | 37 | /// Convenience function that turns a map of offsets to files into a concatenated file, filling |
| 39 | /// gaps with a given filler byte. | 38 | /// gaps with a given filler byte. |
| 40 | static VirtualFile MakeConcatenatedFile(u8 filler_byte, | 39 | static VirtualFile MakeConcatenatedFile(u8 filler_byte, std::string&& name, |
| 41 | const std::multimap<u64, VirtualFile>& files, | 40 | std::multimap<u64, VirtualFile>&& files); |
| 42 | std::string&& name); | ||
| 43 | 41 | ||
| 44 | std::string GetName() const override; | 42 | std::string GetName() const override; |
| 45 | std::size_t GetSize() const override; | 43 | std::size_t GetSize() const override; |
diff --git a/src/core/file_sys/vfs_layered.cpp b/src/core/file_sys/vfs_layered.cpp index 3e6426afc..08daca397 100644 --- a/src/core/file_sys/vfs_layered.cpp +++ b/src/core/file_sys/vfs_layered.cpp | |||
| @@ -38,7 +38,7 @@ VirtualDir LayeredVfsDirectory::GetDirectoryRelative(std::string_view path) cons | |||
| 38 | for (const auto& layer : dirs) { | 38 | for (const auto& layer : dirs) { |
| 39 | auto dir = layer->GetDirectoryRelative(path); | 39 | auto dir = layer->GetDirectoryRelative(path); |
| 40 | if (dir != nullptr) { | 40 | if (dir != nullptr) { |
| 41 | out.push_back(std::move(dir)); | 41 | out.emplace_back(std::move(dir)); |
| 42 | } | 42 | } |
| 43 | } | 43 | } |
| 44 | 44 | ||
| @@ -62,11 +62,11 @@ std::vector<VirtualFile> LayeredVfsDirectory::GetFiles() const { | |||
| 62 | std::set<std::string, std::less<>> out_names; | 62 | std::set<std::string, std::less<>> out_names; |
| 63 | 63 | ||
| 64 | for (const auto& layer : dirs) { | 64 | for (const auto& layer : dirs) { |
| 65 | for (const auto& file : layer->GetFiles()) { | 65 | for (auto& file : layer->GetFiles()) { |
| 66 | auto file_name = file->GetName(); | 66 | auto file_name = file->GetName(); |
| 67 | if (!out_names.contains(file_name)) { | 67 | if (!out_names.contains(file_name)) { |
| 68 | out_names.emplace(std::move(file_name)); | 68 | out_names.emplace(std::move(file_name)); |
| 69 | out.push_back(file); | 69 | out.emplace_back(std::move(file)); |
| 70 | } | 70 | } |
| 71 | } | 71 | } |
| 72 | } | 72 | } |
| @@ -86,7 +86,7 @@ std::vector<VirtualDir> LayeredVfsDirectory::GetSubdirectories() const { | |||
| 86 | std::vector<VirtualDir> out; | 86 | std::vector<VirtualDir> out; |
| 87 | out.reserve(names.size()); | 87 | out.reserve(names.size()); |
| 88 | for (const auto& subdir : names) | 88 | for (const auto& subdir : names) |
| 89 | out.push_back(GetSubdirectory(subdir)); | 89 | out.emplace_back(GetSubdirectory(subdir)); |
| 90 | 90 | ||
| 91 | return out; | 91 | return out; |
| 92 | } | 92 | } |
diff --git a/src/core/hle/kernel/board/nintendo/nx/k_system_control.cpp b/src/core/hle/kernel/board/nintendo/nx/k_system_control.cpp index 4cfdf4558..59364efa1 100644 --- a/src/core/hle/kernel/board/nintendo/nx/k_system_control.cpp +++ b/src/core/hle/kernel/board/nintendo/nx/k_system_control.cpp | |||
| @@ -8,7 +8,11 @@ | |||
| 8 | 8 | ||
| 9 | #include "core/hle/kernel/board/nintendo/nx/k_system_control.h" | 9 | #include "core/hle/kernel/board/nintendo/nx/k_system_control.h" |
| 10 | #include "core/hle/kernel/board/nintendo/nx/secure_monitor.h" | 10 | #include "core/hle/kernel/board/nintendo/nx/secure_monitor.h" |
| 11 | #include "core/hle/kernel/k_memory_manager.h" | ||
| 12 | #include "core/hle/kernel/k_page_table.h" | ||
| 11 | #include "core/hle/kernel/k_trace.h" | 13 | #include "core/hle/kernel/k_trace.h" |
| 14 | #include "core/hle/kernel/kernel.h" | ||
| 15 | #include "core/hle/kernel/svc_results.h" | ||
| 12 | 16 | ||
| 13 | namespace Kernel::Board::Nintendo::Nx { | 17 | namespace Kernel::Board::Nintendo::Nx { |
| 14 | 18 | ||
| @@ -30,6 +34,8 @@ constexpr const std::size_t RequiredNonSecureSystemMemorySize = | |||
| 30 | constexpr const std::size_t RequiredNonSecureSystemMemorySizeWithFatal = | 34 | constexpr const std::size_t RequiredNonSecureSystemMemorySizeWithFatal = |
| 31 | RequiredNonSecureSystemMemorySize + impl::RequiredNonSecureSystemMemorySizeViFatal; | 35 | RequiredNonSecureSystemMemorySize + impl::RequiredNonSecureSystemMemorySizeViFatal; |
| 32 | 36 | ||
| 37 | constexpr const std::size_t SecureAlignment = 128_KiB; | ||
| 38 | |||
| 33 | namespace { | 39 | namespace { |
| 34 | 40 | ||
| 35 | using namespace Common::Literals; | 41 | using namespace Common::Literals; |
| @@ -183,4 +189,57 @@ u64 KSystemControl::GenerateRandomRange(u64 min, u64 max) { | |||
| 183 | return GenerateUniformRange(min, max, GenerateRandomU64); | 189 | return GenerateUniformRange(min, max, GenerateRandomU64); |
| 184 | } | 190 | } |
| 185 | 191 | ||
| 192 | size_t KSystemControl::CalculateRequiredSecureMemorySize(size_t size, u32 pool) { | ||
| 193 | if (pool == static_cast<u32>(KMemoryManager::Pool::Applet)) { | ||
| 194 | return 0; | ||
| 195 | } else { | ||
| 196 | // return KSystemControlBase::CalculateRequiredSecureMemorySize(size, pool); | ||
| 197 | return size; | ||
| 198 | } | ||
| 199 | } | ||
| 200 | |||
| 201 | Result KSystemControl::AllocateSecureMemory(KernelCore& kernel, KVirtualAddress* out, size_t size, | ||
| 202 | u32 pool) { | ||
| 203 | // Applet secure memory is handled separately. | ||
| 204 | UNIMPLEMENTED_IF(pool == static_cast<u32>(KMemoryManager::Pool::Applet)); | ||
| 205 | |||
| 206 | // Ensure the size is aligned. | ||
| 207 | const size_t alignment = | ||
| 208 | (pool == static_cast<u32>(KMemoryManager::Pool::System) ? PageSize : SecureAlignment); | ||
| 209 | R_UNLESS(Common::IsAligned(size, alignment), ResultInvalidSize); | ||
| 210 | |||
| 211 | // Allocate the memory. | ||
| 212 | const size_t num_pages = size / PageSize; | ||
| 213 | const KPhysicalAddress paddr = kernel.MemoryManager().AllocateAndOpenContinuous( | ||
| 214 | num_pages, alignment / PageSize, | ||
| 215 | KMemoryManager::EncodeOption(static_cast<KMemoryManager::Pool>(pool), | ||
| 216 | KMemoryManager::Direction::FromFront)); | ||
| 217 | R_UNLESS(paddr != 0, ResultOutOfMemory); | ||
| 218 | |||
| 219 | // Ensure we don't leak references to the memory on error. | ||
| 220 | ON_RESULT_FAILURE { | ||
| 221 | kernel.MemoryManager().Close(paddr, num_pages); | ||
| 222 | }; | ||
| 223 | |||
| 224 | // We succeeded. | ||
| 225 | *out = KPageTable::GetHeapVirtualAddress(kernel.MemoryLayout(), paddr); | ||
| 226 | R_SUCCEED(); | ||
| 227 | } | ||
| 228 | |||
| 229 | void KSystemControl::FreeSecureMemory(KernelCore& kernel, KVirtualAddress address, size_t size, | ||
| 230 | u32 pool) { | ||
| 231 | // Applet secure memory is handled separately. | ||
| 232 | UNIMPLEMENTED_IF(pool == static_cast<u32>(KMemoryManager::Pool::Applet)); | ||
| 233 | |||
| 234 | // Ensure the size is aligned. | ||
| 235 | const size_t alignment = | ||
| 236 | (pool == static_cast<u32>(KMemoryManager::Pool::System) ? PageSize : SecureAlignment); | ||
| 237 | ASSERT(Common::IsAligned(GetInteger(address), alignment)); | ||
| 238 | ASSERT(Common::IsAligned(size, alignment)); | ||
| 239 | |||
| 240 | // Close the secure region's pages. | ||
| 241 | kernel.MemoryManager().Close(KPageTable::GetHeapPhysicalAddress(kernel.MemoryLayout(), address), | ||
| 242 | size / PageSize); | ||
| 243 | } | ||
| 244 | |||
| 186 | } // namespace Kernel::Board::Nintendo::Nx | 245 | } // namespace Kernel::Board::Nintendo::Nx |
diff --git a/src/core/hle/kernel/board/nintendo/nx/k_system_control.h b/src/core/hle/kernel/board/nintendo/nx/k_system_control.h index b477e8193..ff1feec70 100644 --- a/src/core/hle/kernel/board/nintendo/nx/k_system_control.h +++ b/src/core/hle/kernel/board/nintendo/nx/k_system_control.h | |||
| @@ -4,6 +4,11 @@ | |||
| 4 | #pragma once | 4 | #pragma once |
| 5 | 5 | ||
| 6 | #include "core/hle/kernel/k_typed_address.h" | 6 | #include "core/hle/kernel/k_typed_address.h" |
| 7 | #include "core/hle/result.h" | ||
| 8 | |||
| 9 | namespace Kernel { | ||
| 10 | class KernelCore; | ||
| 11 | } | ||
| 7 | 12 | ||
| 8 | namespace Kernel::Board::Nintendo::Nx { | 13 | namespace Kernel::Board::Nintendo::Nx { |
| 9 | 14 | ||
| @@ -25,8 +30,16 @@ public: | |||
| 25 | static std::size_t GetMinimumNonSecureSystemPoolSize(); | 30 | static std::size_t GetMinimumNonSecureSystemPoolSize(); |
| 26 | }; | 31 | }; |
| 27 | 32 | ||
| 33 | // Randomness. | ||
| 28 | static u64 GenerateRandomRange(u64 min, u64 max); | 34 | static u64 GenerateRandomRange(u64 min, u64 max); |
| 29 | static u64 GenerateRandomU64(); | 35 | static u64 GenerateRandomU64(); |
| 36 | |||
| 37 | // Secure Memory. | ||
| 38 | static size_t CalculateRequiredSecureMemorySize(size_t size, u32 pool); | ||
| 39 | static Result AllocateSecureMemory(KernelCore& kernel, KVirtualAddress* out, size_t size, | ||
| 40 | u32 pool); | ||
| 41 | static void FreeSecureMemory(KernelCore& kernel, KVirtualAddress address, size_t size, | ||
| 42 | u32 pool); | ||
| 30 | }; | 43 | }; |
| 31 | 44 | ||
| 32 | } // namespace Kernel::Board::Nintendo::Nx | 45 | } // namespace Kernel::Board::Nintendo::Nx |
diff --git a/src/core/hle/kernel/init/init_slab_setup.cpp b/src/core/hle/kernel/init/init_slab_setup.cpp index 1f2db673c..a0e20bbbb 100644 --- a/src/core/hle/kernel/init/init_slab_setup.cpp +++ b/src/core/hle/kernel/init/init_slab_setup.cpp | |||
| @@ -106,7 +106,7 @@ static_assert(KernelPageBufferAdditionalSize == | |||
| 106 | /// memory. | 106 | /// memory. |
| 107 | static KPhysicalAddress TranslateSlabAddrToPhysical(KMemoryLayout& memory_layout, | 107 | static KPhysicalAddress TranslateSlabAddrToPhysical(KMemoryLayout& memory_layout, |
| 108 | KVirtualAddress slab_addr) { | 108 | KVirtualAddress slab_addr) { |
| 109 | slab_addr -= GetInteger(memory_layout.GetSlabRegionAddress()); | 109 | slab_addr -= memory_layout.GetSlabRegion().GetAddress(); |
| 110 | return GetInteger(slab_addr) + Core::DramMemoryMap::SlabHeapBase; | 110 | return GetInteger(slab_addr) + Core::DramMemoryMap::SlabHeapBase; |
| 111 | } | 111 | } |
| 112 | 112 | ||
| @@ -196,7 +196,12 @@ void InitializeSlabHeaps(Core::System& system, KMemoryLayout& memory_layout) { | |||
| 196 | auto& kernel = system.Kernel(); | 196 | auto& kernel = system.Kernel(); |
| 197 | 197 | ||
| 198 | // Get the start of the slab region, since that's where we'll be working. | 198 | // Get the start of the slab region, since that's where we'll be working. |
| 199 | KVirtualAddress address = memory_layout.GetSlabRegionAddress(); | 199 | const KMemoryRegion& slab_region = memory_layout.GetSlabRegion(); |
| 200 | KVirtualAddress address = slab_region.GetAddress(); | ||
| 201 | |||
| 202 | // Clear the slab region. | ||
| 203 | // TODO: implement access to kernel VAs. | ||
| 204 | // std::memset(device_ptr, 0, slab_region.GetSize()); | ||
| 200 | 205 | ||
| 201 | // Initialize slab type array to be in sorted order. | 206 | // Initialize slab type array to be in sorted order. |
| 202 | std::array<KSlabType, KSlabType_Count> slab_types; | 207 | std::array<KSlabType, KSlabType_Count> slab_types; |
diff --git a/src/core/hle/kernel/initial_process.h b/src/core/hle/kernel/initial_process.h index 82195f4f7..2c95269fc 100644 --- a/src/core/hle/kernel/initial_process.h +++ b/src/core/hle/kernel/initial_process.h | |||
| @@ -19,4 +19,8 @@ static inline KPhysicalAddress GetInitialProcessBinaryPhysicalAddress() { | |||
| 19 | MainMemoryAddress); | 19 | MainMemoryAddress); |
| 20 | } | 20 | } |
| 21 | 21 | ||
| 22 | static inline size_t GetInitialProcessBinarySize() { | ||
| 23 | return InitialProcessBinarySizeMax; | ||
| 24 | } | ||
| 25 | |||
| 22 | } // namespace Kernel | 26 | } // namespace Kernel |
diff --git a/src/core/hle/kernel/k_capabilities.h b/src/core/hle/kernel/k_capabilities.h index de766c811..ebd4eedb1 100644 --- a/src/core/hle/kernel/k_capabilities.h +++ b/src/core/hle/kernel/k_capabilities.h | |||
| @@ -200,8 +200,8 @@ private: | |||
| 200 | 200 | ||
| 201 | RawCapabilityValue raw; | 201 | RawCapabilityValue raw; |
| 202 | BitField<0, 15, CapabilityType> id; | 202 | BitField<0, 15, CapabilityType> id; |
| 203 | BitField<15, 4, u32> major_version; | 203 | BitField<15, 4, u32> minor_version; |
| 204 | BitField<19, 13, u32> minor_version; | 204 | BitField<19, 13, u32> major_version; |
| 205 | }; | 205 | }; |
| 206 | 206 | ||
| 207 | union HandleTable { | 207 | union HandleTable { |
diff --git a/src/core/hle/kernel/k_condition_variable.cpp b/src/core/hle/kernel/k_condition_variable.cpp index efbac0e6a..7633a51fb 100644 --- a/src/core/hle/kernel/k_condition_variable.cpp +++ b/src/core/hle/kernel/k_condition_variable.cpp | |||
| @@ -107,12 +107,12 @@ KConditionVariable::KConditionVariable(Core::System& system) | |||
| 107 | 107 | ||
| 108 | KConditionVariable::~KConditionVariable() = default; | 108 | KConditionVariable::~KConditionVariable() = default; |
| 109 | 109 | ||
| 110 | Result KConditionVariable::SignalToAddress(KProcessAddress addr) { | 110 | Result KConditionVariable::SignalToAddress(KernelCore& kernel, KProcessAddress addr) { |
| 111 | KThread* owner_thread = GetCurrentThreadPointer(m_kernel); | 111 | KThread* owner_thread = GetCurrentThreadPointer(kernel); |
| 112 | 112 | ||
| 113 | // Signal the address. | 113 | // Signal the address. |
| 114 | { | 114 | { |
| 115 | KScopedSchedulerLock sl(m_kernel); | 115 | KScopedSchedulerLock sl(kernel); |
| 116 | 116 | ||
| 117 | // Remove waiter thread. | 117 | // Remove waiter thread. |
| 118 | bool has_waiters{}; | 118 | bool has_waiters{}; |
| @@ -133,7 +133,7 @@ Result KConditionVariable::SignalToAddress(KProcessAddress addr) { | |||
| 133 | 133 | ||
| 134 | // Write the value to userspace. | 134 | // Write the value to userspace. |
| 135 | Result result{ResultSuccess}; | 135 | Result result{ResultSuccess}; |
| 136 | if (WriteToUser(m_kernel, addr, std::addressof(next_value))) [[likely]] { | 136 | if (WriteToUser(kernel, addr, std::addressof(next_value))) [[likely]] { |
| 137 | result = ResultSuccess; | 137 | result = ResultSuccess; |
| 138 | } else { | 138 | } else { |
| 139 | result = ResultInvalidCurrentMemory; | 139 | result = ResultInvalidCurrentMemory; |
| @@ -148,28 +148,28 @@ Result KConditionVariable::SignalToAddress(KProcessAddress addr) { | |||
| 148 | } | 148 | } |
| 149 | } | 149 | } |
| 150 | 150 | ||
| 151 | Result KConditionVariable::WaitForAddress(Handle handle, KProcessAddress addr, u32 value) { | 151 | Result KConditionVariable::WaitForAddress(KernelCore& kernel, Handle handle, KProcessAddress addr, |
| 152 | KThread* cur_thread = GetCurrentThreadPointer(m_kernel); | 152 | u32 value) { |
| 153 | ThreadQueueImplForKConditionVariableWaitForAddress wait_queue(m_kernel); | 153 | KThread* cur_thread = GetCurrentThreadPointer(kernel); |
| 154 | ThreadQueueImplForKConditionVariableWaitForAddress wait_queue(kernel); | ||
| 154 | 155 | ||
| 155 | // Wait for the address. | 156 | // Wait for the address. |
| 156 | KThread* owner_thread{}; | 157 | KThread* owner_thread{}; |
| 157 | { | 158 | { |
| 158 | KScopedSchedulerLock sl(m_kernel); | 159 | KScopedSchedulerLock sl(kernel); |
| 159 | 160 | ||
| 160 | // Check if the thread should terminate. | 161 | // Check if the thread should terminate. |
| 161 | R_UNLESS(!cur_thread->IsTerminationRequested(), ResultTerminationRequested); | 162 | R_UNLESS(!cur_thread->IsTerminationRequested(), ResultTerminationRequested); |
| 162 | 163 | ||
| 163 | // Read the tag from userspace. | 164 | // Read the tag from userspace. |
| 164 | u32 test_tag{}; | 165 | u32 test_tag{}; |
| 165 | R_UNLESS(ReadFromUser(m_kernel, std::addressof(test_tag), addr), | 166 | R_UNLESS(ReadFromUser(kernel, std::addressof(test_tag), addr), ResultInvalidCurrentMemory); |
| 166 | ResultInvalidCurrentMemory); | ||
| 167 | 167 | ||
| 168 | // If the tag isn't the handle (with wait mask), we're done. | 168 | // If the tag isn't the handle (with wait mask), we're done. |
| 169 | R_SUCCEED_IF(test_tag != (handle | Svc::HandleWaitMask)); | 169 | R_SUCCEED_IF(test_tag != (handle | Svc::HandleWaitMask)); |
| 170 | 170 | ||
| 171 | // Get the lock owner thread. | 171 | // Get the lock owner thread. |
| 172 | owner_thread = GetCurrentProcess(m_kernel) | 172 | owner_thread = GetCurrentProcess(kernel) |
| 173 | .GetHandleTable() | 173 | .GetHandleTable() |
| 174 | .GetObjectWithoutPseudoHandle<KThread>(handle) | 174 | .GetObjectWithoutPseudoHandle<KThread>(handle) |
| 175 | .ReleasePointerUnsafe(); | 175 | .ReleasePointerUnsafe(); |
diff --git a/src/core/hle/kernel/k_condition_variable.h b/src/core/hle/kernel/k_condition_variable.h index 8c2f3ae51..2620c8e39 100644 --- a/src/core/hle/kernel/k_condition_variable.h +++ b/src/core/hle/kernel/k_condition_variable.h | |||
| @@ -24,11 +24,12 @@ public: | |||
| 24 | explicit KConditionVariable(Core::System& system); | 24 | explicit KConditionVariable(Core::System& system); |
| 25 | ~KConditionVariable(); | 25 | ~KConditionVariable(); |
| 26 | 26 | ||
| 27 | // Arbitration | 27 | // Arbitration. |
| 28 | Result SignalToAddress(KProcessAddress addr); | 28 | static Result SignalToAddress(KernelCore& kernel, KProcessAddress addr); |
| 29 | Result WaitForAddress(Handle handle, KProcessAddress addr, u32 value); | 29 | static Result WaitForAddress(KernelCore& kernel, Handle handle, KProcessAddress addr, |
| 30 | u32 value); | ||
| 30 | 31 | ||
| 31 | // Condition variable | 32 | // Condition variable. |
| 32 | void Signal(u64 cv_key, s32 count); | 33 | void Signal(u64 cv_key, s32 count); |
| 33 | Result Wait(KProcessAddress addr, u64 key, u32 value, s64 timeout); | 34 | Result Wait(KProcessAddress addr, u64 key, u32 value, s64 timeout); |
| 34 | 35 | ||
diff --git a/src/core/hle/kernel/k_interrupt_manager.cpp b/src/core/hle/kernel/k_interrupt_manager.cpp index fe6a20168..22d79569a 100644 --- a/src/core/hle/kernel/k_interrupt_manager.cpp +++ b/src/core/hle/kernel/k_interrupt_manager.cpp | |||
| @@ -22,7 +22,7 @@ void HandleInterrupt(KernelCore& kernel, s32 core_id) { | |||
| 22 | KScopedSchedulerLock sl{kernel}; | 22 | KScopedSchedulerLock sl{kernel}; |
| 23 | 23 | ||
| 24 | // Pin the current thread. | 24 | // Pin the current thread. |
| 25 | process->PinCurrentThread(core_id); | 25 | process->PinCurrentThread(); |
| 26 | 26 | ||
| 27 | // Set the interrupt flag for the thread. | 27 | // Set the interrupt flag for the thread. |
| 28 | GetCurrentThread(kernel).SetInterruptFlag(); | 28 | GetCurrentThread(kernel).SetInterruptFlag(); |
diff --git a/src/core/hle/kernel/k_memory_block.h b/src/core/hle/kernel/k_memory_block.h index 41a29da24..ef3f61321 100644 --- a/src/core/hle/kernel/k_memory_block.h +++ b/src/core/hle/kernel/k_memory_block.h | |||
| @@ -36,6 +36,7 @@ enum class KMemoryState : u32 { | |||
| 36 | FlagCanChangeAttribute = (1 << 24), | 36 | FlagCanChangeAttribute = (1 << 24), |
| 37 | FlagCanCodeMemory = (1 << 25), | 37 | FlagCanCodeMemory = (1 << 25), |
| 38 | FlagLinearMapped = (1 << 26), | 38 | FlagLinearMapped = (1 << 26), |
| 39 | FlagCanPermissionLock = (1 << 27), | ||
| 39 | 40 | ||
| 40 | FlagsData = FlagCanReprotect | FlagCanUseIpc | FlagCanUseNonDeviceIpc | FlagCanUseNonSecureIpc | | 41 | FlagsData = FlagCanReprotect | FlagCanUseIpc | FlagCanUseNonDeviceIpc | FlagCanUseNonSecureIpc | |
| 41 | FlagMapped | FlagCanAlias | FlagCanTransfer | FlagCanQueryPhysical | | 42 | FlagMapped | FlagCanAlias | FlagCanTransfer | FlagCanQueryPhysical | |
| @@ -50,12 +51,16 @@ enum class KMemoryState : u32 { | |||
| 50 | FlagLinearMapped, | 51 | FlagLinearMapped, |
| 51 | 52 | ||
| 52 | Free = static_cast<u32>(Svc::MemoryState::Free), | 53 | Free = static_cast<u32>(Svc::MemoryState::Free), |
| 53 | Io = static_cast<u32>(Svc::MemoryState::Io) | FlagMapped | FlagCanDeviceMap | | 54 | |
| 54 | FlagCanAlignedDeviceMap, | 55 | IoMemory = static_cast<u32>(Svc::MemoryState::Io) | FlagMapped | FlagCanDeviceMap | |
| 56 | FlagCanAlignedDeviceMap, | ||
| 57 | IoRegister = | ||
| 58 | static_cast<u32>(Svc::MemoryState::Io) | FlagCanDeviceMap | FlagCanAlignedDeviceMap, | ||
| 59 | |||
| 55 | Static = static_cast<u32>(Svc::MemoryState::Static) | FlagMapped | FlagCanQueryPhysical, | 60 | Static = static_cast<u32>(Svc::MemoryState::Static) | FlagMapped | FlagCanQueryPhysical, |
| 56 | Code = static_cast<u32>(Svc::MemoryState::Code) | FlagsCode | FlagCanMapProcess, | 61 | Code = static_cast<u32>(Svc::MemoryState::Code) | FlagsCode | FlagCanMapProcess, |
| 57 | CodeData = static_cast<u32>(Svc::MemoryState::CodeData) | FlagsData | FlagCanMapProcess | | 62 | CodeData = static_cast<u32>(Svc::MemoryState::CodeData) | FlagsData | FlagCanMapProcess | |
| 58 | FlagCanCodeMemory, | 63 | FlagCanCodeMemory | FlagCanPermissionLock, |
| 59 | Normal = static_cast<u32>(Svc::MemoryState::Normal) | FlagsData | FlagCanCodeMemory, | 64 | Normal = static_cast<u32>(Svc::MemoryState::Normal) | FlagsData | FlagCanCodeMemory, |
| 60 | Shared = static_cast<u32>(Svc::MemoryState::Shared) | FlagMapped | FlagReferenceCounted | | 65 | Shared = static_cast<u32>(Svc::MemoryState::Shared) | FlagMapped | FlagReferenceCounted | |
| 61 | FlagLinearMapped, | 66 | FlagLinearMapped, |
| @@ -65,7 +70,8 @@ enum class KMemoryState : u32 { | |||
| 65 | AliasCode = static_cast<u32>(Svc::MemoryState::AliasCode) | FlagsCode | FlagCanMapProcess | | 70 | AliasCode = static_cast<u32>(Svc::MemoryState::AliasCode) | FlagsCode | FlagCanMapProcess | |
| 66 | FlagCanCodeAlias, | 71 | FlagCanCodeAlias, |
| 67 | AliasCodeData = static_cast<u32>(Svc::MemoryState::AliasCodeData) | FlagsData | | 72 | AliasCodeData = static_cast<u32>(Svc::MemoryState::AliasCodeData) | FlagsData | |
| 68 | FlagCanMapProcess | FlagCanCodeAlias | FlagCanCodeMemory, | 73 | FlagCanMapProcess | FlagCanCodeAlias | FlagCanCodeMemory | |
| 74 | FlagCanPermissionLock, | ||
| 69 | 75 | ||
| 70 | Ipc = static_cast<u32>(Svc::MemoryState::Ipc) | FlagsMisc | FlagCanAlignedDeviceMap | | 76 | Ipc = static_cast<u32>(Svc::MemoryState::Ipc) | FlagsMisc | FlagCanAlignedDeviceMap | |
| 71 | FlagCanUseIpc | FlagCanUseNonSecureIpc | FlagCanUseNonDeviceIpc, | 77 | FlagCanUseIpc | FlagCanUseNonSecureIpc | FlagCanUseNonDeviceIpc, |
| @@ -73,7 +79,7 @@ enum class KMemoryState : u32 { | |||
| 73 | Stack = static_cast<u32>(Svc::MemoryState::Stack) | FlagsMisc | FlagCanAlignedDeviceMap | | 79 | Stack = static_cast<u32>(Svc::MemoryState::Stack) | FlagsMisc | FlagCanAlignedDeviceMap | |
| 74 | FlagCanUseIpc | FlagCanUseNonSecureIpc | FlagCanUseNonDeviceIpc, | 80 | FlagCanUseIpc | FlagCanUseNonSecureIpc | FlagCanUseNonDeviceIpc, |
| 75 | 81 | ||
| 76 | ThreadLocal = static_cast<u32>(Svc::MemoryState::ThreadLocal) | FlagMapped | FlagLinearMapped, | 82 | ThreadLocal = static_cast<u32>(Svc::MemoryState::ThreadLocal) | FlagLinearMapped, |
| 77 | 83 | ||
| 78 | Transfered = static_cast<u32>(Svc::MemoryState::Transfered) | FlagsMisc | | 84 | Transfered = static_cast<u32>(Svc::MemoryState::Transfered) | FlagsMisc | |
| 79 | FlagCanAlignedDeviceMap | FlagCanChangeAttribute | FlagCanUseIpc | | 85 | FlagCanAlignedDeviceMap | FlagCanChangeAttribute | FlagCanUseIpc | |
| @@ -94,7 +100,7 @@ enum class KMemoryState : u32 { | |||
| 94 | NonDeviceIpc = | 100 | NonDeviceIpc = |
| 95 | static_cast<u32>(Svc::MemoryState::NonDeviceIpc) | FlagsMisc | FlagCanUseNonDeviceIpc, | 101 | static_cast<u32>(Svc::MemoryState::NonDeviceIpc) | FlagsMisc | FlagCanUseNonDeviceIpc, |
| 96 | 102 | ||
| 97 | Kernel = static_cast<u32>(Svc::MemoryState::Kernel) | FlagMapped, | 103 | Kernel = static_cast<u32>(Svc::MemoryState::Kernel), |
| 98 | 104 | ||
| 99 | GeneratedCode = static_cast<u32>(Svc::MemoryState::GeneratedCode) | FlagMapped | | 105 | GeneratedCode = static_cast<u32>(Svc::MemoryState::GeneratedCode) | FlagMapped | |
| 100 | FlagReferenceCounted | FlagCanDebug | FlagLinearMapped, | 106 | FlagReferenceCounted | FlagCanDebug | FlagLinearMapped, |
| @@ -105,34 +111,36 @@ enum class KMemoryState : u32 { | |||
| 105 | 111 | ||
| 106 | Insecure = static_cast<u32>(Svc::MemoryState::Insecure) | FlagMapped | FlagReferenceCounted | | 112 | Insecure = static_cast<u32>(Svc::MemoryState::Insecure) | FlagMapped | FlagReferenceCounted | |
| 107 | FlagLinearMapped | FlagCanChangeAttribute | FlagCanDeviceMap | | 113 | FlagLinearMapped | FlagCanChangeAttribute | FlagCanDeviceMap | |
| 108 | FlagCanAlignedDeviceMap | FlagCanUseNonSecureIpc | FlagCanUseNonDeviceIpc, | 114 | FlagCanAlignedDeviceMap | FlagCanQueryPhysical | FlagCanUseNonSecureIpc | |
| 115 | FlagCanUseNonDeviceIpc, | ||
| 109 | }; | 116 | }; |
| 110 | DECLARE_ENUM_FLAG_OPERATORS(KMemoryState); | 117 | DECLARE_ENUM_FLAG_OPERATORS(KMemoryState); |
| 111 | 118 | ||
| 112 | static_assert(static_cast<u32>(KMemoryState::Free) == 0x00000000); | 119 | static_assert(static_cast<u32>(KMemoryState::Free) == 0x00000000); |
| 113 | static_assert(static_cast<u32>(KMemoryState::Io) == 0x00182001); | 120 | static_assert(static_cast<u32>(KMemoryState::IoMemory) == 0x00182001); |
| 121 | static_assert(static_cast<u32>(KMemoryState::IoRegister) == 0x00180001); | ||
| 114 | static_assert(static_cast<u32>(KMemoryState::Static) == 0x00042002); | 122 | static_assert(static_cast<u32>(KMemoryState::Static) == 0x00042002); |
| 115 | static_assert(static_cast<u32>(KMemoryState::Code) == 0x04DC7E03); | 123 | static_assert(static_cast<u32>(KMemoryState::Code) == 0x04DC7E03); |
| 116 | static_assert(static_cast<u32>(KMemoryState::CodeData) == 0x07FEBD04); | 124 | static_assert(static_cast<u32>(KMemoryState::CodeData) == 0x0FFEBD04); |
| 117 | static_assert(static_cast<u32>(KMemoryState::Normal) == 0x077EBD05); | 125 | static_assert(static_cast<u32>(KMemoryState::Normal) == 0x077EBD05); |
| 118 | static_assert(static_cast<u32>(KMemoryState::Shared) == 0x04402006); | 126 | static_assert(static_cast<u32>(KMemoryState::Shared) == 0x04402006); |
| 119 | 127 | ||
| 120 | static_assert(static_cast<u32>(KMemoryState::AliasCode) == 0x04DD7E08); | 128 | static_assert(static_cast<u32>(KMemoryState::AliasCode) == 0x04DD7E08); |
| 121 | static_assert(static_cast<u32>(KMemoryState::AliasCodeData) == 0x07FFBD09); | 129 | static_assert(static_cast<u32>(KMemoryState::AliasCodeData) == 0x0FFFBD09); |
| 122 | static_assert(static_cast<u32>(KMemoryState::Ipc) == 0x045C3C0A); | 130 | static_assert(static_cast<u32>(KMemoryState::Ipc) == 0x045C3C0A); |
| 123 | static_assert(static_cast<u32>(KMemoryState::Stack) == 0x045C3C0B); | 131 | static_assert(static_cast<u32>(KMemoryState::Stack) == 0x045C3C0B); |
| 124 | static_assert(static_cast<u32>(KMemoryState::ThreadLocal) == 0x0400200C); | 132 | static_assert(static_cast<u32>(KMemoryState::ThreadLocal) == 0x0400000C); |
| 125 | static_assert(static_cast<u32>(KMemoryState::Transfered) == 0x055C3C0D); | 133 | static_assert(static_cast<u32>(KMemoryState::Transfered) == 0x055C3C0D); |
| 126 | static_assert(static_cast<u32>(KMemoryState::SharedTransfered) == 0x045C380E); | 134 | static_assert(static_cast<u32>(KMemoryState::SharedTransfered) == 0x045C380E); |
| 127 | static_assert(static_cast<u32>(KMemoryState::SharedCode) == 0x0440380F); | 135 | static_assert(static_cast<u32>(KMemoryState::SharedCode) == 0x0440380F); |
| 128 | static_assert(static_cast<u32>(KMemoryState::Inaccessible) == 0x00000010); | 136 | static_assert(static_cast<u32>(KMemoryState::Inaccessible) == 0x00000010); |
| 129 | static_assert(static_cast<u32>(KMemoryState::NonSecureIpc) == 0x045C3811); | 137 | static_assert(static_cast<u32>(KMemoryState::NonSecureIpc) == 0x045C3811); |
| 130 | static_assert(static_cast<u32>(KMemoryState::NonDeviceIpc) == 0x044C2812); | 138 | static_assert(static_cast<u32>(KMemoryState::NonDeviceIpc) == 0x044C2812); |
| 131 | static_assert(static_cast<u32>(KMemoryState::Kernel) == 0x00002013); | 139 | static_assert(static_cast<u32>(KMemoryState::Kernel) == 0x00000013); |
| 132 | static_assert(static_cast<u32>(KMemoryState::GeneratedCode) == 0x04402214); | 140 | static_assert(static_cast<u32>(KMemoryState::GeneratedCode) == 0x04402214); |
| 133 | static_assert(static_cast<u32>(KMemoryState::CodeOut) == 0x04402015); | 141 | static_assert(static_cast<u32>(KMemoryState::CodeOut) == 0x04402015); |
| 134 | static_assert(static_cast<u32>(KMemoryState::Coverage) == 0x00002016); | 142 | static_assert(static_cast<u32>(KMemoryState::Coverage) == 0x00002016); |
| 135 | static_assert(static_cast<u32>(KMemoryState::Insecure) == 0x05583817); | 143 | static_assert(static_cast<u32>(KMemoryState::Insecure) == 0x055C3817); |
| 136 | 144 | ||
| 137 | enum class KMemoryPermission : u8 { | 145 | enum class KMemoryPermission : u8 { |
| 138 | None = 0, | 146 | None = 0, |
| @@ -182,8 +190,9 @@ enum class KMemoryAttribute : u8 { | |||
| 182 | IpcLocked = static_cast<u8>(Svc::MemoryAttribute::IpcLocked), | 190 | IpcLocked = static_cast<u8>(Svc::MemoryAttribute::IpcLocked), |
| 183 | DeviceShared = static_cast<u8>(Svc::MemoryAttribute::DeviceShared), | 191 | DeviceShared = static_cast<u8>(Svc::MemoryAttribute::DeviceShared), |
| 184 | Uncached = static_cast<u8>(Svc::MemoryAttribute::Uncached), | 192 | Uncached = static_cast<u8>(Svc::MemoryAttribute::Uncached), |
| 193 | PermissionLocked = static_cast<u8>(Svc::MemoryAttribute::PermissionLocked), | ||
| 185 | 194 | ||
| 186 | SetMask = Uncached, | 195 | SetMask = Uncached | PermissionLocked, |
| 187 | }; | 196 | }; |
| 188 | DECLARE_ENUM_FLAG_OPERATORS(KMemoryAttribute); | 197 | DECLARE_ENUM_FLAG_OPERATORS(KMemoryAttribute); |
| 189 | 198 | ||
| @@ -261,6 +270,10 @@ struct KMemoryInfo { | |||
| 261 | return m_state; | 270 | return m_state; |
| 262 | } | 271 | } |
| 263 | 272 | ||
| 273 | constexpr Svc::MemoryState GetSvcState() const { | ||
| 274 | return static_cast<Svc::MemoryState>(m_state & KMemoryState::Mask); | ||
| 275 | } | ||
| 276 | |||
| 264 | constexpr KMemoryPermission GetPermission() const { | 277 | constexpr KMemoryPermission GetPermission() const { |
| 265 | return m_permission; | 278 | return m_permission; |
| 266 | } | 279 | } |
| @@ -326,6 +339,10 @@ public: | |||
| 326 | return this->GetEndAddress() - 1; | 339 | return this->GetEndAddress() - 1; |
| 327 | } | 340 | } |
| 328 | 341 | ||
| 342 | constexpr KMemoryState GetState() const { | ||
| 343 | return m_memory_state; | ||
| 344 | } | ||
| 345 | |||
| 329 | constexpr u16 GetIpcLockCount() const { | 346 | constexpr u16 GetIpcLockCount() const { |
| 330 | return m_ipc_lock_count; | 347 | return m_ipc_lock_count; |
| 331 | } | 348 | } |
| @@ -443,6 +460,13 @@ public: | |||
| 443 | } | 460 | } |
| 444 | } | 461 | } |
| 445 | 462 | ||
| 463 | constexpr void UpdateAttribute(KMemoryAttribute mask, KMemoryAttribute attr) { | ||
| 464 | ASSERT(False(mask & KMemoryAttribute::IpcLocked)); | ||
| 465 | ASSERT(False(mask & KMemoryAttribute::DeviceShared)); | ||
| 466 | |||
| 467 | m_attribute = (m_attribute & ~mask) | attr; | ||
| 468 | } | ||
| 469 | |||
| 446 | constexpr void Split(KMemoryBlock* block, KProcessAddress addr) { | 470 | constexpr void Split(KMemoryBlock* block, KProcessAddress addr) { |
| 447 | ASSERT(this->GetAddress() < addr); | 471 | ASSERT(this->GetAddress() < addr); |
| 448 | ASSERT(this->Contains(addr)); | 472 | ASSERT(this->Contains(addr)); |
diff --git a/src/core/hle/kernel/k_memory_block_manager.cpp b/src/core/hle/kernel/k_memory_block_manager.cpp index ab75f550e..58a1e7216 100644 --- a/src/core/hle/kernel/k_memory_block_manager.cpp +++ b/src/core/hle/kernel/k_memory_block_manager.cpp | |||
| @@ -160,8 +160,8 @@ void KMemoryBlockManager::Update(KMemoryBlockManagerUpdateAllocator* allocator, | |||
| 160 | } | 160 | } |
| 161 | 161 | ||
| 162 | // Update block state. | 162 | // Update block state. |
| 163 | it->Update(state, perm, attr, cur_address == address, static_cast<u8>(set_disable_attr), | 163 | it->Update(state, perm, attr, it->GetAddress() == address, |
| 164 | static_cast<u8>(clear_disable_attr)); | 164 | static_cast<u8>(set_disable_attr), static_cast<u8>(clear_disable_attr)); |
| 165 | cur_address += cur_info.GetSize(); | 165 | cur_address += cur_info.GetSize(); |
| 166 | remaining_pages -= cur_info.GetNumPages(); | 166 | remaining_pages -= cur_info.GetNumPages(); |
| 167 | } | 167 | } |
| @@ -175,7 +175,9 @@ void KMemoryBlockManager::UpdateIfMatch(KMemoryBlockManagerUpdateAllocator* allo | |||
| 175 | KProcessAddress address, size_t num_pages, | 175 | KProcessAddress address, size_t num_pages, |
| 176 | KMemoryState test_state, KMemoryPermission test_perm, | 176 | KMemoryState test_state, KMemoryPermission test_perm, |
| 177 | KMemoryAttribute test_attr, KMemoryState state, | 177 | KMemoryAttribute test_attr, KMemoryState state, |
| 178 | KMemoryPermission perm, KMemoryAttribute attr) { | 178 | KMemoryPermission perm, KMemoryAttribute attr, |
| 179 | KMemoryBlockDisableMergeAttribute set_disable_attr, | ||
| 180 | KMemoryBlockDisableMergeAttribute clear_disable_attr) { | ||
| 179 | // Ensure for auditing that we never end up with an invalid tree. | 181 | // Ensure for auditing that we never end up with an invalid tree. |
| 180 | KScopedMemoryBlockManagerAuditor auditor(this); | 182 | KScopedMemoryBlockManagerAuditor auditor(this); |
| 181 | ASSERT(Common::IsAligned(GetInteger(address), PageSize)); | 183 | ASSERT(Common::IsAligned(GetInteger(address), PageSize)); |
| @@ -214,7 +216,8 @@ void KMemoryBlockManager::UpdateIfMatch(KMemoryBlockManagerUpdateAllocator* allo | |||
| 214 | } | 216 | } |
| 215 | 217 | ||
| 216 | // Update block state. | 218 | // Update block state. |
| 217 | it->Update(state, perm, attr, false, 0, 0); | 219 | it->Update(state, perm, attr, false, static_cast<u8>(set_disable_attr), |
| 220 | static_cast<u8>(clear_disable_attr)); | ||
| 218 | cur_address += cur_info.GetSize(); | 221 | cur_address += cur_info.GetSize(); |
| 219 | remaining_pages -= cur_info.GetNumPages(); | 222 | remaining_pages -= cur_info.GetNumPages(); |
| 220 | } else { | 223 | } else { |
| @@ -284,6 +287,65 @@ void KMemoryBlockManager::UpdateLock(KMemoryBlockManagerUpdateAllocator* allocat | |||
| 284 | this->CoalesceForUpdate(allocator, address, num_pages); | 287 | this->CoalesceForUpdate(allocator, address, num_pages); |
| 285 | } | 288 | } |
| 286 | 289 | ||
| 290 | void KMemoryBlockManager::UpdateAttribute(KMemoryBlockManagerUpdateAllocator* allocator, | ||
| 291 | KProcessAddress address, size_t num_pages, | ||
| 292 | KMemoryAttribute mask, KMemoryAttribute attr) { | ||
| 293 | // Ensure for auditing that we never end up with an invalid tree. | ||
| 294 | KScopedMemoryBlockManagerAuditor auditor(this); | ||
| 295 | ASSERT(Common::IsAligned(GetInteger(address), PageSize)); | ||
| 296 | |||
| 297 | KProcessAddress cur_address = address; | ||
| 298 | size_t remaining_pages = num_pages; | ||
| 299 | iterator it = this->FindIterator(address); | ||
| 300 | |||
| 301 | while (remaining_pages > 0) { | ||
| 302 | const size_t remaining_size = remaining_pages * PageSize; | ||
| 303 | KMemoryInfo cur_info = it->GetMemoryInfo(); | ||
| 304 | |||
| 305 | if ((it->GetAttribute() & mask) != attr) { | ||
| 306 | // If we need to, create a new block before and insert it. | ||
| 307 | if (cur_info.GetAddress() != GetInteger(cur_address)) { | ||
| 308 | KMemoryBlock* new_block = allocator->Allocate(); | ||
| 309 | |||
| 310 | it->Split(new_block, cur_address); | ||
| 311 | it = m_memory_block_tree.insert(*new_block); | ||
| 312 | it++; | ||
| 313 | |||
| 314 | cur_info = it->GetMemoryInfo(); | ||
| 315 | cur_address = cur_info.GetAddress(); | ||
| 316 | } | ||
| 317 | |||
| 318 | // If we need to, create a new block after and insert it. | ||
| 319 | if (cur_info.GetSize() > remaining_size) { | ||
| 320 | KMemoryBlock* new_block = allocator->Allocate(); | ||
| 321 | |||
| 322 | it->Split(new_block, cur_address + remaining_size); | ||
| 323 | it = m_memory_block_tree.insert(*new_block); | ||
| 324 | |||
| 325 | cur_info = it->GetMemoryInfo(); | ||
| 326 | } | ||
| 327 | |||
| 328 | // Update block state. | ||
| 329 | it->UpdateAttribute(mask, attr); | ||
| 330 | cur_address += cur_info.GetSize(); | ||
| 331 | remaining_pages -= cur_info.GetNumPages(); | ||
| 332 | } else { | ||
| 333 | // If we already have the right attributes, just advance. | ||
| 334 | if (cur_address + remaining_size < cur_info.GetEndAddress()) { | ||
| 335 | remaining_pages = 0; | ||
| 336 | cur_address += remaining_size; | ||
| 337 | } else { | ||
| 338 | remaining_pages = | ||
| 339 | (cur_address + remaining_size - cur_info.GetEndAddress()) / PageSize; | ||
| 340 | cur_address = cur_info.GetEndAddress(); | ||
| 341 | } | ||
| 342 | } | ||
| 343 | it++; | ||
| 344 | } | ||
| 345 | |||
| 346 | this->CoalesceForUpdate(allocator, address, num_pages); | ||
| 347 | } | ||
| 348 | |||
| 287 | // Debug. | 349 | // Debug. |
| 288 | bool KMemoryBlockManager::CheckState() const { | 350 | bool KMemoryBlockManager::CheckState() const { |
| 289 | // Loop over every block, ensuring that we are sorted and coalesced. | 351 | // Loop over every block, ensuring that we are sorted and coalesced. |
diff --git a/src/core/hle/kernel/k_memory_block_manager.h b/src/core/hle/kernel/k_memory_block_manager.h index 96496e990..cb7b6f430 100644 --- a/src/core/hle/kernel/k_memory_block_manager.h +++ b/src/core/hle/kernel/k_memory_block_manager.h | |||
| @@ -115,7 +115,11 @@ public: | |||
| 115 | void UpdateIfMatch(KMemoryBlockManagerUpdateAllocator* allocator, KProcessAddress address, | 115 | void UpdateIfMatch(KMemoryBlockManagerUpdateAllocator* allocator, KProcessAddress address, |
| 116 | size_t num_pages, KMemoryState test_state, KMemoryPermission test_perm, | 116 | size_t num_pages, KMemoryState test_state, KMemoryPermission test_perm, |
| 117 | KMemoryAttribute test_attr, KMemoryState state, KMemoryPermission perm, | 117 | KMemoryAttribute test_attr, KMemoryState state, KMemoryPermission perm, |
| 118 | KMemoryAttribute attr); | 118 | KMemoryAttribute attr, KMemoryBlockDisableMergeAttribute set_disable_attr, |
| 119 | KMemoryBlockDisableMergeAttribute clear_disable_attr); | ||
| 120 | |||
| 121 | void UpdateAttribute(KMemoryBlockManagerUpdateAllocator* allocator, KProcessAddress address, | ||
| 122 | size_t num_pages, KMemoryAttribute mask, KMemoryAttribute attr); | ||
| 119 | 123 | ||
| 120 | iterator FindIterator(KProcessAddress address) const { | 124 | iterator FindIterator(KProcessAddress address) const { |
| 121 | return m_memory_block_tree.find(KMemoryBlock( | 125 | return m_memory_block_tree.find(KMemoryBlock( |
diff --git a/src/core/hle/kernel/k_memory_layout.h b/src/core/hle/kernel/k_memory_layout.h index 54a71df56..c8122644f 100644 --- a/src/core/hle/kernel/k_memory_layout.h +++ b/src/core/hle/kernel/k_memory_layout.h | |||
| @@ -137,11 +137,9 @@ public: | |||
| 137 | return GetStackTopAddress(core_id, KMemoryRegionType_KernelMiscExceptionStack); | 137 | return GetStackTopAddress(core_id, KMemoryRegionType_KernelMiscExceptionStack); |
| 138 | } | 138 | } |
| 139 | 139 | ||
| 140 | KVirtualAddress GetSlabRegionAddress() const { | 140 | const KMemoryRegion& GetSlabRegion() const { |
| 141 | return Dereference(GetVirtualMemoryRegionTree().FindByType(KMemoryRegionType_KernelSlab)) | 141 | return Dereference(GetVirtualMemoryRegionTree().FindByType(KMemoryRegionType_KernelSlab)); |
| 142 | .GetAddress(); | ||
| 143 | } | 142 | } |
| 144 | |||
| 145 | const KMemoryRegion& GetDeviceRegion(KMemoryRegionType type) const { | 143 | const KMemoryRegion& GetDeviceRegion(KMemoryRegionType type) const { |
| 146 | return Dereference(GetPhysicalMemoryRegionTree().FindFirstDerived(type)); | 144 | return Dereference(GetPhysicalMemoryRegionTree().FindFirstDerived(type)); |
| 147 | } | 145 | } |
diff --git a/src/core/hle/kernel/k_memory_manager.cpp b/src/core/hle/kernel/k_memory_manager.cpp index 74d8169e0..cdc5572d8 100644 --- a/src/core/hle/kernel/k_memory_manager.cpp +++ b/src/core/hle/kernel/k_memory_manager.cpp | |||
| @@ -11,6 +11,7 @@ | |||
| 11 | #include "core/hle/kernel/initial_process.h" | 11 | #include "core/hle/kernel/initial_process.h" |
| 12 | #include "core/hle/kernel/k_memory_manager.h" | 12 | #include "core/hle/kernel/k_memory_manager.h" |
| 13 | #include "core/hle/kernel/k_page_group.h" | 13 | #include "core/hle/kernel/k_page_group.h" |
| 14 | #include "core/hle/kernel/k_page_table.h" | ||
| 14 | #include "core/hle/kernel/kernel.h" | 15 | #include "core/hle/kernel/kernel.h" |
| 15 | #include "core/hle/kernel/svc_results.h" | 16 | #include "core/hle/kernel/svc_results.h" |
| 16 | 17 | ||
| @@ -119,7 +120,8 @@ void KMemoryManager::Initialize(KVirtualAddress management_region, size_t manage | |||
| 119 | // Free each region to its corresponding heap. | 120 | // Free each region to its corresponding heap. |
| 120 | size_t reserved_sizes[MaxManagerCount] = {}; | 121 | size_t reserved_sizes[MaxManagerCount] = {}; |
| 121 | const KPhysicalAddress ini_start = GetInitialProcessBinaryPhysicalAddress(); | 122 | const KPhysicalAddress ini_start = GetInitialProcessBinaryPhysicalAddress(); |
| 122 | const KPhysicalAddress ini_end = ini_start + InitialProcessBinarySizeMax; | 123 | const size_t ini_size = GetInitialProcessBinarySize(); |
| 124 | const KPhysicalAddress ini_end = ini_start + ini_size; | ||
| 123 | const KPhysicalAddress ini_last = ini_end - 1; | 125 | const KPhysicalAddress ini_last = ini_end - 1; |
| 124 | for (const auto& it : m_system.Kernel().MemoryLayout().GetPhysicalMemoryRegionTree()) { | 126 | for (const auto& it : m_system.Kernel().MemoryLayout().GetPhysicalMemoryRegionTree()) { |
| 125 | if (it.IsDerivedFrom(KMemoryRegionType_DramUserPool)) { | 127 | if (it.IsDerivedFrom(KMemoryRegionType_DramUserPool)) { |
| @@ -137,13 +139,13 @@ void KMemoryManager::Initialize(KVirtualAddress management_region, size_t manage | |||
| 137 | } | 139 | } |
| 138 | 140 | ||
| 139 | // Open/reserve the ini memory. | 141 | // Open/reserve the ini memory. |
| 140 | manager.OpenFirst(ini_start, InitialProcessBinarySizeMax / PageSize); | 142 | manager.OpenFirst(ini_start, ini_size / PageSize); |
| 141 | reserved_sizes[it.GetAttributes()] += InitialProcessBinarySizeMax; | 143 | reserved_sizes[it.GetAttributes()] += ini_size; |
| 142 | 144 | ||
| 143 | // Free memory after the ini to the heap. | 145 | // Free memory after the ini to the heap. |
| 144 | if (ini_last != cur_last) { | 146 | if (ini_last != cur_last) { |
| 145 | ASSERT(cur_end != 0); | 147 | ASSERT(cur_end != 0); |
| 146 | manager.Free(ini_end, cur_end - ini_end); | 148 | manager.Free(ini_end, (cur_end - ini_end) / PageSize); |
| 147 | } | 149 | } |
| 148 | } else { | 150 | } else { |
| 149 | // Ensure there's no partial overlap with the ini image. | 151 | // Ensure there's no partial overlap with the ini image. |
| @@ -167,11 +169,37 @@ void KMemoryManager::Initialize(KVirtualAddress management_region, size_t manage | |||
| 167 | } | 169 | } |
| 168 | 170 | ||
| 169 | Result KMemoryManager::InitializeOptimizedMemory(u64 process_id, Pool pool) { | 171 | Result KMemoryManager::InitializeOptimizedMemory(u64 process_id, Pool pool) { |
| 170 | UNREACHABLE(); | 172 | const u32 pool_index = static_cast<u32>(pool); |
| 173 | |||
| 174 | // Lock the pool. | ||
| 175 | KScopedLightLock lk(m_pool_locks[pool_index]); | ||
| 176 | |||
| 177 | // Check that we don't already have an optimized process. | ||
| 178 | R_UNLESS(!m_has_optimized_process[pool_index], ResultBusy); | ||
| 179 | |||
| 180 | // Set the optimized process id. | ||
| 181 | m_optimized_process_ids[pool_index] = process_id; | ||
| 182 | m_has_optimized_process[pool_index] = true; | ||
| 183 | |||
| 184 | // Clear the management area for the optimized process. | ||
| 185 | for (auto* manager = this->GetFirstManager(pool, Direction::FromFront); manager != nullptr; | ||
| 186 | manager = this->GetNextManager(manager, Direction::FromFront)) { | ||
| 187 | manager->InitializeOptimizedMemory(m_system.Kernel()); | ||
| 188 | } | ||
| 189 | |||
| 190 | R_SUCCEED(); | ||
| 171 | } | 191 | } |
| 172 | 192 | ||
| 173 | void KMemoryManager::FinalizeOptimizedMemory(u64 process_id, Pool pool) { | 193 | void KMemoryManager::FinalizeOptimizedMemory(u64 process_id, Pool pool) { |
| 174 | UNREACHABLE(); | 194 | const u32 pool_index = static_cast<u32>(pool); |
| 195 | |||
| 196 | // Lock the pool. | ||
| 197 | KScopedLightLock lk(m_pool_locks[pool_index]); | ||
| 198 | |||
| 199 | // If the process was optimized, clear it. | ||
| 200 | if (m_has_optimized_process[pool_index] && m_optimized_process_ids[pool_index] == process_id) { | ||
| 201 | m_has_optimized_process[pool_index] = false; | ||
| 202 | } | ||
| 175 | } | 203 | } |
| 176 | 204 | ||
| 177 | KPhysicalAddress KMemoryManager::AllocateAndOpenContinuous(size_t num_pages, size_t align_pages, | 205 | KPhysicalAddress KMemoryManager::AllocateAndOpenContinuous(size_t num_pages, size_t align_pages, |
| @@ -206,7 +234,7 @@ KPhysicalAddress KMemoryManager::AllocateAndOpenContinuous(size_t num_pages, siz | |||
| 206 | 234 | ||
| 207 | // Maintain the optimized memory bitmap, if we should. | 235 | // Maintain the optimized memory bitmap, if we should. |
| 208 | if (m_has_optimized_process[static_cast<size_t>(pool)]) { | 236 | if (m_has_optimized_process[static_cast<size_t>(pool)]) { |
| 209 | UNIMPLEMENTED(); | 237 | chosen_manager->TrackUnoptimizedAllocation(m_system.Kernel(), allocated_block, num_pages); |
| 210 | } | 238 | } |
| 211 | 239 | ||
| 212 | // Open the first reference to the pages. | 240 | // Open the first reference to the pages. |
| @@ -254,7 +282,8 @@ Result KMemoryManager::AllocatePageGroupImpl(KPageGroup* out, size_t num_pages, | |||
| 254 | 282 | ||
| 255 | // Maintain the optimized memory bitmap, if we should. | 283 | // Maintain the optimized memory bitmap, if we should. |
| 256 | if (unoptimized) { | 284 | if (unoptimized) { |
| 257 | UNIMPLEMENTED(); | 285 | cur_manager->TrackUnoptimizedAllocation(m_system.Kernel(), allocated_block, |
| 286 | pages_per_alloc); | ||
| 258 | } | 287 | } |
| 259 | 288 | ||
| 260 | num_pages -= pages_per_alloc; | 289 | num_pages -= pages_per_alloc; |
| @@ -357,8 +386,8 @@ Result KMemoryManager::AllocateForProcess(KPageGroup* out, size_t num_pages, u32 | |||
| 357 | // Process part or all of the block. | 386 | // Process part or all of the block. |
| 358 | const size_t cur_pages = | 387 | const size_t cur_pages = |
| 359 | std::min(remaining_pages, manager.GetPageOffsetToEnd(cur_address)); | 388 | std::min(remaining_pages, manager.GetPageOffsetToEnd(cur_address)); |
| 360 | any_new = | 389 | any_new = manager.ProcessOptimizedAllocation(m_system.Kernel(), cur_address, |
| 361 | manager.ProcessOptimizedAllocation(cur_address, cur_pages, fill_pattern); | 390 | cur_pages, fill_pattern); |
| 362 | 391 | ||
| 363 | // Advance. | 392 | // Advance. |
| 364 | cur_address += cur_pages * PageSize; | 393 | cur_address += cur_pages * PageSize; |
| @@ -381,7 +410,7 @@ Result KMemoryManager::AllocateForProcess(KPageGroup* out, size_t num_pages, u32 | |||
| 381 | // Track some or all of the current pages. | 410 | // Track some or all of the current pages. |
| 382 | const size_t cur_pages = | 411 | const size_t cur_pages = |
| 383 | std::min(remaining_pages, manager.GetPageOffsetToEnd(cur_address)); | 412 | std::min(remaining_pages, manager.GetPageOffsetToEnd(cur_address)); |
| 384 | manager.TrackOptimizedAllocation(cur_address, cur_pages); | 413 | manager.TrackOptimizedAllocation(m_system.Kernel(), cur_address, cur_pages); |
| 385 | 414 | ||
| 386 | // Advance. | 415 | // Advance. |
| 387 | cur_address += cur_pages * PageSize; | 416 | cur_address += cur_pages * PageSize; |
| @@ -426,17 +455,86 @@ size_t KMemoryManager::Impl::Initialize(KPhysicalAddress address, size_t size, | |||
| 426 | return total_management_size; | 455 | return total_management_size; |
| 427 | } | 456 | } |
| 428 | 457 | ||
| 429 | void KMemoryManager::Impl::TrackUnoptimizedAllocation(KPhysicalAddress block, size_t num_pages) { | 458 | void KMemoryManager::Impl::InitializeOptimizedMemory(KernelCore& kernel) { |
| 430 | UNREACHABLE(); | 459 | auto optimize_pa = |
| 460 | KPageTable::GetHeapPhysicalAddress(kernel.MemoryLayout(), m_management_region); | ||
| 461 | auto* optimize_map = kernel.System().DeviceMemory().GetPointer<u64>(optimize_pa); | ||
| 462 | |||
| 463 | std::memset(optimize_map, 0, CalculateOptimizedProcessOverheadSize(m_heap.GetSize())); | ||
| 431 | } | 464 | } |
| 432 | 465 | ||
| 433 | void KMemoryManager::Impl::TrackOptimizedAllocation(KPhysicalAddress block, size_t num_pages) { | 466 | void KMemoryManager::Impl::TrackUnoptimizedAllocation(KernelCore& kernel, KPhysicalAddress block, |
| 434 | UNREACHABLE(); | 467 | size_t num_pages) { |
| 468 | auto optimize_pa = | ||
| 469 | KPageTable::GetHeapPhysicalAddress(kernel.MemoryLayout(), m_management_region); | ||
| 470 | auto* optimize_map = kernel.System().DeviceMemory().GetPointer<u64>(optimize_pa); | ||
| 471 | |||
| 472 | // Get the range we're tracking. | ||
| 473 | size_t offset = this->GetPageOffset(block); | ||
| 474 | const size_t last = offset + num_pages - 1; | ||
| 475 | |||
| 476 | // Track. | ||
| 477 | while (offset <= last) { | ||
| 478 | // Mark the page as not being optimized-allocated. | ||
| 479 | optimize_map[offset / Common::BitSize<u64>()] &= | ||
| 480 | ~(u64(1) << (offset % Common::BitSize<u64>())); | ||
| 481 | |||
| 482 | offset++; | ||
| 483 | } | ||
| 484 | } | ||
| 485 | |||
| 486 | void KMemoryManager::Impl::TrackOptimizedAllocation(KernelCore& kernel, KPhysicalAddress block, | ||
| 487 | size_t num_pages) { | ||
| 488 | auto optimize_pa = | ||
| 489 | KPageTable::GetHeapPhysicalAddress(kernel.MemoryLayout(), m_management_region); | ||
| 490 | auto* optimize_map = kernel.System().DeviceMemory().GetPointer<u64>(optimize_pa); | ||
| 491 | |||
| 492 | // Get the range we're tracking. | ||
| 493 | size_t offset = this->GetPageOffset(block); | ||
| 494 | const size_t last = offset + num_pages - 1; | ||
| 495 | |||
| 496 | // Track. | ||
| 497 | while (offset <= last) { | ||
| 498 | // Mark the page as being optimized-allocated. | ||
| 499 | optimize_map[offset / Common::BitSize<u64>()] |= | ||
| 500 | (u64(1) << (offset % Common::BitSize<u64>())); | ||
| 501 | |||
| 502 | offset++; | ||
| 503 | } | ||
| 435 | } | 504 | } |
| 436 | 505 | ||
| 437 | bool KMemoryManager::Impl::ProcessOptimizedAllocation(KPhysicalAddress block, size_t num_pages, | 506 | bool KMemoryManager::Impl::ProcessOptimizedAllocation(KernelCore& kernel, KPhysicalAddress block, |
| 438 | u8 fill_pattern) { | 507 | size_t num_pages, u8 fill_pattern) { |
| 439 | UNREACHABLE(); | 508 | auto& device_memory = kernel.System().DeviceMemory(); |
| 509 | auto optimize_pa = | ||
| 510 | KPageTable::GetHeapPhysicalAddress(kernel.MemoryLayout(), m_management_region); | ||
| 511 | auto* optimize_map = device_memory.GetPointer<u64>(optimize_pa); | ||
| 512 | |||
| 513 | // We want to return whether any pages were newly allocated. | ||
| 514 | bool any_new = false; | ||
| 515 | |||
| 516 | // Get the range we're processing. | ||
| 517 | size_t offset = this->GetPageOffset(block); | ||
| 518 | const size_t last = offset + num_pages - 1; | ||
| 519 | |||
| 520 | // Process. | ||
| 521 | while (offset <= last) { | ||
| 522 | // Check if the page has been optimized-allocated before. | ||
| 523 | if ((optimize_map[offset / Common::BitSize<u64>()] & | ||
| 524 | (u64(1) << (offset % Common::BitSize<u64>()))) == 0) { | ||
| 525 | // If not, it's new. | ||
| 526 | any_new = true; | ||
| 527 | |||
| 528 | // Fill the page. | ||
| 529 | auto* ptr = device_memory.GetPointer<u8>(m_heap.GetAddress()); | ||
| 530 | std::memset(ptr + offset * PageSize, fill_pattern, PageSize); | ||
| 531 | } | ||
| 532 | |||
| 533 | offset++; | ||
| 534 | } | ||
| 535 | |||
| 536 | // Return the number of pages we processed. | ||
| 537 | return any_new; | ||
| 440 | } | 538 | } |
| 441 | 539 | ||
| 442 | size_t KMemoryManager::Impl::CalculateManagementOverheadSize(size_t region_size) { | 540 | size_t KMemoryManager::Impl::CalculateManagementOverheadSize(size_t region_size) { |
diff --git a/src/core/hle/kernel/k_memory_manager.h b/src/core/hle/kernel/k_memory_manager.h index 7e4b41319..c5a487af9 100644 --- a/src/core/hle/kernel/k_memory_manager.h +++ b/src/core/hle/kernel/k_memory_manager.h | |||
| @@ -216,14 +216,14 @@ private: | |||
| 216 | m_heap.SetInitialUsedSize(reserved_size); | 216 | m_heap.SetInitialUsedSize(reserved_size); |
| 217 | } | 217 | } |
| 218 | 218 | ||
| 219 | void InitializeOptimizedMemory() { | 219 | void InitializeOptimizedMemory(KernelCore& kernel); |
| 220 | UNIMPLEMENTED(); | ||
| 221 | } | ||
| 222 | 220 | ||
| 223 | void TrackUnoptimizedAllocation(KPhysicalAddress block, size_t num_pages); | 221 | void TrackUnoptimizedAllocation(KernelCore& kernel, KPhysicalAddress block, |
| 224 | void TrackOptimizedAllocation(KPhysicalAddress block, size_t num_pages); | 222 | size_t num_pages); |
| 223 | void TrackOptimizedAllocation(KernelCore& kernel, KPhysicalAddress block, size_t num_pages); | ||
| 225 | 224 | ||
| 226 | bool ProcessOptimizedAllocation(KPhysicalAddress block, size_t num_pages, u8 fill_pattern); | 225 | bool ProcessOptimizedAllocation(KernelCore& kernel, KPhysicalAddress block, |
| 226 | size_t num_pages, u8 fill_pattern); | ||
| 227 | 227 | ||
| 228 | constexpr Pool GetPool() const { | 228 | constexpr Pool GetPool() const { |
| 229 | return m_pool; | 229 | return m_pool; |
diff --git a/src/core/hle/kernel/k_memory_region_type.h b/src/core/hle/kernel/k_memory_region_type.h index e5630c1ac..bcbf450f0 100644 --- a/src/core/hle/kernel/k_memory_region_type.h +++ b/src/core/hle/kernel/k_memory_region_type.h | |||
| @@ -190,9 +190,15 @@ static_assert(KMemoryRegionType_DramKernelInitPt.GetValue() == | |||
| 190 | constexpr inline auto KMemoryRegionType_DramKernelSecureAppletMemory = | 190 | constexpr inline auto KMemoryRegionType_DramKernelSecureAppletMemory = |
| 191 | KMemoryRegionType_DramKernelBase.DeriveSparse(1, 3, 0).SetAttribute( | 191 | KMemoryRegionType_DramKernelBase.DeriveSparse(1, 3, 0).SetAttribute( |
| 192 | KMemoryRegionAttr_LinearMapped); | 192 | KMemoryRegionAttr_LinearMapped); |
| 193 | constexpr inline const auto KMemoryRegionType_DramKernelSecureUnknown = | ||
| 194 | KMemoryRegionType_DramKernelBase.DeriveSparse(1, 3, 1).SetAttribute( | ||
| 195 | KMemoryRegionAttr_LinearMapped); | ||
| 193 | static_assert(KMemoryRegionType_DramKernelSecureAppletMemory.GetValue() == | 196 | static_assert(KMemoryRegionType_DramKernelSecureAppletMemory.GetValue() == |
| 194 | (0x18E | KMemoryRegionAttr_CarveoutProtected | KMemoryRegionAttr_NoUserMap | | 197 | (0x18E | KMemoryRegionAttr_CarveoutProtected | KMemoryRegionAttr_NoUserMap | |
| 195 | KMemoryRegionAttr_LinearMapped)); | 198 | KMemoryRegionAttr_LinearMapped)); |
| 199 | static_assert(KMemoryRegionType_DramKernelSecureUnknown.GetValue() == | ||
| 200 | (0x28E | KMemoryRegionAttr_CarveoutProtected | KMemoryRegionAttr_NoUserMap | | ||
| 201 | KMemoryRegionAttr_LinearMapped)); | ||
| 196 | 202 | ||
| 197 | constexpr inline auto KMemoryRegionType_DramReservedEarly = | 203 | constexpr inline auto KMemoryRegionType_DramReservedEarly = |
| 198 | KMemoryRegionType_DramReservedBase.DeriveAttribute(KMemoryRegionAttr_NoUserMap); | 204 | KMemoryRegionType_DramReservedBase.DeriveAttribute(KMemoryRegionAttr_NoUserMap); |
| @@ -217,16 +223,18 @@ constexpr inline auto KMemoryRegionType_DramPoolPartition = | |||
| 217 | static_assert(KMemoryRegionType_DramPoolPartition.GetValue() == | 223 | static_assert(KMemoryRegionType_DramPoolPartition.GetValue() == |
| 218 | (0x26 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap)); | 224 | (0x26 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap)); |
| 219 | 225 | ||
| 220 | constexpr inline auto KMemoryRegionType_DramPoolManagement = | 226 | // UNUSED: .Derive(4, 1); |
| 221 | KMemoryRegionType_DramPoolPartition.DeriveTransition(0, 2).DeriveTransition().SetAttribute( | 227 | // UNUSED: .Derive(4, 2); |
| 228 | constexpr inline const auto KMemoryRegionType_DramPoolManagement = | ||
| 229 | KMemoryRegionType_DramPoolPartition.Derive(4, 0).SetAttribute( | ||
| 222 | KMemoryRegionAttr_CarveoutProtected); | 230 | KMemoryRegionAttr_CarveoutProtected); |
| 223 | constexpr inline auto KMemoryRegionType_DramUserPool = | 231 | constexpr inline const auto KMemoryRegionType_DramUserPool = |
| 224 | KMemoryRegionType_DramPoolPartition.DeriveTransition(1, 2).DeriveTransition(); | 232 | KMemoryRegionType_DramPoolPartition.Derive(4, 3); |
| 225 | static_assert(KMemoryRegionType_DramPoolManagement.GetValue() == | 233 | static_assert(KMemoryRegionType_DramPoolManagement.GetValue() == |
| 226 | (0x166 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap | | 234 | (0xE6 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap | |
| 227 | KMemoryRegionAttr_CarveoutProtected)); | 235 | KMemoryRegionAttr_CarveoutProtected)); |
| 228 | static_assert(KMemoryRegionType_DramUserPool.GetValue() == | 236 | static_assert(KMemoryRegionType_DramUserPool.GetValue() == |
| 229 | (0x1A6 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap)); | 237 | (0x266 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap)); |
| 230 | 238 | ||
| 231 | constexpr inline auto KMemoryRegionType_DramApplicationPool = | 239 | constexpr inline auto KMemoryRegionType_DramApplicationPool = |
| 232 | KMemoryRegionType_DramUserPool.Derive(4, 0); | 240 | KMemoryRegionType_DramUserPool.Derive(4, 0); |
| @@ -237,60 +245,63 @@ constexpr inline auto KMemoryRegionType_DramSystemNonSecurePool = | |||
| 237 | constexpr inline auto KMemoryRegionType_DramSystemPool = | 245 | constexpr inline auto KMemoryRegionType_DramSystemPool = |
| 238 | KMemoryRegionType_DramUserPool.Derive(4, 3).SetAttribute(KMemoryRegionAttr_CarveoutProtected); | 246 | KMemoryRegionType_DramUserPool.Derive(4, 3).SetAttribute(KMemoryRegionAttr_CarveoutProtected); |
| 239 | static_assert(KMemoryRegionType_DramApplicationPool.GetValue() == | 247 | static_assert(KMemoryRegionType_DramApplicationPool.GetValue() == |
| 240 | (0x7A6 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap)); | 248 | (0xE66 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap)); |
| 241 | static_assert(KMemoryRegionType_DramAppletPool.GetValue() == | 249 | static_assert(KMemoryRegionType_DramAppletPool.GetValue() == |
| 242 | (0xBA6 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap)); | 250 | (0x1666 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap)); |
| 243 | static_assert(KMemoryRegionType_DramSystemNonSecurePool.GetValue() == | 251 | static_assert(KMemoryRegionType_DramSystemNonSecurePool.GetValue() == |
| 244 | (0xDA6 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap)); | 252 | (0x1A66 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap)); |
| 245 | static_assert(KMemoryRegionType_DramSystemPool.GetValue() == | 253 | static_assert(KMemoryRegionType_DramSystemPool.GetValue() == |
| 246 | (0x13A6 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap | | 254 | (0x2666 | KMemoryRegionAttr_LinearMapped | KMemoryRegionAttr_NoUserMap | |
| 247 | KMemoryRegionAttr_CarveoutProtected)); | 255 | KMemoryRegionAttr_CarveoutProtected)); |
| 248 | 256 | ||
| 249 | constexpr inline auto KMemoryRegionType_VirtualDramHeapBase = | 257 | constexpr inline auto KMemoryRegionType_VirtualDramHeapBase = |
| 250 | KMemoryRegionType_Dram.DeriveSparse(1, 3, 0); | 258 | KMemoryRegionType_Dram.DeriveSparse(1, 4, 0); |
| 251 | constexpr inline auto KMemoryRegionType_VirtualDramKernelPtHeap = | 259 | constexpr inline auto KMemoryRegionType_VirtualDramKernelPtHeap = |
| 252 | KMemoryRegionType_Dram.DeriveSparse(1, 3, 1); | 260 | KMemoryRegionType_Dram.DeriveSparse(1, 4, 1); |
| 253 | constexpr inline auto KMemoryRegionType_VirtualDramKernelTraceBuffer = | 261 | constexpr inline auto KMemoryRegionType_VirtualDramKernelTraceBuffer = |
| 254 | KMemoryRegionType_Dram.DeriveSparse(1, 3, 2); | 262 | KMemoryRegionType_Dram.DeriveSparse(1, 4, 2); |
| 255 | static_assert(KMemoryRegionType_VirtualDramHeapBase.GetValue() == 0x1A); | 263 | static_assert(KMemoryRegionType_VirtualDramHeapBase.GetValue() == 0x1A); |
| 256 | static_assert(KMemoryRegionType_VirtualDramKernelPtHeap.GetValue() == 0x2A); | 264 | static_assert(KMemoryRegionType_VirtualDramKernelPtHeap.GetValue() == 0x2A); |
| 257 | static_assert(KMemoryRegionType_VirtualDramKernelTraceBuffer.GetValue() == 0x4A); | 265 | static_assert(KMemoryRegionType_VirtualDramKernelTraceBuffer.GetValue() == 0x4A); |
| 258 | 266 | ||
| 259 | // UNUSED: .DeriveSparse(2, 2, 0); | 267 | // UNUSED: .Derive(4, 2); |
| 260 | constexpr inline auto KMemoryRegionType_VirtualDramUnknownDebug = | 268 | constexpr inline const auto KMemoryRegionType_VirtualDramUnknownDebug = |
| 261 | KMemoryRegionType_Dram.DeriveSparse(2, 2, 1); | 269 | KMemoryRegionType_Dram.Advance(2).Derive(4, 0); |
| 262 | static_assert(KMemoryRegionType_VirtualDramUnknownDebug.GetValue() == (0x52)); | 270 | constexpr inline const auto KMemoryRegionType_VirtualDramKernelSecureAppletMemory = |
| 263 | 271 | KMemoryRegionType_Dram.Advance(2).Derive(4, 1); | |
| 264 | constexpr inline auto KMemoryRegionType_VirtualDramKernelSecureAppletMemory = | 272 | constexpr inline const auto KMemoryRegionType_VirtualDramKernelSecureUnknown = |
| 265 | KMemoryRegionType_Dram.DeriveSparse(3, 1, 0); | 273 | KMemoryRegionType_Dram.Advance(2).Derive(4, 3); |
| 266 | static_assert(KMemoryRegionType_VirtualDramKernelSecureAppletMemory.GetValue() == (0x62)); | 274 | static_assert(KMemoryRegionType_VirtualDramUnknownDebug.GetValue() == (0x32)); |
| 267 | 275 | static_assert(KMemoryRegionType_VirtualDramKernelSecureAppletMemory.GetValue() == (0x52)); | |
| 268 | constexpr inline auto KMemoryRegionType_VirtualDramKernelInitPt = | 276 | static_assert(KMemoryRegionType_VirtualDramKernelSecureUnknown.GetValue() == (0x92)); |
| 269 | KMemoryRegionType_VirtualDramHeapBase.Derive(3, 0); | 277 | |
| 270 | constexpr inline auto KMemoryRegionType_VirtualDramPoolManagement = | 278 | // UNUSED: .Derive(4, 3); |
| 271 | KMemoryRegionType_VirtualDramHeapBase.Derive(3, 1); | 279 | constexpr inline const auto KMemoryRegionType_VirtualDramKernelInitPt = |
| 272 | constexpr inline auto KMemoryRegionType_VirtualDramUserPool = | 280 | KMemoryRegionType_VirtualDramHeapBase.Derive(4, 0); |
| 273 | KMemoryRegionType_VirtualDramHeapBase.Derive(3, 2); | 281 | constexpr inline const auto KMemoryRegionType_VirtualDramPoolManagement = |
| 274 | static_assert(KMemoryRegionType_VirtualDramKernelInitPt.GetValue() == 0x19A); | 282 | KMemoryRegionType_VirtualDramHeapBase.Derive(4, 1); |
| 275 | static_assert(KMemoryRegionType_VirtualDramPoolManagement.GetValue() == 0x29A); | 283 | constexpr inline const auto KMemoryRegionType_VirtualDramUserPool = |
| 276 | static_assert(KMemoryRegionType_VirtualDramUserPool.GetValue() == 0x31A); | 284 | KMemoryRegionType_VirtualDramHeapBase.Derive(4, 2); |
| 285 | static_assert(KMemoryRegionType_VirtualDramKernelInitPt.GetValue() == 0x31A); | ||
| 286 | static_assert(KMemoryRegionType_VirtualDramPoolManagement.GetValue() == 0x51A); | ||
| 287 | static_assert(KMemoryRegionType_VirtualDramUserPool.GetValue() == 0x61A); | ||
| 277 | 288 | ||
| 278 | // NOTE: For unknown reason, the pools are derived out-of-order here. | 289 | // NOTE: For unknown reason, the pools are derived out-of-order here. |
| 279 | // It's worth eventually trying to understand why Nintendo made this choice. | 290 | // It's worth eventually trying to understand why Nintendo made this choice. |
| 280 | // UNUSED: .Derive(6, 0); | 291 | // UNUSED: .Derive(6, 0); |
| 281 | // UNUSED: .Derive(6, 1); | 292 | // UNUSED: .Derive(6, 1); |
| 282 | constexpr inline auto KMemoryRegionType_VirtualDramAppletPool = | 293 | constexpr inline const auto KMemoryRegionType_VirtualDramApplicationPool = |
| 283 | KMemoryRegionType_VirtualDramUserPool.Derive(6, 2); | 294 | KMemoryRegionType_VirtualDramUserPool.Derive(4, 0); |
| 284 | constexpr inline auto KMemoryRegionType_VirtualDramApplicationPool = | 295 | constexpr inline const auto KMemoryRegionType_VirtualDramAppletPool = |
| 285 | KMemoryRegionType_VirtualDramUserPool.Derive(6, 3); | 296 | KMemoryRegionType_VirtualDramUserPool.Derive(4, 1); |
| 286 | constexpr inline auto KMemoryRegionType_VirtualDramSystemNonSecurePool = | 297 | constexpr inline const auto KMemoryRegionType_VirtualDramSystemNonSecurePool = |
| 287 | KMemoryRegionType_VirtualDramUserPool.Derive(6, 4); | 298 | KMemoryRegionType_VirtualDramUserPool.Derive(4, 2); |
| 288 | constexpr inline auto KMemoryRegionType_VirtualDramSystemPool = | 299 | constexpr inline const auto KMemoryRegionType_VirtualDramSystemPool = |
| 289 | KMemoryRegionType_VirtualDramUserPool.Derive(6, 5); | 300 | KMemoryRegionType_VirtualDramUserPool.Derive(4, 3); |
| 290 | static_assert(KMemoryRegionType_VirtualDramAppletPool.GetValue() == 0x1B1A); | 301 | static_assert(KMemoryRegionType_VirtualDramApplicationPool.GetValue() == 0x361A); |
| 291 | static_assert(KMemoryRegionType_VirtualDramApplicationPool.GetValue() == 0x271A); | 302 | static_assert(KMemoryRegionType_VirtualDramAppletPool.GetValue() == 0x561A); |
| 292 | static_assert(KMemoryRegionType_VirtualDramSystemNonSecurePool.GetValue() == 0x2B1A); | 303 | static_assert(KMemoryRegionType_VirtualDramSystemNonSecurePool.GetValue() == 0x661A); |
| 293 | static_assert(KMemoryRegionType_VirtualDramSystemPool.GetValue() == 0x331A); | 304 | static_assert(KMemoryRegionType_VirtualDramSystemPool.GetValue() == 0x961A); |
| 294 | 305 | ||
| 295 | constexpr inline auto KMemoryRegionType_ArchDeviceBase = | 306 | constexpr inline auto KMemoryRegionType_ArchDeviceBase = |
| 296 | KMemoryRegionType_Kernel.DeriveTransition(0, 1).SetSparseOnly(); | 307 | KMemoryRegionType_Kernel.DeriveTransition(0, 1).SetSparseOnly(); |
| @@ -354,12 +365,14 @@ constexpr inline auto KMemoryRegionType_KernelTemp = | |||
| 354 | static_assert(KMemoryRegionType_KernelTemp.GetValue() == 0x31); | 365 | static_assert(KMemoryRegionType_KernelTemp.GetValue() == 0x31); |
| 355 | 366 | ||
| 356 | constexpr KMemoryRegionType GetTypeForVirtualLinearMapping(u32 type_id) { | 367 | constexpr KMemoryRegionType GetTypeForVirtualLinearMapping(u32 type_id) { |
| 357 | if (KMemoryRegionType_KernelTraceBuffer.IsAncestorOf(type_id)) { | 368 | if (KMemoryRegionType_DramKernelPtHeap.IsAncestorOf(type_id)) { |
| 358 | return KMemoryRegionType_VirtualDramKernelTraceBuffer; | ||
| 359 | } else if (KMemoryRegionType_DramKernelPtHeap.IsAncestorOf(type_id)) { | ||
| 360 | return KMemoryRegionType_VirtualDramKernelPtHeap; | 369 | return KMemoryRegionType_VirtualDramKernelPtHeap; |
| 361 | } else if (KMemoryRegionType_DramKernelSecureAppletMemory.IsAncestorOf(type_id)) { | 370 | } else if (KMemoryRegionType_DramKernelSecureAppletMemory.IsAncestorOf(type_id)) { |
| 362 | return KMemoryRegionType_VirtualDramKernelSecureAppletMemory; | 371 | return KMemoryRegionType_VirtualDramKernelSecureAppletMemory; |
| 372 | } else if (KMemoryRegionType_DramKernelSecureUnknown.IsAncestorOf(type_id)) { | ||
| 373 | return KMemoryRegionType_VirtualDramKernelSecureUnknown; | ||
| 374 | } else if (KMemoryRegionType_KernelTraceBuffer.IsAncestorOf(type_id)) { | ||
| 375 | return KMemoryRegionType_VirtualDramKernelTraceBuffer; | ||
| 363 | } else if ((type_id | KMemoryRegionAttr_ShouldKernelMap) == type_id) { | 376 | } else if ((type_id | KMemoryRegionAttr_ShouldKernelMap) == type_id) { |
| 364 | return KMemoryRegionType_VirtualDramUnknownDebug; | 377 | return KMemoryRegionType_VirtualDramUnknownDebug; |
| 365 | } else { | 378 | } else { |
diff --git a/src/core/hle/kernel/k_page_group.h b/src/core/hle/kernel/k_page_group.h index b32909f05..de9d63a8d 100644 --- a/src/core/hle/kernel/k_page_group.h +++ b/src/core/hle/kernel/k_page_group.h | |||
| @@ -183,12 +183,17 @@ private: | |||
| 183 | 183 | ||
| 184 | class KScopedPageGroup { | 184 | class KScopedPageGroup { |
| 185 | public: | 185 | public: |
| 186 | explicit KScopedPageGroup(const KPageGroup* gp) : m_pg(gp) { | 186 | explicit KScopedPageGroup(const KPageGroup* gp, bool not_first = true) : m_pg(gp) { |
| 187 | if (m_pg) { | 187 | if (m_pg) { |
| 188 | m_pg->Open(); | 188 | if (not_first) { |
| 189 | m_pg->Open(); | ||
| 190 | } else { | ||
| 191 | m_pg->OpenFirst(); | ||
| 192 | } | ||
| 189 | } | 193 | } |
| 190 | } | 194 | } |
| 191 | explicit KScopedPageGroup(const KPageGroup& gp) : KScopedPageGroup(std::addressof(gp)) {} | 195 | explicit KScopedPageGroup(const KPageGroup& gp, bool not_first = true) |
| 196 | : KScopedPageGroup(std::addressof(gp), not_first) {} | ||
| 192 | ~KScopedPageGroup() { | 197 | ~KScopedPageGroup() { |
| 193 | if (m_pg) { | 198 | if (m_pg) { |
| 194 | m_pg->Close(); | 199 | m_pg->Close(); |
diff --git a/src/core/hle/kernel/k_page_table.cpp b/src/core/hle/kernel/k_page_table.cpp index 5b51edf30..1d47bdf6b 100644 --- a/src/core/hle/kernel/k_page_table.cpp +++ b/src/core/hle/kernel/k_page_table.cpp | |||
| @@ -82,14 +82,14 @@ public: | |||
| 82 | 82 | ||
| 83 | using namespace Common::Literals; | 83 | using namespace Common::Literals; |
| 84 | 84 | ||
| 85 | constexpr size_t GetAddressSpaceWidthFromType(FileSys::ProgramAddressSpaceType as_type) { | 85 | constexpr size_t GetAddressSpaceWidthFromType(Svc::CreateProcessFlag as_type) { |
| 86 | switch (as_type) { | 86 | switch (as_type) { |
| 87 | case FileSys::ProgramAddressSpaceType::Is32Bit: | 87 | case Svc::CreateProcessFlag::AddressSpace32Bit: |
| 88 | case FileSys::ProgramAddressSpaceType::Is32BitNoMap: | 88 | case Svc::CreateProcessFlag::AddressSpace32BitWithoutAlias: |
| 89 | return 32; | 89 | return 32; |
| 90 | case FileSys::ProgramAddressSpaceType::Is36Bit: | 90 | case Svc::CreateProcessFlag::AddressSpace64BitDeprecated: |
| 91 | return 36; | 91 | return 36; |
| 92 | case FileSys::ProgramAddressSpaceType::Is39Bit: | 92 | case Svc::CreateProcessFlag::AddressSpace64Bit: |
| 93 | return 39; | 93 | return 39; |
| 94 | default: | 94 | default: |
| 95 | ASSERT(false); | 95 | ASSERT(false); |
| @@ -105,7 +105,7 @@ KPageTable::KPageTable(Core::System& system_) | |||
| 105 | 105 | ||
| 106 | KPageTable::~KPageTable() = default; | 106 | KPageTable::~KPageTable() = default; |
| 107 | 107 | ||
| 108 | Result KPageTable::InitializeForProcess(FileSys::ProgramAddressSpaceType as_type, bool enable_aslr, | 108 | Result KPageTable::InitializeForProcess(Svc::CreateProcessFlag as_type, bool enable_aslr, |
| 109 | bool enable_das_merge, bool from_back, | 109 | bool enable_das_merge, bool from_back, |
| 110 | KMemoryManager::Pool pool, KProcessAddress code_addr, | 110 | KMemoryManager::Pool pool, KProcessAddress code_addr, |
| 111 | size_t code_size, KSystemResource* system_resource, | 111 | size_t code_size, KSystemResource* system_resource, |
| @@ -133,7 +133,7 @@ Result KPageTable::InitializeForProcess(FileSys::ProgramAddressSpaceType as_type | |||
| 133 | ASSERT(code_addr + code_size - 1 <= end - 1); | 133 | ASSERT(code_addr + code_size - 1 <= end - 1); |
| 134 | 134 | ||
| 135 | // Adjust heap/alias size if we don't have an alias region | 135 | // Adjust heap/alias size if we don't have an alias region |
| 136 | if (as_type == FileSys::ProgramAddressSpaceType::Is32BitNoMap) { | 136 | if (as_type == Svc::CreateProcessFlag::AddressSpace32BitWithoutAlias) { |
| 137 | heap_region_size += alias_region_size; | 137 | heap_region_size += alias_region_size; |
| 138 | alias_region_size = 0; | 138 | alias_region_size = 0; |
| 139 | } | 139 | } |
| @@ -505,7 +505,7 @@ Result KPageTable::UnmapCodeMemory(KProcessAddress dst_address, KProcessAddress | |||
| 505 | R_TRY(this->CheckMemoryStateContiguous( | 505 | R_TRY(this->CheckMemoryStateContiguous( |
| 506 | std::addressof(num_dst_allocator_blocks), dst_address, size, KMemoryState::FlagCanCodeAlias, | 506 | std::addressof(num_dst_allocator_blocks), dst_address, size, KMemoryState::FlagCanCodeAlias, |
| 507 | KMemoryState::FlagCanCodeAlias, KMemoryPermission::None, KMemoryPermission::None, | 507 | KMemoryState::FlagCanCodeAlias, KMemoryPermission::None, KMemoryPermission::None, |
| 508 | KMemoryAttribute::All, KMemoryAttribute::None)); | 508 | KMemoryAttribute::All & ~KMemoryAttribute::PermissionLocked, KMemoryAttribute::None)); |
| 509 | 509 | ||
| 510 | // Determine whether any pages being unmapped are code. | 510 | // Determine whether any pages being unmapped are code. |
| 511 | bool any_code_pages = false; | 511 | bool any_code_pages = false; |
| @@ -1724,29 +1724,43 @@ Result KPageTable::MapPhysicalMemory(KProcessAddress address, size_t size) { | |||
| 1724 | PageSize; | 1724 | PageSize; |
| 1725 | 1725 | ||
| 1726 | // While we have pages to map, map them. | 1726 | // While we have pages to map, map them. |
| 1727 | while (map_pages > 0) { | 1727 | { |
| 1728 | // Check if we're at the end of the physical block. | 1728 | // Create a page group for the current mapping range. |
| 1729 | if (pg_pages == 0) { | 1729 | KPageGroup cur_pg(m_kernel, m_block_info_manager); |
| 1730 | // Ensure there are more pages to map. | 1730 | { |
| 1731 | ASSERT(pg_it != pg.end()); | 1731 | ON_RESULT_FAILURE_2 { |
| 1732 | 1732 | cur_pg.OpenFirst(); | |
| 1733 | // Advance our physical block. | 1733 | cur_pg.Close(); |
| 1734 | ++pg_it; | 1734 | }; |
| 1735 | pg_phys_addr = pg_it->GetAddress(); | 1735 | |
| 1736 | pg_pages = pg_it->GetNumPages(); | 1736 | size_t remain_pages = map_pages; |
| 1737 | while (remain_pages > 0) { | ||
| 1738 | // Check if we're at the end of the physical block. | ||
| 1739 | if (pg_pages == 0) { | ||
| 1740 | // Ensure there are more pages to map. | ||
| 1741 | ASSERT(pg_it != pg.end()); | ||
| 1742 | |||
| 1743 | // Advance our physical block. | ||
| 1744 | ++pg_it; | ||
| 1745 | pg_phys_addr = pg_it->GetAddress(); | ||
| 1746 | pg_pages = pg_it->GetNumPages(); | ||
| 1747 | } | ||
| 1748 | |||
| 1749 | // Add whatever we can to the current block. | ||
| 1750 | const size_t cur_pages = std::min(pg_pages, remain_pages); | ||
| 1751 | R_TRY(cur_pg.AddBlock(pg_phys_addr + | ||
| 1752 | ((pg_pages - cur_pages) * PageSize), | ||
| 1753 | cur_pages)); | ||
| 1754 | |||
| 1755 | // Advance. | ||
| 1756 | remain_pages -= cur_pages; | ||
| 1757 | pg_pages -= cur_pages; | ||
| 1758 | } | ||
| 1737 | } | 1759 | } |
| 1738 | 1760 | ||
| 1739 | // Map whatever we can. | 1761 | // Map the pages. |
| 1740 | const size_t cur_pages = std::min(pg_pages, map_pages); | 1762 | R_TRY(this->Operate(cur_address, map_pages, cur_pg, |
| 1741 | R_TRY(Operate(cur_address, cur_pages, KMemoryPermission::UserReadWrite, | 1763 | OperationType::MapFirstGroup)); |
| 1742 | OperationType::MapFirst, pg_phys_addr)); | ||
| 1743 | |||
| 1744 | // Advance. | ||
| 1745 | cur_address += cur_pages * PageSize; | ||
| 1746 | map_pages -= cur_pages; | ||
| 1747 | |||
| 1748 | pg_phys_addr += cur_pages * PageSize; | ||
| 1749 | pg_pages -= cur_pages; | ||
| 1750 | } | 1764 | } |
| 1751 | } | 1765 | } |
| 1752 | 1766 | ||
| @@ -1770,7 +1784,11 @@ Result KPageTable::MapPhysicalMemory(KProcessAddress address, size_t size) { | |||
| 1770 | m_memory_block_manager.UpdateIfMatch( | 1784 | m_memory_block_manager.UpdateIfMatch( |
| 1771 | std::addressof(allocator), address, size / PageSize, KMemoryState::Free, | 1785 | std::addressof(allocator), address, size / PageSize, KMemoryState::Free, |
| 1772 | KMemoryPermission::None, KMemoryAttribute::None, KMemoryState::Normal, | 1786 | KMemoryPermission::None, KMemoryAttribute::None, KMemoryState::Normal, |
| 1773 | KMemoryPermission::UserReadWrite, KMemoryAttribute::None); | 1787 | KMemoryPermission::UserReadWrite, KMemoryAttribute::None, |
| 1788 | address == this->GetAliasRegionStart() | ||
| 1789 | ? KMemoryBlockDisableMergeAttribute::Normal | ||
| 1790 | : KMemoryBlockDisableMergeAttribute::None, | ||
| 1791 | KMemoryBlockDisableMergeAttribute::None); | ||
| 1774 | 1792 | ||
| 1775 | R_SUCCEED(); | 1793 | R_SUCCEED(); |
| 1776 | } | 1794 | } |
| @@ -1868,6 +1886,13 @@ Result KPageTable::UnmapPhysicalMemory(KProcessAddress address, size_t size) { | |||
| 1868 | 1886 | ||
| 1869 | // Iterate over the memory, unmapping as we go. | 1887 | // Iterate over the memory, unmapping as we go. |
| 1870 | auto it = m_memory_block_manager.FindIterator(cur_address); | 1888 | auto it = m_memory_block_manager.FindIterator(cur_address); |
| 1889 | |||
| 1890 | const auto clear_merge_attr = | ||
| 1891 | (it->GetState() == KMemoryState::Normal && | ||
| 1892 | it->GetAddress() == this->GetAliasRegionStart() && it->GetAddress() == address) | ||
| 1893 | ? KMemoryBlockDisableMergeAttribute::Normal | ||
| 1894 | : KMemoryBlockDisableMergeAttribute::None; | ||
| 1895 | |||
| 1871 | while (true) { | 1896 | while (true) { |
| 1872 | // Check that the iterator is valid. | 1897 | // Check that the iterator is valid. |
| 1873 | ASSERT(it != m_memory_block_manager.end()); | 1898 | ASSERT(it != m_memory_block_manager.end()); |
| @@ -1905,7 +1930,7 @@ Result KPageTable::UnmapPhysicalMemory(KProcessAddress address, size_t size) { | |||
| 1905 | m_memory_block_manager.Update(std::addressof(allocator), address, size / PageSize, | 1930 | m_memory_block_manager.Update(std::addressof(allocator), address, size / PageSize, |
| 1906 | KMemoryState::Free, KMemoryPermission::None, | 1931 | KMemoryState::Free, KMemoryPermission::None, |
| 1907 | KMemoryAttribute::None, KMemoryBlockDisableMergeAttribute::None, | 1932 | KMemoryAttribute::None, KMemoryBlockDisableMergeAttribute::None, |
| 1908 | KMemoryBlockDisableMergeAttribute::None); | 1933 | clear_merge_attr); |
| 1909 | 1934 | ||
| 1910 | // We succeeded. | 1935 | // We succeeded. |
| 1911 | R_SUCCEED(); | 1936 | R_SUCCEED(); |
| @@ -2379,8 +2404,7 @@ Result KPageTable::MapPageGroup(KProcessAddress* out_addr, const KPageGroup& pg, | |||
| 2379 | KScopedPageTableUpdater updater(this); | 2404 | KScopedPageTableUpdater updater(this); |
| 2380 | 2405 | ||
| 2381 | // Perform mapping operation. | 2406 | // Perform mapping operation. |
| 2382 | const KPageProperties properties = {perm, state == KMemoryState::Io, false, | 2407 | const KPageProperties properties = {perm, false, false, DisableMergeAttribute::DisableHead}; |
| 2383 | DisableMergeAttribute::DisableHead}; | ||
| 2384 | R_TRY(this->MapPageGroupImpl(updater.GetPageList(), addr, pg, properties, false)); | 2408 | R_TRY(this->MapPageGroupImpl(updater.GetPageList(), addr, pg, properties, false)); |
| 2385 | 2409 | ||
| 2386 | // Update the blocks. | 2410 | // Update the blocks. |
| @@ -2422,8 +2446,7 @@ Result KPageTable::MapPageGroup(KProcessAddress addr, const KPageGroup& pg, KMem | |||
| 2422 | KScopedPageTableUpdater updater(this); | 2446 | KScopedPageTableUpdater updater(this); |
| 2423 | 2447 | ||
| 2424 | // Perform mapping operation. | 2448 | // Perform mapping operation. |
| 2425 | const KPageProperties properties = {perm, state == KMemoryState::Io, false, | 2449 | const KPageProperties properties = {perm, false, false, DisableMergeAttribute::DisableHead}; |
| 2426 | DisableMergeAttribute::DisableHead}; | ||
| 2427 | R_TRY(this->MapPageGroupImpl(updater.GetPageList(), addr, pg, properties, false)); | 2450 | R_TRY(this->MapPageGroupImpl(updater.GetPageList(), addr, pg, properties, false)); |
| 2428 | 2451 | ||
| 2429 | // Update the blocks. | 2452 | // Update the blocks. |
| @@ -2652,11 +2675,18 @@ Result KPageTable::SetMemoryAttribute(KProcessAddress addr, size_t size, u32 mas | |||
| 2652 | size_t num_allocator_blocks; | 2675 | size_t num_allocator_blocks; |
| 2653 | constexpr auto AttributeTestMask = | 2676 | constexpr auto AttributeTestMask = |
| 2654 | ~(KMemoryAttribute::SetMask | KMemoryAttribute::DeviceShared); | 2677 | ~(KMemoryAttribute::SetMask | KMemoryAttribute::DeviceShared); |
| 2655 | R_TRY(this->CheckMemoryState( | 2678 | const KMemoryState state_test_mask = |
| 2656 | std::addressof(old_state), std::addressof(old_perm), std::addressof(old_attr), | 2679 | static_cast<KMemoryState>(((mask & static_cast<u32>(KMemoryAttribute::Uncached)) |
| 2657 | std::addressof(num_allocator_blocks), addr, size, KMemoryState::FlagCanChangeAttribute, | 2680 | ? static_cast<u32>(KMemoryState::FlagCanChangeAttribute) |
| 2658 | KMemoryState::FlagCanChangeAttribute, KMemoryPermission::None, KMemoryPermission::None, | 2681 | : 0) | |
| 2659 | AttributeTestMask, KMemoryAttribute::None, ~AttributeTestMask)); | 2682 | ((mask & static_cast<u32>(KMemoryAttribute::PermissionLocked)) |
| 2683 | ? static_cast<u32>(KMemoryState::FlagCanPermissionLock) | ||
| 2684 | : 0)); | ||
| 2685 | R_TRY(this->CheckMemoryState(std::addressof(old_state), std::addressof(old_perm), | ||
| 2686 | std::addressof(old_attr), std::addressof(num_allocator_blocks), | ||
| 2687 | addr, size, state_test_mask, state_test_mask, | ||
| 2688 | KMemoryPermission::None, KMemoryPermission::None, | ||
| 2689 | AttributeTestMask, KMemoryAttribute::None, ~AttributeTestMask)); | ||
| 2660 | 2690 | ||
| 2661 | // Create an update allocator. | 2691 | // Create an update allocator. |
| 2662 | Result allocator_result{ResultSuccess}; | 2692 | Result allocator_result{ResultSuccess}; |
| @@ -2664,18 +2694,17 @@ Result KPageTable::SetMemoryAttribute(KProcessAddress addr, size_t size, u32 mas | |||
| 2664 | m_memory_block_slab_manager, num_allocator_blocks); | 2694 | m_memory_block_slab_manager, num_allocator_blocks); |
| 2665 | R_TRY(allocator_result); | 2695 | R_TRY(allocator_result); |
| 2666 | 2696 | ||
| 2667 | // Determine the new attribute. | 2697 | // If we need to, perform a change attribute operation. |
| 2668 | const KMemoryAttribute new_attr = | 2698 | if (True(KMemoryAttribute::Uncached & static_cast<KMemoryAttribute>(mask))) { |
| 2669 | static_cast<KMemoryAttribute>(((old_attr & static_cast<KMemoryAttribute>(~mask)) | | 2699 | // Perform operation. |
| 2670 | static_cast<KMemoryAttribute>(attr & mask))); | 2700 | R_TRY(this->Operate(addr, num_pages, old_perm, |
| 2671 | 2701 | OperationType::ChangePermissionsAndRefreshAndFlush, 0)); | |
| 2672 | // Perform operation. | 2702 | } |
| 2673 | this->Operate(addr, num_pages, old_perm, OperationType::ChangePermissionsAndRefresh); | ||
| 2674 | 2703 | ||
| 2675 | // Update the blocks. | 2704 | // Update the blocks. |
| 2676 | m_memory_block_manager.Update(std::addressof(allocator), addr, num_pages, old_state, old_perm, | 2705 | m_memory_block_manager.UpdateAttribute(std::addressof(allocator), addr, num_pages, |
| 2677 | new_attr, KMemoryBlockDisableMergeAttribute::None, | 2706 | static_cast<KMemoryAttribute>(mask), |
| 2678 | KMemoryBlockDisableMergeAttribute::None); | 2707 | static_cast<KMemoryAttribute>(attr)); |
| 2679 | 2708 | ||
| 2680 | R_SUCCEED(); | 2709 | R_SUCCEED(); |
| 2681 | } | 2710 | } |
| @@ -2863,7 +2892,8 @@ Result KPageTable::LockForMapDeviceAddressSpace(bool* out_is_io, KProcessAddress | |||
| 2863 | &KMemoryBlock::ShareToDevice, KMemoryPermission::None); | 2892 | &KMemoryBlock::ShareToDevice, KMemoryPermission::None); |
| 2864 | 2893 | ||
| 2865 | // Set whether the locked memory was io. | 2894 | // Set whether the locked memory was io. |
| 2866 | *out_is_io = old_state == KMemoryState::Io; | 2895 | *out_is_io = |
| 2896 | static_cast<Svc::MemoryState>(old_state & KMemoryState::Mask) == Svc::MemoryState::Io; | ||
| 2867 | 2897 | ||
| 2868 | R_SUCCEED(); | 2898 | R_SUCCEED(); |
| 2869 | } | 2899 | } |
| @@ -2949,6 +2979,23 @@ Result KPageTable::UnlockForIpcUserBuffer(KProcessAddress address, size_t size) | |||
| 2949 | KMemoryAttribute::Locked, nullptr)); | 2979 | KMemoryAttribute::Locked, nullptr)); |
| 2950 | } | 2980 | } |
| 2951 | 2981 | ||
| 2982 | Result KPageTable::LockForTransferMemory(KPageGroup* out, KProcessAddress address, size_t size, | ||
| 2983 | KMemoryPermission perm) { | ||
| 2984 | R_RETURN(this->LockMemoryAndOpen(out, nullptr, address, size, KMemoryState::FlagCanTransfer, | ||
| 2985 | KMemoryState::FlagCanTransfer, KMemoryPermission::All, | ||
| 2986 | KMemoryPermission::UserReadWrite, KMemoryAttribute::All, | ||
| 2987 | KMemoryAttribute::None, perm, KMemoryAttribute::Locked)); | ||
| 2988 | } | ||
| 2989 | |||
| 2990 | Result KPageTable::UnlockForTransferMemory(KProcessAddress address, size_t size, | ||
| 2991 | const KPageGroup& pg) { | ||
| 2992 | R_RETURN(this->UnlockMemory(address, size, KMemoryState::FlagCanTransfer, | ||
| 2993 | KMemoryState::FlagCanTransfer, KMemoryPermission::None, | ||
| 2994 | KMemoryPermission::None, KMemoryAttribute::All, | ||
| 2995 | KMemoryAttribute::Locked, KMemoryPermission::UserReadWrite, | ||
| 2996 | KMemoryAttribute::Locked, std::addressof(pg))); | ||
| 2997 | } | ||
| 2998 | |||
| 2952 | Result KPageTable::LockForCodeMemory(KPageGroup* out, KProcessAddress addr, size_t size) { | 2999 | Result KPageTable::LockForCodeMemory(KPageGroup* out, KProcessAddress addr, size_t size) { |
| 2953 | R_RETURN(this->LockMemoryAndOpen( | 3000 | R_RETURN(this->LockMemoryAndOpen( |
| 2954 | out, nullptr, addr, size, KMemoryState::FlagCanCodeMemory, KMemoryState::FlagCanCodeMemory, | 3001 | out, nullptr, addr, size, KMemoryState::FlagCanCodeMemory, KMemoryState::FlagCanCodeMemory, |
| @@ -3004,9 +3051,10 @@ Result KPageTable::Operate(KProcessAddress addr, size_t num_pages, const KPageGr | |||
| 3004 | ASSERT(num_pages == page_group.GetNumPages()); | 3051 | ASSERT(num_pages == page_group.GetNumPages()); |
| 3005 | 3052 | ||
| 3006 | switch (operation) { | 3053 | switch (operation) { |
| 3007 | case OperationType::MapGroup: { | 3054 | case OperationType::MapGroup: |
| 3055 | case OperationType::MapFirstGroup: { | ||
| 3008 | // We want to maintain a new reference to every page in the group. | 3056 | // We want to maintain a new reference to every page in the group. |
| 3009 | KScopedPageGroup spg(page_group); | 3057 | KScopedPageGroup spg(page_group, operation != OperationType::MapFirstGroup); |
| 3010 | 3058 | ||
| 3011 | for (const auto& node : page_group) { | 3059 | for (const auto& node : page_group) { |
| 3012 | const size_t size{node.GetNumPages() * PageSize}; | 3060 | const size_t size{node.GetNumPages() * PageSize}; |
| @@ -3048,7 +3096,6 @@ Result KPageTable::Operate(KProcessAddress addr, size_t num_pages, KMemoryPermis | |||
| 3048 | m_memory->UnmapRegion(*m_page_table_impl, addr, num_pages * PageSize); | 3096 | m_memory->UnmapRegion(*m_page_table_impl, addr, num_pages * PageSize); |
| 3049 | break; | 3097 | break; |
| 3050 | } | 3098 | } |
| 3051 | case OperationType::MapFirst: | ||
| 3052 | case OperationType::Map: { | 3099 | case OperationType::Map: { |
| 3053 | ASSERT(map_addr); | 3100 | ASSERT(map_addr); |
| 3054 | ASSERT(Common::IsAligned(GetInteger(map_addr), PageSize)); | 3101 | ASSERT(Common::IsAligned(GetInteger(map_addr), PageSize)); |
| @@ -3056,11 +3103,7 @@ Result KPageTable::Operate(KProcessAddress addr, size_t num_pages, KMemoryPermis | |||
| 3056 | 3103 | ||
| 3057 | // Open references to pages, if we should. | 3104 | // Open references to pages, if we should. |
| 3058 | if (IsHeapPhysicalAddress(m_kernel.MemoryLayout(), map_addr)) { | 3105 | if (IsHeapPhysicalAddress(m_kernel.MemoryLayout(), map_addr)) { |
| 3059 | if (operation == OperationType::MapFirst) { | 3106 | m_kernel.MemoryManager().Open(map_addr, num_pages); |
| 3060 | m_kernel.MemoryManager().OpenFirst(map_addr, num_pages); | ||
| 3061 | } else { | ||
| 3062 | m_kernel.MemoryManager().Open(map_addr, num_pages); | ||
| 3063 | } | ||
| 3064 | } | 3107 | } |
| 3065 | break; | 3108 | break; |
| 3066 | } | 3109 | } |
| @@ -3070,6 +3113,7 @@ Result KPageTable::Operate(KProcessAddress addr, size_t num_pages, KMemoryPermis | |||
| 3070 | } | 3113 | } |
| 3071 | case OperationType::ChangePermissions: | 3114 | case OperationType::ChangePermissions: |
| 3072 | case OperationType::ChangePermissionsAndRefresh: | 3115 | case OperationType::ChangePermissionsAndRefresh: |
| 3116 | case OperationType::ChangePermissionsAndRefreshAndFlush: | ||
| 3073 | break; | 3117 | break; |
| 3074 | default: | 3118 | default: |
| 3075 | ASSERT(false); | 3119 | ASSERT(false); |
| @@ -3089,79 +3133,79 @@ void KPageTable::FinalizeUpdate(PageLinkedList* page_list) { | |||
| 3089 | } | 3133 | } |
| 3090 | } | 3134 | } |
| 3091 | 3135 | ||
| 3092 | KProcessAddress KPageTable::GetRegionAddress(KMemoryState state) const { | 3136 | KProcessAddress KPageTable::GetRegionAddress(Svc::MemoryState state) const { |
| 3093 | switch (state) { | 3137 | switch (state) { |
| 3094 | case KMemoryState::Free: | 3138 | case Svc::MemoryState::Free: |
| 3095 | case KMemoryState::Kernel: | 3139 | case Svc::MemoryState::Kernel: |
| 3096 | return m_address_space_start; | 3140 | return m_address_space_start; |
| 3097 | case KMemoryState::Normal: | 3141 | case Svc::MemoryState::Normal: |
| 3098 | return m_heap_region_start; | 3142 | return m_heap_region_start; |
| 3099 | case KMemoryState::Ipc: | 3143 | case Svc::MemoryState::Ipc: |
| 3100 | case KMemoryState::NonSecureIpc: | 3144 | case Svc::MemoryState::NonSecureIpc: |
| 3101 | case KMemoryState::NonDeviceIpc: | 3145 | case Svc::MemoryState::NonDeviceIpc: |
| 3102 | return m_alias_region_start; | 3146 | return m_alias_region_start; |
| 3103 | case KMemoryState::Stack: | 3147 | case Svc::MemoryState::Stack: |
| 3104 | return m_stack_region_start; | 3148 | return m_stack_region_start; |
| 3105 | case KMemoryState::Static: | 3149 | case Svc::MemoryState::Static: |
| 3106 | case KMemoryState::ThreadLocal: | 3150 | case Svc::MemoryState::ThreadLocal: |
| 3107 | return m_kernel_map_region_start; | 3151 | return m_kernel_map_region_start; |
| 3108 | case KMemoryState::Io: | 3152 | case Svc::MemoryState::Io: |
| 3109 | case KMemoryState::Shared: | 3153 | case Svc::MemoryState::Shared: |
| 3110 | case KMemoryState::AliasCode: | 3154 | case Svc::MemoryState::AliasCode: |
| 3111 | case KMemoryState::AliasCodeData: | 3155 | case Svc::MemoryState::AliasCodeData: |
| 3112 | case KMemoryState::Transfered: | 3156 | case Svc::MemoryState::Transfered: |
| 3113 | case KMemoryState::SharedTransfered: | 3157 | case Svc::MemoryState::SharedTransfered: |
| 3114 | case KMemoryState::SharedCode: | 3158 | case Svc::MemoryState::SharedCode: |
| 3115 | case KMemoryState::GeneratedCode: | 3159 | case Svc::MemoryState::GeneratedCode: |
| 3116 | case KMemoryState::CodeOut: | 3160 | case Svc::MemoryState::CodeOut: |
| 3117 | case KMemoryState::Coverage: | 3161 | case Svc::MemoryState::Coverage: |
| 3118 | case KMemoryState::Insecure: | 3162 | case Svc::MemoryState::Insecure: |
| 3119 | return m_alias_code_region_start; | 3163 | return m_alias_code_region_start; |
| 3120 | case KMemoryState::Code: | 3164 | case Svc::MemoryState::Code: |
| 3121 | case KMemoryState::CodeData: | 3165 | case Svc::MemoryState::CodeData: |
| 3122 | return m_code_region_start; | 3166 | return m_code_region_start; |
| 3123 | default: | 3167 | default: |
| 3124 | UNREACHABLE(); | 3168 | UNREACHABLE(); |
| 3125 | } | 3169 | } |
| 3126 | } | 3170 | } |
| 3127 | 3171 | ||
| 3128 | size_t KPageTable::GetRegionSize(KMemoryState state) const { | 3172 | size_t KPageTable::GetRegionSize(Svc::MemoryState state) const { |
| 3129 | switch (state) { | 3173 | switch (state) { |
| 3130 | case KMemoryState::Free: | 3174 | case Svc::MemoryState::Free: |
| 3131 | case KMemoryState::Kernel: | 3175 | case Svc::MemoryState::Kernel: |
| 3132 | return m_address_space_end - m_address_space_start; | 3176 | return m_address_space_end - m_address_space_start; |
| 3133 | case KMemoryState::Normal: | 3177 | case Svc::MemoryState::Normal: |
| 3134 | return m_heap_region_end - m_heap_region_start; | 3178 | return m_heap_region_end - m_heap_region_start; |
| 3135 | case KMemoryState::Ipc: | 3179 | case Svc::MemoryState::Ipc: |
| 3136 | case KMemoryState::NonSecureIpc: | 3180 | case Svc::MemoryState::NonSecureIpc: |
| 3137 | case KMemoryState::NonDeviceIpc: | 3181 | case Svc::MemoryState::NonDeviceIpc: |
| 3138 | return m_alias_region_end - m_alias_region_start; | 3182 | return m_alias_region_end - m_alias_region_start; |
| 3139 | case KMemoryState::Stack: | 3183 | case Svc::MemoryState::Stack: |
| 3140 | return m_stack_region_end - m_stack_region_start; | 3184 | return m_stack_region_end - m_stack_region_start; |
| 3141 | case KMemoryState::Static: | 3185 | case Svc::MemoryState::Static: |
| 3142 | case KMemoryState::ThreadLocal: | 3186 | case Svc::MemoryState::ThreadLocal: |
| 3143 | return m_kernel_map_region_end - m_kernel_map_region_start; | 3187 | return m_kernel_map_region_end - m_kernel_map_region_start; |
| 3144 | case KMemoryState::Io: | 3188 | case Svc::MemoryState::Io: |
| 3145 | case KMemoryState::Shared: | 3189 | case Svc::MemoryState::Shared: |
| 3146 | case KMemoryState::AliasCode: | 3190 | case Svc::MemoryState::AliasCode: |
| 3147 | case KMemoryState::AliasCodeData: | 3191 | case Svc::MemoryState::AliasCodeData: |
| 3148 | case KMemoryState::Transfered: | 3192 | case Svc::MemoryState::Transfered: |
| 3149 | case KMemoryState::SharedTransfered: | 3193 | case Svc::MemoryState::SharedTransfered: |
| 3150 | case KMemoryState::SharedCode: | 3194 | case Svc::MemoryState::SharedCode: |
| 3151 | case KMemoryState::GeneratedCode: | 3195 | case Svc::MemoryState::GeneratedCode: |
| 3152 | case KMemoryState::CodeOut: | 3196 | case Svc::MemoryState::CodeOut: |
| 3153 | case KMemoryState::Coverage: | 3197 | case Svc::MemoryState::Coverage: |
| 3154 | case KMemoryState::Insecure: | 3198 | case Svc::MemoryState::Insecure: |
| 3155 | return m_alias_code_region_end - m_alias_code_region_start; | 3199 | return m_alias_code_region_end - m_alias_code_region_start; |
| 3156 | case KMemoryState::Code: | 3200 | case Svc::MemoryState::Code: |
| 3157 | case KMemoryState::CodeData: | 3201 | case Svc::MemoryState::CodeData: |
| 3158 | return m_code_region_end - m_code_region_start; | 3202 | return m_code_region_end - m_code_region_start; |
| 3159 | default: | 3203 | default: |
| 3160 | UNREACHABLE(); | 3204 | UNREACHABLE(); |
| 3161 | } | 3205 | } |
| 3162 | } | 3206 | } |
| 3163 | 3207 | ||
| 3164 | bool KPageTable::CanContain(KProcessAddress addr, size_t size, KMemoryState state) const { | 3208 | bool KPageTable::CanContain(KProcessAddress addr, size_t size, Svc::MemoryState state) const { |
| 3165 | const KProcessAddress end = addr + size; | 3209 | const KProcessAddress end = addr + size; |
| 3166 | const KProcessAddress last = end - 1; | 3210 | const KProcessAddress last = end - 1; |
| 3167 | 3211 | ||
| @@ -3175,32 +3219,32 @@ bool KPageTable::CanContain(KProcessAddress addr, size_t size, KMemoryState stat | |||
| 3175 | const bool is_in_alias = !(end <= m_alias_region_start || m_alias_region_end <= addr || | 3219 | const bool is_in_alias = !(end <= m_alias_region_start || m_alias_region_end <= addr || |
| 3176 | m_alias_region_start == m_alias_region_end); | 3220 | m_alias_region_start == m_alias_region_end); |
| 3177 | switch (state) { | 3221 | switch (state) { |
| 3178 | case KMemoryState::Free: | 3222 | case Svc::MemoryState::Free: |
| 3179 | case KMemoryState::Kernel: | 3223 | case Svc::MemoryState::Kernel: |
| 3180 | return is_in_region; | 3224 | return is_in_region; |
| 3181 | case KMemoryState::Io: | 3225 | case Svc::MemoryState::Io: |
| 3182 | case KMemoryState::Static: | 3226 | case Svc::MemoryState::Static: |
| 3183 | case KMemoryState::Code: | 3227 | case Svc::MemoryState::Code: |
| 3184 | case KMemoryState::CodeData: | 3228 | case Svc::MemoryState::CodeData: |
| 3185 | case KMemoryState::Shared: | 3229 | case Svc::MemoryState::Shared: |
| 3186 | case KMemoryState::AliasCode: | 3230 | case Svc::MemoryState::AliasCode: |
| 3187 | case KMemoryState::AliasCodeData: | 3231 | case Svc::MemoryState::AliasCodeData: |
| 3188 | case KMemoryState::Stack: | 3232 | case Svc::MemoryState::Stack: |
| 3189 | case KMemoryState::ThreadLocal: | 3233 | case Svc::MemoryState::ThreadLocal: |
| 3190 | case KMemoryState::Transfered: | 3234 | case Svc::MemoryState::Transfered: |
| 3191 | case KMemoryState::SharedTransfered: | 3235 | case Svc::MemoryState::SharedTransfered: |
| 3192 | case KMemoryState::SharedCode: | 3236 | case Svc::MemoryState::SharedCode: |
| 3193 | case KMemoryState::GeneratedCode: | 3237 | case Svc::MemoryState::GeneratedCode: |
| 3194 | case KMemoryState::CodeOut: | 3238 | case Svc::MemoryState::CodeOut: |
| 3195 | case KMemoryState::Coverage: | 3239 | case Svc::MemoryState::Coverage: |
| 3196 | case KMemoryState::Insecure: | 3240 | case Svc::MemoryState::Insecure: |
| 3197 | return is_in_region && !is_in_heap && !is_in_alias; | 3241 | return is_in_region && !is_in_heap && !is_in_alias; |
| 3198 | case KMemoryState::Normal: | 3242 | case Svc::MemoryState::Normal: |
| 3199 | ASSERT(is_in_heap); | 3243 | ASSERT(is_in_heap); |
| 3200 | return is_in_region && !is_in_alias; | 3244 | return is_in_region && !is_in_alias; |
| 3201 | case KMemoryState::Ipc: | 3245 | case Svc::MemoryState::Ipc: |
| 3202 | case KMemoryState::NonSecureIpc: | 3246 | case Svc::MemoryState::NonSecureIpc: |
| 3203 | case KMemoryState::NonDeviceIpc: | 3247 | case Svc::MemoryState::NonDeviceIpc: |
| 3204 | ASSERT(is_in_alias); | 3248 | ASSERT(is_in_alias); |
| 3205 | return is_in_region && !is_in_heap; | 3249 | return is_in_region && !is_in_heap; |
| 3206 | default: | 3250 | default: |
| @@ -3264,21 +3308,16 @@ Result KPageTable::CheckMemoryStateContiguous(size_t* out_blocks_needed, KProces | |||
| 3264 | 3308 | ||
| 3265 | Result KPageTable::CheckMemoryState(KMemoryState* out_state, KMemoryPermission* out_perm, | 3309 | Result KPageTable::CheckMemoryState(KMemoryState* out_state, KMemoryPermission* out_perm, |
| 3266 | KMemoryAttribute* out_attr, size_t* out_blocks_needed, | 3310 | KMemoryAttribute* out_attr, size_t* out_blocks_needed, |
| 3267 | KProcessAddress addr, size_t size, KMemoryState state_mask, | 3311 | KMemoryBlockManager::const_iterator it, |
| 3312 | KProcessAddress last_addr, KMemoryState state_mask, | ||
| 3268 | KMemoryState state, KMemoryPermission perm_mask, | 3313 | KMemoryState state, KMemoryPermission perm_mask, |
| 3269 | KMemoryPermission perm, KMemoryAttribute attr_mask, | 3314 | KMemoryPermission perm, KMemoryAttribute attr_mask, |
| 3270 | KMemoryAttribute attr, KMemoryAttribute ignore_attr) const { | 3315 | KMemoryAttribute attr, KMemoryAttribute ignore_attr) const { |
| 3271 | ASSERT(this->IsLockedByCurrentThread()); | 3316 | ASSERT(this->IsLockedByCurrentThread()); |
| 3272 | 3317 | ||
| 3273 | // Get information about the first block. | 3318 | // Get information about the first block. |
| 3274 | const KProcessAddress last_addr = addr + size - 1; | ||
| 3275 | KMemoryBlockManager::const_iterator it = m_memory_block_manager.FindIterator(addr); | ||
| 3276 | KMemoryInfo info = it->GetMemoryInfo(); | 3319 | KMemoryInfo info = it->GetMemoryInfo(); |
| 3277 | 3320 | ||
| 3278 | // If the start address isn't aligned, we need a block. | ||
| 3279 | const size_t blocks_for_start_align = | ||
| 3280 | (Common::AlignDown(GetInteger(addr), PageSize) != info.GetAddress()) ? 1 : 0; | ||
| 3281 | |||
| 3282 | // Validate all blocks in the range have correct state. | 3321 | // Validate all blocks in the range have correct state. |
| 3283 | const KMemoryState first_state = info.m_state; | 3322 | const KMemoryState first_state = info.m_state; |
| 3284 | const KMemoryPermission first_perm = info.m_permission; | 3323 | const KMemoryPermission first_perm = info.m_permission; |
| @@ -3304,10 +3343,6 @@ Result KPageTable::CheckMemoryState(KMemoryState* out_state, KMemoryPermission* | |||
| 3304 | info = it->GetMemoryInfo(); | 3343 | info = it->GetMemoryInfo(); |
| 3305 | } | 3344 | } |
| 3306 | 3345 | ||
| 3307 | // If the end address isn't aligned, we need a block. | ||
| 3308 | const size_t blocks_for_end_align = | ||
| 3309 | (Common::AlignUp(GetInteger(addr) + size, PageSize) != info.GetEndAddress()) ? 1 : 0; | ||
| 3310 | |||
| 3311 | // Write output state. | 3346 | // Write output state. |
| 3312 | if (out_state != nullptr) { | 3347 | if (out_state != nullptr) { |
| 3313 | *out_state = first_state; | 3348 | *out_state = first_state; |
| @@ -3318,9 +3353,39 @@ Result KPageTable::CheckMemoryState(KMemoryState* out_state, KMemoryPermission* | |||
| 3318 | if (out_attr != nullptr) { | 3353 | if (out_attr != nullptr) { |
| 3319 | *out_attr = static_cast<KMemoryAttribute>(first_attr & ~ignore_attr); | 3354 | *out_attr = static_cast<KMemoryAttribute>(first_attr & ~ignore_attr); |
| 3320 | } | 3355 | } |
| 3356 | |||
| 3357 | // If the end address isn't aligned, we need a block. | ||
| 3321 | if (out_blocks_needed != nullptr) { | 3358 | if (out_blocks_needed != nullptr) { |
| 3322 | *out_blocks_needed = blocks_for_start_align + blocks_for_end_align; | 3359 | const size_t blocks_for_end_align = |
| 3360 | (Common::AlignDown(GetInteger(last_addr), PageSize) + PageSize != info.GetEndAddress()) | ||
| 3361 | ? 1 | ||
| 3362 | : 0; | ||
| 3363 | *out_blocks_needed = blocks_for_end_align; | ||
| 3323 | } | 3364 | } |
| 3365 | |||
| 3366 | R_SUCCEED(); | ||
| 3367 | } | ||
| 3368 | |||
| 3369 | Result KPageTable::CheckMemoryState(KMemoryState* out_state, KMemoryPermission* out_perm, | ||
| 3370 | KMemoryAttribute* out_attr, size_t* out_blocks_needed, | ||
| 3371 | KProcessAddress addr, size_t size, KMemoryState state_mask, | ||
| 3372 | KMemoryState state, KMemoryPermission perm_mask, | ||
| 3373 | KMemoryPermission perm, KMemoryAttribute attr_mask, | ||
| 3374 | KMemoryAttribute attr, KMemoryAttribute ignore_attr) const { | ||
| 3375 | ASSERT(this->IsLockedByCurrentThread()); | ||
| 3376 | |||
| 3377 | // Check memory state. | ||
| 3378 | const KProcessAddress last_addr = addr + size - 1; | ||
| 3379 | KMemoryBlockManager::const_iterator it = m_memory_block_manager.FindIterator(addr); | ||
| 3380 | R_TRY(this->CheckMemoryState(out_state, out_perm, out_attr, out_blocks_needed, it, last_addr, | ||
| 3381 | state_mask, state, perm_mask, perm, attr_mask, attr, ignore_attr)); | ||
| 3382 | |||
| 3383 | // If the start address isn't aligned, we need a block. | ||
| 3384 | if (out_blocks_needed != nullptr && | ||
| 3385 | Common::AlignDown(GetInteger(addr), PageSize) != it->GetAddress()) { | ||
| 3386 | ++(*out_blocks_needed); | ||
| 3387 | } | ||
| 3388 | |||
| 3324 | R_SUCCEED(); | 3389 | R_SUCCEED(); |
| 3325 | } | 3390 | } |
| 3326 | 3391 | ||
| @@ -3388,6 +3453,11 @@ Result KPageTable::LockMemoryAndOpen(KPageGroup* out_pg, KPhysicalAddress* out_K | |||
| 3388 | new_attr, KMemoryBlockDisableMergeAttribute::Locked, | 3453 | new_attr, KMemoryBlockDisableMergeAttribute::Locked, |
| 3389 | KMemoryBlockDisableMergeAttribute::None); | 3454 | KMemoryBlockDisableMergeAttribute::None); |
| 3390 | 3455 | ||
| 3456 | // If we have an output page group, open. | ||
| 3457 | if (out_pg) { | ||
| 3458 | out_pg->Open(); | ||
| 3459 | } | ||
| 3460 | |||
| 3391 | R_SUCCEED(); | 3461 | R_SUCCEED(); |
| 3392 | } | 3462 | } |
| 3393 | 3463 | ||
diff --git a/src/core/hle/kernel/k_page_table.h b/src/core/hle/kernel/k_page_table.h index b9e8c6042..66f16faaf 100644 --- a/src/core/hle/kernel/k_page_table.h +++ b/src/core/hle/kernel/k_page_table.h | |||
| @@ -63,7 +63,7 @@ public: | |||
| 63 | explicit KPageTable(Core::System& system_); | 63 | explicit KPageTable(Core::System& system_); |
| 64 | ~KPageTable(); | 64 | ~KPageTable(); |
| 65 | 65 | ||
| 66 | Result InitializeForProcess(FileSys::ProgramAddressSpaceType as_type, bool enable_aslr, | 66 | Result InitializeForProcess(Svc::CreateProcessFlag as_type, bool enable_aslr, |
| 67 | bool enable_das_merge, bool from_back, KMemoryManager::Pool pool, | 67 | bool enable_das_merge, bool from_back, KMemoryManager::Pool pool, |
| 68 | KProcessAddress code_addr, size_t code_size, | 68 | KProcessAddress code_addr, size_t code_size, |
| 69 | KSystemResource* system_resource, KResourceLimit* resource_limit, | 69 | KSystemResource* system_resource, KResourceLimit* resource_limit, |
| @@ -104,6 +104,9 @@ public: | |||
| 104 | Result CleanupForIpcServer(KProcessAddress address, size_t size, KMemoryState dst_state); | 104 | Result CleanupForIpcServer(KProcessAddress address, size_t size, KMemoryState dst_state); |
| 105 | Result CleanupForIpcClient(KProcessAddress address, size_t size, KMemoryState dst_state); | 105 | Result CleanupForIpcClient(KProcessAddress address, size_t size, KMemoryState dst_state); |
| 106 | 106 | ||
| 107 | Result LockForTransferMemory(KPageGroup* out, KProcessAddress address, size_t size, | ||
| 108 | KMemoryPermission perm); | ||
| 109 | Result UnlockForTransferMemory(KProcessAddress address, size_t size, const KPageGroup& pg); | ||
| 107 | Result LockForCodeMemory(KPageGroup* out, KProcessAddress addr, size_t size); | 110 | Result LockForCodeMemory(KPageGroup* out, KProcessAddress addr, size_t size); |
| 108 | Result UnlockForCodeMemory(KProcessAddress addr, size_t size, const KPageGroup& pg); | 111 | Result UnlockForCodeMemory(KProcessAddress addr, size_t size, const KPageGroup& pg); |
| 109 | Result MakeAndOpenPageGroup(KPageGroup* out, KProcessAddress address, size_t num_pages, | 112 | Result MakeAndOpenPageGroup(KPageGroup* out, KProcessAddress address, size_t num_pages, |
| @@ -123,8 +126,6 @@ public: | |||
| 123 | return m_block_info_manager; | 126 | return m_block_info_manager; |
| 124 | } | 127 | } |
| 125 | 128 | ||
| 126 | bool CanContain(KProcessAddress addr, size_t size, KMemoryState state) const; | ||
| 127 | |||
| 128 | Result MapPages(KProcessAddress* out_addr, size_t num_pages, size_t alignment, | 129 | Result MapPages(KProcessAddress* out_addr, size_t num_pages, size_t alignment, |
| 129 | KPhysicalAddress phys_addr, KProcessAddress region_start, | 130 | KPhysicalAddress phys_addr, KProcessAddress region_start, |
| 130 | size_t region_num_pages, KMemoryState state, KMemoryPermission perm) { | 131 | size_t region_num_pages, KMemoryState state, KMemoryPermission perm) { |
| @@ -159,6 +160,21 @@ public: | |||
| 159 | void RemapPageGroup(PageLinkedList* page_list, KProcessAddress address, size_t size, | 160 | void RemapPageGroup(PageLinkedList* page_list, KProcessAddress address, size_t size, |
| 160 | const KPageGroup& pg); | 161 | const KPageGroup& pg); |
| 161 | 162 | ||
| 163 | KProcessAddress GetRegionAddress(Svc::MemoryState state) const; | ||
| 164 | size_t GetRegionSize(Svc::MemoryState state) const; | ||
| 165 | bool CanContain(KProcessAddress addr, size_t size, Svc::MemoryState state) const; | ||
| 166 | |||
| 167 | KProcessAddress GetRegionAddress(KMemoryState state) const { | ||
| 168 | return this->GetRegionAddress(static_cast<Svc::MemoryState>(state & KMemoryState::Mask)); | ||
| 169 | } | ||
| 170 | size_t GetRegionSize(KMemoryState state) const { | ||
| 171 | return this->GetRegionSize(static_cast<Svc::MemoryState>(state & KMemoryState::Mask)); | ||
| 172 | } | ||
| 173 | bool CanContain(KProcessAddress addr, size_t size, KMemoryState state) const { | ||
| 174 | return this->CanContain(addr, size, | ||
| 175 | static_cast<Svc::MemoryState>(state & KMemoryState::Mask)); | ||
| 176 | } | ||
| 177 | |||
| 162 | protected: | 178 | protected: |
| 163 | struct PageLinkedList { | 179 | struct PageLinkedList { |
| 164 | private: | 180 | private: |
| @@ -201,12 +217,13 @@ protected: | |||
| 201 | private: | 217 | private: |
| 202 | enum class OperationType : u32 { | 218 | enum class OperationType : u32 { |
| 203 | Map = 0, | 219 | Map = 0, |
| 204 | MapFirst = 1, | 220 | MapGroup = 1, |
| 205 | MapGroup = 2, | 221 | MapFirstGroup = 2, |
| 206 | Unmap = 3, | 222 | Unmap = 3, |
| 207 | ChangePermissions = 4, | 223 | ChangePermissions = 4, |
| 208 | ChangePermissionsAndRefresh = 5, | 224 | ChangePermissionsAndRefresh = 5, |
| 209 | Separate = 6, | 225 | ChangePermissionsAndRefreshAndFlush = 6, |
| 226 | Separate = 7, | ||
| 210 | }; | 227 | }; |
| 211 | 228 | ||
| 212 | static constexpr KMemoryAttribute DefaultMemoryIgnoreAttr = | 229 | static constexpr KMemoryAttribute DefaultMemoryIgnoreAttr = |
| @@ -225,8 +242,6 @@ private: | |||
| 225 | Result Operate(KProcessAddress addr, size_t num_pages, KMemoryPermission perm, | 242 | Result Operate(KProcessAddress addr, size_t num_pages, KMemoryPermission perm, |
| 226 | OperationType operation, KPhysicalAddress map_addr = 0); | 243 | OperationType operation, KPhysicalAddress map_addr = 0); |
| 227 | void FinalizeUpdate(PageLinkedList* page_list); | 244 | void FinalizeUpdate(PageLinkedList* page_list); |
| 228 | KProcessAddress GetRegionAddress(KMemoryState state) const; | ||
| 229 | size_t GetRegionSize(KMemoryState state) const; | ||
| 230 | 245 | ||
| 231 | KProcessAddress FindFreeArea(KProcessAddress region_start, size_t region_num_pages, | 246 | KProcessAddress FindFreeArea(KProcessAddress region_start, size_t region_num_pages, |
| 232 | size_t num_pages, size_t alignment, size_t offset, | 247 | size_t num_pages, size_t alignment, size_t offset, |
| @@ -249,6 +264,13 @@ private: | |||
| 249 | KMemoryAttribute attr_mask, KMemoryAttribute attr) const; | 264 | KMemoryAttribute attr_mask, KMemoryAttribute attr) const; |
| 250 | Result CheckMemoryState(KMemoryState* out_state, KMemoryPermission* out_perm, | 265 | Result CheckMemoryState(KMemoryState* out_state, KMemoryPermission* out_perm, |
| 251 | KMemoryAttribute* out_attr, size_t* out_blocks_needed, | 266 | KMemoryAttribute* out_attr, size_t* out_blocks_needed, |
| 267 | KMemoryBlockManager::const_iterator it, KProcessAddress last_addr, | ||
| 268 | KMemoryState state_mask, KMemoryState state, | ||
| 269 | KMemoryPermission perm_mask, KMemoryPermission perm, | ||
| 270 | KMemoryAttribute attr_mask, KMemoryAttribute attr, | ||
| 271 | KMemoryAttribute ignore_attr = DefaultMemoryIgnoreAttr) const; | ||
| 272 | Result CheckMemoryState(KMemoryState* out_state, KMemoryPermission* out_perm, | ||
| 273 | KMemoryAttribute* out_attr, size_t* out_blocks_needed, | ||
| 252 | KProcessAddress addr, size_t size, KMemoryState state_mask, | 274 | KProcessAddress addr, size_t size, KMemoryState state_mask, |
| 253 | KMemoryState state, KMemoryPermission perm_mask, KMemoryPermission perm, | 275 | KMemoryState state, KMemoryPermission perm_mask, KMemoryPermission perm, |
| 254 | KMemoryAttribute attr_mask, KMemoryAttribute attr, | 276 | KMemoryAttribute attr_mask, KMemoryAttribute attr, |
| @@ -378,7 +400,7 @@ public: | |||
| 378 | constexpr size_t GetAliasCodeRegionSize() const { | 400 | constexpr size_t GetAliasCodeRegionSize() const { |
| 379 | return m_alias_code_region_end - m_alias_code_region_start; | 401 | return m_alias_code_region_end - m_alias_code_region_start; |
| 380 | } | 402 | } |
| 381 | size_t GetNormalMemorySize() { | 403 | size_t GetNormalMemorySize() const { |
| 382 | KScopedLightLock lk(m_general_lock); | 404 | KScopedLightLock lk(m_general_lock); |
| 383 | return GetHeapSize() + m_mapped_physical_memory_size; | 405 | return GetHeapSize() + m_mapped_physical_memory_size; |
| 384 | } | 406 | } |
diff --git a/src/core/hle/kernel/k_process.cpp b/src/core/hle/kernel/k_process.cpp index 4a099286b..1f4b0755d 100644 --- a/src/core/hle/kernel/k_process.cpp +++ b/src/core/hle/kernel/k_process.cpp | |||
| @@ -1,515 +1,598 @@ | |||
| 1 | // SPDX-FileCopyrightText: 2015 Citra Emulator Project | 1 | // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project |
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | 2 | // SPDX-License-Identifier: GPL-2.0-or-later |
| 3 | 3 | ||
| 4 | #include <algorithm> | ||
| 5 | #include <bitset> | ||
| 6 | #include <ctime> | ||
| 7 | #include <memory> | ||
| 8 | #include <random> | 4 | #include <random> |
| 9 | #include "common/alignment.h" | ||
| 10 | #include "common/assert.h" | ||
| 11 | #include "common/logging/log.h" | ||
| 12 | #include "common/scope_exit.h" | 5 | #include "common/scope_exit.h" |
| 13 | #include "common/settings.h" | 6 | #include "common/settings.h" |
| 14 | #include "core/core.h" | 7 | #include "core/core.h" |
| 15 | #include "core/file_sys/program_metadata.h" | ||
| 16 | #include "core/hle/kernel/code_set.h" | ||
| 17 | #include "core/hle/kernel/k_memory_block_manager.h" | ||
| 18 | #include "core/hle/kernel/k_page_table.h" | ||
| 19 | #include "core/hle/kernel/k_process.h" | 8 | #include "core/hle/kernel/k_process.h" |
| 20 | #include "core/hle/kernel/k_resource_limit.h" | ||
| 21 | #include "core/hle/kernel/k_scheduler.h" | ||
| 22 | #include "core/hle/kernel/k_scoped_resource_reservation.h" | 9 | #include "core/hle/kernel/k_scoped_resource_reservation.h" |
| 23 | #include "core/hle/kernel/k_shared_memory.h" | 10 | #include "core/hle/kernel/k_shared_memory.h" |
| 24 | #include "core/hle/kernel/k_shared_memory_info.h" | 11 | #include "core/hle/kernel/k_shared_memory_info.h" |
| 25 | #include "core/hle/kernel/k_thread.h" | 12 | #include "core/hle/kernel/k_thread_local_page.h" |
| 26 | #include "core/hle/kernel/kernel.h" | 13 | #include "core/hle/kernel/k_thread_queue.h" |
| 27 | #include "core/hle/kernel/svc_results.h" | 14 | #include "core/hle/kernel/k_worker_task_manager.h" |
| 28 | #include "core/memory.h" | ||
| 29 | 15 | ||
| 30 | namespace Kernel { | 16 | namespace Kernel { |
| 31 | namespace { | ||
| 32 | /** | ||
| 33 | * Sets up the primary application thread | ||
| 34 | * | ||
| 35 | * @param system The system instance to create the main thread under. | ||
| 36 | * @param owner_process The parent process for the main thread | ||
| 37 | * @param priority The priority to give the main thread | ||
| 38 | */ | ||
| 39 | void SetupMainThread(Core::System& system, KProcess& owner_process, u32 priority, | ||
| 40 | KProcessAddress stack_top) { | ||
| 41 | const KProcessAddress entry_point = owner_process.GetEntryPoint(); | ||
| 42 | ASSERT(owner_process.GetResourceLimit()->Reserve(LimitableResource::ThreadCountMax, 1)); | ||
| 43 | |||
| 44 | KThread* thread = KThread::Create(system.Kernel()); | ||
| 45 | SCOPE_EXIT({ thread->Close(); }); | ||
| 46 | |||
| 47 | ASSERT(KThread::InitializeUserThread(system, thread, entry_point, 0, stack_top, priority, | ||
| 48 | owner_process.GetIdealCoreId(), | ||
| 49 | std::addressof(owner_process)) | ||
| 50 | .IsSuccess()); | ||
| 51 | |||
| 52 | // Register 1 must be a handle to the main thread | ||
| 53 | Handle thread_handle{}; | ||
| 54 | owner_process.GetHandleTable().Add(std::addressof(thread_handle), thread); | ||
| 55 | |||
| 56 | thread->GetContext32().cpu_registers[0] = 0; | ||
| 57 | thread->GetContext64().cpu_registers[0] = 0; | ||
| 58 | thread->GetContext32().cpu_registers[1] = thread_handle; | ||
| 59 | thread->GetContext64().cpu_registers[1] = thread_handle; | ||
| 60 | |||
| 61 | if (system.DebuggerEnabled()) { | ||
| 62 | thread->RequestSuspend(SuspendType::Debug); | ||
| 63 | } | ||
| 64 | 17 | ||
| 65 | // Run our thread. | 18 | namespace { |
| 66 | void(thread->Run()); | ||
| 67 | } | ||
| 68 | } // Anonymous namespace | ||
| 69 | 19 | ||
| 70 | Result KProcess::Initialize(KProcess* process, Core::System& system, std::string process_name, | 20 | Result TerminateChildren(KernelCore& kernel, KProcess* process, |
| 71 | ProcessType type, KResourceLimit* res_limit) { | 21 | const KThread* thread_to_not_terminate) { |
| 72 | auto& kernel = system.Kernel(); | 22 | // Request that all children threads terminate. |
| 23 | { | ||
| 24 | KScopedLightLock proc_lk(process->GetListLock()); | ||
| 25 | KScopedSchedulerLock sl(kernel); | ||
| 26 | |||
| 27 | if (thread_to_not_terminate != nullptr && | ||
| 28 | process->GetPinnedThread(GetCurrentCoreId(kernel)) == thread_to_not_terminate) { | ||
| 29 | // NOTE: Here Nintendo unpins the current thread instead of the thread_to_not_terminate. | ||
| 30 | // This is valid because the only caller which uses non-nullptr as argument uses | ||
| 31 | // GetCurrentThreadPointer(), but it's still notable because it seems incorrect at | ||
| 32 | // first glance. | ||
| 33 | process->UnpinCurrentThread(); | ||
| 34 | } | ||
| 73 | 35 | ||
| 74 | process->name = std::move(process_name); | 36 | auto& thread_list = process->GetThreadList(); |
| 75 | process->m_resource_limit = res_limit; | 37 | for (auto it = thread_list.begin(); it != thread_list.end(); ++it) { |
| 76 | process->m_system_resource_address = 0; | 38 | if (KThread* thread = std::addressof(*it); thread != thread_to_not_terminate) { |
| 77 | process->m_state = State::Created; | 39 | if (thread->GetState() != ThreadState::Terminated) { |
| 78 | process->m_program_id = 0; | 40 | thread->RequestTerminate(); |
| 79 | process->m_process_id = type == ProcessType::KernelInternal ? kernel.CreateNewKernelProcessID() | 41 | } |
| 80 | : kernel.CreateNewUserProcessID(); | 42 | } |
| 81 | process->m_capabilities.InitializeForMetadatalessProcess(); | 43 | } |
| 82 | process->m_is_initialized = true; | 44 | } |
| 83 | 45 | ||
| 84 | std::mt19937 rng(Settings::values.rng_seed_enabled ? Settings::values.rng_seed.GetValue() | 46 | // Wait for all children threads to terminate. |
| 85 | : static_cast<u32>(std::time(nullptr))); | 47 | while (true) { |
| 86 | std::uniform_int_distribution<u64> distribution; | 48 | // Get the next child. |
| 87 | std::generate(process->m_random_entropy.begin(), process->m_random_entropy.end(), | 49 | KThread* cur_child = nullptr; |
| 88 | [&] { return distribution(rng); }); | 50 | { |
| 51 | KScopedLightLock proc_lk(process->GetListLock()); | ||
| 52 | |||
| 53 | auto& thread_list = process->GetThreadList(); | ||
| 54 | for (auto it = thread_list.begin(); it != thread_list.end(); ++it) { | ||
| 55 | if (KThread* thread = std::addressof(*it); thread != thread_to_not_terminate) { | ||
| 56 | if (thread->GetState() != ThreadState::Terminated) { | ||
| 57 | if (thread->Open()) { | ||
| 58 | cur_child = thread; | ||
| 59 | break; | ||
| 60 | } | ||
| 61 | } | ||
| 62 | } | ||
| 63 | } | ||
| 64 | } | ||
| 89 | 65 | ||
| 90 | kernel.AppendNewProcess(process); | 66 | // If we didn't find any non-terminated children, we're done. |
| 67 | if (cur_child == nullptr) { | ||
| 68 | break; | ||
| 69 | } | ||
| 91 | 70 | ||
| 92 | // Clear remaining fields. | 71 | // Terminate and close the thread. |
| 93 | process->m_num_running_threads = 0; | 72 | SCOPE_EXIT({ cur_child->Close(); }); |
| 94 | process->m_is_signaled = false; | ||
| 95 | process->m_exception_thread = nullptr; | ||
| 96 | process->m_is_suspended = false; | ||
| 97 | process->m_schedule_count = 0; | ||
| 98 | process->m_is_handle_table_initialized = false; | ||
| 99 | process->m_is_hbl = false; | ||
| 100 | 73 | ||
| 101 | // Open a reference to the resource limit. | 74 | if (const Result terminate_result = cur_child->Terminate(); |
| 102 | process->m_resource_limit->Open(); | 75 | ResultTerminationRequested == terminate_result) { |
| 76 | R_THROW(terminate_result); | ||
| 77 | } | ||
| 78 | } | ||
| 103 | 79 | ||
| 104 | R_SUCCEED(); | 80 | R_SUCCEED(); |
| 105 | } | 81 | } |
| 106 | 82 | ||
| 107 | void KProcess::DoWorkerTaskImpl() { | 83 | class ThreadQueueImplForKProcessEnterUserException final : public KThreadQueue { |
| 108 | UNIMPLEMENTED(); | 84 | private: |
| 109 | } | 85 | KThread** m_exception_thread; |
| 110 | |||
| 111 | KResourceLimit* KProcess::GetResourceLimit() const { | ||
| 112 | return m_resource_limit; | ||
| 113 | } | ||
| 114 | 86 | ||
| 115 | void KProcess::IncrementRunningThreadCount() { | 87 | public: |
| 116 | ASSERT(m_num_running_threads.load() >= 0); | 88 | explicit ThreadQueueImplForKProcessEnterUserException(KernelCore& kernel, KThread** t) |
| 117 | ++m_num_running_threads; | 89 | : KThreadQueue(kernel), m_exception_thread(t) {} |
| 118 | } | ||
| 119 | 90 | ||
| 120 | void KProcess::DecrementRunningThreadCount() { | 91 | virtual void EndWait(KThread* waiting_thread, Result wait_result) override { |
| 121 | ASSERT(m_num_running_threads.load() > 0); | 92 | // Set the exception thread. |
| 93 | *m_exception_thread = waiting_thread; | ||
| 122 | 94 | ||
| 123 | if (const auto prev = m_num_running_threads--; prev == 1) { | 95 | // Invoke the base end wait handler. |
| 124 | // TODO(bunnei): Process termination to be implemented when multiprocess is supported. | 96 | KThreadQueue::EndWait(waiting_thread, wait_result); |
| 125 | } | 97 | } |
| 126 | } | ||
| 127 | 98 | ||
| 128 | u64 KProcess::GetTotalPhysicalMemoryAvailable() { | 99 | virtual void CancelWait(KThread* waiting_thread, Result wait_result, |
| 129 | const u64 capacity{m_resource_limit->GetFreeValue(LimitableResource::PhysicalMemoryMax) + | 100 | bool cancel_timer_task) override { |
| 130 | m_page_table.GetNormalMemorySize() + GetSystemResourceSize() + m_image_size + | 101 | // Remove the thread as a waiter on its mutex owner. |
| 131 | m_main_thread_stack_size}; | 102 | waiting_thread->GetLockOwner()->RemoveWaiter(waiting_thread); |
| 132 | if (const auto pool_size = m_kernel.MemoryManager().GetSize(KMemoryManager::Pool::Application); | 103 | |
| 133 | capacity != pool_size) { | 104 | // Invoke the base cancel wait handler. |
| 134 | LOG_WARNING(Kernel, "capacity {} != application pool size {}", capacity, pool_size); | 105 | KThreadQueue::CancelWait(waiting_thread, wait_result, cancel_timer_task); |
| 135 | } | ||
| 136 | if (capacity < m_memory_usage_capacity) { | ||
| 137 | return capacity; | ||
| 138 | } | 106 | } |
| 139 | return m_memory_usage_capacity; | 107 | }; |
| 140 | } | ||
| 141 | 108 | ||
| 142 | u64 KProcess::GetTotalPhysicalMemoryAvailableWithoutSystemResource() { | 109 | void GenerateRandom(std::span<u64> out_random) { |
| 143 | return this->GetTotalPhysicalMemoryAvailable() - this->GetSystemResourceSize(); | 110 | std::mt19937 rng(Settings::values.rng_seed_enabled ? Settings::values.rng_seed.GetValue() |
| 111 | : static_cast<u32>(std::time(nullptr))); | ||
| 112 | std::uniform_int_distribution<u64> distribution; | ||
| 113 | std::generate(out_random.begin(), out_random.end(), [&] { return distribution(rng); }); | ||
| 144 | } | 114 | } |
| 145 | 115 | ||
| 146 | u64 KProcess::GetTotalPhysicalMemoryUsed() { | 116 | } // namespace |
| 147 | return m_image_size + m_main_thread_stack_size + m_page_table.GetNormalMemorySize() + | ||
| 148 | this->GetSystemResourceSize(); | ||
| 149 | } | ||
| 150 | 117 | ||
| 151 | u64 KProcess::GetTotalPhysicalMemoryUsedWithoutSystemResource() { | 118 | void KProcess::Finalize() { |
| 152 | return this->GetTotalPhysicalMemoryUsed() - this->GetSystemResourceUsage(); | 119 | // Delete the process local region. |
| 153 | } | 120 | this->DeleteThreadLocalRegion(m_plr_address); |
| 154 | 121 | ||
| 155 | bool KProcess::ReleaseUserException(KThread* thread) { | 122 | // Get the used memory size. |
| 156 | KScopedSchedulerLock sl{m_kernel}; | 123 | const size_t used_memory_size = this->GetUsedNonSystemUserPhysicalMemorySize(); |
| 157 | 124 | ||
| 158 | if (m_exception_thread == thread) { | 125 | // Finalize the page table. |
| 159 | m_exception_thread = nullptr; | 126 | m_page_table.Finalize(); |
| 160 | 127 | ||
| 161 | // Remove waiter thread. | 128 | // Finish using our system resource. |
| 162 | bool has_waiters{}; | 129 | if (m_system_resource) { |
| 163 | if (KThread* next = thread->RemoveKernelWaiterByKey( | 130 | if (m_system_resource->IsSecureResource()) { |
| 164 | std::addressof(has_waiters), | 131 | // Finalize optimized memory. If memory wasn't optimized, this is a no-op. |
| 165 | reinterpret_cast<uintptr_t>(std::addressof(m_exception_thread))); | 132 | m_kernel.MemoryManager().FinalizeOptimizedMemory(this->GetId(), m_memory_pool); |
| 166 | next != nullptr) { | ||
| 167 | next->EndWait(ResultSuccess); | ||
| 168 | } | 133 | } |
| 169 | 134 | ||
| 170 | KScheduler::SetSchedulerUpdateNeeded(m_kernel); | 135 | m_system_resource->Close(); |
| 171 | 136 | m_system_resource = nullptr; | |
| 172 | return true; | ||
| 173 | } else { | ||
| 174 | return false; | ||
| 175 | } | 137 | } |
| 176 | } | ||
| 177 | |||
| 178 | void KProcess::PinCurrentThread(s32 core_id) { | ||
| 179 | ASSERT(KScheduler::IsSchedulerLockedByCurrentThread(m_kernel)); | ||
| 180 | 138 | ||
| 181 | // Get the current thread. | 139 | // Free all shared memory infos. |
| 182 | KThread* cur_thread = | 140 | { |
| 183 | m_kernel.Scheduler(static_cast<std::size_t>(core_id)).GetSchedulerCurrentThread(); | 141 | auto it = m_shared_memory_list.begin(); |
| 142 | while (it != m_shared_memory_list.end()) { | ||
| 143 | KSharedMemoryInfo* info = std::addressof(*it); | ||
| 144 | KSharedMemory* shmem = info->GetSharedMemory(); | ||
| 184 | 145 | ||
| 185 | // If the thread isn't terminated, pin it. | 146 | while (!info->Close()) { |
| 186 | if (!cur_thread->IsTerminationRequested()) { | 147 | shmem->Close(); |
| 187 | // Pin it. | 148 | } |
| 188 | this->PinThread(core_id, cur_thread); | 149 | shmem->Close(); |
| 189 | cur_thread->Pin(core_id); | ||
| 190 | 150 | ||
| 191 | // An update is needed. | 151 | it = m_shared_memory_list.erase(it); |
| 192 | KScheduler::SetSchedulerUpdateNeeded(m_kernel); | 152 | KSharedMemoryInfo::Free(m_kernel, info); |
| 153 | } | ||
| 193 | } | 154 | } |
| 194 | } | ||
| 195 | 155 | ||
| 196 | void KProcess::UnpinCurrentThread(s32 core_id) { | 156 | // Our thread local page list must be empty at this point. |
| 197 | ASSERT(KScheduler::IsSchedulerLockedByCurrentThread(m_kernel)); | 157 | ASSERT(m_partially_used_tlp_tree.empty()); |
| 198 | 158 | ASSERT(m_fully_used_tlp_tree.empty()); | |
| 199 | // Get the current thread. | ||
| 200 | KThread* cur_thread = | ||
| 201 | m_kernel.Scheduler(static_cast<std::size_t>(core_id)).GetSchedulerCurrentThread(); | ||
| 202 | 159 | ||
| 203 | // Unpin it. | 160 | // Release memory to the resource limit. |
| 204 | cur_thread->Unpin(); | 161 | if (m_resource_limit != nullptr) { |
| 205 | this->UnpinThread(core_id, cur_thread); | 162 | ASSERT(used_memory_size >= m_memory_release_hint); |
| 163 | m_resource_limit->Release(Svc::LimitableResource::PhysicalMemoryMax, used_memory_size, | ||
| 164 | used_memory_size - m_memory_release_hint); | ||
| 165 | m_resource_limit->Close(); | ||
| 166 | } | ||
| 206 | 167 | ||
| 207 | // An update is needed. | 168 | // Perform inherited finalization. |
| 208 | KScheduler::SetSchedulerUpdateNeeded(m_kernel); | 169 | KSynchronizationObject::Finalize(); |
| 209 | } | 170 | } |
| 210 | 171 | ||
| 211 | void KProcess::UnpinThread(KThread* thread) { | 172 | Result KProcess::Initialize(const Svc::CreateProcessParameter& params, KResourceLimit* res_limit, |
| 212 | ASSERT(KScheduler::IsSchedulerLockedByCurrentThread(m_kernel)); | 173 | bool is_real) { |
| 213 | 174 | // TODO: remove this special case | |
| 214 | // Get the thread's core id. | 175 | if (is_real) { |
| 215 | const auto core_id = thread->GetActiveCore(); | 176 | // Create and clear the process local region. |
| 177 | R_TRY(this->CreateThreadLocalRegion(std::addressof(m_plr_address))); | ||
| 178 | this->GetMemory().ZeroBlock(m_plr_address, Svc::ThreadLocalRegionSize); | ||
| 179 | } | ||
| 216 | 180 | ||
| 217 | // Unpin it. | 181 | // Copy in the name from parameters. |
| 218 | this->UnpinThread(core_id, thread); | 182 | static_assert(sizeof(params.name) < sizeof(m_name)); |
| 219 | thread->Unpin(); | 183 | std::memcpy(m_name.data(), params.name.data(), sizeof(params.name)); |
| 184 | m_name[sizeof(params.name)] = 0; | ||
| 185 | |||
| 186 | // Set misc fields. | ||
| 187 | m_state = State::Created; | ||
| 188 | m_main_thread_stack_size = 0; | ||
| 189 | m_used_kernel_memory_size = 0; | ||
| 190 | m_ideal_core_id = 0; | ||
| 191 | m_flags = params.flags; | ||
| 192 | m_version = params.version; | ||
| 193 | m_program_id = params.program_id; | ||
| 194 | m_code_address = params.code_address; | ||
| 195 | m_code_size = params.code_num_pages * PageSize; | ||
| 196 | m_is_application = True(params.flags & Svc::CreateProcessFlag::IsApplication); | ||
| 197 | |||
| 198 | // Set thread fields. | ||
| 199 | for (size_t i = 0; i < Core::Hardware::NUM_CPU_CORES; i++) { | ||
| 200 | m_running_threads[i] = nullptr; | ||
| 201 | m_pinned_threads[i] = nullptr; | ||
| 202 | m_running_thread_idle_counts[i] = 0; | ||
| 203 | m_running_thread_switch_counts[i] = 0; | ||
| 204 | } | ||
| 220 | 205 | ||
| 221 | // An update is needed. | 206 | // Set max memory based on address space type. |
| 222 | KScheduler::SetSchedulerUpdateNeeded(m_kernel); | 207 | switch ((params.flags & Svc::CreateProcessFlag::AddressSpaceMask)) { |
| 223 | } | 208 | case Svc::CreateProcessFlag::AddressSpace32Bit: |
| 209 | case Svc::CreateProcessFlag::AddressSpace64BitDeprecated: | ||
| 210 | case Svc::CreateProcessFlag::AddressSpace64Bit: | ||
| 211 | m_max_process_memory = m_page_table.GetHeapRegionSize(); | ||
| 212 | break; | ||
| 213 | case Svc::CreateProcessFlag::AddressSpace32BitWithoutAlias: | ||
| 214 | m_max_process_memory = m_page_table.GetHeapRegionSize() + m_page_table.GetAliasRegionSize(); | ||
| 215 | break; | ||
| 216 | default: | ||
| 217 | UNREACHABLE(); | ||
| 218 | } | ||
| 224 | 219 | ||
| 225 | Result KProcess::AddSharedMemory(KSharedMemory* shmem, [[maybe_unused]] KProcessAddress address, | 220 | // Generate random entropy. |
| 226 | [[maybe_unused]] size_t size) { | 221 | GenerateRandom(m_entropy); |
| 227 | // Lock ourselves, to prevent concurrent access. | ||
| 228 | KScopedLightLock lk(m_state_lock); | ||
| 229 | 222 | ||
| 230 | // Try to find an existing info for the memory. | 223 | // Clear remaining fields. |
| 231 | KSharedMemoryInfo* shemen_info = nullptr; | 224 | m_num_running_threads = 0; |
| 232 | const auto iter = std::find_if( | 225 | m_num_process_switches = 0; |
| 233 | m_shared_memory_list.begin(), m_shared_memory_list.end(), | 226 | m_num_thread_switches = 0; |
| 234 | [shmem](const KSharedMemoryInfo* info) { return info->GetSharedMemory() == shmem; }); | 227 | m_num_fpu_switches = 0; |
| 235 | if (iter != m_shared_memory_list.end()) { | 228 | m_num_supervisor_calls = 0; |
| 236 | shemen_info = *iter; | 229 | m_num_ipc_messages = 0; |
| 237 | } | ||
| 238 | 230 | ||
| 239 | if (shemen_info == nullptr) { | 231 | m_is_signaled = false; |
| 240 | shemen_info = KSharedMemoryInfo::Allocate(m_kernel); | 232 | m_exception_thread = nullptr; |
| 241 | R_UNLESS(shemen_info != nullptr, ResultOutOfMemory); | 233 | m_is_suspended = false; |
| 234 | m_memory_release_hint = 0; | ||
| 235 | m_schedule_count = 0; | ||
| 236 | m_is_handle_table_initialized = false; | ||
| 242 | 237 | ||
| 243 | shemen_info->Initialize(shmem); | 238 | // Open a reference to our resource limit. |
| 244 | m_shared_memory_list.push_back(shemen_info); | 239 | m_resource_limit = res_limit; |
| 245 | } | 240 | m_resource_limit->Open(); |
| 246 | 241 | ||
| 247 | // Open a reference to the shared memory and its info. | 242 | // We're initialized! |
| 248 | shmem->Open(); | 243 | m_is_initialized = true; |
| 249 | shemen_info->Open(); | ||
| 250 | 244 | ||
| 251 | R_SUCCEED(); | 245 | R_SUCCEED(); |
| 252 | } | 246 | } |
| 253 | 247 | ||
| 254 | void KProcess::RemoveSharedMemory(KSharedMemory* shmem, [[maybe_unused]] KProcessAddress address, | 248 | Result KProcess::Initialize(const Svc::CreateProcessParameter& params, const KPageGroup& pg, |
| 255 | [[maybe_unused]] size_t size) { | 249 | std::span<const u32> caps, KResourceLimit* res_limit, |
| 256 | // Lock ourselves, to prevent concurrent access. | 250 | KMemoryManager::Pool pool, bool immortal) { |
| 257 | KScopedLightLock lk(m_state_lock); | 251 | ASSERT(res_limit != nullptr); |
| 252 | ASSERT((params.code_num_pages * PageSize) / PageSize == | ||
| 253 | static_cast<size_t>(params.code_num_pages)); | ||
| 254 | |||
| 255 | // Set members. | ||
| 256 | m_memory_pool = pool; | ||
| 257 | m_is_default_application_system_resource = false; | ||
| 258 | m_is_immortal = immortal; | ||
| 259 | |||
| 260 | // Setup our system resource. | ||
| 261 | if (const size_t system_resource_num_pages = params.system_resource_num_pages; | ||
| 262 | system_resource_num_pages != 0) { | ||
| 263 | // Create a secure system resource. | ||
| 264 | KSecureSystemResource* secure_resource = KSecureSystemResource::Create(m_kernel); | ||
| 265 | R_UNLESS(secure_resource != nullptr, ResultOutOfResource); | ||
| 266 | |||
| 267 | ON_RESULT_FAILURE { | ||
| 268 | secure_resource->Close(); | ||
| 269 | }; | ||
| 270 | |||
| 271 | // Initialize the secure resource. | ||
| 272 | R_TRY(secure_resource->Initialize(system_resource_num_pages * PageSize, res_limit, | ||
| 273 | m_memory_pool)); | ||
| 274 | |||
| 275 | // Set our system resource. | ||
| 276 | m_system_resource = secure_resource; | ||
| 277 | } else { | ||
| 278 | // Use the system-wide system resource. | ||
| 279 | const bool is_app = True(params.flags & Svc::CreateProcessFlag::IsApplication); | ||
| 280 | m_system_resource = std::addressof(is_app ? m_kernel.GetAppSystemResource() | ||
| 281 | : m_kernel.GetSystemSystemResource()); | ||
| 258 | 282 | ||
| 259 | KSharedMemoryInfo* shemen_info = nullptr; | 283 | m_is_default_application_system_resource = is_app; |
| 260 | const auto iter = std::find_if( | 284 | |
| 261 | m_shared_memory_list.begin(), m_shared_memory_list.end(), | 285 | // Open reference to the system resource. |
| 262 | [shmem](const KSharedMemoryInfo* info) { return info->GetSharedMemory() == shmem; }); | 286 | m_system_resource->Open(); |
| 263 | if (iter != m_shared_memory_list.end()) { | ||
| 264 | shemen_info = *iter; | ||
| 265 | } | 287 | } |
| 266 | 288 | ||
| 267 | ASSERT(shemen_info != nullptr); | 289 | // Ensure we clean up our secure resource, if we fail. |
| 290 | ON_RESULT_FAILURE { | ||
| 291 | m_system_resource->Close(); | ||
| 292 | m_system_resource = nullptr; | ||
| 293 | }; | ||
| 268 | 294 | ||
| 269 | if (shemen_info->Close()) { | 295 | // Setup page table. |
| 270 | m_shared_memory_list.erase(iter); | 296 | { |
| 271 | KSharedMemoryInfo::Free(m_kernel, shemen_info); | 297 | const auto as_type = params.flags & Svc::CreateProcessFlag::AddressSpaceMask; |
| 298 | const bool enable_aslr = True(params.flags & Svc::CreateProcessFlag::EnableAslr); | ||
| 299 | const bool enable_das_merge = | ||
| 300 | False(params.flags & Svc::CreateProcessFlag::DisableDeviceAddressSpaceMerge); | ||
| 301 | R_TRY(m_page_table.InitializeForProcess( | ||
| 302 | as_type, enable_aslr, enable_das_merge, !enable_aslr, pool, params.code_address, | ||
| 303 | params.code_num_pages * PageSize, m_system_resource, res_limit, this->GetMemory())); | ||
| 272 | } | 304 | } |
| 305 | ON_RESULT_FAILURE_2 { | ||
| 306 | m_page_table.Finalize(); | ||
| 307 | }; | ||
| 273 | 308 | ||
| 274 | // Close a reference to the shared memory. | 309 | // Ensure we can insert the code region. |
| 275 | shmem->Close(); | 310 | R_UNLESS(m_page_table.CanContain(params.code_address, params.code_num_pages * PageSize, |
| 276 | } | 311 | KMemoryState::Code), |
| 312 | ResultInvalidMemoryRegion); | ||
| 277 | 313 | ||
| 278 | void KProcess::RegisterThread(KThread* thread) { | 314 | // Map the code region. |
| 279 | KScopedLightLock lk{m_list_lock}; | 315 | R_TRY(m_page_table.MapPageGroup(params.code_address, pg, KMemoryState::Code, |
| 316 | KMemoryPermission::KernelRead)); | ||
| 280 | 317 | ||
| 281 | m_thread_list.push_back(thread); | 318 | // Initialize capabilities. |
| 282 | } | 319 | R_TRY(m_capabilities.InitializeForKip(caps, std::addressof(m_page_table))); |
| 283 | 320 | ||
| 284 | void KProcess::UnregisterThread(KThread* thread) { | 321 | // Initialize the process id. |
| 285 | KScopedLightLock lk{m_list_lock}; | 322 | m_process_id = m_kernel.CreateNewUserProcessID(); |
| 323 | ASSERT(InitialProcessIdMin <= m_process_id); | ||
| 324 | ASSERT(m_process_id <= InitialProcessIdMax); | ||
| 286 | 325 | ||
| 287 | m_thread_list.remove(thread); | 326 | // Initialize the rest of the process. |
| 288 | } | 327 | R_TRY(this->Initialize(params, res_limit, true)); |
| 289 | 328 | ||
| 290 | u64 KProcess::GetFreeThreadCount() const { | 329 | // We succeeded! |
| 291 | if (m_resource_limit != nullptr) { | 330 | R_SUCCEED(); |
| 292 | const auto current_value = | ||
| 293 | m_resource_limit->GetCurrentValue(LimitableResource::ThreadCountMax); | ||
| 294 | const auto limit_value = m_resource_limit->GetLimitValue(LimitableResource::ThreadCountMax); | ||
| 295 | return limit_value - current_value; | ||
| 296 | } else { | ||
| 297 | return 0; | ||
| 298 | } | ||
| 299 | } | 331 | } |
| 300 | 332 | ||
| 301 | Result KProcess::Reset() { | 333 | Result KProcess::Initialize(const Svc::CreateProcessParameter& params, |
| 302 | // Lock the process and the scheduler. | 334 | std::span<const u32> user_caps, KResourceLimit* res_limit, |
| 303 | KScopedLightLock lk(m_state_lock); | 335 | KMemoryManager::Pool pool) { |
| 304 | KScopedSchedulerLock sl{m_kernel}; | 336 | ASSERT(res_limit != nullptr); |
| 305 | 337 | ||
| 306 | // Validate that we're in a state that we can reset. | 338 | // Set members. |
| 307 | R_UNLESS(m_state != State::Terminated, ResultInvalidState); | 339 | m_memory_pool = pool; |
| 308 | R_UNLESS(m_is_signaled, ResultInvalidState); | 340 | m_is_default_application_system_resource = false; |
| 341 | m_is_immortal = false; | ||
| 309 | 342 | ||
| 310 | // Clear signaled. | 343 | // Get the memory sizes. |
| 311 | m_is_signaled = false; | 344 | const size_t code_num_pages = params.code_num_pages; |
| 312 | R_SUCCEED(); | 345 | const size_t system_resource_num_pages = params.system_resource_num_pages; |
| 313 | } | 346 | const size_t code_size = code_num_pages * PageSize; |
| 347 | const size_t system_resource_size = system_resource_num_pages * PageSize; | ||
| 314 | 348 | ||
| 315 | Result KProcess::SetActivity(ProcessActivity activity) { | 349 | // Reserve memory for our code resource. |
| 316 | // Lock ourselves and the scheduler. | 350 | KScopedResourceReservation memory_reservation( |
| 317 | KScopedLightLock lk{m_state_lock}; | 351 | res_limit, Svc::LimitableResource::PhysicalMemoryMax, code_size); |
| 318 | KScopedLightLock list_lk{m_list_lock}; | 352 | R_UNLESS(memory_reservation.Succeeded(), ResultLimitReached); |
| 319 | KScopedSchedulerLock sl{m_kernel}; | ||
| 320 | 353 | ||
| 321 | // Validate our state. | 354 | // Setup our system resource. |
| 322 | R_UNLESS(m_state != State::Terminating, ResultInvalidState); | 355 | if (system_resource_num_pages != 0) { |
| 323 | R_UNLESS(m_state != State::Terminated, ResultInvalidState); | 356 | // Create a secure system resource. |
| 357 | KSecureSystemResource* secure_resource = KSecureSystemResource::Create(m_kernel); | ||
| 358 | R_UNLESS(secure_resource != nullptr, ResultOutOfResource); | ||
| 324 | 359 | ||
| 325 | // Either pause or resume. | 360 | ON_RESULT_FAILURE { |
| 326 | if (activity == ProcessActivity::Paused) { | 361 | secure_resource->Close(); |
| 327 | // Verify that we're not suspended. | 362 | }; |
| 328 | R_UNLESS(!m_is_suspended, ResultInvalidState); | ||
| 329 | 363 | ||
| 330 | // Suspend all threads. | 364 | // Initialize the secure resource. |
| 331 | for (auto* thread : this->GetThreadList()) { | 365 | R_TRY(secure_resource->Initialize(system_resource_size, res_limit, m_memory_pool)); |
| 332 | thread->RequestSuspend(SuspendType::Process); | 366 | |
| 333 | } | 367 | // Set our system resource. |
| 368 | m_system_resource = secure_resource; | ||
| 334 | 369 | ||
| 335 | // Set ourselves as suspended. | ||
| 336 | this->SetSuspended(true); | ||
| 337 | } else { | 370 | } else { |
| 338 | ASSERT(activity == ProcessActivity::Runnable); | 371 | // Use the system-wide system resource. |
| 372 | const bool is_app = True(params.flags & Svc::CreateProcessFlag::IsApplication); | ||
| 373 | m_system_resource = std::addressof(is_app ? m_kernel.GetAppSystemResource() | ||
| 374 | : m_kernel.GetSystemSystemResource()); | ||
| 339 | 375 | ||
| 340 | // Verify that we're suspended. | 376 | m_is_default_application_system_resource = is_app; |
| 341 | R_UNLESS(m_is_suspended, ResultInvalidState); | ||
| 342 | 377 | ||
| 343 | // Resume all threads. | 378 | // Open reference to the system resource. |
| 344 | for (auto* thread : this->GetThreadList()) { | 379 | m_system_resource->Open(); |
| 345 | thread->Resume(SuspendType::Process); | 380 | } |
| 346 | } | ||
| 347 | 381 | ||
| 348 | // Set ourselves as resumed. | 382 | // Ensure we clean up our secure resource, if we fail. |
| 349 | this->SetSuspended(false); | 383 | ON_RESULT_FAILURE { |
| 384 | m_system_resource->Close(); | ||
| 385 | m_system_resource = nullptr; | ||
| 386 | }; | ||
| 387 | |||
| 388 | // Setup page table. | ||
| 389 | { | ||
| 390 | const auto as_type = params.flags & Svc::CreateProcessFlag::AddressSpaceMask; | ||
| 391 | const bool enable_aslr = True(params.flags & Svc::CreateProcessFlag::EnableAslr); | ||
| 392 | const bool enable_das_merge = | ||
| 393 | False(params.flags & Svc::CreateProcessFlag::DisableDeviceAddressSpaceMerge); | ||
| 394 | R_TRY(m_page_table.InitializeForProcess(as_type, enable_aslr, enable_das_merge, | ||
| 395 | !enable_aslr, pool, params.code_address, code_size, | ||
| 396 | m_system_resource, res_limit, this->GetMemory())); | ||
| 397 | } | ||
| 398 | ON_RESULT_FAILURE_2 { | ||
| 399 | m_page_table.Finalize(); | ||
| 400 | }; | ||
| 401 | |||
| 402 | // Ensure we can insert the code region. | ||
| 403 | R_UNLESS(m_page_table.CanContain(params.code_address, code_size, KMemoryState::Code), | ||
| 404 | ResultInvalidMemoryRegion); | ||
| 405 | |||
| 406 | // Map the code region. | ||
| 407 | R_TRY(m_page_table.MapPages(params.code_address, code_num_pages, KMemoryState::Code, | ||
| 408 | KMemoryPermission::KernelRead | KMemoryPermission::NotMapped)); | ||
| 409 | |||
| 410 | // Initialize capabilities. | ||
| 411 | R_TRY(m_capabilities.InitializeForUser(user_caps, std::addressof(m_page_table))); | ||
| 412 | |||
| 413 | // Initialize the process id. | ||
| 414 | m_process_id = m_kernel.CreateNewUserProcessID(); | ||
| 415 | ASSERT(ProcessIdMin <= m_process_id); | ||
| 416 | ASSERT(m_process_id <= ProcessIdMax); | ||
| 417 | |||
| 418 | // If we should optimize memory allocations, do so. | ||
| 419 | if (m_system_resource->IsSecureResource() && | ||
| 420 | True(params.flags & Svc::CreateProcessFlag::OptimizeMemoryAllocation)) { | ||
| 421 | R_TRY(m_kernel.MemoryManager().InitializeOptimizedMemory(m_process_id, pool)); | ||
| 350 | } | 422 | } |
| 351 | 423 | ||
| 424 | // Initialize the rest of the process. | ||
| 425 | R_TRY(this->Initialize(params, res_limit, true)); | ||
| 426 | |||
| 427 | // We succeeded, so commit our memory reservation. | ||
| 428 | memory_reservation.Commit(); | ||
| 352 | R_SUCCEED(); | 429 | R_SUCCEED(); |
| 353 | } | 430 | } |
| 354 | 431 | ||
| 355 | Result KProcess::LoadFromMetadata(const FileSys::ProgramMetadata& metadata, std::size_t code_size, | 432 | void KProcess::DoWorkerTaskImpl() { |
| 356 | bool is_hbl) { | 433 | // Terminate child threads. |
| 357 | m_program_id = metadata.GetTitleID(); | 434 | TerminateChildren(m_kernel, this, nullptr); |
| 358 | m_ideal_core = metadata.GetMainThreadCore(); | ||
| 359 | m_is_64bit_process = metadata.Is64BitProgram(); | ||
| 360 | m_system_resource_size = metadata.GetSystemResourceSize(); | ||
| 361 | m_image_size = code_size; | ||
| 362 | m_is_hbl = is_hbl; | ||
| 363 | 435 | ||
| 364 | if (metadata.GetAddressSpaceType() == FileSys::ProgramAddressSpaceType::Is39Bit) { | 436 | // Finalize the handle table, if we're not immortal. |
| 365 | // For 39-bit processes, the ASLR region starts at 0x800'0000 and is ~512GiB large. | 437 | if (!m_is_immortal && m_is_handle_table_initialized) { |
| 366 | // However, some (buggy) programs/libraries like skyline incorrectly depend on the | 438 | this->FinalizeHandleTable(); |
| 367 | // existence of ASLR pages before the entry point, so we will adjust the load address | ||
| 368 | // to point to about 2GiB into the ASLR region. | ||
| 369 | m_code_address = 0x8000'0000; | ||
| 370 | } else { | ||
| 371 | // All other processes can be mapped at the beginning of the code region. | ||
| 372 | if (metadata.GetAddressSpaceType() == FileSys::ProgramAddressSpaceType::Is36Bit) { | ||
| 373 | m_code_address = 0x800'0000; | ||
| 374 | } else { | ||
| 375 | m_code_address = 0x20'0000; | ||
| 376 | } | ||
| 377 | } | 439 | } |
| 378 | 440 | ||
| 379 | KScopedResourceReservation memory_reservation( | 441 | // Finish termination. |
| 380 | m_resource_limit, LimitableResource::PhysicalMemoryMax, code_size + m_system_resource_size); | 442 | this->FinishTermination(); |
| 381 | if (!memory_reservation.Succeeded()) { | 443 | } |
| 382 | LOG_ERROR(Kernel, "Could not reserve process memory requirements of size {:X} bytes", | ||
| 383 | code_size + m_system_resource_size); | ||
| 384 | R_RETURN(ResultLimitReached); | ||
| 385 | } | ||
| 386 | // Initialize process address space | ||
| 387 | if (const Result result{m_page_table.InitializeForProcess( | ||
| 388 | metadata.GetAddressSpaceType(), false, false, false, KMemoryManager::Pool::Application, | ||
| 389 | this->GetEntryPoint(), code_size, std::addressof(m_kernel.GetAppSystemResource()), | ||
| 390 | m_resource_limit, m_kernel.System().ApplicationMemory())}; | ||
| 391 | result.IsError()) { | ||
| 392 | R_RETURN(result); | ||
| 393 | } | ||
| 394 | |||
| 395 | // Map process code region | ||
| 396 | if (const Result result{m_page_table.MapProcessCode(this->GetEntryPoint(), code_size / PageSize, | ||
| 397 | KMemoryState::Code, | ||
| 398 | KMemoryPermission::None)}; | ||
| 399 | result.IsError()) { | ||
| 400 | R_RETURN(result); | ||
| 401 | } | ||
| 402 | |||
| 403 | // Initialize process capabilities | ||
| 404 | const auto& caps{metadata.GetKernelCapabilities()}; | ||
| 405 | if (const Result result{ | ||
| 406 | m_capabilities.InitializeForUserProcess(caps.data(), caps.size(), m_page_table)}; | ||
| 407 | result.IsError()) { | ||
| 408 | R_RETURN(result); | ||
| 409 | } | ||
| 410 | |||
| 411 | // Set memory usage capacity | ||
| 412 | switch (metadata.GetAddressSpaceType()) { | ||
| 413 | case FileSys::ProgramAddressSpaceType::Is32Bit: | ||
| 414 | case FileSys::ProgramAddressSpaceType::Is36Bit: | ||
| 415 | case FileSys::ProgramAddressSpaceType::Is39Bit: | ||
| 416 | m_memory_usage_capacity = | ||
| 417 | m_page_table.GetHeapRegionEnd() - m_page_table.GetHeapRegionStart(); | ||
| 418 | break; | ||
| 419 | 444 | ||
| 420 | case FileSys::ProgramAddressSpaceType::Is32BitNoMap: | 445 | Result KProcess::StartTermination() { |
| 421 | m_memory_usage_capacity = | 446 | // Finalize the handle table when we're done, if the process isn't immortal. |
| 422 | (m_page_table.GetHeapRegionEnd() - m_page_table.GetHeapRegionStart()) + | 447 | SCOPE_EXIT({ |
| 423 | (m_page_table.GetAliasRegionEnd() - m_page_table.GetAliasRegionStart()); | 448 | if (!m_is_immortal) { |
| 424 | break; | 449 | this->FinalizeHandleTable(); |
| 450 | } | ||
| 451 | }); | ||
| 425 | 452 | ||
| 426 | default: | 453 | // Terminate child threads other than the current one. |
| 427 | ASSERT(false); | 454 | R_RETURN(TerminateChildren(m_kernel, this, GetCurrentThreadPointer(m_kernel))); |
| 428 | break; | 455 | } |
| 429 | } | ||
| 430 | 456 | ||
| 431 | // Create TLS region | 457 | void KProcess::FinishTermination() { |
| 432 | R_TRY(this->CreateThreadLocalRegion(std::addressof(m_plr_address))); | 458 | // Only allow termination to occur if the process isn't immortal. |
| 433 | memory_reservation.Commit(); | 459 | if (!m_is_immortal) { |
| 460 | // Release resource limit hint. | ||
| 461 | if (m_resource_limit != nullptr) { | ||
| 462 | m_memory_release_hint = this->GetUsedNonSystemUserPhysicalMemorySize(); | ||
| 463 | m_resource_limit->Release(Svc::LimitableResource::PhysicalMemoryMax, 0, | ||
| 464 | m_memory_release_hint); | ||
| 465 | } | ||
| 466 | |||
| 467 | // Change state. | ||
| 468 | { | ||
| 469 | KScopedSchedulerLock sl(m_kernel); | ||
| 470 | this->ChangeState(State::Terminated); | ||
| 471 | } | ||
| 434 | 472 | ||
| 435 | R_RETURN(m_handle_table.Initialize(m_capabilities.GetHandleTableSize())); | 473 | // Close. |
| 474 | this->Close(); | ||
| 475 | } | ||
| 436 | } | 476 | } |
| 437 | 477 | ||
| 438 | void KProcess::Run(s32 main_thread_priority, u64 stack_size) { | 478 | void KProcess::Exit() { |
| 439 | ASSERT(this->AllocateMainThreadStack(stack_size) == ResultSuccess); | 479 | // Determine whether we need to start terminating |
| 440 | m_resource_limit->Reserve(LimitableResource::ThreadCountMax, 1); | 480 | bool needs_terminate = false; |
| 481 | { | ||
| 482 | KScopedLightLock lk(m_state_lock); | ||
| 483 | KScopedSchedulerLock sl(m_kernel); | ||
| 484 | |||
| 485 | ASSERT(m_state != State::Created); | ||
| 486 | ASSERT(m_state != State::CreatedAttached); | ||
| 487 | ASSERT(m_state != State::Crashed); | ||
| 488 | ASSERT(m_state != State::Terminated); | ||
| 489 | if (m_state == State::Running || m_state == State::RunningAttached || | ||
| 490 | m_state == State::DebugBreak) { | ||
| 491 | this->ChangeState(State::Terminating); | ||
| 492 | needs_terminate = true; | ||
| 493 | } | ||
| 494 | } | ||
| 441 | 495 | ||
| 442 | const std::size_t heap_capacity{m_memory_usage_capacity - | 496 | // If we need to start termination, do so. |
| 443 | (m_main_thread_stack_size + m_image_size)}; | 497 | if (needs_terminate) { |
| 444 | ASSERT(!m_page_table.SetMaxHeapSize(heap_capacity).IsError()); | 498 | this->StartTermination(); |
| 445 | 499 | ||
| 446 | this->ChangeState(State::Running); | 500 | // Register the process as a work task. |
| 501 | m_kernel.WorkerTaskManager().AddTask(m_kernel, KWorkerTaskManager::WorkerType::Exit, this); | ||
| 502 | } | ||
| 447 | 503 | ||
| 448 | SetupMainThread(m_kernel.System(), *this, main_thread_priority, m_main_thread_stack_top); | 504 | // Exit the current thread. |
| 505 | GetCurrentThread(m_kernel).Exit(); | ||
| 449 | } | 506 | } |
| 450 | 507 | ||
| 451 | void KProcess::PrepareForTermination() { | 508 | Result KProcess::Terminate() { |
| 452 | this->ChangeState(State::Terminating); | 509 | // Determine whether we need to start terminating. |
| 510 | bool needs_terminate = false; | ||
| 511 | { | ||
| 512 | KScopedLightLock lk(m_state_lock); | ||
| 453 | 513 | ||
| 454 | const auto stop_threads = [this](const std::vector<KThread*>& in_thread_list) { | 514 | // Check whether we're allowed to terminate. |
| 455 | for (auto* thread : in_thread_list) { | 515 | R_UNLESS(m_state != State::Created, ResultInvalidState); |
| 456 | if (thread->GetOwnerProcess() != this) | 516 | R_UNLESS(m_state != State::CreatedAttached, ResultInvalidState); |
| 457 | continue; | ||
| 458 | 517 | ||
| 459 | if (thread == GetCurrentThreadPointer(m_kernel)) | 518 | KScopedSchedulerLock sl(m_kernel); |
| 460 | continue; | ||
| 461 | 519 | ||
| 462 | // TODO(Subv): When are the other running/ready threads terminated? | 520 | if (m_state == State::Running || m_state == State::RunningAttached || |
| 463 | ASSERT_MSG(thread->GetState() == ThreadState::Waiting, | 521 | m_state == State::Crashed || m_state == State::DebugBreak) { |
| 464 | "Exiting processes with non-waiting threads is currently unimplemented"); | 522 | this->ChangeState(State::Terminating); |
| 523 | needs_terminate = true; | ||
| 524 | } | ||
| 525 | } | ||
| 465 | 526 | ||
| 466 | thread->Exit(); | 527 | // If we need to terminate, do so. |
| 528 | if (needs_terminate) { | ||
| 529 | // Start termination. | ||
| 530 | if (R_SUCCEEDED(this->StartTermination())) { | ||
| 531 | // Finish termination. | ||
| 532 | this->FinishTermination(); | ||
| 533 | } else { | ||
| 534 | // Register the process as a work task. | ||
| 535 | m_kernel.WorkerTaskManager().AddTask(m_kernel, KWorkerTaskManager::WorkerType::Exit, | ||
| 536 | this); | ||
| 467 | } | 537 | } |
| 468 | }; | 538 | } |
| 469 | 539 | ||
| 470 | stop_threads(m_kernel.System().GlobalSchedulerContext().GetThreadList()); | 540 | R_SUCCEED(); |
| 541 | } | ||
| 471 | 542 | ||
| 472 | this->DeleteThreadLocalRegion(m_plr_address); | 543 | Result KProcess::AddSharedMemory(KSharedMemory* shmem, KProcessAddress address, size_t size) { |
| 473 | m_plr_address = 0; | 544 | // Lock ourselves, to prevent concurrent access. |
| 545 | KScopedLightLock lk(m_state_lock); | ||
| 474 | 546 | ||
| 475 | if (m_resource_limit) { | 547 | // Try to find an existing info for the memory. |
| 476 | m_resource_limit->Release(LimitableResource::PhysicalMemoryMax, | 548 | KSharedMemoryInfo* info = nullptr; |
| 477 | m_main_thread_stack_size + m_image_size); | 549 | for (auto it = m_shared_memory_list.begin(); it != m_shared_memory_list.end(); ++it) { |
| 550 | if (it->GetSharedMemory() == shmem) { | ||
| 551 | info = std::addressof(*it); | ||
| 552 | break; | ||
| 553 | } | ||
| 478 | } | 554 | } |
| 479 | 555 | ||
| 480 | this->ChangeState(State::Terminated); | 556 | // If we didn't find an info, create one. |
| 481 | } | 557 | if (info == nullptr) { |
| 558 | // Allocate a new info. | ||
| 559 | info = KSharedMemoryInfo::Allocate(m_kernel); | ||
| 560 | R_UNLESS(info != nullptr, ResultOutOfResource); | ||
| 482 | 561 | ||
| 483 | void KProcess::Finalize() { | 562 | // Initialize the info and add it to our list. |
| 484 | // Free all shared memory infos. | 563 | info->Initialize(shmem); |
| 485 | { | 564 | m_shared_memory_list.push_back(*info); |
| 486 | auto it = m_shared_memory_list.begin(); | 565 | } |
| 487 | while (it != m_shared_memory_list.end()) { | ||
| 488 | KSharedMemoryInfo* info = *it; | ||
| 489 | KSharedMemory* shmem = info->GetSharedMemory(); | ||
| 490 | 566 | ||
| 491 | while (!info->Close()) { | 567 | // Open a reference to the shared memory and its info. |
| 492 | shmem->Close(); | 568 | shmem->Open(); |
| 493 | } | 569 | info->Open(); |
| 494 | 570 | ||
| 495 | shmem->Close(); | 571 | R_SUCCEED(); |
| 572 | } | ||
| 496 | 573 | ||
| 497 | it = m_shared_memory_list.erase(it); | 574 | void KProcess::RemoveSharedMemory(KSharedMemory* shmem, KProcessAddress address, size_t size) { |
| 498 | KSharedMemoryInfo::Free(m_kernel, info); | 575 | // Lock ourselves, to prevent concurrent access. |
| 576 | KScopedLightLock lk(m_state_lock); | ||
| 577 | |||
| 578 | // Find an existing info for the memory. | ||
| 579 | KSharedMemoryInfo* info = nullptr; | ||
| 580 | auto it = m_shared_memory_list.begin(); | ||
| 581 | for (; it != m_shared_memory_list.end(); ++it) { | ||
| 582 | if (it->GetSharedMemory() == shmem) { | ||
| 583 | info = std::addressof(*it); | ||
| 584 | break; | ||
| 499 | } | 585 | } |
| 500 | } | 586 | } |
| 587 | ASSERT(info != nullptr); | ||
| 501 | 588 | ||
| 502 | // Release memory to the resource limit. | 589 | // Close a reference to the info and its memory. |
| 503 | if (m_resource_limit != nullptr) { | 590 | if (info->Close()) { |
| 504 | m_resource_limit->Close(); | 591 | m_shared_memory_list.erase(it); |
| 505 | m_resource_limit = nullptr; | 592 | KSharedMemoryInfo::Free(m_kernel, info); |
| 506 | } | 593 | } |
| 507 | 594 | ||
| 508 | // Finalize the page table. | 595 | shmem->Close(); |
| 509 | m_page_table.Finalize(); | ||
| 510 | |||
| 511 | // Perform inherited finalization. | ||
| 512 | KSynchronizationObject::Finalize(); | ||
| 513 | } | 596 | } |
| 514 | 597 | ||
| 515 | Result KProcess::CreateThreadLocalRegion(KProcessAddress* out) { | 598 | Result KProcess::CreateThreadLocalRegion(KProcessAddress* out) { |
| @@ -518,7 +601,7 @@ Result KProcess::CreateThreadLocalRegion(KProcessAddress* out) { | |||
| 518 | 601 | ||
| 519 | // See if we can get a region from a partially used TLP. | 602 | // See if we can get a region from a partially used TLP. |
| 520 | { | 603 | { |
| 521 | KScopedSchedulerLock sl{m_kernel}; | 604 | KScopedSchedulerLock sl(m_kernel); |
| 522 | 605 | ||
| 523 | if (auto it = m_partially_used_tlp_tree.begin(); it != m_partially_used_tlp_tree.end()) { | 606 | if (auto it = m_partially_used_tlp_tree.begin(); it != m_partially_used_tlp_tree.end()) { |
| 524 | tlr = it->Reserve(); | 607 | tlr = it->Reserve(); |
| @@ -538,7 +621,9 @@ Result KProcess::CreateThreadLocalRegion(KProcessAddress* out) { | |||
| 538 | // Allocate a new page. | 621 | // Allocate a new page. |
| 539 | tlp = KThreadLocalPage::Allocate(m_kernel); | 622 | tlp = KThreadLocalPage::Allocate(m_kernel); |
| 540 | R_UNLESS(tlp != nullptr, ResultOutOfMemory); | 623 | R_UNLESS(tlp != nullptr, ResultOutOfMemory); |
| 541 | auto tlp_guard = SCOPE_GUARD({ KThreadLocalPage::Free(m_kernel, tlp); }); | 624 | ON_RESULT_FAILURE { |
| 625 | KThreadLocalPage::Free(m_kernel, tlp); | ||
| 626 | }; | ||
| 542 | 627 | ||
| 543 | // Initialize the new page. | 628 | // Initialize the new page. |
| 544 | R_TRY(tlp->Initialize(m_kernel, this)); | 629 | R_TRY(tlp->Initialize(m_kernel, this)); |
| @@ -549,7 +634,7 @@ Result KProcess::CreateThreadLocalRegion(KProcessAddress* out) { | |||
| 549 | 634 | ||
| 550 | // Insert into our tree. | 635 | // Insert into our tree. |
| 551 | { | 636 | { |
| 552 | KScopedSchedulerLock sl{m_kernel}; | 637 | KScopedSchedulerLock sl(m_kernel); |
| 553 | if (tlp->IsAllUsed()) { | 638 | if (tlp->IsAllUsed()) { |
| 554 | m_fully_used_tlp_tree.insert(*tlp); | 639 | m_fully_used_tlp_tree.insert(*tlp); |
| 555 | } else { | 640 | } else { |
| @@ -558,7 +643,6 @@ Result KProcess::CreateThreadLocalRegion(KProcessAddress* out) { | |||
| 558 | } | 643 | } |
| 559 | 644 | ||
| 560 | // We succeeded! | 645 | // We succeeded! |
| 561 | tlp_guard.Cancel(); | ||
| 562 | *out = tlr; | 646 | *out = tlr; |
| 563 | R_SUCCEED(); | 647 | R_SUCCEED(); |
| 564 | } | 648 | } |
| @@ -568,7 +652,7 @@ Result KProcess::DeleteThreadLocalRegion(KProcessAddress addr) { | |||
| 568 | 652 | ||
| 569 | // Release the region. | 653 | // Release the region. |
| 570 | { | 654 | { |
| 571 | KScopedSchedulerLock sl{m_kernel}; | 655 | KScopedSchedulerLock sl(m_kernel); |
| 572 | 656 | ||
| 573 | // Try to find the page in the partially used list. | 657 | // Try to find the page in the partially used list. |
| 574 | auto it = m_partially_used_tlp_tree.find_key(Common::AlignDown(GetInteger(addr), PageSize)); | 658 | auto it = m_partially_used_tlp_tree.find_key(Common::AlignDown(GetInteger(addr), PageSize)); |
| @@ -611,95 +695,213 @@ Result KProcess::DeleteThreadLocalRegion(KProcessAddress addr) { | |||
| 611 | R_SUCCEED(); | 695 | R_SUCCEED(); |
| 612 | } | 696 | } |
| 613 | 697 | ||
| 614 | bool KProcess::InsertWatchpoint(KProcessAddress addr, u64 size, DebugWatchpointType type) { | 698 | bool KProcess::ReserveResource(Svc::LimitableResource which, s64 value) { |
| 615 | const auto watch{std::find_if(m_watchpoints.begin(), m_watchpoints.end(), [&](const auto& wp) { | 699 | if (KResourceLimit* rl = this->GetResourceLimit(); rl != nullptr) { |
| 616 | return wp.type == DebugWatchpointType::None; | 700 | return rl->Reserve(which, value); |
| 617 | })}; | 701 | } else { |
| 702 | return true; | ||
| 703 | } | ||
| 704 | } | ||
| 618 | 705 | ||
| 619 | if (watch == m_watchpoints.end()) { | 706 | bool KProcess::ReserveResource(Svc::LimitableResource which, s64 value, s64 timeout) { |
| 620 | return false; | 707 | if (KResourceLimit* rl = this->GetResourceLimit(); rl != nullptr) { |
| 708 | return rl->Reserve(which, value, timeout); | ||
| 709 | } else { | ||
| 710 | return true; | ||
| 621 | } | 711 | } |
| 712 | } | ||
| 622 | 713 | ||
| 623 | watch->start_address = addr; | 714 | void KProcess::ReleaseResource(Svc::LimitableResource which, s64 value) { |
| 624 | watch->end_address = addr + size; | 715 | if (KResourceLimit* rl = this->GetResourceLimit(); rl != nullptr) { |
| 625 | watch->type = type; | 716 | rl->Release(which, value); |
| 717 | } | ||
| 718 | } | ||
| 626 | 719 | ||
| 627 | for (KProcessAddress page = Common::AlignDown(GetInteger(addr), PageSize); page < addr + size; | 720 | void KProcess::ReleaseResource(Svc::LimitableResource which, s64 value, s64 hint) { |
| 628 | page += PageSize) { | 721 | if (KResourceLimit* rl = this->GetResourceLimit(); rl != nullptr) { |
| 629 | m_debug_page_refcounts[page]++; | 722 | rl->Release(which, value, hint); |
| 630 | this->GetMemory().MarkRegionDebug(page, PageSize, true); | ||
| 631 | } | 723 | } |
| 724 | } | ||
| 632 | 725 | ||
| 633 | return true; | 726 | void KProcess::IncrementRunningThreadCount() { |
| 727 | ASSERT(m_num_running_threads.load() >= 0); | ||
| 728 | |||
| 729 | ++m_num_running_threads; | ||
| 634 | } | 730 | } |
| 635 | 731 | ||
| 636 | bool KProcess::RemoveWatchpoint(KProcessAddress addr, u64 size, DebugWatchpointType type) { | 732 | void KProcess::DecrementRunningThreadCount() { |
| 637 | const auto watch{std::find_if(m_watchpoints.begin(), m_watchpoints.end(), [&](const auto& wp) { | 733 | ASSERT(m_num_running_threads.load() > 0); |
| 638 | return wp.start_address == addr && wp.end_address == addr + size && wp.type == type; | ||
| 639 | })}; | ||
| 640 | 734 | ||
| 641 | if (watch == m_watchpoints.end()) { | 735 | if (const auto prev = m_num_running_threads--; prev == 1) { |
| 736 | this->Terminate(); | ||
| 737 | } | ||
| 738 | } | ||
| 739 | |||
| 740 | bool KProcess::EnterUserException() { | ||
| 741 | // Get the current thread. | ||
| 742 | KThread* cur_thread = GetCurrentThreadPointer(m_kernel); | ||
| 743 | ASSERT(this == cur_thread->GetOwnerProcess()); | ||
| 744 | |||
| 745 | // Check that we haven't already claimed the exception thread. | ||
| 746 | if (m_exception_thread == cur_thread) { | ||
| 642 | return false; | 747 | return false; |
| 643 | } | 748 | } |
| 644 | 749 | ||
| 645 | watch->start_address = 0; | 750 | // Create the wait queue we'll be using. |
| 646 | watch->end_address = 0; | 751 | ThreadQueueImplForKProcessEnterUserException wait_queue(m_kernel, |
| 647 | watch->type = DebugWatchpointType::None; | 752 | std::addressof(m_exception_thread)); |
| 648 | 753 | ||
| 649 | for (KProcessAddress page = Common::AlignDown(GetInteger(addr), PageSize); page < addr + size; | 754 | // Claim the exception thread. |
| 650 | page += PageSize) { | 755 | { |
| 651 | m_debug_page_refcounts[page]--; | 756 | // Lock the scheduler. |
| 652 | if (!m_debug_page_refcounts[page]) { | 757 | KScopedSchedulerLock sl(m_kernel); |
| 653 | this->GetMemory().MarkRegionDebug(page, PageSize, false); | 758 | |
| 759 | // Check that we're not terminating. | ||
| 760 | if (cur_thread->IsTerminationRequested()) { | ||
| 761 | return false; | ||
| 762 | } | ||
| 763 | |||
| 764 | // If we don't have an exception thread, we can just claim it directly. | ||
| 765 | if (m_exception_thread == nullptr) { | ||
| 766 | m_exception_thread = cur_thread; | ||
| 767 | KScheduler::SetSchedulerUpdateNeeded(m_kernel); | ||
| 768 | return true; | ||
| 654 | } | 769 | } |
| 770 | |||
| 771 | // Otherwise, we need to wait until we don't have an exception thread. | ||
| 772 | |||
| 773 | // Add the current thread as a waiter on the current exception thread. | ||
| 774 | cur_thread->SetKernelAddressKey( | ||
| 775 | reinterpret_cast<uintptr_t>(std::addressof(m_exception_thread)) | 1); | ||
| 776 | m_exception_thread->AddWaiter(cur_thread); | ||
| 777 | |||
| 778 | // Wait to claim the exception thread. | ||
| 779 | cur_thread->BeginWait(std::addressof(wait_queue)); | ||
| 655 | } | 780 | } |
| 656 | 781 | ||
| 657 | return true; | 782 | // If our wait didn't end due to thread termination, we succeeded. |
| 783 | return ResultTerminationRequested != cur_thread->GetWaitResult(); | ||
| 658 | } | 784 | } |
| 659 | 785 | ||
| 660 | void KProcess::LoadModule(CodeSet code_set, KProcessAddress base_addr) { | 786 | bool KProcess::LeaveUserException() { |
| 661 | const auto ReprotectSegment = [&](const CodeSet::Segment& segment, | 787 | return this->ReleaseUserException(GetCurrentThreadPointer(m_kernel)); |
| 662 | Svc::MemoryPermission permission) { | 788 | } |
| 663 | m_page_table.SetProcessMemoryPermission(segment.addr + base_addr, segment.size, permission); | ||
| 664 | }; | ||
| 665 | 789 | ||
| 666 | this->GetMemory().WriteBlock(base_addr, code_set.memory.data(), code_set.memory.size()); | 790 | bool KProcess::ReleaseUserException(KThread* thread) { |
| 791 | KScopedSchedulerLock sl(m_kernel); | ||
| 667 | 792 | ||
| 668 | ReprotectSegment(code_set.CodeSegment(), Svc::MemoryPermission::ReadExecute); | 793 | if (m_exception_thread == thread) { |
| 669 | ReprotectSegment(code_set.RODataSegment(), Svc::MemoryPermission::Read); | 794 | m_exception_thread = nullptr; |
| 670 | ReprotectSegment(code_set.DataSegment(), Svc::MemoryPermission::ReadWrite); | 795 | |
| 796 | // Remove waiter thread. | ||
| 797 | bool has_waiters; | ||
| 798 | if (KThread* next = thread->RemoveKernelWaiterByKey( | ||
| 799 | std::addressof(has_waiters), | ||
| 800 | reinterpret_cast<uintptr_t>(std::addressof(m_exception_thread)) | 1); | ||
| 801 | next != nullptr) { | ||
| 802 | next->EndWait(ResultSuccess); | ||
| 803 | } | ||
| 804 | |||
| 805 | KScheduler::SetSchedulerUpdateNeeded(m_kernel); | ||
| 806 | |||
| 807 | return true; | ||
| 808 | } else { | ||
| 809 | return false; | ||
| 810 | } | ||
| 671 | } | 811 | } |
| 672 | 812 | ||
| 673 | bool KProcess::IsSignaled() const { | 813 | void KProcess::RegisterThread(KThread* thread) { |
| 674 | ASSERT(KScheduler::IsSchedulerLockedByCurrentThread(m_kernel)); | 814 | KScopedLightLock lk(m_list_lock); |
| 675 | return m_is_signaled; | 815 | |
| 816 | m_thread_list.push_back(*thread); | ||
| 676 | } | 817 | } |
| 677 | 818 | ||
| 678 | KProcess::KProcess(KernelCore& kernel) | 819 | void KProcess::UnregisterThread(KThread* thread) { |
| 679 | : KAutoObjectWithSlabHeapAndContainer{kernel}, m_page_table{m_kernel.System()}, | 820 | KScopedLightLock lk(m_list_lock); |
| 680 | m_handle_table{m_kernel}, m_address_arbiter{m_kernel.System()}, | ||
| 681 | m_condition_var{m_kernel.System()}, m_state_lock{m_kernel}, m_list_lock{m_kernel} {} | ||
| 682 | 821 | ||
| 683 | KProcess::~KProcess() = default; | 822 | m_thread_list.erase(m_thread_list.iterator_to(*thread)); |
| 823 | } | ||
| 824 | |||
| 825 | size_t KProcess::GetUsedUserPhysicalMemorySize() const { | ||
| 826 | const size_t norm_size = m_page_table.GetNormalMemorySize(); | ||
| 827 | const size_t other_size = m_code_size + m_main_thread_stack_size; | ||
| 828 | const size_t sec_size = this->GetRequiredSecureMemorySizeNonDefault(); | ||
| 684 | 829 | ||
| 685 | void KProcess::ChangeState(State new_state) { | 830 | return norm_size + other_size + sec_size; |
| 686 | if (m_state == new_state) { | 831 | } |
| 687 | return; | 832 | |
| 833 | size_t KProcess::GetTotalUserPhysicalMemorySize() const { | ||
| 834 | // Get the amount of free and used size. | ||
| 835 | const size_t free_size = | ||
| 836 | m_resource_limit->GetFreeValue(Svc::LimitableResource::PhysicalMemoryMax); | ||
| 837 | const size_t max_size = m_max_process_memory; | ||
| 838 | |||
| 839 | // Determine used size. | ||
| 840 | // NOTE: This does *not* check this->IsDefaultApplicationSystemResource(), unlike | ||
| 841 | // GetUsedUserPhysicalMemorySize(). | ||
| 842 | const size_t norm_size = m_page_table.GetNormalMemorySize(); | ||
| 843 | const size_t other_size = m_code_size + m_main_thread_stack_size; | ||
| 844 | const size_t sec_size = this->GetRequiredSecureMemorySize(); | ||
| 845 | const size_t used_size = norm_size + other_size + sec_size; | ||
| 846 | |||
| 847 | // NOTE: These function calls will recalculate, introducing a race...it is unclear why Nintendo | ||
| 848 | // does it this way. | ||
| 849 | if (used_size + free_size > max_size) { | ||
| 850 | return max_size; | ||
| 851 | } else { | ||
| 852 | return free_size + this->GetUsedUserPhysicalMemorySize(); | ||
| 688 | } | 853 | } |
| 854 | } | ||
| 689 | 855 | ||
| 690 | m_state = new_state; | 856 | size_t KProcess::GetUsedNonSystemUserPhysicalMemorySize() const { |
| 691 | m_is_signaled = true; | 857 | const size_t norm_size = m_page_table.GetNormalMemorySize(); |
| 692 | this->NotifyAvailable(); | 858 | const size_t other_size = m_code_size + m_main_thread_stack_size; |
| 859 | |||
| 860 | return norm_size + other_size; | ||
| 861 | } | ||
| 862 | |||
| 863 | size_t KProcess::GetTotalNonSystemUserPhysicalMemorySize() const { | ||
| 864 | // Get the amount of free and used size. | ||
| 865 | const size_t free_size = | ||
| 866 | m_resource_limit->GetFreeValue(Svc::LimitableResource::PhysicalMemoryMax); | ||
| 867 | const size_t max_size = m_max_process_memory; | ||
| 868 | |||
| 869 | // Determine used size. | ||
| 870 | // NOTE: This does *not* check this->IsDefaultApplicationSystemResource(), unlike | ||
| 871 | // GetUsedUserPhysicalMemorySize(). | ||
| 872 | const size_t norm_size = m_page_table.GetNormalMemorySize(); | ||
| 873 | const size_t other_size = m_code_size + m_main_thread_stack_size; | ||
| 874 | const size_t sec_size = this->GetRequiredSecureMemorySize(); | ||
| 875 | const size_t used_size = norm_size + other_size + sec_size; | ||
| 876 | |||
| 877 | // NOTE: These function calls will recalculate, introducing a race...it is unclear why Nintendo | ||
| 878 | // does it this way. | ||
| 879 | if (used_size + free_size > max_size) { | ||
| 880 | return max_size - this->GetRequiredSecureMemorySizeNonDefault(); | ||
| 881 | } else { | ||
| 882 | return free_size + this->GetUsedNonSystemUserPhysicalMemorySize(); | ||
| 883 | } | ||
| 693 | } | 884 | } |
| 694 | 885 | ||
| 695 | Result KProcess::AllocateMainThreadStack(std::size_t stack_size) { | 886 | Result KProcess::Run(s32 priority, size_t stack_size) { |
| 887 | // Lock ourselves, to prevent concurrent access. | ||
| 888 | KScopedLightLock lk(m_state_lock); | ||
| 889 | |||
| 890 | // Validate that we're in a state where we can initialize. | ||
| 891 | const auto state = m_state; | ||
| 892 | R_UNLESS(state == State::Created || state == State::CreatedAttached, ResultInvalidState); | ||
| 893 | |||
| 894 | // Place a tentative reservation of a thread for this process. | ||
| 895 | KScopedResourceReservation thread_reservation(this, Svc::LimitableResource::ThreadCountMax); | ||
| 896 | R_UNLESS(thread_reservation.Succeeded(), ResultLimitReached); | ||
| 897 | |||
| 696 | // Ensure that we haven't already allocated stack. | 898 | // Ensure that we haven't already allocated stack. |
| 697 | ASSERT(m_main_thread_stack_size == 0); | 899 | ASSERT(m_main_thread_stack_size == 0); |
| 698 | 900 | ||
| 699 | // Ensure that we're allocating a valid stack. | 901 | // Ensure that we're allocating a valid stack. |
| 700 | stack_size = Common::AlignUp(stack_size, PageSize); | 902 | stack_size = Common::AlignUp(stack_size, PageSize); |
| 701 | // R_UNLESS(stack_size + image_size <= m_max_process_memory, ResultOutOfMemory); | 903 | R_UNLESS(stack_size + m_code_size <= m_max_process_memory, ResultOutOfMemory); |
| 702 | R_UNLESS(stack_size + m_image_size >= m_image_size, ResultOutOfMemory); | 904 | R_UNLESS(stack_size + m_code_size >= m_code_size, ResultOutOfMemory); |
| 703 | 905 | ||
| 704 | // Place a tentative reservation of memory for our new stack. | 906 | // Place a tentative reservation of memory for our new stack. |
| 705 | KScopedResourceReservation mem_reservation(this, Svc::LimitableResource::PhysicalMemoryMax, | 907 | KScopedResourceReservation mem_reservation(this, Svc::LimitableResource::PhysicalMemoryMax, |
| @@ -707,21 +909,359 @@ Result KProcess::AllocateMainThreadStack(std::size_t stack_size) { | |||
| 707 | R_UNLESS(mem_reservation.Succeeded(), ResultLimitReached); | 909 | R_UNLESS(mem_reservation.Succeeded(), ResultLimitReached); |
| 708 | 910 | ||
| 709 | // Allocate and map our stack. | 911 | // Allocate and map our stack. |
| 912 | KProcessAddress stack_top = 0; | ||
| 710 | if (stack_size) { | 913 | if (stack_size) { |
| 711 | KProcessAddress stack_bottom; | 914 | KProcessAddress stack_bottom; |
| 712 | R_TRY(m_page_table.MapPages(std::addressof(stack_bottom), stack_size / PageSize, | 915 | R_TRY(m_page_table.MapPages(std::addressof(stack_bottom), stack_size / PageSize, |
| 713 | KMemoryState::Stack, KMemoryPermission::UserReadWrite)); | 916 | KMemoryState::Stack, KMemoryPermission::UserReadWrite)); |
| 714 | 917 | ||
| 715 | m_main_thread_stack_top = stack_bottom + stack_size; | 918 | stack_top = stack_bottom + stack_size; |
| 716 | m_main_thread_stack_size = stack_size; | 919 | m_main_thread_stack_size = stack_size; |
| 717 | } | 920 | } |
| 718 | 921 | ||
| 922 | // Ensure our stack is safe to clean up on exit. | ||
| 923 | ON_RESULT_FAILURE { | ||
| 924 | if (m_main_thread_stack_size) { | ||
| 925 | ASSERT(R_SUCCEEDED(m_page_table.UnmapPages(stack_top - m_main_thread_stack_size, | ||
| 926 | m_main_thread_stack_size / PageSize, | ||
| 927 | KMemoryState::Stack))); | ||
| 928 | m_main_thread_stack_size = 0; | ||
| 929 | } | ||
| 930 | }; | ||
| 931 | |||
| 932 | // Set our maximum heap size. | ||
| 933 | R_TRY(m_page_table.SetMaxHeapSize(m_max_process_memory - | ||
| 934 | (m_main_thread_stack_size + m_code_size))); | ||
| 935 | |||
| 936 | // Initialize our handle table. | ||
| 937 | R_TRY(this->InitializeHandleTable(m_capabilities.GetHandleTableSize())); | ||
| 938 | ON_RESULT_FAILURE_2 { | ||
| 939 | this->FinalizeHandleTable(); | ||
| 940 | }; | ||
| 941 | |||
| 942 | // Create a new thread for the process. | ||
| 943 | KThread* main_thread = KThread::Create(m_kernel); | ||
| 944 | R_UNLESS(main_thread != nullptr, ResultOutOfResource); | ||
| 945 | SCOPE_EXIT({ main_thread->Close(); }); | ||
| 946 | |||
| 947 | // Initialize the thread. | ||
| 948 | R_TRY(KThread::InitializeUserThread(m_kernel.System(), main_thread, this->GetEntryPoint(), 0, | ||
| 949 | stack_top, priority, m_ideal_core_id, this)); | ||
| 950 | |||
| 951 | // Register the thread, and commit our reservation. | ||
| 952 | KThread::Register(m_kernel, main_thread); | ||
| 953 | thread_reservation.Commit(); | ||
| 954 | |||
| 955 | // Add the thread to our handle table. | ||
| 956 | Handle thread_handle; | ||
| 957 | R_TRY(m_handle_table.Add(std::addressof(thread_handle), main_thread)); | ||
| 958 | |||
| 959 | // Set the thread arguments. | ||
| 960 | main_thread->GetContext32().cpu_registers[0] = 0; | ||
| 961 | main_thread->GetContext64().cpu_registers[0] = 0; | ||
| 962 | main_thread->GetContext32().cpu_registers[1] = thread_handle; | ||
| 963 | main_thread->GetContext64().cpu_registers[1] = thread_handle; | ||
| 964 | |||
| 965 | // Update our state. | ||
| 966 | this->ChangeState((state == State::Created) ? State::Running : State::RunningAttached); | ||
| 967 | ON_RESULT_FAILURE_2 { | ||
| 968 | this->ChangeState(state); | ||
| 969 | }; | ||
| 970 | |||
| 971 | // Suspend for debug, if we should. | ||
| 972 | if (m_kernel.System().DebuggerEnabled()) { | ||
| 973 | main_thread->RequestSuspend(SuspendType::Debug); | ||
| 974 | } | ||
| 975 | |||
| 976 | // Run our thread. | ||
| 977 | R_TRY(main_thread->Run()); | ||
| 978 | |||
| 979 | // Open a reference to represent that we're running. | ||
| 980 | this->Open(); | ||
| 981 | |||
| 719 | // We succeeded! Commit our memory reservation. | 982 | // We succeeded! Commit our memory reservation. |
| 720 | mem_reservation.Commit(); | 983 | mem_reservation.Commit(); |
| 721 | 984 | ||
| 722 | R_SUCCEED(); | 985 | R_SUCCEED(); |
| 723 | } | 986 | } |
| 724 | 987 | ||
| 988 | Result KProcess::Reset() { | ||
| 989 | // Lock the process and the scheduler. | ||
| 990 | KScopedLightLock lk(m_state_lock); | ||
| 991 | KScopedSchedulerLock sl(m_kernel); | ||
| 992 | |||
| 993 | // Validate that we're in a state that we can reset. | ||
| 994 | R_UNLESS(m_state != State::Terminated, ResultInvalidState); | ||
| 995 | R_UNLESS(m_is_signaled, ResultInvalidState); | ||
| 996 | |||
| 997 | // Clear signaled. | ||
| 998 | m_is_signaled = false; | ||
| 999 | R_SUCCEED(); | ||
| 1000 | } | ||
| 1001 | |||
| 1002 | Result KProcess::SetActivity(Svc::ProcessActivity activity) { | ||
| 1003 | // Lock ourselves and the scheduler. | ||
| 1004 | KScopedLightLock lk(m_state_lock); | ||
| 1005 | KScopedLightLock list_lk(m_list_lock); | ||
| 1006 | KScopedSchedulerLock sl(m_kernel); | ||
| 1007 | |||
| 1008 | // Validate our state. | ||
| 1009 | R_UNLESS(m_state != State::Terminating, ResultInvalidState); | ||
| 1010 | R_UNLESS(m_state != State::Terminated, ResultInvalidState); | ||
| 1011 | |||
| 1012 | // Either pause or resume. | ||
| 1013 | if (activity == Svc::ProcessActivity::Paused) { | ||
| 1014 | // Verify that we're not suspended. | ||
| 1015 | R_UNLESS(!m_is_suspended, ResultInvalidState); | ||
| 1016 | |||
| 1017 | // Suspend all threads. | ||
| 1018 | auto end = this->GetThreadList().end(); | ||
| 1019 | for (auto it = this->GetThreadList().begin(); it != end; ++it) { | ||
| 1020 | it->RequestSuspend(SuspendType::Process); | ||
| 1021 | } | ||
| 1022 | |||
| 1023 | // Set ourselves as suspended. | ||
| 1024 | this->SetSuspended(true); | ||
| 1025 | } else { | ||
| 1026 | ASSERT(activity == Svc::ProcessActivity::Runnable); | ||
| 1027 | |||
| 1028 | // Verify that we're suspended. | ||
| 1029 | R_UNLESS(m_is_suspended, ResultInvalidState); | ||
| 1030 | |||
| 1031 | // Resume all threads. | ||
| 1032 | auto end = this->GetThreadList().end(); | ||
| 1033 | for (auto it = this->GetThreadList().begin(); it != end; ++it) { | ||
| 1034 | it->Resume(SuspendType::Process); | ||
| 1035 | } | ||
| 1036 | |||
| 1037 | // Set ourselves as resumed. | ||
| 1038 | this->SetSuspended(false); | ||
| 1039 | } | ||
| 1040 | |||
| 1041 | R_SUCCEED(); | ||
| 1042 | } | ||
| 1043 | |||
| 1044 | void KProcess::PinCurrentThread() { | ||
| 1045 | ASSERT(KScheduler::IsSchedulerLockedByCurrentThread(m_kernel)); | ||
| 1046 | |||
| 1047 | // Get the current thread. | ||
| 1048 | const s32 core_id = GetCurrentCoreId(m_kernel); | ||
| 1049 | KThread* cur_thread = GetCurrentThreadPointer(m_kernel); | ||
| 1050 | |||
| 1051 | // If the thread isn't terminated, pin it. | ||
| 1052 | if (!cur_thread->IsTerminationRequested()) { | ||
| 1053 | // Pin it. | ||
| 1054 | this->PinThread(core_id, cur_thread); | ||
| 1055 | cur_thread->Pin(core_id); | ||
| 1056 | |||
| 1057 | // An update is needed. | ||
| 1058 | KScheduler::SetSchedulerUpdateNeeded(m_kernel); | ||
| 1059 | } | ||
| 1060 | } | ||
| 1061 | |||
| 1062 | void KProcess::UnpinCurrentThread() { | ||
| 1063 | ASSERT(KScheduler::IsSchedulerLockedByCurrentThread(m_kernel)); | ||
| 1064 | |||
| 1065 | // Get the current thread. | ||
| 1066 | const s32 core_id = GetCurrentCoreId(m_kernel); | ||
| 1067 | KThread* cur_thread = GetCurrentThreadPointer(m_kernel); | ||
| 1068 | |||
| 1069 | // Unpin it. | ||
| 1070 | cur_thread->Unpin(); | ||
| 1071 | this->UnpinThread(core_id, cur_thread); | ||
| 1072 | |||
| 1073 | // An update is needed. | ||
| 1074 | KScheduler::SetSchedulerUpdateNeeded(m_kernel); | ||
| 1075 | } | ||
| 1076 | |||
| 1077 | void KProcess::UnpinThread(KThread* thread) { | ||
| 1078 | ASSERT(KScheduler::IsSchedulerLockedByCurrentThread(m_kernel)); | ||
| 1079 | |||
| 1080 | // Get the thread's core id. | ||
| 1081 | const auto core_id = thread->GetActiveCore(); | ||
| 1082 | |||
| 1083 | // Unpin it. | ||
| 1084 | this->UnpinThread(core_id, thread); | ||
| 1085 | thread->Unpin(); | ||
| 1086 | |||
| 1087 | // An update is needed. | ||
| 1088 | KScheduler::SetSchedulerUpdateNeeded(m_kernel); | ||
| 1089 | } | ||
| 1090 | |||
| 1091 | Result KProcess::GetThreadList(s32* out_num_threads, KProcessAddress out_thread_ids, | ||
| 1092 | s32 max_out_count) { | ||
| 1093 | // TODO: use current memory reference | ||
| 1094 | auto& memory = m_kernel.System().ApplicationMemory(); | ||
| 1095 | |||
| 1096 | // Lock the list. | ||
| 1097 | KScopedLightLock lk(m_list_lock); | ||
| 1098 | |||
| 1099 | // Iterate over the list. | ||
| 1100 | s32 count = 0; | ||
| 1101 | auto end = this->GetThreadList().end(); | ||
| 1102 | for (auto it = this->GetThreadList().begin(); it != end; ++it) { | ||
| 1103 | // If we're within array bounds, write the id. | ||
| 1104 | if (count < max_out_count) { | ||
| 1105 | // Get the thread id. | ||
| 1106 | KThread* thread = std::addressof(*it); | ||
| 1107 | const u64 id = thread->GetId(); | ||
| 1108 | |||
| 1109 | // Copy the id to userland. | ||
| 1110 | memory.Write64(out_thread_ids + count * sizeof(u64), id); | ||
| 1111 | } | ||
| 1112 | |||
| 1113 | // Increment the count. | ||
| 1114 | ++count; | ||
| 1115 | } | ||
| 1116 | |||
| 1117 | // We successfully iterated the list. | ||
| 1118 | *out_num_threads = count; | ||
| 1119 | R_SUCCEED(); | ||
| 1120 | } | ||
| 1121 | |||
| 1122 | void KProcess::Switch(KProcess* cur_process, KProcess* next_process) {} | ||
| 1123 | |||
| 1124 | KProcess::KProcess(KernelCore& kernel) | ||
| 1125 | : KAutoObjectWithSlabHeapAndContainer(kernel), m_page_table{kernel.System()}, | ||
| 1126 | m_state_lock{kernel}, m_list_lock{kernel}, m_cond_var{kernel.System()}, | ||
| 1127 | m_address_arbiter{kernel.System()}, m_handle_table{kernel} {} | ||
| 1128 | KProcess::~KProcess() = default; | ||
| 1129 | |||
| 1130 | Result KProcess::LoadFromMetadata(const FileSys::ProgramMetadata& metadata, std::size_t code_size, | ||
| 1131 | bool is_hbl) { | ||
| 1132 | // Create a resource limit for the process. | ||
| 1133 | const auto physical_memory_size = | ||
| 1134 | m_kernel.MemoryManager().GetSize(Kernel::KMemoryManager::Pool::Application); | ||
| 1135 | auto* res_limit = | ||
| 1136 | Kernel::CreateResourceLimitForProcess(m_kernel.System(), physical_memory_size); | ||
| 1137 | |||
| 1138 | // Ensure we maintain a clean state on exit. | ||
| 1139 | SCOPE_EXIT({ res_limit->Close(); }); | ||
| 1140 | |||
| 1141 | // Declare flags and code address. | ||
| 1142 | Svc::CreateProcessFlag flag{}; | ||
| 1143 | u64 code_address{}; | ||
| 1144 | |||
| 1145 | // We are an application. | ||
| 1146 | flag |= Svc::CreateProcessFlag::IsApplication; | ||
| 1147 | |||
| 1148 | // If we are 64-bit, create as such. | ||
| 1149 | if (metadata.Is64BitProgram()) { | ||
| 1150 | flag |= Svc::CreateProcessFlag::Is64Bit; | ||
| 1151 | } | ||
| 1152 | |||
| 1153 | // Set the address space type and code address. | ||
| 1154 | switch (metadata.GetAddressSpaceType()) { | ||
| 1155 | case FileSys::ProgramAddressSpaceType::Is39Bit: | ||
| 1156 | flag |= Svc::CreateProcessFlag::AddressSpace64Bit; | ||
| 1157 | |||
| 1158 | // For 39-bit processes, the ASLR region starts at 0x800'0000 and is ~512GiB large. | ||
| 1159 | // However, some (buggy) programs/libraries like skyline incorrectly depend on the | ||
| 1160 | // existence of ASLR pages before the entry point, so we will adjust the load address | ||
| 1161 | // to point to about 2GiB into the ASLR region. | ||
| 1162 | code_address = 0x8000'0000; | ||
| 1163 | break; | ||
| 1164 | case FileSys::ProgramAddressSpaceType::Is36Bit: | ||
| 1165 | flag |= Svc::CreateProcessFlag::AddressSpace64BitDeprecated; | ||
| 1166 | code_address = 0x800'0000; | ||
| 1167 | break; | ||
| 1168 | case FileSys::ProgramAddressSpaceType::Is32Bit: | ||
| 1169 | flag |= Svc::CreateProcessFlag::AddressSpace32Bit; | ||
| 1170 | code_address = 0x20'0000; | ||
| 1171 | break; | ||
| 1172 | case FileSys::ProgramAddressSpaceType::Is32BitNoMap: | ||
| 1173 | flag |= Svc::CreateProcessFlag::AddressSpace32BitWithoutAlias; | ||
| 1174 | code_address = 0x20'0000; | ||
| 1175 | break; | ||
| 1176 | } | ||
| 1177 | |||
| 1178 | Svc::CreateProcessParameter params{ | ||
| 1179 | .name = {}, | ||
| 1180 | .version = {}, | ||
| 1181 | .program_id = metadata.GetTitleID(), | ||
| 1182 | .code_address = code_address, | ||
| 1183 | .code_num_pages = static_cast<s32>(code_size / PageSize), | ||
| 1184 | .flags = flag, | ||
| 1185 | .reslimit = Svc::InvalidHandle, | ||
| 1186 | .system_resource_num_pages = static_cast<s32>(metadata.GetSystemResourceSize() / PageSize), | ||
| 1187 | }; | ||
| 1188 | |||
| 1189 | // Set the process name. | ||
| 1190 | const auto& name = metadata.GetName(); | ||
| 1191 | static_assert(sizeof(params.name) <= sizeof(name)); | ||
| 1192 | std::memcpy(params.name.data(), name.data(), sizeof(params.name)); | ||
| 1193 | |||
| 1194 | // Initialize for application process. | ||
| 1195 | R_TRY(this->Initialize(params, metadata.GetKernelCapabilities(), res_limit, | ||
| 1196 | KMemoryManager::Pool::Application)); | ||
| 1197 | |||
| 1198 | // Assign remaining properties. | ||
| 1199 | m_is_hbl = is_hbl; | ||
| 1200 | m_ideal_core_id = metadata.GetMainThreadCore(); | ||
| 1201 | |||
| 1202 | // We succeeded. | ||
| 1203 | R_SUCCEED(); | ||
| 1204 | } | ||
| 1205 | |||
| 1206 | void KProcess::LoadModule(CodeSet code_set, KProcessAddress base_addr) { | ||
| 1207 | const auto ReprotectSegment = [&](const CodeSet::Segment& segment, | ||
| 1208 | Svc::MemoryPermission permission) { | ||
| 1209 | m_page_table.SetProcessMemoryPermission(segment.addr + base_addr, segment.size, permission); | ||
| 1210 | }; | ||
| 1211 | |||
| 1212 | this->GetMemory().WriteBlock(base_addr, code_set.memory.data(), code_set.memory.size()); | ||
| 1213 | |||
| 1214 | ReprotectSegment(code_set.CodeSegment(), Svc::MemoryPermission::ReadExecute); | ||
| 1215 | ReprotectSegment(code_set.RODataSegment(), Svc::MemoryPermission::Read); | ||
| 1216 | ReprotectSegment(code_set.DataSegment(), Svc::MemoryPermission::ReadWrite); | ||
| 1217 | } | ||
| 1218 | |||
| 1219 | bool KProcess::InsertWatchpoint(KProcessAddress addr, u64 size, DebugWatchpointType type) { | ||
| 1220 | const auto watch{std::find_if(m_watchpoints.begin(), m_watchpoints.end(), [&](const auto& wp) { | ||
| 1221 | return wp.type == DebugWatchpointType::None; | ||
| 1222 | })}; | ||
| 1223 | |||
| 1224 | if (watch == m_watchpoints.end()) { | ||
| 1225 | return false; | ||
| 1226 | } | ||
| 1227 | |||
| 1228 | watch->start_address = addr; | ||
| 1229 | watch->end_address = addr + size; | ||
| 1230 | watch->type = type; | ||
| 1231 | |||
| 1232 | for (KProcessAddress page = Common::AlignDown(GetInteger(addr), PageSize); page < addr + size; | ||
| 1233 | page += PageSize) { | ||
| 1234 | m_debug_page_refcounts[page]++; | ||
| 1235 | this->GetMemory().MarkRegionDebug(page, PageSize, true); | ||
| 1236 | } | ||
| 1237 | |||
| 1238 | return true; | ||
| 1239 | } | ||
| 1240 | |||
| 1241 | bool KProcess::RemoveWatchpoint(KProcessAddress addr, u64 size, DebugWatchpointType type) { | ||
| 1242 | const auto watch{std::find_if(m_watchpoints.begin(), m_watchpoints.end(), [&](const auto& wp) { | ||
| 1243 | return wp.start_address == addr && wp.end_address == addr + size && wp.type == type; | ||
| 1244 | })}; | ||
| 1245 | |||
| 1246 | if (watch == m_watchpoints.end()) { | ||
| 1247 | return false; | ||
| 1248 | } | ||
| 1249 | |||
| 1250 | watch->start_address = 0; | ||
| 1251 | watch->end_address = 0; | ||
| 1252 | watch->type = DebugWatchpointType::None; | ||
| 1253 | |||
| 1254 | for (KProcessAddress page = Common::AlignDown(GetInteger(addr), PageSize); page < addr + size; | ||
| 1255 | page += PageSize) { | ||
| 1256 | m_debug_page_refcounts[page]--; | ||
| 1257 | if (!m_debug_page_refcounts[page]) { | ||
| 1258 | this->GetMemory().MarkRegionDebug(page, PageSize, false); | ||
| 1259 | } | ||
| 1260 | } | ||
| 1261 | |||
| 1262 | return true; | ||
| 1263 | } | ||
| 1264 | |||
| 725 | Core::Memory::Memory& KProcess::GetMemory() const { | 1265 | Core::Memory::Memory& KProcess::GetMemory() const { |
| 726 | // TODO: per-process memory | 1266 | // TODO: per-process memory |
| 727 | return m_kernel.System().ApplicationMemory(); | 1267 | return m_kernel.System().ApplicationMemory(); |
diff --git a/src/core/hle/kernel/k_process.h b/src/core/hle/kernel/k_process.h index 146e07a57..f9f755afa 100644 --- a/src/core/hle/kernel/k_process.h +++ b/src/core/hle/kernel/k_process.h | |||
| @@ -1,59 +1,23 @@ | |||
| 1 | // SPDX-FileCopyrightText: 2015 Citra Emulator Project | 1 | // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project |
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | 2 | // SPDX-License-Identifier: GPL-2.0-or-later |
| 3 | 3 | ||
| 4 | #pragma once | 4 | #pragma once |
| 5 | 5 | ||
| 6 | #include <array> | ||
| 7 | #include <cstddef> | ||
| 8 | #include <list> | ||
| 9 | #include <map> | 6 | #include <map> |
| 10 | #include <string> | 7 | |
| 8 | #include "core/hle/kernel/code_set.h" | ||
| 11 | #include "core/hle/kernel/k_address_arbiter.h" | 9 | #include "core/hle/kernel/k_address_arbiter.h" |
| 12 | #include "core/hle/kernel/k_auto_object.h" | 10 | #include "core/hle/kernel/k_capabilities.h" |
| 13 | #include "core/hle/kernel/k_condition_variable.h" | 11 | #include "core/hle/kernel/k_condition_variable.h" |
| 14 | #include "core/hle/kernel/k_handle_table.h" | 12 | #include "core/hle/kernel/k_handle_table.h" |
| 15 | #include "core/hle/kernel/k_page_table.h" | 13 | #include "core/hle/kernel/k_page_table.h" |
| 16 | #include "core/hle/kernel/k_synchronization_object.h" | 14 | #include "core/hle/kernel/k_page_table_manager.h" |
| 15 | #include "core/hle/kernel/k_system_resource.h" | ||
| 16 | #include "core/hle/kernel/k_thread.h" | ||
| 17 | #include "core/hle/kernel/k_thread_local_page.h" | 17 | #include "core/hle/kernel/k_thread_local_page.h" |
| 18 | #include "core/hle/kernel/k_typed_address.h" | ||
| 19 | #include "core/hle/kernel/k_worker_task.h" | ||
| 20 | #include "core/hle/kernel/process_capability.h" | ||
| 21 | #include "core/hle/kernel/slab_helpers.h" | ||
| 22 | #include "core/hle/result.h" | ||
| 23 | |||
| 24 | namespace Core { | ||
| 25 | namespace Memory { | ||
| 26 | class Memory; | ||
| 27 | }; | ||
| 28 | |||
| 29 | class System; | ||
| 30 | } // namespace Core | ||
| 31 | |||
| 32 | namespace FileSys { | ||
| 33 | class ProgramMetadata; | ||
| 34 | } | ||
| 35 | 18 | ||
| 36 | namespace Kernel { | 19 | namespace Kernel { |
| 37 | 20 | ||
| 38 | class KernelCore; | ||
| 39 | class KResourceLimit; | ||
| 40 | class KThread; | ||
| 41 | class KSharedMemoryInfo; | ||
| 42 | class TLSPage; | ||
| 43 | |||
| 44 | struct CodeSet; | ||
| 45 | |||
| 46 | enum class MemoryRegion : u16 { | ||
| 47 | APPLICATION = 1, | ||
| 48 | SYSTEM = 2, | ||
| 49 | BASE = 3, | ||
| 50 | }; | ||
| 51 | |||
| 52 | enum class ProcessActivity : u32 { | ||
| 53 | Runnable, | ||
| 54 | Paused, | ||
| 55 | }; | ||
| 56 | |||
| 57 | enum class DebugWatchpointType : u8 { | 21 | enum class DebugWatchpointType : u8 { |
| 58 | None = 0, | 22 | None = 0, |
| 59 | Read = 1 << 0, | 23 | Read = 1 << 0, |
| @@ -72,9 +36,6 @@ class KProcess final : public KAutoObjectWithSlabHeapAndContainer<KProcess, KWor | |||
| 72 | KERNEL_AUTOOBJECT_TRAITS(KProcess, KSynchronizationObject); | 36 | KERNEL_AUTOOBJECT_TRAITS(KProcess, KSynchronizationObject); |
| 73 | 37 | ||
| 74 | public: | 38 | public: |
| 75 | explicit KProcess(KernelCore& kernel); | ||
| 76 | ~KProcess() override; | ||
| 77 | |||
| 78 | enum class State { | 39 | enum class State { |
| 79 | Created = static_cast<u32>(Svc::ProcessState::Created), | 40 | Created = static_cast<u32>(Svc::ProcessState::Created), |
| 80 | CreatedAttached = static_cast<u32>(Svc::ProcessState::CreatedAttached), | 41 | CreatedAttached = static_cast<u32>(Svc::ProcessState::CreatedAttached), |
| @@ -86,470 +47,493 @@ public: | |||
| 86 | DebugBreak = static_cast<u32>(Svc::ProcessState::DebugBreak), | 47 | DebugBreak = static_cast<u32>(Svc::ProcessState::DebugBreak), |
| 87 | }; | 48 | }; |
| 88 | 49 | ||
| 89 | enum : u64 { | 50 | using ThreadList = Common::IntrusiveListMemberTraits<&KThread::m_process_list_node>::ListType; |
| 90 | /// Lowest allowed process ID for a kernel initial process. | ||
| 91 | InitialKIPIDMin = 1, | ||
| 92 | /// Highest allowed process ID for a kernel initial process. | ||
| 93 | InitialKIPIDMax = 80, | ||
| 94 | |||
| 95 | /// Lowest allowed process ID for a userland process. | ||
| 96 | ProcessIDMin = 81, | ||
| 97 | /// Highest allowed process ID for a userland process. | ||
| 98 | ProcessIDMax = 0xFFFFFFFFFFFFFFFF, | ||
| 99 | }; | ||
| 100 | 51 | ||
| 101 | // Used to determine how process IDs are assigned. | 52 | static constexpr size_t AslrAlignment = 2_MiB; |
| 102 | enum class ProcessType { | ||
| 103 | KernelInternal, | ||
| 104 | Userland, | ||
| 105 | }; | ||
| 106 | 53 | ||
| 107 | static constexpr std::size_t RANDOM_ENTROPY_SIZE = 4; | 54 | public: |
| 55 | static constexpr u64 InitialProcessIdMin = 1; | ||
| 56 | static constexpr u64 InitialProcessIdMax = 0x50; | ||
| 108 | 57 | ||
| 109 | static Result Initialize(KProcess* process, Core::System& system, std::string process_name, | 58 | static constexpr u64 ProcessIdMin = InitialProcessIdMax + 1; |
| 110 | ProcessType type, KResourceLimit* res_limit); | 59 | static constexpr u64 ProcessIdMax = std::numeric_limits<u64>::max(); |
| 111 | 60 | ||
| 112 | /// Gets a reference to the process' page table. | 61 | private: |
| 113 | KPageTable& GetPageTable() { | 62 | using SharedMemoryInfoList = Common::IntrusiveListBaseTraits<KSharedMemoryInfo>::ListType; |
| 114 | return m_page_table; | 63 | using TLPTree = |
| 115 | } | 64 | Common::IntrusiveRedBlackTreeBaseTraits<KThreadLocalPage>::TreeType<KThreadLocalPage>; |
| 65 | using TLPIterator = TLPTree::iterator; | ||
| 116 | 66 | ||
| 117 | /// Gets const a reference to the process' page table. | 67 | private: |
| 118 | const KPageTable& GetPageTable() const { | 68 | KPageTable m_page_table; |
| 119 | return m_page_table; | 69 | std::atomic<size_t> m_used_kernel_memory_size{}; |
| 120 | } | 70 | TLPTree m_fully_used_tlp_tree{}; |
| 71 | TLPTree m_partially_used_tlp_tree{}; | ||
| 72 | s32 m_ideal_core_id{}; | ||
| 73 | KResourceLimit* m_resource_limit{}; | ||
| 74 | KSystemResource* m_system_resource{}; | ||
| 75 | size_t m_memory_release_hint{}; | ||
| 76 | State m_state{}; | ||
| 77 | KLightLock m_state_lock; | ||
| 78 | KLightLock m_list_lock; | ||
| 79 | KConditionVariable m_cond_var; | ||
| 80 | KAddressArbiter m_address_arbiter; | ||
| 81 | std::array<u64, 4> m_entropy{}; | ||
| 82 | bool m_is_signaled{}; | ||
| 83 | bool m_is_initialized{}; | ||
| 84 | bool m_is_application{}; | ||
| 85 | bool m_is_default_application_system_resource{}; | ||
| 86 | bool m_is_hbl{}; | ||
| 87 | std::array<char, 13> m_name{}; | ||
| 88 | std::atomic<u16> m_num_running_threads{}; | ||
| 89 | Svc::CreateProcessFlag m_flags{}; | ||
| 90 | KMemoryManager::Pool m_memory_pool{}; | ||
| 91 | s64 m_schedule_count{}; | ||
| 92 | KCapabilities m_capabilities{}; | ||
| 93 | u64 m_program_id{}; | ||
| 94 | u64 m_process_id{}; | ||
| 95 | KProcessAddress m_code_address{}; | ||
| 96 | size_t m_code_size{}; | ||
| 97 | size_t m_main_thread_stack_size{}; | ||
| 98 | size_t m_max_process_memory{}; | ||
| 99 | u32 m_version{}; | ||
| 100 | KHandleTable m_handle_table; | ||
| 101 | KProcessAddress m_plr_address{}; | ||
| 102 | KThread* m_exception_thread{}; | ||
| 103 | ThreadList m_thread_list{}; | ||
| 104 | SharedMemoryInfoList m_shared_memory_list{}; | ||
| 105 | bool m_is_suspended{}; | ||
| 106 | bool m_is_immortal{}; | ||
| 107 | bool m_is_handle_table_initialized{}; | ||
| 108 | std::array<KThread*, Core::Hardware::NUM_CPU_CORES> m_running_threads{}; | ||
| 109 | std::array<u64, Core::Hardware::NUM_CPU_CORES> m_running_thread_idle_counts{}; | ||
| 110 | std::array<u64, Core::Hardware::NUM_CPU_CORES> m_running_thread_switch_counts{}; | ||
| 111 | std::array<KThread*, Core::Hardware::NUM_CPU_CORES> m_pinned_threads{}; | ||
| 112 | std::array<DebugWatchpoint, Core::Hardware::NUM_WATCHPOINTS> m_watchpoints{}; | ||
| 113 | std::map<KProcessAddress, u64> m_debug_page_refcounts{}; | ||
| 114 | std::atomic<s64> m_cpu_time{}; | ||
| 115 | std::atomic<s64> m_num_process_switches{}; | ||
| 116 | std::atomic<s64> m_num_thread_switches{}; | ||
| 117 | std::atomic<s64> m_num_fpu_switches{}; | ||
| 118 | std::atomic<s64> m_num_supervisor_calls{}; | ||
| 119 | std::atomic<s64> m_num_ipc_messages{}; | ||
| 120 | std::atomic<s64> m_num_ipc_replies{}; | ||
| 121 | std::atomic<s64> m_num_ipc_receives{}; | ||
| 121 | 122 | ||
| 122 | /// Gets a reference to the process' handle table. | 123 | private: |
| 123 | KHandleTable& GetHandleTable() { | 124 | Result StartTermination(); |
| 124 | return m_handle_table; | 125 | void FinishTermination(); |
| 125 | } | ||
| 126 | 126 | ||
| 127 | /// Gets a const reference to the process' handle table. | 127 | void PinThread(s32 core_id, KThread* thread) { |
| 128 | const KHandleTable& GetHandleTable() const { | 128 | ASSERT(0 <= core_id && core_id < static_cast<s32>(Core::Hardware::NUM_CPU_CORES)); |
| 129 | return m_handle_table; | 129 | ASSERT(thread != nullptr); |
| 130 | ASSERT(m_pinned_threads[core_id] == nullptr); | ||
| 131 | m_pinned_threads[core_id] = thread; | ||
| 130 | } | 132 | } |
| 131 | 133 | ||
| 132 | /// Gets a reference to process's memory. | 134 | void UnpinThread(s32 core_id, KThread* thread) { |
| 133 | Core::Memory::Memory& GetMemory() const; | 135 | ASSERT(0 <= core_id && core_id < static_cast<s32>(Core::Hardware::NUM_CPU_CORES)); |
| 134 | 136 | ASSERT(thread != nullptr); | |
| 135 | Result SignalToAddress(KProcessAddress address) { | 137 | ASSERT(m_pinned_threads[core_id] == thread); |
| 136 | return m_condition_var.SignalToAddress(address); | 138 | m_pinned_threads[core_id] = nullptr; |
| 137 | } | 139 | } |
| 138 | 140 | ||
| 139 | Result WaitForAddress(Handle handle, KProcessAddress address, u32 tag) { | 141 | public: |
| 140 | return m_condition_var.WaitForAddress(handle, address, tag); | 142 | explicit KProcess(KernelCore& kernel); |
| 141 | } | 143 | ~KProcess() override; |
| 142 | 144 | ||
| 143 | void SignalConditionVariable(u64 cv_key, int32_t count) { | 145 | Result Initialize(const Svc::CreateProcessParameter& params, KResourceLimit* res_limit, |
| 144 | return m_condition_var.Signal(cv_key, count); | 146 | bool is_real); |
| 145 | } | ||
| 146 | 147 | ||
| 147 | Result WaitConditionVariable(KProcessAddress address, u64 cv_key, u32 tag, s64 ns) { | 148 | Result Initialize(const Svc::CreateProcessParameter& params, const KPageGroup& pg, |
| 148 | R_RETURN(m_condition_var.Wait(address, cv_key, tag, ns)); | 149 | std::span<const u32> caps, KResourceLimit* res_limit, |
| 149 | } | 150 | KMemoryManager::Pool pool, bool immortal); |
| 151 | Result Initialize(const Svc::CreateProcessParameter& params, std::span<const u32> user_caps, | ||
| 152 | KResourceLimit* res_limit, KMemoryManager::Pool pool); | ||
| 153 | void Exit(); | ||
| 150 | 154 | ||
| 151 | Result SignalAddressArbiter(uint64_t address, Svc::SignalType signal_type, s32 value, | 155 | const char* GetName() const { |
| 152 | s32 count) { | 156 | return m_name.data(); |
| 153 | R_RETURN(m_address_arbiter.SignalToAddress(address, signal_type, value, count)); | ||
| 154 | } | 157 | } |
| 155 | 158 | ||
| 156 | Result WaitAddressArbiter(uint64_t address, Svc::ArbitrationType arb_type, s32 value, | 159 | u64 GetProgramId() const { |
| 157 | s64 timeout) { | 160 | return m_program_id; |
| 158 | R_RETURN(m_address_arbiter.WaitForAddress(address, arb_type, value, timeout)); | ||
| 159 | } | 161 | } |
| 160 | 162 | ||
| 161 | KProcessAddress GetProcessLocalRegionAddress() const { | 163 | u64 GetProcessId() const { |
| 162 | return m_plr_address; | 164 | return m_process_id; |
| 163 | } | 165 | } |
| 164 | 166 | ||
| 165 | /// Gets the current status of the process | ||
| 166 | State GetState() const { | 167 | State GetState() const { |
| 167 | return m_state; | 168 | return m_state; |
| 168 | } | 169 | } |
| 169 | 170 | ||
| 170 | /// Gets the unique ID that identifies this particular process. | 171 | u64 GetCoreMask() const { |
| 171 | u64 GetProcessId() const { | 172 | return m_capabilities.GetCoreMask(); |
| 172 | return m_process_id; | 173 | } |
| 174 | u64 GetPhysicalCoreMask() const { | ||
| 175 | return m_capabilities.GetPhysicalCoreMask(); | ||
| 176 | } | ||
| 177 | u64 GetPriorityMask() const { | ||
| 178 | return m_capabilities.GetPriorityMask(); | ||
| 173 | } | 179 | } |
| 174 | 180 | ||
| 175 | /// Gets the program ID corresponding to this process. | 181 | s32 GetIdealCoreId() const { |
| 176 | u64 GetProgramId() const { | 182 | return m_ideal_core_id; |
| 177 | return m_program_id; | 183 | } |
| 184 | void SetIdealCoreId(s32 core_id) { | ||
| 185 | m_ideal_core_id = core_id; | ||
| 178 | } | 186 | } |
| 179 | 187 | ||
| 180 | KProcessAddress GetEntryPoint() const { | 188 | bool CheckThreadPriority(s32 prio) const { |
| 181 | return m_code_address; | 189 | return ((1ULL << prio) & this->GetPriorityMask()) != 0; |
| 182 | } | 190 | } |
| 183 | 191 | ||
| 184 | /// Gets the resource limit descriptor for this process | 192 | u32 GetCreateProcessFlags() const { |
| 185 | KResourceLimit* GetResourceLimit() const; | 193 | return static_cast<u32>(m_flags); |
| 194 | } | ||
| 186 | 195 | ||
| 187 | /// Gets the ideal CPU core ID for this process | 196 | bool Is64Bit() const { |
| 188 | u8 GetIdealCoreId() const { | 197 | return True(m_flags & Svc::CreateProcessFlag::Is64Bit); |
| 189 | return m_ideal_core; | ||
| 190 | } | 198 | } |
| 191 | 199 | ||
| 192 | /// Checks if the specified thread priority is valid. | 200 | KProcessAddress GetEntryPoint() const { |
| 193 | bool CheckThreadPriority(s32 prio) const { | 201 | return m_code_address; |
| 194 | return ((1ULL << prio) & GetPriorityMask()) != 0; | ||
| 195 | } | 202 | } |
| 196 | 203 | ||
| 197 | /// Gets the bitmask of allowed cores that this process' threads can run on. | 204 | size_t GetMainStackSize() const { |
| 198 | u64 GetCoreMask() const { | 205 | return m_main_thread_stack_size; |
| 199 | return m_capabilities.GetCoreMask(); | ||
| 200 | } | 206 | } |
| 201 | 207 | ||
| 202 | /// Gets the bitmask of allowed thread priorities. | 208 | KMemoryManager::Pool GetMemoryPool() const { |
| 203 | u64 GetPriorityMask() const { | 209 | return m_memory_pool; |
| 204 | return m_capabilities.GetPriorityMask(); | ||
| 205 | } | 210 | } |
| 206 | 211 | ||
| 207 | /// Gets the amount of secure memory to allocate for memory management. | 212 | u64 GetRandomEntropy(size_t i) const { |
| 208 | u32 GetSystemResourceSize() const { | 213 | return m_entropy[i]; |
| 209 | return m_system_resource_size; | ||
| 210 | } | 214 | } |
| 211 | 215 | ||
| 212 | /// Gets the amount of secure memory currently in use for memory management. | 216 | bool IsApplication() const { |
| 213 | u32 GetSystemResourceUsage() const { | 217 | return m_is_application; |
| 214 | // On hardware, this returns the amount of system resource memory that has | ||
| 215 | // been used by the kernel. This is problematic for Yuzu to emulate, because | ||
| 216 | // system resource memory is used for page tables -- and yuzu doesn't really | ||
| 217 | // have a way to calculate how much memory is required for page tables for | ||
| 218 | // the current process at any given time. | ||
| 219 | // TODO: Is this even worth implementing? Games may retrieve this value via | ||
| 220 | // an SDK function that gets used + available system resource size for debug | ||
| 221 | // or diagnostic purposes. However, it seems unlikely that a game would make | ||
| 222 | // decisions based on how much system memory is dedicated to its page tables. | ||
| 223 | // Is returning a value other than zero wise? | ||
| 224 | return 0; | ||
| 225 | } | 218 | } |
| 226 | 219 | ||
| 227 | /// Whether this process is an AArch64 or AArch32 process. | 220 | bool IsDefaultApplicationSystemResource() const { |
| 228 | bool Is64BitProcess() const { | 221 | return m_is_default_application_system_resource; |
| 229 | return m_is_64bit_process; | ||
| 230 | } | 222 | } |
| 231 | 223 | ||
| 232 | bool IsSuspended() const { | 224 | bool IsSuspended() const { |
| 233 | return m_is_suspended; | 225 | return m_is_suspended; |
| 234 | } | 226 | } |
| 235 | |||
| 236 | void SetSuspended(bool suspended) { | 227 | void SetSuspended(bool suspended) { |
| 237 | m_is_suspended = suspended; | 228 | m_is_suspended = suspended; |
| 238 | } | 229 | } |
| 239 | 230 | ||
| 240 | /// Gets the total running time of the process instance in ticks. | 231 | Result Terminate(); |
| 241 | u64 GetCPUTimeTicks() const { | 232 | |
| 242 | return m_total_process_running_time_ticks; | 233 | bool IsTerminated() const { |
| 234 | return m_state == State::Terminated; | ||
| 243 | } | 235 | } |
| 244 | 236 | ||
| 245 | /// Updates the total running time, adding the given ticks to it. | 237 | bool IsPermittedSvc(u32 svc_id) const { |
| 246 | void UpdateCPUTimeTicks(u64 ticks) { | 238 | return m_capabilities.IsPermittedSvc(svc_id); |
| 247 | m_total_process_running_time_ticks += ticks; | ||
| 248 | } | 239 | } |
| 249 | 240 | ||
| 250 | /// Gets the process schedule count, used for thread yielding | 241 | bool IsPermittedInterrupt(s32 interrupt_id) const { |
| 251 | s64 GetScheduledCount() const { | 242 | return m_capabilities.IsPermittedInterrupt(interrupt_id); |
| 252 | return m_schedule_count; | ||
| 253 | } | 243 | } |
| 254 | 244 | ||
| 255 | /// Increments the process schedule count, used for thread yielding. | 245 | bool IsPermittedDebug() const { |
| 256 | void IncrementScheduledCount() { | 246 | return m_capabilities.IsPermittedDebug(); |
| 257 | ++m_schedule_count; | ||
| 258 | } | 247 | } |
| 259 | 248 | ||
| 260 | void IncrementRunningThreadCount(); | 249 | bool CanForceDebug() const { |
| 261 | void DecrementRunningThreadCount(); | 250 | return m_capabilities.CanForceDebug(); |
| 251 | } | ||
| 262 | 252 | ||
| 263 | void SetRunningThread(s32 core, KThread* thread, u64 idle_count) { | 253 | bool IsHbl() const { |
| 264 | m_running_threads[core] = thread; | 254 | return m_is_hbl; |
| 265 | m_running_thread_idle_counts[core] = idle_count; | ||
| 266 | } | 255 | } |
| 267 | 256 | ||
| 268 | void ClearRunningThread(KThread* thread) { | 257 | Kernel::KMemoryManager::Direction GetAllocateOption() const { |
| 269 | for (size_t i = 0; i < m_running_threads.size(); ++i) { | 258 | // TODO: property of the KPageTableBase |
| 270 | if (m_running_threads[i] == thread) { | 259 | return KMemoryManager::Direction::FromFront; |
| 271 | m_running_threads[i] = nullptr; | ||
| 272 | } | ||
| 273 | } | ||
| 274 | } | 260 | } |
| 275 | 261 | ||
| 276 | [[nodiscard]] KThread* GetRunningThread(s32 core) const { | 262 | ThreadList& GetThreadList() { |
| 277 | return m_running_threads[core]; | 263 | return m_thread_list; |
| 264 | } | ||
| 265 | const ThreadList& GetThreadList() const { | ||
| 266 | return m_thread_list; | ||
| 278 | } | 267 | } |
| 279 | 268 | ||
| 269 | bool EnterUserException(); | ||
| 270 | bool LeaveUserException(); | ||
| 280 | bool ReleaseUserException(KThread* thread); | 271 | bool ReleaseUserException(KThread* thread); |
| 281 | 272 | ||
| 282 | [[nodiscard]] KThread* GetPinnedThread(s32 core_id) const { | 273 | KThread* GetPinnedThread(s32 core_id) const { |
| 283 | ASSERT(0 <= core_id && core_id < static_cast<s32>(Core::Hardware::NUM_CPU_CORES)); | 274 | ASSERT(0 <= core_id && core_id < static_cast<s32>(Core::Hardware::NUM_CPU_CORES)); |
| 284 | return m_pinned_threads[core_id]; | 275 | return m_pinned_threads[core_id]; |
| 285 | } | 276 | } |
| 286 | 277 | ||
| 287 | /// Gets 8 bytes of random data for svcGetInfo RandomEntropy | 278 | const Svc::SvcAccessFlagSet& GetSvcPermissions() const { |
| 288 | u64 GetRandomEntropy(std::size_t index) const { | 279 | return m_capabilities.GetSvcPermissions(); |
| 289 | return m_random_entropy.at(index); | ||
| 290 | } | 280 | } |
| 291 | 281 | ||
| 292 | /// Retrieves the total physical memory available to this process in bytes. | 282 | KResourceLimit* GetResourceLimit() const { |
| 293 | u64 GetTotalPhysicalMemoryAvailable(); | 283 | return m_resource_limit; |
| 294 | |||
| 295 | /// Retrieves the total physical memory available to this process in bytes, | ||
| 296 | /// without the size of the personal system resource heap added to it. | ||
| 297 | u64 GetTotalPhysicalMemoryAvailableWithoutSystemResource(); | ||
| 298 | |||
| 299 | /// Retrieves the total physical memory used by this process in bytes. | ||
| 300 | u64 GetTotalPhysicalMemoryUsed(); | ||
| 301 | |||
| 302 | /// Retrieves the total physical memory used by this process in bytes, | ||
| 303 | /// without the size of the personal system resource heap added to it. | ||
| 304 | u64 GetTotalPhysicalMemoryUsedWithoutSystemResource(); | ||
| 305 | |||
| 306 | /// Gets the list of all threads created with this process as their owner. | ||
| 307 | std::list<KThread*>& GetThreadList() { | ||
| 308 | return m_thread_list; | ||
| 309 | } | 284 | } |
| 310 | 285 | ||
| 311 | /// Registers a thread as being created under this process, | 286 | bool ReserveResource(Svc::LimitableResource which, s64 value); |
| 312 | /// adding it to this process' thread list. | 287 | bool ReserveResource(Svc::LimitableResource which, s64 value, s64 timeout); |
| 313 | void RegisterThread(KThread* thread); | 288 | void ReleaseResource(Svc::LimitableResource which, s64 value); |
| 289 | void ReleaseResource(Svc::LimitableResource which, s64 value, s64 hint); | ||
| 314 | 290 | ||
| 315 | /// Unregisters a thread from this process, removing it | 291 | KLightLock& GetStateLock() { |
| 316 | /// from this process' thread list. | 292 | return m_state_lock; |
| 317 | void UnregisterThread(KThread* thread); | 293 | } |
| 294 | KLightLock& GetListLock() { | ||
| 295 | return m_list_lock; | ||
| 296 | } | ||
| 318 | 297 | ||
| 319 | /// Retrieves the number of available threads for this process. | 298 | KPageTable& GetPageTable() { |
| 320 | u64 GetFreeThreadCount() const; | 299 | return m_page_table; |
| 321 | 300 | } | |
| 322 | /// Clears the signaled state of the process if and only if it's signaled. | 301 | const KPageTable& GetPageTable() const { |
| 323 | /// | 302 | return m_page_table; |
| 324 | /// @pre The process must not be already terminated. If this is called on a | 303 | } |
| 325 | /// terminated process, then ResultInvalidState will be returned. | ||
| 326 | /// | ||
| 327 | /// @pre The process must be in a signaled state. If this is called on a | ||
| 328 | /// process instance that is not signaled, ResultInvalidState will be | ||
| 329 | /// returned. | ||
| 330 | Result Reset(); | ||
| 331 | 304 | ||
| 332 | /** | 305 | KHandleTable& GetHandleTable() { |
| 333 | * Loads process-specifics configuration info with metadata provided | 306 | return m_handle_table; |
| 334 | * by an executable. | 307 | } |
| 335 | * | 308 | const KHandleTable& GetHandleTable() const { |
| 336 | * @param metadata The provided metadata to load process specific info from. | 309 | return m_handle_table; |
| 337 | * | 310 | } |
| 338 | * @returns ResultSuccess if all relevant metadata was able to be | ||
| 339 | * loaded and parsed. Otherwise, an error code is returned. | ||
| 340 | */ | ||
| 341 | Result LoadFromMetadata(const FileSys::ProgramMetadata& metadata, std::size_t code_size, | ||
| 342 | bool is_hbl); | ||
| 343 | 311 | ||
| 344 | /** | 312 | size_t GetUsedUserPhysicalMemorySize() const; |
| 345 | * Starts the main application thread for this process. | 313 | size_t GetTotalUserPhysicalMemorySize() const; |
| 346 | * | 314 | size_t GetUsedNonSystemUserPhysicalMemorySize() const; |
| 347 | * @param main_thread_priority The priority for the main thread. | 315 | size_t GetTotalNonSystemUserPhysicalMemorySize() const; |
| 348 | * @param stack_size The stack size for the main thread in bytes. | ||
| 349 | */ | ||
| 350 | void Run(s32 main_thread_priority, u64 stack_size); | ||
| 351 | 316 | ||
| 352 | /** | 317 | Result AddSharedMemory(KSharedMemory* shmem, KProcessAddress address, size_t size); |
| 353 | * Prepares a process for termination by stopping all of its threads | 318 | void RemoveSharedMemory(KSharedMemory* shmem, KProcessAddress address, size_t size); |
| 354 | * and clearing any other resources. | ||
| 355 | */ | ||
| 356 | void PrepareForTermination(); | ||
| 357 | 319 | ||
| 358 | void LoadModule(CodeSet code_set, KProcessAddress base_addr); | 320 | Result CreateThreadLocalRegion(KProcessAddress* out); |
| 321 | Result DeleteThreadLocalRegion(KProcessAddress addr); | ||
| 359 | 322 | ||
| 360 | bool IsInitialized() const override { | 323 | KProcessAddress GetProcessLocalRegionAddress() const { |
| 361 | return m_is_initialized; | 324 | return m_plr_address; |
| 362 | } | 325 | } |
| 363 | 326 | ||
| 364 | static void PostDestroy(uintptr_t arg) {} | 327 | KThread* GetExceptionThread() const { |
| 365 | 328 | return m_exception_thread; | |
| 366 | void Finalize() override; | ||
| 367 | |||
| 368 | u64 GetId() const override { | ||
| 369 | return GetProcessId(); | ||
| 370 | } | 329 | } |
| 371 | 330 | ||
| 372 | bool IsHbl() const { | 331 | void AddCpuTime(s64 diff) { |
| 373 | return m_is_hbl; | 332 | m_cpu_time += diff; |
| 333 | } | ||
| 334 | s64 GetCpuTime() { | ||
| 335 | return m_cpu_time.load(); | ||
| 374 | } | 336 | } |
| 375 | 337 | ||
| 376 | bool IsSignaled() const override; | 338 | s64 GetScheduledCount() const { |
| 377 | 339 | return m_schedule_count; | |
| 378 | void DoWorkerTaskImpl(); | 340 | } |
| 341 | void IncrementScheduledCount() { | ||
| 342 | ++m_schedule_count; | ||
| 343 | } | ||
| 379 | 344 | ||
| 380 | Result SetActivity(ProcessActivity activity); | 345 | void IncrementRunningThreadCount(); |
| 346 | void DecrementRunningThreadCount(); | ||
| 381 | 347 | ||
| 382 | void PinCurrentThread(s32 core_id); | 348 | size_t GetRequiredSecureMemorySizeNonDefault() const { |
| 383 | void UnpinCurrentThread(s32 core_id); | 349 | if (!this->IsDefaultApplicationSystemResource() && m_system_resource->IsSecureResource()) { |
| 384 | void UnpinThread(KThread* thread); | 350 | auto* secure_system_resource = static_cast<KSecureSystemResource*>(m_system_resource); |
| 351 | return secure_system_resource->CalculateRequiredSecureMemorySize(); | ||
| 352 | } | ||
| 385 | 353 | ||
| 386 | KLightLock& GetStateLock() { | 354 | return 0; |
| 387 | return m_state_lock; | ||
| 388 | } | 355 | } |
| 389 | 356 | ||
| 390 | Result AddSharedMemory(KSharedMemory* shmem, KProcessAddress address, size_t size); | 357 | size_t GetRequiredSecureMemorySize() const { |
| 391 | void RemoveSharedMemory(KSharedMemory* shmem, KProcessAddress address, size_t size); | 358 | if (m_system_resource->IsSecureResource()) { |
| 392 | 359 | auto* secure_system_resource = static_cast<KSecureSystemResource*>(m_system_resource); | |
| 393 | /////////////////////////////////////////////////////////////////////////////////////////////// | 360 | return secure_system_resource->CalculateRequiredSecureMemorySize(); |
| 394 | // Thread-local storage management | 361 | } |
| 395 | |||
| 396 | // Marks the next available region as used and returns the address of the slot. | ||
| 397 | [[nodiscard]] Result CreateThreadLocalRegion(KProcessAddress* out); | ||
| 398 | 362 | ||
| 399 | // Frees a used TLS slot identified by the given address | 363 | return 0; |
| 400 | Result DeleteThreadLocalRegion(KProcessAddress addr); | 364 | } |
| 401 | 365 | ||
| 402 | /////////////////////////////////////////////////////////////////////////////////////////////// | 366 | size_t GetTotalSystemResourceSize() const { |
| 403 | // Debug watchpoint management | 367 | if (!this->IsDefaultApplicationSystemResource() && m_system_resource->IsSecureResource()) { |
| 368 | auto* secure_system_resource = static_cast<KSecureSystemResource*>(m_system_resource); | ||
| 369 | return secure_system_resource->GetSize(); | ||
| 370 | } | ||
| 404 | 371 | ||
| 405 | // Attempts to insert a watchpoint into a free slot. Returns false if none are available. | 372 | return 0; |
| 406 | bool InsertWatchpoint(KProcessAddress addr, u64 size, DebugWatchpointType type); | 373 | } |
| 407 | 374 | ||
| 408 | // Attempts to remove the watchpoint specified by the given parameters. | 375 | size_t GetUsedSystemResourceSize() const { |
| 409 | bool RemoveWatchpoint(KProcessAddress addr, u64 size, DebugWatchpointType type); | 376 | if (!this->IsDefaultApplicationSystemResource() && m_system_resource->IsSecureResource()) { |
| 377 | auto* secure_system_resource = static_cast<KSecureSystemResource*>(m_system_resource); | ||
| 378 | return secure_system_resource->GetUsedSize(); | ||
| 379 | } | ||
| 410 | 380 | ||
| 411 | const std::array<DebugWatchpoint, Core::Hardware::NUM_WATCHPOINTS>& GetWatchpoints() const { | 381 | return 0; |
| 412 | return m_watchpoints; | ||
| 413 | } | 382 | } |
| 414 | 383 | ||
| 415 | const std::string& GetName() { | 384 | void SetRunningThread(s32 core, KThread* thread, u64 idle_count, u64 switch_count) { |
| 416 | return name; | 385 | m_running_threads[core] = thread; |
| 386 | m_running_thread_idle_counts[core] = idle_count; | ||
| 387 | m_running_thread_switch_counts[core] = switch_count; | ||
| 417 | } | 388 | } |
| 418 | 389 | ||
| 419 | private: | 390 | void ClearRunningThread(KThread* thread) { |
| 420 | void PinThread(s32 core_id, KThread* thread) { | 391 | for (size_t i = 0; i < m_running_threads.size(); ++i) { |
| 421 | ASSERT(0 <= core_id && core_id < static_cast<s32>(Core::Hardware::NUM_CPU_CORES)); | 392 | if (m_running_threads[i] == thread) { |
| 422 | ASSERT(thread != nullptr); | 393 | m_running_threads[i] = nullptr; |
| 423 | ASSERT(m_pinned_threads[core_id] == nullptr); | 394 | } |
| 424 | m_pinned_threads[core_id] = thread; | 395 | } |
| 425 | } | 396 | } |
| 426 | 397 | ||
| 427 | void UnpinThread(s32 core_id, KThread* thread) { | 398 | const KSystemResource& GetSystemResource() const { |
| 428 | ASSERT(0 <= core_id && core_id < static_cast<s32>(Core::Hardware::NUM_CPU_CORES)); | 399 | return *m_system_resource; |
| 429 | ASSERT(thread != nullptr); | ||
| 430 | ASSERT(m_pinned_threads[core_id] == thread); | ||
| 431 | m_pinned_threads[core_id] = nullptr; | ||
| 432 | } | 400 | } |
| 433 | 401 | ||
| 434 | void FinalizeHandleTable() { | 402 | const KMemoryBlockSlabManager& GetMemoryBlockSlabManager() const { |
| 435 | // Finalize the table. | 403 | return m_system_resource->GetMemoryBlockSlabManager(); |
| 436 | m_handle_table.Finalize(); | 404 | } |
| 437 | 405 | const KBlockInfoManager& GetBlockInfoManager() const { | |
| 438 | // Note that the table is finalized. | 406 | return m_system_resource->GetBlockInfoManager(); |
| 439 | m_is_handle_table_initialized = false; | 407 | } |
| 408 | const KPageTableManager& GetPageTableManager() const { | ||
| 409 | return m_system_resource->GetPageTableManager(); | ||
| 440 | } | 410 | } |
| 441 | 411 | ||
| 442 | void ChangeState(State new_state); | 412 | KThread* GetRunningThread(s32 core) const { |
| 443 | 413 | return m_running_threads[core]; | |
| 444 | /// Allocates the main thread stack for the process, given the stack size in bytes. | 414 | } |
| 445 | Result AllocateMainThreadStack(std::size_t stack_size); | 415 | u64 GetRunningThreadIdleCount(s32 core) const { |
| 446 | 416 | return m_running_thread_idle_counts[core]; | |
| 447 | /// Memory manager for this process | 417 | } |
| 448 | KPageTable m_page_table; | 418 | u64 GetRunningThreadSwitchCount(s32 core) const { |
| 449 | 419 | return m_running_thread_switch_counts[core]; | |
| 450 | /// Current status of the process | 420 | } |
| 451 | State m_state{}; | ||
| 452 | 421 | ||
| 453 | /// The ID of this process | 422 | void RegisterThread(KThread* thread); |
| 454 | u64 m_process_id = 0; | 423 | void UnregisterThread(KThread* thread); |
| 455 | 424 | ||
| 456 | /// Title ID corresponding to the process | 425 | Result Run(s32 priority, size_t stack_size); |
| 457 | u64 m_program_id = 0; | ||
| 458 | 426 | ||
| 459 | /// Specifies additional memory to be reserved for the process's memory management by the | 427 | Result Reset(); |
| 460 | /// system. When this is non-zero, secure memory is allocated and used for page table allocation | ||
| 461 | /// instead of using the normal global page tables/memory block management. | ||
| 462 | u32 m_system_resource_size = 0; | ||
| 463 | 428 | ||
| 464 | /// Resource limit descriptor for this process | 429 | void SetDebugBreak() { |
| 465 | KResourceLimit* m_resource_limit{}; | 430 | if (m_state == State::RunningAttached) { |
| 431 | this->ChangeState(State::DebugBreak); | ||
| 432 | } | ||
| 433 | } | ||
| 466 | 434 | ||
| 467 | KVirtualAddress m_system_resource_address{}; | 435 | void SetAttached() { |
| 436 | if (m_state == State::DebugBreak) { | ||
| 437 | this->ChangeState(State::RunningAttached); | ||
| 438 | } | ||
| 439 | } | ||
| 468 | 440 | ||
| 469 | /// The ideal CPU core for this process, threads are scheduled on this core by default. | 441 | Result SetActivity(Svc::ProcessActivity activity); |
| 470 | u8 m_ideal_core = 0; | ||
| 471 | 442 | ||
| 472 | /// Contains the parsed process capability descriptors. | 443 | void PinCurrentThread(); |
| 473 | ProcessCapabilities m_capabilities; | 444 | void UnpinCurrentThread(); |
| 445 | void UnpinThread(KThread* thread); | ||
| 474 | 446 | ||
| 475 | /// Whether or not this process is AArch64, or AArch32. | 447 | void SignalConditionVariable(uintptr_t cv_key, int32_t count) { |
| 476 | /// By default, we currently assume this is true, unless otherwise | 448 | return m_cond_var.Signal(cv_key, count); |
| 477 | /// specified by metadata provided to the process during loading. | 449 | } |
| 478 | bool m_is_64bit_process = true; | ||
| 479 | 450 | ||
| 480 | /// Total running time for the process in ticks. | 451 | Result WaitConditionVariable(KProcessAddress address, uintptr_t cv_key, u32 tag, s64 ns) { |
| 481 | std::atomic<u64> m_total_process_running_time_ticks = 0; | 452 | R_RETURN(m_cond_var.Wait(address, cv_key, tag, ns)); |
| 453 | } | ||
| 482 | 454 | ||
| 483 | /// Per-process handle table for storing created object handles in. | 455 | Result SignalAddressArbiter(uintptr_t address, Svc::SignalType signal_type, s32 value, |
| 484 | KHandleTable m_handle_table; | 456 | s32 count) { |
| 457 | R_RETURN(m_address_arbiter.SignalToAddress(address, signal_type, value, count)); | ||
| 458 | } | ||
| 485 | 459 | ||
| 486 | /// Per-process address arbiter. | 460 | Result WaitAddressArbiter(uintptr_t address, Svc::ArbitrationType arb_type, s32 value, |
| 487 | KAddressArbiter m_address_arbiter; | 461 | s64 timeout) { |
| 462 | R_RETURN(m_address_arbiter.WaitForAddress(address, arb_type, value, timeout)); | ||
| 463 | } | ||
| 488 | 464 | ||
| 489 | /// The per-process mutex lock instance used for handling various | 465 | Result GetThreadList(s32* out_num_threads, KProcessAddress out_thread_ids, s32 max_out_count); |
| 490 | /// forms of services, such as lock arbitration, and condition | ||
| 491 | /// variable related facilities. | ||
| 492 | KConditionVariable m_condition_var; | ||
| 493 | 466 | ||
| 494 | /// Address indicating the location of the process' dedicated TLS region. | 467 | static void Switch(KProcess* cur_process, KProcess* next_process); |
| 495 | KProcessAddress m_plr_address = 0; | ||
| 496 | 468 | ||
| 497 | /// Address indicating the location of the process's entry point. | 469 | public: |
| 498 | KProcessAddress m_code_address = 0; | 470 | // Attempts to insert a watchpoint into a free slot. Returns false if none are available. |
| 471 | bool InsertWatchpoint(KProcessAddress addr, u64 size, DebugWatchpointType type); | ||
| 499 | 472 | ||
| 500 | /// Random values for svcGetInfo RandomEntropy | 473 | // Attempts to remove the watchpoint specified by the given parameters. |
| 501 | std::array<u64, RANDOM_ENTROPY_SIZE> m_random_entropy{}; | 474 | bool RemoveWatchpoint(KProcessAddress addr, u64 size, DebugWatchpointType type); |
| 502 | 475 | ||
| 503 | /// List of threads that are running with this process as their owner. | 476 | const std::array<DebugWatchpoint, Core::Hardware::NUM_WATCHPOINTS>& GetWatchpoints() const { |
| 504 | std::list<KThread*> m_thread_list; | 477 | return m_watchpoints; |
| 478 | } | ||
| 505 | 479 | ||
| 506 | /// List of shared memory that are running with this process as their owner. | 480 | public: |
| 507 | std::list<KSharedMemoryInfo*> m_shared_memory_list; | 481 | Result LoadFromMetadata(const FileSys::ProgramMetadata& metadata, std::size_t code_size, |
| 482 | bool is_hbl); | ||
| 508 | 483 | ||
| 509 | /// Address of the top of the main thread's stack | 484 | void LoadModule(CodeSet code_set, KProcessAddress base_addr); |
| 510 | KProcessAddress m_main_thread_stack_top{}; | ||
| 511 | 485 | ||
| 512 | /// Size of the main thread's stack | 486 | Core::Memory::Memory& GetMemory() const; |
| 513 | std::size_t m_main_thread_stack_size{}; | ||
| 514 | 487 | ||
| 515 | /// Memory usage capacity for the process | 488 | public: |
| 516 | std::size_t m_memory_usage_capacity{}; | 489 | // Overridden parent functions. |
| 490 | bool IsInitialized() const override { | ||
| 491 | return m_is_initialized; | ||
| 492 | } | ||
| 517 | 493 | ||
| 518 | /// Process total image size | 494 | static void PostDestroy(uintptr_t arg) {} |
| 519 | std::size_t m_image_size{}; | ||
| 520 | 495 | ||
| 521 | /// Schedule count of this process | 496 | void Finalize() override; |
| 522 | s64 m_schedule_count{}; | ||
| 523 | 497 | ||
| 524 | size_t m_memory_release_hint{}; | 498 | u64 GetIdImpl() const { |
| 499 | return this->GetProcessId(); | ||
| 500 | } | ||
| 501 | u64 GetId() const override { | ||
| 502 | return this->GetIdImpl(); | ||
| 503 | } | ||
| 525 | 504 | ||
| 526 | std::string name{}; | 505 | virtual bool IsSignaled() const override { |
| 506 | ASSERT(KScheduler::IsSchedulerLockedByCurrentThread(m_kernel)); | ||
| 507 | return m_is_signaled; | ||
| 508 | } | ||
| 527 | 509 | ||
| 528 | bool m_is_signaled{}; | 510 | void DoWorkerTaskImpl(); |
| 529 | bool m_is_suspended{}; | ||
| 530 | bool m_is_immortal{}; | ||
| 531 | bool m_is_handle_table_initialized{}; | ||
| 532 | bool m_is_initialized{}; | ||
| 533 | bool m_is_hbl{}; | ||
| 534 | 511 | ||
| 535 | std::atomic<u16> m_num_running_threads{}; | 512 | private: |
| 513 | void ChangeState(State new_state) { | ||
| 514 | if (m_state != new_state) { | ||
| 515 | m_state = new_state; | ||
| 516 | m_is_signaled = true; | ||
| 517 | this->NotifyAvailable(); | ||
| 518 | } | ||
| 519 | } | ||
| 536 | 520 | ||
| 537 | std::array<KThread*, Core::Hardware::NUM_CPU_CORES> m_running_threads{}; | 521 | Result InitializeHandleTable(s32 size) { |
| 538 | std::array<u64, Core::Hardware::NUM_CPU_CORES> m_running_thread_idle_counts{}; | 522 | // Try to initialize the handle table. |
| 539 | std::array<KThread*, Core::Hardware::NUM_CPU_CORES> m_pinned_threads{}; | 523 | R_TRY(m_handle_table.Initialize(size)); |
| 540 | std::array<DebugWatchpoint, Core::Hardware::NUM_WATCHPOINTS> m_watchpoints{}; | ||
| 541 | std::map<KProcessAddress, u64> m_debug_page_refcounts; | ||
| 542 | 524 | ||
| 543 | KThread* m_exception_thread{}; | 525 | // We succeeded, so note that we did. |
| 526 | m_is_handle_table_initialized = true; | ||
| 527 | R_SUCCEED(); | ||
| 528 | } | ||
| 544 | 529 | ||
| 545 | KLightLock m_state_lock; | 530 | void FinalizeHandleTable() { |
| 546 | KLightLock m_list_lock; | 531 | // Finalize the table. |
| 532 | m_handle_table.Finalize(); | ||
| 547 | 533 | ||
| 548 | using TLPTree = | 534 | // Note that the table is finalized. |
| 549 | Common::IntrusiveRedBlackTreeBaseTraits<KThreadLocalPage>::TreeType<KThreadLocalPage>; | 535 | m_is_handle_table_initialized = false; |
| 550 | using TLPIterator = TLPTree::iterator; | 536 | } |
| 551 | TLPTree m_fully_used_tlp_tree; | ||
| 552 | TLPTree m_partially_used_tlp_tree; | ||
| 553 | }; | 537 | }; |
| 554 | 538 | ||
| 555 | } // namespace Kernel | 539 | } // namespace Kernel |
diff --git a/src/core/hle/kernel/k_scheduler.cpp b/src/core/hle/kernel/k_scheduler.cpp index d8143c650..1bce63a56 100644 --- a/src/core/hle/kernel/k_scheduler.cpp +++ b/src/core/hle/kernel/k_scheduler.cpp | |||
| @@ -190,7 +190,7 @@ u64 KScheduler::UpdateHighestPriorityThread(KThread* highest_thread) { | |||
| 190 | if (m_state.should_count_idle) { | 190 | if (m_state.should_count_idle) { |
| 191 | if (highest_thread != nullptr) [[likely]] { | 191 | if (highest_thread != nullptr) [[likely]] { |
| 192 | if (KProcess* process = highest_thread->GetOwnerProcess(); process != nullptr) { | 192 | if (KProcess* process = highest_thread->GetOwnerProcess(); process != nullptr) { |
| 193 | process->SetRunningThread(m_core_id, highest_thread, m_state.idle_count); | 193 | process->SetRunningThread(m_core_id, highest_thread, m_state.idle_count, 0); |
| 194 | } | 194 | } |
| 195 | } else { | 195 | } else { |
| 196 | m_state.idle_count++; | 196 | m_state.idle_count++; |
| @@ -356,7 +356,7 @@ void KScheduler::SwitchThread(KThread* next_thread) { | |||
| 356 | const s64 tick_diff = cur_tick - prev_tick; | 356 | const s64 tick_diff = cur_tick - prev_tick; |
| 357 | cur_thread->AddCpuTime(m_core_id, tick_diff); | 357 | cur_thread->AddCpuTime(m_core_id, tick_diff); |
| 358 | if (cur_process != nullptr) { | 358 | if (cur_process != nullptr) { |
| 359 | cur_process->UpdateCPUTimeTicks(tick_diff); | 359 | cur_process->AddCpuTime(tick_diff); |
| 360 | } | 360 | } |
| 361 | m_last_context_switch_time = cur_tick; | 361 | m_last_context_switch_time = cur_tick; |
| 362 | 362 | ||
diff --git a/src/core/hle/kernel/k_system_resource.cpp b/src/core/hle/kernel/k_system_resource.cpp index e6c8d589a..07e92aa80 100644 --- a/src/core/hle/kernel/k_system_resource.cpp +++ b/src/core/hle/kernel/k_system_resource.cpp | |||
| @@ -1,25 +1,100 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2022 yuzu Emulator Project | 1 | // SPDX-FileCopyrightText: Copyright 2022 yuzu Emulator Project |
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | 2 | // SPDX-License-Identifier: GPL-2.0-or-later |
| 3 | 3 | ||
| 4 | #include "core/core.h" | ||
| 5 | #include "core/hle/kernel/k_scoped_resource_reservation.h" | ||
| 4 | #include "core/hle/kernel/k_system_resource.h" | 6 | #include "core/hle/kernel/k_system_resource.h" |
| 5 | 7 | ||
| 6 | namespace Kernel { | 8 | namespace Kernel { |
| 7 | 9 | ||
| 8 | Result KSecureSystemResource::Initialize(size_t size, KResourceLimit* resource_limit, | 10 | Result KSecureSystemResource::Initialize(size_t size, KResourceLimit* resource_limit, |
| 9 | KMemoryManager::Pool pool) { | 11 | KMemoryManager::Pool pool) { |
| 10 | // Unimplemented | 12 | // Set members. |
| 11 | UNREACHABLE(); | 13 | m_resource_limit = resource_limit; |
| 14 | m_resource_size = size; | ||
| 15 | m_resource_pool = pool; | ||
| 16 | |||
| 17 | // Determine required size for our secure resource. | ||
| 18 | const size_t secure_size = this->CalculateRequiredSecureMemorySize(); | ||
| 19 | |||
| 20 | // Reserve memory for our secure resource. | ||
| 21 | KScopedResourceReservation memory_reservation( | ||
| 22 | m_resource_limit, Svc::LimitableResource::PhysicalMemoryMax, secure_size); | ||
| 23 | R_UNLESS(memory_reservation.Succeeded(), ResultLimitReached); | ||
| 24 | |||
| 25 | // Allocate secure memory. | ||
| 26 | R_TRY(KSystemControl::AllocateSecureMemory(m_kernel, std::addressof(m_resource_address), | ||
| 27 | m_resource_size, static_cast<u32>(m_resource_pool))); | ||
| 28 | ASSERT(m_resource_address != 0); | ||
| 29 | |||
| 30 | // Ensure we clean up the secure memory, if we fail past this point. | ||
| 31 | ON_RESULT_FAILURE { | ||
| 32 | KSystemControl::FreeSecureMemory(m_kernel, m_resource_address, m_resource_size, | ||
| 33 | static_cast<u32>(m_resource_pool)); | ||
| 34 | }; | ||
| 35 | |||
| 36 | // Check that our allocation is bigger than the reference counts needed for it. | ||
| 37 | const size_t rc_size = | ||
| 38 | Common::AlignUp(KPageTableSlabHeap::CalculateReferenceCountSize(m_resource_size), PageSize); | ||
| 39 | R_UNLESS(m_resource_size > rc_size, ResultOutOfMemory); | ||
| 40 | |||
| 41 | // Get resource pointer. | ||
| 42 | KPhysicalAddress resource_paddr = | ||
| 43 | KPageTable::GetHeapPhysicalAddress(m_kernel.MemoryLayout(), m_resource_address); | ||
| 44 | auto* resource = | ||
| 45 | m_kernel.System().DeviceMemory().GetPointer<KPageTableManager::RefCount>(resource_paddr); | ||
| 46 | |||
| 47 | // Initialize slab heaps. | ||
| 48 | m_dynamic_page_manager.Initialize(m_resource_address + rc_size, m_resource_size - rc_size, | ||
| 49 | PageSize); | ||
| 50 | m_page_table_heap.Initialize(std::addressof(m_dynamic_page_manager), 0, resource); | ||
| 51 | m_memory_block_heap.Initialize(std::addressof(m_dynamic_page_manager), 0); | ||
| 52 | m_block_info_heap.Initialize(std::addressof(m_dynamic_page_manager), 0); | ||
| 53 | |||
| 54 | // Initialize managers. | ||
| 55 | m_page_table_manager.Initialize(std::addressof(m_dynamic_page_manager), | ||
| 56 | std::addressof(m_page_table_heap)); | ||
| 57 | m_memory_block_slab_manager.Initialize(std::addressof(m_dynamic_page_manager), | ||
| 58 | std::addressof(m_memory_block_heap)); | ||
| 59 | m_block_info_manager.Initialize(std::addressof(m_dynamic_page_manager), | ||
| 60 | std::addressof(m_block_info_heap)); | ||
| 61 | |||
| 62 | // Set our managers. | ||
| 63 | this->SetManagers(m_memory_block_slab_manager, m_block_info_manager, m_page_table_manager); | ||
| 64 | |||
| 65 | // Commit the memory reservation. | ||
| 66 | memory_reservation.Commit(); | ||
| 67 | |||
| 68 | // Open reference to our resource limit. | ||
| 69 | m_resource_limit->Open(); | ||
| 70 | |||
| 71 | // Set ourselves as initialized. | ||
| 72 | m_is_initialized = true; | ||
| 73 | |||
| 74 | R_SUCCEED(); | ||
| 12 | } | 75 | } |
| 13 | 76 | ||
| 14 | void KSecureSystemResource::Finalize() { | 77 | void KSecureSystemResource::Finalize() { |
| 15 | // Unimplemented | 78 | // Check that we have no outstanding allocations. |
| 16 | UNREACHABLE(); | 79 | ASSERT(m_memory_block_slab_manager.GetUsed() == 0); |
| 80 | ASSERT(m_block_info_manager.GetUsed() == 0); | ||
| 81 | ASSERT(m_page_table_manager.GetUsed() == 0); | ||
| 82 | |||
| 83 | // Free our secure memory. | ||
| 84 | KSystemControl::FreeSecureMemory(m_kernel, m_resource_address, m_resource_size, | ||
| 85 | static_cast<u32>(m_resource_pool)); | ||
| 86 | |||
| 87 | // Release the memory reservation. | ||
| 88 | m_resource_limit->Release(Svc::LimitableResource::PhysicalMemoryMax, | ||
| 89 | this->CalculateRequiredSecureMemorySize()); | ||
| 90 | |||
| 91 | // Close reference to our resource limit. | ||
| 92 | m_resource_limit->Close(); | ||
| 17 | } | 93 | } |
| 18 | 94 | ||
| 19 | size_t KSecureSystemResource::CalculateRequiredSecureMemorySize(size_t size, | 95 | size_t KSecureSystemResource::CalculateRequiredSecureMemorySize(size_t size, |
| 20 | KMemoryManager::Pool pool) { | 96 | KMemoryManager::Pool pool) { |
| 21 | // Unimplemented | 97 | return KSystemControl::CalculateRequiredSecureMemorySize(size, static_cast<u32>(pool)); |
| 22 | UNREACHABLE(); | ||
| 23 | } | 98 | } |
| 24 | 99 | ||
| 25 | } // namespace Kernel | 100 | } // namespace Kernel |
diff --git a/src/core/hle/kernel/k_thread.cpp b/src/core/hle/kernel/k_thread.cpp index 7df8fd7f7..a6deb50ec 100644 --- a/src/core/hle/kernel/k_thread.cpp +++ b/src/core/hle/kernel/k_thread.cpp | |||
| @@ -122,16 +122,15 @@ Result KThread::Initialize(KThreadFunction func, uintptr_t arg, KProcessAddress | |||
| 122 | case ThreadType::Main: | 122 | case ThreadType::Main: |
| 123 | ASSERT(arg == 0); | 123 | ASSERT(arg == 0); |
| 124 | [[fallthrough]]; | 124 | [[fallthrough]]; |
| 125 | case ThreadType::HighPriority: | ||
| 126 | [[fallthrough]]; | ||
| 127 | case ThreadType::Dummy: | ||
| 128 | [[fallthrough]]; | ||
| 129 | case ThreadType::User: | 125 | case ThreadType::User: |
| 130 | ASSERT(((owner == nullptr) || | 126 | ASSERT(((owner == nullptr) || |
| 131 | (owner->GetCoreMask() | (1ULL << virt_core)) == owner->GetCoreMask())); | 127 | (owner->GetCoreMask() | (1ULL << virt_core)) == owner->GetCoreMask())); |
| 132 | ASSERT(((owner == nullptr) || (prio > Svc::LowestThreadPriority) || | 128 | ASSERT(((owner == nullptr) || (prio > Svc::LowestThreadPriority) || |
| 133 | (owner->GetPriorityMask() | (1ULL << prio)) == owner->GetPriorityMask())); | 129 | (owner->GetPriorityMask() | (1ULL << prio)) == owner->GetPriorityMask())); |
| 134 | break; | 130 | break; |
| 131 | case ThreadType::HighPriority: | ||
| 132 | case ThreadType::Dummy: | ||
| 133 | break; | ||
| 135 | case ThreadType::Kernel: | 134 | case ThreadType::Kernel: |
| 136 | UNIMPLEMENTED(); | 135 | UNIMPLEMENTED(); |
| 137 | break; | 136 | break; |
| @@ -216,6 +215,7 @@ Result KThread::Initialize(KThreadFunction func, uintptr_t arg, KProcessAddress | |||
| 216 | // Setup the TLS, if needed. | 215 | // Setup the TLS, if needed. |
| 217 | if (type == ThreadType::User) { | 216 | if (type == ThreadType::User) { |
| 218 | R_TRY(owner->CreateThreadLocalRegion(std::addressof(m_tls_address))); | 217 | R_TRY(owner->CreateThreadLocalRegion(std::addressof(m_tls_address))); |
| 218 | owner->GetMemory().ZeroBlock(m_tls_address, Svc::ThreadLocalRegionSize); | ||
| 219 | } | 219 | } |
| 220 | 220 | ||
| 221 | m_parent = owner; | 221 | m_parent = owner; |
| @@ -403,7 +403,7 @@ void KThread::StartTermination() { | |||
| 403 | if (m_parent != nullptr) { | 403 | if (m_parent != nullptr) { |
| 404 | m_parent->ReleaseUserException(this); | 404 | m_parent->ReleaseUserException(this); |
| 405 | if (m_parent->GetPinnedThread(GetCurrentCoreId(m_kernel)) == this) { | 405 | if (m_parent->GetPinnedThread(GetCurrentCoreId(m_kernel)) == this) { |
| 406 | m_parent->UnpinCurrentThread(m_core_id); | 406 | m_parent->UnpinCurrentThread(); |
| 407 | } | 407 | } |
| 408 | } | 408 | } |
| 409 | 409 | ||
| @@ -415,10 +415,6 @@ void KThread::StartTermination() { | |||
| 415 | m_parent->ClearRunningThread(this); | 415 | m_parent->ClearRunningThread(this); |
| 416 | } | 416 | } |
| 417 | 417 | ||
| 418 | // Signal. | ||
| 419 | m_signaled = true; | ||
| 420 | KSynchronizationObject::NotifyAvailable(); | ||
| 421 | |||
| 422 | // Clear previous thread in KScheduler. | 418 | // Clear previous thread in KScheduler. |
| 423 | KScheduler::ClearPreviousThread(m_kernel, this); | 419 | KScheduler::ClearPreviousThread(m_kernel, this); |
| 424 | 420 | ||
| @@ -437,6 +433,13 @@ void KThread::FinishTermination() { | |||
| 437 | } | 433 | } |
| 438 | } | 434 | } |
| 439 | 435 | ||
| 436 | // Acquire the scheduler lock. | ||
| 437 | KScopedSchedulerLock sl{m_kernel}; | ||
| 438 | |||
| 439 | // Signal. | ||
| 440 | m_signaled = true; | ||
| 441 | KSynchronizationObject::NotifyAvailable(); | ||
| 442 | |||
| 440 | // Close the thread. | 443 | // Close the thread. |
| 441 | this->Close(); | 444 | this->Close(); |
| 442 | } | 445 | } |
| @@ -820,7 +823,7 @@ void KThread::CloneFpuStatus() { | |||
| 820 | ASSERT(this->GetOwnerProcess() != nullptr); | 823 | ASSERT(this->GetOwnerProcess() != nullptr); |
| 821 | ASSERT(this->GetOwnerProcess() == GetCurrentProcessPointer(m_kernel)); | 824 | ASSERT(this->GetOwnerProcess() == GetCurrentProcessPointer(m_kernel)); |
| 822 | 825 | ||
| 823 | if (this->GetOwnerProcess()->Is64BitProcess()) { | 826 | if (this->GetOwnerProcess()->Is64Bit()) { |
| 824 | // Clone FPSR and FPCR. | 827 | // Clone FPSR and FPCR. |
| 825 | ThreadContext64 cur_ctx{}; | 828 | ThreadContext64 cur_ctx{}; |
| 826 | m_kernel.System().CurrentArmInterface().SaveContext(cur_ctx); | 829 | m_kernel.System().CurrentArmInterface().SaveContext(cur_ctx); |
| @@ -923,7 +926,7 @@ Result KThread::GetThreadContext3(Common::ScratchBuffer<u8>& out) { | |||
| 923 | 926 | ||
| 924 | // If we're not terminating, get the thread's user context. | 927 | // If we're not terminating, get the thread's user context. |
| 925 | if (!this->IsTerminationRequested()) { | 928 | if (!this->IsTerminationRequested()) { |
| 926 | if (m_parent->Is64BitProcess()) { | 929 | if (m_parent->Is64Bit()) { |
| 927 | // Mask away mode bits, interrupt bits, IL bit, and other reserved bits. | 930 | // Mask away mode bits, interrupt bits, IL bit, and other reserved bits. |
| 928 | auto context = GetContext64(); | 931 | auto context = GetContext64(); |
| 929 | context.pstate &= 0xFF0FFE20; | 932 | context.pstate &= 0xFF0FFE20; |
| @@ -1174,6 +1177,9 @@ Result KThread::Run() { | |||
| 1174 | owner->IncrementRunningThreadCount(); | 1177 | owner->IncrementRunningThreadCount(); |
| 1175 | } | 1178 | } |
| 1176 | 1179 | ||
| 1180 | // Open a reference, now that we're running. | ||
| 1181 | this->Open(); | ||
| 1182 | |||
| 1177 | // Set our state and finish. | 1183 | // Set our state and finish. |
| 1178 | this->SetState(ThreadState::Runnable); | 1184 | this->SetState(ThreadState::Runnable); |
| 1179 | 1185 | ||
diff --git a/src/core/hle/kernel/k_thread.h b/src/core/hle/kernel/k_thread.h index d178c2453..e1f80b04f 100644 --- a/src/core/hle/kernel/k_thread.h +++ b/src/core/hle/kernel/k_thread.h | |||
| @@ -721,6 +721,7 @@ private: | |||
| 721 | // For core KThread implementation | 721 | // For core KThread implementation |
| 722 | ThreadContext32 m_thread_context_32{}; | 722 | ThreadContext32 m_thread_context_32{}; |
| 723 | ThreadContext64 m_thread_context_64{}; | 723 | ThreadContext64 m_thread_context_64{}; |
| 724 | Common::IntrusiveListNode m_process_list_node; | ||
| 724 | Common::IntrusiveRedBlackTreeNode m_condvar_arbiter_tree_node{}; | 725 | Common::IntrusiveRedBlackTreeNode m_condvar_arbiter_tree_node{}; |
| 725 | s32 m_priority{}; | 726 | s32 m_priority{}; |
| 726 | using ConditionVariableThreadTreeTraits = | 727 | using ConditionVariableThreadTreeTraits = |
diff --git a/src/core/hle/kernel/k_transfer_memory.cpp b/src/core/hle/kernel/k_transfer_memory.cpp index 13d34125c..0e2e11743 100644 --- a/src/core/hle/kernel/k_transfer_memory.cpp +++ b/src/core/hle/kernel/k_transfer_memory.cpp | |||
| @@ -1,6 +1,7 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project | 1 | // SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project |
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | 2 | // SPDX-License-Identifier: GPL-2.0-or-later |
| 3 | 3 | ||
| 4 | #include "common/scope_exit.h" | ||
| 4 | #include "core/hle/kernel/k_process.h" | 5 | #include "core/hle/kernel/k_process.h" |
| 5 | #include "core/hle/kernel/k_resource_limit.h" | 6 | #include "core/hle/kernel/k_resource_limit.h" |
| 6 | #include "core/hle/kernel/k_transfer_memory.h" | 7 | #include "core/hle/kernel/k_transfer_memory.h" |
| @@ -9,28 +10,50 @@ | |||
| 9 | namespace Kernel { | 10 | namespace Kernel { |
| 10 | 11 | ||
| 11 | KTransferMemory::KTransferMemory(KernelCore& kernel) | 12 | KTransferMemory::KTransferMemory(KernelCore& kernel) |
| 12 | : KAutoObjectWithSlabHeapAndContainer{kernel} {} | 13 | : KAutoObjectWithSlabHeapAndContainer{kernel}, m_lock{kernel} {} |
| 13 | 14 | ||
| 14 | KTransferMemory::~KTransferMemory() = default; | 15 | KTransferMemory::~KTransferMemory() = default; |
| 15 | 16 | ||
| 16 | Result KTransferMemory::Initialize(KProcessAddress address, std::size_t size, | 17 | Result KTransferMemory::Initialize(KProcessAddress addr, std::size_t size, |
| 17 | Svc::MemoryPermission owner_perm) { | 18 | Svc::MemoryPermission own_perm) { |
| 18 | // Set members. | 19 | // Set members. |
| 19 | m_owner = GetCurrentProcessPointer(m_kernel); | 20 | m_owner = GetCurrentProcessPointer(m_kernel); |
| 20 | 21 | ||
| 21 | // TODO(bunnei): Lock for transfer memory | 22 | // Get the owner page table. |
| 23 | auto& page_table = m_owner->GetPageTable(); | ||
| 24 | |||
| 25 | // Construct the page group, guarding to make sure our state is valid on exit. | ||
| 26 | m_page_group.emplace(m_kernel, page_table.GetBlockInfoManager()); | ||
| 27 | auto pg_guard = SCOPE_GUARD({ m_page_group.reset(); }); | ||
| 28 | |||
| 29 | // Lock the memory. | ||
| 30 | R_TRY(page_table.LockForTransferMemory(std::addressof(*m_page_group), addr, size, | ||
| 31 | ConvertToKMemoryPermission(own_perm))); | ||
| 22 | 32 | ||
| 23 | // Set remaining tracking members. | 33 | // Set remaining tracking members. |
| 24 | m_owner->Open(); | 34 | m_owner->Open(); |
| 25 | m_owner_perm = owner_perm; | 35 | m_owner_perm = own_perm; |
| 26 | m_address = address; | 36 | m_address = addr; |
| 27 | m_size = size; | ||
| 28 | m_is_initialized = true; | 37 | m_is_initialized = true; |
| 38 | m_is_mapped = false; | ||
| 29 | 39 | ||
| 40 | // We succeeded. | ||
| 41 | pg_guard.Cancel(); | ||
| 30 | R_SUCCEED(); | 42 | R_SUCCEED(); |
| 31 | } | 43 | } |
| 32 | 44 | ||
| 33 | void KTransferMemory::Finalize() {} | 45 | void KTransferMemory::Finalize() { |
| 46 | // Unlock. | ||
| 47 | if (!m_is_mapped) { | ||
| 48 | const size_t size = m_page_group->GetNumPages() * PageSize; | ||
| 49 | ASSERT(R_SUCCEEDED( | ||
| 50 | m_owner->GetPageTable().UnlockForTransferMemory(m_address, size, *m_page_group))); | ||
| 51 | } | ||
| 52 | |||
| 53 | // Close the page group. | ||
| 54 | m_page_group->Close(); | ||
| 55 | m_page_group->Finalize(); | ||
| 56 | } | ||
| 34 | 57 | ||
| 35 | void KTransferMemory::PostDestroy(uintptr_t arg) { | 58 | void KTransferMemory::PostDestroy(uintptr_t arg) { |
| 36 | KProcess* owner = reinterpret_cast<KProcess*>(arg); | 59 | KProcess* owner = reinterpret_cast<KProcess*>(arg); |
| @@ -38,4 +61,54 @@ void KTransferMemory::PostDestroy(uintptr_t arg) { | |||
| 38 | owner->Close(); | 61 | owner->Close(); |
| 39 | } | 62 | } |
| 40 | 63 | ||
| 64 | Result KTransferMemory::Map(KProcessAddress address, size_t size, Svc::MemoryPermission map_perm) { | ||
| 65 | // Validate the size. | ||
| 66 | R_UNLESS(m_page_group->GetNumPages() == Common::DivideUp(size, PageSize), ResultInvalidSize); | ||
| 67 | |||
| 68 | // Validate the permission. | ||
| 69 | R_UNLESS(m_owner_perm == map_perm, ResultInvalidState); | ||
| 70 | |||
| 71 | // Lock ourselves. | ||
| 72 | KScopedLightLock lk(m_lock); | ||
| 73 | |||
| 74 | // Ensure we're not already mapped. | ||
| 75 | R_UNLESS(!m_is_mapped, ResultInvalidState); | ||
| 76 | |||
| 77 | // Map the memory. | ||
| 78 | const KMemoryState state = (m_owner_perm == Svc::MemoryPermission::None) | ||
| 79 | ? KMemoryState::Transfered | ||
| 80 | : KMemoryState::SharedTransfered; | ||
| 81 | R_TRY(GetCurrentProcess(m_kernel).GetPageTable().MapPageGroup( | ||
| 82 | address, *m_page_group, state, KMemoryPermission::UserReadWrite)); | ||
| 83 | |||
| 84 | // Mark ourselves as mapped. | ||
| 85 | m_is_mapped = true; | ||
| 86 | |||
| 87 | R_SUCCEED(); | ||
| 88 | } | ||
| 89 | |||
| 90 | Result KTransferMemory::Unmap(KProcessAddress address, size_t size) { | ||
| 91 | // Validate the size. | ||
| 92 | R_UNLESS(m_page_group->GetNumPages() == Common::DivideUp(size, PageSize), ResultInvalidSize); | ||
| 93 | |||
| 94 | // Lock ourselves. | ||
| 95 | KScopedLightLock lk(m_lock); | ||
| 96 | |||
| 97 | // Unmap the memory. | ||
| 98 | const KMemoryState state = (m_owner_perm == Svc::MemoryPermission::None) | ||
| 99 | ? KMemoryState::Transfered | ||
| 100 | : KMemoryState::SharedTransfered; | ||
| 101 | R_TRY(GetCurrentProcess(m_kernel).GetPageTable().UnmapPageGroup(address, *m_page_group, state)); | ||
| 102 | |||
| 103 | // Mark ourselves as unmapped. | ||
| 104 | ASSERT(m_is_mapped); | ||
| 105 | m_is_mapped = false; | ||
| 106 | |||
| 107 | R_SUCCEED(); | ||
| 108 | } | ||
| 109 | |||
| 110 | size_t KTransferMemory::GetSize() const { | ||
| 111 | return m_is_initialized ? m_page_group->GetNumPages() * PageSize : 0; | ||
| 112 | } | ||
| 113 | |||
| 41 | } // namespace Kernel | 114 | } // namespace Kernel |
diff --git a/src/core/hle/kernel/k_transfer_memory.h b/src/core/hle/kernel/k_transfer_memory.h index 54f97ccb4..8a0b08761 100644 --- a/src/core/hle/kernel/k_transfer_memory.h +++ b/src/core/hle/kernel/k_transfer_memory.h | |||
| @@ -3,6 +3,9 @@ | |||
| 3 | 3 | ||
| 4 | #pragma once | 4 | #pragma once |
| 5 | 5 | ||
| 6 | #include <optional> | ||
| 7 | |||
| 8 | #include "core/hle/kernel/k_page_group.h" | ||
| 6 | #include "core/hle/kernel/slab_helpers.h" | 9 | #include "core/hle/kernel/slab_helpers.h" |
| 7 | #include "core/hle/kernel/svc_types.h" | 10 | #include "core/hle/kernel/svc_types.h" |
| 8 | #include "core/hle/result.h" | 11 | #include "core/hle/result.h" |
| @@ -48,16 +51,19 @@ public: | |||
| 48 | return m_address; | 51 | return m_address; |
| 49 | } | 52 | } |
| 50 | 53 | ||
| 51 | size_t GetSize() const { | 54 | size_t GetSize() const; |
| 52 | return m_is_initialized ? m_size : 0; | 55 | |
| 53 | } | 56 | Result Map(KProcessAddress address, size_t size, Svc::MemoryPermission map_perm); |
| 57 | Result Unmap(KProcessAddress address, size_t size); | ||
| 54 | 58 | ||
| 55 | private: | 59 | private: |
| 60 | std::optional<KPageGroup> m_page_group{}; | ||
| 56 | KProcess* m_owner{}; | 61 | KProcess* m_owner{}; |
| 57 | KProcessAddress m_address{}; | 62 | KProcessAddress m_address{}; |
| 63 | KLightLock m_lock; | ||
| 58 | Svc::MemoryPermission m_owner_perm{}; | 64 | Svc::MemoryPermission m_owner_perm{}; |
| 59 | size_t m_size{}; | ||
| 60 | bool m_is_initialized{}; | 65 | bool m_is_initialized{}; |
| 66 | bool m_is_mapped{}; | ||
| 61 | }; | 67 | }; |
| 62 | 68 | ||
| 63 | } // namespace Kernel | 69 | } // namespace Kernel |
diff --git a/src/core/hle/kernel/kernel.cpp b/src/core/hle/kernel/kernel.cpp index a1134b7e2..4a1559291 100644 --- a/src/core/hle/kernel/kernel.cpp +++ b/src/core/hle/kernel/kernel.cpp | |||
| @@ -101,35 +101,31 @@ struct KernelCore::Impl { | |||
| 101 | 101 | ||
| 102 | void InitializeCores() { | 102 | void InitializeCores() { |
| 103 | for (u32 core_id = 0; core_id < Core::Hardware::NUM_CPU_CORES; core_id++) { | 103 | for (u32 core_id = 0; core_id < Core::Hardware::NUM_CPU_CORES; core_id++) { |
| 104 | cores[core_id]->Initialize((*application_process).Is64BitProcess()); | 104 | cores[core_id]->Initialize((*application_process).Is64Bit()); |
| 105 | system.ApplicationMemory().SetCurrentPageTable(*application_process, core_id); | 105 | system.ApplicationMemory().SetCurrentPageTable(*application_process, core_id); |
| 106 | } | 106 | } |
| 107 | } | 107 | } |
| 108 | 108 | ||
| 109 | void CloseApplicationProcess() { | 109 | void TerminateApplicationProcess() { |
| 110 | KProcess* old_process = application_process.exchange(nullptr); | 110 | application_process.load()->Terminate(); |
| 111 | if (old_process == nullptr) { | ||
| 112 | return; | ||
| 113 | } | ||
| 114 | |||
| 115 | // old_process->Close(); | ||
| 116 | // TODO: The process should be destroyed based on accurate ref counting after | ||
| 117 | // calling Close(). Adding a manual Destroy() call instead to avoid a memory leak. | ||
| 118 | old_process->Finalize(); | ||
| 119 | old_process->Destroy(); | ||
| 120 | } | 111 | } |
| 121 | 112 | ||
| 122 | void Shutdown() { | 113 | void Shutdown() { |
| 123 | is_shutting_down.store(true, std::memory_order_relaxed); | 114 | is_shutting_down.store(true, std::memory_order_relaxed); |
| 124 | SCOPE_EXIT({ is_shutting_down.store(false, std::memory_order_relaxed); }); | 115 | SCOPE_EXIT({ is_shutting_down.store(false, std::memory_order_relaxed); }); |
| 125 | 116 | ||
| 126 | process_list.clear(); | ||
| 127 | |||
| 128 | CloseServices(); | 117 | CloseServices(); |
| 129 | 118 | ||
| 119 | auto* old_process = application_process.exchange(nullptr); | ||
| 120 | if (old_process) { | ||
| 121 | old_process->Close(); | ||
| 122 | } | ||
| 123 | |||
| 124 | process_list.clear(); | ||
| 125 | |||
| 130 | next_object_id = 0; | 126 | next_object_id = 0; |
| 131 | next_kernel_process_id = KProcess::InitialKIPIDMin; | 127 | next_kernel_process_id = KProcess::InitialProcessIdMin; |
| 132 | next_user_process_id = KProcess::ProcessIDMin; | 128 | next_user_process_id = KProcess::ProcessIdMin; |
| 133 | next_thread_id = 1; | 129 | next_thread_id = 1; |
| 134 | 130 | ||
| 135 | global_handle_table->Finalize(); | 131 | global_handle_table->Finalize(); |
| @@ -176,8 +172,6 @@ struct KernelCore::Impl { | |||
| 176 | } | 172 | } |
| 177 | } | 173 | } |
| 178 | 174 | ||
| 179 | CloseApplicationProcess(); | ||
| 180 | |||
| 181 | // Track kernel objects that were not freed on shutdown | 175 | // Track kernel objects that were not freed on shutdown |
| 182 | { | 176 | { |
| 183 | std::scoped_lock lk{registered_objects_lock}; | 177 | std::scoped_lock lk{registered_objects_lock}; |
| @@ -344,6 +338,8 @@ struct KernelCore::Impl { | |||
| 344 | // Create the system page table managers. | 338 | // Create the system page table managers. |
| 345 | app_system_resource = std::make_unique<KSystemResource>(kernel); | 339 | app_system_resource = std::make_unique<KSystemResource>(kernel); |
| 346 | sys_system_resource = std::make_unique<KSystemResource>(kernel); | 340 | sys_system_resource = std::make_unique<KSystemResource>(kernel); |
| 341 | KAutoObject::Create(std::addressof(*app_system_resource)); | ||
| 342 | KAutoObject::Create(std::addressof(*sys_system_resource)); | ||
| 347 | 343 | ||
| 348 | // Set the managers for the system resources. | 344 | // Set the managers for the system resources. |
| 349 | app_system_resource->SetManagers(*app_memory_block_manager, *app_block_info_manager, | 345 | app_system_resource->SetManagers(*app_memory_block_manager, *app_block_info_manager, |
| @@ -373,7 +369,7 @@ struct KernelCore::Impl { | |||
| 373 | static inline thread_local u8 host_thread_id = UINT8_MAX; | 369 | static inline thread_local u8 host_thread_id = UINT8_MAX; |
| 374 | 370 | ||
| 375 | /// Sets the host thread ID for the caller. | 371 | /// Sets the host thread ID for the caller. |
| 376 | u32 SetHostThreadId(std::size_t core_id) { | 372 | LTO_NOINLINE u32 SetHostThreadId(std::size_t core_id) { |
| 377 | // This should only be called during core init. | 373 | // This should only be called during core init. |
| 378 | ASSERT(host_thread_id == UINT8_MAX); | 374 | ASSERT(host_thread_id == UINT8_MAX); |
| 379 | 375 | ||
| @@ -384,13 +380,13 @@ struct KernelCore::Impl { | |||
| 384 | } | 380 | } |
| 385 | 381 | ||
| 386 | /// Gets the host thread ID for the caller | 382 | /// Gets the host thread ID for the caller |
| 387 | u32 GetHostThreadId() const { | 383 | LTO_NOINLINE u32 GetHostThreadId() const { |
| 388 | return host_thread_id; | 384 | return host_thread_id; |
| 389 | } | 385 | } |
| 390 | 386 | ||
| 391 | // Gets the dummy KThread for the caller, allocating a new one if this is the first time | 387 | // Gets the dummy KThread for the caller, allocating a new one if this is the first time |
| 392 | KThread* GetHostDummyThread(KThread* existing_thread) { | 388 | LTO_NOINLINE KThread* GetHostDummyThread(KThread* existing_thread) { |
| 393 | const auto initialize{[](KThread* thread) { | 389 | const auto initialize{[](KThread* thread) LTO_NOINLINE { |
| 394 | ASSERT(KThread::InitializeDummyThread(thread, nullptr).IsSuccess()); | 390 | ASSERT(KThread::InitializeDummyThread(thread, nullptr).IsSuccess()); |
| 395 | return thread; | 391 | return thread; |
| 396 | }}; | 392 | }}; |
| @@ -424,11 +420,11 @@ struct KernelCore::Impl { | |||
| 424 | 420 | ||
| 425 | static inline thread_local bool is_phantom_mode_for_singlecore{false}; | 421 | static inline thread_local bool is_phantom_mode_for_singlecore{false}; |
| 426 | 422 | ||
| 427 | bool IsPhantomModeForSingleCore() const { | 423 | LTO_NOINLINE bool IsPhantomModeForSingleCore() const { |
| 428 | return is_phantom_mode_for_singlecore; | 424 | return is_phantom_mode_for_singlecore; |
| 429 | } | 425 | } |
| 430 | 426 | ||
| 431 | void SetIsPhantomModeForSingleCore(bool value) { | 427 | LTO_NOINLINE void SetIsPhantomModeForSingleCore(bool value) { |
| 432 | ASSERT(!is_multicore); | 428 | ASSERT(!is_multicore); |
| 433 | is_phantom_mode_for_singlecore = value; | 429 | is_phantom_mode_for_singlecore = value; |
| 434 | } | 430 | } |
| @@ -439,14 +435,14 @@ struct KernelCore::Impl { | |||
| 439 | 435 | ||
| 440 | static inline thread_local KThread* current_thread{nullptr}; | 436 | static inline thread_local KThread* current_thread{nullptr}; |
| 441 | 437 | ||
| 442 | KThread* GetCurrentEmuThread() { | 438 | LTO_NOINLINE KThread* GetCurrentEmuThread() { |
| 443 | if (!current_thread) { | 439 | if (!current_thread) { |
| 444 | current_thread = GetHostDummyThread(nullptr); | 440 | current_thread = GetHostDummyThread(nullptr); |
| 445 | } | 441 | } |
| 446 | return current_thread; | 442 | return current_thread; |
| 447 | } | 443 | } |
| 448 | 444 | ||
| 449 | void SetCurrentEmuThread(KThread* thread) { | 445 | LTO_NOINLINE void SetCurrentEmuThread(KThread* thread) { |
| 450 | current_thread = thread; | 446 | current_thread = thread; |
| 451 | } | 447 | } |
| 452 | 448 | ||
| @@ -623,14 +619,33 @@ struct KernelCore::Impl { | |||
| 623 | ASSERT(memory_layout->GetPhysicalMemoryRegionTree().Insert( | 619 | ASSERT(memory_layout->GetPhysicalMemoryRegionTree().Insert( |
| 624 | GetInteger(slab_start_phys_addr), slab_region_size, KMemoryRegionType_DramKernelSlab)); | 620 | GetInteger(slab_start_phys_addr), slab_region_size, KMemoryRegionType_DramKernelSlab)); |
| 625 | 621 | ||
| 622 | // Insert a physical region for the secure applet memory. | ||
| 623 | const auto secure_applet_end_phys_addr = | ||
| 624 | slab_end_phys_addr + KSystemControl::SecureAppletMemorySize; | ||
| 625 | if constexpr (KSystemControl::SecureAppletMemorySize > 0) { | ||
| 626 | ASSERT(memory_layout->GetPhysicalMemoryRegionTree().Insert( | ||
| 627 | GetInteger(slab_end_phys_addr), KSystemControl::SecureAppletMemorySize, | ||
| 628 | KMemoryRegionType_DramKernelSecureAppletMemory)); | ||
| 629 | } | ||
| 630 | |||
| 631 | // Insert a physical region for the unknown debug2 region. | ||
| 632 | constexpr size_t SecureUnknownRegionSize = 0; | ||
| 633 | const size_t secure_unknown_size = SecureUnknownRegionSize; | ||
| 634 | const auto secure_unknown_end_phys_addr = secure_applet_end_phys_addr + secure_unknown_size; | ||
| 635 | if constexpr (SecureUnknownRegionSize > 0) { | ||
| 636 | ASSERT(memory_layout->GetPhysicalMemoryRegionTree().Insert( | ||
| 637 | GetInteger(secure_applet_end_phys_addr), secure_unknown_size, | ||
| 638 | KMemoryRegionType_DramKernelSecureUnknown)); | ||
| 639 | } | ||
| 640 | |||
| 626 | // Determine size available for kernel page table heaps, requiring > 8 MB. | 641 | // Determine size available for kernel page table heaps, requiring > 8 MB. |
| 627 | const KPhysicalAddress resource_end_phys_addr = slab_start_phys_addr + resource_region_size; | 642 | const KPhysicalAddress resource_end_phys_addr = slab_start_phys_addr + resource_region_size; |
| 628 | const size_t page_table_heap_size = resource_end_phys_addr - slab_end_phys_addr; | 643 | const size_t page_table_heap_size = resource_end_phys_addr - secure_unknown_end_phys_addr; |
| 629 | ASSERT(page_table_heap_size / 4_MiB > 2); | 644 | ASSERT(page_table_heap_size / 4_MiB > 2); |
| 630 | 645 | ||
| 631 | // Insert a physical region for the kernel page table heap region | 646 | // Insert a physical region for the kernel page table heap region |
| 632 | ASSERT(memory_layout->GetPhysicalMemoryRegionTree().Insert( | 647 | ASSERT(memory_layout->GetPhysicalMemoryRegionTree().Insert( |
| 633 | GetInteger(slab_end_phys_addr), page_table_heap_size, | 648 | GetInteger(secure_unknown_end_phys_addr), page_table_heap_size, |
| 634 | KMemoryRegionType_DramKernelPtHeap)); | 649 | KMemoryRegionType_DramKernelPtHeap)); |
| 635 | 650 | ||
| 636 | // All DRAM regions that we haven't tagged by this point will be mapped under the linear | 651 | // All DRAM regions that we haven't tagged by this point will be mapped under the linear |
| @@ -773,8 +788,8 @@ struct KernelCore::Impl { | |||
| 773 | std::mutex registered_in_use_objects_lock; | 788 | std::mutex registered_in_use_objects_lock; |
| 774 | 789 | ||
| 775 | std::atomic<u32> next_object_id{0}; | 790 | std::atomic<u32> next_object_id{0}; |
| 776 | std::atomic<u64> next_kernel_process_id{KProcess::InitialKIPIDMin}; | 791 | std::atomic<u64> next_kernel_process_id{KProcess::InitialProcessIdMin}; |
| 777 | std::atomic<u64> next_user_process_id{KProcess::ProcessIDMin}; | 792 | std::atomic<u64> next_user_process_id{KProcess::ProcessIdMin}; |
| 778 | std::atomic<u64> next_thread_id{1}; | 793 | std::atomic<u64> next_thread_id{1}; |
| 779 | 794 | ||
| 780 | // Lists all processes that exist in the current session. | 795 | // Lists all processes that exist in the current session. |
| @@ -905,10 +920,6 @@ const KProcess* KernelCore::ApplicationProcess() const { | |||
| 905 | return impl->application_process; | 920 | return impl->application_process; |
| 906 | } | 921 | } |
| 907 | 922 | ||
| 908 | void KernelCore::CloseApplicationProcess() { | ||
| 909 | impl->CloseApplicationProcess(); | ||
| 910 | } | ||
| 911 | |||
| 912 | const std::vector<KProcess*>& KernelCore::GetProcessList() const { | 923 | const std::vector<KProcess*>& KernelCore::GetProcessList() const { |
| 913 | return impl->process_list; | 924 | return impl->process_list; |
| 914 | } | 925 | } |
| @@ -1109,8 +1120,8 @@ std::jthread KernelCore::RunOnHostCoreProcess(std::string&& process_name, | |||
| 1109 | std::function<void()> func) { | 1120 | std::function<void()> func) { |
| 1110 | // Make a new process. | 1121 | // Make a new process. |
| 1111 | KProcess* process = KProcess::Create(*this); | 1122 | KProcess* process = KProcess::Create(*this); |
| 1112 | ASSERT(R_SUCCEEDED(KProcess::Initialize(process, System(), "", KProcess::ProcessType::Userland, | 1123 | ASSERT(R_SUCCEEDED( |
| 1113 | GetSystemResourceLimit()))); | 1124 | process->Initialize(Svc::CreateProcessParameter{}, GetSystemResourceLimit(), false))); |
| 1114 | 1125 | ||
| 1115 | // Ensure that we don't hold onto any extra references. | 1126 | // Ensure that we don't hold onto any extra references. |
| 1116 | SCOPE_EXIT({ process->Close(); }); | 1127 | SCOPE_EXIT({ process->Close(); }); |
| @@ -1137,8 +1148,8 @@ void KernelCore::RunOnGuestCoreProcess(std::string&& process_name, std::function | |||
| 1137 | 1148 | ||
| 1138 | // Make a new process. | 1149 | // Make a new process. |
| 1139 | KProcess* process = KProcess::Create(*this); | 1150 | KProcess* process = KProcess::Create(*this); |
| 1140 | ASSERT(R_SUCCEEDED(KProcess::Initialize(process, System(), "", KProcess::ProcessType::Userland, | 1151 | ASSERT(R_SUCCEEDED( |
| 1141 | GetSystemResourceLimit()))); | 1152 | process->Initialize(Svc::CreateProcessParameter{}, GetSystemResourceLimit(), false))); |
| 1142 | 1153 | ||
| 1143 | // Ensure that we don't hold onto any extra references. | 1154 | // Ensure that we don't hold onto any extra references. |
| 1144 | SCOPE_EXIT({ process->Close(); }); | 1155 | SCOPE_EXIT({ process->Close(); }); |
| @@ -1247,7 +1258,8 @@ const Kernel::KSharedMemory& KernelCore::GetHidBusSharedMem() const { | |||
| 1247 | 1258 | ||
| 1248 | void KernelCore::SuspendApplication(bool suspended) { | 1259 | void KernelCore::SuspendApplication(bool suspended) { |
| 1249 | const bool should_suspend{exception_exited || suspended}; | 1260 | const bool should_suspend{exception_exited || suspended}; |
| 1250 | const auto activity = should_suspend ? ProcessActivity::Paused : ProcessActivity::Runnable; | 1261 | const auto activity = |
| 1262 | should_suspend ? Svc::ProcessActivity::Paused : Svc::ProcessActivity::Runnable; | ||
| 1251 | 1263 | ||
| 1252 | // Get the application process. | 1264 | // Get the application process. |
| 1253 | KScopedAutoObject<KProcess> process = ApplicationProcess(); | 1265 | KScopedAutoObject<KProcess> process = ApplicationProcess(); |
| @@ -1281,6 +1293,8 @@ void KernelCore::SuspendApplication(bool suspended) { | |||
| 1281 | } | 1293 | } |
| 1282 | 1294 | ||
| 1283 | void KernelCore::ShutdownCores() { | 1295 | void KernelCore::ShutdownCores() { |
| 1296 | impl->TerminateApplicationProcess(); | ||
| 1297 | |||
| 1284 | KScopedSchedulerLock lk{*this}; | 1298 | KScopedSchedulerLock lk{*this}; |
| 1285 | 1299 | ||
| 1286 | for (auto* thread : impl->shutdown_threads) { | 1300 | for (auto* thread : impl->shutdown_threads) { |
diff --git a/src/core/hle/kernel/kernel.h b/src/core/hle/kernel/kernel.h index d5b08eeb5..d8086c0ea 100644 --- a/src/core/hle/kernel/kernel.h +++ b/src/core/hle/kernel/kernel.h | |||
| @@ -134,9 +134,6 @@ public: | |||
| 134 | /// Retrieves a const pointer to the application process. | 134 | /// Retrieves a const pointer to the application process. |
| 135 | const KProcess* ApplicationProcess() const; | 135 | const KProcess* ApplicationProcess() const; |
| 136 | 136 | ||
| 137 | /// Closes the application process. | ||
| 138 | void CloseApplicationProcess(); | ||
| 139 | |||
| 140 | /// Retrieves the list of processes. | 137 | /// Retrieves the list of processes. |
| 141 | const std::vector<KProcess*>& GetProcessList() const; | 138 | const std::vector<KProcess*>& GetProcessList() const; |
| 142 | 139 | ||
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp index 871d541d4..b76683969 100644 --- a/src/core/hle/kernel/svc.cpp +++ b/src/core/hle/kernel/svc.cpp | |||
| @@ -4426,7 +4426,7 @@ void Call(Core::System& system, u32 imm) { | |||
| 4426 | auto& kernel = system.Kernel(); | 4426 | auto& kernel = system.Kernel(); |
| 4427 | kernel.EnterSVCProfile(); | 4427 | kernel.EnterSVCProfile(); |
| 4428 | 4428 | ||
| 4429 | if (GetCurrentProcess(system.Kernel()).Is64BitProcess()) { | 4429 | if (GetCurrentProcess(system.Kernel()).Is64Bit()) { |
| 4430 | Call64(system, imm); | 4430 | Call64(system, imm); |
| 4431 | } else { | 4431 | } else { |
| 4432 | Call32(system, imm); | 4432 | Call32(system, imm); |
diff --git a/src/core/hle/kernel/svc/svc_info.cpp b/src/core/hle/kernel/svc/svc_info.cpp index f99964028..ada998772 100644 --- a/src/core/hle/kernel/svc/svc_info.cpp +++ b/src/core/hle/kernel/svc/svc_info.cpp | |||
| @@ -86,20 +86,19 @@ Result GetInfo(Core::System& system, u64* result, InfoType info_id_type, Handle | |||
| 86 | R_SUCCEED(); | 86 | R_SUCCEED(); |
| 87 | 87 | ||
| 88 | case InfoType::TotalMemorySize: | 88 | case InfoType::TotalMemorySize: |
| 89 | *result = process->GetTotalPhysicalMemoryAvailable(); | 89 | *result = process->GetTotalUserPhysicalMemorySize(); |
| 90 | R_SUCCEED(); | 90 | R_SUCCEED(); |
| 91 | 91 | ||
| 92 | case InfoType::UsedMemorySize: | 92 | case InfoType::UsedMemorySize: |
| 93 | *result = process->GetTotalPhysicalMemoryUsed(); | 93 | *result = process->GetUsedUserPhysicalMemorySize(); |
| 94 | R_SUCCEED(); | 94 | R_SUCCEED(); |
| 95 | 95 | ||
| 96 | case InfoType::SystemResourceSizeTotal: | 96 | case InfoType::SystemResourceSizeTotal: |
| 97 | *result = process->GetSystemResourceSize(); | 97 | *result = process->GetTotalSystemResourceSize(); |
| 98 | R_SUCCEED(); | 98 | R_SUCCEED(); |
| 99 | 99 | ||
| 100 | case InfoType::SystemResourceSizeUsed: | 100 | case InfoType::SystemResourceSizeUsed: |
| 101 | LOG_WARNING(Kernel_SVC, "(STUBBED) Attempted to query system resource usage"); | 101 | *result = process->GetUsedSystemResourceSize(); |
| 102 | *result = process->GetSystemResourceUsage(); | ||
| 103 | R_SUCCEED(); | 102 | R_SUCCEED(); |
| 104 | 103 | ||
| 105 | case InfoType::ProgramId: | 104 | case InfoType::ProgramId: |
| @@ -111,20 +110,29 @@ Result GetInfo(Core::System& system, u64* result, InfoType info_id_type, Handle | |||
| 111 | R_SUCCEED(); | 110 | R_SUCCEED(); |
| 112 | 111 | ||
| 113 | case InfoType::TotalNonSystemMemorySize: | 112 | case InfoType::TotalNonSystemMemorySize: |
| 114 | *result = process->GetTotalPhysicalMemoryAvailableWithoutSystemResource(); | 113 | *result = process->GetTotalNonSystemUserPhysicalMemorySize(); |
| 115 | R_SUCCEED(); | 114 | R_SUCCEED(); |
| 116 | 115 | ||
| 117 | case InfoType::UsedNonSystemMemorySize: | 116 | case InfoType::UsedNonSystemMemorySize: |
| 118 | *result = process->GetTotalPhysicalMemoryUsedWithoutSystemResource(); | 117 | *result = process->GetUsedNonSystemUserPhysicalMemorySize(); |
| 119 | R_SUCCEED(); | 118 | R_SUCCEED(); |
| 120 | 119 | ||
| 121 | case InfoType::IsApplication: | 120 | case InfoType::IsApplication: |
| 122 | LOG_WARNING(Kernel_SVC, "(STUBBED) Assuming process is application"); | 121 | LOG_WARNING(Kernel_SVC, "(STUBBED) Assuming process is application"); |
| 123 | *result = true; | 122 | *result = process->IsApplication(); |
| 124 | R_SUCCEED(); | 123 | R_SUCCEED(); |
| 125 | 124 | ||
| 126 | case InfoType::FreeThreadCount: | 125 | case InfoType::FreeThreadCount: |
| 127 | *result = process->GetFreeThreadCount(); | 126 | if (KResourceLimit* resource_limit = process->GetResourceLimit(); |
| 127 | resource_limit != nullptr) { | ||
| 128 | const auto current_value = | ||
| 129 | resource_limit->GetCurrentValue(Svc::LimitableResource::ThreadCountMax); | ||
| 130 | const auto limit_value = | ||
| 131 | resource_limit->GetLimitValue(Svc::LimitableResource::ThreadCountMax); | ||
| 132 | *result = limit_value - current_value; | ||
| 133 | } else { | ||
| 134 | *result = 0; | ||
| 135 | } | ||
| 128 | R_SUCCEED(); | 136 | R_SUCCEED(); |
| 129 | 137 | ||
| 130 | default: | 138 | default: |
| @@ -161,7 +169,7 @@ Result GetInfo(Core::System& system, u64* result, InfoType info_id_type, Handle | |||
| 161 | 169 | ||
| 162 | case InfoType::RandomEntropy: | 170 | case InfoType::RandomEntropy: |
| 163 | R_UNLESS(handle == 0, ResultInvalidHandle); | 171 | R_UNLESS(handle == 0, ResultInvalidHandle); |
| 164 | R_UNLESS(info_sub_id < KProcess::RANDOM_ENTROPY_SIZE, ResultInvalidCombination); | 172 | R_UNLESS(info_sub_id < 4, ResultInvalidCombination); |
| 165 | 173 | ||
| 166 | *result = GetCurrentProcess(system.Kernel()).GetRandomEntropy(info_sub_id); | 174 | *result = GetCurrentProcess(system.Kernel()).GetRandomEntropy(info_sub_id); |
| 167 | R_SUCCEED(); | 175 | R_SUCCEED(); |
diff --git a/src/core/hle/kernel/svc/svc_lock.cpp b/src/core/hle/kernel/svc/svc_lock.cpp index 1d7bc4246..5f0833fcb 100644 --- a/src/core/hle/kernel/svc/svc_lock.cpp +++ b/src/core/hle/kernel/svc/svc_lock.cpp | |||
| @@ -17,7 +17,7 @@ Result ArbitrateLock(Core::System& system, Handle thread_handle, u64 address, u3 | |||
| 17 | R_UNLESS(!IsKernelAddress(address), ResultInvalidCurrentMemory); | 17 | R_UNLESS(!IsKernelAddress(address), ResultInvalidCurrentMemory); |
| 18 | R_UNLESS(Common::IsAligned(address, sizeof(u32)), ResultInvalidAddress); | 18 | R_UNLESS(Common::IsAligned(address, sizeof(u32)), ResultInvalidAddress); |
| 19 | 19 | ||
| 20 | R_RETURN(GetCurrentProcess(system.Kernel()).WaitForAddress(thread_handle, address, tag)); | 20 | R_RETURN(KConditionVariable::WaitForAddress(system.Kernel(), thread_handle, address, tag)); |
| 21 | } | 21 | } |
| 22 | 22 | ||
| 23 | /// Unlock a mutex | 23 | /// Unlock a mutex |
| @@ -28,7 +28,7 @@ Result ArbitrateUnlock(Core::System& system, u64 address) { | |||
| 28 | R_UNLESS(!IsKernelAddress(address), ResultInvalidCurrentMemory); | 28 | R_UNLESS(!IsKernelAddress(address), ResultInvalidCurrentMemory); |
| 29 | R_UNLESS(Common::IsAligned(address, sizeof(u32)), ResultInvalidAddress); | 29 | R_UNLESS(Common::IsAligned(address, sizeof(u32)), ResultInvalidAddress); |
| 30 | 30 | ||
| 31 | R_RETURN(GetCurrentProcess(system.Kernel()).SignalToAddress(address)); | 31 | R_RETURN(KConditionVariable::SignalToAddress(system.Kernel(), address)); |
| 32 | } | 32 | } |
| 33 | 33 | ||
| 34 | Result ArbitrateLock64(Core::System& system, Handle thread_handle, uint64_t address, uint32_t tag) { | 34 | Result ArbitrateLock64(Core::System& system, Handle thread_handle, uint64_t address, uint32_t tag) { |
diff --git a/src/core/hle/kernel/svc/svc_memory.cpp b/src/core/hle/kernel/svc/svc_memory.cpp index 2cab74127..97f1210de 100644 --- a/src/core/hle/kernel/svc/svc_memory.cpp +++ b/src/core/hle/kernel/svc/svc_memory.cpp | |||
| @@ -76,7 +76,7 @@ Result MapUnmapMemorySanityChecks(const KPageTable& manager, u64 dst_addr, u64 s | |||
| 76 | } // namespace | 76 | } // namespace |
| 77 | 77 | ||
| 78 | Result SetMemoryPermission(Core::System& system, u64 address, u64 size, MemoryPermission perm) { | 78 | Result SetMemoryPermission(Core::System& system, u64 address, u64 size, MemoryPermission perm) { |
| 79 | LOG_DEBUG(Kernel_SVC, "called, address=0x{:016X}, size=0x{:X}, perm=0x{:08X", address, size, | 79 | LOG_DEBUG(Kernel_SVC, "called, address=0x{:016X}, size=0x{:X}, perm=0x{:08X}", address, size, |
| 80 | perm); | 80 | perm); |
| 81 | 81 | ||
| 82 | // Validate address / size. | 82 | // Validate address / size. |
| @@ -108,10 +108,16 @@ Result SetMemoryAttribute(Core::System& system, u64 address, u64 size, u32 mask, | |||
| 108 | R_UNLESS((address < address + size), ResultInvalidCurrentMemory); | 108 | R_UNLESS((address < address + size), ResultInvalidCurrentMemory); |
| 109 | 109 | ||
| 110 | // Validate the attribute and mask. | 110 | // Validate the attribute and mask. |
| 111 | constexpr u32 SupportedMask = static_cast<u32>(MemoryAttribute::Uncached); | 111 | constexpr u32 SupportedMask = |
| 112 | static_cast<u32>(MemoryAttribute::Uncached | MemoryAttribute::PermissionLocked); | ||
| 112 | R_UNLESS((mask | attr) == mask, ResultInvalidCombination); | 113 | R_UNLESS((mask | attr) == mask, ResultInvalidCombination); |
| 113 | R_UNLESS((mask | attr | SupportedMask) == SupportedMask, ResultInvalidCombination); | 114 | R_UNLESS((mask | attr | SupportedMask) == SupportedMask, ResultInvalidCombination); |
| 114 | 115 | ||
| 116 | // Check that permission locked is either being set or not masked. | ||
| 117 | R_UNLESS((static_cast<Svc::MemoryAttribute>(mask) & Svc::MemoryAttribute::PermissionLocked) == | ||
| 118 | (static_cast<Svc::MemoryAttribute>(attr) & Svc::MemoryAttribute::PermissionLocked), | ||
| 119 | ResultInvalidCombination); | ||
| 120 | |||
| 115 | // Validate that the region is in range for the current process. | 121 | // Validate that the region is in range for the current process. |
| 116 | auto& page_table{GetCurrentProcess(system.Kernel()).GetPageTable()}; | 122 | auto& page_table{GetCurrentProcess(system.Kernel()).GetPageTable()}; |
| 117 | R_UNLESS(page_table.Contains(address, size), ResultInvalidCurrentMemory); | 123 | R_UNLESS(page_table.Contains(address, size), ResultInvalidCurrentMemory); |
diff --git a/src/core/hle/kernel/svc/svc_physical_memory.cpp b/src/core/hle/kernel/svc/svc_physical_memory.cpp index d3545f232..99330d02a 100644 --- a/src/core/hle/kernel/svc/svc_physical_memory.cpp +++ b/src/core/hle/kernel/svc/svc_physical_memory.cpp | |||
| @@ -46,7 +46,7 @@ Result MapPhysicalMemory(Core::System& system, u64 addr, u64 size) { | |||
| 46 | KProcess* const current_process{GetCurrentProcessPointer(system.Kernel())}; | 46 | KProcess* const current_process{GetCurrentProcessPointer(system.Kernel())}; |
| 47 | auto& page_table{current_process->GetPageTable()}; | 47 | auto& page_table{current_process->GetPageTable()}; |
| 48 | 48 | ||
| 49 | if (current_process->GetSystemResourceSize() == 0) { | 49 | if (current_process->GetTotalSystemResourceSize() == 0) { |
| 50 | LOG_ERROR(Kernel_SVC, "System Resource Size is zero"); | 50 | LOG_ERROR(Kernel_SVC, "System Resource Size is zero"); |
| 51 | R_THROW(ResultInvalidState); | 51 | R_THROW(ResultInvalidState); |
| 52 | } | 52 | } |
| @@ -95,7 +95,7 @@ Result UnmapPhysicalMemory(Core::System& system, u64 addr, u64 size) { | |||
| 95 | KProcess* const current_process{GetCurrentProcessPointer(system.Kernel())}; | 95 | KProcess* const current_process{GetCurrentProcessPointer(system.Kernel())}; |
| 96 | auto& page_table{current_process->GetPageTable()}; | 96 | auto& page_table{current_process->GetPageTable()}; |
| 97 | 97 | ||
| 98 | if (current_process->GetSystemResourceSize() == 0) { | 98 | if (current_process->GetTotalSystemResourceSize() == 0) { |
| 99 | LOG_ERROR(Kernel_SVC, "System Resource Size is zero"); | 99 | LOG_ERROR(Kernel_SVC, "System Resource Size is zero"); |
| 100 | R_THROW(ResultInvalidState); | 100 | R_THROW(ResultInvalidState); |
| 101 | } | 101 | } |
diff --git a/src/core/hle/kernel/svc/svc_synchronization.cpp b/src/core/hle/kernel/svc/svc_synchronization.cpp index 8ebc1bd1c..6c79cfd8d 100644 --- a/src/core/hle/kernel/svc/svc_synchronization.cpp +++ b/src/core/hle/kernel/svc/svc_synchronization.cpp | |||
| @@ -132,7 +132,7 @@ void SynchronizePreemptionState(Core::System& system) { | |||
| 132 | GetCurrentThread(kernel).ClearInterruptFlag(); | 132 | GetCurrentThread(kernel).ClearInterruptFlag(); |
| 133 | 133 | ||
| 134 | // Unpin the current thread. | 134 | // Unpin the current thread. |
| 135 | cur_process->UnpinCurrentThread(core_id); | 135 | cur_process->UnpinCurrentThread(); |
| 136 | } | 136 | } |
| 137 | } | 137 | } |
| 138 | 138 | ||
diff --git a/src/core/hle/kernel/svc/svc_thread.cpp b/src/core/hle/kernel/svc/svc_thread.cpp index 933b82e30..755fd62b5 100644 --- a/src/core/hle/kernel/svc/svc_thread.cpp +++ b/src/core/hle/kernel/svc/svc_thread.cpp | |||
| @@ -85,10 +85,6 @@ Result StartThread(Core::System& system, Handle thread_handle) { | |||
| 85 | // Try to start the thread. | 85 | // Try to start the thread. |
| 86 | R_TRY(thread->Run()); | 86 | R_TRY(thread->Run()); |
| 87 | 87 | ||
| 88 | // If we succeeded, persist a reference to the thread. | ||
| 89 | thread->Open(); | ||
| 90 | system.Kernel().RegisterInUseObject(thread.GetPointerUnsafe()); | ||
| 91 | |||
| 92 | R_SUCCEED(); | 88 | R_SUCCEED(); |
| 93 | } | 89 | } |
| 94 | 90 | ||
| @@ -99,7 +95,6 @@ void ExitThread(Core::System& system) { | |||
| 99 | auto* const current_thread = GetCurrentThreadPointer(system.Kernel()); | 95 | auto* const current_thread = GetCurrentThreadPointer(system.Kernel()); |
| 100 | system.GlobalSchedulerContext().RemoveThread(current_thread); | 96 | system.GlobalSchedulerContext().RemoveThread(current_thread); |
| 101 | current_thread->Exit(); | 97 | current_thread->Exit(); |
| 102 | system.Kernel().UnregisterInUseObject(current_thread); | ||
| 103 | } | 98 | } |
| 104 | 99 | ||
| 105 | /// Sleep the current thread | 100 | /// Sleep the current thread |
| @@ -260,7 +255,7 @@ Result GetThreadList(Core::System& system, s32* out_num_threads, u64 out_thread_ | |||
| 260 | 255 | ||
| 261 | auto list_iter = thread_list.cbegin(); | 256 | auto list_iter = thread_list.cbegin(); |
| 262 | for (std::size_t i = 0; i < copy_amount; ++i, ++list_iter) { | 257 | for (std::size_t i = 0; i < copy_amount; ++i, ++list_iter) { |
| 263 | memory.Write64(out_thread_ids, (*list_iter)->GetThreadId()); | 258 | memory.Write64(out_thread_ids, list_iter->GetThreadId()); |
| 264 | out_thread_ids += sizeof(u64); | 259 | out_thread_ids += sizeof(u64); |
| 265 | } | 260 | } |
| 266 | 261 | ||
diff --git a/src/core/hle/kernel/svc/svc_transfer_memory.cpp b/src/core/hle/kernel/svc/svc_transfer_memory.cpp index 7d94e7f09..1f97121b3 100644 --- a/src/core/hle/kernel/svc/svc_transfer_memory.cpp +++ b/src/core/hle/kernel/svc/svc_transfer_memory.cpp | |||
| @@ -71,15 +71,59 @@ Result CreateTransferMemory(Core::System& system, Handle* out, u64 address, u64 | |||
| 71 | } | 71 | } |
| 72 | 72 | ||
| 73 | Result MapTransferMemory(Core::System& system, Handle trmem_handle, uint64_t address, uint64_t size, | 73 | Result MapTransferMemory(Core::System& system, Handle trmem_handle, uint64_t address, uint64_t size, |
| 74 | MemoryPermission owner_perm) { | 74 | MemoryPermission map_perm) { |
| 75 | UNIMPLEMENTED(); | 75 | // Validate the address/size. |
| 76 | R_THROW(ResultNotImplemented); | 76 | R_UNLESS(Common::IsAligned(address, PageSize), ResultInvalidAddress); |
| 77 | R_UNLESS(Common::IsAligned(size, PageSize), ResultInvalidSize); | ||
| 78 | R_UNLESS(size > 0, ResultInvalidSize); | ||
| 79 | R_UNLESS((address < address + size), ResultInvalidCurrentMemory); | ||
| 80 | |||
| 81 | // Validate the permission. | ||
| 82 | R_UNLESS(IsValidTransferMemoryPermission(map_perm), ResultInvalidState); | ||
| 83 | |||
| 84 | // Get the transfer memory. | ||
| 85 | KScopedAutoObject trmem = GetCurrentProcess(system.Kernel()) | ||
| 86 | .GetHandleTable() | ||
| 87 | .GetObject<KTransferMemory>(trmem_handle); | ||
| 88 | R_UNLESS(trmem.IsNotNull(), ResultInvalidHandle); | ||
| 89 | |||
| 90 | // Verify that the mapping is in range. | ||
| 91 | R_UNLESS(GetCurrentProcess(system.Kernel()) | ||
| 92 | .GetPageTable() | ||
| 93 | .CanContain(address, size, KMemoryState::Transfered), | ||
| 94 | ResultInvalidMemoryRegion); | ||
| 95 | |||
| 96 | // Map the transfer memory. | ||
| 97 | R_TRY(trmem->Map(address, size, map_perm)); | ||
| 98 | |||
| 99 | // We succeeded. | ||
| 100 | R_SUCCEED(); | ||
| 77 | } | 101 | } |
| 78 | 102 | ||
| 79 | Result UnmapTransferMemory(Core::System& system, Handle trmem_handle, uint64_t address, | 103 | Result UnmapTransferMemory(Core::System& system, Handle trmem_handle, uint64_t address, |
| 80 | uint64_t size) { | 104 | uint64_t size) { |
| 81 | UNIMPLEMENTED(); | 105 | // Validate the address/size. |
| 82 | R_THROW(ResultNotImplemented); | 106 | R_UNLESS(Common::IsAligned(address, PageSize), ResultInvalidAddress); |
| 107 | R_UNLESS(Common::IsAligned(size, PageSize), ResultInvalidSize); | ||
| 108 | R_UNLESS(size > 0, ResultInvalidSize); | ||
| 109 | R_UNLESS((address < address + size), ResultInvalidCurrentMemory); | ||
| 110 | |||
| 111 | // Get the transfer memory. | ||
| 112 | KScopedAutoObject trmem = GetCurrentProcess(system.Kernel()) | ||
| 113 | .GetHandleTable() | ||
| 114 | .GetObject<KTransferMemory>(trmem_handle); | ||
| 115 | R_UNLESS(trmem.IsNotNull(), ResultInvalidHandle); | ||
| 116 | |||
| 117 | // Verify that the mapping is in range. | ||
| 118 | R_UNLESS(GetCurrentProcess(system.Kernel()) | ||
| 119 | .GetPageTable() | ||
| 120 | .CanContain(address, size, KMemoryState::Transfered), | ||
| 121 | ResultInvalidMemoryRegion); | ||
| 122 | |||
| 123 | // Unmap the transfer memory. | ||
| 124 | R_TRY(trmem->Unmap(address, size)); | ||
| 125 | |||
| 126 | R_SUCCEED(); | ||
| 83 | } | 127 | } |
| 84 | 128 | ||
| 85 | Result MapTransferMemory64(Core::System& system, Handle trmem_handle, uint64_t address, | 129 | Result MapTransferMemory64(Core::System& system, Handle trmem_handle, uint64_t address, |
diff --git a/src/core/hle/kernel/svc_generator.py b/src/core/hle/kernel/svc_generator.py index 7fcbb1ba1..5531faac6 100644 --- a/src/core/hle/kernel/svc_generator.py +++ b/src/core/hle/kernel/svc_generator.py | |||
| @@ -592,7 +592,7 @@ void Call(Core::System& system, u32 imm) { | |||
| 592 | auto& kernel = system.Kernel(); | 592 | auto& kernel = system.Kernel(); |
| 593 | kernel.EnterSVCProfile(); | 593 | kernel.EnterSVCProfile(); |
| 594 | 594 | ||
| 595 | if (GetCurrentProcess(system.Kernel()).Is64BitProcess()) { | 595 | if (GetCurrentProcess(system.Kernel()).Is64Bit()) { |
| 596 | Call64(system, imm); | 596 | Call64(system, imm); |
| 597 | } else { | 597 | } else { |
| 598 | Call32(system, imm); | 598 | Call32(system, imm); |
diff --git a/src/core/hle/kernel/svc_types.h b/src/core/hle/kernel/svc_types.h index 7f380ca4f..50de02e36 100644 --- a/src/core/hle/kernel/svc_types.h +++ b/src/core/hle/kernel/svc_types.h | |||
| @@ -46,6 +46,7 @@ enum class MemoryAttribute : u32 { | |||
| 46 | IpcLocked = (1 << 1), | 46 | IpcLocked = (1 << 1), |
| 47 | DeviceShared = (1 << 2), | 47 | DeviceShared = (1 << 2), |
| 48 | Uncached = (1 << 3), | 48 | Uncached = (1 << 3), |
| 49 | PermissionLocked = (1 << 4), | ||
| 49 | }; | 50 | }; |
| 50 | DECLARE_ENUM_FLAG_OPERATORS(MemoryAttribute); | 51 | DECLARE_ENUM_FLAG_OPERATORS(MemoryAttribute); |
| 51 | 52 | ||
| @@ -603,13 +604,57 @@ enum class ProcessActivity : u32 { | |||
| 603 | Paused, | 604 | Paused, |
| 604 | }; | 605 | }; |
| 605 | 606 | ||
| 607 | enum class CreateProcessFlag : u32 { | ||
| 608 | // Is 64 bit? | ||
| 609 | Is64Bit = (1 << 0), | ||
| 610 | |||
| 611 | // What kind of address space? | ||
| 612 | AddressSpaceShift = 1, | ||
| 613 | AddressSpaceMask = (7 << AddressSpaceShift), | ||
| 614 | AddressSpace32Bit = (0 << AddressSpaceShift), | ||
| 615 | AddressSpace64BitDeprecated = (1 << AddressSpaceShift), | ||
| 616 | AddressSpace32BitWithoutAlias = (2 << AddressSpaceShift), | ||
| 617 | AddressSpace64Bit = (3 << AddressSpaceShift), | ||
| 618 | |||
| 619 | // Should JIT debug be done on crash? | ||
| 620 | EnableDebug = (1 << 4), | ||
| 621 | |||
| 622 | // Should ASLR be enabled for the process? | ||
| 623 | EnableAslr = (1 << 5), | ||
| 624 | |||
| 625 | // Is the process an application? | ||
| 626 | IsApplication = (1 << 6), | ||
| 627 | |||
| 628 | // 4.x deprecated: Should use secure memory? | ||
| 629 | DeprecatedUseSecureMemory = (1 << 7), | ||
| 630 | |||
| 631 | // 5.x+ Pool partition type. | ||
| 632 | PoolPartitionShift = 7, | ||
| 633 | PoolPartitionMask = (0xF << PoolPartitionShift), | ||
| 634 | PoolPartitionApplication = (0 << PoolPartitionShift), | ||
| 635 | PoolPartitionApplet = (1 << PoolPartitionShift), | ||
| 636 | PoolPartitionSystem = (2 << PoolPartitionShift), | ||
| 637 | PoolPartitionSystemNonSecure = (3 << PoolPartitionShift), | ||
| 638 | |||
| 639 | // 7.x+ Should memory allocation be optimized? This requires IsApplication. | ||
| 640 | OptimizeMemoryAllocation = (1 << 11), | ||
| 641 | |||
| 642 | // 11.x+ DisableDeviceAddressSpaceMerge. | ||
| 643 | DisableDeviceAddressSpaceMerge = (1 << 12), | ||
| 644 | |||
| 645 | // Mask of all flags. | ||
| 646 | All = Is64Bit | AddressSpaceMask | EnableDebug | EnableAslr | IsApplication | | ||
| 647 | PoolPartitionMask | OptimizeMemoryAllocation | DisableDeviceAddressSpaceMerge, | ||
| 648 | }; | ||
| 649 | DECLARE_ENUM_FLAG_OPERATORS(CreateProcessFlag); | ||
| 650 | |||
| 606 | struct CreateProcessParameter { | 651 | struct CreateProcessParameter { |
| 607 | std::array<char, 12> name; | 652 | std::array<char, 12> name; |
| 608 | u32 version; | 653 | u32 version; |
| 609 | u64 program_id; | 654 | u64 program_id; |
| 610 | u64 code_address; | 655 | u64 code_address; |
| 611 | s32 code_num_pages; | 656 | s32 code_num_pages; |
| 612 | u32 flags; | 657 | CreateProcessFlag flags; |
| 613 | Handle reslimit; | 658 | Handle reslimit; |
| 614 | s32 system_resource_num_pages; | 659 | s32 system_resource_num_pages; |
| 615 | }; | 660 | }; |
diff --git a/src/core/hle/service/acc/acc.cpp b/src/core/hle/service/acc/acc.cpp index b971401e6..1b1c8190e 100644 --- a/src/core/hle/service/acc/acc.cpp +++ b/src/core/hle/service/acc/acc.cpp | |||
| @@ -49,7 +49,7 @@ public: | |||
| 49 | : ServiceFramework{system_, "IManagerForSystemService"} { | 49 | : ServiceFramework{system_, "IManagerForSystemService"} { |
| 50 | // clang-format off | 50 | // clang-format off |
| 51 | static const FunctionInfo functions[] = { | 51 | static const FunctionInfo functions[] = { |
| 52 | {0, nullptr, "CheckAvailability"}, | 52 | {0, &IManagerForSystemService::CheckAvailability, "CheckAvailability"}, |
| 53 | {1, nullptr, "GetAccountId"}, | 53 | {1, nullptr, "GetAccountId"}, |
| 54 | {2, nullptr, "EnsureIdTokenCacheAsync"}, | 54 | {2, nullptr, "EnsureIdTokenCacheAsync"}, |
| 55 | {3, nullptr, "LoadIdTokenCache"}, | 55 | {3, nullptr, "LoadIdTokenCache"}, |
| @@ -78,6 +78,13 @@ public: | |||
| 78 | 78 | ||
| 79 | RegisterHandlers(functions); | 79 | RegisterHandlers(functions); |
| 80 | } | 80 | } |
| 81 | |||
| 82 | private: | ||
| 83 | void CheckAvailability(HLERequestContext& ctx) { | ||
| 84 | LOG_WARNING(Service_ACC, "(STUBBED) called"); | ||
| 85 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 86 | rb.Push(ResultSuccess); | ||
| 87 | } | ||
| 81 | }; | 88 | }; |
| 82 | 89 | ||
| 83 | // 3.0.0+ | 90 | // 3.0.0+ |
| @@ -400,13 +407,13 @@ protected: | |||
| 400 | IPC::RequestParser rp{ctx}; | 407 | IPC::RequestParser rp{ctx}; |
| 401 | const auto base = rp.PopRaw<ProfileBase>(); | 408 | const auto base = rp.PopRaw<ProfileBase>(); |
| 402 | 409 | ||
| 403 | const auto user_data = ctx.ReadBuffer(); | 410 | const auto image_data = ctx.ReadBufferA(0); |
| 404 | const auto image_data = ctx.ReadBuffer(1); | 411 | const auto user_data = ctx.ReadBufferX(0); |
| 405 | 412 | ||
| 406 | LOG_DEBUG(Service_ACC, "called, username='{}', timestamp={:016X}, uuid=0x{}", | 413 | LOG_INFO(Service_ACC, "called, username='{}', timestamp={:016X}, uuid=0x{}", |
| 407 | Common::StringFromFixedZeroTerminatedBuffer( | 414 | Common::StringFromFixedZeroTerminatedBuffer( |
| 408 | reinterpret_cast<const char*>(base.username.data()), base.username.size()), | 415 | reinterpret_cast<const char*>(base.username.data()), base.username.size()), |
| 409 | base.timestamp, base.user_uuid.RawString()); | 416 | base.timestamp, base.user_uuid.RawString()); |
| 410 | 417 | ||
| 411 | if (user_data.size() < sizeof(UserData)) { | 418 | if (user_data.size() < sizeof(UserData)) { |
| 412 | LOG_ERROR(Service_ACC, "UserData buffer too small!"); | 419 | LOG_ERROR(Service_ACC, "UserData buffer too small!"); |
| @@ -837,6 +844,29 @@ void Module::Interface::InitializeApplicationInfoV2(HLERequestContext& ctx) { | |||
| 837 | rb.Push(ResultSuccess); | 844 | rb.Push(ResultSuccess); |
| 838 | } | 845 | } |
| 839 | 846 | ||
| 847 | void Module::Interface::BeginUserRegistration(HLERequestContext& ctx) { | ||
| 848 | const auto user_id = Common::UUID::MakeRandom(); | ||
| 849 | profile_manager->CreateNewUser(user_id, "yuzu"); | ||
| 850 | |||
| 851 | LOG_INFO(Service_ACC, "called, uuid={}", user_id.FormattedString()); | ||
| 852 | |||
| 853 | IPC::ResponseBuilder rb{ctx, 6}; | ||
| 854 | rb.Push(ResultSuccess); | ||
| 855 | rb.PushRaw(user_id); | ||
| 856 | } | ||
| 857 | |||
| 858 | void Module::Interface::CompleteUserRegistration(HLERequestContext& ctx) { | ||
| 859 | IPC::RequestParser rp{ctx}; | ||
| 860 | Common::UUID user_id = rp.PopRaw<Common::UUID>(); | ||
| 861 | |||
| 862 | LOG_INFO(Service_ACC, "called, uuid={}", user_id.FormattedString()); | ||
| 863 | |||
| 864 | profile_manager->WriteUserSaveFile(); | ||
| 865 | |||
| 866 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 867 | rb.Push(ResultSuccess); | ||
| 868 | } | ||
| 869 | |||
| 840 | void Module::Interface::GetProfileEditor(HLERequestContext& ctx) { | 870 | void Module::Interface::GetProfileEditor(HLERequestContext& ctx) { |
| 841 | IPC::RequestParser rp{ctx}; | 871 | IPC::RequestParser rp{ctx}; |
| 842 | Common::UUID user_id = rp.PopRaw<Common::UUID>(); | 872 | Common::UUID user_id = rp.PopRaw<Common::UUID>(); |
| @@ -880,6 +910,17 @@ void Module::Interface::StoreSaveDataThumbnailApplication(HLERequestContext& ctx | |||
| 880 | StoreSaveDataThumbnail(ctx, uuid, tid); | 910 | StoreSaveDataThumbnail(ctx, uuid, tid); |
| 881 | } | 911 | } |
| 882 | 912 | ||
| 913 | void Module::Interface::GetBaasAccountManagerForSystemService(HLERequestContext& ctx) { | ||
| 914 | IPC::RequestParser rp{ctx}; | ||
| 915 | const auto uuid = rp.PopRaw<Common::UUID>(); | ||
| 916 | |||
| 917 | LOG_INFO(Service_ACC, "called, uuid=0x{}", uuid.RawString()); | ||
| 918 | |||
| 919 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | ||
| 920 | rb.Push(ResultSuccess); | ||
| 921 | rb.PushIpcInterface<IManagerForSystemService>(system, uuid); | ||
| 922 | } | ||
| 923 | |||
| 883 | void Module::Interface::StoreSaveDataThumbnailSystem(HLERequestContext& ctx) { | 924 | void Module::Interface::StoreSaveDataThumbnailSystem(HLERequestContext& ctx) { |
| 884 | IPC::RequestParser rp{ctx}; | 925 | IPC::RequestParser rp{ctx}; |
| 885 | const auto uuid = rp.PopRaw<Common::UUID>(); | 926 | const auto uuid = rp.PopRaw<Common::UUID>(); |
diff --git a/src/core/hle/service/acc/acc.h b/src/core/hle/service/acc/acc.h index 6b4735c2f..0395229b4 100644 --- a/src/core/hle/service/acc/acc.h +++ b/src/core/hle/service/acc/acc.h | |||
| @@ -33,10 +33,13 @@ public: | |||
| 33 | void TrySelectUserWithoutInteraction(HLERequestContext& ctx); | 33 | void TrySelectUserWithoutInteraction(HLERequestContext& ctx); |
| 34 | void IsUserAccountSwitchLocked(HLERequestContext& ctx); | 34 | void IsUserAccountSwitchLocked(HLERequestContext& ctx); |
| 35 | void InitializeApplicationInfoV2(HLERequestContext& ctx); | 35 | void InitializeApplicationInfoV2(HLERequestContext& ctx); |
| 36 | void BeginUserRegistration(HLERequestContext& ctx); | ||
| 37 | void CompleteUserRegistration(HLERequestContext& ctx); | ||
| 36 | void GetProfileEditor(HLERequestContext& ctx); | 38 | void GetProfileEditor(HLERequestContext& ctx); |
| 37 | void ListQualifiedUsers(HLERequestContext& ctx); | 39 | void ListQualifiedUsers(HLERequestContext& ctx); |
| 38 | void ListOpenContextStoredUsers(HLERequestContext& ctx); | 40 | void ListOpenContextStoredUsers(HLERequestContext& ctx); |
| 39 | void StoreSaveDataThumbnailApplication(HLERequestContext& ctx); | 41 | void StoreSaveDataThumbnailApplication(HLERequestContext& ctx); |
| 42 | void GetBaasAccountManagerForSystemService(HLERequestContext& ctx); | ||
| 40 | void StoreSaveDataThumbnailSystem(HLERequestContext& ctx); | 43 | void StoreSaveDataThumbnailSystem(HLERequestContext& ctx); |
| 41 | 44 | ||
| 42 | private: | 45 | private: |
diff --git a/src/core/hle/service/acc/acc_su.cpp b/src/core/hle/service/acc/acc_su.cpp index d9882ecd3..770d13ec5 100644 --- a/src/core/hle/service/acc/acc_su.cpp +++ b/src/core/hle/service/acc/acc_su.cpp | |||
| @@ -23,7 +23,7 @@ ACC_SU::ACC_SU(std::shared_ptr<Module> module_, std::shared_ptr<ProfileManager> | |||
| 23 | {99, nullptr, "DebugActivateOpenContextRetention"}, | 23 | {99, nullptr, "DebugActivateOpenContextRetention"}, |
| 24 | {100, nullptr, "GetUserRegistrationNotifier"}, | 24 | {100, nullptr, "GetUserRegistrationNotifier"}, |
| 25 | {101, nullptr, "GetUserStateChangeNotifier"}, | 25 | {101, nullptr, "GetUserStateChangeNotifier"}, |
| 26 | {102, nullptr, "GetBaasAccountManagerForSystemService"}, | 26 | {102, &ACC_SU::GetBaasAccountManagerForSystemService, "GetBaasAccountManagerForSystemService"}, |
| 27 | {103, nullptr, "GetBaasUserAvailabilityChangeNotifier"}, | 27 | {103, nullptr, "GetBaasUserAvailabilityChangeNotifier"}, |
| 28 | {104, nullptr, "GetProfileUpdateNotifier"}, | 28 | {104, nullptr, "GetProfileUpdateNotifier"}, |
| 29 | {105, nullptr, "CheckNetworkServiceAvailabilityAsync"}, | 29 | {105, nullptr, "CheckNetworkServiceAvailabilityAsync"}, |
| @@ -40,8 +40,8 @@ ACC_SU::ACC_SU(std::shared_ptr<Module> module_, std::shared_ptr<ProfileManager> | |||
| 40 | {152, nullptr, "LoadSignedDeviceIdentifierCacheForNintendoAccount"}, | 40 | {152, nullptr, "LoadSignedDeviceIdentifierCacheForNintendoAccount"}, |
| 41 | {190, nullptr, "GetUserLastOpenedApplication"}, | 41 | {190, nullptr, "GetUserLastOpenedApplication"}, |
| 42 | {191, nullptr, "ActivateOpenContextHolder"}, | 42 | {191, nullptr, "ActivateOpenContextHolder"}, |
| 43 | {200, nullptr, "BeginUserRegistration"}, | 43 | {200, &ACC_SU::BeginUserRegistration, "BeginUserRegistration"}, |
| 44 | {201, nullptr, "CompleteUserRegistration"}, | 44 | {201, &ACC_SU::CompleteUserRegistration, "CompleteUserRegistration"}, |
| 45 | {202, nullptr, "CancelUserRegistration"}, | 45 | {202, nullptr, "CancelUserRegistration"}, |
| 46 | {203, nullptr, "DeleteUser"}, | 46 | {203, nullptr, "DeleteUser"}, |
| 47 | {204, nullptr, "SetUserPosition"}, | 47 | {204, nullptr, "SetUserPosition"}, |
diff --git a/src/core/hle/service/acc/profile_manager.h b/src/core/hle/service/acc/profile_manager.h index 993a5a57a..900e32200 100644 --- a/src/core/hle/service/acc/profile_manager.h +++ b/src/core/hle/service/acc/profile_manager.h | |||
| @@ -96,9 +96,10 @@ public: | |||
| 96 | bool SetProfileBaseAndData(Common::UUID uuid, const ProfileBase& profile_new, | 96 | bool SetProfileBaseAndData(Common::UUID uuid, const ProfileBase& profile_new, |
| 97 | const UserData& data_new); | 97 | const UserData& data_new); |
| 98 | 98 | ||
| 99 | void WriteUserSaveFile(); | ||
| 100 | |||
| 99 | private: | 101 | private: |
| 100 | void ParseUserSaveFile(); | 102 | void ParseUserSaveFile(); |
| 101 | void WriteUserSaveFile(); | ||
| 102 | std::optional<std::size_t> AddToProfiles(const ProfileInfo& profile); | 103 | std::optional<std::size_t> AddToProfiles(const ProfileInfo& profile); |
| 103 | bool RemoveProfileAtIndex(std::size_t index); | 104 | bool RemoveProfileAtIndex(std::size_t index); |
| 104 | 105 | ||
diff --git a/src/core/hle/service/am/am.cpp b/src/core/hle/service/am/am.cpp index 819dea6a7..ff067c8d9 100644 --- a/src/core/hle/service/am/am.cpp +++ b/src/core/hle/service/am/am.cpp | |||
| @@ -31,7 +31,7 @@ | |||
| 31 | #include "core/hle/service/apm/apm_controller.h" | 31 | #include "core/hle/service/apm/apm_controller.h" |
| 32 | #include "core/hle/service/apm/apm_interface.h" | 32 | #include "core/hle/service/apm/apm_interface.h" |
| 33 | #include "core/hle/service/bcat/backend/backend.h" | 33 | #include "core/hle/service/bcat/backend/backend.h" |
| 34 | #include "core/hle/service/caps/caps.h" | 34 | #include "core/hle/service/caps/caps_types.h" |
| 35 | #include "core/hle/service/filesystem/filesystem.h" | 35 | #include "core/hle/service/filesystem/filesystem.h" |
| 36 | #include "core/hle/service/ipc_helpers.h" | 36 | #include "core/hle/service/ipc_helpers.h" |
| 37 | #include "core/hle/service/ns/ns.h" | 37 | #include "core/hle/service/ns/ns.h" |
| @@ -210,8 +210,8 @@ IDisplayController::IDisplayController(Core::System& system_) | |||
| 210 | {21, nullptr, "ClearAppletTransitionBuffer"}, | 210 | {21, nullptr, "ClearAppletTransitionBuffer"}, |
| 211 | {22, nullptr, "AcquireLastApplicationCaptureSharedBuffer"}, | 211 | {22, nullptr, "AcquireLastApplicationCaptureSharedBuffer"}, |
| 212 | {23, nullptr, "ReleaseLastApplicationCaptureSharedBuffer"}, | 212 | {23, nullptr, "ReleaseLastApplicationCaptureSharedBuffer"}, |
| 213 | {24, nullptr, "AcquireLastForegroundCaptureSharedBuffer"}, | 213 | {24, &IDisplayController::AcquireLastForegroundCaptureSharedBuffer, "AcquireLastForegroundCaptureSharedBuffer"}, |
| 214 | {25, nullptr, "ReleaseLastForegroundCaptureSharedBuffer"}, | 214 | {25, &IDisplayController::ReleaseLastForegroundCaptureSharedBuffer, "ReleaseLastForegroundCaptureSharedBuffer"}, |
| 215 | {26, &IDisplayController::AcquireCallerAppletCaptureSharedBuffer, "AcquireCallerAppletCaptureSharedBuffer"}, | 215 | {26, &IDisplayController::AcquireCallerAppletCaptureSharedBuffer, "AcquireCallerAppletCaptureSharedBuffer"}, |
| 216 | {27, &IDisplayController::ReleaseCallerAppletCaptureSharedBuffer, "ReleaseCallerAppletCaptureSharedBuffer"}, | 216 | {27, &IDisplayController::ReleaseCallerAppletCaptureSharedBuffer, "ReleaseCallerAppletCaptureSharedBuffer"}, |
| 217 | {28, nullptr, "TakeScreenShotOfOwnLayerEx"}, | 217 | {28, nullptr, "TakeScreenShotOfOwnLayerEx"}, |
| @@ -239,6 +239,22 @@ void IDisplayController::TakeScreenShotOfOwnLayer(HLERequestContext& ctx) { | |||
| 239 | rb.Push(ResultSuccess); | 239 | rb.Push(ResultSuccess); |
| 240 | } | 240 | } |
| 241 | 241 | ||
| 242 | void IDisplayController::AcquireLastForegroundCaptureSharedBuffer(HLERequestContext& ctx) { | ||
| 243 | LOG_WARNING(Service_AM, "(STUBBED) called"); | ||
| 244 | |||
| 245 | IPC::ResponseBuilder rb{ctx, 4}; | ||
| 246 | rb.Push(ResultSuccess); | ||
| 247 | rb.Push(1U); | ||
| 248 | rb.Push(0); | ||
| 249 | } | ||
| 250 | |||
| 251 | void IDisplayController::ReleaseLastForegroundCaptureSharedBuffer(HLERequestContext& ctx) { | ||
| 252 | LOG_WARNING(Service_AM, "(STUBBED) called"); | ||
| 253 | |||
| 254 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 255 | rb.Push(ResultSuccess); | ||
| 256 | } | ||
| 257 | |||
| 242 | void IDisplayController::AcquireCallerAppletCaptureSharedBuffer(HLERequestContext& ctx) { | 258 | void IDisplayController::AcquireCallerAppletCaptureSharedBuffer(HLERequestContext& ctx) { |
| 243 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 259 | LOG_WARNING(Service_AM, "(STUBBED) called"); |
| 244 | 260 | ||
| @@ -764,6 +780,68 @@ void AppletMessageQueue::OperationModeChanged() { | |||
| 764 | on_operation_mode_changed->Signal(); | 780 | on_operation_mode_changed->Signal(); |
| 765 | } | 781 | } |
| 766 | 782 | ||
| 783 | ILockAccessor::ILockAccessor(Core::System& system_) | ||
| 784 | : ServiceFramework{system_, "ILockAccessor"}, service_context{system_, "ILockAccessor"} { | ||
| 785 | // clang-format off | ||
| 786 | static const FunctionInfo functions[] = { | ||
| 787 | {1, &ILockAccessor::TryLock, "TryLock"}, | ||
| 788 | {2, &ILockAccessor::Unlock, "Unlock"}, | ||
| 789 | {3, &ILockAccessor::GetEvent, "GetEvent"}, | ||
| 790 | {4,&ILockAccessor::IsLocked, "IsLocked"}, | ||
| 791 | }; | ||
| 792 | // clang-format on | ||
| 793 | |||
| 794 | RegisterHandlers(functions); | ||
| 795 | |||
| 796 | lock_event = service_context.CreateEvent("ILockAccessor::LockEvent"); | ||
| 797 | } | ||
| 798 | |||
| 799 | ILockAccessor::~ILockAccessor() { | ||
| 800 | service_context.CloseEvent(lock_event); | ||
| 801 | }; | ||
| 802 | |||
| 803 | void ILockAccessor::TryLock(HLERequestContext& ctx) { | ||
| 804 | IPC::RequestParser rp{ctx}; | ||
| 805 | const auto return_handle = rp.Pop<bool>(); | ||
| 806 | |||
| 807 | LOG_WARNING(Service_AM, "(STUBBED) called, return_handle={}", return_handle); | ||
| 808 | |||
| 809 | // TODO: When return_handle is true this function should return the lock handle | ||
| 810 | |||
| 811 | is_locked = true; | ||
| 812 | |||
| 813 | IPC::ResponseBuilder rb{ctx, 3}; | ||
| 814 | rb.Push(ResultSuccess); | ||
| 815 | rb.Push<u8>(is_locked); | ||
| 816 | } | ||
| 817 | |||
| 818 | void ILockAccessor::Unlock(HLERequestContext& ctx) { | ||
| 819 | LOG_INFO(Service_AM, "called"); | ||
| 820 | |||
| 821 | is_locked = false; | ||
| 822 | |||
| 823 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 824 | rb.Push(ResultSuccess); | ||
| 825 | } | ||
| 826 | |||
| 827 | void ILockAccessor::GetEvent(HLERequestContext& ctx) { | ||
| 828 | LOG_INFO(Service_AM, "called"); | ||
| 829 | |||
| 830 | lock_event->Signal(); | ||
| 831 | |||
| 832 | IPC::ResponseBuilder rb{ctx, 2, 1}; | ||
| 833 | rb.Push(ResultSuccess); | ||
| 834 | rb.PushCopyObjects(lock_event->GetReadableEvent()); | ||
| 835 | } | ||
| 836 | |||
| 837 | void ILockAccessor::IsLocked(HLERequestContext& ctx) { | ||
| 838 | LOG_INFO(Service_AM, "called"); | ||
| 839 | |||
| 840 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 841 | rb.Push(ResultSuccess); | ||
| 842 | rb.Push<u8>(is_locked); | ||
| 843 | } | ||
| 844 | |||
| 767 | ICommonStateGetter::ICommonStateGetter(Core::System& system_, | 845 | ICommonStateGetter::ICommonStateGetter(Core::System& system_, |
| 768 | std::shared_ptr<AppletMessageQueue> msg_queue_) | 846 | std::shared_ptr<AppletMessageQueue> msg_queue_) |
| 769 | : ServiceFramework{system_, "ICommonStateGetter"}, msg_queue{std::move(msg_queue_)}, | 847 | : ServiceFramework{system_, "ICommonStateGetter"}, msg_queue{std::move(msg_queue_)}, |
| @@ -787,7 +865,7 @@ ICommonStateGetter::ICommonStateGetter(Core::System& system_, | |||
| 787 | {14, nullptr, "GetWakeupCount"}, | 865 | {14, nullptr, "GetWakeupCount"}, |
| 788 | {20, nullptr, "PushToGeneralChannel"}, | 866 | {20, nullptr, "PushToGeneralChannel"}, |
| 789 | {30, nullptr, "GetHomeButtonReaderLockAccessor"}, | 867 | {30, nullptr, "GetHomeButtonReaderLockAccessor"}, |
| 790 | {31, nullptr, "GetReaderLockAccessorEx"}, | 868 | {31, &ICommonStateGetter::GetReaderLockAccessorEx, "GetReaderLockAccessorEx"}, |
| 791 | {32, nullptr, "GetWriterLockAccessorEx"}, | 869 | {32, nullptr, "GetWriterLockAccessorEx"}, |
| 792 | {40, nullptr, "GetCradleFwVersion"}, | 870 | {40, nullptr, "GetCradleFwVersion"}, |
| 793 | {50, &ICommonStateGetter::IsVrModeEnabled, "IsVrModeEnabled"}, | 871 | {50, &ICommonStateGetter::IsVrModeEnabled, "IsVrModeEnabled"}, |
| @@ -805,7 +883,7 @@ ICommonStateGetter::ICommonStateGetter(Core::System& system_, | |||
| 805 | {65, nullptr, "GetApplicationIdByContentActionName"}, | 883 | {65, nullptr, "GetApplicationIdByContentActionName"}, |
| 806 | {66, &ICommonStateGetter::SetCpuBoostMode, "SetCpuBoostMode"}, | 884 | {66, &ICommonStateGetter::SetCpuBoostMode, "SetCpuBoostMode"}, |
| 807 | {67, nullptr, "CancelCpuBoostMode"}, | 885 | {67, nullptr, "CancelCpuBoostMode"}, |
| 808 | {68, nullptr, "GetBuiltInDisplayType"}, | 886 | {68, &ICommonStateGetter::GetBuiltInDisplayType, "GetBuiltInDisplayType"}, |
| 809 | {80, &ICommonStateGetter::PerformSystemButtonPressingIfInFocus, "PerformSystemButtonPressingIfInFocus"}, | 887 | {80, &ICommonStateGetter::PerformSystemButtonPressingIfInFocus, "PerformSystemButtonPressingIfInFocus"}, |
| 810 | {90, nullptr, "SetPerformanceConfigurationChangedNotification"}, | 888 | {90, nullptr, "SetPerformanceConfigurationChangedNotification"}, |
| 811 | {91, nullptr, "GetCurrentPerformanceConfiguration"}, | 889 | {91, nullptr, "GetCurrentPerformanceConfiguration"}, |
| @@ -833,7 +911,9 @@ ICommonStateGetter::ICommonStateGetter(Core::System& system_, | |||
| 833 | msg_queue->PushMessage(AppletMessageQueue::AppletMessage::ChangeIntoForeground); | 911 | msg_queue->PushMessage(AppletMessageQueue::AppletMessage::ChangeIntoForeground); |
| 834 | } | 912 | } |
| 835 | 913 | ||
| 836 | ICommonStateGetter::~ICommonStateGetter() = default; | 914 | ICommonStateGetter::~ICommonStateGetter() { |
| 915 | service_context.CloseEvent(sleep_lock_event); | ||
| 916 | }; | ||
| 837 | 917 | ||
| 838 | void ICommonStateGetter::GetBootMode(HLERequestContext& ctx) { | 918 | void ICommonStateGetter::GetBootMode(HLERequestContext& ctx) { |
| 839 | LOG_DEBUG(Service_AM, "called"); | 919 | LOG_DEBUG(Service_AM, "called"); |
| @@ -886,6 +966,18 @@ void ICommonStateGetter::RequestToAcquireSleepLock(HLERequestContext& ctx) { | |||
| 886 | rb.Push(ResultSuccess); | 966 | rb.Push(ResultSuccess); |
| 887 | } | 967 | } |
| 888 | 968 | ||
| 969 | void ICommonStateGetter::GetReaderLockAccessorEx(HLERequestContext& ctx) { | ||
| 970 | IPC::RequestParser rp{ctx}; | ||
| 971 | const auto unknown = rp.Pop<u32>(); | ||
| 972 | |||
| 973 | LOG_INFO(Service_AM, "called, unknown={}", unknown); | ||
| 974 | |||
| 975 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | ||
| 976 | |||
| 977 | rb.Push(ResultSuccess); | ||
| 978 | rb.PushIpcInterface<ILockAccessor>(system); | ||
| 979 | } | ||
| 980 | |||
| 889 | void ICommonStateGetter::GetAcquiredSleepLockEvent(HLERequestContext& ctx) { | 981 | void ICommonStateGetter::GetAcquiredSleepLockEvent(HLERequestContext& ctx) { |
| 890 | LOG_WARNING(Service_AM, "called"); | 982 | LOG_WARNING(Service_AM, "called"); |
| 891 | 983 | ||
| @@ -970,6 +1062,14 @@ void ICommonStateGetter::SetCpuBoostMode(HLERequestContext& ctx) { | |||
| 970 | apm_sys->SetCpuBoostMode(ctx); | 1062 | apm_sys->SetCpuBoostMode(ctx); |
| 971 | } | 1063 | } |
| 972 | 1064 | ||
| 1065 | void ICommonStateGetter::GetBuiltInDisplayType(HLERequestContext& ctx) { | ||
| 1066 | LOG_WARNING(Service_AM, "(STUBBED) called"); | ||
| 1067 | |||
| 1068 | IPC::ResponseBuilder rb{ctx, 3}; | ||
| 1069 | rb.Push(ResultSuccess); | ||
| 1070 | rb.Push(0); | ||
| 1071 | } | ||
| 1072 | |||
| 973 | void ICommonStateGetter::PerformSystemButtonPressingIfInFocus(HLERequestContext& ctx) { | 1073 | void ICommonStateGetter::PerformSystemButtonPressingIfInFocus(HLERequestContext& ctx) { |
| 974 | IPC::RequestParser rp{ctx}; | 1074 | IPC::RequestParser rp{ctx}; |
| 975 | const auto system_button{rp.PopEnum<SystemButtonType>()}; | 1075 | const auto system_button{rp.PopEnum<SystemButtonType>()}; |
| @@ -1477,7 +1577,7 @@ ILibraryAppletSelfAccessor::ILibraryAppletSelfAccessor(Core::System& system_) | |||
| 1477 | {100, nullptr, "CreateGameMovieTrimmer"}, | 1577 | {100, nullptr, "CreateGameMovieTrimmer"}, |
| 1478 | {101, nullptr, "ReserveResourceForMovieOperation"}, | 1578 | {101, nullptr, "ReserveResourceForMovieOperation"}, |
| 1479 | {102, nullptr, "UnreserveResourceForMovieOperation"}, | 1579 | {102, nullptr, "UnreserveResourceForMovieOperation"}, |
| 1480 | {110, nullptr, "GetMainAppletAvailableUsers"}, | 1580 | {110, &ILibraryAppletSelfAccessor::GetMainAppletAvailableUsers, "GetMainAppletAvailableUsers"}, |
| 1481 | {120, nullptr, "GetLaunchStorageInfoForDebug"}, | 1581 | {120, nullptr, "GetLaunchStorageInfoForDebug"}, |
| 1482 | {130, nullptr, "GetGpuErrorDetectedSystemEvent"}, | 1582 | {130, nullptr, "GetGpuErrorDetectedSystemEvent"}, |
| 1483 | {140, nullptr, "SetApplicationMemoryReservation"}, | 1583 | {140, nullptr, "SetApplicationMemoryReservation"}, |
| @@ -1493,6 +1593,9 @@ ILibraryAppletSelfAccessor::ILibraryAppletSelfAccessor(Core::System& system_) | |||
| 1493 | case Applets::AppletId::MiiEdit: | 1593 | case Applets::AppletId::MiiEdit: |
| 1494 | PushInShowMiiEditData(); | 1594 | PushInShowMiiEditData(); |
| 1495 | break; | 1595 | break; |
| 1596 | case Applets::AppletId::PhotoViewer: | ||
| 1597 | PushInShowAlbum(); | ||
| 1598 | break; | ||
| 1496 | default: | 1599 | default: |
| 1497 | break; | 1600 | break; |
| 1498 | } | 1601 | } |
| @@ -1569,6 +1672,42 @@ void ILibraryAppletSelfAccessor::GetCallerAppletIdentityInfo(HLERequestContext& | |||
| 1569 | rb.PushRaw(applet_info); | 1672 | rb.PushRaw(applet_info); |
| 1570 | } | 1673 | } |
| 1571 | 1674 | ||
| 1675 | void ILibraryAppletSelfAccessor::GetMainAppletAvailableUsers(HLERequestContext& ctx) { | ||
| 1676 | const Service::Account::ProfileManager manager{}; | ||
| 1677 | bool is_empty{true}; | ||
| 1678 | s32 user_count{-1}; | ||
| 1679 | |||
| 1680 | LOG_INFO(Service_AM, "called"); | ||
| 1681 | |||
| 1682 | if (manager.GetUserCount() > 0) { | ||
| 1683 | is_empty = false; | ||
| 1684 | user_count = static_cast<s32>(manager.GetUserCount()); | ||
| 1685 | ctx.WriteBuffer(manager.GetAllUsers()); | ||
| 1686 | } | ||
| 1687 | |||
| 1688 | IPC::ResponseBuilder rb{ctx, 4}; | ||
| 1689 | rb.Push(ResultSuccess); | ||
| 1690 | rb.Push<u8>(is_empty); | ||
| 1691 | rb.Push(user_count); | ||
| 1692 | } | ||
| 1693 | |||
| 1694 | void ILibraryAppletSelfAccessor::PushInShowAlbum() { | ||
| 1695 | const Applets::CommonArguments arguments{ | ||
| 1696 | .arguments_version = Applets::CommonArgumentVersion::Version3, | ||
| 1697 | .size = Applets::CommonArgumentSize::Version3, | ||
| 1698 | .library_version = 1, | ||
| 1699 | .theme_color = Applets::ThemeColor::BasicBlack, | ||
| 1700 | .play_startup_sound = true, | ||
| 1701 | .system_tick = system.CoreTiming().GetClockTicks(), | ||
| 1702 | }; | ||
| 1703 | |||
| 1704 | std::vector<u8> argument_data(sizeof(arguments)); | ||
| 1705 | std::vector<u8> settings_data{2}; | ||
| 1706 | std::memcpy(argument_data.data(), &arguments, sizeof(arguments)); | ||
| 1707 | queue_data.emplace_back(std::move(argument_data)); | ||
| 1708 | queue_data.emplace_back(std::move(settings_data)); | ||
| 1709 | } | ||
| 1710 | |||
| 1572 | void ILibraryAppletSelfAccessor::PushInShowCabinetData() { | 1711 | void ILibraryAppletSelfAccessor::PushInShowCabinetData() { |
| 1573 | const Applets::CommonArguments arguments{ | 1712 | const Applets::CommonArguments arguments{ |
| 1574 | .arguments_version = Applets::CommonArgumentVersion::Version3, | 1713 | .arguments_version = Applets::CommonArgumentVersion::Version3, |
diff --git a/src/core/hle/service/am/am.h b/src/core/hle/service/am/am.h index 349482dcc..64b3f3fe2 100644 --- a/src/core/hle/service/am/am.h +++ b/src/core/hle/service/am/am.h | |||
| @@ -124,6 +124,8 @@ public: | |||
| 124 | private: | 124 | private: |
| 125 | void GetCallerAppletCaptureImageEx(HLERequestContext& ctx); | 125 | void GetCallerAppletCaptureImageEx(HLERequestContext& ctx); |
| 126 | void TakeScreenShotOfOwnLayer(HLERequestContext& ctx); | 126 | void TakeScreenShotOfOwnLayer(HLERequestContext& ctx); |
| 127 | void AcquireLastForegroundCaptureSharedBuffer(HLERequestContext& ctx); | ||
| 128 | void ReleaseLastForegroundCaptureSharedBuffer(HLERequestContext& ctx); | ||
| 127 | void AcquireCallerAppletCaptureSharedBuffer(HLERequestContext& ctx); | 129 | void AcquireCallerAppletCaptureSharedBuffer(HLERequestContext& ctx); |
| 128 | void ReleaseCallerAppletCaptureSharedBuffer(HLERequestContext& ctx); | 130 | void ReleaseCallerAppletCaptureSharedBuffer(HLERequestContext& ctx); |
| 129 | }; | 131 | }; |
| @@ -195,6 +197,23 @@ private: | |||
| 195 | ScreenshotPermission screenshot_permission = ScreenshotPermission::Inherit; | 197 | ScreenshotPermission screenshot_permission = ScreenshotPermission::Inherit; |
| 196 | }; | 198 | }; |
| 197 | 199 | ||
| 200 | class ILockAccessor final : public ServiceFramework<ILockAccessor> { | ||
| 201 | public: | ||
| 202 | explicit ILockAccessor(Core::System& system_); | ||
| 203 | ~ILockAccessor() override; | ||
| 204 | |||
| 205 | private: | ||
| 206 | void TryLock(HLERequestContext& ctx); | ||
| 207 | void Unlock(HLERequestContext& ctx); | ||
| 208 | void GetEvent(HLERequestContext& ctx); | ||
| 209 | void IsLocked(HLERequestContext& ctx); | ||
| 210 | |||
| 211 | bool is_locked{}; | ||
| 212 | |||
| 213 | Kernel::KEvent* lock_event; | ||
| 214 | KernelHelpers::ServiceContext service_context; | ||
| 215 | }; | ||
| 216 | |||
| 198 | class ICommonStateGetter final : public ServiceFramework<ICommonStateGetter> { | 217 | class ICommonStateGetter final : public ServiceFramework<ICommonStateGetter> { |
| 199 | public: | 218 | public: |
| 200 | explicit ICommonStateGetter(Core::System& system_, | 219 | explicit ICommonStateGetter(Core::System& system_, |
| @@ -237,6 +256,7 @@ private: | |||
| 237 | void GetCurrentFocusState(HLERequestContext& ctx); | 256 | void GetCurrentFocusState(HLERequestContext& ctx); |
| 238 | void RequestToAcquireSleepLock(HLERequestContext& ctx); | 257 | void RequestToAcquireSleepLock(HLERequestContext& ctx); |
| 239 | void GetAcquiredSleepLockEvent(HLERequestContext& ctx); | 258 | void GetAcquiredSleepLockEvent(HLERequestContext& ctx); |
| 259 | void GetReaderLockAccessorEx(HLERequestContext& ctx); | ||
| 240 | void GetDefaultDisplayResolutionChangeEvent(HLERequestContext& ctx); | 260 | void GetDefaultDisplayResolutionChangeEvent(HLERequestContext& ctx); |
| 241 | void GetOperationMode(HLERequestContext& ctx); | 261 | void GetOperationMode(HLERequestContext& ctx); |
| 242 | void GetPerformanceMode(HLERequestContext& ctx); | 262 | void GetPerformanceMode(HLERequestContext& ctx); |
| @@ -248,6 +268,7 @@ private: | |||
| 248 | void EndVrModeEx(HLERequestContext& ctx); | 268 | void EndVrModeEx(HLERequestContext& ctx); |
| 249 | void GetDefaultDisplayResolution(HLERequestContext& ctx); | 269 | void GetDefaultDisplayResolution(HLERequestContext& ctx); |
| 250 | void SetCpuBoostMode(HLERequestContext& ctx); | 270 | void SetCpuBoostMode(HLERequestContext& ctx); |
| 271 | void GetBuiltInDisplayType(HLERequestContext& ctx); | ||
| 251 | void PerformSystemButtonPressingIfInFocus(HLERequestContext& ctx); | 272 | void PerformSystemButtonPressingIfInFocus(HLERequestContext& ctx); |
| 252 | void GetSettingsPlatformRegion(HLERequestContext& ctx); | 273 | void GetSettingsPlatformRegion(HLERequestContext& ctx); |
| 253 | void SetRequestExitToLibraryAppletAtExecuteNextProgramEnabled(HLERequestContext& ctx); | 274 | void SetRequestExitToLibraryAppletAtExecuteNextProgramEnabled(HLERequestContext& ctx); |
| @@ -326,7 +347,9 @@ private: | |||
| 326 | void GetLibraryAppletInfo(HLERequestContext& ctx); | 347 | void GetLibraryAppletInfo(HLERequestContext& ctx); |
| 327 | void ExitProcessAndReturn(HLERequestContext& ctx); | 348 | void ExitProcessAndReturn(HLERequestContext& ctx); |
| 328 | void GetCallerAppletIdentityInfo(HLERequestContext& ctx); | 349 | void GetCallerAppletIdentityInfo(HLERequestContext& ctx); |
| 350 | void GetMainAppletAvailableUsers(HLERequestContext& ctx); | ||
| 329 | 351 | ||
| 352 | void PushInShowAlbum(); | ||
| 330 | void PushInShowCabinetData(); | 353 | void PushInShowCabinetData(); |
| 331 | void PushInShowMiiEditData(); | 354 | void PushInShowMiiEditData(); |
| 332 | 355 | ||
diff --git a/src/core/hle/service/am/applet_ae.cpp b/src/core/hle/service/am/applet_ae.cpp index eb12312cc..e30e6478a 100644 --- a/src/core/hle/service/am/applet_ae.cpp +++ b/src/core/hle/service/am/applet_ae.cpp | |||
| @@ -28,8 +28,8 @@ public: | |||
| 28 | {11, &ILibraryAppletProxy::GetLibraryAppletCreator, "GetLibraryAppletCreator"}, | 28 | {11, &ILibraryAppletProxy::GetLibraryAppletCreator, "GetLibraryAppletCreator"}, |
| 29 | {20, &ILibraryAppletProxy::OpenLibraryAppletSelfAccessor, "OpenLibraryAppletSelfAccessor"}, | 29 | {20, &ILibraryAppletProxy::OpenLibraryAppletSelfAccessor, "OpenLibraryAppletSelfAccessor"}, |
| 30 | {21, &ILibraryAppletProxy::GetAppletCommonFunctions, "GetAppletCommonFunctions"}, | 30 | {21, &ILibraryAppletProxy::GetAppletCommonFunctions, "GetAppletCommonFunctions"}, |
| 31 | {22, nullptr, "GetHomeMenuFunctions"}, | 31 | {22, &ILibraryAppletProxy::GetHomeMenuFunctions, "GetHomeMenuFunctions"}, |
| 32 | {23, nullptr, "GetGlobalStateController"}, | 32 | {23, &ILibraryAppletProxy::GetGlobalStateController, "GetGlobalStateController"}, |
| 33 | {1000, &ILibraryAppletProxy::GetDebugFunctions, "GetDebugFunctions"}, | 33 | {1000, &ILibraryAppletProxy::GetDebugFunctions, "GetDebugFunctions"}, |
| 34 | }; | 34 | }; |
| 35 | // clang-format on | 35 | // clang-format on |
| @@ -110,6 +110,22 @@ private: | |||
| 110 | rb.PushIpcInterface<IAppletCommonFunctions>(system); | 110 | rb.PushIpcInterface<IAppletCommonFunctions>(system); |
| 111 | } | 111 | } |
| 112 | 112 | ||
| 113 | void GetHomeMenuFunctions(HLERequestContext& ctx) { | ||
| 114 | LOG_DEBUG(Service_AM, "called"); | ||
| 115 | |||
| 116 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | ||
| 117 | rb.Push(ResultSuccess); | ||
| 118 | rb.PushIpcInterface<IHomeMenuFunctions>(system); | ||
| 119 | } | ||
| 120 | |||
| 121 | void GetGlobalStateController(HLERequestContext& ctx) { | ||
| 122 | LOG_DEBUG(Service_AM, "called"); | ||
| 123 | |||
| 124 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | ||
| 125 | rb.Push(ResultSuccess); | ||
| 126 | rb.PushIpcInterface<IGlobalStateController>(system); | ||
| 127 | } | ||
| 128 | |||
| 113 | void GetDebugFunctions(HLERequestContext& ctx) { | 129 | void GetDebugFunctions(HLERequestContext& ctx) { |
| 114 | LOG_DEBUG(Service_AM, "called"); | 130 | LOG_DEBUG(Service_AM, "called"); |
| 115 | 131 | ||
diff --git a/src/core/hle/service/am/applets/applet_cabinet.cpp b/src/core/hle/service/am/applets/applet_cabinet.cpp index 19ed184e8..b379dadeb 100644 --- a/src/core/hle/service/am/applets/applet_cabinet.cpp +++ b/src/core/hle/service/am/applets/applet_cabinet.cpp | |||
| @@ -25,7 +25,9 @@ Cabinet::Cabinet(Core::System& system_, LibraryAppletMode applet_mode_, | |||
| 25 | service_context.CreateEvent("CabinetApplet:AvailabilityChangeEvent"); | 25 | service_context.CreateEvent("CabinetApplet:AvailabilityChangeEvent"); |
| 26 | } | 26 | } |
| 27 | 27 | ||
| 28 | Cabinet::~Cabinet() = default; | 28 | Cabinet::~Cabinet() { |
| 29 | service_context.CloseEvent(availability_change_event); | ||
| 30 | }; | ||
| 29 | 31 | ||
| 30 | void Cabinet::Initialize() { | 32 | void Cabinet::Initialize() { |
| 31 | Applet::Initialize(); | 33 | Applet::Initialize(); |
diff --git a/src/core/hle/service/am/applets/applet_error.cpp b/src/core/hle/service/am/applets/applet_error.cpp index b46ea840c..5d17c353f 100644 --- a/src/core/hle/service/am/applets/applet_error.cpp +++ b/src/core/hle/service/am/applets/applet_error.cpp | |||
| @@ -138,6 +138,10 @@ void Error::Initialize() { | |||
| 138 | CopyArgumentData(data, args->application_error); | 138 | CopyArgumentData(data, args->application_error); |
| 139 | error_code = Result(args->application_error.error_code); | 139 | error_code = Result(args->application_error.error_code); |
| 140 | break; | 140 | break; |
| 141 | case ErrorAppletMode::ShowErrorPctl: | ||
| 142 | CopyArgumentData(data, args->error_record); | ||
| 143 | error_code = Decode64BitError(args->error_record.error_code_64); | ||
| 144 | break; | ||
| 141 | case ErrorAppletMode::ShowErrorRecord: | 145 | case ErrorAppletMode::ShowErrorRecord: |
| 142 | CopyArgumentData(data, args->error_record); | 146 | CopyArgumentData(data, args->error_record); |
| 143 | error_code = Decode64BitError(args->error_record.error_code_64); | 147 | error_code = Decode64BitError(args->error_record.error_code_64); |
| @@ -191,6 +195,7 @@ void Error::Execute() { | |||
| 191 | frontend.ShowCustomErrorText(error_code, main_text_string, detail_text_string, callback); | 195 | frontend.ShowCustomErrorText(error_code, main_text_string, detail_text_string, callback); |
| 192 | break; | 196 | break; |
| 193 | } | 197 | } |
| 198 | case ErrorAppletMode::ShowErrorPctl: | ||
| 194 | case ErrorAppletMode::ShowErrorRecord: | 199 | case ErrorAppletMode::ShowErrorRecord: |
| 195 | reporter.SaveErrorReport(title_id, error_code, | 200 | reporter.SaveErrorReport(title_id, error_code, |
| 196 | fmt::format("{:016X}", args->error_record.posix_time)); | 201 | fmt::format("{:016X}", args->error_record.posix_time)); |
diff --git a/src/core/hle/service/caps/caps.cpp b/src/core/hle/service/caps/caps.cpp index 610fe9940..cd1dfe993 100644 --- a/src/core/hle/service/caps/caps.cpp +++ b/src/core/hle/service/caps/caps.cpp | |||
| @@ -4,6 +4,7 @@ | |||
| 4 | #include "core/hle/service/caps/caps.h" | 4 | #include "core/hle/service/caps/caps.h" |
| 5 | #include "core/hle/service/caps/caps_a.h" | 5 | #include "core/hle/service/caps/caps_a.h" |
| 6 | #include "core/hle/service/caps/caps_c.h" | 6 | #include "core/hle/service/caps/caps_c.h" |
| 7 | #include "core/hle/service/caps/caps_manager.h" | ||
| 7 | #include "core/hle/service/caps/caps_sc.h" | 8 | #include "core/hle/service/caps/caps_sc.h" |
| 8 | #include "core/hle/service/caps/caps_ss.h" | 9 | #include "core/hle/service/caps/caps_ss.h" |
| 9 | #include "core/hle/service/caps/caps_su.h" | 10 | #include "core/hle/service/caps/caps_su.h" |
| @@ -15,13 +16,22 @@ namespace Service::Capture { | |||
| 15 | 16 | ||
| 16 | void LoopProcess(Core::System& system) { | 17 | void LoopProcess(Core::System& system) { |
| 17 | auto server_manager = std::make_unique<ServerManager>(system); | 18 | auto server_manager = std::make_unique<ServerManager>(system); |
| 19 | auto album_manager = std::make_shared<AlbumManager>(system); | ||
| 20 | |||
| 21 | server_manager->RegisterNamedService( | ||
| 22 | "caps:a", std::make_shared<IAlbumAccessorService>(system, album_manager)); | ||
| 23 | server_manager->RegisterNamedService( | ||
| 24 | "caps:c", std::make_shared<IAlbumControlService>(system, album_manager)); | ||
| 25 | server_manager->RegisterNamedService( | ||
| 26 | "caps:u", std::make_shared<IAlbumApplicationService>(system, album_manager)); | ||
| 27 | |||
| 28 | server_manager->RegisterNamedService( | ||
| 29 | "caps:ss", std::make_shared<IScreenShotService>(system, album_manager)); | ||
| 30 | server_manager->RegisterNamedService("caps:sc", | ||
| 31 | std::make_shared<IScreenShotControlService>(system)); | ||
| 32 | server_manager->RegisterNamedService( | ||
| 33 | "caps:su", std::make_shared<IScreenShotApplicationService>(system, album_manager)); | ||
| 18 | 34 | ||
| 19 | server_manager->RegisterNamedService("caps:a", std::make_shared<CAPS_A>(system)); | ||
| 20 | server_manager->RegisterNamedService("caps:c", std::make_shared<CAPS_C>(system)); | ||
| 21 | server_manager->RegisterNamedService("caps:u", std::make_shared<CAPS_U>(system)); | ||
| 22 | server_manager->RegisterNamedService("caps:sc", std::make_shared<CAPS_SC>(system)); | ||
| 23 | server_manager->RegisterNamedService("caps:ss", std::make_shared<CAPS_SS>(system)); | ||
| 24 | server_manager->RegisterNamedService("caps:su", std::make_shared<CAPS_SU>(system)); | ||
| 25 | ServerManager::RunServer(std::move(server_manager)); | 35 | ServerManager::RunServer(std::move(server_manager)); |
| 26 | } | 36 | } |
| 27 | 37 | ||
diff --git a/src/core/hle/service/caps/caps.h b/src/core/hle/service/caps/caps.h index 15f0ecfaa..58e9725b8 100644 --- a/src/core/hle/service/caps/caps.h +++ b/src/core/hle/service/caps/caps.h | |||
| @@ -3,93 +3,12 @@ | |||
| 3 | 3 | ||
| 4 | #pragma once | 4 | #pragma once |
| 5 | 5 | ||
| 6 | #include "common/common_funcs.h" | ||
| 7 | #include "common/common_types.h" | ||
| 8 | |||
| 9 | namespace Core { | 6 | namespace Core { |
| 10 | class System; | 7 | class System; |
| 11 | } | 8 | } |
| 12 | 9 | ||
| 13 | namespace Service::SM { | ||
| 14 | class ServiceManager; | ||
| 15 | } | ||
| 16 | |||
| 17 | namespace Service::Capture { | 10 | namespace Service::Capture { |
| 18 | 11 | ||
| 19 | enum class AlbumImageOrientation { | ||
| 20 | Orientation0 = 0, | ||
| 21 | Orientation1 = 1, | ||
| 22 | Orientation2 = 2, | ||
| 23 | Orientation3 = 3, | ||
| 24 | }; | ||
| 25 | |||
| 26 | enum class AlbumReportOption : s32 { | ||
| 27 | Disable = 0, | ||
| 28 | Enable = 1, | ||
| 29 | }; | ||
| 30 | |||
| 31 | enum class ContentType : u8 { | ||
| 32 | Screenshot = 0, | ||
| 33 | Movie = 1, | ||
| 34 | ExtraMovie = 3, | ||
| 35 | }; | ||
| 36 | |||
| 37 | enum class AlbumStorage : u8 { | ||
| 38 | NAND = 0, | ||
| 39 | SD = 1, | ||
| 40 | }; | ||
| 41 | |||
| 42 | struct AlbumFileDateTime { | ||
| 43 | s16 year{}; | ||
| 44 | s8 month{}; | ||
| 45 | s8 day{}; | ||
| 46 | s8 hour{}; | ||
| 47 | s8 minute{}; | ||
| 48 | s8 second{}; | ||
| 49 | s8 uid{}; | ||
| 50 | }; | ||
| 51 | static_assert(sizeof(AlbumFileDateTime) == 0x8, "AlbumFileDateTime has incorrect size."); | ||
| 52 | |||
| 53 | struct AlbumEntry { | ||
| 54 | u64 size{}; | ||
| 55 | u64 application_id{}; | ||
| 56 | AlbumFileDateTime datetime{}; | ||
| 57 | AlbumStorage storage{}; | ||
| 58 | ContentType content{}; | ||
| 59 | INSERT_PADDING_BYTES(6); | ||
| 60 | }; | ||
| 61 | static_assert(sizeof(AlbumEntry) == 0x20, "AlbumEntry has incorrect size."); | ||
| 62 | |||
| 63 | struct AlbumFileEntry { | ||
| 64 | u64 size{}; // Size of the entry | ||
| 65 | u64 hash{}; // AES256 with hardcoded key over AlbumEntry | ||
| 66 | AlbumFileDateTime datetime{}; | ||
| 67 | AlbumStorage storage{}; | ||
| 68 | ContentType content{}; | ||
| 69 | INSERT_PADDING_BYTES(5); | ||
| 70 | u8 unknown{1}; // Set to 1 on official SW | ||
| 71 | }; | ||
| 72 | static_assert(sizeof(AlbumFileEntry) == 0x20, "AlbumFileEntry has incorrect size."); | ||
| 73 | |||
| 74 | struct ApplicationAlbumEntry { | ||
| 75 | u64 size{}; // Size of the entry | ||
| 76 | u64 hash{}; // AES256 with hardcoded key over AlbumEntry | ||
| 77 | AlbumFileDateTime datetime{}; | ||
| 78 | AlbumStorage storage{}; | ||
| 79 | ContentType content{}; | ||
| 80 | INSERT_PADDING_BYTES(5); | ||
| 81 | u8 unknown{1}; // Set to 1 on official SW | ||
| 82 | }; | ||
| 83 | static_assert(sizeof(ApplicationAlbumEntry) == 0x20, "ApplicationAlbumEntry has incorrect size."); | ||
| 84 | |||
| 85 | struct ApplicationAlbumFileEntry { | ||
| 86 | ApplicationAlbumEntry entry{}; | ||
| 87 | AlbumFileDateTime datetime{}; | ||
| 88 | u64 unknown{}; | ||
| 89 | }; | ||
| 90 | static_assert(sizeof(ApplicationAlbumFileEntry) == 0x30, | ||
| 91 | "ApplicationAlbumFileEntry has incorrect size."); | ||
| 92 | |||
| 93 | void LoopProcess(Core::System& system); | 12 | void LoopProcess(Core::System& system); |
| 94 | 13 | ||
| 95 | } // namespace Service::Capture | 14 | } // namespace Service::Capture |
diff --git a/src/core/hle/service/caps/caps_a.cpp b/src/core/hle/service/caps/caps_a.cpp index 44267b284..9925720a3 100644 --- a/src/core/hle/service/caps/caps_a.cpp +++ b/src/core/hle/service/caps/caps_a.cpp | |||
| @@ -1,40 +1,26 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project | 1 | // SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project |
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | 2 | // SPDX-License-Identifier: GPL-2.0-or-later |
| 3 | 3 | ||
| 4 | #include "common/logging/log.h" | ||
| 4 | #include "core/hle/service/caps/caps_a.h" | 5 | #include "core/hle/service/caps/caps_a.h" |
| 6 | #include "core/hle/service/caps/caps_manager.h" | ||
| 7 | #include "core/hle/service/caps/caps_result.h" | ||
| 8 | #include "core/hle/service/caps/caps_types.h" | ||
| 9 | #include "core/hle/service/ipc_helpers.h" | ||
| 5 | 10 | ||
| 6 | namespace Service::Capture { | 11 | namespace Service::Capture { |
| 7 | 12 | ||
| 8 | class IAlbumAccessorSession final : public ServiceFramework<IAlbumAccessorSession> { | 13 | IAlbumAccessorService::IAlbumAccessorService(Core::System& system_, |
| 9 | public: | 14 | std::shared_ptr<AlbumManager> album_manager) |
| 10 | explicit IAlbumAccessorSession(Core::System& system_) | 15 | : ServiceFramework{system_, "caps:a"}, manager{album_manager} { |
| 11 | : ServiceFramework{system_, "IAlbumAccessorSession"} { | ||
| 12 | // clang-format off | ||
| 13 | static const FunctionInfo functions[] = { | ||
| 14 | {2001, nullptr, "OpenAlbumMovieReadStream"}, | ||
| 15 | {2002, nullptr, "CloseAlbumMovieReadStream"}, | ||
| 16 | {2003, nullptr, "GetAlbumMovieReadStreamMovieDataSize"}, | ||
| 17 | {2004, nullptr, "ReadMovieDataFromAlbumMovieReadStream"}, | ||
| 18 | {2005, nullptr, "GetAlbumMovieReadStreamBrokenReason"}, | ||
| 19 | {2006, nullptr, "GetAlbumMovieReadStreamImageDataSize"}, | ||
| 20 | {2007, nullptr, "ReadImageDataFromAlbumMovieReadStream"}, | ||
| 21 | {2008, nullptr, "ReadFileAttributeFromAlbumMovieReadStream"}, | ||
| 22 | }; | ||
| 23 | // clang-format on | ||
| 24 | |||
| 25 | RegisterHandlers(functions); | ||
| 26 | } | ||
| 27 | }; | ||
| 28 | |||
| 29 | CAPS_A::CAPS_A(Core::System& system_) : ServiceFramework{system_, "caps:a"} { | ||
| 30 | // clang-format off | 16 | // clang-format off |
| 31 | static const FunctionInfo functions[] = { | 17 | static const FunctionInfo functions[] = { |
| 32 | {0, nullptr, "GetAlbumFileCount"}, | 18 | {0, nullptr, "GetAlbumFileCount"}, |
| 33 | {1, nullptr, "GetAlbumFileList"}, | 19 | {1, nullptr, "GetAlbumFileList"}, |
| 34 | {2, nullptr, "LoadAlbumFile"}, | 20 | {2, nullptr, "LoadAlbumFile"}, |
| 35 | {3, nullptr, "DeleteAlbumFile"}, | 21 | {3, &IAlbumAccessorService::DeleteAlbumFile, "DeleteAlbumFile"}, |
| 36 | {4, nullptr, "StorageCopyAlbumFile"}, | 22 | {4, nullptr, "StorageCopyAlbumFile"}, |
| 37 | {5, nullptr, "IsAlbumMounted"}, | 23 | {5, &IAlbumAccessorService::IsAlbumMounted, "IsAlbumMounted"}, |
| 38 | {6, nullptr, "GetAlbumUsage"}, | 24 | {6, nullptr, "GetAlbumUsage"}, |
| 39 | {7, nullptr, "GetAlbumFileSize"}, | 25 | {7, nullptr, "GetAlbumFileSize"}, |
| 40 | {8, nullptr, "LoadAlbumFileThumbnail"}, | 26 | {8, nullptr, "LoadAlbumFileThumbnail"}, |
| @@ -47,18 +33,18 @@ CAPS_A::CAPS_A(Core::System& system_) : ServiceFramework{system_, "caps:a"} { | |||
| 47 | {15, nullptr, "GetAlbumUsage3"}, | 33 | {15, nullptr, "GetAlbumUsage3"}, |
| 48 | {16, nullptr, "GetAlbumMountResult"}, | 34 | {16, nullptr, "GetAlbumMountResult"}, |
| 49 | {17, nullptr, "GetAlbumUsage16"}, | 35 | {17, nullptr, "GetAlbumUsage16"}, |
| 50 | {18, nullptr, "Unknown18"}, | 36 | {18, &IAlbumAccessorService::Unknown18, "Unknown18"}, |
| 51 | {19, nullptr, "Unknown19"}, | 37 | {19, nullptr, "Unknown19"}, |
| 52 | {100, nullptr, "GetAlbumFileCountEx0"}, | 38 | {100, nullptr, "GetAlbumFileCountEx0"}, |
| 53 | {101, nullptr, "GetAlbumFileListEx0"}, | 39 | {101, &IAlbumAccessorService::GetAlbumFileListEx0, "GetAlbumFileListEx0"}, |
| 54 | {202, nullptr, "SaveEditedScreenShot"}, | 40 | {202, nullptr, "SaveEditedScreenShot"}, |
| 55 | {301, nullptr, "GetLastThumbnail"}, | 41 | {301, nullptr, "GetLastThumbnail"}, |
| 56 | {302, nullptr, "GetLastOverlayMovieThumbnail"}, | 42 | {302, nullptr, "GetLastOverlayMovieThumbnail"}, |
| 57 | {401, nullptr, "GetAutoSavingStorage"}, | 43 | {401, &IAlbumAccessorService::GetAutoSavingStorage, "GetAutoSavingStorage"}, |
| 58 | {501, nullptr, "GetRequiredStorageSpaceSizeToCopyAll"}, | 44 | {501, nullptr, "GetRequiredStorageSpaceSizeToCopyAll"}, |
| 59 | {1001, nullptr, "LoadAlbumScreenShotThumbnailImageEx0"}, | 45 | {1001, nullptr, "LoadAlbumScreenShotThumbnailImageEx0"}, |
| 60 | {1002, nullptr, "LoadAlbumScreenShotImageEx1"}, | 46 | {1002, &IAlbumAccessorService::LoadAlbumScreenShotImageEx1, "LoadAlbumScreenShotImageEx1"}, |
| 61 | {1003, nullptr, "LoadAlbumScreenShotThumbnailImageEx1"}, | 47 | {1003, &IAlbumAccessorService::LoadAlbumScreenShotThumbnailImageEx1, "LoadAlbumScreenShotThumbnailImageEx1"}, |
| 62 | {8001, nullptr, "ForceAlbumUnmounted"}, | 48 | {8001, nullptr, "ForceAlbumUnmounted"}, |
| 63 | {8002, nullptr, "ResetAlbumMountStatus"}, | 49 | {8002, nullptr, "ResetAlbumMountStatus"}, |
| 64 | {8011, nullptr, "RefreshAlbumCache"}, | 50 | {8011, nullptr, "RefreshAlbumCache"}, |
| @@ -74,6 +60,199 @@ CAPS_A::CAPS_A(Core::System& system_) : ServiceFramework{system_, "caps:a"} { | |||
| 74 | RegisterHandlers(functions); | 60 | RegisterHandlers(functions); |
| 75 | } | 61 | } |
| 76 | 62 | ||
| 77 | CAPS_A::~CAPS_A() = default; | 63 | IAlbumAccessorService::~IAlbumAccessorService() = default; |
| 64 | |||
| 65 | void IAlbumAccessorService::DeleteAlbumFile(HLERequestContext& ctx) { | ||
| 66 | IPC::RequestParser rp{ctx}; | ||
| 67 | const auto file_id{rp.PopRaw<AlbumFileId>()}; | ||
| 68 | |||
| 69 | LOG_INFO(Service_Capture, "called, application_id=0x{:0x}, storage={}, type={}", | ||
| 70 | file_id.application_id, file_id.storage, file_id.type); | ||
| 71 | |||
| 72 | Result result = manager->DeleteAlbumFile(file_id); | ||
| 73 | result = TranslateResult(result); | ||
| 74 | |||
| 75 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 76 | rb.Push(result); | ||
| 77 | } | ||
| 78 | |||
| 79 | void IAlbumAccessorService::IsAlbumMounted(HLERequestContext& ctx) { | ||
| 80 | IPC::RequestParser rp{ctx}; | ||
| 81 | const auto storage{rp.PopEnum<AlbumStorage>()}; | ||
| 82 | |||
| 83 | LOG_INFO(Service_Capture, "called, storage={}", storage); | ||
| 84 | |||
| 85 | Result result = manager->IsAlbumMounted(storage); | ||
| 86 | const bool is_mounted = result.IsSuccess(); | ||
| 87 | result = TranslateResult(result); | ||
| 88 | |||
| 89 | IPC::ResponseBuilder rb{ctx, 3}; | ||
| 90 | rb.Push(result); | ||
| 91 | rb.Push<u8>(is_mounted); | ||
| 92 | } | ||
| 93 | |||
| 94 | void IAlbumAccessorService::Unknown18(HLERequestContext& ctx) { | ||
| 95 | struct UnknownBuffer { | ||
| 96 | INSERT_PADDING_BYTES(0x10); | ||
| 97 | }; | ||
| 98 | static_assert(sizeof(UnknownBuffer) == 0x10, "UnknownBuffer is an invalid size"); | ||
| 99 | |||
| 100 | LOG_WARNING(Service_Capture, "(STUBBED) called"); | ||
| 101 | |||
| 102 | std::vector<UnknownBuffer> buffer{}; | ||
| 103 | |||
| 104 | if (!buffer.empty()) { | ||
| 105 | ctx.WriteBuffer(buffer); | ||
| 106 | } | ||
| 107 | |||
| 108 | IPC::ResponseBuilder rb{ctx, 3}; | ||
| 109 | rb.Push(ResultSuccess); | ||
| 110 | rb.Push(static_cast<u32>(buffer.size())); | ||
| 111 | } | ||
| 112 | |||
| 113 | void IAlbumAccessorService::GetAlbumFileListEx0(HLERequestContext& ctx) { | ||
| 114 | IPC::RequestParser rp{ctx}; | ||
| 115 | const auto storage{rp.PopEnum<AlbumStorage>()}; | ||
| 116 | const auto flags{rp.Pop<u8>()}; | ||
| 117 | const auto album_entry_size{ctx.GetWriteBufferNumElements<AlbumEntry>()}; | ||
| 118 | |||
| 119 | LOG_INFO(Service_Capture, "called, storage={}, flags={}", storage, flags); | ||
| 120 | |||
| 121 | std::vector<AlbumEntry> entries; | ||
| 122 | Result result = manager->GetAlbumFileList(entries, storage, flags); | ||
| 123 | result = TranslateResult(result); | ||
| 124 | |||
| 125 | entries.resize(std::min(album_entry_size, entries.size())); | ||
| 126 | |||
| 127 | if (!entries.empty()) { | ||
| 128 | ctx.WriteBuffer(entries); | ||
| 129 | } | ||
| 130 | |||
| 131 | IPC::ResponseBuilder rb{ctx, 4}; | ||
| 132 | rb.Push(result); | ||
| 133 | rb.Push<u64>(entries.size()); | ||
| 134 | } | ||
| 135 | |||
| 136 | void IAlbumAccessorService::GetAutoSavingStorage(HLERequestContext& ctx) { | ||
| 137 | LOG_WARNING(Service_Capture, "(STUBBED) called"); | ||
| 138 | |||
| 139 | bool is_autosaving{}; | ||
| 140 | Result result = manager->GetAutoSavingStorage(is_autosaving); | ||
| 141 | result = TranslateResult(result); | ||
| 142 | |||
| 143 | IPC::ResponseBuilder rb{ctx, 3}; | ||
| 144 | rb.Push(result); | ||
| 145 | rb.Push<u8>(is_autosaving); | ||
| 146 | } | ||
| 147 | |||
| 148 | void IAlbumAccessorService::LoadAlbumScreenShotImageEx1(HLERequestContext& ctx) { | ||
| 149 | IPC::RequestParser rp{ctx}; | ||
| 150 | const auto file_id{rp.PopRaw<AlbumFileId>()}; | ||
| 151 | const auto decoder_options{rp.PopRaw<ScreenShotDecodeOption>()}; | ||
| 152 | const auto image_buffer_size{ctx.GetWriteBufferSize(1)}; | ||
| 153 | |||
| 154 | LOG_INFO(Service_Capture, "called, application_id=0x{:0x}, storage={}, type={}, flags={}", | ||
| 155 | file_id.application_id, file_id.storage, file_id.type, decoder_options.flags); | ||
| 156 | |||
| 157 | std::vector<u8> image; | ||
| 158 | LoadAlbumScreenShotImageOutput image_output; | ||
| 159 | Result result = | ||
| 160 | manager->LoadAlbumScreenShotImage(image_output, image, file_id, decoder_options); | ||
| 161 | result = TranslateResult(result); | ||
| 162 | |||
| 163 | if (image.size() > image_buffer_size) { | ||
| 164 | result = ResultWorkMemoryError; | ||
| 165 | } | ||
| 166 | |||
| 167 | if (result.IsSuccess()) { | ||
| 168 | ctx.WriteBuffer(image_output, 0); | ||
| 169 | ctx.WriteBuffer(image, 1); | ||
| 170 | } | ||
| 171 | |||
| 172 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 173 | rb.Push(result); | ||
| 174 | } | ||
| 175 | |||
| 176 | void IAlbumAccessorService::LoadAlbumScreenShotThumbnailImageEx1(HLERequestContext& ctx) { | ||
| 177 | IPC::RequestParser rp{ctx}; | ||
| 178 | const auto file_id{rp.PopRaw<AlbumFileId>()}; | ||
| 179 | const auto decoder_options{rp.PopRaw<ScreenShotDecodeOption>()}; | ||
| 180 | |||
| 181 | LOG_INFO(Service_Capture, "called, application_id=0x{:0x}, storage={}, type={}, flags={}", | ||
| 182 | file_id.application_id, file_id.storage, file_id.type, decoder_options.flags); | ||
| 183 | |||
| 184 | std::vector<u8> image(ctx.GetWriteBufferSize(1)); | ||
| 185 | LoadAlbumScreenShotImageOutput image_output; | ||
| 186 | Result result = | ||
| 187 | manager->LoadAlbumScreenShotThumbnail(image_output, image, file_id, decoder_options); | ||
| 188 | result = TranslateResult(result); | ||
| 189 | |||
| 190 | if (result.IsSuccess()) { | ||
| 191 | ctx.WriteBuffer(image_output, 0); | ||
| 192 | ctx.WriteBuffer(image, 1); | ||
| 193 | } | ||
| 194 | |||
| 195 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 196 | rb.Push(result); | ||
| 197 | } | ||
| 198 | |||
| 199 | Result IAlbumAccessorService::TranslateResult(Result in_result) { | ||
| 200 | if (in_result.IsSuccess()) { | ||
| 201 | return in_result; | ||
| 202 | } | ||
| 203 | |||
| 204 | if ((in_result.raw & 0x3801ff) == ResultUnknown1024.raw) { | ||
| 205 | if (in_result.description - 0x514 < 100) { | ||
| 206 | return ResultInvalidFileData; | ||
| 207 | } | ||
| 208 | if (in_result.description - 0x5dc < 100) { | ||
| 209 | return ResultInvalidFileData; | ||
| 210 | } | ||
| 211 | |||
| 212 | if (in_result.description - 0x578 < 100) { | ||
| 213 | if (in_result == ResultFileCountLimit) { | ||
| 214 | return ResultUnknown22; | ||
| 215 | } | ||
| 216 | return ResultUnknown25; | ||
| 217 | } | ||
| 218 | |||
| 219 | if (in_result.raw < ResultUnknown1801.raw) { | ||
| 220 | if (in_result == ResultUnknown1202) { | ||
| 221 | return ResultUnknown810; | ||
| 222 | } | ||
| 223 | if (in_result == ResultUnknown1203) { | ||
| 224 | return ResultUnknown810; | ||
| 225 | } | ||
| 226 | if (in_result == ResultUnknown1701) { | ||
| 227 | return ResultUnknown5; | ||
| 228 | } | ||
| 229 | } else if (in_result.raw < ResultUnknown1803.raw) { | ||
| 230 | if (in_result == ResultUnknown1801) { | ||
| 231 | return ResultUnknown5; | ||
| 232 | } | ||
| 233 | if (in_result == ResultUnknown1802) { | ||
| 234 | return ResultUnknown6; | ||
| 235 | } | ||
| 236 | } else { | ||
| 237 | if (in_result == ResultUnknown1803) { | ||
| 238 | return ResultUnknown7; | ||
| 239 | } | ||
| 240 | if (in_result == ResultUnknown1804) { | ||
| 241 | return ResultOutOfRange; | ||
| 242 | } | ||
| 243 | } | ||
| 244 | return ResultUnknown1024; | ||
| 245 | } | ||
| 246 | |||
| 247 | if (in_result.module == ErrorModule::FS) { | ||
| 248 | if ((in_result.description >> 0xc < 0x7d) || (in_result.description - 1000 < 2000) || | ||
| 249 | (((in_result.description - 3000) >> 3) < 0x271)) { | ||
| 250 | // TODO: Translate FS error | ||
| 251 | return in_result; | ||
| 252 | } | ||
| 253 | } | ||
| 254 | |||
| 255 | return in_result; | ||
| 256 | } | ||
| 78 | 257 | ||
| 79 | } // namespace Service::Capture | 258 | } // namespace Service::Capture |
diff --git a/src/core/hle/service/caps/caps_a.h b/src/core/hle/service/caps/caps_a.h index 98a21a5ad..c90cff71e 100644 --- a/src/core/hle/service/caps/caps_a.h +++ b/src/core/hle/service/caps/caps_a.h | |||
| @@ -10,11 +10,26 @@ class System; | |||
| 10 | } | 10 | } |
| 11 | 11 | ||
| 12 | namespace Service::Capture { | 12 | namespace Service::Capture { |
| 13 | class AlbumManager; | ||
| 13 | 14 | ||
| 14 | class CAPS_A final : public ServiceFramework<CAPS_A> { | 15 | class IAlbumAccessorService final : public ServiceFramework<IAlbumAccessorService> { |
| 15 | public: | 16 | public: |
| 16 | explicit CAPS_A(Core::System& system_); | 17 | explicit IAlbumAccessorService(Core::System& system_, |
| 17 | ~CAPS_A() override; | 18 | std::shared_ptr<AlbumManager> album_manager); |
| 19 | ~IAlbumAccessorService() override; | ||
| 20 | |||
| 21 | private: | ||
| 22 | void DeleteAlbumFile(HLERequestContext& ctx); | ||
| 23 | void IsAlbumMounted(HLERequestContext& ctx); | ||
| 24 | void Unknown18(HLERequestContext& ctx); | ||
| 25 | void GetAlbumFileListEx0(HLERequestContext& ctx); | ||
| 26 | void GetAutoSavingStorage(HLERequestContext& ctx); | ||
| 27 | void LoadAlbumScreenShotImageEx1(HLERequestContext& ctx); | ||
| 28 | void LoadAlbumScreenShotThumbnailImageEx1(HLERequestContext& ctx); | ||
| 29 | |||
| 30 | Result TranslateResult(Result in_result); | ||
| 31 | |||
| 32 | std::shared_ptr<AlbumManager> manager = nullptr; | ||
| 18 | }; | 33 | }; |
| 19 | 34 | ||
| 20 | } // namespace Service::Capture | 35 | } // namespace Service::Capture |
diff --git a/src/core/hle/service/caps/caps_c.cpp b/src/core/hle/service/caps/caps_c.cpp index fc77e35cd..1e7fe6474 100644 --- a/src/core/hle/service/caps/caps_c.cpp +++ b/src/core/hle/service/caps/caps_c.cpp | |||
| @@ -3,53 +3,21 @@ | |||
| 3 | 3 | ||
| 4 | #include "common/logging/log.h" | 4 | #include "common/logging/log.h" |
| 5 | #include "core/hle/service/caps/caps_c.h" | 5 | #include "core/hle/service/caps/caps_c.h" |
| 6 | #include "core/hle/service/caps/caps_manager.h" | ||
| 7 | #include "core/hle/service/caps/caps_result.h" | ||
| 8 | #include "core/hle/service/caps/caps_types.h" | ||
| 6 | #include "core/hle/service/ipc_helpers.h" | 9 | #include "core/hle/service/ipc_helpers.h" |
| 7 | 10 | ||
| 8 | namespace Service::Capture { | 11 | namespace Service::Capture { |
| 9 | 12 | ||
| 10 | class IAlbumControlSession final : public ServiceFramework<IAlbumControlSession> { | 13 | IAlbumControlService::IAlbumControlService(Core::System& system_, |
| 11 | public: | 14 | std::shared_ptr<AlbumManager> album_manager) |
| 12 | explicit IAlbumControlSession(Core::System& system_) | 15 | : ServiceFramework{system_, "caps:c"}, manager{album_manager} { |
| 13 | : ServiceFramework{system_, "IAlbumControlSession"} { | ||
| 14 | // clang-format off | ||
| 15 | static const FunctionInfo functions[] = { | ||
| 16 | {2001, nullptr, "OpenAlbumMovieReadStream"}, | ||
| 17 | {2002, nullptr, "CloseAlbumMovieReadStream"}, | ||
| 18 | {2003, nullptr, "GetAlbumMovieReadStreamMovieDataSize"}, | ||
| 19 | {2004, nullptr, "ReadMovieDataFromAlbumMovieReadStream"}, | ||
| 20 | {2005, nullptr, "GetAlbumMovieReadStreamBrokenReason"}, | ||
| 21 | {2006, nullptr, "GetAlbumMovieReadStreamImageDataSize"}, | ||
| 22 | {2007, nullptr, "ReadImageDataFromAlbumMovieReadStream"}, | ||
| 23 | {2008, nullptr, "ReadFileAttributeFromAlbumMovieReadStream"}, | ||
| 24 | {2401, nullptr, "OpenAlbumMovieWriteStream"}, | ||
| 25 | {2402, nullptr, "FinishAlbumMovieWriteStream"}, | ||
| 26 | {2403, nullptr, "CommitAlbumMovieWriteStream"}, | ||
| 27 | {2404, nullptr, "DiscardAlbumMovieWriteStream"}, | ||
| 28 | {2405, nullptr, "DiscardAlbumMovieWriteStreamNoDelete"}, | ||
| 29 | {2406, nullptr, "CommitAlbumMovieWriteStreamEx"}, | ||
| 30 | {2411, nullptr, "StartAlbumMovieWriteStreamDataSection"}, | ||
| 31 | {2412, nullptr, "EndAlbumMovieWriteStreamDataSection"}, | ||
| 32 | {2413, nullptr, "StartAlbumMovieWriteStreamMetaSection"}, | ||
| 33 | {2414, nullptr, "EndAlbumMovieWriteStreamMetaSection"}, | ||
| 34 | {2421, nullptr, "ReadDataFromAlbumMovieWriteStream"}, | ||
| 35 | {2422, nullptr, "WriteDataToAlbumMovieWriteStream"}, | ||
| 36 | {2424, nullptr, "WriteMetaToAlbumMovieWriteStream"}, | ||
| 37 | {2431, nullptr, "GetAlbumMovieWriteStreamBrokenReason"}, | ||
| 38 | {2433, nullptr, "GetAlbumMovieWriteStreamDataSize"}, | ||
| 39 | {2434, nullptr, "SetAlbumMovieWriteStreamDataSize"}, | ||
| 40 | }; | ||
| 41 | // clang-format on | ||
| 42 | |||
| 43 | RegisterHandlers(functions); | ||
| 44 | } | ||
| 45 | }; | ||
| 46 | |||
| 47 | CAPS_C::CAPS_C(Core::System& system_) : ServiceFramework{system_, "caps:c"} { | ||
| 48 | // clang-format off | 16 | // clang-format off |
| 49 | static const FunctionInfo functions[] = { | 17 | static const FunctionInfo functions[] = { |
| 50 | {1, nullptr, "CaptureRawImage"}, | 18 | {1, nullptr, "CaptureRawImage"}, |
| 51 | {2, nullptr, "CaptureRawImageWithTimeout"}, | 19 | {2, nullptr, "CaptureRawImageWithTimeout"}, |
| 52 | {33, &CAPS_C::SetShimLibraryVersion, "SetShimLibraryVersion"}, | 20 | {33, &IAlbumControlService::SetShimLibraryVersion, "SetShimLibraryVersion"}, |
| 53 | {1001, nullptr, "RequestTakingScreenShot"}, | 21 | {1001, nullptr, "RequestTakingScreenShot"}, |
| 54 | {1002, nullptr, "RequestTakingScreenShotWithTimeout"}, | 22 | {1002, nullptr, "RequestTakingScreenShotWithTimeout"}, |
| 55 | {1011, nullptr, "NotifyTakingScreenShotRefused"}, | 23 | {1011, nullptr, "NotifyTakingScreenShotRefused"}, |
| @@ -72,9 +40,9 @@ CAPS_C::CAPS_C(Core::System& system_) : ServiceFramework{system_, "caps:c"} { | |||
| 72 | RegisterHandlers(functions); | 40 | RegisterHandlers(functions); |
| 73 | } | 41 | } |
| 74 | 42 | ||
| 75 | CAPS_C::~CAPS_C() = default; | 43 | IAlbumControlService::~IAlbumControlService() = default; |
| 76 | 44 | ||
| 77 | void CAPS_C::SetShimLibraryVersion(HLERequestContext& ctx) { | 45 | void IAlbumControlService::SetShimLibraryVersion(HLERequestContext& ctx) { |
| 78 | IPC::RequestParser rp{ctx}; | 46 | IPC::RequestParser rp{ctx}; |
| 79 | const auto library_version{rp.Pop<u64>()}; | 47 | const auto library_version{rp.Pop<u64>()}; |
| 80 | const auto applet_resource_user_id{rp.Pop<u64>()}; | 48 | const auto applet_resource_user_id{rp.Pop<u64>()}; |
diff --git a/src/core/hle/service/caps/caps_c.h b/src/core/hle/service/caps/caps_c.h index 537b3a2e3..92ba242db 100644 --- a/src/core/hle/service/caps/caps_c.h +++ b/src/core/hle/service/caps/caps_c.h | |||
| @@ -10,14 +10,18 @@ class System; | |||
| 10 | } | 10 | } |
| 11 | 11 | ||
| 12 | namespace Service::Capture { | 12 | namespace Service::Capture { |
| 13 | class AlbumManager; | ||
| 13 | 14 | ||
| 14 | class CAPS_C final : public ServiceFramework<CAPS_C> { | 15 | class IAlbumControlService final : public ServiceFramework<IAlbumControlService> { |
| 15 | public: | 16 | public: |
| 16 | explicit CAPS_C(Core::System& system_); | 17 | explicit IAlbumControlService(Core::System& system_, |
| 17 | ~CAPS_C() override; | 18 | std::shared_ptr<AlbumManager> album_manager); |
| 19 | ~IAlbumControlService() override; | ||
| 18 | 20 | ||
| 19 | private: | 21 | private: |
| 20 | void SetShimLibraryVersion(HLERequestContext& ctx); | 22 | void SetShimLibraryVersion(HLERequestContext& ctx); |
| 23 | |||
| 24 | std::shared_ptr<AlbumManager> manager = nullptr; | ||
| 21 | }; | 25 | }; |
| 22 | 26 | ||
| 23 | } // namespace Service::Capture | 27 | } // namespace Service::Capture |
diff --git a/src/core/hle/service/caps/caps_manager.cpp b/src/core/hle/service/caps/caps_manager.cpp new file mode 100644 index 000000000..7d733eb54 --- /dev/null +++ b/src/core/hle/service/caps/caps_manager.cpp | |||
| @@ -0,0 +1,469 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #include <sstream> | ||
| 5 | |||
| 6 | #include "common/fs/file.h" | ||
| 7 | #include "common/fs/path_util.h" | ||
| 8 | #include "common/logging/log.h" | ||
| 9 | #include "common/stb.h" | ||
| 10 | #include "core/core.h" | ||
| 11 | #include "core/hle/service/caps/caps_manager.h" | ||
| 12 | #include "core/hle/service/caps/caps_result.h" | ||
| 13 | #include "core/hle/service/time/time_manager.h" | ||
| 14 | #include "core/hle/service/time/time_zone_content_manager.h" | ||
| 15 | |||
| 16 | namespace Service::Capture { | ||
| 17 | |||
| 18 | AlbumManager::AlbumManager(Core::System& system_) : system{system_} {} | ||
| 19 | |||
| 20 | AlbumManager::~AlbumManager() = default; | ||
| 21 | |||
| 22 | Result AlbumManager::DeleteAlbumFile(const AlbumFileId& file_id) { | ||
| 23 | if (file_id.storage > AlbumStorage::Sd) { | ||
| 24 | return ResultInvalidStorage; | ||
| 25 | } | ||
| 26 | |||
| 27 | if (!is_mounted) { | ||
| 28 | return ResultIsNotMounted; | ||
| 29 | } | ||
| 30 | |||
| 31 | std::filesystem::path path; | ||
| 32 | const auto result = GetFile(path, file_id); | ||
| 33 | |||
| 34 | if (result.IsError()) { | ||
| 35 | return result; | ||
| 36 | } | ||
| 37 | |||
| 38 | if (!Common::FS::RemoveFile(path)) { | ||
| 39 | return ResultFileNotFound; | ||
| 40 | } | ||
| 41 | |||
| 42 | return ResultSuccess; | ||
| 43 | } | ||
| 44 | |||
| 45 | Result AlbumManager::IsAlbumMounted(AlbumStorage storage) { | ||
| 46 | if (storage > AlbumStorage::Sd) { | ||
| 47 | return ResultInvalidStorage; | ||
| 48 | } | ||
| 49 | |||
| 50 | is_mounted = true; | ||
| 51 | |||
| 52 | if (storage == AlbumStorage::Sd) { | ||
| 53 | FindScreenshots(); | ||
| 54 | } | ||
| 55 | |||
| 56 | return is_mounted ? ResultSuccess : ResultIsNotMounted; | ||
| 57 | } | ||
| 58 | |||
| 59 | Result AlbumManager::GetAlbumFileList(std::vector<AlbumEntry>& out_entries, AlbumStorage storage, | ||
| 60 | u8 flags) const { | ||
| 61 | if (storage > AlbumStorage::Sd) { | ||
| 62 | return ResultInvalidStorage; | ||
| 63 | } | ||
| 64 | |||
| 65 | if (!is_mounted) { | ||
| 66 | return ResultIsNotMounted; | ||
| 67 | } | ||
| 68 | |||
| 69 | for (auto& [file_id, path] : album_files) { | ||
| 70 | if (file_id.storage != storage) { | ||
| 71 | continue; | ||
| 72 | } | ||
| 73 | if (out_entries.size() >= SdAlbumFileLimit) { | ||
| 74 | break; | ||
| 75 | } | ||
| 76 | |||
| 77 | const auto entry_size = Common::FS::GetSize(path); | ||
| 78 | out_entries.push_back({ | ||
| 79 | .entry_size = entry_size, | ||
| 80 | .file_id = file_id, | ||
| 81 | }); | ||
| 82 | } | ||
| 83 | |||
| 84 | return ResultSuccess; | ||
| 85 | } | ||
| 86 | |||
| 87 | Result AlbumManager::GetAlbumFileList(std::vector<ApplicationAlbumFileEntry>& out_entries, | ||
| 88 | ContentType contex_type, s64 start_posix_time, | ||
| 89 | s64 end_posix_time, u64 aruid) const { | ||
| 90 | if (!is_mounted) { | ||
| 91 | return ResultIsNotMounted; | ||
| 92 | } | ||
| 93 | |||
| 94 | std::vector<ApplicationAlbumEntry> album_entries; | ||
| 95 | const auto start_date = ConvertToAlbumDateTime(start_posix_time); | ||
| 96 | const auto end_date = ConvertToAlbumDateTime(end_posix_time); | ||
| 97 | const auto result = GetAlbumFileList(album_entries, contex_type, start_date, end_date, aruid); | ||
| 98 | |||
| 99 | if (result.IsError()) { | ||
| 100 | return result; | ||
| 101 | } | ||
| 102 | |||
| 103 | for (const auto& album_entry : album_entries) { | ||
| 104 | ApplicationAlbumFileEntry entry{ | ||
| 105 | .entry = album_entry, | ||
| 106 | .datetime = album_entry.datetime, | ||
| 107 | .unknown = {}, | ||
| 108 | }; | ||
| 109 | out_entries.push_back(entry); | ||
| 110 | } | ||
| 111 | |||
| 112 | return ResultSuccess; | ||
| 113 | } | ||
| 114 | |||
| 115 | Result AlbumManager::GetAlbumFileList(std::vector<ApplicationAlbumEntry>& out_entries, | ||
| 116 | ContentType contex_type, AlbumFileDateTime start_date, | ||
| 117 | AlbumFileDateTime end_date, u64 aruid) const { | ||
| 118 | if (!is_mounted) { | ||
| 119 | return ResultIsNotMounted; | ||
| 120 | } | ||
| 121 | |||
| 122 | for (auto& [file_id, path] : album_files) { | ||
| 123 | if (file_id.type != contex_type) { | ||
| 124 | continue; | ||
| 125 | } | ||
| 126 | if (file_id.date > start_date) { | ||
| 127 | continue; | ||
| 128 | } | ||
| 129 | if (file_id.date < end_date) { | ||
| 130 | continue; | ||
| 131 | } | ||
| 132 | if (out_entries.size() >= SdAlbumFileLimit) { | ||
| 133 | break; | ||
| 134 | } | ||
| 135 | |||
| 136 | const auto entry_size = Common::FS::GetSize(path); | ||
| 137 | ApplicationAlbumEntry entry{ | ||
| 138 | .size = entry_size, | ||
| 139 | .hash{}, | ||
| 140 | .datetime = file_id.date, | ||
| 141 | .storage = file_id.storage, | ||
| 142 | .content = contex_type, | ||
| 143 | .unknown = 1, | ||
| 144 | }; | ||
| 145 | out_entries.push_back(entry); | ||
| 146 | } | ||
| 147 | |||
| 148 | return ResultSuccess; | ||
| 149 | } | ||
| 150 | |||
| 151 | Result AlbumManager::GetAutoSavingStorage(bool& out_is_autosaving) const { | ||
| 152 | out_is_autosaving = false; | ||
| 153 | return ResultSuccess; | ||
| 154 | } | ||
| 155 | |||
| 156 | Result AlbumManager::LoadAlbumScreenShotImage(LoadAlbumScreenShotImageOutput& out_image_output, | ||
| 157 | std::vector<u8>& out_image, | ||
| 158 | const AlbumFileId& file_id, | ||
| 159 | const ScreenShotDecodeOption& decoder_options) const { | ||
| 160 | if (file_id.storage > AlbumStorage::Sd) { | ||
| 161 | return ResultInvalidStorage; | ||
| 162 | } | ||
| 163 | |||
| 164 | if (!is_mounted) { | ||
| 165 | return ResultIsNotMounted; | ||
| 166 | } | ||
| 167 | |||
| 168 | out_image_output = { | ||
| 169 | .width = 1280, | ||
| 170 | .height = 720, | ||
| 171 | .attribute = | ||
| 172 | { | ||
| 173 | .unknown_0{}, | ||
| 174 | .orientation = AlbumImageOrientation::None, | ||
| 175 | .unknown_1{}, | ||
| 176 | .unknown_2{}, | ||
| 177 | }, | ||
| 178 | }; | ||
| 179 | |||
| 180 | std::filesystem::path path; | ||
| 181 | const auto result = GetFile(path, file_id); | ||
| 182 | |||
| 183 | if (result.IsError()) { | ||
| 184 | return result; | ||
| 185 | } | ||
| 186 | |||
| 187 | out_image.resize(out_image_output.height * out_image_output.width * STBI_rgb_alpha); | ||
| 188 | |||
| 189 | return LoadImage(out_image, path, static_cast<int>(out_image_output.width), | ||
| 190 | +static_cast<int>(out_image_output.height), decoder_options.flags); | ||
| 191 | } | ||
| 192 | |||
| 193 | Result AlbumManager::LoadAlbumScreenShotThumbnail( | ||
| 194 | LoadAlbumScreenShotImageOutput& out_image_output, std::vector<u8>& out_image, | ||
| 195 | const AlbumFileId& file_id, const ScreenShotDecodeOption& decoder_options) const { | ||
| 196 | if (file_id.storage > AlbumStorage::Sd) { | ||
| 197 | return ResultInvalidStorage; | ||
| 198 | } | ||
| 199 | |||
| 200 | if (!is_mounted) { | ||
| 201 | return ResultIsNotMounted; | ||
| 202 | } | ||
| 203 | |||
| 204 | out_image_output = { | ||
| 205 | .width = 320, | ||
| 206 | .height = 180, | ||
| 207 | .attribute = | ||
| 208 | { | ||
| 209 | .unknown_0{}, | ||
| 210 | .orientation = AlbumImageOrientation::None, | ||
| 211 | .unknown_1{}, | ||
| 212 | .unknown_2{}, | ||
| 213 | }, | ||
| 214 | }; | ||
| 215 | |||
| 216 | std::filesystem::path path; | ||
| 217 | const auto result = GetFile(path, file_id); | ||
| 218 | |||
| 219 | if (result.IsError()) { | ||
| 220 | return result; | ||
| 221 | } | ||
| 222 | |||
| 223 | out_image.resize(out_image_output.height * out_image_output.width * STBI_rgb_alpha); | ||
| 224 | |||
| 225 | return LoadImage(out_image, path, static_cast<int>(out_image_output.width), | ||
| 226 | +static_cast<int>(out_image_output.height), decoder_options.flags); | ||
| 227 | } | ||
| 228 | |||
| 229 | Result AlbumManager::SaveScreenShot(ApplicationAlbumEntry& out_entry, | ||
| 230 | const ScreenShotAttribute& attribute, | ||
| 231 | std::span<const u8> image_data, u64 aruid) { | ||
| 232 | return SaveScreenShot(out_entry, attribute, {}, image_data, aruid); | ||
| 233 | } | ||
| 234 | |||
| 235 | Result AlbumManager::SaveScreenShot(ApplicationAlbumEntry& out_entry, | ||
| 236 | const ScreenShotAttribute& attribute, | ||
| 237 | const ApplicationData& app_data, std::span<const u8> image_data, | ||
| 238 | u64 aruid) { | ||
| 239 | const u64 title_id = system.GetApplicationProcessProgramID(); | ||
| 240 | const auto& user_clock = system.GetTimeManager().GetStandardUserSystemClockCore(); | ||
| 241 | |||
| 242 | s64 posix_time{}; | ||
| 243 | Result result = user_clock.GetCurrentTime(system, posix_time); | ||
| 244 | |||
| 245 | if (result.IsError()) { | ||
| 246 | return result; | ||
| 247 | } | ||
| 248 | |||
| 249 | const auto date = ConvertToAlbumDateTime(posix_time); | ||
| 250 | |||
| 251 | return SaveImage(out_entry, image_data, title_id, date); | ||
| 252 | } | ||
| 253 | |||
| 254 | Result AlbumManager::SaveEditedScreenShot(ApplicationAlbumEntry& out_entry, | ||
| 255 | const ScreenShotAttribute& attribute, | ||
| 256 | const AlbumFileId& file_id, | ||
| 257 | std::span<const u8> image_data) { | ||
| 258 | const auto& user_clock = system.GetTimeManager().GetStandardUserSystemClockCore(); | ||
| 259 | |||
| 260 | s64 posix_time{}; | ||
| 261 | Result result = user_clock.GetCurrentTime(system, posix_time); | ||
| 262 | |||
| 263 | if (result.IsError()) { | ||
| 264 | return result; | ||
| 265 | } | ||
| 266 | |||
| 267 | const auto date = ConvertToAlbumDateTime(posix_time); | ||
| 268 | |||
| 269 | return SaveImage(out_entry, image_data, file_id.application_id, date); | ||
| 270 | } | ||
| 271 | |||
| 272 | Result AlbumManager::GetFile(std::filesystem::path& out_path, const AlbumFileId& file_id) const { | ||
| 273 | const auto file = album_files.find(file_id); | ||
| 274 | |||
| 275 | if (file == album_files.end()) { | ||
| 276 | return ResultFileNotFound; | ||
| 277 | } | ||
| 278 | |||
| 279 | out_path = file->second; | ||
| 280 | return ResultSuccess; | ||
| 281 | } | ||
| 282 | |||
| 283 | void AlbumManager::FindScreenshots() { | ||
| 284 | is_mounted = false; | ||
| 285 | album_files.clear(); | ||
| 286 | |||
| 287 | // TODO: Swap this with a blocking operation. | ||
| 288 | const auto screenshots_dir = Common::FS::GetYuzuPath(Common::FS::YuzuPath::ScreenshotsDir); | ||
| 289 | Common::FS::IterateDirEntries( | ||
| 290 | screenshots_dir, | ||
| 291 | [this](const std::filesystem::path& full_path) { | ||
| 292 | AlbumEntry entry; | ||
| 293 | if (GetAlbumEntry(entry, full_path).IsError()) { | ||
| 294 | return true; | ||
| 295 | } | ||
| 296 | while (album_files.contains(entry.file_id)) { | ||
| 297 | if (++entry.file_id.date.unique_id == 0) { | ||
| 298 | break; | ||
| 299 | } | ||
| 300 | } | ||
| 301 | album_files[entry.file_id] = full_path; | ||
| 302 | return true; | ||
| 303 | }, | ||
| 304 | Common::FS::DirEntryFilter::File); | ||
| 305 | |||
| 306 | is_mounted = true; | ||
| 307 | } | ||
| 308 | |||
| 309 | Result AlbumManager::GetAlbumEntry(AlbumEntry& out_entry, const std::filesystem::path& path) const { | ||
| 310 | std::istringstream line_stream(path.filename().string()); | ||
| 311 | std::string date; | ||
| 312 | std::string application; | ||
| 313 | std::string time; | ||
| 314 | |||
| 315 | // Parse filename to obtain entry properties | ||
| 316 | std::getline(line_stream, application, '_'); | ||
| 317 | std::getline(line_stream, date, '_'); | ||
| 318 | std::getline(line_stream, time, '_'); | ||
| 319 | |||
| 320 | std::istringstream date_stream(date); | ||
| 321 | std::istringstream time_stream(time); | ||
| 322 | std::string year; | ||
| 323 | std::string month; | ||
| 324 | std::string day; | ||
| 325 | std::string hour; | ||
| 326 | std::string minute; | ||
| 327 | std::string second; | ||
| 328 | |||
| 329 | std::getline(date_stream, year, '-'); | ||
| 330 | std::getline(date_stream, month, '-'); | ||
| 331 | std::getline(date_stream, day, '-'); | ||
| 332 | |||
| 333 | std::getline(time_stream, hour, '-'); | ||
| 334 | std::getline(time_stream, minute, '-'); | ||
| 335 | std::getline(time_stream, second, '-'); | ||
| 336 | |||
| 337 | try { | ||
| 338 | out_entry = { | ||
| 339 | .entry_size = 1, | ||
| 340 | .file_id{ | ||
| 341 | .application_id = static_cast<u64>(std::stoll(application, 0, 16)), | ||
| 342 | .date = | ||
| 343 | { | ||
| 344 | .year = static_cast<s16>(std::stoi(year)), | ||
| 345 | .month = static_cast<s8>(std::stoi(month)), | ||
| 346 | .day = static_cast<s8>(std::stoi(day)), | ||
| 347 | .hour = static_cast<s8>(std::stoi(hour)), | ||
| 348 | .minute = static_cast<s8>(std::stoi(minute)), | ||
| 349 | .second = static_cast<s8>(std::stoi(second)), | ||
| 350 | .unique_id = 0, | ||
| 351 | }, | ||
| 352 | .storage = AlbumStorage::Sd, | ||
| 353 | .type = ContentType::Screenshot, | ||
| 354 | .unknown = 1, | ||
| 355 | }, | ||
| 356 | }; | ||
| 357 | } catch (const std::invalid_argument&) { | ||
| 358 | return ResultUnknown; | ||
| 359 | } catch (const std::out_of_range&) { | ||
| 360 | return ResultUnknown; | ||
| 361 | } catch (const std::exception&) { | ||
| 362 | return ResultUnknown; | ||
| 363 | } | ||
| 364 | |||
| 365 | return ResultSuccess; | ||
| 366 | } | ||
| 367 | |||
| 368 | Result AlbumManager::LoadImage(std::span<u8> out_image, const std::filesystem::path& path, | ||
| 369 | int width, int height, ScreenShotDecoderFlag flag) const { | ||
| 370 | if (out_image.size() != static_cast<std::size_t>(width * height * STBI_rgb_alpha)) { | ||
| 371 | return ResultUnknown; | ||
| 372 | } | ||
| 373 | |||
| 374 | const Common::FS::IOFile db_file{path, Common::FS::FileAccessMode::Read, | ||
| 375 | Common::FS::FileType::BinaryFile}; | ||
| 376 | |||
| 377 | std::vector<u8> raw_file(db_file.GetSize()); | ||
| 378 | if (db_file.Read(raw_file) != raw_file.size()) { | ||
| 379 | return ResultUnknown; | ||
| 380 | } | ||
| 381 | |||
| 382 | int filter_flag = STBIR_FILTER_DEFAULT; | ||
| 383 | int original_width, original_height, color_channels; | ||
| 384 | const auto dbi_image = | ||
| 385 | stbi_load_from_memory(raw_file.data(), static_cast<int>(raw_file.size()), &original_width, | ||
| 386 | &original_height, &color_channels, STBI_rgb_alpha); | ||
| 387 | |||
| 388 | if (dbi_image == nullptr) { | ||
| 389 | return ResultUnknown; | ||
| 390 | } | ||
| 391 | |||
| 392 | switch (flag) { | ||
| 393 | case ScreenShotDecoderFlag::EnableFancyUpsampling: | ||
| 394 | filter_flag = STBIR_FILTER_TRIANGLE; | ||
| 395 | break; | ||
| 396 | case ScreenShotDecoderFlag::EnableBlockSmoothing: | ||
| 397 | filter_flag = STBIR_FILTER_BOX; | ||
| 398 | break; | ||
| 399 | default: | ||
| 400 | filter_flag = STBIR_FILTER_DEFAULT; | ||
| 401 | break; | ||
| 402 | } | ||
| 403 | |||
| 404 | stbir_resize_uint8_srgb(dbi_image, original_width, original_height, 0, out_image.data(), width, | ||
| 405 | height, 0, STBI_rgb_alpha, 3, filter_flag); | ||
| 406 | |||
| 407 | return ResultSuccess; | ||
| 408 | } | ||
| 409 | |||
| 410 | static void PNGToMemory(void* context, void* png, int len) { | ||
| 411 | std::vector<u8>* png_image = static_cast<std::vector<u8>*>(context); | ||
| 412 | png_image->reserve(len); | ||
| 413 | std::memcpy(png_image->data(), png, len); | ||
| 414 | } | ||
| 415 | |||
| 416 | Result AlbumManager::SaveImage(ApplicationAlbumEntry& out_entry, std::span<const u8> image, | ||
| 417 | u64 title_id, const AlbumFileDateTime& date) const { | ||
| 418 | const auto screenshot_path = | ||
| 419 | Common::FS::GetYuzuPathString(Common::FS::YuzuPath::ScreenshotsDir); | ||
| 420 | const std::string formatted_date = | ||
| 421 | fmt::format("{:04}-{:02}-{:02}_{:02}-{:02}-{:02}-{:03}", date.year, date.month, date.day, | ||
| 422 | date.hour, date.minute, date.second, 0); | ||
| 423 | const std::string file_path = | ||
| 424 | fmt::format("{}/{:016x}_{}.png", screenshot_path, title_id, formatted_date); | ||
| 425 | |||
| 426 | const Common::FS::IOFile db_file{file_path, Common::FS::FileAccessMode::Write, | ||
| 427 | Common::FS::FileType::BinaryFile}; | ||
| 428 | |||
| 429 | std::vector<u8> png_image; | ||
| 430 | if (!stbi_write_png_to_func(PNGToMemory, &png_image, 1280, 720, STBI_rgb_alpha, image.data(), | ||
| 431 | 0)) { | ||
| 432 | return ResultFileCountLimit; | ||
| 433 | } | ||
| 434 | |||
| 435 | if (db_file.Write(png_image) != png_image.size()) { | ||
| 436 | return ResultFileCountLimit; | ||
| 437 | } | ||
| 438 | |||
| 439 | out_entry = { | ||
| 440 | .size = png_image.size(), | ||
| 441 | .hash = {}, | ||
| 442 | .datetime = date, | ||
| 443 | .storage = AlbumStorage::Sd, | ||
| 444 | .content = ContentType::Screenshot, | ||
| 445 | .unknown = 1, | ||
| 446 | }; | ||
| 447 | |||
| 448 | return ResultSuccess; | ||
| 449 | } | ||
| 450 | |||
| 451 | AlbumFileDateTime AlbumManager::ConvertToAlbumDateTime(u64 posix_time) const { | ||
| 452 | Time::TimeZone::CalendarInfo calendar_date{}; | ||
| 453 | const auto& time_zone_manager = | ||
| 454 | system.GetTimeManager().GetTimeZoneContentManager().GetTimeZoneManager(); | ||
| 455 | |||
| 456 | time_zone_manager.ToCalendarTimeWithMyRules(posix_time, calendar_date); | ||
| 457 | |||
| 458 | return { | ||
| 459 | .year = calendar_date.time.year, | ||
| 460 | .month = calendar_date.time.month, | ||
| 461 | .day = calendar_date.time.day, | ||
| 462 | .hour = calendar_date.time.hour, | ||
| 463 | .minute = calendar_date.time.minute, | ||
| 464 | .second = calendar_date.time.second, | ||
| 465 | .unique_id = 0, | ||
| 466 | }; | ||
| 467 | } | ||
| 468 | |||
| 469 | } // namespace Service::Capture | ||
diff --git a/src/core/hle/service/caps/caps_manager.h b/src/core/hle/service/caps/caps_manager.h new file mode 100644 index 000000000..44d85117f --- /dev/null +++ b/src/core/hle/service/caps/caps_manager.h | |||
| @@ -0,0 +1,90 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #pragma once | ||
| 5 | |||
| 6 | #include <unordered_map> | ||
| 7 | |||
| 8 | #include "common/fs/fs.h" | ||
| 9 | #include "core/hle/result.h" | ||
| 10 | #include "core/hle/service/caps/caps_types.h" | ||
| 11 | |||
| 12 | namespace Core { | ||
| 13 | class System; | ||
| 14 | } | ||
| 15 | |||
| 16 | namespace std { | ||
| 17 | // Hash used to create lists from AlbumFileId data | ||
| 18 | template <> | ||
| 19 | struct hash<Service::Capture::AlbumFileId> { | ||
| 20 | size_t operator()(const Service::Capture::AlbumFileId& pad_id) const noexcept { | ||
| 21 | u64 hash_value = (static_cast<u64>(pad_id.date.year) << 8); | ||
| 22 | hash_value ^= (static_cast<u64>(pad_id.date.month) << 7); | ||
| 23 | hash_value ^= (static_cast<u64>(pad_id.date.day) << 6); | ||
| 24 | hash_value ^= (static_cast<u64>(pad_id.date.hour) << 5); | ||
| 25 | hash_value ^= (static_cast<u64>(pad_id.date.minute) << 4); | ||
| 26 | hash_value ^= (static_cast<u64>(pad_id.date.second) << 3); | ||
| 27 | hash_value ^= (static_cast<u64>(pad_id.date.unique_id) << 2); | ||
| 28 | hash_value ^= (static_cast<u64>(pad_id.storage) << 1); | ||
| 29 | hash_value ^= static_cast<u64>(pad_id.type); | ||
| 30 | return static_cast<size_t>(hash_value); | ||
| 31 | } | ||
| 32 | }; | ||
| 33 | |||
| 34 | } // namespace std | ||
| 35 | |||
| 36 | namespace Service::Capture { | ||
| 37 | |||
| 38 | class AlbumManager { | ||
| 39 | public: | ||
| 40 | explicit AlbumManager(Core::System& system_); | ||
| 41 | ~AlbumManager(); | ||
| 42 | |||
| 43 | Result DeleteAlbumFile(const AlbumFileId& file_id); | ||
| 44 | Result IsAlbumMounted(AlbumStorage storage); | ||
| 45 | Result GetAlbumFileList(std::vector<AlbumEntry>& out_entries, AlbumStorage storage, | ||
| 46 | u8 flags) const; | ||
| 47 | Result GetAlbumFileList(std::vector<ApplicationAlbumFileEntry>& out_entries, | ||
| 48 | ContentType contex_type, s64 start_posix_time, s64 end_posix_time, | ||
| 49 | u64 aruid) const; | ||
| 50 | Result GetAlbumFileList(std::vector<ApplicationAlbumEntry>& out_entries, | ||
| 51 | ContentType contex_type, AlbumFileDateTime start_date, | ||
| 52 | AlbumFileDateTime end_date, u64 aruid) const; | ||
| 53 | Result GetAutoSavingStorage(bool& out_is_autosaving) const; | ||
| 54 | Result LoadAlbumScreenShotImage(LoadAlbumScreenShotImageOutput& out_image_output, | ||
| 55 | std::vector<u8>& out_image, const AlbumFileId& file_id, | ||
| 56 | const ScreenShotDecodeOption& decoder_options) const; | ||
| 57 | Result LoadAlbumScreenShotThumbnail(LoadAlbumScreenShotImageOutput& out_image_output, | ||
| 58 | std::vector<u8>& out_image, const AlbumFileId& file_id, | ||
| 59 | const ScreenShotDecodeOption& decoder_options) const; | ||
| 60 | |||
| 61 | Result SaveScreenShot(ApplicationAlbumEntry& out_entry, const ScreenShotAttribute& attribute, | ||
| 62 | std::span<const u8> image_data, u64 aruid); | ||
| 63 | Result SaveScreenShot(ApplicationAlbumEntry& out_entry, const ScreenShotAttribute& attribute, | ||
| 64 | const ApplicationData& app_data, std::span<const u8> image_data, | ||
| 65 | u64 aruid); | ||
| 66 | Result SaveEditedScreenShot(ApplicationAlbumEntry& out_entry, | ||
| 67 | const ScreenShotAttribute& attribute, const AlbumFileId& file_id, | ||
| 68 | std::span<const u8> image_data); | ||
| 69 | |||
| 70 | private: | ||
| 71 | static constexpr std::size_t NandAlbumFileLimit = 1000; | ||
| 72 | static constexpr std::size_t SdAlbumFileLimit = 10000; | ||
| 73 | |||
| 74 | void FindScreenshots(); | ||
| 75 | Result GetFile(std::filesystem::path& out_path, const AlbumFileId& file_id) const; | ||
| 76 | Result GetAlbumEntry(AlbumEntry& out_entry, const std::filesystem::path& path) const; | ||
| 77 | Result LoadImage(std::span<u8> out_image, const std::filesystem::path& path, int width, | ||
| 78 | int height, ScreenShotDecoderFlag flag) const; | ||
| 79 | Result SaveImage(ApplicationAlbumEntry& out_entry, std::span<const u8> image, u64 title_id, | ||
| 80 | const AlbumFileDateTime& date) const; | ||
| 81 | |||
| 82 | AlbumFileDateTime ConvertToAlbumDateTime(u64 posix_time) const; | ||
| 83 | |||
| 84 | bool is_mounted{}; | ||
| 85 | std::unordered_map<AlbumFileId, std::filesystem::path> album_files; | ||
| 86 | |||
| 87 | Core::System& system; | ||
| 88 | }; | ||
| 89 | |||
| 90 | } // namespace Service::Capture | ||
diff --git a/src/core/hle/service/caps/caps_result.h b/src/core/hle/service/caps/caps_result.h new file mode 100644 index 000000000..c65e5fb9a --- /dev/null +++ b/src/core/hle/service/caps/caps_result.h | |||
| @@ -0,0 +1,35 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #pragma once | ||
| 5 | |||
| 6 | #include "core/hle/result.h" | ||
| 7 | |||
| 8 | namespace Service::Capture { | ||
| 9 | |||
| 10 | constexpr Result ResultWorkMemoryError(ErrorModule::Capture, 3); | ||
| 11 | constexpr Result ResultUnknown5(ErrorModule::Capture, 5); | ||
| 12 | constexpr Result ResultUnknown6(ErrorModule::Capture, 6); | ||
| 13 | constexpr Result ResultUnknown7(ErrorModule::Capture, 7); | ||
| 14 | constexpr Result ResultOutOfRange(ErrorModule::Capture, 8); | ||
| 15 | constexpr Result ResulInvalidTimestamp(ErrorModule::Capture, 12); | ||
| 16 | constexpr Result ResultInvalidStorage(ErrorModule::Capture, 13); | ||
| 17 | constexpr Result ResultInvalidFileContents(ErrorModule::Capture, 14); | ||
| 18 | constexpr Result ResultIsNotMounted(ErrorModule::Capture, 21); | ||
| 19 | constexpr Result ResultUnknown22(ErrorModule::Capture, 22); | ||
| 20 | constexpr Result ResultFileNotFound(ErrorModule::Capture, 23); | ||
| 21 | constexpr Result ResultInvalidFileData(ErrorModule::Capture, 24); | ||
| 22 | constexpr Result ResultUnknown25(ErrorModule::Capture, 25); | ||
| 23 | constexpr Result ResultReadBufferShortage(ErrorModule::Capture, 30); | ||
| 24 | constexpr Result ResultUnknown810(ErrorModule::Capture, 810); | ||
| 25 | constexpr Result ResultUnknown1024(ErrorModule::Capture, 1024); | ||
| 26 | constexpr Result ResultUnknown1202(ErrorModule::Capture, 1202); | ||
| 27 | constexpr Result ResultUnknown1203(ErrorModule::Capture, 1203); | ||
| 28 | constexpr Result ResultFileCountLimit(ErrorModule::Capture, 1401); | ||
| 29 | constexpr Result ResultUnknown1701(ErrorModule::Capture, 1701); | ||
| 30 | constexpr Result ResultUnknown1801(ErrorModule::Capture, 1801); | ||
| 31 | constexpr Result ResultUnknown1802(ErrorModule::Capture, 1802); | ||
| 32 | constexpr Result ResultUnknown1803(ErrorModule::Capture, 1803); | ||
| 33 | constexpr Result ResultUnknown1804(ErrorModule::Capture, 1804); | ||
| 34 | |||
| 35 | } // namespace Service::Capture | ||
diff --git a/src/core/hle/service/caps/caps_sc.cpp b/src/core/hle/service/caps/caps_sc.cpp index 395b13da7..6117cb7c6 100644 --- a/src/core/hle/service/caps/caps_sc.cpp +++ b/src/core/hle/service/caps/caps_sc.cpp | |||
| @@ -5,7 +5,8 @@ | |||
| 5 | 5 | ||
| 6 | namespace Service::Capture { | 6 | namespace Service::Capture { |
| 7 | 7 | ||
| 8 | CAPS_SC::CAPS_SC(Core::System& system_) : ServiceFramework{system_, "caps:sc"} { | 8 | IScreenShotControlService::IScreenShotControlService(Core::System& system_) |
| 9 | : ServiceFramework{system_, "caps:sc"} { | ||
| 9 | // clang-format off | 10 | // clang-format off |
| 10 | static const FunctionInfo functions[] = { | 11 | static const FunctionInfo functions[] = { |
| 11 | {1, nullptr, "CaptureRawImage"}, | 12 | {1, nullptr, "CaptureRawImage"}, |
| @@ -34,6 +35,6 @@ CAPS_SC::CAPS_SC(Core::System& system_) : ServiceFramework{system_, "caps:sc"} { | |||
| 34 | RegisterHandlers(functions); | 35 | RegisterHandlers(functions); |
| 35 | } | 36 | } |
| 36 | 37 | ||
| 37 | CAPS_SC::~CAPS_SC() = default; | 38 | IScreenShotControlService::~IScreenShotControlService() = default; |
| 38 | 39 | ||
| 39 | } // namespace Service::Capture | 40 | } // namespace Service::Capture |
diff --git a/src/core/hle/service/caps/caps_sc.h b/src/core/hle/service/caps/caps_sc.h index e5600f6d7..d555f4979 100644 --- a/src/core/hle/service/caps/caps_sc.h +++ b/src/core/hle/service/caps/caps_sc.h | |||
| @@ -11,10 +11,10 @@ class System; | |||
| 11 | 11 | ||
| 12 | namespace Service::Capture { | 12 | namespace Service::Capture { |
| 13 | 13 | ||
| 14 | class CAPS_SC final : public ServiceFramework<CAPS_SC> { | 14 | class IScreenShotControlService final : public ServiceFramework<IScreenShotControlService> { |
| 15 | public: | 15 | public: |
| 16 | explicit CAPS_SC(Core::System& system_); | 16 | explicit IScreenShotControlService(Core::System& system_); |
| 17 | ~CAPS_SC() override; | 17 | ~IScreenShotControlService() override; |
| 18 | }; | 18 | }; |
| 19 | 19 | ||
| 20 | } // namespace Service::Capture | 20 | } // namespace Service::Capture |
diff --git a/src/core/hle/service/caps/caps_ss.cpp b/src/core/hle/service/caps/caps_ss.cpp index 62b9edd41..1ba2b7972 100644 --- a/src/core/hle/service/caps/caps_ss.cpp +++ b/src/core/hle/service/caps/caps_ss.cpp | |||
| @@ -1,18 +1,25 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project | 1 | // SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project |
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | 2 | // SPDX-License-Identifier: GPL-2.0-or-later |
| 3 | 3 | ||
| 4 | #include "common/logging/log.h" | ||
| 5 | #include "core/hle/service/caps/caps_manager.h" | ||
| 6 | #include "core/hle/service/caps/caps_types.h" | ||
| 7 | #include "core/hle/service/ipc_helpers.h" | ||
| 8 | |||
| 4 | #include "core/hle/service/caps/caps_ss.h" | 9 | #include "core/hle/service/caps/caps_ss.h" |
| 5 | 10 | ||
| 6 | namespace Service::Capture { | 11 | namespace Service::Capture { |
| 7 | 12 | ||
| 8 | CAPS_SS::CAPS_SS(Core::System& system_) : ServiceFramework{system_, "caps:ss"} { | 13 | IScreenShotService::IScreenShotService(Core::System& system_, |
| 14 | std::shared_ptr<AlbumManager> album_manager) | ||
| 15 | : ServiceFramework{system_, "caps:ss"}, manager{album_manager} { | ||
| 9 | // clang-format off | 16 | // clang-format off |
| 10 | static const FunctionInfo functions[] = { | 17 | static const FunctionInfo functions[] = { |
| 11 | {201, nullptr, "SaveScreenShot"}, | 18 | {201, nullptr, "SaveScreenShot"}, |
| 12 | {202, nullptr, "SaveEditedScreenShot"}, | 19 | {202, nullptr, "SaveEditedScreenShot"}, |
| 13 | {203, nullptr, "SaveScreenShotEx0"}, | 20 | {203, &IScreenShotService::SaveScreenShotEx0, "SaveScreenShotEx0"}, |
| 14 | {204, nullptr, "SaveEditedScreenShotEx0"}, | 21 | {204, nullptr, "SaveEditedScreenShotEx0"}, |
| 15 | {206, nullptr, "Unknown206"}, | 22 | {206, &IScreenShotService::SaveEditedScreenShotEx1, "SaveEditedScreenShotEx1"}, |
| 16 | {208, nullptr, "SaveScreenShotOfMovieEx1"}, | 23 | {208, nullptr, "SaveScreenShotOfMovieEx1"}, |
| 17 | {1000, nullptr, "Unknown1000"}, | 24 | {1000, nullptr, "Unknown1000"}, |
| 18 | }; | 25 | }; |
| @@ -21,6 +28,67 @@ CAPS_SS::CAPS_SS(Core::System& system_) : ServiceFramework{system_, "caps:ss"} { | |||
| 21 | RegisterHandlers(functions); | 28 | RegisterHandlers(functions); |
| 22 | } | 29 | } |
| 23 | 30 | ||
| 24 | CAPS_SS::~CAPS_SS() = default; | 31 | IScreenShotService::~IScreenShotService() = default; |
| 32 | |||
| 33 | void IScreenShotService::SaveScreenShotEx0(HLERequestContext& ctx) { | ||
| 34 | IPC::RequestParser rp{ctx}; | ||
| 35 | struct Parameters { | ||
| 36 | ScreenShotAttribute attribute{}; | ||
| 37 | u32 report_option{}; | ||
| 38 | INSERT_PADDING_BYTES(0x4); | ||
| 39 | u64 applet_resource_user_id{}; | ||
| 40 | }; | ||
| 41 | static_assert(sizeof(Parameters) == 0x50, "Parameters has incorrect size."); | ||
| 42 | |||
| 43 | const auto parameters{rp.PopRaw<Parameters>()}; | ||
| 44 | const auto image_data_buffer = ctx.ReadBuffer(); | ||
| 45 | |||
| 46 | LOG_INFO(Service_Capture, | ||
| 47 | "called, report_option={}, image_data_buffer_size={}, applet_resource_user_id={}", | ||
| 48 | parameters.report_option, image_data_buffer.size(), | ||
| 49 | parameters.applet_resource_user_id); | ||
| 50 | |||
| 51 | ApplicationAlbumEntry entry{}; | ||
| 52 | const auto result = manager->SaveScreenShot(entry, parameters.attribute, image_data_buffer, | ||
| 53 | parameters.applet_resource_user_id); | ||
| 54 | |||
| 55 | IPC::ResponseBuilder rb{ctx, 10}; | ||
| 56 | rb.Push(result); | ||
| 57 | rb.PushRaw(entry); | ||
| 58 | } | ||
| 59 | void IScreenShotService::SaveEditedScreenShotEx1(HLERequestContext& ctx) { | ||
| 60 | IPC::RequestParser rp{ctx}; | ||
| 61 | struct Parameters { | ||
| 62 | ScreenShotAttribute attribute; | ||
| 63 | u64 width; | ||
| 64 | u64 height; | ||
| 65 | u64 thumbnail_width; | ||
| 66 | u64 thumbnail_height; | ||
| 67 | AlbumFileId file_id; | ||
| 68 | }; | ||
| 69 | static_assert(sizeof(Parameters) == 0x78, "Parameters has incorrect size."); | ||
| 70 | |||
| 71 | const auto parameters{rp.PopRaw<Parameters>()}; | ||
| 72 | const auto application_data_buffer = ctx.ReadBuffer(0); | ||
| 73 | const auto image_data_buffer = ctx.ReadBuffer(1); | ||
| 74 | const auto thumbnail_image_data_buffer = ctx.ReadBuffer(2); | ||
| 75 | |||
| 76 | LOG_INFO(Service_Capture, | ||
| 77 | "called, width={}, height={}, thumbnail_width={}, thumbnail_height={}, " | ||
| 78 | "application_id={:016x}, storage={}, type={}, app_data_buffer_size={}, " | ||
| 79 | "image_data_buffer_size={}, thumbnail_image_buffer_size={}", | ||
| 80 | parameters.width, parameters.height, parameters.thumbnail_width, | ||
| 81 | parameters.thumbnail_height, parameters.file_id.application_id, | ||
| 82 | parameters.file_id.storage, parameters.file_id.type, application_data_buffer.size(), | ||
| 83 | image_data_buffer.size(), thumbnail_image_data_buffer.size()); | ||
| 84 | |||
| 85 | ApplicationAlbumEntry entry{}; | ||
| 86 | const auto result = manager->SaveEditedScreenShot(entry, parameters.attribute, | ||
| 87 | parameters.file_id, image_data_buffer); | ||
| 88 | |||
| 89 | IPC::ResponseBuilder rb{ctx, 10}; | ||
| 90 | rb.Push(result); | ||
| 91 | rb.PushRaw(entry); | ||
| 92 | } | ||
| 25 | 93 | ||
| 26 | } // namespace Service::Capture | 94 | } // namespace Service::Capture |
diff --git a/src/core/hle/service/caps/caps_ss.h b/src/core/hle/service/caps/caps_ss.h index 718ade485..a7e9972ab 100644 --- a/src/core/hle/service/caps/caps_ss.h +++ b/src/core/hle/service/caps/caps_ss.h | |||
| @@ -11,10 +11,16 @@ class System; | |||
| 11 | 11 | ||
| 12 | namespace Service::Capture { | 12 | namespace Service::Capture { |
| 13 | 13 | ||
| 14 | class CAPS_SS final : public ServiceFramework<CAPS_SS> { | 14 | class IScreenShotService final : public ServiceFramework<IScreenShotService> { |
| 15 | public: | 15 | public: |
| 16 | explicit CAPS_SS(Core::System& system_); | 16 | explicit IScreenShotService(Core::System& system_, std::shared_ptr<AlbumManager> album_manager); |
| 17 | ~CAPS_SS() override; | 17 | ~IScreenShotService() override; |
| 18 | |||
| 19 | private: | ||
| 20 | void SaveScreenShotEx0(HLERequestContext& ctx); | ||
| 21 | void SaveEditedScreenShotEx1(HLERequestContext& ctx); | ||
| 22 | |||
| 23 | std::shared_ptr<AlbumManager> manager; | ||
| 18 | }; | 24 | }; |
| 19 | 25 | ||
| 20 | } // namespace Service::Capture | 26 | } // namespace Service::Capture |
diff --git a/src/core/hle/service/caps/caps_su.cpp b/src/core/hle/service/caps/caps_su.cpp index 3b11cc95c..e85625ee4 100644 --- a/src/core/hle/service/caps/caps_su.cpp +++ b/src/core/hle/service/caps/caps_su.cpp | |||
| @@ -2,18 +2,22 @@ | |||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | 2 | // SPDX-License-Identifier: GPL-2.0-or-later |
| 3 | 3 | ||
| 4 | #include "common/logging/log.h" | 4 | #include "common/logging/log.h" |
| 5 | #include "core/hle/service/caps/caps_manager.h" | ||
| 5 | #include "core/hle/service/caps/caps_su.h" | 6 | #include "core/hle/service/caps/caps_su.h" |
| 7 | #include "core/hle/service/caps/caps_types.h" | ||
| 6 | #include "core/hle/service/ipc_helpers.h" | 8 | #include "core/hle/service/ipc_helpers.h" |
| 7 | 9 | ||
| 8 | namespace Service::Capture { | 10 | namespace Service::Capture { |
| 9 | 11 | ||
| 10 | CAPS_SU::CAPS_SU(Core::System& system_) : ServiceFramework{system_, "caps:su"} { | 12 | IScreenShotApplicationService::IScreenShotApplicationService( |
| 13 | Core::System& system_, std::shared_ptr<AlbumManager> album_manager) | ||
| 14 | : ServiceFramework{system_, "caps:su"}, manager{album_manager} { | ||
| 11 | // clang-format off | 15 | // clang-format off |
| 12 | static const FunctionInfo functions[] = { | 16 | static const FunctionInfo functions[] = { |
| 13 | {32, &CAPS_SU::SetShimLibraryVersion, "SetShimLibraryVersion"}, | 17 | {32, &IScreenShotApplicationService::SetShimLibraryVersion, "SetShimLibraryVersion"}, |
| 14 | {201, nullptr, "SaveScreenShot"}, | 18 | {201, nullptr, "SaveScreenShot"}, |
| 15 | {203, nullptr, "SaveScreenShotEx0"}, | 19 | {203, &IScreenShotApplicationService::SaveScreenShotEx0, "SaveScreenShotEx0"}, |
| 16 | {205, nullptr, "SaveScreenShotEx1"}, | 20 | {205, &IScreenShotApplicationService::SaveScreenShotEx1, "SaveScreenShotEx1"}, |
| 17 | {210, nullptr, "SaveScreenShotEx2"}, | 21 | {210, nullptr, "SaveScreenShotEx2"}, |
| 18 | }; | 22 | }; |
| 19 | // clang-format on | 23 | // clang-format on |
| @@ -21,9 +25,9 @@ CAPS_SU::CAPS_SU(Core::System& system_) : ServiceFramework{system_, "caps:su"} { | |||
| 21 | RegisterHandlers(functions); | 25 | RegisterHandlers(functions); |
| 22 | } | 26 | } |
| 23 | 27 | ||
| 24 | CAPS_SU::~CAPS_SU() = default; | 28 | IScreenShotApplicationService::~IScreenShotApplicationService() = default; |
| 25 | 29 | ||
| 26 | void CAPS_SU::SetShimLibraryVersion(HLERequestContext& ctx) { | 30 | void IScreenShotApplicationService::SetShimLibraryVersion(HLERequestContext& ctx) { |
| 27 | IPC::RequestParser rp{ctx}; | 31 | IPC::RequestParser rp{ctx}; |
| 28 | const auto library_version{rp.Pop<u64>()}; | 32 | const auto library_version{rp.Pop<u64>()}; |
| 29 | const auto applet_resource_user_id{rp.Pop<u64>()}; | 33 | const auto applet_resource_user_id{rp.Pop<u64>()}; |
| @@ -35,4 +39,62 @@ void CAPS_SU::SetShimLibraryVersion(HLERequestContext& ctx) { | |||
| 35 | rb.Push(ResultSuccess); | 39 | rb.Push(ResultSuccess); |
| 36 | } | 40 | } |
| 37 | 41 | ||
| 42 | void IScreenShotApplicationService::SaveScreenShotEx0(HLERequestContext& ctx) { | ||
| 43 | IPC::RequestParser rp{ctx}; | ||
| 44 | struct Parameters { | ||
| 45 | ScreenShotAttribute attribute{}; | ||
| 46 | AlbumReportOption report_option{}; | ||
| 47 | INSERT_PADDING_BYTES(0x4); | ||
| 48 | u64 applet_resource_user_id{}; | ||
| 49 | }; | ||
| 50 | static_assert(sizeof(Parameters) == 0x50, "Parameters has incorrect size."); | ||
| 51 | |||
| 52 | const auto parameters{rp.PopRaw<Parameters>()}; | ||
| 53 | const auto image_data_buffer = ctx.ReadBuffer(); | ||
| 54 | |||
| 55 | LOG_INFO(Service_Capture, | ||
| 56 | "called, report_option={}, image_data_buffer_size={}, applet_resource_user_id={}", | ||
| 57 | parameters.report_option, image_data_buffer.size(), | ||
| 58 | parameters.applet_resource_user_id); | ||
| 59 | |||
| 60 | ApplicationAlbumEntry entry{}; | ||
| 61 | const auto result = manager->SaveScreenShot(entry, parameters.attribute, image_data_buffer, | ||
| 62 | parameters.applet_resource_user_id); | ||
| 63 | |||
| 64 | IPC::ResponseBuilder rb{ctx, 10}; | ||
| 65 | rb.Push(result); | ||
| 66 | rb.PushRaw(entry); | ||
| 67 | } | ||
| 68 | |||
| 69 | void IScreenShotApplicationService::SaveScreenShotEx1(HLERequestContext& ctx) { | ||
| 70 | IPC::RequestParser rp{ctx}; | ||
| 71 | struct Parameters { | ||
| 72 | ScreenShotAttribute attribute{}; | ||
| 73 | AlbumReportOption report_option{}; | ||
| 74 | INSERT_PADDING_BYTES(0x4); | ||
| 75 | u64 applet_resource_user_id{}; | ||
| 76 | }; | ||
| 77 | static_assert(sizeof(Parameters) == 0x50, "Parameters has incorrect size."); | ||
| 78 | |||
| 79 | const auto parameters{rp.PopRaw<Parameters>()}; | ||
| 80 | const auto app_data_buffer = ctx.ReadBuffer(0); | ||
| 81 | const auto image_data_buffer = ctx.ReadBuffer(1); | ||
| 82 | |||
| 83 | LOG_INFO(Service_Capture, | ||
| 84 | "called, report_option={}, image_data_buffer_size={}, applet_resource_user_id={}", | ||
| 85 | parameters.report_option, image_data_buffer.size(), | ||
| 86 | parameters.applet_resource_user_id); | ||
| 87 | |||
| 88 | ApplicationAlbumEntry entry{}; | ||
| 89 | ApplicationData app_data{}; | ||
| 90 | std::memcpy(&app_data, app_data_buffer.data(), sizeof(ApplicationData)); | ||
| 91 | const auto result = | ||
| 92 | manager->SaveScreenShot(entry, parameters.attribute, app_data, image_data_buffer, | ||
| 93 | parameters.applet_resource_user_id); | ||
| 94 | |||
| 95 | IPC::ResponseBuilder rb{ctx, 10}; | ||
| 96 | rb.Push(result); | ||
| 97 | rb.PushRaw(entry); | ||
| 98 | } | ||
| 99 | |||
| 38 | } // namespace Service::Capture | 100 | } // namespace Service::Capture |
diff --git a/src/core/hle/service/caps/caps_su.h b/src/core/hle/service/caps/caps_su.h index c6398858d..89e71f506 100644 --- a/src/core/hle/service/caps/caps_su.h +++ b/src/core/hle/service/caps/caps_su.h | |||
| @@ -10,14 +10,20 @@ class System; | |||
| 10 | } | 10 | } |
| 11 | 11 | ||
| 12 | namespace Service::Capture { | 12 | namespace Service::Capture { |
| 13 | class AlbumManager; | ||
| 13 | 14 | ||
| 14 | class CAPS_SU final : public ServiceFramework<CAPS_SU> { | 15 | class IScreenShotApplicationService final : public ServiceFramework<IScreenShotApplicationService> { |
| 15 | public: | 16 | public: |
| 16 | explicit CAPS_SU(Core::System& system_); | 17 | explicit IScreenShotApplicationService(Core::System& system_, |
| 17 | ~CAPS_SU() override; | 18 | std::shared_ptr<AlbumManager> album_manager); |
| 19 | ~IScreenShotApplicationService() override; | ||
| 18 | 20 | ||
| 19 | private: | 21 | private: |
| 20 | void SetShimLibraryVersion(HLERequestContext& ctx); | 22 | void SetShimLibraryVersion(HLERequestContext& ctx); |
| 23 | void SaveScreenShotEx0(HLERequestContext& ctx); | ||
| 24 | void SaveScreenShotEx1(HLERequestContext& ctx); | ||
| 25 | |||
| 26 | std::shared_ptr<AlbumManager> manager; | ||
| 21 | }; | 27 | }; |
| 22 | 28 | ||
| 23 | } // namespace Service::Capture | 29 | } // namespace Service::Capture |
diff --git a/src/core/hle/service/caps/caps_types.h b/src/core/hle/service/caps/caps_types.h new file mode 100644 index 000000000..589ac28d3 --- /dev/null +++ b/src/core/hle/service/caps/caps_types.h | |||
| @@ -0,0 +1,186 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #pragma once | ||
| 5 | |||
| 6 | #include "common/common_funcs.h" | ||
| 7 | #include "common/common_types.h" | ||
| 8 | |||
| 9 | namespace Service::Capture { | ||
| 10 | |||
| 11 | // This is nn::album::ImageOrientation | ||
| 12 | enum class AlbumImageOrientation { | ||
| 13 | None, | ||
| 14 | Rotate90, | ||
| 15 | Rotate180, | ||
| 16 | Rotate270, | ||
| 17 | }; | ||
| 18 | |||
| 19 | // This is nn::album::AlbumReportOption | ||
| 20 | enum class AlbumReportOption : s32 { | ||
| 21 | Disable, | ||
| 22 | Enable, | ||
| 23 | Unknown2, | ||
| 24 | Unknown3, | ||
| 25 | }; | ||
| 26 | |||
| 27 | enum class ContentType : u8 { | ||
| 28 | Screenshot = 0, | ||
| 29 | Movie = 1, | ||
| 30 | ExtraMovie = 3, | ||
| 31 | }; | ||
| 32 | |||
| 33 | enum class AlbumStorage : u8 { | ||
| 34 | Nand, | ||
| 35 | Sd, | ||
| 36 | }; | ||
| 37 | |||
| 38 | enum class ScreenShotDecoderFlag : u64 { | ||
| 39 | None = 0, | ||
| 40 | EnableFancyUpsampling = 1 << 0, | ||
| 41 | EnableBlockSmoothing = 1 << 1, | ||
| 42 | }; | ||
| 43 | |||
| 44 | // This is nn::capsrv::AlbumFileDateTime | ||
| 45 | struct AlbumFileDateTime { | ||
| 46 | s16 year{}; | ||
| 47 | s8 month{}; | ||
| 48 | s8 day{}; | ||
| 49 | s8 hour{}; | ||
| 50 | s8 minute{}; | ||
| 51 | s8 second{}; | ||
| 52 | s8 unique_id{}; | ||
| 53 | |||
| 54 | friend constexpr bool operator==(const AlbumFileDateTime&, const AlbumFileDateTime&) = default; | ||
| 55 | friend constexpr bool operator>(const AlbumFileDateTime& a, const AlbumFileDateTime& b) { | ||
| 56 | if (a.year > b.year) { | ||
| 57 | return true; | ||
| 58 | } | ||
| 59 | if (a.month > b.month) { | ||
| 60 | return true; | ||
| 61 | } | ||
| 62 | if (a.day > b.day) { | ||
| 63 | return true; | ||
| 64 | } | ||
| 65 | if (a.hour > b.hour) { | ||
| 66 | return true; | ||
| 67 | } | ||
| 68 | if (a.minute > b.minute) { | ||
| 69 | return true; | ||
| 70 | } | ||
| 71 | return a.second > b.second; | ||
| 72 | }; | ||
| 73 | friend constexpr bool operator<(const AlbumFileDateTime& a, const AlbumFileDateTime& b) { | ||
| 74 | if (a.year < b.year) { | ||
| 75 | return true; | ||
| 76 | } | ||
| 77 | if (a.month < b.month) { | ||
| 78 | return true; | ||
| 79 | } | ||
| 80 | if (a.day < b.day) { | ||
| 81 | return true; | ||
| 82 | } | ||
| 83 | if (a.hour < b.hour) { | ||
| 84 | return true; | ||
| 85 | } | ||
| 86 | if (a.minute < b.minute) { | ||
| 87 | return true; | ||
| 88 | } | ||
| 89 | return a.second < b.second; | ||
| 90 | }; | ||
| 91 | }; | ||
| 92 | static_assert(sizeof(AlbumFileDateTime) == 0x8, "AlbumFileDateTime has incorrect size."); | ||
| 93 | |||
| 94 | // This is nn::album::AlbumEntry | ||
| 95 | struct AlbumFileEntry { | ||
| 96 | u64 size{}; // Size of the entry | ||
| 97 | u64 hash{}; // AES256 with hardcoded key over AlbumEntry | ||
| 98 | AlbumFileDateTime datetime{}; | ||
| 99 | AlbumStorage storage{}; | ||
| 100 | ContentType content{}; | ||
| 101 | INSERT_PADDING_BYTES(5); | ||
| 102 | u8 unknown{}; // Set to 1 on official SW | ||
| 103 | }; | ||
| 104 | static_assert(sizeof(AlbumFileEntry) == 0x20, "AlbumFileEntry has incorrect size."); | ||
| 105 | |||
| 106 | struct AlbumFileId { | ||
| 107 | u64 application_id{}; | ||
| 108 | AlbumFileDateTime date{}; | ||
| 109 | AlbumStorage storage{}; | ||
| 110 | ContentType type{}; | ||
| 111 | INSERT_PADDING_BYTES(0x5); | ||
| 112 | u8 unknown{}; | ||
| 113 | |||
| 114 | friend constexpr bool operator==(const AlbumFileId&, const AlbumFileId&) = default; | ||
| 115 | }; | ||
| 116 | static_assert(sizeof(AlbumFileId) == 0x18, "AlbumFileId is an invalid size"); | ||
| 117 | |||
| 118 | // This is nn::capsrv::AlbumEntry | ||
| 119 | struct AlbumEntry { | ||
| 120 | u64 entry_size{}; | ||
| 121 | AlbumFileId file_id{}; | ||
| 122 | }; | ||
| 123 | static_assert(sizeof(AlbumEntry) == 0x20, "AlbumEntry has incorrect size."); | ||
| 124 | |||
| 125 | // This is nn::capsrv::ApplicationAlbumEntry | ||
| 126 | struct ApplicationAlbumEntry { | ||
| 127 | u64 size{}; // Size of the entry | ||
| 128 | u64 hash{}; // AES256 with hardcoded key over AlbumEntry | ||
| 129 | AlbumFileDateTime datetime{}; | ||
| 130 | AlbumStorage storage{}; | ||
| 131 | ContentType content{}; | ||
| 132 | INSERT_PADDING_BYTES(5); | ||
| 133 | u8 unknown{1}; // Set to 1 on official SW | ||
| 134 | }; | ||
| 135 | static_assert(sizeof(ApplicationAlbumEntry) == 0x20, "ApplicationAlbumEntry has incorrect size."); | ||
| 136 | |||
| 137 | // This is nn::capsrv::ApplicationAlbumFileEntry | ||
| 138 | struct ApplicationAlbumFileEntry { | ||
| 139 | ApplicationAlbumEntry entry{}; | ||
| 140 | AlbumFileDateTime datetime{}; | ||
| 141 | u64 unknown{}; | ||
| 142 | }; | ||
| 143 | static_assert(sizeof(ApplicationAlbumFileEntry) == 0x30, | ||
| 144 | "ApplicationAlbumFileEntry has incorrect size."); | ||
| 145 | |||
| 146 | struct ApplicationData { | ||
| 147 | std::array<u8, 0x400> data{}; | ||
| 148 | u32 data_size{}; | ||
| 149 | }; | ||
| 150 | static_assert(sizeof(ApplicationData) == 0x404, "ApplicationData is an invalid size"); | ||
| 151 | |||
| 152 | struct ScreenShotAttribute { | ||
| 153 | u32 unknown_0{}; | ||
| 154 | AlbumImageOrientation orientation{}; | ||
| 155 | u32 unknown_1{}; | ||
| 156 | u32 unknown_2{}; | ||
| 157 | INSERT_PADDING_BYTES(0x30); | ||
| 158 | }; | ||
| 159 | static_assert(sizeof(ScreenShotAttribute) == 0x40, "ScreenShotAttribute is an invalid size"); | ||
| 160 | |||
| 161 | struct ScreenShotDecodeOption { | ||
| 162 | ScreenShotDecoderFlag flags{}; | ||
| 163 | INSERT_PADDING_BYTES(0x18); | ||
| 164 | }; | ||
| 165 | static_assert(sizeof(ScreenShotDecodeOption) == 0x20, "ScreenShotDecodeOption is an invalid size"); | ||
| 166 | |||
| 167 | struct LoadAlbumScreenShotImageOutput { | ||
| 168 | s64 width{}; | ||
| 169 | s64 height{}; | ||
| 170 | ScreenShotAttribute attribute{}; | ||
| 171 | INSERT_PADDING_BYTES(0x400); | ||
| 172 | }; | ||
| 173 | static_assert(sizeof(LoadAlbumScreenShotImageOutput) == 0x450, | ||
| 174 | "LoadAlbumScreenShotImageOutput is an invalid size"); | ||
| 175 | |||
| 176 | struct LoadAlbumScreenShotImageOutputForApplication { | ||
| 177 | s64 width{}; | ||
| 178 | s64 height{}; | ||
| 179 | ScreenShotAttribute attribute{}; | ||
| 180 | ApplicationData data{}; | ||
| 181 | INSERT_PADDING_BYTES(0xAC); | ||
| 182 | }; | ||
| 183 | static_assert(sizeof(LoadAlbumScreenShotImageOutputForApplication) == 0x500, | ||
| 184 | "LoadAlbumScreenShotImageOutput is an invalid size"); | ||
| 185 | |||
| 186 | } // namespace Service::Capture | ||
diff --git a/src/core/hle/service/caps/caps_u.cpp b/src/core/hle/service/caps/caps_u.cpp index bffe0f8d0..b6b33fb2f 100644 --- a/src/core/hle/service/caps/caps_u.cpp +++ b/src/core/hle/service/caps/caps_u.cpp | |||
| @@ -2,45 +2,29 @@ | |||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | 2 | // SPDX-License-Identifier: GPL-2.0-or-later |
| 3 | 3 | ||
| 4 | #include "common/logging/log.h" | 4 | #include "common/logging/log.h" |
| 5 | #include "core/hle/service/caps/caps.h" | 5 | #include "core/hle/service/caps/caps_manager.h" |
| 6 | #include "core/hle/service/caps/caps_types.h" | ||
| 6 | #include "core/hle/service/caps/caps_u.h" | 7 | #include "core/hle/service/caps/caps_u.h" |
| 7 | #include "core/hle/service/ipc_helpers.h" | 8 | #include "core/hle/service/ipc_helpers.h" |
| 8 | 9 | ||
| 9 | namespace Service::Capture { | 10 | namespace Service::Capture { |
| 10 | 11 | ||
| 11 | class IAlbumAccessorApplicationSession final | 12 | IAlbumApplicationService::IAlbumApplicationService(Core::System& system_, |
| 12 | : public ServiceFramework<IAlbumAccessorApplicationSession> { | 13 | std::shared_ptr<AlbumManager> album_manager) |
| 13 | public: | 14 | : ServiceFramework{system_, "caps:u"}, manager{album_manager} { |
| 14 | explicit IAlbumAccessorApplicationSession(Core::System& system_) | ||
| 15 | : ServiceFramework{system_, "IAlbumAccessorApplicationSession"} { | ||
| 16 | // clang-format off | ||
| 17 | static const FunctionInfo functions[] = { | ||
| 18 | {2001, nullptr, "OpenAlbumMovieReadStream"}, | ||
| 19 | {2002, nullptr, "CloseAlbumMovieReadStream"}, | ||
| 20 | {2003, nullptr, "GetAlbumMovieReadStreamMovieDataSize"}, | ||
| 21 | {2004, nullptr, "ReadMovieDataFromAlbumMovieReadStream"}, | ||
| 22 | {2005, nullptr, "GetAlbumMovieReadStreamBrokenReason"}, | ||
| 23 | }; | ||
| 24 | // clang-format on | ||
| 25 | |||
| 26 | RegisterHandlers(functions); | ||
| 27 | } | ||
| 28 | }; | ||
| 29 | |||
| 30 | CAPS_U::CAPS_U(Core::System& system_) : ServiceFramework{system_, "caps:u"} { | ||
| 31 | // clang-format off | 15 | // clang-format off |
| 32 | static const FunctionInfo functions[] = { | 16 | static const FunctionInfo functions[] = { |
| 33 | {32, &CAPS_U::SetShimLibraryVersion, "SetShimLibraryVersion"}, | 17 | {32, &IAlbumApplicationService::SetShimLibraryVersion, "SetShimLibraryVersion"}, |
| 34 | {102, &CAPS_U::GetAlbumContentsFileListForApplication, "GetAlbumContentsFileListForApplication"}, | 18 | {102, &IAlbumApplicationService::GetAlbumFileList0AafeAruidDeprecated, "GetAlbumFileList0AafeAruidDeprecated"}, |
| 35 | {103, nullptr, "DeleteAlbumContentsFileForApplication"}, | 19 | {103, nullptr, "DeleteAlbumFileByAruid"}, |
| 36 | {104, nullptr, "GetAlbumContentsFileSizeForApplication"}, | 20 | {104, nullptr, "GetAlbumFileSizeByAruid"}, |
| 37 | {105, nullptr, "DeleteAlbumFileByAruidForDebug"}, | 21 | {105, nullptr, "DeleteAlbumFileByAruidForDebug"}, |
| 38 | {110, nullptr, "LoadAlbumContentsFileScreenShotImageForApplication"}, | 22 | {110, nullptr, "LoadAlbumScreenShotImageByAruid"}, |
| 39 | {120, nullptr, "LoadAlbumContentsFileThumbnailImageForApplication"}, | 23 | {120, nullptr, "LoadAlbumScreenShotThumbnailImageByAruid"}, |
| 40 | {130, nullptr, "PrecheckToCreateContentsForApplication"}, | 24 | {130, nullptr, "PrecheckToCreateContentsByAruid"}, |
| 41 | {140, nullptr, "GetAlbumFileList1AafeAruidDeprecated"}, | 25 | {140, nullptr, "GetAlbumFileList1AafeAruidDeprecated"}, |
| 42 | {141, nullptr, "GetAlbumFileList2AafeUidAruidDeprecated"}, | 26 | {141, nullptr, "GetAlbumFileList2AafeUidAruidDeprecated"}, |
| 43 | {142, &CAPS_U::GetAlbumFileList3AaeAruid, "GetAlbumFileList3AaeAruid"}, | 27 | {142, &IAlbumApplicationService::GetAlbumFileList3AaeAruid, "GetAlbumFileList3AaeAruid"}, |
| 44 | {143, nullptr, "GetAlbumFileList4AaeUidAruid"}, | 28 | {143, nullptr, "GetAlbumFileList4AaeUidAruid"}, |
| 45 | {144, nullptr, "GetAllAlbumFileList3AaeAruid"}, | 29 | {144, nullptr, "GetAllAlbumFileList3AaeAruid"}, |
| 46 | {60002, nullptr, "OpenAccessorSessionForApplication"}, | 30 | {60002, nullptr, "OpenAccessorSessionForApplication"}, |
| @@ -50,9 +34,9 @@ CAPS_U::CAPS_U(Core::System& system_) : ServiceFramework{system_, "caps:u"} { | |||
| 50 | RegisterHandlers(functions); | 34 | RegisterHandlers(functions); |
| 51 | } | 35 | } |
| 52 | 36 | ||
| 53 | CAPS_U::~CAPS_U() = default; | 37 | IAlbumApplicationService::~IAlbumApplicationService() = default; |
| 54 | 38 | ||
| 55 | void CAPS_U::SetShimLibraryVersion(HLERequestContext& ctx) { | 39 | void IAlbumApplicationService::SetShimLibraryVersion(HLERequestContext& ctx) { |
| 56 | IPC::RequestParser rp{ctx}; | 40 | IPC::RequestParser rp{ctx}; |
| 57 | const auto library_version{rp.Pop<u64>()}; | 41 | const auto library_version{rp.Pop<u64>()}; |
| 58 | const auto applet_resource_user_id{rp.Pop<u64>()}; | 42 | const auto applet_resource_user_id{rp.Pop<u64>()}; |
| @@ -64,37 +48,89 @@ void CAPS_U::SetShimLibraryVersion(HLERequestContext& ctx) { | |||
| 64 | rb.Push(ResultSuccess); | 48 | rb.Push(ResultSuccess); |
| 65 | } | 49 | } |
| 66 | 50 | ||
| 67 | void CAPS_U::GetAlbumContentsFileListForApplication(HLERequestContext& ctx) { | 51 | void IAlbumApplicationService::GetAlbumFileList0AafeAruidDeprecated(HLERequestContext& ctx) { |
| 68 | // Takes a type-0x6 output buffer containing an array of ApplicationAlbumFileEntry, a PID, an | ||
| 69 | // u8 ContentType, two s64s, and an u64 AppletResourceUserId. Returns an output u64 for total | ||
| 70 | // output entries (which is copied to a s32 by official SW). | ||
| 71 | IPC::RequestParser rp{ctx}; | 52 | IPC::RequestParser rp{ctx}; |
| 72 | const auto pid{rp.Pop<s32>()}; | 53 | struct Parameters { |
| 73 | const auto content_type{rp.PopEnum<ContentType>()}; | 54 | ContentType content_type; |
| 74 | const auto start_posix_time{rp.Pop<s64>()}; | 55 | INSERT_PADDING_BYTES(7); |
| 75 | const auto end_posix_time{rp.Pop<s64>()}; | 56 | s64 start_posix_time; |
| 76 | const auto applet_resource_user_id{rp.Pop<u64>()}; | 57 | s64 end_posix_time; |
| 58 | u64 applet_resource_user_id; | ||
| 59 | }; | ||
| 60 | static_assert(sizeof(Parameters) == 0x20, "Parameters has incorrect size."); | ||
| 77 | 61 | ||
| 78 | // TODO: Update this when we implement the album. | 62 | const auto parameters{rp.PopRaw<Parameters>()}; |
| 79 | // Currently we do not have a method of accessing album entries, set this to 0 for now. | ||
| 80 | constexpr u32 total_entries_1{}; | ||
| 81 | constexpr u32 total_entries_2{}; | ||
| 82 | 63 | ||
| 83 | LOG_WARNING( | 64 | LOG_WARNING(Service_Capture, |
| 84 | Service_Capture, | 65 | "(STUBBED) called. content_type={}, start_posix_time={}, end_posix_time={}, " |
| 85 | "(STUBBED) called. pid={}, content_type={}, start_posix_time={}, " | 66 | "applet_resource_user_id={}", |
| 86 | "end_posix_time={}, applet_resource_user_id={}, total_entries_1={}, total_entries_2={}", | 67 | parameters.content_type, parameters.start_posix_time, parameters.end_posix_time, |
| 87 | pid, content_type, start_posix_time, end_posix_time, applet_resource_user_id, | 68 | parameters.applet_resource_user_id); |
| 88 | total_entries_1, total_entries_2); | 69 | |
| 70 | Result result = ResultSuccess; | ||
| 71 | |||
| 72 | if (result.IsSuccess()) { | ||
| 73 | result = manager->IsAlbumMounted(AlbumStorage::Sd); | ||
| 74 | } | ||
| 75 | |||
| 76 | std::vector<ApplicationAlbumFileEntry> entries; | ||
| 77 | if (result.IsSuccess()) { | ||
| 78 | result = manager->GetAlbumFileList(entries, parameters.content_type, | ||
| 79 | parameters.start_posix_time, parameters.end_posix_time, | ||
| 80 | parameters.applet_resource_user_id); | ||
| 81 | } | ||
| 82 | |||
| 83 | if (!entries.empty()) { | ||
| 84 | ctx.WriteBuffer(entries); | ||
| 85 | } | ||
| 89 | 86 | ||
| 90 | IPC::ResponseBuilder rb{ctx, 4}; | 87 | IPC::ResponseBuilder rb{ctx, 4}; |
| 91 | rb.Push(ResultSuccess); | 88 | rb.Push(result); |
| 92 | rb.Push(total_entries_1); | 89 | rb.Push<u64>(entries.size()); |
| 93 | rb.Push(total_entries_2); | ||
| 94 | } | 90 | } |
| 95 | 91 | ||
| 96 | void CAPS_U::GetAlbumFileList3AaeAruid(HLERequestContext& ctx) { | 92 | void IAlbumApplicationService::GetAlbumFileList3AaeAruid(HLERequestContext& ctx) { |
| 97 | GetAlbumContentsFileListForApplication(ctx); | 93 | IPC::RequestParser rp{ctx}; |
| 94 | struct Parameters { | ||
| 95 | ContentType content_type; | ||
| 96 | INSERT_PADDING_BYTES(1); | ||
| 97 | AlbumFileDateTime start_date_time; | ||
| 98 | AlbumFileDateTime end_date_time; | ||
| 99 | INSERT_PADDING_BYTES(6); | ||
| 100 | u64 applet_resource_user_id; | ||
| 101 | }; | ||
| 102 | static_assert(sizeof(Parameters) == 0x20, "Parameters has incorrect size."); | ||
| 103 | |||
| 104 | const auto parameters{rp.PopRaw<Parameters>()}; | ||
| 105 | |||
| 106 | LOG_WARNING(Service_Capture, | ||
| 107 | "(STUBBED) called. content_type={}, start_date={}/{}/{}, " | ||
| 108 | "end_date={}/{}/{}, applet_resource_user_id={}", | ||
| 109 | parameters.content_type, parameters.start_date_time.year, | ||
| 110 | parameters.start_date_time.month, parameters.start_date_time.day, | ||
| 111 | parameters.end_date_time.year, parameters.end_date_time.month, | ||
| 112 | parameters.end_date_time.day, parameters.applet_resource_user_id); | ||
| 113 | |||
| 114 | Result result = ResultSuccess; | ||
| 115 | |||
| 116 | if (result.IsSuccess()) { | ||
| 117 | result = manager->IsAlbumMounted(AlbumStorage::Sd); | ||
| 118 | } | ||
| 119 | |||
| 120 | std::vector<ApplicationAlbumEntry> entries; | ||
| 121 | if (result.IsSuccess()) { | ||
| 122 | result = | ||
| 123 | manager->GetAlbumFileList(entries, parameters.content_type, parameters.start_date_time, | ||
| 124 | parameters.end_date_time, parameters.applet_resource_user_id); | ||
| 125 | } | ||
| 126 | |||
| 127 | if (!entries.empty()) { | ||
| 128 | ctx.WriteBuffer(entries); | ||
| 129 | } | ||
| 130 | |||
| 131 | IPC::ResponseBuilder rb{ctx, 4}; | ||
| 132 | rb.Push(result); | ||
| 133 | rb.Push<u64>(entries.size()); | ||
| 98 | } | 134 | } |
| 99 | 135 | ||
| 100 | } // namespace Service::Capture | 136 | } // namespace Service::Capture |
diff --git a/src/core/hle/service/caps/caps_u.h b/src/core/hle/service/caps/caps_u.h index e8dd037d7..9458c128e 100644 --- a/src/core/hle/service/caps/caps_u.h +++ b/src/core/hle/service/caps/caps_u.h | |||
| @@ -10,16 +10,20 @@ class System; | |||
| 10 | } | 10 | } |
| 11 | 11 | ||
| 12 | namespace Service::Capture { | 12 | namespace Service::Capture { |
| 13 | class AlbumManager; | ||
| 13 | 14 | ||
| 14 | class CAPS_U final : public ServiceFramework<CAPS_U> { | 15 | class IAlbumApplicationService final : public ServiceFramework<IAlbumApplicationService> { |
| 15 | public: | 16 | public: |
| 16 | explicit CAPS_U(Core::System& system_); | 17 | explicit IAlbumApplicationService(Core::System& system_, |
| 17 | ~CAPS_U() override; | 18 | std::shared_ptr<AlbumManager> album_manager); |
| 19 | ~IAlbumApplicationService() override; | ||
| 18 | 20 | ||
| 19 | private: | 21 | private: |
| 20 | void SetShimLibraryVersion(HLERequestContext& ctx); | 22 | void SetShimLibraryVersion(HLERequestContext& ctx); |
| 21 | void GetAlbumContentsFileListForApplication(HLERequestContext& ctx); | 23 | void GetAlbumFileList0AafeAruidDeprecated(HLERequestContext& ctx); |
| 22 | void GetAlbumFileList3AaeAruid(HLERequestContext& ctx); | 24 | void GetAlbumFileList3AaeAruid(HLERequestContext& ctx); |
| 25 | |||
| 26 | std::shared_ptr<AlbumManager> manager = nullptr; | ||
| 23 | }; | 27 | }; |
| 24 | 28 | ||
| 25 | } // namespace Service::Capture | 29 | } // namespace Service::Capture |
diff --git a/src/core/hle/service/hid/controllers/palma.cpp b/src/core/hle/service/hid/controllers/palma.cpp index 14c67e454..73a2a2b91 100644 --- a/src/core/hle/service/hid/controllers/palma.cpp +++ b/src/core/hle/service/hid/controllers/palma.cpp | |||
| @@ -19,7 +19,9 @@ Controller_Palma::Controller_Palma(Core::HID::HIDCore& hid_core_, u8* raw_shared | |||
| 19 | operation_complete_event = service_context.CreateEvent("hid:PalmaOperationCompleteEvent"); | 19 | operation_complete_event = service_context.CreateEvent("hid:PalmaOperationCompleteEvent"); |
| 20 | } | 20 | } |
| 21 | 21 | ||
| 22 | Controller_Palma::~Controller_Palma() = default; | 22 | Controller_Palma::~Controller_Palma() { |
| 23 | service_context.CloseEvent(operation_complete_event); | ||
| 24 | }; | ||
| 23 | 25 | ||
| 24 | void Controller_Palma::OnInit() {} | 26 | void Controller_Palma::OnInit() {} |
| 25 | 27 | ||
diff --git a/src/core/hle/service/hid/hid.cpp b/src/core/hle/service/hid/hid.cpp index 4d70006c1..929dd5f03 100644 --- a/src/core/hle/service/hid/hid.cpp +++ b/src/core/hle/service/hid/hid.cpp | |||
| @@ -2757,6 +2757,10 @@ public: | |||
| 2757 | joy_detach_event = service_context.CreateEvent("HidSys::JoyDetachEvent"); | 2757 | joy_detach_event = service_context.CreateEvent("HidSys::JoyDetachEvent"); |
| 2758 | } | 2758 | } |
| 2759 | 2759 | ||
| 2760 | ~HidSys() { | ||
| 2761 | service_context.CloseEvent(joy_detach_event); | ||
| 2762 | }; | ||
| 2763 | |||
| 2760 | private: | 2764 | private: |
| 2761 | void ApplyNpadSystemCommonPolicy(HLERequestContext& ctx) { | 2765 | void ApplyNpadSystemCommonPolicy(HLERequestContext& ctx) { |
| 2762 | LOG_WARNING(Service_HID, "called"); | 2766 | LOG_WARNING(Service_HID, "called"); |
diff --git a/src/core/hle/service/hid/hidbus/hidbus_base.cpp b/src/core/hle/service/hid/hidbus/hidbus_base.cpp index ee522c36e..8c44f93e8 100644 --- a/src/core/hle/service/hid/hidbus/hidbus_base.cpp +++ b/src/core/hle/service/hid/hidbus/hidbus_base.cpp | |||
| @@ -13,7 +13,10 @@ HidbusBase::HidbusBase(Core::System& system_, KernelHelpers::ServiceContext& ser | |||
| 13 | : system(system_), service_context(service_context_) { | 13 | : system(system_), service_context(service_context_) { |
| 14 | send_command_async_event = service_context.CreateEvent("hidbus:SendCommandAsyncEvent"); | 14 | send_command_async_event = service_context.CreateEvent("hidbus:SendCommandAsyncEvent"); |
| 15 | } | 15 | } |
| 16 | HidbusBase::~HidbusBase() = default; | 16 | |
| 17 | HidbusBase::~HidbusBase() { | ||
| 18 | service_context.CloseEvent(send_command_async_event); | ||
| 19 | }; | ||
| 17 | 20 | ||
| 18 | void HidbusBase::ActivateDevice() { | 21 | void HidbusBase::ActivateDevice() { |
| 19 | if (is_activated) { | 22 | if (is_activated) { |
diff --git a/src/core/hle/service/hle_ipc.cpp b/src/core/hle/service/hle_ipc.cpp index f6a1e54f2..ff374ae39 100644 --- a/src/core/hle/service/hle_ipc.cpp +++ b/src/core/hle/service/hle_ipc.cpp | |||
| @@ -23,6 +23,19 @@ | |||
| 23 | #include "core/hle/service/ipc_helpers.h" | 23 | #include "core/hle/service/ipc_helpers.h" |
| 24 | #include "core/memory.h" | 24 | #include "core/memory.h" |
| 25 | 25 | ||
| 26 | namespace { | ||
| 27 | static thread_local std::array read_buffer_data_a{ | ||
| 28 | Common::ScratchBuffer<u8>(), | ||
| 29 | Common::ScratchBuffer<u8>(), | ||
| 30 | Common::ScratchBuffer<u8>(), | ||
| 31 | }; | ||
| 32 | static thread_local std::array read_buffer_data_x{ | ||
| 33 | Common::ScratchBuffer<u8>(), | ||
| 34 | Common::ScratchBuffer<u8>(), | ||
| 35 | Common::ScratchBuffer<u8>(), | ||
| 36 | }; | ||
| 37 | } // Anonymous namespace | ||
| 38 | |||
| 26 | namespace Service { | 39 | namespace Service { |
| 27 | 40 | ||
| 28 | SessionRequestHandler::SessionRequestHandler(Kernel::KernelCore& kernel_, const char* service_name_) | 41 | SessionRequestHandler::SessionRequestHandler(Kernel::KernelCore& kernel_, const char* service_name_) |
| @@ -328,26 +341,61 @@ std::vector<u8> HLERequestContext::ReadBufferCopy(std::size_t buffer_index) cons | |||
| 328 | } | 341 | } |
| 329 | } | 342 | } |
| 330 | 343 | ||
| 331 | std::span<const u8> HLERequestContext::ReadBuffer(std::size_t buffer_index) const { | 344 | std::span<const u8> HLERequestContext::ReadBufferA(std::size_t buffer_index) const { |
| 332 | static thread_local std::array read_buffer_a{ | 345 | static thread_local std::array read_buffer_a{ |
| 333 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), | 346 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), |
| 334 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), | 347 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), |
| 348 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), | ||
| 335 | }; | 349 | }; |
| 336 | static thread_local std::array read_buffer_data_a{ | 350 | |
| 337 | Common::ScratchBuffer<u8>(), | 351 | ASSERT_OR_EXECUTE_MSG( |
| 338 | Common::ScratchBuffer<u8>(), | 352 | BufferDescriptorA().size() > buffer_index, { return {}; }, |
| 339 | }; | 353 | "BufferDescriptorA invalid buffer_index {}", buffer_index); |
| 354 | auto& read_buffer = read_buffer_a[buffer_index]; | ||
| 355 | return read_buffer.Read(BufferDescriptorA()[buffer_index].Address(), | ||
| 356 | BufferDescriptorA()[buffer_index].Size(), | ||
| 357 | &read_buffer_data_a[buffer_index]); | ||
| 358 | } | ||
| 359 | |||
| 360 | std::span<const u8> HLERequestContext::ReadBufferX(std::size_t buffer_index) const { | ||
| 340 | static thread_local std::array read_buffer_x{ | 361 | static thread_local std::array read_buffer_x{ |
| 341 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), | 362 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), |
| 342 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), | 363 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), |
| 364 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), | ||
| 365 | }; | ||
| 366 | |||
| 367 | ASSERT_OR_EXECUTE_MSG( | ||
| 368 | BufferDescriptorX().size() > buffer_index, { return {}; }, | ||
| 369 | "BufferDescriptorX invalid buffer_index {}", buffer_index); | ||
| 370 | auto& read_buffer = read_buffer_x[buffer_index]; | ||
| 371 | return read_buffer.Read(BufferDescriptorX()[buffer_index].Address(), | ||
| 372 | BufferDescriptorX()[buffer_index].Size(), | ||
| 373 | &read_buffer_data_x[buffer_index]); | ||
| 374 | } | ||
| 375 | |||
| 376 | std::span<const u8> HLERequestContext::ReadBuffer(std::size_t buffer_index) const { | ||
| 377 | static thread_local std::array read_buffer_a{ | ||
| 378 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), | ||
| 379 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), | ||
| 380 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), | ||
| 343 | }; | 381 | }; |
| 344 | static thread_local std::array read_buffer_data_x{ | 382 | static thread_local std::array read_buffer_x{ |
| 345 | Common::ScratchBuffer<u8>(), | 383 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), |
| 346 | Common::ScratchBuffer<u8>(), | 384 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), |
| 385 | Core::Memory::CpuGuestMemory<u8, Core::Memory::GuestMemoryFlags::SafeRead>(memory, 0, 0), | ||
| 347 | }; | 386 | }; |
| 348 | 387 | ||
| 349 | const bool is_buffer_a{BufferDescriptorA().size() > buffer_index && | 388 | const bool is_buffer_a{BufferDescriptorA().size() > buffer_index && |
| 350 | BufferDescriptorA()[buffer_index].Size()}; | 389 | BufferDescriptorA()[buffer_index].Size()}; |
| 390 | const bool is_buffer_x{BufferDescriptorX().size() > buffer_index && | ||
| 391 | BufferDescriptorX()[buffer_index].Size()}; | ||
| 392 | |||
| 393 | if (is_buffer_a && is_buffer_x) { | ||
| 394 | LOG_WARNING(Input, "Both buffer descriptors are available a.size={}, x.size={}", | ||
| 395 | BufferDescriptorA()[buffer_index].Size(), | ||
| 396 | BufferDescriptorX()[buffer_index].Size()); | ||
| 397 | } | ||
| 398 | |||
| 351 | if (is_buffer_a) { | 399 | if (is_buffer_a) { |
| 352 | ASSERT_OR_EXECUTE_MSG( | 400 | ASSERT_OR_EXECUTE_MSG( |
| 353 | BufferDescriptorA().size() > buffer_index, { return {}; }, | 401 | BufferDescriptorA().size() > buffer_index, { return {}; }, |
diff --git a/src/core/hle/service/hle_ipc.h b/src/core/hle/service/hle_ipc.h index 4bd24c899..ad5259a5c 100644 --- a/src/core/hle/service/hle_ipc.h +++ b/src/core/hle/service/hle_ipc.h | |||
| @@ -253,6 +253,12 @@ public: | |||
| 253 | return domain_message_header.has_value(); | 253 | return domain_message_header.has_value(); |
| 254 | } | 254 | } |
| 255 | 255 | ||
| 256 | /// Helper function to get a span of a buffer using the buffer descriptor A | ||
| 257 | [[nodiscard]] std::span<const u8> ReadBufferA(std::size_t buffer_index = 0) const; | ||
| 258 | |||
| 259 | /// Helper function to get a span of a buffer using the buffer descriptor X | ||
| 260 | [[nodiscard]] std::span<const u8> ReadBufferX(std::size_t buffer_index = 0) const; | ||
| 261 | |||
| 256 | /// Helper function to get a span of a buffer using the appropriate buffer descriptor | 262 | /// Helper function to get a span of a buffer using the appropriate buffer descriptor |
| 257 | [[nodiscard]] std::span<const u8> ReadBuffer(std::size_t buffer_index = 0) const; | 263 | [[nodiscard]] std::span<const u8> ReadBuffer(std::size_t buffer_index = 0) const; |
| 258 | 264 | ||
diff --git a/src/core/hle/service/jit/jit_context.cpp b/src/core/hle/service/jit/jit_context.cpp index 4ed3f02e2..0090e8568 100644 --- a/src/core/hle/service/jit/jit_context.cpp +++ b/src/core/hle/service/jit/jit_context.cpp | |||
| @@ -156,6 +156,8 @@ public: | |||
| 156 | 156 | ||
| 157 | bool LoadNRO(std::span<const u8> data) { | 157 | bool LoadNRO(std::span<const u8> data) { |
| 158 | local_memory.clear(); | 158 | local_memory.clear(); |
| 159 | |||
| 160 | relocbase = local_memory.size(); | ||
| 159 | local_memory.insert(local_memory.end(), data.begin(), data.end()); | 161 | local_memory.insert(local_memory.end(), data.begin(), data.end()); |
| 160 | 162 | ||
| 161 | if (FixupRelocations()) { | 163 | if (FixupRelocations()) { |
| @@ -181,8 +183,8 @@ public: | |||
| 181 | // https://refspecs.linuxbase.org/elf/gabi4+/ch5.dynamic.html | 183 | // https://refspecs.linuxbase.org/elf/gabi4+/ch5.dynamic.html |
| 182 | // https://refspecs.linuxbase.org/elf/gabi4+/ch4.reloc.html | 184 | // https://refspecs.linuxbase.org/elf/gabi4+/ch4.reloc.html |
| 183 | VAddr dynamic_offset{mod_offset + callbacks->MemoryRead32(mod_offset + 4)}; | 185 | VAddr dynamic_offset{mod_offset + callbacks->MemoryRead32(mod_offset + 4)}; |
| 184 | VAddr rela_dyn = 0; | 186 | VAddr rela_dyn = 0, relr_dyn = 0; |
| 185 | size_t num_rela = 0; | 187 | size_t num_rela = 0, num_relr = 0; |
| 186 | while (true) { | 188 | while (true) { |
| 187 | const auto dyn{callbacks->ReadMemory<Elf64_Dyn>(dynamic_offset)}; | 189 | const auto dyn{callbacks->ReadMemory<Elf64_Dyn>(dynamic_offset)}; |
| 188 | dynamic_offset += sizeof(Elf64_Dyn); | 190 | dynamic_offset += sizeof(Elf64_Dyn); |
| @@ -196,6 +198,12 @@ public: | |||
| 196 | if (dyn.d_tag == ElfDtRelasz) { | 198 | if (dyn.d_tag == ElfDtRelasz) { |
| 197 | num_rela = dyn.d_un.d_val / sizeof(Elf64_Rela); | 199 | num_rela = dyn.d_un.d_val / sizeof(Elf64_Rela); |
| 198 | } | 200 | } |
| 201 | if (dyn.d_tag == ElfDtRelr) { | ||
| 202 | relr_dyn = dyn.d_un.d_ptr; | ||
| 203 | } | ||
| 204 | if (dyn.d_tag == ElfDtRelrsz) { | ||
| 205 | num_relr = dyn.d_un.d_val / sizeof(Elf64_Relr); | ||
| 206 | } | ||
| 199 | } | 207 | } |
| 200 | 208 | ||
| 201 | for (size_t i = 0; i < num_rela; i++) { | 209 | for (size_t i = 0; i < num_rela; i++) { |
| @@ -207,6 +215,29 @@ public: | |||
| 207 | callbacks->MemoryWrite64(rela.r_offset, contents + rela.r_addend); | 215 | callbacks->MemoryWrite64(rela.r_offset, contents + rela.r_addend); |
| 208 | } | 216 | } |
| 209 | 217 | ||
| 218 | VAddr relr_where = 0; | ||
| 219 | for (size_t i = 0; i < num_relr; i++) { | ||
| 220 | const auto relr{callbacks->ReadMemory<Elf64_Relr>(relr_dyn + i * sizeof(Elf64_Relr))}; | ||
| 221 | const auto incr{[&](VAddr where) { | ||
| 222 | callbacks->MemoryWrite64(where, callbacks->MemoryRead64(where) + relocbase); | ||
| 223 | }}; | ||
| 224 | |||
| 225 | if ((relr & 1) == 0) { | ||
| 226 | // where pointer | ||
| 227 | relr_where = relocbase + relr; | ||
| 228 | incr(relr_where); | ||
| 229 | relr_where += sizeof(Elf64_Addr); | ||
| 230 | } else { | ||
| 231 | // bitmap | ||
| 232 | for (int bit = 1; bit < 64; bit++) { | ||
| 233 | if ((relr & (1ULL << bit)) != 0) { | ||
| 234 | incr(relr_where + i * sizeof(Elf64_Addr)); | ||
| 235 | } | ||
| 236 | } | ||
| 237 | relr_where += 63 * sizeof(Elf64_Addr); | ||
| 238 | } | ||
| 239 | } | ||
| 240 | |||
| 210 | return true; | 241 | return true; |
| 211 | } | 242 | } |
| 212 | 243 | ||
| @@ -313,6 +344,7 @@ public: | |||
| 313 | Core::Memory::Memory& memory; | 344 | Core::Memory::Memory& memory; |
| 314 | VAddr top_of_stack; | 345 | VAddr top_of_stack; |
| 315 | VAddr heap_pointer; | 346 | VAddr heap_pointer; |
| 347 | VAddr relocbase; | ||
| 316 | }; | 348 | }; |
| 317 | 349 | ||
| 318 | void DynarmicCallbacks64::CallSVC(u32 swi) { | 350 | void DynarmicCallbacks64::CallSVC(u32 swi) { |
diff --git a/src/core/hle/service/kernel_helpers.cpp b/src/core/hle/service/kernel_helpers.cpp index 6a313a03b..f51e63564 100644 --- a/src/core/hle/service/kernel_helpers.cpp +++ b/src/core/hle/service/kernel_helpers.cpp | |||
| @@ -21,10 +21,8 @@ ServiceContext::ServiceContext(Core::System& system_, std::string name_) | |||
| 21 | 21 | ||
| 22 | // Create the process. | 22 | // Create the process. |
| 23 | process = Kernel::KProcess::Create(kernel); | 23 | process = Kernel::KProcess::Create(kernel); |
| 24 | ASSERT(Kernel::KProcess::Initialize(process, system_, std::move(name_), | 24 | ASSERT(R_SUCCEEDED(process->Initialize(Kernel::Svc::CreateProcessParameter{}, |
| 25 | Kernel::KProcess::ProcessType::KernelInternal, | 25 | kernel.GetSystemResourceLimit(), false))); |
| 26 | kernel.GetSystemResourceLimit()) | ||
| 27 | .IsSuccess()); | ||
| 28 | 26 | ||
| 29 | // Register the process. | 27 | // Register the process. |
| 30 | Kernel::KProcess::Register(kernel, process); | 28 | Kernel::KProcess::Register(kernel, process); |
diff --git a/src/core/hle/service/mii/types/core_data.cpp b/src/core/hle/service/mii/types/core_data.cpp index 970c748ca..ba1da76ba 100644 --- a/src/core/hle/service/mii/types/core_data.cpp +++ b/src/core/hle/service/mii/types/core_data.cpp | |||
| @@ -41,6 +41,7 @@ void CoreData::BuildRandom(Age age, Gender gender, Race race) { | |||
| 41 | } | 41 | } |
| 42 | } | 42 | } |
| 43 | 43 | ||
| 44 | SetDefault(); | ||
| 44 | SetGender(gender); | 45 | SetGender(gender); |
| 45 | SetFavoriteColor(MiiUtil::GetRandomValue(FavoriteColor::Max)); | 46 | SetFavoriteColor(MiiUtil::GetRandomValue(FavoriteColor::Max)); |
| 46 | SetRegionMove(0); | 47 | SetRegionMove(0); |
diff --git a/src/core/hle/service/nifm/nifm.cpp b/src/core/hle/service/nifm/nifm.cpp index 21b06d10b..22dc55a6d 100644 --- a/src/core/hle/service/nifm/nifm.cpp +++ b/src/core/hle/service/nifm/nifm.cpp | |||
| @@ -545,6 +545,16 @@ void IGeneralService::IsAnyInternetRequestAccepted(HLERequestContext& ctx) { | |||
| 545 | } | 545 | } |
| 546 | } | 546 | } |
| 547 | 547 | ||
| 548 | void IGeneralService::IsAnyForegroundRequestAccepted(HLERequestContext& ctx) { | ||
| 549 | const bool is_accepted{}; | ||
| 550 | |||
| 551 | LOG_WARNING(Service_NIFM, "(STUBBED) called, is_accepted={}", is_accepted); | ||
| 552 | |||
| 553 | IPC::ResponseBuilder rb{ctx, 3}; | ||
| 554 | rb.Push(ResultSuccess); | ||
| 555 | rb.Push<u8>(is_accepted); | ||
| 556 | } | ||
| 557 | |||
| 548 | IGeneralService::IGeneralService(Core::System& system_) | 558 | IGeneralService::IGeneralService(Core::System& system_) |
| 549 | : ServiceFramework{system_, "IGeneralService"}, network{system_.GetRoomNetwork()} { | 559 | : ServiceFramework{system_, "IGeneralService"}, network{system_.GetRoomNetwork()} { |
| 550 | // clang-format off | 560 | // clang-format off |
| @@ -569,7 +579,7 @@ IGeneralService::IGeneralService(Core::System& system_) | |||
| 569 | {19, nullptr, "SetEthernetCommunicationEnabled"}, | 579 | {19, nullptr, "SetEthernetCommunicationEnabled"}, |
| 570 | {20, &IGeneralService::IsEthernetCommunicationEnabled, "IsEthernetCommunicationEnabled"}, | 580 | {20, &IGeneralService::IsEthernetCommunicationEnabled, "IsEthernetCommunicationEnabled"}, |
| 571 | {21, &IGeneralService::IsAnyInternetRequestAccepted, "IsAnyInternetRequestAccepted"}, | 581 | {21, &IGeneralService::IsAnyInternetRequestAccepted, "IsAnyInternetRequestAccepted"}, |
| 572 | {22, nullptr, "IsAnyForegroundRequestAccepted"}, | 582 | {22, &IGeneralService::IsAnyForegroundRequestAccepted, "IsAnyForegroundRequestAccepted"}, |
| 573 | {23, nullptr, "PutToSleep"}, | 583 | {23, nullptr, "PutToSleep"}, |
| 574 | {24, nullptr, "WakeUp"}, | 584 | {24, nullptr, "WakeUp"}, |
| 575 | {25, nullptr, "GetSsidListVersion"}, | 585 | {25, nullptr, "GetSsidListVersion"}, |
diff --git a/src/core/hle/service/nifm/nifm.h b/src/core/hle/service/nifm/nifm.h index ae99c4695..b74b66438 100644 --- a/src/core/hle/service/nifm/nifm.h +++ b/src/core/hle/service/nifm/nifm.h | |||
| @@ -35,6 +35,7 @@ private: | |||
| 35 | void GetInternetConnectionStatus(HLERequestContext& ctx); | 35 | void GetInternetConnectionStatus(HLERequestContext& ctx); |
| 36 | void IsEthernetCommunicationEnabled(HLERequestContext& ctx); | 36 | void IsEthernetCommunicationEnabled(HLERequestContext& ctx); |
| 37 | void IsAnyInternetRequestAccepted(HLERequestContext& ctx); | 37 | void IsAnyInternetRequestAccepted(HLERequestContext& ctx); |
| 38 | void IsAnyForegroundRequestAccepted(HLERequestContext& ctx); | ||
| 38 | 39 | ||
| 39 | Network::RoomNetwork& network; | 40 | Network::RoomNetwork& network; |
| 40 | }; | 41 | }; |
diff --git a/src/core/hle/service/ns/ns.cpp b/src/core/hle/service/ns/ns.cpp index 6e0baf0be..f9e0e272d 100644 --- a/src/core/hle/service/ns/ns.cpp +++ b/src/core/hle/service/ns/ns.cpp | |||
| @@ -7,6 +7,7 @@ | |||
| 7 | #include "core/file_sys/control_metadata.h" | 7 | #include "core/file_sys/control_metadata.h" |
| 8 | #include "core/file_sys/patch_manager.h" | 8 | #include "core/file_sys/patch_manager.h" |
| 9 | #include "core/file_sys/vfs.h" | 9 | #include "core/file_sys/vfs.h" |
| 10 | #include "core/hle/service/filesystem/filesystem.h" | ||
| 10 | #include "core/hle/service/glue/glue_manager.h" | 11 | #include "core/hle/service/glue/glue_manager.h" |
| 11 | #include "core/hle/service/ipc_helpers.h" | 12 | #include "core/hle/service/ipc_helpers.h" |
| 12 | #include "core/hle/service/ns/errors.h" | 13 | #include "core/hle/service/ns/errors.h" |
| @@ -502,8 +503,8 @@ IContentManagementInterface::IContentManagementInterface(Core::System& system_) | |||
| 502 | static const FunctionInfo functions[] = { | 503 | static const FunctionInfo functions[] = { |
| 503 | {11, nullptr, "CalculateApplicationOccupiedSize"}, | 504 | {11, nullptr, "CalculateApplicationOccupiedSize"}, |
| 504 | {43, nullptr, "CheckSdCardMountStatus"}, | 505 | {43, nullptr, "CheckSdCardMountStatus"}, |
| 505 | {47, nullptr, "GetTotalSpaceSize"}, | 506 | {47, &IContentManagementInterface::GetTotalSpaceSize, "GetTotalSpaceSize"}, |
| 506 | {48, nullptr, "GetFreeSpaceSize"}, | 507 | {48, &IContentManagementInterface::GetFreeSpaceSize, "GetFreeSpaceSize"}, |
| 507 | {600, nullptr, "CountApplicationContentMeta"}, | 508 | {600, nullptr, "CountApplicationContentMeta"}, |
| 508 | {601, nullptr, "ListApplicationContentMetaStatus"}, | 509 | {601, nullptr, "ListApplicationContentMetaStatus"}, |
| 509 | {605, nullptr, "ListApplicationContentMetaStatusWithRightsCheck"}, | 510 | {605, nullptr, "ListApplicationContentMetaStatusWithRightsCheck"}, |
| @@ -516,6 +517,28 @@ IContentManagementInterface::IContentManagementInterface(Core::System& system_) | |||
| 516 | 517 | ||
| 517 | IContentManagementInterface::~IContentManagementInterface() = default; | 518 | IContentManagementInterface::~IContentManagementInterface() = default; |
| 518 | 519 | ||
| 520 | void IContentManagementInterface::GetTotalSpaceSize(HLERequestContext& ctx) { | ||
| 521 | IPC::RequestParser rp{ctx}; | ||
| 522 | const auto storage{rp.PopEnum<FileSys::StorageId>()}; | ||
| 523 | |||
| 524 | LOG_INFO(Service_Capture, "called, storage={}", storage); | ||
| 525 | |||
| 526 | IPC::ResponseBuilder rb{ctx, 4}; | ||
| 527 | rb.Push(ResultSuccess); | ||
| 528 | rb.Push<u64>(system.GetFileSystemController().GetTotalSpaceSize(storage)); | ||
| 529 | } | ||
| 530 | |||
| 531 | void IContentManagementInterface::GetFreeSpaceSize(HLERequestContext& ctx) { | ||
| 532 | IPC::RequestParser rp{ctx}; | ||
| 533 | const auto storage{rp.PopEnum<FileSys::StorageId>()}; | ||
| 534 | |||
| 535 | LOG_INFO(Service_Capture, "called, storage={}", storage); | ||
| 536 | |||
| 537 | IPC::ResponseBuilder rb{ctx, 4}; | ||
| 538 | rb.Push(ResultSuccess); | ||
| 539 | rb.Push<u64>(system.GetFileSystemController().GetFreeSpaceSize(storage)); | ||
| 540 | } | ||
| 541 | |||
| 519 | IDocumentInterface::IDocumentInterface(Core::System& system_) | 542 | IDocumentInterface::IDocumentInterface(Core::System& system_) |
| 520 | : ServiceFramework{system_, "IDocumentInterface"} { | 543 | : ServiceFramework{system_, "IDocumentInterface"} { |
| 521 | // clang-format off | 544 | // clang-format off |
diff --git a/src/core/hle/service/ns/ns.h b/src/core/hle/service/ns/ns.h index 175dad780..34d2a45dc 100644 --- a/src/core/hle/service/ns/ns.h +++ b/src/core/hle/service/ns/ns.h | |||
| @@ -48,6 +48,10 @@ class IContentManagementInterface final : public ServiceFramework<IContentManage | |||
| 48 | public: | 48 | public: |
| 49 | explicit IContentManagementInterface(Core::System& system_); | 49 | explicit IContentManagementInterface(Core::System& system_); |
| 50 | ~IContentManagementInterface() override; | 50 | ~IContentManagementInterface() override; |
| 51 | |||
| 52 | private: | ||
| 53 | void GetTotalSpaceSize(HLERequestContext& ctx); | ||
| 54 | void GetFreeSpaceSize(HLERequestContext& ctx); | ||
| 51 | }; | 55 | }; |
| 52 | 56 | ||
| 53 | class IDocumentInterface final : public ServiceFramework<IDocumentInterface> { | 57 | class IDocumentInterface final : public ServiceFramework<IDocumentInterface> { |
diff --git a/src/core/hle/service/nvnflinger/buffer_queue_core.cpp b/src/core/hle/service/nvnflinger/buffer_queue_core.cpp index 2dbe29616..ed66f6f5b 100644 --- a/src/core/hle/service/nvnflinger/buffer_queue_core.cpp +++ b/src/core/hle/service/nvnflinger/buffer_queue_core.cpp | |||
| @@ -41,7 +41,7 @@ bool BufferQueueCore::WaitForDequeueCondition(std::unique_lock<std::mutex>& lk) | |||
| 41 | s32 BufferQueueCore::GetMinUndequeuedBufferCountLocked(bool async) const { | 41 | s32 BufferQueueCore::GetMinUndequeuedBufferCountLocked(bool async) const { |
| 42 | // If DequeueBuffer is allowed to error out, we don't have to add an extra buffer. | 42 | // If DequeueBuffer is allowed to error out, we don't have to add an extra buffer. |
| 43 | if (!use_async_buffer) { | 43 | if (!use_async_buffer) { |
| 44 | return max_acquired_buffer_count; | 44 | return 0; |
| 45 | } | 45 | } |
| 46 | 46 | ||
| 47 | if (dequeue_buffer_cannot_block || async) { | 47 | if (dequeue_buffer_cannot_block || async) { |
| @@ -52,7 +52,7 @@ s32 BufferQueueCore::GetMinUndequeuedBufferCountLocked(bool async) const { | |||
| 52 | } | 52 | } |
| 53 | 53 | ||
| 54 | s32 BufferQueueCore::GetMinMaxBufferCountLocked(bool async) const { | 54 | s32 BufferQueueCore::GetMinMaxBufferCountLocked(bool async) const { |
| 55 | return GetMinUndequeuedBufferCountLocked(async) + 1; | 55 | return GetMinUndequeuedBufferCountLocked(async); |
| 56 | } | 56 | } |
| 57 | 57 | ||
| 58 | s32 BufferQueueCore::GetMaxBufferCountLocked(bool async) const { | 58 | s32 BufferQueueCore::GetMaxBufferCountLocked(bool async) const { |
| @@ -61,7 +61,7 @@ s32 BufferQueueCore::GetMaxBufferCountLocked(bool async) const { | |||
| 61 | 61 | ||
| 62 | if (override_max_buffer_count != 0) { | 62 | if (override_max_buffer_count != 0) { |
| 63 | ASSERT(override_max_buffer_count >= min_buffer_count); | 63 | ASSERT(override_max_buffer_count >= min_buffer_count); |
| 64 | max_buffer_count = override_max_buffer_count; | 64 | return override_max_buffer_count; |
| 65 | } | 65 | } |
| 66 | 66 | ||
| 67 | // Any buffers that are dequeued by the producer or sitting in the queue waiting to be consumed | 67 | // Any buffers that are dequeued by the producer or sitting in the queue waiting to be consumed |
diff --git a/src/core/hle/service/nvnflinger/buffer_queue_producer.cpp b/src/core/hle/service/nvnflinger/buffer_queue_producer.cpp index dc6917d5d..6e7a49658 100644 --- a/src/core/hle/service/nvnflinger/buffer_queue_producer.cpp +++ b/src/core/hle/service/nvnflinger/buffer_queue_producer.cpp | |||
| @@ -134,7 +134,7 @@ Status BufferQueueProducer::WaitForFreeSlotThenRelock(bool async, s32* found, St | |||
| 134 | const s32 max_buffer_count = core->GetMaxBufferCountLocked(async); | 134 | const s32 max_buffer_count = core->GetMaxBufferCountLocked(async); |
| 135 | if (async && core->override_max_buffer_count) { | 135 | if (async && core->override_max_buffer_count) { |
| 136 | if (core->override_max_buffer_count < max_buffer_count) { | 136 | if (core->override_max_buffer_count < max_buffer_count) { |
| 137 | LOG_ERROR(Service_Nvnflinger, "async mode is invalid with buffer count override"); | 137 | *found = BufferQueueCore::INVALID_BUFFER_SLOT; |
| 138 | return Status::BadValue; | 138 | return Status::BadValue; |
| 139 | } | 139 | } |
| 140 | } | 140 | } |
| @@ -142,7 +142,8 @@ Status BufferQueueProducer::WaitForFreeSlotThenRelock(bool async, s32* found, St | |||
| 142 | // Free up any buffers that are in slots beyond the max buffer count | 142 | // Free up any buffers that are in slots beyond the max buffer count |
| 143 | for (s32 s = max_buffer_count; s < BufferQueueDefs::NUM_BUFFER_SLOTS; ++s) { | 143 | for (s32 s = max_buffer_count; s < BufferQueueDefs::NUM_BUFFER_SLOTS; ++s) { |
| 144 | ASSERT(slots[s].buffer_state == BufferState::Free); | 144 | ASSERT(slots[s].buffer_state == BufferState::Free); |
| 145 | if (slots[s].graphic_buffer != nullptr) { | 145 | if (slots[s].graphic_buffer != nullptr && slots[s].buffer_state == BufferState::Free && |
| 146 | !slots[s].is_preallocated) { | ||
| 146 | core->FreeBufferLocked(s); | 147 | core->FreeBufferLocked(s); |
| 147 | *return_flags |= Status::ReleaseAllBuffers; | 148 | *return_flags |= Status::ReleaseAllBuffers; |
| 148 | } | 149 | } |
diff --git a/src/core/hle/service/nvnflinger/fb_share_buffer_manager.cpp b/src/core/hle/service/nvnflinger/fb_share_buffer_manager.cpp index 469a53244..2e29bc848 100644 --- a/src/core/hle/service/nvnflinger/fb_share_buffer_manager.cpp +++ b/src/core/hle/service/nvnflinger/fb_share_buffer_manager.cpp | |||
| @@ -46,7 +46,7 @@ Result AllocateIoForProcessAddressSpace(Common::ProcessAddress* out_map_address, | |||
| 46 | // Get bounds of where mapping is possible. | 46 | // Get bounds of where mapping is possible. |
| 47 | const VAddr alias_code_begin = GetInteger(page_table.GetAliasCodeRegionStart()); | 47 | const VAddr alias_code_begin = GetInteger(page_table.GetAliasCodeRegionStart()); |
| 48 | const VAddr alias_code_size = page_table.GetAliasCodeRegionSize() / YUZU_PAGESIZE; | 48 | const VAddr alias_code_size = page_table.GetAliasCodeRegionSize() / YUZU_PAGESIZE; |
| 49 | const auto state = Kernel::KMemoryState::Io; | 49 | const auto state = Kernel::KMemoryState::IoMemory; |
| 50 | const auto perm = Kernel::KMemoryPermission::UserReadWrite; | 50 | const auto perm = Kernel::KMemoryPermission::UserReadWrite; |
| 51 | std::mt19937_64 rng{process->GetRandomEntropy(0)}; | 51 | std::mt19937_64 rng{process->GetRandomEntropy(0)}; |
| 52 | 52 | ||
diff --git a/src/core/hle/service/nvnflinger/nvnflinger.cpp b/src/core/hle/service/nvnflinger/nvnflinger.cpp index a07c621d9..bebb45eae 100644 --- a/src/core/hle/service/nvnflinger/nvnflinger.cpp +++ b/src/core/hle/service/nvnflinger/nvnflinger.cpp | |||
| @@ -66,7 +66,6 @@ Nvnflinger::Nvnflinger(Core::System& system_, HosBinderDriverServer& hos_binder_ | |||
| 66 | "ScreenComposition", | 66 | "ScreenComposition", |
| 67 | [this](std::uintptr_t, s64 time, | 67 | [this](std::uintptr_t, s64 time, |
| 68 | std::chrono::nanoseconds ns_late) -> std::optional<std::chrono::nanoseconds> { | 68 | std::chrono::nanoseconds ns_late) -> std::optional<std::chrono::nanoseconds> { |
| 69 | { const auto lock_guard = Lock(); } | ||
| 70 | vsync_signal.Set(); | 69 | vsync_signal.Set(); |
| 71 | return std::chrono::nanoseconds(GetNextTicks()); | 70 | return std::chrono::nanoseconds(GetNextTicks()); |
| 72 | }); | 71 | }); |
| @@ -99,6 +98,7 @@ Nvnflinger::~Nvnflinger() { | |||
| 99 | } | 98 | } |
| 100 | 99 | ||
| 101 | ShutdownLayers(); | 100 | ShutdownLayers(); |
| 101 | vsync_thread = {}; | ||
| 102 | 102 | ||
| 103 | if (nvdrv) { | 103 | if (nvdrv) { |
| 104 | nvdrv->Close(disp_fd); | 104 | nvdrv->Close(disp_fd); |
| @@ -106,6 +106,7 @@ Nvnflinger::~Nvnflinger() { | |||
| 106 | } | 106 | } |
| 107 | 107 | ||
| 108 | void Nvnflinger::ShutdownLayers() { | 108 | void Nvnflinger::ShutdownLayers() { |
| 109 | const auto lock_guard = Lock(); | ||
| 109 | for (auto& display : displays) { | 110 | for (auto& display : displays) { |
| 110 | for (size_t layer = 0; layer < display.GetNumLayers(); ++layer) { | 111 | for (size_t layer = 0; layer < display.GetNumLayers(); ++layer) { |
| 111 | display.GetLayer(layer).Core().NotifyShutdown(); | 112 | display.GetLayer(layer).Core().NotifyShutdown(); |
| @@ -229,16 +230,6 @@ VI::Layer* Nvnflinger::FindLayer(u64 display_id, u64 layer_id) { | |||
| 229 | return display->FindLayer(layer_id); | 230 | return display->FindLayer(layer_id); |
| 230 | } | 231 | } |
| 231 | 232 | ||
| 232 | const VI::Layer* Nvnflinger::FindLayer(u64 display_id, u64 layer_id) const { | ||
| 233 | const auto* const display = FindDisplay(display_id); | ||
| 234 | |||
| 235 | if (display == nullptr) { | ||
| 236 | return nullptr; | ||
| 237 | } | ||
| 238 | |||
| 239 | return display->FindLayer(layer_id); | ||
| 240 | } | ||
| 241 | |||
| 242 | VI::Layer* Nvnflinger::FindOrCreateLayer(u64 display_id, u64 layer_id) { | 233 | VI::Layer* Nvnflinger::FindOrCreateLayer(u64 display_id, u64 layer_id) { |
| 243 | auto* const display = FindDisplay(display_id); | 234 | auto* const display = FindDisplay(display_id); |
| 244 | 235 | ||
| @@ -288,7 +279,6 @@ void Nvnflinger::Compose() { | |||
| 288 | auto nvdisp = nvdrv->GetDevice<Nvidia::Devices::nvdisp_disp0>(disp_fd); | 279 | auto nvdisp = nvdrv->GetDevice<Nvidia::Devices::nvdisp_disp0>(disp_fd); |
| 289 | ASSERT(nvdisp); | 280 | ASSERT(nvdisp); |
| 290 | 281 | ||
| 291 | guard->unlock(); | ||
| 292 | Common::Rectangle<int> crop_rect{ | 282 | Common::Rectangle<int> crop_rect{ |
| 293 | static_cast<int>(buffer.crop.Left()), static_cast<int>(buffer.crop.Top()), | 283 | static_cast<int>(buffer.crop.Left()), static_cast<int>(buffer.crop.Top()), |
| 294 | static_cast<int>(buffer.crop.Right()), static_cast<int>(buffer.crop.Bottom())}; | 284 | static_cast<int>(buffer.crop.Right()), static_cast<int>(buffer.crop.Bottom())}; |
| @@ -299,7 +289,6 @@ void Nvnflinger::Compose() { | |||
| 299 | buffer.fence.fences, buffer.fence.num_fences); | 289 | buffer.fence.fences, buffer.fence.num_fences); |
| 300 | 290 | ||
| 301 | MicroProfileFlip(); | 291 | MicroProfileFlip(); |
| 302 | guard->lock(); | ||
| 303 | 292 | ||
| 304 | swap_interval = buffer.swap_interval; | 293 | swap_interval = buffer.swap_interval; |
| 305 | 294 | ||
diff --git a/src/core/hle/service/nvnflinger/nvnflinger.h b/src/core/hle/service/nvnflinger/nvnflinger.h index 14c783582..959d8b46b 100644 --- a/src/core/hle/service/nvnflinger/nvnflinger.h +++ b/src/core/hle/service/nvnflinger/nvnflinger.h | |||
| @@ -117,9 +117,6 @@ private: | |||
| 117 | /// Finds the layer identified by the specified ID in the desired display. | 117 | /// Finds the layer identified by the specified ID in the desired display. |
| 118 | [[nodiscard]] VI::Layer* FindLayer(u64 display_id, u64 layer_id); | 118 | [[nodiscard]] VI::Layer* FindLayer(u64 display_id, u64 layer_id); |
| 119 | 119 | ||
| 120 | /// Finds the layer identified by the specified ID in the desired display. | ||
| 121 | [[nodiscard]] const VI::Layer* FindLayer(u64 display_id, u64 layer_id) const; | ||
| 122 | |||
| 123 | /// Finds the layer identified by the specified ID in the desired display, | 120 | /// Finds the layer identified by the specified ID in the desired display, |
| 124 | /// or creates the layer if it is not found. | 121 | /// or creates the layer if it is not found. |
| 125 | /// To be used when the system expects the specified ID to already exist. | 122 | /// To be used when the system expects the specified ID to already exist. |
diff --git a/src/core/hle/service/pctl/pctl_module.cpp b/src/core/hle/service/pctl/pctl_module.cpp index 5db1703d1..6a7fd72bc 100644 --- a/src/core/hle/service/pctl/pctl_module.cpp +++ b/src/core/hle/service/pctl/pctl_module.cpp | |||
| @@ -33,7 +33,7 @@ public: | |||
| 33 | {1001, &IParentalControlService::CheckFreeCommunicationPermission, "CheckFreeCommunicationPermission"}, | 33 | {1001, &IParentalControlService::CheckFreeCommunicationPermission, "CheckFreeCommunicationPermission"}, |
| 34 | {1002, nullptr, "ConfirmLaunchApplicationPermission"}, | 34 | {1002, nullptr, "ConfirmLaunchApplicationPermission"}, |
| 35 | {1003, nullptr, "ConfirmResumeApplicationPermission"}, | 35 | {1003, nullptr, "ConfirmResumeApplicationPermission"}, |
| 36 | {1004, nullptr, "ConfirmSnsPostPermission"}, | 36 | {1004, &IParentalControlService::ConfirmSnsPostPermission, "ConfirmSnsPostPermission"}, |
| 37 | {1005, nullptr, "ConfirmSystemSettingsPermission"}, | 37 | {1005, nullptr, "ConfirmSystemSettingsPermission"}, |
| 38 | {1006, &IParentalControlService::IsRestrictionTemporaryUnlocked, "IsRestrictionTemporaryUnlocked"}, | 38 | {1006, &IParentalControlService::IsRestrictionTemporaryUnlocked, "IsRestrictionTemporaryUnlocked"}, |
| 39 | {1007, nullptr, "RevertRestrictionTemporaryUnlocked"}, | 39 | {1007, nullptr, "RevertRestrictionTemporaryUnlocked"}, |
| @@ -141,6 +141,12 @@ public: | |||
| 141 | service_context.CreateEvent("IParentalControlService::RequestSuspensionEvent"); | 141 | service_context.CreateEvent("IParentalControlService::RequestSuspensionEvent"); |
| 142 | } | 142 | } |
| 143 | 143 | ||
| 144 | ~IParentalControlService() { | ||
| 145 | service_context.CloseEvent(synchronization_event); | ||
| 146 | service_context.CloseEvent(unlinked_event); | ||
| 147 | service_context.CloseEvent(request_suspension_event); | ||
| 148 | }; | ||
| 149 | |||
| 144 | private: | 150 | private: |
| 145 | bool CheckFreeCommunicationPermissionImpl() const { | 151 | bool CheckFreeCommunicationPermissionImpl() const { |
| 146 | if (states.temporary_unlocked) { | 152 | if (states.temporary_unlocked) { |
| @@ -236,6 +242,13 @@ private: | |||
| 236 | states.free_communication = true; | 242 | states.free_communication = true; |
| 237 | } | 243 | } |
| 238 | 244 | ||
| 245 | void ConfirmSnsPostPermission(HLERequestContext& ctx) { | ||
| 246 | LOG_WARNING(Service_PCTL, "(STUBBED) called"); | ||
| 247 | |||
| 248 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 249 | rb.Push(Error::ResultNoFreeCommunication); | ||
| 250 | } | ||
| 251 | |||
| 239 | void IsRestrictionTemporaryUnlocked(HLERequestContext& ctx) { | 252 | void IsRestrictionTemporaryUnlocked(HLERequestContext& ctx) { |
| 240 | const bool is_temporary_unlocked = false; | 253 | const bool is_temporary_unlocked = false; |
| 241 | 254 | ||
diff --git a/src/core/hle/service/pm/pm.cpp b/src/core/hle/service/pm/pm.cpp index f9cf2dda3..d92499f05 100644 --- a/src/core/hle/service/pm/pm.cpp +++ b/src/core/hle/service/pm/pm.cpp | |||
| @@ -37,7 +37,7 @@ std::optional<Kernel::KProcess*> SearchProcessList( | |||
| 37 | void GetApplicationPidGeneric(HLERequestContext& ctx, | 37 | void GetApplicationPidGeneric(HLERequestContext& ctx, |
| 38 | const std::vector<Kernel::KProcess*>& process_list) { | 38 | const std::vector<Kernel::KProcess*>& process_list) { |
| 39 | const auto process = SearchProcessList(process_list, [](const auto& proc) { | 39 | const auto process = SearchProcessList(process_list, [](const auto& proc) { |
| 40 | return proc->GetProcessId() == Kernel::KProcess::ProcessIDMin; | 40 | return proc->GetProcessId() == Kernel::KProcess::ProcessIdMin; |
| 41 | }); | 41 | }); |
| 42 | 42 | ||
| 43 | IPC::ResponseBuilder rb{ctx, 4}; | 43 | IPC::ResponseBuilder rb{ctx, 4}; |
diff --git a/src/core/hle/service/prepo/prepo.cpp b/src/core/hle/service/prepo/prepo.cpp index ec4a84989..14e8df63a 100644 --- a/src/core/hle/service/prepo/prepo.cpp +++ b/src/core/hle/service/prepo/prepo.cpp | |||
| @@ -58,14 +58,8 @@ private: | |||
| 58 | IPC::RequestParser rp{ctx}; | 58 | IPC::RequestParser rp{ctx}; |
| 59 | const auto process_id = rp.PopRaw<u64>(); | 59 | const auto process_id = rp.PopRaw<u64>(); |
| 60 | 60 | ||
| 61 | const auto data1 = ctx.ReadBuffer(0); | 61 | const auto data1 = ctx.ReadBufferA(0); |
| 62 | const auto data2 = [&ctx] { | 62 | const auto data2 = ctx.ReadBufferX(0); |
| 63 | if (ctx.CanReadBuffer(1)) { | ||
| 64 | return ctx.ReadBuffer(1); | ||
| 65 | } | ||
| 66 | |||
| 67 | return std::span<const u8>{}; | ||
| 68 | }(); | ||
| 69 | 63 | ||
| 70 | LOG_DEBUG(Service_PREPO, | 64 | LOG_DEBUG(Service_PREPO, |
| 71 | "called, type={:02X}, process_id={:016X}, data1_size={:016X}, data2_size={:016X}", | 65 | "called, type={:02X}, process_id={:016X}, data1_size={:016X}, data2_size={:016X}", |
| @@ -85,14 +79,8 @@ private: | |||
| 85 | const auto user_id = rp.PopRaw<u128>(); | 79 | const auto user_id = rp.PopRaw<u128>(); |
| 86 | const auto process_id = rp.PopRaw<u64>(); | 80 | const auto process_id = rp.PopRaw<u64>(); |
| 87 | 81 | ||
| 88 | const auto data1 = ctx.ReadBuffer(0); | 82 | const auto data1 = ctx.ReadBufferA(0); |
| 89 | const auto data2 = [&ctx] { | 83 | const auto data2 = ctx.ReadBufferX(0); |
| 90 | if (ctx.CanReadBuffer(1)) { | ||
| 91 | return ctx.ReadBuffer(1); | ||
| 92 | } | ||
| 93 | |||
| 94 | return std::span<const u8>{}; | ||
| 95 | }(); | ||
| 96 | 84 | ||
| 97 | LOG_DEBUG(Service_PREPO, | 85 | LOG_DEBUG(Service_PREPO, |
| 98 | "called, type={:02X}, user_id={:016X}{:016X}, process_id={:016X}, " | 86 | "called, type={:02X}, user_id={:016X}{:016X}, process_id={:016X}, " |
| @@ -137,14 +125,8 @@ private: | |||
| 137 | IPC::RequestParser rp{ctx}; | 125 | IPC::RequestParser rp{ctx}; |
| 138 | const auto title_id = rp.PopRaw<u64>(); | 126 | const auto title_id = rp.PopRaw<u64>(); |
| 139 | 127 | ||
| 140 | const auto data1 = ctx.ReadBuffer(0); | 128 | const auto data1 = ctx.ReadBufferA(0); |
| 141 | const auto data2 = [&ctx] { | 129 | const auto data2 = ctx.ReadBufferX(0); |
| 142 | if (ctx.CanReadBuffer(1)) { | ||
| 143 | return ctx.ReadBuffer(1); | ||
| 144 | } | ||
| 145 | |||
| 146 | return std::span<const u8>{}; | ||
| 147 | }(); | ||
| 148 | 130 | ||
| 149 | LOG_DEBUG(Service_PREPO, "called, title_id={:016X}, data1_size={:016X}, data2_size={:016X}", | 131 | LOG_DEBUG(Service_PREPO, "called, title_id={:016X}, data1_size={:016X}, data2_size={:016X}", |
| 150 | title_id, data1.size(), data2.size()); | 132 | title_id, data1.size(), data2.size()); |
| @@ -161,14 +143,8 @@ private: | |||
| 161 | const auto user_id = rp.PopRaw<u128>(); | 143 | const auto user_id = rp.PopRaw<u128>(); |
| 162 | const auto title_id = rp.PopRaw<u64>(); | 144 | const auto title_id = rp.PopRaw<u64>(); |
| 163 | 145 | ||
| 164 | const auto data1 = ctx.ReadBuffer(0); | 146 | const auto data1 = ctx.ReadBufferA(0); |
| 165 | const auto data2 = [&ctx] { | 147 | const auto data2 = ctx.ReadBufferX(0); |
| 166 | if (ctx.CanReadBuffer(1)) { | ||
| 167 | return ctx.ReadBuffer(1); | ||
| 168 | } | ||
| 169 | |||
| 170 | return std::span<const u8>{}; | ||
| 171 | }(); | ||
| 172 | 148 | ||
| 173 | LOG_DEBUG(Service_PREPO, | 149 | LOG_DEBUG(Service_PREPO, |
| 174 | "called, user_id={:016X}{:016X}, title_id={:016X}, data1_size={:016X}, " | 150 | "called, user_id={:016X}{:016X}, title_id={:016X}, data1_size={:016X}, " |
diff --git a/src/core/hle/service/ptm/ts.cpp b/src/core/hle/service/ptm/ts.cpp index ca064dd90..652f38b97 100644 --- a/src/core/hle/service/ptm/ts.cpp +++ b/src/core/hle/service/ptm/ts.cpp | |||
| @@ -9,6 +9,35 @@ | |||
| 9 | 9 | ||
| 10 | namespace Service::PTM { | 10 | namespace Service::PTM { |
| 11 | 11 | ||
| 12 | enum class Location : u8 { | ||
| 13 | Internal, | ||
| 14 | External, | ||
| 15 | }; | ||
| 16 | |||
| 17 | class ISession : public ServiceFramework<ISession> { | ||
| 18 | public: | ||
| 19 | explicit ISession(Core::System& system_) : ServiceFramework{system_, "ISession"} { | ||
| 20 | // clang-format off | ||
| 21 | static const FunctionInfo functions[] = { | ||
| 22 | {0, nullptr, "GetTemperatureRange"}, | ||
| 23 | {2, nullptr, "SetMeasurementMode"}, | ||
| 24 | {4, &ISession::GetTemperature, "GetTemperature"}, | ||
| 25 | }; | ||
| 26 | // clang-format on | ||
| 27 | |||
| 28 | RegisterHandlers(functions); | ||
| 29 | } | ||
| 30 | |||
| 31 | private: | ||
| 32 | void GetTemperature(HLERequestContext& ctx) { | ||
| 33 | constexpr f32 temperature = 35; | ||
| 34 | |||
| 35 | IPC::ResponseBuilder rb{ctx, 3}; | ||
| 36 | rb.Push(ResultSuccess); | ||
| 37 | rb.Push(temperature); | ||
| 38 | } | ||
| 39 | }; | ||
| 40 | |||
| 12 | TS::TS(Core::System& system_) : ServiceFramework{system_, "ts"} { | 41 | TS::TS(Core::System& system_) : ServiceFramework{system_, "ts"} { |
| 13 | // clang-format off | 42 | // clang-format off |
| 14 | static const FunctionInfo functions[] = { | 43 | static const FunctionInfo functions[] = { |
| @@ -16,7 +45,7 @@ TS::TS(Core::System& system_) : ServiceFramework{system_, "ts"} { | |||
| 16 | {1, &TS::GetTemperature, "GetTemperature"}, | 45 | {1, &TS::GetTemperature, "GetTemperature"}, |
| 17 | {2, nullptr, "SetMeasurementMode"}, | 46 | {2, nullptr, "SetMeasurementMode"}, |
| 18 | {3, &TS::GetTemperatureMilliC, "GetTemperatureMilliC"}, | 47 | {3, &TS::GetTemperatureMilliC, "GetTemperatureMilliC"}, |
| 19 | {4, nullptr, "OpenSession"}, | 48 | {4, &TS::OpenSession, "OpenSession"}, |
| 20 | }; | 49 | }; |
| 21 | // clang-format on | 50 | // clang-format on |
| 22 | 51 | ||
| @@ -47,4 +76,13 @@ void TS::GetTemperatureMilliC(HLERequestContext& ctx) { | |||
| 47 | rb.Push(temperature); | 76 | rb.Push(temperature); |
| 48 | } | 77 | } |
| 49 | 78 | ||
| 79 | void TS::OpenSession(HLERequestContext& ctx) { | ||
| 80 | IPC::RequestParser rp{ctx}; | ||
| 81 | [[maybe_unused]] const u32 device_code = rp.Pop<u32>(); | ||
| 82 | |||
| 83 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | ||
| 84 | rb.Push(ResultSuccess); | ||
| 85 | rb.PushIpcInterface<ISession>(system); | ||
| 86 | } | ||
| 87 | |||
| 50 | } // namespace Service::PTM | 88 | } // namespace Service::PTM |
diff --git a/src/core/hle/service/ptm/ts.h b/src/core/hle/service/ptm/ts.h index c3f43d5a3..a10a91a64 100644 --- a/src/core/hle/service/ptm/ts.h +++ b/src/core/hle/service/ptm/ts.h | |||
| @@ -14,13 +14,9 @@ public: | |||
| 14 | ~TS() override; | 14 | ~TS() override; |
| 15 | 15 | ||
| 16 | private: | 16 | private: |
| 17 | enum class Location : u8 { | ||
| 18 | Internal, | ||
| 19 | External, | ||
| 20 | }; | ||
| 21 | |||
| 22 | void GetTemperature(HLERequestContext& ctx); | 17 | void GetTemperature(HLERequestContext& ctx); |
| 23 | void GetTemperatureMilliC(HLERequestContext& ctx); | 18 | void GetTemperatureMilliC(HLERequestContext& ctx); |
| 19 | void OpenSession(HLERequestContext& ctx); | ||
| 24 | }; | 20 | }; |
| 25 | 21 | ||
| 26 | } // namespace Service::PTM | 22 | } // namespace Service::PTM |
diff --git a/src/core/hle/service/set/set_sys.cpp b/src/core/hle/service/set/set_sys.cpp index 165b97dad..ec3af80af 100644 --- a/src/core/hle/service/set/set_sys.cpp +++ b/src/core/hle/service/set/set_sys.cpp | |||
| @@ -5,8 +5,13 @@ | |||
| 5 | #include "common/logging/log.h" | 5 | #include "common/logging/log.h" |
| 6 | #include "common/settings.h" | 6 | #include "common/settings.h" |
| 7 | #include "common/string_util.h" | 7 | #include "common/string_util.h" |
| 8 | #include "core/core.h" | ||
| 9 | #include "core/file_sys/content_archive.h" | ||
| 8 | #include "core/file_sys/errors.h" | 10 | #include "core/file_sys/errors.h" |
| 9 | #include "core/file_sys/system_archive/system_version.h" | 11 | #include "core/file_sys/nca_metadata.h" |
| 12 | #include "core/file_sys/registered_cache.h" | ||
| 13 | #include "core/file_sys/romfs.h" | ||
| 14 | #include "core/file_sys/system_archive/system_archive.h" | ||
| 10 | #include "core/hle/service/filesystem/filesystem.h" | 15 | #include "core/hle/service/filesystem/filesystem.h" |
| 11 | #include "core/hle/service/ipc_helpers.h" | 16 | #include "core/hle/service/ipc_helpers.h" |
| 12 | #include "core/hle/service/set/set.h" | 17 | #include "core/hle/service/set/set.h" |
| @@ -22,18 +27,30 @@ enum class GetFirmwareVersionType { | |||
| 22 | Version2, | 27 | Version2, |
| 23 | }; | 28 | }; |
| 24 | 29 | ||
| 25 | void GetFirmwareVersionImpl(HLERequestContext& ctx, GetFirmwareVersionType type) { | 30 | void GetFirmwareVersionImpl(Core::System& system, HLERequestContext& ctx, |
| 26 | LOG_WARNING(Service_SET, "called - Using hardcoded firmware version '{}'", | 31 | GetFirmwareVersionType type) { |
| 27 | FileSys::SystemArchive::GetLongDisplayVersion()); | ||
| 28 | |||
| 29 | ASSERT_MSG(ctx.GetWriteBufferSize() == 0x100, | 32 | ASSERT_MSG(ctx.GetWriteBufferSize() == 0x100, |
| 30 | "FirmwareVersion output buffer must be 0x100 bytes in size!"); | 33 | "FirmwareVersion output buffer must be 0x100 bytes in size!"); |
| 31 | 34 | ||
| 32 | // Instead of using the normal procedure of checking for the real system archive and if it | 35 | constexpr u64 FirmwareVersionSystemDataId = 0x0100000000000809; |
| 33 | // doesn't exist, synthesizing one, I feel that that would lead to strange bugs because a | 36 | auto& fsc = system.GetFileSystemController(); |
| 34 | // used is using a really old or really new SystemVersion title. The synthesized one ensures | 37 | |
| 35 | // consistence (currently reports as 5.1.0-0.0) | 38 | // Attempt to load version data from disk |
| 36 | const auto archive = FileSys::SystemArchive::SystemVersion(); | 39 | const FileSys::RegisteredCache* bis_system{}; |
| 40 | std::unique_ptr<FileSys::NCA> nca{}; | ||
| 41 | FileSys::VirtualDir romfs{}; | ||
| 42 | |||
| 43 | bis_system = fsc.GetSystemNANDContents(); | ||
| 44 | if (bis_system) { | ||
| 45 | nca = bis_system->GetEntry(FirmwareVersionSystemDataId, FileSys::ContentRecordType::Data); | ||
| 46 | } | ||
| 47 | if (nca) { | ||
| 48 | romfs = FileSys::ExtractRomFS(nca->GetRomFS()); | ||
| 49 | } | ||
| 50 | if (!romfs) { | ||
| 51 | romfs = FileSys::ExtractRomFS( | ||
| 52 | FileSys::SystemArchive::SynthesizeSystemArchive(FirmwareVersionSystemDataId)); | ||
| 53 | } | ||
| 37 | 54 | ||
| 38 | const auto early_exit_failure = [&ctx](std::string_view desc, Result code) { | 55 | const auto early_exit_failure = [&ctx](std::string_view desc, Result code) { |
| 39 | LOG_ERROR(Service_SET, "General failure while attempting to resolve firmware version ({}).", | 56 | LOG_ERROR(Service_SET, "General failure while attempting to resolve firmware version ({}).", |
| @@ -42,13 +59,7 @@ void GetFirmwareVersionImpl(HLERequestContext& ctx, GetFirmwareVersionType type) | |||
| 42 | rb.Push(code); | 59 | rb.Push(code); |
| 43 | }; | 60 | }; |
| 44 | 61 | ||
| 45 | if (archive == nullptr) { | 62 | const auto ver_file = romfs->GetFile("file"); |
| 46 | early_exit_failure("The system version archive couldn't be synthesized.", | ||
| 47 | FileSys::ERROR_FAILED_MOUNT_ARCHIVE); | ||
| 48 | return; | ||
| 49 | } | ||
| 50 | |||
| 51 | const auto ver_file = archive->GetFile("file"); | ||
| 52 | if (ver_file == nullptr) { | 63 | if (ver_file == nullptr) { |
| 53 | early_exit_failure("The system version archive didn't contain the file 'file'.", | 64 | early_exit_failure("The system version archive didn't contain the file 'file'.", |
| 54 | FileSys::ERROR_INVALID_ARGUMENT); | 65 | FileSys::ERROR_INVALID_ARGUMENT); |
| @@ -87,12 +98,12 @@ void SET_SYS::SetLanguageCode(HLERequestContext& ctx) { | |||
| 87 | 98 | ||
| 88 | void SET_SYS::GetFirmwareVersion(HLERequestContext& ctx) { | 99 | void SET_SYS::GetFirmwareVersion(HLERequestContext& ctx) { |
| 89 | LOG_DEBUG(Service_SET, "called"); | 100 | LOG_DEBUG(Service_SET, "called"); |
| 90 | GetFirmwareVersionImpl(ctx, GetFirmwareVersionType::Version1); | 101 | GetFirmwareVersionImpl(system, ctx, GetFirmwareVersionType::Version1); |
| 91 | } | 102 | } |
| 92 | 103 | ||
| 93 | void SET_SYS::GetFirmwareVersion2(HLERequestContext& ctx) { | 104 | void SET_SYS::GetFirmwareVersion2(HLERequestContext& ctx) { |
| 94 | LOG_DEBUG(Service_SET, "called"); | 105 | LOG_DEBUG(Service_SET, "called"); |
| 95 | GetFirmwareVersionImpl(ctx, GetFirmwareVersionType::Version2); | 106 | GetFirmwareVersionImpl(system, ctx, GetFirmwareVersionType::Version2); |
| 96 | } | 107 | } |
| 97 | 108 | ||
| 98 | void SET_SYS::GetAccountSettings(HLERequestContext& ctx) { | 109 | void SET_SYS::GetAccountSettings(HLERequestContext& ctx) { |
diff --git a/src/core/loader/deconstructed_rom_directory.cpp b/src/core/loader/deconstructed_rom_directory.cpp index 5a42dea48..5c36b71e5 100644 --- a/src/core/loader/deconstructed_rom_directory.cpp +++ b/src/core/loader/deconstructed_rom_directory.cpp | |||
| @@ -118,7 +118,7 @@ AppLoader_DeconstructedRomDirectory::LoadResult AppLoader_DeconstructedRomDirect | |||
| 118 | return {ResultStatus::ErrorMissingNPDM, {}}; | 118 | return {ResultStatus::ErrorMissingNPDM, {}}; |
| 119 | } | 119 | } |
| 120 | 120 | ||
| 121 | const ResultStatus result2 = metadata.Load(npdm); | 121 | const ResultStatus result2 = metadata.Reload(npdm); |
| 122 | if (result2 != ResultStatus::Success) { | 122 | if (result2 != ResultStatus::Success) { |
| 123 | return {result2, {}}; | 123 | return {result2, {}}; |
| 124 | } | 124 | } |
diff --git a/src/core/memory/cheat_engine.cpp b/src/core/memory/cheat_engine.cpp index a06e99166..53a89cc8f 100644 --- a/src/core/memory/cheat_engine.cpp +++ b/src/core/memory/cheat_engine.cpp | |||
| @@ -19,16 +19,23 @@ namespace Core::Memory { | |||
| 19 | namespace { | 19 | namespace { |
| 20 | constexpr auto CHEAT_ENGINE_NS = std::chrono::nanoseconds{1000000000 / 12}; | 20 | constexpr auto CHEAT_ENGINE_NS = std::chrono::nanoseconds{1000000000 / 12}; |
| 21 | 21 | ||
| 22 | std::string_view ExtractName(std::string_view data, std::size_t start_index, char match) { | 22 | std::string_view ExtractName(std::size_t& out_name_size, std::string_view data, |
| 23 | std::size_t start_index, char match) { | ||
| 23 | auto end_index = start_index; | 24 | auto end_index = start_index; |
| 24 | while (data[end_index] != match) { | 25 | while (data[end_index] != match) { |
| 25 | ++end_index; | 26 | ++end_index; |
| 26 | if (end_index > data.size() || | 27 | if (end_index > data.size()) { |
| 27 | (end_index - start_index - 1) > sizeof(CheatDefinition::readable_name)) { | ||
| 28 | return {}; | 28 | return {}; |
| 29 | } | 29 | } |
| 30 | } | 30 | } |
| 31 | 31 | ||
| 32 | out_name_size = end_index - start_index; | ||
| 33 | |||
| 34 | // Clamp name if it's too big | ||
| 35 | if (out_name_size > sizeof(CheatDefinition::readable_name)) { | ||
| 36 | end_index = start_index + sizeof(CheatDefinition::readable_name); | ||
| 37 | } | ||
| 38 | |||
| 32 | return data.substr(start_index, end_index - start_index); | 39 | return data.substr(start_index, end_index - start_index); |
| 33 | } | 40 | } |
| 34 | } // Anonymous namespace | 41 | } // Anonymous namespace |
| @@ -113,7 +120,8 @@ std::vector<CheatEntry> TextCheatParser::Parse(std::string_view data) const { | |||
| 113 | return {}; | 120 | return {}; |
| 114 | } | 121 | } |
| 115 | 122 | ||
| 116 | const auto name = ExtractName(data, i + 1, '}'); | 123 | std::size_t name_size{}; |
| 124 | const auto name = ExtractName(name_size, data, i + 1, '}'); | ||
| 117 | if (name.empty()) { | 125 | if (name.empty()) { |
| 118 | return {}; | 126 | return {}; |
| 119 | } | 127 | } |
| @@ -125,12 +133,13 @@ std::vector<CheatEntry> TextCheatParser::Parse(std::string_view data) const { | |||
| 125 | .definition.readable_name[out[*current_entry].definition.readable_name.size() - 1] = | 133 | .definition.readable_name[out[*current_entry].definition.readable_name.size() - 1] = |
| 126 | '\0'; | 134 | '\0'; |
| 127 | 135 | ||
| 128 | i += name.length() + 1; | 136 | i += name_size + 1; |
| 129 | } else if (data[i] == '[') { | 137 | } else if (data[i] == '[') { |
| 130 | current_entry = out.size(); | 138 | current_entry = out.size(); |
| 131 | out.emplace_back(); | 139 | out.emplace_back(); |
| 132 | 140 | ||
| 133 | const auto name = ExtractName(data, i + 1, ']'); | 141 | std::size_t name_size{}; |
| 142 | const auto name = ExtractName(name_size, data, i + 1, ']'); | ||
| 134 | if (name.empty()) { | 143 | if (name.empty()) { |
| 135 | return {}; | 144 | return {}; |
| 136 | } | 145 | } |
| @@ -142,7 +151,7 @@ std::vector<CheatEntry> TextCheatParser::Parse(std::string_view data) const { | |||
| 142 | .definition.readable_name[out[*current_entry].definition.readable_name.size() - 1] = | 151 | .definition.readable_name[out[*current_entry].definition.readable_name.size() - 1] = |
| 143 | '\0'; | 152 | '\0'; |
| 144 | 153 | ||
| 145 | i += name.length() + 1; | 154 | i += name_size + 1; |
| 146 | } else if (::isxdigit(data[i])) { | 155 | } else if (::isxdigit(data[i])) { |
| 147 | if (!current_entry || out[*current_entry].definition.num_opcodes >= | 156 | if (!current_entry || out[*current_entry].definition.num_opcodes >= |
| 148 | out[*current_entry].definition.opcodes.size()) { | 157 | out[*current_entry].definition.opcodes.size()) { |
diff --git a/src/core/reporter.cpp b/src/core/reporter.cpp index ed875d444..5d168cbc1 100644 --- a/src/core/reporter.cpp +++ b/src/core/reporter.cpp | |||
| @@ -116,7 +116,7 @@ json GetProcessorStateDataAuto(Core::System& system) { | |||
| 116 | Core::ARM_Interface::ThreadContext64 context{}; | 116 | Core::ARM_Interface::ThreadContext64 context{}; |
| 117 | arm.SaveContext(context); | 117 | arm.SaveContext(context); |
| 118 | 118 | ||
| 119 | return GetProcessorStateData(process->Is64BitProcess() ? "AArch64" : "AArch32", | 119 | return GetProcessorStateData(process->Is64Bit() ? "AArch64" : "AArch32", |
| 120 | GetInteger(process->GetEntryPoint()), context.sp, context.pc, | 120 | GetInteger(process->GetEntryPoint()), context.sp, context.pc, |
| 121 | context.pstate, context.cpu_registers); | 121 | context.pstate, context.cpu_registers); |
| 122 | } | 122 | } |
diff --git a/src/input_common/drivers/udp_client.cpp b/src/input_common/drivers/udp_client.cpp index 808b21069..77db60e92 100644 --- a/src/input_common/drivers/udp_client.cpp +++ b/src/input_common/drivers/udp_client.cpp | |||
| @@ -338,6 +338,7 @@ void UDPClient::StartCommunication(std::size_t client, const std::string& host, | |||
| 338 | for (std::size_t index = 0; index < PADS_PER_CLIENT; ++index) { | 338 | for (std::size_t index = 0; index < PADS_PER_CLIENT; ++index) { |
| 339 | const PadIdentifier identifier = GetPadIdentifier(client * PADS_PER_CLIENT + index); | 339 | const PadIdentifier identifier = GetPadIdentifier(client * PADS_PER_CLIENT + index); |
| 340 | PreSetController(identifier); | 340 | PreSetController(identifier); |
| 341 | PreSetMotion(identifier, 0); | ||
| 341 | } | 342 | } |
| 342 | } | 343 | } |
| 343 | 344 | ||
diff --git a/src/input_common/helpers/joycon_driver.cpp b/src/input_common/helpers/joycon_driver.cpp index cf51f3481..c9f903213 100644 --- a/src/input_common/helpers/joycon_driver.cpp +++ b/src/input_common/helpers/joycon_driver.cpp | |||
| @@ -139,7 +139,7 @@ void JoyconDriver::InputThread(std::stop_token stop_token) { | |||
| 139 | input_thread_running = true; | 139 | input_thread_running = true; |
| 140 | 140 | ||
| 141 | // Max update rate is 5ms, ensure we are always able to read a bit faster | 141 | // Max update rate is 5ms, ensure we are always able to read a bit faster |
| 142 | constexpr int ThreadDelay = 2; | 142 | constexpr int ThreadDelay = 3; |
| 143 | std::vector<u8> buffer(MaxBufferSize); | 143 | std::vector<u8> buffer(MaxBufferSize); |
| 144 | 144 | ||
| 145 | while (!stop_token.stop_requested()) { | 145 | while (!stop_token.stop_requested()) { |
| @@ -163,6 +163,17 @@ void JoyconDriver::InputThread(std::stop_token stop_token) { | |||
| 163 | OnNewData(buffer); | 163 | OnNewData(buffer); |
| 164 | } | 164 | } |
| 165 | 165 | ||
| 166 | if (!vibration_queue.Empty()) { | ||
| 167 | VibrationValue vibration_value; | ||
| 168 | vibration_queue.Pop(vibration_value); | ||
| 169 | last_vibration_result = rumble_protocol->SendVibration(vibration_value); | ||
| 170 | } | ||
| 171 | |||
| 172 | // We can't keep up with vibrations. Start skipping. | ||
| 173 | while (vibration_queue.Size() > 6) { | ||
| 174 | vibration_queue.Pop(); | ||
| 175 | } | ||
| 176 | |||
| 166 | std::this_thread::yield(); | 177 | std::this_thread::yield(); |
| 167 | } | 178 | } |
| 168 | 179 | ||
| @@ -402,7 +413,8 @@ Common::Input::DriverResult JoyconDriver::SetVibration(const VibrationValue& vib | |||
| 402 | if (disable_input_thread) { | 413 | if (disable_input_thread) { |
| 403 | return Common::Input::DriverResult::HandleInUse; | 414 | return Common::Input::DriverResult::HandleInUse; |
| 404 | } | 415 | } |
| 405 | return rumble_protocol->SendVibration(vibration); | 416 | vibration_queue.Push(vibration); |
| 417 | return last_vibration_result; | ||
| 406 | } | 418 | } |
| 407 | 419 | ||
| 408 | Common::Input::DriverResult JoyconDriver::SetLedConfig(u8 led_pattern) { | 420 | Common::Input::DriverResult JoyconDriver::SetLedConfig(u8 led_pattern) { |
diff --git a/src/input_common/helpers/joycon_driver.h b/src/input_common/helpers/joycon_driver.h index 335e12cc3..5355780fb 100644 --- a/src/input_common/helpers/joycon_driver.h +++ b/src/input_common/helpers/joycon_driver.h | |||
| @@ -9,6 +9,7 @@ | |||
| 9 | #include <span> | 9 | #include <span> |
| 10 | #include <thread> | 10 | #include <thread> |
| 11 | 11 | ||
| 12 | #include "common/threadsafe_queue.h" | ||
| 12 | #include "input_common/helpers/joycon_protocol/joycon_types.h" | 13 | #include "input_common/helpers/joycon_protocol/joycon_types.h" |
| 13 | 14 | ||
| 14 | namespace Common::Input { | 15 | namespace Common::Input { |
| @@ -152,6 +153,10 @@ private: | |||
| 152 | SerialNumber handle_serial_number{}; // Serial number type reported by hidapi | 153 | SerialNumber handle_serial_number{}; // Serial number type reported by hidapi |
| 153 | SupportedFeatures supported_features{}; | 154 | SupportedFeatures supported_features{}; |
| 154 | 155 | ||
| 156 | /// Queue of vibration request to controllers | ||
| 157 | Common::Input::DriverResult last_vibration_result{Common::Input::DriverResult::Success}; | ||
| 158 | Common::SPSCQueue<VibrationValue> vibration_queue; | ||
| 159 | |||
| 155 | // Thread related | 160 | // Thread related |
| 156 | mutable std::mutex mutex; | 161 | mutable std::mutex mutex; |
| 157 | std::jthread input_thread; | 162 | std::jthread input_thread; |
diff --git a/src/shader_recompiler/backend/glsl/emit_glsl.cpp b/src/shader_recompiler/backend/glsl/emit_glsl.cpp index d91e04446..66ecfc9f7 100644 --- a/src/shader_recompiler/backend/glsl/emit_glsl.cpp +++ b/src/shader_recompiler/backend/glsl/emit_glsl.cpp | |||
| @@ -242,6 +242,7 @@ std::string EmitGLSL(const Profile& profile, const RuntimeInfo& runtime_info, IR | |||
| 242 | } | 242 | } |
| 243 | if (program.info.uses_subgroup_shuffles) { | 243 | if (program.info.uses_subgroup_shuffles) { |
| 244 | ctx.header += "bool shfl_in_bounds;"; | 244 | ctx.header += "bool shfl_in_bounds;"; |
| 245 | ctx.header += "uint shfl_result;"; | ||
| 245 | } | 246 | } |
| 246 | ctx.code.insert(0, ctx.header); | 247 | ctx.code.insert(0, ctx.header); |
| 247 | ctx.code += '}'; | 248 | ctx.code += '}'; |
diff --git a/src/shader_recompiler/backend/glsl/emit_glsl_warp.cpp b/src/shader_recompiler/backend/glsl/emit_glsl_warp.cpp index 1245c9429..f9be5de1c 100644 --- a/src/shader_recompiler/backend/glsl/emit_glsl_warp.cpp +++ b/src/shader_recompiler/backend/glsl/emit_glsl_warp.cpp | |||
| @@ -141,7 +141,8 @@ void EmitShuffleIndex(EmitContext& ctx, IR::Inst& inst, std::string_view value, | |||
| 141 | const auto src_thread_id{fmt::format("({})|({})", lhs, min_thread_id)}; | 141 | const auto src_thread_id{fmt::format("({})|({})", lhs, min_thread_id)}; |
| 142 | ctx.Add("shfl_in_bounds=int({})<=int({});", src_thread_id, max_thread_id); | 142 | ctx.Add("shfl_in_bounds=int({})<=int({});", src_thread_id, max_thread_id); |
| 143 | SetInBoundsFlag(ctx, inst); | 143 | SetInBoundsFlag(ctx, inst); |
| 144 | ctx.AddU32("{}=shfl_in_bounds?readInvocationARB({},{}):{};", inst, value, src_thread_id, value); | 144 | ctx.Add("shfl_result=readInvocationARB({},{});", value, src_thread_id); |
| 145 | ctx.AddU32("{}=shfl_in_bounds?shfl_result:{};", inst, value); | ||
| 145 | } | 146 | } |
| 146 | 147 | ||
| 147 | void EmitShuffleUp(EmitContext& ctx, IR::Inst& inst, std::string_view value, std::string_view index, | 148 | void EmitShuffleUp(EmitContext& ctx, IR::Inst& inst, std::string_view value, std::string_view index, |
| @@ -158,7 +159,8 @@ void EmitShuffleUp(EmitContext& ctx, IR::Inst& inst, std::string_view value, std | |||
| 158 | const auto src_thread_id{fmt::format("({}-{})", THREAD_ID, index)}; | 159 | const auto src_thread_id{fmt::format("({}-{})", THREAD_ID, index)}; |
| 159 | ctx.Add("shfl_in_bounds=int({})>=int({});", src_thread_id, max_thread_id); | 160 | ctx.Add("shfl_in_bounds=int({})>=int({});", src_thread_id, max_thread_id); |
| 160 | SetInBoundsFlag(ctx, inst); | 161 | SetInBoundsFlag(ctx, inst); |
| 161 | ctx.AddU32("{}=shfl_in_bounds?readInvocationARB({},{}):{};", inst, value, src_thread_id, value); | 162 | ctx.Add("shfl_result=readInvocationARB({},{});", value, src_thread_id); |
| 163 | ctx.AddU32("{}=shfl_in_bounds?shfl_result:{};", inst, value); | ||
| 162 | } | 164 | } |
| 163 | 165 | ||
| 164 | void EmitShuffleDown(EmitContext& ctx, IR::Inst& inst, std::string_view value, | 166 | void EmitShuffleDown(EmitContext& ctx, IR::Inst& inst, std::string_view value, |
| @@ -175,7 +177,8 @@ void EmitShuffleDown(EmitContext& ctx, IR::Inst& inst, std::string_view value, | |||
| 175 | const auto src_thread_id{fmt::format("({}+{})", THREAD_ID, index)}; | 177 | const auto src_thread_id{fmt::format("({}+{})", THREAD_ID, index)}; |
| 176 | ctx.Add("shfl_in_bounds=int({})<=int({});", src_thread_id, max_thread_id); | 178 | ctx.Add("shfl_in_bounds=int({})<=int({});", src_thread_id, max_thread_id); |
| 177 | SetInBoundsFlag(ctx, inst); | 179 | SetInBoundsFlag(ctx, inst); |
| 178 | ctx.AddU32("{}=shfl_in_bounds?readInvocationARB({},{}):{};", inst, value, src_thread_id, value); | 180 | ctx.Add("shfl_result=readInvocationARB({},{});", value, src_thread_id); |
| 181 | ctx.AddU32("{}=shfl_in_bounds?shfl_result:{};", inst, value); | ||
| 179 | } | 182 | } |
| 180 | 183 | ||
| 181 | void EmitShuffleButterfly(EmitContext& ctx, IR::Inst& inst, std::string_view value, | 184 | void EmitShuffleButterfly(EmitContext& ctx, IR::Inst& inst, std::string_view value, |
| @@ -193,7 +196,8 @@ void EmitShuffleButterfly(EmitContext& ctx, IR::Inst& inst, std::string_view val | |||
| 193 | const auto src_thread_id{fmt::format("({}^{})", THREAD_ID, index)}; | 196 | const auto src_thread_id{fmt::format("({}^{})", THREAD_ID, index)}; |
| 194 | ctx.Add("shfl_in_bounds=int({})<=int({});", src_thread_id, max_thread_id); | 197 | ctx.Add("shfl_in_bounds=int({})<=int({});", src_thread_id, max_thread_id); |
| 195 | SetInBoundsFlag(ctx, inst); | 198 | SetInBoundsFlag(ctx, inst); |
| 196 | ctx.AddU32("{}=shfl_in_bounds?readInvocationARB({},{}):{};", inst, value, src_thread_id, value); | 199 | ctx.Add("shfl_result=readInvocationARB({},{});", value, src_thread_id); |
| 200 | ctx.AddU32("{}=shfl_in_bounds?shfl_result:{};", inst, value); | ||
| 197 | } | 201 | } |
| 198 | 202 | ||
| 199 | void EmitFSwizzleAdd(EmitContext& ctx, IR::Inst& inst, std::string_view op_a, std::string_view op_b, | 203 | void EmitFSwizzleAdd(EmitContext& ctx, IR::Inst& inst, std::string_view op_a, std::string_view op_b, |
diff --git a/src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp b/src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp index 2868fc57d..1d77426e0 100644 --- a/src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp +++ b/src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp | |||
| @@ -111,16 +111,33 @@ Id GetCbuf(EmitContext& ctx, Id result_type, Id UniformDefinitions::*member_ptr, | |||
| 111 | } else if (element_size > 1) { | 111 | } else if (element_size > 1) { |
| 112 | const u32 log2_element_size{static_cast<u32>(std::countr_zero(element_size))}; | 112 | const u32 log2_element_size{static_cast<u32>(std::countr_zero(element_size))}; |
| 113 | const Id shift{ctx.Const(log2_element_size)}; | 113 | const Id shift{ctx.Const(log2_element_size)}; |
| 114 | buffer_offset = ctx.OpShiftRightArithmetic(ctx.U32[1], ctx.Def(offset), shift); | 114 | buffer_offset = ctx.OpShiftRightLogical(ctx.U32[1], ctx.Def(offset), shift); |
| 115 | } else { | 115 | } else { |
| 116 | buffer_offset = ctx.Def(offset); | 116 | buffer_offset = ctx.Def(offset); |
| 117 | } | 117 | } |
| 118 | if (!binding.IsImmediate()) { | 118 | if (!binding.IsImmediate()) { |
| 119 | return ctx.OpFunctionCall(result_type, indirect_func, ctx.Def(binding), buffer_offset); | 119 | return ctx.OpFunctionCall(result_type, indirect_func, ctx.Def(binding), buffer_offset); |
| 120 | } | 120 | } |
| 121 | |||
| 121 | const Id cbuf{ctx.cbufs[binding.U32()].*member_ptr}; | 122 | const Id cbuf{ctx.cbufs[binding.U32()].*member_ptr}; |
| 122 | const Id access_chain{ctx.OpAccessChain(uniform_type, cbuf, ctx.u32_zero_value, buffer_offset)}; | 123 | const Id access_chain{ctx.OpAccessChain(uniform_type, cbuf, ctx.u32_zero_value, buffer_offset)}; |
| 123 | return ctx.OpLoad(result_type, access_chain); | 124 | const Id val = ctx.OpLoad(result_type, access_chain); |
| 125 | |||
| 126 | if (offset.IsImmediate() || !ctx.profile.has_broken_robust) { | ||
| 127 | return val; | ||
| 128 | } | ||
| 129 | |||
| 130 | const auto is_float = UniformDefinitions::IsFloat(member_ptr); | ||
| 131 | const auto num_elements = UniformDefinitions::NumElements(member_ptr); | ||
| 132 | const std::array zero_vec{ | ||
| 133 | is_float ? ctx.Const(0.0f) : ctx.Const(0u), | ||
| 134 | is_float ? ctx.Const(0.0f) : ctx.Const(0u), | ||
| 135 | is_float ? ctx.Const(0.0f) : ctx.Const(0u), | ||
| 136 | is_float ? ctx.Const(0.0f) : ctx.Const(0u), | ||
| 137 | }; | ||
| 138 | const Id cond = ctx.OpULessThanEqual(ctx.TypeBool(), buffer_offset, ctx.Const(0xFFFFu)); | ||
| 139 | const Id zero = ctx.OpCompositeConstruct(result_type, std::span(zero_vec.data(), num_elements)); | ||
| 140 | return ctx.OpSelect(result_type, cond, val, zero); | ||
| 124 | } | 141 | } |
| 125 | 142 | ||
| 126 | Id GetCbufU32(EmitContext& ctx, const IR::Value& binding, const IR::Value& offset) { | 143 | Id GetCbufU32(EmitContext& ctx, const IR::Value& binding, const IR::Value& offset) { |
| @@ -138,7 +155,7 @@ Id GetCbufElement(EmitContext& ctx, Id vector, const IR::Value& offset, u32 inde | |||
| 138 | const u32 element{(offset.U32() / 4) % 4 + index_offset}; | 155 | const u32 element{(offset.U32() / 4) % 4 + index_offset}; |
| 139 | return ctx.OpCompositeExtract(ctx.U32[1], vector, element); | 156 | return ctx.OpCompositeExtract(ctx.U32[1], vector, element); |
| 140 | } | 157 | } |
| 141 | const Id shift{ctx.OpShiftRightArithmetic(ctx.U32[1], ctx.Def(offset), ctx.Const(2u))}; | 158 | const Id shift{ctx.OpShiftRightLogical(ctx.U32[1], ctx.Def(offset), ctx.Const(2u))}; |
| 142 | Id element{ctx.OpBitwiseAnd(ctx.U32[1], shift, ctx.Const(3u))}; | 159 | Id element{ctx.OpBitwiseAnd(ctx.U32[1], shift, ctx.Const(3u))}; |
| 143 | if (index_offset > 0) { | 160 | if (index_offset > 0) { |
| 144 | element = ctx.OpIAdd(ctx.U32[1], element, ctx.Const(index_offset)); | 161 | element = ctx.OpIAdd(ctx.U32[1], element, ctx.Const(index_offset)); |
diff --git a/src/shader_recompiler/backend/spirv/spirv_emit_context.h b/src/shader_recompiler/backend/spirv/spirv_emit_context.h index 7c49fd504..1aa79863d 100644 --- a/src/shader_recompiler/backend/spirv/spirv_emit_context.h +++ b/src/shader_recompiler/backend/spirv/spirv_emit_context.h | |||
| @@ -64,6 +64,42 @@ struct UniformDefinitions { | |||
| 64 | Id F32{}; | 64 | Id F32{}; |
| 65 | Id U32x2{}; | 65 | Id U32x2{}; |
| 66 | Id U32x4{}; | 66 | Id U32x4{}; |
| 67 | |||
| 68 | constexpr static size_t NumElements(Id UniformDefinitions::*member_ptr) { | ||
| 69 | if (member_ptr == &UniformDefinitions::U8) { | ||
| 70 | return 1; | ||
| 71 | } | ||
| 72 | if (member_ptr == &UniformDefinitions::S8) { | ||
| 73 | return 1; | ||
| 74 | } | ||
| 75 | if (member_ptr == &UniformDefinitions::U16) { | ||
| 76 | return 1; | ||
| 77 | } | ||
| 78 | if (member_ptr == &UniformDefinitions::S16) { | ||
| 79 | return 1; | ||
| 80 | } | ||
| 81 | if (member_ptr == &UniformDefinitions::U32) { | ||
| 82 | return 1; | ||
| 83 | } | ||
| 84 | if (member_ptr == &UniformDefinitions::F32) { | ||
| 85 | return 1; | ||
| 86 | } | ||
| 87 | if (member_ptr == &UniformDefinitions::U32x2) { | ||
| 88 | return 2; | ||
| 89 | } | ||
| 90 | if (member_ptr == &UniformDefinitions::U32x4) { | ||
| 91 | return 4; | ||
| 92 | } | ||
| 93 | ASSERT(false); | ||
| 94 | return 1; | ||
| 95 | } | ||
| 96 | |||
| 97 | constexpr static bool IsFloat(Id UniformDefinitions::*member_ptr) { | ||
| 98 | if (member_ptr == &UniformDefinitions::F32) { | ||
| 99 | return true; | ||
| 100 | } | ||
| 101 | return false; | ||
| 102 | } | ||
| 67 | }; | 103 | }; |
| 68 | 104 | ||
| 69 | struct StorageTypeDefinition { | 105 | struct StorageTypeDefinition { |
diff --git a/src/shader_recompiler/profile.h b/src/shader_recompiler/profile.h index 9ca97f6a4..38d820db2 100644 --- a/src/shader_recompiler/profile.h +++ b/src/shader_recompiler/profile.h | |||
| @@ -9,7 +9,6 @@ namespace Shader { | |||
| 9 | 9 | ||
| 10 | struct Profile { | 10 | struct Profile { |
| 11 | u32 supported_spirv{0x00010000}; | 11 | u32 supported_spirv{0x00010000}; |
| 12 | |||
| 13 | bool unified_descriptor_binding{}; | 12 | bool unified_descriptor_binding{}; |
| 14 | bool support_descriptor_aliasing{}; | 13 | bool support_descriptor_aliasing{}; |
| 15 | bool support_int8{}; | 14 | bool support_int8{}; |
| @@ -82,6 +81,9 @@ struct Profile { | |||
| 82 | bool has_broken_spirv_subgroup_mask_vector_extract_dynamic{}; | 81 | bool has_broken_spirv_subgroup_mask_vector_extract_dynamic{}; |
| 83 | 82 | ||
| 84 | u32 gl_max_compute_smem_size{}; | 83 | u32 gl_max_compute_smem_size{}; |
| 84 | |||
| 85 | /// Maxwell and earlier nVidia architectures have broken robust support | ||
| 86 | bool has_broken_robust{}; | ||
| 85 | }; | 87 | }; |
| 86 | 88 | ||
| 87 | } // namespace Shader | 89 | } // namespace Shader |
diff --git a/src/tests/common/unique_function.cpp b/src/tests/common/unique_function.cpp index f7a23e876..42e6ade09 100644 --- a/src/tests/common/unique_function.cpp +++ b/src/tests/common/unique_function.cpp | |||
| @@ -46,8 +46,8 @@ TEST_CASE("UniqueFunction", "[common]") { | |||
| 46 | Noisy noisy; | 46 | Noisy noisy; |
| 47 | REQUIRE(noisy.state == "Default constructed"); | 47 | REQUIRE(noisy.state == "Default constructed"); |
| 48 | 48 | ||
| 49 | Common::UniqueFunction<void> func = [noisy = std::move(noisy)] { | 49 | Common::UniqueFunction<void> func = [noisy_inner = std::move(noisy)] { |
| 50 | REQUIRE(noisy.state == "Move constructed"); | 50 | REQUIRE(noisy_inner.state == "Move constructed"); |
| 51 | }; | 51 | }; |
| 52 | REQUIRE(noisy.state == "Moved away"); | 52 | REQUIRE(noisy.state == "Moved away"); |
| 53 | func(); | 53 | func(); |
| @@ -101,7 +101,7 @@ TEST_CASE("UniqueFunction", "[common]") { | |||
| 101 | }; | 101 | }; |
| 102 | Foo object{&num_destroyed}; | 102 | Foo object{&num_destroyed}; |
| 103 | { | 103 | { |
| 104 | Common::UniqueFunction<void> func = [object = std::move(object)] {}; | 104 | Common::UniqueFunction<void> func = [object_inner = std::move(object)] {}; |
| 105 | REQUIRE(num_destroyed == 0); | 105 | REQUIRE(num_destroyed == 0); |
| 106 | } | 106 | } |
| 107 | REQUIRE(num_destroyed == 1); | 107 | REQUIRE(num_destroyed == 1); |
diff --git a/src/video_core/buffer_cache/buffer_cache.h b/src/video_core/buffer_cache/buffer_cache.h index 9e90c587c..081a574e8 100644 --- a/src/video_core/buffer_cache/buffer_cache.h +++ b/src/video_core/buffer_cache/buffer_cache.h | |||
| @@ -544,7 +544,7 @@ void BufferCache<P>::CommitAsyncFlushesHigh() { | |||
| 544 | it++; | 544 | it++; |
| 545 | } | 545 | } |
| 546 | 546 | ||
| 547 | boost::container::small_vector<std::pair<BufferCopy, BufferId>, 1> downloads; | 547 | boost::container::small_vector<std::pair<BufferCopy, BufferId>, 16> downloads; |
| 548 | u64 total_size_bytes = 0; | 548 | u64 total_size_bytes = 0; |
| 549 | u64 largest_copy = 0; | 549 | u64 largest_copy = 0; |
| 550 | for (const IntervalSet& intervals : committed_ranges) { | 550 | for (const IntervalSet& intervals : committed_ranges) { |
| @@ -914,6 +914,11 @@ void BufferCache<P>::BindHostGraphicsStorageBuffers(size_t stage) { | |||
| 914 | 914 | ||
| 915 | const u32 offset = buffer.Offset(binding.cpu_addr); | 915 | const u32 offset = buffer.Offset(binding.cpu_addr); |
| 916 | const bool is_written = ((channel_state->written_storage_buffers[stage] >> index) & 1) != 0; | 916 | const bool is_written = ((channel_state->written_storage_buffers[stage] >> index) & 1) != 0; |
| 917 | |||
| 918 | if (is_written) { | ||
| 919 | MarkWrittenBuffer(binding.buffer_id, binding.cpu_addr, size); | ||
| 920 | } | ||
| 921 | |||
| 917 | if constexpr (NEEDS_BIND_STORAGE_INDEX) { | 922 | if constexpr (NEEDS_BIND_STORAGE_INDEX) { |
| 918 | runtime.BindStorageBuffer(stage, binding_index, buffer, offset, size, is_written); | 923 | runtime.BindStorageBuffer(stage, binding_index, buffer, offset, size, is_written); |
| 919 | ++binding_index; | 924 | ++binding_index; |
| @@ -931,6 +936,11 @@ void BufferCache<P>::BindHostGraphicsTextureBuffers(size_t stage) { | |||
| 931 | const u32 size = binding.size; | 936 | const u32 size = binding.size; |
| 932 | SynchronizeBuffer(buffer, binding.cpu_addr, size); | 937 | SynchronizeBuffer(buffer, binding.cpu_addr, size); |
| 933 | 938 | ||
| 939 | const bool is_written = ((channel_state->written_texture_buffers[stage] >> index) & 1) != 0; | ||
| 940 | if (is_written) { | ||
| 941 | MarkWrittenBuffer(binding.buffer_id, binding.cpu_addr, size); | ||
| 942 | } | ||
| 943 | |||
| 934 | const u32 offset = buffer.Offset(binding.cpu_addr); | 944 | const u32 offset = buffer.Offset(binding.cpu_addr); |
| 935 | const PixelFormat format = binding.format; | 945 | const PixelFormat format = binding.format; |
| 936 | if constexpr (SEPARATE_IMAGE_BUFFERS_BINDINGS) { | 946 | if constexpr (SEPARATE_IMAGE_BUFFERS_BINDINGS) { |
| @@ -962,6 +972,8 @@ void BufferCache<P>::BindHostTransformFeedbackBuffers() { | |||
| 962 | const u32 size = binding.size; | 972 | const u32 size = binding.size; |
| 963 | SynchronizeBuffer(buffer, binding.cpu_addr, size); | 973 | SynchronizeBuffer(buffer, binding.cpu_addr, size); |
| 964 | 974 | ||
| 975 | MarkWrittenBuffer(binding.buffer_id, binding.cpu_addr, size); | ||
| 976 | |||
| 965 | const u32 offset = buffer.Offset(binding.cpu_addr); | 977 | const u32 offset = buffer.Offset(binding.cpu_addr); |
| 966 | host_bindings.buffers.push_back(&buffer); | 978 | host_bindings.buffers.push_back(&buffer); |
| 967 | host_bindings.offsets.push_back(offset); | 979 | host_bindings.offsets.push_back(offset); |
| @@ -1011,6 +1023,11 @@ void BufferCache<P>::BindHostComputeStorageBuffers() { | |||
| 1011 | const u32 offset = buffer.Offset(binding.cpu_addr); | 1023 | const u32 offset = buffer.Offset(binding.cpu_addr); |
| 1012 | const bool is_written = | 1024 | const bool is_written = |
| 1013 | ((channel_state->written_compute_storage_buffers >> index) & 1) != 0; | 1025 | ((channel_state->written_compute_storage_buffers >> index) & 1) != 0; |
| 1026 | |||
| 1027 | if (is_written) { | ||
| 1028 | MarkWrittenBuffer(binding.buffer_id, binding.cpu_addr, size); | ||
| 1029 | } | ||
| 1030 | |||
| 1014 | if constexpr (NEEDS_BIND_STORAGE_INDEX) { | 1031 | if constexpr (NEEDS_BIND_STORAGE_INDEX) { |
| 1015 | runtime.BindComputeStorageBuffer(binding_index, buffer, offset, size, is_written); | 1032 | runtime.BindComputeStorageBuffer(binding_index, buffer, offset, size, is_written); |
| 1016 | ++binding_index; | 1033 | ++binding_index; |
| @@ -1028,6 +1045,12 @@ void BufferCache<P>::BindHostComputeTextureBuffers() { | |||
| 1028 | const u32 size = binding.size; | 1045 | const u32 size = binding.size; |
| 1029 | SynchronizeBuffer(buffer, binding.cpu_addr, size); | 1046 | SynchronizeBuffer(buffer, binding.cpu_addr, size); |
| 1030 | 1047 | ||
| 1048 | const bool is_written = | ||
| 1049 | ((channel_state->written_compute_texture_buffers >> index) & 1) != 0; | ||
| 1050 | if (is_written) { | ||
| 1051 | MarkWrittenBuffer(binding.buffer_id, binding.cpu_addr, size); | ||
| 1052 | } | ||
| 1053 | |||
| 1031 | const u32 offset = buffer.Offset(binding.cpu_addr); | 1054 | const u32 offset = buffer.Offset(binding.cpu_addr); |
| 1032 | const PixelFormat format = binding.format; | 1055 | const PixelFormat format = binding.format; |
| 1033 | if constexpr (SEPARATE_IMAGE_BUFFERS_BINDINGS) { | 1056 | if constexpr (SEPARATE_IMAGE_BUFFERS_BINDINGS) { |
| @@ -1044,8 +1067,7 @@ void BufferCache<P>::BindHostComputeTextureBuffers() { | |||
| 1044 | 1067 | ||
| 1045 | template <class P> | 1068 | template <class P> |
| 1046 | void BufferCache<P>::DoUpdateGraphicsBuffers(bool is_indexed) { | 1069 | void BufferCache<P>::DoUpdateGraphicsBuffers(bool is_indexed) { |
| 1047 | do { | 1070 | BufferOperations([&]() { |
| 1048 | channel_state->has_deleted_buffers = false; | ||
| 1049 | if (is_indexed) { | 1071 | if (is_indexed) { |
| 1050 | UpdateIndexBuffer(); | 1072 | UpdateIndexBuffer(); |
| 1051 | } | 1073 | } |
| @@ -1059,14 +1081,16 @@ void BufferCache<P>::DoUpdateGraphicsBuffers(bool is_indexed) { | |||
| 1059 | if (current_draw_indirect) { | 1081 | if (current_draw_indirect) { |
| 1060 | UpdateDrawIndirect(); | 1082 | UpdateDrawIndirect(); |
| 1061 | } | 1083 | } |
| 1062 | } while (channel_state->has_deleted_buffers); | 1084 | }); |
| 1063 | } | 1085 | } |
| 1064 | 1086 | ||
| 1065 | template <class P> | 1087 | template <class P> |
| 1066 | void BufferCache<P>::DoUpdateComputeBuffers() { | 1088 | void BufferCache<P>::DoUpdateComputeBuffers() { |
| 1067 | UpdateComputeUniformBuffers(); | 1089 | BufferOperations([&]() { |
| 1068 | UpdateComputeStorageBuffers(); | 1090 | UpdateComputeUniformBuffers(); |
| 1069 | UpdateComputeTextureBuffers(); | 1091 | UpdateComputeStorageBuffers(); |
| 1092 | UpdateComputeTextureBuffers(); | ||
| 1093 | }); | ||
| 1070 | } | 1094 | } |
| 1071 | 1095 | ||
| 1072 | template <class P> | 1096 | template <class P> |
| @@ -1201,16 +1225,11 @@ void BufferCache<P>::UpdateUniformBuffers(size_t stage) { | |||
| 1201 | 1225 | ||
| 1202 | template <class P> | 1226 | template <class P> |
| 1203 | void BufferCache<P>::UpdateStorageBuffers(size_t stage) { | 1227 | void BufferCache<P>::UpdateStorageBuffers(size_t stage) { |
| 1204 | const u32 written_mask = channel_state->written_storage_buffers[stage]; | ||
| 1205 | ForEachEnabledBit(channel_state->enabled_storage_buffers[stage], [&](u32 index) { | 1228 | ForEachEnabledBit(channel_state->enabled_storage_buffers[stage], [&](u32 index) { |
| 1206 | // Resolve buffer | 1229 | // Resolve buffer |
| 1207 | Binding& binding = channel_state->storage_buffers[stage][index]; | 1230 | Binding& binding = channel_state->storage_buffers[stage][index]; |
| 1208 | const BufferId buffer_id = FindBuffer(binding.cpu_addr, binding.size); | 1231 | const BufferId buffer_id = FindBuffer(binding.cpu_addr, binding.size); |
| 1209 | binding.buffer_id = buffer_id; | 1232 | binding.buffer_id = buffer_id; |
| 1210 | // Mark buffer as written if needed | ||
| 1211 | if (((written_mask >> index) & 1) != 0) { | ||
| 1212 | MarkWrittenBuffer(buffer_id, binding.cpu_addr, binding.size); | ||
| 1213 | } | ||
| 1214 | }); | 1233 | }); |
| 1215 | } | 1234 | } |
| 1216 | 1235 | ||
| @@ -1219,10 +1238,6 @@ void BufferCache<P>::UpdateTextureBuffers(size_t stage) { | |||
| 1219 | ForEachEnabledBit(channel_state->enabled_texture_buffers[stage], [&](u32 index) { | 1238 | ForEachEnabledBit(channel_state->enabled_texture_buffers[stage], [&](u32 index) { |
| 1220 | Binding& binding = channel_state->texture_buffers[stage][index]; | 1239 | Binding& binding = channel_state->texture_buffers[stage][index]; |
| 1221 | binding.buffer_id = FindBuffer(binding.cpu_addr, binding.size); | 1240 | binding.buffer_id = FindBuffer(binding.cpu_addr, binding.size); |
| 1222 | // Mark buffer as written if needed | ||
| 1223 | if (((channel_state->written_texture_buffers[stage] >> index) & 1) != 0) { | ||
| 1224 | MarkWrittenBuffer(binding.buffer_id, binding.cpu_addr, binding.size); | ||
| 1225 | } | ||
| 1226 | }); | 1241 | }); |
| 1227 | } | 1242 | } |
| 1228 | 1243 | ||
| @@ -1252,7 +1267,6 @@ void BufferCache<P>::UpdateTransformFeedbackBuffer(u32 index) { | |||
| 1252 | .size = size, | 1267 | .size = size, |
| 1253 | .buffer_id = buffer_id, | 1268 | .buffer_id = buffer_id, |
| 1254 | }; | 1269 | }; |
| 1255 | MarkWrittenBuffer(buffer_id, *cpu_addr, size); | ||
| 1256 | } | 1270 | } |
| 1257 | 1271 | ||
| 1258 | template <class P> | 1272 | template <class P> |
| @@ -1279,10 +1293,6 @@ void BufferCache<P>::UpdateComputeStorageBuffers() { | |||
| 1279 | // Resolve buffer | 1293 | // Resolve buffer |
| 1280 | Binding& binding = channel_state->compute_storage_buffers[index]; | 1294 | Binding& binding = channel_state->compute_storage_buffers[index]; |
| 1281 | binding.buffer_id = FindBuffer(binding.cpu_addr, binding.size); | 1295 | binding.buffer_id = FindBuffer(binding.cpu_addr, binding.size); |
| 1282 | // Mark as written if needed | ||
| 1283 | if (((channel_state->written_compute_storage_buffers >> index) & 1) != 0) { | ||
| 1284 | MarkWrittenBuffer(binding.buffer_id, binding.cpu_addr, binding.size); | ||
| 1285 | } | ||
| 1286 | }); | 1296 | }); |
| 1287 | } | 1297 | } |
| 1288 | 1298 | ||
| @@ -1291,18 +1301,11 @@ void BufferCache<P>::UpdateComputeTextureBuffers() { | |||
| 1291 | ForEachEnabledBit(channel_state->enabled_compute_texture_buffers, [&](u32 index) { | 1301 | ForEachEnabledBit(channel_state->enabled_compute_texture_buffers, [&](u32 index) { |
| 1292 | Binding& binding = channel_state->compute_texture_buffers[index]; | 1302 | Binding& binding = channel_state->compute_texture_buffers[index]; |
| 1293 | binding.buffer_id = FindBuffer(binding.cpu_addr, binding.size); | 1303 | binding.buffer_id = FindBuffer(binding.cpu_addr, binding.size); |
| 1294 | // Mark as written if needed | ||
| 1295 | if (((channel_state->written_compute_texture_buffers >> index) & 1) != 0) { | ||
| 1296 | MarkWrittenBuffer(binding.buffer_id, binding.cpu_addr, binding.size); | ||
| 1297 | } | ||
| 1298 | }); | 1304 | }); |
| 1299 | } | 1305 | } |
| 1300 | 1306 | ||
| 1301 | template <class P> | 1307 | template <class P> |
| 1302 | void BufferCache<P>::MarkWrittenBuffer(BufferId buffer_id, VAddr cpu_addr, u32 size) { | 1308 | void BufferCache<P>::MarkWrittenBuffer(BufferId buffer_id, VAddr cpu_addr, u32 size) { |
| 1303 | if (memory_tracker.IsRegionCpuModified(cpu_addr, size)) { | ||
| 1304 | SynchronizeBuffer(slot_buffers[buffer_id], cpu_addr, size); | ||
| 1305 | } | ||
| 1306 | memory_tracker.MarkRegionAsGpuModified(cpu_addr, size); | 1309 | memory_tracker.MarkRegionAsGpuModified(cpu_addr, size); |
| 1307 | 1310 | ||
| 1308 | const IntervalType base_interval{cpu_addr, cpu_addr + size}; | 1311 | const IntervalType base_interval{cpu_addr, cpu_addr + size}; |
diff --git a/src/video_core/buffer_cache/buffer_cache_base.h b/src/video_core/buffer_cache/buffer_cache_base.h index c4f6e8d12..eed267361 100644 --- a/src/video_core/buffer_cache/buffer_cache_base.h +++ b/src/video_core/buffer_cache/buffer_cache_base.h | |||
| @@ -62,7 +62,11 @@ using BufferId = SlotId; | |||
| 62 | using VideoCore::Surface::PixelFormat; | 62 | using VideoCore::Surface::PixelFormat; |
| 63 | using namespace Common::Literals; | 63 | using namespace Common::Literals; |
| 64 | 64 | ||
| 65 | #ifdef __APPLE__ | ||
| 66 | constexpr u32 NUM_VERTEX_BUFFERS = 16; | ||
| 67 | #else | ||
| 65 | constexpr u32 NUM_VERTEX_BUFFERS = 32; | 68 | constexpr u32 NUM_VERTEX_BUFFERS = 32; |
| 69 | #endif | ||
| 66 | constexpr u32 NUM_TRANSFORM_FEEDBACK_BUFFERS = 4; | 70 | constexpr u32 NUM_TRANSFORM_FEEDBACK_BUFFERS = 4; |
| 67 | constexpr u32 NUM_GRAPHICS_UNIFORM_BUFFERS = 18; | 71 | constexpr u32 NUM_GRAPHICS_UNIFORM_BUFFERS = 18; |
| 68 | constexpr u32 NUM_COMPUTE_UNIFORM_BUFFERS = 8; | 72 | constexpr u32 NUM_COMPUTE_UNIFORM_BUFFERS = 8; |
diff --git a/src/video_core/engines/draw_manager.cpp b/src/video_core/engines/draw_manager.cpp index f34090791..d77ff455b 100644 --- a/src/video_core/engines/draw_manager.cpp +++ b/src/video_core/engines/draw_manager.cpp | |||
| @@ -48,8 +48,14 @@ void DrawManager::ProcessMethodCall(u32 method, u32 argument) { | |||
| 48 | SetInlineIndexBuffer(regs.inline_index_4x8.index3); | 48 | SetInlineIndexBuffer(regs.inline_index_4x8.index3); |
| 49 | break; | 49 | break; |
| 50 | case MAXWELL3D_REG_INDEX(vertex_array_instance_first): | 50 | case MAXWELL3D_REG_INDEX(vertex_array_instance_first): |
| 51 | DrawArrayInstanced(regs.vertex_array_instance_first.topology.Value(), | ||
| 52 | regs.vertex_array_instance_first.start.Value(), | ||
| 53 | regs.vertex_array_instance_first.count.Value(), false); | ||
| 54 | break; | ||
| 51 | case MAXWELL3D_REG_INDEX(vertex_array_instance_subsequent): { | 55 | case MAXWELL3D_REG_INDEX(vertex_array_instance_subsequent): { |
| 52 | LOG_WARNING(HW_GPU, "(STUBBED) called"); | 56 | DrawArrayInstanced(regs.vertex_array_instance_subsequent.topology.Value(), |
| 57 | regs.vertex_array_instance_subsequent.start.Value(), | ||
| 58 | regs.vertex_array_instance_subsequent.count.Value(), true); | ||
| 53 | break; | 59 | break; |
| 54 | } | 60 | } |
| 55 | case MAXWELL3D_REG_INDEX(draw_texture.src_y0): { | 61 | case MAXWELL3D_REG_INDEX(draw_texture.src_y0): { |
| @@ -84,6 +90,22 @@ void DrawManager::DrawArray(PrimitiveTopology topology, u32 vertex_first, u32 ve | |||
| 84 | ProcessDraw(false, num_instances); | 90 | ProcessDraw(false, num_instances); |
| 85 | } | 91 | } |
| 86 | 92 | ||
| 93 | void DrawManager::DrawArrayInstanced(PrimitiveTopology topology, u32 vertex_first, u32 vertex_count, | ||
| 94 | bool subsequent) { | ||
| 95 | draw_state.topology = topology; | ||
| 96 | draw_state.vertex_buffer.first = vertex_first; | ||
| 97 | draw_state.vertex_buffer.count = vertex_count; | ||
| 98 | |||
| 99 | if (!subsequent) { | ||
| 100 | draw_state.instance_count = 1; | ||
| 101 | } | ||
| 102 | |||
| 103 | draw_state.base_instance = draw_state.instance_count - 1; | ||
| 104 | draw_state.draw_mode = DrawMode::Instance; | ||
| 105 | draw_state.instance_count++; | ||
| 106 | ProcessDraw(false, 1); | ||
| 107 | } | ||
| 108 | |||
| 87 | void DrawManager::DrawIndex(PrimitiveTopology topology, u32 index_first, u32 index_count, | 109 | void DrawManager::DrawIndex(PrimitiveTopology topology, u32 index_first, u32 index_count, |
| 88 | u32 base_index, u32 base_instance, u32 num_instances) { | 110 | u32 base_index, u32 base_instance, u32 num_instances) { |
| 89 | const auto& regs{maxwell3d->regs}; | 111 | const auto& regs{maxwell3d->regs}; |
diff --git a/src/video_core/engines/draw_manager.h b/src/video_core/engines/draw_manager.h index 18d959143..cfc8127fc 100644 --- a/src/video_core/engines/draw_manager.h +++ b/src/video_core/engines/draw_manager.h | |||
| @@ -66,6 +66,8 @@ public: | |||
| 66 | 66 | ||
| 67 | void DrawArray(PrimitiveTopology topology, u32 vertex_first, u32 vertex_count, | 67 | void DrawArray(PrimitiveTopology topology, u32 vertex_first, u32 vertex_count, |
| 68 | u32 base_instance, u32 num_instances); | 68 | u32 base_instance, u32 num_instances); |
| 69 | void DrawArrayInstanced(PrimitiveTopology topology, u32 vertex_first, u32 vertex_count, | ||
| 70 | bool subsequent); | ||
| 69 | 71 | ||
| 70 | void DrawIndex(PrimitiveTopology topology, u32 index_first, u32 index_count, u32 base_index, | 72 | void DrawIndex(PrimitiveTopology topology, u32 index_first, u32 index_count, u32 base_index, |
| 71 | u32 base_instance, u32 num_instances); | 73 | u32 base_instance, u32 num_instances); |
diff --git a/src/video_core/fence_manager.h b/src/video_core/fence_manager.h index 805a89900..c0e6471fe 100644 --- a/src/video_core/fence_manager.h +++ b/src/video_core/fence_manager.h | |||
| @@ -86,7 +86,10 @@ public: | |||
| 86 | uncommitted_operations.emplace_back(std::move(func)); | 86 | uncommitted_operations.emplace_back(std::move(func)); |
| 87 | } | 87 | } |
| 88 | pending_operations.emplace_back(std::move(uncommitted_operations)); | 88 | pending_operations.emplace_back(std::move(uncommitted_operations)); |
| 89 | QueueFence(new_fence); | 89 | { |
| 90 | std::scoped_lock lock{buffer_cache.mutex, texture_cache.mutex}; | ||
| 91 | QueueFence(new_fence); | ||
| 92 | } | ||
| 90 | if (!delay_fence) { | 93 | if (!delay_fence) { |
| 91 | func(); | 94 | func(); |
| 92 | } | 95 | } |
diff --git a/src/video_core/host1x/codecs/codec.cpp b/src/video_core/host1x/codecs/codec.cpp index 8d7da50fc..dbcf508e5 100644 --- a/src/video_core/host1x/codecs/codec.cpp +++ b/src/video_core/host1x/codecs/codec.cpp | |||
| @@ -137,16 +137,6 @@ bool Codec::CreateGpuAvDevice() { | |||
| 137 | break; | 137 | break; |
| 138 | } | 138 | } |
| 139 | if ((config->methods & HW_CONFIG_METHOD) != 0 && config->device_type == type) { | 139 | if ((config->methods & HW_CONFIG_METHOD) != 0 && config->device_type == type) { |
| 140 | #if defined(__unix__) | ||
| 141 | // Some linux decoding backends are reported to crash with this config method | ||
| 142 | // TODO(ameerj): Properly support this method | ||
| 143 | if ((config->methods & AV_CODEC_HW_CONFIG_METHOD_HW_FRAMES_CTX) != 0) { | ||
| 144 | // skip zero-copy decoders, we don't currently support them | ||
| 145 | LOG_DEBUG(Service_NVDRV, "Skipping decoder {} with unsupported capability {}.", | ||
| 146 | av_hwdevice_get_type_name(type), config->methods); | ||
| 147 | continue; | ||
| 148 | } | ||
| 149 | #endif | ||
| 150 | LOG_INFO(Service_NVDRV, "Using {} GPU decoder", av_hwdevice_get_type_name(type)); | 140 | LOG_INFO(Service_NVDRV, "Using {} GPU decoder", av_hwdevice_get_type_name(type)); |
| 151 | av_codec_ctx->pix_fmt = config->pix_fmt; | 141 | av_codec_ctx->pix_fmt = config->pix_fmt; |
| 152 | return true; | 142 | return true; |
diff --git a/src/video_core/host_shaders/CMakeLists.txt b/src/video_core/host_shaders/CMakeLists.txt index 6b912027f..cd2549232 100644 --- a/src/video_core/host_shaders/CMakeLists.txt +++ b/src/video_core/host_shaders/CMakeLists.txt | |||
| @@ -19,6 +19,8 @@ set(SHADER_FILES | |||
| 19 | block_linear_unswizzle_2d.comp | 19 | block_linear_unswizzle_2d.comp |
| 20 | block_linear_unswizzle_3d.comp | 20 | block_linear_unswizzle_3d.comp |
| 21 | convert_abgr8_to_d24s8.frag | 21 | convert_abgr8_to_d24s8.frag |
| 22 | convert_abgr8_to_d32f.frag | ||
| 23 | convert_d32f_to_abgr8.frag | ||
| 22 | convert_d24s8_to_abgr8.frag | 24 | convert_d24s8_to_abgr8.frag |
| 23 | convert_depth_to_float.frag | 25 | convert_depth_to_float.frag |
| 24 | convert_float_to_depth.frag | 26 | convert_float_to_depth.frag |
diff --git a/src/video_core/host_shaders/convert_abgr8_to_d32f.frag b/src/video_core/host_shaders/convert_abgr8_to_d32f.frag new file mode 100644 index 000000000..095b910c2 --- /dev/null +++ b/src/video_core/host_shaders/convert_abgr8_to_d32f.frag | |||
| @@ -0,0 +1,15 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #version 450 | ||
| 5 | |||
| 6 | layout(binding = 0) uniform sampler2D color_texture; | ||
| 7 | |||
| 8 | void main() { | ||
| 9 | ivec2 coord = ivec2(gl_FragCoord.xy); | ||
| 10 | vec4 color = texelFetch(color_texture, coord, 0).abgr; | ||
| 11 | |||
| 12 | float value = color.a * (color.r + color.g + color.b) / 3.0f; | ||
| 13 | |||
| 14 | gl_FragDepth = value; | ||
| 15 | } | ||
diff --git a/src/video_core/host_shaders/convert_d24s8_to_abgr8.frag b/src/video_core/host_shaders/convert_d24s8_to_abgr8.frag index d33131d7c..b81a54056 100644 --- a/src/video_core/host_shaders/convert_d24s8_to_abgr8.frag +++ b/src/video_core/host_shaders/convert_d24s8_to_abgr8.frag | |||
| @@ -3,16 +3,16 @@ | |||
| 3 | 3 | ||
| 4 | #version 450 | 4 | #version 450 |
| 5 | 5 | ||
| 6 | precision mediump int; | ||
| 7 | precision highp float; | ||
| 8 | |||
| 6 | layout(binding = 0) uniform sampler2D depth_tex; | 9 | layout(binding = 0) uniform sampler2D depth_tex; |
| 7 | layout(binding = 1) uniform isampler2D stencil_tex; | 10 | layout(binding = 1) uniform usampler2D stencil_tex; |
| 8 | 11 | ||
| 9 | layout(location = 0) out vec4 color; | 12 | layout(location = 0) out vec4 color; |
| 10 | 13 | ||
| 11 | void main() { | 14 | void main() { |
| 12 | ivec2 coord = ivec2(gl_FragCoord.xy); | 15 | ivec2 coord = ivec2(gl_FragCoord.xy); |
| 13 | uint depth = uint(textureLod(depth_tex, coord, 0).r * (exp2(24.0) - 1.0f)); | ||
| 14 | uint stencil = uint(textureLod(stencil_tex, coord, 0).r); | ||
| 15 | |||
| 16 | highp uint depth_val = | 16 | highp uint depth_val = |
| 17 | uint(textureLod(depth_tex, coord, 0).r * (exp2(32.0) - 1.0)); | 17 | uint(textureLod(depth_tex, coord, 0).r * (exp2(32.0) - 1.0)); |
| 18 | lowp uint stencil_val = textureLod(stencil_tex, coord, 0).r; | 18 | lowp uint stencil_val = textureLod(stencil_tex, coord, 0).r; |
diff --git a/src/video_core/host_shaders/convert_d32f_to_abgr8.frag b/src/video_core/host_shaders/convert_d32f_to_abgr8.frag new file mode 100644 index 000000000..4e5a9f955 --- /dev/null +++ b/src/video_core/host_shaders/convert_d32f_to_abgr8.frag | |||
| @@ -0,0 +1,14 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #version 450 | ||
| 5 | |||
| 6 | layout(binding = 0) uniform sampler2D depth_tex; | ||
| 7 | |||
| 8 | layout(location = 0) out vec4 color; | ||
| 9 | |||
| 10 | void main() { | ||
| 11 | ivec2 coord = ivec2(gl_FragCoord.xy); | ||
| 12 | float depth = texelFetch(depth_tex, coord, 0).r; | ||
| 13 | color = vec4(depth, depth, depth, 1.0); | ||
| 14 | } | ||
diff --git a/src/video_core/host_shaders/convert_s8d24_to_abgr8.frag b/src/video_core/host_shaders/convert_s8d24_to_abgr8.frag index 31db7d426..6a457981d 100644 --- a/src/video_core/host_shaders/convert_s8d24_to_abgr8.frag +++ b/src/video_core/host_shaders/convert_s8d24_to_abgr8.frag | |||
| @@ -3,16 +3,16 @@ | |||
| 3 | 3 | ||
| 4 | #version 450 | 4 | #version 450 |
| 5 | 5 | ||
| 6 | precision mediump int; | ||
| 7 | precision highp float; | ||
| 8 | |||
| 6 | layout(binding = 0) uniform sampler2D depth_tex; | 9 | layout(binding = 0) uniform sampler2D depth_tex; |
| 7 | layout(binding = 1) uniform isampler2D stencil_tex; | 10 | layout(binding = 1) uniform usampler2D stencil_tex; |
| 8 | 11 | ||
| 9 | layout(location = 0) out vec4 color; | 12 | layout(location = 0) out vec4 color; |
| 10 | 13 | ||
| 11 | void main() { | 14 | void main() { |
| 12 | ivec2 coord = ivec2(gl_FragCoord.xy); | 15 | ivec2 coord = ivec2(gl_FragCoord.xy); |
| 13 | uint depth = uint(textureLod(depth_tex, coord, 0).r * (exp2(24.0) - 1.0f)); | ||
| 14 | uint stencil = uint(textureLod(stencil_tex, coord, 0).r); | ||
| 15 | |||
| 16 | highp uint depth_val = | 16 | highp uint depth_val = |
| 17 | uint(textureLod(depth_tex, coord, 0).r * (exp2(32.0) - 1.0)); | 17 | uint(textureLod(depth_tex, coord, 0).r * (exp2(32.0) - 1.0)); |
| 18 | lowp uint stencil_val = textureLod(stencil_tex, coord, 0).r; | 18 | lowp uint stencil_val = textureLod(stencil_tex, coord, 0).r; |
diff --git a/src/video_core/renderer_base.h b/src/video_core/renderer_base.h index 3e12a8813..78ea5208b 100644 --- a/src/video_core/renderer_base.h +++ b/src/video_core/renderer_base.h | |||
| @@ -89,9 +89,6 @@ public: | |||
| 89 | void RequestScreenshot(void* data, std::function<void(bool)> callback, | 89 | void RequestScreenshot(void* data, std::function<void(bool)> callback, |
| 90 | const Layout::FramebufferLayout& layout); | 90 | const Layout::FramebufferLayout& layout); |
| 91 | 91 | ||
| 92 | /// This is called to notify the rendering backend of a surface change | ||
| 93 | virtual void NotifySurfaceChanged() {} | ||
| 94 | |||
| 95 | protected: | 92 | protected: |
| 96 | Core::Frontend::EmuWindow& render_window; ///< Reference to the render window handle. | 93 | Core::Frontend::EmuWindow& render_window; ///< Reference to the render window handle. |
| 97 | std::unique_ptr<Core::Frontend::GraphicsContext> context; | 94 | std::unique_ptr<Core::Frontend::GraphicsContext> context; |
diff --git a/src/video_core/renderer_opengl/gl_texture_cache.cpp b/src/video_core/renderer_opengl/gl_texture_cache.cpp index 9cafd2983..512eef575 100644 --- a/src/video_core/renderer_opengl/gl_texture_cache.cpp +++ b/src/video_core/renderer_opengl/gl_texture_cache.cpp | |||
| @@ -1048,6 +1048,10 @@ void Image::Scale(bool up_scale) { | |||
| 1048 | } | 1048 | } |
| 1049 | 1049 | ||
| 1050 | bool Image::ScaleUp(bool ignore) { | 1050 | bool Image::ScaleUp(bool ignore) { |
| 1051 | const auto& resolution = runtime->resolution; | ||
| 1052 | if (!resolution.active) { | ||
| 1053 | return false; | ||
| 1054 | } | ||
| 1051 | if (True(flags & ImageFlagBits::Rescaled)) { | 1055 | if (True(flags & ImageFlagBits::Rescaled)) { |
| 1052 | return false; | 1056 | return false; |
| 1053 | } | 1057 | } |
| @@ -1060,9 +1064,6 @@ bool Image::ScaleUp(bool ignore) { | |||
| 1060 | return false; | 1064 | return false; |
| 1061 | } | 1065 | } |
| 1062 | flags |= ImageFlagBits::Rescaled; | 1066 | flags |= ImageFlagBits::Rescaled; |
| 1063 | if (!runtime->resolution.active) { | ||
| 1064 | return false; | ||
| 1065 | } | ||
| 1066 | has_scaled = true; | 1067 | has_scaled = true; |
| 1067 | if (ignore) { | 1068 | if (ignore) { |
| 1068 | current_texture = upscaled_backup.handle; | 1069 | current_texture = upscaled_backup.handle; |
| @@ -1073,13 +1074,14 @@ bool Image::ScaleUp(bool ignore) { | |||
| 1073 | } | 1074 | } |
| 1074 | 1075 | ||
| 1075 | bool Image::ScaleDown(bool ignore) { | 1076 | bool Image::ScaleDown(bool ignore) { |
| 1076 | if (False(flags & ImageFlagBits::Rescaled)) { | 1077 | const auto& resolution = runtime->resolution; |
| 1078 | if (!resolution.active) { | ||
| 1077 | return false; | 1079 | return false; |
| 1078 | } | 1080 | } |
| 1079 | flags &= ~ImageFlagBits::Rescaled; | 1081 | if (False(flags & ImageFlagBits::Rescaled)) { |
| 1080 | if (!runtime->resolution.active) { | ||
| 1081 | return false; | 1082 | return false; |
| 1082 | } | 1083 | } |
| 1084 | flags &= ~ImageFlagBits::Rescaled; | ||
| 1083 | if (ignore) { | 1085 | if (ignore) { |
| 1084 | current_texture = texture.handle; | 1086 | current_texture = texture.handle; |
| 1085 | return true; | 1087 | return true; |
diff --git a/src/video_core/renderer_opengl/gl_texture_cache.h b/src/video_core/renderer_opengl/gl_texture_cache.h index 3676eaaa9..e71b87e99 100644 --- a/src/video_core/renderer_opengl/gl_texture_cache.h +++ b/src/video_core/renderer_opengl/gl_texture_cache.h | |||
| @@ -118,6 +118,8 @@ public: | |||
| 118 | 118 | ||
| 119 | void InsertUploadMemoryBarrier(); | 119 | void InsertUploadMemoryBarrier(); |
| 120 | 120 | ||
| 121 | void TransitionImageLayout(Image& image) {} | ||
| 122 | |||
| 121 | FormatProperties FormatInfo(VideoCommon::ImageType type, GLenum internal_format) const; | 123 | FormatProperties FormatInfo(VideoCommon::ImageType type, GLenum internal_format) const; |
| 122 | 124 | ||
| 123 | bool HasNativeBgr() const noexcept { | 125 | bool HasNativeBgr() const noexcept { |
diff --git a/src/video_core/renderer_opengl/maxwell_to_gl.h b/src/video_core/renderer_opengl/maxwell_to_gl.h index c7dc7e0a1..5ea9e2378 100644 --- a/src/video_core/renderer_opengl/maxwell_to_gl.h +++ b/src/video_core/renderer_opengl/maxwell_to_gl.h | |||
| @@ -116,6 +116,7 @@ constexpr std::array<FormatTuple, VideoCore::Surface::MaxPixelFormat> FORMAT_TAB | |||
| 116 | {GL_RGB9_E5, GL_RGB, GL_UNSIGNED_INT_5_9_9_9_REV}, // E5B9G9R9_FLOAT | 116 | {GL_RGB9_E5, GL_RGB, GL_UNSIGNED_INT_5_9_9_9_REV}, // E5B9G9R9_FLOAT |
| 117 | {GL_DEPTH_COMPONENT32F, GL_DEPTH_COMPONENT, GL_FLOAT}, // D32_FLOAT | 117 | {GL_DEPTH_COMPONENT32F, GL_DEPTH_COMPONENT, GL_FLOAT}, // D32_FLOAT |
| 118 | {GL_DEPTH_COMPONENT16, GL_DEPTH_COMPONENT, GL_UNSIGNED_SHORT}, // D16_UNORM | 118 | {GL_DEPTH_COMPONENT16, GL_DEPTH_COMPONENT, GL_UNSIGNED_SHORT}, // D16_UNORM |
| 119 | {GL_DEPTH_COMPONENT24, GL_DEPTH_COMPONENT, GL_UNSIGNED_INT_24_8}, // X8_D24_UNORM | ||
| 119 | {GL_STENCIL_INDEX8, GL_STENCIL, GL_UNSIGNED_BYTE}, // S8_UINT | 120 | {GL_STENCIL_INDEX8, GL_STENCIL, GL_UNSIGNED_BYTE}, // S8_UINT |
| 120 | {GL_DEPTH24_STENCIL8, GL_DEPTH_STENCIL, GL_UNSIGNED_INT_24_8}, // D24_UNORM_S8_UINT | 121 | {GL_DEPTH24_STENCIL8, GL_DEPTH_STENCIL, GL_UNSIGNED_INT_24_8}, // D24_UNORM_S8_UINT |
| 121 | {GL_DEPTH24_STENCIL8, GL_DEPTH_STENCIL, GL_UNSIGNED_INT_24_8}, // S8_UINT_D24_UNORM | 122 | {GL_DEPTH24_STENCIL8, GL_DEPTH_STENCIL, GL_UNSIGNED_INT_24_8}, // S8_UINT_D24_UNORM |
diff --git a/src/video_core/renderer_vulkan/blit_image.cpp b/src/video_core/renderer_vulkan/blit_image.cpp index 1032c9d12..c3db09424 100644 --- a/src/video_core/renderer_vulkan/blit_image.cpp +++ b/src/video_core/renderer_vulkan/blit_image.cpp | |||
| @@ -8,7 +8,9 @@ | |||
| 8 | #include "common/settings.h" | 8 | #include "common/settings.h" |
| 9 | #include "video_core/host_shaders/blit_color_float_frag_spv.h" | 9 | #include "video_core/host_shaders/blit_color_float_frag_spv.h" |
| 10 | #include "video_core/host_shaders/convert_abgr8_to_d24s8_frag_spv.h" | 10 | #include "video_core/host_shaders/convert_abgr8_to_d24s8_frag_spv.h" |
| 11 | #include "video_core/host_shaders/convert_abgr8_to_d32f_frag_spv.h" | ||
| 11 | #include "video_core/host_shaders/convert_d24s8_to_abgr8_frag_spv.h" | 12 | #include "video_core/host_shaders/convert_d24s8_to_abgr8_frag_spv.h" |
| 13 | #include "video_core/host_shaders/convert_d32f_to_abgr8_frag_spv.h" | ||
| 12 | #include "video_core/host_shaders/convert_depth_to_float_frag_spv.h" | 14 | #include "video_core/host_shaders/convert_depth_to_float_frag_spv.h" |
| 13 | #include "video_core/host_shaders/convert_float_to_depth_frag_spv.h" | 15 | #include "video_core/host_shaders/convert_float_to_depth_frag_spv.h" |
| 14 | #include "video_core/host_shaders/convert_s8d24_to_abgr8_frag_spv.h" | 16 | #include "video_core/host_shaders/convert_s8d24_to_abgr8_frag_spv.h" |
| @@ -433,6 +435,8 @@ BlitImageHelper::BlitImageHelper(const Device& device_, Scheduler& scheduler_, | |||
| 433 | convert_depth_to_float_frag(BuildShader(device, CONVERT_DEPTH_TO_FLOAT_FRAG_SPV)), | 435 | convert_depth_to_float_frag(BuildShader(device, CONVERT_DEPTH_TO_FLOAT_FRAG_SPV)), |
| 434 | convert_float_to_depth_frag(BuildShader(device, CONVERT_FLOAT_TO_DEPTH_FRAG_SPV)), | 436 | convert_float_to_depth_frag(BuildShader(device, CONVERT_FLOAT_TO_DEPTH_FRAG_SPV)), |
| 435 | convert_abgr8_to_d24s8_frag(BuildShader(device, CONVERT_ABGR8_TO_D24S8_FRAG_SPV)), | 437 | convert_abgr8_to_d24s8_frag(BuildShader(device, CONVERT_ABGR8_TO_D24S8_FRAG_SPV)), |
| 438 | convert_abgr8_to_d32f_frag(BuildShader(device, CONVERT_ABGR8_TO_D32F_FRAG_SPV)), | ||
| 439 | convert_d32f_to_abgr8_frag(BuildShader(device, CONVERT_D32F_TO_ABGR8_FRAG_SPV)), | ||
| 436 | convert_d24s8_to_abgr8_frag(BuildShader(device, CONVERT_D24S8_TO_ABGR8_FRAG_SPV)), | 440 | convert_d24s8_to_abgr8_frag(BuildShader(device, CONVERT_D24S8_TO_ABGR8_FRAG_SPV)), |
| 437 | convert_s8d24_to_abgr8_frag(BuildShader(device, CONVERT_S8D24_TO_ABGR8_FRAG_SPV)), | 441 | convert_s8d24_to_abgr8_frag(BuildShader(device, CONVERT_S8D24_TO_ABGR8_FRAG_SPV)), |
| 438 | linear_sampler(device.GetLogical().CreateSampler(SAMPLER_CREATE_INFO<VK_FILTER_LINEAR>)), | 442 | linear_sampler(device.GetLogical().CreateSampler(SAMPLER_CREATE_INFO<VK_FILTER_LINEAR>)), |
| @@ -557,6 +561,20 @@ void BlitImageHelper::ConvertABGR8ToD24S8(const Framebuffer* dst_framebuffer, | |||
| 557 | Convert(*convert_abgr8_to_d24s8_pipeline, dst_framebuffer, src_image_view); | 561 | Convert(*convert_abgr8_to_d24s8_pipeline, dst_framebuffer, src_image_view); |
| 558 | } | 562 | } |
| 559 | 563 | ||
| 564 | void BlitImageHelper::ConvertABGR8ToD32F(const Framebuffer* dst_framebuffer, | ||
| 565 | const ImageView& src_image_view) { | ||
| 566 | ConvertPipelineDepthTargetEx(convert_abgr8_to_d32f_pipeline, dst_framebuffer->RenderPass(), | ||
| 567 | convert_abgr8_to_d32f_frag); | ||
| 568 | Convert(*convert_abgr8_to_d32f_pipeline, dst_framebuffer, src_image_view); | ||
| 569 | } | ||
| 570 | |||
| 571 | void BlitImageHelper::ConvertD32FToABGR8(const Framebuffer* dst_framebuffer, | ||
| 572 | ImageView& src_image_view) { | ||
| 573 | ConvertPipelineColorTargetEx(convert_d32f_to_abgr8_pipeline, dst_framebuffer->RenderPass(), | ||
| 574 | convert_d32f_to_abgr8_frag); | ||
| 575 | ConvertDepthStencil(*convert_d32f_to_abgr8_pipeline, dst_framebuffer, src_image_view); | ||
| 576 | } | ||
| 577 | |||
| 560 | void BlitImageHelper::ConvertD24S8ToABGR8(const Framebuffer* dst_framebuffer, | 578 | void BlitImageHelper::ConvertD24S8ToABGR8(const Framebuffer* dst_framebuffer, |
| 561 | ImageView& src_image_view) { | 579 | ImageView& src_image_view) { |
| 562 | ConvertPipelineColorTargetEx(convert_d24s8_to_abgr8_pipeline, dst_framebuffer->RenderPass(), | 580 | ConvertPipelineColorTargetEx(convert_d24s8_to_abgr8_pipeline, dst_framebuffer->RenderPass(), |
| @@ -609,6 +627,8 @@ void BlitImageHelper::ClearDepthStencil(const Framebuffer* dst_framebuffer, bool | |||
| 609 | const VkPipelineLayout layout = *clear_color_pipeline_layout; | 627 | const VkPipelineLayout layout = *clear_color_pipeline_layout; |
| 610 | scheduler.RequestRenderpass(dst_framebuffer); | 628 | scheduler.RequestRenderpass(dst_framebuffer); |
| 611 | scheduler.Record([pipeline, layout, clear_depth, dst_region](vk::CommandBuffer cmdbuf) { | 629 | scheduler.Record([pipeline, layout, clear_depth, dst_region](vk::CommandBuffer cmdbuf) { |
| 630 | constexpr std::array blend_constants{0.0f, 0.0f, 0.0f, 0.0f}; | ||
| 631 | cmdbuf.SetBlendConstants(blend_constants.data()); | ||
| 612 | cmdbuf.BindPipeline(VK_PIPELINE_BIND_POINT_GRAPHICS, pipeline); | 632 | cmdbuf.BindPipeline(VK_PIPELINE_BIND_POINT_GRAPHICS, pipeline); |
| 613 | BindBlitState(cmdbuf, dst_region); | 633 | BindBlitState(cmdbuf, dst_region); |
| 614 | cmdbuf.PushConstants(layout, VK_SHADER_STAGE_FRAGMENT_BIT, clear_depth); | 634 | cmdbuf.PushConstants(layout, VK_SHADER_STAGE_FRAGMENT_BIT, clear_depth); |
| @@ -865,7 +885,7 @@ VkPipeline BlitImageHelper::FindOrEmplaceClearStencilPipeline( | |||
| 865 | .sType = VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO, | 885 | .sType = VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO, |
| 866 | .pNext = nullptr, | 886 | .pNext = nullptr, |
| 867 | .flags = 0, | 887 | .flags = 0, |
| 868 | .depthTestEnable = VK_FALSE, | 888 | .depthTestEnable = key.depth_clear, |
| 869 | .depthWriteEnable = key.depth_clear, | 889 | .depthWriteEnable = key.depth_clear, |
| 870 | .depthCompareOp = VK_COMPARE_OP_ALWAYS, | 890 | .depthCompareOp = VK_COMPARE_OP_ALWAYS, |
| 871 | .depthBoundsTestEnable = VK_FALSE, | 891 | .depthBoundsTestEnable = VK_FALSE, |
diff --git a/src/video_core/renderer_vulkan/blit_image.h b/src/video_core/renderer_vulkan/blit_image.h index dcfe217aa..b2104a59e 100644 --- a/src/video_core/renderer_vulkan/blit_image.h +++ b/src/video_core/renderer_vulkan/blit_image.h | |||
| @@ -67,6 +67,10 @@ public: | |||
| 67 | 67 | ||
| 68 | void ConvertABGR8ToD24S8(const Framebuffer* dst_framebuffer, const ImageView& src_image_view); | 68 | void ConvertABGR8ToD24S8(const Framebuffer* dst_framebuffer, const ImageView& src_image_view); |
| 69 | 69 | ||
| 70 | void ConvertABGR8ToD32F(const Framebuffer* dst_framebuffer, const ImageView& src_image_view); | ||
| 71 | |||
| 72 | void ConvertD32FToABGR8(const Framebuffer* dst_framebuffer, ImageView& src_image_view); | ||
| 73 | |||
| 70 | void ConvertD24S8ToABGR8(const Framebuffer* dst_framebuffer, ImageView& src_image_view); | 74 | void ConvertD24S8ToABGR8(const Framebuffer* dst_framebuffer, ImageView& src_image_view); |
| 71 | 75 | ||
| 72 | void ConvertS8D24ToABGR8(const Framebuffer* dst_framebuffer, ImageView& src_image_view); | 76 | void ConvertS8D24ToABGR8(const Framebuffer* dst_framebuffer, ImageView& src_image_view); |
| @@ -128,6 +132,8 @@ private: | |||
| 128 | vk::ShaderModule convert_depth_to_float_frag; | 132 | vk::ShaderModule convert_depth_to_float_frag; |
| 129 | vk::ShaderModule convert_float_to_depth_frag; | 133 | vk::ShaderModule convert_float_to_depth_frag; |
| 130 | vk::ShaderModule convert_abgr8_to_d24s8_frag; | 134 | vk::ShaderModule convert_abgr8_to_d24s8_frag; |
| 135 | vk::ShaderModule convert_abgr8_to_d32f_frag; | ||
| 136 | vk::ShaderModule convert_d32f_to_abgr8_frag; | ||
| 131 | vk::ShaderModule convert_d24s8_to_abgr8_frag; | 137 | vk::ShaderModule convert_d24s8_to_abgr8_frag; |
| 132 | vk::ShaderModule convert_s8d24_to_abgr8_frag; | 138 | vk::ShaderModule convert_s8d24_to_abgr8_frag; |
| 133 | vk::Sampler linear_sampler; | 139 | vk::Sampler linear_sampler; |
| @@ -146,6 +152,8 @@ private: | |||
| 146 | vk::Pipeline convert_d16_to_r16_pipeline; | 152 | vk::Pipeline convert_d16_to_r16_pipeline; |
| 147 | vk::Pipeline convert_r16_to_d16_pipeline; | 153 | vk::Pipeline convert_r16_to_d16_pipeline; |
| 148 | vk::Pipeline convert_abgr8_to_d24s8_pipeline; | 154 | vk::Pipeline convert_abgr8_to_d24s8_pipeline; |
| 155 | vk::Pipeline convert_abgr8_to_d32f_pipeline; | ||
| 156 | vk::Pipeline convert_d32f_to_abgr8_pipeline; | ||
| 149 | vk::Pipeline convert_d24s8_to_abgr8_pipeline; | 157 | vk::Pipeline convert_d24s8_to_abgr8_pipeline; |
| 150 | vk::Pipeline convert_s8d24_to_abgr8_pipeline; | 158 | vk::Pipeline convert_s8d24_to_abgr8_pipeline; |
| 151 | }; | 159 | }; |
diff --git a/src/video_core/renderer_vulkan/maxwell_to_vk.cpp b/src/video_core/renderer_vulkan/maxwell_to_vk.cpp index 208e88533..a08f2f67f 100644 --- a/src/video_core/renderer_vulkan/maxwell_to_vk.cpp +++ b/src/video_core/renderer_vulkan/maxwell_to_vk.cpp | |||
| @@ -214,8 +214,9 @@ struct FormatTuple { | |||
| 214 | {VK_FORMAT_E5B9G9R9_UFLOAT_PACK32}, // E5B9G9R9_FLOAT | 214 | {VK_FORMAT_E5B9G9R9_UFLOAT_PACK32}, // E5B9G9R9_FLOAT |
| 215 | 215 | ||
| 216 | // Depth formats | 216 | // Depth formats |
| 217 | {VK_FORMAT_D32_SFLOAT, Attachable}, // D32_FLOAT | 217 | {VK_FORMAT_D32_SFLOAT, Attachable}, // D32_FLOAT |
| 218 | {VK_FORMAT_D16_UNORM, Attachable}, // D16_UNORM | 218 | {VK_FORMAT_D16_UNORM, Attachable}, // D16_UNORM |
| 219 | {VK_FORMAT_X8_D24_UNORM_PACK32, Attachable}, // X8_D24_UNORM | ||
| 219 | 220 | ||
| 220 | // Stencil formats | 221 | // Stencil formats |
| 221 | {VK_FORMAT_S8_UINT, Attachable}, // S8_UINT | 222 | {VK_FORMAT_S8_UINT, Attachable}, // S8_UINT |
diff --git a/src/video_core/renderer_vulkan/renderer_vulkan.cpp b/src/video_core/renderer_vulkan/renderer_vulkan.cpp index c4c30d807..7e7a80740 100644 --- a/src/video_core/renderer_vulkan/renderer_vulkan.cpp +++ b/src/video_core/renderer_vulkan/renderer_vulkan.cpp | |||
| @@ -132,12 +132,16 @@ void RendererVulkan::SwapBuffers(const Tegra::FramebufferConfig* framebuffer) { | |||
| 132 | const bool use_accelerated = | 132 | const bool use_accelerated = |
| 133 | rasterizer.AccelerateDisplay(*framebuffer, framebuffer_addr, framebuffer->stride); | 133 | rasterizer.AccelerateDisplay(*framebuffer, framebuffer_addr, framebuffer->stride); |
| 134 | const bool is_srgb = use_accelerated && screen_info.is_srgb; | 134 | const bool is_srgb = use_accelerated && screen_info.is_srgb; |
| 135 | RenderScreenshot(*framebuffer, use_accelerated); | ||
| 136 | 135 | ||
| 137 | Frame* frame = present_manager.GetRenderFrame(); | 136 | { |
| 138 | blit_screen.DrawToSwapchain(frame, *framebuffer, use_accelerated, is_srgb); | 137 | std::scoped_lock lock{rasterizer.LockCaches()}; |
| 139 | scheduler.Flush(*frame->render_ready); | 138 | RenderScreenshot(*framebuffer, use_accelerated); |
| 140 | present_manager.Present(frame); | 139 | |
| 140 | Frame* frame = present_manager.GetRenderFrame(); | ||
| 141 | blit_screen.DrawToSwapchain(frame, *framebuffer, use_accelerated, is_srgb); | ||
| 142 | scheduler.Flush(*frame->render_ready); | ||
| 143 | present_manager.Present(frame); | ||
| 144 | } | ||
| 141 | 145 | ||
| 142 | gpu.RendererFrameEndNotify(); | 146 | gpu.RendererFrameEndNotify(); |
| 143 | rasterizer.TickFrame(); | 147 | rasterizer.TickFrame(); |
diff --git a/src/video_core/renderer_vulkan/renderer_vulkan.h b/src/video_core/renderer_vulkan/renderer_vulkan.h index 590bc1c64..14e257cf7 100644 --- a/src/video_core/renderer_vulkan/renderer_vulkan.h +++ b/src/video_core/renderer_vulkan/renderer_vulkan.h | |||
| @@ -56,10 +56,6 @@ public: | |||
| 56 | return device.GetDriverName(); | 56 | return device.GetDriverName(); |
| 57 | } | 57 | } |
| 58 | 58 | ||
| 59 | void NotifySurfaceChanged() override { | ||
| 60 | present_manager.NotifySurfaceChanged(); | ||
| 61 | } | ||
| 62 | |||
| 63 | private: | 59 | private: |
| 64 | void Report() const; | 60 | void Report() const; |
| 65 | 61 | ||
diff --git a/src/video_core/renderer_vulkan/vk_blit_screen.cpp b/src/video_core/renderer_vulkan/vk_blit_screen.cpp index 31928bb94..52fc142d1 100644 --- a/src/video_core/renderer_vulkan/vk_blit_screen.cpp +++ b/src/video_core/renderer_vulkan/vk_blit_screen.cpp | |||
| @@ -96,6 +96,7 @@ std::size_t GetSizeInBytes(const Tegra::FramebufferConfig& framebuffer) { | |||
| 96 | VkFormat GetFormat(const Tegra::FramebufferConfig& framebuffer) { | 96 | VkFormat GetFormat(const Tegra::FramebufferConfig& framebuffer) { |
| 97 | switch (framebuffer.pixel_format) { | 97 | switch (framebuffer.pixel_format) { |
| 98 | case Service::android::PixelFormat::Rgba8888: | 98 | case Service::android::PixelFormat::Rgba8888: |
| 99 | case Service::android::PixelFormat::Rgbx8888: | ||
| 99 | return VK_FORMAT_A8B8G8R8_UNORM_PACK32; | 100 | return VK_FORMAT_A8B8G8R8_UNORM_PACK32; |
| 100 | case Service::android::PixelFormat::Rgb565: | 101 | case Service::android::PixelFormat::Rgb565: |
| 101 | return VK_FORMAT_R5G6B5_UNORM_PACK16; | 102 | return VK_FORMAT_R5G6B5_UNORM_PACK16; |
diff --git a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp index a1ec1a100..22bf8cc77 100644 --- a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp | |||
| @@ -356,7 +356,11 @@ PipelineCache::PipelineCache(RasterizerVulkan& rasterizer_, const Device& device | |||
| 356 | .has_broken_fp16_float_controls = driver_id == VK_DRIVER_ID_NVIDIA_PROPRIETARY, | 356 | .has_broken_fp16_float_controls = driver_id == VK_DRIVER_ID_NVIDIA_PROPRIETARY, |
| 357 | .ignore_nan_fp_comparisons = false, | 357 | .ignore_nan_fp_comparisons = false, |
| 358 | .has_broken_spirv_subgroup_mask_vector_extract_dynamic = | 358 | .has_broken_spirv_subgroup_mask_vector_extract_dynamic = |
| 359 | driver_id == VK_DRIVER_ID_QUALCOMM_PROPRIETARY}; | 359 | driver_id == VK_DRIVER_ID_QUALCOMM_PROPRIETARY, |
| 360 | .has_broken_robust = | ||
| 361 | device.IsNvidia() && device.GetNvidiaArch() <= NvidiaArchitecture::Arch_Pascal, | ||
| 362 | }; | ||
| 363 | |||
| 360 | host_info = Shader::HostTranslateInfo{ | 364 | host_info = Shader::HostTranslateInfo{ |
| 361 | .support_float64 = device.IsFloat64Supported(), | 365 | .support_float64 = device.IsFloat64Supported(), |
| 362 | .support_float16 = device.IsFloat16Supported(), | 366 | .support_float16 = device.IsFloat16Supported(), |
diff --git a/src/video_core/renderer_vulkan/vk_present_manager.cpp b/src/video_core/renderer_vulkan/vk_present_manager.cpp index d681bd22a..2ef36583b 100644 --- a/src/video_core/renderer_vulkan/vk_present_manager.cpp +++ b/src/video_core/renderer_vulkan/vk_present_manager.cpp | |||
| @@ -103,8 +103,7 @@ PresentManager::PresentManager(const vk::Instance& instance_, | |||
| 103 | surface{surface_}, blit_supported{CanBlitToSwapchain(device.GetPhysical(), | 103 | surface{surface_}, blit_supported{CanBlitToSwapchain(device.GetPhysical(), |
| 104 | swapchain.GetImageViewFormat())}, | 104 | swapchain.GetImageViewFormat())}, |
| 105 | use_present_thread{Settings::values.async_presentation.GetValue()}, | 105 | use_present_thread{Settings::values.async_presentation.GetValue()}, |
| 106 | image_count{swapchain.GetImageCount()}, last_render_surface{ | 106 | image_count{swapchain.GetImageCount()} { |
| 107 | render_window_.GetWindowInfo().render_surface} { | ||
| 108 | 107 | ||
| 109 | auto& dld = device.GetLogical(); | 108 | auto& dld = device.GetLogical(); |
| 110 | cmdpool = dld.CreateCommandPool({ | 109 | cmdpool = dld.CreateCommandPool({ |
| @@ -289,44 +288,36 @@ void PresentManager::PresentThread(std::stop_token token) { | |||
| 289 | } | 288 | } |
| 290 | } | 289 | } |
| 291 | 290 | ||
| 292 | void PresentManager::NotifySurfaceChanged() { | 291 | void PresentManager::RecreateSwapchain(Frame* frame) { |
| 293 | #ifdef ANDROID | 292 | swapchain.Create(*surface, frame->width, frame->height, frame->is_srgb); |
| 294 | std::scoped_lock lock{recreate_surface_mutex}; | 293 | image_count = swapchain.GetImageCount(); |
| 295 | recreate_surface_cv.notify_one(); | ||
| 296 | #endif | ||
| 297 | } | 294 | } |
| 298 | 295 | ||
| 299 | void PresentManager::CopyToSwapchain(Frame* frame) { | 296 | void PresentManager::CopyToSwapchain(Frame* frame) { |
| 300 | MICROPROFILE_SCOPE(Vulkan_CopyToSwapchain); | 297 | bool requires_recreation = false; |
| 301 | 298 | ||
| 302 | const auto recreate_swapchain = [&] { | 299 | while (true) { |
| 303 | swapchain.Create(*surface, frame->width, frame->height, frame->is_srgb); | 300 | try { |
| 304 | image_count = swapchain.GetImageCount(); | 301 | // Recreate surface and swapchain if needed. |
| 305 | }; | 302 | if (requires_recreation) { |
| 306 | 303 | surface = CreateSurface(instance, render_window.GetWindowInfo()); | |
| 307 | #ifdef ANDROID | 304 | RecreateSwapchain(frame); |
| 308 | std::unique_lock lock{recreate_surface_mutex}; | 305 | } |
| 309 | 306 | ||
| 310 | const auto needs_recreation = [&] { | 307 | // Draw to swapchain. |
| 311 | if (last_render_surface != render_window.GetWindowInfo().render_surface) { | 308 | return CopyToSwapchainImpl(frame); |
| 312 | return true; | 309 | } catch (const vk::Exception& except) { |
| 313 | } | 310 | if (except.GetResult() != VK_ERROR_SURFACE_LOST_KHR) { |
| 314 | if (swapchain.NeedsRecreation(frame->is_srgb)) { | 311 | throw; |
| 315 | return true; | 312 | } |
| 313 | |||
| 314 | requires_recreation = true; | ||
| 316 | } | 315 | } |
| 317 | return false; | ||
| 318 | }; | ||
| 319 | |||
| 320 | recreate_surface_cv.wait_for(lock, std::chrono::milliseconds(400), | ||
| 321 | [&]() { return !needs_recreation(); }); | ||
| 322 | |||
| 323 | // If the frontend recreated the surface, recreate the renderer surface and swapchain. | ||
| 324 | if (last_render_surface != render_window.GetWindowInfo().render_surface) { | ||
| 325 | last_render_surface = render_window.GetWindowInfo().render_surface; | ||
| 326 | surface = CreateSurface(instance, render_window.GetWindowInfo()); | ||
| 327 | recreate_swapchain(); | ||
| 328 | } | 316 | } |
| 329 | #endif | 317 | } |
| 318 | |||
| 319 | void PresentManager::CopyToSwapchainImpl(Frame* frame) { | ||
| 320 | MICROPROFILE_SCOPE(Vulkan_CopyToSwapchain); | ||
| 330 | 321 | ||
| 331 | // If the size or colorspace of the incoming frames has changed, recreate the swapchain | 322 | // If the size or colorspace of the incoming frames has changed, recreate the swapchain |
| 332 | // to account for that. | 323 | // to account for that. |
| @@ -334,11 +325,11 @@ void PresentManager::CopyToSwapchain(Frame* frame) { | |||
| 334 | const bool size_changed = | 325 | const bool size_changed = |
| 335 | swapchain.GetWidth() != frame->width || swapchain.GetHeight() != frame->height; | 326 | swapchain.GetWidth() != frame->width || swapchain.GetHeight() != frame->height; |
| 336 | if (srgb_changed || size_changed) { | 327 | if (srgb_changed || size_changed) { |
| 337 | recreate_swapchain(); | 328 | RecreateSwapchain(frame); |
| 338 | } | 329 | } |
| 339 | 330 | ||
| 340 | while (swapchain.AcquireNextImage()) { | 331 | while (swapchain.AcquireNextImage()) { |
| 341 | recreate_swapchain(); | 332 | RecreateSwapchain(frame); |
| 342 | } | 333 | } |
| 343 | 334 | ||
| 344 | const vk::CommandBuffer cmdbuf{frame->cmdbuf}; | 335 | const vk::CommandBuffer cmdbuf{frame->cmdbuf}; |
| @@ -488,4 +479,4 @@ void PresentManager::CopyToSwapchain(Frame* frame) { | |||
| 488 | swapchain.Present(render_semaphore); | 479 | swapchain.Present(render_semaphore); |
| 489 | } | 480 | } |
| 490 | 481 | ||
| 491 | } // namespace Vulkan \ No newline at end of file | 482 | } // namespace Vulkan |
diff --git a/src/video_core/renderer_vulkan/vk_present_manager.h b/src/video_core/renderer_vulkan/vk_present_manager.h index 83e859416..a3d825fe6 100644 --- a/src/video_core/renderer_vulkan/vk_present_manager.h +++ b/src/video_core/renderer_vulkan/vk_present_manager.h | |||
| @@ -54,14 +54,15 @@ public: | |||
| 54 | /// Waits for the present thread to finish presenting all queued frames. | 54 | /// Waits for the present thread to finish presenting all queued frames. |
| 55 | void WaitPresent(); | 55 | void WaitPresent(); |
| 56 | 56 | ||
| 57 | /// This is called to notify the rendering backend of a surface change | ||
| 58 | void NotifySurfaceChanged(); | ||
| 59 | |||
| 60 | private: | 57 | private: |
| 61 | void PresentThread(std::stop_token token); | 58 | void PresentThread(std::stop_token token); |
| 62 | 59 | ||
| 63 | void CopyToSwapchain(Frame* frame); | 60 | void CopyToSwapchain(Frame* frame); |
| 64 | 61 | ||
| 62 | void CopyToSwapchainImpl(Frame* frame); | ||
| 63 | |||
| 64 | void RecreateSwapchain(Frame* frame); | ||
| 65 | |||
| 65 | private: | 66 | private: |
| 66 | const vk::Instance& instance; | 67 | const vk::Instance& instance; |
| 67 | Core::Frontend::EmuWindow& render_window; | 68 | Core::Frontend::EmuWindow& render_window; |
| @@ -76,16 +77,13 @@ private: | |||
| 76 | std::queue<Frame*> free_queue; | 77 | std::queue<Frame*> free_queue; |
| 77 | std::condition_variable_any frame_cv; | 78 | std::condition_variable_any frame_cv; |
| 78 | std::condition_variable free_cv; | 79 | std::condition_variable free_cv; |
| 79 | std::condition_variable recreate_surface_cv; | ||
| 80 | std::mutex swapchain_mutex; | 80 | std::mutex swapchain_mutex; |
| 81 | std::mutex recreate_surface_mutex; | ||
| 82 | std::mutex queue_mutex; | 81 | std::mutex queue_mutex; |
| 83 | std::mutex free_mutex; | 82 | std::mutex free_mutex; |
| 84 | std::jthread present_thread; | 83 | std::jthread present_thread; |
| 85 | bool blit_supported; | 84 | bool blit_supported; |
| 86 | bool use_present_thread; | 85 | bool use_present_thread; |
| 87 | std::size_t image_count{}; | 86 | std::size_t image_count{}; |
| 88 | void* last_render_surface{}; | ||
| 89 | }; | 87 | }; |
| 90 | 88 | ||
| 91 | } // namespace Vulkan | 89 | } // namespace Vulkan |
diff --git a/src/video_core/renderer_vulkan/vk_query_cache.cpp b/src/video_core/renderer_vulkan/vk_query_cache.cpp index 2edaafa7e..66c03bf17 100644 --- a/src/video_core/renderer_vulkan/vk_query_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_query_cache.cpp | |||
| @@ -1436,6 +1436,7 @@ void QueryCacheRuntime::Barriers(bool is_prebarrier) { | |||
| 1436 | .srcAccessMask = VK_ACCESS_TRANSFER_WRITE_BIT, | 1436 | .srcAccessMask = VK_ACCESS_TRANSFER_WRITE_BIT, |
| 1437 | .dstAccessMask = VK_ACCESS_MEMORY_READ_BIT | VK_ACCESS_MEMORY_WRITE_BIT, | 1437 | .dstAccessMask = VK_ACCESS_MEMORY_READ_BIT | VK_ACCESS_MEMORY_WRITE_BIT, |
| 1438 | }; | 1438 | }; |
| 1439 | impl->scheduler.RequestOutsideRenderPassOperationContext(); | ||
| 1439 | if (is_prebarrier) { | 1440 | if (is_prebarrier) { |
| 1440 | impl->scheduler.Record([](vk::CommandBuffer cmdbuf) { | 1441 | impl->scheduler.Record([](vk::CommandBuffer cmdbuf) { |
| 1441 | cmdbuf.PipelineBarrier(VK_PIPELINE_STAGE_ALL_COMMANDS_BIT, | 1442 | cmdbuf.PipelineBarrier(VK_PIPELINE_STAGE_ALL_COMMANDS_BIT, |
diff --git a/src/video_core/renderer_vulkan/vk_rasterizer.cpp b/src/video_core/renderer_vulkan/vk_rasterizer.cpp index 1628d76d6..059b7cb40 100644 --- a/src/video_core/renderer_vulkan/vk_rasterizer.cpp +++ b/src/video_core/renderer_vulkan/vk_rasterizer.cpp | |||
| @@ -13,6 +13,7 @@ | |||
| 13 | #include "common/microprofile.h" | 13 | #include "common/microprofile.h" |
| 14 | #include "common/scope_exit.h" | 14 | #include "common/scope_exit.h" |
| 15 | #include "common/settings.h" | 15 | #include "common/settings.h" |
| 16 | #include "video_core/buffer_cache/buffer_cache.h" | ||
| 16 | #include "video_core/control/channel_state.h" | 17 | #include "video_core/control/channel_state.h" |
| 17 | #include "video_core/engines/draw_manager.h" | 18 | #include "video_core/engines/draw_manager.h" |
| 18 | #include "video_core/engines/kepler_compute.h" | 19 | #include "video_core/engines/kepler_compute.h" |
| @@ -198,7 +199,7 @@ void RasterizerVulkan::PrepareDraw(bool is_indexed, Func&& draw_func) { | |||
| 198 | if (!pipeline) { | 199 | if (!pipeline) { |
| 199 | return; | 200 | return; |
| 200 | } | 201 | } |
| 201 | std::scoped_lock lock{buffer_cache.mutex, texture_cache.mutex}; | 202 | std::scoped_lock lock{LockCaches()}; |
| 202 | // update engine as channel may be different. | 203 | // update engine as channel may be different. |
| 203 | pipeline->SetEngine(maxwell3d, gpu_memory); | 204 | pipeline->SetEngine(maxwell3d, gpu_memory); |
| 204 | pipeline->Configure(is_indexed); | 205 | pipeline->Configure(is_indexed); |
| @@ -285,6 +286,7 @@ void RasterizerVulkan::DrawTexture() { | |||
| 285 | 286 | ||
| 286 | query_cache.NotifySegment(true); | 287 | query_cache.NotifySegment(true); |
| 287 | 288 | ||
| 289 | std::scoped_lock l{texture_cache.mutex}; | ||
| 288 | texture_cache.SynchronizeGraphicsDescriptors(); | 290 | texture_cache.SynchronizeGraphicsDescriptors(); |
| 289 | texture_cache.UpdateRenderTargets(false); | 291 | texture_cache.UpdateRenderTargets(false); |
| 290 | 292 | ||
| @@ -422,7 +424,8 @@ void RasterizerVulkan::Clear(u32 layer_count) { | |||
| 422 | return; | 424 | return; |
| 423 | } | 425 | } |
| 424 | 426 | ||
| 425 | if (use_stencil && regs.stencil_front_mask != 0xFF && regs.stencil_front_mask != 0) { | 427 | if (use_stencil && framebuffer->HasAspectStencilBit() && regs.stencil_front_mask != 0xFF && |
| 428 | regs.stencil_front_mask != 0) { | ||
| 426 | Region2D dst_region = { | 429 | Region2D dst_region = { |
| 427 | Offset2D{.x = clear_rect.rect.offset.x, .y = clear_rect.rect.offset.y}, | 430 | Offset2D{.x = clear_rect.rect.offset.x, .y = clear_rect.rect.offset.y}, |
| 428 | Offset2D{.x = clear_rect.rect.offset.x + static_cast<s32>(clear_rect.rect.extent.width), | 431 | Offset2D{.x = clear_rect.rect.offset.x + static_cast<s32>(clear_rect.rect.extent.width), |
| @@ -707,6 +710,7 @@ void RasterizerVulkan::TiledCacheBarrier() { | |||
| 707 | } | 710 | } |
| 708 | 711 | ||
| 709 | void RasterizerVulkan::FlushCommands() { | 712 | void RasterizerVulkan::FlushCommands() { |
| 713 | std::scoped_lock lock{LockCaches()}; | ||
| 710 | if (draw_counter == 0) { | 714 | if (draw_counter == 0) { |
| 711 | return; | 715 | return; |
| 712 | } | 716 | } |
| @@ -804,6 +808,7 @@ void RasterizerVulkan::FlushWork() { | |||
| 804 | if ((++draw_counter & 7) != 7) { | 808 | if ((++draw_counter & 7) != 7) { |
| 805 | return; | 809 | return; |
| 806 | } | 810 | } |
| 811 | std::scoped_lock lock{LockCaches()}; | ||
| 807 | if (draw_counter < DRAWS_TO_DISPATCH) { | 812 | if (draw_counter < DRAWS_TO_DISPATCH) { |
| 808 | // Send recorded tasks to the worker thread | 813 | // Send recorded tasks to the worker thread |
| 809 | scheduler.DispatchWork(); | 814 | scheduler.DispatchWork(); |
| @@ -974,6 +979,19 @@ void RasterizerVulkan::UpdateScissorsState(Tegra::Engines::Maxwell3D::Regs& regs | |||
| 974 | if (!state_tracker.TouchScissors()) { | 979 | if (!state_tracker.TouchScissors()) { |
| 975 | return; | 980 | return; |
| 976 | } | 981 | } |
| 982 | if (!regs.viewport_scale_offset_enabled) { | ||
| 983 | const auto x = static_cast<float>(regs.surface_clip.x); | ||
| 984 | const auto y = static_cast<float>(regs.surface_clip.y); | ||
| 985 | const auto width = static_cast<float>(regs.surface_clip.width); | ||
| 986 | const auto height = static_cast<float>(regs.surface_clip.height); | ||
| 987 | VkRect2D scissor; | ||
| 988 | scissor.offset.x = static_cast<u32>(x); | ||
| 989 | scissor.offset.y = static_cast<u32>(y); | ||
| 990 | scissor.extent.width = static_cast<u32>(width != 0.0f ? width : 1.0f); | ||
| 991 | scissor.extent.height = static_cast<u32>(height != 0.0f ? height : 1.0f); | ||
| 992 | scheduler.Record([scissor](vk::CommandBuffer cmdbuf) { cmdbuf.SetScissor(0, scissor); }); | ||
| 993 | return; | ||
| 994 | } | ||
| 977 | u32 up_scale = 1; | 995 | u32 up_scale = 1; |
| 978 | u32 down_shift = 0; | 996 | u32 down_shift = 0; |
| 979 | if (texture_cache.IsRescaling()) { | 997 | if (texture_cache.IsRescaling()) { |
| @@ -1485,7 +1503,7 @@ void RasterizerVulkan::UpdateVertexInput(Tegra::Engines::Maxwell3D::Regs& regs) | |||
| 1485 | void RasterizerVulkan::InitializeChannel(Tegra::Control::ChannelState& channel) { | 1503 | void RasterizerVulkan::InitializeChannel(Tegra::Control::ChannelState& channel) { |
| 1486 | CreateChannel(channel); | 1504 | CreateChannel(channel); |
| 1487 | { | 1505 | { |
| 1488 | std::scoped_lock lock{buffer_cache.mutex, texture_cache.mutex}; | 1506 | std::scoped_lock lock{LockCaches()}; |
| 1489 | texture_cache.CreateChannel(channel); | 1507 | texture_cache.CreateChannel(channel); |
| 1490 | buffer_cache.CreateChannel(channel); | 1508 | buffer_cache.CreateChannel(channel); |
| 1491 | } | 1509 | } |
| @@ -1498,7 +1516,7 @@ void RasterizerVulkan::BindChannel(Tegra::Control::ChannelState& channel) { | |||
| 1498 | const s32 channel_id = channel.bind_id; | 1516 | const s32 channel_id = channel.bind_id; |
| 1499 | BindToChannel(channel_id); | 1517 | BindToChannel(channel_id); |
| 1500 | { | 1518 | { |
| 1501 | std::scoped_lock lock{buffer_cache.mutex, texture_cache.mutex}; | 1519 | std::scoped_lock lock{LockCaches()}; |
| 1502 | texture_cache.BindToChannel(channel_id); | 1520 | texture_cache.BindToChannel(channel_id); |
| 1503 | buffer_cache.BindToChannel(channel_id); | 1521 | buffer_cache.BindToChannel(channel_id); |
| 1504 | } | 1522 | } |
| @@ -1511,7 +1529,7 @@ void RasterizerVulkan::BindChannel(Tegra::Control::ChannelState& channel) { | |||
| 1511 | void RasterizerVulkan::ReleaseChannel(s32 channel_id) { | 1529 | void RasterizerVulkan::ReleaseChannel(s32 channel_id) { |
| 1512 | EraseChannel(channel_id); | 1530 | EraseChannel(channel_id); |
| 1513 | { | 1531 | { |
| 1514 | std::scoped_lock lock{buffer_cache.mutex, texture_cache.mutex}; | 1532 | std::scoped_lock lock{LockCaches()}; |
| 1515 | texture_cache.EraseChannel(channel_id); | 1533 | texture_cache.EraseChannel(channel_id); |
| 1516 | buffer_cache.EraseChannel(channel_id); | 1534 | buffer_cache.EraseChannel(channel_id); |
| 1517 | } | 1535 | } |
diff --git a/src/video_core/renderer_vulkan/vk_rasterizer.h b/src/video_core/renderer_vulkan/vk_rasterizer.h index ad069556c..ce3dfbaab 100644 --- a/src/video_core/renderer_vulkan/vk_rasterizer.h +++ b/src/video_core/renderer_vulkan/vk_rasterizer.h | |||
| @@ -133,6 +133,10 @@ public: | |||
| 133 | 133 | ||
| 134 | void ReleaseChannel(s32 channel_id) override; | 134 | void ReleaseChannel(s32 channel_id) override; |
| 135 | 135 | ||
| 136 | std::scoped_lock<std::recursive_mutex, std::recursive_mutex> LockCaches() { | ||
| 137 | return std::scoped_lock{buffer_cache.mutex, texture_cache.mutex}; | ||
| 138 | } | ||
| 139 | |||
| 136 | private: | 140 | private: |
| 137 | static constexpr size_t MAX_TEXTURES = 192; | 141 | static constexpr size_t MAX_TEXTURES = 192; |
| 138 | static constexpr size_t MAX_IMAGES = 48; | 142 | static constexpr size_t MAX_IMAGES = 48; |
diff --git a/src/video_core/renderer_vulkan/vk_render_pass_cache.cpp b/src/video_core/renderer_vulkan/vk_render_pass_cache.cpp index ae9f1de64..7746a88d3 100644 --- a/src/video_core/renderer_vulkan/vk_render_pass_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_render_pass_cache.cpp | |||
| @@ -19,7 +19,7 @@ VkAttachmentDescription AttachmentDescription(const Device& device, PixelFormat | |||
| 19 | VkSampleCountFlagBits samples) { | 19 | VkSampleCountFlagBits samples) { |
| 20 | using MaxwellToVK::SurfaceFormat; | 20 | using MaxwellToVK::SurfaceFormat; |
| 21 | return { | 21 | return { |
| 22 | .flags = VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT, | 22 | .flags = {}, |
| 23 | .format = SurfaceFormat(device, FormatType::Optimal, true, format).format, | 23 | .format = SurfaceFormat(device, FormatType::Optimal, true, format).format, |
| 24 | .samples = samples, | 24 | .samples = samples, |
| 25 | .loadOp = VK_ATTACHMENT_LOAD_OP_LOAD, | 25 | .loadOp = VK_ATTACHMENT_LOAD_OP_LOAD, |
diff --git a/src/video_core/renderer_vulkan/vk_staging_buffer_pool.cpp b/src/video_core/renderer_vulkan/vk_staging_buffer_pool.cpp index ce92f66ab..b278614e6 100644 --- a/src/video_core/renderer_vulkan/vk_staging_buffer_pool.cpp +++ b/src/video_core/renderer_vulkan/vk_staging_buffer_pool.cpp | |||
| @@ -24,25 +24,38 @@ using namespace Common::Literals; | |||
| 24 | 24 | ||
| 25 | // Maximum potential alignment of a Vulkan buffer | 25 | // Maximum potential alignment of a Vulkan buffer |
| 26 | constexpr VkDeviceSize MAX_ALIGNMENT = 256; | 26 | constexpr VkDeviceSize MAX_ALIGNMENT = 256; |
| 27 | // Maximum size to put elements in the stream buffer | ||
| 28 | constexpr VkDeviceSize MAX_STREAM_BUFFER_REQUEST_SIZE = 8_MiB; | ||
| 29 | // Stream buffer size in bytes | 27 | // Stream buffer size in bytes |
| 30 | constexpr VkDeviceSize STREAM_BUFFER_SIZE = 128_MiB; | 28 | constexpr VkDeviceSize MAX_STREAM_BUFFER_SIZE = 128_MiB; |
| 31 | constexpr VkDeviceSize REGION_SIZE = STREAM_BUFFER_SIZE / StagingBufferPool::NUM_SYNCS; | ||
| 32 | 29 | ||
| 33 | size_t Region(size_t iterator) noexcept { | 30 | size_t GetStreamBufferSize(const Device& device) { |
| 34 | return iterator / REGION_SIZE; | 31 | VkDeviceSize size{0}; |
| 32 | if (device.HasDebuggingToolAttached()) { | ||
| 33 | ForEachDeviceLocalHostVisibleHeap(device, [&size](size_t index, VkMemoryHeap& heap) { | ||
| 34 | size = std::max(size, heap.size); | ||
| 35 | }); | ||
| 36 | // If rebar is not supported, cut the max heap size to 40%. This will allow 2 captures to be | ||
| 37 | // loaded at the same time in RenderDoc. If rebar is supported, this shouldn't be an issue | ||
| 38 | // as the heap will be much larger. | ||
| 39 | if (size <= 256_MiB) { | ||
| 40 | size = size * 40 / 100; | ||
| 41 | } | ||
| 42 | } else { | ||
| 43 | size = MAX_STREAM_BUFFER_SIZE; | ||
| 44 | } | ||
| 45 | return std::min(Common::AlignUp(size, MAX_ALIGNMENT), MAX_STREAM_BUFFER_SIZE); | ||
| 35 | } | 46 | } |
| 36 | } // Anonymous namespace | 47 | } // Anonymous namespace |
| 37 | 48 | ||
| 38 | StagingBufferPool::StagingBufferPool(const Device& device_, MemoryAllocator& memory_allocator_, | 49 | StagingBufferPool::StagingBufferPool(const Device& device_, MemoryAllocator& memory_allocator_, |
| 39 | Scheduler& scheduler_) | 50 | Scheduler& scheduler_) |
| 40 | : device{device_}, memory_allocator{memory_allocator_}, scheduler{scheduler_} { | 51 | : device{device_}, memory_allocator{memory_allocator_}, scheduler{scheduler_}, |
| 52 | stream_buffer_size{GetStreamBufferSize(device)}, region_size{stream_buffer_size / | ||
| 53 | StagingBufferPool::NUM_SYNCS} { | ||
| 41 | VkBufferCreateInfo stream_ci = { | 54 | VkBufferCreateInfo stream_ci = { |
| 42 | .sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO, | 55 | .sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO, |
| 43 | .pNext = nullptr, | 56 | .pNext = nullptr, |
| 44 | .flags = 0, | 57 | .flags = 0, |
| 45 | .size = STREAM_BUFFER_SIZE, | 58 | .size = stream_buffer_size, |
| 46 | .usage = VK_BUFFER_USAGE_TRANSFER_SRC_BIT | VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT | | 59 | .usage = VK_BUFFER_USAGE_TRANSFER_SRC_BIT | VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT | |
| 47 | VK_BUFFER_USAGE_INDEX_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_BUFFER_BIT, | 60 | VK_BUFFER_USAGE_INDEX_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_BUFFER_BIT, |
| 48 | .sharingMode = VK_SHARING_MODE_EXCLUSIVE, | 61 | .sharingMode = VK_SHARING_MODE_EXCLUSIVE, |
| @@ -63,7 +76,7 @@ StagingBufferPool::StagingBufferPool(const Device& device_, MemoryAllocator& mem | |||
| 63 | StagingBufferPool::~StagingBufferPool() = default; | 76 | StagingBufferPool::~StagingBufferPool() = default; |
| 64 | 77 | ||
| 65 | StagingBufferRef StagingBufferPool::Request(size_t size, MemoryUsage usage, bool deferred) { | 78 | StagingBufferRef StagingBufferPool::Request(size_t size, MemoryUsage usage, bool deferred) { |
| 66 | if (!deferred && usage == MemoryUsage::Upload && size <= MAX_STREAM_BUFFER_REQUEST_SIZE) { | 79 | if (!deferred && usage == MemoryUsage::Upload && size <= region_size) { |
| 67 | return GetStreamBuffer(size); | 80 | return GetStreamBuffer(size); |
| 68 | } | 81 | } |
| 69 | return GetStagingBuffer(size, usage, deferred); | 82 | return GetStagingBuffer(size, usage, deferred); |
| @@ -101,7 +114,7 @@ StagingBufferRef StagingBufferPool::GetStreamBuffer(size_t size) { | |||
| 101 | used_iterator = iterator; | 114 | used_iterator = iterator; |
| 102 | free_iterator = std::max(free_iterator, iterator + size); | 115 | free_iterator = std::max(free_iterator, iterator + size); |
| 103 | 116 | ||
| 104 | if (iterator + size >= STREAM_BUFFER_SIZE) { | 117 | if (iterator + size >= stream_buffer_size) { |
| 105 | std::fill(sync_ticks.begin() + Region(used_iterator), sync_ticks.begin() + NUM_SYNCS, | 118 | std::fill(sync_ticks.begin() + Region(used_iterator), sync_ticks.begin() + NUM_SYNCS, |
| 106 | current_tick); | 119 | current_tick); |
| 107 | used_iterator = 0; | 120 | used_iterator = 0; |
diff --git a/src/video_core/renderer_vulkan/vk_staging_buffer_pool.h b/src/video_core/renderer_vulkan/vk_staging_buffer_pool.h index 5f69f08b1..d3deb9072 100644 --- a/src/video_core/renderer_vulkan/vk_staging_buffer_pool.h +++ b/src/video_core/renderer_vulkan/vk_staging_buffer_pool.h | |||
| @@ -90,6 +90,9 @@ private: | |||
| 90 | void ReleaseCache(MemoryUsage usage); | 90 | void ReleaseCache(MemoryUsage usage); |
| 91 | 91 | ||
| 92 | void ReleaseLevel(StagingBuffersCache& cache, size_t log2); | 92 | void ReleaseLevel(StagingBuffersCache& cache, size_t log2); |
| 93 | size_t Region(size_t iter) const noexcept { | ||
| 94 | return iter / region_size; | ||
| 95 | } | ||
| 93 | 96 | ||
| 94 | const Device& device; | 97 | const Device& device; |
| 95 | MemoryAllocator& memory_allocator; | 98 | MemoryAllocator& memory_allocator; |
| @@ -97,6 +100,8 @@ private: | |||
| 97 | 100 | ||
| 98 | vk::Buffer stream_buffer; | 101 | vk::Buffer stream_buffer; |
| 99 | std::span<u8> stream_pointer; | 102 | std::span<u8> stream_pointer; |
| 103 | VkDeviceSize stream_buffer_size; | ||
| 104 | VkDeviceSize region_size; | ||
| 100 | 105 | ||
| 101 | size_t iterator = 0; | 106 | size_t iterator = 0; |
| 102 | size_t used_iterator = 0; | 107 | size_t used_iterator = 0; |
diff --git a/src/video_core/renderer_vulkan/vk_state_tracker.cpp b/src/video_core/renderer_vulkan/vk_state_tracker.cpp index d56558a83..daaea2979 100644 --- a/src/video_core/renderer_vulkan/vk_state_tracker.cpp +++ b/src/video_core/renderer_vulkan/vk_state_tracker.cpp | |||
| @@ -190,7 +190,7 @@ void SetupDirtySpecialOps(Tables& tables) { | |||
| 190 | void SetupDirtyViewportSwizzles(Tables& tables) { | 190 | void SetupDirtyViewportSwizzles(Tables& tables) { |
| 191 | static constexpr size_t swizzle_offset = 6; | 191 | static constexpr size_t swizzle_offset = 6; |
| 192 | for (size_t index = 0; index < Regs::NumViewports; ++index) { | 192 | for (size_t index = 0; index < Regs::NumViewports; ++index) { |
| 193 | tables[0][OFF(viewport_transform) + index * NUM(viewport_transform[0]) + swizzle_offset] = | 193 | tables[1][OFF(viewport_transform) + index * NUM(viewport_transform[0]) + swizzle_offset] = |
| 194 | ViewportSwizzles; | 194 | ViewportSwizzles; |
| 195 | } | 195 | } |
| 196 | } | 196 | } |
diff --git a/src/video_core/renderer_vulkan/vk_texture_cache.cpp b/src/video_core/renderer_vulkan/vk_texture_cache.cpp index 71fdec809..de34f6d49 100644 --- a/src/video_core/renderer_vulkan/vk_texture_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_texture_cache.cpp | |||
| @@ -238,6 +238,7 @@ constexpr VkBorderColor ConvertBorderColor(const std::array<float, 4>& color) { | |||
| 238 | return any_r ? VK_IMAGE_ASPECT_STENCIL_BIT : VK_IMAGE_ASPECT_DEPTH_BIT; | 238 | return any_r ? VK_IMAGE_ASPECT_STENCIL_BIT : VK_IMAGE_ASPECT_DEPTH_BIT; |
| 239 | case PixelFormat::D16_UNORM: | 239 | case PixelFormat::D16_UNORM: |
| 240 | case PixelFormat::D32_FLOAT: | 240 | case PixelFormat::D32_FLOAT: |
| 241 | case PixelFormat::X8_D24_UNORM: | ||
| 241 | return VK_IMAGE_ASPECT_DEPTH_BIT; | 242 | return VK_IMAGE_ASPECT_DEPTH_BIT; |
| 242 | case PixelFormat::S8_UINT: | 243 | case PixelFormat::S8_UINT: |
| 243 | return VK_IMAGE_ASPECT_STENCIL_BIT; | 244 | return VK_IMAGE_ASPECT_STENCIL_BIT; |
| @@ -1193,6 +1194,11 @@ void TextureCacheRuntime::ConvertImage(Framebuffer* dst, ImageView& dst_view, Im | |||
| 1193 | return blit_image_helper.ConvertD16ToR16(dst, src_view); | 1194 | return blit_image_helper.ConvertD16ToR16(dst, src_view); |
| 1194 | } | 1195 | } |
| 1195 | break; | 1196 | break; |
| 1197 | case PixelFormat::A8B8G8R8_SRGB: | ||
| 1198 | if (src_view.format == PixelFormat::D32_FLOAT) { | ||
| 1199 | return blit_image_helper.ConvertD32FToABGR8(dst, src_view); | ||
| 1200 | } | ||
| 1201 | break; | ||
| 1196 | case PixelFormat::A8B8G8R8_UNORM: | 1202 | case PixelFormat::A8B8G8R8_UNORM: |
| 1197 | if (src_view.format == PixelFormat::S8_UINT_D24_UNORM) { | 1203 | if (src_view.format == PixelFormat::S8_UINT_D24_UNORM) { |
| 1198 | return blit_image_helper.ConvertD24S8ToABGR8(dst, src_view); | 1204 | return blit_image_helper.ConvertD24S8ToABGR8(dst, src_view); |
| @@ -1200,6 +1206,19 @@ void TextureCacheRuntime::ConvertImage(Framebuffer* dst, ImageView& dst_view, Im | |||
| 1200 | if (src_view.format == PixelFormat::D24_UNORM_S8_UINT) { | 1206 | if (src_view.format == PixelFormat::D24_UNORM_S8_UINT) { |
| 1201 | return blit_image_helper.ConvertS8D24ToABGR8(dst, src_view); | 1207 | return blit_image_helper.ConvertS8D24ToABGR8(dst, src_view); |
| 1202 | } | 1208 | } |
| 1209 | if (src_view.format == PixelFormat::D32_FLOAT) { | ||
| 1210 | return blit_image_helper.ConvertD32FToABGR8(dst, src_view); | ||
| 1211 | } | ||
| 1212 | break; | ||
| 1213 | case PixelFormat::B8G8R8A8_SRGB: | ||
| 1214 | if (src_view.format == PixelFormat::D32_FLOAT) { | ||
| 1215 | return blit_image_helper.ConvertD32FToABGR8(dst, src_view); | ||
| 1216 | } | ||
| 1217 | break; | ||
| 1218 | case PixelFormat::B8G8R8A8_UNORM: | ||
| 1219 | if (src_view.format == PixelFormat::D32_FLOAT) { | ||
| 1220 | return blit_image_helper.ConvertD32FToABGR8(dst, src_view); | ||
| 1221 | } | ||
| 1203 | break; | 1222 | break; |
| 1204 | case PixelFormat::R32_FLOAT: | 1223 | case PixelFormat::R32_FLOAT: |
| 1205 | if (src_view.format == PixelFormat::D32_FLOAT) { | 1224 | if (src_view.format == PixelFormat::D32_FLOAT) { |
| @@ -1218,6 +1237,12 @@ void TextureCacheRuntime::ConvertImage(Framebuffer* dst, ImageView& dst_view, Im | |||
| 1218 | } | 1237 | } |
| 1219 | break; | 1238 | break; |
| 1220 | case PixelFormat::D32_FLOAT: | 1239 | case PixelFormat::D32_FLOAT: |
| 1240 | if (src_view.format == PixelFormat::A8B8G8R8_UNORM || | ||
| 1241 | src_view.format == PixelFormat::B8G8R8A8_UNORM || | ||
| 1242 | src_view.format == PixelFormat::A8B8G8R8_SRGB || | ||
| 1243 | src_view.format == PixelFormat::B8G8R8A8_SRGB) { | ||
| 1244 | return blit_image_helper.ConvertABGR8ToD32F(dst, src_view); | ||
| 1245 | } | ||
| 1221 | if (src_view.format == PixelFormat::R32_FLOAT) { | 1246 | if (src_view.format == PixelFormat::R32_FLOAT) { |
| 1222 | return blit_image_helper.ConvertR32ToD32(dst, src_view); | 1247 | return blit_image_helper.ConvertR32ToD32(dst, src_view); |
| 1223 | } | 1248 | } |
| @@ -1526,15 +1551,15 @@ bool Image::IsRescaled() const noexcept { | |||
| 1526 | } | 1551 | } |
| 1527 | 1552 | ||
| 1528 | bool Image::ScaleUp(bool ignore) { | 1553 | bool Image::ScaleUp(bool ignore) { |
| 1554 | const auto& resolution = runtime->resolution; | ||
| 1555 | if (!resolution.active) { | ||
| 1556 | return false; | ||
| 1557 | } | ||
| 1529 | if (True(flags & ImageFlagBits::Rescaled)) { | 1558 | if (True(flags & ImageFlagBits::Rescaled)) { |
| 1530 | return false; | 1559 | return false; |
| 1531 | } | 1560 | } |
| 1532 | ASSERT(info.type != ImageType::Linear); | 1561 | ASSERT(info.type != ImageType::Linear); |
| 1533 | flags |= ImageFlagBits::Rescaled; | 1562 | flags |= ImageFlagBits::Rescaled; |
| 1534 | const auto& resolution = runtime->resolution; | ||
| 1535 | if (!resolution.active) { | ||
| 1536 | return false; | ||
| 1537 | } | ||
| 1538 | has_scaled = true; | 1563 | has_scaled = true; |
| 1539 | if (!scaled_image) { | 1564 | if (!scaled_image) { |
| 1540 | const bool is_2d = info.type == ImageType::e2D; | 1565 | const bool is_2d = info.type == ImageType::e2D; |
| @@ -1563,15 +1588,15 @@ bool Image::ScaleUp(bool ignore) { | |||
| 1563 | } | 1588 | } |
| 1564 | 1589 | ||
| 1565 | bool Image::ScaleDown(bool ignore) { | 1590 | bool Image::ScaleDown(bool ignore) { |
| 1591 | const auto& resolution = runtime->resolution; | ||
| 1592 | if (!resolution.active) { | ||
| 1593 | return false; | ||
| 1594 | } | ||
| 1566 | if (False(flags & ImageFlagBits::Rescaled)) { | 1595 | if (False(flags & ImageFlagBits::Rescaled)) { |
| 1567 | return false; | 1596 | return false; |
| 1568 | } | 1597 | } |
| 1569 | ASSERT(info.type != ImageType::Linear); | 1598 | ASSERT(info.type != ImageType::Linear); |
| 1570 | flags &= ~ImageFlagBits::Rescaled; | 1599 | flags &= ~ImageFlagBits::Rescaled; |
| 1571 | const auto& resolution = runtime->resolution; | ||
| 1572 | if (!resolution.active) { | ||
| 1573 | return false; | ||
| 1574 | } | ||
| 1575 | current_image = *original_image; | 1600 | current_image = *original_image; |
| 1576 | if (ignore) { | 1601 | if (ignore) { |
| 1577 | return true; | 1602 | return true; |
| @@ -2009,4 +2034,32 @@ void TextureCacheRuntime::AccelerateImageUpload( | |||
| 2009 | ASSERT(false); | 2034 | ASSERT(false); |
| 2010 | } | 2035 | } |
| 2011 | 2036 | ||
| 2037 | void TextureCacheRuntime::TransitionImageLayout(Image& image) { | ||
| 2038 | if (!image.ExchangeInitialization()) { | ||
| 2039 | VkImageMemoryBarrier barrier{ | ||
| 2040 | .sType = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER, | ||
| 2041 | .pNext = nullptr, | ||
| 2042 | .srcAccessMask = VK_ACCESS_NONE, | ||
| 2043 | .dstAccessMask = VK_ACCESS_MEMORY_READ_BIT | VK_ACCESS_MEMORY_WRITE_BIT, | ||
| 2044 | .oldLayout = VK_IMAGE_LAYOUT_UNDEFINED, | ||
| 2045 | .newLayout = VK_IMAGE_LAYOUT_GENERAL, | ||
| 2046 | .srcQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, | ||
| 2047 | .dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, | ||
| 2048 | .image = image.Handle(), | ||
| 2049 | .subresourceRange{ | ||
| 2050 | .aspectMask = image.AspectMask(), | ||
| 2051 | .baseMipLevel = 0, | ||
| 2052 | .levelCount = VK_REMAINING_MIP_LEVELS, | ||
| 2053 | .baseArrayLayer = 0, | ||
| 2054 | .layerCount = VK_REMAINING_ARRAY_LAYERS, | ||
| 2055 | }, | ||
| 2056 | }; | ||
| 2057 | scheduler.RequestOutsideRenderPassOperationContext(); | ||
| 2058 | scheduler.Record([barrier](vk::CommandBuffer cmdbuf) { | ||
| 2059 | cmdbuf.PipelineBarrier(VK_PIPELINE_STAGE_ALL_COMMANDS_BIT, | ||
| 2060 | VK_PIPELINE_STAGE_ALL_COMMANDS_BIT, 0, barrier); | ||
| 2061 | }); | ||
| 2062 | } | ||
| 2063 | } | ||
| 2064 | |||
| 2012 | } // namespace Vulkan | 2065 | } // namespace Vulkan |
diff --git a/src/video_core/renderer_vulkan/vk_texture_cache.h b/src/video_core/renderer_vulkan/vk_texture_cache.h index d6c5a15cc..7a0807709 100644 --- a/src/video_core/renderer_vulkan/vk_texture_cache.h +++ b/src/video_core/renderer_vulkan/vk_texture_cache.h | |||
| @@ -92,6 +92,8 @@ public: | |||
| 92 | 92 | ||
| 93 | void InsertUploadMemoryBarrier() {} | 93 | void InsertUploadMemoryBarrier() {} |
| 94 | 94 | ||
| 95 | void TransitionImageLayout(Image& image); | ||
| 96 | |||
| 95 | bool HasBrokenTextureViewFormats() const noexcept { | 97 | bool HasBrokenTextureViewFormats() const noexcept { |
| 96 | // No known Vulkan driver has broken image views | 98 | // No known Vulkan driver has broken image views |
| 97 | return false; | 99 | return false; |
diff --git a/src/video_core/surface.cpp b/src/video_core/surface.cpp index e16cd5e73..5b3c7aa5a 100644 --- a/src/video_core/surface.cpp +++ b/src/video_core/surface.cpp | |||
| @@ -85,6 +85,8 @@ PixelFormat PixelFormatFromDepthFormat(Tegra::DepthFormat format) { | |||
| 85 | return PixelFormat::S8_UINT; | 85 | return PixelFormat::S8_UINT; |
| 86 | case Tegra::DepthFormat::Z32_FLOAT_X24S8_UINT: | 86 | case Tegra::DepthFormat::Z32_FLOAT_X24S8_UINT: |
| 87 | return PixelFormat::D32_FLOAT_S8_UINT; | 87 | return PixelFormat::D32_FLOAT_S8_UINT; |
| 88 | case Tegra::DepthFormat::X8Z24_UNORM: | ||
| 89 | return PixelFormat::X8_D24_UNORM; | ||
| 88 | default: | 90 | default: |
| 89 | UNIMPLEMENTED_MSG("Unimplemented format={}", format); | 91 | UNIMPLEMENTED_MSG("Unimplemented format={}", format); |
| 90 | return PixelFormat::S8_UINT_D24_UNORM; | 92 | return PixelFormat::S8_UINT_D24_UNORM; |
| @@ -202,6 +204,7 @@ PixelFormat PixelFormatFromRenderTargetFormat(Tegra::RenderTargetFormat format) | |||
| 202 | PixelFormat PixelFormatFromGPUPixelFormat(Service::android::PixelFormat format) { | 204 | PixelFormat PixelFormatFromGPUPixelFormat(Service::android::PixelFormat format) { |
| 203 | switch (format) { | 205 | switch (format) { |
| 204 | case Service::android::PixelFormat::Rgba8888: | 206 | case Service::android::PixelFormat::Rgba8888: |
| 207 | case Service::android::PixelFormat::Rgbx8888: | ||
| 205 | return PixelFormat::A8B8G8R8_UNORM; | 208 | return PixelFormat::A8B8G8R8_UNORM; |
| 206 | case Service::android::PixelFormat::Rgb565: | 209 | case Service::android::PixelFormat::Rgb565: |
| 207 | return PixelFormat::R5G6B5_UNORM; | 210 | return PixelFormat::R5G6B5_UNORM; |
diff --git a/src/video_core/surface.h b/src/video_core/surface.h index 9b9c4d9bc..a5e8e2f62 100644 --- a/src/video_core/surface.h +++ b/src/video_core/surface.h | |||
| @@ -115,6 +115,7 @@ enum class PixelFormat { | |||
| 115 | // Depth formats | 115 | // Depth formats |
| 116 | D32_FLOAT = MaxColorFormat, | 116 | D32_FLOAT = MaxColorFormat, |
| 117 | D16_UNORM, | 117 | D16_UNORM, |
| 118 | X8_D24_UNORM, | ||
| 118 | 119 | ||
| 119 | MaxDepthFormat, | 120 | MaxDepthFormat, |
| 120 | 121 | ||
| @@ -251,6 +252,7 @@ constexpr std::array<u8, MaxPixelFormat> BLOCK_WIDTH_TABLE = {{ | |||
| 251 | 1, // E5B9G9R9_FLOAT | 252 | 1, // E5B9G9R9_FLOAT |
| 252 | 1, // D32_FLOAT | 253 | 1, // D32_FLOAT |
| 253 | 1, // D16_UNORM | 254 | 1, // D16_UNORM |
| 255 | 1, // X8_D24_UNORM | ||
| 254 | 1, // S8_UINT | 256 | 1, // S8_UINT |
| 255 | 1, // D24_UNORM_S8_UINT | 257 | 1, // D24_UNORM_S8_UINT |
| 256 | 1, // S8_UINT_D24_UNORM | 258 | 1, // S8_UINT_D24_UNORM |
| @@ -360,6 +362,7 @@ constexpr std::array<u8, MaxPixelFormat> BLOCK_HEIGHT_TABLE = {{ | |||
| 360 | 1, // E5B9G9R9_FLOAT | 362 | 1, // E5B9G9R9_FLOAT |
| 361 | 1, // D32_FLOAT | 363 | 1, // D32_FLOAT |
| 362 | 1, // D16_UNORM | 364 | 1, // D16_UNORM |
| 365 | 1, // X8_D24_UNORM | ||
| 363 | 1, // S8_UINT | 366 | 1, // S8_UINT |
| 364 | 1, // D24_UNORM_S8_UINT | 367 | 1, // D24_UNORM_S8_UINT |
| 365 | 1, // S8_UINT_D24_UNORM | 368 | 1, // S8_UINT_D24_UNORM |
| @@ -469,6 +472,7 @@ constexpr std::array<u8, MaxPixelFormat> BITS_PER_BLOCK_TABLE = {{ | |||
| 469 | 32, // E5B9G9R9_FLOAT | 472 | 32, // E5B9G9R9_FLOAT |
| 470 | 32, // D32_FLOAT | 473 | 32, // D32_FLOAT |
| 471 | 16, // D16_UNORM | 474 | 16, // D16_UNORM |
| 475 | 32, // X8_D24_UNORM | ||
| 472 | 8, // S8_UINT | 476 | 8, // S8_UINT |
| 473 | 32, // D24_UNORM_S8_UINT | 477 | 32, // D24_UNORM_S8_UINT |
| 474 | 32, // S8_UINT_D24_UNORM | 478 | 32, // S8_UINT_D24_UNORM |
diff --git a/src/video_core/texture_cache/format_lookup_table.cpp b/src/video_core/texture_cache/format_lookup_table.cpp index 56307d030..8c774f512 100644 --- a/src/video_core/texture_cache/format_lookup_table.cpp +++ b/src/video_core/texture_cache/format_lookup_table.cpp | |||
| @@ -138,10 +138,16 @@ PixelFormat PixelFormatFromTextureInfo(TextureFormat format, ComponentType red, | |||
| 138 | return PixelFormat::E5B9G9R9_FLOAT; | 138 | return PixelFormat::E5B9G9R9_FLOAT; |
| 139 | case Hash(TextureFormat::Z32, FLOAT): | 139 | case Hash(TextureFormat::Z32, FLOAT): |
| 140 | return PixelFormat::D32_FLOAT; | 140 | return PixelFormat::D32_FLOAT; |
| 141 | case Hash(TextureFormat::Z32, FLOAT, UINT, UINT, UINT, LINEAR): | ||
| 142 | return PixelFormat::D32_FLOAT; | ||
| 141 | case Hash(TextureFormat::Z16, UNORM): | 143 | case Hash(TextureFormat::Z16, UNORM): |
| 142 | return PixelFormat::D16_UNORM; | 144 | return PixelFormat::D16_UNORM; |
| 143 | case Hash(TextureFormat::Z16, UNORM, UINT, UINT, UINT, LINEAR): | 145 | case Hash(TextureFormat::Z16, UNORM, UINT, UINT, UINT, LINEAR): |
| 144 | return PixelFormat::D16_UNORM; | 146 | return PixelFormat::D16_UNORM; |
| 147 | case Hash(TextureFormat::X8Z24, UNORM): | ||
| 148 | return PixelFormat::X8_D24_UNORM; | ||
| 149 | case Hash(TextureFormat::X8Z24, UNORM, UINT, UINT, UINT, LINEAR): | ||
| 150 | return PixelFormat::X8_D24_UNORM; | ||
| 145 | case Hash(TextureFormat::Z24S8, UINT, UNORM, UNORM, UNORM, LINEAR): | 151 | case Hash(TextureFormat::Z24S8, UINT, UNORM, UNORM, UNORM, LINEAR): |
| 146 | return PixelFormat::S8_UINT_D24_UNORM; | 152 | return PixelFormat::S8_UINT_D24_UNORM; |
| 147 | case Hash(TextureFormat::Z24S8, UINT, UNORM, UINT, UINT, LINEAR): | 153 | case Hash(TextureFormat::Z24S8, UINT, UNORM, UINT, UINT, LINEAR): |
diff --git a/src/video_core/texture_cache/formatter.cpp b/src/video_core/texture_cache/formatter.cpp index 6279d8e9e..2b7e0df72 100644 --- a/src/video_core/texture_cache/formatter.cpp +++ b/src/video_core/texture_cache/formatter.cpp | |||
| @@ -10,19 +10,23 @@ | |||
| 10 | #include "video_core/texture_cache/image_info.h" | 10 | #include "video_core/texture_cache/image_info.h" |
| 11 | #include "video_core/texture_cache/image_view_base.h" | 11 | #include "video_core/texture_cache/image_view_base.h" |
| 12 | #include "video_core/texture_cache/render_targets.h" | 12 | #include "video_core/texture_cache/render_targets.h" |
| 13 | #include "video_core/texture_cache/samples_helper.h" | ||
| 13 | 14 | ||
| 14 | namespace VideoCommon { | 15 | namespace VideoCommon { |
| 15 | 16 | ||
| 16 | std::string Name(const ImageBase& image) { | 17 | std::string Name(const ImageBase& image) { |
| 17 | const GPUVAddr gpu_addr = image.gpu_addr; | 18 | const GPUVAddr gpu_addr = image.gpu_addr; |
| 18 | const ImageInfo& info = image.info; | 19 | const ImageInfo& info = image.info; |
| 19 | const u32 width = info.size.width; | 20 | u32 width = info.size.width; |
| 20 | const u32 height = info.size.height; | 21 | u32 height = info.size.height; |
| 21 | const u32 depth = info.size.depth; | 22 | const u32 depth = info.size.depth; |
| 22 | const u32 num_layers = image.info.resources.layers; | 23 | const u32 num_layers = image.info.resources.layers; |
| 23 | const u32 num_levels = image.info.resources.levels; | 24 | const u32 num_levels = image.info.resources.levels; |
| 24 | std::string resource; | 25 | std::string resource; |
| 25 | if (image.info.num_samples > 1) { | 26 | if (image.info.num_samples > 1) { |
| 27 | const auto [samples_x, samples_y] = VideoCommon::SamplesLog2(image.info.num_samples); | ||
| 28 | width >>= samples_x; | ||
| 29 | height >>= samples_y; | ||
| 26 | resource += fmt::format(":{}xMSAA", image.info.num_samples); | 30 | resource += fmt::format(":{}xMSAA", image.info.num_samples); |
| 27 | } | 31 | } |
| 28 | if (num_layers > 1) { | 32 | if (num_layers > 1) { |
diff --git a/src/video_core/texture_cache/formatter.h b/src/video_core/texture_cache/formatter.h index 9ee57a076..cabbfcb2d 100644 --- a/src/video_core/texture_cache/formatter.h +++ b/src/video_core/texture_cache/formatter.h | |||
| @@ -211,6 +211,8 @@ struct fmt::formatter<VideoCore::Surface::PixelFormat> : fmt::formatter<fmt::str | |||
| 211 | return "D32_FLOAT"; | 211 | return "D32_FLOAT"; |
| 212 | case PixelFormat::D16_UNORM: | 212 | case PixelFormat::D16_UNORM: |
| 213 | return "D16_UNORM"; | 213 | return "D16_UNORM"; |
| 214 | case PixelFormat::X8_D24_UNORM: | ||
| 215 | return "X8_D24_UNORM"; | ||
| 214 | case PixelFormat::S8_UINT: | 216 | case PixelFormat::S8_UINT: |
| 215 | return "S8_UINT"; | 217 | return "S8_UINT"; |
| 216 | case PixelFormat::D24_UNORM_S8_UINT: | 218 | case PixelFormat::D24_UNORM_S8_UINT: |
diff --git a/src/video_core/texture_cache/image_view_base.cpp b/src/video_core/texture_cache/image_view_base.cpp index 0c5f4450d..18b9250f9 100644 --- a/src/video_core/texture_cache/image_view_base.cpp +++ b/src/video_core/texture_cache/image_view_base.cpp | |||
| @@ -85,6 +85,7 @@ bool ImageViewBase::SupportsAnisotropy() const noexcept { | |||
| 85 | // Depth formats | 85 | // Depth formats |
| 86 | case PixelFormat::D32_FLOAT: | 86 | case PixelFormat::D32_FLOAT: |
| 87 | case PixelFormat::D16_UNORM: | 87 | case PixelFormat::D16_UNORM: |
| 88 | case PixelFormat::X8_D24_UNORM: | ||
| 88 | // Stencil formats | 89 | // Stencil formats |
| 89 | case PixelFormat::S8_UINT: | 90 | case PixelFormat::S8_UINT: |
| 90 | // DepthStencil formats | 91 | // DepthStencil formats |
diff --git a/src/video_core/texture_cache/samples_helper.h b/src/video_core/texture_cache/samples_helper.h index 203ac1b11..2ee2f8312 100644 --- a/src/video_core/texture_cache/samples_helper.h +++ b/src/video_core/texture_cache/samples_helper.h | |||
| @@ -24,7 +24,7 @@ namespace VideoCommon { | |||
| 24 | return {2, 2}; | 24 | return {2, 2}; |
| 25 | } | 25 | } |
| 26 | ASSERT_MSG(false, "Invalid number of samples={}", num_samples); | 26 | ASSERT_MSG(false, "Invalid number of samples={}", num_samples); |
| 27 | return {1, 1}; | 27 | return {0, 0}; |
| 28 | } | 28 | } |
| 29 | 29 | ||
| 30 | [[nodiscard]] inline int NumSamples(Tegra::Texture::MsaaMode msaa_mode) { | 30 | [[nodiscard]] inline int NumSamples(Tegra::Texture::MsaaMode msaa_mode) { |
diff --git a/src/video_core/texture_cache/texture_cache.h b/src/video_core/texture_cache/texture_cache.h index 1bdb0def5..d575c57ca 100644 --- a/src/video_core/texture_cache/texture_cache.h +++ b/src/video_core/texture_cache/texture_cache.h | |||
| @@ -1016,6 +1016,7 @@ void TextureCache<P>::RefreshContents(Image& image, ImageId image_id) { | |||
| 1016 | 1016 | ||
| 1017 | if (image.info.num_samples > 1 && !runtime.CanUploadMSAA()) { | 1017 | if (image.info.num_samples > 1 && !runtime.CanUploadMSAA()) { |
| 1018 | LOG_WARNING(HW_GPU, "MSAA image uploads are not implemented"); | 1018 | LOG_WARNING(HW_GPU, "MSAA image uploads are not implemented"); |
| 1019 | runtime.TransitionImageLayout(image); | ||
| 1019 | return; | 1020 | return; |
| 1020 | } | 1021 | } |
| 1021 | if (True(image.flags & ImageFlagBits::AsynchronousDecode)) { | 1022 | if (True(image.flags & ImageFlagBits::AsynchronousDecode)) { |
diff --git a/src/video_core/texture_cache/util.cpp b/src/video_core/texture_cache/util.cpp index 0a86ce139..15596c925 100644 --- a/src/video_core/texture_cache/util.cpp +++ b/src/video_core/texture_cache/util.cpp | |||
| @@ -68,6 +68,7 @@ struct LevelInfo { | |||
| 68 | Extent2D tile_size; | 68 | Extent2D tile_size; |
| 69 | u32 bpp_log2; | 69 | u32 bpp_log2; |
| 70 | u32 tile_width_spacing; | 70 | u32 tile_width_spacing; |
| 71 | u32 num_levels; | ||
| 71 | }; | 72 | }; |
| 72 | 73 | ||
| 73 | [[nodiscard]] constexpr u32 AdjustTileSize(u32 shift, u32 unit_factor, u32 dimension) { | 74 | [[nodiscard]] constexpr u32 AdjustTileSize(u32 shift, u32 unit_factor, u32 dimension) { |
| @@ -118,11 +119,11 @@ template <u32 GOB_EXTENT> | |||
| 118 | } | 119 | } |
| 119 | 120 | ||
| 120 | [[nodiscard]] constexpr Extent3D AdjustMipBlockSize(Extent3D num_tiles, Extent3D block_size, | 121 | [[nodiscard]] constexpr Extent3D AdjustMipBlockSize(Extent3D num_tiles, Extent3D block_size, |
| 121 | u32 level) { | 122 | u32 level, u32 num_levels) { |
| 122 | return { | 123 | return { |
| 123 | .width = AdjustMipBlockSize<GOB_SIZE_X>(num_tiles.width, block_size.width, level), | 124 | .width = AdjustMipBlockSize<GOB_SIZE_X>(num_tiles.width, block_size.width, level), |
| 124 | .height = AdjustMipBlockSize<GOB_SIZE_Y>(num_tiles.height, block_size.height, level), | 125 | .height = AdjustMipBlockSize<GOB_SIZE_Y>(num_tiles.height, block_size.height, level), |
| 125 | .depth = level == 0 | 126 | .depth = level == 0 && num_levels == 1 |
| 126 | ? block_size.depth | 127 | ? block_size.depth |
| 127 | : AdjustMipBlockSize<GOB_SIZE_Z>(num_tiles.depth, block_size.depth, level), | 128 | : AdjustMipBlockSize<GOB_SIZE_Z>(num_tiles.depth, block_size.depth, level), |
| 128 | }; | 129 | }; |
| @@ -166,7 +167,7 @@ template <u32 GOB_EXTENT> | |||
| 166 | } | 167 | } |
| 167 | 168 | ||
| 168 | [[nodiscard]] constexpr Extent3D TileShift(const LevelInfo& info, u32 level) { | 169 | [[nodiscard]] constexpr Extent3D TileShift(const LevelInfo& info, u32 level) { |
| 169 | if (level == 0) { | 170 | if (level == 0 && info.num_levels == 1) { |
| 170 | return Extent3D{ | 171 | return Extent3D{ |
| 171 | .width = info.block.width, | 172 | .width = info.block.width, |
| 172 | .height = info.block.height, | 173 | .height = info.block.height, |
| @@ -257,7 +258,7 @@ template <u32 GOB_EXTENT> | |||
| 257 | } | 258 | } |
| 258 | 259 | ||
| 259 | [[nodiscard]] constexpr LevelInfo MakeLevelInfo(PixelFormat format, Extent3D size, Extent3D block, | 260 | [[nodiscard]] constexpr LevelInfo MakeLevelInfo(PixelFormat format, Extent3D size, Extent3D block, |
| 260 | u32 tile_width_spacing) { | 261 | u32 tile_width_spacing, u32 num_levels) { |
| 261 | const u32 bytes_per_block = BytesPerBlock(format); | 262 | const u32 bytes_per_block = BytesPerBlock(format); |
| 262 | return { | 263 | return { |
| 263 | .size = | 264 | .size = |
| @@ -270,16 +271,18 @@ template <u32 GOB_EXTENT> | |||
| 270 | .tile_size = DefaultBlockSize(format), | 271 | .tile_size = DefaultBlockSize(format), |
| 271 | .bpp_log2 = BytesPerBlockLog2(bytes_per_block), | 272 | .bpp_log2 = BytesPerBlockLog2(bytes_per_block), |
| 272 | .tile_width_spacing = tile_width_spacing, | 273 | .tile_width_spacing = tile_width_spacing, |
| 274 | .num_levels = num_levels, | ||
| 273 | }; | 275 | }; |
| 274 | } | 276 | } |
| 275 | 277 | ||
| 276 | [[nodiscard]] constexpr LevelInfo MakeLevelInfo(const ImageInfo& info) { | 278 | [[nodiscard]] constexpr LevelInfo MakeLevelInfo(const ImageInfo& info) { |
| 277 | return MakeLevelInfo(info.format, info.size, info.block, info.tile_width_spacing); | 279 | return MakeLevelInfo(info.format, info.size, info.block, info.tile_width_spacing, |
| 280 | info.resources.levels); | ||
| 278 | } | 281 | } |
| 279 | 282 | ||
| 280 | [[nodiscard]] constexpr u32 CalculateLevelOffset(PixelFormat format, Extent3D size, Extent3D block, | 283 | [[nodiscard]] constexpr u32 CalculateLevelOffset(PixelFormat format, Extent3D size, Extent3D block, |
| 281 | u32 tile_width_spacing, u32 level) { | 284 | u32 tile_width_spacing, u32 level) { |
| 282 | const LevelInfo info = MakeLevelInfo(format, size, block, tile_width_spacing); | 285 | const LevelInfo info = MakeLevelInfo(format, size, block, tile_width_spacing, level); |
| 283 | u32 offset = 0; | 286 | u32 offset = 0; |
| 284 | for (u32 current_level = 0; current_level < level; ++current_level) { | 287 | for (u32 current_level = 0; current_level < level; ++current_level) { |
| 285 | offset += CalculateLevelSize(info, current_level); | 288 | offset += CalculateLevelSize(info, current_level); |
| @@ -466,7 +469,7 @@ template <u32 GOB_EXTENT> | |||
| 466 | }; | 469 | }; |
| 467 | const u32 bpp_log2 = BytesPerBlockLog2(info.format); | 470 | const u32 bpp_log2 = BytesPerBlockLog2(info.format); |
| 468 | const u32 alignment = StrideAlignment(num_tiles, info.block, bpp_log2, info.tile_width_spacing); | 471 | const u32 alignment = StrideAlignment(num_tiles, info.block, bpp_log2, info.tile_width_spacing); |
| 469 | const Extent3D mip_block = AdjustMipBlockSize(num_tiles, info.block, 0); | 472 | const Extent3D mip_block = AdjustMipBlockSize(num_tiles, info.block, 0, info.resources.levels); |
| 470 | return Extent3D{ | 473 | return Extent3D{ |
| 471 | .width = Common::AlignUpLog2(num_tiles.width, alignment), | 474 | .width = Common::AlignUpLog2(num_tiles.width, alignment), |
| 472 | .height = Common::AlignUpLog2(num_tiles.height, GOB_SIZE_Y_SHIFT + mip_block.height), | 475 | .height = Common::AlignUpLog2(num_tiles.height, GOB_SIZE_Y_SHIFT + mip_block.height), |
| @@ -533,7 +536,8 @@ void SwizzleBlockLinearImage(Tegra::MemoryManager& gpu_memory, GPUVAddr gpu_addr | |||
| 533 | UNIMPLEMENTED_IF(copy.image_extent != level_size); | 536 | UNIMPLEMENTED_IF(copy.image_extent != level_size); |
| 534 | 537 | ||
| 535 | const Extent3D num_tiles = AdjustTileSize(level_size, tile_size); | 538 | const Extent3D num_tiles = AdjustTileSize(level_size, tile_size); |
| 536 | const Extent3D block = AdjustMipBlockSize(num_tiles, level_info.block, level); | 539 | const Extent3D block = |
| 540 | AdjustMipBlockSize(num_tiles, level_info.block, level, level_info.num_levels); | ||
| 537 | 541 | ||
| 538 | size_t host_offset = copy.buffer_offset; | 542 | size_t host_offset = copy.buffer_offset; |
| 539 | 543 | ||
| @@ -698,7 +702,7 @@ u32 CalculateLevelStrideAlignment(const ImageInfo& info, u32 level) { | |||
| 698 | const Extent2D tile_size = DefaultBlockSize(info.format); | 702 | const Extent2D tile_size = DefaultBlockSize(info.format); |
| 699 | const Extent3D level_size = AdjustMipSize(info.size, level); | 703 | const Extent3D level_size = AdjustMipSize(info.size, level); |
| 700 | const Extent3D num_tiles = AdjustTileSize(level_size, tile_size); | 704 | const Extent3D num_tiles = AdjustTileSize(level_size, tile_size); |
| 701 | const Extent3D block = AdjustMipBlockSize(num_tiles, info.block, level); | 705 | const Extent3D block = AdjustMipBlockSize(num_tiles, info.block, level, info.resources.levels); |
| 702 | const u32 bpp_log2 = BytesPerBlockLog2(info.format); | 706 | const u32 bpp_log2 = BytesPerBlockLog2(info.format); |
| 703 | return StrideAlignment(num_tiles, block, bpp_log2, info.tile_width_spacing); | 707 | return StrideAlignment(num_tiles, block, bpp_log2, info.tile_width_spacing); |
| 704 | } | 708 | } |
| @@ -887,7 +891,8 @@ boost::container::small_vector<BufferImageCopy, 16> UnswizzleImage(Tegra::Memory | |||
| 887 | .image_extent = level_size, | 891 | .image_extent = level_size, |
| 888 | }; | 892 | }; |
| 889 | const Extent3D num_tiles = AdjustTileSize(level_size, tile_size); | 893 | const Extent3D num_tiles = AdjustTileSize(level_size, tile_size); |
| 890 | const Extent3D block = AdjustMipBlockSize(num_tiles, level_info.block, level); | 894 | const Extent3D block = |
| 895 | AdjustMipBlockSize(num_tiles, level_info.block, level, level_info.num_levels); | ||
| 891 | const u32 stride_alignment = StrideAlignment(num_tiles, info.block, gob, bpp_log2); | 896 | const u32 stride_alignment = StrideAlignment(num_tiles, info.block, gob, bpp_log2); |
| 892 | size_t guest_layer_offset = 0; | 897 | size_t guest_layer_offset = 0; |
| 893 | 898 | ||
| @@ -1041,7 +1046,7 @@ Extent3D MipBlockSize(const ImageInfo& info, u32 level) { | |||
| 1041 | const Extent2D tile_size = DefaultBlockSize(info.format); | 1046 | const Extent2D tile_size = DefaultBlockSize(info.format); |
| 1042 | const Extent3D level_size = AdjustMipSize(info.size, level); | 1047 | const Extent3D level_size = AdjustMipSize(info.size, level); |
| 1043 | const Extent3D num_tiles = AdjustTileSize(level_size, tile_size); | 1048 | const Extent3D num_tiles = AdjustTileSize(level_size, tile_size); |
| 1044 | return AdjustMipBlockSize(num_tiles, level_info.block, level); | 1049 | return AdjustMipBlockSize(num_tiles, level_info.block, level, level_info.num_levels); |
| 1045 | } | 1050 | } |
| 1046 | 1051 | ||
| 1047 | boost::container::small_vector<SwizzleParameters, 16> FullUploadSwizzles(const ImageInfo& info) { | 1052 | boost::container::small_vector<SwizzleParameters, 16> FullUploadSwizzles(const ImageInfo& info) { |
| @@ -1063,7 +1068,8 @@ boost::container::small_vector<SwizzleParameters, 16> FullUploadSwizzles(const I | |||
| 1063 | for (s32 level = 0; level < num_levels; ++level) { | 1068 | for (s32 level = 0; level < num_levels; ++level) { |
| 1064 | const Extent3D level_size = AdjustMipSize(size, level); | 1069 | const Extent3D level_size = AdjustMipSize(size, level); |
| 1065 | const Extent3D num_tiles = AdjustTileSize(level_size, tile_size); | 1070 | const Extent3D num_tiles = AdjustTileSize(level_size, tile_size); |
| 1066 | const Extent3D block = AdjustMipBlockSize(num_tiles, level_info.block, level); | 1071 | const Extent3D block = |
| 1072 | AdjustMipBlockSize(num_tiles, level_info.block, level, level_info.num_levels); | ||
| 1067 | params[level] = SwizzleParameters{ | 1073 | params[level] = SwizzleParameters{ |
| 1068 | .num_tiles = num_tiles, | 1074 | .num_tiles = num_tiles, |
| 1069 | .block = block, | 1075 | .block = block, |
| @@ -1292,11 +1298,11 @@ u32 MapSizeBytes(const ImageBase& image) { | |||
| 1292 | } | 1298 | } |
| 1293 | } | 1299 | } |
| 1294 | 1300 | ||
| 1295 | static_assert(CalculateLevelSize(LevelInfo{{1920, 1080, 1}, {0, 2, 0}, {1, 1}, 2, 0}, 0) == | 1301 | static_assert(CalculateLevelSize(LevelInfo{{1920, 1080, 1}, {0, 2, 0}, {1, 1}, 2, 0, 1}, 0) == |
| 1296 | 0x7f8000); | 1302 | 0x7f8000); |
| 1297 | static_assert(CalculateLevelSize(LevelInfo{{32, 32, 1}, {0, 0, 4}, {1, 1}, 4, 0}, 0) == 0x40000); | 1303 | static_assert(CalculateLevelSize(LevelInfo{{32, 32, 1}, {0, 0, 4}, {1, 1}, 4, 0, 1}, 0) == 0x40000); |
| 1298 | 1304 | ||
| 1299 | static_assert(CalculateLevelSize(LevelInfo{{128, 8, 1}, {0, 4, 0}, {1, 1}, 4, 0}, 0) == 0x40000); | 1305 | static_assert(CalculateLevelSize(LevelInfo{{128, 8, 1}, {0, 4, 0}, {1, 1}, 4, 0, 1}, 0) == 0x40000); |
| 1300 | 1306 | ||
| 1301 | static_assert(CalculateLevelOffset(PixelFormat::R8_SINT, {1920, 1080, 1}, {0, 2, 0}, 0, 7) == | 1307 | static_assert(CalculateLevelOffset(PixelFormat::R8_SINT, {1920, 1080, 1}, {0, 2, 0}, 0, 7) == |
| 1302 | 0x2afc00); | 1308 | 0x2afc00); |
diff --git a/src/video_core/vulkan_common/vulkan_device.cpp b/src/video_core/vulkan_common/vulkan_device.cpp index 3960b135a..e518756d2 100644 --- a/src/video_core/vulkan_common/vulkan_device.cpp +++ b/src/video_core/vulkan_common/vulkan_device.cpp | |||
| @@ -83,12 +83,6 @@ constexpr std::array VK_FORMAT_A4B4G4R4_UNORM_PACK16{ | |||
| 83 | 83 | ||
| 84 | } // namespace Alternatives | 84 | } // namespace Alternatives |
| 85 | 85 | ||
| 86 | enum class NvidiaArchitecture { | ||
| 87 | AmpereOrNewer, | ||
| 88 | Turing, | ||
| 89 | VoltaOrOlder, | ||
| 90 | }; | ||
| 91 | |||
| 92 | template <typename T> | 86 | template <typename T> |
| 93 | void SetNext(void**& next, T& data) { | 87 | void SetNext(void**& next, T& data) { |
| 94 | *next = &data; | 88 | *next = &data; |
| @@ -200,6 +194,7 @@ std::unordered_map<VkFormat, VkFormatProperties> GetFormatProperties(vk::Physica | |||
| 200 | VK_FORMAT_BC7_UNORM_BLOCK, | 194 | VK_FORMAT_BC7_UNORM_BLOCK, |
| 201 | VK_FORMAT_D16_UNORM, | 195 | VK_FORMAT_D16_UNORM, |
| 202 | VK_FORMAT_D16_UNORM_S8_UINT, | 196 | VK_FORMAT_D16_UNORM_S8_UINT, |
| 197 | VK_FORMAT_X8_D24_UNORM_PACK32, | ||
| 203 | VK_FORMAT_D24_UNORM_S8_UINT, | 198 | VK_FORMAT_D24_UNORM_S8_UINT, |
| 204 | VK_FORMAT_D32_SFLOAT, | 199 | VK_FORMAT_D32_SFLOAT, |
| 205 | VK_FORMAT_D32_SFLOAT_S8_UINT, | 200 | VK_FORMAT_D32_SFLOAT_S8_UINT, |
| @@ -321,13 +316,38 @@ NvidiaArchitecture GetNvidiaArchitecture(vk::PhysicalDevice physical, | |||
| 321 | physical.GetProperties2(physical_properties); | 316 | physical.GetProperties2(physical_properties); |
| 322 | if (shading_rate_props.primitiveFragmentShadingRateWithMultipleViewports) { | 317 | if (shading_rate_props.primitiveFragmentShadingRateWithMultipleViewports) { |
| 323 | // Only Ampere and newer support this feature | 318 | // Only Ampere and newer support this feature |
| 324 | return NvidiaArchitecture::AmpereOrNewer; | 319 | // TODO: Find a way to differentiate Ampere and Ada |
| 320 | return NvidiaArchitecture::Arch_AmpereOrNewer; | ||
| 325 | } | 321 | } |
| 322 | return NvidiaArchitecture::Arch_Turing; | ||
| 326 | } | 323 | } |
| 327 | if (exts.contains(VK_NV_SHADING_RATE_IMAGE_EXTENSION_NAME)) { | 324 | |
| 328 | return NvidiaArchitecture::Turing; | 325 | if (exts.contains(VK_EXT_BLEND_OPERATION_ADVANCED_EXTENSION_NAME)) { |
| 326 | VkPhysicalDeviceBlendOperationAdvancedPropertiesEXT advanced_blending_props{}; | ||
| 327 | advanced_blending_props.sType = | ||
| 328 | VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BLEND_OPERATION_ADVANCED_PROPERTIES_EXT; | ||
| 329 | VkPhysicalDeviceProperties2 physical_properties{}; | ||
| 330 | physical_properties.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROPERTIES_2; | ||
| 331 | physical_properties.pNext = &advanced_blending_props; | ||
| 332 | physical.GetProperties2(physical_properties); | ||
| 333 | if (advanced_blending_props.advancedBlendMaxColorAttachments == 1) { | ||
| 334 | return NvidiaArchitecture::Arch_Maxwell; | ||
| 335 | } | ||
| 336 | |||
| 337 | if (exts.contains(VK_EXT_CONSERVATIVE_RASTERIZATION_EXTENSION_NAME)) { | ||
| 338 | VkPhysicalDeviceConservativeRasterizationPropertiesEXT conservative_raster_props{}; | ||
| 339 | conservative_raster_props.sType = | ||
| 340 | VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_CONSERVATIVE_RASTERIZATION_PROPERTIES_EXT; | ||
| 341 | physical_properties.pNext = &conservative_raster_props; | ||
| 342 | physical.GetProperties2(physical_properties); | ||
| 343 | if (conservative_raster_props.degenerateLinesRasterized) { | ||
| 344 | return NvidiaArchitecture::Arch_Volta; | ||
| 345 | } | ||
| 346 | return NvidiaArchitecture::Arch_Pascal; | ||
| 347 | } | ||
| 329 | } | 348 | } |
| 330 | return NvidiaArchitecture::VoltaOrOlder; | 349 | |
| 350 | return NvidiaArchitecture::Arch_KeplerOrOlder; | ||
| 331 | } | 351 | } |
| 332 | 352 | ||
| 333 | std::vector<const char*> ExtensionListForVulkan( | 353 | std::vector<const char*> ExtensionListForVulkan( |
| @@ -407,6 +427,10 @@ Device::Device(VkInstance instance_, vk::PhysicalDevice physical_, VkSurfaceKHR | |||
| 407 | throw vk::Exception(VK_ERROR_INCOMPATIBLE_DRIVER); | 427 | throw vk::Exception(VK_ERROR_INCOMPATIBLE_DRIVER); |
| 408 | } | 428 | } |
| 409 | 429 | ||
| 430 | if (is_nvidia) { | ||
| 431 | nvidia_arch = GetNvidiaArchitecture(physical, supported_extensions); | ||
| 432 | } | ||
| 433 | |||
| 410 | SetupFamilies(surface); | 434 | SetupFamilies(surface); |
| 411 | const auto queue_cis = GetDeviceQueueCreateInfos(); | 435 | const auto queue_cis = GetDeviceQueueCreateInfos(); |
| 412 | 436 | ||
| @@ -503,20 +527,15 @@ Device::Device(VkInstance instance_, vk::PhysicalDevice physical_, VkSurfaceKHR | |||
| 503 | 527 | ||
| 504 | if (is_nvidia) { | 528 | if (is_nvidia) { |
| 505 | const u32 nv_major_version = (properties.properties.driverVersion >> 22) & 0x3ff; | 529 | const u32 nv_major_version = (properties.properties.driverVersion >> 22) & 0x3ff; |
| 506 | const auto arch = GetNvidiaArchitecture(physical, supported_extensions); | 530 | const auto arch = GetNvidiaArch(); |
| 507 | switch (arch) { | 531 | if (arch >= NvidiaArchitecture::Arch_AmpereOrNewer) { |
| 508 | case NvidiaArchitecture::AmpereOrNewer: | ||
| 509 | LOG_WARNING(Render_Vulkan, "Ampere and newer have broken float16 math"); | 532 | LOG_WARNING(Render_Vulkan, "Ampere and newer have broken float16 math"); |
| 510 | features.shader_float16_int8.shaderFloat16 = false; | 533 | features.shader_float16_int8.shaderFloat16 = false; |
| 511 | break; | 534 | } else if (arch <= NvidiaArchitecture::Arch_Volta) { |
| 512 | case NvidiaArchitecture::Turing: | ||
| 513 | break; | ||
| 514 | case NvidiaArchitecture::VoltaOrOlder: | ||
| 515 | if (nv_major_version < 527) { | 535 | if (nv_major_version < 527) { |
| 516 | LOG_WARNING(Render_Vulkan, "Volta and older have broken VK_KHR_push_descriptor"); | 536 | LOG_WARNING(Render_Vulkan, "Volta and older have broken VK_KHR_push_descriptor"); |
| 517 | RemoveExtension(extensions.push_descriptor, VK_KHR_PUSH_DESCRIPTOR_EXTENSION_NAME); | 537 | RemoveExtension(extensions.push_descriptor, VK_KHR_PUSH_DESCRIPTOR_EXTENSION_NAME); |
| 518 | } | 538 | } |
| 519 | break; | ||
| 520 | } | 539 | } |
| 521 | if (nv_major_version >= 510) { | 540 | if (nv_major_version >= 510) { |
| 522 | LOG_WARNING(Render_Vulkan, "NVIDIA Drivers >= 510 do not support MSAA image blits"); | 541 | LOG_WARNING(Render_Vulkan, "NVIDIA Drivers >= 510 do not support MSAA image blits"); |
| @@ -661,7 +680,15 @@ Device::Device(VkInstance instance_, vk::PhysicalDevice physical_, VkSurfaceKHR | |||
| 661 | "ANV drivers 22.3.0 to 23.1.0 have broken VK_KHR_push_descriptor"); | 680 | "ANV drivers 22.3.0 to 23.1.0 have broken VK_KHR_push_descriptor"); |
| 662 | RemoveExtension(extensions.push_descriptor, VK_KHR_PUSH_DESCRIPTOR_EXTENSION_NAME); | 681 | RemoveExtension(extensions.push_descriptor, VK_KHR_PUSH_DESCRIPTOR_EXTENSION_NAME); |
| 663 | } | 682 | } |
| 683 | } else if (extensions.push_descriptor && is_nvidia) { | ||
| 684 | const auto arch = GetNvidiaArch(); | ||
| 685 | if (arch <= NvidiaArchitecture::Arch_Pascal) { | ||
| 686 | LOG_WARNING(Render_Vulkan, | ||
| 687 | "Pascal and older architectures have broken VK_KHR_push_descriptor"); | ||
| 688 | RemoveExtension(extensions.push_descriptor, VK_KHR_PUSH_DESCRIPTOR_EXTENSION_NAME); | ||
| 689 | } | ||
| 664 | } | 690 | } |
| 691 | |||
| 665 | if (is_mvk) { | 692 | if (is_mvk) { |
| 666 | LOG_WARNING(Render_Vulkan, | 693 | LOG_WARNING(Render_Vulkan, |
| 667 | "MVK driver breaks when using more than 16 vertex attributes/bindings"); | 694 | "MVK driver breaks when using more than 16 vertex attributes/bindings"); |
diff --git a/src/video_core/vulkan_common/vulkan_device.h b/src/video_core/vulkan_common/vulkan_device.h index 282a2925d..b213ed7dd 100644 --- a/src/video_core/vulkan_common/vulkan_device.h +++ b/src/video_core/vulkan_common/vulkan_device.h | |||
| @@ -177,6 +177,15 @@ enum class FormatType { Linear, Optimal, Buffer }; | |||
| 177 | /// Subgroup size of the guest emulated hardware (Nvidia has 32 threads per subgroup). | 177 | /// Subgroup size of the guest emulated hardware (Nvidia has 32 threads per subgroup). |
| 178 | const u32 GuestWarpSize = 32; | 178 | const u32 GuestWarpSize = 32; |
| 179 | 179 | ||
| 180 | enum class NvidiaArchitecture { | ||
| 181 | Arch_KeplerOrOlder, | ||
| 182 | Arch_Maxwell, | ||
| 183 | Arch_Pascal, | ||
| 184 | Arch_Volta, | ||
| 185 | Arch_Turing, | ||
| 186 | Arch_AmpereOrNewer, | ||
| 187 | }; | ||
| 188 | |||
| 180 | /// Handles data specific to a physical device. | 189 | /// Handles data specific to a physical device. |
| 181 | class Device { | 190 | class Device { |
| 182 | public: | 191 | public: |
| @@ -670,6 +679,14 @@ public: | |||
| 670 | return false; | 679 | return false; |
| 671 | } | 680 | } |
| 672 | 681 | ||
| 682 | bool IsNvidia() const noexcept { | ||
| 683 | return properties.driver.driverID == VK_DRIVER_ID_NVIDIA_PROPRIETARY; | ||
| 684 | } | ||
| 685 | |||
| 686 | NvidiaArchitecture GetNvidiaArch() const noexcept { | ||
| 687 | return nvidia_arch; | ||
| 688 | } | ||
| 689 | |||
| 673 | private: | 690 | private: |
| 674 | /// Checks if the physical device is suitable and configures the object state | 691 | /// Checks if the physical device is suitable and configures the object state |
| 675 | /// with all necessary info about its properties. | 692 | /// with all necessary info about its properties. |
| @@ -788,6 +805,7 @@ private: | |||
| 788 | bool supports_conditional_barriers{}; ///< Allows barriers in conditional control flow. | 805 | bool supports_conditional_barriers{}; ///< Allows barriers in conditional control flow. |
| 789 | u64 device_access_memory{}; ///< Total size of device local memory in bytes. | 806 | u64 device_access_memory{}; ///< Total size of device local memory in bytes. |
| 790 | u32 sets_per_pool{}; ///< Sets per Description Pool | 807 | u32 sets_per_pool{}; ///< Sets per Description Pool |
| 808 | NvidiaArchitecture nvidia_arch{NvidiaArchitecture::Arch_AmpereOrNewer}; | ||
| 791 | 809 | ||
| 792 | // Telemetry parameters | 810 | // Telemetry parameters |
| 793 | std::set<std::string, std::less<>> supported_extensions; ///< Reported Vulkan extensions. | 811 | std::set<std::string, std::less<>> supported_extensions; ///< Reported Vulkan extensions. |
diff --git a/src/video_core/vulkan_common/vulkan_memory_allocator.cpp b/src/video_core/vulkan_common/vulkan_memory_allocator.cpp index 3ef381a38..8dd1667f3 100644 --- a/src/video_core/vulkan_common/vulkan_memory_allocator.cpp +++ b/src/video_core/vulkan_common/vulkan_memory_allocator.cpp | |||
| @@ -9,6 +9,7 @@ | |||
| 9 | #include "common/alignment.h" | 9 | #include "common/alignment.h" |
| 10 | #include "common/assert.h" | 10 | #include "common/assert.h" |
| 11 | #include "common/common_types.h" | 11 | #include "common/common_types.h" |
| 12 | #include "common/literals.h" | ||
| 12 | #include "common/logging/log.h" | 13 | #include "common/logging/log.h" |
| 13 | #include "common/polyfill_ranges.h" | 14 | #include "common/polyfill_ranges.h" |
| 14 | #include "video_core/vulkan_common/vma.h" | 15 | #include "video_core/vulkan_common/vma.h" |
| @@ -65,12 +66,12 @@ struct Range { | |||
| 65 | switch (usage) { | 66 | switch (usage) { |
| 66 | case MemoryUsage::Upload: | 67 | case MemoryUsage::Upload: |
| 67 | case MemoryUsage::Stream: | 68 | case MemoryUsage::Stream: |
| 68 | return VMA_ALLOCATION_CREATE_HOST_ACCESS_SEQUENTIAL_WRITE_BIT; | 69 | return VMA_ALLOCATION_CREATE_MAPPED_BIT | |
| 70 | VMA_ALLOCATION_CREATE_HOST_ACCESS_SEQUENTIAL_WRITE_BIT; | ||
| 69 | case MemoryUsage::Download: | 71 | case MemoryUsage::Download: |
| 70 | return VMA_ALLOCATION_CREATE_HOST_ACCESS_RANDOM_BIT; | 72 | return VMA_ALLOCATION_CREATE_MAPPED_BIT | VMA_ALLOCATION_CREATE_HOST_ACCESS_RANDOM_BIT; |
| 71 | case MemoryUsage::DeviceLocal: | 73 | case MemoryUsage::DeviceLocal: |
| 72 | return VMA_ALLOCATION_CREATE_HOST_ACCESS_SEQUENTIAL_WRITE_BIT | | 74 | return {}; |
| 73 | VMA_ALLOCATION_CREATE_HOST_ACCESS_ALLOW_TRANSFER_INSTEAD_BIT; | ||
| 74 | } | 75 | } |
| 75 | return {}; | 76 | return {}; |
| 76 | } | 77 | } |
| @@ -212,7 +213,20 @@ MemoryAllocator::MemoryAllocator(const Device& device_) | |||
| 212 | : device{device_}, allocator{device.GetAllocator()}, | 213 | : device{device_}, allocator{device.GetAllocator()}, |
| 213 | properties{device_.GetPhysical().GetMemoryProperties().memoryProperties}, | 214 | properties{device_.GetPhysical().GetMemoryProperties().memoryProperties}, |
| 214 | buffer_image_granularity{ | 215 | buffer_image_granularity{ |
| 215 | device_.GetPhysical().GetProperties().limits.bufferImageGranularity} {} | 216 | device_.GetPhysical().GetProperties().limits.bufferImageGranularity} { |
| 217 | // GPUs not supporting rebar may only have a region with less than 256MB host visible/device | ||
| 218 | // local memory. In that case, opening 2 RenderDoc captures side-by-side is not possible due to | ||
| 219 | // the heap running out of memory. With RenderDoc attached and only a small host/device region, | ||
| 220 | // only allow the stream buffer in this memory heap. | ||
| 221 | if (device.HasDebuggingToolAttached()) { | ||
| 222 | using namespace Common::Literals; | ||
| 223 | ForEachDeviceLocalHostVisibleHeap(device, [this](size_t index, VkMemoryHeap& heap) { | ||
| 224 | if (heap.size <= 256_MiB) { | ||
| 225 | valid_memory_types &= ~(1u << index); | ||
| 226 | } | ||
| 227 | }); | ||
| 228 | } | ||
| 229 | } | ||
| 216 | 230 | ||
| 217 | MemoryAllocator::~MemoryAllocator() = default; | 231 | MemoryAllocator::~MemoryAllocator() = default; |
| 218 | 232 | ||
| @@ -239,12 +253,11 @@ vk::Image MemoryAllocator::CreateImage(const VkImageCreateInfo& ci) const { | |||
| 239 | 253 | ||
| 240 | vk::Buffer MemoryAllocator::CreateBuffer(const VkBufferCreateInfo& ci, MemoryUsage usage) const { | 254 | vk::Buffer MemoryAllocator::CreateBuffer(const VkBufferCreateInfo& ci, MemoryUsage usage) const { |
| 241 | const VmaAllocationCreateInfo alloc_ci = { | 255 | const VmaAllocationCreateInfo alloc_ci = { |
| 242 | .flags = VMA_ALLOCATION_CREATE_WITHIN_BUDGET_BIT | VMA_ALLOCATION_CREATE_MAPPED_BIT | | 256 | .flags = VMA_ALLOCATION_CREATE_WITHIN_BUDGET_BIT | MemoryUsageVmaFlags(usage), |
| 243 | MemoryUsageVmaFlags(usage), | ||
| 244 | .usage = MemoryUsageVma(usage), | 257 | .usage = MemoryUsageVma(usage), |
| 245 | .requiredFlags = 0, | 258 | .requiredFlags = 0, |
| 246 | .preferredFlags = MemoryUsagePreferedVmaFlags(usage), | 259 | .preferredFlags = MemoryUsagePreferedVmaFlags(usage), |
| 247 | .memoryTypeBits = 0, | 260 | .memoryTypeBits = usage == MemoryUsage::Stream ? 0u : valid_memory_types, |
| 248 | .pool = VK_NULL_HANDLE, | 261 | .pool = VK_NULL_HANDLE, |
| 249 | .pUserData = nullptr, | 262 | .pUserData = nullptr, |
| 250 | .priority = 0.f, | 263 | .priority = 0.f, |
diff --git a/src/video_core/vulkan_common/vulkan_memory_allocator.h b/src/video_core/vulkan_common/vulkan_memory_allocator.h index f449bc8d0..38a182bcb 100644 --- a/src/video_core/vulkan_common/vulkan_memory_allocator.h +++ b/src/video_core/vulkan_common/vulkan_memory_allocator.h | |||
| @@ -7,6 +7,7 @@ | |||
| 7 | #include <span> | 7 | #include <span> |
| 8 | #include <vector> | 8 | #include <vector> |
| 9 | #include "common/common_types.h" | 9 | #include "common/common_types.h" |
| 10 | #include "video_core/vulkan_common/vulkan_device.h" | ||
| 10 | #include "video_core/vulkan_common/vulkan_wrapper.h" | 11 | #include "video_core/vulkan_common/vulkan_wrapper.h" |
| 11 | 12 | ||
| 12 | VK_DEFINE_HANDLE(VmaAllocator) | 13 | VK_DEFINE_HANDLE(VmaAllocator) |
| @@ -26,6 +27,18 @@ enum class MemoryUsage { | |||
| 26 | Stream, ///< Requests device local host visible buffer, falling back host memory. | 27 | Stream, ///< Requests device local host visible buffer, falling back host memory. |
| 27 | }; | 28 | }; |
| 28 | 29 | ||
| 30 | template <typename F> | ||
| 31 | void ForEachDeviceLocalHostVisibleHeap(const Device& device, F&& f) { | ||
| 32 | auto memory_props = device.GetPhysical().GetMemoryProperties().memoryProperties; | ||
| 33 | for (size_t i = 0; i < memory_props.memoryTypeCount; i++) { | ||
| 34 | auto& memory_type = memory_props.memoryTypes[i]; | ||
| 35 | if ((memory_type.propertyFlags & VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT) && | ||
| 36 | (memory_type.propertyFlags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT)) { | ||
| 37 | f(memory_type.heapIndex, memory_props.memoryHeaps[memory_type.heapIndex]); | ||
| 38 | } | ||
| 39 | } | ||
| 40 | } | ||
| 41 | |||
| 29 | /// Ownership handle of a memory commitment. | 42 | /// Ownership handle of a memory commitment. |
| 30 | /// Points to a subregion of a memory allocation. | 43 | /// Points to a subregion of a memory allocation. |
| 31 | class MemoryCommit { | 44 | class MemoryCommit { |
| @@ -124,6 +137,7 @@ private: | |||
| 124 | std::vector<std::unique_ptr<MemoryAllocation>> allocations; ///< Current allocations. | 137 | std::vector<std::unique_ptr<MemoryAllocation>> allocations; ///< Current allocations. |
| 125 | VkDeviceSize buffer_image_granularity; // The granularity for adjacent offsets between buffers | 138 | VkDeviceSize buffer_image_granularity; // The granularity for adjacent offsets between buffers |
| 126 | // and optimal images | 139 | // and optimal images |
| 140 | u32 valid_memory_types{~0u}; | ||
| 127 | }; | 141 | }; |
| 128 | 142 | ||
| 129 | } // namespace Vulkan | 143 | } // namespace Vulkan |
diff --git a/src/video_core/vulkan_common/vulkan_wrapper.cpp b/src/video_core/vulkan_common/vulkan_wrapper.cpp index 2f3254a97..70cf14afa 100644 --- a/src/video_core/vulkan_common/vulkan_wrapper.cpp +++ b/src/video_core/vulkan_common/vulkan_wrapper.cpp | |||
| @@ -522,7 +522,7 @@ Instance Instance::Create(u32 version, Span<const char*> layers, Span<const char | |||
| 522 | .applicationVersion = VK_MAKE_VERSION(0, 1, 0), | 522 | .applicationVersion = VK_MAKE_VERSION(0, 1, 0), |
| 523 | .pEngineName = "yuzu Emulator", | 523 | .pEngineName = "yuzu Emulator", |
| 524 | .engineVersion = VK_MAKE_VERSION(0, 1, 0), | 524 | .engineVersion = VK_MAKE_VERSION(0, 1, 0), |
| 525 | .apiVersion = version, | 525 | .apiVersion = VK_API_VERSION_1_3, |
| 526 | }; | 526 | }; |
| 527 | const VkInstanceCreateInfo ci{ | 527 | const VkInstanceCreateInfo ci{ |
| 528 | .sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO, | 528 | .sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO, |
diff --git a/src/video_core/vulkan_common/vulkan_wrapper.h b/src/video_core/vulkan_common/vulkan_wrapper.h index 1e3c0fa64..0487cd3b6 100644 --- a/src/video_core/vulkan_common/vulkan_wrapper.h +++ b/src/video_core/vulkan_common/vulkan_wrapper.h | |||
| @@ -117,6 +117,9 @@ public: | |||
| 117 | virtual ~Exception() = default; | 117 | virtual ~Exception() = default; |
| 118 | 118 | ||
| 119 | const char* what() const noexcept override; | 119 | const char* what() const noexcept override; |
| 120 | VkResult GetResult() const noexcept { | ||
| 121 | return result; | ||
| 122 | } | ||
| 120 | 123 | ||
| 121 | private: | 124 | private: |
| 122 | VkResult result; | 125 | VkResult result; |
diff --git a/src/yuzu/CMakeLists.txt b/src/yuzu/CMakeLists.txt index d23c1e9d0..33e1fb663 100644 --- a/src/yuzu/CMakeLists.txt +++ b/src/yuzu/CMakeLists.txt | |||
| @@ -195,6 +195,8 @@ add_executable(yuzu | |||
| 195 | multiplayer/state.cpp | 195 | multiplayer/state.cpp |
| 196 | multiplayer/state.h | 196 | multiplayer/state.h |
| 197 | multiplayer/validation.h | 197 | multiplayer/validation.h |
| 198 | play_time_manager.cpp | ||
| 199 | play_time_manager.h | ||
| 198 | precompiled_headers.h | 200 | precompiled_headers.h |
| 199 | qt_common.cpp | 201 | qt_common.cpp |
| 200 | qt_common.h | 202 | qt_common.h |
| @@ -382,7 +384,7 @@ if (USE_DISCORD_PRESENCE) | |||
| 382 | discord_impl.cpp | 384 | discord_impl.cpp |
| 383 | discord_impl.h | 385 | discord_impl.h |
| 384 | ) | 386 | ) |
| 385 | target_link_libraries(yuzu PRIVATE DiscordRPC::discord-rpc httplib::httplib) | 387 | target_link_libraries(yuzu PRIVATE DiscordRPC::discord-rpc httplib::httplib Qt${QT_MAJOR_VERSION}::Network) |
| 386 | target_compile_definitions(yuzu PRIVATE -DUSE_DISCORD_PRESENCE) | 388 | target_compile_definitions(yuzu PRIVATE -DUSE_DISCORD_PRESENCE) |
| 387 | endif() | 389 | endif() |
| 388 | 390 | ||
diff --git a/src/yuzu/applets/qt_controller.cpp b/src/yuzu/applets/qt_controller.cpp index d15559518..515cb7ce6 100644 --- a/src/yuzu/applets/qt_controller.cpp +++ b/src/yuzu/applets/qt_controller.cpp | |||
| @@ -23,6 +23,7 @@ | |||
| 23 | #include "yuzu/configuration/configure_vibration.h" | 23 | #include "yuzu/configuration/configure_vibration.h" |
| 24 | #include "yuzu/configuration/input_profiles.h" | 24 | #include "yuzu/configuration/input_profiles.h" |
| 25 | #include "yuzu/main.h" | 25 | #include "yuzu/main.h" |
| 26 | #include "yuzu/util/controller_navigation.h" | ||
| 26 | 27 | ||
| 27 | namespace { | 28 | namespace { |
| 28 | 29 | ||
| @@ -132,6 +133,8 @@ QtControllerSelectorDialog::QtControllerSelectorDialog( | |||
| 132 | ui->checkboxPlayer7Connected, ui->checkboxPlayer8Connected, | 133 | ui->checkboxPlayer7Connected, ui->checkboxPlayer8Connected, |
| 133 | }; | 134 | }; |
| 134 | 135 | ||
| 136 | ui->labelError->setVisible(false); | ||
| 137 | |||
| 135 | // Setup/load everything prior to setting up connections. | 138 | // Setup/load everything prior to setting up connections. |
| 136 | // This avoids unintentionally changing the states of elements while loading them in. | 139 | // This avoids unintentionally changing the states of elements while loading them in. |
| 137 | SetSupportedControllers(); | 140 | SetSupportedControllers(); |
| @@ -143,6 +146,8 @@ QtControllerSelectorDialog::QtControllerSelectorDialog( | |||
| 143 | 146 | ||
| 144 | LoadConfiguration(); | 147 | LoadConfiguration(); |
| 145 | 148 | ||
| 149 | controller_navigation = new ControllerNavigation(system.HIDCore(), this); | ||
| 150 | |||
| 146 | for (std::size_t i = 0; i < NUM_PLAYERS; ++i) { | 151 | for (std::size_t i = 0; i < NUM_PLAYERS; ++i) { |
| 147 | SetExplainText(i); | 152 | SetExplainText(i); |
| 148 | UpdateControllerIcon(i); | 153 | UpdateControllerIcon(i); |
| @@ -150,16 +155,27 @@ QtControllerSelectorDialog::QtControllerSelectorDialog( | |||
| 150 | UpdateBorderColor(i); | 155 | UpdateBorderColor(i); |
| 151 | 156 | ||
| 152 | connect(player_groupboxes[i], &QGroupBox::toggled, [this, i](bool checked) { | 157 | connect(player_groupboxes[i], &QGroupBox::toggled, [this, i](bool checked) { |
| 153 | if (checked) { | 158 | // Reconnect current controller if it was the last one checked |
| 154 | for (std::size_t index = 0; index <= i; ++index) { | 159 | // (player number was reduced by more than one) |
| 155 | connected_controller_checkboxes[index]->setChecked(checked); | 160 | const bool reconnect_first = !checked && i < player_groupboxes.size() - 1 && |
| 156 | } | 161 | player_groupboxes[i + 1]->isChecked(); |
| 157 | } else { | 162 | |
| 158 | for (std::size_t index = i; index < NUM_PLAYERS; ++index) { | 163 | // Ensures that connecting a controller changes the number of players |
| 159 | connected_controller_checkboxes[index]->setChecked(checked); | 164 | if (connected_controller_checkboxes[i]->isChecked() != checked) { |
| 160 | } | 165 | // Ensures that the players are always connected in sequential order |
| 166 | PropagatePlayerNumberChanged(i, checked, reconnect_first); | ||
| 161 | } | 167 | } |
| 162 | }); | 168 | }); |
| 169 | connect(connected_controller_checkboxes[i], &QCheckBox::clicked, [this, i](bool checked) { | ||
| 170 | // Reconnect current controller if it was the last one checked | ||
| 171 | // (player number was reduced by more than one) | ||
| 172 | const bool reconnect_first = !checked && | ||
| 173 | i < connected_controller_checkboxes.size() - 1 && | ||
| 174 | connected_controller_checkboxes[i + 1]->isChecked(); | ||
| 175 | |||
| 176 | // Ensures that the players are always connected in sequential order | ||
| 177 | PropagatePlayerNumberChanged(i, checked, reconnect_first); | ||
| 178 | }); | ||
| 163 | 179 | ||
| 164 | connect(emulated_controllers[i], qOverload<int>(&QComboBox::currentIndexChanged), | 180 | connect(emulated_controllers[i], qOverload<int>(&QComboBox::currentIndexChanged), |
| 165 | [this, i](int) { | 181 | [this, i](int) { |
| @@ -199,6 +215,12 @@ QtControllerSelectorDialog::QtControllerSelectorDialog( | |||
| 199 | connect(ui->buttonBox, &QDialogButtonBox::accepted, this, | 215 | connect(ui->buttonBox, &QDialogButtonBox::accepted, this, |
| 200 | &QtControllerSelectorDialog::ApplyConfiguration); | 216 | &QtControllerSelectorDialog::ApplyConfiguration); |
| 201 | 217 | ||
| 218 | connect(controller_navigation, &ControllerNavigation::TriggerKeyboardEvent, | ||
| 219 | [this](Qt::Key key) { | ||
| 220 | QKeyEvent* event = new QKeyEvent(QEvent::KeyPress, key, Qt::NoModifier); | ||
| 221 | QCoreApplication::postEvent(this, event); | ||
| 222 | }); | ||
| 223 | |||
| 202 | // Enhancement: Check if the parameters have already been met before disconnecting controllers. | 224 | // Enhancement: Check if the parameters have already been met before disconnecting controllers. |
| 203 | // If all the parameters are met AND only allows a single player, | 225 | // If all the parameters are met AND only allows a single player, |
| 204 | // stop the constructor here as we do not need to continue. | 226 | // stop the constructor here as we do not need to continue. |
| @@ -217,6 +239,7 @@ QtControllerSelectorDialog::QtControllerSelectorDialog( | |||
| 217 | } | 239 | } |
| 218 | 240 | ||
| 219 | QtControllerSelectorDialog::~QtControllerSelectorDialog() { | 241 | QtControllerSelectorDialog::~QtControllerSelectorDialog() { |
| 242 | controller_navigation->UnloadController(); | ||
| 220 | system.HIDCore().DisableAllControllerConfiguration(); | 243 | system.HIDCore().DisableAllControllerConfiguration(); |
| 221 | } | 244 | } |
| 222 | 245 | ||
| @@ -291,6 +314,31 @@ void QtControllerSelectorDialog::CallConfigureInputProfileDialog() { | |||
| 291 | dialog.exec(); | 314 | dialog.exec(); |
| 292 | } | 315 | } |
| 293 | 316 | ||
| 317 | void QtControllerSelectorDialog::keyPressEvent(QKeyEvent* evt) { | ||
| 318 | const auto num_connected_players = static_cast<int>( | ||
| 319 | std::count_if(player_groupboxes.begin(), player_groupboxes.end(), | ||
| 320 | [](const QGroupBox* player) { return player->isChecked(); })); | ||
| 321 | |||
| 322 | const auto min_supported_players = parameters.enable_single_mode ? 1 : parameters.min_players; | ||
| 323 | const auto max_supported_players = parameters.enable_single_mode ? 1 : parameters.max_players; | ||
| 324 | |||
| 325 | if ((evt->key() == Qt::Key_Enter || evt->key() == Qt::Key_Return) && !parameters_met) { | ||
| 326 | // Display error message when trying to validate using "Enter" and "OK" button is disabled | ||
| 327 | ui->labelError->setVisible(true); | ||
| 328 | return; | ||
| 329 | } else if (evt->key() == Qt::Key_Left && num_connected_players > min_supported_players) { | ||
| 330 | // Remove a player if possible | ||
| 331 | connected_controller_checkboxes[num_connected_players - 1]->setChecked(false); | ||
| 332 | return; | ||
| 333 | } else if (evt->key() == Qt::Key_Right && num_connected_players < max_supported_players) { | ||
| 334 | // Add a player, if possible | ||
| 335 | ui->labelError->setVisible(false); | ||
| 336 | connected_controller_checkboxes[num_connected_players]->setChecked(true); | ||
| 337 | return; | ||
| 338 | } | ||
| 339 | QDialog::keyPressEvent(evt); | ||
| 340 | } | ||
| 341 | |||
| 294 | bool QtControllerSelectorDialog::CheckIfParametersMet() { | 342 | bool QtControllerSelectorDialog::CheckIfParametersMet() { |
| 295 | // Here, we check and validate the current configuration against all applicable parameters. | 343 | // Here, we check and validate the current configuration against all applicable parameters. |
| 296 | const auto num_connected_players = static_cast<int>( | 344 | const auto num_connected_players = static_cast<int>( |
| @@ -629,6 +677,29 @@ void QtControllerSelectorDialog::UpdateDockedState(bool is_handheld) { | |||
| 629 | } | 677 | } |
| 630 | } | 678 | } |
| 631 | 679 | ||
| 680 | void QtControllerSelectorDialog::PropagatePlayerNumberChanged(size_t player_index, bool checked, | ||
| 681 | bool reconnect_current) { | ||
| 682 | connected_controller_checkboxes[player_index]->setChecked(checked); | ||
| 683 | // Hide eventual error message about number of controllers | ||
| 684 | ui->labelError->setVisible(false); | ||
| 685 | |||
| 686 | if (checked) { | ||
| 687 | // Check all previous buttons when checked | ||
| 688 | if (player_index > 0) { | ||
| 689 | PropagatePlayerNumberChanged(player_index - 1, checked); | ||
| 690 | } | ||
| 691 | } else { | ||
| 692 | // Unchecked all following buttons when unchecked | ||
| 693 | if (player_index < connected_controller_checkboxes.size() - 1) { | ||
| 694 | PropagatePlayerNumberChanged(player_index + 1, checked); | ||
| 695 | } | ||
| 696 | } | ||
| 697 | |||
| 698 | if (reconnect_current) { | ||
| 699 | connected_controller_checkboxes[player_index]->setCheckState(Qt::Checked); | ||
| 700 | } | ||
| 701 | } | ||
| 702 | |||
| 632 | void QtControllerSelectorDialog::DisableUnsupportedPlayers() { | 703 | void QtControllerSelectorDialog::DisableUnsupportedPlayers() { |
| 633 | const auto max_supported_players = parameters.enable_single_mode ? 1 : parameters.max_players; | 704 | const auto max_supported_players = parameters.enable_single_mode ? 1 : parameters.max_players; |
| 634 | 705 | ||
diff --git a/src/yuzu/applets/qt_controller.h b/src/yuzu/applets/qt_controller.h index 2fdc35857..e5372495d 100644 --- a/src/yuzu/applets/qt_controller.h +++ b/src/yuzu/applets/qt_controller.h | |||
| @@ -34,6 +34,8 @@ class HIDCore; | |||
| 34 | enum class NpadStyleIndex : u8; | 34 | enum class NpadStyleIndex : u8; |
| 35 | } // namespace Core::HID | 35 | } // namespace Core::HID |
| 36 | 36 | ||
| 37 | class ControllerNavigation; | ||
| 38 | |||
| 37 | class QtControllerSelectorDialog final : public QDialog { | 39 | class QtControllerSelectorDialog final : public QDialog { |
| 38 | Q_OBJECT | 40 | Q_OBJECT |
| 39 | 41 | ||
| @@ -46,6 +48,8 @@ public: | |||
| 46 | 48 | ||
| 47 | int exec() override; | 49 | int exec() override; |
| 48 | 50 | ||
| 51 | void keyPressEvent(QKeyEvent* evt) override; | ||
| 52 | |||
| 49 | private: | 53 | private: |
| 50 | // Applies the current configuration. | 54 | // Applies the current configuration. |
| 51 | void ApplyConfiguration(); | 55 | void ApplyConfiguration(); |
| @@ -96,6 +100,10 @@ private: | |||
| 96 | // Updates the console mode. | 100 | // Updates the console mode. |
| 97 | void UpdateDockedState(bool is_handheld); | 101 | void UpdateDockedState(bool is_handheld); |
| 98 | 102 | ||
| 103 | // Enable preceding controllers or disable following ones | ||
| 104 | void PropagatePlayerNumberChanged(size_t player_index, bool checked, | ||
| 105 | bool reconnect_current = false); | ||
| 106 | |||
| 99 | // Disables and disconnects unsupported players based on the given parameters. | 107 | // Disables and disconnects unsupported players based on the given parameters. |
| 100 | void DisableUnsupportedPlayers(); | 108 | void DisableUnsupportedPlayers(); |
| 101 | 109 | ||
| @@ -110,6 +118,8 @@ private: | |||
| 110 | 118 | ||
| 111 | Core::System& system; | 119 | Core::System& system; |
| 112 | 120 | ||
| 121 | ControllerNavigation* controller_navigation = nullptr; | ||
| 122 | |||
| 113 | // This is true if and only if all parameters are met. Otherwise, this is false. | 123 | // This is true if and only if all parameters are met. Otherwise, this is false. |
| 114 | // This determines whether the "OK" button can be clicked to exit the applet. | 124 | // This determines whether the "OK" button can be clicked to exit the applet. |
| 115 | bool parameters_met{false}; | 125 | bool parameters_met{false}; |
diff --git a/src/yuzu/applets/qt_controller.ui b/src/yuzu/applets/qt_controller.ui index 729e921ee..6f7cb3c13 100644 --- a/src/yuzu/applets/qt_controller.ui +++ b/src/yuzu/applets/qt_controller.ui | |||
| @@ -2624,13 +2624,53 @@ | |||
| 2624 | </spacer> | 2624 | </spacer> |
| 2625 | </item> | 2625 | </item> |
| 2626 | <item alignment="Qt::AlignBottom"> | 2626 | <item alignment="Qt::AlignBottom"> |
| 2627 | <widget class="QDialogButtonBox" name="buttonBox"> | 2627 | <widget class="QWidget" name="closeButtons" native="true"> |
| 2628 | <property name="enabled"> | 2628 | <layout class="QVBoxLayout" name="verticalLayout_46"> |
| 2629 | <bool>true</bool> | 2629 | <property name="spacing"> |
| 2630 | </property> | 2630 | <number>7</number> |
| 2631 | <property name="standardButtons"> | 2631 | </property> |
| 2632 | <set>QDialogButtonBox::Cancel|QDialogButtonBox::Ok</set> | 2632 | <property name="leftMargin"> |
| 2633 | </property> | 2633 | <number>0</number> |
| 2634 | </property> | ||
| 2635 | <property name="topMargin"> | ||
| 2636 | <number>0</number> | ||
| 2637 | </property> | ||
| 2638 | <property name="rightMargin"> | ||
| 2639 | <number>0</number> | ||
| 2640 | </property> | ||
| 2641 | <property name="bottomMargin"> | ||
| 2642 | <number>0</number> | ||
| 2643 | </property> | ||
| 2644 | <item> | ||
| 2645 | <widget class="QLabel" name="labelError"> | ||
| 2646 | <property name="enabled"> | ||
| 2647 | <bool>true</bool> | ||
| 2648 | </property> | ||
| 2649 | <property name="styleSheet"> | ||
| 2650 | <string notr="true">QLabel { color : red; }</string> | ||
| 2651 | </property> | ||
| 2652 | <property name="text"> | ||
| 2653 | <string>Not enough controllers</string> | ||
| 2654 | </property> | ||
| 2655 | <property name="alignment"> | ||
| 2656 | <set>Qt::AlignCenter</set> | ||
| 2657 | </property> | ||
| 2658 | <property name="margin"> | ||
| 2659 | <number>0</number> | ||
| 2660 | </property> | ||
| 2661 | </widget> | ||
| 2662 | </item> | ||
| 2663 | <item> | ||
| 2664 | <widget class="QDialogButtonBox" name="buttonBox"> | ||
| 2665 | <property name="enabled"> | ||
| 2666 | <bool>true</bool> | ||
| 2667 | </property> | ||
| 2668 | <property name="standardButtons"> | ||
| 2669 | <set>QDialogButtonBox::Cancel|QDialogButtonBox::Ok</set> | ||
| 2670 | </property> | ||
| 2671 | </widget> | ||
| 2672 | </item> | ||
| 2673 | </layout> | ||
| 2634 | </widget> | 2674 | </widget> |
| 2635 | </item> | 2675 | </item> |
| 2636 | </layout> | 2676 | </layout> |
diff --git a/src/yuzu/configuration/config.cpp b/src/yuzu/configuration/config.cpp index 1de093447..baa3e55f3 100644 --- a/src/yuzu/configuration/config.cpp +++ b/src/yuzu/configuration/config.cpp | |||
| @@ -114,7 +114,7 @@ const std::map<Settings::ShaderBackend, QString> Config::shader_backend_texts_ma | |||
| 114 | // This must be in alphabetical order according to action name as it must have the same order as | 114 | // This must be in alphabetical order according to action name as it must have the same order as |
| 115 | // UISetting::values.shortcuts, which is alphabetically ordered. | 115 | // UISetting::values.shortcuts, which is alphabetically ordered. |
| 116 | // clang-format off | 116 | // clang-format off |
| 117 | const std::array<UISettings::Shortcut, 22> Config::default_hotkeys{{ | 117 | const std::array<UISettings::Shortcut, 23> Config::default_hotkeys{{ |
| 118 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Audio Mute/Unmute")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+M"), QStringLiteral("Home+Dpad_Right"), Qt::WindowShortcut, false}}, | 118 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Audio Mute/Unmute")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+M"), QStringLiteral("Home+Dpad_Right"), Qt::WindowShortcut, false}}, |
| 119 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Audio Volume Down")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("-"), QStringLiteral("Home+Dpad_Down"), Qt::ApplicationShortcut, true}}, | 119 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Audio Volume Down")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("-"), QStringLiteral("Home+Dpad_Down"), Qt::ApplicationShortcut, true}}, |
| 120 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Audio Volume Up")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("="), QStringLiteral("Home+Dpad_Up"), Qt::ApplicationShortcut, true}}, | 120 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Audio Volume Up")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("="), QStringLiteral("Home+Dpad_Up"), Qt::ApplicationShortcut, true}}, |
| @@ -128,14 +128,15 @@ const std::array<UISettings::Shortcut, 22> Config::default_hotkeys{{ | |||
| 128 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Fullscreen")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("F11"), QStringLiteral("Home+B"), Qt::WindowShortcut, false}}, | 128 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Fullscreen")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("F11"), QStringLiteral("Home+B"), Qt::WindowShortcut, false}}, |
| 129 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Load File")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+O"), QStringLiteral(""), Qt::WidgetWithChildrenShortcut, false}}, | 129 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Load File")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+O"), QStringLiteral(""), Qt::WidgetWithChildrenShortcut, false}}, |
| 130 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Load/Remove Amiibo")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("F2"), QStringLiteral("Home+A"), Qt::WidgetWithChildrenShortcut, false}}, | 130 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Load/Remove Amiibo")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("F2"), QStringLiteral("Home+A"), Qt::WidgetWithChildrenShortcut, false}}, |
| 131 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Restart Emulation")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("F6"), QStringLiteral(""), Qt::WindowShortcut, false}}, | 131 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Restart Emulation")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("F6"), QStringLiteral("R+Plus+Minus"), Qt::WindowShortcut, false}}, |
| 132 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Stop Emulation")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("F5"), QStringLiteral(""), Qt::WindowShortcut, false}}, | 132 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Stop Emulation")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("F5"), QStringLiteral("L+Plus+Minus"), Qt::WindowShortcut, false}}, |
| 133 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "TAS Record")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+F7"), QStringLiteral(""), Qt::ApplicationShortcut, false}}, | 133 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "TAS Record")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+F7"), QStringLiteral(""), Qt::ApplicationShortcut, false}}, |
| 134 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "TAS Reset")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+F6"), QStringLiteral(""), Qt::ApplicationShortcut, false}}, | 134 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "TAS Reset")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+F6"), QStringLiteral(""), Qt::ApplicationShortcut, false}}, |
| 135 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "TAS Start/Stop")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+F5"), QStringLiteral(""), Qt::ApplicationShortcut, false}}, | 135 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "TAS Start/Stop")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+F5"), QStringLiteral(""), Qt::ApplicationShortcut, false}}, |
| 136 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Toggle Filter Bar")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+F"), QStringLiteral(""), Qt::WindowShortcut, false}}, | 136 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Toggle Filter Bar")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+F"), QStringLiteral(""), Qt::WindowShortcut, false}}, |
| 137 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Toggle Framerate Limit")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+U"), QStringLiteral("Home+Y"), Qt::ApplicationShortcut, false}}, | 137 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Toggle Framerate Limit")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+U"), QStringLiteral("Home+Y"), Qt::ApplicationShortcut, false}}, |
| 138 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Toggle Mouse Panning")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+F9"), QStringLiteral(""), Qt::ApplicationShortcut, false}}, | 138 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Toggle Mouse Panning")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+F9"), QStringLiteral(""), Qt::ApplicationShortcut, false}}, |
| 139 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Toggle Renderdoc Capture")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral(""), QStringLiteral(""), Qt::ApplicationShortcut, false}}, | ||
| 139 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Toggle Status Bar")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+S"), QStringLiteral(""), Qt::WindowShortcut, false}}, | 140 | {QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Toggle Status Bar")), QStringLiteral(QT_TRANSLATE_NOOP("Hotkeys", "Main Window")), {QStringLiteral("Ctrl+S"), QStringLiteral(""), Qt::WindowShortcut, false}}, |
| 140 | }}; | 141 | }}; |
| 141 | // clang-format on | 142 | // clang-format on |
diff --git a/src/yuzu/configuration/config.h b/src/yuzu/configuration/config.h index 727feebfb..74ec4f771 100644 --- a/src/yuzu/configuration/config.h +++ b/src/yuzu/configuration/config.h | |||
| @@ -48,7 +48,7 @@ public: | |||
| 48 | default_mouse_buttons; | 48 | default_mouse_buttons; |
| 49 | static const std::array<int, Settings::NativeKeyboard::NumKeyboardKeys> default_keyboard_keys; | 49 | static const std::array<int, Settings::NativeKeyboard::NumKeyboardKeys> default_keyboard_keys; |
| 50 | static const std::array<int, Settings::NativeKeyboard::NumKeyboardMods> default_keyboard_mods; | 50 | static const std::array<int, Settings::NativeKeyboard::NumKeyboardMods> default_keyboard_mods; |
| 51 | static const std::array<UISettings::Shortcut, 22> default_hotkeys; | 51 | static const std::array<UISettings::Shortcut, 23> default_hotkeys; |
| 52 | 52 | ||
| 53 | static const std::map<Settings::AntiAliasing, QString> anti_aliasing_texts_map; | 53 | static const std::map<Settings::AntiAliasing, QString> anti_aliasing_texts_map; |
| 54 | static const std::map<Settings::ScalingFilter, QString> scaling_filter_texts_map; | 54 | static const std::map<Settings::ScalingFilter, QString> scaling_filter_texts_map; |
diff --git a/src/yuzu/configuration/configure_audio.cpp b/src/yuzu/configuration/configure_audio.cpp index 9ccfb2435..81dd51ad3 100644 --- a/src/yuzu/configuration/configure_audio.cpp +++ b/src/yuzu/configuration/configure_audio.cpp | |||
| @@ -42,6 +42,9 @@ void ConfigureAudio::Setup(const ConfigurationShared::Builder& builder) { | |||
| 42 | for (auto* setting : Settings::values.linkage.by_category[category]) { | 42 | for (auto* setting : Settings::values.linkage.by_category[category]) { |
| 43 | settings.push_back(setting); | 43 | settings.push_back(setting); |
| 44 | } | 44 | } |
| 45 | for (auto* setting : UISettings::values.linkage.by_category[category]) { | ||
| 46 | settings.push_back(setting); | ||
| 47 | } | ||
| 45 | }; | 48 | }; |
| 46 | 49 | ||
| 47 | push(Settings::Category::Audio); | 50 | push(Settings::Category::Audio); |
diff --git a/src/yuzu/configuration/configure_hotkeys.cpp b/src/yuzu/configuration/configure_hotkeys.cpp index 0b2a965f8..68e21cd84 100644 --- a/src/yuzu/configuration/configure_hotkeys.cpp +++ b/src/yuzu/configuration/configure_hotkeys.cpp | |||
| @@ -319,6 +319,13 @@ void ConfigureHotkeys::ApplyConfiguration(HotkeyRegistry& registry) { | |||
| 319 | void ConfigureHotkeys::RestoreDefaults() { | 319 | void ConfigureHotkeys::RestoreDefaults() { |
| 320 | for (int r = 0; r < model->rowCount(); ++r) { | 320 | for (int r = 0; r < model->rowCount(); ++r) { |
| 321 | const QStandardItem* parent = model->item(r, 0); | 321 | const QStandardItem* parent = model->item(r, 0); |
| 322 | const int hotkey_size = static_cast<int>(Config::default_hotkeys.size()); | ||
| 323 | |||
| 324 | if (hotkey_size != parent->rowCount()) { | ||
| 325 | QMessageBox::warning(this, tr("Invalid hotkey settings"), | ||
| 326 | tr("An error occurred. Please report this issue on github.")); | ||
| 327 | return; | ||
| 328 | } | ||
| 322 | 329 | ||
| 323 | for (int r2 = 0; r2 < parent->rowCount(); ++r2) { | 330 | for (int r2 = 0; r2 < parent->rowCount(); ++r2) { |
| 324 | model->item(r, 0) | 331 | model->item(r, 0) |
diff --git a/src/yuzu/configuration/configure_input.cpp b/src/yuzu/configuration/configure_input.cpp index e8f9ebfd8..3dcad2701 100644 --- a/src/yuzu/configuration/configure_input.cpp +++ b/src/yuzu/configuration/configure_input.cpp | |||
| @@ -101,13 +101,13 @@ void ConfigureInput::Initialize(InputCommon::InputSubsystem* input_subsystem, | |||
| 101 | ui->tabPlayer5, ui->tabPlayer6, ui->tabPlayer7, ui->tabPlayer8, | 101 | ui->tabPlayer5, ui->tabPlayer6, ui->tabPlayer7, ui->tabPlayer8, |
| 102 | }; | 102 | }; |
| 103 | 103 | ||
| 104 | player_connected = { | 104 | connected_controller_checkboxes = { |
| 105 | ui->checkboxPlayer1Connected, ui->checkboxPlayer2Connected, ui->checkboxPlayer3Connected, | 105 | ui->checkboxPlayer1Connected, ui->checkboxPlayer2Connected, ui->checkboxPlayer3Connected, |
| 106 | ui->checkboxPlayer4Connected, ui->checkboxPlayer5Connected, ui->checkboxPlayer6Connected, | 106 | ui->checkboxPlayer4Connected, ui->checkboxPlayer5Connected, ui->checkboxPlayer6Connected, |
| 107 | ui->checkboxPlayer7Connected, ui->checkboxPlayer8Connected, | 107 | ui->checkboxPlayer7Connected, ui->checkboxPlayer8Connected, |
| 108 | }; | 108 | }; |
| 109 | 109 | ||
| 110 | std::array<QLabel*, 8> player_connected_labels = { | 110 | std::array<QLabel*, 8> connected_controller_labels = { |
| 111 | ui->label, ui->label_3, ui->label_4, ui->label_5, | 111 | ui->label, ui->label_3, ui->label_4, ui->label_5, |
| 112 | ui->label_6, ui->label_7, ui->label_8, ui->label_9, | 112 | ui->label_6, ui->label_7, ui->label_8, ui->label_9, |
| 113 | }; | 113 | }; |
| @@ -115,31 +115,37 @@ void ConfigureInput::Initialize(InputCommon::InputSubsystem* input_subsystem, | |||
| 115 | for (std::size_t i = 0; i < player_tabs.size(); ++i) { | 115 | for (std::size_t i = 0; i < player_tabs.size(); ++i) { |
| 116 | player_tabs[i]->setLayout(new QHBoxLayout(player_tabs[i])); | 116 | player_tabs[i]->setLayout(new QHBoxLayout(player_tabs[i])); |
| 117 | player_tabs[i]->layout()->addWidget(player_controllers[i]); | 117 | player_tabs[i]->layout()->addWidget(player_controllers[i]); |
| 118 | connect(player_controllers[i], &ConfigureInputPlayer::Connected, [&, i](bool is_connected) { | 118 | connect(player_controllers[i], &ConfigureInputPlayer::Connected, [this, i](bool checked) { |
| 119 | // Ensures that the controllers are always connected in sequential order | 119 | // Ensures that connecting a controller changes the number of players |
| 120 | if (is_connected) { | 120 | if (connected_controller_checkboxes[i]->isChecked() != checked) { |
| 121 | for (std::size_t index = 0; index <= i; ++index) { | 121 | // Ensures that the players are always connected in sequential order |
| 122 | player_connected[index]->setChecked(is_connected); | 122 | PropagatePlayerNumberChanged(i, checked); |
| 123 | } | ||
| 124 | } else { | ||
| 125 | for (std::size_t index = i; index < player_tabs.size(); ++index) { | ||
| 126 | player_connected[index]->setChecked(is_connected); | ||
| 127 | } | ||
| 128 | } | 123 | } |
| 129 | }); | 124 | }); |
| 125 | connect(connected_controller_checkboxes[i], &QCheckBox::clicked, [this, i](bool checked) { | ||
| 126 | // Reconnect current controller if it was the last one checked | ||
| 127 | // (player number was reduced by more than one) | ||
| 128 | const bool reconnect_first = !checked && | ||
| 129 | i < connected_controller_checkboxes.size() - 1 && | ||
| 130 | connected_controller_checkboxes[i + 1]->isChecked(); | ||
| 131 | |||
| 132 | // Ensures that the players are always connected in sequential order | ||
| 133 | PropagatePlayerNumberChanged(i, checked, reconnect_first); | ||
| 134 | }); | ||
| 130 | connect(player_controllers[i], &ConfigureInputPlayer::RefreshInputDevices, this, | 135 | connect(player_controllers[i], &ConfigureInputPlayer::RefreshInputDevices, this, |
| 131 | &ConfigureInput::UpdateAllInputDevices); | 136 | &ConfigureInput::UpdateAllInputDevices); |
| 132 | connect(player_controllers[i], &ConfigureInputPlayer::RefreshInputProfiles, this, | 137 | connect(player_controllers[i], &ConfigureInputPlayer::RefreshInputProfiles, this, |
| 133 | &ConfigureInput::UpdateAllInputProfiles, Qt::QueuedConnection); | 138 | &ConfigureInput::UpdateAllInputProfiles, Qt::QueuedConnection); |
| 134 | connect(player_connected[i], &QCheckBox::stateChanged, [this, i](int state) { | 139 | connect(connected_controller_checkboxes[i], &QCheckBox::stateChanged, [this, i](int state) { |
| 140 | // Keep activated controllers synced with the "Connected Controllers" checkboxes | ||
| 135 | player_controllers[i]->ConnectPlayer(state == Qt::Checked); | 141 | player_controllers[i]->ConnectPlayer(state == Qt::Checked); |
| 136 | }); | 142 | }); |
| 137 | 143 | ||
| 138 | // Remove/hide all the elements that exceed max_players, if applicable. | 144 | // Remove/hide all the elements that exceed max_players, if applicable. |
| 139 | if (i >= max_players) { | 145 | if (i >= max_players) { |
| 140 | ui->tabWidget->removeTab(static_cast<int>(max_players)); | 146 | ui->tabWidget->removeTab(static_cast<int>(max_players)); |
| 141 | player_connected[i]->hide(); | 147 | connected_controller_checkboxes[i]->hide(); |
| 142 | player_connected_labels[i]->hide(); | 148 | connected_controller_labels[i]->hide(); |
| 143 | } | 149 | } |
| 144 | } | 150 | } |
| 145 | // Only the first player can choose handheld mode so connect the signal just to player 1 | 151 | // Only the first player can choose handheld mode so connect the signal just to player 1 |
| @@ -183,6 +189,27 @@ void ConfigureInput::Initialize(InputCommon::InputSubsystem* input_subsystem, | |||
| 183 | LoadConfiguration(); | 189 | LoadConfiguration(); |
| 184 | } | 190 | } |
| 185 | 191 | ||
| 192 | void ConfigureInput::PropagatePlayerNumberChanged(size_t player_index, bool checked, | ||
| 193 | bool reconnect_current) { | ||
| 194 | connected_controller_checkboxes[player_index]->setChecked(checked); | ||
| 195 | |||
| 196 | if (checked) { | ||
| 197 | // Check all previous buttons when checked | ||
| 198 | if (player_index > 0) { | ||
| 199 | PropagatePlayerNumberChanged(player_index - 1, checked); | ||
| 200 | } | ||
| 201 | } else { | ||
| 202 | // Unchecked all following buttons when unchecked | ||
| 203 | if (player_index < connected_controller_checkboxes.size() - 1) { | ||
| 204 | PropagatePlayerNumberChanged(player_index + 1, checked); | ||
| 205 | } | ||
| 206 | } | ||
| 207 | |||
| 208 | if (reconnect_current) { | ||
| 209 | connected_controller_checkboxes[player_index]->setCheckState(Qt::Checked); | ||
| 210 | } | ||
| 211 | } | ||
| 212 | |||
| 186 | QList<QWidget*> ConfigureInput::GetSubTabs() const { | 213 | QList<QWidget*> ConfigureInput::GetSubTabs() const { |
| 187 | return { | 214 | return { |
| 188 | ui->tabPlayer1, ui->tabPlayer2, ui->tabPlayer3, ui->tabPlayer4, ui->tabPlayer5, | 215 | ui->tabPlayer1, ui->tabPlayer2, ui->tabPlayer3, ui->tabPlayer4, ui->tabPlayer5, |
| @@ -233,17 +260,17 @@ void ConfigureInput::LoadConfiguration() { | |||
| 233 | } | 260 | } |
| 234 | 261 | ||
| 235 | void ConfigureInput::LoadPlayerControllerIndices() { | 262 | void ConfigureInput::LoadPlayerControllerIndices() { |
| 236 | for (std::size_t i = 0; i < player_connected.size(); ++i) { | 263 | for (std::size_t i = 0; i < connected_controller_checkboxes.size(); ++i) { |
| 237 | if (i == 0) { | 264 | if (i == 0) { |
| 238 | auto* handheld = | 265 | auto* handheld = |
| 239 | system.HIDCore().GetEmulatedController(Core::HID::NpadIdType::Handheld); | 266 | system.HIDCore().GetEmulatedController(Core::HID::NpadIdType::Handheld); |
| 240 | if (handheld->IsConnected()) { | 267 | if (handheld->IsConnected()) { |
| 241 | player_connected[i]->setChecked(true); | 268 | connected_controller_checkboxes[i]->setChecked(true); |
| 242 | continue; | 269 | continue; |
| 243 | } | 270 | } |
| 244 | } | 271 | } |
| 245 | const auto* controller = system.HIDCore().GetEmulatedControllerByIndex(i); | 272 | const auto* controller = system.HIDCore().GetEmulatedControllerByIndex(i); |
| 246 | player_connected[i]->setChecked(controller->IsConnected()); | 273 | connected_controller_checkboxes[i]->setChecked(controller->IsConnected()); |
| 247 | } | 274 | } |
| 248 | } | 275 | } |
| 249 | 276 | ||
diff --git a/src/yuzu/configuration/configure_input.h b/src/yuzu/configuration/configure_input.h index c89189c36..136cd3a0a 100644 --- a/src/yuzu/configuration/configure_input.h +++ b/src/yuzu/configuration/configure_input.h | |||
| @@ -56,6 +56,9 @@ private: | |||
| 56 | void UpdateDockedState(bool is_handheld); | 56 | void UpdateDockedState(bool is_handheld); |
| 57 | void UpdateAllInputDevices(); | 57 | void UpdateAllInputDevices(); |
| 58 | void UpdateAllInputProfiles(std::size_t player_index); | 58 | void UpdateAllInputProfiles(std::size_t player_index); |
| 59 | // Enable preceding controllers or disable following ones | ||
| 60 | void PropagatePlayerNumberChanged(size_t player_index, bool checked, | ||
| 61 | bool reconnect_current = false); | ||
| 59 | 62 | ||
| 60 | /// Load configuration settings. | 63 | /// Load configuration settings. |
| 61 | void LoadConfiguration(); | 64 | void LoadConfiguration(); |
| @@ -70,7 +73,8 @@ private: | |||
| 70 | 73 | ||
| 71 | std::array<ConfigureInputPlayer*, 8> player_controllers; | 74 | std::array<ConfigureInputPlayer*, 8> player_controllers; |
| 72 | std::array<QWidget*, 8> player_tabs; | 75 | std::array<QWidget*, 8> player_tabs; |
| 73 | std::array<QCheckBox*, 8> player_connected; | 76 | // Checkboxes representing the "Connected Controllers". |
| 77 | std::array<QCheckBox*, 8> connected_controller_checkboxes; | ||
| 74 | ConfigureInputAdvanced* advanced; | 78 | ConfigureInputAdvanced* advanced; |
| 75 | 79 | ||
| 76 | Core::System& system; | 80 | Core::System& system; |
diff --git a/src/yuzu/configuration/configure_input_player.h b/src/yuzu/configuration/configure_input_player.h index d4df43d73..d3255d2b4 100644 --- a/src/yuzu/configuration/configure_input_player.h +++ b/src/yuzu/configuration/configure_input_player.h | |||
| @@ -75,7 +75,7 @@ public: | |||
| 75 | void ClearAll(); | 75 | void ClearAll(); |
| 76 | 76 | ||
| 77 | signals: | 77 | signals: |
| 78 | /// Emitted when this controller is connected by the user. | 78 | /// Emitted when this controller is (dis)connected by the user. |
| 79 | void Connected(bool connected); | 79 | void Connected(bool connected); |
| 80 | /// Emitted when the Handheld mode is selected (undocked with dual joycons attached). | 80 | /// Emitted when the Handheld mode is selected (undocked with dual joycons attached). |
| 81 | void HandheldStateChanged(bool is_handheld); | 81 | void HandheldStateChanged(bool is_handheld); |
| @@ -183,9 +183,6 @@ private: | |||
| 183 | /// Stores a pair of "Connected Controllers" combobox index and Controller Type enum. | 183 | /// Stores a pair of "Connected Controllers" combobox index and Controller Type enum. |
| 184 | std::vector<std::pair<int, Core::HID::NpadStyleIndex>> index_controller_type_pairs; | 184 | std::vector<std::pair<int, Core::HID::NpadStyleIndex>> index_controller_type_pairs; |
| 185 | 185 | ||
| 186 | static constexpr int PLAYER_COUNT = 8; | ||
| 187 | std::array<QCheckBox*, PLAYER_COUNT> player_connected_checkbox; | ||
| 188 | |||
| 189 | /// This will be the the setting function when an input is awaiting configuration. | 186 | /// This will be the the setting function when an input is awaiting configuration. |
| 190 | std::optional<std::function<void(const Common::ParamPackage&)>> input_setter; | 187 | std::optional<std::function<void(const Common::ParamPackage&)>> input_setter; |
| 191 | 188 | ||
diff --git a/src/yuzu/configuration/configure_ui.cpp b/src/yuzu/configuration/configure_ui.cpp index a9fde9f4f..82f3b6e78 100644 --- a/src/yuzu/configuration/configure_ui.cpp +++ b/src/yuzu/configuration/configure_ui.cpp | |||
| @@ -123,6 +123,8 @@ ConfigureUi::ConfigureUi(Core::System& system_, QWidget* parent) | |||
| 123 | connect(ui->show_compat, &QCheckBox::stateChanged, this, &ConfigureUi::RequestGameListUpdate); | 123 | connect(ui->show_compat, &QCheckBox::stateChanged, this, &ConfigureUi::RequestGameListUpdate); |
| 124 | connect(ui->show_size, &QCheckBox::stateChanged, this, &ConfigureUi::RequestGameListUpdate); | 124 | connect(ui->show_size, &QCheckBox::stateChanged, this, &ConfigureUi::RequestGameListUpdate); |
| 125 | connect(ui->show_types, &QCheckBox::stateChanged, this, &ConfigureUi::RequestGameListUpdate); | 125 | connect(ui->show_types, &QCheckBox::stateChanged, this, &ConfigureUi::RequestGameListUpdate); |
| 126 | connect(ui->show_play_time, &QCheckBox::stateChanged, this, | ||
| 127 | &ConfigureUi::RequestGameListUpdate); | ||
| 126 | connect(ui->game_icon_size_combobox, QOverload<int>::of(&QComboBox::currentIndexChanged), this, | 128 | connect(ui->game_icon_size_combobox, QOverload<int>::of(&QComboBox::currentIndexChanged), this, |
| 127 | &ConfigureUi::RequestGameListUpdate); | 129 | &ConfigureUi::RequestGameListUpdate); |
| 128 | connect(ui->folder_icon_size_combobox, QOverload<int>::of(&QComboBox::currentIndexChanged), | 130 | connect(ui->folder_icon_size_combobox, QOverload<int>::of(&QComboBox::currentIndexChanged), |
| @@ -167,6 +169,7 @@ void ConfigureUi::ApplyConfiguration() { | |||
| 167 | UISettings::values.show_compat = ui->show_compat->isChecked(); | 169 | UISettings::values.show_compat = ui->show_compat->isChecked(); |
| 168 | UISettings::values.show_size = ui->show_size->isChecked(); | 170 | UISettings::values.show_size = ui->show_size->isChecked(); |
| 169 | UISettings::values.show_types = ui->show_types->isChecked(); | 171 | UISettings::values.show_types = ui->show_types->isChecked(); |
| 172 | UISettings::values.show_play_time = ui->show_play_time->isChecked(); | ||
| 170 | UISettings::values.game_icon_size = ui->game_icon_size_combobox->currentData().toUInt(); | 173 | UISettings::values.game_icon_size = ui->game_icon_size_combobox->currentData().toUInt(); |
| 171 | UISettings::values.folder_icon_size = ui->folder_icon_size_combobox->currentData().toUInt(); | 174 | UISettings::values.folder_icon_size = ui->folder_icon_size_combobox->currentData().toUInt(); |
| 172 | UISettings::values.row_1_text_id = ui->row_1_text_combobox->currentData().toUInt(); | 175 | UISettings::values.row_1_text_id = ui->row_1_text_combobox->currentData().toUInt(); |
| @@ -179,6 +182,7 @@ void ConfigureUi::ApplyConfiguration() { | |||
| 179 | const u32 height = ScreenshotDimensionToInt(ui->screenshot_height->currentText()); | 182 | const u32 height = ScreenshotDimensionToInt(ui->screenshot_height->currentText()); |
| 180 | UISettings::values.screenshot_height.SetValue(height); | 183 | UISettings::values.screenshot_height.SetValue(height); |
| 181 | 184 | ||
| 185 | RequestGameListUpdate(); | ||
| 182 | system.ApplySettings(); | 186 | system.ApplySettings(); |
| 183 | } | 187 | } |
| 184 | 188 | ||
| @@ -194,6 +198,7 @@ void ConfigureUi::SetConfiguration() { | |||
| 194 | ui->show_compat->setChecked(UISettings::values.show_compat.GetValue()); | 198 | ui->show_compat->setChecked(UISettings::values.show_compat.GetValue()); |
| 195 | ui->show_size->setChecked(UISettings::values.show_size.GetValue()); | 199 | ui->show_size->setChecked(UISettings::values.show_size.GetValue()); |
| 196 | ui->show_types->setChecked(UISettings::values.show_types.GetValue()); | 200 | ui->show_types->setChecked(UISettings::values.show_types.GetValue()); |
| 201 | ui->show_play_time->setChecked(UISettings::values.show_play_time.GetValue()); | ||
| 197 | ui->game_icon_size_combobox->setCurrentIndex( | 202 | ui->game_icon_size_combobox->setCurrentIndex( |
| 198 | ui->game_icon_size_combobox->findData(UISettings::values.game_icon_size.GetValue())); | 203 | ui->game_icon_size_combobox->findData(UISettings::values.game_icon_size.GetValue())); |
| 199 | ui->folder_icon_size_combobox->setCurrentIndex( | 204 | ui->folder_icon_size_combobox->setCurrentIndex( |
diff --git a/src/yuzu/configuration/configure_ui.ui b/src/yuzu/configuration/configure_ui.ui index cb66ef104..b8e648381 100644 --- a/src/yuzu/configuration/configure_ui.ui +++ b/src/yuzu/configuration/configure_ui.ui | |||
| @@ -105,6 +105,13 @@ | |||
| 105 | </widget> | 105 | </widget> |
| 106 | </item> | 106 | </item> |
| 107 | <item> | 107 | <item> |
| 108 | <widget class="QCheckBox" name="show_play_time"> | ||
| 109 | <property name="text"> | ||
| 110 | <string>Show Play Time Column</string> | ||
| 111 | </property> | ||
| 112 | </widget> | ||
| 113 | </item> | ||
| 114 | <item> | ||
| 108 | <layout class="QHBoxLayout" name="game_icon_size_qhbox_layout_2"> | 115 | <layout class="QHBoxLayout" name="game_icon_size_qhbox_layout_2"> |
| 109 | <item> | 116 | <item> |
| 110 | <widget class="QLabel" name="game_icon_size_label"> | 117 | <widget class="QLabel" name="game_icon_size_label"> |
diff --git a/src/yuzu/configuration/configure_vibration.cpp b/src/yuzu/configuration/configure_vibration.cpp index d765e808a..68c28b320 100644 --- a/src/yuzu/configuration/configure_vibration.cpp +++ b/src/yuzu/configuration/configure_vibration.cpp | |||
| @@ -89,7 +89,7 @@ void ConfigureVibration::VibrateController(Core::HID::ControllerTriggerType type | |||
| 89 | 89 | ||
| 90 | auto& player = Settings::values.players.GetValue()[player_index]; | 90 | auto& player = Settings::values.players.GetValue()[player_index]; |
| 91 | auto controller = hid_core.GetEmulatedControllerByIndex(player_index); | 91 | auto controller = hid_core.GetEmulatedControllerByIndex(player_index); |
| 92 | const int vibration_strenght = vibration_spinboxes[player_index]->value(); | 92 | const int vibration_strength = vibration_spinboxes[player_index]->value(); |
| 93 | const auto& buttons = controller->GetButtonsValues(); | 93 | const auto& buttons = controller->GetButtonsValues(); |
| 94 | 94 | ||
| 95 | bool button_is_pressed = false; | 95 | bool button_is_pressed = false; |
| @@ -105,10 +105,10 @@ void ConfigureVibration::VibrateController(Core::HID::ControllerTriggerType type | |||
| 105 | return; | 105 | return; |
| 106 | } | 106 | } |
| 107 | 107 | ||
| 108 | const int old_vibration_enabled = player.vibration_enabled; | 108 | const bool old_vibration_enabled = player.vibration_enabled; |
| 109 | const bool old_vibration_strenght = player.vibration_strength; | 109 | const int old_vibration_strength = player.vibration_strength; |
| 110 | player.vibration_enabled = true; | 110 | player.vibration_enabled = true; |
| 111 | player.vibration_strength = vibration_strenght; | 111 | player.vibration_strength = vibration_strength; |
| 112 | 112 | ||
| 113 | const Core::HID::VibrationValue vibration{ | 113 | const Core::HID::VibrationValue vibration{ |
| 114 | .low_amplitude = 1.0f, | 114 | .low_amplitude = 1.0f, |
| @@ -121,7 +121,7 @@ void ConfigureVibration::VibrateController(Core::HID::ControllerTriggerType type | |||
| 121 | 121 | ||
| 122 | // Restore previous values | 122 | // Restore previous values |
| 123 | player.vibration_enabled = old_vibration_enabled; | 123 | player.vibration_enabled = old_vibration_enabled; |
| 124 | player.vibration_strength = old_vibration_strenght; | 124 | player.vibration_strength = old_vibration_strength; |
| 125 | } | 125 | } |
| 126 | 126 | ||
| 127 | void ConfigureVibration::StopVibrations() { | 127 | void ConfigureVibration::StopVibrations() { |
diff --git a/src/yuzu/configuration/shared_translation.cpp b/src/yuzu/configuration/shared_translation.cpp index 276bdbaba..3fe448f27 100644 --- a/src/yuzu/configuration/shared_translation.cpp +++ b/src/yuzu/configuration/shared_translation.cpp | |||
| @@ -29,9 +29,10 @@ std::unique_ptr<TranslationMap> InitializeTranslations(QWidget* parent) { | |||
| 29 | INSERT(Settings, sink_id, "Output Engine:", ""); | 29 | INSERT(Settings, sink_id, "Output Engine:", ""); |
| 30 | INSERT(Settings, audio_output_device_id, "Output Device:", ""); | 30 | INSERT(Settings, audio_output_device_id, "Output Device:", ""); |
| 31 | INSERT(Settings, audio_input_device_id, "Input Device:", ""); | 31 | INSERT(Settings, audio_input_device_id, "Input Device:", ""); |
| 32 | INSERT(Settings, audio_muted, "Mute audio when in background", ""); | 32 | INSERT(Settings, audio_muted, "Mute audio", ""); |
| 33 | INSERT(Settings, volume, "Volume:", ""); | 33 | INSERT(Settings, volume, "Volume:", ""); |
| 34 | INSERT(Settings, dump_audio_commands, "", ""); | 34 | INSERT(Settings, dump_audio_commands, "", ""); |
| 35 | INSERT(UISettings, mute_when_in_background, "Mute audio when in background", ""); | ||
| 35 | 36 | ||
| 36 | // Core | 37 | // Core |
| 37 | INSERT(Settings, use_multi_core, "Multicore CPU Emulation", ""); | 38 | INSERT(Settings, use_multi_core, "Multicore CPU Emulation", ""); |
| @@ -156,6 +157,7 @@ std::unique_ptr<TranslationMap> InitializeTranslations(QWidget* parent) { | |||
| 156 | INSERT(UISettings, select_user_on_boot, "Prompt for user on game boot", ""); | 157 | INSERT(UISettings, select_user_on_boot, "Prompt for user on game boot", ""); |
| 157 | INSERT(UISettings, pause_when_in_background, "Pause emulation when in background", ""); | 158 | INSERT(UISettings, pause_when_in_background, "Pause emulation when in background", ""); |
| 158 | INSERT(UISettings, confirm_before_closing, "Confirm exit while emulation is running", ""); | 159 | INSERT(UISettings, confirm_before_closing, "Confirm exit while emulation is running", ""); |
| 160 | INSERT(UISettings, confirm_before_stopping, "Confirm before stopping emulation", ""); | ||
| 159 | INSERT(UISettings, hide_mouse, "Hide mouse on inactivity", ""); | 161 | INSERT(UISettings, hide_mouse, "Hide mouse on inactivity", ""); |
| 160 | INSERT(UISettings, controller_applet_disabled, "Disable controller applet", ""); | 162 | INSERT(UISettings, controller_applet_disabled, "Disable controller applet", ""); |
| 161 | 163 | ||
| @@ -382,6 +384,13 @@ std::unique_ptr<ComboboxTranslationMap> ComboboxEnumeration(QWidget* parent) { | |||
| 382 | translations->insert( | 384 | translations->insert( |
| 383 | {Settings::EnumMetadata<Settings::ConsoleMode>::Index(), | 385 | {Settings::EnumMetadata<Settings::ConsoleMode>::Index(), |
| 384 | {PAIR(ConsoleMode, Docked, "Docked"), PAIR(ConsoleMode, Handheld, "Handheld")}}); | 386 | {PAIR(ConsoleMode, Docked, "Docked"), PAIR(ConsoleMode, Handheld, "Handheld")}}); |
| 387 | translations->insert( | ||
| 388 | {Settings::EnumMetadata<Settings::ConfirmStop>::Index(), | ||
| 389 | { | ||
| 390 | PAIR(ConfirmStop, Ask_Always, "Always ask (Default)"), | ||
| 391 | PAIR(ConfirmStop, Ask_Based_On_Game, "Only if game specifies not to stop"), | ||
| 392 | PAIR(ConfirmStop, Ask_Never, "Never ask"), | ||
| 393 | }}); | ||
| 385 | 394 | ||
| 386 | #undef PAIR | 395 | #undef PAIR |
| 387 | #undef CTX_PAIR | 396 | #undef CTX_PAIR |
diff --git a/src/yuzu/debugger/wait_tree.cpp b/src/yuzu/debugger/wait_tree.cpp index 0783a2430..7049c57b6 100644 --- a/src/yuzu/debugger/wait_tree.cpp +++ b/src/yuzu/debugger/wait_tree.cpp | |||
| @@ -127,7 +127,7 @@ std::vector<std::unique_ptr<WaitTreeItem>> WaitTreeCallstack::GetChildren() cons | |||
| 127 | return list; | 127 | return list; |
| 128 | } | 128 | } |
| 129 | 129 | ||
| 130 | if (thread.GetOwnerProcess() == nullptr || !thread.GetOwnerProcess()->Is64BitProcess()) { | 130 | if (thread.GetOwnerProcess() == nullptr || !thread.GetOwnerProcess()->Is64Bit()) { |
| 131 | return list; | 131 | return list; |
| 132 | } | 132 | } |
| 133 | 133 | ||
diff --git a/src/yuzu/game_list.cpp b/src/yuzu/game_list.cpp index f254c1e1c..7e7d8e252 100644 --- a/src/yuzu/game_list.cpp +++ b/src/yuzu/game_list.cpp | |||
| @@ -312,8 +312,10 @@ void GameList::OnFilterCloseClicked() { | |||
| 312 | } | 312 | } |
| 313 | 313 | ||
| 314 | GameList::GameList(FileSys::VirtualFilesystem vfs_, FileSys::ManualContentProvider* provider_, | 314 | GameList::GameList(FileSys::VirtualFilesystem vfs_, FileSys::ManualContentProvider* provider_, |
| 315 | Core::System& system_, GMainWindow* parent) | 315 | PlayTime::PlayTimeManager& play_time_manager_, Core::System& system_, |
| 316 | : QWidget{parent}, vfs{std::move(vfs_)}, provider{provider_}, system{system_} { | 316 | GMainWindow* parent) |
| 317 | : QWidget{parent}, vfs{std::move(vfs_)}, provider{provider_}, | ||
| 318 | play_time_manager{play_time_manager_}, system{system_} { | ||
| 317 | watcher = new QFileSystemWatcher(this); | 319 | watcher = new QFileSystemWatcher(this); |
| 318 | connect(watcher, &QFileSystemWatcher::directoryChanged, this, &GameList::RefreshGameDirectory); | 320 | connect(watcher, &QFileSystemWatcher::directoryChanged, this, &GameList::RefreshGameDirectory); |
| 319 | 321 | ||
| @@ -340,6 +342,7 @@ GameList::GameList(FileSys::VirtualFilesystem vfs_, FileSys::ManualContentProvid | |||
| 340 | 342 | ||
| 341 | tree_view->setColumnHidden(COLUMN_ADD_ONS, !UISettings::values.show_add_ons); | 343 | tree_view->setColumnHidden(COLUMN_ADD_ONS, !UISettings::values.show_add_ons); |
| 342 | tree_view->setColumnHidden(COLUMN_COMPATIBILITY, !UISettings::values.show_compat); | 344 | tree_view->setColumnHidden(COLUMN_COMPATIBILITY, !UISettings::values.show_compat); |
| 345 | tree_view->setColumnHidden(COLUMN_PLAY_TIME, !UISettings::values.show_play_time); | ||
| 343 | item_model->setSortRole(GameListItemPath::SortRole); | 346 | item_model->setSortRole(GameListItemPath::SortRole); |
| 344 | 347 | ||
| 345 | connect(main_window, &GMainWindow::UpdateThemedIcons, this, &GameList::OnUpdateThemedIcons); | 348 | connect(main_window, &GMainWindow::UpdateThemedIcons, this, &GameList::OnUpdateThemedIcons); |
| @@ -377,7 +380,6 @@ void GameList::UnloadController() { | |||
| 377 | 380 | ||
| 378 | GameList::~GameList() { | 381 | GameList::~GameList() { |
| 379 | UnloadController(); | 382 | UnloadController(); |
| 380 | emit ShouldCancelWorker(); | ||
| 381 | } | 383 | } |
| 382 | 384 | ||
| 383 | void GameList::SetFilterFocus() { | 385 | void GameList::SetFilterFocus() { |
| @@ -394,6 +396,10 @@ void GameList::ClearFilter() { | |||
| 394 | search_field->clear(); | 396 | search_field->clear(); |
| 395 | } | 397 | } |
| 396 | 398 | ||
| 399 | void GameList::WorkerEvent() { | ||
| 400 | current_worker->ProcessEvents(this); | ||
| 401 | } | ||
| 402 | |||
| 397 | void GameList::AddDirEntry(GameListDir* entry_items) { | 403 | void GameList::AddDirEntry(GameListDir* entry_items) { |
| 398 | item_model->invisibleRootItem()->appendRow(entry_items); | 404 | item_model->invisibleRootItem()->appendRow(entry_items); |
| 399 | tree_view->setExpanded( | 405 | tree_view->setExpanded( |
| @@ -548,6 +554,7 @@ void GameList::AddGamePopup(QMenu& context_menu, u64 program_id, const std::stri | |||
| 548 | QAction* remove_update = remove_menu->addAction(tr("Remove Installed Update")); | 554 | QAction* remove_update = remove_menu->addAction(tr("Remove Installed Update")); |
| 549 | QAction* remove_dlc = remove_menu->addAction(tr("Remove All Installed DLC")); | 555 | QAction* remove_dlc = remove_menu->addAction(tr("Remove All Installed DLC")); |
| 550 | QAction* remove_custom_config = remove_menu->addAction(tr("Remove Custom Configuration")); | 556 | QAction* remove_custom_config = remove_menu->addAction(tr("Remove Custom Configuration")); |
| 557 | QAction* remove_play_time_data = remove_menu->addAction(tr("Remove Play Time Data")); | ||
| 551 | QAction* remove_cache_storage = remove_menu->addAction(tr("Remove Cache Storage")); | 558 | QAction* remove_cache_storage = remove_menu->addAction(tr("Remove Cache Storage")); |
| 552 | QAction* remove_gl_shader_cache = remove_menu->addAction(tr("Remove OpenGL Pipeline Cache")); | 559 | QAction* remove_gl_shader_cache = remove_menu->addAction(tr("Remove OpenGL Pipeline Cache")); |
| 553 | QAction* remove_vk_shader_cache = remove_menu->addAction(tr("Remove Vulkan Pipeline Cache")); | 560 | QAction* remove_vk_shader_cache = remove_menu->addAction(tr("Remove Vulkan Pipeline Cache")); |
| @@ -560,9 +567,9 @@ void GameList::AddGamePopup(QMenu& context_menu, u64 program_id, const std::stri | |||
| 560 | QAction* verify_integrity = context_menu.addAction(tr("Verify Integrity")); | 567 | QAction* verify_integrity = context_menu.addAction(tr("Verify Integrity")); |
| 561 | QAction* copy_tid = context_menu.addAction(tr("Copy Title ID to Clipboard")); | 568 | QAction* copy_tid = context_menu.addAction(tr("Copy Title ID to Clipboard")); |
| 562 | QAction* navigate_to_gamedb_entry = context_menu.addAction(tr("Navigate to GameDB entry")); | 569 | QAction* navigate_to_gamedb_entry = context_menu.addAction(tr("Navigate to GameDB entry")); |
| 563 | #ifndef WIN32 | ||
| 564 | QMenu* shortcut_menu = context_menu.addMenu(tr("Create Shortcut")); | 570 | QMenu* shortcut_menu = context_menu.addMenu(tr("Create Shortcut")); |
| 565 | QAction* create_desktop_shortcut = shortcut_menu->addAction(tr("Add to Desktop")); | 571 | QAction* create_desktop_shortcut = shortcut_menu->addAction(tr("Add to Desktop")); |
| 572 | #ifndef WIN32 | ||
| 566 | QAction* create_applications_menu_shortcut = | 573 | QAction* create_applications_menu_shortcut = |
| 567 | shortcut_menu->addAction(tr("Add to Applications Menu")); | 574 | shortcut_menu->addAction(tr("Add to Applications Menu")); |
| 568 | #endif | 575 | #endif |
| @@ -622,6 +629,8 @@ void GameList::AddGamePopup(QMenu& context_menu, u64 program_id, const std::stri | |||
| 622 | connect(remove_custom_config, &QAction::triggered, [this, program_id, path]() { | 629 | connect(remove_custom_config, &QAction::triggered, [this, program_id, path]() { |
| 623 | emit RemoveFileRequested(program_id, GameListRemoveTarget::CustomConfiguration, path); | 630 | emit RemoveFileRequested(program_id, GameListRemoveTarget::CustomConfiguration, path); |
| 624 | }); | 631 | }); |
| 632 | connect(remove_play_time_data, &QAction::triggered, | ||
| 633 | [this, program_id]() { emit RemovePlayTimeRequested(program_id); }); | ||
| 625 | connect(remove_cache_storage, &QAction::triggered, [this, program_id, path] { | 634 | connect(remove_cache_storage, &QAction::triggered, [this, program_id, path] { |
| 626 | emit RemoveFileRequested(program_id, GameListRemoveTarget::CacheStorage, path); | 635 | emit RemoveFileRequested(program_id, GameListRemoveTarget::CacheStorage, path); |
| 627 | }); | 636 | }); |
| @@ -638,10 +647,10 @@ void GameList::AddGamePopup(QMenu& context_menu, u64 program_id, const std::stri | |||
| 638 | connect(navigate_to_gamedb_entry, &QAction::triggered, [this, program_id]() { | 647 | connect(navigate_to_gamedb_entry, &QAction::triggered, [this, program_id]() { |
| 639 | emit NavigateToGamedbEntryRequested(program_id, compatibility_list); | 648 | emit NavigateToGamedbEntryRequested(program_id, compatibility_list); |
| 640 | }); | 649 | }); |
| 641 | #ifndef WIN32 | ||
| 642 | connect(create_desktop_shortcut, &QAction::triggered, [this, program_id, path]() { | 650 | connect(create_desktop_shortcut, &QAction::triggered, [this, program_id, path]() { |
| 643 | emit CreateShortcut(program_id, path, GameListShortcutTarget::Desktop); | 651 | emit CreateShortcut(program_id, path, GameListShortcutTarget::Desktop); |
| 644 | }); | 652 | }); |
| 653 | #ifndef WIN32 | ||
| 645 | connect(create_applications_menu_shortcut, &QAction::triggered, [this, program_id, path]() { | 654 | connect(create_applications_menu_shortcut, &QAction::triggered, [this, program_id, path]() { |
| 646 | emit CreateShortcut(program_id, path, GameListShortcutTarget::Applications); | 655 | emit CreateShortcut(program_id, path, GameListShortcutTarget::Applications); |
| 647 | }); | 656 | }); |
| @@ -790,6 +799,7 @@ void GameList::RetranslateUI() { | |||
| 790 | item_model->setHeaderData(COLUMN_ADD_ONS, Qt::Horizontal, tr("Add-ons")); | 799 | item_model->setHeaderData(COLUMN_ADD_ONS, Qt::Horizontal, tr("Add-ons")); |
| 791 | item_model->setHeaderData(COLUMN_FILE_TYPE, Qt::Horizontal, tr("File type")); | 800 | item_model->setHeaderData(COLUMN_FILE_TYPE, Qt::Horizontal, tr("File type")); |
| 792 | item_model->setHeaderData(COLUMN_SIZE, Qt::Horizontal, tr("Size")); | 801 | item_model->setHeaderData(COLUMN_SIZE, Qt::Horizontal, tr("Size")); |
| 802 | item_model->setHeaderData(COLUMN_PLAY_TIME, Qt::Horizontal, tr("Play time")); | ||
| 793 | } | 803 | } |
| 794 | 804 | ||
| 795 | void GameListSearchField::changeEvent(QEvent* event) { | 805 | void GameListSearchField::changeEvent(QEvent* event) { |
| @@ -817,28 +827,23 @@ void GameList::PopulateAsync(QVector<UISettings::GameDir>& game_dirs) { | |||
| 817 | tree_view->setColumnHidden(COLUMN_COMPATIBILITY, !UISettings::values.show_compat); | 827 | tree_view->setColumnHidden(COLUMN_COMPATIBILITY, !UISettings::values.show_compat); |
| 818 | tree_view->setColumnHidden(COLUMN_FILE_TYPE, !UISettings::values.show_types); | 828 | tree_view->setColumnHidden(COLUMN_FILE_TYPE, !UISettings::values.show_types); |
| 819 | tree_view->setColumnHidden(COLUMN_SIZE, !UISettings::values.show_size); | 829 | tree_view->setColumnHidden(COLUMN_SIZE, !UISettings::values.show_size); |
| 830 | tree_view->setColumnHidden(COLUMN_PLAY_TIME, !UISettings::values.show_play_time); | ||
| 831 | |||
| 832 | // Cancel any existing worker. | ||
| 833 | current_worker.reset(); | ||
| 820 | 834 | ||
| 821 | // Delete any rows that might already exist if we're repopulating | 835 | // Delete any rows that might already exist if we're repopulating |
| 822 | item_model->removeRows(0, item_model->rowCount()); | 836 | item_model->removeRows(0, item_model->rowCount()); |
| 823 | search_field->clear(); | 837 | search_field->clear(); |
| 824 | 838 | ||
| 825 | emit ShouldCancelWorker(); | 839 | current_worker = std::make_unique<GameListWorker>(vfs, provider, game_dirs, compatibility_list, |
| 840 | play_time_manager, system); | ||
| 826 | 841 | ||
| 827 | GameListWorker* worker = | 842 | // Get events from the worker as data becomes available |
| 828 | new GameListWorker(vfs, provider, game_dirs, compatibility_list, system); | 843 | connect(current_worker.get(), &GameListWorker::DataAvailable, this, &GameList::WorkerEvent, |
| 829 | |||
| 830 | connect(worker, &GameListWorker::EntryReady, this, &GameList::AddEntry, Qt::QueuedConnection); | ||
| 831 | connect(worker, &GameListWorker::DirEntryReady, this, &GameList::AddDirEntry, | ||
| 832 | Qt::QueuedConnection); | ||
| 833 | connect(worker, &GameListWorker::Finished, this, &GameList::DonePopulating, | ||
| 834 | Qt::QueuedConnection); | 844 | Qt::QueuedConnection); |
| 835 | // Use DirectConnection here because worker->Cancel() is thread-safe and we want it to | ||
| 836 | // cancel without delay. | ||
| 837 | connect(this, &GameList::ShouldCancelWorker, worker, &GameListWorker::Cancel, | ||
| 838 | Qt::DirectConnection); | ||
| 839 | 845 | ||
| 840 | QThreadPool::globalInstance()->start(worker); | 846 | QThreadPool::globalInstance()->start(current_worker.get()); |
| 841 | current_worker = std::move(worker); | ||
| 842 | } | 847 | } |
| 843 | 848 | ||
| 844 | void GameList::SaveInterfaceLayout() { | 849 | void GameList::SaveInterfaceLayout() { |
diff --git a/src/yuzu/game_list.h b/src/yuzu/game_list.h index 1fcbbf0ba..563a3a35b 100644 --- a/src/yuzu/game_list.h +++ b/src/yuzu/game_list.h | |||
| @@ -18,6 +18,7 @@ | |||
| 18 | #include "core/core.h" | 18 | #include "core/core.h" |
| 19 | #include "uisettings.h" | 19 | #include "uisettings.h" |
| 20 | #include "yuzu/compatibility_list.h" | 20 | #include "yuzu/compatibility_list.h" |
| 21 | #include "yuzu/play_time_manager.h" | ||
| 21 | 22 | ||
| 22 | namespace Core { | 23 | namespace Core { |
| 23 | class System; | 24 | class System; |
| @@ -75,11 +76,13 @@ public: | |||
| 75 | COLUMN_ADD_ONS, | 76 | COLUMN_ADD_ONS, |
| 76 | COLUMN_FILE_TYPE, | 77 | COLUMN_FILE_TYPE, |
| 77 | COLUMN_SIZE, | 78 | COLUMN_SIZE, |
| 79 | COLUMN_PLAY_TIME, | ||
| 78 | COLUMN_COUNT, // Number of columns | 80 | COLUMN_COUNT, // Number of columns |
| 79 | }; | 81 | }; |
| 80 | 82 | ||
| 81 | explicit GameList(std::shared_ptr<FileSys::VfsFilesystem> vfs_, | 83 | explicit GameList(std::shared_ptr<FileSys::VfsFilesystem> vfs_, |
| 82 | FileSys::ManualContentProvider* provider_, Core::System& system_, | 84 | FileSys::ManualContentProvider* provider_, |
| 85 | PlayTime::PlayTimeManager& play_time_manager_, Core::System& system_, | ||
| 83 | GMainWindow* parent = nullptr); | 86 | GMainWindow* parent = nullptr); |
| 84 | ~GameList() override; | 87 | ~GameList() override; |
| 85 | 88 | ||
| @@ -106,13 +109,13 @@ signals: | |||
| 106 | void BootGame(const QString& game_path, u64 program_id, std::size_t program_index, | 109 | void BootGame(const QString& game_path, u64 program_id, std::size_t program_index, |
| 107 | StartGameType type, AmLaunchType launch_type); | 110 | StartGameType type, AmLaunchType launch_type); |
| 108 | void GameChosen(const QString& game_path, const u64 title_id = 0); | 111 | void GameChosen(const QString& game_path, const u64 title_id = 0); |
| 109 | void ShouldCancelWorker(); | ||
| 110 | void OpenFolderRequested(u64 program_id, GameListOpenTarget target, | 112 | void OpenFolderRequested(u64 program_id, GameListOpenTarget target, |
| 111 | const std::string& game_path); | 113 | const std::string& game_path); |
| 112 | void OpenTransferableShaderCacheRequested(u64 program_id); | 114 | void OpenTransferableShaderCacheRequested(u64 program_id); |
| 113 | void RemoveInstalledEntryRequested(u64 program_id, InstalledEntryType type); | 115 | void RemoveInstalledEntryRequested(u64 program_id, InstalledEntryType type); |
| 114 | void RemoveFileRequested(u64 program_id, GameListRemoveTarget target, | 116 | void RemoveFileRequested(u64 program_id, GameListRemoveTarget target, |
| 115 | const std::string& game_path); | 117 | const std::string& game_path); |
| 118 | void RemovePlayTimeRequested(u64 program_id); | ||
| 116 | void DumpRomFSRequested(u64 program_id, const std::string& game_path, DumpRomFSTarget target); | 119 | void DumpRomFSRequested(u64 program_id, const std::string& game_path, DumpRomFSTarget target); |
| 117 | void VerifyIntegrityRequested(const std::string& game_path); | 120 | void VerifyIntegrityRequested(const std::string& game_path); |
| 118 | void CopyTIDRequested(u64 program_id); | 121 | void CopyTIDRequested(u64 program_id); |
| @@ -134,11 +137,16 @@ private slots: | |||
| 134 | void OnUpdateThemedIcons(); | 137 | void OnUpdateThemedIcons(); |
| 135 | 138 | ||
| 136 | private: | 139 | private: |
| 140 | friend class GameListWorker; | ||
| 141 | void WorkerEvent(); | ||
| 142 | |||
| 137 | void AddDirEntry(GameListDir* entry_items); | 143 | void AddDirEntry(GameListDir* entry_items); |
| 138 | void AddEntry(const QList<QStandardItem*>& entry_items, GameListDir* parent); | 144 | void AddEntry(const QList<QStandardItem*>& entry_items, GameListDir* parent); |
| 139 | void ValidateEntry(const QModelIndex& item); | ||
| 140 | void DonePopulating(const QStringList& watch_list); | 145 | void DonePopulating(const QStringList& watch_list); |
| 141 | 146 | ||
| 147 | private: | ||
| 148 | void ValidateEntry(const QModelIndex& item); | ||
| 149 | |||
| 142 | void RefreshGameDirectory(); | 150 | void RefreshGameDirectory(); |
| 143 | 151 | ||
| 144 | void ToggleFavorite(u64 program_id); | 152 | void ToggleFavorite(u64 program_id); |
| @@ -161,13 +169,14 @@ private: | |||
| 161 | QVBoxLayout* layout = nullptr; | 169 | QVBoxLayout* layout = nullptr; |
| 162 | QTreeView* tree_view = nullptr; | 170 | QTreeView* tree_view = nullptr; |
| 163 | QStandardItemModel* item_model = nullptr; | 171 | QStandardItemModel* item_model = nullptr; |
| 164 | GameListWorker* current_worker = nullptr; | 172 | std::unique_ptr<GameListWorker> current_worker; |
| 165 | QFileSystemWatcher* watcher = nullptr; | 173 | QFileSystemWatcher* watcher = nullptr; |
| 166 | ControllerNavigation* controller_navigation = nullptr; | 174 | ControllerNavigation* controller_navigation = nullptr; |
| 167 | CompatibilityList compatibility_list; | 175 | CompatibilityList compatibility_list; |
| 168 | 176 | ||
| 169 | friend class GameListSearchField; | 177 | friend class GameListSearchField; |
| 170 | 178 | ||
| 179 | const PlayTime::PlayTimeManager& play_time_manager; | ||
| 171 | Core::System& system; | 180 | Core::System& system; |
| 172 | }; | 181 | }; |
| 173 | 182 | ||
diff --git a/src/yuzu/game_list_p.h b/src/yuzu/game_list_p.h index 1800f090f..86a0c41d9 100644 --- a/src/yuzu/game_list_p.h +++ b/src/yuzu/game_list_p.h | |||
| @@ -18,6 +18,7 @@ | |||
| 18 | #include "common/common_types.h" | 18 | #include "common/common_types.h" |
| 19 | #include "common/logging/log.h" | 19 | #include "common/logging/log.h" |
| 20 | #include "common/string_util.h" | 20 | #include "common/string_util.h" |
| 21 | #include "yuzu/play_time_manager.h" | ||
| 21 | #include "yuzu/uisettings.h" | 22 | #include "yuzu/uisettings.h" |
| 22 | #include "yuzu/util/util.h" | 23 | #include "yuzu/util/util.h" |
| 23 | 24 | ||
| @@ -221,6 +222,31 @@ public: | |||
| 221 | } | 222 | } |
| 222 | }; | 223 | }; |
| 223 | 224 | ||
| 225 | /** | ||
| 226 | * GameListItem for Play Time values. | ||
| 227 | * This object stores the play time of a game in seconds, and its readable | ||
| 228 | * representation in minutes/hours | ||
| 229 | */ | ||
| 230 | class GameListItemPlayTime : public GameListItem { | ||
| 231 | public: | ||
| 232 | static constexpr int PlayTimeRole = SortRole; | ||
| 233 | |||
| 234 | GameListItemPlayTime() = default; | ||
| 235 | explicit GameListItemPlayTime(const qulonglong time_seconds) { | ||
| 236 | setData(time_seconds, PlayTimeRole); | ||
| 237 | } | ||
| 238 | |||
| 239 | void setData(const QVariant& value, int role) override { | ||
| 240 | qulonglong time_seconds = value.toULongLong(); | ||
| 241 | GameListItem::setData(PlayTime::ReadablePlayTime(time_seconds), Qt::DisplayRole); | ||
| 242 | GameListItem::setData(value, PlayTimeRole); | ||
| 243 | } | ||
| 244 | |||
| 245 | bool operator<(const QStandardItem& other) const override { | ||
| 246 | return data(PlayTimeRole).toULongLong() < other.data(PlayTimeRole).toULongLong(); | ||
| 247 | } | ||
| 248 | }; | ||
| 249 | |||
| 224 | class GameListDir : public GameListItem { | 250 | class GameListDir : public GameListItem { |
| 225 | public: | 251 | public: |
| 226 | static constexpr int GameDirRole = Qt::UserRole + 2; | 252 | static constexpr int GameDirRole = Qt::UserRole + 2; |
diff --git a/src/yuzu/game_list_worker.cpp b/src/yuzu/game_list_worker.cpp index e7fb8a282..69be21027 100644 --- a/src/yuzu/game_list_worker.cpp +++ b/src/yuzu/game_list_worker.cpp | |||
| @@ -194,6 +194,7 @@ QList<QStandardItem*> MakeGameListEntry(const std::string& path, const std::stri | |||
| 194 | const std::size_t size, const std::vector<u8>& icon, | 194 | const std::size_t size, const std::vector<u8>& icon, |
| 195 | Loader::AppLoader& loader, u64 program_id, | 195 | Loader::AppLoader& loader, u64 program_id, |
| 196 | const CompatibilityList& compatibility_list, | 196 | const CompatibilityList& compatibility_list, |
| 197 | const PlayTime::PlayTimeManager& play_time_manager, | ||
| 197 | const FileSys::PatchManager& patch) { | 198 | const FileSys::PatchManager& patch) { |
| 198 | const auto it = FindMatchingCompatibilityEntry(compatibility_list, program_id); | 199 | const auto it = FindMatchingCompatibilityEntry(compatibility_list, program_id); |
| 199 | 200 | ||
| @@ -212,6 +213,7 @@ QList<QStandardItem*> MakeGameListEntry(const std::string& path, const std::stri | |||
| 212 | new GameListItemCompat(compatibility), | 213 | new GameListItemCompat(compatibility), |
| 213 | new GameListItem(file_type_string), | 214 | new GameListItem(file_type_string), |
| 214 | new GameListItemSize(size), | 215 | new GameListItemSize(size), |
| 216 | new GameListItemPlayTime(play_time_manager.GetPlayTime(program_id)), | ||
| 215 | }; | 217 | }; |
| 216 | 218 | ||
| 217 | const auto patch_versions = GetGameListCachedObject( | 219 | const auto patch_versions = GetGameListCachedObject( |
| @@ -227,11 +229,57 @@ QList<QStandardItem*> MakeGameListEntry(const std::string& path, const std::stri | |||
| 227 | GameListWorker::GameListWorker(FileSys::VirtualFilesystem vfs_, | 229 | GameListWorker::GameListWorker(FileSys::VirtualFilesystem vfs_, |
| 228 | FileSys::ManualContentProvider* provider_, | 230 | FileSys::ManualContentProvider* provider_, |
| 229 | QVector<UISettings::GameDir>& game_dirs_, | 231 | QVector<UISettings::GameDir>& game_dirs_, |
| 230 | const CompatibilityList& compatibility_list_, Core::System& system_) | 232 | const CompatibilityList& compatibility_list_, |
| 233 | const PlayTime::PlayTimeManager& play_time_manager_, | ||
| 234 | Core::System& system_) | ||
| 231 | : vfs{std::move(vfs_)}, provider{provider_}, game_dirs{game_dirs_}, | 235 | : vfs{std::move(vfs_)}, provider{provider_}, game_dirs{game_dirs_}, |
| 232 | compatibility_list{compatibility_list_}, system{system_} {} | 236 | compatibility_list{compatibility_list_}, play_time_manager{play_time_manager_}, system{ |
| 237 | system_} { | ||
| 238 | // We want the game list to manage our lifetime. | ||
| 239 | setAutoDelete(false); | ||
| 240 | } | ||
| 241 | |||
| 242 | GameListWorker::~GameListWorker() { | ||
| 243 | this->disconnect(); | ||
| 244 | stop_requested.store(true); | ||
| 245 | processing_completed.Wait(); | ||
| 246 | } | ||
| 233 | 247 | ||
| 234 | GameListWorker::~GameListWorker() = default; | 248 | void GameListWorker::ProcessEvents(GameList* game_list) { |
| 249 | while (true) { | ||
| 250 | std::function<void(GameList*)> func; | ||
| 251 | { | ||
| 252 | // Lock queue to protect concurrent modification. | ||
| 253 | std::scoped_lock lk(lock); | ||
| 254 | |||
| 255 | // If we can't pop a function, return. | ||
| 256 | if (queued_events.empty()) { | ||
| 257 | return; | ||
| 258 | } | ||
| 259 | |||
| 260 | // Pop a function. | ||
| 261 | func = std::move(queued_events.back()); | ||
| 262 | queued_events.pop_back(); | ||
| 263 | } | ||
| 264 | |||
| 265 | // Run the function. | ||
| 266 | func(game_list); | ||
| 267 | } | ||
| 268 | } | ||
| 269 | |||
| 270 | template <typename F> | ||
| 271 | void GameListWorker::RecordEvent(F&& func) { | ||
| 272 | { | ||
| 273 | // Lock queue to protect concurrent modification. | ||
| 274 | std::scoped_lock lk(lock); | ||
| 275 | |||
| 276 | // Add the function into the front of the queue. | ||
| 277 | queued_events.emplace_front(std::move(func)); | ||
| 278 | } | ||
| 279 | |||
| 280 | // Data now available. | ||
| 281 | emit DataAvailable(); | ||
| 282 | } | ||
| 235 | 283 | ||
| 236 | void GameListWorker::AddTitlesToGameList(GameListDir* parent_dir) { | 284 | void GameListWorker::AddTitlesToGameList(GameListDir* parent_dir) { |
| 237 | using namespace FileSys; | 285 | using namespace FileSys; |
| @@ -279,16 +327,16 @@ void GameListWorker::AddTitlesToGameList(GameListDir* parent_dir) { | |||
| 279 | GetMetadataFromControlNCA(patch, *control, icon, name); | 327 | GetMetadataFromControlNCA(patch, *control, icon, name); |
| 280 | } | 328 | } |
| 281 | 329 | ||
| 282 | emit EntryReady(MakeGameListEntry(file->GetFullPath(), name, file->GetSize(), icon, *loader, | 330 | auto entry = MakeGameListEntry(file->GetFullPath(), name, file->GetSize(), icon, *loader, |
| 283 | program_id, compatibility_list, patch), | 331 | program_id, compatibility_list, play_time_manager, patch); |
| 284 | parent_dir); | 332 | RecordEvent([=](GameList* game_list) { game_list->AddEntry(entry, parent_dir); }); |
| 285 | } | 333 | } |
| 286 | } | 334 | } |
| 287 | 335 | ||
| 288 | void GameListWorker::ScanFileSystem(ScanTarget target, const std::string& dir_path, bool deep_scan, | 336 | void GameListWorker::ScanFileSystem(ScanTarget target, const std::string& dir_path, bool deep_scan, |
| 289 | GameListDir* parent_dir) { | 337 | GameListDir* parent_dir) { |
| 290 | const auto callback = [this, target, parent_dir](const std::filesystem::path& path) -> bool { | 338 | const auto callback = [this, target, parent_dir](const std::filesystem::path& path) -> bool { |
| 291 | if (stop_processing) { | 339 | if (stop_requested) { |
| 292 | // Breaks the callback loop. | 340 | // Breaks the callback loop. |
| 293 | return false; | 341 | return false; |
| 294 | } | 342 | } |
| @@ -355,10 +403,12 @@ void GameListWorker::ScanFileSystem(ScanTarget target, const std::string& dir_pa | |||
| 355 | const FileSys::PatchManager patch{id, system.GetFileSystemController(), | 403 | const FileSys::PatchManager patch{id, system.GetFileSystemController(), |
| 356 | system.GetContentProvider()}; | 404 | system.GetContentProvider()}; |
| 357 | 405 | ||
| 358 | emit EntryReady(MakeGameListEntry(physical_name, name, | 406 | auto entry = MakeGameListEntry( |
| 359 | Common::FS::GetSize(physical_name), icon, | 407 | physical_name, name, Common::FS::GetSize(physical_name), icon, *loader, |
| 360 | *loader, id, compatibility_list, patch), | 408 | id, compatibility_list, play_time_manager, patch); |
| 361 | parent_dir); | 409 | |
| 410 | RecordEvent( | ||
| 411 | [=](GameList* game_list) { game_list->AddEntry(entry, parent_dir); }); | ||
| 362 | } | 412 | } |
| 363 | } else { | 413 | } else { |
| 364 | std::vector<u8> icon; | 414 | std::vector<u8> icon; |
| @@ -370,10 +420,12 @@ void GameListWorker::ScanFileSystem(ScanTarget target, const std::string& dir_pa | |||
| 370 | const FileSys::PatchManager patch{program_id, system.GetFileSystemController(), | 420 | const FileSys::PatchManager patch{program_id, system.GetFileSystemController(), |
| 371 | system.GetContentProvider()}; | 421 | system.GetContentProvider()}; |
| 372 | 422 | ||
| 373 | emit EntryReady( | 423 | auto entry = MakeGameListEntry( |
| 374 | MakeGameListEntry(physical_name, name, Common::FS::GetSize(physical_name), | 424 | physical_name, name, Common::FS::GetSize(physical_name), icon, *loader, |
| 375 | icon, *loader, program_id, compatibility_list, patch), | 425 | program_id, compatibility_list, play_time_manager, patch); |
| 376 | parent_dir); | 426 | |
| 427 | RecordEvent( | ||
| 428 | [=](GameList* game_list) { game_list->AddEntry(entry, parent_dir); }); | ||
| 377 | } | 429 | } |
| 378 | } | 430 | } |
| 379 | } else if (is_dir) { | 431 | } else if (is_dir) { |
| @@ -392,26 +444,34 @@ void GameListWorker::ScanFileSystem(ScanTarget target, const std::string& dir_pa | |||
| 392 | } | 444 | } |
| 393 | 445 | ||
| 394 | void GameListWorker::run() { | 446 | void GameListWorker::run() { |
| 395 | stop_processing = false; | 447 | watch_list.clear(); |
| 396 | provider->ClearAllEntries(); | 448 | provider->ClearAllEntries(); |
| 397 | 449 | ||
| 450 | const auto DirEntryReady = [&](GameListDir* game_list_dir) { | ||
| 451 | RecordEvent([=](GameList* game_list) { game_list->AddDirEntry(game_list_dir); }); | ||
| 452 | }; | ||
| 453 | |||
| 398 | for (UISettings::GameDir& game_dir : game_dirs) { | 454 | for (UISettings::GameDir& game_dir : game_dirs) { |
| 455 | if (stop_requested) { | ||
| 456 | break; | ||
| 457 | } | ||
| 458 | |||
| 399 | if (game_dir.path == QStringLiteral("SDMC")) { | 459 | if (game_dir.path == QStringLiteral("SDMC")) { |
| 400 | auto* const game_list_dir = new GameListDir(game_dir, GameListItemType::SdmcDir); | 460 | auto* const game_list_dir = new GameListDir(game_dir, GameListItemType::SdmcDir); |
| 401 | emit DirEntryReady(game_list_dir); | 461 | DirEntryReady(game_list_dir); |
| 402 | AddTitlesToGameList(game_list_dir); | 462 | AddTitlesToGameList(game_list_dir); |
| 403 | } else if (game_dir.path == QStringLiteral("UserNAND")) { | 463 | } else if (game_dir.path == QStringLiteral("UserNAND")) { |
| 404 | auto* const game_list_dir = new GameListDir(game_dir, GameListItemType::UserNandDir); | 464 | auto* const game_list_dir = new GameListDir(game_dir, GameListItemType::UserNandDir); |
| 405 | emit DirEntryReady(game_list_dir); | 465 | DirEntryReady(game_list_dir); |
| 406 | AddTitlesToGameList(game_list_dir); | 466 | AddTitlesToGameList(game_list_dir); |
| 407 | } else if (game_dir.path == QStringLiteral("SysNAND")) { | 467 | } else if (game_dir.path == QStringLiteral("SysNAND")) { |
| 408 | auto* const game_list_dir = new GameListDir(game_dir, GameListItemType::SysNandDir); | 468 | auto* const game_list_dir = new GameListDir(game_dir, GameListItemType::SysNandDir); |
| 409 | emit DirEntryReady(game_list_dir); | 469 | DirEntryReady(game_list_dir); |
| 410 | AddTitlesToGameList(game_list_dir); | 470 | AddTitlesToGameList(game_list_dir); |
| 411 | } else { | 471 | } else { |
| 412 | watch_list.append(game_dir.path); | 472 | watch_list.append(game_dir.path); |
| 413 | auto* const game_list_dir = new GameListDir(game_dir); | 473 | auto* const game_list_dir = new GameListDir(game_dir); |
| 414 | emit DirEntryReady(game_list_dir); | 474 | DirEntryReady(game_list_dir); |
| 415 | ScanFileSystem(ScanTarget::FillManualContentProvider, game_dir.path.toStdString(), | 475 | ScanFileSystem(ScanTarget::FillManualContentProvider, game_dir.path.toStdString(), |
| 416 | game_dir.deep_scan, game_list_dir); | 476 | game_dir.deep_scan, game_list_dir); |
| 417 | ScanFileSystem(ScanTarget::PopulateGameList, game_dir.path.toStdString(), | 477 | ScanFileSystem(ScanTarget::PopulateGameList, game_dir.path.toStdString(), |
| @@ -419,10 +479,6 @@ void GameListWorker::run() { | |||
| 419 | } | 479 | } |
| 420 | } | 480 | } |
| 421 | 481 | ||
| 422 | emit Finished(watch_list); | 482 | RecordEvent([=](GameList* game_list) { game_list->DonePopulating(watch_list); }); |
| 423 | } | 483 | processing_completed.Set(); |
| 424 | |||
| 425 | void GameListWorker::Cancel() { | ||
| 426 | this->disconnect(); | ||
| 427 | stop_processing = true; | ||
| 428 | } | 484 | } |
diff --git a/src/yuzu/game_list_worker.h b/src/yuzu/game_list_worker.h index 24a4e92c3..d5990fcde 100644 --- a/src/yuzu/game_list_worker.h +++ b/src/yuzu/game_list_worker.h | |||
| @@ -4,6 +4,7 @@ | |||
| 4 | #pragma once | 4 | #pragma once |
| 5 | 5 | ||
| 6 | #include <atomic> | 6 | #include <atomic> |
| 7 | #include <deque> | ||
| 7 | #include <memory> | 8 | #include <memory> |
| 8 | #include <string> | 9 | #include <string> |
| 9 | 10 | ||
| @@ -12,12 +13,15 @@ | |||
| 12 | #include <QRunnable> | 13 | #include <QRunnable> |
| 13 | #include <QString> | 14 | #include <QString> |
| 14 | 15 | ||
| 16 | #include "common/thread.h" | ||
| 15 | #include "yuzu/compatibility_list.h" | 17 | #include "yuzu/compatibility_list.h" |
| 18 | #include "yuzu/play_time_manager.h" | ||
| 16 | 19 | ||
| 17 | namespace Core { | 20 | namespace Core { |
| 18 | class System; | 21 | class System; |
| 19 | } | 22 | } |
| 20 | 23 | ||
| 24 | class GameList; | ||
| 21 | class QStandardItem; | 25 | class QStandardItem; |
| 22 | 26 | ||
| 23 | namespace FileSys { | 27 | namespace FileSys { |
| @@ -36,30 +40,30 @@ public: | |||
| 36 | explicit GameListWorker(std::shared_ptr<FileSys::VfsFilesystem> vfs_, | 40 | explicit GameListWorker(std::shared_ptr<FileSys::VfsFilesystem> vfs_, |
| 37 | FileSys::ManualContentProvider* provider_, | 41 | FileSys::ManualContentProvider* provider_, |
| 38 | QVector<UISettings::GameDir>& game_dirs_, | 42 | QVector<UISettings::GameDir>& game_dirs_, |
| 39 | const CompatibilityList& compatibility_list_, Core::System& system_); | 43 | const CompatibilityList& compatibility_list_, |
| 44 | const PlayTime::PlayTimeManager& play_time_manager_, | ||
| 45 | Core::System& system_); | ||
| 40 | ~GameListWorker() override; | 46 | ~GameListWorker() override; |
| 41 | 47 | ||
| 42 | /// Starts the processing of directory tree information. | 48 | /// Starts the processing of directory tree information. |
| 43 | void run() override; | 49 | void run() override; |
| 44 | 50 | ||
| 45 | /// Tells the worker that it should no longer continue processing. Thread-safe. | 51 | public: |
| 46 | void Cancel(); | ||
| 47 | |||
| 48 | signals: | ||
| 49 | /** | 52 | /** |
| 50 | * The `EntryReady` signal is emitted once an entry has been prepared and is ready | 53 | * Synchronously processes any events queued by the worker. |
| 51 | * to be added to the game list. | 54 | * |
| 52 | * @param entry_items a list with `QStandardItem`s that make up the columns of the new | 55 | * AddDirEntry is called on the game list for every discovered directory. |
| 53 | * entry. | 56 | * AddEntry is called on the game list for every discovered program. |
| 57 | * DonePopulating is called on the game list when processing completes. | ||
| 54 | */ | 58 | */ |
| 55 | void DirEntryReady(GameListDir* entry_items); | 59 | void ProcessEvents(GameList* game_list); |
| 56 | void EntryReady(QList<QStandardItem*> entry_items, GameListDir* parent_dir); | ||
| 57 | 60 | ||
| 58 | /** | 61 | signals: |
| 59 | * After the worker has traversed the game directory looking for entries, this signal is | 62 | void DataAvailable(); |
| 60 | * emitted with a list of folders that should be watched for changes as well. | 63 | |
| 61 | */ | 64 | private: |
| 62 | void Finished(QStringList watch_list); | 65 | template <typename F> |
| 66 | void RecordEvent(F&& func); | ||
| 63 | 67 | ||
| 64 | private: | 68 | private: |
| 65 | void AddTitlesToGameList(GameListDir* parent_dir); | 69 | void AddTitlesToGameList(GameListDir* parent_dir); |
| @@ -76,9 +80,15 @@ private: | |||
| 76 | FileSys::ManualContentProvider* provider; | 80 | FileSys::ManualContentProvider* provider; |
| 77 | QVector<UISettings::GameDir>& game_dirs; | 81 | QVector<UISettings::GameDir>& game_dirs; |
| 78 | const CompatibilityList& compatibility_list; | 82 | const CompatibilityList& compatibility_list; |
| 83 | const PlayTime::PlayTimeManager& play_time_manager; | ||
| 79 | 84 | ||
| 80 | QStringList watch_list; | 85 | QStringList watch_list; |
| 81 | std::atomic_bool stop_processing; | 86 | |
| 87 | std::mutex lock; | ||
| 88 | std::condition_variable cv; | ||
| 89 | std::deque<std::function<void(GameList*)>> queued_events; | ||
| 90 | std::atomic_bool stop_requested = false; | ||
| 91 | Common::Event processing_completed; | ||
| 82 | 92 | ||
| 83 | Core::System& system; | 93 | Core::System& system; |
| 84 | }; | 94 | }; |
diff --git a/src/yuzu/main.cpp b/src/yuzu/main.cpp index eb69da4ba..7cc11ae3b 100644 --- a/src/yuzu/main.cpp +++ b/src/yuzu/main.cpp | |||
| @@ -67,6 +67,7 @@ static FileSys::VirtualFile VfsDirectoryCreateFileWrapper(const FileSys::Virtual | |||
| 67 | #define QT_NO_OPENGL | 67 | #define QT_NO_OPENGL |
| 68 | #include <QClipboard> | 68 | #include <QClipboard> |
| 69 | #include <QDesktopServices> | 69 | #include <QDesktopServices> |
| 70 | #include <QDir> | ||
| 70 | #include <QFile> | 71 | #include <QFile> |
| 71 | #include <QFileDialog> | 72 | #include <QFileDialog> |
| 72 | #include <QInputDialog> | 73 | #include <QInputDialog> |
| @@ -76,6 +77,7 @@ static FileSys::VirtualFile VfsDirectoryCreateFileWrapper(const FileSys::Virtual | |||
| 76 | #include <QPushButton> | 77 | #include <QPushButton> |
| 77 | #include <QScreen> | 78 | #include <QScreen> |
| 78 | #include <QShortcut> | 79 | #include <QShortcut> |
| 80 | #include <QStandardPaths> | ||
| 79 | #include <QStatusBar> | 81 | #include <QStatusBar> |
| 80 | #include <QString> | 82 | #include <QString> |
| 81 | #include <QSysInfo> | 83 | #include <QSysInfo> |
| @@ -98,6 +100,7 @@ static FileSys::VirtualFile VfsDirectoryCreateFileWrapper(const FileSys::Virtual | |||
| 98 | #include "common/scm_rev.h" | 100 | #include "common/scm_rev.h" |
| 99 | #include "common/scope_exit.h" | 101 | #include "common/scope_exit.h" |
| 100 | #ifdef _WIN32 | 102 | #ifdef _WIN32 |
| 103 | #include <shlobj.h> | ||
| 101 | #include "common/windows/timer_resolution.h" | 104 | #include "common/windows/timer_resolution.h" |
| 102 | #endif | 105 | #endif |
| 103 | #ifdef ARCHITECTURE_x86_64 | 106 | #ifdef ARCHITECTURE_x86_64 |
| @@ -150,6 +153,7 @@ static FileSys::VirtualFile VfsDirectoryCreateFileWrapper(const FileSys::Virtual | |||
| 150 | #include "yuzu/install_dialog.h" | 153 | #include "yuzu/install_dialog.h" |
| 151 | #include "yuzu/loading_screen.h" | 154 | #include "yuzu/loading_screen.h" |
| 152 | #include "yuzu/main.h" | 155 | #include "yuzu/main.h" |
| 156 | #include "yuzu/play_time_manager.h" | ||
| 153 | #include "yuzu/startup_checks.h" | 157 | #include "yuzu/startup_checks.h" |
| 154 | #include "yuzu/uisettings.h" | 158 | #include "yuzu/uisettings.h" |
| 155 | #include "yuzu/util/clickable_label.h" | 159 | #include "yuzu/util/clickable_label.h" |
| @@ -207,7 +211,7 @@ void GMainWindow::ShowTelemetryCallout() { | |||
| 207 | tr("<a href='https://yuzu-emu.org/help/feature/telemetry/'>Anonymous " | 211 | tr("<a href='https://yuzu-emu.org/help/feature/telemetry/'>Anonymous " |
| 208 | "data is collected</a> to help improve yuzu. " | 212 | "data is collected</a> to help improve yuzu. " |
| 209 | "<br/><br/>Would you like to share your usage data with us?"); | 213 | "<br/><br/>Would you like to share your usage data with us?"); |
| 210 | if (QMessageBox::question(this, tr("Telemetry"), telemetry_message) != QMessageBox::Yes) { | 214 | if (!question(this, tr("Telemetry"), telemetry_message)) { |
| 211 | Settings::values.enable_telemetry = false; | 215 | Settings::values.enable_telemetry = false; |
| 212 | system->ApplySettings(); | 216 | system->ApplySettings(); |
| 213 | } | 217 | } |
| @@ -338,6 +342,8 @@ GMainWindow::GMainWindow(std::unique_ptr<Config> config_, bool has_broken_vulkan | |||
| 338 | SetDiscordEnabled(UISettings::values.enable_discord_presence.GetValue()); | 342 | SetDiscordEnabled(UISettings::values.enable_discord_presence.GetValue()); |
| 339 | discord_rpc->Update(); | 343 | discord_rpc->Update(); |
| 340 | 344 | ||
| 345 | play_time_manager = std::make_unique<PlayTime::PlayTimeManager>(); | ||
| 346 | |||
| 341 | system->GetRoomNetwork().Init(); | 347 | system->GetRoomNetwork().Init(); |
| 342 | 348 | ||
| 343 | RegisterMetaTypes(); | 349 | RegisterMetaTypes(); |
| @@ -986,7 +992,7 @@ void GMainWindow::InitializeWidgets() { | |||
| 986 | render_window = new GRenderWindow(this, emu_thread.get(), input_subsystem, *system); | 992 | render_window = new GRenderWindow(this, emu_thread.get(), input_subsystem, *system); |
| 987 | render_window->hide(); | 993 | render_window->hide(); |
| 988 | 994 | ||
| 989 | game_list = new GameList(vfs, provider.get(), *system, this); | 995 | game_list = new GameList(vfs, provider.get(), *play_time_manager, *system, this); |
| 990 | ui->horizontalLayout->addWidget(game_list); | 996 | ui->horizontalLayout->addWidget(game_list); |
| 991 | 997 | ||
| 992 | game_list_placeholder = new GameListPlaceholder(this); | 998 | game_list_placeholder = new GameListPlaceholder(this); |
| @@ -1447,6 +1453,7 @@ void GMainWindow::OnAppFocusStateChanged(Qt::ApplicationState state) { | |||
| 1447 | Settings::values.audio_muted = false; | 1453 | Settings::values.audio_muted = false; |
| 1448 | auto_muted = false; | 1454 | auto_muted = false; |
| 1449 | } | 1455 | } |
| 1456 | UpdateVolumeUI(); | ||
| 1450 | } | 1457 | } |
| 1451 | } | 1458 | } |
| 1452 | 1459 | ||
| @@ -1460,6 +1467,8 @@ void GMainWindow::ConnectWidgetEvents() { | |||
| 1460 | connect(game_list, &GameList::RemoveInstalledEntryRequested, this, | 1467 | connect(game_list, &GameList::RemoveInstalledEntryRequested, this, |
| 1461 | &GMainWindow::OnGameListRemoveInstalledEntry); | 1468 | &GMainWindow::OnGameListRemoveInstalledEntry); |
| 1462 | connect(game_list, &GameList::RemoveFileRequested, this, &GMainWindow::OnGameListRemoveFile); | 1469 | connect(game_list, &GameList::RemoveFileRequested, this, &GMainWindow::OnGameListRemoveFile); |
| 1470 | connect(game_list, &GameList::RemovePlayTimeRequested, this, | ||
| 1471 | &GMainWindow::OnGameListRemovePlayTimeData); | ||
| 1463 | connect(game_list, &GameList::DumpRomFSRequested, this, &GMainWindow::OnGameListDumpRomFS); | 1472 | connect(game_list, &GameList::DumpRomFSRequested, this, &GMainWindow::OnGameListDumpRomFS); |
| 1464 | connect(game_list, &GameList::VerifyIntegrityRequested, this, | 1473 | connect(game_list, &GameList::VerifyIntegrityRequested, this, |
| 1465 | &GMainWindow::OnGameListVerifyIntegrity); | 1474 | &GMainWindow::OnGameListVerifyIntegrity); |
| @@ -1553,6 +1562,7 @@ void GMainWindow::ConnectMenuEvents() { | |||
| 1553 | // Tools | 1562 | // Tools |
| 1554 | connect_menu(ui->action_Rederive, std::bind(&GMainWindow::OnReinitializeKeys, this, | 1563 | connect_menu(ui->action_Rederive, std::bind(&GMainWindow::OnReinitializeKeys, this, |
| 1555 | ReinitializeKeyBehavior::Warning)); | 1564 | ReinitializeKeyBehavior::Warning)); |
| 1565 | connect_menu(ui->action_Load_Album, &GMainWindow::OnAlbum); | ||
| 1556 | connect_menu(ui->action_Load_Cabinet_Nickname_Owner, | 1566 | connect_menu(ui->action_Load_Cabinet_Nickname_Owner, |
| 1557 | [this]() { OnCabinet(Service::NFP::CabinetMode::StartNicknameAndOwnerSettings); }); | 1567 | [this]() { OnCabinet(Service::NFP::CabinetMode::StartNicknameAndOwnerSettings); }); |
| 1558 | connect_menu(ui->action_Load_Cabinet_Eraser, | 1568 | connect_menu(ui->action_Load_Cabinet_Eraser, |
| @@ -1590,6 +1600,7 @@ void GMainWindow::UpdateMenuState() { | |||
| 1590 | }; | 1600 | }; |
| 1591 | 1601 | ||
| 1592 | const std::array applet_actions{ | 1602 | const std::array applet_actions{ |
| 1603 | ui->action_Load_Album, | ||
| 1593 | ui->action_Load_Cabinet_Nickname_Owner, | 1604 | ui->action_Load_Cabinet_Nickname_Owner, |
| 1594 | ui->action_Load_Cabinet_Eraser, | 1605 | ui->action_Load_Cabinet_Eraser, |
| 1595 | ui->action_Load_Cabinet_Restorer, | 1606 | ui->action_Load_Cabinet_Restorer, |
| @@ -2008,7 +2019,7 @@ void GMainWindow::BootGame(const QString& filename, u64 program_id, std::size_t | |||
| 2008 | std::filesystem::path{Common::U16StringFromBuffer(filename.utf16(), filename.size())} | 2019 | std::filesystem::path{Common::U16StringFromBuffer(filename.utf16(), filename.size())} |
| 2009 | .filename()); | 2020 | .filename()); |
| 2010 | } | 2021 | } |
| 2011 | const bool is_64bit = system->Kernel().ApplicationProcess()->Is64BitProcess(); | 2022 | const bool is_64bit = system->Kernel().ApplicationProcess()->Is64Bit(); |
| 2012 | const auto instruction_set_suffix = is_64bit ? tr("(64-bit)") : tr("(32-bit)"); | 2023 | const auto instruction_set_suffix = is_64bit ? tr("(64-bit)") : tr("(32-bit)"); |
| 2013 | title_name = tr("%1 %2", "%1 is the title name. %2 indicates if the title is 64-bit or 32-bit") | 2024 | title_name = tr("%1 %2", "%1 is the title name. %2 indicates if the title is 64-bit or 32-bit") |
| 2014 | .arg(QString::fromStdString(title_name), instruction_set_suffix) | 2025 | .arg(QString::fromStdString(title_name), instruction_set_suffix) |
| @@ -2409,9 +2420,8 @@ void GMainWindow::OnGameListRemoveInstalledEntry(u64 program_id, InstalledEntryT | |||
| 2409 | } | 2420 | } |
| 2410 | }(); | 2421 | }(); |
| 2411 | 2422 | ||
| 2412 | if (QMessageBox::question(this, tr("Remove Entry"), entry_question, | 2423 | if (!question(this, tr("Remove Entry"), entry_question, QMessageBox::Yes | QMessageBox::No, |
| 2413 | QMessageBox::Yes | QMessageBox::No, | 2424 | QMessageBox::No)) { |
| 2414 | QMessageBox::No) != QMessageBox::Yes) { | ||
| 2415 | return; | 2425 | return; |
| 2416 | } | 2426 | } |
| 2417 | 2427 | ||
| @@ -2510,8 +2520,8 @@ void GMainWindow::OnGameListRemoveFile(u64 program_id, GameListRemoveTarget targ | |||
| 2510 | } | 2520 | } |
| 2511 | }(); | 2521 | }(); |
| 2512 | 2522 | ||
| 2513 | if (QMessageBox::question(this, tr("Remove File"), question, QMessageBox::Yes | QMessageBox::No, | 2523 | if (!GMainWindow::question(this, tr("Remove File"), question, |
| 2514 | QMessageBox::No) != QMessageBox::Yes) { | 2524 | QMessageBox::Yes | QMessageBox::No, QMessageBox::No)) { |
| 2515 | return; | 2525 | return; |
| 2516 | } | 2526 | } |
| 2517 | 2527 | ||
| @@ -2534,6 +2544,17 @@ void GMainWindow::OnGameListRemoveFile(u64 program_id, GameListRemoveTarget targ | |||
| 2534 | } | 2544 | } |
| 2535 | } | 2545 | } |
| 2536 | 2546 | ||
| 2547 | void GMainWindow::OnGameListRemovePlayTimeData(u64 program_id) { | ||
| 2548 | if (QMessageBox::question(this, tr("Remove Play Time Data"), tr("Reset play time?"), | ||
| 2549 | QMessageBox::Yes | QMessageBox::No, | ||
| 2550 | QMessageBox::No) != QMessageBox::Yes) { | ||
| 2551 | return; | ||
| 2552 | } | ||
| 2553 | |||
| 2554 | play_time_manager->ResetProgramPlayTime(program_id); | ||
| 2555 | game_list->PopulateAsync(UISettings::values.game_dirs); | ||
| 2556 | } | ||
| 2557 | |||
| 2537 | void GMainWindow::RemoveTransferableShaderCache(u64 program_id, GameListRemoveTarget target) { | 2558 | void GMainWindow::RemoveTransferableShaderCache(u64 program_id, GameListRemoveTarget target) { |
| 2538 | const auto target_file_name = [target] { | 2559 | const auto target_file_name = [target] { |
| 2539 | switch (target) { | 2560 | switch (target) { |
| @@ -2825,7 +2846,6 @@ void GMainWindow::OnGameListCreateShortcut(u64 program_id, const std::string& ga | |||
| 2825 | const QStringList args = QApplication::arguments(); | 2846 | const QStringList args = QApplication::arguments(); |
| 2826 | std::filesystem::path yuzu_command = args[0].toStdString(); | 2847 | std::filesystem::path yuzu_command = args[0].toStdString(); |
| 2827 | 2848 | ||
| 2828 | #if defined(__linux__) || defined(__FreeBSD__) | ||
| 2829 | // If relative path, make it an absolute path | 2849 | // If relative path, make it an absolute path |
| 2830 | if (yuzu_command.c_str()[0] == '.') { | 2850 | if (yuzu_command.c_str()[0] == '.') { |
| 2831 | yuzu_command = Common::FS::GetCurrentDir() / yuzu_command; | 2851 | yuzu_command = Common::FS::GetCurrentDir() / yuzu_command; |
| @@ -2848,44 +2868,52 @@ void GMainWindow::OnGameListCreateShortcut(u64 program_id, const std::string& ga | |||
| 2848 | UISettings::values.shortcut_already_warned = true; | 2868 | UISettings::values.shortcut_already_warned = true; |
| 2849 | } | 2869 | } |
| 2850 | #endif // __linux__ | 2870 | #endif // __linux__ |
| 2851 | #endif // __linux__ || __FreeBSD__ | ||
| 2852 | 2871 | ||
| 2853 | std::filesystem::path target_directory{}; | 2872 | std::filesystem::path target_directory{}; |
| 2854 | // Determine target directory for shortcut | ||
| 2855 | #if defined(__linux__) || defined(__FreeBSD__) | ||
| 2856 | const char* home = std::getenv("HOME"); | ||
| 2857 | const std::filesystem::path home_path = (home == nullptr ? "~" : home); | ||
| 2858 | const char* xdg_data_home = std::getenv("XDG_DATA_HOME"); | ||
| 2859 | 2873 | ||
| 2860 | if (target == GameListShortcutTarget::Desktop) { | 2874 | switch (target) { |
| 2861 | target_directory = home_path / "Desktop"; | 2875 | case GameListShortcutTarget::Desktop: { |
| 2862 | if (!Common::FS::IsDir(target_directory)) { | 2876 | const QString desktop_path = |
| 2863 | QMessageBox::critical( | 2877 | QStandardPaths::writableLocation(QStandardPaths::DesktopLocation); |
| 2864 | this, tr("Create Shortcut"), | 2878 | target_directory = desktop_path.toUtf8().toStdString(); |
| 2865 | tr("Cannot create shortcut on desktop. Path \"%1\" does not exist.") | 2879 | break; |
| 2866 | .arg(QString::fromStdString(target_directory)), | 2880 | } |
| 2867 | QMessageBox::StandardButton::Ok); | 2881 | case GameListShortcutTarget::Applications: { |
| 2868 | return; | 2882 | const QString applications_path = |
| 2869 | } | 2883 | QStandardPaths::writableLocation(QStandardPaths::ApplicationsLocation); |
| 2870 | } else if (target == GameListShortcutTarget::Applications) { | 2884 | if (applications_path.isEmpty()) { |
| 2871 | target_directory = (xdg_data_home == nullptr ? home_path / ".local/share" : xdg_data_home) / | 2885 | const char* home = std::getenv("HOME"); |
| 2872 | "applications"; | 2886 | if (home != nullptr) { |
| 2873 | if (!Common::FS::CreateDirs(target_directory)) { | 2887 | target_directory = std::filesystem::path(home) / ".local/share/applications"; |
| 2874 | QMessageBox::critical(this, tr("Create Shortcut"), | 2888 | } |
| 2875 | tr("Cannot create shortcut in applications menu. Path \"%1\" " | 2889 | } else { |
| 2876 | "does not exist and cannot be created.") | 2890 | target_directory = applications_path.toUtf8().toStdString(); |
| 2877 | .arg(QString::fromStdString(target_directory)), | ||
| 2878 | QMessageBox::StandardButton::Ok); | ||
| 2879 | return; | ||
| 2880 | } | 2891 | } |
| 2892 | break; | ||
| 2893 | } | ||
| 2894 | default: | ||
| 2895 | return; | ||
| 2896 | } | ||
| 2897 | |||
| 2898 | const QDir dir(QString::fromStdString(target_directory.generic_string())); | ||
| 2899 | if (!dir.exists()) { | ||
| 2900 | QMessageBox::critical(this, tr("Create Shortcut"), | ||
| 2901 | tr("Cannot create shortcut. Path \"%1\" does not exist.") | ||
| 2902 | .arg(QString::fromStdString(target_directory.generic_string())), | ||
| 2903 | QMessageBox::StandardButton::Ok); | ||
| 2904 | return; | ||
| 2881 | } | 2905 | } |
| 2882 | #endif | ||
| 2883 | 2906 | ||
| 2884 | const std::string game_file_name = std::filesystem::path(game_path).filename().string(); | 2907 | const std::string game_file_name = std::filesystem::path(game_path).filename().string(); |
| 2885 | // Determine full paths for icon and shortcut | 2908 | // Determine full paths for icon and shortcut |
| 2886 | #if defined(__linux__) || defined(__FreeBSD__) | 2909 | #if defined(__linux__) || defined(__FreeBSD__) |
| 2910 | const char* home = std::getenv("HOME"); | ||
| 2911 | const std::filesystem::path home_path = (home == nullptr ? "~" : home); | ||
| 2912 | const char* xdg_data_home = std::getenv("XDG_DATA_HOME"); | ||
| 2913 | |||
| 2887 | std::filesystem::path system_icons_path = | 2914 | std::filesystem::path system_icons_path = |
| 2888 | (xdg_data_home == nullptr ? home_path / ".local/share/" : xdg_data_home) / | 2915 | (xdg_data_home == nullptr ? home_path / ".local/share/" |
| 2916 | : std::filesystem::path(xdg_data_home)) / | ||
| 2889 | "icons/hicolor/256x256"; | 2917 | "icons/hicolor/256x256"; |
| 2890 | if (!Common::FS::CreateDirs(system_icons_path)) { | 2918 | if (!Common::FS::CreateDirs(system_icons_path)) { |
| 2891 | QMessageBox::critical( | 2919 | QMessageBox::critical( |
| @@ -2901,9 +2929,14 @@ void GMainWindow::OnGameListCreateShortcut(u64 program_id, const std::string& ga | |||
| 2901 | const std::filesystem::path shortcut_path = | 2929 | const std::filesystem::path shortcut_path = |
| 2902 | target_directory / (program_id == 0 ? fmt::format("yuzu-{}.desktop", game_file_name) | 2930 | target_directory / (program_id == 0 ? fmt::format("yuzu-{}.desktop", game_file_name) |
| 2903 | : fmt::format("yuzu-{:016X}.desktop", program_id)); | 2931 | : fmt::format("yuzu-{:016X}.desktop", program_id)); |
| 2932 | #elif defined(WIN32) | ||
| 2933 | std::filesystem::path icons_path = | ||
| 2934 | Common::FS::GetYuzuPathString(Common::FS::YuzuPath::IconsDir); | ||
| 2935 | std::filesystem::path icon_path = | ||
| 2936 | icons_path / ((program_id == 0 ? fmt::format("yuzu-{}.ico", game_file_name) | ||
| 2937 | : fmt::format("yuzu-{:016X}.ico", program_id))); | ||
| 2904 | #else | 2938 | #else |
| 2905 | const std::filesystem::path icon_path{}; | 2939 | std::string icon_extension; |
| 2906 | const std::filesystem::path shortcut_path{}; | ||
| 2907 | #endif | 2940 | #endif |
| 2908 | 2941 | ||
| 2909 | // Get title from game file | 2942 | // Get title from game file |
| @@ -2928,29 +2961,37 @@ void GMainWindow::OnGameListCreateShortcut(u64 program_id, const std::string& ga | |||
| 2928 | LOG_WARNING(Frontend, "Could not read icon from {:s}", game_path); | 2961 | LOG_WARNING(Frontend, "Could not read icon from {:s}", game_path); |
| 2929 | } | 2962 | } |
| 2930 | 2963 | ||
| 2931 | QImage icon_jpeg = | 2964 | QImage icon_data = |
| 2932 | QImage::fromData(icon_image_file.data(), static_cast<int>(icon_image_file.size())); | 2965 | QImage::fromData(icon_image_file.data(), static_cast<int>(icon_image_file.size())); |
| 2933 | #if defined(__linux__) || defined(__FreeBSD__) | 2966 | #if defined(__linux__) || defined(__FreeBSD__) |
| 2934 | // Convert and write the icon as a PNG | 2967 | // Convert and write the icon as a PNG |
| 2935 | if (!icon_jpeg.save(QString::fromStdString(icon_path.string()))) { | 2968 | if (!icon_data.save(QString::fromStdString(icon_path.string()))) { |
| 2936 | LOG_ERROR(Frontend, "Could not write icon as PNG to file"); | 2969 | LOG_ERROR(Frontend, "Could not write icon as PNG to file"); |
| 2937 | } else { | 2970 | } else { |
| 2938 | LOG_INFO(Frontend, "Wrote an icon to {}", icon_path.string()); | 2971 | LOG_INFO(Frontend, "Wrote an icon to {}", icon_path.string()); |
| 2939 | } | 2972 | } |
| 2973 | #elif defined(WIN32) | ||
| 2974 | if (!SaveIconToFile(icon_path.string(), icon_data)) { | ||
| 2975 | LOG_ERROR(Frontend, "Could not write icon to file"); | ||
| 2976 | return; | ||
| 2977 | } | ||
| 2940 | #endif // __linux__ | 2978 | #endif // __linux__ |
| 2941 | 2979 | ||
| 2942 | #if defined(__linux__) || defined(__FreeBSD__) | 2980 | #ifdef _WIN32 |
| 2981 | // Replace characters that are illegal in Windows filenames by a dash | ||
| 2982 | const std::string illegal_chars = "<>:\"/\\|?*"; | ||
| 2983 | for (char c : illegal_chars) { | ||
| 2984 | std::replace(title.begin(), title.end(), c, '_'); | ||
| 2985 | } | ||
| 2986 | const std::filesystem::path shortcut_path = target_directory / (title + ".lnk").c_str(); | ||
| 2987 | #endif | ||
| 2988 | |||
| 2943 | const std::string comment = | 2989 | const std::string comment = |
| 2944 | tr("Start %1 with the yuzu Emulator").arg(QString::fromStdString(title)).toStdString(); | 2990 | tr("Start %1 with the yuzu Emulator").arg(QString::fromStdString(title)).toStdString(); |
| 2945 | const std::string arguments = fmt::format("-g \"{:s}\"", game_path); | 2991 | const std::string arguments = fmt::format("-g \"{:s}\"", game_path); |
| 2946 | const std::string categories = "Game;Emulator;Qt;"; | 2992 | const std::string categories = "Game;Emulator;Qt;"; |
| 2947 | const std::string keywords = "Switch;Nintendo;"; | 2993 | const std::string keywords = "Switch;Nintendo;"; |
| 2948 | #else | 2994 | |
| 2949 | const std::string comment{}; | ||
| 2950 | const std::string arguments{}; | ||
| 2951 | const std::string categories{}; | ||
| 2952 | const std::string keywords{}; | ||
| 2953 | #endif | ||
| 2954 | if (!CreateShortcut(shortcut_path.string(), title, comment, icon_path.string(), | 2995 | if (!CreateShortcut(shortcut_path.string(), title, comment, icon_path.string(), |
| 2955 | yuzu_command.string(), arguments, categories, keywords)) { | 2996 | yuzu_command.string(), arguments, categories, keywords)) { |
| 2956 | QMessageBox::critical(this, tr("Create Shortcut"), | 2997 | QMessageBox::critical(this, tr("Create Shortcut"), |
| @@ -3357,6 +3398,9 @@ void GMainWindow::OnStartGame() { | |||
| 3357 | UpdateMenuState(); | 3398 | UpdateMenuState(); |
| 3358 | OnTasStateChanged(); | 3399 | OnTasStateChanged(); |
| 3359 | 3400 | ||
| 3401 | play_time_manager->SetProgramId(system->GetApplicationProcessProgramID()); | ||
| 3402 | play_time_manager->Start(); | ||
| 3403 | |||
| 3360 | discord_rpc->Update(); | 3404 | discord_rpc->Update(); |
| 3361 | } | 3405 | } |
| 3362 | 3406 | ||
| @@ -3364,14 +3408,18 @@ void GMainWindow::OnRestartGame() { | |||
| 3364 | if (!system->IsPoweredOn()) { | 3408 | if (!system->IsPoweredOn()) { |
| 3365 | return; | 3409 | return; |
| 3366 | } | 3410 | } |
| 3367 | // Make a copy since ShutdownGame edits game_path | 3411 | |
| 3368 | const auto current_game = QString(current_game_path); | 3412 | if (ConfirmShutdownGame()) { |
| 3369 | ShutdownGame(); | 3413 | // Make a copy since ShutdownGame edits game_path |
| 3370 | BootGame(current_game); | 3414 | const auto current_game = QString(current_game_path); |
| 3415 | ShutdownGame(); | ||
| 3416 | BootGame(current_game); | ||
| 3417 | } | ||
| 3371 | } | 3418 | } |
| 3372 | 3419 | ||
| 3373 | void GMainWindow::OnPauseGame() { | 3420 | void GMainWindow::OnPauseGame() { |
| 3374 | emu_thread->SetRunning(false); | 3421 | emu_thread->SetRunning(false); |
| 3422 | play_time_manager->Stop(); | ||
| 3375 | UpdateMenuState(); | 3423 | UpdateMenuState(); |
| 3376 | AllowOSSleep(); | 3424 | AllowOSSleep(); |
| 3377 | } | 3425 | } |
| @@ -3388,15 +3436,39 @@ void GMainWindow::OnPauseContinueGame() { | |||
| 3388 | } | 3436 | } |
| 3389 | 3437 | ||
| 3390 | void GMainWindow::OnStopGame() { | 3438 | void GMainWindow::OnStopGame() { |
| 3391 | if (system->GetExitLocked() && !ConfirmForceLockedExit()) { | 3439 | if (ConfirmShutdownGame()) { |
| 3392 | return; | 3440 | play_time_manager->Stop(); |
| 3441 | // Update game list to show new play time | ||
| 3442 | game_list->PopulateAsync(UISettings::values.game_dirs); | ||
| 3443 | if (OnShutdownBegin()) { | ||
| 3444 | OnShutdownBeginDialog(); | ||
| 3445 | } else { | ||
| 3446 | OnEmulationStopped(); | ||
| 3447 | } | ||
| 3393 | } | 3448 | } |
| 3449 | } | ||
| 3394 | 3450 | ||
| 3395 | if (OnShutdownBegin()) { | 3451 | bool GMainWindow::ConfirmShutdownGame() { |
| 3396 | OnShutdownBeginDialog(); | 3452 | if (UISettings::values.confirm_before_stopping.GetValue() == ConfirmStop::Ask_Always) { |
| 3453 | if (system->GetExitLocked()) { | ||
| 3454 | if (!ConfirmForceLockedExit()) { | ||
| 3455 | return false; | ||
| 3456 | } | ||
| 3457 | } else { | ||
| 3458 | if (!ConfirmChangeGame()) { | ||
| 3459 | return false; | ||
| 3460 | } | ||
| 3461 | } | ||
| 3397 | } else { | 3462 | } else { |
| 3398 | OnEmulationStopped(); | 3463 | if (UISettings::values.confirm_before_stopping.GetValue() == |
| 3464 | ConfirmStop::Ask_Based_On_Game && | ||
| 3465 | system->GetExitLocked()) { | ||
| 3466 | if (!ConfirmForceLockedExit()) { | ||
| 3467 | return false; | ||
| 3468 | } | ||
| 3469 | } | ||
| 3399 | } | 3470 | } |
| 3471 | return true; | ||
| 3400 | } | 3472 | } |
| 3401 | 3473 | ||
| 3402 | void GMainWindow::OnLoadComplete() { | 3474 | void GMainWindow::OnLoadComplete() { |
| @@ -3776,22 +3848,11 @@ void GMainWindow::OnTasRecord() { | |||
| 3776 | const bool is_recording = input_subsystem->GetTas()->Record(); | 3848 | const bool is_recording = input_subsystem->GetTas()->Record(); |
| 3777 | if (!is_recording) { | 3849 | if (!is_recording) { |
| 3778 | is_tas_recording_dialog_active = true; | 3850 | is_tas_recording_dialog_active = true; |
| 3779 | ControllerNavigation* controller_navigation = | 3851 | |
| 3780 | new ControllerNavigation(system->HIDCore(), this); | 3852 | bool answer = question(this, tr("TAS Recording"), tr("Overwrite file of player 1?"), |
| 3781 | // Use QMessageBox instead of question so we can link controller navigation | 3853 | QMessageBox::Yes | QMessageBox::No, QMessageBox::Yes); |
| 3782 | QMessageBox* box_dialog = new QMessageBox(); | 3854 | |
| 3783 | box_dialog->setWindowTitle(tr("TAS Recording")); | 3855 | input_subsystem->GetTas()->SaveRecording(answer); |
| 3784 | box_dialog->setText(tr("Overwrite file of player 1?")); | ||
| 3785 | box_dialog->setStandardButtons(QMessageBox::Yes | QMessageBox::No); | ||
| 3786 | box_dialog->setDefaultButton(QMessageBox::Yes); | ||
| 3787 | connect(controller_navigation, &ControllerNavigation::TriggerKeyboardEvent, | ||
| 3788 | [box_dialog](Qt::Key key) { | ||
| 3789 | QKeyEvent* event = new QKeyEvent(QEvent::KeyPress, key, Qt::NoModifier); | ||
| 3790 | QCoreApplication::postEvent(box_dialog, event); | ||
| 3791 | }); | ||
| 3792 | int res = box_dialog->exec(); | ||
| 3793 | controller_navigation->UnloadController(); | ||
| 3794 | input_subsystem->GetTas()->SaveRecording(res == QMessageBox::Yes); | ||
| 3795 | is_tas_recording_dialog_active = false; | 3856 | is_tas_recording_dialog_active = false; |
| 3796 | } | 3857 | } |
| 3797 | OnTasStateChanged(); | 3858 | OnTasStateChanged(); |
| @@ -3965,6 +4026,34 @@ bool GMainWindow::CreateShortcut(const std::string& shortcut_path, const std::st | |||
| 3965 | shortcut_stream.close(); | 4026 | shortcut_stream.close(); |
| 3966 | 4027 | ||
| 3967 | return true; | 4028 | return true; |
| 4029 | #elif defined(WIN32) | ||
| 4030 | IShellLinkW* shell_link; | ||
| 4031 | auto hres = CoCreateInstance(CLSID_ShellLink, NULL, CLSCTX_INPROC_SERVER, IID_IShellLinkW, | ||
| 4032 | (void**)&shell_link); | ||
| 4033 | if (FAILED(hres)) { | ||
| 4034 | return false; | ||
| 4035 | } | ||
| 4036 | shell_link->SetPath( | ||
| 4037 | Common::UTF8ToUTF16W(command).data()); // Path to the object we are referring to | ||
| 4038 | shell_link->SetArguments(Common::UTF8ToUTF16W(arguments).data()); | ||
| 4039 | shell_link->SetDescription(Common::UTF8ToUTF16W(comment).data()); | ||
| 4040 | shell_link->SetIconLocation(Common::UTF8ToUTF16W(icon_path).data(), 0); | ||
| 4041 | |||
| 4042 | IPersistFile* persist_file; | ||
| 4043 | hres = shell_link->QueryInterface(IID_IPersistFile, (void**)&persist_file); | ||
| 4044 | if (FAILED(hres)) { | ||
| 4045 | return false; | ||
| 4046 | } | ||
| 4047 | |||
| 4048 | hres = persist_file->Save(Common::UTF8ToUTF16W(shortcut_path).data(), TRUE); | ||
| 4049 | if (FAILED(hres)) { | ||
| 4050 | return false; | ||
| 4051 | } | ||
| 4052 | |||
| 4053 | persist_file->Release(); | ||
| 4054 | shell_link->Release(); | ||
| 4055 | |||
| 4056 | return true; | ||
| 3968 | #endif | 4057 | #endif |
| 3969 | return false; | 4058 | return false; |
| 3970 | } | 4059 | } |
| @@ -4004,6 +4093,29 @@ void GMainWindow::OnLoadAmiibo() { | |||
| 4004 | LoadAmiibo(filename); | 4093 | LoadAmiibo(filename); |
| 4005 | } | 4094 | } |
| 4006 | 4095 | ||
| 4096 | bool GMainWindow::question(QWidget* parent, const QString& title, const QString& text, | ||
| 4097 | QMessageBox::StandardButtons buttons, | ||
| 4098 | QMessageBox::StandardButton defaultButton) { | ||
| 4099 | |||
| 4100 | QMessageBox* box_dialog = new QMessageBox(parent); | ||
| 4101 | box_dialog->setWindowTitle(title); | ||
| 4102 | box_dialog->setText(text); | ||
| 4103 | box_dialog->setStandardButtons(buttons); | ||
| 4104 | box_dialog->setDefaultButton(defaultButton); | ||
| 4105 | |||
| 4106 | ControllerNavigation* controller_navigation = | ||
| 4107 | new ControllerNavigation(system->HIDCore(), box_dialog); | ||
| 4108 | connect(controller_navigation, &ControllerNavigation::TriggerKeyboardEvent, | ||
| 4109 | [box_dialog](Qt::Key key) { | ||
| 4110 | QKeyEvent* event = new QKeyEvent(QEvent::KeyPress, key, Qt::NoModifier); | ||
| 4111 | QCoreApplication::postEvent(box_dialog, event); | ||
| 4112 | }); | ||
| 4113 | int res = box_dialog->exec(); | ||
| 4114 | |||
| 4115 | controller_navigation->UnloadController(); | ||
| 4116 | return res == QMessageBox::Yes; | ||
| 4117 | } | ||
| 4118 | |||
| 4007 | void GMainWindow::LoadAmiibo(const QString& filename) { | 4119 | void GMainWindow::LoadAmiibo(const QString& filename) { |
| 4008 | auto* virtual_amiibo = input_subsystem->GetVirtualAmiibo(); | 4120 | auto* virtual_amiibo = input_subsystem->GetVirtualAmiibo(); |
| 4009 | const QString title = tr("Error loading Amiibo data"); | 4121 | const QString title = tr("Error loading Amiibo data"); |
| @@ -4157,6 +4269,29 @@ void GMainWindow::OnToggleStatusBar() { | |||
| 4157 | statusBar()->setVisible(ui->action_Show_Status_Bar->isChecked()); | 4269 | statusBar()->setVisible(ui->action_Show_Status_Bar->isChecked()); |
| 4158 | } | 4270 | } |
| 4159 | 4271 | ||
| 4272 | void GMainWindow::OnAlbum() { | ||
| 4273 | constexpr u64 AlbumId = 0x010000000000100Dull; | ||
| 4274 | auto bis_system = system->GetFileSystemController().GetSystemNANDContents(); | ||
| 4275 | if (!bis_system) { | ||
| 4276 | QMessageBox::warning(this, tr("No firmware available"), | ||
| 4277 | tr("Please install the firmware to use the Album applet.")); | ||
| 4278 | return; | ||
| 4279 | } | ||
| 4280 | |||
| 4281 | auto album_nca = bis_system->GetEntry(AlbumId, FileSys::ContentRecordType::Program); | ||
| 4282 | if (!album_nca) { | ||
| 4283 | QMessageBox::warning(this, tr("Album Applet"), | ||
| 4284 | tr("Album applet is not available. Please reinstall firmware.")); | ||
| 4285 | return; | ||
| 4286 | } | ||
| 4287 | |||
| 4288 | system->GetAppletManager().SetCurrentAppletId(Service::AM::Applets::AppletId::PhotoViewer); | ||
| 4289 | |||
| 4290 | const auto filename = QString::fromStdString(album_nca->GetFullPath()); | ||
| 4291 | UISettings::values.roms_path = QFileInfo(filename).path(); | ||
| 4292 | BootGame(filename); | ||
| 4293 | } | ||
| 4294 | |||
| 4160 | void GMainWindow::OnCabinet(Service::NFP::CabinetMode mode) { | 4295 | void GMainWindow::OnCabinet(Service::NFP::CabinetMode mode) { |
| 4161 | constexpr u64 CabinetId = 0x0100000000001002ull; | 4296 | constexpr u64 CabinetId = 0x0100000000001002ull; |
| 4162 | auto bis_system = system->GetFileSystemController().GetSystemNANDContents(); | 4297 | auto bis_system = system->GetFileSystemController().GetSystemNANDContents(); |
| @@ -4714,8 +4849,7 @@ bool GMainWindow::ConfirmClose() { | |||
| 4714 | return true; | 4849 | return true; |
| 4715 | } | 4850 | } |
| 4716 | const auto text = tr("Are you sure you want to close yuzu?"); | 4851 | const auto text = tr("Are you sure you want to close yuzu?"); |
| 4717 | const auto answer = QMessageBox::question(this, tr("yuzu"), text); | 4852 | return question(this, tr("yuzu"), text); |
| 4718 | return answer != QMessageBox::No; | ||
| 4719 | } | 4853 | } |
| 4720 | 4854 | ||
| 4721 | void GMainWindow::closeEvent(QCloseEvent* event) { | 4855 | void GMainWindow::closeEvent(QCloseEvent* event) { |
| @@ -4808,11 +4942,11 @@ bool GMainWindow::ConfirmChangeGame() { | |||
| 4808 | if (emu_thread == nullptr) | 4942 | if (emu_thread == nullptr) |
| 4809 | return true; | 4943 | return true; |
| 4810 | 4944 | ||
| 4811 | const auto answer = QMessageBox::question( | 4945 | // Use custom question to link controller navigation |
| 4946 | return question( | ||
| 4812 | this, tr("yuzu"), | 4947 | this, tr("yuzu"), |
| 4813 | tr("Are you sure you want to stop the emulation? Any unsaved progress will be lost."), | 4948 | tr("Are you sure you want to stop the emulation? Any unsaved progress will be lost."), |
| 4814 | QMessageBox::Yes | QMessageBox::No, QMessageBox::No); | 4949 | QMessageBox::Yes | QMessageBox::No, QMessageBox::Yes); |
| 4815 | return answer != QMessageBox::No; | ||
| 4816 | } | 4950 | } |
| 4817 | 4951 | ||
| 4818 | bool GMainWindow::ConfirmForceLockedExit() { | 4952 | bool GMainWindow::ConfirmForceLockedExit() { |
| @@ -4822,8 +4956,7 @@ bool GMainWindow::ConfirmForceLockedExit() { | |||
| 4822 | const auto text = tr("The currently running application has requested yuzu to not exit.\n\n" | 4956 | const auto text = tr("The currently running application has requested yuzu to not exit.\n\n" |
| 4823 | "Would you like to bypass this and exit anyway?"); | 4957 | "Would you like to bypass this and exit anyway?"); |
| 4824 | 4958 | ||
| 4825 | const auto answer = QMessageBox::question(this, tr("yuzu"), text); | 4959 | return question(this, tr("yuzu"), text); |
| 4826 | return answer != QMessageBox::No; | ||
| 4827 | } | 4960 | } |
| 4828 | 4961 | ||
| 4829 | void GMainWindow::RequestGameExit() { | 4962 | void GMainWindow::RequestGameExit() { |
diff --git a/src/yuzu/main.h b/src/yuzu/main.h index 52028234c..270a40c5f 100644 --- a/src/yuzu/main.h +++ b/src/yuzu/main.h | |||
| @@ -7,6 +7,7 @@ | |||
| 7 | #include <optional> | 7 | #include <optional> |
| 8 | 8 | ||
| 9 | #include <QMainWindow> | 9 | #include <QMainWindow> |
| 10 | #include <QMessageBox> | ||
| 10 | #include <QTimer> | 11 | #include <QTimer> |
| 11 | #include <QTranslator> | 12 | #include <QTranslator> |
| 12 | 13 | ||
| @@ -15,6 +16,7 @@ | |||
| 15 | #include "input_common/drivers/tas_input.h" | 16 | #include "input_common/drivers/tas_input.h" |
| 16 | #include "yuzu/compatibility_list.h" | 17 | #include "yuzu/compatibility_list.h" |
| 17 | #include "yuzu/hotkeys.h" | 18 | #include "yuzu/hotkeys.h" |
| 19 | #include "yuzu/util/controller_navigation.h" | ||
| 18 | 20 | ||
| 19 | #ifdef __unix__ | 21 | #ifdef __unix__ |
| 20 | #include <QVariant> | 22 | #include <QVariant> |
| @@ -81,6 +83,10 @@ namespace DiscordRPC { | |||
| 81 | class DiscordInterface; | 83 | class DiscordInterface; |
| 82 | } | 84 | } |
| 83 | 85 | ||
| 86 | namespace PlayTime { | ||
| 87 | class PlayTimeManager; | ||
| 88 | } | ||
| 89 | |||
| 84 | namespace FileSys { | 90 | namespace FileSys { |
| 85 | class ContentProvider; | 91 | class ContentProvider; |
| 86 | class ManualContentProvider; | 92 | class ManualContentProvider; |
| @@ -323,6 +329,7 @@ private slots: | |||
| 323 | void OnGameListRemoveInstalledEntry(u64 program_id, InstalledEntryType type); | 329 | void OnGameListRemoveInstalledEntry(u64 program_id, InstalledEntryType type); |
| 324 | void OnGameListRemoveFile(u64 program_id, GameListRemoveTarget target, | 330 | void OnGameListRemoveFile(u64 program_id, GameListRemoveTarget target, |
| 325 | const std::string& game_path); | 331 | const std::string& game_path); |
| 332 | void OnGameListRemovePlayTimeData(u64 program_id); | ||
| 326 | void OnGameListDumpRomFS(u64 program_id, const std::string& game_path, DumpRomFSTarget target); | 333 | void OnGameListDumpRomFS(u64 program_id, const std::string& game_path, DumpRomFSTarget target); |
| 327 | void OnGameListVerifyIntegrity(const std::string& game_path); | 334 | void OnGameListVerifyIntegrity(const std::string& game_path); |
| 328 | void OnGameListCopyTID(u64 program_id); | 335 | void OnGameListCopyTID(u64 program_id); |
| @@ -369,6 +376,7 @@ private slots: | |||
| 369 | void ResetWindowSize720(); | 376 | void ResetWindowSize720(); |
| 370 | void ResetWindowSize900(); | 377 | void ResetWindowSize900(); |
| 371 | void ResetWindowSize1080(); | 378 | void ResetWindowSize1080(); |
| 379 | void OnAlbum(); | ||
| 372 | void OnCabinet(Service::NFP::CabinetMode mode); | 380 | void OnCabinet(Service::NFP::CabinetMode mode); |
| 373 | void OnMiiEdit(); | 381 | void OnMiiEdit(); |
| 374 | void OnCaptureScreenshot(); | 382 | void OnCaptureScreenshot(); |
| @@ -389,6 +397,7 @@ private: | |||
| 389 | void RemoveVulkanDriverPipelineCache(u64 program_id); | 397 | void RemoveVulkanDriverPipelineCache(u64 program_id); |
| 390 | void RemoveAllTransferableShaderCaches(u64 program_id); | 398 | void RemoveAllTransferableShaderCaches(u64 program_id); |
| 391 | void RemoveCustomConfiguration(u64 program_id, const std::string& game_path); | 399 | void RemoveCustomConfiguration(u64 program_id, const std::string& game_path); |
| 400 | void RemovePlayTimeData(u64 program_id); | ||
| 392 | void RemoveCacheStorage(u64 program_id); | 401 | void RemoveCacheStorage(u64 program_id); |
| 393 | bool SelectRomFSDumpTarget(const FileSys::ContentProvider&, u64 program_id, | 402 | bool SelectRomFSDumpTarget(const FileSys::ContentProvider&, u64 program_id, |
| 394 | u64* selected_title_id, u8* selected_content_record_type); | 403 | u64* selected_title_id, u8* selected_content_record_type); |
| @@ -417,6 +426,11 @@ private: | |||
| 417 | bool CheckSystemArchiveDecryption(); | 426 | bool CheckSystemArchiveDecryption(); |
| 418 | bool CheckFirmwarePresence(); | 427 | bool CheckFirmwarePresence(); |
| 419 | void ConfigureFilesystemProvider(const std::string& filepath); | 428 | void ConfigureFilesystemProvider(const std::string& filepath); |
| 429 | /** | ||
| 430 | * Open (or not) the right confirm dialog based on current setting and game exit lock | ||
| 431 | * @returns true if the player confirmed or the settings do no require it | ||
| 432 | */ | ||
| 433 | bool ConfirmShutdownGame(); | ||
| 420 | 434 | ||
| 421 | QString GetTasStateDescription() const; | 435 | QString GetTasStateDescription() const; |
| 422 | bool CreateShortcut(const std::string& shortcut_path, const std::string& title, | 436 | bool CreateShortcut(const std::string& shortcut_path, const std::string& title, |
| @@ -424,10 +438,22 @@ private: | |||
| 424 | const std::string& command, const std::string& arguments, | 438 | const std::string& command, const std::string& arguments, |
| 425 | const std::string& categories, const std::string& keywords); | 439 | const std::string& categories, const std::string& keywords); |
| 426 | 440 | ||
| 441 | /** | ||
| 442 | * Mimic the behavior of QMessageBox::question but link controller navigation to the dialog | ||
| 443 | * The only difference is that it returns a boolean. | ||
| 444 | * | ||
| 445 | * @returns true if buttons contains QMessageBox::Yes and the user clicks on the "Yes" button. | ||
| 446 | */ | ||
| 447 | bool question(QWidget* parent, const QString& title, const QString& text, | ||
| 448 | QMessageBox::StandardButtons buttons = | ||
| 449 | QMessageBox::StandardButtons(QMessageBox::Yes | QMessageBox::No), | ||
| 450 | QMessageBox::StandardButton defaultButton = QMessageBox::NoButton); | ||
| 451 | |||
| 427 | std::unique_ptr<Ui::MainWindow> ui; | 452 | std::unique_ptr<Ui::MainWindow> ui; |
| 428 | 453 | ||
| 429 | std::unique_ptr<Core::System> system; | 454 | std::unique_ptr<Core::System> system; |
| 430 | std::unique_ptr<DiscordRPC::DiscordInterface> discord_rpc; | 455 | std::unique_ptr<DiscordRPC::DiscordInterface> discord_rpc; |
| 456 | std::unique_ptr<PlayTime::PlayTimeManager> play_time_manager; | ||
| 431 | std::shared_ptr<InputCommon::InputSubsystem> input_subsystem; | 457 | std::shared_ptr<InputCommon::InputSubsystem> input_subsystem; |
| 432 | 458 | ||
| 433 | MultiplayerState* multiplayer_state = nullptr; | 459 | MultiplayerState* multiplayer_state = nullptr; |
diff --git a/src/yuzu/main.ui b/src/yuzu/main.ui index 31c3de9ef..88684ffb5 100644 --- a/src/yuzu/main.ui +++ b/src/yuzu/main.ui | |||
| @@ -160,6 +160,7 @@ | |||
| 160 | <addaction name="action_Verify_installed_contents"/> | 160 | <addaction name="action_Verify_installed_contents"/> |
| 161 | <addaction name="separator"/> | 161 | <addaction name="separator"/> |
| 162 | <addaction name="menu_cabinet_applet"/> | 162 | <addaction name="menu_cabinet_applet"/> |
| 163 | <addaction name="action_Load_Album"/> | ||
| 163 | <addaction name="action_Load_Mii_Edit"/> | 164 | <addaction name="action_Load_Mii_Edit"/> |
| 164 | <addaction name="separator"/> | 165 | <addaction name="separator"/> |
| 165 | <addaction name="action_Capture_Screenshot"/> | 166 | <addaction name="action_Capture_Screenshot"/> |
| @@ -380,6 +381,11 @@ | |||
| 380 | <string>&Capture Screenshot</string> | 381 | <string>&Capture Screenshot</string> |
| 381 | </property> | 382 | </property> |
| 382 | </action> | 383 | </action> |
| 384 | <action name="action_Load_Album"> | ||
| 385 | <property name="text"> | ||
| 386 | <string>Open &Album</string> | ||
| 387 | </property> | ||
| 388 | </action> | ||
| 383 | <action name="action_Load_Cabinet_Nickname_Owner"> | 389 | <action name="action_Load_Cabinet_Nickname_Owner"> |
| 384 | <property name="text"> | 390 | <property name="text"> |
| 385 | <string>&Set Nickname and Owner</string> | 391 | <string>&Set Nickname and Owner</string> |
diff --git a/src/yuzu/play_time_manager.cpp b/src/yuzu/play_time_manager.cpp new file mode 100644 index 000000000..155c36b7d --- /dev/null +++ b/src/yuzu/play_time_manager.cpp | |||
| @@ -0,0 +1,179 @@ | |||
| 1 | // SPDX-FileCopyrightText: 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #include "common/alignment.h" | ||
| 5 | #include "common/fs/file.h" | ||
| 6 | #include "common/fs/fs.h" | ||
| 7 | #include "common/fs/path_util.h" | ||
| 8 | #include "common/logging/log.h" | ||
| 9 | #include "common/settings.h" | ||
| 10 | #include "common/thread.h" | ||
| 11 | #include "core/hle/service/acc/profile_manager.h" | ||
| 12 | #include "yuzu/play_time_manager.h" | ||
| 13 | |||
| 14 | namespace PlayTime { | ||
| 15 | |||
| 16 | namespace { | ||
| 17 | |||
| 18 | struct PlayTimeElement { | ||
| 19 | ProgramId program_id; | ||
| 20 | PlayTime play_time; | ||
| 21 | }; | ||
| 22 | |||
| 23 | std::optional<std::filesystem::path> GetCurrentUserPlayTimePath() { | ||
| 24 | const Service::Account::ProfileManager manager; | ||
| 25 | const auto uuid = manager.GetUser(static_cast<s32>(Settings::values.current_user)); | ||
| 26 | if (!uuid.has_value()) { | ||
| 27 | return std::nullopt; | ||
| 28 | } | ||
| 29 | return Common::FS::GetYuzuPath(Common::FS::YuzuPath::PlayTimeDir) / | ||
| 30 | uuid->RawString().append(".bin"); | ||
| 31 | } | ||
| 32 | |||
| 33 | [[nodiscard]] bool ReadPlayTimeFile(PlayTimeDatabase& out_play_time_db) { | ||
| 34 | const auto filename = GetCurrentUserPlayTimePath(); | ||
| 35 | |||
| 36 | if (!filename.has_value()) { | ||
| 37 | LOG_ERROR(Frontend, "Failed to get current user path"); | ||
| 38 | return false; | ||
| 39 | } | ||
| 40 | |||
| 41 | out_play_time_db.clear(); | ||
| 42 | |||
| 43 | if (Common::FS::Exists(filename.value())) { | ||
| 44 | Common::FS::IOFile file{filename.value(), Common::FS::FileAccessMode::Read, | ||
| 45 | Common::FS::FileType::BinaryFile}; | ||
| 46 | if (!file.IsOpen()) { | ||
| 47 | LOG_ERROR(Frontend, "Failed to open play time file: {}", | ||
| 48 | Common::FS::PathToUTF8String(filename.value())); | ||
| 49 | return false; | ||
| 50 | } | ||
| 51 | |||
| 52 | const size_t num_elements = file.GetSize() / sizeof(PlayTimeElement); | ||
| 53 | std::vector<PlayTimeElement> elements(num_elements); | ||
| 54 | |||
| 55 | if (file.ReadSpan<PlayTimeElement>(elements) != num_elements) { | ||
| 56 | return false; | ||
| 57 | } | ||
| 58 | |||
| 59 | for (const auto& [program_id, play_time] : elements) { | ||
| 60 | if (program_id != 0) { | ||
| 61 | out_play_time_db[program_id] = play_time; | ||
| 62 | } | ||
| 63 | } | ||
| 64 | } | ||
| 65 | |||
| 66 | return true; | ||
| 67 | } | ||
| 68 | |||
| 69 | [[nodiscard]] bool WritePlayTimeFile(const PlayTimeDatabase& play_time_db) { | ||
| 70 | const auto filename = GetCurrentUserPlayTimePath(); | ||
| 71 | |||
| 72 | if (!filename.has_value()) { | ||
| 73 | LOG_ERROR(Frontend, "Failed to get current user path"); | ||
| 74 | return false; | ||
| 75 | } | ||
| 76 | |||
| 77 | Common::FS::IOFile file{filename.value(), Common::FS::FileAccessMode::Write, | ||
| 78 | Common::FS::FileType::BinaryFile}; | ||
| 79 | if (!file.IsOpen()) { | ||
| 80 | LOG_ERROR(Frontend, "Failed to open play time file: {}", | ||
| 81 | Common::FS::PathToUTF8String(filename.value())); | ||
| 82 | return false; | ||
| 83 | } | ||
| 84 | |||
| 85 | std::vector<PlayTimeElement> elements; | ||
| 86 | elements.reserve(play_time_db.size()); | ||
| 87 | |||
| 88 | for (auto& [program_id, play_time] : play_time_db) { | ||
| 89 | if (program_id != 0) { | ||
| 90 | elements.push_back(PlayTimeElement{program_id, play_time}); | ||
| 91 | } | ||
| 92 | } | ||
| 93 | |||
| 94 | return file.WriteSpan<PlayTimeElement>(elements) == elements.size(); | ||
| 95 | } | ||
| 96 | |||
| 97 | } // namespace | ||
| 98 | |||
| 99 | PlayTimeManager::PlayTimeManager() { | ||
| 100 | if (!ReadPlayTimeFile(database)) { | ||
| 101 | LOG_ERROR(Frontend, "Failed to read play time database! Resetting to default."); | ||
| 102 | } | ||
| 103 | } | ||
| 104 | |||
| 105 | PlayTimeManager::~PlayTimeManager() { | ||
| 106 | Save(); | ||
| 107 | } | ||
| 108 | |||
| 109 | void PlayTimeManager::SetProgramId(u64 program_id) { | ||
| 110 | running_program_id = program_id; | ||
| 111 | } | ||
| 112 | |||
| 113 | void PlayTimeManager::Start() { | ||
| 114 | play_time_thread = std::jthread([&](std::stop_token stop_token) { AutoTimestamp(stop_token); }); | ||
| 115 | } | ||
| 116 | |||
| 117 | void PlayTimeManager::Stop() { | ||
| 118 | play_time_thread = {}; | ||
| 119 | } | ||
| 120 | |||
| 121 | void PlayTimeManager::AutoTimestamp(std::stop_token stop_token) { | ||
| 122 | Common::SetCurrentThreadName("PlayTimeReport"); | ||
| 123 | |||
| 124 | using namespace std::literals::chrono_literals; | ||
| 125 | using std::chrono::seconds; | ||
| 126 | using std::chrono::steady_clock; | ||
| 127 | |||
| 128 | auto timestamp = steady_clock::now(); | ||
| 129 | |||
| 130 | const auto GetDuration = [&]() -> u64 { | ||
| 131 | const auto last_timestamp = std::exchange(timestamp, steady_clock::now()); | ||
| 132 | const auto duration = std::chrono::duration_cast<seconds>(timestamp - last_timestamp); | ||
| 133 | return static_cast<u64>(duration.count()); | ||
| 134 | }; | ||
| 135 | |||
| 136 | while (!stop_token.stop_requested()) { | ||
| 137 | Common::StoppableTimedWait(stop_token, 30s); | ||
| 138 | |||
| 139 | database[running_program_id] += GetDuration(); | ||
| 140 | Save(); | ||
| 141 | } | ||
| 142 | } | ||
| 143 | |||
| 144 | void PlayTimeManager::Save() { | ||
| 145 | if (!WritePlayTimeFile(database)) { | ||
| 146 | LOG_ERROR(Frontend, "Failed to update play time database!"); | ||
| 147 | } | ||
| 148 | } | ||
| 149 | |||
| 150 | u64 PlayTimeManager::GetPlayTime(u64 program_id) const { | ||
| 151 | auto it = database.find(program_id); | ||
| 152 | if (it != database.end()) { | ||
| 153 | return it->second; | ||
| 154 | } else { | ||
| 155 | return 0; | ||
| 156 | } | ||
| 157 | } | ||
| 158 | |||
| 159 | void PlayTimeManager::ResetProgramPlayTime(u64 program_id) { | ||
| 160 | database.erase(program_id); | ||
| 161 | Save(); | ||
| 162 | } | ||
| 163 | |||
| 164 | QString ReadablePlayTime(qulonglong time_seconds) { | ||
| 165 | if (time_seconds == 0) { | ||
| 166 | return {}; | ||
| 167 | } | ||
| 168 | const auto time_minutes = std::max(static_cast<double>(time_seconds) / 60, 1.0); | ||
| 169 | const auto time_hours = static_cast<double>(time_seconds) / 3600; | ||
| 170 | const bool is_minutes = time_minutes < 60; | ||
| 171 | const char* unit = is_minutes ? "m" : "h"; | ||
| 172 | const auto value = is_minutes ? time_minutes : time_hours; | ||
| 173 | |||
| 174 | return QStringLiteral("%L1 %2") | ||
| 175 | .arg(value, 0, 'f', !is_minutes && time_seconds % 60 != 0) | ||
| 176 | .arg(QString::fromUtf8(unit)); | ||
| 177 | } | ||
| 178 | |||
| 179 | } // namespace PlayTime | ||
diff --git a/src/yuzu/play_time_manager.h b/src/yuzu/play_time_manager.h new file mode 100644 index 000000000..5f96f3447 --- /dev/null +++ b/src/yuzu/play_time_manager.h | |||
| @@ -0,0 +1,44 @@ | |||
| 1 | // SPDX-FileCopyrightText: 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #pragma once | ||
| 5 | |||
| 6 | #include <QString> | ||
| 7 | |||
| 8 | #include <map> | ||
| 9 | |||
| 10 | #include "common/common_funcs.h" | ||
| 11 | #include "common/common_types.h" | ||
| 12 | #include "common/polyfill_thread.h" | ||
| 13 | |||
| 14 | namespace PlayTime { | ||
| 15 | |||
| 16 | using ProgramId = u64; | ||
| 17 | using PlayTime = u64; | ||
| 18 | using PlayTimeDatabase = std::map<ProgramId, PlayTime>; | ||
| 19 | |||
| 20 | class PlayTimeManager { | ||
| 21 | public: | ||
| 22 | explicit PlayTimeManager(); | ||
| 23 | ~PlayTimeManager(); | ||
| 24 | |||
| 25 | YUZU_NON_COPYABLE(PlayTimeManager); | ||
| 26 | YUZU_NON_MOVEABLE(PlayTimeManager); | ||
| 27 | |||
| 28 | u64 GetPlayTime(u64 program_id) const; | ||
| 29 | void ResetProgramPlayTime(u64 program_id); | ||
| 30 | void SetProgramId(u64 program_id); | ||
| 31 | void Start(); | ||
| 32 | void Stop(); | ||
| 33 | |||
| 34 | private: | ||
| 35 | PlayTimeDatabase database; | ||
| 36 | u64 running_program_id; | ||
| 37 | std::jthread play_time_thread; | ||
| 38 | void AutoTimestamp(std::stop_token stop_token); | ||
| 39 | void Save(); | ||
| 40 | }; | ||
| 41 | |||
| 42 | QString ReadablePlayTime(qulonglong time_seconds); | ||
| 43 | |||
| 44 | } // namespace PlayTime | ||
diff --git a/src/yuzu/uisettings.h b/src/yuzu/uisettings.h index 8efd63f31..b62ff620c 100644 --- a/src/yuzu/uisettings.h +++ b/src/yuzu/uisettings.h | |||
| @@ -16,7 +16,9 @@ | |||
| 16 | #include "common/settings_enums.h" | 16 | #include "common/settings_enums.h" |
| 17 | 17 | ||
| 18 | using Settings::Category; | 18 | using Settings::Category; |
| 19 | using Settings::ConfirmStop; | ||
| 19 | using Settings::Setting; | 20 | using Settings::Setting; |
| 21 | using Settings::SwitchableSetting; | ||
| 20 | 22 | ||
| 21 | #ifndef CANNOT_EXPLICITLY_INSTANTIATE | 23 | #ifndef CANNOT_EXPLICITLY_INSTANTIATE |
| 22 | namespace Settings { | 24 | namespace Settings { |
| @@ -94,6 +96,15 @@ struct Values { | |||
| 94 | Setting<bool> confirm_before_closing{ | 96 | Setting<bool> confirm_before_closing{ |
| 95 | linkage, true, "confirmClose", Category::UiGeneral, Settings::Specialization::Default, | 97 | linkage, true, "confirmClose", Category::UiGeneral, Settings::Specialization::Default, |
| 96 | true, true}; | 98 | true, true}; |
| 99 | |||
| 100 | SwitchableSetting<ConfirmStop> confirm_before_stopping{linkage, | ||
| 101 | ConfirmStop::Ask_Always, | ||
| 102 | "confirmStop", | ||
| 103 | Category::UiGeneral, | ||
| 104 | Settings::Specialization::Default, | ||
| 105 | true, | ||
| 106 | true}; | ||
| 107 | |||
| 97 | Setting<bool> first_start{linkage, true, "firstStart", Category::Ui}; | 108 | Setting<bool> first_start{linkage, true, "firstStart", Category::Ui}; |
| 98 | Setting<bool> pause_when_in_background{linkage, | 109 | Setting<bool> pause_when_in_background{linkage, |
| 99 | false, | 110 | false, |
| @@ -103,7 +114,7 @@ struct Values { | |||
| 103 | true, | 114 | true, |
| 104 | true}; | 115 | true}; |
| 105 | Setting<bool> mute_when_in_background{ | 116 | Setting<bool> mute_when_in_background{ |
| 106 | linkage, false, "muteWhenInBackground", Category::Ui, Settings::Specialization::Default, | 117 | linkage, false, "muteWhenInBackground", Category::Audio, Settings::Specialization::Default, |
| 107 | true, true}; | 118 | true, true}; |
| 108 | Setting<bool> hide_mouse{ | 119 | Setting<bool> hide_mouse{ |
| 109 | linkage, true, "hideInactiveMouse", Category::UiGeneral, Settings::Specialization::Default, | 120 | linkage, true, "hideInactiveMouse", Category::UiGeneral, Settings::Specialization::Default, |
| @@ -183,6 +194,9 @@ struct Values { | |||
| 183 | Setting<bool> show_size{linkage, true, "show_size", Category::UiGameList}; | 194 | Setting<bool> show_size{linkage, true, "show_size", Category::UiGameList}; |
| 184 | Setting<bool> show_types{linkage, true, "show_types", Category::UiGameList}; | 195 | Setting<bool> show_types{linkage, true, "show_types", Category::UiGameList}; |
| 185 | 196 | ||
| 197 | // Play time | ||
| 198 | Setting<bool> show_play_time{linkage, true, "show_play_time", Category::UiGameList}; | ||
| 199 | |||
| 186 | bool configuration_applied; | 200 | bool configuration_applied; |
| 187 | bool reset_to_defaults; | 201 | bool reset_to_defaults; |
| 188 | bool shortcut_already_warned{false}; | 202 | bool shortcut_already_warned{false}; |
diff --git a/src/yuzu/util/util.cpp b/src/yuzu/util/util.cpp index 5c3e4589e..f2854c8ec 100644 --- a/src/yuzu/util/util.cpp +++ b/src/yuzu/util/util.cpp | |||
| @@ -5,6 +5,10 @@ | |||
| 5 | #include <cmath> | 5 | #include <cmath> |
| 6 | #include <QPainter> | 6 | #include <QPainter> |
| 7 | #include "yuzu/util/util.h" | 7 | #include "yuzu/util/util.h" |
| 8 | #ifdef _WIN32 | ||
| 9 | #include <windows.h> | ||
| 10 | #include "common/fs/file.h" | ||
| 11 | #endif | ||
| 8 | 12 | ||
| 9 | QFont GetMonospaceFont() { | 13 | QFont GetMonospaceFont() { |
| 10 | QFont font(QStringLiteral("monospace")); | 14 | QFont font(QStringLiteral("monospace")); |
| @@ -37,3 +41,101 @@ QPixmap CreateCirclePixmapFromColor(const QColor& color) { | |||
| 37 | painter.drawEllipse({circle_pixmap.width() / 2.0, circle_pixmap.height() / 2.0}, 7.0, 7.0); | 41 | painter.drawEllipse({circle_pixmap.width() / 2.0, circle_pixmap.height() / 2.0}, 7.0, 7.0); |
| 38 | return circle_pixmap; | 42 | return circle_pixmap; |
| 39 | } | 43 | } |
| 44 | |||
| 45 | bool SaveIconToFile(const std::string_view path, const QImage& image) { | ||
| 46 | #if defined(WIN32) | ||
| 47 | #pragma pack(push, 2) | ||
| 48 | struct IconDir { | ||
| 49 | WORD id_reserved; | ||
| 50 | WORD id_type; | ||
| 51 | WORD id_count; | ||
| 52 | }; | ||
| 53 | |||
| 54 | struct IconDirEntry { | ||
| 55 | BYTE width; | ||
| 56 | BYTE height; | ||
| 57 | BYTE color_count; | ||
| 58 | BYTE reserved; | ||
| 59 | WORD planes; | ||
| 60 | WORD bit_count; | ||
| 61 | DWORD bytes_in_res; | ||
| 62 | DWORD image_offset; | ||
| 63 | }; | ||
| 64 | #pragma pack(pop) | ||
| 65 | |||
| 66 | const QImage source_image = image.convertToFormat(QImage::Format_RGB32); | ||
| 67 | constexpr std::array<int, 7> scale_sizes{256, 128, 64, 48, 32, 24, 16}; | ||
| 68 | constexpr int bytes_per_pixel = 4; | ||
| 69 | |||
| 70 | const IconDir icon_dir{ | ||
| 71 | .id_reserved = 0, | ||
| 72 | .id_type = 1, | ||
| 73 | .id_count = static_cast<WORD>(scale_sizes.size()), | ||
| 74 | }; | ||
| 75 | |||
| 76 | Common::FS::IOFile icon_file(path, Common::FS::FileAccessMode::Write, | ||
| 77 | Common::FS::FileType::BinaryFile); | ||
| 78 | if (!icon_file.IsOpen()) { | ||
| 79 | return false; | ||
| 80 | } | ||
| 81 | |||
| 82 | if (!icon_file.Write(icon_dir)) { | ||
| 83 | return false; | ||
| 84 | } | ||
| 85 | |||
| 86 | std::size_t image_offset = sizeof(IconDir) + (sizeof(IconDirEntry) * scale_sizes.size()); | ||
| 87 | for (std::size_t i = 0; i < scale_sizes.size(); i++) { | ||
| 88 | const int image_size = scale_sizes[i] * scale_sizes[i] * bytes_per_pixel; | ||
| 89 | const IconDirEntry icon_entry{ | ||
| 90 | .width = static_cast<BYTE>(scale_sizes[i]), | ||
| 91 | .height = static_cast<BYTE>(scale_sizes[i]), | ||
| 92 | .color_count = 0, | ||
| 93 | .reserved = 0, | ||
| 94 | .planes = 1, | ||
| 95 | .bit_count = bytes_per_pixel * 8, | ||
| 96 | .bytes_in_res = static_cast<DWORD>(sizeof(BITMAPINFOHEADER) + image_size), | ||
| 97 | .image_offset = static_cast<DWORD>(image_offset), | ||
| 98 | }; | ||
| 99 | image_offset += icon_entry.bytes_in_res; | ||
| 100 | if (!icon_file.Write(icon_entry)) { | ||
| 101 | return false; | ||
| 102 | } | ||
| 103 | } | ||
| 104 | |||
| 105 | for (std::size_t i = 0; i < scale_sizes.size(); i++) { | ||
| 106 | const QImage scaled_image = source_image.scaled( | ||
| 107 | scale_sizes[i], scale_sizes[i], Qt::IgnoreAspectRatio, Qt::SmoothTransformation); | ||
| 108 | const BITMAPINFOHEADER info_header{ | ||
| 109 | .biSize = sizeof(BITMAPINFOHEADER), | ||
| 110 | .biWidth = scaled_image.width(), | ||
| 111 | .biHeight = scaled_image.height() * 2, | ||
| 112 | .biPlanes = 1, | ||
| 113 | .biBitCount = bytes_per_pixel * 8, | ||
| 114 | .biCompression = BI_RGB, | ||
| 115 | .biSizeImage{}, | ||
| 116 | .biXPelsPerMeter{}, | ||
| 117 | .biYPelsPerMeter{}, | ||
| 118 | .biClrUsed{}, | ||
| 119 | .biClrImportant{}, | ||
| 120 | }; | ||
| 121 | |||
| 122 | if (!icon_file.Write(info_header)) { | ||
| 123 | return false; | ||
| 124 | } | ||
| 125 | |||
| 126 | for (int y = 0; y < scaled_image.height(); y++) { | ||
| 127 | const auto* line = scaled_image.scanLine(scaled_image.height() - 1 - y); | ||
| 128 | std::vector<u8> line_data(scaled_image.width() * bytes_per_pixel); | ||
| 129 | std::memcpy(line_data.data(), line, line_data.size()); | ||
| 130 | if (!icon_file.Write(line_data)) { | ||
| 131 | return false; | ||
| 132 | } | ||
| 133 | } | ||
| 134 | } | ||
| 135 | icon_file.Close(); | ||
| 136 | |||
| 137 | return true; | ||
| 138 | #else | ||
| 139 | return false; | ||
| 140 | #endif | ||
| 141 | } | ||
diff --git a/src/yuzu/util/util.h b/src/yuzu/util/util.h index 39dd2d895..09c14ce3f 100644 --- a/src/yuzu/util/util.h +++ b/src/yuzu/util/util.h | |||
| @@ -7,14 +7,22 @@ | |||
| 7 | #include <QString> | 7 | #include <QString> |
| 8 | 8 | ||
| 9 | /// Returns a QFont object appropriate to use as a monospace font for debugging widgets, etc. | 9 | /// Returns a QFont object appropriate to use as a monospace font for debugging widgets, etc. |
| 10 | QFont GetMonospaceFont(); | 10 | [[nodiscard]] QFont GetMonospaceFont(); |
| 11 | 11 | ||
| 12 | /// Convert a size in bytes into a readable format (KiB, MiB, etc.) | 12 | /// Convert a size in bytes into a readable format (KiB, MiB, etc.) |
| 13 | QString ReadableByteSize(qulonglong size); | 13 | [[nodiscard]] QString ReadableByteSize(qulonglong size); |
| 14 | 14 | ||
| 15 | /** | 15 | /** |
| 16 | * Creates a circle pixmap from a specified color | 16 | * Creates a circle pixmap from a specified color |
| 17 | * @param color The color the pixmap shall have | 17 | * @param color The color the pixmap shall have |
| 18 | * @return QPixmap circle pixmap | 18 | * @return QPixmap circle pixmap |
| 19 | */ | 19 | */ |
| 20 | QPixmap CreateCirclePixmapFromColor(const QColor& color); | 20 | [[nodiscard]] QPixmap CreateCirclePixmapFromColor(const QColor& color); |
| 21 | |||
| 22 | /** | ||
| 23 | * Saves a windows icon to a file | ||
| 24 | * @param path The icons path | ||
| 25 | * @param image The image to save | ||
| 26 | * @return bool If the operation succeeded | ||
| 27 | */ | ||
| 28 | [[nodiscard]] bool SaveIconToFile(const std::string_view path, const QImage& image); | ||