diff options
Diffstat (limited to 'src')
| -rw-r--r-- | src/core/arm/dynarmic/arm_dynarmic.cpp | 2 | ||||
| -rw-r--r-- | src/core/arm/unicorn/arm_unicorn.cpp | 2 | ||||
| -rw-r--r-- | src/core/core_timing.cpp | 15 | ||||
| -rw-r--r-- | src/core/core_timing.h | 2 | ||||
| -rw-r--r-- | src/core/cpu_core_manager.cpp | 4 |
5 files changed, 12 insertions, 13 deletions
diff --git a/src/core/arm/dynarmic/arm_dynarmic.cpp b/src/core/arm/dynarmic/arm_dynarmic.cpp index 4d2e99ed0..700c4afff 100644 --- a/src/core/arm/dynarmic/arm_dynarmic.cpp +++ b/src/core/arm/dynarmic/arm_dynarmic.cpp | |||
| @@ -116,7 +116,7 @@ public: | |||
| 116 | num_interpreted_instructions = 0; | 116 | num_interpreted_instructions = 0; |
| 117 | } | 117 | } |
| 118 | u64 GetTicksRemaining() override { | 118 | u64 GetTicksRemaining() override { |
| 119 | return std::max<s64>(parent.system.CoreTiming().GetDowncount(), 0LL); | 119 | return std::max(parent.system.CoreTiming().GetDowncount(), s64{0}); |
| 120 | } | 120 | } |
| 121 | u64 GetCNTPCT() override { | 121 | u64 GetCNTPCT() override { |
| 122 | return Timing::CpuCyclesToClockCycles(parent.system.CoreTiming().GetTicks()); | 122 | return Timing::CpuCyclesToClockCycles(parent.system.CoreTiming().GetTicks()); |
diff --git a/src/core/arm/unicorn/arm_unicorn.cpp b/src/core/arm/unicorn/arm_unicorn.cpp index 3f91b06d4..d4f41bfc1 100644 --- a/src/core/arm/unicorn/arm_unicorn.cpp +++ b/src/core/arm/unicorn/arm_unicorn.cpp | |||
| @@ -156,7 +156,7 @@ void ARM_Unicorn::Run() { | |||
| 156 | if (GDBStub::IsServerEnabled()) { | 156 | if (GDBStub::IsServerEnabled()) { |
| 157 | ExecuteInstructions(std::max(4000000, 0)); | 157 | ExecuteInstructions(std::max(4000000, 0)); |
| 158 | } else { | 158 | } else { |
| 159 | ExecuteInstructions(std::max<s64>(system.CoreTiming().GetDowncount(), 0LL)); | 159 | ExecuteInstructions(std::max(system.CoreTiming().GetDowncount(), s64{0})); |
| 160 | } | 160 | } |
| 161 | } | 161 | } |
| 162 | 162 | ||
diff --git a/src/core/core_timing.cpp b/src/core/core_timing.cpp index 3ca265b4f..780c6843a 100644 --- a/src/core/core_timing.cpp +++ b/src/core/core_timing.cpp | |||
| @@ -38,10 +38,8 @@ CoreTiming::CoreTiming() = default; | |||
| 38 | CoreTiming::~CoreTiming() = default; | 38 | CoreTiming::~CoreTiming() = default; |
| 39 | 39 | ||
| 40 | void CoreTiming::Initialize() { | 40 | void CoreTiming::Initialize() { |
| 41 | for (std::size_t core = 0; core < num_cpu_cores; core++) { | 41 | downcounts.fill(MAX_SLICE_LENGTH); |
| 42 | downcounts[core] = MAX_SLICE_LENGTH; | 42 | time_slice.fill(MAX_SLICE_LENGTH); |
| 43 | time_slice[core] = MAX_SLICE_LENGTH; | ||
| 44 | } | ||
| 45 | slice_length = MAX_SLICE_LENGTH; | 43 | slice_length = MAX_SLICE_LENGTH; |
| 46 | global_timer = 0; | 44 | global_timer = 0; |
| 47 | idled_cycles = 0; | 45 | idled_cycles = 0; |
| @@ -162,17 +160,17 @@ std::optional<u64> CoreTiming::NextAvailableCore(const s64 needed_ticks) const { | |||
| 162 | if (time_slice[next_context] >= needed_ticks) { | 160 | if (time_slice[next_context] >= needed_ticks) { |
| 163 | return {next_context}; | 161 | return {next_context}; |
| 164 | } else if (time_slice[next_context] >= 0) { | 162 | } else if (time_slice[next_context] >= 0) { |
| 165 | return {}; | 163 | return std::nullopt; |
| 166 | } | 164 | } |
| 167 | next_context = (next_context + 1) % num_cpu_cores; | 165 | next_context = (next_context + 1) % num_cpu_cores; |
| 168 | } | 166 | } |
| 169 | return {}; | 167 | return std::nullopt; |
| 170 | } | 168 | } |
| 171 | 169 | ||
| 172 | void CoreTiming::Advance() { | 170 | void CoreTiming::Advance() { |
| 173 | std::unique_lock<std::mutex> guard(inner_mutex); | 171 | std::unique_lock<std::mutex> guard(inner_mutex); |
| 174 | 172 | ||
| 175 | const int cycles_executed = accumulated_ticks; | 173 | const u64 cycles_executed = accumulated_ticks; |
| 176 | time_slice[current_context] = std::max<s64>(0, time_slice[current_context] - accumulated_ticks); | 174 | time_slice[current_context] = std::max<s64>(0, time_slice[current_context] - accumulated_ticks); |
| 177 | global_timer += cycles_executed; | 175 | global_timer += cycles_executed; |
| 178 | 176 | ||
| @@ -191,7 +189,8 @@ void CoreTiming::Advance() { | |||
| 191 | 189 | ||
| 192 | // Still events left (scheduled in the future) | 190 | // Still events left (scheduled in the future) |
| 193 | if (!event_queue.empty()) { | 191 | if (!event_queue.empty()) { |
| 194 | s64 needed_ticks = std::min<s64>(event_queue.front().time - global_timer, MAX_SLICE_LENGTH); | 192 | const s64 needed_ticks = |
| 193 | std::min<s64>(event_queue.front().time - global_timer, MAX_SLICE_LENGTH); | ||
| 195 | const auto next_core = NextAvailableCore(needed_ticks); | 194 | const auto next_core = NextAvailableCore(needed_ticks); |
| 196 | if (next_core) { | 195 | if (next_core) { |
| 197 | downcounts[*next_core] = needed_ticks; | 196 | downcounts[*next_core] = needed_ticks; |
diff --git a/src/core/core_timing.h b/src/core/core_timing.h index 8bba45beb..3bb88c810 100644 --- a/src/core/core_timing.h +++ b/src/core/core_timing.h | |||
| @@ -113,7 +113,7 @@ public: | |||
| 113 | current_context = new_context; | 113 | current_context = new_context; |
| 114 | } | 114 | } |
| 115 | 115 | ||
| 116 | bool CurrentContextCanRun() const { | 116 | bool CanCurrentContextRun() const { |
| 117 | return time_slice[current_context] > 0; | 117 | return time_slice[current_context] > 0; |
| 118 | } | 118 | } |
| 119 | 119 | ||
diff --git a/src/core/cpu_core_manager.cpp b/src/core/cpu_core_manager.cpp index e022e6a60..16b384076 100644 --- a/src/core/cpu_core_manager.cpp +++ b/src/core/cpu_core_manager.cpp | |||
| @@ -130,10 +130,10 @@ void CpuCoreManager::RunLoop(bool tight_loop) { | |||
| 130 | keep_running = false; | 130 | keep_running = false; |
| 131 | for (active_core = 0; active_core < NUM_CPU_CORES; ++active_core) { | 131 | for (active_core = 0; active_core < NUM_CPU_CORES; ++active_core) { |
| 132 | core_timing.SwitchContext(active_core); | 132 | core_timing.SwitchContext(active_core); |
| 133 | if (core_timing.CurrentContextCanRun()) { | 133 | if (core_timing.CanCurrentContextRun()) { |
| 134 | cores[active_core]->RunLoop(tight_loop); | 134 | cores[active_core]->RunLoop(tight_loop); |
| 135 | } | 135 | } |
| 136 | keep_running |= core_timing.CurrentContextCanRun(); | 136 | keep_running |= core_timing.CanCurrentContextRun(); |
| 137 | } | 137 | } |
| 138 | } while (keep_running); | 138 | } while (keep_running); |
| 139 | 139 | ||