summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/core/hle/service/service.cpp19
-rw-r--r--src/core/hle/service/sm/sm.cpp8
2 files changed, 8 insertions, 19 deletions
diff --git a/src/core/hle/service/service.cpp b/src/core/hle/service/service.cpp
index 1ec340466..d41df3732 100644
--- a/src/core/hle/service/service.cpp
+++ b/src/core/hle/service/service.cpp
@@ -70,10 +70,6 @@
70#include "core/hle/service/vi/vi.h" 70#include "core/hle/service/vi/vi.h"
71#include "core/hle/service/wlan/wlan.h" 71#include "core/hle/service/wlan/wlan.h"
72 72
73using Kernel::ClientPort;
74using Kernel::ServerPort;
75using Kernel::SharedPtr;
76
77namespace Service { 73namespace Service {
78 74
79/** 75/**
@@ -110,10 +106,8 @@ void ServiceFrameworkBase::InstallAsNamedPort() {
110 ASSERT(port == nullptr); 106 ASSERT(port == nullptr);
111 107
112 auto& kernel = Core::System::GetInstance().Kernel(); 108 auto& kernel = Core::System::GetInstance().Kernel();
113 SharedPtr<ServerPort> server_port; 109 auto [server_port, client_port] =
114 SharedPtr<ClientPort> client_port; 110 Kernel::ServerPort::CreatePortPair(kernel, max_sessions, service_name);
115 std::tie(server_port, client_port) =
116 ServerPort::CreatePortPair(kernel, max_sessions, service_name);
117 server_port->SetHleHandler(shared_from_this()); 111 server_port->SetHleHandler(shared_from_this());
118 kernel.AddNamedPort(service_name, std::move(client_port)); 112 kernel.AddNamedPort(service_name, std::move(client_port));
119} 113}
@@ -122,11 +116,9 @@ Kernel::SharedPtr<Kernel::ClientPort> ServiceFrameworkBase::CreatePort() {
122 ASSERT(port == nullptr); 116 ASSERT(port == nullptr);
123 117
124 auto& kernel = Core::System::GetInstance().Kernel(); 118 auto& kernel = Core::System::GetInstance().Kernel();
125 Kernel::SharedPtr<Kernel::ServerPort> server_port; 119 auto [server_port, client_port] =
126 Kernel::SharedPtr<Kernel::ClientPort> client_port;
127 std::tie(server_port, client_port) =
128 Kernel::ServerPort::CreatePortPair(kernel, max_sessions, service_name); 120 Kernel::ServerPort::CreatePortPair(kernel, max_sessions, service_name);
129 port = MakeResult<Kernel::SharedPtr<Kernel::ServerPort>>(std::move(server_port)).Unwrap(); 121 port = MakeResult(std::move(server_port)).Unwrap();
130 port->SetHleHandler(shared_from_this()); 122 port->SetHleHandler(shared_from_this());
131 return client_port; 123 return client_port;
132} 124}
@@ -152,8 +144,7 @@ void ServiceFrameworkBase::ReportUnimplementedFunction(Kernel::HLERequestContext
152 } 144 }
153 buf.push_back('}'); 145 buf.push_back('}');
154 146
155 LOG_ERROR(Service, "unknown / unimplemented {}", fmt::to_string(buf)); 147 UNIMPLEMENTED_MSG("Unknown / unimplemented {}", fmt::to_string(buf));
156 UNIMPLEMENTED();
157} 148}
158 149
159void ServiceFrameworkBase::InvokeRequest(Kernel::HLERequestContext& ctx) { 150void ServiceFrameworkBase::InvokeRequest(Kernel::HLERequestContext& ctx) {
diff --git a/src/core/hle/service/sm/sm.cpp b/src/core/hle/service/sm/sm.cpp
index 0d0f63a78..d73530086 100644
--- a/src/core/hle/service/sm/sm.cpp
+++ b/src/core/hle/service/sm/sm.cpp
@@ -54,13 +54,11 @@ ResultVal<Kernel::SharedPtr<Kernel::ServerPort>> ServiceManager::RegisterService
54 return ERR_ALREADY_REGISTERED; 54 return ERR_ALREADY_REGISTERED;
55 55
56 auto& kernel = Core::System::GetInstance().Kernel(); 56 auto& kernel = Core::System::GetInstance().Kernel();
57 Kernel::SharedPtr<Kernel::ServerPort> server_port; 57 auto [server_port, client_port] =
58 Kernel::SharedPtr<Kernel::ClientPort> client_port;
59 std::tie(server_port, client_port) =
60 Kernel::ServerPort::CreatePortPair(kernel, max_sessions, name); 58 Kernel::ServerPort::CreatePortPair(kernel, max_sessions, name);
61 59
62 registered_services.emplace(std::move(name), std::move(client_port)); 60 registered_services.emplace(std::move(name), std::move(client_port));
63 return MakeResult<Kernel::SharedPtr<Kernel::ServerPort>>(std::move(server_port)); 61 return MakeResult(std::move(server_port));
64} 62}
65 63
66ResultCode ServiceManager::UnregisterService(const std::string& name) { 64ResultCode ServiceManager::UnregisterService(const std::string& name) {
@@ -83,7 +81,7 @@ ResultVal<Kernel::SharedPtr<Kernel::ClientPort>> ServiceManager::GetServicePort(
83 return ERR_SERVICE_NOT_REGISTERED; 81 return ERR_SERVICE_NOT_REGISTERED;
84 } 82 }
85 83
86 return MakeResult<Kernel::SharedPtr<Kernel::ClientPort>>(it->second); 84 return MakeResult(it->second);
87} 85}
88 86
89ResultVal<Kernel::SharedPtr<Kernel::ClientSession>> ServiceManager::ConnectToService( 87ResultVal<Kernel::SharedPtr<Kernel::ClientSession>> ServiceManager::ConnectToService(