diff options
Diffstat (limited to 'src')
26 files changed, 187 insertions, 115 deletions
diff --git a/src/core/arm/dynarmic/arm_dynarmic.cpp b/src/core/arm/dynarmic/arm_dynarmic.cpp index 0762321a9..4d2491870 100644 --- a/src/core/arm/dynarmic/arm_dynarmic.cpp +++ b/src/core/arm/dynarmic/arm_dynarmic.cpp | |||
| @@ -144,7 +144,7 @@ std::unique_ptr<Dynarmic::A64::Jit> ARM_Dynarmic::MakeJit() const { | |||
| 144 | 144 | ||
| 145 | // Multi-process state | 145 | // Multi-process state |
| 146 | config.processor_id = core_index; | 146 | config.processor_id = core_index; |
| 147 | config.global_monitor = &exclusive_monitor->monitor; | 147 | config.global_monitor = &exclusive_monitor.monitor; |
| 148 | 148 | ||
| 149 | // System registers | 149 | // System registers |
| 150 | config.tpidrro_el0 = &cb->tpidrro_el0; | 150 | config.tpidrro_el0 = &cb->tpidrro_el0; |
| @@ -171,10 +171,9 @@ void ARM_Dynarmic::Step() { | |||
| 171 | cb->InterpreterFallback(jit->GetPC(), 1); | 171 | cb->InterpreterFallback(jit->GetPC(), 1); |
| 172 | } | 172 | } |
| 173 | 173 | ||
| 174 | ARM_Dynarmic::ARM_Dynarmic(std::shared_ptr<ExclusiveMonitor> exclusive_monitor, | 174 | ARM_Dynarmic::ARM_Dynarmic(ExclusiveMonitor& exclusive_monitor, std::size_t core_index) |
| 175 | std::size_t core_index) | ||
| 176 | : cb(std::make_unique<ARM_Dynarmic_Callbacks>(*this)), core_index{core_index}, | 175 | : cb(std::make_unique<ARM_Dynarmic_Callbacks>(*this)), core_index{core_index}, |
| 177 | exclusive_monitor{std::dynamic_pointer_cast<DynarmicExclusiveMonitor>(exclusive_monitor)} { | 176 | exclusive_monitor{dynamic_cast<DynarmicExclusiveMonitor&>(exclusive_monitor)} { |
| 178 | ThreadContext ctx{}; | 177 | ThreadContext ctx{}; |
| 179 | inner_unicorn.SaveContext(ctx); | 178 | inner_unicorn.SaveContext(ctx); |
| 180 | PageTableChanged(); | 179 | PageTableChanged(); |
diff --git a/src/core/arm/dynarmic/arm_dynarmic.h b/src/core/arm/dynarmic/arm_dynarmic.h index 4ee92ee27..512bf8ce9 100644 --- a/src/core/arm/dynarmic/arm_dynarmic.h +++ b/src/core/arm/dynarmic/arm_dynarmic.h | |||
| @@ -23,7 +23,7 @@ class DynarmicExclusiveMonitor; | |||
| 23 | 23 | ||
| 24 | class ARM_Dynarmic final : public ARM_Interface { | 24 | class ARM_Dynarmic final : public ARM_Interface { |
| 25 | public: | 25 | public: |
| 26 | ARM_Dynarmic(std::shared_ptr<ExclusiveMonitor> exclusive_monitor, std::size_t core_index); | 26 | ARM_Dynarmic(ExclusiveMonitor& exclusive_monitor, std::size_t core_index); |
| 27 | ~ARM_Dynarmic(); | 27 | ~ARM_Dynarmic(); |
| 28 | 28 | ||
| 29 | void MapBackingMemory(VAddr address, std::size_t size, u8* memory, | 29 | void MapBackingMemory(VAddr address, std::size_t size, u8* memory, |
| @@ -62,7 +62,7 @@ private: | |||
| 62 | ARM_Unicorn inner_unicorn; | 62 | ARM_Unicorn inner_unicorn; |
| 63 | 63 | ||
| 64 | std::size_t core_index; | 64 | std::size_t core_index; |
| 65 | std::shared_ptr<DynarmicExclusiveMonitor> exclusive_monitor; | 65 | DynarmicExclusiveMonitor& exclusive_monitor; |
| 66 | 66 | ||
| 67 | Memory::PageTable* current_page_table = nullptr; | 67 | Memory::PageTable* current_page_table = nullptr; |
| 68 | }; | 68 | }; |
diff --git a/src/core/core.cpp b/src/core/core.cpp index 32baa40dc..3c57a62ec 100644 --- a/src/core/core.cpp +++ b/src/core/core.cpp | |||
| @@ -71,9 +71,9 @@ FileSys::VirtualFile GetGameFileFromPath(const FileSys::VirtualFilesystem& vfs, | |||
| 71 | } | 71 | } |
| 72 | 72 | ||
| 73 | /// Runs a CPU core while the system is powered on | 73 | /// Runs a CPU core while the system is powered on |
| 74 | void RunCpuCore(std::shared_ptr<Cpu> cpu_state) { | 74 | void RunCpuCore(Cpu& cpu_state) { |
| 75 | while (Core::System::GetInstance().IsPoweredOn()) { | 75 | while (Core::System::GetInstance().IsPoweredOn()) { |
| 76 | cpu_state->RunLoop(true); | 76 | cpu_state.RunLoop(true); |
| 77 | } | 77 | } |
| 78 | } | 78 | } |
| 79 | } // Anonymous namespace | 79 | } // Anonymous namespace |
| @@ -95,7 +95,7 @@ struct System::Impl { | |||
| 95 | status = ResultStatus::Success; | 95 | status = ResultStatus::Success; |
| 96 | 96 | ||
| 97 | // Update thread_to_cpu in case Core 0 is run from a different host thread | 97 | // Update thread_to_cpu in case Core 0 is run from a different host thread |
| 98 | thread_to_cpu[std::this_thread::get_id()] = cpu_cores[0]; | 98 | thread_to_cpu[std::this_thread::get_id()] = cpu_cores[0].get(); |
| 99 | 99 | ||
| 100 | if (GDBStub::IsServerEnabled()) { | 100 | if (GDBStub::IsServerEnabled()) { |
| 101 | GDBStub::HandlePacket(); | 101 | GDBStub::HandlePacket(); |
| @@ -139,10 +139,10 @@ struct System::Impl { | |||
| 139 | auto main_process = Kernel::Process::Create(kernel, "main"); | 139 | auto main_process = Kernel::Process::Create(kernel, "main"); |
| 140 | kernel.MakeCurrentProcess(main_process.get()); | 140 | kernel.MakeCurrentProcess(main_process.get()); |
| 141 | 141 | ||
| 142 | cpu_barrier = std::make_shared<CpuBarrier>(); | 142 | cpu_barrier = std::make_unique<CpuBarrier>(); |
| 143 | cpu_exclusive_monitor = Cpu::MakeExclusiveMonitor(cpu_cores.size()); | 143 | cpu_exclusive_monitor = Cpu::MakeExclusiveMonitor(cpu_cores.size()); |
| 144 | for (std::size_t index = 0; index < cpu_cores.size(); ++index) { | 144 | for (std::size_t index = 0; index < cpu_cores.size(); ++index) { |
| 145 | cpu_cores[index] = std::make_shared<Cpu>(cpu_exclusive_monitor, cpu_barrier, index); | 145 | cpu_cores[index] = std::make_unique<Cpu>(*cpu_exclusive_monitor, *cpu_barrier, index); |
| 146 | } | 146 | } |
| 147 | 147 | ||
| 148 | telemetry_session = std::make_unique<Core::TelemetrySession>(); | 148 | telemetry_session = std::make_unique<Core::TelemetrySession>(); |
| @@ -160,12 +160,12 @@ struct System::Impl { | |||
| 160 | 160 | ||
| 161 | // Create threads for CPU cores 1-3, and build thread_to_cpu map | 161 | // Create threads for CPU cores 1-3, and build thread_to_cpu map |
| 162 | // CPU core 0 is run on the main thread | 162 | // CPU core 0 is run on the main thread |
| 163 | thread_to_cpu[std::this_thread::get_id()] = cpu_cores[0]; | 163 | thread_to_cpu[std::this_thread::get_id()] = cpu_cores[0].get(); |
| 164 | if (Settings::values.use_multi_core) { | 164 | if (Settings::values.use_multi_core) { |
| 165 | for (std::size_t index = 0; index < cpu_core_threads.size(); ++index) { | 165 | for (std::size_t index = 0; index < cpu_core_threads.size(); ++index) { |
| 166 | cpu_core_threads[index] = | 166 | cpu_core_threads[index] = |
| 167 | std::make_unique<std::thread>(RunCpuCore, cpu_cores[index + 1]); | 167 | std::make_unique<std::thread>(RunCpuCore, std::ref(*cpu_cores[index + 1])); |
| 168 | thread_to_cpu[cpu_core_threads[index]->get_id()] = cpu_cores[index + 1]; | 168 | thread_to_cpu[cpu_core_threads[index]->get_id()] = cpu_cores[index + 1].get(); |
| 169 | } | 169 | } |
| 170 | } | 170 | } |
| 171 | 171 | ||
| @@ -245,6 +245,7 @@ struct System::Impl { | |||
| 245 | for (auto& cpu_core : cpu_cores) { | 245 | for (auto& cpu_core : cpu_cores) { |
| 246 | cpu_core.reset(); | 246 | cpu_core.reset(); |
| 247 | } | 247 | } |
| 248 | cpu_exclusive_monitor.reset(); | ||
| 248 | cpu_barrier.reset(); | 249 | cpu_barrier.reset(); |
| 249 | 250 | ||
| 250 | // Shutdown kernel and core timing | 251 | // Shutdown kernel and core timing |
| @@ -282,9 +283,9 @@ struct System::Impl { | |||
| 282 | std::unique_ptr<VideoCore::RendererBase> renderer; | 283 | std::unique_ptr<VideoCore::RendererBase> renderer; |
| 283 | std::unique_ptr<Tegra::GPU> gpu_core; | 284 | std::unique_ptr<Tegra::GPU> gpu_core; |
| 284 | std::shared_ptr<Tegra::DebugContext> debug_context; | 285 | std::shared_ptr<Tegra::DebugContext> debug_context; |
| 285 | std::shared_ptr<ExclusiveMonitor> cpu_exclusive_monitor; | 286 | std::unique_ptr<ExclusiveMonitor> cpu_exclusive_monitor; |
| 286 | std::shared_ptr<CpuBarrier> cpu_barrier; | 287 | std::unique_ptr<CpuBarrier> cpu_barrier; |
| 287 | std::array<std::shared_ptr<Cpu>, NUM_CPU_CORES> cpu_cores; | 288 | std::array<std::unique_ptr<Cpu>, NUM_CPU_CORES> cpu_cores; |
| 288 | std::array<std::unique_ptr<std::thread>, NUM_CPU_CORES - 1> cpu_core_threads; | 289 | std::array<std::unique_ptr<std::thread>, NUM_CPU_CORES - 1> cpu_core_threads; |
| 289 | std::size_t active_core{}; ///< Active core, only used in single thread mode | 290 | std::size_t active_core{}; ///< Active core, only used in single thread mode |
| 290 | 291 | ||
| @@ -298,7 +299,7 @@ struct System::Impl { | |||
| 298 | std::string status_details = ""; | 299 | std::string status_details = ""; |
| 299 | 300 | ||
| 300 | /// Map of guest threads to CPU cores | 301 | /// Map of guest threads to CPU cores |
| 301 | std::map<std::thread::id, std::shared_ptr<Cpu>> thread_to_cpu; | 302 | std::map<std::thread::id, Cpu*> thread_to_cpu; |
| 302 | 303 | ||
| 303 | Core::PerfStats perf_stats; | 304 | Core::PerfStats perf_stats; |
| 304 | Core::FrameLimiter frame_limiter; | 305 | Core::FrameLimiter frame_limiter; |
| @@ -354,12 +355,15 @@ std::size_t System::CurrentCoreIndex() { | |||
| 354 | } | 355 | } |
| 355 | 356 | ||
| 356 | Kernel::Scheduler& System::CurrentScheduler() { | 357 | Kernel::Scheduler& System::CurrentScheduler() { |
| 357 | return *CurrentCpuCore().Scheduler(); | 358 | return CurrentCpuCore().Scheduler(); |
| 358 | } | 359 | } |
| 359 | 360 | ||
| 360 | const std::shared_ptr<Kernel::Scheduler>& System::Scheduler(std::size_t core_index) { | 361 | Kernel::Scheduler& System::Scheduler(std::size_t core_index) { |
| 361 | ASSERT(core_index < NUM_CPU_CORES); | 362 | return CpuCore(core_index).Scheduler(); |
| 362 | return impl->cpu_cores[core_index]->Scheduler(); | 363 | } |
| 364 | |||
| 365 | const Kernel::Scheduler& System::Scheduler(std::size_t core_index) const { | ||
| 366 | return CpuCore(core_index).Scheduler(); | ||
| 363 | } | 367 | } |
| 364 | 368 | ||
| 365 | Kernel::Process* System::CurrentProcess() { | 369 | Kernel::Process* System::CurrentProcess() { |
| @@ -380,6 +384,11 @@ Cpu& System::CpuCore(std::size_t core_index) { | |||
| 380 | return *impl->cpu_cores[core_index]; | 384 | return *impl->cpu_cores[core_index]; |
| 381 | } | 385 | } |
| 382 | 386 | ||
| 387 | const Cpu& System::CpuCore(std::size_t core_index) const { | ||
| 388 | ASSERT(core_index < NUM_CPU_CORES); | ||
| 389 | return *impl->cpu_cores[core_index]; | ||
| 390 | } | ||
| 391 | |||
| 383 | ExclusiveMonitor& System::Monitor() { | 392 | ExclusiveMonitor& System::Monitor() { |
| 384 | return *impl->cpu_exclusive_monitor; | 393 | return *impl->cpu_exclusive_monitor; |
| 385 | } | 394 | } |
diff --git a/src/core/core.h b/src/core/core.h index ea4d53914..173be45f8 100644 --- a/src/core/core.h +++ b/src/core/core.h | |||
| @@ -156,6 +156,9 @@ public: | |||
| 156 | /// Gets a CPU interface to the CPU core with the specified index | 156 | /// Gets a CPU interface to the CPU core with the specified index |
| 157 | Cpu& CpuCore(std::size_t core_index); | 157 | Cpu& CpuCore(std::size_t core_index); |
| 158 | 158 | ||
| 159 | /// Gets a CPU interface to the CPU core with the specified index | ||
| 160 | const Cpu& CpuCore(std::size_t core_index) const; | ||
| 161 | |||
| 159 | /// Gets the exclusive monitor | 162 | /// Gets the exclusive monitor |
| 160 | ExclusiveMonitor& Monitor(); | 163 | ExclusiveMonitor& Monitor(); |
| 161 | 164 | ||
| @@ -172,7 +175,10 @@ public: | |||
| 172 | const VideoCore::RendererBase& Renderer() const; | 175 | const VideoCore::RendererBase& Renderer() const; |
| 173 | 176 | ||
| 174 | /// Gets the scheduler for the CPU core with the specified index | 177 | /// Gets the scheduler for the CPU core with the specified index |
| 175 | const std::shared_ptr<Kernel::Scheduler>& Scheduler(std::size_t core_index); | 178 | Kernel::Scheduler& Scheduler(std::size_t core_index); |
| 179 | |||
| 180 | /// Gets the scheduler for the CPU core with the specified index | ||
| 181 | const Kernel::Scheduler& Scheduler(std::size_t core_index) const; | ||
| 176 | 182 | ||
| 177 | /// Provides a pointer to the current process | 183 | /// Provides a pointer to the current process |
| 178 | Kernel::Process* CurrentProcess(); | 184 | Kernel::Process* CurrentProcess(); |
diff --git a/src/core/core_cpu.cpp b/src/core/core_cpu.cpp index 265f8ed9c..fffda8a99 100644 --- a/src/core/core_cpu.cpp +++ b/src/core/core_cpu.cpp | |||
| @@ -49,10 +49,8 @@ bool CpuBarrier::Rendezvous() { | |||
| 49 | return false; | 49 | return false; |
| 50 | } | 50 | } |
| 51 | 51 | ||
| 52 | Cpu::Cpu(std::shared_ptr<ExclusiveMonitor> exclusive_monitor, | 52 | Cpu::Cpu(ExclusiveMonitor& exclusive_monitor, CpuBarrier& cpu_barrier, std::size_t core_index) |
| 53 | std::shared_ptr<CpuBarrier> cpu_barrier, std::size_t core_index) | 53 | : cpu_barrier{cpu_barrier}, core_index{core_index} { |
| 54 | : cpu_barrier{std::move(cpu_barrier)}, core_index{core_index} { | ||
| 55 | |||
| 56 | if (Settings::values.use_cpu_jit) { | 54 | if (Settings::values.use_cpu_jit) { |
| 57 | #ifdef ARCHITECTURE_x86_64 | 55 | #ifdef ARCHITECTURE_x86_64 |
| 58 | arm_interface = std::make_unique<ARM_Dynarmic>(exclusive_monitor, core_index); | 56 | arm_interface = std::make_unique<ARM_Dynarmic>(exclusive_monitor, core_index); |
| @@ -64,15 +62,15 @@ Cpu::Cpu(std::shared_ptr<ExclusiveMonitor> exclusive_monitor, | |||
| 64 | arm_interface = std::make_unique<ARM_Unicorn>(); | 62 | arm_interface = std::make_unique<ARM_Unicorn>(); |
| 65 | } | 63 | } |
| 66 | 64 | ||
| 67 | scheduler = std::make_shared<Kernel::Scheduler>(*arm_interface); | 65 | scheduler = std::make_unique<Kernel::Scheduler>(*arm_interface); |
| 68 | } | 66 | } |
| 69 | 67 | ||
| 70 | Cpu::~Cpu() = default; | 68 | Cpu::~Cpu() = default; |
| 71 | 69 | ||
| 72 | std::shared_ptr<ExclusiveMonitor> Cpu::MakeExclusiveMonitor(std::size_t num_cores) { | 70 | std::unique_ptr<ExclusiveMonitor> Cpu::MakeExclusiveMonitor(std::size_t num_cores) { |
| 73 | if (Settings::values.use_cpu_jit) { | 71 | if (Settings::values.use_cpu_jit) { |
| 74 | #ifdef ARCHITECTURE_x86_64 | 72 | #ifdef ARCHITECTURE_x86_64 |
| 75 | return std::make_shared<DynarmicExclusiveMonitor>(num_cores); | 73 | return std::make_unique<DynarmicExclusiveMonitor>(num_cores); |
| 76 | #else | 74 | #else |
| 77 | return nullptr; // TODO(merry): Passthrough exclusive monitor | 75 | return nullptr; // TODO(merry): Passthrough exclusive monitor |
| 78 | #endif | 76 | #endif |
| @@ -83,7 +81,7 @@ std::shared_ptr<ExclusiveMonitor> Cpu::MakeExclusiveMonitor(std::size_t num_core | |||
| 83 | 81 | ||
| 84 | void Cpu::RunLoop(bool tight_loop) { | 82 | void Cpu::RunLoop(bool tight_loop) { |
| 85 | // Wait for all other CPU cores to complete the previous slice, such that they run in lock-step | 83 | // Wait for all other CPU cores to complete the previous slice, such that they run in lock-step |
| 86 | if (!cpu_barrier->Rendezvous()) { | 84 | if (!cpu_barrier.Rendezvous()) { |
| 87 | // If rendezvous failed, session has been killed | 85 | // If rendezvous failed, session has been killed |
| 88 | return; | 86 | return; |
| 89 | } | 87 | } |
diff --git a/src/core/core_cpu.h b/src/core/core_cpu.h index ee7e04abc..1d2bdc6cd 100644 --- a/src/core/core_cpu.h +++ b/src/core/core_cpu.h | |||
| @@ -41,8 +41,7 @@ private: | |||
| 41 | 41 | ||
| 42 | class Cpu { | 42 | class Cpu { |
| 43 | public: | 43 | public: |
| 44 | Cpu(std::shared_ptr<ExclusiveMonitor> exclusive_monitor, | 44 | Cpu(ExclusiveMonitor& exclusive_monitor, CpuBarrier& cpu_barrier, std::size_t core_index); |
| 45 | std::shared_ptr<CpuBarrier> cpu_barrier, std::size_t core_index); | ||
| 46 | ~Cpu(); | 45 | ~Cpu(); |
| 47 | 46 | ||
| 48 | void RunLoop(bool tight_loop = true); | 47 | void RunLoop(bool tight_loop = true); |
| @@ -59,8 +58,12 @@ public: | |||
| 59 | return *arm_interface; | 58 | return *arm_interface; |
| 60 | } | 59 | } |
| 61 | 60 | ||
| 62 | const std::shared_ptr<Kernel::Scheduler>& Scheduler() const { | 61 | Kernel::Scheduler& Scheduler() { |
| 63 | return scheduler; | 62 | return *scheduler; |
| 63 | } | ||
| 64 | |||
| 65 | const Kernel::Scheduler& Scheduler() const { | ||
| 66 | return *scheduler; | ||
| 64 | } | 67 | } |
| 65 | 68 | ||
| 66 | bool IsMainCore() const { | 69 | bool IsMainCore() const { |
| @@ -71,14 +74,14 @@ public: | |||
| 71 | return core_index; | 74 | return core_index; |
| 72 | } | 75 | } |
| 73 | 76 | ||
| 74 | static std::shared_ptr<ExclusiveMonitor> MakeExclusiveMonitor(std::size_t num_cores); | 77 | static std::unique_ptr<ExclusiveMonitor> MakeExclusiveMonitor(std::size_t num_cores); |
| 75 | 78 | ||
| 76 | private: | 79 | private: |
| 77 | void Reschedule(); | 80 | void Reschedule(); |
| 78 | 81 | ||
| 79 | std::unique_ptr<ARM_Interface> arm_interface; | 82 | std::unique_ptr<ARM_Interface> arm_interface; |
| 80 | std::shared_ptr<CpuBarrier> cpu_barrier; | 83 | CpuBarrier& cpu_barrier; |
| 81 | std::shared_ptr<Kernel::Scheduler> scheduler; | 84 | std::unique_ptr<Kernel::Scheduler> scheduler; |
| 82 | 85 | ||
| 83 | std::atomic<bool> reschedule_pending = false; | 86 | std::atomic<bool> reschedule_pending = false; |
| 84 | std::size_t core_index; | 87 | std::size_t core_index; |
diff --git a/src/core/file_sys/bis_factory.cpp b/src/core/file_sys/bis_factory.cpp index 6102ef476..76a2b7e86 100644 --- a/src/core/file_sys/bis_factory.cpp +++ b/src/core/file_sys/bis_factory.cpp | |||
| @@ -10,19 +10,19 @@ namespace FileSys { | |||
| 10 | 10 | ||
| 11 | BISFactory::BISFactory(VirtualDir nand_root_, VirtualDir load_root_) | 11 | BISFactory::BISFactory(VirtualDir nand_root_, VirtualDir load_root_) |
| 12 | : nand_root(std::move(nand_root_)), load_root(std::move(load_root_)), | 12 | : nand_root(std::move(nand_root_)), load_root(std::move(load_root_)), |
| 13 | sysnand_cache(std::make_shared<RegisteredCache>( | 13 | sysnand_cache(std::make_unique<RegisteredCache>( |
| 14 | GetOrCreateDirectoryRelative(nand_root, "/system/Contents/registered"))), | 14 | GetOrCreateDirectoryRelative(nand_root, "/system/Contents/registered"))), |
| 15 | usrnand_cache(std::make_shared<RegisteredCache>( | 15 | usrnand_cache(std::make_unique<RegisteredCache>( |
| 16 | GetOrCreateDirectoryRelative(nand_root, "/user/Contents/registered"))) {} | 16 | GetOrCreateDirectoryRelative(nand_root, "/user/Contents/registered"))) {} |
| 17 | 17 | ||
| 18 | BISFactory::~BISFactory() = default; | 18 | BISFactory::~BISFactory() = default; |
| 19 | 19 | ||
| 20 | std::shared_ptr<RegisteredCache> BISFactory::GetSystemNANDContents() const { | 20 | RegisteredCache* BISFactory::GetSystemNANDContents() const { |
| 21 | return sysnand_cache; | 21 | return sysnand_cache.get(); |
| 22 | } | 22 | } |
| 23 | 23 | ||
| 24 | std::shared_ptr<RegisteredCache> BISFactory::GetUserNANDContents() const { | 24 | RegisteredCache* BISFactory::GetUserNANDContents() const { |
| 25 | return usrnand_cache; | 25 | return usrnand_cache.get(); |
| 26 | } | 26 | } |
| 27 | 27 | ||
| 28 | VirtualDir BISFactory::GetModificationLoadRoot(u64 title_id) const { | 28 | VirtualDir BISFactory::GetModificationLoadRoot(u64 title_id) const { |
diff --git a/src/core/file_sys/bis_factory.h b/src/core/file_sys/bis_factory.h index c352e0925..364d309bd 100644 --- a/src/core/file_sys/bis_factory.h +++ b/src/core/file_sys/bis_factory.h | |||
| @@ -20,8 +20,8 @@ public: | |||
| 20 | explicit BISFactory(VirtualDir nand_root, VirtualDir load_root); | 20 | explicit BISFactory(VirtualDir nand_root, VirtualDir load_root); |
| 21 | ~BISFactory(); | 21 | ~BISFactory(); |
| 22 | 22 | ||
| 23 | std::shared_ptr<RegisteredCache> GetSystemNANDContents() const; | 23 | RegisteredCache* GetSystemNANDContents() const; |
| 24 | std::shared_ptr<RegisteredCache> GetUserNANDContents() const; | 24 | RegisteredCache* GetUserNANDContents() const; |
| 25 | 25 | ||
| 26 | VirtualDir GetModificationLoadRoot(u64 title_id) const; | 26 | VirtualDir GetModificationLoadRoot(u64 title_id) const; |
| 27 | 27 | ||
| @@ -29,8 +29,8 @@ private: | |||
| 29 | VirtualDir nand_root; | 29 | VirtualDir nand_root; |
| 30 | VirtualDir load_root; | 30 | VirtualDir load_root; |
| 31 | 31 | ||
| 32 | std::shared_ptr<RegisteredCache> sysnand_cache; | 32 | std::unique_ptr<RegisteredCache> sysnand_cache; |
| 33 | std::shared_ptr<RegisteredCache> usrnand_cache; | 33 | std::unique_ptr<RegisteredCache> usrnand_cache; |
| 34 | }; | 34 | }; |
| 35 | 35 | ||
| 36 | } // namespace FileSys | 36 | } // namespace FileSys |
diff --git a/src/core/file_sys/content_archive.cpp b/src/core/file_sys/content_archive.cpp index aa1b3c17d..6dcec7816 100644 --- a/src/core/file_sys/content_archive.cpp +++ b/src/core/file_sys/content_archive.cpp | |||
| @@ -133,7 +133,7 @@ boost::optional<Core::Crypto::Key128> NCA::GetKeyAreaKey(NCASectionCryptoType ty | |||
| 133 | static_cast<u8>(type)); | 133 | static_cast<u8>(type)); |
| 134 | u128 out_128{}; | 134 | u128 out_128{}; |
| 135 | memcpy(out_128.data(), out.data(), 16); | 135 | memcpy(out_128.data(), out.data(), 16); |
| 136 | LOG_DEBUG(Crypto, "called with crypto_rev={:02X}, kak_index={:02X}, key={:016X}{:016X}", | 136 | LOG_TRACE(Crypto, "called with crypto_rev={:02X}, kak_index={:02X}, key={:016X}{:016X}", |
| 137 | master_key_id, header.key_index, out_128[1], out_128[0]); | 137 | master_key_id, header.key_index, out_128[1], out_128[0]); |
| 138 | 138 | ||
| 139 | return out; | 139 | return out; |
diff --git a/src/core/file_sys/patch_manager.cpp b/src/core/file_sys/patch_manager.cpp index 019caebe9..0117cb0bf 100644 --- a/src/core/file_sys/patch_manager.cpp +++ b/src/core/file_sys/patch_manager.cpp | |||
| @@ -214,8 +214,14 @@ static void ApplyLayeredFS(VirtualFile& romfs, u64 title_id, ContentRecordType t | |||
| 214 | 214 | ||
| 215 | VirtualFile PatchManager::PatchRomFS(VirtualFile romfs, u64 ivfc_offset, ContentRecordType type, | 215 | VirtualFile PatchManager::PatchRomFS(VirtualFile romfs, u64 ivfc_offset, ContentRecordType type, |
| 216 | VirtualFile update_raw) const { | 216 | VirtualFile update_raw) const { |
| 217 | LOG_INFO(Loader, "Patching RomFS for title_id={:016X}, type={:02X}", title_id, | 217 | const auto log_string = fmt::format("Patching RomFS for title_id={:016X}, type={:02X}", |
| 218 | static_cast<u8>(type)); | 218 | title_id, static_cast<u8>(type)) |
| 219 | .c_str(); | ||
| 220 | |||
| 221 | if (type == ContentRecordType::Program) | ||
| 222 | LOG_INFO(Loader, log_string); | ||
| 223 | else | ||
| 224 | LOG_DEBUG(Loader, log_string); | ||
| 219 | 225 | ||
| 220 | if (romfs == nullptr) | 226 | if (romfs == nullptr) |
| 221 | return romfs; | 227 | return romfs; |
| @@ -346,7 +352,7 @@ std::map<std::string, std::string, std::less<>> PatchManager::GetPatchVersionNam | |||
| 346 | } | 352 | } |
| 347 | 353 | ||
| 348 | std::pair<std::unique_ptr<NACP>, VirtualFile> PatchManager::GetControlMetadata() const { | 354 | std::pair<std::unique_ptr<NACP>, VirtualFile> PatchManager::GetControlMetadata() const { |
| 349 | const auto& installed{Service::FileSystem::GetUnionContents()}; | 355 | const auto installed{Service::FileSystem::GetUnionContents()}; |
| 350 | 356 | ||
| 351 | const auto base_control_nca = installed->GetEntry(title_id, ContentRecordType::Control); | 357 | const auto base_control_nca = installed->GetEntry(title_id, ContentRecordType::Control); |
| 352 | if (base_control_nca == nullptr) | 358 | if (base_control_nca == nullptr) |
diff --git a/src/core/file_sys/registered_cache.cpp b/src/core/file_sys/registered_cache.cpp index e9b040689..1febb398e 100644 --- a/src/core/file_sys/registered_cache.cpp +++ b/src/core/file_sys/registered_cache.cpp | |||
| @@ -308,14 +308,14 @@ VirtualFile RegisteredCache::GetEntryRaw(RegisteredCacheEntry entry) const { | |||
| 308 | return GetEntryRaw(entry.title_id, entry.type); | 308 | return GetEntryRaw(entry.title_id, entry.type); |
| 309 | } | 309 | } |
| 310 | 310 | ||
| 311 | std::shared_ptr<NCA> RegisteredCache::GetEntry(u64 title_id, ContentRecordType type) const { | 311 | std::unique_ptr<NCA> RegisteredCache::GetEntry(u64 title_id, ContentRecordType type) const { |
| 312 | const auto raw = GetEntryRaw(title_id, type); | 312 | const auto raw = GetEntryRaw(title_id, type); |
| 313 | if (raw == nullptr) | 313 | if (raw == nullptr) |
| 314 | return nullptr; | 314 | return nullptr; |
| 315 | return std::make_shared<NCA>(raw); | 315 | return std::make_unique<NCA>(raw); |
| 316 | } | 316 | } |
| 317 | 317 | ||
| 318 | std::shared_ptr<NCA> RegisteredCache::GetEntry(RegisteredCacheEntry entry) const { | 318 | std::unique_ptr<NCA> RegisteredCache::GetEntry(RegisteredCacheEntry entry) const { |
| 319 | return GetEntry(entry.title_id, entry.type); | 319 | return GetEntry(entry.title_id, entry.type); |
| 320 | } | 320 | } |
| 321 | 321 | ||
| @@ -516,7 +516,7 @@ bool RegisteredCache::RawInstallYuzuMeta(const CNMT& cnmt) { | |||
| 516 | }) != yuzu_meta.end(); | 516 | }) != yuzu_meta.end(); |
| 517 | } | 517 | } |
| 518 | 518 | ||
| 519 | RegisteredCacheUnion::RegisteredCacheUnion(std::vector<std::shared_ptr<RegisteredCache>> caches) | 519 | RegisteredCacheUnion::RegisteredCacheUnion(std::vector<RegisteredCache*> caches) |
| 520 | : caches(std::move(caches)) {} | 520 | : caches(std::move(caches)) {} |
| 521 | 521 | ||
| 522 | void RegisteredCacheUnion::Refresh() { | 522 | void RegisteredCacheUnion::Refresh() { |
| @@ -572,14 +572,14 @@ VirtualFile RegisteredCacheUnion::GetEntryRaw(RegisteredCacheEntry entry) const | |||
| 572 | return GetEntryRaw(entry.title_id, entry.type); | 572 | return GetEntryRaw(entry.title_id, entry.type); |
| 573 | } | 573 | } |
| 574 | 574 | ||
| 575 | std::shared_ptr<NCA> RegisteredCacheUnion::GetEntry(u64 title_id, ContentRecordType type) const { | 575 | std::unique_ptr<NCA> RegisteredCacheUnion::GetEntry(u64 title_id, ContentRecordType type) const { |
| 576 | const auto raw = GetEntryRaw(title_id, type); | 576 | const auto raw = GetEntryRaw(title_id, type); |
| 577 | if (raw == nullptr) | 577 | if (raw == nullptr) |
| 578 | return nullptr; | 578 | return nullptr; |
| 579 | return std::make_shared<NCA>(raw); | 579 | return std::make_unique<NCA>(raw); |
| 580 | } | 580 | } |
| 581 | 581 | ||
| 582 | std::shared_ptr<NCA> RegisteredCacheUnion::GetEntry(RegisteredCacheEntry entry) const { | 582 | std::unique_ptr<NCA> RegisteredCacheUnion::GetEntry(RegisteredCacheEntry entry) const { |
| 583 | return GetEntry(entry.title_id, entry.type); | 583 | return GetEntry(entry.title_id, entry.type); |
| 584 | } | 584 | } |
| 585 | 585 | ||
diff --git a/src/core/file_sys/registered_cache.h b/src/core/file_sys/registered_cache.h index c0cd59fc5..5ddacba47 100644 --- a/src/core/file_sys/registered_cache.h +++ b/src/core/file_sys/registered_cache.h | |||
| @@ -88,8 +88,8 @@ public: | |||
| 88 | VirtualFile GetEntryRaw(u64 title_id, ContentRecordType type) const; | 88 | VirtualFile GetEntryRaw(u64 title_id, ContentRecordType type) const; |
| 89 | VirtualFile GetEntryRaw(RegisteredCacheEntry entry) const; | 89 | VirtualFile GetEntryRaw(RegisteredCacheEntry entry) const; |
| 90 | 90 | ||
| 91 | std::shared_ptr<NCA> GetEntry(u64 title_id, ContentRecordType type) const; | 91 | std::unique_ptr<NCA> GetEntry(u64 title_id, ContentRecordType type) const; |
| 92 | std::shared_ptr<NCA> GetEntry(RegisteredCacheEntry entry) const; | 92 | std::unique_ptr<NCA> GetEntry(RegisteredCacheEntry entry) const; |
| 93 | 93 | ||
| 94 | std::vector<RegisteredCacheEntry> ListEntries() const; | 94 | std::vector<RegisteredCacheEntry> ListEntries() const; |
| 95 | // If a parameter is not boost::none, it will be filtered for from all entries. | 95 | // If a parameter is not boost::none, it will be filtered for from all entries. |
| @@ -142,7 +142,7 @@ private: | |||
| 142 | // Combines multiple RegisteredCaches (i.e. SysNAND, UserNAND, SDMC) into one interface. | 142 | // Combines multiple RegisteredCaches (i.e. SysNAND, UserNAND, SDMC) into one interface. |
| 143 | class RegisteredCacheUnion { | 143 | class RegisteredCacheUnion { |
| 144 | public: | 144 | public: |
| 145 | explicit RegisteredCacheUnion(std::vector<std::shared_ptr<RegisteredCache>> caches); | 145 | explicit RegisteredCacheUnion(std::vector<RegisteredCache*> caches); |
| 146 | 146 | ||
| 147 | void Refresh(); | 147 | void Refresh(); |
| 148 | 148 | ||
| @@ -157,8 +157,8 @@ public: | |||
| 157 | VirtualFile GetEntryRaw(u64 title_id, ContentRecordType type) const; | 157 | VirtualFile GetEntryRaw(u64 title_id, ContentRecordType type) const; |
| 158 | VirtualFile GetEntryRaw(RegisteredCacheEntry entry) const; | 158 | VirtualFile GetEntryRaw(RegisteredCacheEntry entry) const; |
| 159 | 159 | ||
| 160 | std::shared_ptr<NCA> GetEntry(u64 title_id, ContentRecordType type) const; | 160 | std::unique_ptr<NCA> GetEntry(u64 title_id, ContentRecordType type) const; |
| 161 | std::shared_ptr<NCA> GetEntry(RegisteredCacheEntry entry) const; | 161 | std::unique_ptr<NCA> GetEntry(RegisteredCacheEntry entry) const; |
| 162 | 162 | ||
| 163 | std::vector<RegisteredCacheEntry> ListEntries() const; | 163 | std::vector<RegisteredCacheEntry> ListEntries() const; |
| 164 | // If a parameter is not boost::none, it will be filtered for from all entries. | 164 | // If a parameter is not boost::none, it will be filtered for from all entries. |
| @@ -168,7 +168,7 @@ public: | |||
| 168 | boost::optional<u64> title_id = boost::none) const; | 168 | boost::optional<u64> title_id = boost::none) const; |
| 169 | 169 | ||
| 170 | private: | 170 | private: |
| 171 | std::vector<std::shared_ptr<RegisteredCache>> caches; | 171 | std::vector<RegisteredCache*> caches; |
| 172 | }; | 172 | }; |
| 173 | 173 | ||
| 174 | } // namespace FileSys | 174 | } // namespace FileSys |
diff --git a/src/core/file_sys/sdmc_factory.cpp b/src/core/file_sys/sdmc_factory.cpp index d66a9c9a4..bd3a57058 100644 --- a/src/core/file_sys/sdmc_factory.cpp +++ b/src/core/file_sys/sdmc_factory.cpp | |||
| @@ -10,10 +10,10 @@ | |||
| 10 | namespace FileSys { | 10 | namespace FileSys { |
| 11 | 11 | ||
| 12 | SDMCFactory::SDMCFactory(VirtualDir dir_) | 12 | SDMCFactory::SDMCFactory(VirtualDir dir_) |
| 13 | : dir(std::move(dir_)), contents(std::make_shared<RegisteredCache>( | 13 | : dir(std::move(dir_)), contents(std::make_unique<RegisteredCache>( |
| 14 | GetOrCreateDirectoryRelative(dir, "/Nintendo/Contents/registered"), | 14 | GetOrCreateDirectoryRelative(dir, "/Nintendo/Contents/registered"), |
| 15 | [](const VirtualFile& file, const NcaID& id) { | 15 | [](const VirtualFile& file, const NcaID& id) { |
| 16 | return std::make_shared<NAX>(file, id)->GetDecrypted(); | 16 | return NAX{file, id}.GetDecrypted(); |
| 17 | })) {} | 17 | })) {} |
| 18 | 18 | ||
| 19 | SDMCFactory::~SDMCFactory() = default; | 19 | SDMCFactory::~SDMCFactory() = default; |
| @@ -22,8 +22,8 @@ ResultVal<VirtualDir> SDMCFactory::Open() { | |||
| 22 | return MakeResult<VirtualDir>(dir); | 22 | return MakeResult<VirtualDir>(dir); |
| 23 | } | 23 | } |
| 24 | 24 | ||
| 25 | std::shared_ptr<RegisteredCache> SDMCFactory::GetSDMCContents() const { | 25 | RegisteredCache* SDMCFactory::GetSDMCContents() const { |
| 26 | return contents; | 26 | return contents.get(); |
| 27 | } | 27 | } |
| 28 | 28 | ||
| 29 | } // namespace FileSys | 29 | } // namespace FileSys |
diff --git a/src/core/file_sys/sdmc_factory.h b/src/core/file_sys/sdmc_factory.h index ea12149de..42794ba5b 100644 --- a/src/core/file_sys/sdmc_factory.h +++ b/src/core/file_sys/sdmc_factory.h | |||
| @@ -19,12 +19,12 @@ public: | |||
| 19 | ~SDMCFactory(); | 19 | ~SDMCFactory(); |
| 20 | 20 | ||
| 21 | ResultVal<VirtualDir> Open(); | 21 | ResultVal<VirtualDir> Open(); |
| 22 | std::shared_ptr<RegisteredCache> GetSDMCContents() const; | 22 | RegisteredCache* GetSDMCContents() const; |
| 23 | 23 | ||
| 24 | private: | 24 | private: |
| 25 | VirtualDir dir; | 25 | VirtualDir dir; |
| 26 | 26 | ||
| 27 | std::shared_ptr<RegisteredCache> contents; | 27 | std::unique_ptr<RegisteredCache> contents; |
| 28 | }; | 28 | }; |
| 29 | 29 | ||
| 30 | } // namespace FileSys | 30 | } // namespace FileSys |
diff --git a/src/core/gdbstub/gdbstub.cpp b/src/core/gdbstub/gdbstub.cpp index e961ef121..bdcc889e0 100644 --- a/src/core/gdbstub/gdbstub.cpp +++ b/src/core/gdbstub/gdbstub.cpp | |||
| @@ -207,7 +207,7 @@ void RegisterModule(std::string name, VAddr beg, VAddr end, bool add_elf_ext) { | |||
| 207 | 207 | ||
| 208 | static Kernel::Thread* FindThreadById(int id) { | 208 | static Kernel::Thread* FindThreadById(int id) { |
| 209 | for (u32 core = 0; core < Core::NUM_CPU_CORES; core++) { | 209 | for (u32 core = 0; core < Core::NUM_CPU_CORES; core++) { |
| 210 | const auto& threads = Core::System::GetInstance().Scheduler(core)->GetThreadList(); | 210 | const auto& threads = Core::System::GetInstance().Scheduler(core).GetThreadList(); |
| 211 | for (auto& thread : threads) { | 211 | for (auto& thread : threads) { |
| 212 | if (thread->GetThreadID() == static_cast<u32>(id)) { | 212 | if (thread->GetThreadID() == static_cast<u32>(id)) { |
| 213 | current_core = core; | 213 | current_core = core; |
| @@ -597,7 +597,7 @@ static void HandleQuery() { | |||
| 597 | } else if (strncmp(query, "fThreadInfo", strlen("fThreadInfo")) == 0) { | 597 | } else if (strncmp(query, "fThreadInfo", strlen("fThreadInfo")) == 0) { |
| 598 | std::string val = "m"; | 598 | std::string val = "m"; |
| 599 | for (u32 core = 0; core < Core::NUM_CPU_CORES; core++) { | 599 | for (u32 core = 0; core < Core::NUM_CPU_CORES; core++) { |
| 600 | const auto& threads = Core::System::GetInstance().Scheduler(core)->GetThreadList(); | 600 | const auto& threads = Core::System::GetInstance().Scheduler(core).GetThreadList(); |
| 601 | for (const auto& thread : threads) { | 601 | for (const auto& thread : threads) { |
| 602 | val += fmt::format("{:x}", thread->GetThreadID()); | 602 | val += fmt::format("{:x}", thread->GetThreadID()); |
| 603 | val += ","; | 603 | val += ","; |
| @@ -612,7 +612,7 @@ static void HandleQuery() { | |||
| 612 | buffer += "l<?xml version=\"1.0\"?>"; | 612 | buffer += "l<?xml version=\"1.0\"?>"; |
| 613 | buffer += "<threads>"; | 613 | buffer += "<threads>"; |
| 614 | for (u32 core = 0; core < Core::NUM_CPU_CORES; core++) { | 614 | for (u32 core = 0; core < Core::NUM_CPU_CORES; core++) { |
| 615 | const auto& threads = Core::System::GetInstance().Scheduler(core)->GetThreadList(); | 615 | const auto& threads = Core::System::GetInstance().Scheduler(core).GetThreadList(); |
| 616 | for (const auto& thread : threads) { | 616 | for (const auto& thread : threads) { |
| 617 | buffer += | 617 | buffer += |
| 618 | fmt::format(R"*(<thread id="{:x}" core="{:d}" name="Thread {:x}"></thread>)*", | 618 | fmt::format(R"*(<thread id="{:x}" core="{:d}" name="Thread {:x}"></thread>)*", |
diff --git a/src/core/hle/kernel/address_arbiter.cpp b/src/core/hle/kernel/address_arbiter.cpp index ebf193930..57157beb4 100644 --- a/src/core/hle/kernel/address_arbiter.cpp +++ b/src/core/hle/kernel/address_arbiter.cpp | |||
| @@ -39,7 +39,7 @@ static std::vector<SharedPtr<Thread>> GetThreadsWaitingOnAddress(VAddr address) | |||
| 39 | std::vector<SharedPtr<Thread>>& waiting_threads, | 39 | std::vector<SharedPtr<Thread>>& waiting_threads, |
| 40 | VAddr arb_addr) { | 40 | VAddr arb_addr) { |
| 41 | const auto& scheduler = Core::System::GetInstance().Scheduler(core_index); | 41 | const auto& scheduler = Core::System::GetInstance().Scheduler(core_index); |
| 42 | const auto& thread_list = scheduler->GetThreadList(); | 42 | const auto& thread_list = scheduler.GetThreadList(); |
| 43 | 43 | ||
| 44 | for (const auto& thread : thread_list) { | 44 | for (const auto& thread : thread_list) { |
| 45 | if (thread->GetArbiterWaitAddress() == arb_addr) | 45 | if (thread->GetArbiterWaitAddress() == arb_addr) |
diff --git a/src/core/hle/kernel/process.cpp b/src/core/hle/kernel/process.cpp index c80b2c507..073dd5a7d 100644 --- a/src/core/hle/kernel/process.cpp +++ b/src/core/hle/kernel/process.cpp | |||
| @@ -153,11 +153,11 @@ void Process::PrepareForTermination() { | |||
| 153 | } | 153 | } |
| 154 | }; | 154 | }; |
| 155 | 155 | ||
| 156 | auto& system = Core::System::GetInstance(); | 156 | const auto& system = Core::System::GetInstance(); |
| 157 | stop_threads(system.Scheduler(0)->GetThreadList()); | 157 | stop_threads(system.Scheduler(0).GetThreadList()); |
| 158 | stop_threads(system.Scheduler(1)->GetThreadList()); | 158 | stop_threads(system.Scheduler(1).GetThreadList()); |
| 159 | stop_threads(system.Scheduler(2)->GetThreadList()); | 159 | stop_threads(system.Scheduler(2).GetThreadList()); |
| 160 | stop_threads(system.Scheduler(3)->GetThreadList()); | 160 | stop_threads(system.Scheduler(3).GetThreadList()); |
| 161 | } | 161 | } |
| 162 | 162 | ||
| 163 | /** | 163 | /** |
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp index 7a053da1e..3e5f11f2b 100644 --- a/src/core/hle/kernel/svc.cpp +++ b/src/core/hle/kernel/svc.cpp | |||
| @@ -809,7 +809,7 @@ static ResultCode SignalProcessWideKey(VAddr condition_variable_addr, s32 target | |||
| 809 | std::vector<SharedPtr<Thread>>& waiting_threads, | 809 | std::vector<SharedPtr<Thread>>& waiting_threads, |
| 810 | VAddr condvar_addr) { | 810 | VAddr condvar_addr) { |
| 811 | const auto& scheduler = Core::System::GetInstance().Scheduler(core_index); | 811 | const auto& scheduler = Core::System::GetInstance().Scheduler(core_index); |
| 812 | const auto& thread_list = scheduler->GetThreadList(); | 812 | const auto& thread_list = scheduler.GetThreadList(); |
| 813 | 813 | ||
| 814 | for (const auto& thread : thread_list) { | 814 | for (const auto& thread : thread_list) { |
| 815 | if (thread->GetCondVarWaitAddress() == condvar_addr) | 815 | if (thread->GetCondVarWaitAddress() == condvar_addr) |
diff --git a/src/core/hle/kernel/thread.cpp b/src/core/hle/kernel/thread.cpp index 352ce1725..35ec98c1a 100644 --- a/src/core/hle/kernel/thread.cpp +++ b/src/core/hle/kernel/thread.cpp | |||
| @@ -97,7 +97,7 @@ void Thread::CancelWakeupTimer() { | |||
| 97 | static boost::optional<s32> GetNextProcessorId(u64 mask) { | 97 | static boost::optional<s32> GetNextProcessorId(u64 mask) { |
| 98 | for (s32 index = 0; index < Core::NUM_CPU_CORES; ++index) { | 98 | for (s32 index = 0; index < Core::NUM_CPU_CORES; ++index) { |
| 99 | if (mask & (1ULL << index)) { | 99 | if (mask & (1ULL << index)) { |
| 100 | if (!Core::System::GetInstance().Scheduler(index)->GetCurrentThread()) { | 100 | if (!Core::System::GetInstance().Scheduler(index).GetCurrentThread()) { |
| 101 | // Core is enabled and not running any threads, use this one | 101 | // Core is enabled and not running any threads, use this one |
| 102 | return index; | 102 | return index; |
| 103 | } | 103 | } |
| @@ -147,14 +147,14 @@ void Thread::ResumeFromWait() { | |||
| 147 | new_processor_id = processor_id; | 147 | new_processor_id = processor_id; |
| 148 | } | 148 | } |
| 149 | if (ideal_core != -1 && | 149 | if (ideal_core != -1 && |
| 150 | Core::System::GetInstance().Scheduler(ideal_core)->GetCurrentThread() == nullptr) { | 150 | Core::System::GetInstance().Scheduler(ideal_core).GetCurrentThread() == nullptr) { |
| 151 | new_processor_id = ideal_core; | 151 | new_processor_id = ideal_core; |
| 152 | } | 152 | } |
| 153 | 153 | ||
| 154 | ASSERT(*new_processor_id < 4); | 154 | ASSERT(*new_processor_id < 4); |
| 155 | 155 | ||
| 156 | // Add thread to new core's scheduler | 156 | // Add thread to new core's scheduler |
| 157 | auto& next_scheduler = Core::System::GetInstance().Scheduler(*new_processor_id); | 157 | auto* next_scheduler = &Core::System::GetInstance().Scheduler(*new_processor_id); |
| 158 | 158 | ||
| 159 | if (*new_processor_id != processor_id) { | 159 | if (*new_processor_id != processor_id) { |
| 160 | // Remove thread from previous core's scheduler | 160 | // Remove thread from previous core's scheduler |
| @@ -169,7 +169,7 @@ void Thread::ResumeFromWait() { | |||
| 169 | next_scheduler->ScheduleThread(this, current_priority); | 169 | next_scheduler->ScheduleThread(this, current_priority); |
| 170 | 170 | ||
| 171 | // Change thread's scheduler | 171 | // Change thread's scheduler |
| 172 | scheduler = next_scheduler.get(); | 172 | scheduler = next_scheduler; |
| 173 | 173 | ||
| 174 | Core::System::GetInstance().CpuCore(processor_id).PrepareReschedule(); | 174 | Core::System::GetInstance().CpuCore(processor_id).PrepareReschedule(); |
| 175 | } | 175 | } |
| @@ -230,7 +230,7 @@ ResultVal<SharedPtr<Thread>> Thread::Create(KernelCore& kernel, std::string name | |||
| 230 | thread->name = std::move(name); | 230 | thread->name = std::move(name); |
| 231 | thread->callback_handle = kernel.ThreadWakeupCallbackHandleTable().Create(thread).Unwrap(); | 231 | thread->callback_handle = kernel.ThreadWakeupCallbackHandleTable().Create(thread).Unwrap(); |
| 232 | thread->owner_process = &owner_process; | 232 | thread->owner_process = &owner_process; |
| 233 | thread->scheduler = Core::System::GetInstance().Scheduler(processor_id).get(); | 233 | thread->scheduler = &Core::System::GetInstance().Scheduler(processor_id); |
| 234 | thread->scheduler->AddThread(thread, priority); | 234 | thread->scheduler->AddThread(thread, priority); |
| 235 | thread->tls_address = thread->owner_process->MarkNextAvailableTLSSlotAsUsed(*thread); | 235 | thread->tls_address = thread->owner_process->MarkNextAvailableTLSSlotAsUsed(*thread); |
| 236 | 236 | ||
| @@ -375,14 +375,14 @@ void Thread::ChangeCore(u32 core, u64 mask) { | |||
| 375 | new_processor_id = processor_id; | 375 | new_processor_id = processor_id; |
| 376 | } | 376 | } |
| 377 | if (ideal_core != -1 && | 377 | if (ideal_core != -1 && |
| 378 | Core::System::GetInstance().Scheduler(ideal_core)->GetCurrentThread() == nullptr) { | 378 | Core::System::GetInstance().Scheduler(ideal_core).GetCurrentThread() == nullptr) { |
| 379 | new_processor_id = ideal_core; | 379 | new_processor_id = ideal_core; |
| 380 | } | 380 | } |
| 381 | 381 | ||
| 382 | ASSERT(*new_processor_id < 4); | 382 | ASSERT(*new_processor_id < 4); |
| 383 | 383 | ||
| 384 | // Add thread to new core's scheduler | 384 | // Add thread to new core's scheduler |
| 385 | auto& next_scheduler = Core::System::GetInstance().Scheduler(*new_processor_id); | 385 | auto* next_scheduler = &Core::System::GetInstance().Scheduler(*new_processor_id); |
| 386 | 386 | ||
| 387 | if (*new_processor_id != processor_id) { | 387 | if (*new_processor_id != processor_id) { |
| 388 | // Remove thread from previous core's scheduler | 388 | // Remove thread from previous core's scheduler |
| @@ -397,7 +397,7 @@ void Thread::ChangeCore(u32 core, u64 mask) { | |||
| 397 | next_scheduler->ScheduleThread(this, current_priority); | 397 | next_scheduler->ScheduleThread(this, current_priority); |
| 398 | 398 | ||
| 399 | // Change thread's scheduler | 399 | // Change thread's scheduler |
| 400 | scheduler = next_scheduler.get(); | 400 | scheduler = next_scheduler; |
| 401 | 401 | ||
| 402 | Core::System::GetInstance().CpuCore(processor_id).PrepareReschedule(); | 402 | Core::System::GetInstance().CpuCore(processor_id).PrepareReschedule(); |
| 403 | } | 403 | } |
diff --git a/src/core/hle/service/filesystem/filesystem.cpp b/src/core/hle/service/filesystem/filesystem.cpp index e06712603..e32a7c48e 100644 --- a/src/core/hle/service/filesystem/filesystem.cpp +++ b/src/core/hle/service/filesystem/filesystem.cpp | |||
| @@ -319,13 +319,12 @@ ResultVal<FileSys::VirtualDir> OpenSDMC() { | |||
| 319 | return sdmc_factory->Open(); | 319 | return sdmc_factory->Open(); |
| 320 | } | 320 | } |
| 321 | 321 | ||
| 322 | std::shared_ptr<FileSys::RegisteredCacheUnion> GetUnionContents() { | 322 | std::unique_ptr<FileSys::RegisteredCacheUnion> GetUnionContents() { |
| 323 | return std::make_shared<FileSys::RegisteredCacheUnion>( | 323 | return std::make_unique<FileSys::RegisteredCacheUnion>(std::vector<FileSys::RegisteredCache*>{ |
| 324 | std::vector<std::shared_ptr<FileSys::RegisteredCache>>{ | 324 | GetSystemNANDContents(), GetUserNANDContents(), GetSDMCContents()}); |
| 325 | GetSystemNANDContents(), GetUserNANDContents(), GetSDMCContents()}); | ||
| 326 | } | 325 | } |
| 327 | 326 | ||
| 328 | std::shared_ptr<FileSys::RegisteredCache> GetSystemNANDContents() { | 327 | FileSys::RegisteredCache* GetSystemNANDContents() { |
| 329 | LOG_TRACE(Service_FS, "Opening System NAND Contents"); | 328 | LOG_TRACE(Service_FS, "Opening System NAND Contents"); |
| 330 | 329 | ||
| 331 | if (bis_factory == nullptr) | 330 | if (bis_factory == nullptr) |
| @@ -334,7 +333,7 @@ std::shared_ptr<FileSys::RegisteredCache> GetSystemNANDContents() { | |||
| 334 | return bis_factory->GetSystemNANDContents(); | 333 | return bis_factory->GetSystemNANDContents(); |
| 335 | } | 334 | } |
| 336 | 335 | ||
| 337 | std::shared_ptr<FileSys::RegisteredCache> GetUserNANDContents() { | 336 | FileSys::RegisteredCache* GetUserNANDContents() { |
| 338 | LOG_TRACE(Service_FS, "Opening User NAND Contents"); | 337 | LOG_TRACE(Service_FS, "Opening User NAND Contents"); |
| 339 | 338 | ||
| 340 | if (bis_factory == nullptr) | 339 | if (bis_factory == nullptr) |
| @@ -343,7 +342,7 @@ std::shared_ptr<FileSys::RegisteredCache> GetUserNANDContents() { | |||
| 343 | return bis_factory->GetUserNANDContents(); | 342 | return bis_factory->GetUserNANDContents(); |
| 344 | } | 343 | } |
| 345 | 344 | ||
| 346 | std::shared_ptr<FileSys::RegisteredCache> GetSDMCContents() { | 345 | FileSys::RegisteredCache* GetSDMCContents() { |
| 347 | LOG_TRACE(Service_FS, "Opening SDMC Contents"); | 346 | LOG_TRACE(Service_FS, "Opening SDMC Contents"); |
| 348 | 347 | ||
| 349 | if (sdmc_factory == nullptr) | 348 | if (sdmc_factory == nullptr) |
diff --git a/src/core/hle/service/filesystem/filesystem.h b/src/core/hle/service/filesystem/filesystem.h index 2df1faeb0..6ca5c5636 100644 --- a/src/core/hle/service/filesystem/filesystem.h +++ b/src/core/hle/service/filesystem/filesystem.h | |||
| @@ -47,11 +47,11 @@ ResultVal<FileSys::VirtualDir> OpenSaveData(FileSys::SaveDataSpaceId space, | |||
| 47 | FileSys::SaveDataDescriptor save_struct); | 47 | FileSys::SaveDataDescriptor save_struct); |
| 48 | ResultVal<FileSys::VirtualDir> OpenSDMC(); | 48 | ResultVal<FileSys::VirtualDir> OpenSDMC(); |
| 49 | 49 | ||
| 50 | std::shared_ptr<FileSys::RegisteredCacheUnion> GetUnionContents(); | 50 | std::unique_ptr<FileSys::RegisteredCacheUnion> GetUnionContents(); |
| 51 | 51 | ||
| 52 | std::shared_ptr<FileSys::RegisteredCache> GetSystemNANDContents(); | 52 | FileSys::RegisteredCache* GetSystemNANDContents(); |
| 53 | std::shared_ptr<FileSys::RegisteredCache> GetUserNANDContents(); | 53 | FileSys::RegisteredCache* GetUserNANDContents(); |
| 54 | std::shared_ptr<FileSys::RegisteredCache> GetSDMCContents(); | 54 | FileSys::RegisteredCache* GetSDMCContents(); |
| 55 | 55 | ||
| 56 | FileSys::VirtualDir GetModificationLoadRoot(u64 title_id); | 56 | FileSys::VirtualDir GetModificationLoadRoot(u64 title_id); |
| 57 | 57 | ||
diff --git a/src/core/hle/service/ns/pl_u.cpp b/src/core/hle/service/ns/pl_u.cpp index 4b2f758a8..44accecb7 100644 --- a/src/core/hle/service/ns/pl_u.cpp +++ b/src/core/hle/service/ns/pl_u.cpp | |||
| @@ -161,7 +161,7 @@ PL_U::PL_U() : ServiceFramework("pl:u"), impl{std::make_unique<Impl>()} { | |||
| 161 | }; | 161 | }; |
| 162 | RegisterHandlers(functions); | 162 | RegisterHandlers(functions); |
| 163 | // Attempt to load shared font data from disk | 163 | // Attempt to load shared font data from disk |
| 164 | const auto nand = FileSystem::GetSystemNANDContents(); | 164 | const auto* nand = FileSystem::GetSystemNANDContents(); |
| 165 | std::size_t offset = 0; | 165 | std::size_t offset = 0; |
| 166 | // Rebuild shared fonts from data ncas | 166 | // Rebuild shared fonts from data ncas |
| 167 | if (nand->HasEntry(static_cast<u64>(FontArchives::Standard), | 167 | if (nand->HasEntry(static_cast<u64>(FontArchives::Standard), |
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp index bbc02abcc..184537daa 100644 --- a/src/core/hle/service/vi/vi.cpp +++ b/src/core/hle/service/vi/vi.cpp | |||
| @@ -968,6 +968,54 @@ private: | |||
| 968 | rb.PushCopyObjects(vsync_event); | 968 | rb.PushCopyObjects(vsync_event); |
| 969 | } | 969 | } |
| 970 | 970 | ||
| 971 | enum class ConvertedScaleMode : u64 { | ||
| 972 | None = 0, // VI seems to name this as "Unknown" but lots of games pass it, assume it's no | ||
| 973 | // scaling/default | ||
| 974 | Freeze = 1, | ||
| 975 | ScaleToWindow = 2, | ||
| 976 | Crop = 3, | ||
| 977 | NoCrop = 4, | ||
| 978 | }; | ||
| 979 | |||
| 980 | // This struct is different, currently it's 1:1 but this might change in the future. | ||
| 981 | enum class NintendoScaleMode : u32 { | ||
| 982 | None = 0, | ||
| 983 | Freeze = 1, | ||
| 984 | ScaleToWindow = 2, | ||
| 985 | Crop = 3, | ||
| 986 | NoCrop = 4, | ||
| 987 | }; | ||
| 988 | |||
| 989 | void ConvertScalingMode(Kernel::HLERequestContext& ctx) { | ||
| 990 | IPC::RequestParser rp{ctx}; | ||
| 991 | auto mode = rp.PopEnum<NintendoScaleMode>(); | ||
| 992 | LOG_DEBUG(Service_VI, "called mode={}", static_cast<u32>(mode)); | ||
| 993 | |||
| 994 | IPC::ResponseBuilder rb{ctx, 4}; | ||
| 995 | rb.Push(RESULT_SUCCESS); | ||
| 996 | switch (mode) { | ||
| 997 | case NintendoScaleMode::None: | ||
| 998 | rb.PushEnum(ConvertedScaleMode::None); | ||
| 999 | break; | ||
| 1000 | case NintendoScaleMode::Freeze: | ||
| 1001 | rb.PushEnum(ConvertedScaleMode::Freeze); | ||
| 1002 | break; | ||
| 1003 | case NintendoScaleMode::ScaleToWindow: | ||
| 1004 | rb.PushEnum(ConvertedScaleMode::ScaleToWindow); | ||
| 1005 | break; | ||
| 1006 | case NintendoScaleMode::Crop: | ||
| 1007 | rb.PushEnum(ConvertedScaleMode::Crop); | ||
| 1008 | break; | ||
| 1009 | case NintendoScaleMode::NoCrop: | ||
| 1010 | rb.PushEnum(ConvertedScaleMode::NoCrop); | ||
| 1011 | break; | ||
| 1012 | default: | ||
| 1013 | UNIMPLEMENTED_MSG("Unknown scaling mode {}", static_cast<u32>(mode)); | ||
| 1014 | rb.PushEnum(ConvertedScaleMode::None); | ||
| 1015 | break; | ||
| 1016 | } | ||
| 1017 | } | ||
| 1018 | |||
| 971 | std::shared_ptr<NVFlinger::NVFlinger> nv_flinger; | 1019 | std::shared_ptr<NVFlinger::NVFlinger> nv_flinger; |
| 972 | }; | 1020 | }; |
| 973 | 1021 | ||
| @@ -991,7 +1039,7 @@ IApplicationDisplayService::IApplicationDisplayService( | |||
| 991 | {2030, &IApplicationDisplayService::CreateStrayLayer, "CreateStrayLayer"}, | 1039 | {2030, &IApplicationDisplayService::CreateStrayLayer, "CreateStrayLayer"}, |
| 992 | {2031, &IApplicationDisplayService::DestroyStrayLayer, "DestroyStrayLayer"}, | 1040 | {2031, &IApplicationDisplayService::DestroyStrayLayer, "DestroyStrayLayer"}, |
| 993 | {2101, &IApplicationDisplayService::SetLayerScalingMode, "SetLayerScalingMode"}, | 1041 | {2101, &IApplicationDisplayService::SetLayerScalingMode, "SetLayerScalingMode"}, |
| 994 | {2102, nullptr, "ConvertScalingMode"}, | 1042 | {2102, &IApplicationDisplayService::ConvertScalingMode, "ConvertScalingMode"}, |
| 995 | {2450, nullptr, "GetIndirectLayerImageMap"}, | 1043 | {2450, nullptr, "GetIndirectLayerImageMap"}, |
| 996 | {2451, nullptr, "GetIndirectLayerImageCropMap"}, | 1044 | {2451, nullptr, "GetIndirectLayerImageCropMap"}, |
| 997 | {2460, nullptr, "GetIndirectLayerImageRequiredMemoryInfo"}, | 1045 | {2460, nullptr, "GetIndirectLayerImageRequiredMemoryInfo"}, |
diff --git a/src/yuzu/debugger/wait_tree.cpp b/src/yuzu/debugger/wait_tree.cpp index 4a09da685..7403e9ccd 100644 --- a/src/yuzu/debugger/wait_tree.cpp +++ b/src/yuzu/debugger/wait_tree.cpp | |||
| @@ -66,10 +66,11 @@ std::vector<std::unique_ptr<WaitTreeThread>> WaitTreeItem::MakeThreadItemList() | |||
| 66 | } | 66 | } |
| 67 | }; | 67 | }; |
| 68 | 68 | ||
| 69 | add_threads(Core::System::GetInstance().Scheduler(0)->GetThreadList()); | 69 | const auto& system = Core::System::GetInstance(); |
| 70 | add_threads(Core::System::GetInstance().Scheduler(1)->GetThreadList()); | 70 | add_threads(system.Scheduler(0).GetThreadList()); |
| 71 | add_threads(Core::System::GetInstance().Scheduler(2)->GetThreadList()); | 71 | add_threads(system.Scheduler(1).GetThreadList()); |
| 72 | add_threads(Core::System::GetInstance().Scheduler(3)->GetThreadList()); | 72 | add_threads(system.Scheduler(2).GetThreadList()); |
| 73 | add_threads(system.Scheduler(3).GetThreadList()); | ||
| 73 | 74 | ||
| 74 | return item_list; | 75 | return item_list; |
| 75 | } | 76 | } |
diff --git a/src/yuzu/game_list_worker.cpp b/src/yuzu/game_list_worker.cpp index 8f99a1c78..3881aba5f 100644 --- a/src/yuzu/game_list_worker.cpp +++ b/src/yuzu/game_list_worker.cpp | |||
| @@ -96,7 +96,7 @@ void GameListWorker::AddInstalledTitlesToGameList() { | |||
| 96 | FileSys::ContentRecordType::Program); | 96 | FileSys::ContentRecordType::Program); |
| 97 | 97 | ||
| 98 | for (const auto& game : installed_games) { | 98 | for (const auto& game : installed_games) { |
| 99 | const auto& file = cache->GetEntryUnparsed(game); | 99 | const auto file = cache->GetEntryUnparsed(game); |
| 100 | std::unique_ptr<Loader::AppLoader> loader = Loader::GetLoader(file); | 100 | std::unique_ptr<Loader::AppLoader> loader = Loader::GetLoader(file); |
| 101 | if (!loader) | 101 | if (!loader) |
| 102 | continue; | 102 | continue; |
| @@ -107,7 +107,7 @@ void GameListWorker::AddInstalledTitlesToGameList() { | |||
| 107 | loader->ReadProgramId(program_id); | 107 | loader->ReadProgramId(program_id); |
| 108 | 108 | ||
| 109 | const FileSys::PatchManager patch{program_id}; | 109 | const FileSys::PatchManager patch{program_id}; |
| 110 | const auto& control = cache->GetEntry(game.title_id, FileSys::ContentRecordType::Control); | 110 | const auto control = cache->GetEntry(game.title_id, FileSys::ContentRecordType::Control); |
| 111 | if (control != nullptr) | 111 | if (control != nullptr) |
| 112 | GetMetadataFromControlNCA(patch, *control, icon, name); | 112 | GetMetadataFromControlNCA(patch, *control, icon, name); |
| 113 | 113 | ||
| @@ -135,9 +135,10 @@ void GameListWorker::AddInstalledTitlesToGameList() { | |||
| 135 | FileSys::ContentRecordType::Control); | 135 | FileSys::ContentRecordType::Control); |
| 136 | 136 | ||
| 137 | for (const auto& entry : control_data) { | 137 | for (const auto& entry : control_data) { |
| 138 | const auto nca = cache->GetEntry(entry); | 138 | auto nca = cache->GetEntry(entry); |
| 139 | if (nca != nullptr) | 139 | if (nca != nullptr) { |
| 140 | nca_control_map.insert_or_assign(entry.title_id, nca); | 140 | nca_control_map.insert_or_assign(entry.title_id, std::move(nca)); |
| 141 | } | ||
| 141 | } | 142 | } |
| 142 | } | 143 | } |
| 143 | 144 | ||
| @@ -153,9 +154,11 @@ void GameListWorker::FillControlMap(const std::string& dir_path) { | |||
| 153 | QFileInfo file_info(physical_name.c_str()); | 154 | QFileInfo file_info(physical_name.c_str()); |
| 154 | if (!is_dir && file_info.suffix().toStdString() == "nca") { | 155 | if (!is_dir && file_info.suffix().toStdString() == "nca") { |
| 155 | auto nca = | 156 | auto nca = |
| 156 | std::make_shared<FileSys::NCA>(vfs->OpenFile(physical_name, FileSys::Mode::Read)); | 157 | std::make_unique<FileSys::NCA>(vfs->OpenFile(physical_name, FileSys::Mode::Read)); |
| 157 | if (nca->GetType() == FileSys::NCAContentType::Control) | 158 | if (nca->GetType() == FileSys::NCAContentType::Control) { |
| 158 | nca_control_map.insert_or_assign(nca->GetTitleId(), nca); | 159 | const u64 title_id = nca->GetTitleId(); |
| 160 | nca_control_map.insert_or_assign(title_id, std::move(nca)); | ||
| 161 | } | ||
| 159 | } | 162 | } |
| 160 | return true; | 163 | return true; |
| 161 | }; | 164 | }; |
diff --git a/src/yuzu/game_list_worker.h b/src/yuzu/game_list_worker.h index 09d20c42f..0e42d0bde 100644 --- a/src/yuzu/game_list_worker.h +++ b/src/yuzu/game_list_worker.h | |||
| @@ -63,7 +63,7 @@ private: | |||
| 63 | void AddFstEntriesToGameList(const std::string& dir_path, unsigned int recursion = 0); | 63 | void AddFstEntriesToGameList(const std::string& dir_path, unsigned int recursion = 0); |
| 64 | 64 | ||
| 65 | std::shared_ptr<FileSys::VfsFilesystem> vfs; | 65 | std::shared_ptr<FileSys::VfsFilesystem> vfs; |
| 66 | std::map<u64, std::shared_ptr<FileSys::NCA>> nca_control_map; | 66 | std::map<u64, std::unique_ptr<FileSys::NCA>> nca_control_map; |
| 67 | QStringList watch_list; | 67 | QStringList watch_list; |
| 68 | QString dir_path; | 68 | QString dir_path; |
| 69 | bool deep_scan; | 69 | bool deep_scan; |