diff options
Diffstat (limited to 'src')
99 files changed, 304 insertions, 279 deletions
diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index 83da30418..efb851f5a 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt | |||
| @@ -651,20 +651,17 @@ endif() | |||
| 651 | 651 | ||
| 652 | if (MSVC) | 652 | if (MSVC) |
| 653 | target_compile_options(core PRIVATE | 653 | target_compile_options(core PRIVATE |
| 654 | # 'expression' : signed/unsigned mismatch | 654 | /we4018 # 'expression' : signed/unsigned mismatch |
| 655 | /we4018 | 655 | /we4244 # 'argument' : conversion from 'type1' to 'type2', possible loss of data (floating-point) |
| 656 | # 'argument' : conversion from 'type1' to 'type2', possible loss of data (floating-point) | 656 | /we4245 # 'conversion' : conversion from 'type1' to 'type2', signed/unsigned mismatch |
| 657 | /we4244 | 657 | /we4254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data |
| 658 | # 'conversion' : conversion from 'type1' to 'type2', signed/unsigned mismatch | 658 | /we4267 # 'var' : conversion from 'size_t' to 'type', possible loss of data |
| 659 | /we4245 | 659 | /we4305 # 'context' : truncation from 'type1' to 'type2' |
| 660 | # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data | 660 | /we4456 # Declaration of 'identifier' hides previous local declaration |
| 661 | /we4254 | 661 | /we4457 # Declaration of 'identifier' hides function parameter |
| 662 | # 'var' : conversion from 'size_t' to 'type', possible loss of data | 662 | /we4458 # Declaration of 'identifier' hides class member |
| 663 | /we4267 | 663 | /we4459 # Declaration of 'identifier' hides global declaration |
| 664 | # 'context' : truncation from 'type1' to 'type2' | 664 | /we4715 # 'function' : not all control paths return a value |
| 665 | /we4305 | ||
| 666 | # 'function' : not all control paths return a value | ||
| 667 | /we4715 | ||
| 668 | ) | 665 | ) |
| 669 | else() | 666 | else() |
| 670 | target_compile_options(core PRIVATE | 667 | target_compile_options(core PRIVATE |
| @@ -672,6 +669,7 @@ else() | |||
| 672 | -Werror=ignored-qualifiers | 669 | -Werror=ignored-qualifiers |
| 673 | -Werror=implicit-fallthrough | 670 | -Werror=implicit-fallthrough |
| 674 | -Werror=sign-compare | 671 | -Werror=sign-compare |
| 672 | -Werror=shadow | ||
| 675 | 673 | ||
| 676 | $<$<CXX_COMPILER_ID:GNU>:-Werror=class-memaccess> | 674 | $<$<CXX_COMPILER_ID:GNU>:-Werror=class-memaccess> |
| 677 | $<$<CXX_COMPILER_ID:GNU>:-Werror=unused-but-set-parameter> | 675 | $<$<CXX_COMPILER_ID:GNU>:-Werror=unused-but-set-parameter> |
diff --git a/src/core/arm/dynarmic/arm_dynarmic_32.cpp b/src/core/arm/dynarmic/arm_dynarmic_32.cpp index 42a37e84f..ab3266916 100644 --- a/src/core/arm/dynarmic/arm_dynarmic_32.cpp +++ b/src/core/arm/dynarmic/arm_dynarmic_32.cpp | |||
| @@ -24,7 +24,7 @@ namespace Core { | |||
| 24 | 24 | ||
| 25 | class DynarmicCallbacks32 : public Dynarmic::A32::UserCallbacks { | 25 | class DynarmicCallbacks32 : public Dynarmic::A32::UserCallbacks { |
| 26 | public: | 26 | public: |
| 27 | explicit DynarmicCallbacks32(ARM_Dynarmic_32& parent) : parent(parent) {} | 27 | explicit DynarmicCallbacks32(ARM_Dynarmic_32& parent_) : parent{parent_} {} |
| 28 | 28 | ||
| 29 | u8 MemoryRead8(u32 vaddr) override { | 29 | u8 MemoryRead8(u32 vaddr) override { |
| 30 | return parent.system.Memory().Read8(vaddr); | 30 | return parent.system.Memory().Read8(vaddr); |
diff --git a/src/core/arm/dynarmic/arm_dynarmic_64.cpp b/src/core/arm/dynarmic/arm_dynarmic_64.cpp index 653bb7a77..a4d830e48 100644 --- a/src/core/arm/dynarmic/arm_dynarmic_64.cpp +++ b/src/core/arm/dynarmic/arm_dynarmic_64.cpp | |||
| @@ -27,7 +27,7 @@ using Vector = Dynarmic::A64::Vector; | |||
| 27 | 27 | ||
| 28 | class DynarmicCallbacks64 : public Dynarmic::A64::UserCallbacks { | 28 | class DynarmicCallbacks64 : public Dynarmic::A64::UserCallbacks { |
| 29 | public: | 29 | public: |
| 30 | explicit DynarmicCallbacks64(ARM_Dynarmic_64& parent) : parent(parent) {} | 30 | explicit DynarmicCallbacks64(ARM_Dynarmic_64& parent_) : parent{parent_} {} |
| 31 | 31 | ||
| 32 | u8 MemoryRead8(u64 vaddr) override { | 32 | u8 MemoryRead8(u64 vaddr) override { |
| 33 | return parent.system.Memory().Read8(vaddr); | 33 | return parent.system.Memory().Read8(vaddr); |
diff --git a/src/core/arm/dynarmic/arm_dynarmic_cp15.h b/src/core/arm/dynarmic/arm_dynarmic_cp15.h index dc6f4af3a..8597beddf 100644 --- a/src/core/arm/dynarmic/arm_dynarmic_cp15.h +++ b/src/core/arm/dynarmic/arm_dynarmic_cp15.h | |||
| @@ -18,7 +18,7 @@ class DynarmicCP15 final : public Dynarmic::A32::Coprocessor { | |||
| 18 | public: | 18 | public: |
| 19 | using CoprocReg = Dynarmic::A32::CoprocReg; | 19 | using CoprocReg = Dynarmic::A32::CoprocReg; |
| 20 | 20 | ||
| 21 | explicit DynarmicCP15(ARM_Dynarmic_32& parent) : parent(parent) {} | 21 | explicit DynarmicCP15(ARM_Dynarmic_32& parent_) : parent{parent_} {} |
| 22 | 22 | ||
| 23 | std::optional<Callback> CompileInternalOperation(bool two, unsigned opc1, CoprocReg CRd, | 23 | std::optional<Callback> CompileInternalOperation(bool two, unsigned opc1, CoprocReg CRd, |
| 24 | CoprocReg CRn, CoprocReg CRm, | 24 | CoprocReg CRn, CoprocReg CRm, |
diff --git a/src/core/arm/dynarmic/arm_exclusive_monitor.cpp b/src/core/arm/dynarmic/arm_exclusive_monitor.cpp index 4e209f6a5..9426a3edf 100644 --- a/src/core/arm/dynarmic/arm_exclusive_monitor.cpp +++ b/src/core/arm/dynarmic/arm_exclusive_monitor.cpp | |||
| @@ -9,8 +9,8 @@ | |||
| 9 | 9 | ||
| 10 | namespace Core { | 10 | namespace Core { |
| 11 | 11 | ||
| 12 | DynarmicExclusiveMonitor::DynarmicExclusiveMonitor(Memory::Memory& memory, std::size_t core_count) | 12 | DynarmicExclusiveMonitor::DynarmicExclusiveMonitor(Memory::Memory& memory_, std::size_t core_count_) |
| 13 | : monitor(core_count), memory{memory} {} | 13 | : monitor{core_count_}, memory{memory_} {} |
| 14 | 14 | ||
| 15 | DynarmicExclusiveMonitor::~DynarmicExclusiveMonitor() = default; | 15 | DynarmicExclusiveMonitor::~DynarmicExclusiveMonitor() = default; |
| 16 | 16 | ||
diff --git a/src/core/arm/dynarmic/arm_exclusive_monitor.h b/src/core/arm/dynarmic/arm_exclusive_monitor.h index 964f4a55d..f9f056a59 100644 --- a/src/core/arm/dynarmic/arm_exclusive_monitor.h +++ b/src/core/arm/dynarmic/arm_exclusive_monitor.h | |||
| @@ -22,7 +22,7 @@ namespace Core { | |||
| 22 | 22 | ||
| 23 | class DynarmicExclusiveMonitor final : public ExclusiveMonitor { | 23 | class DynarmicExclusiveMonitor final : public ExclusiveMonitor { |
| 24 | public: | 24 | public: |
| 25 | explicit DynarmicExclusiveMonitor(Memory::Memory& memory, std::size_t core_count); | 25 | explicit DynarmicExclusiveMonitor(Memory::Memory& memory_, std::size_t core_count_); |
| 26 | ~DynarmicExclusiveMonitor() override; | 26 | ~DynarmicExclusiveMonitor() override; |
| 27 | 27 | ||
| 28 | u8 ExclusiveRead8(std::size_t core_index, VAddr addr) override; | 28 | u8 ExclusiveRead8(std::size_t core_index, VAddr addr) override; |
diff --git a/src/core/cpu_manager.cpp b/src/core/cpu_manager.cpp index bdb374792..7e195346b 100644 --- a/src/core/cpu_manager.cpp +++ b/src/core/cpu_manager.cpp | |||
| @@ -18,7 +18,7 @@ | |||
| 18 | 18 | ||
| 19 | namespace Core { | 19 | namespace Core { |
| 20 | 20 | ||
| 21 | CpuManager::CpuManager(System& system) : system{system} {} | 21 | CpuManager::CpuManager(System& system_) : system{system_} {} |
| 22 | CpuManager::~CpuManager() = default; | 22 | CpuManager::~CpuManager() = default; |
| 23 | 23 | ||
| 24 | void CpuManager::ThreadStart(CpuManager& cpu_manager, std::size_t core) { | 24 | void CpuManager::ThreadStart(CpuManager& cpu_manager, std::size_t core) { |
diff --git a/src/core/cpu_manager.h b/src/core/cpu_manager.h index 9817017c0..140263b09 100644 --- a/src/core/cpu_manager.h +++ b/src/core/cpu_manager.h | |||
| @@ -25,7 +25,7 @@ class System; | |||
| 25 | 25 | ||
| 26 | class CpuManager { | 26 | class CpuManager { |
| 27 | public: | 27 | public: |
| 28 | explicit CpuManager(System& system); | 28 | explicit CpuManager(System& system_); |
| 29 | CpuManager(const CpuManager&) = delete; | 29 | CpuManager(const CpuManager&) = delete; |
| 30 | CpuManager(CpuManager&&) = delete; | 30 | CpuManager(CpuManager&&) = delete; |
| 31 | 31 | ||
diff --git a/src/core/crypto/ctr_encryption_layer.cpp b/src/core/crypto/ctr_encryption_layer.cpp index 5c84bb0a4..1231da8e3 100644 --- a/src/core/crypto/ctr_encryption_layer.cpp +++ b/src/core/crypto/ctr_encryption_layer.cpp | |||
| @@ -10,8 +10,8 @@ | |||
| 10 | namespace Core::Crypto { | 10 | namespace Core::Crypto { |
| 11 | 11 | ||
| 12 | CTREncryptionLayer::CTREncryptionLayer(FileSys::VirtualFile base_, Key128 key_, | 12 | CTREncryptionLayer::CTREncryptionLayer(FileSys::VirtualFile base_, Key128 key_, |
| 13 | std::size_t base_offset) | 13 | std::size_t base_offset_) |
| 14 | : EncryptionLayer(std::move(base_)), base_offset(base_offset), cipher(key_, Mode::CTR) {} | 14 | : EncryptionLayer(std::move(base_)), base_offset(base_offset_), cipher(key_, Mode::CTR) {} |
| 15 | 15 | ||
| 16 | std::size_t CTREncryptionLayer::Read(u8* data, std::size_t length, std::size_t offset) const { | 16 | std::size_t CTREncryptionLayer::Read(u8* data, std::size_t length, std::size_t offset) const { |
| 17 | if (length == 0) | 17 | if (length == 0) |
diff --git a/src/core/crypto/ctr_encryption_layer.h b/src/core/crypto/ctr_encryption_layer.h index a2429f001..f86f01b6f 100644 --- a/src/core/crypto/ctr_encryption_layer.h +++ b/src/core/crypto/ctr_encryption_layer.h | |||
| @@ -17,7 +17,7 @@ class CTREncryptionLayer : public EncryptionLayer { | |||
| 17 | public: | 17 | public: |
| 18 | using IVData = std::array<u8, 16>; | 18 | using IVData = std::array<u8, 16>; |
| 19 | 19 | ||
| 20 | CTREncryptionLayer(FileSys::VirtualFile base, Key128 key, std::size_t base_offset); | 20 | CTREncryptionLayer(FileSys::VirtualFile base_, Key128 key_, std::size_t base_offset_); |
| 21 | 21 | ||
| 22 | std::size_t Read(u8* data, std::size_t length, std::size_t offset) const override; | 22 | std::size_t Read(u8* data, std::size_t length, std::size_t offset) const override; |
| 23 | 23 | ||
diff --git a/src/core/crypto/key_manager.cpp b/src/core/crypto/key_manager.cpp index 070ed439e..a4b739c63 100644 --- a/src/core/crypto/key_manager.cpp +++ b/src/core/crypto/key_manager.cpp | |||
| @@ -458,7 +458,7 @@ static std::array<u8, size> operator^(const std::array<u8, size>& lhs, | |||
| 458 | const std::array<u8, size>& rhs) { | 458 | const std::array<u8, size>& rhs) { |
| 459 | std::array<u8, size> out; | 459 | std::array<u8, size> out; |
| 460 | std::transform(lhs.begin(), lhs.end(), rhs.begin(), out.begin(), | 460 | std::transform(lhs.begin(), lhs.end(), rhs.begin(), out.begin(), |
| 461 | [](u8 lhs, u8 rhs) { return u8(lhs ^ rhs); }); | 461 | [](u8 lhs_elem, u8 rhs_elem) { return u8(lhs_elem ^ rhs_elem); }); |
| 462 | return out; | 462 | return out; |
| 463 | } | 463 | } |
| 464 | 464 | ||
diff --git a/src/core/file_sys/nca_metadata.cpp b/src/core/file_sys/nca_metadata.cpp index 3596541b2..f5cb4aa8c 100644 --- a/src/core/file_sys/nca_metadata.cpp +++ b/src/core/file_sys/nca_metadata.cpp | |||
| @@ -39,10 +39,10 @@ CNMT::CNMT(VirtualFile file) { | |||
| 39 | } | 39 | } |
| 40 | } | 40 | } |
| 41 | 41 | ||
| 42 | CNMT::CNMT(CNMTHeader header, OptionalHeader opt_header, std::vector<ContentRecord> content_records, | 42 | CNMT::CNMT(CNMTHeader header_, OptionalHeader opt_header_, |
| 43 | std::vector<MetaRecord> meta_records) | 43 | std::vector<ContentRecord> content_records_, std::vector<MetaRecord> meta_records_) |
| 44 | : header(std::move(header)), opt_header(std::move(opt_header)), | 44 | : header(std::move(header_)), opt_header(std::move(opt_header_)), |
| 45 | content_records(std::move(content_records)), meta_records(std::move(meta_records)) {} | 45 | content_records(std::move(content_records_)), meta_records(std::move(meta_records_)) {} |
| 46 | 46 | ||
| 47 | CNMT::~CNMT() = default; | 47 | CNMT::~CNMT() = default; |
| 48 | 48 | ||
diff --git a/src/core/file_sys/nca_metadata.h b/src/core/file_sys/nca_metadata.h index 53535e5f5..ce1138a17 100644 --- a/src/core/file_sys/nca_metadata.h +++ b/src/core/file_sys/nca_metadata.h | |||
| @@ -87,8 +87,8 @@ static_assert(sizeof(CNMTHeader) == 0x20, "CNMTHeader has incorrect size."); | |||
| 87 | class CNMT { | 87 | class CNMT { |
| 88 | public: | 88 | public: |
| 89 | explicit CNMT(VirtualFile file); | 89 | explicit CNMT(VirtualFile file); |
| 90 | CNMT(CNMTHeader header, OptionalHeader opt_header, std::vector<ContentRecord> content_records, | 90 | CNMT(CNMTHeader header_, OptionalHeader opt_header_, |
| 91 | std::vector<MetaRecord> meta_records); | 91 | std::vector<ContentRecord> content_records_, std::vector<MetaRecord> meta_records_); |
| 92 | ~CNMT(); | 92 | ~CNMT(); |
| 93 | 93 | ||
| 94 | u64 GetTitleID() const; | 94 | u64 GetTitleID() const; |
diff --git a/src/core/file_sys/submission_package.cpp b/src/core/file_sys/submission_package.cpp index 80e560970..d51d469e3 100644 --- a/src/core/file_sys/submission_package.cpp +++ b/src/core/file_sys/submission_package.cpp | |||
| @@ -20,8 +20,8 @@ | |||
| 20 | 20 | ||
| 21 | namespace FileSys { | 21 | namespace FileSys { |
| 22 | 22 | ||
| 23 | NSP::NSP(VirtualFile file_, std::size_t program_index) | 23 | NSP::NSP(VirtualFile file_, std::size_t program_index_) |
| 24 | : file(std::move(file_)), program_index(program_index), status{Loader::ResultStatus::Success}, | 24 | : file(std::move(file_)), program_index(program_index_), status{Loader::ResultStatus::Success}, |
| 25 | pfs(std::make_shared<PartitionFilesystem>(file)), keys{Core::Crypto::KeyManager::Instance()} { | 25 | pfs(std::make_shared<PartitionFilesystem>(file)), keys{Core::Crypto::KeyManager::Instance()} { |
| 26 | if (pfs->GetStatus() != Loader::ResultStatus::Success) { | 26 | if (pfs->GetStatus() != Loader::ResultStatus::Success) { |
| 27 | status = pfs->GetStatus(); | 27 | status = pfs->GetStatus(); |
diff --git a/src/core/file_sys/submission_package.h b/src/core/file_sys/submission_package.h index 54581a6f3..ecb3b6f15 100644 --- a/src/core/file_sys/submission_package.h +++ b/src/core/file_sys/submission_package.h | |||
| @@ -27,7 +27,7 @@ enum class ContentRecordType : u8; | |||
| 27 | 27 | ||
| 28 | class NSP : public ReadOnlyVfsDirectory { | 28 | class NSP : public ReadOnlyVfsDirectory { |
| 29 | public: | 29 | public: |
| 30 | explicit NSP(VirtualFile file, std::size_t program_index = 0); | 30 | explicit NSP(VirtualFile file_, std::size_t program_index_ = 0); |
| 31 | ~NSP() override; | 31 | ~NSP() override; |
| 32 | 32 | ||
| 33 | Loader::ResultStatus GetStatus() const; | 33 | Loader::ResultStatus GetStatus() const; |
diff --git a/src/core/file_sys/vfs_concat.cpp b/src/core/file_sys/vfs_concat.cpp index 619081502..5f8c09124 100644 --- a/src/core/file_sys/vfs_concat.cpp +++ b/src/core/file_sys/vfs_concat.cpp | |||
| @@ -23,8 +23,8 @@ static bool VerifyConcatenationMapContinuity(const std::multimap<u64, VirtualFil | |||
| 23 | return map.begin()->first == 0; | 23 | return map.begin()->first == 0; |
| 24 | } | 24 | } |
| 25 | 25 | ||
| 26 | ConcatenatedVfsFile::ConcatenatedVfsFile(std::vector<VirtualFile> files_, std::string name) | 26 | ConcatenatedVfsFile::ConcatenatedVfsFile(std::vector<VirtualFile> files_, std::string name_) |
| 27 | : name(std::move(name)) { | 27 | : name(std::move(name_)) { |
| 28 | std::size_t next_offset = 0; | 28 | std::size_t next_offset = 0; |
| 29 | for (const auto& file : files_) { | 29 | for (const auto& file : files_) { |
| 30 | files.emplace(next_offset, file); | 30 | files.emplace(next_offset, file); |
| @@ -32,8 +32,8 @@ ConcatenatedVfsFile::ConcatenatedVfsFile(std::vector<VirtualFile> files_, std::s | |||
| 32 | } | 32 | } |
| 33 | } | 33 | } |
| 34 | 34 | ||
| 35 | ConcatenatedVfsFile::ConcatenatedVfsFile(std::multimap<u64, VirtualFile> files_, std::string name) | 35 | ConcatenatedVfsFile::ConcatenatedVfsFile(std::multimap<u64, VirtualFile> files_, std::string name_) |
| 36 | : files(std::move(files_)), name(std::move(name)) { | 36 | : files(std::move(files_)), name(std::move(name_)) { |
| 37 | ASSERT(VerifyConcatenationMapContinuity(files)); | 37 | ASSERT(VerifyConcatenationMapContinuity(files)); |
| 38 | } | 38 | } |
| 39 | 39 | ||
diff --git a/src/core/file_sys/vfs_concat.h b/src/core/file_sys/vfs_concat.h index 3397d32cd..cd32960a5 100644 --- a/src/core/file_sys/vfs_concat.h +++ b/src/core/file_sys/vfs_concat.h | |||
| @@ -14,8 +14,8 @@ namespace FileSys { | |||
| 14 | // Class that wraps multiple vfs files and concatenates them, making reads seamless. Currently | 14 | // Class that wraps multiple vfs files and concatenates them, making reads seamless. Currently |
| 15 | // read-only. | 15 | // read-only. |
| 16 | class ConcatenatedVfsFile : public VfsFile { | 16 | class ConcatenatedVfsFile : public VfsFile { |
| 17 | ConcatenatedVfsFile(std::vector<VirtualFile> files, std::string name); | 17 | explicit ConcatenatedVfsFile(std::vector<VirtualFile> files, std::string name_); |
| 18 | ConcatenatedVfsFile(std::multimap<u64, VirtualFile> files, std::string name); | 18 | explicit ConcatenatedVfsFile(std::multimap<u64, VirtualFile> files, std::string name_); |
| 19 | 19 | ||
| 20 | public: | 20 | public: |
| 21 | ~ConcatenatedVfsFile() override; | 21 | ~ConcatenatedVfsFile() override; |
diff --git a/src/core/file_sys/vfs_layered.cpp b/src/core/file_sys/vfs_layered.cpp index 192740058..e093c4db2 100644 --- a/src/core/file_sys/vfs_layered.cpp +++ b/src/core/file_sys/vfs_layered.cpp | |||
| @@ -8,8 +8,8 @@ | |||
| 8 | 8 | ||
| 9 | namespace FileSys { | 9 | namespace FileSys { |
| 10 | 10 | ||
| 11 | LayeredVfsDirectory::LayeredVfsDirectory(std::vector<VirtualDir> dirs, std::string name) | 11 | LayeredVfsDirectory::LayeredVfsDirectory(std::vector<VirtualDir> dirs_, std::string name_) |
| 12 | : dirs(std::move(dirs)), name(std::move(name)) {} | 12 | : dirs(std::move(dirs_)), name(std::move(name_)) {} |
| 13 | 13 | ||
| 14 | LayeredVfsDirectory::~LayeredVfsDirectory() = default; | 14 | LayeredVfsDirectory::~LayeredVfsDirectory() = default; |
| 15 | 15 | ||
diff --git a/src/core/file_sys/vfs_layered.h b/src/core/file_sys/vfs_layered.h index cb4b32e91..cd6baf28c 100644 --- a/src/core/file_sys/vfs_layered.h +++ b/src/core/file_sys/vfs_layered.h | |||
| @@ -13,7 +13,7 @@ namespace FileSys { | |||
| 13 | // one and falling back to the one after. The highest priority directory (overwrites all others) | 13 | // one and falling back to the one after. The highest priority directory (overwrites all others) |
| 14 | // should be element 0 in the dirs vector. | 14 | // should be element 0 in the dirs vector. |
| 15 | class LayeredVfsDirectory : public VfsDirectory { | 15 | class LayeredVfsDirectory : public VfsDirectory { |
| 16 | LayeredVfsDirectory(std::vector<VirtualDir> dirs, std::string name); | 16 | explicit LayeredVfsDirectory(std::vector<VirtualDir> dirs_, std::string name_); |
| 17 | 17 | ||
| 18 | public: | 18 | public: |
| 19 | ~LayeredVfsDirectory() override; | 19 | ~LayeredVfsDirectory() override; |
diff --git a/src/core/file_sys/vfs_libzip.cpp b/src/core/file_sys/vfs_libzip.cpp index 429d7bc8b..618eb658a 100644 --- a/src/core/file_sys/vfs_libzip.cpp +++ b/src/core/file_sys/vfs_libzip.cpp | |||
| @@ -3,7 +3,16 @@ | |||
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include <string> | 5 | #include <string> |
| 6 | |||
| 7 | #ifdef __GNUC__ | ||
| 8 | #pragma GCC diagnostic push | ||
| 9 | #pragma GCC diagnostic ignored "-Wshadow" | ||
| 10 | #endif | ||
| 6 | #include <zip.h> | 11 | #include <zip.h> |
| 12 | #ifdef __GNUC__ | ||
| 13 | #pragma GCC diagnostic pop | ||
| 14 | #endif | ||
| 15 | |||
| 7 | #include "common/logging/backend.h" | 16 | #include "common/logging/backend.h" |
| 8 | #include "core/file_sys/vfs.h" | 17 | #include "core/file_sys/vfs.h" |
| 9 | #include "core/file_sys/vfs_libzip.h" | 18 | #include "core/file_sys/vfs_libzip.h" |
diff --git a/src/core/file_sys/vfs_static.h b/src/core/file_sys/vfs_static.h index c840b24b9..f5b66cf71 100644 --- a/src/core/file_sys/vfs_static.h +++ b/src/core/file_sys/vfs_static.h | |||
| @@ -14,9 +14,9 @@ namespace FileSys { | |||
| 14 | 14 | ||
| 15 | class StaticVfsFile : public VfsFile { | 15 | class StaticVfsFile : public VfsFile { |
| 16 | public: | 16 | public: |
| 17 | explicit StaticVfsFile(u8 value, std::size_t size = 0, std::string name = "", | 17 | explicit StaticVfsFile(u8 value_, std::size_t size_ = 0, std::string name_ = "", |
| 18 | VirtualDir parent = nullptr) | 18 | VirtualDir parent_ = nullptr) |
| 19 | : value{value}, size{size}, name{std::move(name)}, parent{std::move(parent)} {} | 19 | : value{value_}, size{size_}, name{std::move(name_)}, parent{std::move(parent_)} {} |
| 20 | 20 | ||
| 21 | std::string GetName() const override { | 21 | std::string GetName() const override { |
| 22 | return name; | 22 | return name; |
diff --git a/src/core/file_sys/vfs_vector.cpp b/src/core/file_sys/vfs_vector.cpp index 1a3f06227..f64b88639 100644 --- a/src/core/file_sys/vfs_vector.cpp +++ b/src/core/file_sys/vfs_vector.cpp | |||
| @@ -7,8 +7,8 @@ | |||
| 7 | #include "core/file_sys/vfs_vector.h" | 7 | #include "core/file_sys/vfs_vector.h" |
| 8 | 8 | ||
| 9 | namespace FileSys { | 9 | namespace FileSys { |
| 10 | VectorVfsFile::VectorVfsFile(std::vector<u8> initial_data, std::string name, VirtualDir parent) | 10 | VectorVfsFile::VectorVfsFile(std::vector<u8> initial_data, std::string name_, VirtualDir parent_) |
| 11 | : data(std::move(initial_data)), parent(std::move(parent)), name(std::move(name)) {} | 11 | : data(std::move(initial_data)), parent(std::move(parent_)), name(std::move(name_)) {} |
| 12 | 12 | ||
| 13 | VectorVfsFile::~VectorVfsFile() = default; | 13 | VectorVfsFile::~VectorVfsFile() = default; |
| 14 | 14 | ||
diff --git a/src/core/file_sys/vfs_vector.h b/src/core/file_sys/vfs_vector.h index c10c527b6..73f180070 100644 --- a/src/core/file_sys/vfs_vector.h +++ b/src/core/file_sys/vfs_vector.h | |||
| @@ -75,8 +75,8 @@ std::shared_ptr<ArrayVfsFile<Size>> MakeArrayFile(const std::array<u8, Size>& da | |||
| 75 | // An implementation of VfsFile that is backed by a vector optionally supplied upon construction | 75 | // An implementation of VfsFile that is backed by a vector optionally supplied upon construction |
| 76 | class VectorVfsFile : public VfsFile { | 76 | class VectorVfsFile : public VfsFile { |
| 77 | public: | 77 | public: |
| 78 | explicit VectorVfsFile(std::vector<u8> initial_data = {}, std::string name = "", | 78 | explicit VectorVfsFile(std::vector<u8> initial_data = {}, std::string name_ = "", |
| 79 | VirtualDir parent = nullptr); | 79 | VirtualDir parent_ = nullptr); |
| 80 | ~VectorVfsFile() override; | 80 | ~VectorVfsFile() override; |
| 81 | 81 | ||
| 82 | std::string GetName() const override; | 82 | std::string GetName() const override; |
diff --git a/src/core/frontend/emu_window.cpp b/src/core/frontend/emu_window.cpp index cff49899a..e11ec0b0b 100644 --- a/src/core/frontend/emu_window.cpp +++ b/src/core/frontend/emu_window.cpp | |||
| @@ -26,7 +26,7 @@ public: | |||
| 26 | private: | 26 | private: |
| 27 | class Device : public Input::TouchDevice { | 27 | class Device : public Input::TouchDevice { |
| 28 | public: | 28 | public: |
| 29 | explicit Device(std::weak_ptr<TouchState>&& touch_state) : touch_state(touch_state) {} | 29 | explicit Device(std::weak_ptr<TouchState>&& touch_state_) : touch_state(touch_state_) {} |
| 30 | Input::TouchStatus GetStatus() const override { | 30 | Input::TouchStatus GetStatus() const override { |
| 31 | if (auto state = touch_state.lock()) { | 31 | if (auto state = touch_state.lock()) { |
| 32 | std::lock_guard guard{state->mutex}; | 32 | std::lock_guard guard{state->mutex}; |
diff --git a/src/core/hle/ipc_helpers.h b/src/core/hle/ipc_helpers.h index 5fed3dbf5..497f35d23 100644 --- a/src/core/hle/ipc_helpers.h +++ b/src/core/hle/ipc_helpers.h | |||
| @@ -33,8 +33,8 @@ protected: | |||
| 33 | public: | 33 | public: |
| 34 | explicit RequestHelperBase(u32* command_buffer) : cmdbuf(command_buffer) {} | 34 | explicit RequestHelperBase(u32* command_buffer) : cmdbuf(command_buffer) {} |
| 35 | 35 | ||
| 36 | explicit RequestHelperBase(Kernel::HLERequestContext& context) | 36 | explicit RequestHelperBase(Kernel::HLERequestContext& ctx) |
| 37 | : context(&context), cmdbuf(context.CommandBuffer()) {} | 37 | : context(&ctx), cmdbuf(ctx.CommandBuffer()) {} |
| 38 | 38 | ||
| 39 | void Skip(u32 size_in_words, bool set_to_null) { | 39 | void Skip(u32 size_in_words, bool set_to_null) { |
| 40 | if (set_to_null) { | 40 | if (set_to_null) { |
| @@ -71,12 +71,12 @@ public: | |||
| 71 | AlwaysMoveHandles = 1, | 71 | AlwaysMoveHandles = 1, |
| 72 | }; | 72 | }; |
| 73 | 73 | ||
| 74 | explicit ResponseBuilder(Kernel::HLERequestContext& ctx, u32 normal_params_size, | 74 | explicit ResponseBuilder(Kernel::HLERequestContext& ctx, u32 normal_params_size_, |
| 75 | u32 num_handles_to_copy = 0, u32 num_objects_to_move = 0, | 75 | u32 num_handles_to_copy_ = 0, u32 num_objects_to_move_ = 0, |
| 76 | Flags flags = Flags::None) | 76 | Flags flags = Flags::None) |
| 77 | : RequestHelperBase(ctx), normal_params_size(normal_params_size), | 77 | : RequestHelperBase(ctx), normal_params_size(normal_params_size_), |
| 78 | num_handles_to_copy(num_handles_to_copy), | 78 | num_handles_to_copy(num_handles_to_copy_), |
| 79 | num_objects_to_move(num_objects_to_move), kernel{ctx.kernel} { | 79 | num_objects_to_move(num_objects_to_move_), kernel{ctx.kernel} { |
| 80 | 80 | ||
| 81 | memset(cmdbuf, 0, sizeof(u32) * IPC::COMMAND_BUFFER_LENGTH); | 81 | memset(cmdbuf, 0, sizeof(u32) * IPC::COMMAND_BUFFER_LENGTH); |
| 82 | 82 | ||
| @@ -110,14 +110,14 @@ public: | |||
| 110 | 110 | ||
| 111 | ctx.data_size = static_cast<u32>(raw_data_size); | 111 | ctx.data_size = static_cast<u32>(raw_data_size); |
| 112 | header.data_size.Assign(static_cast<u32>(raw_data_size)); | 112 | header.data_size.Assign(static_cast<u32>(raw_data_size)); |
| 113 | if (num_handles_to_copy || num_handles_to_move) { | 113 | if (num_handles_to_copy != 0 || num_handles_to_move != 0) { |
| 114 | header.enable_handle_descriptor.Assign(1); | 114 | header.enable_handle_descriptor.Assign(1); |
| 115 | } | 115 | } |
| 116 | PushRaw(header); | 116 | PushRaw(header); |
| 117 | 117 | ||
| 118 | if (header.enable_handle_descriptor) { | 118 | if (header.enable_handle_descriptor) { |
| 119 | IPC::HandleDescriptorHeader handle_descriptor_header{}; | 119 | IPC::HandleDescriptorHeader handle_descriptor_header{}; |
| 120 | handle_descriptor_header.num_handles_to_copy.Assign(num_handles_to_copy); | 120 | handle_descriptor_header.num_handles_to_copy.Assign(num_handles_to_copy_); |
| 121 | handle_descriptor_header.num_handles_to_move.Assign(num_handles_to_move); | 121 | handle_descriptor_header.num_handles_to_move.Assign(num_handles_to_move); |
| 122 | PushRaw(handle_descriptor_header); | 122 | PushRaw(handle_descriptor_header); |
| 123 | 123 | ||
diff --git a/src/core/hle/kernel/global_scheduler_context.cpp b/src/core/hle/kernel/global_scheduler_context.cpp index 7c87cbada..4f4e338e3 100644 --- a/src/core/hle/kernel/global_scheduler_context.cpp +++ b/src/core/hle/kernel/global_scheduler_context.cpp | |||
| @@ -12,8 +12,8 @@ | |||
| 12 | 12 | ||
| 13 | namespace Kernel { | 13 | namespace Kernel { |
| 14 | 14 | ||
| 15 | GlobalSchedulerContext::GlobalSchedulerContext(KernelCore& kernel) | 15 | GlobalSchedulerContext::GlobalSchedulerContext(KernelCore& kernel_) |
| 16 | : kernel{kernel}, scheduler_lock{kernel} {} | 16 | : kernel{kernel_}, scheduler_lock{kernel_} {} |
| 17 | 17 | ||
| 18 | GlobalSchedulerContext::~GlobalSchedulerContext() = default; | 18 | GlobalSchedulerContext::~GlobalSchedulerContext() = default; |
| 19 | 19 | ||
diff --git a/src/core/hle/kernel/global_scheduler_context.h b/src/core/hle/kernel/global_scheduler_context.h index ba8b67fd1..6f44b534f 100644 --- a/src/core/hle/kernel/global_scheduler_context.h +++ b/src/core/hle/kernel/global_scheduler_context.h | |||
| @@ -34,7 +34,7 @@ class GlobalSchedulerContext final { | |||
| 34 | public: | 34 | public: |
| 35 | using LockType = KAbstractSchedulerLock<KScheduler>; | 35 | using LockType = KAbstractSchedulerLock<KScheduler>; |
| 36 | 36 | ||
| 37 | explicit GlobalSchedulerContext(KernelCore& kernel); | 37 | explicit GlobalSchedulerContext(KernelCore& kernel_); |
| 38 | ~GlobalSchedulerContext(); | 38 | ~GlobalSchedulerContext(); |
| 39 | 39 | ||
| 40 | /// Adds a new thread to the scheduler | 40 | /// Adds a new thread to the scheduler |
diff --git a/src/core/hle/kernel/k_light_condition_variable.h b/src/core/hle/kernel/k_light_condition_variable.h index 362d0db28..ca2e539a7 100644 --- a/src/core/hle/kernel/k_light_condition_variable.h +++ b/src/core/hle/kernel/k_light_condition_variable.h | |||
| @@ -18,7 +18,8 @@ class KernelCore; | |||
| 18 | 18 | ||
| 19 | class KLightConditionVariable { | 19 | class KLightConditionVariable { |
| 20 | public: | 20 | public: |
| 21 | explicit KLightConditionVariable(KernelCore& kernel) : thread_queue(kernel), kernel(kernel) {} | 21 | explicit KLightConditionVariable(KernelCore& kernel_) |
| 22 | : thread_queue(kernel_), kernel(kernel_) {} | ||
| 22 | 23 | ||
| 23 | void Wait(KLightLock* lock, s64 timeout = -1) { | 24 | void Wait(KLightLock* lock, s64 timeout = -1) { |
| 24 | WaitImpl(lock, timeout); | 25 | WaitImpl(lock, timeout); |
diff --git a/src/core/hle/kernel/k_linked_list.h b/src/core/hle/kernel/k_linked_list.h index 540e518cd..6adfe1e34 100644 --- a/src/core/hle/kernel/k_linked_list.h +++ b/src/core/hle/kernel/k_linked_list.h | |||
| @@ -201,10 +201,10 @@ public: | |||
| 201 | } | 201 | } |
| 202 | 202 | ||
| 203 | iterator insert(const_iterator pos, reference ref) { | 203 | iterator insert(const_iterator pos, reference ref) { |
| 204 | KLinkedListNode* node = KLinkedListNode::Allocate(kernel); | 204 | KLinkedListNode* new_node = KLinkedListNode::Allocate(kernel); |
| 205 | ASSERT(node != nullptr); | 205 | ASSERT(new_node != nullptr); |
| 206 | node->Initialize(std::addressof(ref)); | 206 | new_node->Initialize(std::addressof(ref)); |
| 207 | return iterator(BaseList::insert(pos.m_base_it, *node)); | 207 | return iterator(BaseList::insert(pos.m_base_it, *new_node)); |
| 208 | } | 208 | } |
| 209 | 209 | ||
| 210 | void push_back(reference ref) { | 210 | void push_back(reference ref) { |
diff --git a/src/core/hle/kernel/k_memory_block_manager.cpp b/src/core/hle/kernel/k_memory_block_manager.cpp index 44bfeb0d5..fc7033564 100644 --- a/src/core/hle/kernel/k_memory_block_manager.cpp +++ b/src/core/hle/kernel/k_memory_block_manager.cpp | |||
| @@ -7,8 +7,8 @@ | |||
| 7 | 7 | ||
| 8 | namespace Kernel { | 8 | namespace Kernel { |
| 9 | 9 | ||
| 10 | KMemoryBlockManager::KMemoryBlockManager(VAddr start_addr, VAddr end_addr) | 10 | KMemoryBlockManager::KMemoryBlockManager(VAddr start_addr_, VAddr end_addr_) |
| 11 | : start_addr{start_addr}, end_addr{end_addr} { | 11 | : start_addr{start_addr_}, end_addr{end_addr_} { |
| 12 | const u64 num_pages{(end_addr - start_addr) / PageSize}; | 12 | const u64 num_pages{(end_addr - start_addr) / PageSize}; |
| 13 | memory_block_tree.emplace_back(start_addr, num_pages, KMemoryState::Free, | 13 | memory_block_tree.emplace_back(start_addr, num_pages, KMemoryState::Free, |
| 14 | KMemoryPermission::None, KMemoryAttribute::None); | 14 | KMemoryPermission::None, KMemoryAttribute::None); |
diff --git a/src/core/hle/kernel/k_memory_block_manager.h b/src/core/hle/kernel/k_memory_block_manager.h index e11cc70c8..d222da919 100644 --- a/src/core/hle/kernel/k_memory_block_manager.h +++ b/src/core/hle/kernel/k_memory_block_manager.h | |||
| @@ -19,7 +19,7 @@ public: | |||
| 19 | using const_iterator = MemoryBlockTree::const_iterator; | 19 | using const_iterator = MemoryBlockTree::const_iterator; |
| 20 | 20 | ||
| 21 | public: | 21 | public: |
| 22 | KMemoryBlockManager(VAddr start_addr, VAddr end_addr); | 22 | KMemoryBlockManager(VAddr start_addr_, VAddr end_addr_); |
| 23 | 23 | ||
| 24 | iterator end() { | 24 | iterator end() { |
| 25 | return memory_block_tree.end(); | 25 | return memory_block_tree.end(); |
diff --git a/src/core/hle/kernel/k_page_linked_list.h b/src/core/hle/kernel/k_page_linked_list.h index 64024d01f..dfdac5321 100644 --- a/src/core/hle/kernel/k_page_linked_list.h +++ b/src/core/hle/kernel/k_page_linked_list.h | |||
| @@ -17,7 +17,7 @@ class KPageLinkedList final { | |||
| 17 | public: | 17 | public: |
| 18 | class Node final { | 18 | class Node final { |
| 19 | public: | 19 | public: |
| 20 | constexpr Node(u64 addr, std::size_t num_pages) : addr{addr}, num_pages{num_pages} {} | 20 | constexpr Node(u64 addr_, std::size_t num_pages_) : addr{addr_}, num_pages{num_pages_} {} |
| 21 | 21 | ||
| 22 | constexpr u64 GetAddress() const { | 22 | constexpr u64 GetAddress() const { |
| 23 | return addr; | 23 | return addr; |
diff --git a/src/core/hle/kernel/k_page_table.cpp b/src/core/hle/kernel/k_page_table.cpp index d4ce98ee3..27dbf0ebc 100644 --- a/src/core/hle/kernel/k_page_table.cpp +++ b/src/core/hle/kernel/k_page_table.cpp | |||
| @@ -58,7 +58,7 @@ constexpr std::size_t GetSizeInRange(const KMemoryInfo& info, VAddr start, VAddr | |||
| 58 | 58 | ||
| 59 | } // namespace | 59 | } // namespace |
| 60 | 60 | ||
| 61 | KPageTable::KPageTable(Core::System& system) : system{system} {} | 61 | KPageTable::KPageTable(Core::System& system_) : system{system_} {} |
| 62 | 62 | ||
| 63 | ResultCode KPageTable::InitializeForProcess(FileSys::ProgramAddressSpaceType as_type, | 63 | ResultCode KPageTable::InitializeForProcess(FileSys::ProgramAddressSpaceType as_type, |
| 64 | bool enable_aslr, VAddr code_addr, | 64 | bool enable_aslr, VAddr code_addr, |
| @@ -906,8 +906,8 @@ ResultCode KPageTable::LockForDeviceAddressSpace(VAddr addr, std::size_t size) { | |||
| 906 | 906 | ||
| 907 | block_manager->UpdateLock( | 907 | block_manager->UpdateLock( |
| 908 | addr, size / PageSize, | 908 | addr, size / PageSize, |
| 909 | [](KMemoryBlockManager::iterator block, KMemoryPermission perm) { | 909 | [](KMemoryBlockManager::iterator block, KMemoryPermission permission) { |
| 910 | block->ShareToDevice(perm); | 910 | block->ShareToDevice(permission); |
| 911 | }, | 911 | }, |
| 912 | perm); | 912 | perm); |
| 913 | 913 | ||
| @@ -929,8 +929,8 @@ ResultCode KPageTable::UnlockForDeviceAddressSpace(VAddr addr, std::size_t size) | |||
| 929 | 929 | ||
| 930 | block_manager->UpdateLock( | 930 | block_manager->UpdateLock( |
| 931 | addr, size / PageSize, | 931 | addr, size / PageSize, |
| 932 | [](KMemoryBlockManager::iterator block, KMemoryPermission perm) { | 932 | [](KMemoryBlockManager::iterator block, KMemoryPermission permission) { |
| 933 | block->UnshareToDevice(perm); | 933 | block->UnshareToDevice(permission); |
| 934 | }, | 934 | }, |
| 935 | perm); | 935 | perm); |
| 936 | 936 | ||
diff --git a/src/core/hle/kernel/k_page_table.h b/src/core/hle/kernel/k_page_table.h index 8c2cc03eb..770c4841c 100644 --- a/src/core/hle/kernel/k_page_table.h +++ b/src/core/hle/kernel/k_page_table.h | |||
| @@ -24,7 +24,7 @@ class KMemoryBlockManager; | |||
| 24 | 24 | ||
| 25 | class KPageTable final : NonCopyable { | 25 | class KPageTable final : NonCopyable { |
| 26 | public: | 26 | public: |
| 27 | explicit KPageTable(Core::System& system); | 27 | explicit KPageTable(Core::System& system_); |
| 28 | 28 | ||
| 29 | ResultCode InitializeForProcess(FileSys::ProgramAddressSpaceType as_type, bool enable_aslr, | 29 | ResultCode InitializeForProcess(FileSys::ProgramAddressSpaceType as_type, bool enable_aslr, |
| 30 | VAddr code_addr, std::size_t code_size, | 30 | VAddr code_addr, std::size_t code_size, |
diff --git a/src/core/hle/kernel/k_scheduler.cpp b/src/core/hle/kernel/k_scheduler.cpp index e256e9415..2f82fbcd6 100644 --- a/src/core/hle/kernel/k_scheduler.cpp +++ b/src/core/hle/kernel/k_scheduler.cpp | |||
| @@ -607,7 +607,7 @@ void KScheduler::YieldToAnyThread(KernelCore& kernel) { | |||
| 607 | } | 607 | } |
| 608 | } | 608 | } |
| 609 | 609 | ||
| 610 | KScheduler::KScheduler(Core::System& system, s32 core_id) : system(system), core_id(core_id) { | 610 | KScheduler::KScheduler(Core::System& system_, s32 core_id_) : system{system_}, core_id{core_id_} { |
| 611 | switch_fiber = std::make_shared<Common::Fiber>(OnSwitch, this); | 611 | switch_fiber = std::make_shared<Common::Fiber>(OnSwitch, this); |
| 612 | state.needs_scheduling.store(true); | 612 | state.needs_scheduling.store(true); |
| 613 | state.interrupt_task_thread_runnable = false; | 613 | state.interrupt_task_thread_runnable = false; |
diff --git a/src/core/hle/kernel/k_scheduler.h b/src/core/hle/kernel/k_scheduler.h index 13a2414e6..12cfae919 100644 --- a/src/core/hle/kernel/k_scheduler.h +++ b/src/core/hle/kernel/k_scheduler.h | |||
| @@ -30,7 +30,7 @@ class KThread; | |||
| 30 | 30 | ||
| 31 | class KScheduler final { | 31 | class KScheduler final { |
| 32 | public: | 32 | public: |
| 33 | explicit KScheduler(Core::System& system, s32 core_id); | 33 | explicit KScheduler(Core::System& system_, s32 core_id_); |
| 34 | ~KScheduler(); | 34 | ~KScheduler(); |
| 35 | 35 | ||
| 36 | /// Reschedules to the next available thread (call after current thread is suspended) | 36 | /// Reschedules to the next available thread (call after current thread is suspended) |
diff --git a/src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h b/src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h index b5d405744..a86af56dd 100644 --- a/src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h +++ b/src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h | |||
| @@ -17,8 +17,8 @@ namespace Kernel { | |||
| 17 | 17 | ||
| 18 | class [[nodiscard]] KScopedSchedulerLockAndSleep { | 18 | class [[nodiscard]] KScopedSchedulerLockAndSleep { |
| 19 | public: | 19 | public: |
| 20 | explicit KScopedSchedulerLockAndSleep(KernelCore & kernel, KThread * t, s64 timeout) | 20 | explicit KScopedSchedulerLockAndSleep(KernelCore & kernel_, KThread * t, s64 timeout) |
| 21 | : kernel(kernel), thread(t), timeout_tick(timeout) { | 21 | : kernel(kernel_), thread(t), timeout_tick(timeout) { |
| 22 | // Lock the scheduler. | 22 | // Lock the scheduler. |
| 23 | kernel.GlobalSchedulerContext().scheduler_lock.Lock(); | 23 | kernel.GlobalSchedulerContext().scheduler_lock.Lock(); |
| 24 | } | 24 | } |
diff --git a/src/core/hle/kernel/k_thread_queue.h b/src/core/hle/kernel/k_thread_queue.h index c52eba249..35d471dc5 100644 --- a/src/core/hle/kernel/k_thread_queue.h +++ b/src/core/hle/kernel/k_thread_queue.h | |||
| @@ -10,7 +10,7 @@ namespace Kernel { | |||
| 10 | 10 | ||
| 11 | class KThreadQueue { | 11 | class KThreadQueue { |
| 12 | public: | 12 | public: |
| 13 | explicit KThreadQueue(KernelCore& kernel) : kernel{kernel} {} | 13 | explicit KThreadQueue(KernelCore& kernel_) : kernel{kernel_} {} |
| 14 | 14 | ||
| 15 | bool IsEmpty() const { | 15 | bool IsEmpty() const { |
| 16 | return wait_list.empty(); | 16 | return wait_list.empty(); |
diff --git a/src/core/hle/kernel/physical_core.cpp b/src/core/hle/kernel/physical_core.cpp index 7fea45f96..7f02d9471 100644 --- a/src/core/hle/kernel/physical_core.cpp +++ b/src/core/hle/kernel/physical_core.cpp | |||
| @@ -13,10 +13,10 @@ | |||
| 13 | 13 | ||
| 14 | namespace Kernel { | 14 | namespace Kernel { |
| 15 | 15 | ||
| 16 | PhysicalCore::PhysicalCore(std::size_t core_index, Core::System& system, | 16 | PhysicalCore::PhysicalCore(std::size_t core_index_, Core::System& system_, KScheduler& scheduler_, |
| 17 | Kernel::KScheduler& scheduler, Core::CPUInterrupts& interrupts) | 17 | Core::CPUInterrupts& interrupts_) |
| 18 | : core_index{core_index}, system{system}, scheduler{scheduler}, | 18 | : core_index{core_index_}, system{system_}, scheduler{scheduler_}, |
| 19 | interrupts{interrupts}, guard{std::make_unique<Common::SpinLock>()} {} | 19 | interrupts{interrupts_}, guard{std::make_unique<Common::SpinLock>()} {} |
| 20 | 20 | ||
| 21 | PhysicalCore::~PhysicalCore() = default; | 21 | PhysicalCore::~PhysicalCore() = default; |
| 22 | 22 | ||
diff --git a/src/core/hle/kernel/physical_core.h b/src/core/hle/kernel/physical_core.h index f2b0911aa..901f7e3b0 100644 --- a/src/core/hle/kernel/physical_core.h +++ b/src/core/hle/kernel/physical_core.h | |||
| @@ -28,8 +28,8 @@ namespace Kernel { | |||
| 28 | 28 | ||
| 29 | class PhysicalCore { | 29 | class PhysicalCore { |
| 30 | public: | 30 | public: |
| 31 | PhysicalCore(std::size_t core_index, Core::System& system, Kernel::KScheduler& scheduler, | 31 | PhysicalCore(std::size_t core_index_, Core::System& system_, KScheduler& scheduler_, |
| 32 | Core::CPUInterrupts& interrupts); | 32 | Core::CPUInterrupts& interrupts_); |
| 33 | ~PhysicalCore(); | 33 | ~PhysicalCore(); |
| 34 | 34 | ||
| 35 | PhysicalCore(const PhysicalCore&) = delete; | 35 | PhysicalCore(const PhysicalCore&) = delete; |
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp index 6b445677e..81e23f700 100644 --- a/src/core/hle/kernel/svc.cpp +++ b/src/core/hle/kernel/svc.cpp | |||
| @@ -819,10 +819,10 @@ static ResultCode GetInfo(Core::System& system, u64* result, u64 info_id, Handle | |||
| 819 | return RESULT_SUCCESS; | 819 | return RESULT_SUCCESS; |
| 820 | } | 820 | } |
| 821 | 821 | ||
| 822 | Handle handle{}; | 822 | Handle resource_handle{}; |
| 823 | R_TRY(handle_table.Add(&handle, resource_limit)); | 823 | R_TRY(handle_table.Add(&resource_handle, resource_limit)); |
| 824 | 824 | ||
| 825 | *result = handle; | 825 | *result = resource_handle; |
| 826 | return RESULT_SUCCESS; | 826 | return RESULT_SUCCESS; |
| 827 | } | 827 | } |
| 828 | 828 | ||
diff --git a/src/core/hle/result.h b/src/core/hle/result.h index 8feda7ad7..43968386f 100644 --- a/src/core/hle/result.h +++ b/src/core/hle/result.h | |||
| @@ -56,7 +56,7 @@ enum class ErrorModule : u32 { | |||
| 56 | PCIe = 120, | 56 | PCIe = 120, |
| 57 | Friends = 121, | 57 | Friends = 121, |
| 58 | BCAT = 122, | 58 | BCAT = 122, |
| 59 | SSL = 123, | 59 | SSLSrv = 123, |
| 60 | Account = 124, | 60 | Account = 124, |
| 61 | News = 125, | 61 | News = 125, |
| 62 | Mii = 126, | 62 | Mii = 126, |
diff --git a/src/core/hle/service/am/am.cpp b/src/core/hle/service/am/am.cpp index 408e441dc..234173297 100644 --- a/src/core/hle/service/am/am.cpp +++ b/src/core/hle/service/am/am.cpp | |||
| @@ -833,7 +833,7 @@ IStorageImpl::~IStorageImpl() = default; | |||
| 833 | 833 | ||
| 834 | class StorageDataImpl final : public IStorageImpl { | 834 | class StorageDataImpl final : public IStorageImpl { |
| 835 | public: | 835 | public: |
| 836 | explicit StorageDataImpl(std::vector<u8>&& buffer) : buffer{std::move(buffer)} {} | 836 | explicit StorageDataImpl(std::vector<u8>&& buffer_) : buffer{std::move(buffer_)} {} |
| 837 | 837 | ||
| 838 | std::vector<u8>& GetData() override { | 838 | std::vector<u8>& GetData() override { |
| 839 | return buffer; | 839 | return buffer; |
| @@ -1513,9 +1513,9 @@ void IApplicationFunctions::GetDisplayVersion(Kernel::HLERequestContext& ctx) { | |||
| 1513 | 1513 | ||
| 1514 | const FileSys::PatchManager pm{title_id, system.GetFileSystemController(), | 1514 | const FileSys::PatchManager pm{title_id, system.GetFileSystemController(), |
| 1515 | system.GetContentProvider()}; | 1515 | system.GetContentProvider()}; |
| 1516 | auto res = pm.GetControlMetadata(); | 1516 | auto metadata = pm.GetControlMetadata(); |
| 1517 | if (res.first != nullptr) { | 1517 | if (metadata.first != nullptr) { |
| 1518 | return res; | 1518 | return metadata; |
| 1519 | } | 1519 | } |
| 1520 | 1520 | ||
| 1521 | const FileSys::PatchManager pm_update{FileSys::GetUpdateTitleID(title_id), | 1521 | const FileSys::PatchManager pm_update{FileSys::GetUpdateTitleID(title_id), |
| @@ -1550,9 +1550,9 @@ void IApplicationFunctions::GetDesiredLanguage(Kernel::HLERequestContext& ctx) { | |||
| 1550 | 1550 | ||
| 1551 | const FileSys::PatchManager pm{title_id, system.GetFileSystemController(), | 1551 | const FileSys::PatchManager pm{title_id, system.GetFileSystemController(), |
| 1552 | system.GetContentProvider()}; | 1552 | system.GetContentProvider()}; |
| 1553 | auto res = pm.GetControlMetadata(); | 1553 | auto metadata = pm.GetControlMetadata(); |
| 1554 | if (res.first != nullptr) { | 1554 | if (metadata.first != nullptr) { |
| 1555 | return res; | 1555 | return metadata; |
| 1556 | } | 1556 | } |
| 1557 | 1557 | ||
| 1558 | const FileSys::PatchManager pm_update{FileSys::GetUpdateTitleID(title_id), | 1558 | const FileSys::PatchManager pm_update{FileSys::GetUpdateTitleID(title_id), |
diff --git a/src/core/hle/service/apm/controller.cpp b/src/core/hle/service/apm/controller.cpp index 00c174bb0..8bfa7c0e4 100644 --- a/src/core/hle/service/apm/controller.cpp +++ b/src/core/hle/service/apm/controller.cpp | |||
| @@ -15,11 +15,11 @@ namespace Service::APM { | |||
| 15 | 15 | ||
| 16 | constexpr auto DEFAULT_PERFORMANCE_CONFIGURATION = PerformanceConfiguration::Config7; | 16 | constexpr auto DEFAULT_PERFORMANCE_CONFIGURATION = PerformanceConfiguration::Config7; |
| 17 | 17 | ||
| 18 | Controller::Controller(Core::Timing::CoreTiming& core_timing) | 18 | Controller::Controller(Core::Timing::CoreTiming& core_timing_) |
| 19 | : core_timing{core_timing}, configs{ | 19 | : core_timing{core_timing_}, configs{ |
| 20 | {PerformanceMode::Handheld, DEFAULT_PERFORMANCE_CONFIGURATION}, | 20 | {PerformanceMode::Handheld, DEFAULT_PERFORMANCE_CONFIGURATION}, |
| 21 | {PerformanceMode::Docked, DEFAULT_PERFORMANCE_CONFIGURATION}, | 21 | {PerformanceMode::Docked, DEFAULT_PERFORMANCE_CONFIGURATION}, |
| 22 | } {} | 22 | } {} |
| 23 | 23 | ||
| 24 | Controller::~Controller() = default; | 24 | Controller::~Controller() = default; |
| 25 | 25 | ||
diff --git a/src/core/hle/service/apm/controller.h b/src/core/hle/service/apm/controller.h index af0c4cd34..8d48e0104 100644 --- a/src/core/hle/service/apm/controller.h +++ b/src/core/hle/service/apm/controller.h | |||
| @@ -50,7 +50,7 @@ enum class PerformanceMode : u8 { | |||
| 50 | // system during times of high load -- this simply maps to different PerformanceConfigs to use. | 50 | // system during times of high load -- this simply maps to different PerformanceConfigs to use. |
| 51 | class Controller { | 51 | class Controller { |
| 52 | public: | 52 | public: |
| 53 | explicit Controller(Core::Timing::CoreTiming& core_timing); | 53 | explicit Controller(Core::Timing::CoreTiming& core_timing_); |
| 54 | ~Controller(); | 54 | ~Controller(); |
| 55 | 55 | ||
| 56 | void SetPerformanceConfiguration(PerformanceMode mode, PerformanceConfiguration config); | 56 | void SetPerformanceConfiguration(PerformanceMode mode, PerformanceConfiguration config); |
diff --git a/src/core/hle/service/audio/audren_u.cpp b/src/core/hle/service/audio/audren_u.cpp index 65887011f..ae4284adf 100644 --- a/src/core/hle/service/audio/audren_u.cpp +++ b/src/core/hle/service/audio/audren_u.cpp | |||
| @@ -362,7 +362,7 @@ void AudRenU::GetAudioRendererWorkBufferSize(Kernel::HLERequestContext& ctx) { | |||
| 362 | static constexpr u64 max_perf_detail_entries = 100; | 362 | static constexpr u64 max_perf_detail_entries = 100; |
| 363 | 363 | ||
| 364 | // Size of the data structure representing the bulk of the voice-related state. | 364 | // Size of the data structure representing the bulk of the voice-related state. |
| 365 | static constexpr u64 voice_state_size = 0x100; | 365 | static constexpr u64 voice_state_size_bytes = 0x100; |
| 366 | 366 | ||
| 367 | // Size of the upsampler manager data structure | 367 | // Size of the upsampler manager data structure |
| 368 | constexpr u64 upsampler_manager_size = 0x48; | 368 | constexpr u64 upsampler_manager_size = 0x48; |
| @@ -449,7 +449,8 @@ void AudRenU::GetAudioRendererWorkBufferSize(Kernel::HLERequestContext& ctx) { | |||
| 449 | size += Common::AlignUp(voice_info_size * params.voice_count, info_field_alignment_size); | 449 | size += Common::AlignUp(voice_info_size * params.voice_count, info_field_alignment_size); |
| 450 | size += | 450 | size += |
| 451 | Common::AlignUp(voice_resource_size * params.voice_count, info_field_alignment_size); | 451 | Common::AlignUp(voice_resource_size * params.voice_count, info_field_alignment_size); |
| 452 | size += Common::AlignUp(voice_state_size * params.voice_count, info_field_alignment_size); | 452 | size += |
| 453 | Common::AlignUp(voice_state_size_bytes * params.voice_count, info_field_alignment_size); | ||
| 453 | return size; | 454 | return size; |
| 454 | }; | 455 | }; |
| 455 | 456 | ||
diff --git a/src/core/hle/service/audio/hwopus.cpp b/src/core/hle/service/audio/hwopus.cpp index 19c578b3a..ee5ec8cd6 100644 --- a/src/core/hle/service/audio/hwopus.cpp +++ b/src/core/hle/service/audio/hwopus.cpp | |||
| @@ -50,8 +50,8 @@ public: | |||
| 50 | Enabled, | 50 | Enabled, |
| 51 | }; | 51 | }; |
| 52 | 52 | ||
| 53 | explicit OpusDecoderState(OpusDecoderPtr decoder, u32 sample_rate, u32 channel_count) | 53 | explicit OpusDecoderState(OpusDecoderPtr decoder_, u32 sample_rate_, u32 channel_count_) |
| 54 | : decoder{std::move(decoder)}, sample_rate{sample_rate}, channel_count{channel_count} {} | 54 | : decoder{std::move(decoder_)}, sample_rate{sample_rate_}, channel_count{channel_count_} {} |
| 55 | 55 | ||
| 56 | // Decodes interleaved Opus packets. Optionally allows reporting time taken to | 56 | // Decodes interleaved Opus packets. Optionally allows reporting time taken to |
| 57 | // perform the decoding, as well as any relevant extra behavior. | 57 | // perform the decoding, as well as any relevant extra behavior. |
| @@ -160,9 +160,9 @@ private: | |||
| 160 | 160 | ||
| 161 | class IHardwareOpusDecoderManager final : public ServiceFramework<IHardwareOpusDecoderManager> { | 161 | class IHardwareOpusDecoderManager final : public ServiceFramework<IHardwareOpusDecoderManager> { |
| 162 | public: | 162 | public: |
| 163 | explicit IHardwareOpusDecoderManager(Core::System& system_, OpusDecoderState decoder_state) | 163 | explicit IHardwareOpusDecoderManager(Core::System& system_, OpusDecoderState decoder_state_) |
| 164 | : ServiceFramework{system_, "IHardwareOpusDecoderManager"}, decoder_state{ | 164 | : ServiceFramework{system_, "IHardwareOpusDecoderManager"}, decoder_state{ |
| 165 | std::move(decoder_state)} { | 165 | std::move(decoder_state_)} { |
| 166 | // clang-format off | 166 | // clang-format off |
| 167 | static const FunctionInfo functions[] = { | 167 | static const FunctionInfo functions[] = { |
| 168 | {0, &IHardwareOpusDecoderManager::DecodeInterleavedOld, "DecodeInterleavedOld"}, | 168 | {0, &IHardwareOpusDecoderManager::DecodeInterleavedOld, "DecodeInterleavedOld"}, |
diff --git a/src/core/hle/service/bcat/backend/boxcat.cpp b/src/core/hle/service/bcat/backend/boxcat.cpp index cee1774d1..d6d2f52e5 100644 --- a/src/core/hle/service/bcat/backend/boxcat.cpp +++ b/src/core/hle/service/bcat/backend/boxcat.cpp | |||
| @@ -3,9 +3,18 @@ | |||
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include <fmt/ostream.h> | 5 | #include <fmt/ostream.h> |
| 6 | |||
| 7 | #ifdef __GNUC__ | ||
| 8 | #pragma GCC diagnostic push | ||
| 9 | #pragma GCC diagnostic ignored "-Wshadow" | ||
| 10 | #endif | ||
| 6 | #include <httplib.h> | 11 | #include <httplib.h> |
| 7 | #include <mbedtls/sha256.h> | 12 | #include <mbedtls/sha256.h> |
| 8 | #include <nlohmann/json.hpp> | 13 | #include <nlohmann/json.hpp> |
| 14 | #ifdef __GNUC__ | ||
| 15 | #pragma GCC diagnostic pop | ||
| 16 | #endif | ||
| 17 | |||
| 9 | #include "common/hex_util.h" | 18 | #include "common/hex_util.h" |
| 10 | #include "common/logging/backend.h" | 19 | #include "common/logging/backend.h" |
| 11 | #include "common/logging/log.h" | 20 | #include "common/logging/log.h" |
| @@ -178,8 +187,8 @@ bool VfsRawCopyDProgress(FileSys::VirtualDir src, FileSys::VirtualDir dest, | |||
| 178 | 187 | ||
| 179 | class Boxcat::Client { | 188 | class Boxcat::Client { |
| 180 | public: | 189 | public: |
| 181 | Client(std::string path, u64 title_id, u64 build_id) | 190 | Client(std::string path_, u64 title_id_, u64 build_id_) |
| 182 | : path(std::move(path)), title_id(title_id), build_id(build_id) {} | 191 | : path(std::move(path_)), title_id(title_id_), build_id(build_id_) {} |
| 183 | 192 | ||
| 184 | DownloadResult DownloadDataZip() { | 193 | DownloadResult DownloadDataZip() { |
| 185 | return DownloadInternal(fmt::format(BOXCAT_PATHNAME_DATA, title_id), TIMEOUT_SECONDS, | 194 | return DownloadInternal(fmt::format(BOXCAT_PATHNAME_DATA, title_id), TIMEOUT_SECONDS, |
diff --git a/src/core/hle/service/hid/controllers/controller_base.cpp b/src/core/hle/service/hid/controllers/controller_base.cpp index 8091db9d7..9d1e6db6a 100644 --- a/src/core/hle/service/hid/controllers/controller_base.cpp +++ b/src/core/hle/service/hid/controllers/controller_base.cpp | |||
| @@ -6,7 +6,7 @@ | |||
| 6 | 6 | ||
| 7 | namespace Service::HID { | 7 | namespace Service::HID { |
| 8 | 8 | ||
| 9 | ControllerBase::ControllerBase(Core::System& system) : system(system) {} | 9 | ControllerBase::ControllerBase(Core::System& system_) : system(system_) {} |
| 10 | ControllerBase::~ControllerBase() = default; | 10 | ControllerBase::~ControllerBase() = default; |
| 11 | 11 | ||
| 12 | void ControllerBase::ActivateController() { | 12 | void ControllerBase::ActivateController() { |
diff --git a/src/core/hle/service/hid/controllers/controller_base.h b/src/core/hle/service/hid/controllers/controller_base.h index f47a9e61c..1556fb08e 100644 --- a/src/core/hle/service/hid/controllers/controller_base.h +++ b/src/core/hle/service/hid/controllers/controller_base.h | |||
| @@ -18,7 +18,7 @@ class System; | |||
| 18 | namespace Service::HID { | 18 | namespace Service::HID { |
| 19 | class ControllerBase { | 19 | class ControllerBase { |
| 20 | public: | 20 | public: |
| 21 | explicit ControllerBase(Core::System& system); | 21 | explicit ControllerBase(Core::System& system_); |
| 22 | virtual ~ControllerBase(); | 22 | virtual ~ControllerBase(); |
| 23 | 23 | ||
| 24 | // Called when the controller is initialized | 24 | // Called when the controller is initialized |
diff --git a/src/core/hle/service/hid/controllers/gesture.cpp b/src/core/hle/service/hid/controllers/gesture.cpp index 9e5df3bb7..d311f754b 100644 --- a/src/core/hle/service/hid/controllers/gesture.cpp +++ b/src/core/hle/service/hid/controllers/gesture.cpp | |||
| @@ -23,7 +23,7 @@ constexpr f32 Square(s32 num) { | |||
| 23 | return static_cast<f32>(num * num); | 23 | return static_cast<f32>(num * num); |
| 24 | } | 24 | } |
| 25 | 25 | ||
| 26 | Controller_Gesture::Controller_Gesture(Core::System& system) : ControllerBase(system) {} | 26 | Controller_Gesture::Controller_Gesture(Core::System& system_) : ControllerBase(system_) {} |
| 27 | Controller_Gesture::~Controller_Gesture() = default; | 27 | Controller_Gesture::~Controller_Gesture() = default; |
| 28 | 28 | ||
| 29 | void Controller_Gesture::OnInit() { | 29 | void Controller_Gesture::OnInit() { |
| @@ -211,15 +211,16 @@ void Controller_Gesture::UpdateExistingGesture(GestureProperties& gesture, Touch | |||
| 211 | } | 211 | } |
| 212 | } | 212 | } |
| 213 | 213 | ||
| 214 | void Controller_Gesture::EndGesture(GestureProperties& gesture, GestureProperties& last_gesture, | 214 | void Controller_Gesture::EndGesture(GestureProperties& gesture, |
| 215 | TouchType& type, Attribute& attributes, f32 time_difference) { | 215 | GestureProperties& last_gesture_props, TouchType& type, |
| 216 | Attribute& attributes, f32 time_difference) { | ||
| 216 | const auto& last_entry = | 217 | const auto& last_entry = |
| 217 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; | 218 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; |
| 218 | if (last_gesture.active_points != 0) { | 219 | if (last_gesture_props.active_points != 0) { |
| 219 | switch (last_entry.type) { | 220 | switch (last_entry.type) { |
| 220 | case TouchType::Touch: | 221 | case TouchType::Touch: |
| 221 | if (enable_press_and_tap) { | 222 | if (enable_press_and_tap) { |
| 222 | SetTapEvent(gesture, last_gesture, type, attributes); | 223 | SetTapEvent(gesture, last_gesture_props, type, attributes); |
| 223 | return; | 224 | return; |
| 224 | } | 225 | } |
| 225 | type = TouchType::Cancel; | 226 | type = TouchType::Cancel; |
| @@ -234,7 +235,7 @@ void Controller_Gesture::EndGesture(GestureProperties& gesture, GesturePropertie | |||
| 234 | force_update = true; | 235 | force_update = true; |
| 235 | break; | 236 | break; |
| 236 | case TouchType::Pan: | 237 | case TouchType::Pan: |
| 237 | EndPanEvent(gesture, last_gesture, type, time_difference); | 238 | EndPanEvent(gesture, last_gesture_props, type, time_difference); |
| 238 | break; | 239 | break; |
| 239 | default: | 240 | default: |
| 240 | break; | 241 | break; |
| @@ -246,10 +247,11 @@ void Controller_Gesture::EndGesture(GestureProperties& gesture, GesturePropertie | |||
| 246 | } | 247 | } |
| 247 | } | 248 | } |
| 248 | 249 | ||
| 249 | void Controller_Gesture::SetTapEvent(GestureProperties& gesture, GestureProperties& last_gesture, | 250 | void Controller_Gesture::SetTapEvent(GestureProperties& gesture, |
| 250 | TouchType& type, Attribute& attributes) { | 251 | GestureProperties& last_gesture_props, TouchType& type, |
| 252 | Attribute& attributes) { | ||
| 251 | type = TouchType::Tap; | 253 | type = TouchType::Tap; |
| 252 | gesture = last_gesture; | 254 | gesture = last_gesture_props; |
| 253 | force_update = true; | 255 | force_update = true; |
| 254 | f32 tap_time_difference = | 256 | f32 tap_time_difference = |
| 255 | static_cast<f32>(last_update_timestamp - last_tap_timestamp) / (1000 * 1000 * 1000); | 257 | static_cast<f32>(last_update_timestamp - last_tap_timestamp) / (1000 * 1000 * 1000); |
| @@ -259,8 +261,9 @@ void Controller_Gesture::SetTapEvent(GestureProperties& gesture, GestureProperti | |||
| 259 | } | 261 | } |
| 260 | } | 262 | } |
| 261 | 263 | ||
| 262 | void Controller_Gesture::UpdatePanEvent(GestureProperties& gesture, GestureProperties& last_gesture, | 264 | void Controller_Gesture::UpdatePanEvent(GestureProperties& gesture, |
| 263 | TouchType& type, f32 time_difference) { | 265 | GestureProperties& last_gesture_props, TouchType& type, |
| 266 | f32 time_difference) { | ||
| 264 | auto& cur_entry = shared_memory.gesture_states[shared_memory.header.last_entry_index]; | 267 | auto& cur_entry = shared_memory.gesture_states[shared_memory.header.last_entry_index]; |
| 265 | const auto& last_entry = | 268 | const auto& last_entry = |
| 266 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; | 269 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; |
| @@ -272,13 +275,14 @@ void Controller_Gesture::UpdatePanEvent(GestureProperties& gesture, GesturePrope | |||
| 272 | last_pan_time_difference = time_difference; | 275 | last_pan_time_difference = time_difference; |
| 273 | 276 | ||
| 274 | // Promote to pinch type | 277 | // Promote to pinch type |
| 275 | if (std::abs(gesture.average_distance - last_gesture.average_distance) > pinch_threshold) { | 278 | if (std::abs(gesture.average_distance - last_gesture_props.average_distance) > |
| 279 | pinch_threshold) { | ||
| 276 | type = TouchType::Pinch; | 280 | type = TouchType::Pinch; |
| 277 | cur_entry.scale = gesture.average_distance / last_gesture.average_distance; | 281 | cur_entry.scale = gesture.average_distance / last_gesture_props.average_distance; |
| 278 | } | 282 | } |
| 279 | 283 | ||
| 280 | const f32 angle_between_two_lines = std::atan((gesture.angle - last_gesture.angle) / | 284 | const f32 angle_between_two_lines = std::atan((gesture.angle - last_gesture_props.angle) / |
| 281 | (1 + (gesture.angle * last_gesture.angle))); | 285 | (1 + (gesture.angle * last_gesture_props.angle))); |
| 282 | // Promote to rotate type | 286 | // Promote to rotate type |
| 283 | if (std::abs(angle_between_two_lines) > angle_threshold) { | 287 | if (std::abs(angle_between_two_lines) > angle_threshold) { |
| 284 | type = TouchType::Rotate; | 288 | type = TouchType::Rotate; |
| @@ -287,8 +291,9 @@ void Controller_Gesture::UpdatePanEvent(GestureProperties& gesture, GesturePrope | |||
| 287 | } | 291 | } |
| 288 | } | 292 | } |
| 289 | 293 | ||
| 290 | void Controller_Gesture::EndPanEvent(GestureProperties& gesture, GestureProperties& last_gesture, | 294 | void Controller_Gesture::EndPanEvent(GestureProperties& gesture, |
| 291 | TouchType& type, f32 time_difference) { | 295 | GestureProperties& last_gesture_props, TouchType& type, |
| 296 | f32 time_difference) { | ||
| 292 | auto& cur_entry = shared_memory.gesture_states[shared_memory.header.last_entry_index]; | 297 | auto& cur_entry = shared_memory.gesture_states[shared_memory.header.last_entry_index]; |
| 293 | const auto& last_entry = | 298 | const auto& last_entry = |
| 294 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; | 299 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; |
| @@ -301,7 +306,7 @@ void Controller_Gesture::EndPanEvent(GestureProperties& gesture, GestureProperti | |||
| 301 | 306 | ||
| 302 | // Set swipe event with parameters | 307 | // Set swipe event with parameters |
| 303 | if (curr_vel > swipe_threshold) { | 308 | if (curr_vel > swipe_threshold) { |
| 304 | SetSwipeEvent(gesture, last_gesture, type); | 309 | SetSwipeEvent(gesture, last_gesture_props, type); |
| 305 | return; | 310 | return; |
| 306 | } | 311 | } |
| 307 | 312 | ||
| @@ -312,13 +317,13 @@ void Controller_Gesture::EndPanEvent(GestureProperties& gesture, GestureProperti | |||
| 312 | force_update = true; | 317 | force_update = true; |
| 313 | } | 318 | } |
| 314 | 319 | ||
| 315 | void Controller_Gesture::SetSwipeEvent(GestureProperties& gesture, GestureProperties& last_gesture, | 320 | void Controller_Gesture::SetSwipeEvent(GestureProperties& gesture, |
| 316 | TouchType& type) { | 321 | GestureProperties& last_gesture_props, TouchType& type) { |
| 317 | auto& cur_entry = shared_memory.gesture_states[shared_memory.header.last_entry_index]; | 322 | auto& cur_entry = shared_memory.gesture_states[shared_memory.header.last_entry_index]; |
| 318 | const auto& last_entry = | 323 | const auto& last_entry = |
| 319 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; | 324 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; |
| 320 | type = TouchType::Swipe; | 325 | type = TouchType::Swipe; |
| 321 | gesture = last_gesture; | 326 | gesture = last_gesture_props; |
| 322 | force_update = true; | 327 | force_update = true; |
| 323 | cur_entry.delta_x = last_entry.delta_x; | 328 | cur_entry.delta_x = last_entry.delta_x; |
| 324 | cur_entry.delta_y = last_entry.delta_y; | 329 | cur_entry.delta_y = last_entry.delta_y; |
diff --git a/src/core/hle/service/hid/controllers/gesture.h b/src/core/hle/service/hid/controllers/gesture.h index 18110a6ad..f46e29411 100644 --- a/src/core/hle/service/hid/controllers/gesture.h +++ b/src/core/hle/service/hid/controllers/gesture.h | |||
| @@ -128,32 +128,34 @@ private: | |||
| 128 | void UpdateExistingGesture(GestureProperties& gesture, TouchType& type, f32 time_difference); | 128 | void UpdateExistingGesture(GestureProperties& gesture, TouchType& type, f32 time_difference); |
| 129 | 129 | ||
| 130 | // Terminates exiting gesture | 130 | // Terminates exiting gesture |
| 131 | void EndGesture(GestureProperties& gesture, GestureProperties& last_gesture, TouchType& type, | 131 | void EndGesture(GestureProperties& gesture, GestureProperties& last_gesture_props, |
| 132 | Attribute& attributes, f32 time_difference); | 132 | TouchType& type, Attribute& attributes, f32 time_difference); |
| 133 | 133 | ||
| 134 | // Set current event to a tap event | 134 | // Set current event to a tap event |
| 135 | void SetTapEvent(GestureProperties& gesture, GestureProperties& last_gesture, TouchType& type, | 135 | void SetTapEvent(GestureProperties& gesture, GestureProperties& last_gesture_props, |
| 136 | Attribute& attributes); | 136 | TouchType& type, Attribute& attributes); |
| 137 | 137 | ||
| 138 | // Calculates and set the extra parameters related to a pan event | 138 | // Calculates and set the extra parameters related to a pan event |
| 139 | void UpdatePanEvent(GestureProperties& gesture, GestureProperties& last_gesture, | 139 | void UpdatePanEvent(GestureProperties& gesture, GestureProperties& last_gesture_props, |
| 140 | TouchType& type, f32 time_difference); | 140 | TouchType& type, f32 time_difference); |
| 141 | 141 | ||
| 142 | // Terminates the pan event | 142 | // Terminates the pan event |
| 143 | void EndPanEvent(GestureProperties& gesture, GestureProperties& last_gesture, TouchType& type, | 143 | void EndPanEvent(GestureProperties& gesture, GestureProperties& last_gesture_props, |
| 144 | f32 time_difference); | 144 | TouchType& type, f32 time_difference); |
| 145 | 145 | ||
| 146 | // Set current event to a swipe event | 146 | // Set current event to a swipe event |
| 147 | void SetSwipeEvent(GestureProperties& gesture, GestureProperties& last_gesture, | 147 | void SetSwipeEvent(GestureProperties& gesture, GestureProperties& last_gesture_props, |
| 148 | TouchType& type); | 148 | TouchType& type); |
| 149 | 149 | ||
| 150 | // Returns an unused finger id, if there is no fingers avaliable MAX_FINGERS will be returned | 150 | // Returns an unused finger id, if there is no fingers available std::nullopt is returned. |
| 151 | std::optional<size_t> GetUnusedFingerID() const; | 151 | std::optional<size_t> GetUnusedFingerID() const; |
| 152 | 152 | ||
| 153 | /** If the touch is new it tries to assing a new finger id, if there is no fingers avaliable no | 153 | /** |
| 154 | * If the touch is new it tries to assign a new finger id, if there is no fingers available no | ||
| 154 | * changes will be made. Updates the coordinates if the finger id it's already set. If the touch | 155 | * changes will be made. Updates the coordinates if the finger id it's already set. If the touch |
| 155 | * ends delays the output by one frame to set the end_touch flag before finally freeing the | 156 | * ends delays the output by one frame to set the end_touch flag before finally freeing the |
| 156 | * finger id */ | 157 | * finger id |
| 158 | */ | ||
| 157 | size_t UpdateTouchInputEvent(const std::tuple<float, float, bool>& touch_input, | 159 | size_t UpdateTouchInputEvent(const std::tuple<float, float, bool>& touch_input, |
| 158 | size_t finger_id); | 160 | size_t finger_id); |
| 159 | 161 | ||
diff --git a/src/core/hle/service/mii/manager.h b/src/core/hle/service/mii/manager.h index 2106a528a..ec7efa5f7 100644 --- a/src/core/hle/service/mii/manager.h +++ b/src/core/hle/service/mii/manager.h | |||
| @@ -89,7 +89,7 @@ static_assert(std::has_unique_object_representations_v<MiiInfo>, | |||
| 89 | #pragma pack(push, 4) | 89 | #pragma pack(push, 4) |
| 90 | 90 | ||
| 91 | struct MiiInfoElement { | 91 | struct MiiInfoElement { |
| 92 | MiiInfoElement(const MiiInfo& info, Source source) : info{info}, source{source} {} | 92 | MiiInfoElement(const MiiInfo& info_, Source source_) : info{info_}, source{source_} {} |
| 93 | 93 | ||
| 94 | MiiInfo info{}; | 94 | MiiInfo info{}; |
| 95 | Source source{}; | 95 | Source source{}; |
diff --git a/src/core/hle/service/mii/mii.cpp b/src/core/hle/service/mii/mii.cpp index 26be9e45b..81f150a88 100644 --- a/src/core/hle/service/mii/mii.cpp +++ b/src/core/hle/service/mii/mii.cpp | |||
| @@ -253,8 +253,8 @@ private: | |||
| 253 | 253 | ||
| 254 | class MiiDBModule final : public ServiceFramework<MiiDBModule> { | 254 | class MiiDBModule final : public ServiceFramework<MiiDBModule> { |
| 255 | public: | 255 | public: |
| 256 | explicit MiiDBModule(Core::System& system_, const char* name) | 256 | explicit MiiDBModule(Core::System& system_, const char* name_) |
| 257 | : ServiceFramework{system_, name} { | 257 | : ServiceFramework{system_, name_} { |
| 258 | // clang-format off | 258 | // clang-format off |
| 259 | static const FunctionInfo functions[] = { | 259 | static const FunctionInfo functions[] = { |
| 260 | {0, &MiiDBModule::GetDatabaseService, "GetDatabaseService"}, | 260 | {0, &MiiDBModule::GetDatabaseService, "GetDatabaseService"}, |
diff --git a/src/core/hle/service/nvdrv/devices/nvdevice.h b/src/core/hle/service/nvdrv/devices/nvdevice.h index b37f023df..5b73a5a34 100644 --- a/src/core/hle/service/nvdrv/devices/nvdevice.h +++ b/src/core/hle/service/nvdrv/devices/nvdevice.h | |||
| @@ -21,7 +21,7 @@ namespace Service::Nvidia::Devices { | |||
| 21 | /// implement the ioctl interface. | 21 | /// implement the ioctl interface. |
| 22 | class nvdevice { | 22 | class nvdevice { |
| 23 | public: | 23 | public: |
| 24 | explicit nvdevice(Core::System& system) : system{system} {} | 24 | explicit nvdevice(Core::System& system_) : system{system_} {} |
| 25 | virtual ~nvdevice() = default; | 25 | virtual ~nvdevice() = default; |
| 26 | 26 | ||
| 27 | /** | 27 | /** |
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.h b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.h index 229bf6350..24e3151cb 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.h +++ b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.h | |||
| @@ -48,13 +48,13 @@ private: | |||
| 48 | public: | 48 | public: |
| 49 | constexpr BufferMap() = default; | 49 | constexpr BufferMap() = default; |
| 50 | 50 | ||
| 51 | constexpr BufferMap(GPUVAddr start_addr, std::size_t size) | 51 | constexpr BufferMap(GPUVAddr start_addr_, std::size_t size_) |
| 52 | : start_addr{start_addr}, end_addr{start_addr + size} {} | 52 | : start_addr{start_addr_}, end_addr{start_addr_ + size_} {} |
| 53 | 53 | ||
| 54 | constexpr BufferMap(GPUVAddr start_addr, std::size_t size, VAddr cpu_addr, | 54 | constexpr BufferMap(GPUVAddr start_addr_, std::size_t size_, VAddr cpu_addr_, |
| 55 | bool is_allocated) | 55 | bool is_allocated_) |
| 56 | : start_addr{start_addr}, end_addr{start_addr + size}, cpu_addr{cpu_addr}, | 56 | : start_addr{start_addr_}, end_addr{start_addr_ + size_}, cpu_addr{cpu_addr_}, |
| 57 | is_allocated{is_allocated} {} | 57 | is_allocated{is_allocated_} {} |
| 58 | 58 | ||
| 59 | constexpr VAddr StartAddr() const { | 59 | constexpr VAddr StartAddr() const { |
| 60 | return start_addr; | 60 | return start_addr; |
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_nvdec_common.h b/src/core/hle/service/nvdrv/devices/nvhost_nvdec_common.h index 14d0d210a..da10f5f41 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_nvdec_common.h +++ b/src/core/hle/service/nvdrv/devices/nvhost_nvdec_common.h | |||
| @@ -27,13 +27,13 @@ protected: | |||
| 27 | public: | 27 | public: |
| 28 | constexpr BufferMap() = default; | 28 | constexpr BufferMap() = default; |
| 29 | 29 | ||
| 30 | constexpr BufferMap(GPUVAddr start_addr, std::size_t size) | 30 | constexpr BufferMap(GPUVAddr start_addr_, std::size_t size_) |
| 31 | : start_addr{start_addr}, end_addr{start_addr + size} {} | 31 | : start_addr{start_addr_}, end_addr{start_addr_ + size_} {} |
| 32 | 32 | ||
| 33 | constexpr BufferMap(GPUVAddr start_addr, std::size_t size, VAddr cpu_addr, | 33 | constexpr BufferMap(GPUVAddr start_addr_, std::size_t size_, VAddr cpu_addr_, |
| 34 | bool is_allocated) | 34 | bool is_allocated_) |
| 35 | : start_addr{start_addr}, end_addr{start_addr + size}, cpu_addr{cpu_addr}, | 35 | : start_addr{start_addr_}, end_addr{start_addr_ + size_}, cpu_addr{cpu_addr_}, |
| 36 | is_allocated{is_allocated} {} | 36 | is_allocated{is_allocated_} {} |
| 37 | 37 | ||
| 38 | constexpr VAddr StartAddr() const { | 38 | constexpr VAddr StartAddr() const { |
| 39 | return start_addr; | 39 | return start_addr; |
diff --git a/src/core/hle/service/nvdrv/syncpoint_manager.cpp b/src/core/hle/service/nvdrv/syncpoint_manager.cpp index 0151a03b7..3b6f55526 100644 --- a/src/core/hle/service/nvdrv/syncpoint_manager.cpp +++ b/src/core/hle/service/nvdrv/syncpoint_manager.cpp | |||
| @@ -8,7 +8,7 @@ | |||
| 8 | 8 | ||
| 9 | namespace Service::Nvidia { | 9 | namespace Service::Nvidia { |
| 10 | 10 | ||
| 11 | SyncpointManager::SyncpointManager(Tegra::GPU& gpu) : gpu{gpu} {} | 11 | SyncpointManager::SyncpointManager(Tegra::GPU& gpu_) : gpu{gpu_} {} |
| 12 | 12 | ||
| 13 | SyncpointManager::~SyncpointManager() = default; | 13 | SyncpointManager::~SyncpointManager() = default; |
| 14 | 14 | ||
diff --git a/src/core/hle/service/nvdrv/syncpoint_manager.h b/src/core/hle/service/nvdrv/syncpoint_manager.h index d395c5d0b..99f286474 100644 --- a/src/core/hle/service/nvdrv/syncpoint_manager.h +++ b/src/core/hle/service/nvdrv/syncpoint_manager.h | |||
| @@ -18,7 +18,7 @@ namespace Service::Nvidia { | |||
| 18 | 18 | ||
| 19 | class SyncpointManager final { | 19 | class SyncpointManager final { |
| 20 | public: | 20 | public: |
| 21 | explicit SyncpointManager(Tegra::GPU& gpu); | 21 | explicit SyncpointManager(Tegra::GPU& gpu_); |
| 22 | ~SyncpointManager(); | 22 | ~SyncpointManager(); |
| 23 | 23 | ||
| 24 | /** | 24 | /** |
diff --git a/src/core/hle/service/nvflinger/buffer_queue.cpp b/src/core/hle/service/nvflinger/buffer_queue.cpp index 0b6e7430b..59ddf6298 100644 --- a/src/core/hle/service/nvflinger/buffer_queue.cpp +++ b/src/core/hle/service/nvflinger/buffer_queue.cpp | |||
| @@ -13,8 +13,8 @@ | |||
| 13 | 13 | ||
| 14 | namespace Service::NVFlinger { | 14 | namespace Service::NVFlinger { |
| 15 | 15 | ||
| 16 | BufferQueue::BufferQueue(Kernel::KernelCore& kernel, u32 id, u64 layer_id) | 16 | BufferQueue::BufferQueue(Kernel::KernelCore& kernel, u32 id_, u64 layer_id_) |
| 17 | : id(id), layer_id(layer_id), buffer_wait_event{kernel} { | 17 | : id(id_), layer_id(layer_id_), buffer_wait_event{kernel} { |
| 18 | Kernel::KAutoObject::Create(std::addressof(buffer_wait_event)); | 18 | Kernel::KAutoObject::Create(std::addressof(buffer_wait_event)); |
| 19 | buffer_wait_event.Initialize("BufferQueue:WaitEvent"); | 19 | buffer_wait_event.Initialize("BufferQueue:WaitEvent"); |
| 20 | } | 20 | } |
diff --git a/src/core/hle/service/nvflinger/buffer_queue.h b/src/core/hle/service/nvflinger/buffer_queue.h index 4ec0b1506..61e337ac5 100644 --- a/src/core/hle/service/nvflinger/buffer_queue.h +++ b/src/core/hle/service/nvflinger/buffer_queue.h | |||
| @@ -54,7 +54,7 @@ public: | |||
| 54 | NativeWindowFormat = 2, | 54 | NativeWindowFormat = 2, |
| 55 | }; | 55 | }; |
| 56 | 56 | ||
| 57 | explicit BufferQueue(Kernel::KernelCore& kernel, u32 id, u64 layer_id); | 57 | explicit BufferQueue(Kernel::KernelCore& kernel, u32 id_, u64 layer_id_); |
| 58 | ~BufferQueue(); | 58 | ~BufferQueue(); |
| 59 | 59 | ||
| 60 | enum class BufferTransformFlags : u32 { | 60 | enum class BufferTransformFlags : u32 { |
diff --git a/src/core/hle/service/nvflinger/nvflinger.cpp b/src/core/hle/service/nvflinger/nvflinger.cpp index 7fb9133c7..72c630b4e 100644 --- a/src/core/hle/service/nvflinger/nvflinger.cpp +++ b/src/core/hle/service/nvflinger/nvflinger.cpp | |||
| @@ -61,7 +61,7 @@ void NVFlinger::SplitVSync() { | |||
| 61 | } | 61 | } |
| 62 | } | 62 | } |
| 63 | 63 | ||
| 64 | NVFlinger::NVFlinger(Core::System& system) : system(system) { | 64 | NVFlinger::NVFlinger(Core::System& system_) : system(system_) { |
| 65 | displays.emplace_back(0, "Default", system); | 65 | displays.emplace_back(0, "Default", system); |
| 66 | displays.emplace_back(1, "External", system); | 66 | displays.emplace_back(1, "External", system); |
| 67 | displays.emplace_back(2, "Edid", system); | 67 | displays.emplace_back(2, "Edid", system); |
diff --git a/src/core/hle/service/nvflinger/nvflinger.h b/src/core/hle/service/nvflinger/nvflinger.h index b0febdaec..b1cab7db3 100644 --- a/src/core/hle/service/nvflinger/nvflinger.h +++ b/src/core/hle/service/nvflinger/nvflinger.h | |||
| @@ -45,7 +45,7 @@ class BufferQueue; | |||
| 45 | 45 | ||
| 46 | class NVFlinger final { | 46 | class NVFlinger final { |
| 47 | public: | 47 | public: |
| 48 | explicit NVFlinger(Core::System& system); | 48 | explicit NVFlinger(Core::System& system_); |
| 49 | ~NVFlinger(); | 49 | ~NVFlinger(); |
| 50 | 50 | ||
| 51 | /// Sets the NVDrv module instance to use to send buffers to the GPU. | 51 | /// Sets the NVDrv module instance to use to send buffers to the GPU. |
diff --git a/src/core/hle/service/pctl/pctl.cpp b/src/core/hle/service/pctl/pctl.cpp index e4d155c86..908e0a1e3 100644 --- a/src/core/hle/service/pctl/pctl.cpp +++ b/src/core/hle/service/pctl/pctl.cpp | |||
| @@ -7,8 +7,8 @@ | |||
| 7 | namespace Service::PCTL { | 7 | namespace Service::PCTL { |
| 8 | 8 | ||
| 9 | PCTL::PCTL(Core::System& system_, std::shared_ptr<Module> module_, const char* name, | 9 | PCTL::PCTL(Core::System& system_, std::shared_ptr<Module> module_, const char* name, |
| 10 | Capability capability) | 10 | Capability capability_) |
| 11 | : Interface{system_, std::move(module_), name, capability} { | 11 | : Interface{system_, std::move(module_), name, capability_} { |
| 12 | static const FunctionInfo functions[] = { | 12 | static const FunctionInfo functions[] = { |
| 13 | {0, &PCTL::CreateService, "CreateService"}, | 13 | {0, &PCTL::CreateService, "CreateService"}, |
| 14 | {1, &PCTL::CreateServiceWithoutInitialize, "CreateServiceWithoutInitialize"}, | 14 | {1, &PCTL::CreateServiceWithoutInitialize, "CreateServiceWithoutInitialize"}, |
diff --git a/src/core/hle/service/pctl/pctl.h b/src/core/hle/service/pctl/pctl.h index fd0a1e486..ea3b97823 100644 --- a/src/core/hle/service/pctl/pctl.h +++ b/src/core/hle/service/pctl/pctl.h | |||
| @@ -15,7 +15,7 @@ namespace Service::PCTL { | |||
| 15 | class PCTL final : public Module::Interface { | 15 | class PCTL final : public Module::Interface { |
| 16 | public: | 16 | public: |
| 17 | explicit PCTL(Core::System& system_, std::shared_ptr<Module> module_, const char* name, | 17 | explicit PCTL(Core::System& system_, std::shared_ptr<Module> module_, const char* name, |
| 18 | Capability capability); | 18 | Capability capability_); |
| 19 | ~PCTL() override; | 19 | ~PCTL() override; |
| 20 | }; | 20 | }; |
| 21 | 21 | ||
diff --git a/src/core/hle/service/pm/pm.cpp b/src/core/hle/service/pm/pm.cpp index f4715935d..a43185c44 100644 --- a/src/core/hle/service/pm/pm.cpp +++ b/src/core/hle/service/pm/pm.cpp | |||
| @@ -31,8 +31,8 @@ std::optional<Kernel::KProcess*> SearchProcessList( | |||
| 31 | 31 | ||
| 32 | void GetApplicationPidGeneric(Kernel::HLERequestContext& ctx, | 32 | void GetApplicationPidGeneric(Kernel::HLERequestContext& ctx, |
| 33 | const std::vector<Kernel::KProcess*>& process_list) { | 33 | const std::vector<Kernel::KProcess*>& process_list) { |
| 34 | const auto process = SearchProcessList(process_list, [](const auto& process) { | 34 | const auto process = SearchProcessList(process_list, [](const auto& proc) { |
| 35 | return process->GetProcessID() == Kernel::KProcess::ProcessIDMin; | 35 | return proc->GetProcessID() == Kernel::KProcess::ProcessIDMin; |
| 36 | }); | 36 | }); |
| 37 | 37 | ||
| 38 | IPC::ResponseBuilder rb{ctx, 4}; | 38 | IPC::ResponseBuilder rb{ctx, 4}; |
| @@ -100,8 +100,8 @@ private: | |||
| 100 | LOG_DEBUG(Service_PM, "called, title_id={:016X}", title_id); | 100 | LOG_DEBUG(Service_PM, "called, title_id={:016X}", title_id); |
| 101 | 101 | ||
| 102 | const auto process = | 102 | const auto process = |
| 103 | SearchProcessList(kernel.GetProcessList(), [title_id](const auto& process) { | 103 | SearchProcessList(kernel.GetProcessList(), [title_id](const auto& proc) { |
| 104 | return process->GetTitleID() == title_id; | 104 | return proc->GetTitleID() == title_id; |
| 105 | }); | 105 | }); |
| 106 | 106 | ||
| 107 | if (!process.has_value()) { | 107 | if (!process.has_value()) { |
| @@ -140,8 +140,8 @@ private: | |||
| 140 | 140 | ||
| 141 | LOG_DEBUG(Service_PM, "called, process_id={:016X}", process_id); | 141 | LOG_DEBUG(Service_PM, "called, process_id={:016X}", process_id); |
| 142 | 142 | ||
| 143 | const auto process = SearchProcessList(process_list, [process_id](const auto& process) { | 143 | const auto process = SearchProcessList(process_list, [process_id](const auto& proc) { |
| 144 | return process->GetProcessID() == process_id; | 144 | return proc->GetProcessID() == process_id; |
| 145 | }); | 145 | }); |
| 146 | 146 | ||
| 147 | if (!process.has_value()) { | 147 | if (!process.has_value()) { |
diff --git a/src/core/hle/service/service.h b/src/core/hle/service/service.h index 3dfb0740a..4c048173b 100644 --- a/src/core/hle/service/service.h +++ b/src/core/hle/service/service.h | |||
| @@ -155,17 +155,17 @@ protected: | |||
| 155 | /** | 155 | /** |
| 156 | * Constructs a FunctionInfo for a function. | 156 | * Constructs a FunctionInfo for a function. |
| 157 | * | 157 | * |
| 158 | * @param expected_header request header in the command buffer which will trigger dispatch | 158 | * @param expected_header_ request header in the command buffer which will trigger dispatch |
| 159 | * to this handler | 159 | * to this handler |
| 160 | * @param handler_callback member function in this service which will be called to handle | 160 | * @param handler_callback_ member function in this service which will be called to handle |
| 161 | * the request | 161 | * the request |
| 162 | * @param name human-friendly name for the request. Used mostly for logging purposes. | 162 | * @param name_ human-friendly name for the request. Used mostly for logging purposes. |
| 163 | */ | 163 | */ |
| 164 | FunctionInfo(u32 expected_header, HandlerFnP<Self> handler_callback, const char* name) | 164 | FunctionInfo(u32 expected_header_, HandlerFnP<Self> handler_callback_, const char* name_) |
| 165 | : FunctionInfoBase{ | 165 | : FunctionInfoBase{ |
| 166 | expected_header, | 166 | expected_header_, |
| 167 | // Type-erase member function pointer by casting it down to the base class. | 167 | // Type-erase member function pointer by casting it down to the base class. |
| 168 | static_cast<HandlerFnP<ServiceFrameworkBase>>(handler_callback), name} {} | 168 | static_cast<HandlerFnP<ServiceFrameworkBase>>(handler_callback_), name_} {} |
| 169 | }; | 169 | }; |
| 170 | 170 | ||
| 171 | /** | 171 | /** |
diff --git a/src/core/hle/service/time/ephemeral_network_system_clock_core.h b/src/core/hle/service/time/ephemeral_network_system_clock_core.h index 4c6cdef86..d12cb5335 100644 --- a/src/core/hle/service/time/ephemeral_network_system_clock_core.h +++ b/src/core/hle/service/time/ephemeral_network_system_clock_core.h | |||
| @@ -10,8 +10,8 @@ namespace Service::Time::Clock { | |||
| 10 | 10 | ||
| 11 | class EphemeralNetworkSystemClockCore final : public SystemClockCore { | 11 | class EphemeralNetworkSystemClockCore final : public SystemClockCore { |
| 12 | public: | 12 | public: |
| 13 | explicit EphemeralNetworkSystemClockCore(SteadyClockCore& steady_clock_core) | 13 | explicit EphemeralNetworkSystemClockCore(SteadyClockCore& steady_clock_core_) |
| 14 | : SystemClockCore{steady_clock_core} {} | 14 | : SystemClockCore{steady_clock_core_} {} |
| 15 | }; | 15 | }; |
| 16 | 16 | ||
| 17 | } // namespace Service::Time::Clock | 17 | } // namespace Service::Time::Clock |
diff --git a/src/core/hle/service/time/local_system_clock_context_writer.h b/src/core/hle/service/time/local_system_clock_context_writer.h index 7050844c6..490d0ef3e 100644 --- a/src/core/hle/service/time/local_system_clock_context_writer.h +++ b/src/core/hle/service/time/local_system_clock_context_writer.h | |||
| @@ -12,8 +12,8 @@ namespace Service::Time::Clock { | |||
| 12 | 12 | ||
| 13 | class LocalSystemClockContextWriter final : public SystemClockContextUpdateCallback { | 13 | class LocalSystemClockContextWriter final : public SystemClockContextUpdateCallback { |
| 14 | public: | 14 | public: |
| 15 | explicit LocalSystemClockContextWriter(SharedMemory& shared_memory) | 15 | explicit LocalSystemClockContextWriter(SharedMemory& shared_memory_) |
| 16 | : SystemClockContextUpdateCallback{}, shared_memory{shared_memory} {} | 16 | : SystemClockContextUpdateCallback{}, shared_memory{shared_memory_} {} |
| 17 | 17 | ||
| 18 | protected: | 18 | protected: |
| 19 | ResultCode Update() override { | 19 | ResultCode Update() override { |
diff --git a/src/core/hle/service/time/network_system_clock_context_writer.h b/src/core/hle/service/time/network_system_clock_context_writer.h index 94d8788ff..e2920b8eb 100644 --- a/src/core/hle/service/time/network_system_clock_context_writer.h +++ b/src/core/hle/service/time/network_system_clock_context_writer.h | |||
| @@ -12,8 +12,8 @@ namespace Service::Time::Clock { | |||
| 12 | 12 | ||
| 13 | class NetworkSystemClockContextWriter final : public SystemClockContextUpdateCallback { | 13 | class NetworkSystemClockContextWriter final : public SystemClockContextUpdateCallback { |
| 14 | public: | 14 | public: |
| 15 | explicit NetworkSystemClockContextWriter(SharedMemory& shared_memory) | 15 | explicit NetworkSystemClockContextWriter(SharedMemory& shared_memory_) |
| 16 | : SystemClockContextUpdateCallback{}, shared_memory{shared_memory} {} | 16 | : SystemClockContextUpdateCallback{}, shared_memory{shared_memory_} {} |
| 17 | 17 | ||
| 18 | protected: | 18 | protected: |
| 19 | ResultCode Update() override { | 19 | ResultCode Update() override { |
diff --git a/src/core/hle/service/time/standard_local_system_clock_core.h b/src/core/hle/service/time/standard_local_system_clock_core.h index 8c1882eb1..6320c7af1 100644 --- a/src/core/hle/service/time/standard_local_system_clock_core.h +++ b/src/core/hle/service/time/standard_local_system_clock_core.h | |||
| @@ -10,8 +10,8 @@ namespace Service::Time::Clock { | |||
| 10 | 10 | ||
| 11 | class StandardLocalSystemClockCore final : public SystemClockCore { | 11 | class StandardLocalSystemClockCore final : public SystemClockCore { |
| 12 | public: | 12 | public: |
| 13 | explicit StandardLocalSystemClockCore(SteadyClockCore& steady_clock_core) | 13 | explicit StandardLocalSystemClockCore(SteadyClockCore& steady_clock_core_) |
| 14 | : SystemClockCore{steady_clock_core} {} | 14 | : SystemClockCore{steady_clock_core_} {} |
| 15 | }; | 15 | }; |
| 16 | 16 | ||
| 17 | } // namespace Service::Time::Clock | 17 | } // namespace Service::Time::Clock |
diff --git a/src/core/hle/service/time/standard_network_system_clock_core.h b/src/core/hle/service/time/standard_network_system_clock_core.h index c993bdf79..9d0aeaedb 100644 --- a/src/core/hle/service/time/standard_network_system_clock_core.h +++ b/src/core/hle/service/time/standard_network_system_clock_core.h | |||
| @@ -16,21 +16,21 @@ namespace Service::Time::Clock { | |||
| 16 | 16 | ||
| 17 | class StandardNetworkSystemClockCore final : public SystemClockCore { | 17 | class StandardNetworkSystemClockCore final : public SystemClockCore { |
| 18 | public: | 18 | public: |
| 19 | explicit StandardNetworkSystemClockCore(SteadyClockCore& steady_clock_core) | 19 | explicit StandardNetworkSystemClockCore(SteadyClockCore& steady_clock_core_) |
| 20 | : SystemClockCore{steady_clock_core} {} | 20 | : SystemClockCore{steady_clock_core_} {} |
| 21 | 21 | ||
| 22 | void SetStandardNetworkClockSufficientAccuracy(TimeSpanType value) { | 22 | void SetStandardNetworkClockSufficientAccuracy(TimeSpanType value) { |
| 23 | standard_network_clock_sufficient_accuracy = value; | 23 | standard_network_clock_sufficient_accuracy = value; |
| 24 | } | 24 | } |
| 25 | 25 | ||
| 26 | bool IsStandardNetworkSystemClockAccuracySufficient(Core::System& system) const { | 26 | bool IsStandardNetworkSystemClockAccuracySufficient(Core::System& system) const { |
| 27 | SystemClockContext context{}; | 27 | SystemClockContext clock_ctx{}; |
| 28 | if (GetClockContext(system, context) != RESULT_SUCCESS) { | 28 | if (GetClockContext(system, clock_ctx) != RESULT_SUCCESS) { |
| 29 | return {}; | 29 | return {}; |
| 30 | } | 30 | } |
| 31 | 31 | ||
| 32 | s64 span{}; | 32 | s64 span{}; |
| 33 | if (context.steady_time_point.GetSpanBetween( | 33 | if (clock_ctx.steady_time_point.GetSpanBetween( |
| 34 | GetSteadyClockCore().GetCurrentTimePoint(system), span) != RESULT_SUCCESS) { | 34 | GetSteadyClockCore().GetCurrentTimePoint(system), span) != RESULT_SUCCESS) { |
| 35 | return {}; | 35 | return {}; |
| 36 | } | 36 | } |
diff --git a/src/core/hle/service/time/standard_user_system_clock_core.cpp b/src/core/hle/service/time/standard_user_system_clock_core.cpp index 7f47b12b8..41bc01abd 100644 --- a/src/core/hle/service/time/standard_user_system_clock_core.cpp +++ b/src/core/hle/service/time/standard_user_system_clock_core.cpp | |||
| @@ -11,13 +11,13 @@ | |||
| 11 | namespace Service::Time::Clock { | 11 | namespace Service::Time::Clock { |
| 12 | 12 | ||
| 13 | StandardUserSystemClockCore::StandardUserSystemClockCore( | 13 | StandardUserSystemClockCore::StandardUserSystemClockCore( |
| 14 | StandardLocalSystemClockCore& local_system_clock_core, | 14 | StandardLocalSystemClockCore& local_system_clock_core_, |
| 15 | StandardNetworkSystemClockCore& network_system_clock_core, Core::System& system) | 15 | StandardNetworkSystemClockCore& network_system_clock_core_, Core::System& system_) |
| 16 | : SystemClockCore(local_system_clock_core.GetSteadyClockCore()), | 16 | : SystemClockCore(local_system_clock_core_.GetSteadyClockCore()), |
| 17 | local_system_clock_core{local_system_clock_core}, | 17 | local_system_clock_core{local_system_clock_core_}, |
| 18 | network_system_clock_core{network_system_clock_core}, auto_correction_enabled{}, | 18 | network_system_clock_core{network_system_clock_core_}, |
| 19 | auto_correction_time{SteadyClockTimePoint::GetRandom()}, auto_correction_event{ | 19 | auto_correction_time{SteadyClockTimePoint::GetRandom()}, auto_correction_event{ |
| 20 | system.Kernel()} { | 20 | system_.Kernel()} { |
| 21 | Kernel::KAutoObject::Create(std::addressof(auto_correction_event)); | 21 | Kernel::KAutoObject::Create(std::addressof(auto_correction_event)); |
| 22 | auto_correction_event.Initialize("StandardUserSystemClockCore:AutoCorrectionEvent"); | 22 | auto_correction_event.Initialize("StandardUserSystemClockCore:AutoCorrectionEvent"); |
| 23 | } | 23 | } |
| @@ -35,13 +35,13 @@ ResultCode StandardUserSystemClockCore::SetAutomaticCorrectionEnabled(Core::Syst | |||
| 35 | } | 35 | } |
| 36 | 36 | ||
| 37 | ResultCode StandardUserSystemClockCore::GetClockContext(Core::System& system, | 37 | ResultCode StandardUserSystemClockCore::GetClockContext(Core::System& system, |
| 38 | SystemClockContext& context) const { | 38 | SystemClockContext& ctx) const { |
| 39 | if (const ResultCode result{ApplyAutomaticCorrection(system, false)}; | 39 | if (const ResultCode result{ApplyAutomaticCorrection(system, false)}; |
| 40 | result != RESULT_SUCCESS) { | 40 | result != RESULT_SUCCESS) { |
| 41 | return result; | 41 | return result; |
| 42 | } | 42 | } |
| 43 | 43 | ||
| 44 | return local_system_clock_core.GetClockContext(system, context); | 44 | return local_system_clock_core.GetClockContext(system, ctx); |
| 45 | } | 45 | } |
| 46 | 46 | ||
| 47 | ResultCode StandardUserSystemClockCore::Flush(const SystemClockContext&) { | 47 | ResultCode StandardUserSystemClockCore::Flush(const SystemClockContext&) { |
| @@ -64,13 +64,13 @@ ResultCode StandardUserSystemClockCore::ApplyAutomaticCorrection(Core::System& s | |||
| 64 | return ERROR_UNINITIALIZED_CLOCK; | 64 | return ERROR_UNINITIALIZED_CLOCK; |
| 65 | } | 65 | } |
| 66 | 66 | ||
| 67 | SystemClockContext context{}; | 67 | SystemClockContext ctx{}; |
| 68 | if (const ResultCode result{network_system_clock_core.GetClockContext(system, context)}; | 68 | if (const ResultCode result{network_system_clock_core.GetClockContext(system, ctx)}; |
| 69 | result != RESULT_SUCCESS) { | 69 | result != RESULT_SUCCESS) { |
| 70 | return result; | 70 | return result; |
| 71 | } | 71 | } |
| 72 | 72 | ||
| 73 | local_system_clock_core.SetClockContext(context); | 73 | local_system_clock_core.SetClockContext(ctx); |
| 74 | 74 | ||
| 75 | return RESULT_SUCCESS; | 75 | return RESULT_SUCCESS; |
| 76 | } | 76 | } |
diff --git a/src/core/hle/service/time/standard_user_system_clock_core.h b/src/core/hle/service/time/standard_user_system_clock_core.h index 1bff8a5af..bf9ec5e42 100644 --- a/src/core/hle/service/time/standard_user_system_clock_core.h +++ b/src/core/hle/service/time/standard_user_system_clock_core.h | |||
| @@ -23,13 +23,13 @@ class StandardNetworkSystemClockCore; | |||
| 23 | 23 | ||
| 24 | class StandardUserSystemClockCore final : public SystemClockCore { | 24 | class StandardUserSystemClockCore final : public SystemClockCore { |
| 25 | public: | 25 | public: |
| 26 | StandardUserSystemClockCore(StandardLocalSystemClockCore& local_system_clock_core, | 26 | StandardUserSystemClockCore(StandardLocalSystemClockCore& local_system_clock_core_, |
| 27 | StandardNetworkSystemClockCore& network_system_clock_core, | 27 | StandardNetworkSystemClockCore& network_system_clock_core_, |
| 28 | Core::System& system); | 28 | Core::System& system_); |
| 29 | 29 | ||
| 30 | ResultCode SetAutomaticCorrectionEnabled(Core::System& system, bool value); | 30 | ResultCode SetAutomaticCorrectionEnabled(Core::System& system, bool value); |
| 31 | 31 | ||
| 32 | ResultCode GetClockContext(Core::System& system, SystemClockContext& context) const override; | 32 | ResultCode GetClockContext(Core::System& system, SystemClockContext& ctx) const override; |
| 33 | 33 | ||
| 34 | bool IsAutomaticCorrectionEnabled() const { | 34 | bool IsAutomaticCorrectionEnabled() const { |
| 35 | return auto_correction_enabled; | 35 | return auto_correction_enabled; |
diff --git a/src/core/hle/service/time/system_clock_core.cpp b/src/core/hle/service/time/system_clock_core.cpp index 46fc8c6c3..2ef442b56 100644 --- a/src/core/hle/service/time/system_clock_core.cpp +++ b/src/core/hle/service/time/system_clock_core.cpp | |||
| @@ -8,8 +8,8 @@ | |||
| 8 | 8 | ||
| 9 | namespace Service::Time::Clock { | 9 | namespace Service::Time::Clock { |
| 10 | 10 | ||
| 11 | SystemClockCore::SystemClockCore(SteadyClockCore& steady_clock_core) | 11 | SystemClockCore::SystemClockCore(SteadyClockCore& steady_clock_core_) |
| 12 | : steady_clock_core{steady_clock_core} { | 12 | : steady_clock_core{steady_clock_core_} { |
| 13 | context.steady_time_point.clock_source_id = steady_clock_core.GetClockSourceId(); | 13 | context.steady_time_point.clock_source_id = steady_clock_core.GetClockSourceId(); |
| 14 | } | 14 | } |
| 15 | 15 | ||
diff --git a/src/core/hle/service/time/system_clock_core.h b/src/core/hle/service/time/system_clock_core.h index 82a8b79ff..b8e6122bf 100644 --- a/src/core/hle/service/time/system_clock_core.h +++ b/src/core/hle/service/time/system_clock_core.h | |||
| @@ -21,7 +21,7 @@ class SystemClockContextUpdateCallback; | |||
| 21 | 21 | ||
| 22 | class SystemClockCore { | 22 | class SystemClockCore { |
| 23 | public: | 23 | public: |
| 24 | explicit SystemClockCore(SteadyClockCore& steady_clock_core); | 24 | explicit SystemClockCore(SteadyClockCore& steady_clock_core_); |
| 25 | virtual ~SystemClockCore(); | 25 | virtual ~SystemClockCore(); |
| 26 | 26 | ||
| 27 | SteadyClockCore& GetSteadyClockCore() const { | 27 | SteadyClockCore& GetSteadyClockCore() const { |
diff --git a/src/core/hle/service/time/time_manager.cpp b/src/core/hle/service/time/time_manager.cpp index fe01a3739..4f9684de8 100644 --- a/src/core/hle/service/time/time_manager.cpp +++ b/src/core/hle/service/time/time_manager.cpp | |||
| @@ -223,7 +223,7 @@ struct TimeManager::Impl final { | |||
| 223 | TimeZone::TimeZoneContentManager time_zone_content_manager; | 223 | TimeZone::TimeZoneContentManager time_zone_content_manager; |
| 224 | }; | 224 | }; |
| 225 | 225 | ||
| 226 | TimeManager::TimeManager(Core::System& system) : system{system} {} | 226 | TimeManager::TimeManager(Core::System& system_) : system{system_} {} |
| 227 | 227 | ||
| 228 | TimeManager::~TimeManager() = default; | 228 | TimeManager::~TimeManager() = default; |
| 229 | 229 | ||
diff --git a/src/core/hle/service/time/time_manager.h b/src/core/hle/service/time/time_manager.h index 4db8cc0e1..3af868d87 100644 --- a/src/core/hle/service/time/time_manager.h +++ b/src/core/hle/service/time/time_manager.h | |||
| @@ -30,7 +30,7 @@ class NetworkSystemClockContextWriter; | |||
| 30 | 30 | ||
| 31 | class TimeManager final { | 31 | class TimeManager final { |
| 32 | public: | 32 | public: |
| 33 | explicit TimeManager(Core::System& system); | 33 | explicit TimeManager(Core::System& system_); |
| 34 | ~TimeManager(); | 34 | ~TimeManager(); |
| 35 | 35 | ||
| 36 | void Initialize(); | 36 | void Initialize(); |
diff --git a/src/core/hle/service/time/time_sharedmemory.cpp b/src/core/hle/service/time/time_sharedmemory.cpp index eb57899f6..176ad0eee 100644 --- a/src/core/hle/service/time/time_sharedmemory.cpp +++ b/src/core/hle/service/time/time_sharedmemory.cpp | |||
| @@ -15,7 +15,7 @@ namespace Service::Time { | |||
| 15 | 15 | ||
| 16 | static constexpr std::size_t SHARED_MEMORY_SIZE{0x1000}; | 16 | static constexpr std::size_t SHARED_MEMORY_SIZE{0x1000}; |
| 17 | 17 | ||
| 18 | SharedMemory::SharedMemory(Core::System& system) : system(system) { | 18 | SharedMemory::SharedMemory(Core::System& system_) : system(system_) { |
| 19 | std::memset(system.Kernel().GetTimeSharedMem().GetPointer(), 0, SHARED_MEMORY_SIZE); | 19 | std::memset(system.Kernel().GetTimeSharedMem().GetPointer(), 0, SHARED_MEMORY_SIZE); |
| 20 | } | 20 | } |
| 21 | 21 | ||
diff --git a/src/core/hle/service/time/time_sharedmemory.h b/src/core/hle/service/time/time_sharedmemory.h index 1ad9a286d..d471b5d18 100644 --- a/src/core/hle/service/time/time_sharedmemory.h +++ b/src/core/hle/service/time/time_sharedmemory.h | |||
| @@ -14,7 +14,7 @@ namespace Service::Time { | |||
| 14 | 14 | ||
| 15 | class SharedMemory final { | 15 | class SharedMemory final { |
| 16 | public: | 16 | public: |
| 17 | explicit SharedMemory(Core::System& system); | 17 | explicit SharedMemory(Core::System& system_); |
| 18 | ~SharedMemory(); | 18 | ~SharedMemory(); |
| 19 | 19 | ||
| 20 | // TODO(ogniK): We have to properly simulate memory barriers, how are we going to do this? | 20 | // TODO(ogniK): We have to properly simulate memory barriers, how are we going to do this? |
diff --git a/src/core/hle/service/time/time_zone_content_manager.cpp b/src/core/hle/service/time/time_zone_content_manager.cpp index 3c8e71a3c..57f71e6f0 100644 --- a/src/core/hle/service/time/time_zone_content_manager.cpp +++ b/src/core/hle/service/time/time_zone_content_manager.cpp | |||
| @@ -68,8 +68,8 @@ static std::vector<std::string> BuildLocationNameCache(Core::System& system) { | |||
| 68 | return location_name_cache; | 68 | return location_name_cache; |
| 69 | } | 69 | } |
| 70 | 70 | ||
| 71 | TimeZoneContentManager::TimeZoneContentManager(Core::System& system) | 71 | TimeZoneContentManager::TimeZoneContentManager(Core::System& system_) |
| 72 | : system{system}, location_name_cache{BuildLocationNameCache(system)} {} | 72 | : system{system_}, location_name_cache{BuildLocationNameCache(system)} {} |
| 73 | 73 | ||
| 74 | void TimeZoneContentManager::Initialize(TimeManager& time_manager) { | 74 | void TimeZoneContentManager::Initialize(TimeManager& time_manager) { |
| 75 | std::string location_name; | 75 | std::string location_name; |
diff --git a/src/core/hle/service/time/time_zone_content_manager.h b/src/core/hle/service/time/time_zone_content_manager.h index 52dd1a020..cfa601084 100644 --- a/src/core/hle/service/time/time_zone_content_manager.h +++ b/src/core/hle/service/time/time_zone_content_manager.h | |||
| @@ -21,7 +21,7 @@ namespace Service::Time::TimeZone { | |||
| 21 | 21 | ||
| 22 | class TimeZoneContentManager final { | 22 | class TimeZoneContentManager final { |
| 23 | public: | 23 | public: |
| 24 | explicit TimeZoneContentManager(Core::System& system); | 24 | explicit TimeZoneContentManager(Core::System& system_); |
| 25 | 25 | ||
| 26 | void Initialize(TimeManager& time_manager); | 26 | void Initialize(TimeManager& time_manager); |
| 27 | 27 | ||
diff --git a/src/core/hle/service/vi/display/vi_display.cpp b/src/core/hle/service/vi/display/vi_display.cpp index becbd36c1..0dd342dbf 100644 --- a/src/core/hle/service/vi/display/vi_display.cpp +++ b/src/core/hle/service/vi/display/vi_display.cpp | |||
| @@ -17,8 +17,8 @@ | |||
| 17 | 17 | ||
| 18 | namespace Service::VI { | 18 | namespace Service::VI { |
| 19 | 19 | ||
| 20 | Display::Display(u64 id, std::string name, Core::System& system) | 20 | Display::Display(u64 id, std::string name_, Core::System& system) |
| 21 | : id{id}, name{std::move(name)}, vsync_event{system.Kernel()} { | 21 | : display_id{id}, name{std::move(name_)}, vsync_event{system.Kernel()} { |
| 22 | Kernel::KAutoObject::Create(std::addressof(vsync_event)); | 22 | Kernel::KAutoObject::Create(std::addressof(vsync_event)); |
| 23 | vsync_event.Initialize(fmt::format("Display VSync Event {}", id)); | 23 | vsync_event.Initialize(fmt::format("Display VSync Event {}", id)); |
| 24 | } | 24 | } |
diff --git a/src/core/hle/service/vi/display/vi_display.h b/src/core/hle/service/vi/display/vi_display.h index 388ce6083..166f2a4cc 100644 --- a/src/core/hle/service/vi/display/vi_display.h +++ b/src/core/hle/service/vi/display/vi_display.h | |||
| @@ -32,14 +32,14 @@ public: | |||
| 32 | /// Constructs a display with a given unique ID and name. | 32 | /// Constructs a display with a given unique ID and name. |
| 33 | /// | 33 | /// |
| 34 | /// @param id The unique ID for this display. | 34 | /// @param id The unique ID for this display. |
| 35 | /// @param name The name for this display. | 35 | /// @param name_ The name for this display. |
| 36 | /// | 36 | /// |
| 37 | Display(u64 id, std::string name, Core::System& system); | 37 | Display(u64 id, std::string name_, Core::System& system); |
| 38 | ~Display(); | 38 | ~Display(); |
| 39 | 39 | ||
| 40 | /// Gets the unique ID assigned to this display. | 40 | /// Gets the unique ID assigned to this display. |
| 41 | u64 GetID() const { | 41 | u64 GetID() const { |
| 42 | return id; | 42 | return display_id; |
| 43 | } | 43 | } |
| 44 | 44 | ||
| 45 | /// Gets the name of this display | 45 | /// Gets the name of this display |
| @@ -96,7 +96,7 @@ public: | |||
| 96 | const Layer* FindLayer(u64 layer_id) const; | 96 | const Layer* FindLayer(u64 layer_id) const; |
| 97 | 97 | ||
| 98 | private: | 98 | private: |
| 99 | u64 id; | 99 | u64 display_id; |
| 100 | std::string name; | 100 | std::string name; |
| 101 | 101 | ||
| 102 | std::vector<std::shared_ptr<Layer>> layers; | 102 | std::vector<std::shared_ptr<Layer>> layers; |
diff --git a/src/core/hle/service/vi/layer/vi_layer.cpp b/src/core/hle/service/vi/layer/vi_layer.cpp index 954225c26..9bc382587 100644 --- a/src/core/hle/service/vi/layer/vi_layer.cpp +++ b/src/core/hle/service/vi/layer/vi_layer.cpp | |||
| @@ -6,7 +6,7 @@ | |||
| 6 | 6 | ||
| 7 | namespace Service::VI { | 7 | namespace Service::VI { |
| 8 | 8 | ||
| 9 | Layer::Layer(u64 id, NVFlinger::BufferQueue& queue) : id{id}, buffer_queue{queue} {} | 9 | Layer::Layer(u64 id, NVFlinger::BufferQueue& queue) : layer_id{id}, buffer_queue{queue} {} |
| 10 | 10 | ||
| 11 | Layer::~Layer() = default; | 11 | Layer::~Layer() = default; |
| 12 | 12 | ||
diff --git a/src/core/hle/service/vi/layer/vi_layer.h b/src/core/hle/service/vi/layer/vi_layer.h index c6bfd01f6..ebdd85505 100644 --- a/src/core/hle/service/vi/layer/vi_layer.h +++ b/src/core/hle/service/vi/layer/vi_layer.h | |||
| @@ -31,7 +31,7 @@ public: | |||
| 31 | 31 | ||
| 32 | /// Gets the ID for this layer. | 32 | /// Gets the ID for this layer. |
| 33 | u64 GetID() const { | 33 | u64 GetID() const { |
| 34 | return id; | 34 | return layer_id; |
| 35 | } | 35 | } |
| 36 | 36 | ||
| 37 | /// Gets a reference to the buffer queue this layer is using. | 37 | /// Gets a reference to the buffer queue this layer is using. |
| @@ -45,7 +45,7 @@ public: | |||
| 45 | } | 45 | } |
| 46 | 46 | ||
| 47 | private: | 47 | private: |
| 48 | u64 id; | 48 | u64 layer_id; |
| 49 | NVFlinger::BufferQueue& buffer_queue; | 49 | NVFlinger::BufferQueue& buffer_queue; |
| 50 | }; | 50 | }; |
| 51 | 51 | ||
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp index 32e47a43e..fdd2b4b4f 100644 --- a/src/core/hle/service/vi/vi.cpp +++ b/src/core/hle/service/vi/vi.cpp | |||
| @@ -212,7 +212,7 @@ private: | |||
| 212 | 212 | ||
| 213 | class IGBPConnectRequestParcel : public Parcel { | 213 | class IGBPConnectRequestParcel : public Parcel { |
| 214 | public: | 214 | public: |
| 215 | explicit IGBPConnectRequestParcel(std::vector<u8> buffer) : Parcel(std::move(buffer)) { | 215 | explicit IGBPConnectRequestParcel(std::vector<u8> buffer_) : Parcel(std::move(buffer_)) { |
| 216 | Deserialize(); | 216 | Deserialize(); |
| 217 | } | 217 | } |
| 218 | 218 | ||
| @@ -274,8 +274,8 @@ private: | |||
| 274 | 274 | ||
| 275 | class IGBPSetPreallocatedBufferRequestParcel : public Parcel { | 275 | class IGBPSetPreallocatedBufferRequestParcel : public Parcel { |
| 276 | public: | 276 | public: |
| 277 | explicit IGBPSetPreallocatedBufferRequestParcel(std::vector<u8> buffer) | 277 | explicit IGBPSetPreallocatedBufferRequestParcel(std::vector<u8> buffer_) |
| 278 | : Parcel(std::move(buffer)) { | 278 | : Parcel(std::move(buffer_)) { |
| 279 | Deserialize(); | 279 | Deserialize(); |
| 280 | } | 280 | } |
| 281 | 281 | ||
| @@ -312,7 +312,7 @@ protected: | |||
| 312 | 312 | ||
| 313 | class IGBPCancelBufferRequestParcel : public Parcel { | 313 | class IGBPCancelBufferRequestParcel : public Parcel { |
| 314 | public: | 314 | public: |
| 315 | explicit IGBPCancelBufferRequestParcel(std::vector<u8> buffer) : Parcel(std::move(buffer)) { | 315 | explicit IGBPCancelBufferRequestParcel(std::vector<u8> buffer_) : Parcel(std::move(buffer_)) { |
| 316 | Deserialize(); | 316 | Deserialize(); |
| 317 | } | 317 | } |
| 318 | 318 | ||
| @@ -338,7 +338,7 @@ protected: | |||
| 338 | 338 | ||
| 339 | class IGBPDequeueBufferRequestParcel : public Parcel { | 339 | class IGBPDequeueBufferRequestParcel : public Parcel { |
| 340 | public: | 340 | public: |
| 341 | explicit IGBPDequeueBufferRequestParcel(std::vector<u8> buffer) : Parcel(std::move(buffer)) { | 341 | explicit IGBPDequeueBufferRequestParcel(std::vector<u8> buffer_) : Parcel(std::move(buffer_)) { |
| 342 | Deserialize(); | 342 | Deserialize(); |
| 343 | } | 343 | } |
| 344 | 344 | ||
| @@ -360,8 +360,8 @@ public: | |||
| 360 | 360 | ||
| 361 | class IGBPDequeueBufferResponseParcel : public Parcel { | 361 | class IGBPDequeueBufferResponseParcel : public Parcel { |
| 362 | public: | 362 | public: |
| 363 | explicit IGBPDequeueBufferResponseParcel(u32 slot, Service::Nvidia::MultiFence& multi_fence) | 363 | explicit IGBPDequeueBufferResponseParcel(u32 slot_, Nvidia::MultiFence& multi_fence_) |
| 364 | : slot(slot), multi_fence(multi_fence) {} | 364 | : slot(slot_), multi_fence(multi_fence_) {} |
| 365 | 365 | ||
| 366 | protected: | 366 | protected: |
| 367 | void SerializeData() override { | 367 | void SerializeData() override { |
| @@ -377,7 +377,7 @@ protected: | |||
| 377 | 377 | ||
| 378 | class IGBPRequestBufferRequestParcel : public Parcel { | 378 | class IGBPRequestBufferRequestParcel : public Parcel { |
| 379 | public: | 379 | public: |
| 380 | explicit IGBPRequestBufferRequestParcel(std::vector<u8> buffer) : Parcel(std::move(buffer)) { | 380 | explicit IGBPRequestBufferRequestParcel(std::vector<u8> buffer_) : Parcel(std::move(buffer_)) { |
| 381 | Deserialize(); | 381 | Deserialize(); |
| 382 | } | 382 | } |
| 383 | 383 | ||
| @@ -391,7 +391,7 @@ public: | |||
| 391 | 391 | ||
| 392 | class IGBPRequestBufferResponseParcel : public Parcel { | 392 | class IGBPRequestBufferResponseParcel : public Parcel { |
| 393 | public: | 393 | public: |
| 394 | explicit IGBPRequestBufferResponseParcel(NVFlinger::IGBPBuffer buffer) : buffer(buffer) {} | 394 | explicit IGBPRequestBufferResponseParcel(NVFlinger::IGBPBuffer buffer_) : buffer(buffer_) {} |
| 395 | ~IGBPRequestBufferResponseParcel() override = default; | 395 | ~IGBPRequestBufferResponseParcel() override = default; |
| 396 | 396 | ||
| 397 | protected: | 397 | protected: |
| @@ -408,7 +408,7 @@ protected: | |||
| 408 | 408 | ||
| 409 | class IGBPQueueBufferRequestParcel : public Parcel { | 409 | class IGBPQueueBufferRequestParcel : public Parcel { |
| 410 | public: | 410 | public: |
| 411 | explicit IGBPQueueBufferRequestParcel(std::vector<u8> buffer) : Parcel(std::move(buffer)) { | 411 | explicit IGBPQueueBufferRequestParcel(std::vector<u8> buffer_) : Parcel(std::move(buffer_)) { |
| 412 | Deserialize(); | 412 | Deserialize(); |
| 413 | } | 413 | } |
| 414 | 414 | ||
| @@ -470,7 +470,7 @@ private: | |||
| 470 | 470 | ||
| 471 | class IGBPQueryRequestParcel : public Parcel { | 471 | class IGBPQueryRequestParcel : public Parcel { |
| 472 | public: | 472 | public: |
| 473 | explicit IGBPQueryRequestParcel(std::vector<u8> buffer) : Parcel(std::move(buffer)) { | 473 | explicit IGBPQueryRequestParcel(std::vector<u8> buffer_) : Parcel(std::move(buffer_)) { |
| 474 | Deserialize(); | 474 | Deserialize(); |
| 475 | } | 475 | } |
| 476 | 476 | ||
| @@ -484,7 +484,7 @@ public: | |||
| 484 | 484 | ||
| 485 | class IGBPQueryResponseParcel : public Parcel { | 485 | class IGBPQueryResponseParcel : public Parcel { |
| 486 | public: | 486 | public: |
| 487 | explicit IGBPQueryResponseParcel(u32 value) : value(value) {} | 487 | explicit IGBPQueryResponseParcel(u32 value_) : value{value_} {} |
| 488 | ~IGBPQueryResponseParcel() override = default; | 488 | ~IGBPQueryResponseParcel() override = default; |
| 489 | 489 | ||
| 490 | protected: | 490 | protected: |
diff --git a/src/core/loader/deconstructed_rom_directory.cpp b/src/core/loader/deconstructed_rom_directory.cpp index 42f023258..022885c1b 100644 --- a/src/core/loader/deconstructed_rom_directory.cpp +++ b/src/core/loader/deconstructed_rom_directory.cpp | |||
| @@ -22,8 +22,8 @@ | |||
| 22 | namespace Loader { | 22 | namespace Loader { |
| 23 | 23 | ||
| 24 | AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory(FileSys::VirtualFile file_, | 24 | AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory(FileSys::VirtualFile file_, |
| 25 | bool override_update) | 25 | bool override_update_) |
| 26 | : AppLoader(std::move(file_)), override_update(override_update) { | 26 | : AppLoader(std::move(file_)), override_update(override_update_) { |
| 27 | const auto file_dir = file->GetContainingDirectory(); | 27 | const auto file_dir = file->GetContainingDirectory(); |
| 28 | 28 | ||
| 29 | // Title ID | 29 | // Title ID |
| @@ -48,9 +48,9 @@ AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory(FileSys | |||
| 48 | // Any png, jpeg, or bmp file | 48 | // Any png, jpeg, or bmp file |
| 49 | const auto& files = file_dir->GetFiles(); | 49 | const auto& files = file_dir->GetFiles(); |
| 50 | const auto icon_iter = | 50 | const auto icon_iter = |
| 51 | std::find_if(files.begin(), files.end(), [](const FileSys::VirtualFile& file) { | 51 | std::find_if(files.begin(), files.end(), [](const FileSys::VirtualFile& f) { |
| 52 | return file->GetExtension() == "png" || file->GetExtension() == "jpg" || | 52 | return f->GetExtension() == "png" || f->GetExtension() == "jpg" || |
| 53 | file->GetExtension() == "bmp" || file->GetExtension() == "jpeg"; | 53 | f->GetExtension() == "bmp" || f->GetExtension() == "jpeg"; |
| 54 | }); | 54 | }); |
| 55 | if (icon_iter != files.end()) | 55 | if (icon_iter != files.end()) |
| 56 | icon_data = (*icon_iter)->ReadAllBytes(); | 56 | icon_data = (*icon_iter)->ReadAllBytes(); |
| @@ -61,9 +61,8 @@ AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory(FileSys | |||
| 61 | if (nacp_file == nullptr) { | 61 | if (nacp_file == nullptr) { |
| 62 | const auto& files = file_dir->GetFiles(); | 62 | const auto& files = file_dir->GetFiles(); |
| 63 | const auto nacp_iter = | 63 | const auto nacp_iter = |
| 64 | std::find_if(files.begin(), files.end(), [](const FileSys::VirtualFile& file) { | 64 | std::find_if(files.begin(), files.end(), |
| 65 | return file->GetExtension() == "nacp"; | 65 | [](const FileSys::VirtualFile& f) { return f->GetExtension() == "nacp"; }); |
| 66 | }); | ||
| 67 | if (nacp_iter != files.end()) | 66 | if (nacp_iter != files.end()) |
| 68 | nacp_file = *nacp_iter; | 67 | nacp_file = *nacp_iter; |
| 69 | } | 68 | } |
| @@ -75,9 +74,9 @@ AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory(FileSys | |||
| 75 | } | 74 | } |
| 76 | 75 | ||
| 77 | AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory( | 76 | AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory( |
| 78 | FileSys::VirtualDir directory, bool override_update) | 77 | FileSys::VirtualDir directory, bool override_update_) |
| 79 | : AppLoader(directory->GetFile("main")), dir(std::move(directory)), | 78 | : AppLoader(directory->GetFile("main")), dir(std::move(directory)), |
| 80 | override_update(override_update) {} | 79 | override_update(override_update_) {} |
| 81 | 80 | ||
| 82 | FileType AppLoader_DeconstructedRomDirectory::IdentifyType(const FileSys::VirtualFile& dir_file) { | 81 | FileType AppLoader_DeconstructedRomDirectory::IdentifyType(const FileSys::VirtualFile& dir_file) { |
| 83 | if (FileSys::IsDirectoryExeFS(dir_file->GetContainingDirectory())) { | 82 | if (FileSys::IsDirectoryExeFS(dir_file->GetContainingDirectory())) { |
| @@ -184,8 +183,8 @@ AppLoader_DeconstructedRomDirectory::LoadResult AppLoader_DeconstructedRomDirect | |||
| 184 | // Find the RomFS by searching for a ".romfs" file in this directory | 183 | // Find the RomFS by searching for a ".romfs" file in this directory |
| 185 | const auto& files = dir->GetFiles(); | 184 | const auto& files = dir->GetFiles(); |
| 186 | const auto romfs_iter = | 185 | const auto romfs_iter = |
| 187 | std::find_if(files.begin(), files.end(), [](const FileSys::VirtualFile& file) { | 186 | std::find_if(files.begin(), files.end(), [](const FileSys::VirtualFile& f) { |
| 188 | return file->GetName().find(".romfs") != std::string::npos; | 187 | return f->GetName().find(".romfs") != std::string::npos; |
| 189 | }); | 188 | }); |
| 190 | 189 | ||
| 191 | // Register the RomFS if a ".romfs" file was found | 190 | // Register the RomFS if a ".romfs" file was found |
diff --git a/src/core/loader/deconstructed_rom_directory.h b/src/core/loader/deconstructed_rom_directory.h index a49a8b001..79a4d4db5 100644 --- a/src/core/loader/deconstructed_rom_directory.h +++ b/src/core/loader/deconstructed_rom_directory.h | |||
| @@ -24,11 +24,11 @@ namespace Loader { | |||
| 24 | class AppLoader_DeconstructedRomDirectory final : public AppLoader { | 24 | class AppLoader_DeconstructedRomDirectory final : public AppLoader { |
| 25 | public: | 25 | public: |
| 26 | explicit AppLoader_DeconstructedRomDirectory(FileSys::VirtualFile main_file, | 26 | explicit AppLoader_DeconstructedRomDirectory(FileSys::VirtualFile main_file, |
| 27 | bool override_update = false); | 27 | bool override_update_ = false); |
| 28 | 28 | ||
| 29 | // Overload to accept exefs directory. Must contain 'main' and 'main.npdm' | 29 | // Overload to accept exefs directory. Must contain 'main' and 'main.npdm' |
| 30 | explicit AppLoader_DeconstructedRomDirectory(FileSys::VirtualDir directory, | 30 | explicit AppLoader_DeconstructedRomDirectory(FileSys::VirtualDir directory, |
| 31 | bool override_update = false); | 31 | bool override_update_ = false); |
| 32 | 32 | ||
| 33 | /** | 33 | /** |
| 34 | * Identifies whether or not the given file is a deconstructed ROM directory. | 34 | * Identifies whether or not the given file is a deconstructed ROM directory. |
diff --git a/src/core/loader/loader.cpp b/src/core/loader/loader.cpp index 11b2d0837..d4808fb5b 100644 --- a/src/core/loader/loader.cpp +++ b/src/core/loader/loader.cpp | |||
| @@ -194,7 +194,7 @@ std::ostream& operator<<(std::ostream& os, ResultStatus status) { | |||
| 194 | return os; | 194 | return os; |
| 195 | } | 195 | } |
| 196 | 196 | ||
| 197 | AppLoader::AppLoader(FileSys::VirtualFile file) : file(std::move(file)) {} | 197 | AppLoader::AppLoader(FileSys::VirtualFile file_) : file(std::move(file_)) {} |
| 198 | AppLoader::~AppLoader() = default; | 198 | AppLoader::~AppLoader() = default; |
| 199 | 199 | ||
| 200 | /** | 200 | /** |
diff --git a/src/core/loader/loader.h b/src/core/loader/loader.h index 9eac11dec..edc8bb257 100644 --- a/src/core/loader/loader.h +++ b/src/core/loader/loader.h | |||
| @@ -147,7 +147,7 @@ public: | |||
| 147 | }; | 147 | }; |
| 148 | using LoadResult = std::pair<ResultStatus, std::optional<LoadParameters>>; | 148 | using LoadResult = std::pair<ResultStatus, std::optional<LoadParameters>>; |
| 149 | 149 | ||
| 150 | explicit AppLoader(FileSys::VirtualFile file); | 150 | explicit AppLoader(FileSys::VirtualFile file_); |
| 151 | virtual ~AppLoader(); | 151 | virtual ~AppLoader(); |
| 152 | 152 | ||
| 153 | /** | 153 | /** |
diff --git a/src/core/memory/cheat_engine.cpp b/src/core/memory/cheat_engine.cpp index 0f5ef7954..46a7e09b4 100644 --- a/src/core/memory/cheat_engine.cpp +++ b/src/core/memory/cheat_engine.cpp | |||
| @@ -37,8 +37,8 @@ std::string_view ExtractName(std::string_view data, std::size_t start_index, cha | |||
| 37 | } | 37 | } |
| 38 | } // Anonymous namespace | 38 | } // Anonymous namespace |
| 39 | 39 | ||
| 40 | StandardVmCallbacks::StandardVmCallbacks(Core::System& system, const CheatProcessMetadata& metadata) | 40 | StandardVmCallbacks::StandardVmCallbacks(System& system_, const CheatProcessMetadata& metadata_) |
| 41 | : metadata(metadata), system(system) {} | 41 | : metadata{metadata_}, system{system_} {} |
| 42 | 42 | ||
| 43 | StandardVmCallbacks::~StandardVmCallbacks() = default; | 43 | StandardVmCallbacks::~StandardVmCallbacks() = default; |
| 44 | 44 | ||
| @@ -174,11 +174,11 @@ std::vector<CheatEntry> TextCheatParser::Parse(std::string_view data) const { | |||
| 174 | return out; | 174 | return out; |
| 175 | } | 175 | } |
| 176 | 176 | ||
| 177 | CheatEngine::CheatEngine(Core::System& system, std::vector<CheatEntry> cheats, | 177 | CheatEngine::CheatEngine(System& system_, std::vector<CheatEntry> cheats_, |
| 178 | const std::array<u8, 0x20>& build_id) | 178 | const std::array<u8, 0x20>& build_id_) |
| 179 | : vm{std::make_unique<StandardVmCallbacks>(system, metadata)}, | 179 | : vm{std::make_unique<StandardVmCallbacks>(system_, metadata)}, |
| 180 | cheats(std::move(cheats)), core_timing{system.CoreTiming()}, system{system} { | 180 | cheats(std::move(cheats_)), core_timing{system_.CoreTiming()}, system{system_} { |
| 181 | metadata.main_nso_build_id = build_id; | 181 | metadata.main_nso_build_id = build_id_; |
| 182 | } | 182 | } |
| 183 | 183 | ||
| 184 | CheatEngine::~CheatEngine() { | 184 | CheatEngine::~CheatEngine() { |
diff --git a/src/core/memory/cheat_engine.h b/src/core/memory/cheat_engine.h index 5e6f901ec..a8e041d9d 100644 --- a/src/core/memory/cheat_engine.h +++ b/src/core/memory/cheat_engine.h | |||
| @@ -25,7 +25,7 @@ namespace Core::Memory { | |||
| 25 | 25 | ||
| 26 | class StandardVmCallbacks : public DmntCheatVm::Callbacks { | 26 | class StandardVmCallbacks : public DmntCheatVm::Callbacks { |
| 27 | public: | 27 | public: |
| 28 | StandardVmCallbacks(Core::System& system, const CheatProcessMetadata& metadata); | 28 | StandardVmCallbacks(System& system_, const CheatProcessMetadata& metadata_); |
| 29 | ~StandardVmCallbacks() override; | 29 | ~StandardVmCallbacks() override; |
| 30 | 30 | ||
| 31 | void MemoryRead(VAddr address, void* data, u64 size) override; | 31 | void MemoryRead(VAddr address, void* data, u64 size) override; |
| @@ -38,7 +38,7 @@ private: | |||
| 38 | VAddr SanitizeAddress(VAddr address) const; | 38 | VAddr SanitizeAddress(VAddr address) const; |
| 39 | 39 | ||
| 40 | const CheatProcessMetadata& metadata; | 40 | const CheatProcessMetadata& metadata; |
| 41 | Core::System& system; | 41 | System& system; |
| 42 | }; | 42 | }; |
| 43 | 43 | ||
| 44 | // Intermediary class that parses a text file or other disk format for storing cheats into a | 44 | // Intermediary class that parses a text file or other disk format for storing cheats into a |
| @@ -61,8 +61,8 @@ public: | |||
| 61 | // Class that encapsulates a CheatList and manages its interaction with memory and CoreTiming | 61 | // Class that encapsulates a CheatList and manages its interaction with memory and CoreTiming |
| 62 | class CheatEngine final { | 62 | class CheatEngine final { |
| 63 | public: | 63 | public: |
| 64 | CheatEngine(Core::System& system_, std::vector<CheatEntry> cheats_, | 64 | CheatEngine(System& system_, std::vector<CheatEntry> cheats_, |
| 65 | const std::array<u8, 0x20>& build_id); | 65 | const std::array<u8, 0x20>& build_id_); |
| 66 | ~CheatEngine(); | 66 | ~CheatEngine(); |
| 67 | 67 | ||
| 68 | void Initialize(); | 68 | void Initialize(); |
diff --git a/src/core/memory/dmnt_cheat_vm.cpp b/src/core/memory/dmnt_cheat_vm.cpp index 48be80c12..dc04e37d2 100644 --- a/src/core/memory/dmnt_cheat_vm.cpp +++ b/src/core/memory/dmnt_cheat_vm.cpp | |||
| @@ -29,7 +29,8 @@ | |||
| 29 | 29 | ||
| 30 | namespace Core::Memory { | 30 | namespace Core::Memory { |
| 31 | 31 | ||
| 32 | DmntCheatVm::DmntCheatVm(std::unique_ptr<Callbacks> callbacks) : callbacks(std::move(callbacks)) {} | 32 | DmntCheatVm::DmntCheatVm(std::unique_ptr<Callbacks> callbacks_) |
| 33 | : callbacks(std::move(callbacks_)) {} | ||
| 33 | 34 | ||
| 34 | DmntCheatVm::~DmntCheatVm() = default; | 35 | DmntCheatVm::~DmntCheatVm() = default; |
| 35 | 36 | ||
diff --git a/src/core/memory/dmnt_cheat_vm.h b/src/core/memory/dmnt_cheat_vm.h index 21b86b72c..707bee82b 100644 --- a/src/core/memory/dmnt_cheat_vm.h +++ b/src/core/memory/dmnt_cheat_vm.h | |||
| @@ -293,7 +293,7 @@ public: | |||
| 293 | static constexpr std::size_t NumStaticRegisters = | 293 | static constexpr std::size_t NumStaticRegisters = |
| 294 | NumReadableStaticRegisters + NumWritableStaticRegisters; | 294 | NumReadableStaticRegisters + NumWritableStaticRegisters; |
| 295 | 295 | ||
| 296 | explicit DmntCheatVm(std::unique_ptr<Callbacks> callbacks); | 296 | explicit DmntCheatVm(std::unique_ptr<Callbacks> callbacks_); |
| 297 | ~DmntCheatVm(); | 297 | ~DmntCheatVm(); |
| 298 | 298 | ||
| 299 | std::size_t GetProgramSize() const { | 299 | std::size_t GetProgramSize() const { |
diff --git a/src/core/perf_stats.cpp b/src/core/perf_stats.cpp index c92337079..b185a3884 100644 --- a/src/core/perf_stats.cpp +++ b/src/core/perf_stats.cpp | |||
| @@ -27,7 +27,7 @@ constexpr std::size_t IgnoreFrames = 5; | |||
| 27 | 27 | ||
| 28 | namespace Core { | 28 | namespace Core { |
| 29 | 29 | ||
| 30 | PerfStats::PerfStats(u64 title_id) : title_id(title_id) {} | 30 | PerfStats::PerfStats(u64 title_id_) : title_id(title_id_) {} |
| 31 | 31 | ||
| 32 | PerfStats::~PerfStats() { | 32 | PerfStats::~PerfStats() { |
| 33 | if (!Settings::values.record_frame_times || title_id == 0) { | 33 | if (!Settings::values.record_frame_times || title_id == 0) { |
diff --git a/src/core/perf_stats.h b/src/core/perf_stats.h index 69256b960..ae4698696 100644 --- a/src/core/perf_stats.h +++ b/src/core/perf_stats.h | |||
| @@ -29,7 +29,7 @@ struct PerfStatsResults { | |||
| 29 | */ | 29 | */ |
| 30 | class PerfStats { | 30 | class PerfStats { |
| 31 | public: | 31 | public: |
| 32 | explicit PerfStats(u64 title_id); | 32 | explicit PerfStats(u64 title_id_); |
| 33 | ~PerfStats(); | 33 | ~PerfStats(); |
| 34 | 34 | ||
| 35 | using Clock = std::chrono::high_resolution_clock; | 35 | using Clock = std::chrono::high_resolution_clock; |
diff --git a/src/core/reporter.cpp b/src/core/reporter.cpp index 896add892..d1e807dd4 100644 --- a/src/core/reporter.cpp +++ b/src/core/reporter.cpp | |||
| @@ -192,7 +192,7 @@ json GetHLERequestContextData(Kernel::HLERequestContext& ctx, Core::Memory::Memo | |||
| 192 | 192 | ||
| 193 | namespace Core { | 193 | namespace Core { |
| 194 | 194 | ||
| 195 | Reporter::Reporter(System& system) : system(system) {} | 195 | Reporter::Reporter(System& system_) : system(system_) {} |
| 196 | 196 | ||
| 197 | Reporter::~Reporter() = default; | 197 | Reporter::~Reporter() = default; |
| 198 | 198 | ||
diff --git a/src/core/reporter.h b/src/core/reporter.h index b2c2d9a2e..6fb6ebffa 100644 --- a/src/core/reporter.h +++ b/src/core/reporter.h | |||
| @@ -30,7 +30,7 @@ class System; | |||
| 30 | 30 | ||
| 31 | class Reporter { | 31 | class Reporter { |
| 32 | public: | 32 | public: |
| 33 | explicit Reporter(System& system); | 33 | explicit Reporter(System& system_); |
| 34 | ~Reporter(); | 34 | ~Reporter(); |
| 35 | 35 | ||
| 36 | // Used by fatal services | 36 | // Used by fatal services |