diff options
Diffstat (limited to 'src')
40 files changed, 941 insertions, 382 deletions
diff --git a/src/audio_core/stream.cpp b/src/audio_core/stream.cpp index 742a5e0a0..f35628e45 100644 --- a/src/audio_core/stream.cpp +++ b/src/audio_core/stream.cpp | |||
| @@ -11,7 +11,6 @@ | |||
| 11 | #include "audio_core/stream.h" | 11 | #include "audio_core/stream.h" |
| 12 | #include "common/assert.h" | 12 | #include "common/assert.h" |
| 13 | #include "common/logging/log.h" | 13 | #include "common/logging/log.h" |
| 14 | #include "common/microprofile.h" | ||
| 15 | #include "core/core_timing.h" | 14 | #include "core/core_timing.h" |
| 16 | #include "core/core_timing_util.h" | 15 | #include "core/core_timing_util.h" |
| 17 | #include "core/settings.h" | 16 | #include "core/settings.h" |
| @@ -104,10 +103,7 @@ void Stream::PlayNextBuffer() { | |||
| 104 | CoreTiming::ScheduleEventThreadsafe(GetBufferReleaseCycles(*active_buffer), release_event, {}); | 103 | CoreTiming::ScheduleEventThreadsafe(GetBufferReleaseCycles(*active_buffer), release_event, {}); |
| 105 | } | 104 | } |
| 106 | 105 | ||
| 107 | MICROPROFILE_DEFINE(AudioOutput, "Audio", "ReleaseActiveBuffer", MP_RGB(100, 100, 255)); | ||
| 108 | |||
| 109 | void Stream::ReleaseActiveBuffer() { | 106 | void Stream::ReleaseActiveBuffer() { |
| 110 | MICROPROFILE_SCOPE(AudioOutput); | ||
| 111 | ASSERT(active_buffer); | 107 | ASSERT(active_buffer); |
| 112 | released_buffers.push(std::move(active_buffer)); | 108 | released_buffers.push(std::move(active_buffer)); |
| 113 | release_callback(); | 109 | release_callback(); |
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp index c7c579aaf..7e8e87c33 100644 --- a/src/core/hle/kernel/svc.cpp +++ b/src/core/hle/kernel/svc.cpp | |||
| @@ -395,16 +395,42 @@ struct BreakReason { | |||
| 395 | /// Break program execution | 395 | /// Break program execution |
| 396 | static void Break(u32 reason, u64 info1, u64 info2) { | 396 | static void Break(u32 reason, u64 info1, u64 info2) { |
| 397 | BreakReason break_reason{reason}; | 397 | BreakReason break_reason{reason}; |
| 398 | bool has_dumped_buffer{}; | ||
| 398 | 399 | ||
| 400 | const auto handle_debug_buffer = [&](VAddr addr, u64 sz) { | ||
| 401 | if (sz == 0 || addr == 0 || has_dumped_buffer) { | ||
| 402 | return; | ||
| 403 | } | ||
| 404 | |||
| 405 | // This typically is an error code so we're going to assume this is the case | ||
| 406 | if (sz == sizeof(u32)) { | ||
| 407 | LOG_CRITICAL(Debug_Emulated, "debug_buffer_err_code={:X}", Memory::Read32(addr)); | ||
| 408 | } else { | ||
| 409 | // We don't know what's in here so we'll hexdump it | ||
| 410 | std::vector<u8> debug_buffer(sz); | ||
| 411 | Memory::ReadBlock(addr, debug_buffer.data(), sz); | ||
| 412 | std::string hexdump; | ||
| 413 | for (std::size_t i = 0; i < debug_buffer.size(); i++) { | ||
| 414 | hexdump += fmt::format("{:02X} ", debug_buffer[i]); | ||
| 415 | if (i != 0 && i % 16 == 0) { | ||
| 416 | hexdump += '\n'; | ||
| 417 | } | ||
| 418 | } | ||
| 419 | LOG_CRITICAL(Debug_Emulated, "debug_buffer=\n{}", hexdump); | ||
| 420 | } | ||
| 421 | has_dumped_buffer = true; | ||
| 422 | }; | ||
| 399 | switch (break_reason.break_type) { | 423 | switch (break_reason.break_type) { |
| 400 | case BreakType::Panic: | 424 | case BreakType::Panic: |
| 401 | LOG_CRITICAL(Debug_Emulated, "Signalling debugger, PANIC! info1=0x{:016X}, info2=0x{:016X}", | 425 | LOG_CRITICAL(Debug_Emulated, "Signalling debugger, PANIC! info1=0x{:016X}, info2=0x{:016X}", |
| 402 | info1, info2); | 426 | info1, info2); |
| 427 | handle_debug_buffer(info1, info2); | ||
| 403 | break; | 428 | break; |
| 404 | case BreakType::AssertionFailed: | 429 | case BreakType::AssertionFailed: |
| 405 | LOG_CRITICAL(Debug_Emulated, | 430 | LOG_CRITICAL(Debug_Emulated, |
| 406 | "Signalling debugger, Assertion failed! info1=0x{:016X}, info2=0x{:016X}", | 431 | "Signalling debugger, Assertion failed! info1=0x{:016X}, info2=0x{:016X}", |
| 407 | info1, info2); | 432 | info1, info2); |
| 433 | handle_debug_buffer(info1, info2); | ||
| 408 | break; | 434 | break; |
| 409 | case BreakType::PreNROLoad: | 435 | case BreakType::PreNROLoad: |
| 410 | LOG_WARNING( | 436 | LOG_WARNING( |
| @@ -433,6 +459,7 @@ static void Break(u32 reason, u64 info1, u64 info2) { | |||
| 433 | Debug_Emulated, | 459 | Debug_Emulated, |
| 434 | "Signalling debugger, Unknown break reason {}, info1=0x{:016X}, info2=0x{:016X}", | 460 | "Signalling debugger, Unknown break reason {}, info1=0x{:016X}, info2=0x{:016X}", |
| 435 | static_cast<u32>(break_reason.break_type.Value()), info1, info2); | 461 | static_cast<u32>(break_reason.break_type.Value()), info1, info2); |
| 462 | handle_debug_buffer(info1, info2); | ||
| 436 | break; | 463 | break; |
| 437 | } | 464 | } |
| 438 | 465 | ||
| @@ -441,6 +468,7 @@ static void Break(u32 reason, u64 info1, u64 info2) { | |||
| 441 | Debug_Emulated, | 468 | Debug_Emulated, |
| 442 | "Emulated program broke execution! reason=0x{:016X}, info1=0x{:016X}, info2=0x{:016X}", | 469 | "Emulated program broke execution! reason=0x{:016X}, info1=0x{:016X}, info2=0x{:016X}", |
| 443 | reason, info1, info2); | 470 | reason, info1, info2); |
| 471 | handle_debug_buffer(info1, info2); | ||
| 444 | ASSERT(false); | 472 | ASSERT(false); |
| 445 | 473 | ||
| 446 | Core::CurrentProcess()->PrepareForTermination(); | 474 | Core::CurrentProcess()->PrepareForTermination(); |
diff --git a/src/core/hle/service/acc/acc.cpp b/src/core/hle/service/acc/acc.cpp index c6437a671..8318eff5f 100644 --- a/src/core/hle/service/acc/acc.cpp +++ b/src/core/hle/service/acc/acc.cpp | |||
| @@ -242,6 +242,28 @@ void Module::Interface::GetBaasAccountManagerForApplication(Kernel::HLERequestCo | |||
| 242 | LOG_DEBUG(Service_ACC, "called"); | 242 | LOG_DEBUG(Service_ACC, "called"); |
| 243 | } | 243 | } |
| 244 | 244 | ||
| 245 | void Module::Interface::TrySelectUserWithoutInteraction(Kernel::HLERequestContext& ctx) { | ||
| 246 | LOG_DEBUG(Service_ACC, "called"); | ||
| 247 | // A u8 is passed into this function which we can safely ignore. It's to determine if we have | ||
| 248 | // access to use the network or not by the looks of it | ||
| 249 | IPC::ResponseBuilder rb{ctx, 6}; | ||
| 250 | if (profile_manager->GetUserCount() != 1) { | ||
| 251 | rb.Push(RESULT_SUCCESS); | ||
| 252 | rb.PushRaw<u128>(INVALID_UUID); | ||
| 253 | return; | ||
| 254 | } | ||
| 255 | auto user_list = profile_manager->GetAllUsers(); | ||
| 256 | if (user_list.empty()) { | ||
| 257 | rb.Push(ResultCode(-1)); // TODO(ogniK): Find the correct error code | ||
| 258 | rb.PushRaw<u128>(INVALID_UUID); | ||
| 259 | return; | ||
| 260 | } | ||
| 261 | |||
| 262 | // Select the first user we have | ||
| 263 | rb.Push(RESULT_SUCCESS); | ||
| 264 | rb.PushRaw<u128>(profile_manager->GetUser(0)->uuid); | ||
| 265 | } | ||
| 266 | |||
| 245 | Module::Interface::Interface(std::shared_ptr<Module> module, | 267 | Module::Interface::Interface(std::shared_ptr<Module> module, |
| 246 | std::shared_ptr<ProfileManager> profile_manager, const char* name) | 268 | std::shared_ptr<ProfileManager> profile_manager, const char* name) |
| 247 | : ServiceFramework(name), module(std::move(module)), | 269 | : ServiceFramework(name), module(std::move(module)), |
diff --git a/src/core/hle/service/acc/acc.h b/src/core/hle/service/acc/acc.h index c7ed74351..89b2104fa 100644 --- a/src/core/hle/service/acc/acc.h +++ b/src/core/hle/service/acc/acc.h | |||
| @@ -27,6 +27,7 @@ public: | |||
| 27 | void InitializeApplicationInfo(Kernel::HLERequestContext& ctx); | 27 | void InitializeApplicationInfo(Kernel::HLERequestContext& ctx); |
| 28 | void GetBaasAccountManagerForApplication(Kernel::HLERequestContext& ctx); | 28 | void GetBaasAccountManagerForApplication(Kernel::HLERequestContext& ctx); |
| 29 | void IsUserRegistrationRequestPermitted(Kernel::HLERequestContext& ctx); | 29 | void IsUserRegistrationRequestPermitted(Kernel::HLERequestContext& ctx); |
| 30 | void TrySelectUserWithoutInteraction(Kernel::HLERequestContext& ctx); | ||
| 30 | 31 | ||
| 31 | protected: | 32 | protected: |
| 32 | std::shared_ptr<Module> module; | 33 | std::shared_ptr<Module> module; |
diff --git a/src/core/hle/service/acc/acc_su.cpp b/src/core/hle/service/acc/acc_su.cpp index ad455c3a7..5e2030355 100644 --- a/src/core/hle/service/acc/acc_su.cpp +++ b/src/core/hle/service/acc/acc_su.cpp | |||
| @@ -17,7 +17,7 @@ ACC_SU::ACC_SU(std::shared_ptr<Module> module, std::shared_ptr<ProfileManager> p | |||
| 17 | {5, &ACC_SU::GetProfile, "GetProfile"}, | 17 | {5, &ACC_SU::GetProfile, "GetProfile"}, |
| 18 | {6, nullptr, "GetProfileDigest"}, | 18 | {6, nullptr, "GetProfileDigest"}, |
| 19 | {50, &ACC_SU::IsUserRegistrationRequestPermitted, "IsUserRegistrationRequestPermitted"}, | 19 | {50, &ACC_SU::IsUserRegistrationRequestPermitted, "IsUserRegistrationRequestPermitted"}, |
| 20 | {51, nullptr, "TrySelectUserWithoutInteraction"}, | 20 | {51, &ACC_SU::TrySelectUserWithoutInteraction, "TrySelectUserWithoutInteraction"}, |
| 21 | {60, nullptr, "ListOpenContextStoredUsers"}, | 21 | {60, nullptr, "ListOpenContextStoredUsers"}, |
| 22 | {100, nullptr, "GetUserRegistrationNotifier"}, | 22 | {100, nullptr, "GetUserRegistrationNotifier"}, |
| 23 | {101, nullptr, "GetUserStateChangeNotifier"}, | 23 | {101, nullptr, "GetUserStateChangeNotifier"}, |
diff --git a/src/core/hle/service/acc/acc_u0.cpp b/src/core/hle/service/acc/acc_u0.cpp index 72d4adf35..a4d705b45 100644 --- a/src/core/hle/service/acc/acc_u0.cpp +++ b/src/core/hle/service/acc/acc_u0.cpp | |||
| @@ -17,7 +17,7 @@ ACC_U0::ACC_U0(std::shared_ptr<Module> module, std::shared_ptr<ProfileManager> p | |||
| 17 | {5, &ACC_U0::GetProfile, "GetProfile"}, | 17 | {5, &ACC_U0::GetProfile, "GetProfile"}, |
| 18 | {6, nullptr, "GetProfileDigest"}, | 18 | {6, nullptr, "GetProfileDigest"}, |
| 19 | {50, &ACC_U0::IsUserRegistrationRequestPermitted, "IsUserRegistrationRequestPermitted"}, | 19 | {50, &ACC_U0::IsUserRegistrationRequestPermitted, "IsUserRegistrationRequestPermitted"}, |
| 20 | {51, nullptr, "TrySelectUserWithoutInteraction"}, | 20 | {51, &ACC_U0::TrySelectUserWithoutInteraction, "TrySelectUserWithoutInteraction"}, |
| 21 | {60, nullptr, "ListOpenContextStoredUsers"}, | 21 | {60, nullptr, "ListOpenContextStoredUsers"}, |
| 22 | {100, &ACC_U0::InitializeApplicationInfo, "InitializeApplicationInfo"}, | 22 | {100, &ACC_U0::InitializeApplicationInfo, "InitializeApplicationInfo"}, |
| 23 | {101, &ACC_U0::GetBaasAccountManagerForApplication, "GetBaasAccountManagerForApplication"}, | 23 | {101, &ACC_U0::GetBaasAccountManagerForApplication, "GetBaasAccountManagerForApplication"}, |
diff --git a/src/core/hle/service/acc/acc_u1.cpp b/src/core/hle/service/acc/acc_u1.cpp index d480f08e5..8fffc93b5 100644 --- a/src/core/hle/service/acc/acc_u1.cpp +++ b/src/core/hle/service/acc/acc_u1.cpp | |||
| @@ -17,7 +17,7 @@ ACC_U1::ACC_U1(std::shared_ptr<Module> module, std::shared_ptr<ProfileManager> p | |||
| 17 | {5, &ACC_U1::GetProfile, "GetProfile"}, | 17 | {5, &ACC_U1::GetProfile, "GetProfile"}, |
| 18 | {6, nullptr, "GetProfileDigest"}, | 18 | {6, nullptr, "GetProfileDigest"}, |
| 19 | {50, &ACC_U1::IsUserRegistrationRequestPermitted, "IsUserRegistrationRequestPermitted"}, | 19 | {50, &ACC_U1::IsUserRegistrationRequestPermitted, "IsUserRegistrationRequestPermitted"}, |
| 20 | {51, nullptr, "TrySelectUserWithoutInteraction"}, | 20 | {51, &ACC_U1::TrySelectUserWithoutInteraction, "TrySelectUserWithoutInteraction"}, |
| 21 | {60, nullptr, "ListOpenContextStoredUsers"}, | 21 | {60, nullptr, "ListOpenContextStoredUsers"}, |
| 22 | {100, nullptr, "GetUserRegistrationNotifier"}, | 22 | {100, nullptr, "GetUserRegistrationNotifier"}, |
| 23 | {101, nullptr, "GetUserStateChangeNotifier"}, | 23 | {101, nullptr, "GetUserStateChangeNotifier"}, |
diff --git a/src/core/hle/service/am/am.cpp b/src/core/hle/service/am/am.cpp index ac3ff9f20..0477ce66e 100644 --- a/src/core/hle/service/am/am.cpp +++ b/src/core/hle/service/am/am.cpp | |||
| @@ -338,7 +338,54 @@ void ISelfController::GetIdleTimeDetectionExtension(Kernel::HLERequestContext& c | |||
| 338 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 338 | LOG_WARNING(Service_AM, "(STUBBED) called"); |
| 339 | } | 339 | } |
| 340 | 340 | ||
| 341 | ICommonStateGetter::ICommonStateGetter() : ServiceFramework("ICommonStateGetter") { | 341 | AppletMessageQueue::AppletMessageQueue() { |
| 342 | auto& kernel = Core::System::GetInstance().Kernel(); | ||
| 343 | on_new_message = Kernel::Event::Create(kernel, Kernel::ResetType::Sticky, | ||
| 344 | "AMMessageQueue:OnMessageRecieved"); | ||
| 345 | on_operation_mode_changed = Kernel::Event::Create(kernel, Kernel::ResetType::OneShot, | ||
| 346 | "AMMessageQueue:OperationModeChanged"); | ||
| 347 | } | ||
| 348 | |||
| 349 | AppletMessageQueue::~AppletMessageQueue() = default; | ||
| 350 | |||
| 351 | const Kernel::SharedPtr<Kernel::Event>& AppletMessageQueue::GetMesssageRecieveEvent() const { | ||
| 352 | return on_new_message; | ||
| 353 | } | ||
| 354 | |||
| 355 | const Kernel::SharedPtr<Kernel::Event>& AppletMessageQueue::GetOperationModeChangedEvent() const { | ||
| 356 | return on_operation_mode_changed; | ||
| 357 | } | ||
| 358 | |||
| 359 | void AppletMessageQueue::PushMessage(AppletMessage msg) { | ||
| 360 | messages.push(msg); | ||
| 361 | on_new_message->Signal(); | ||
| 362 | } | ||
| 363 | |||
| 364 | AppletMessageQueue::AppletMessage AppletMessageQueue::PopMessage() { | ||
| 365 | if (messages.empty()) { | ||
| 366 | on_new_message->Clear(); | ||
| 367 | return AppletMessage::NoMessage; | ||
| 368 | } | ||
| 369 | auto msg = messages.front(); | ||
| 370 | messages.pop(); | ||
| 371 | if (messages.empty()) { | ||
| 372 | on_new_message->Clear(); | ||
| 373 | } | ||
| 374 | return msg; | ||
| 375 | } | ||
| 376 | |||
| 377 | std::size_t AppletMessageQueue::GetMessageCount() const { | ||
| 378 | return messages.size(); | ||
| 379 | } | ||
| 380 | |||
| 381 | void AppletMessageQueue::OperationModeChanged() { | ||
| 382 | PushMessage(AppletMessage::OperationModeChanged); | ||
| 383 | PushMessage(AppletMessage::PerformanceModeChanged); | ||
| 384 | on_operation_mode_changed->Signal(); | ||
| 385 | } | ||
| 386 | |||
| 387 | ICommonStateGetter::ICommonStateGetter(std::shared_ptr<AppletMessageQueue> msg_queue) | ||
| 388 | : ServiceFramework("ICommonStateGetter"), msg_queue(std::move(msg_queue)) { | ||
| 342 | // clang-format off | 389 | // clang-format off |
| 343 | static const FunctionInfo functions[] = { | 390 | static const FunctionInfo functions[] = { |
| 344 | {0, &ICommonStateGetter::GetEventHandle, "GetEventHandle"}, | 391 | {0, &ICommonStateGetter::GetEventHandle, "GetEventHandle"}, |
| @@ -388,21 +435,19 @@ void ICommonStateGetter::GetBootMode(Kernel::HLERequestContext& ctx) { | |||
| 388 | } | 435 | } |
| 389 | 436 | ||
| 390 | void ICommonStateGetter::GetEventHandle(Kernel::HLERequestContext& ctx) { | 437 | void ICommonStateGetter::GetEventHandle(Kernel::HLERequestContext& ctx) { |
| 391 | event->Signal(); | ||
| 392 | |||
| 393 | IPC::ResponseBuilder rb{ctx, 2, 1}; | 438 | IPC::ResponseBuilder rb{ctx, 2, 1}; |
| 394 | rb.Push(RESULT_SUCCESS); | 439 | rb.Push(RESULT_SUCCESS); |
| 395 | rb.PushCopyObjects(event); | 440 | rb.PushCopyObjects(msg_queue->GetMesssageRecieveEvent()); |
| 396 | 441 | ||
| 397 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 442 | LOG_DEBUG(Service_AM, "called"); |
| 398 | } | 443 | } |
| 399 | 444 | ||
| 400 | void ICommonStateGetter::ReceiveMessage(Kernel::HLERequestContext& ctx) { | 445 | void ICommonStateGetter::ReceiveMessage(Kernel::HLERequestContext& ctx) { |
| 401 | IPC::ResponseBuilder rb{ctx, 3}; | 446 | IPC::ResponseBuilder rb{ctx, 3}; |
| 402 | rb.Push(RESULT_SUCCESS); | 447 | rb.Push(RESULT_SUCCESS); |
| 403 | rb.Push<u32>(15); | 448 | rb.PushEnum<AppletMessageQueue::AppletMessage>(msg_queue->PopMessage()); |
| 404 | 449 | ||
| 405 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 450 | LOG_DEBUG(Service_AM, "called"); |
| 406 | } | 451 | } |
| 407 | 452 | ||
| 408 | void ICommonStateGetter::GetCurrentFocusState(Kernel::HLERequestContext& ctx) { | 453 | void ICommonStateGetter::GetCurrentFocusState(Kernel::HLERequestContext& ctx) { |
| @@ -414,13 +459,11 @@ void ICommonStateGetter::GetCurrentFocusState(Kernel::HLERequestContext& ctx) { | |||
| 414 | } | 459 | } |
| 415 | 460 | ||
| 416 | void ICommonStateGetter::GetDefaultDisplayResolutionChangeEvent(Kernel::HLERequestContext& ctx) { | 461 | void ICommonStateGetter::GetDefaultDisplayResolutionChangeEvent(Kernel::HLERequestContext& ctx) { |
| 417 | event->Signal(); | ||
| 418 | |||
| 419 | IPC::ResponseBuilder rb{ctx, 2, 1}; | 462 | IPC::ResponseBuilder rb{ctx, 2, 1}; |
| 420 | rb.Push(RESULT_SUCCESS); | 463 | rb.Push(RESULT_SUCCESS); |
| 421 | rb.PushCopyObjects(event); | 464 | rb.PushCopyObjects(msg_queue->GetOperationModeChangedEvent()); |
| 422 | 465 | ||
| 423 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 466 | LOG_DEBUG(Service_AM, "called"); |
| 424 | } | 467 | } |
| 425 | 468 | ||
| 426 | void ICommonStateGetter::GetDefaultDisplayResolution(Kernel::HLERequestContext& ctx) { | 469 | void ICommonStateGetter::GetDefaultDisplayResolution(Kernel::HLERequestContext& ctx) { |
| @@ -444,7 +487,7 @@ void ICommonStateGetter::GetOperationMode(Kernel::HLERequestContext& ctx) { | |||
| 444 | rb.Push(RESULT_SUCCESS); | 487 | rb.Push(RESULT_SUCCESS); |
| 445 | rb.Push(static_cast<u8>(use_docked_mode ? OperationMode::Docked : OperationMode::Handheld)); | 488 | rb.Push(static_cast<u8>(use_docked_mode ? OperationMode::Docked : OperationMode::Handheld)); |
| 446 | 489 | ||
| 447 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 490 | LOG_DEBUG(Service_AM, "called"); |
| 448 | } | 491 | } |
| 449 | 492 | ||
| 450 | void ICommonStateGetter::GetPerformanceMode(Kernel::HLERequestContext& ctx) { | 493 | void ICommonStateGetter::GetPerformanceMode(Kernel::HLERequestContext& ctx) { |
| @@ -454,7 +497,7 @@ void ICommonStateGetter::GetPerformanceMode(Kernel::HLERequestContext& ctx) { | |||
| 454 | rb.Push(static_cast<u32>(use_docked_mode ? APM::PerformanceMode::Docked | 497 | rb.Push(static_cast<u32>(use_docked_mode ? APM::PerformanceMode::Docked |
| 455 | : APM::PerformanceMode::Handheld)); | 498 | : APM::PerformanceMode::Handheld)); |
| 456 | 499 | ||
| 457 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 500 | LOG_DEBUG(Service_AM, "called"); |
| 458 | } | 501 | } |
| 459 | 502 | ||
| 460 | class IStorageAccessor final : public ServiceFramework<IStorageAccessor> { | 503 | class IStorageAccessor final : public ServiceFramework<IStorageAccessor> { |
| @@ -840,8 +883,12 @@ void IApplicationFunctions::GetPseudoDeviceId(Kernel::HLERequestContext& ctx) { | |||
| 840 | 883 | ||
| 841 | void InstallInterfaces(SM::ServiceManager& service_manager, | 884 | void InstallInterfaces(SM::ServiceManager& service_manager, |
| 842 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger) { | 885 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger) { |
| 843 | std::make_shared<AppletAE>(nvflinger)->InstallAsService(service_manager); | 886 | auto message_queue = std::make_shared<AppletMessageQueue>(); |
| 844 | std::make_shared<AppletOE>(nvflinger)->InstallAsService(service_manager); | 887 | message_queue->PushMessage( |
| 888 | AppletMessageQueue::AppletMessage::FocusStateChanged); // Needed on game boot | ||
| 889 | |||
| 890 | std::make_shared<AppletAE>(nvflinger, message_queue)->InstallAsService(service_manager); | ||
| 891 | std::make_shared<AppletOE>(nvflinger, message_queue)->InstallAsService(service_manager); | ||
| 845 | std::make_shared<IdleSys>()->InstallAsService(service_manager); | 892 | std::make_shared<IdleSys>()->InstallAsService(service_manager); |
| 846 | std::make_shared<OMM>()->InstallAsService(service_manager); | 893 | std::make_shared<OMM>()->InstallAsService(service_manager); |
| 847 | std::make_shared<SPSM>()->InstallAsService(service_manager); | 894 | std::make_shared<SPSM>()->InstallAsService(service_manager); |
diff --git a/src/core/hle/service/am/am.h b/src/core/hle/service/am/am.h index 095f94851..2f1c20bce 100644 --- a/src/core/hle/service/am/am.h +++ b/src/core/hle/service/am/am.h | |||
| @@ -5,6 +5,7 @@ | |||
| 5 | #pragma once | 5 | #pragma once |
| 6 | 6 | ||
| 7 | #include <memory> | 7 | #include <memory> |
| 8 | #include <queue> | ||
| 8 | #include "core/hle/service/service.h" | 9 | #include "core/hle/service/service.h" |
| 9 | 10 | ||
| 10 | namespace Kernel { | 11 | namespace Kernel { |
| @@ -39,6 +40,31 @@ enum SystemLanguage { | |||
| 39 | TraditionalChinese = 16, | 40 | TraditionalChinese = 16, |
| 40 | }; | 41 | }; |
| 41 | 42 | ||
| 43 | class AppletMessageQueue { | ||
| 44 | public: | ||
| 45 | enum class AppletMessage : u32 { | ||
| 46 | NoMessage = 0, | ||
| 47 | FocusStateChanged = 15, | ||
| 48 | OperationModeChanged = 30, | ||
| 49 | PerformanceModeChanged = 31, | ||
| 50 | }; | ||
| 51 | |||
| 52 | AppletMessageQueue(); | ||
| 53 | ~AppletMessageQueue(); | ||
| 54 | |||
| 55 | const Kernel::SharedPtr<Kernel::Event>& GetMesssageRecieveEvent() const; | ||
| 56 | const Kernel::SharedPtr<Kernel::Event>& GetOperationModeChangedEvent() const; | ||
| 57 | void PushMessage(AppletMessage msg); | ||
| 58 | AppletMessage PopMessage(); | ||
| 59 | std::size_t GetMessageCount() const; | ||
| 60 | void OperationModeChanged(); | ||
| 61 | |||
| 62 | private: | ||
| 63 | std::queue<AppletMessage> messages; | ||
| 64 | Kernel::SharedPtr<Kernel::Event> on_new_message; | ||
| 65 | Kernel::SharedPtr<Kernel::Event> on_operation_mode_changed; | ||
| 66 | }; | ||
| 67 | |||
| 42 | class IWindowController final : public ServiceFramework<IWindowController> { | 68 | class IWindowController final : public ServiceFramework<IWindowController> { |
| 43 | public: | 69 | public: |
| 44 | IWindowController(); | 70 | IWindowController(); |
| @@ -102,7 +128,7 @@ private: | |||
| 102 | 128 | ||
| 103 | class ICommonStateGetter final : public ServiceFramework<ICommonStateGetter> { | 129 | class ICommonStateGetter final : public ServiceFramework<ICommonStateGetter> { |
| 104 | public: | 130 | public: |
| 105 | ICommonStateGetter(); | 131 | explicit ICommonStateGetter(std::shared_ptr<AppletMessageQueue> msg_queue); |
| 106 | ~ICommonStateGetter() override; | 132 | ~ICommonStateGetter() override; |
| 107 | 133 | ||
| 108 | private: | 134 | private: |
| @@ -126,6 +152,7 @@ private: | |||
| 126 | void GetDefaultDisplayResolution(Kernel::HLERequestContext& ctx); | 152 | void GetDefaultDisplayResolution(Kernel::HLERequestContext& ctx); |
| 127 | 153 | ||
| 128 | Kernel::SharedPtr<Kernel::Event> event; | 154 | Kernel::SharedPtr<Kernel::Event> event; |
| 155 | std::shared_ptr<AppletMessageQueue> msg_queue; | ||
| 129 | }; | 156 | }; |
| 130 | 157 | ||
| 131 | class ILibraryAppletCreator final : public ServiceFramework<ILibraryAppletCreator> { | 158 | class ILibraryAppletCreator final : public ServiceFramework<ILibraryAppletCreator> { |
diff --git a/src/core/hle/service/am/applet_ae.cpp b/src/core/hle/service/am/applet_ae.cpp index 68ea778e8..ec93e3529 100644 --- a/src/core/hle/service/am/applet_ae.cpp +++ b/src/core/hle/service/am/applet_ae.cpp | |||
| @@ -12,8 +12,10 @@ namespace Service::AM { | |||
| 12 | 12 | ||
| 13 | class ILibraryAppletProxy final : public ServiceFramework<ILibraryAppletProxy> { | 13 | class ILibraryAppletProxy final : public ServiceFramework<ILibraryAppletProxy> { |
| 14 | public: | 14 | public: |
| 15 | explicit ILibraryAppletProxy(std::shared_ptr<NVFlinger::NVFlinger> nvflinger) | 15 | explicit ILibraryAppletProxy(std::shared_ptr<NVFlinger::NVFlinger> nvflinger, |
| 16 | : ServiceFramework("ILibraryAppletProxy"), nvflinger(std::move(nvflinger)) { | 16 | std::shared_ptr<AppletMessageQueue> msg_queue) |
| 17 | : ServiceFramework("ILibraryAppletProxy"), nvflinger(std::move(nvflinger)), | ||
| 18 | msg_queue(std::move(msg_queue)) { | ||
| 17 | static const FunctionInfo functions[] = { | 19 | static const FunctionInfo functions[] = { |
| 18 | {0, &ILibraryAppletProxy::GetCommonStateGetter, "GetCommonStateGetter"}, | 20 | {0, &ILibraryAppletProxy::GetCommonStateGetter, "GetCommonStateGetter"}, |
| 19 | {1, &ILibraryAppletProxy::GetSelfController, "GetSelfController"}, | 21 | {1, &ILibraryAppletProxy::GetSelfController, "GetSelfController"}, |
| @@ -32,7 +34,7 @@ private: | |||
| 32 | void GetCommonStateGetter(Kernel::HLERequestContext& ctx) { | 34 | void GetCommonStateGetter(Kernel::HLERequestContext& ctx) { |
| 33 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | 35 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; |
| 34 | rb.Push(RESULT_SUCCESS); | 36 | rb.Push(RESULT_SUCCESS); |
| 35 | rb.PushIpcInterface<ICommonStateGetter>(); | 37 | rb.PushIpcInterface<ICommonStateGetter>(msg_queue); |
| 36 | LOG_DEBUG(Service_AM, "called"); | 38 | LOG_DEBUG(Service_AM, "called"); |
| 37 | } | 39 | } |
| 38 | 40 | ||
| @@ -93,12 +95,15 @@ private: | |||
| 93 | } | 95 | } |
| 94 | 96 | ||
| 95 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; | 97 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; |
| 98 | std::shared_ptr<AppletMessageQueue> msg_queue; | ||
| 96 | }; | 99 | }; |
| 97 | 100 | ||
| 98 | class ISystemAppletProxy final : public ServiceFramework<ISystemAppletProxy> { | 101 | class ISystemAppletProxy final : public ServiceFramework<ISystemAppletProxy> { |
| 99 | public: | 102 | public: |
| 100 | explicit ISystemAppletProxy(std::shared_ptr<NVFlinger::NVFlinger> nvflinger) | 103 | explicit ISystemAppletProxy(std::shared_ptr<NVFlinger::NVFlinger> nvflinger, |
| 101 | : ServiceFramework("ISystemAppletProxy"), nvflinger(std::move(nvflinger)) { | 104 | std::shared_ptr<AppletMessageQueue> msg_queue) |
| 105 | : ServiceFramework("ISystemAppletProxy"), nvflinger(std::move(nvflinger)), | ||
| 106 | msg_queue(std::move(msg_queue)) { | ||
| 102 | static const FunctionInfo functions[] = { | 107 | static const FunctionInfo functions[] = { |
| 103 | {0, &ISystemAppletProxy::GetCommonStateGetter, "GetCommonStateGetter"}, | 108 | {0, &ISystemAppletProxy::GetCommonStateGetter, "GetCommonStateGetter"}, |
| 104 | {1, &ISystemAppletProxy::GetSelfController, "GetSelfController"}, | 109 | {1, &ISystemAppletProxy::GetSelfController, "GetSelfController"}, |
| @@ -119,7 +124,7 @@ private: | |||
| 119 | void GetCommonStateGetter(Kernel::HLERequestContext& ctx) { | 124 | void GetCommonStateGetter(Kernel::HLERequestContext& ctx) { |
| 120 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | 125 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; |
| 121 | rb.Push(RESULT_SUCCESS); | 126 | rb.Push(RESULT_SUCCESS); |
| 122 | rb.PushIpcInterface<ICommonStateGetter>(); | 127 | rb.PushIpcInterface<ICommonStateGetter>(msg_queue); |
| 123 | LOG_DEBUG(Service_AM, "called"); | 128 | LOG_DEBUG(Service_AM, "called"); |
| 124 | } | 129 | } |
| 125 | 130 | ||
| @@ -186,31 +191,34 @@ private: | |||
| 186 | LOG_DEBUG(Service_AM, "called"); | 191 | LOG_DEBUG(Service_AM, "called"); |
| 187 | } | 192 | } |
| 188 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; | 193 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; |
| 194 | std::shared_ptr<AppletMessageQueue> msg_queue; | ||
| 189 | }; | 195 | }; |
| 190 | 196 | ||
| 191 | void AppletAE::OpenSystemAppletProxy(Kernel::HLERequestContext& ctx) { | 197 | void AppletAE::OpenSystemAppletProxy(Kernel::HLERequestContext& ctx) { |
| 192 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | 198 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; |
| 193 | rb.Push(RESULT_SUCCESS); | 199 | rb.Push(RESULT_SUCCESS); |
| 194 | rb.PushIpcInterface<ISystemAppletProxy>(nvflinger); | 200 | rb.PushIpcInterface<ISystemAppletProxy>(nvflinger, msg_queue); |
| 195 | LOG_DEBUG(Service_AM, "called"); | 201 | LOG_DEBUG(Service_AM, "called"); |
| 196 | } | 202 | } |
| 197 | 203 | ||
| 198 | void AppletAE::OpenLibraryAppletProxy(Kernel::HLERequestContext& ctx) { | 204 | void AppletAE::OpenLibraryAppletProxy(Kernel::HLERequestContext& ctx) { |
| 199 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | 205 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; |
| 200 | rb.Push(RESULT_SUCCESS); | 206 | rb.Push(RESULT_SUCCESS); |
| 201 | rb.PushIpcInterface<ILibraryAppletProxy>(nvflinger); | 207 | rb.PushIpcInterface<ILibraryAppletProxy>(nvflinger, msg_queue); |
| 202 | LOG_DEBUG(Service_AM, "called"); | 208 | LOG_DEBUG(Service_AM, "called"); |
| 203 | } | 209 | } |
| 204 | 210 | ||
| 205 | void AppletAE::OpenLibraryAppletProxyOld(Kernel::HLERequestContext& ctx) { | 211 | void AppletAE::OpenLibraryAppletProxyOld(Kernel::HLERequestContext& ctx) { |
| 206 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | 212 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; |
| 207 | rb.Push(RESULT_SUCCESS); | 213 | rb.Push(RESULT_SUCCESS); |
| 208 | rb.PushIpcInterface<ILibraryAppletProxy>(nvflinger); | 214 | rb.PushIpcInterface<ILibraryAppletProxy>(nvflinger, msg_queue); |
| 209 | LOG_DEBUG(Service_AM, "called"); | 215 | LOG_DEBUG(Service_AM, "called"); |
| 210 | } | 216 | } |
| 211 | 217 | ||
| 212 | AppletAE::AppletAE(std::shared_ptr<NVFlinger::NVFlinger> nvflinger) | 218 | AppletAE::AppletAE(std::shared_ptr<NVFlinger::NVFlinger> nvflinger, |
| 213 | : ServiceFramework("appletAE"), nvflinger(std::move(nvflinger)) { | 219 | std::shared_ptr<AppletMessageQueue> msg_queue) |
| 220 | : ServiceFramework("appletAE"), nvflinger(std::move(nvflinger)), | ||
| 221 | msg_queue(std::move(msg_queue)) { | ||
| 214 | // clang-format off | 222 | // clang-format off |
| 215 | static const FunctionInfo functions[] = { | 223 | static const FunctionInfo functions[] = { |
| 216 | {100, &AppletAE::OpenSystemAppletProxy, "OpenSystemAppletProxy"}, | 224 | {100, &AppletAE::OpenSystemAppletProxy, "OpenSystemAppletProxy"}, |
| @@ -228,4 +236,8 @@ AppletAE::AppletAE(std::shared_ptr<NVFlinger::NVFlinger> nvflinger) | |||
| 228 | 236 | ||
| 229 | AppletAE::~AppletAE() = default; | 237 | AppletAE::~AppletAE() = default; |
| 230 | 238 | ||
| 239 | const std::shared_ptr<AppletMessageQueue>& AppletAE::GetMessageQueue() const { | ||
| 240 | return msg_queue; | ||
| 241 | } | ||
| 242 | |||
| 231 | } // namespace Service::AM | 243 | } // namespace Service::AM |
diff --git a/src/core/hle/service/am/applet_ae.h b/src/core/hle/service/am/applet_ae.h index 1ed77baa4..902db2665 100644 --- a/src/core/hle/service/am/applet_ae.h +++ b/src/core/hle/service/am/applet_ae.h | |||
| @@ -17,15 +17,19 @@ namespace AM { | |||
| 17 | 17 | ||
| 18 | class AppletAE final : public ServiceFramework<AppletAE> { | 18 | class AppletAE final : public ServiceFramework<AppletAE> { |
| 19 | public: | 19 | public: |
| 20 | explicit AppletAE(std::shared_ptr<NVFlinger::NVFlinger> nvflinger); | 20 | explicit AppletAE(std::shared_ptr<NVFlinger::NVFlinger> nvflinger, |
| 21 | std::shared_ptr<AppletMessageQueue> msg_queue); | ||
| 21 | ~AppletAE() override; | 22 | ~AppletAE() override; |
| 22 | 23 | ||
| 24 | const std::shared_ptr<AppletMessageQueue>& GetMessageQueue() const; | ||
| 25 | |||
| 23 | private: | 26 | private: |
| 24 | void OpenSystemAppletProxy(Kernel::HLERequestContext& ctx); | 27 | void OpenSystemAppletProxy(Kernel::HLERequestContext& ctx); |
| 25 | void OpenLibraryAppletProxy(Kernel::HLERequestContext& ctx); | 28 | void OpenLibraryAppletProxy(Kernel::HLERequestContext& ctx); |
| 26 | void OpenLibraryAppletProxyOld(Kernel::HLERequestContext& ctx); | 29 | void OpenLibraryAppletProxyOld(Kernel::HLERequestContext& ctx); |
| 27 | 30 | ||
| 28 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; | 31 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; |
| 32 | std::shared_ptr<AppletMessageQueue> msg_queue; | ||
| 29 | }; | 33 | }; |
| 30 | 34 | ||
| 31 | } // namespace AM | 35 | } // namespace AM |
diff --git a/src/core/hle/service/am/applet_oe.cpp b/src/core/hle/service/am/applet_oe.cpp index 60717afd9..20c8d5fff 100644 --- a/src/core/hle/service/am/applet_oe.cpp +++ b/src/core/hle/service/am/applet_oe.cpp | |||
| @@ -12,8 +12,10 @@ namespace Service::AM { | |||
| 12 | 12 | ||
| 13 | class IApplicationProxy final : public ServiceFramework<IApplicationProxy> { | 13 | class IApplicationProxy final : public ServiceFramework<IApplicationProxy> { |
| 14 | public: | 14 | public: |
| 15 | explicit IApplicationProxy(std::shared_ptr<NVFlinger::NVFlinger> nvflinger) | 15 | explicit IApplicationProxy(std::shared_ptr<NVFlinger::NVFlinger> nvflinger, |
| 16 | : ServiceFramework("IApplicationProxy"), nvflinger(std::move(nvflinger)) { | 16 | std::shared_ptr<AppletMessageQueue> msg_queue) |
| 17 | : ServiceFramework("IApplicationProxy"), nvflinger(std::move(nvflinger)), | ||
| 18 | msg_queue(std::move(msg_queue)) { | ||
| 17 | // clang-format off | 19 | // clang-format off |
| 18 | static const FunctionInfo functions[] = { | 20 | static const FunctionInfo functions[] = { |
| 19 | {0, &IApplicationProxy::GetCommonStateGetter, "GetCommonStateGetter"}, | 21 | {0, &IApplicationProxy::GetCommonStateGetter, "GetCommonStateGetter"}, |
| @@ -70,7 +72,7 @@ private: | |||
| 70 | void GetCommonStateGetter(Kernel::HLERequestContext& ctx) { | 72 | void GetCommonStateGetter(Kernel::HLERequestContext& ctx) { |
| 71 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | 73 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; |
| 72 | rb.Push(RESULT_SUCCESS); | 74 | rb.Push(RESULT_SUCCESS); |
| 73 | rb.PushIpcInterface<ICommonStateGetter>(); | 75 | rb.PushIpcInterface<ICommonStateGetter>(msg_queue); |
| 74 | LOG_DEBUG(Service_AM, "called"); | 76 | LOG_DEBUG(Service_AM, "called"); |
| 75 | } | 77 | } |
| 76 | 78 | ||
| @@ -89,17 +91,20 @@ private: | |||
| 89 | } | 91 | } |
| 90 | 92 | ||
| 91 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; | 93 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; |
| 94 | std::shared_ptr<AppletMessageQueue> msg_queue; | ||
| 92 | }; | 95 | }; |
| 93 | 96 | ||
| 94 | void AppletOE::OpenApplicationProxy(Kernel::HLERequestContext& ctx) { | 97 | void AppletOE::OpenApplicationProxy(Kernel::HLERequestContext& ctx) { |
| 95 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | 98 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; |
| 96 | rb.Push(RESULT_SUCCESS); | 99 | rb.Push(RESULT_SUCCESS); |
| 97 | rb.PushIpcInterface<IApplicationProxy>(nvflinger); | 100 | rb.PushIpcInterface<IApplicationProxy>(nvflinger, msg_queue); |
| 98 | LOG_DEBUG(Service_AM, "called"); | 101 | LOG_DEBUG(Service_AM, "called"); |
| 99 | } | 102 | } |
| 100 | 103 | ||
| 101 | AppletOE::AppletOE(std::shared_ptr<NVFlinger::NVFlinger> nvflinger) | 104 | AppletOE::AppletOE(std::shared_ptr<NVFlinger::NVFlinger> nvflinger, |
| 102 | : ServiceFramework("appletOE"), nvflinger(std::move(nvflinger)) { | 105 | std::shared_ptr<AppletMessageQueue> msg_queue) |
| 106 | : ServiceFramework("appletOE"), nvflinger(std::move(nvflinger)), | ||
| 107 | msg_queue(std::move(msg_queue)) { | ||
| 103 | static const FunctionInfo functions[] = { | 108 | static const FunctionInfo functions[] = { |
| 104 | {0, &AppletOE::OpenApplicationProxy, "OpenApplicationProxy"}, | 109 | {0, &AppletOE::OpenApplicationProxy, "OpenApplicationProxy"}, |
| 105 | }; | 110 | }; |
| @@ -108,4 +113,8 @@ AppletOE::AppletOE(std::shared_ptr<NVFlinger::NVFlinger> nvflinger) | |||
| 108 | 113 | ||
| 109 | AppletOE::~AppletOE() = default; | 114 | AppletOE::~AppletOE() = default; |
| 110 | 115 | ||
| 116 | const std::shared_ptr<AppletMessageQueue>& AppletOE::GetMessageQueue() const { | ||
| 117 | return msg_queue; | ||
| 118 | } | ||
| 119 | |||
| 111 | } // namespace Service::AM | 120 | } // namespace Service::AM |
diff --git a/src/core/hle/service/am/applet_oe.h b/src/core/hle/service/am/applet_oe.h index 60cfdfd9d..bbd0108ef 100644 --- a/src/core/hle/service/am/applet_oe.h +++ b/src/core/hle/service/am/applet_oe.h | |||
| @@ -17,13 +17,17 @@ namespace AM { | |||
| 17 | 17 | ||
| 18 | class AppletOE final : public ServiceFramework<AppletOE> { | 18 | class AppletOE final : public ServiceFramework<AppletOE> { |
| 19 | public: | 19 | public: |
| 20 | explicit AppletOE(std::shared_ptr<NVFlinger::NVFlinger> nvflinger); | 20 | explicit AppletOE(std::shared_ptr<NVFlinger::NVFlinger> nvflinger, |
| 21 | std::shared_ptr<AppletMessageQueue> msg_queue); | ||
| 21 | ~AppletOE() override; | 22 | ~AppletOE() override; |
| 22 | 23 | ||
| 24 | const std::shared_ptr<AppletMessageQueue>& GetMessageQueue() const; | ||
| 25 | |||
| 23 | private: | 26 | private: |
| 24 | void OpenApplicationProxy(Kernel::HLERequestContext& ctx); | 27 | void OpenApplicationProxy(Kernel::HLERequestContext& ctx); |
| 25 | 28 | ||
| 26 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; | 29 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; |
| 30 | std::shared_ptr<AppletMessageQueue> msg_queue; | ||
| 27 | }; | 31 | }; |
| 28 | 32 | ||
| 29 | } // namespace AM | 33 | } // namespace AM |
diff --git a/src/core/hle/service/hid/controllers/npad.cpp b/src/core/hle/service/hid/controllers/npad.cpp index 1ef789bd0..ff9b64be4 100644 --- a/src/core/hle/service/hid/controllers/npad.cpp +++ b/src/core/hle/service/hid/controllers/npad.cpp | |||
| @@ -392,8 +392,10 @@ std::size_t Controller_NPad::GetSupportedNPadIdTypesSize() const { | |||
| 392 | } | 392 | } |
| 393 | 393 | ||
| 394 | void Controller_NPad::SetHoldType(NpadHoldType joy_hold_type) { | 394 | void Controller_NPad::SetHoldType(NpadHoldType joy_hold_type) { |
| 395 | styleset_changed_event->Signal(); | ||
| 395 | hold_type = joy_hold_type; | 396 | hold_type = joy_hold_type; |
| 396 | } | 397 | } |
| 398 | |||
| 397 | Controller_NPad::NpadHoldType Controller_NPad::GetHoldType() const { | 399 | Controller_NPad::NpadHoldType Controller_NPad::GetHoldType() const { |
| 398 | return hold_type; | 400 | return hold_type; |
| 399 | } | 401 | } |
diff --git a/src/video_core/CMakeLists.txt b/src/video_core/CMakeLists.txt index ddb1a1d69..a780215c1 100644 --- a/src/video_core/CMakeLists.txt +++ b/src/video_core/CMakeLists.txt | |||
| @@ -21,6 +21,7 @@ add_library(video_core STATIC | |||
| 21 | macro_interpreter.h | 21 | macro_interpreter.h |
| 22 | memory_manager.cpp | 22 | memory_manager.cpp |
| 23 | memory_manager.h | 23 | memory_manager.h |
| 24 | rasterizer_cache.cpp | ||
| 24 | rasterizer_cache.h | 25 | rasterizer_cache.h |
| 25 | rasterizer_interface.h | 26 | rasterizer_interface.h |
| 26 | renderer_base.cpp | 27 | renderer_base.cpp |
| @@ -33,6 +34,7 @@ add_library(video_core STATIC | |||
| 33 | renderer_opengl/gl_rasterizer.h | 34 | renderer_opengl/gl_rasterizer.h |
| 34 | renderer_opengl/gl_rasterizer_cache.cpp | 35 | renderer_opengl/gl_rasterizer_cache.cpp |
| 35 | renderer_opengl/gl_rasterizer_cache.h | 36 | renderer_opengl/gl_rasterizer_cache.h |
| 37 | renderer_opengl/gl_resource_manager.cpp | ||
| 36 | renderer_opengl/gl_resource_manager.h | 38 | renderer_opengl/gl_resource_manager.h |
| 37 | renderer_opengl/gl_shader_cache.cpp | 39 | renderer_opengl/gl_shader_cache.cpp |
| 38 | renderer_opengl/gl_shader_cache.h | 40 | renderer_opengl/gl_shader_cache.h |
diff --git a/src/video_core/engines/maxwell_3d.cpp b/src/video_core/engines/maxwell_3d.cpp index d79c50919..5ae836aca 100644 --- a/src/video_core/engines/maxwell_3d.cpp +++ b/src/video_core/engines/maxwell_3d.cpp | |||
| @@ -37,6 +37,22 @@ void Maxwell3D::InitializeRegisterDefaults() { | |||
| 37 | regs.viewport[viewport].depth_range_near = 0.0f; | 37 | regs.viewport[viewport].depth_range_near = 0.0f; |
| 38 | regs.viewport[viewport].depth_range_far = 1.0f; | 38 | regs.viewport[viewport].depth_range_far = 1.0f; |
| 39 | } | 39 | } |
| 40 | // Doom and Bomberman seems to use the uninitialized registers and just enable blend | ||
| 41 | // so initialize blend registers with sane values | ||
| 42 | regs.blend.equation_rgb = Regs::Blend::Equation::Add; | ||
| 43 | regs.blend.factor_source_rgb = Regs::Blend::Factor::One; | ||
| 44 | regs.blend.factor_dest_rgb = Regs::Blend::Factor::Zero; | ||
| 45 | regs.blend.equation_a = Regs::Blend::Equation::Add; | ||
| 46 | regs.blend.factor_source_a = Regs::Blend::Factor::One; | ||
| 47 | regs.blend.factor_dest_a = Regs::Blend::Factor::Zero; | ||
| 48 | for (std::size_t blend_index = 0; blend_index < Regs::NumRenderTargets; blend_index++) { | ||
| 49 | regs.independent_blend[blend_index].equation_rgb = Regs::Blend::Equation::Add; | ||
| 50 | regs.independent_blend[blend_index].factor_source_rgb = Regs::Blend::Factor::One; | ||
| 51 | regs.independent_blend[blend_index].factor_dest_rgb = Regs::Blend::Factor::Zero; | ||
| 52 | regs.independent_blend[blend_index].equation_a = Regs::Blend::Equation::Add; | ||
| 53 | regs.independent_blend[blend_index].factor_source_a = Regs::Blend::Factor::One; | ||
| 54 | regs.independent_blend[blend_index].factor_dest_a = Regs::Blend::Factor::Zero; | ||
| 55 | } | ||
| 40 | } | 56 | } |
| 41 | 57 | ||
| 42 | void Maxwell3D::CallMacroMethod(u32 method, std::vector<u32> parameters) { | 58 | void Maxwell3D::CallMacroMethod(u32 method, std::vector<u32> parameters) { |
| @@ -92,8 +108,16 @@ void Maxwell3D::WriteReg(u32 method, u32 value, u32 remaining_params) { | |||
| 92 | debug_context->OnEvent(Tegra::DebugContext::Event::MaxwellCommandLoaded, nullptr); | 108 | debug_context->OnEvent(Tegra::DebugContext::Event::MaxwellCommandLoaded, nullptr); |
| 93 | } | 109 | } |
| 94 | 110 | ||
| 111 | u32 old = regs.reg_array[method]; | ||
| 95 | regs.reg_array[method] = value; | 112 | regs.reg_array[method] = value; |
| 96 | 113 | ||
| 114 | if (value != old) { | ||
| 115 | if (method >= MAXWELL3D_REG_INDEX(vertex_attrib_format) && | ||
| 116 | method < MAXWELL3D_REG_INDEX(vertex_attrib_format) + regs.vertex_attrib_format.size()) { | ||
| 117 | dirty_flags.vertex_attrib_format = true; | ||
| 118 | } | ||
| 119 | } | ||
| 120 | |||
| 97 | switch (method) { | 121 | switch (method) { |
| 98 | case MAXWELL3D_REG_INDEX(macros.data): { | 122 | case MAXWELL3D_REG_INDEX(macros.data): { |
| 99 | ProcessMacroUpload(value); | 123 | ProcessMacroUpload(value); |
diff --git a/src/video_core/engines/maxwell_3d.h b/src/video_core/engines/maxwell_3d.h index 50873813e..557795d0f 100644 --- a/src/video_core/engines/maxwell_3d.h +++ b/src/video_core/engines/maxwell_3d.h | |||
| @@ -462,6 +462,16 @@ public: | |||
| 462 | } | 462 | } |
| 463 | }; | 463 | }; |
| 464 | 464 | ||
| 465 | struct ColorMask { | ||
| 466 | union { | ||
| 467 | u32 raw; | ||
| 468 | BitField<0, 4, u32> R; | ||
| 469 | BitField<4, 4, u32> G; | ||
| 470 | BitField<8, 4, u32> B; | ||
| 471 | BitField<12, 4, u32> A; | ||
| 472 | }; | ||
| 473 | }; | ||
| 474 | |||
| 465 | bool IsShaderConfigEnabled(std::size_t index) const { | 475 | bool IsShaderConfigEnabled(std::size_t index) const { |
| 466 | // The VertexB is always enabled. | 476 | // The VertexB is always enabled. |
| 467 | if (index == static_cast<std::size_t>(Regs::ShaderProgram::VertexB)) { | 477 | if (index == static_cast<std::size_t>(Regs::ShaderProgram::VertexB)) { |
| @@ -571,7 +581,11 @@ public: | |||
| 571 | u32 stencil_back_mask; | 581 | u32 stencil_back_mask; |
| 572 | u32 stencil_back_func_mask; | 582 | u32 stencil_back_func_mask; |
| 573 | 583 | ||
| 574 | INSERT_PADDING_WORDS(0x13); | 584 | INSERT_PADDING_WORDS(0xC); |
| 585 | |||
| 586 | u32 color_mask_common; | ||
| 587 | |||
| 588 | INSERT_PADDING_WORDS(0x6); | ||
| 575 | 589 | ||
| 576 | u32 rt_separate_frag_data; | 590 | u32 rt_separate_frag_data; |
| 577 | 591 | ||
| @@ -646,8 +660,14 @@ public: | |||
| 646 | ComparisonOp depth_test_func; | 660 | ComparisonOp depth_test_func; |
| 647 | float alpha_test_ref; | 661 | float alpha_test_ref; |
| 648 | ComparisonOp alpha_test_func; | 662 | ComparisonOp alpha_test_func; |
| 649 | 663 | u32 draw_tfb_stride; | |
| 650 | INSERT_PADDING_WORDS(0x9); | 664 | struct { |
| 665 | float r; | ||
| 666 | float g; | ||
| 667 | float b; | ||
| 668 | float a; | ||
| 669 | } blend_color; | ||
| 670 | INSERT_PADDING_WORDS(0x4); | ||
| 651 | 671 | ||
| 652 | struct { | 672 | struct { |
| 653 | u32 separate_alpha; | 673 | u32 separate_alpha; |
| @@ -841,8 +861,9 @@ public: | |||
| 841 | BitField<6, 4, u32> RT; | 861 | BitField<6, 4, u32> RT; |
| 842 | BitField<10, 11, u32> layer; | 862 | BitField<10, 11, u32> layer; |
| 843 | } clear_buffers; | 863 | } clear_buffers; |
| 844 | 864 | INSERT_PADDING_WORDS(0xB); | |
| 845 | INSERT_PADDING_WORDS(0x4B); | 865 | std::array<ColorMask, NumRenderTargets> color_mask; |
| 866 | INSERT_PADDING_WORDS(0x38); | ||
| 846 | 867 | ||
| 847 | struct { | 868 | struct { |
| 848 | u32 query_address_high; | 869 | u32 query_address_high; |
| @@ -983,6 +1004,12 @@ public: | |||
| 983 | State state{}; | 1004 | State state{}; |
| 984 | MemoryManager& memory_manager; | 1005 | MemoryManager& memory_manager; |
| 985 | 1006 | ||
| 1007 | struct DirtyFlags { | ||
| 1008 | bool vertex_attrib_format = true; | ||
| 1009 | }; | ||
| 1010 | |||
| 1011 | DirtyFlags dirty_flags; | ||
| 1012 | |||
| 986 | /// Reads a register value located at the input method address | 1013 | /// Reads a register value located at the input method address |
| 987 | u32 GetRegisterValue(u32 method) const; | 1014 | u32 GetRegisterValue(u32 method) const; |
| 988 | 1015 | ||
| @@ -1075,6 +1102,7 @@ ASSERT_REG_POSITION(scissor_test, 0x380); | |||
| 1075 | ASSERT_REG_POSITION(stencil_back_func_ref, 0x3D5); | 1102 | ASSERT_REG_POSITION(stencil_back_func_ref, 0x3D5); |
| 1076 | ASSERT_REG_POSITION(stencil_back_mask, 0x3D6); | 1103 | ASSERT_REG_POSITION(stencil_back_mask, 0x3D6); |
| 1077 | ASSERT_REG_POSITION(stencil_back_func_mask, 0x3D7); | 1104 | ASSERT_REG_POSITION(stencil_back_func_mask, 0x3D7); |
| 1105 | ASSERT_REG_POSITION(color_mask_common, 0x3E4); | ||
| 1078 | ASSERT_REG_POSITION(rt_separate_frag_data, 0x3EB); | 1106 | ASSERT_REG_POSITION(rt_separate_frag_data, 0x3EB); |
| 1079 | ASSERT_REG_POSITION(zeta, 0x3F8); | 1107 | ASSERT_REG_POSITION(zeta, 0x3F8); |
| 1080 | ASSERT_REG_POSITION(vertex_attrib_format, 0x458); | 1108 | ASSERT_REG_POSITION(vertex_attrib_format, 0x458); |
| @@ -1087,6 +1115,10 @@ ASSERT_REG_POSITION(depth_write_enabled, 0x4BA); | |||
| 1087 | ASSERT_REG_POSITION(alpha_test_enabled, 0x4BB); | 1115 | ASSERT_REG_POSITION(alpha_test_enabled, 0x4BB); |
| 1088 | ASSERT_REG_POSITION(d3d_cull_mode, 0x4C2); | 1116 | ASSERT_REG_POSITION(d3d_cull_mode, 0x4C2); |
| 1089 | ASSERT_REG_POSITION(depth_test_func, 0x4C3); | 1117 | ASSERT_REG_POSITION(depth_test_func, 0x4C3); |
| 1118 | ASSERT_REG_POSITION(alpha_test_ref, 0x4C4); | ||
| 1119 | ASSERT_REG_POSITION(alpha_test_func, 0x4C5); | ||
| 1120 | ASSERT_REG_POSITION(draw_tfb_stride, 0x4C6); | ||
| 1121 | ASSERT_REG_POSITION(blend_color, 0x4C7); | ||
| 1090 | ASSERT_REG_POSITION(blend, 0x4CF); | 1122 | ASSERT_REG_POSITION(blend, 0x4CF); |
| 1091 | ASSERT_REG_POSITION(stencil_enable, 0x4E0); | 1123 | ASSERT_REG_POSITION(stencil_enable, 0x4E0); |
| 1092 | ASSERT_REG_POSITION(stencil_front_op_fail, 0x4E1); | 1124 | ASSERT_REG_POSITION(stencil_front_op_fail, 0x4E1); |
| @@ -1117,6 +1149,7 @@ ASSERT_REG_POSITION(instanced_arrays, 0x620); | |||
| 1117 | ASSERT_REG_POSITION(cull, 0x646); | 1149 | ASSERT_REG_POSITION(cull, 0x646); |
| 1118 | ASSERT_REG_POSITION(logic_op, 0x671); | 1150 | ASSERT_REG_POSITION(logic_op, 0x671); |
| 1119 | ASSERT_REG_POSITION(clear_buffers, 0x674); | 1151 | ASSERT_REG_POSITION(clear_buffers, 0x674); |
| 1152 | ASSERT_REG_POSITION(color_mask, 0x680); | ||
| 1120 | ASSERT_REG_POSITION(query, 0x6C0); | 1153 | ASSERT_REG_POSITION(query, 0x6C0); |
| 1121 | ASSERT_REG_POSITION(vertex_array[0], 0x700); | 1154 | ASSERT_REG_POSITION(vertex_array[0], 0x700); |
| 1122 | ASSERT_REG_POSITION(independent_blend, 0x780); | 1155 | ASSERT_REG_POSITION(independent_blend, 0x780); |
diff --git a/src/video_core/memory_manager.cpp b/src/video_core/memory_manager.cpp index 90a8e825d..77a20bb84 100644 --- a/src/video_core/memory_manager.cpp +++ b/src/video_core/memory_manager.cpp | |||
| @@ -4,18 +4,21 @@ | |||
| 4 | 4 | ||
| 5 | #include "common/alignment.h" | 5 | #include "common/alignment.h" |
| 6 | #include "common/assert.h" | 6 | #include "common/assert.h" |
| 7 | #include "common/logging/log.h" | ||
| 7 | #include "video_core/memory_manager.h" | 8 | #include "video_core/memory_manager.h" |
| 8 | 9 | ||
| 9 | namespace Tegra { | 10 | namespace Tegra { |
| 10 | 11 | ||
| 11 | GPUVAddr MemoryManager::AllocateSpace(u64 size, u64 align) { | 12 | GPUVAddr MemoryManager::AllocateSpace(u64 size, u64 align) { |
| 12 | std::optional<GPUVAddr> gpu_addr = FindFreeBlock(size, align); | 13 | const std::optional<GPUVAddr> gpu_addr{FindFreeBlock(0, size, align, PageStatus::Unmapped)}; |
| 13 | ASSERT(gpu_addr); | ||
| 14 | 14 | ||
| 15 | for (u64 offset = 0; offset < size; offset += PAGE_SIZE) { | 15 | ASSERT_MSG(gpu_addr, "unable to find available GPU memory"); |
| 16 | VAddr& slot = PageSlot(*gpu_addr + offset); | 16 | |
| 17 | for (u64 offset{}; offset < size; offset += PAGE_SIZE) { | ||
| 18 | VAddr& slot{PageSlot(*gpu_addr + offset)}; | ||
| 17 | 19 | ||
| 18 | ASSERT(slot == static_cast<u64>(PageStatus::Unmapped)); | 20 | ASSERT(slot == static_cast<u64>(PageStatus::Unmapped)); |
| 21 | |||
| 19 | slot = static_cast<u64>(PageStatus::Allocated); | 22 | slot = static_cast<u64>(PageStatus::Allocated); |
| 20 | } | 23 | } |
| 21 | 24 | ||
| @@ -23,10 +26,11 @@ GPUVAddr MemoryManager::AllocateSpace(u64 size, u64 align) { | |||
| 23 | } | 26 | } |
| 24 | 27 | ||
| 25 | GPUVAddr MemoryManager::AllocateSpace(GPUVAddr gpu_addr, u64 size, u64 align) { | 28 | GPUVAddr MemoryManager::AllocateSpace(GPUVAddr gpu_addr, u64 size, u64 align) { |
| 26 | for (u64 offset = 0; offset < size; offset += PAGE_SIZE) { | 29 | for (u64 offset{}; offset < size; offset += PAGE_SIZE) { |
| 27 | VAddr& slot = PageSlot(gpu_addr + offset); | 30 | VAddr& slot{PageSlot(gpu_addr + offset)}; |
| 28 | 31 | ||
| 29 | ASSERT(slot == static_cast<u64>(PageStatus::Unmapped)); | 32 | ASSERT(slot == static_cast<u64>(PageStatus::Unmapped)); |
| 33 | |||
| 30 | slot = static_cast<u64>(PageStatus::Allocated); | 34 | slot = static_cast<u64>(PageStatus::Allocated); |
| 31 | } | 35 | } |
| 32 | 36 | ||
| @@ -34,17 +38,19 @@ GPUVAddr MemoryManager::AllocateSpace(GPUVAddr gpu_addr, u64 size, u64 align) { | |||
| 34 | } | 38 | } |
| 35 | 39 | ||
| 36 | GPUVAddr MemoryManager::MapBufferEx(VAddr cpu_addr, u64 size) { | 40 | GPUVAddr MemoryManager::MapBufferEx(VAddr cpu_addr, u64 size) { |
| 37 | std::optional<GPUVAddr> gpu_addr = FindFreeBlock(size, PAGE_SIZE); | 41 | const std::optional<GPUVAddr> gpu_addr{FindFreeBlock(0, size, PAGE_SIZE, PageStatus::Unmapped)}; |
| 38 | ASSERT(gpu_addr); | 42 | |
| 43 | ASSERT_MSG(gpu_addr, "unable to find available GPU memory"); | ||
| 39 | 44 | ||
| 40 | for (u64 offset = 0; offset < size; offset += PAGE_SIZE) { | 45 | for (u64 offset{}; offset < size; offset += PAGE_SIZE) { |
| 41 | VAddr& slot = PageSlot(*gpu_addr + offset); | 46 | VAddr& slot{PageSlot(*gpu_addr + offset)}; |
| 42 | 47 | ||
| 43 | ASSERT(slot == static_cast<u64>(PageStatus::Unmapped)); | 48 | ASSERT(slot == static_cast<u64>(PageStatus::Unmapped)); |
| 49 | |||
| 44 | slot = cpu_addr + offset; | 50 | slot = cpu_addr + offset; |
| 45 | } | 51 | } |
| 46 | 52 | ||
| 47 | MappedRegion region{cpu_addr, *gpu_addr, size}; | 53 | const MappedRegion region{cpu_addr, *gpu_addr, size}; |
| 48 | mapped_regions.push_back(region); | 54 | mapped_regions.push_back(region); |
| 49 | 55 | ||
| 50 | return *gpu_addr; | 56 | return *gpu_addr; |
| @@ -53,14 +59,31 @@ GPUVAddr MemoryManager::MapBufferEx(VAddr cpu_addr, u64 size) { | |||
| 53 | GPUVAddr MemoryManager::MapBufferEx(VAddr cpu_addr, GPUVAddr gpu_addr, u64 size) { | 59 | GPUVAddr MemoryManager::MapBufferEx(VAddr cpu_addr, GPUVAddr gpu_addr, u64 size) { |
| 54 | ASSERT((gpu_addr & PAGE_MASK) == 0); | 60 | ASSERT((gpu_addr & PAGE_MASK) == 0); |
| 55 | 61 | ||
| 56 | for (u64 offset = 0; offset < size; offset += PAGE_SIZE) { | 62 | if (PageSlot(gpu_addr) != static_cast<u64>(PageStatus::Allocated)) { |
| 57 | VAddr& slot = PageSlot(gpu_addr + offset); | 63 | // Page has been already mapped. In this case, we must find a new area of memory to use that |
| 64 | // is different than the specified one. Super Mario Odyssey hits this scenario when changing | ||
| 65 | // areas, but we do not want to overwrite the old pages. | ||
| 66 | // TODO(bunnei): We need to write a hardware test to confirm this behavior. | ||
| 67 | |||
| 68 | LOG_ERROR(HW_GPU, "attempting to map addr 0x{:016X}, which is not available!", gpu_addr); | ||
| 69 | |||
| 70 | const std::optional<GPUVAddr> new_gpu_addr{ | ||
| 71 | FindFreeBlock(gpu_addr, size, PAGE_SIZE, PageStatus::Allocated)}; | ||
| 72 | |||
| 73 | ASSERT_MSG(new_gpu_addr, "unable to find available GPU memory"); | ||
| 74 | |||
| 75 | gpu_addr = *new_gpu_addr; | ||
| 76 | } | ||
| 77 | |||
| 78 | for (u64 offset{}; offset < size; offset += PAGE_SIZE) { | ||
| 79 | VAddr& slot{PageSlot(gpu_addr + offset)}; | ||
| 58 | 80 | ||
| 59 | ASSERT(slot == static_cast<u64>(PageStatus::Allocated)); | 81 | ASSERT(slot == static_cast<u64>(PageStatus::Allocated)); |
| 82 | |||
| 60 | slot = cpu_addr + offset; | 83 | slot = cpu_addr + offset; |
| 61 | } | 84 | } |
| 62 | 85 | ||
| 63 | MappedRegion region{cpu_addr, gpu_addr, size}; | 86 | const MappedRegion region{cpu_addr, gpu_addr, size}; |
| 64 | mapped_regions.push_back(region); | 87 | mapped_regions.push_back(region); |
| 65 | 88 | ||
| 66 | return gpu_addr; | 89 | return gpu_addr; |
| @@ -69,11 +92,12 @@ GPUVAddr MemoryManager::MapBufferEx(VAddr cpu_addr, GPUVAddr gpu_addr, u64 size) | |||
| 69 | GPUVAddr MemoryManager::UnmapBuffer(GPUVAddr gpu_addr, u64 size) { | 92 | GPUVAddr MemoryManager::UnmapBuffer(GPUVAddr gpu_addr, u64 size) { |
| 70 | ASSERT((gpu_addr & PAGE_MASK) == 0); | 93 | ASSERT((gpu_addr & PAGE_MASK) == 0); |
| 71 | 94 | ||
| 72 | for (u64 offset = 0; offset < size; offset += PAGE_SIZE) { | 95 | for (u64 offset{}; offset < size; offset += PAGE_SIZE) { |
| 73 | VAddr& slot = PageSlot(gpu_addr + offset); | 96 | VAddr& slot{PageSlot(gpu_addr + offset)}; |
| 74 | 97 | ||
| 75 | ASSERT(slot != static_cast<u64>(PageStatus::Allocated) && | 98 | ASSERT(slot != static_cast<u64>(PageStatus::Allocated) && |
| 76 | slot != static_cast<u64>(PageStatus::Unmapped)); | 99 | slot != static_cast<u64>(PageStatus::Unmapped)); |
| 100 | |||
| 77 | slot = static_cast<u64>(PageStatus::Unmapped); | 101 | slot = static_cast<u64>(PageStatus::Unmapped); |
| 78 | } | 102 | } |
| 79 | 103 | ||
| @@ -97,13 +121,14 @@ GPUVAddr MemoryManager::GetRegionEnd(GPUVAddr region_start) const { | |||
| 97 | return {}; | 121 | return {}; |
| 98 | } | 122 | } |
| 99 | 123 | ||
| 100 | std::optional<GPUVAddr> MemoryManager::FindFreeBlock(u64 size, u64 align) { | 124 | std::optional<GPUVAddr> MemoryManager::FindFreeBlock(GPUVAddr region_start, u64 size, u64 align, |
| 101 | GPUVAddr gpu_addr = 0; | 125 | PageStatus status) { |
| 102 | u64 free_space = 0; | 126 | GPUVAddr gpu_addr{region_start}; |
| 127 | u64 free_space{}; | ||
| 103 | align = (align + PAGE_MASK) & ~PAGE_MASK; | 128 | align = (align + PAGE_MASK) & ~PAGE_MASK; |
| 104 | 129 | ||
| 105 | while (gpu_addr + free_space < MAX_ADDRESS) { | 130 | while (gpu_addr + free_space < MAX_ADDRESS) { |
| 106 | if (!IsPageMapped(gpu_addr + free_space)) { | 131 | if (PageSlot(gpu_addr + free_space) == static_cast<u64>(status)) { |
| 107 | free_space += PAGE_SIZE; | 132 | free_space += PAGE_SIZE; |
| 108 | if (free_space >= size) { | 133 | if (free_space >= size) { |
| 109 | return gpu_addr; | 134 | return gpu_addr; |
| @@ -119,7 +144,7 @@ std::optional<GPUVAddr> MemoryManager::FindFreeBlock(u64 size, u64 align) { | |||
| 119 | } | 144 | } |
| 120 | 145 | ||
| 121 | std::optional<VAddr> MemoryManager::GpuToCpuAddress(GPUVAddr gpu_addr) { | 146 | std::optional<VAddr> MemoryManager::GpuToCpuAddress(GPUVAddr gpu_addr) { |
| 122 | VAddr base_addr = PageSlot(gpu_addr); | 147 | const VAddr base_addr{PageSlot(gpu_addr)}; |
| 123 | 148 | ||
| 124 | if (base_addr == static_cast<u64>(PageStatus::Allocated) || | 149 | if (base_addr == static_cast<u64>(PageStatus::Allocated) || |
| 125 | base_addr == static_cast<u64>(PageStatus::Unmapped)) { | 150 | base_addr == static_cast<u64>(PageStatus::Unmapped)) { |
| @@ -133,19 +158,15 @@ std::vector<GPUVAddr> MemoryManager::CpuToGpuAddress(VAddr cpu_addr) const { | |||
| 133 | std::vector<GPUVAddr> results; | 158 | std::vector<GPUVAddr> results; |
| 134 | for (const auto& region : mapped_regions) { | 159 | for (const auto& region : mapped_regions) { |
| 135 | if (cpu_addr >= region.cpu_addr && cpu_addr < (region.cpu_addr + region.size)) { | 160 | if (cpu_addr >= region.cpu_addr && cpu_addr < (region.cpu_addr + region.size)) { |
| 136 | u64 offset = cpu_addr - region.cpu_addr; | 161 | const u64 offset{cpu_addr - region.cpu_addr}; |
| 137 | results.push_back(region.gpu_addr + offset); | 162 | results.push_back(region.gpu_addr + offset); |
| 138 | } | 163 | } |
| 139 | } | 164 | } |
| 140 | return results; | 165 | return results; |
| 141 | } | 166 | } |
| 142 | 167 | ||
| 143 | bool MemoryManager::IsPageMapped(GPUVAddr gpu_addr) { | ||
| 144 | return PageSlot(gpu_addr) != static_cast<u64>(PageStatus::Unmapped); | ||
| 145 | } | ||
| 146 | |||
| 147 | VAddr& MemoryManager::PageSlot(GPUVAddr gpu_addr) { | 168 | VAddr& MemoryManager::PageSlot(GPUVAddr gpu_addr) { |
| 148 | auto& block = page_table[(gpu_addr >> (PAGE_BITS + PAGE_TABLE_BITS)) & PAGE_TABLE_MASK]; | 169 | auto& block{page_table[(gpu_addr >> (PAGE_BITS + PAGE_TABLE_BITS)) & PAGE_TABLE_MASK]}; |
| 149 | if (!block) { | 170 | if (!block) { |
| 150 | block = std::make_unique<PageBlock>(); | 171 | block = std::make_unique<PageBlock>(); |
| 151 | block->fill(static_cast<VAddr>(PageStatus::Unmapped)); | 172 | block->fill(static_cast<VAddr>(PageStatus::Unmapped)); |
diff --git a/src/video_core/memory_manager.h b/src/video_core/memory_manager.h index b1255fd56..4eb338aa2 100644 --- a/src/video_core/memory_manager.h +++ b/src/video_core/memory_manager.h | |||
| @@ -34,15 +34,15 @@ public: | |||
| 34 | static constexpr u64 PAGE_MASK = PAGE_SIZE - 1; | 34 | static constexpr u64 PAGE_MASK = PAGE_SIZE - 1; |
| 35 | 35 | ||
| 36 | private: | 36 | private: |
| 37 | std::optional<GPUVAddr> FindFreeBlock(u64 size, u64 align = 1); | ||
| 38 | bool IsPageMapped(GPUVAddr gpu_addr); | ||
| 39 | VAddr& PageSlot(GPUVAddr gpu_addr); | ||
| 40 | |||
| 41 | enum class PageStatus : u64 { | 37 | enum class PageStatus : u64 { |
| 42 | Unmapped = 0xFFFFFFFFFFFFFFFFULL, | 38 | Unmapped = 0xFFFFFFFFFFFFFFFFULL, |
| 43 | Allocated = 0xFFFFFFFFFFFFFFFEULL, | 39 | Allocated = 0xFFFFFFFFFFFFFFFEULL, |
| 44 | }; | 40 | }; |
| 45 | 41 | ||
| 42 | std::optional<GPUVAddr> FindFreeBlock(GPUVAddr region_start, u64 size, u64 align, | ||
| 43 | PageStatus status); | ||
| 44 | VAddr& PageSlot(GPUVAddr gpu_addr); | ||
| 45 | |||
| 46 | static constexpr u64 MAX_ADDRESS{0x10000000000ULL}; | 46 | static constexpr u64 MAX_ADDRESS{0x10000000000ULL}; |
| 47 | static constexpr u64 PAGE_TABLE_BITS{10}; | 47 | static constexpr u64 PAGE_TABLE_BITS{10}; |
| 48 | static constexpr u64 PAGE_TABLE_SIZE{1 << PAGE_TABLE_BITS}; | 48 | static constexpr u64 PAGE_TABLE_SIZE{1 << PAGE_TABLE_BITS}; |
diff --git a/src/video_core/rasterizer_cache.cpp b/src/video_core/rasterizer_cache.cpp new file mode 100644 index 000000000..093b2cdf4 --- /dev/null +++ b/src/video_core/rasterizer_cache.cpp | |||
| @@ -0,0 +1,7 @@ | |||
| 1 | // Copyright 2018 yuzu Emulator Project | ||
| 2 | // Licensed under GPLv2 or any later version | ||
| 3 | // Refer to the license.txt file included. | ||
| 4 | |||
| 5 | #include "video_core/rasterizer_cache.h" | ||
| 6 | |||
| 7 | RasterizerCacheObject::~RasterizerCacheObject() = default; | ||
diff --git a/src/video_core/rasterizer_cache.h b/src/video_core/rasterizer_cache.h index 0a3b3951e..6d41321fa 100644 --- a/src/video_core/rasterizer_cache.h +++ b/src/video_core/rasterizer_cache.h | |||
| @@ -10,13 +10,13 @@ | |||
| 10 | #include <boost/range/iterator_range_core.hpp> | 10 | #include <boost/range/iterator_range_core.hpp> |
| 11 | 11 | ||
| 12 | #include "common/common_types.h" | 12 | #include "common/common_types.h" |
| 13 | #include "core/core.h" | ||
| 14 | #include "core/settings.h" | 13 | #include "core/settings.h" |
| 15 | #include "video_core/rasterizer_interface.h" | 14 | #include "video_core/rasterizer_interface.h" |
| 16 | #include "video_core/renderer_base.h" | ||
| 17 | 15 | ||
| 18 | class RasterizerCacheObject { | 16 | class RasterizerCacheObject { |
| 19 | public: | 17 | public: |
| 18 | virtual ~RasterizerCacheObject(); | ||
| 19 | |||
| 20 | /// Gets the address of the shader in guest memory, required for cache management | 20 | /// Gets the address of the shader in guest memory, required for cache management |
| 21 | virtual VAddr GetAddr() const = 0; | 21 | virtual VAddr GetAddr() const = 0; |
| 22 | 22 | ||
| @@ -64,6 +64,8 @@ class RasterizerCache : NonCopyable { | |||
| 64 | friend class RasterizerCacheObject; | 64 | friend class RasterizerCacheObject; |
| 65 | 65 | ||
| 66 | public: | 66 | public: |
| 67 | explicit RasterizerCache(VideoCore::RasterizerInterface& rasterizer) : rasterizer{rasterizer} {} | ||
| 68 | |||
| 67 | /// Write any cached resources overlapping the specified region back to memory | 69 | /// Write any cached resources overlapping the specified region back to memory |
| 68 | void FlushRegion(Tegra::GPUVAddr addr, size_t size) { | 70 | void FlushRegion(Tegra::GPUVAddr addr, size_t size) { |
| 69 | const auto& objects{GetSortedObjectsFromRegion(addr, size)}; | 71 | const auto& objects{GetSortedObjectsFromRegion(addr, size)}; |
| @@ -109,14 +111,12 @@ protected: | |||
| 109 | void Register(const T& object) { | 111 | void Register(const T& object) { |
| 110 | object->SetIsRegistered(true); | 112 | object->SetIsRegistered(true); |
| 111 | object_cache.add({GetInterval(object), ObjectSet{object}}); | 113 | object_cache.add({GetInterval(object), ObjectSet{object}}); |
| 112 | auto& rasterizer = Core::System::GetInstance().Renderer().Rasterizer(); | ||
| 113 | rasterizer.UpdatePagesCachedCount(object->GetAddr(), object->GetSizeInBytes(), 1); | 114 | rasterizer.UpdatePagesCachedCount(object->GetAddr(), object->GetSizeInBytes(), 1); |
| 114 | } | 115 | } |
| 115 | 116 | ||
| 116 | /// Unregisters an object from the cache | 117 | /// Unregisters an object from the cache |
| 117 | void Unregister(const T& object) { | 118 | void Unregister(const T& object) { |
| 118 | object->SetIsRegistered(false); | 119 | object->SetIsRegistered(false); |
| 119 | auto& rasterizer = Core::System::GetInstance().Renderer().Rasterizer(); | ||
| 120 | rasterizer.UpdatePagesCachedCount(object->GetAddr(), object->GetSizeInBytes(), -1); | 120 | rasterizer.UpdatePagesCachedCount(object->GetAddr(), object->GetSizeInBytes(), -1); |
| 121 | 121 | ||
| 122 | // Only flush if use_accurate_gpu_emulation is enabled, as it incurs a performance hit | 122 | // Only flush if use_accurate_gpu_emulation is enabled, as it incurs a performance hit |
| @@ -177,4 +177,5 @@ private: | |||
| 177 | 177 | ||
| 178 | ObjectCache object_cache; ///< Cache of objects | 178 | ObjectCache object_cache; ///< Cache of objects |
| 179 | u64 modified_ticks{}; ///< Counter of cache state ticks, used for in-order flushing | 179 | u64 modified_ticks{}; ///< Counter of cache state ticks, used for in-order flushing |
| 180 | VideoCore::RasterizerInterface& rasterizer; | ||
| 180 | }; | 181 | }; |
diff --git a/src/video_core/renderer_opengl/gl_buffer_cache.cpp b/src/video_core/renderer_opengl/gl_buffer_cache.cpp index 41a54b3e7..075192c3f 100644 --- a/src/video_core/renderer_opengl/gl_buffer_cache.cpp +++ b/src/video_core/renderer_opengl/gl_buffer_cache.cpp | |||
| @@ -9,10 +9,12 @@ | |||
| 9 | #include "core/core.h" | 9 | #include "core/core.h" |
| 10 | #include "core/memory.h" | 10 | #include "core/memory.h" |
| 11 | #include "video_core/renderer_opengl/gl_buffer_cache.h" | 11 | #include "video_core/renderer_opengl/gl_buffer_cache.h" |
| 12 | #include "video_core/renderer_opengl/gl_rasterizer.h" | ||
| 12 | 13 | ||
| 13 | namespace OpenGL { | 14 | namespace OpenGL { |
| 14 | 15 | ||
| 15 | OGLBufferCache::OGLBufferCache(std::size_t size) : stream_buffer(GL_ARRAY_BUFFER, size) {} | 16 | OGLBufferCache::OGLBufferCache(RasterizerOpenGL& rasterizer, std::size_t size) |
| 17 | : RasterizerCache{rasterizer}, stream_buffer(GL_ARRAY_BUFFER, size) {} | ||
| 16 | 18 | ||
| 17 | GLintptr OGLBufferCache::UploadMemory(Tegra::GPUVAddr gpu_addr, std::size_t size, | 19 | GLintptr OGLBufferCache::UploadMemory(Tegra::GPUVAddr gpu_addr, std::size_t size, |
| 18 | std::size_t alignment, bool cache) { | 20 | std::size_t alignment, bool cache) { |
diff --git a/src/video_core/renderer_opengl/gl_buffer_cache.h b/src/video_core/renderer_opengl/gl_buffer_cache.h index be29dc8be..91fca3f6c 100644 --- a/src/video_core/renderer_opengl/gl_buffer_cache.h +++ b/src/video_core/renderer_opengl/gl_buffer_cache.h | |||
| @@ -15,6 +15,8 @@ | |||
| 15 | 15 | ||
| 16 | namespace OpenGL { | 16 | namespace OpenGL { |
| 17 | 17 | ||
| 18 | class RasterizerOpenGL; | ||
| 19 | |||
| 18 | struct CachedBufferEntry final : public RasterizerCacheObject { | 20 | struct CachedBufferEntry final : public RasterizerCacheObject { |
| 19 | VAddr GetAddr() const override { | 21 | VAddr GetAddr() const override { |
| 20 | return addr; | 22 | return addr; |
| @@ -35,7 +37,7 @@ struct CachedBufferEntry final : public RasterizerCacheObject { | |||
| 35 | 37 | ||
| 36 | class OGLBufferCache final : public RasterizerCache<std::shared_ptr<CachedBufferEntry>> { | 38 | class OGLBufferCache final : public RasterizerCache<std::shared_ptr<CachedBufferEntry>> { |
| 37 | public: | 39 | public: |
| 38 | explicit OGLBufferCache(std::size_t size); | 40 | explicit OGLBufferCache(RasterizerOpenGL& rasterizer, std::size_t size); |
| 39 | 41 | ||
| 40 | /// Uploads data from a guest GPU address. Returns host's buffer offset where it's been | 42 | /// Uploads data from a guest GPU address. Returns host's buffer offset where it's been |
| 41 | /// allocated. | 43 | /// allocated. |
diff --git a/src/video_core/renderer_opengl/gl_primitive_assembler.cpp b/src/video_core/renderer_opengl/gl_primitive_assembler.cpp index 741f14bc3..d9ed08437 100644 --- a/src/video_core/renderer_opengl/gl_primitive_assembler.cpp +++ b/src/video_core/renderer_opengl/gl_primitive_assembler.cpp | |||
| @@ -6,6 +6,7 @@ | |||
| 6 | #include <array> | 6 | #include <array> |
| 7 | #include "common/assert.h" | 7 | #include "common/assert.h" |
| 8 | #include "common/common_types.h" | 8 | #include "common/common_types.h" |
| 9 | #include "core/core.h" | ||
| 9 | #include "core/memory.h" | 10 | #include "core/memory.h" |
| 10 | #include "video_core/renderer_opengl/gl_buffer_cache.h" | 11 | #include "video_core/renderer_opengl/gl_buffer_cache.h" |
| 11 | #include "video_core/renderer_opengl/gl_primitive_assembler.h" | 12 | #include "video_core/renderer_opengl/gl_primitive_assembler.h" |
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.cpp b/src/video_core/renderer_opengl/gl_rasterizer.cpp index a0527fe57..a99f2b1f9 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.cpp +++ b/src/video_core/renderer_opengl/gl_rasterizer.cpp | |||
| @@ -33,7 +33,8 @@ using Maxwell = Tegra::Engines::Maxwell3D::Regs; | |||
| 33 | using PixelFormat = VideoCore::Surface::PixelFormat; | 33 | using PixelFormat = VideoCore::Surface::PixelFormat; |
| 34 | using SurfaceType = VideoCore::Surface::SurfaceType; | 34 | using SurfaceType = VideoCore::Surface::SurfaceType; |
| 35 | 35 | ||
| 36 | MICROPROFILE_DEFINE(OpenGL_VAO, "OpenGL", "Vertex Array Setup", MP_RGB(128, 128, 192)); | 36 | MICROPROFILE_DEFINE(OpenGL_VAO, "OpenGL", "Vertex Format Setup", MP_RGB(128, 128, 192)); |
| 37 | MICROPROFILE_DEFINE(OpenGL_VB, "OpenGL", "Vertex Buffer Setup", MP_RGB(128, 128, 192)); | ||
| 37 | MICROPROFILE_DEFINE(OpenGL_Shader, "OpenGL", "Shader Setup", MP_RGB(128, 128, 192)); | 38 | MICROPROFILE_DEFINE(OpenGL_Shader, "OpenGL", "Shader Setup", MP_RGB(128, 128, 192)); |
| 38 | MICROPROFILE_DEFINE(OpenGL_UBO, "OpenGL", "Const Buffer Setup", MP_RGB(128, 128, 192)); | 39 | MICROPROFILE_DEFINE(OpenGL_UBO, "OpenGL", "Const Buffer Setup", MP_RGB(128, 128, 192)); |
| 39 | MICROPROFILE_DEFINE(OpenGL_Index, "OpenGL", "Index Buffer Setup", MP_RGB(128, 128, 192)); | 40 | MICROPROFILE_DEFINE(OpenGL_Index, "OpenGL", "Index Buffer Setup", MP_RGB(128, 128, 192)); |
| @@ -79,7 +80,8 @@ struct DrawParameters { | |||
| 79 | }; | 80 | }; |
| 80 | 81 | ||
| 81 | RasterizerOpenGL::RasterizerOpenGL(Core::Frontend::EmuWindow& window, ScreenInfo& info) | 82 | RasterizerOpenGL::RasterizerOpenGL(Core::Frontend::EmuWindow& window, ScreenInfo& info) |
| 82 | : emu_window{window}, screen_info{info}, buffer_cache(STREAM_BUFFER_SIZE) { | 83 | : res_cache{*this}, shader_cache{*this}, emu_window{window}, screen_info{info}, |
| 84 | buffer_cache(*this, STREAM_BUFFER_SIZE) { | ||
| 83 | // Create sampler objects | 85 | // Create sampler objects |
| 84 | for (std::size_t i = 0; i < texture_samplers.size(); ++i) { | 86 | for (std::size_t i = 0; i < texture_samplers.size(); ++i) { |
| 85 | texture_samplers[i].Create(); | 87 | texture_samplers[i].Create(); |
| @@ -122,11 +124,16 @@ RasterizerOpenGL::RasterizerOpenGL(Core::Frontend::EmuWindow& window, ScreenInfo | |||
| 122 | 124 | ||
| 123 | RasterizerOpenGL::~RasterizerOpenGL() {} | 125 | RasterizerOpenGL::~RasterizerOpenGL() {} |
| 124 | 126 | ||
| 125 | void RasterizerOpenGL::SetupVertexArrays() { | 127 | void RasterizerOpenGL::SetupVertexFormat() { |
| 126 | MICROPROFILE_SCOPE(OpenGL_VAO); | 128 | auto& gpu = Core::System::GetInstance().GPU().Maxwell3D(); |
| 127 | const auto& gpu = Core::System::GetInstance().GPU().Maxwell3D(); | ||
| 128 | const auto& regs = gpu.regs; | 129 | const auto& regs = gpu.regs; |
| 129 | 130 | ||
| 131 | if (!gpu.dirty_flags.vertex_attrib_format) | ||
| 132 | return; | ||
| 133 | gpu.dirty_flags.vertex_attrib_format = false; | ||
| 134 | |||
| 135 | MICROPROFILE_SCOPE(OpenGL_VAO); | ||
| 136 | |||
| 130 | auto [iter, is_cache_miss] = vertex_array_cache.try_emplace(regs.vertex_attrib_format); | 137 | auto [iter, is_cache_miss] = vertex_array_cache.try_emplace(regs.vertex_attrib_format); |
| 131 | auto& VAO = iter->second; | 138 | auto& VAO = iter->second; |
| 132 | 139 | ||
| @@ -175,8 +182,13 @@ void RasterizerOpenGL::SetupVertexArrays() { | |||
| 175 | } | 182 | } |
| 176 | } | 183 | } |
| 177 | state.draw.vertex_array = VAO.handle; | 184 | state.draw.vertex_array = VAO.handle; |
| 178 | state.draw.vertex_buffer = buffer_cache.GetHandle(); | ||
| 179 | state.Apply(); | 185 | state.Apply(); |
| 186 | } | ||
| 187 | |||
| 188 | void RasterizerOpenGL::SetupVertexBuffer() { | ||
| 189 | MICROPROFILE_SCOPE(OpenGL_VB); | ||
| 190 | const auto& gpu = Core::System::GetInstance().GPU().Maxwell3D(); | ||
| 191 | const auto& regs = gpu.regs; | ||
| 180 | 192 | ||
| 181 | // Upload all guest vertex arrays sequentially to our buffer | 193 | // Upload all guest vertex arrays sequentially to our buffer |
| 182 | for (u32 index = 0; index < Maxwell::NumVertexArrays; ++index) { | 194 | for (u32 index = 0; index < Maxwell::NumVertexArrays; ++index) { |
| @@ -203,6 +215,9 @@ void RasterizerOpenGL::SetupVertexArrays() { | |||
| 203 | glVertexBindingDivisor(index, 0); | 215 | glVertexBindingDivisor(index, 0); |
| 204 | } | 216 | } |
| 205 | } | 217 | } |
| 218 | |||
| 219 | // Implicit set by glBindVertexBuffer. Stupid glstate handling... | ||
| 220 | state.draw.vertex_buffer = buffer_cache.GetHandle(); | ||
| 206 | } | 221 | } |
| 207 | 222 | ||
| 208 | DrawParameters RasterizerOpenGL::SetupDraw() { | 223 | DrawParameters RasterizerOpenGL::SetupDraw() { |
| @@ -511,10 +526,10 @@ void RasterizerOpenGL::Clear() { | |||
| 511 | 526 | ||
| 512 | OpenGLState clear_state; | 527 | OpenGLState clear_state; |
| 513 | clear_state.draw.draw_framebuffer = framebuffer.handle; | 528 | clear_state.draw.draw_framebuffer = framebuffer.handle; |
| 514 | clear_state.color_mask.red_enabled = regs.clear_buffers.R ? GL_TRUE : GL_FALSE; | 529 | clear_state.color_mask[0].red_enabled = regs.clear_buffers.R ? GL_TRUE : GL_FALSE; |
| 515 | clear_state.color_mask.green_enabled = regs.clear_buffers.G ? GL_TRUE : GL_FALSE; | 530 | clear_state.color_mask[0].green_enabled = regs.clear_buffers.G ? GL_TRUE : GL_FALSE; |
| 516 | clear_state.color_mask.blue_enabled = regs.clear_buffers.B ? GL_TRUE : GL_FALSE; | 531 | clear_state.color_mask[0].blue_enabled = regs.clear_buffers.B ? GL_TRUE : GL_FALSE; |
| 517 | clear_state.color_mask.alpha_enabled = regs.clear_buffers.A ? GL_TRUE : GL_FALSE; | 532 | clear_state.color_mask[0].alpha_enabled = regs.clear_buffers.A ? GL_TRUE : GL_FALSE; |
| 518 | 533 | ||
| 519 | if (regs.clear_buffers.R || regs.clear_buffers.G || regs.clear_buffers.B || | 534 | if (regs.clear_buffers.R || regs.clear_buffers.G || regs.clear_buffers.B || |
| 520 | regs.clear_buffers.A) { | 535 | regs.clear_buffers.A) { |
| @@ -573,14 +588,13 @@ void RasterizerOpenGL::DrawArrays() { | |||
| 573 | ScopeAcquireGLContext acquire_context{emu_window}; | 588 | ScopeAcquireGLContext acquire_context{emu_window}; |
| 574 | 589 | ||
| 575 | ConfigureFramebuffers(); | 590 | ConfigureFramebuffers(); |
| 576 | 591 | SyncColorMask(); | |
| 577 | SyncDepthTestState(); | 592 | SyncDepthTestState(); |
| 578 | SyncStencilTestState(); | 593 | SyncStencilTestState(); |
| 579 | SyncBlendState(); | 594 | SyncBlendState(); |
| 580 | SyncLogicOpState(); | 595 | SyncLogicOpState(); |
| 581 | SyncCullMode(); | 596 | SyncCullMode(); |
| 582 | SyncPrimitiveRestart(); | 597 | SyncPrimitiveRestart(); |
| 583 | SyncDepthRange(); | ||
| 584 | SyncScissorTest(); | 598 | SyncScissorTest(); |
| 585 | // Alpha Testing is synced on shaders. | 599 | // Alpha Testing is synced on shaders. |
| 586 | SyncTransformFeedback(); | 600 | SyncTransformFeedback(); |
| @@ -621,7 +635,8 @@ void RasterizerOpenGL::DrawArrays() { | |||
| 621 | 635 | ||
| 622 | buffer_cache.Map(buffer_size); | 636 | buffer_cache.Map(buffer_size); |
| 623 | 637 | ||
| 624 | SetupVertexArrays(); | 638 | SetupVertexFormat(); |
| 639 | SetupVertexBuffer(); | ||
| 625 | DrawParameters params = SetupDraw(); | 640 | DrawParameters params = SetupDraw(); |
| 626 | SetupShaders(params.primitive_mode); | 641 | SetupShaders(params.primitive_mode); |
| 627 | 642 | ||
| @@ -899,12 +914,16 @@ u32 RasterizerOpenGL::SetupTextures(Maxwell::ShaderStage stage, Shader& shader, | |||
| 899 | 914 | ||
| 900 | void RasterizerOpenGL::SyncViewport() { | 915 | void RasterizerOpenGL::SyncViewport() { |
| 901 | const auto& regs = Core::System::GetInstance().GPU().Maxwell3D().regs; | 916 | const auto& regs = Core::System::GetInstance().GPU().Maxwell3D().regs; |
| 902 | const MathUtil::Rectangle<s32> viewport_rect{regs.viewport_transform[0].GetRect()}; | 917 | for (size_t i = 0; i < Tegra::Engines::Maxwell3D::Regs::NumRenderTargets; i++) { |
| 903 | 918 | const MathUtil::Rectangle<s32> viewport_rect{regs.viewport_transform[i].GetRect()}; | |
| 904 | state.viewport.x = viewport_rect.left; | 919 | auto& viewport = state.viewports[i]; |
| 905 | state.viewport.y = viewport_rect.bottom; | 920 | viewport.x = viewport_rect.left; |
| 906 | state.viewport.width = static_cast<GLsizei>(viewport_rect.GetWidth()); | 921 | viewport.y = viewport_rect.bottom; |
| 907 | state.viewport.height = static_cast<GLsizei>(viewport_rect.GetHeight()); | 922 | viewport.width = static_cast<GLfloat>(viewport_rect.GetWidth()); |
| 923 | viewport.height = static_cast<GLfloat>(viewport_rect.GetHeight()); | ||
| 924 | viewport.depth_range_far = regs.viewport[i].depth_range_far; | ||
| 925 | viewport.depth_range_near = regs.viewport[i].depth_range_near; | ||
| 926 | } | ||
| 908 | } | 927 | } |
| 909 | 928 | ||
| 910 | void RasterizerOpenGL::SyncClipEnabled() { | 929 | void RasterizerOpenGL::SyncClipEnabled() { |
| @@ -946,13 +965,6 @@ void RasterizerOpenGL::SyncPrimitiveRestart() { | |||
| 946 | state.primitive_restart.index = regs.primitive_restart.index; | 965 | state.primitive_restart.index = regs.primitive_restart.index; |
| 947 | } | 966 | } |
| 948 | 967 | ||
| 949 | void RasterizerOpenGL::SyncDepthRange() { | ||
| 950 | const auto& regs = Core::System::GetInstance().GPU().Maxwell3D().regs; | ||
| 951 | |||
| 952 | state.depth.depth_range_near = regs.viewport->depth_range_near; | ||
| 953 | state.depth.depth_range_far = regs.viewport->depth_range_far; | ||
| 954 | } | ||
| 955 | |||
| 956 | void RasterizerOpenGL::SyncDepthTestState() { | 968 | void RasterizerOpenGL::SyncDepthTestState() { |
| 957 | const auto& regs = Core::System::GetInstance().GPU().Maxwell3D().regs; | 969 | const auto& regs = Core::System::GetInstance().GPU().Maxwell3D().regs; |
| 958 | 970 | ||
| @@ -993,26 +1005,60 @@ void RasterizerOpenGL::SyncStencilTestState() { | |||
| 993 | state.stencil.back.write_mask = regs.stencil_back_mask; | 1005 | state.stencil.back.write_mask = regs.stencil_back_mask; |
| 994 | } | 1006 | } |
| 995 | 1007 | ||
| 996 | void RasterizerOpenGL::SyncBlendState() { | 1008 | void RasterizerOpenGL::SyncColorMask() { |
| 997 | const auto& regs = Core::System::GetInstance().GPU().Maxwell3D().regs; | 1009 | const auto& regs = Core::System::GetInstance().GPU().Maxwell3D().regs; |
| 1010 | for (size_t i = 0; i < Tegra::Engines::Maxwell3D::Regs::NumRenderTargets; i++) { | ||
| 1011 | const auto& source = regs.color_mask[regs.color_mask_common ? 0 : i]; | ||
| 1012 | auto& dest = state.color_mask[i]; | ||
| 1013 | dest.red_enabled = (source.R == 0) ? GL_FALSE : GL_TRUE; | ||
| 1014 | dest.green_enabled = (source.G == 0) ? GL_FALSE : GL_TRUE; | ||
| 1015 | dest.blue_enabled = (source.B == 0) ? GL_FALSE : GL_TRUE; | ||
| 1016 | dest.alpha_enabled = (source.A == 0) ? GL_FALSE : GL_TRUE; | ||
| 1017 | } | ||
| 1018 | } | ||
| 998 | 1019 | ||
| 999 | // TODO(Subv): Support more than just render target 0. | 1020 | void RasterizerOpenGL::SyncBlendState() { |
| 1000 | state.blend.enabled = regs.blend.enable[0] != 0; | 1021 | const auto& regs = Core::System::GetInstance().GPU().Maxwell3D().regs; |
| 1001 | 1022 | ||
| 1002 | if (!state.blend.enabled) | 1023 | state.blend_color.red = regs.blend_color.r; |
| 1024 | state.blend_color.green = regs.blend_color.g; | ||
| 1025 | state.blend_color.blue = regs.blend_color.b; | ||
| 1026 | state.blend_color.alpha = regs.blend_color.a; | ||
| 1027 | |||
| 1028 | state.independant_blend.enabled = regs.independent_blend_enable; | ||
| 1029 | if (!state.independant_blend.enabled) { | ||
| 1030 | auto& blend = state.blend[0]; | ||
| 1031 | blend.enabled = regs.blend.enable[0] != 0; | ||
| 1032 | blend.separate_alpha = regs.blend.separate_alpha; | ||
| 1033 | blend.rgb_equation = MaxwellToGL::BlendEquation(regs.blend.equation_rgb); | ||
| 1034 | blend.src_rgb_func = MaxwellToGL::BlendFunc(regs.blend.factor_source_rgb); | ||
| 1035 | blend.dst_rgb_func = MaxwellToGL::BlendFunc(regs.blend.factor_dest_rgb); | ||
| 1036 | if (blend.separate_alpha) { | ||
| 1037 | blend.a_equation = MaxwellToGL::BlendEquation(regs.blend.equation_a); | ||
| 1038 | blend.src_a_func = MaxwellToGL::BlendFunc(regs.blend.factor_source_a); | ||
| 1039 | blend.dst_a_func = MaxwellToGL::BlendFunc(regs.blend.factor_dest_a); | ||
| 1040 | } | ||
| 1041 | for (size_t i = 1; i < Tegra::Engines::Maxwell3D::Regs::NumRenderTargets; i++) { | ||
| 1042 | state.blend[i].enabled = false; | ||
| 1043 | } | ||
| 1003 | return; | 1044 | return; |
| 1045 | } | ||
| 1004 | 1046 | ||
| 1005 | ASSERT_MSG(regs.logic_op.enable == 0, | 1047 | for (size_t i = 0; i < Tegra::Engines::Maxwell3D::Regs::NumRenderTargets; i++) { |
| 1006 | "Blending and logic op can't be enabled at the same time."); | 1048 | auto& blend = state.blend[i]; |
| 1007 | 1049 | blend.enabled = regs.blend.enable[i] != 0; | |
| 1008 | ASSERT_MSG(regs.independent_blend_enable == 1, "Only independent blending is implemented"); | 1050 | if (!blend.enabled) |
| 1009 | ASSERT_MSG(!regs.independent_blend[0].separate_alpha, "Unimplemented"); | 1051 | continue; |
| 1010 | state.blend.rgb_equation = MaxwellToGL::BlendEquation(regs.independent_blend[0].equation_rgb); | 1052 | blend.separate_alpha = regs.independent_blend[i].separate_alpha; |
| 1011 | state.blend.src_rgb_func = MaxwellToGL::BlendFunc(regs.independent_blend[0].factor_source_rgb); | 1053 | blend.rgb_equation = MaxwellToGL::BlendEquation(regs.independent_blend[i].equation_rgb); |
| 1012 | state.blend.dst_rgb_func = MaxwellToGL::BlendFunc(regs.independent_blend[0].factor_dest_rgb); | 1054 | blend.src_rgb_func = MaxwellToGL::BlendFunc(regs.independent_blend[i].factor_source_rgb); |
| 1013 | state.blend.a_equation = MaxwellToGL::BlendEquation(regs.independent_blend[0].equation_a); | 1055 | blend.dst_rgb_func = MaxwellToGL::BlendFunc(regs.independent_blend[i].factor_dest_rgb); |
| 1014 | state.blend.src_a_func = MaxwellToGL::BlendFunc(regs.independent_blend[0].factor_source_a); | 1056 | if (blend.separate_alpha) { |
| 1015 | state.blend.dst_a_func = MaxwellToGL::BlendFunc(regs.independent_blend[0].factor_dest_a); | 1057 | blend.a_equation = MaxwellToGL::BlendEquation(regs.independent_blend[i].equation_a); |
| 1058 | blend.src_a_func = MaxwellToGL::BlendFunc(regs.independent_blend[i].factor_source_a); | ||
| 1059 | blend.dst_a_func = MaxwellToGL::BlendFunc(regs.independent_blend[i].factor_dest_a); | ||
| 1060 | } | ||
| 1061 | } | ||
| 1016 | } | 1062 | } |
| 1017 | 1063 | ||
| 1018 | void RasterizerOpenGL::SyncLogicOpState() { | 1064 | void RasterizerOpenGL::SyncLogicOpState() { |
| @@ -1031,19 +1077,19 @@ void RasterizerOpenGL::SyncLogicOpState() { | |||
| 1031 | } | 1077 | } |
| 1032 | 1078 | ||
| 1033 | void RasterizerOpenGL::SyncScissorTest() { | 1079 | void RasterizerOpenGL::SyncScissorTest() { |
| 1080 | // TODO: what is the correct behavior here, a single scissor for all targets | ||
| 1081 | // or scissor disabled for the rest of the targets? | ||
| 1034 | const auto& regs = Core::System::GetInstance().GPU().Maxwell3D().regs; | 1082 | const auto& regs = Core::System::GetInstance().GPU().Maxwell3D().regs; |
| 1035 | |||
| 1036 | state.scissor.enabled = (regs.scissor_test.enable != 0); | 1083 | state.scissor.enabled = (regs.scissor_test.enable != 0); |
| 1037 | // TODO(Blinkhawk): Figure if the hardware supports scissor testing per viewport and how it's | 1084 | if (regs.scissor_test.enable == 0) { |
| 1038 | // implemented. | 1085 | return; |
| 1039 | if (regs.scissor_test.enable != 0) { | ||
| 1040 | const u32 width = regs.scissor_test.max_x - regs.scissor_test.min_x; | ||
| 1041 | const u32 height = regs.scissor_test.max_y - regs.scissor_test.min_y; | ||
| 1042 | state.scissor.x = regs.scissor_test.min_x; | ||
| 1043 | state.scissor.y = regs.scissor_test.min_y; | ||
| 1044 | state.scissor.width = width; | ||
| 1045 | state.scissor.height = height; | ||
| 1046 | } | 1086 | } |
| 1087 | const u32 width = regs.scissor_test.max_x - regs.scissor_test.min_x; | ||
| 1088 | const u32 height = regs.scissor_test.max_y - regs.scissor_test.min_y; | ||
| 1089 | state.scissor.x = regs.scissor_test.min_x; | ||
| 1090 | state.scissor.y = regs.scissor_test.min_y; | ||
| 1091 | state.scissor.width = width; | ||
| 1092 | state.scissor.height = height; | ||
| 1047 | } | 1093 | } |
| 1048 | 1094 | ||
| 1049 | void RasterizerOpenGL::SyncTransformFeedback() { | 1095 | void RasterizerOpenGL::SyncTransformFeedback() { |
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.h b/src/video_core/renderer_opengl/gl_rasterizer.h index 47097c569..5eee5f088 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.h +++ b/src/video_core/renderer_opengl/gl_rasterizer.h | |||
| @@ -133,7 +133,7 @@ private: | |||
| 133 | u32 SetupTextures(Tegra::Engines::Maxwell3D::Regs::ShaderStage stage, Shader& shader, | 133 | u32 SetupTextures(Tegra::Engines::Maxwell3D::Regs::ShaderStage stage, Shader& shader, |
| 134 | GLenum primitive_mode, u32 current_unit); | 134 | GLenum primitive_mode, u32 current_unit); |
| 135 | 135 | ||
| 136 | /// Syncs the viewport to match the guest state | 136 | /// Syncs the viewport and depth range to match the guest state |
| 137 | void SyncViewport(); | 137 | void SyncViewport(); |
| 138 | 138 | ||
| 139 | /// Syncs the clip enabled status to match the guest state | 139 | /// Syncs the clip enabled status to match the guest state |
| @@ -148,9 +148,6 @@ private: | |||
| 148 | /// Syncs the primitve restart to match the guest state | 148 | /// Syncs the primitve restart to match the guest state |
| 149 | void SyncPrimitiveRestart(); | 149 | void SyncPrimitiveRestart(); |
| 150 | 150 | ||
| 151 | /// Syncs the depth range to match the guest state | ||
| 152 | void SyncDepthRange(); | ||
| 153 | |||
| 154 | /// Syncs the depth test state to match the guest state | 151 | /// Syncs the depth test state to match the guest state |
| 155 | void SyncDepthTestState(); | 152 | void SyncDepthTestState(); |
| 156 | 153 | ||
| @@ -172,6 +169,9 @@ private: | |||
| 172 | /// Syncs the point state to match the guest state | 169 | /// Syncs the point state to match the guest state |
| 173 | void SyncPointState(); | 170 | void SyncPointState(); |
| 174 | 171 | ||
| 172 | /// Syncs Color Mask | ||
| 173 | void SyncColorMask(); | ||
| 174 | |||
| 175 | /// Check asserts for alpha testing. | 175 | /// Check asserts for alpha testing. |
| 176 | void CheckAlphaTests(); | 176 | void CheckAlphaTests(); |
| 177 | 177 | ||
| @@ -207,7 +207,8 @@ private: | |||
| 207 | 207 | ||
| 208 | std::size_t CalculateIndexBufferSize() const; | 208 | std::size_t CalculateIndexBufferSize() const; |
| 209 | 209 | ||
| 210 | void SetupVertexArrays(); | 210 | void SetupVertexFormat(); |
| 211 | void SetupVertexBuffer(); | ||
| 211 | 212 | ||
| 212 | DrawParameters SetupDraw(); | 213 | DrawParameters SetupDraw(); |
| 213 | 214 | ||
diff --git a/src/video_core/renderer_opengl/gl_rasterizer_cache.cpp b/src/video_core/renderer_opengl/gl_rasterizer_cache.cpp index dcbf009c0..c8864cce8 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer_cache.cpp +++ b/src/video_core/renderer_opengl/gl_rasterizer_cache.cpp | |||
| @@ -15,7 +15,9 @@ | |||
| 15 | #include "core/memory.h" | 15 | #include "core/memory.h" |
| 16 | #include "core/settings.h" | 16 | #include "core/settings.h" |
| 17 | #include "video_core/engines/maxwell_3d.h" | 17 | #include "video_core/engines/maxwell_3d.h" |
| 18 | #include "video_core/renderer_opengl/gl_rasterizer.h" | ||
| 18 | #include "video_core/renderer_opengl/gl_rasterizer_cache.h" | 19 | #include "video_core/renderer_opengl/gl_rasterizer_cache.h" |
| 20 | #include "video_core/renderer_opengl/gl_state.h" | ||
| 19 | #include "video_core/renderer_opengl/utils.h" | 21 | #include "video_core/renderer_opengl/utils.h" |
| 20 | #include "video_core/surface.h" | 22 | #include "video_core/surface.h" |
| 21 | #include "video_core/textures/astc.h" | 23 | #include "video_core/textures/astc.h" |
| @@ -561,9 +563,11 @@ void SwizzleFunc(const GLConversionArray& functions, const SurfaceParams& params | |||
| 561 | } | 563 | } |
| 562 | } | 564 | } |
| 563 | 565 | ||
| 566 | MICROPROFILE_DEFINE(OpenGL_BlitSurface, "OpenGL", "BlitSurface", MP_RGB(128, 192, 64)); | ||
| 564 | static bool BlitSurface(const Surface& src_surface, const Surface& dst_surface, | 567 | static bool BlitSurface(const Surface& src_surface, const Surface& dst_surface, |
| 565 | GLuint read_fb_handle, GLuint draw_fb_handle, GLenum src_attachment = 0, | 568 | GLuint read_fb_handle, GLuint draw_fb_handle, GLenum src_attachment = 0, |
| 566 | GLenum dst_attachment = 0, std::size_t cubemap_face = 0) { | 569 | GLenum dst_attachment = 0, std::size_t cubemap_face = 0) { |
| 570 | MICROPROFILE_SCOPE(OpenGL_BlitSurface); | ||
| 567 | 571 | ||
| 568 | const auto& src_params{src_surface->GetSurfaceParams()}; | 572 | const auto& src_params{src_surface->GetSurfaceParams()}; |
| 569 | const auto& dst_params{dst_surface->GetSurfaceParams()}; | 573 | const auto& dst_params{dst_surface->GetSurfaceParams()}; |
| @@ -703,9 +707,11 @@ static void FastCopySurface(const Surface& src_surface, const Surface& dst_surfa | |||
| 703 | 0, 0, width, height, 1); | 707 | 0, 0, width, height, 1); |
| 704 | } | 708 | } |
| 705 | 709 | ||
| 710 | MICROPROFILE_DEFINE(OpenGL_CopySurface, "OpenGL", "CopySurface", MP_RGB(128, 192, 64)); | ||
| 706 | static void CopySurface(const Surface& src_surface, const Surface& dst_surface, | 711 | static void CopySurface(const Surface& src_surface, const Surface& dst_surface, |
| 707 | GLuint copy_pbo_handle, GLenum src_attachment = 0, | 712 | GLuint copy_pbo_handle, GLenum src_attachment = 0, |
| 708 | GLenum dst_attachment = 0, std::size_t cubemap_face = 0) { | 713 | GLenum dst_attachment = 0, std::size_t cubemap_face = 0) { |
| 714 | MICROPROFILE_SCOPE(OpenGL_CopySurface); | ||
| 709 | ASSERT_MSG(dst_attachment == 0, "Unimplemented"); | 715 | ASSERT_MSG(dst_attachment == 0, "Unimplemented"); |
| 710 | 716 | ||
| 711 | const auto& src_params{src_surface->GetSurfaceParams()}; | 717 | const auto& src_params{src_surface->GetSurfaceParams()}; |
| @@ -974,7 +980,7 @@ static void ConvertFormatAsNeeded_FlushGLBuffer(std::vector<u8>& data, PixelForm | |||
| 974 | } | 980 | } |
| 975 | } | 981 | } |
| 976 | 982 | ||
| 977 | MICROPROFILE_DEFINE(OpenGL_SurfaceLoad, "OpenGL", "Surface Load", MP_RGB(128, 64, 192)); | 983 | MICROPROFILE_DEFINE(OpenGL_SurfaceLoad, "OpenGL", "Surface Load", MP_RGB(128, 192, 64)); |
| 978 | void CachedSurface::LoadGLBuffer() { | 984 | void CachedSurface::LoadGLBuffer() { |
| 979 | MICROPROFILE_SCOPE(OpenGL_SurfaceLoad); | 985 | MICROPROFILE_SCOPE(OpenGL_SurfaceLoad); |
| 980 | gl_buffer.resize(params.max_mip_level); | 986 | gl_buffer.resize(params.max_mip_level); |
| @@ -1156,7 +1162,7 @@ void CachedSurface::UploadGLMipmapTexture(u32 mip_map, GLuint read_fb_handle, | |||
| 1156 | glPixelStorei(GL_UNPACK_ROW_LENGTH, 0); | 1162 | glPixelStorei(GL_UNPACK_ROW_LENGTH, 0); |
| 1157 | } | 1163 | } |
| 1158 | 1164 | ||
| 1159 | MICROPROFILE_DEFINE(OpenGL_TextureUL, "OpenGL", "Texture Upload", MP_RGB(128, 64, 192)); | 1165 | MICROPROFILE_DEFINE(OpenGL_TextureUL, "OpenGL", "Texture Upload", MP_RGB(128, 192, 64)); |
| 1160 | void CachedSurface::UploadGLTexture(GLuint read_fb_handle, GLuint draw_fb_handle) { | 1166 | void CachedSurface::UploadGLTexture(GLuint read_fb_handle, GLuint draw_fb_handle) { |
| 1161 | if (params.type == SurfaceType::Fill) | 1167 | if (params.type == SurfaceType::Fill) |
| 1162 | return; | 1168 | return; |
| @@ -1167,7 +1173,8 @@ void CachedSurface::UploadGLTexture(GLuint read_fb_handle, GLuint draw_fb_handle | |||
| 1167 | UploadGLMipmapTexture(i, read_fb_handle, draw_fb_handle); | 1173 | UploadGLMipmapTexture(i, read_fb_handle, draw_fb_handle); |
| 1168 | } | 1174 | } |
| 1169 | 1175 | ||
| 1170 | RasterizerCacheOpenGL::RasterizerCacheOpenGL() { | 1176 | RasterizerCacheOpenGL::RasterizerCacheOpenGL(RasterizerOpenGL& rasterizer) |
| 1177 | : RasterizerCache{rasterizer} { | ||
| 1171 | read_framebuffer.Create(); | 1178 | read_framebuffer.Create(); |
| 1172 | draw_framebuffer.Create(); | 1179 | draw_framebuffer.Create(); |
| 1173 | copy_pbo.Create(); | 1180 | copy_pbo.Create(); |
diff --git a/src/video_core/renderer_opengl/gl_rasterizer_cache.h b/src/video_core/renderer_opengl/gl_rasterizer_cache.h index c0b6bc4e6..494f6b903 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer_cache.h +++ b/src/video_core/renderer_opengl/gl_rasterizer_cache.h | |||
| @@ -264,6 +264,8 @@ struct hash<SurfaceReserveKey> { | |||
| 264 | 264 | ||
| 265 | namespace OpenGL { | 265 | namespace OpenGL { |
| 266 | 266 | ||
| 267 | class RasterizerOpenGL; | ||
| 268 | |||
| 267 | class CachedSurface final : public RasterizerCacheObject { | 269 | class CachedSurface final : public RasterizerCacheObject { |
| 268 | public: | 270 | public: |
| 269 | CachedSurface(const SurfaceParams& params); | 271 | CachedSurface(const SurfaceParams& params); |
| @@ -311,7 +313,7 @@ private: | |||
| 311 | 313 | ||
| 312 | class RasterizerCacheOpenGL final : public RasterizerCache<Surface> { | 314 | class RasterizerCacheOpenGL final : public RasterizerCache<Surface> { |
| 313 | public: | 315 | public: |
| 314 | RasterizerCacheOpenGL(); | 316 | explicit RasterizerCacheOpenGL(RasterizerOpenGL& rasterizer); |
| 315 | 317 | ||
| 316 | /// Get a surface based on the texture configuration | 318 | /// Get a surface based on the texture configuration |
| 317 | Surface GetTextureSurface(const Tegra::Texture::FullTextureInfo& config, | 319 | Surface GetTextureSurface(const Tegra::Texture::FullTextureInfo& config, |
diff --git a/src/video_core/renderer_opengl/gl_resource_manager.cpp b/src/video_core/renderer_opengl/gl_resource_manager.cpp new file mode 100644 index 000000000..c17d5ac00 --- /dev/null +++ b/src/video_core/renderer_opengl/gl_resource_manager.cpp | |||
| @@ -0,0 +1,186 @@ | |||
| 1 | // Copyright 2015 Citra Emulator Project | ||
| 2 | // Licensed under GPLv2 or any later version | ||
| 3 | // Refer to the license.txt file included. | ||
| 4 | |||
| 5 | #include <utility> | ||
| 6 | #include <glad/glad.h> | ||
| 7 | #include "common/common_types.h" | ||
| 8 | #include "common/microprofile.h" | ||
| 9 | #include "video_core/renderer_opengl/gl_resource_manager.h" | ||
| 10 | #include "video_core/renderer_opengl/gl_shader_util.h" | ||
| 11 | #include "video_core/renderer_opengl/gl_state.h" | ||
| 12 | |||
| 13 | MICROPROFILE_DEFINE(OpenGL_ResourceCreation, "OpenGL", "Resource Creation", MP_RGB(128, 128, 192)); | ||
| 14 | MICROPROFILE_DEFINE(OpenGL_ResourceDeletion, "OpenGL", "Resource Deletion", MP_RGB(128, 128, 192)); | ||
| 15 | |||
| 16 | namespace OpenGL { | ||
| 17 | |||
| 18 | void OGLTexture::Create() { | ||
| 19 | if (handle != 0) | ||
| 20 | return; | ||
| 21 | |||
| 22 | MICROPROFILE_SCOPE(OpenGL_ResourceCreation); | ||
| 23 | glGenTextures(1, &handle); | ||
| 24 | } | ||
| 25 | |||
| 26 | void OGLTexture::Release() { | ||
| 27 | if (handle == 0) | ||
| 28 | return; | ||
| 29 | |||
| 30 | MICROPROFILE_SCOPE(OpenGL_ResourceDeletion); | ||
| 31 | glDeleteTextures(1, &handle); | ||
| 32 | OpenGLState::GetCurState().UnbindTexture(handle).Apply(); | ||
| 33 | handle = 0; | ||
| 34 | } | ||
| 35 | |||
| 36 | void OGLSampler::Create() { | ||
| 37 | if (handle != 0) | ||
| 38 | return; | ||
| 39 | |||
| 40 | MICROPROFILE_SCOPE(OpenGL_ResourceCreation); | ||
| 41 | glGenSamplers(1, &handle); | ||
| 42 | } | ||
| 43 | |||
| 44 | void OGLSampler::Release() { | ||
| 45 | if (handle == 0) | ||
| 46 | return; | ||
| 47 | |||
| 48 | MICROPROFILE_SCOPE(OpenGL_ResourceDeletion); | ||
| 49 | glDeleteSamplers(1, &handle); | ||
| 50 | OpenGLState::GetCurState().ResetSampler(handle).Apply(); | ||
| 51 | handle = 0; | ||
| 52 | } | ||
| 53 | |||
| 54 | void OGLShader::Create(const char* source, GLenum type) { | ||
| 55 | if (handle != 0) | ||
| 56 | return; | ||
| 57 | if (source == nullptr) | ||
| 58 | return; | ||
| 59 | |||
| 60 | MICROPROFILE_SCOPE(OpenGL_ResourceCreation); | ||
| 61 | handle = GLShader::LoadShader(source, type); | ||
| 62 | } | ||
| 63 | |||
| 64 | void OGLShader::Release() { | ||
| 65 | if (handle == 0) | ||
| 66 | return; | ||
| 67 | |||
| 68 | MICROPROFILE_SCOPE(OpenGL_ResourceDeletion); | ||
| 69 | glDeleteShader(handle); | ||
| 70 | handle = 0; | ||
| 71 | } | ||
| 72 | |||
| 73 | void OGLProgram::CreateFromSource(const char* vert_shader, const char* geo_shader, | ||
| 74 | const char* frag_shader, bool separable_program) { | ||
| 75 | OGLShader vert, geo, frag; | ||
| 76 | if (vert_shader) | ||
| 77 | vert.Create(vert_shader, GL_VERTEX_SHADER); | ||
| 78 | if (geo_shader) | ||
| 79 | geo.Create(geo_shader, GL_GEOMETRY_SHADER); | ||
| 80 | if (frag_shader) | ||
| 81 | frag.Create(frag_shader, GL_FRAGMENT_SHADER); | ||
| 82 | |||
| 83 | MICROPROFILE_SCOPE(OpenGL_ResourceCreation); | ||
| 84 | Create(separable_program, vert.handle, geo.handle, frag.handle); | ||
| 85 | } | ||
| 86 | |||
| 87 | void OGLProgram::Release() { | ||
| 88 | if (handle == 0) | ||
| 89 | return; | ||
| 90 | |||
| 91 | MICROPROFILE_SCOPE(OpenGL_ResourceDeletion); | ||
| 92 | glDeleteProgram(handle); | ||
| 93 | OpenGLState::GetCurState().ResetProgram(handle).Apply(); | ||
| 94 | handle = 0; | ||
| 95 | } | ||
| 96 | |||
| 97 | void OGLPipeline::Create() { | ||
| 98 | if (handle != 0) | ||
| 99 | return; | ||
| 100 | |||
| 101 | MICROPROFILE_SCOPE(OpenGL_ResourceCreation); | ||
| 102 | glGenProgramPipelines(1, &handle); | ||
| 103 | } | ||
| 104 | |||
| 105 | void OGLPipeline::Release() { | ||
| 106 | if (handle == 0) | ||
| 107 | return; | ||
| 108 | |||
| 109 | MICROPROFILE_SCOPE(OpenGL_ResourceDeletion); | ||
| 110 | glDeleteProgramPipelines(1, &handle); | ||
| 111 | OpenGLState::GetCurState().ResetPipeline(handle).Apply(); | ||
| 112 | handle = 0; | ||
| 113 | } | ||
| 114 | |||
| 115 | void OGLBuffer::Create() { | ||
| 116 | if (handle != 0) | ||
| 117 | return; | ||
| 118 | |||
| 119 | MICROPROFILE_SCOPE(OpenGL_ResourceCreation); | ||
| 120 | glGenBuffers(1, &handle); | ||
| 121 | } | ||
| 122 | |||
| 123 | void OGLBuffer::Release() { | ||
| 124 | if (handle == 0) | ||
| 125 | return; | ||
| 126 | |||
| 127 | MICROPROFILE_SCOPE(OpenGL_ResourceDeletion); | ||
| 128 | glDeleteBuffers(1, &handle); | ||
| 129 | OpenGLState::GetCurState().ResetBuffer(handle).Apply(); | ||
| 130 | handle = 0; | ||
| 131 | } | ||
| 132 | |||
| 133 | void OGLSync::Create() { | ||
| 134 | if (handle != 0) | ||
| 135 | return; | ||
| 136 | |||
| 137 | // Don't profile here, this one is expected to happen ingame. | ||
| 138 | handle = glFenceSync(GL_SYNC_GPU_COMMANDS_COMPLETE, 0); | ||
| 139 | } | ||
| 140 | |||
| 141 | void OGLSync::Release() { | ||
| 142 | if (handle == 0) | ||
| 143 | return; | ||
| 144 | |||
| 145 | // Don't profile here, this one is expected to happen ingame. | ||
| 146 | glDeleteSync(handle); | ||
| 147 | handle = 0; | ||
| 148 | } | ||
| 149 | |||
| 150 | void OGLVertexArray::Create() { | ||
| 151 | if (handle != 0) | ||
| 152 | return; | ||
| 153 | |||
| 154 | MICROPROFILE_SCOPE(OpenGL_ResourceCreation); | ||
| 155 | glGenVertexArrays(1, &handle); | ||
| 156 | } | ||
| 157 | |||
| 158 | void OGLVertexArray::Release() { | ||
| 159 | if (handle == 0) | ||
| 160 | return; | ||
| 161 | |||
| 162 | MICROPROFILE_SCOPE(OpenGL_ResourceDeletion); | ||
| 163 | glDeleteVertexArrays(1, &handle); | ||
| 164 | OpenGLState::GetCurState().ResetVertexArray(handle).Apply(); | ||
| 165 | handle = 0; | ||
| 166 | } | ||
| 167 | |||
| 168 | void OGLFramebuffer::Create() { | ||
| 169 | if (handle != 0) | ||
| 170 | return; | ||
| 171 | |||
| 172 | MICROPROFILE_SCOPE(OpenGL_ResourceCreation); | ||
| 173 | glGenFramebuffers(1, &handle); | ||
| 174 | } | ||
| 175 | |||
| 176 | void OGLFramebuffer::Release() { | ||
| 177 | if (handle == 0) | ||
| 178 | return; | ||
| 179 | |||
| 180 | MICROPROFILE_SCOPE(OpenGL_ResourceDeletion); | ||
| 181 | glDeleteFramebuffers(1, &handle); | ||
| 182 | OpenGLState::GetCurState().ResetFramebuffer(handle).Apply(); | ||
| 183 | handle = 0; | ||
| 184 | } | ||
| 185 | |||
| 186 | } // namespace OpenGL | ||
diff --git a/src/video_core/renderer_opengl/gl_resource_manager.h b/src/video_core/renderer_opengl/gl_resource_manager.h index 3bc1b83b5..e33f1e973 100644 --- a/src/video_core/renderer_opengl/gl_resource_manager.h +++ b/src/video_core/renderer_opengl/gl_resource_manager.h | |||
| @@ -8,7 +8,6 @@ | |||
| 8 | #include <glad/glad.h> | 8 | #include <glad/glad.h> |
| 9 | #include "common/common_types.h" | 9 | #include "common/common_types.h" |
| 10 | #include "video_core/renderer_opengl/gl_shader_util.h" | 10 | #include "video_core/renderer_opengl/gl_shader_util.h" |
| 11 | #include "video_core/renderer_opengl/gl_state.h" | ||
| 12 | 11 | ||
| 13 | namespace OpenGL { | 12 | namespace OpenGL { |
| 14 | 13 | ||
| @@ -29,20 +28,10 @@ public: | |||
| 29 | } | 28 | } |
| 30 | 29 | ||
| 31 | /// Creates a new internal OpenGL resource and stores the handle | 30 | /// Creates a new internal OpenGL resource and stores the handle |
| 32 | void Create() { | 31 | void Create(); |
| 33 | if (handle != 0) | ||
| 34 | return; | ||
| 35 | glGenTextures(1, &handle); | ||
| 36 | } | ||
| 37 | 32 | ||
| 38 | /// Deletes the internal OpenGL resource | 33 | /// Deletes the internal OpenGL resource |
| 39 | void Release() { | 34 | void Release(); |
| 40 | if (handle == 0) | ||
| 41 | return; | ||
| 42 | glDeleteTextures(1, &handle); | ||
| 43 | OpenGLState::GetCurState().UnbindTexture(handle).Apply(); | ||
| 44 | handle = 0; | ||
| 45 | } | ||
| 46 | 35 | ||
| 47 | GLuint handle = 0; | 36 | GLuint handle = 0; |
| 48 | }; | 37 | }; |
| @@ -64,20 +53,10 @@ public: | |||
| 64 | } | 53 | } |
| 65 | 54 | ||
| 66 | /// Creates a new internal OpenGL resource and stores the handle | 55 | /// Creates a new internal OpenGL resource and stores the handle |
| 67 | void Create() { | 56 | void Create(); |
| 68 | if (handle != 0) | ||
| 69 | return; | ||
| 70 | glGenSamplers(1, &handle); | ||
| 71 | } | ||
| 72 | 57 | ||
| 73 | /// Deletes the internal OpenGL resource | 58 | /// Deletes the internal OpenGL resource |
| 74 | void Release() { | 59 | void Release(); |
| 75 | if (handle == 0) | ||
| 76 | return; | ||
| 77 | glDeleteSamplers(1, &handle); | ||
| 78 | OpenGLState::GetCurState().ResetSampler(handle).Apply(); | ||
| 79 | handle = 0; | ||
| 80 | } | ||
| 81 | 60 | ||
| 82 | GLuint handle = 0; | 61 | GLuint handle = 0; |
| 83 | }; | 62 | }; |
| @@ -98,20 +77,9 @@ public: | |||
| 98 | return *this; | 77 | return *this; |
| 99 | } | 78 | } |
| 100 | 79 | ||
| 101 | void Create(const char* source, GLenum type) { | 80 | void Create(const char* source, GLenum type); |
| 102 | if (handle != 0) | ||
| 103 | return; | ||
| 104 | if (source == nullptr) | ||
| 105 | return; | ||
| 106 | handle = GLShader::LoadShader(source, type); | ||
| 107 | } | ||
| 108 | 81 | ||
| 109 | void Release() { | 82 | void Release(); |
| 110 | if (handle == 0) | ||
| 111 | return; | ||
| 112 | glDeleteShader(handle); | ||
| 113 | handle = 0; | ||
| 114 | } | ||
| 115 | 83 | ||
| 116 | GLuint handle = 0; | 84 | GLuint handle = 0; |
| 117 | }; | 85 | }; |
| @@ -141,25 +109,10 @@ public: | |||
| 141 | 109 | ||
| 142 | /// Creates a new internal OpenGL resource and stores the handle | 110 | /// Creates a new internal OpenGL resource and stores the handle |
| 143 | void CreateFromSource(const char* vert_shader, const char* geo_shader, const char* frag_shader, | 111 | void CreateFromSource(const char* vert_shader, const char* geo_shader, const char* frag_shader, |
| 144 | bool separable_program = false) { | 112 | bool separable_program = false); |
| 145 | OGLShader vert, geo, frag; | ||
| 146 | if (vert_shader) | ||
| 147 | vert.Create(vert_shader, GL_VERTEX_SHADER); | ||
| 148 | if (geo_shader) | ||
| 149 | geo.Create(geo_shader, GL_GEOMETRY_SHADER); | ||
| 150 | if (frag_shader) | ||
| 151 | frag.Create(frag_shader, GL_FRAGMENT_SHADER); | ||
| 152 | Create(separable_program, vert.handle, geo.handle, frag.handle); | ||
| 153 | } | ||
| 154 | 113 | ||
| 155 | /// Deletes the internal OpenGL resource | 114 | /// Deletes the internal OpenGL resource |
| 156 | void Release() { | 115 | void Release(); |
| 157 | if (handle == 0) | ||
| 158 | return; | ||
| 159 | glDeleteProgram(handle); | ||
| 160 | OpenGLState::GetCurState().ResetProgram(handle).Apply(); | ||
| 161 | handle = 0; | ||
| 162 | } | ||
| 163 | 116 | ||
| 164 | GLuint handle = 0; | 117 | GLuint handle = 0; |
| 165 | }; | 118 | }; |
| @@ -178,20 +131,10 @@ public: | |||
| 178 | } | 131 | } |
| 179 | 132 | ||
| 180 | /// Creates a new internal OpenGL resource and stores the handle | 133 | /// Creates a new internal OpenGL resource and stores the handle |
| 181 | void Create() { | 134 | void Create(); |
| 182 | if (handle != 0) | ||
| 183 | return; | ||
| 184 | glGenProgramPipelines(1, &handle); | ||
| 185 | } | ||
| 186 | 135 | ||
| 187 | /// Deletes the internal OpenGL resource | 136 | /// Deletes the internal OpenGL resource |
| 188 | void Release() { | 137 | void Release(); |
| 189 | if (handle == 0) | ||
| 190 | return; | ||
| 191 | glDeleteProgramPipelines(1, &handle); | ||
| 192 | OpenGLState::GetCurState().ResetPipeline(handle).Apply(); | ||
| 193 | handle = 0; | ||
| 194 | } | ||
| 195 | 138 | ||
| 196 | GLuint handle = 0; | 139 | GLuint handle = 0; |
| 197 | }; | 140 | }; |
| @@ -213,20 +156,10 @@ public: | |||
| 213 | } | 156 | } |
| 214 | 157 | ||
| 215 | /// Creates a new internal OpenGL resource and stores the handle | 158 | /// Creates a new internal OpenGL resource and stores the handle |
| 216 | void Create() { | 159 | void Create(); |
| 217 | if (handle != 0) | ||
| 218 | return; | ||
| 219 | glGenBuffers(1, &handle); | ||
| 220 | } | ||
| 221 | 160 | ||
| 222 | /// Deletes the internal OpenGL resource | 161 | /// Deletes the internal OpenGL resource |
| 223 | void Release() { | 162 | void Release(); |
| 224 | if (handle == 0) | ||
| 225 | return; | ||
| 226 | glDeleteBuffers(1, &handle); | ||
| 227 | OpenGLState::GetCurState().ResetBuffer(handle).Apply(); | ||
| 228 | handle = 0; | ||
| 229 | } | ||
| 230 | 163 | ||
| 231 | GLuint handle = 0; | 164 | GLuint handle = 0; |
| 232 | }; | 165 | }; |
| @@ -247,19 +180,10 @@ public: | |||
| 247 | } | 180 | } |
| 248 | 181 | ||
| 249 | /// Creates a new internal OpenGL resource and stores the handle | 182 | /// Creates a new internal OpenGL resource and stores the handle |
| 250 | void Create() { | 183 | void Create(); |
| 251 | if (handle != 0) | ||
| 252 | return; | ||
| 253 | handle = glFenceSync(GL_SYNC_GPU_COMMANDS_COMPLETE, 0); | ||
| 254 | } | ||
| 255 | 184 | ||
| 256 | /// Deletes the internal OpenGL resource | 185 | /// Deletes the internal OpenGL resource |
| 257 | void Release() { | 186 | void Release(); |
| 258 | if (handle == 0) | ||
| 259 | return; | ||
| 260 | glDeleteSync(handle); | ||
| 261 | handle = 0; | ||
| 262 | } | ||
| 263 | 187 | ||
| 264 | GLsync handle = 0; | 188 | GLsync handle = 0; |
| 265 | }; | 189 | }; |
| @@ -281,20 +205,10 @@ public: | |||
| 281 | } | 205 | } |
| 282 | 206 | ||
| 283 | /// Creates a new internal OpenGL resource and stores the handle | 207 | /// Creates a new internal OpenGL resource and stores the handle |
| 284 | void Create() { | 208 | void Create(); |
| 285 | if (handle != 0) | ||
| 286 | return; | ||
| 287 | glGenVertexArrays(1, &handle); | ||
| 288 | } | ||
| 289 | 209 | ||
| 290 | /// Deletes the internal OpenGL resource | 210 | /// Deletes the internal OpenGL resource |
| 291 | void Release() { | 211 | void Release(); |
| 292 | if (handle == 0) | ||
| 293 | return; | ||
| 294 | glDeleteVertexArrays(1, &handle); | ||
| 295 | OpenGLState::GetCurState().ResetVertexArray(handle).Apply(); | ||
| 296 | handle = 0; | ||
| 297 | } | ||
| 298 | 212 | ||
| 299 | GLuint handle = 0; | 213 | GLuint handle = 0; |
| 300 | }; | 214 | }; |
| @@ -316,20 +230,10 @@ public: | |||
| 316 | } | 230 | } |
| 317 | 231 | ||
| 318 | /// Creates a new internal OpenGL resource and stores the handle | 232 | /// Creates a new internal OpenGL resource and stores the handle |
| 319 | void Create() { | 233 | void Create(); |
| 320 | if (handle != 0) | ||
| 321 | return; | ||
| 322 | glGenFramebuffers(1, &handle); | ||
| 323 | } | ||
| 324 | 234 | ||
| 325 | /// Deletes the internal OpenGL resource | 235 | /// Deletes the internal OpenGL resource |
| 326 | void Release() { | 236 | void Release(); |
| 327 | if (handle == 0) | ||
| 328 | return; | ||
| 329 | glDeleteFramebuffers(1, &handle); | ||
| 330 | OpenGLState::GetCurState().ResetFramebuffer(handle).Apply(); | ||
| 331 | handle = 0; | ||
| 332 | } | ||
| 333 | 237 | ||
| 334 | GLuint handle = 0; | 238 | GLuint handle = 0; |
| 335 | }; | 239 | }; |
diff --git a/src/video_core/renderer_opengl/gl_shader_cache.cpp b/src/video_core/renderer_opengl/gl_shader_cache.cpp index 9522fd344..a85a7c0c5 100644 --- a/src/video_core/renderer_opengl/gl_shader_cache.cpp +++ b/src/video_core/renderer_opengl/gl_shader_cache.cpp | |||
| @@ -6,10 +6,10 @@ | |||
| 6 | #include "core/core.h" | 6 | #include "core/core.h" |
| 7 | #include "core/memory.h" | 7 | #include "core/memory.h" |
| 8 | #include "video_core/engines/maxwell_3d.h" | 8 | #include "video_core/engines/maxwell_3d.h" |
| 9 | #include "video_core/renderer_opengl/gl_rasterizer.h" | ||
| 9 | #include "video_core/renderer_opengl/gl_shader_cache.h" | 10 | #include "video_core/renderer_opengl/gl_shader_cache.h" |
| 10 | #include "video_core/renderer_opengl/gl_shader_manager.h" | 11 | #include "video_core/renderer_opengl/gl_shader_manager.h" |
| 11 | #include "video_core/renderer_opengl/utils.h" | 12 | #include "video_core/renderer_opengl/utils.h" |
| 12 | #include "video_core/utils.h" | ||
| 13 | 13 | ||
| 14 | namespace OpenGL { | 14 | namespace OpenGL { |
| 15 | 15 | ||
| @@ -121,12 +121,16 @@ GLint CachedShader::GetUniformLocation(const GLShader::SamplerEntry& sampler) { | |||
| 121 | } | 121 | } |
| 122 | 122 | ||
| 123 | GLuint CachedShader::LazyGeometryProgram(OGLProgram& target_program, | 123 | GLuint CachedShader::LazyGeometryProgram(OGLProgram& target_program, |
| 124 | const std::string& glsl_topology, | 124 | const std::string& glsl_topology, u32 max_vertices, |
| 125 | const std::string& debug_name) { | 125 | const std::string& debug_name) { |
| 126 | if (target_program.handle != 0) { | 126 | if (target_program.handle != 0) { |
| 127 | return target_program.handle; | 127 | return target_program.handle; |
| 128 | } | 128 | } |
| 129 | const std::string source{geometry_programs.code + "layout (" + glsl_topology + ") in;\n"}; | 129 | std::string source = "#version 430 core\n"; |
| 130 | source += "layout (" + glsl_topology + ") in;\n"; | ||
| 131 | source += "#define MAX_VERTEX_INPUT " + std::to_string(max_vertices) + '\n'; | ||
| 132 | source += geometry_programs.code; | ||
| 133 | |||
| 130 | OGLShader shader; | 134 | OGLShader shader; |
| 131 | shader.Create(source.c_str(), GL_GEOMETRY_SHADER); | 135 | shader.Create(source.c_str(), GL_GEOMETRY_SHADER); |
| 132 | target_program.Create(true, shader.handle); | 136 | target_program.Create(true, shader.handle); |
| @@ -135,6 +139,8 @@ GLuint CachedShader::LazyGeometryProgram(OGLProgram& target_program, | |||
| 135 | return target_program.handle; | 139 | return target_program.handle; |
| 136 | }; | 140 | }; |
| 137 | 141 | ||
| 142 | ShaderCacheOpenGL::ShaderCacheOpenGL(RasterizerOpenGL& rasterizer) : RasterizerCache{rasterizer} {} | ||
| 143 | |||
| 138 | Shader ShaderCacheOpenGL::GetStageProgram(Maxwell::ShaderProgram program) { | 144 | Shader ShaderCacheOpenGL::GetStageProgram(Maxwell::ShaderProgram program) { |
| 139 | const VAddr program_addr{GetShaderAddress(program)}; | 145 | const VAddr program_addr{GetShaderAddress(program)}; |
| 140 | 146 | ||
diff --git a/src/video_core/renderer_opengl/gl_shader_cache.h b/src/video_core/renderer_opengl/gl_shader_cache.h index a210f1731..ffbf21831 100644 --- a/src/video_core/renderer_opengl/gl_shader_cache.h +++ b/src/video_core/renderer_opengl/gl_shader_cache.h | |||
| @@ -16,6 +16,8 @@ | |||
| 16 | namespace OpenGL { | 16 | namespace OpenGL { |
| 17 | 17 | ||
| 18 | class CachedShader; | 18 | class CachedShader; |
| 19 | class RasterizerOpenGL; | ||
| 20 | |||
| 19 | using Shader = std::shared_ptr<CachedShader>; | 21 | using Shader = std::shared_ptr<CachedShader>; |
| 20 | using Maxwell = Tegra::Engines::Maxwell3D::Regs; | 22 | using Maxwell = Tegra::Engines::Maxwell3D::Regs; |
| 21 | 23 | ||
| @@ -46,22 +48,23 @@ public: | |||
| 46 | } | 48 | } |
| 47 | switch (primitive_mode) { | 49 | switch (primitive_mode) { |
| 48 | case GL_POINTS: | 50 | case GL_POINTS: |
| 49 | return LazyGeometryProgram(geometry_programs.points, "points", "ShaderPoints"); | 51 | return LazyGeometryProgram(geometry_programs.points, "points", 1, "ShaderPoints"); |
| 50 | case GL_LINES: | 52 | case GL_LINES: |
| 51 | case GL_LINE_STRIP: | 53 | case GL_LINE_STRIP: |
| 52 | return LazyGeometryProgram(geometry_programs.lines, "lines", "ShaderLines"); | 54 | return LazyGeometryProgram(geometry_programs.lines, "lines", 2, "ShaderLines"); |
| 53 | case GL_LINES_ADJACENCY: | 55 | case GL_LINES_ADJACENCY: |
| 54 | case GL_LINE_STRIP_ADJACENCY: | 56 | case GL_LINE_STRIP_ADJACENCY: |
| 55 | return LazyGeometryProgram(geometry_programs.lines_adjacency, "lines_adjacency", | 57 | return LazyGeometryProgram(geometry_programs.lines_adjacency, "lines_adjacency", 4, |
| 56 | "ShaderLinesAdjacency"); | 58 | "ShaderLinesAdjacency"); |
| 57 | case GL_TRIANGLES: | 59 | case GL_TRIANGLES: |
| 58 | case GL_TRIANGLE_STRIP: | 60 | case GL_TRIANGLE_STRIP: |
| 59 | case GL_TRIANGLE_FAN: | 61 | case GL_TRIANGLE_FAN: |
| 60 | return LazyGeometryProgram(geometry_programs.triangles, "triangles", "ShaderTriangles"); | 62 | return LazyGeometryProgram(geometry_programs.triangles, "triangles", 3, |
| 63 | "ShaderTriangles"); | ||
| 61 | case GL_TRIANGLES_ADJACENCY: | 64 | case GL_TRIANGLES_ADJACENCY: |
| 62 | case GL_TRIANGLE_STRIP_ADJACENCY: | 65 | case GL_TRIANGLE_STRIP_ADJACENCY: |
| 63 | return LazyGeometryProgram(geometry_programs.triangles_adjacency, "triangles_adjacency", | 66 | return LazyGeometryProgram(geometry_programs.triangles_adjacency, "triangles_adjacency", |
| 64 | "ShaderLines"); | 67 | 6, "ShaderTrianglesAdjacency"); |
| 65 | default: | 68 | default: |
| 66 | UNREACHABLE_MSG("Unknown primitive mode."); | 69 | UNREACHABLE_MSG("Unknown primitive mode."); |
| 67 | } | 70 | } |
| @@ -76,7 +79,7 @@ public: | |||
| 76 | private: | 79 | private: |
| 77 | /// Generates a geometry shader or returns one that already exists. | 80 | /// Generates a geometry shader or returns one that already exists. |
| 78 | GLuint LazyGeometryProgram(OGLProgram& target_program, const std::string& glsl_topology, | 81 | GLuint LazyGeometryProgram(OGLProgram& target_program, const std::string& glsl_topology, |
| 79 | const std::string& debug_name); | 82 | u32 max_vertices, const std::string& debug_name); |
| 80 | 83 | ||
| 81 | VAddr addr; | 84 | VAddr addr; |
| 82 | Maxwell::ShaderProgram program_type; | 85 | Maxwell::ShaderProgram program_type; |
| @@ -104,6 +107,8 @@ private: | |||
| 104 | 107 | ||
| 105 | class ShaderCacheOpenGL final : public RasterizerCache<Shader> { | 108 | class ShaderCacheOpenGL final : public RasterizerCache<Shader> { |
| 106 | public: | 109 | public: |
| 110 | explicit ShaderCacheOpenGL(RasterizerOpenGL& rasterizer); | ||
| 111 | |||
| 107 | /// Gets the current specified shader stage program | 112 | /// Gets the current specified shader stage program |
| 108 | Shader GetStageProgram(Maxwell::ShaderProgram program); | 113 | Shader GetStageProgram(Maxwell::ShaderProgram program); |
| 109 | }; | 114 | }; |
diff --git a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp index 09b003c59..5fde22ad4 100644 --- a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp +++ b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp | |||
| @@ -494,10 +494,10 @@ public: | |||
| 494 | // instruction for now. | 494 | // instruction for now. |
| 495 | if (stage == Maxwell3D::Regs::ShaderStage::Geometry) { | 495 | if (stage == Maxwell3D::Regs::ShaderStage::Geometry) { |
| 496 | // TODO(Rodrigo): nouveau sets some attributes after setting emitting a geometry | 496 | // TODO(Rodrigo): nouveau sets some attributes after setting emitting a geometry |
| 497 | // shader. These instructions use a dirty register as buffer index. To avoid some | 497 | // shader. These instructions use a dirty register as buffer index, to avoid some |
| 498 | // drivers from complaining for the out of boundary writes, guard them. | 498 | // drivers from complaining about out of boundary writes, guard them. |
| 499 | const std::string buf_index{"min(" + GetRegisterAsInteger(buf_reg) + ", " + | 499 | const std::string buf_index{"((" + GetRegisterAsInteger(buf_reg) + ") % " + |
| 500 | std::to_string(MAX_GEOMETRY_BUFFERS - 1) + ')'}; | 500 | std::to_string(MAX_GEOMETRY_BUFFERS) + ')'}; |
| 501 | shader.AddLine("amem[" + buf_index + "][" + | 501 | shader.AddLine("amem[" + buf_index + "][" + |
| 502 | std::to_string(static_cast<u32>(attribute)) + ']' + | 502 | std::to_string(static_cast<u32>(attribute)) + ']' + |
| 503 | GetSwizzle(elem) + " = " + src + ';'); | 503 | GetSwizzle(elem) + " = " + src + ';'); |
| @@ -811,7 +811,11 @@ private: | |||
| 811 | std::optional<Register> vertex = {}) { | 811 | std::optional<Register> vertex = {}) { |
| 812 | auto GeometryPass = [&](const std::string& name) { | 812 | auto GeometryPass = [&](const std::string& name) { |
| 813 | if (stage == Maxwell3D::Regs::ShaderStage::Geometry && vertex) { | 813 | if (stage == Maxwell3D::Regs::ShaderStage::Geometry && vertex) { |
| 814 | return "gs_" + name + '[' + GetRegisterAsInteger(*vertex, 0, false) + ']'; | 814 | // TODO(Rodrigo): Guard geometry inputs against out of bound reads. Some games set |
| 815 | // an 0x80000000 index for those and the shader fails to build. Find out why this | ||
| 816 | // happens and what's its intent. | ||
| 817 | return "gs_" + name + '[' + GetRegisterAsInteger(*vertex, 0, false) + | ||
| 818 | " % MAX_VERTEX_INPUT]"; | ||
| 815 | } | 819 | } |
| 816 | return name; | 820 | return name; |
| 817 | }; | 821 | }; |
| @@ -2742,12 +2746,12 @@ private: | |||
| 2742 | } | 2746 | } |
| 2743 | case 3: { | 2747 | case 3: { |
| 2744 | if (is_array) { | 2748 | if (is_array) { |
| 2745 | UNIMPLEMENTED_MSG("3-coordinate arrays not fully implemented"); | 2749 | const std::string index = regs.GetRegisterAsInteger(instr.gpr8); |
| 2746 | const std::string x = regs.GetRegisterAsFloat(instr.gpr8); | 2750 | const std::string x = regs.GetRegisterAsFloat(instr.gpr8.Value() + 1); |
| 2747 | const std::string y = regs.GetRegisterAsFloat(instr.gpr20); | 2751 | const std::string y = regs.GetRegisterAsFloat(instr.gpr8.Value() + 2); |
| 2748 | coord = "vec2 coords = vec2(" + x + ", " + y + ");"; | 2752 | const std::string z = regs.GetRegisterAsFloat(instr.gpr20); |
| 2749 | texture_type = Tegra::Shader::TextureType::Texture2D; | 2753 | coord = |
| 2750 | is_array = false; | 2754 | "vec4 coords = vec4(" + x + ", " + y + ", " + z + ", " + index + ");"; |
| 2751 | } else { | 2755 | } else { |
| 2752 | const std::string x = regs.GetRegisterAsFloat(instr.gpr8); | 2756 | const std::string x = regs.GetRegisterAsFloat(instr.gpr8); |
| 2753 | const std::string y = regs.GetRegisterAsFloat(instr.gpr8.Value() + 1); | 2757 | const std::string y = regs.GetRegisterAsFloat(instr.gpr8.Value() + 1); |
| @@ -2777,7 +2781,11 @@ private: | |||
| 2777 | break; | 2781 | break; |
| 2778 | } | 2782 | } |
| 2779 | case Tegra::Shader::TextureProcessMode::LZ: { | 2783 | case Tegra::Shader::TextureProcessMode::LZ: { |
| 2780 | texture = "textureLod(" + sampler + ", coords, 0.0)"; | 2784 | if (depth_compare && is_array) { |
| 2785 | texture = "texture(" + sampler + ", coords)"; | ||
| 2786 | } else { | ||
| 2787 | texture = "textureLod(" + sampler + ", coords, 0.0)"; | ||
| 2788 | } | ||
| 2781 | break; | 2789 | break; |
| 2782 | } | 2790 | } |
| 2783 | case Tegra::Shader::TextureProcessMode::LL: { | 2791 | case Tegra::Shader::TextureProcessMode::LL: { |
diff --git a/src/video_core/renderer_opengl/gl_shader_gen.cpp b/src/video_core/renderer_opengl/gl_shader_gen.cpp index 9d17edd63..eea090e52 100644 --- a/src/video_core/renderer_opengl/gl_shader_gen.cpp +++ b/src/video_core/renderer_opengl/gl_shader_gen.cpp | |||
| @@ -82,8 +82,8 @@ void main() { | |||
| 82 | } | 82 | } |
| 83 | 83 | ||
| 84 | ProgramResult GenerateGeometryShader(const ShaderSetup& setup) { | 84 | ProgramResult GenerateGeometryShader(const ShaderSetup& setup) { |
| 85 | std::string out = "#version 430 core\n"; | 85 | // Version is intentionally skipped in shader generation, it's added by the lazy compilation. |
| 86 | out += "#extension GL_ARB_separate_shader_objects : enable\n\n"; | 86 | std::string out = "#extension GL_ARB_separate_shader_objects : enable\n\n"; |
| 87 | out += Decompiler::GetCommonDeclarations(); | 87 | out += Decompiler::GetCommonDeclarations(); |
| 88 | out += "bool exec_geometry();\n"; | 88 | out += "bool exec_geometry();\n"; |
| 89 | 89 | ||
diff --git a/src/video_core/renderer_opengl/gl_shader_manager.h b/src/video_core/renderer_opengl/gl_shader_manager.h index 36fe1f04c..2a069cdd8 100644 --- a/src/video_core/renderer_opengl/gl_shader_manager.h +++ b/src/video_core/renderer_opengl/gl_shader_manager.h | |||
| @@ -7,6 +7,7 @@ | |||
| 7 | #include <glad/glad.h> | 7 | #include <glad/glad.h> |
| 8 | 8 | ||
| 9 | #include "video_core/renderer_opengl/gl_resource_manager.h" | 9 | #include "video_core/renderer_opengl/gl_resource_manager.h" |
| 10 | #include "video_core/renderer_opengl/gl_state.h" | ||
| 10 | #include "video_core/renderer_opengl/maxwell_to_gl.h" | 11 | #include "video_core/renderer_opengl/maxwell_to_gl.h" |
| 11 | 12 | ||
| 12 | namespace OpenGL::GLShader { | 13 | namespace OpenGL::GLShader { |
diff --git a/src/video_core/renderer_opengl/gl_state.cpp b/src/video_core/renderer_opengl/gl_state.cpp index b6b426f34..9517285e5 100644 --- a/src/video_core/renderer_opengl/gl_state.cpp +++ b/src/video_core/renderer_opengl/gl_state.cpp | |||
| @@ -22,17 +22,15 @@ OpenGLState::OpenGLState() { | |||
| 22 | depth.test_enabled = false; | 22 | depth.test_enabled = false; |
| 23 | depth.test_func = GL_LESS; | 23 | depth.test_func = GL_LESS; |
| 24 | depth.write_mask = GL_TRUE; | 24 | depth.write_mask = GL_TRUE; |
| 25 | depth.depth_range_near = 0.0f; | ||
| 26 | depth.depth_range_far = 1.0f; | ||
| 27 | 25 | ||
| 28 | primitive_restart.enabled = false; | 26 | primitive_restart.enabled = false; |
| 29 | primitive_restart.index = 0; | 27 | primitive_restart.index = 0; |
| 30 | 28 | for (auto& item : color_mask) { | |
| 31 | color_mask.red_enabled = GL_TRUE; | 29 | item.red_enabled = GL_TRUE; |
| 32 | color_mask.green_enabled = GL_TRUE; | 30 | item.green_enabled = GL_TRUE; |
| 33 | color_mask.blue_enabled = GL_TRUE; | 31 | item.blue_enabled = GL_TRUE; |
| 34 | color_mask.alpha_enabled = GL_TRUE; | 32 | item.alpha_enabled = GL_TRUE; |
| 35 | 33 | } | |
| 36 | stencil.test_enabled = false; | 34 | stencil.test_enabled = false; |
| 37 | auto reset_stencil = [](auto& config) { | 35 | auto reset_stencil = [](auto& config) { |
| 38 | config.test_func = GL_ALWAYS; | 36 | config.test_func = GL_ALWAYS; |
| @@ -45,19 +43,33 @@ OpenGLState::OpenGLState() { | |||
| 45 | }; | 43 | }; |
| 46 | reset_stencil(stencil.front); | 44 | reset_stencil(stencil.front); |
| 47 | reset_stencil(stencil.back); | 45 | reset_stencil(stencil.back); |
| 48 | 46 | for (auto& item : viewports) { | |
| 49 | blend.enabled = true; | 47 | item.x = 0; |
| 50 | blend.rgb_equation = GL_FUNC_ADD; | 48 | item.y = 0; |
| 51 | blend.a_equation = GL_FUNC_ADD; | 49 | item.width = 0; |
| 52 | blend.src_rgb_func = GL_ONE; | 50 | item.height = 0; |
| 53 | blend.dst_rgb_func = GL_ZERO; | 51 | item.depth_range_near = 0.0f; |
| 54 | blend.src_a_func = GL_ONE; | 52 | item.depth_range_far = 1.0f; |
| 55 | blend.dst_a_func = GL_ZERO; | 53 | } |
| 56 | blend.color.red = 0.0f; | 54 | scissor.enabled = false; |
| 57 | blend.color.green = 0.0f; | 55 | scissor.x = 0; |
| 58 | blend.color.blue = 0.0f; | 56 | scissor.y = 0; |
| 59 | blend.color.alpha = 0.0f; | 57 | scissor.width = 0; |
| 60 | 58 | scissor.height = 0; | |
| 59 | for (auto& item : blend) { | ||
| 60 | item.enabled = true; | ||
| 61 | item.rgb_equation = GL_FUNC_ADD; | ||
| 62 | item.a_equation = GL_FUNC_ADD; | ||
| 63 | item.src_rgb_func = GL_ONE; | ||
| 64 | item.dst_rgb_func = GL_ZERO; | ||
| 65 | item.src_a_func = GL_ONE; | ||
| 66 | item.dst_a_func = GL_ZERO; | ||
| 67 | } | ||
| 68 | independant_blend.enabled = false; | ||
| 69 | blend_color.red = 0.0f; | ||
| 70 | blend_color.green = 0.0f; | ||
| 71 | blend_color.blue = 0.0f; | ||
| 72 | blend_color.alpha = 0.0f; | ||
| 61 | logic_op.enabled = false; | 73 | logic_op.enabled = false; |
| 62 | logic_op.operation = GL_COPY; | 74 | logic_op.operation = GL_COPY; |
| 63 | 75 | ||
| @@ -73,17 +85,6 @@ OpenGLState::OpenGLState() { | |||
| 73 | draw.shader_program = 0; | 85 | draw.shader_program = 0; |
| 74 | draw.program_pipeline = 0; | 86 | draw.program_pipeline = 0; |
| 75 | 87 | ||
| 76 | scissor.enabled = false; | ||
| 77 | scissor.x = 0; | ||
| 78 | scissor.y = 0; | ||
| 79 | scissor.width = 0; | ||
| 80 | scissor.height = 0; | ||
| 81 | |||
| 82 | viewport.x = 0; | ||
| 83 | viewport.y = 0; | ||
| 84 | viewport.width = 0; | ||
| 85 | viewport.height = 0; | ||
| 86 | |||
| 87 | clip_distance = {}; | 88 | clip_distance = {}; |
| 88 | 89 | ||
| 89 | point.size = 1; | 90 | point.size = 1; |
| @@ -134,6 +135,32 @@ void OpenGLState::ApplyCulling() const { | |||
| 134 | } | 135 | } |
| 135 | } | 136 | } |
| 136 | 137 | ||
| 138 | void OpenGLState::ApplyColorMask() const { | ||
| 139 | if (GLAD_GL_ARB_viewport_array) { | ||
| 140 | for (size_t i = 0; i < Tegra::Engines::Maxwell3D::Regs::NumRenderTargets; i++) { | ||
| 141 | const auto& updated = color_mask[i]; | ||
| 142 | const auto& current = cur_state.color_mask[i]; | ||
| 143 | if (updated.red_enabled != current.red_enabled || | ||
| 144 | updated.green_enabled != current.green_enabled || | ||
| 145 | updated.blue_enabled != current.blue_enabled || | ||
| 146 | updated.alpha_enabled != current.alpha_enabled) { | ||
| 147 | glColorMaski(static_cast<GLuint>(i), updated.red_enabled, updated.green_enabled, | ||
| 148 | updated.blue_enabled, updated.alpha_enabled); | ||
| 149 | } | ||
| 150 | } | ||
| 151 | } else { | ||
| 152 | const auto& updated = color_mask[0]; | ||
| 153 | const auto& current = cur_state.color_mask[0]; | ||
| 154 | if (updated.red_enabled != current.red_enabled || | ||
| 155 | updated.green_enabled != current.green_enabled || | ||
| 156 | updated.blue_enabled != current.blue_enabled || | ||
| 157 | updated.alpha_enabled != current.alpha_enabled) { | ||
| 158 | glColorMask(updated.red_enabled, updated.green_enabled, updated.blue_enabled, | ||
| 159 | updated.alpha_enabled); | ||
| 160 | } | ||
| 161 | } | ||
| 162 | } | ||
| 163 | |||
| 137 | void OpenGLState::ApplyDepth() const { | 164 | void OpenGLState::ApplyDepth() const { |
| 138 | // Depth test | 165 | // Depth test |
| 139 | const bool depth_test_changed = depth.test_enabled != cur_state.depth.test_enabled; | 166 | const bool depth_test_changed = depth.test_enabled != cur_state.depth.test_enabled; |
| @@ -152,11 +179,6 @@ void OpenGLState::ApplyDepth() const { | |||
| 152 | if (depth.write_mask != cur_state.depth.write_mask) { | 179 | if (depth.write_mask != cur_state.depth.write_mask) { |
| 153 | glDepthMask(depth.write_mask); | 180 | glDepthMask(depth.write_mask); |
| 154 | } | 181 | } |
| 155 | // Depth range | ||
| 156 | if (depth.depth_range_near != cur_state.depth.depth_range_near || | ||
| 157 | depth.depth_range_far != cur_state.depth.depth_range_far) { | ||
| 158 | glDepthRange(depth.depth_range_near, depth.depth_range_far); | ||
| 159 | } | ||
| 160 | } | 182 | } |
| 161 | 183 | ||
| 162 | void OpenGLState::ApplyPrimitiveRestart() const { | 184 | void OpenGLState::ApplyPrimitiveRestart() const { |
| @@ -208,7 +230,7 @@ void OpenGLState::ApplyStencilTest() const { | |||
| 208 | } | 230 | } |
| 209 | } | 231 | } |
| 210 | 232 | ||
| 211 | void OpenGLState::ApplyScissorTest() const { | 233 | void OpenGLState::ApplyScissor() const { |
| 212 | const bool scissor_changed = scissor.enabled != cur_state.scissor.enabled; | 234 | const bool scissor_changed = scissor.enabled != cur_state.scissor.enabled; |
| 213 | if (scissor_changed) { | 235 | if (scissor_changed) { |
| 214 | if (scissor.enabled) { | 236 | if (scissor.enabled) { |
| @@ -217,51 +239,141 @@ void OpenGLState::ApplyScissorTest() const { | |||
| 217 | glDisable(GL_SCISSOR_TEST); | 239 | glDisable(GL_SCISSOR_TEST); |
| 218 | } | 240 | } |
| 219 | } | 241 | } |
| 220 | if (scissor_changed || scissor_changed || scissor.x != cur_state.scissor.x || | 242 | if (scissor.enabled && |
| 221 | scissor.y != cur_state.scissor.y || scissor.width != cur_state.scissor.width || | 243 | (scissor_changed || scissor.x != cur_state.scissor.x || scissor.y != cur_state.scissor.y || |
| 222 | scissor.height != cur_state.scissor.height) { | 244 | scissor.width != cur_state.scissor.width || scissor.height != cur_state.scissor.height)) { |
| 223 | glScissor(scissor.x, scissor.y, scissor.width, scissor.height); | 245 | glScissor(scissor.x, scissor.y, scissor.width, scissor.height); |
| 224 | } | 246 | } |
| 225 | } | 247 | } |
| 226 | 248 | ||
| 227 | void OpenGLState::ApplyBlending() const { | 249 | void OpenGLState::ApplyViewport() const { |
| 228 | const bool blend_changed = blend.enabled != cur_state.blend.enabled; | 250 | if (GLAD_GL_ARB_viewport_array) { |
| 251 | for (GLuint i = 0; | ||
| 252 | i < static_cast<GLuint>(Tegra::Engines::Maxwell3D::Regs::NumRenderTargets); i++) { | ||
| 253 | const auto& current = cur_state.viewports[i]; | ||
| 254 | const auto& updated = viewports[i]; | ||
| 255 | if (updated.x != current.x || updated.y != current.y || | ||
| 256 | updated.width != current.width || updated.height != current.height) { | ||
| 257 | glViewportIndexedf(i, updated.x, updated.y, updated.width, updated.height); | ||
| 258 | } | ||
| 259 | if (updated.depth_range_near != current.depth_range_near || | ||
| 260 | updated.depth_range_far != current.depth_range_far) { | ||
| 261 | glDepthRangeIndexed(i, updated.depth_range_near, updated.depth_range_far); | ||
| 262 | } | ||
| 263 | } | ||
| 264 | } else { | ||
| 265 | const auto& current = cur_state.viewports[0]; | ||
| 266 | const auto& updated = viewports[0]; | ||
| 267 | if (updated.x != current.x || updated.y != current.y || updated.width != current.width || | ||
| 268 | updated.height != current.height) { | ||
| 269 | glViewport(updated.x, updated.y, updated.width, updated.height); | ||
| 270 | } | ||
| 271 | if (updated.depth_range_near != current.depth_range_near || | ||
| 272 | updated.depth_range_far != current.depth_range_far) { | ||
| 273 | glDepthRange(updated.depth_range_near, updated.depth_range_far); | ||
| 274 | } | ||
| 275 | } | ||
| 276 | } | ||
| 277 | |||
| 278 | void OpenGLState::ApplyGlobalBlending() const { | ||
| 279 | const Blend& current = cur_state.blend[0]; | ||
| 280 | const Blend& updated = blend[0]; | ||
| 281 | const bool blend_changed = updated.enabled != current.enabled; | ||
| 229 | if (blend_changed) { | 282 | if (blend_changed) { |
| 230 | if (blend.enabled) { | 283 | if (updated.enabled) { |
| 231 | ASSERT(!logic_op.enabled); | ||
| 232 | glEnable(GL_BLEND); | 284 | glEnable(GL_BLEND); |
| 233 | } else { | 285 | } else { |
| 234 | glDisable(GL_BLEND); | 286 | glDisable(GL_BLEND); |
| 235 | } | 287 | } |
| 236 | } | 288 | } |
| 237 | if (blend.enabled) { | 289 | if (!updated.enabled) { |
| 238 | if (blend_changed || blend.color.red != cur_state.blend.color.red || | 290 | return; |
| 239 | blend.color.green != cur_state.blend.color.green || | 291 | } |
| 240 | blend.color.blue != cur_state.blend.color.blue || | 292 | if (updated.separate_alpha) { |
| 241 | blend.color.alpha != cur_state.blend.color.alpha) { | 293 | if (blend_changed || updated.src_rgb_func != current.src_rgb_func || |
| 242 | glBlendColor(blend.color.red, blend.color.green, blend.color.blue, blend.color.alpha); | 294 | updated.dst_rgb_func != current.dst_rgb_func || |
| 295 | updated.src_a_func != current.src_a_func || updated.dst_a_func != current.dst_a_func) { | ||
| 296 | glBlendFuncSeparate(updated.src_rgb_func, updated.dst_rgb_func, updated.src_a_func, | ||
| 297 | updated.dst_a_func); | ||
| 243 | } | 298 | } |
| 244 | 299 | ||
| 245 | if (blend_changed || blend.src_rgb_func != cur_state.blend.src_rgb_func || | 300 | if (blend_changed || updated.rgb_equation != current.rgb_equation || |
| 246 | blend.dst_rgb_func != cur_state.blend.dst_rgb_func || | 301 | updated.a_equation != current.a_equation) { |
| 247 | blend.src_a_func != cur_state.blend.src_a_func || | 302 | glBlendEquationSeparate(updated.rgb_equation, updated.a_equation); |
| 248 | blend.dst_a_func != cur_state.blend.dst_a_func) { | 303 | } |
| 249 | glBlendFuncSeparate(blend.src_rgb_func, blend.dst_rgb_func, blend.src_a_func, | 304 | } else { |
| 250 | blend.dst_a_func); | 305 | if (blend_changed || updated.src_rgb_func != current.src_rgb_func || |
| 306 | updated.dst_rgb_func != current.dst_rgb_func) { | ||
| 307 | glBlendFunc(updated.src_rgb_func, updated.dst_rgb_func); | ||
| 251 | } | 308 | } |
| 252 | 309 | ||
| 253 | if (blend_changed || blend.rgb_equation != cur_state.blend.rgb_equation || | 310 | if (blend_changed || updated.rgb_equation != current.rgb_equation) { |
| 254 | blend.a_equation != cur_state.blend.a_equation) { | 311 | glBlendEquation(updated.rgb_equation); |
| 255 | glBlendEquationSeparate(blend.rgb_equation, blend.a_equation); | ||
| 256 | } | 312 | } |
| 257 | } | 313 | } |
| 258 | } | 314 | } |
| 259 | 315 | ||
| 316 | void OpenGLState::ApplyTargetBlending(int target, bool force) const { | ||
| 317 | const Blend& updated = blend[target]; | ||
| 318 | const Blend& current = cur_state.blend[target]; | ||
| 319 | const bool blend_changed = updated.enabled != current.enabled || force; | ||
| 320 | if (blend_changed) { | ||
| 321 | if (updated.enabled) { | ||
| 322 | glEnablei(GL_BLEND, static_cast<GLuint>(target)); | ||
| 323 | } else { | ||
| 324 | glDisablei(GL_BLEND, static_cast<GLuint>(target)); | ||
| 325 | } | ||
| 326 | } | ||
| 327 | if (!updated.enabled) { | ||
| 328 | return; | ||
| 329 | } | ||
| 330 | if (updated.separate_alpha) { | ||
| 331 | if (blend_changed || updated.src_rgb_func != current.src_rgb_func || | ||
| 332 | updated.dst_rgb_func != current.dst_rgb_func || | ||
| 333 | updated.src_a_func != current.src_a_func || updated.dst_a_func != current.dst_a_func) { | ||
| 334 | glBlendFuncSeparateiARB(static_cast<GLuint>(target), updated.src_rgb_func, | ||
| 335 | updated.dst_rgb_func, updated.src_a_func, updated.dst_a_func); | ||
| 336 | } | ||
| 337 | |||
| 338 | if (blend_changed || updated.rgb_equation != current.rgb_equation || | ||
| 339 | updated.a_equation != current.a_equation) { | ||
| 340 | glBlendEquationSeparateiARB(static_cast<GLuint>(target), updated.rgb_equation, | ||
| 341 | updated.a_equation); | ||
| 342 | } | ||
| 343 | } else { | ||
| 344 | if (blend_changed || updated.src_rgb_func != current.src_rgb_func || | ||
| 345 | updated.dst_rgb_func != current.dst_rgb_func) { | ||
| 346 | glBlendFunciARB(static_cast<GLuint>(target), updated.src_rgb_func, | ||
| 347 | updated.dst_rgb_func); | ||
| 348 | } | ||
| 349 | |||
| 350 | if (blend_changed || updated.rgb_equation != current.rgb_equation) { | ||
| 351 | glBlendEquationiARB(static_cast<GLuint>(target), updated.rgb_equation); | ||
| 352 | } | ||
| 353 | } | ||
| 354 | } | ||
| 355 | |||
| 356 | void OpenGLState::ApplyBlending() const { | ||
| 357 | if (independant_blend.enabled) { | ||
| 358 | for (size_t i = 0; i < Tegra::Engines::Maxwell3D::Regs::NumRenderTargets; i++) { | ||
| 359 | ApplyTargetBlending(i, | ||
| 360 | independant_blend.enabled != cur_state.independant_blend.enabled); | ||
| 361 | } | ||
| 362 | } else { | ||
| 363 | ApplyGlobalBlending(); | ||
| 364 | } | ||
| 365 | if (blend_color.red != cur_state.blend_color.red || | ||
| 366 | blend_color.green != cur_state.blend_color.green || | ||
| 367 | blend_color.blue != cur_state.blend_color.blue || | ||
| 368 | blend_color.alpha != cur_state.blend_color.alpha) { | ||
| 369 | glBlendColor(blend_color.red, blend_color.green, blend_color.blue, blend_color.alpha); | ||
| 370 | } | ||
| 371 | } | ||
| 372 | |||
| 260 | void OpenGLState::ApplyLogicOp() const { | 373 | void OpenGLState::ApplyLogicOp() const { |
| 261 | const bool logic_op_changed = logic_op.enabled != cur_state.logic_op.enabled; | 374 | const bool logic_op_changed = logic_op.enabled != cur_state.logic_op.enabled; |
| 262 | if (logic_op_changed) { | 375 | if (logic_op_changed) { |
| 263 | if (logic_op.enabled) { | 376 | if (logic_op.enabled) { |
| 264 | ASSERT(!blend.enabled); | ||
| 265 | glEnable(GL_COLOR_LOGIC_OP); | 377 | glEnable(GL_COLOR_LOGIC_OP); |
| 266 | } else { | 378 | } else { |
| 267 | glDisable(GL_COLOR_LOGIC_OP); | 379 | glDisable(GL_COLOR_LOGIC_OP); |
| @@ -348,12 +460,6 @@ void OpenGLState::Apply() const { | |||
| 348 | if (draw.program_pipeline != cur_state.draw.program_pipeline) { | 460 | if (draw.program_pipeline != cur_state.draw.program_pipeline) { |
| 349 | glBindProgramPipeline(draw.program_pipeline); | 461 | glBindProgramPipeline(draw.program_pipeline); |
| 350 | } | 462 | } |
| 351 | // Viewport | ||
| 352 | if (viewport.x != cur_state.viewport.x || viewport.y != cur_state.viewport.y || | ||
| 353 | viewport.width != cur_state.viewport.width || | ||
| 354 | viewport.height != cur_state.viewport.height) { | ||
| 355 | glViewport(viewport.x, viewport.y, viewport.width, viewport.height); | ||
| 356 | } | ||
| 357 | // Clip distance | 463 | // Clip distance |
| 358 | for (std::size_t i = 0; i < clip_distance.size(); ++i) { | 464 | for (std::size_t i = 0; i < clip_distance.size(); ++i) { |
| 359 | if (clip_distance[i] != cur_state.clip_distance[i]) { | 465 | if (clip_distance[i] != cur_state.clip_distance[i]) { |
| @@ -364,19 +470,13 @@ void OpenGLState::Apply() const { | |||
| 364 | } | 470 | } |
| 365 | } | 471 | } |
| 366 | } | 472 | } |
| 367 | // Color mask | ||
| 368 | if (color_mask.red_enabled != cur_state.color_mask.red_enabled || | ||
| 369 | color_mask.green_enabled != cur_state.color_mask.green_enabled || | ||
| 370 | color_mask.blue_enabled != cur_state.color_mask.blue_enabled || | ||
| 371 | color_mask.alpha_enabled != cur_state.color_mask.alpha_enabled) { | ||
| 372 | glColorMask(color_mask.red_enabled, color_mask.green_enabled, color_mask.blue_enabled, | ||
| 373 | color_mask.alpha_enabled); | ||
| 374 | } | ||
| 375 | // Point | 473 | // Point |
| 376 | if (point.size != cur_state.point.size) { | 474 | if (point.size != cur_state.point.size) { |
| 377 | glPointSize(point.size); | 475 | glPointSize(point.size); |
| 378 | } | 476 | } |
| 379 | ApplyScissorTest(); | 477 | ApplyColorMask(); |
| 478 | ApplyViewport(); | ||
| 479 | ApplyScissor(); | ||
| 380 | ApplyStencilTest(); | 480 | ApplyStencilTest(); |
| 381 | ApplySRgb(); | 481 | ApplySRgb(); |
| 382 | ApplyCulling(); | 482 | ApplyCulling(); |
diff --git a/src/video_core/renderer_opengl/gl_state.h b/src/video_core/renderer_opengl/gl_state.h index fe648aff6..b8cf1f637 100644 --- a/src/video_core/renderer_opengl/gl_state.h +++ b/src/video_core/renderer_opengl/gl_state.h | |||
| @@ -46,11 +46,9 @@ public: | |||
| 46 | } cull; | 46 | } cull; |
| 47 | 47 | ||
| 48 | struct { | 48 | struct { |
| 49 | bool test_enabled; // GL_DEPTH_TEST | 49 | bool test_enabled; // GL_DEPTH_TEST |
| 50 | GLenum test_func; // GL_DEPTH_FUNC | 50 | GLenum test_func; // GL_DEPTH_FUNC |
| 51 | GLboolean write_mask; // GL_DEPTH_WRITEMASK | 51 | GLboolean write_mask; // GL_DEPTH_WRITEMASK |
| 52 | GLfloat depth_range_near; // GL_DEPTH_RANGE | ||
| 53 | GLfloat depth_range_far; // GL_DEPTH_RANGE | ||
| 54 | } depth; | 52 | } depth; |
| 55 | 53 | ||
| 56 | struct { | 54 | struct { |
| @@ -58,13 +56,14 @@ public: | |||
| 58 | GLuint index; | 56 | GLuint index; |
| 59 | } primitive_restart; // GL_PRIMITIVE_RESTART | 57 | } primitive_restart; // GL_PRIMITIVE_RESTART |
| 60 | 58 | ||
| 61 | struct { | 59 | struct ColorMask { |
| 62 | GLboolean red_enabled; | 60 | GLboolean red_enabled; |
| 63 | GLboolean green_enabled; | 61 | GLboolean green_enabled; |
| 64 | GLboolean blue_enabled; | 62 | GLboolean blue_enabled; |
| 65 | GLboolean alpha_enabled; | 63 | GLboolean alpha_enabled; |
| 66 | } color_mask; // GL_COLOR_WRITEMASK | 64 | }; |
| 67 | 65 | std::array<ColorMask, Tegra::Engines::Maxwell3D::Regs::NumRenderTargets> | |
| 66 | color_mask; // GL_COLOR_WRITEMASK | ||
| 68 | struct { | 67 | struct { |
| 69 | bool test_enabled; // GL_STENCIL_TEST | 68 | bool test_enabled; // GL_STENCIL_TEST |
| 70 | struct { | 69 | struct { |
| @@ -78,22 +77,28 @@ public: | |||
| 78 | } front, back; | 77 | } front, back; |
| 79 | } stencil; | 78 | } stencil; |
| 80 | 79 | ||
| 81 | struct { | 80 | struct Blend { |
| 82 | bool enabled; // GL_BLEND | 81 | bool enabled; // GL_BLEND |
| 82 | bool separate_alpha; // Independent blend enabled | ||
| 83 | GLenum rgb_equation; // GL_BLEND_EQUATION_RGB | 83 | GLenum rgb_equation; // GL_BLEND_EQUATION_RGB |
| 84 | GLenum a_equation; // GL_BLEND_EQUATION_ALPHA | 84 | GLenum a_equation; // GL_BLEND_EQUATION_ALPHA |
| 85 | GLenum src_rgb_func; // GL_BLEND_SRC_RGB | 85 | GLenum src_rgb_func; // GL_BLEND_SRC_RGB |
| 86 | GLenum dst_rgb_func; // GL_BLEND_DST_RGB | 86 | GLenum dst_rgb_func; // GL_BLEND_DST_RGB |
| 87 | GLenum src_a_func; // GL_BLEND_SRC_ALPHA | 87 | GLenum src_a_func; // GL_BLEND_SRC_ALPHA |
| 88 | GLenum dst_a_func; // GL_BLEND_DST_ALPHA | 88 | GLenum dst_a_func; // GL_BLEND_DST_ALPHA |
| 89 | }; | ||
| 90 | std::array<Blend, Tegra::Engines::Maxwell3D::Regs::NumRenderTargets> blend; | ||
| 89 | 91 | ||
| 90 | struct { | 92 | struct { |
| 91 | GLclampf red; | 93 | bool enabled; |
| 92 | GLclampf green; | 94 | } independant_blend; |
| 93 | GLclampf blue; | 95 | |
| 94 | GLclampf alpha; | 96 | struct { |
| 95 | } color; // GL_BLEND_COLOR | 97 | GLclampf red; |
| 96 | } blend; | 98 | GLclampf green; |
| 99 | GLclampf blue; | ||
| 100 | GLclampf alpha; | ||
| 101 | } blend_color; // GL_BLEND_COLOR | ||
| 97 | 102 | ||
| 98 | struct { | 103 | struct { |
| 99 | bool enabled; // GL_LOGIC_OP_MODE | 104 | bool enabled; // GL_LOGIC_OP_MODE |
| @@ -138,6 +143,16 @@ public: | |||
| 138 | GLuint program_pipeline; // GL_PROGRAM_PIPELINE_BINDING | 143 | GLuint program_pipeline; // GL_PROGRAM_PIPELINE_BINDING |
| 139 | } draw; | 144 | } draw; |
| 140 | 145 | ||
| 146 | struct viewport { | ||
| 147 | GLfloat x; | ||
| 148 | GLfloat y; | ||
| 149 | GLfloat width; | ||
| 150 | GLfloat height; | ||
| 151 | GLfloat depth_range_near; // GL_DEPTH_RANGE | ||
| 152 | GLfloat depth_range_far; // GL_DEPTH_RANGE | ||
| 153 | }; | ||
| 154 | std::array<viewport, Tegra::Engines::Maxwell3D::Regs::NumRenderTargets> viewports; | ||
| 155 | |||
| 141 | struct { | 156 | struct { |
| 142 | bool enabled; // GL_SCISSOR_TEST | 157 | bool enabled; // GL_SCISSOR_TEST |
| 143 | GLint x; | 158 | GLint x; |
| @@ -147,13 +162,6 @@ public: | |||
| 147 | } scissor; | 162 | } scissor; |
| 148 | 163 | ||
| 149 | struct { | 164 | struct { |
| 150 | GLint x; | ||
| 151 | GLint y; | ||
| 152 | GLsizei width; | ||
| 153 | GLsizei height; | ||
| 154 | } viewport; | ||
| 155 | |||
| 156 | struct { | ||
| 157 | float size; // GL_POINT_SIZE | 165 | float size; // GL_POINT_SIZE |
| 158 | } point; | 166 | } point; |
| 159 | 167 | ||
| @@ -191,14 +199,18 @@ private: | |||
| 191 | static bool s_rgb_used; | 199 | static bool s_rgb_used; |
| 192 | void ApplySRgb() const; | 200 | void ApplySRgb() const; |
| 193 | void ApplyCulling() const; | 201 | void ApplyCulling() const; |
| 202 | void ApplyColorMask() const; | ||
| 194 | void ApplyDepth() const; | 203 | void ApplyDepth() const; |
| 195 | void ApplyPrimitiveRestart() const; | 204 | void ApplyPrimitiveRestart() const; |
| 196 | void ApplyStencilTest() const; | 205 | void ApplyStencilTest() const; |
| 197 | void ApplyScissorTest() const; | 206 | void ApplyViewport() const; |
| 207 | void ApplyTargetBlending(int target, bool force) const; | ||
| 208 | void ApplyGlobalBlending() const; | ||
| 198 | void ApplyBlending() const; | 209 | void ApplyBlending() const; |
| 199 | void ApplyLogicOp() const; | 210 | void ApplyLogicOp() const; |
| 200 | void ApplyTextures() const; | 211 | void ApplyTextures() const; |
| 201 | void ApplySamplers() const; | 212 | void ApplySamplers() const; |
| 213 | void ApplyScissor() const; | ||
| 202 | }; | 214 | }; |
| 203 | 215 | ||
| 204 | } // namespace OpenGL | 216 | } // namespace OpenGL |
diff --git a/src/video_core/renderer_opengl/gl_stream_buffer.cpp b/src/video_core/renderer_opengl/gl_stream_buffer.cpp index e409228cc..b97b895a4 100644 --- a/src/video_core/renderer_opengl/gl_stream_buffer.cpp +++ b/src/video_core/renderer_opengl/gl_stream_buffer.cpp | |||
| @@ -6,9 +6,13 @@ | |||
| 6 | #include <vector> | 6 | #include <vector> |
| 7 | #include "common/alignment.h" | 7 | #include "common/alignment.h" |
| 8 | #include "common/assert.h" | 8 | #include "common/assert.h" |
| 9 | #include "common/microprofile.h" | ||
| 9 | #include "video_core/renderer_opengl/gl_state.h" | 10 | #include "video_core/renderer_opengl/gl_state.h" |
| 10 | #include "video_core/renderer_opengl/gl_stream_buffer.h" | 11 | #include "video_core/renderer_opengl/gl_stream_buffer.h" |
| 11 | 12 | ||
| 13 | MICROPROFILE_DEFINE(OpenGL_StreamBuffer, "OpenGL", "Stream Buffer Orphaning", | ||
| 14 | MP_RGB(128, 128, 192)); | ||
| 15 | |||
| 12 | namespace OpenGL { | 16 | namespace OpenGL { |
| 13 | 17 | ||
| 14 | OGLStreamBuffer::OGLStreamBuffer(GLenum target, GLsizeiptr size, bool prefer_coherent) | 18 | OGLStreamBuffer::OGLStreamBuffer(GLenum target, GLsizeiptr size, bool prefer_coherent) |
| @@ -75,6 +79,7 @@ std::tuple<u8*, GLintptr, bool> OGLStreamBuffer::Map(GLsizeiptr size, GLintptr a | |||
| 75 | } | 79 | } |
| 76 | 80 | ||
| 77 | if (invalidate || !persistent) { | 81 | if (invalidate || !persistent) { |
| 82 | MICROPROFILE_SCOPE(OpenGL_StreamBuffer); | ||
| 78 | GLbitfield flags = GL_MAP_WRITE_BIT | (persistent ? GL_MAP_PERSISTENT_BIT : 0) | | 83 | GLbitfield flags = GL_MAP_WRITE_BIT | (persistent ? GL_MAP_PERSISTENT_BIT : 0) | |
| 79 | (coherent ? GL_MAP_COHERENT_BIT : GL_MAP_FLUSH_EXPLICIT_BIT) | | 84 | (coherent ? GL_MAP_COHERENT_BIT : GL_MAP_FLUSH_EXPLICIT_BIT) | |
| 80 | (invalidate ? GL_MAP_INVALIDATE_BUFFER_BIT : GL_MAP_UNSYNCHRONIZED_BIT); | 85 | (invalidate ? GL_MAP_INVALIDATE_BUFFER_BIT : GL_MAP_UNSYNCHRONIZED_BIT); |
diff --git a/src/yuzu/configuration/configure_general.cpp b/src/yuzu/configuration/configure_general.cpp index 537d6e576..b322258a0 100644 --- a/src/yuzu/configuration/configure_general.cpp +++ b/src/yuzu/configuration/configure_general.cpp | |||
| @@ -3,6 +3,10 @@ | |||
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include "core/core.h" | 5 | #include "core/core.h" |
| 6 | #include "core/hle/service/am/am.h" | ||
| 7 | #include "core/hle/service/am/applet_ae.h" | ||
| 8 | #include "core/hle/service/am/applet_oe.h" | ||
| 9 | #include "core/hle/service/sm/sm.h" | ||
| 6 | #include "core/settings.h" | 10 | #include "core/settings.h" |
| 7 | #include "ui_configure_general.h" | 11 | #include "ui_configure_general.h" |
| 8 | #include "yuzu/configuration/configure_general.h" | 12 | #include "yuzu/configuration/configure_general.h" |
| @@ -20,7 +24,6 @@ ConfigureGeneral::ConfigureGeneral(QWidget* parent) | |||
| 20 | this->setConfiguration(); | 24 | this->setConfiguration(); |
| 21 | 25 | ||
| 22 | ui->use_cpu_jit->setEnabled(!Core::System::GetInstance().IsPoweredOn()); | 26 | ui->use_cpu_jit->setEnabled(!Core::System::GetInstance().IsPoweredOn()); |
| 23 | ui->use_docked_mode->setEnabled(!Core::System::GetInstance().IsPoweredOn()); | ||
| 24 | } | 27 | } |
| 25 | 28 | ||
| 26 | ConfigureGeneral::~ConfigureGeneral() = default; | 29 | ConfigureGeneral::~ConfigureGeneral() = default; |
| @@ -38,6 +41,30 @@ void ConfigureGeneral::PopulateHotkeyList(const HotkeyRegistry& registry) { | |||
| 38 | ui->widget->Populate(registry); | 41 | ui->widget->Populate(registry); |
| 39 | } | 42 | } |
| 40 | 43 | ||
| 44 | void ConfigureGeneral::OnDockedModeChanged(bool last_state, bool new_state) { | ||
| 45 | if (last_state == new_state) { | ||
| 46 | return; | ||
| 47 | } | ||
| 48 | |||
| 49 | Core::System& system{Core::System::GetInstance()}; | ||
| 50 | Service::SM::ServiceManager& sm = system.ServiceManager(); | ||
| 51 | |||
| 52 | // Message queue is shared between these services, we just need to signal an operation | ||
| 53 | // change to one and it will handle both automatically | ||
| 54 | auto applet_oe = sm.GetService<Service::AM::AppletOE>("appletOE"); | ||
| 55 | auto applet_ae = sm.GetService<Service::AM::AppletAE>("appletAE"); | ||
| 56 | bool has_signalled = false; | ||
| 57 | |||
| 58 | if (applet_oe != nullptr) { | ||
| 59 | applet_oe->GetMessageQueue()->OperationModeChanged(); | ||
| 60 | has_signalled = true; | ||
| 61 | } | ||
| 62 | |||
| 63 | if (applet_ae != nullptr && !has_signalled) { | ||
| 64 | applet_ae->GetMessageQueue()->OperationModeChanged(); | ||
| 65 | } | ||
| 66 | } | ||
| 67 | |||
| 41 | void ConfigureGeneral::applyConfiguration() { | 68 | void ConfigureGeneral::applyConfiguration() { |
| 42 | UISettings::values.gamedir_deepscan = ui->toggle_deepscan->isChecked(); | 69 | UISettings::values.gamedir_deepscan = ui->toggle_deepscan->isChecked(); |
| 43 | UISettings::values.confirm_before_closing = ui->toggle_check_exit->isChecked(); | 70 | UISettings::values.confirm_before_closing = ui->toggle_check_exit->isChecked(); |
| @@ -45,6 +72,9 @@ void ConfigureGeneral::applyConfiguration() { | |||
| 45 | ui->theme_combobox->itemData(ui->theme_combobox->currentIndex()).toString(); | 72 | ui->theme_combobox->itemData(ui->theme_combobox->currentIndex()).toString(); |
| 46 | 73 | ||
| 47 | Settings::values.use_cpu_jit = ui->use_cpu_jit->isChecked(); | 74 | Settings::values.use_cpu_jit = ui->use_cpu_jit->isChecked(); |
| 75 | const bool pre_docked_mode = Settings::values.use_docked_mode; | ||
| 48 | Settings::values.use_docked_mode = ui->use_docked_mode->isChecked(); | 76 | Settings::values.use_docked_mode = ui->use_docked_mode->isChecked(); |
| 77 | OnDockedModeChanged(pre_docked_mode, Settings::values.use_docked_mode); | ||
| 78 | |||
| 49 | Settings::values.enable_nfc = ui->enable_nfc->isChecked(); | 79 | Settings::values.enable_nfc = ui->enable_nfc->isChecked(); |
| 50 | } | 80 | } |
diff --git a/src/yuzu/configuration/configure_general.h b/src/yuzu/configuration/configure_general.h index 4770034cc..2210d48da 100644 --- a/src/yuzu/configuration/configure_general.h +++ b/src/yuzu/configuration/configure_general.h | |||
| @@ -25,6 +25,7 @@ public: | |||
| 25 | 25 | ||
| 26 | private: | 26 | private: |
| 27 | void setConfiguration(); | 27 | void setConfiguration(); |
| 28 | void OnDockedModeChanged(bool last_state, bool new_state); | ||
| 28 | 29 | ||
| 29 | std::unique_ptr<Ui::ConfigureGeneral> ui; | 30 | std::unique_ptr<Ui::ConfigureGeneral> ui; |
| 30 | }; | 31 | }; |