diff options
Diffstat (limited to 'src')
| -rw-r--r-- | src/video_core/engines/const_buffer_engine_interface.h | 1 | ||||
| -rw-r--r-- | src/video_core/engines/kepler_compute.cpp | 5 | ||||
| -rw-r--r-- | src/video_core/engines/kepler_compute.h | 2 | ||||
| -rw-r--r-- | src/video_core/engines/maxwell_3d.cpp | 5 | ||||
| -rw-r--r-- | src/video_core/engines/maxwell_3d.h | 2 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/gl_rasterizer.cpp | 16 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/gl_shader_disk_cache.cpp | 64 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/gl_shader_disk_cache.h | 1 | ||||
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_rasterizer.cpp | 11 | ||||
| -rw-r--r-- | src/video_core/shader/decode/texture.cpp | 55 | ||||
| -rw-r--r-- | src/video_core/shader/node.h | 75 | ||||
| -rw-r--r-- | src/video_core/shader/node_helper.h | 2 | ||||
| -rw-r--r-- | src/video_core/shader/registry.cpp | 20 | ||||
| -rw-r--r-- | src/video_core/shader/registry.h | 35 | ||||
| -rw-r--r-- | src/video_core/shader/shader_ir.h | 4 | ||||
| -rw-r--r-- | src/video_core/shader/track.cpp | 24 |
16 files changed, 234 insertions, 88 deletions
diff --git a/src/video_core/engines/const_buffer_engine_interface.h b/src/video_core/engines/const_buffer_engine_interface.h index ebe139504..f46e81bb7 100644 --- a/src/video_core/engines/const_buffer_engine_interface.h +++ b/src/video_core/engines/const_buffer_engine_interface.h | |||
| @@ -93,6 +93,7 @@ public: | |||
| 93 | virtual SamplerDescriptor AccessBoundSampler(ShaderType stage, u64 offset) const = 0; | 93 | virtual SamplerDescriptor AccessBoundSampler(ShaderType stage, u64 offset) const = 0; |
| 94 | virtual SamplerDescriptor AccessBindlessSampler(ShaderType stage, u64 const_buffer, | 94 | virtual SamplerDescriptor AccessBindlessSampler(ShaderType stage, u64 const_buffer, |
| 95 | u64 offset) const = 0; | 95 | u64 offset) const = 0; |
| 96 | virtual SamplerDescriptor AccessSampler(u32 handle) const = 0; | ||
| 96 | virtual u32 GetBoundBuffer() const = 0; | 97 | virtual u32 GetBoundBuffer() const = 0; |
| 97 | 98 | ||
| 98 | virtual VideoCore::GuestDriverProfile& AccessGuestDriverProfile() = 0; | 99 | virtual VideoCore::GuestDriverProfile& AccessGuestDriverProfile() = 0; |
diff --git a/src/video_core/engines/kepler_compute.cpp b/src/video_core/engines/kepler_compute.cpp index f6237fc6a..a82b06a38 100644 --- a/src/video_core/engines/kepler_compute.cpp +++ b/src/video_core/engines/kepler_compute.cpp | |||
| @@ -92,8 +92,11 @@ SamplerDescriptor KeplerCompute::AccessBindlessSampler(ShaderType stage, u64 con | |||
| 92 | ASSERT(stage == ShaderType::Compute); | 92 | ASSERT(stage == ShaderType::Compute); |
| 93 | const auto& tex_info_buffer = launch_description.const_buffer_config[const_buffer]; | 93 | const auto& tex_info_buffer = launch_description.const_buffer_config[const_buffer]; |
| 94 | const GPUVAddr tex_info_address = tex_info_buffer.Address() + offset; | 94 | const GPUVAddr tex_info_address = tex_info_buffer.Address() + offset; |
| 95 | return AccessSampler(memory_manager.Read<u32>(tex_info_address)); | ||
| 96 | } | ||
| 95 | 97 | ||
| 96 | const Texture::TextureHandle tex_handle{memory_manager.Read<u32>(tex_info_address)}; | 98 | SamplerDescriptor KeplerCompute::AccessSampler(u32 handle) const { |
| 99 | const Texture::TextureHandle tex_handle{handle}; | ||
| 97 | const Texture::FullTextureInfo tex_info = GetTextureInfo(tex_handle); | 100 | const Texture::FullTextureInfo tex_info = GetTextureInfo(tex_handle); |
| 98 | SamplerDescriptor result = SamplerDescriptor::FromTIC(tex_info.tic); | 101 | SamplerDescriptor result = SamplerDescriptor::FromTIC(tex_info.tic); |
| 99 | result.is_shadow.Assign(tex_info.tsc.depth_compare_enabled.Value()); | 102 | result.is_shadow.Assign(tex_info.tsc.depth_compare_enabled.Value()); |
diff --git a/src/video_core/engines/kepler_compute.h b/src/video_core/engines/kepler_compute.h index 18ceedfaf..b7f668d88 100644 --- a/src/video_core/engines/kepler_compute.h +++ b/src/video_core/engines/kepler_compute.h | |||
| @@ -219,6 +219,8 @@ public: | |||
| 219 | SamplerDescriptor AccessBindlessSampler(ShaderType stage, u64 const_buffer, | 219 | SamplerDescriptor AccessBindlessSampler(ShaderType stage, u64 const_buffer, |
| 220 | u64 offset) const override; | 220 | u64 offset) const override; |
| 221 | 221 | ||
| 222 | SamplerDescriptor AccessSampler(u32 handle) const override; | ||
| 223 | |||
| 222 | u32 GetBoundBuffer() const override { | 224 | u32 GetBoundBuffer() const override { |
| 223 | return regs.tex_cb_index; | 225 | return regs.tex_cb_index; |
| 224 | } | 226 | } |
diff --git a/src/video_core/engines/maxwell_3d.cpp b/src/video_core/engines/maxwell_3d.cpp index 13ef2e42d..d539ae7b1 100644 --- a/src/video_core/engines/maxwell_3d.cpp +++ b/src/video_core/engines/maxwell_3d.cpp | |||
| @@ -743,8 +743,11 @@ SamplerDescriptor Maxwell3D::AccessBindlessSampler(ShaderType stage, u64 const_b | |||
| 743 | const auto& shader = state.shader_stages[static_cast<std::size_t>(stage)]; | 743 | const auto& shader = state.shader_stages[static_cast<std::size_t>(stage)]; |
| 744 | const auto& tex_info_buffer = shader.const_buffers[const_buffer]; | 744 | const auto& tex_info_buffer = shader.const_buffers[const_buffer]; |
| 745 | const GPUVAddr tex_info_address = tex_info_buffer.address + offset; | 745 | const GPUVAddr tex_info_address = tex_info_buffer.address + offset; |
| 746 | return AccessSampler(memory_manager.Read<u32>(tex_info_address)); | ||
| 747 | } | ||
| 746 | 748 | ||
| 747 | const Texture::TextureHandle tex_handle{memory_manager.Read<u32>(tex_info_address)}; | 749 | SamplerDescriptor Maxwell3D::AccessSampler(u32 handle) const { |
| 750 | const Texture::TextureHandle tex_handle{handle}; | ||
| 748 | const Texture::FullTextureInfo tex_info = GetTextureInfo(tex_handle); | 751 | const Texture::FullTextureInfo tex_info = GetTextureInfo(tex_handle); |
| 749 | SamplerDescriptor result = SamplerDescriptor::FromTIC(tex_info.tic); | 752 | SamplerDescriptor result = SamplerDescriptor::FromTIC(tex_info.tic); |
| 750 | result.is_shadow.Assign(tex_info.tsc.depth_compare_enabled.Value()); | 753 | result.is_shadow.Assign(tex_info.tsc.depth_compare_enabled.Value()); |
diff --git a/src/video_core/engines/maxwell_3d.h b/src/video_core/engines/maxwell_3d.h index 05dd6b39b..c5f1b0499 100644 --- a/src/video_core/engines/maxwell_3d.h +++ b/src/video_core/engines/maxwell_3d.h | |||
| @@ -1403,6 +1403,8 @@ public: | |||
| 1403 | SamplerDescriptor AccessBindlessSampler(ShaderType stage, u64 const_buffer, | 1403 | SamplerDescriptor AccessBindlessSampler(ShaderType stage, u64 const_buffer, |
| 1404 | u64 offset) const override; | 1404 | u64 offset) const override; |
| 1405 | 1405 | ||
| 1406 | SamplerDescriptor AccessSampler(u32 handle) const override; | ||
| 1407 | |||
| 1406 | u32 GetBoundBuffer() const override { | 1408 | u32 GetBoundBuffer() const override { |
| 1407 | return regs.tex_cb_index; | 1409 | return regs.tex_cb_index; |
| 1408 | } | 1410 | } |
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.cpp b/src/video_core/renderer_opengl/gl_rasterizer.cpp index 55e79aaf6..aedcdcb78 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.cpp +++ b/src/video_core/renderer_opengl/gl_rasterizer.cpp | |||
| @@ -65,10 +65,22 @@ constexpr std::size_t NumSupportedVertexAttributes = 16; | |||
| 65 | template <typename Engine, typename Entry> | 65 | template <typename Engine, typename Entry> |
| 66 | Tegra::Texture::FullTextureInfo GetTextureInfo(const Engine& engine, const Entry& entry, | 66 | Tegra::Texture::FullTextureInfo GetTextureInfo(const Engine& engine, const Entry& entry, |
| 67 | ShaderType shader_type, std::size_t index = 0) { | 67 | ShaderType shader_type, std::size_t index = 0) { |
| 68 | if constexpr (std::is_same_v<Entry, SamplerEntry>) { | ||
| 69 | if (entry.is_separated) { | ||
| 70 | const u32 buffer_1 = entry.buffer; | ||
| 71 | const u32 buffer_2 = entry.secondary_buffer; | ||
| 72 | const u32 offset_1 = entry.offset; | ||
| 73 | const u32 offset_2 = entry.secondary_offset; | ||
| 74 | const u32 handle_1 = engine.AccessConstBuffer32(shader_type, buffer_1, offset_1); | ||
| 75 | const u32 handle_2 = engine.AccessConstBuffer32(shader_type, buffer_2, offset_2); | ||
| 76 | return engine.GetTextureInfo(handle_1 | handle_2); | ||
| 77 | } | ||
| 78 | } | ||
| 68 | if (entry.is_bindless) { | 79 | if (entry.is_bindless) { |
| 69 | const auto tex_handle = engine.AccessConstBuffer32(shader_type, entry.buffer, entry.offset); | 80 | const u32 handle = engine.AccessConstBuffer32(shader_type, entry.buffer, entry.offset); |
| 70 | return engine.GetTextureInfo(tex_handle); | 81 | return engine.GetTextureInfo(handle); |
| 71 | } | 82 | } |
| 83 | |||
| 72 | const auto& gpu_profile = engine.AccessGuestDriverProfile(); | 84 | const auto& gpu_profile = engine.AccessGuestDriverProfile(); |
| 73 | const u32 offset = entry.offset + static_cast<u32>(index * gpu_profile.GetTextureHandlerSize()); | 85 | const u32 offset = entry.offset + static_cast<u32>(index * gpu_profile.GetTextureHandlerSize()); |
| 74 | if constexpr (std::is_same_v<Engine, Tegra::Engines::Maxwell3D>) { | 86 | if constexpr (std::is_same_v<Engine, Tegra::Engines::Maxwell3D>) { |
diff --git a/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp b/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp index 9e95a122b..653c3f2f9 100644 --- a/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp +++ b/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp | |||
| @@ -29,6 +29,8 @@ using VideoCommon::Shader::KeyMap; | |||
| 29 | 29 | ||
| 30 | namespace { | 30 | namespace { |
| 31 | 31 | ||
| 32 | using VideoCommon::Shader::SeparateSamplerKey; | ||
| 33 | |||
| 32 | using ShaderCacheVersionHash = std::array<u8, 64>; | 34 | using ShaderCacheVersionHash = std::array<u8, 64>; |
| 33 | 35 | ||
| 34 | struct ConstBufferKey { | 36 | struct ConstBufferKey { |
| @@ -37,18 +39,26 @@ struct ConstBufferKey { | |||
| 37 | u32 value = 0; | 39 | u32 value = 0; |
| 38 | }; | 40 | }; |
| 39 | 41 | ||
| 40 | struct BoundSamplerKey { | 42 | struct BoundSamplerEntry { |
| 41 | u32 offset = 0; | 43 | u32 offset = 0; |
| 42 | Tegra::Engines::SamplerDescriptor sampler; | 44 | Tegra::Engines::SamplerDescriptor sampler; |
| 43 | }; | 45 | }; |
| 44 | 46 | ||
| 45 | struct BindlessSamplerKey { | 47 | struct SeparateSamplerEntry { |
| 48 | u32 cbuf1 = 0; | ||
| 49 | u32 cbuf2 = 0; | ||
| 50 | u32 offset1 = 0; | ||
| 51 | u32 offset2 = 0; | ||
| 52 | Tegra::Engines::SamplerDescriptor sampler; | ||
| 53 | }; | ||
| 54 | |||
| 55 | struct BindlessSamplerEntry { | ||
| 46 | u32 cbuf = 0; | 56 | u32 cbuf = 0; |
| 47 | u32 offset = 0; | 57 | u32 offset = 0; |
| 48 | Tegra::Engines::SamplerDescriptor sampler; | 58 | Tegra::Engines::SamplerDescriptor sampler; |
| 49 | }; | 59 | }; |
| 50 | 60 | ||
| 51 | constexpr u32 NativeVersion = 20; | 61 | constexpr u32 NativeVersion = 21; |
| 52 | 62 | ||
| 53 | ShaderCacheVersionHash GetShaderCacheVersionHash() { | 63 | ShaderCacheVersionHash GetShaderCacheVersionHash() { |
| 54 | ShaderCacheVersionHash hash{}; | 64 | ShaderCacheVersionHash hash{}; |
| @@ -87,12 +97,14 @@ bool ShaderDiskCacheEntry::Load(FileUtil::IOFile& file) { | |||
| 87 | u32 texture_handler_size_value; | 97 | u32 texture_handler_size_value; |
| 88 | u32 num_keys; | 98 | u32 num_keys; |
| 89 | u32 num_bound_samplers; | 99 | u32 num_bound_samplers; |
| 100 | u32 num_separate_samplers; | ||
| 90 | u32 num_bindless_samplers; | 101 | u32 num_bindless_samplers; |
| 91 | if (file.ReadArray(&unique_identifier, 1) != 1 || file.ReadArray(&bound_buffer, 1) != 1 || | 102 | if (file.ReadArray(&unique_identifier, 1) != 1 || file.ReadArray(&bound_buffer, 1) != 1 || |
| 92 | file.ReadArray(&is_texture_handler_size_known, 1) != 1 || | 103 | file.ReadArray(&is_texture_handler_size_known, 1) != 1 || |
| 93 | file.ReadArray(&texture_handler_size_value, 1) != 1 || | 104 | file.ReadArray(&texture_handler_size_value, 1) != 1 || |
| 94 | file.ReadArray(&graphics_info, 1) != 1 || file.ReadArray(&compute_info, 1) != 1 || | 105 | file.ReadArray(&graphics_info, 1) != 1 || file.ReadArray(&compute_info, 1) != 1 || |
| 95 | file.ReadArray(&num_keys, 1) != 1 || file.ReadArray(&num_bound_samplers, 1) != 1 || | 106 | file.ReadArray(&num_keys, 1) != 1 || file.ReadArray(&num_bound_samplers, 1) != 1 || |
| 107 | file.ReadArray(&num_separate_samplers, 1) != 1 || | ||
| 96 | file.ReadArray(&num_bindless_samplers, 1) != 1) { | 108 | file.ReadArray(&num_bindless_samplers, 1) != 1) { |
| 97 | return false; | 109 | return false; |
| 98 | } | 110 | } |
| @@ -101,23 +113,32 @@ bool ShaderDiskCacheEntry::Load(FileUtil::IOFile& file) { | |||
| 101 | } | 113 | } |
| 102 | 114 | ||
| 103 | std::vector<ConstBufferKey> flat_keys(num_keys); | 115 | std::vector<ConstBufferKey> flat_keys(num_keys); |
| 104 | std::vector<BoundSamplerKey> flat_bound_samplers(num_bound_samplers); | 116 | std::vector<BoundSamplerEntry> flat_bound_samplers(num_bound_samplers); |
| 105 | std::vector<BindlessSamplerKey> flat_bindless_samplers(num_bindless_samplers); | 117 | std::vector<SeparateSamplerEntry> flat_separate_samplers(num_separate_samplers); |
| 118 | std::vector<BindlessSamplerEntry> flat_bindless_samplers(num_bindless_samplers); | ||
| 106 | if (file.ReadArray(flat_keys.data(), flat_keys.size()) != flat_keys.size() || | 119 | if (file.ReadArray(flat_keys.data(), flat_keys.size()) != flat_keys.size() || |
| 107 | file.ReadArray(flat_bound_samplers.data(), flat_bound_samplers.size()) != | 120 | file.ReadArray(flat_bound_samplers.data(), flat_bound_samplers.size()) != |
| 108 | flat_bound_samplers.size() || | 121 | flat_bound_samplers.size() || |
| 122 | file.ReadArray(flat_separate_samplers.data(), flat_separate_samplers.size()) != | ||
| 123 | flat_separate_samplers.size() || | ||
| 109 | file.ReadArray(flat_bindless_samplers.data(), flat_bindless_samplers.size()) != | 124 | file.ReadArray(flat_bindless_samplers.data(), flat_bindless_samplers.size()) != |
| 110 | flat_bindless_samplers.size()) { | 125 | flat_bindless_samplers.size()) { |
| 111 | return false; | 126 | return false; |
| 112 | } | 127 | } |
| 113 | for (const auto& key : flat_keys) { | 128 | for (const auto& entry : flat_keys) { |
| 114 | keys.insert({{key.cbuf, key.offset}, key.value}); | 129 | keys.insert({{entry.cbuf, entry.offset}, entry.value}); |
| 115 | } | 130 | } |
| 116 | for (const auto& key : flat_bound_samplers) { | 131 | for (const auto& entry : flat_bound_samplers) { |
| 117 | bound_samplers.emplace(key.offset, key.sampler); | 132 | bound_samplers.emplace(entry.offset, entry.sampler); |
| 118 | } | 133 | } |
| 119 | for (const auto& key : flat_bindless_samplers) { | 134 | for (const auto& entry : flat_separate_samplers) { |
| 120 | bindless_samplers.insert({{key.cbuf, key.offset}, key.sampler}); | 135 | SeparateSamplerKey key; |
| 136 | key.buffers = {entry.cbuf1, entry.cbuf2}; | ||
| 137 | key.offsets = {entry.offset1, entry.offset2}; | ||
| 138 | separate_samplers.emplace(key, entry.sampler); | ||
| 139 | } | ||
| 140 | for (const auto& entry : flat_bindless_samplers) { | ||
| 141 | bindless_samplers.insert({{entry.cbuf, entry.offset}, entry.sampler}); | ||
| 121 | } | 142 | } |
| 122 | 143 | ||
| 123 | return true; | 144 | return true; |
| @@ -142,6 +163,7 @@ bool ShaderDiskCacheEntry::Save(FileUtil::IOFile& file) const { | |||
| 142 | file.WriteObject(graphics_info) != 1 || file.WriteObject(compute_info) != 1 || | 163 | file.WriteObject(graphics_info) != 1 || file.WriteObject(compute_info) != 1 || |
| 143 | file.WriteObject(static_cast<u32>(keys.size())) != 1 || | 164 | file.WriteObject(static_cast<u32>(keys.size())) != 1 || |
| 144 | file.WriteObject(static_cast<u32>(bound_samplers.size())) != 1 || | 165 | file.WriteObject(static_cast<u32>(bound_samplers.size())) != 1 || |
| 166 | file.WriteObject(static_cast<u32>(separate_samplers.size())) != 1 || | ||
| 145 | file.WriteObject(static_cast<u32>(bindless_samplers.size())) != 1) { | 167 | file.WriteObject(static_cast<u32>(bindless_samplers.size())) != 1) { |
| 146 | return false; | 168 | return false; |
| 147 | } | 169 | } |
| @@ -152,22 +174,34 @@ bool ShaderDiskCacheEntry::Save(FileUtil::IOFile& file) const { | |||
| 152 | flat_keys.push_back(ConstBufferKey{address.first, address.second, value}); | 174 | flat_keys.push_back(ConstBufferKey{address.first, address.second, value}); |
| 153 | } | 175 | } |
| 154 | 176 | ||
| 155 | std::vector<BoundSamplerKey> flat_bound_samplers; | 177 | std::vector<BoundSamplerEntry> flat_bound_samplers; |
| 156 | flat_bound_samplers.reserve(bound_samplers.size()); | 178 | flat_bound_samplers.reserve(bound_samplers.size()); |
| 157 | for (const auto& [address, sampler] : bound_samplers) { | 179 | for (const auto& [address, sampler] : bound_samplers) { |
| 158 | flat_bound_samplers.push_back(BoundSamplerKey{address, sampler}); | 180 | flat_bound_samplers.push_back(BoundSamplerEntry{address, sampler}); |
| 181 | } | ||
| 182 | |||
| 183 | std::vector<SeparateSamplerEntry> flat_separate_samplers; | ||
| 184 | flat_separate_samplers.reserve(separate_samplers.size()); | ||
| 185 | for (const auto& [key, sampler] : separate_samplers) { | ||
| 186 | SeparateSamplerEntry entry; | ||
| 187 | std::tie(entry.cbuf1, entry.cbuf2) = key.buffers; | ||
| 188 | std::tie(entry.offset1, entry.offset2) = key.offsets; | ||
| 189 | entry.sampler = sampler; | ||
| 190 | flat_separate_samplers.push_back(entry); | ||
| 159 | } | 191 | } |
| 160 | 192 | ||
| 161 | std::vector<BindlessSamplerKey> flat_bindless_samplers; | 193 | std::vector<BindlessSamplerEntry> flat_bindless_samplers; |
| 162 | flat_bindless_samplers.reserve(bindless_samplers.size()); | 194 | flat_bindless_samplers.reserve(bindless_samplers.size()); |
| 163 | for (const auto& [address, sampler] : bindless_samplers) { | 195 | for (const auto& [address, sampler] : bindless_samplers) { |
| 164 | flat_bindless_samplers.push_back( | 196 | flat_bindless_samplers.push_back( |
| 165 | BindlessSamplerKey{address.first, address.second, sampler}); | 197 | BindlessSamplerEntry{address.first, address.second, sampler}); |
| 166 | } | 198 | } |
| 167 | 199 | ||
| 168 | return file.WriteArray(flat_keys.data(), flat_keys.size()) == flat_keys.size() && | 200 | return file.WriteArray(flat_keys.data(), flat_keys.size()) == flat_keys.size() && |
| 169 | file.WriteArray(flat_bound_samplers.data(), flat_bound_samplers.size()) == | 201 | file.WriteArray(flat_bound_samplers.data(), flat_bound_samplers.size()) == |
| 170 | flat_bound_samplers.size() && | 202 | flat_bound_samplers.size() && |
| 203 | file.WriteArray(flat_separate_samplers.data(), flat_separate_samplers.size()) == | ||
| 204 | flat_separate_samplers.size() && | ||
| 171 | file.WriteArray(flat_bindless_samplers.data(), flat_bindless_samplers.size()) == | 205 | file.WriteArray(flat_bindless_samplers.data(), flat_bindless_samplers.size()) == |
| 172 | flat_bindless_samplers.size(); | 206 | flat_bindless_samplers.size(); |
| 173 | } | 207 | } |
diff --git a/src/video_core/renderer_opengl/gl_shader_disk_cache.h b/src/video_core/renderer_opengl/gl_shader_disk_cache.h index d5be52e40..a79cef0e9 100644 --- a/src/video_core/renderer_opengl/gl_shader_disk_cache.h +++ b/src/video_core/renderer_opengl/gl_shader_disk_cache.h | |||
| @@ -57,6 +57,7 @@ struct ShaderDiskCacheEntry { | |||
| 57 | VideoCommon::Shader::ComputeInfo compute_info; | 57 | VideoCommon::Shader::ComputeInfo compute_info; |
| 58 | VideoCommon::Shader::KeyMap keys; | 58 | VideoCommon::Shader::KeyMap keys; |
| 59 | VideoCommon::Shader::BoundSamplerMap bound_samplers; | 59 | VideoCommon::Shader::BoundSamplerMap bound_samplers; |
| 60 | VideoCommon::Shader::SeparateSamplerMap separate_samplers; | ||
| 60 | VideoCommon::Shader::BindlessSamplerMap bindless_samplers; | 61 | VideoCommon::Shader::BindlessSamplerMap bindless_samplers; |
| 61 | }; | 62 | }; |
| 62 | 63 | ||
diff --git a/src/video_core/renderer_vulkan/vk_rasterizer.cpp b/src/video_core/renderer_vulkan/vk_rasterizer.cpp index a3d992ed3..42a20530d 100644 --- a/src/video_core/renderer_vulkan/vk_rasterizer.cpp +++ b/src/video_core/renderer_vulkan/vk_rasterizer.cpp | |||
| @@ -117,6 +117,17 @@ template <typename Engine, typename Entry> | |||
| 117 | Tegra::Texture::FullTextureInfo GetTextureInfo(const Engine& engine, const Entry& entry, | 117 | Tegra::Texture::FullTextureInfo GetTextureInfo(const Engine& engine, const Entry& entry, |
| 118 | std::size_t stage, std::size_t index = 0) { | 118 | std::size_t stage, std::size_t index = 0) { |
| 119 | const auto stage_type = static_cast<Tegra::Engines::ShaderType>(stage); | 119 | const auto stage_type = static_cast<Tegra::Engines::ShaderType>(stage); |
| 120 | if constexpr (std::is_same_v<Entry, SamplerEntry>) { | ||
| 121 | if (entry.is_separated) { | ||
| 122 | const u32 buffer_1 = entry.buffer; | ||
| 123 | const u32 buffer_2 = entry.secondary_buffer; | ||
| 124 | const u32 offset_1 = entry.offset; | ||
| 125 | const u32 offset_2 = entry.secondary_offset; | ||
| 126 | const u32 handle_1 = engine.AccessConstBuffer32(stage_type, buffer_1, offset_1); | ||
| 127 | const u32 handle_2 = engine.AccessConstBuffer32(stage_type, buffer_2, offset_2); | ||
| 128 | return engine.GetTextureInfo(handle_1 | handle_2); | ||
| 129 | } | ||
| 130 | } | ||
| 120 | if (entry.is_bindless) { | 131 | if (entry.is_bindless) { |
| 121 | const auto tex_handle = engine.AccessConstBuffer32(stage_type, entry.buffer, entry.offset); | 132 | const auto tex_handle = engine.AccessConstBuffer32(stage_type, entry.buffer, entry.offset); |
| 122 | return engine.GetTextureInfo(tex_handle); | 133 | return engine.GetTextureInfo(tex_handle); |
diff --git a/src/video_core/shader/decode/texture.cpp b/src/video_core/shader/decode/texture.cpp index 8f0bb996e..29ebf65ba 100644 --- a/src/video_core/shader/decode/texture.cpp +++ b/src/video_core/shader/decode/texture.cpp | |||
| @@ -357,13 +357,11 @@ u32 ShaderIR::DecodeTexture(NodeBlock& bb, u32 pc) { | |||
| 357 | return pc; | 357 | return pc; |
| 358 | } | 358 | } |
| 359 | 359 | ||
| 360 | ShaderIR::SamplerInfo ShaderIR::GetSamplerInfo(SamplerInfo info, u32 offset, | 360 | ShaderIR::SamplerInfo ShaderIR::GetSamplerInfo( |
| 361 | std::optional<u32> buffer) { | 361 | SamplerInfo info, std::optional<Tegra::Engines::SamplerDescriptor> sampler) { |
| 362 | if (info.IsComplete()) { | 362 | if (info.IsComplete()) { |
| 363 | return info; | 363 | return info; |
| 364 | } | 364 | } |
| 365 | const auto sampler = buffer ? registry.ObtainBindlessSampler(*buffer, offset) | ||
| 366 | : registry.ObtainBoundSampler(offset); | ||
| 367 | if (!sampler) { | 365 | if (!sampler) { |
| 368 | LOG_WARNING(HW_GPU, "Unknown sampler info"); | 366 | LOG_WARNING(HW_GPU, "Unknown sampler info"); |
| 369 | info.type = info.type.value_or(Tegra::Shader::TextureType::Texture2D); | 367 | info.type = info.type.value_or(Tegra::Shader::TextureType::Texture2D); |
| @@ -381,8 +379,8 @@ ShaderIR::SamplerInfo ShaderIR::GetSamplerInfo(SamplerInfo info, u32 offset, | |||
| 381 | 379 | ||
| 382 | std::optional<Sampler> ShaderIR::GetSampler(Tegra::Shader::Sampler sampler, | 380 | std::optional<Sampler> ShaderIR::GetSampler(Tegra::Shader::Sampler sampler, |
| 383 | SamplerInfo sampler_info) { | 381 | SamplerInfo sampler_info) { |
| 384 | const auto offset = static_cast<u32>(sampler.index.Value()); | 382 | const u32 offset = static_cast<u32>(sampler.index.Value()); |
| 385 | const auto info = GetSamplerInfo(sampler_info, offset); | 383 | const auto info = GetSamplerInfo(sampler_info, registry.ObtainBoundSampler(offset)); |
| 386 | 384 | ||
| 387 | // If this sampler has already been used, return the existing mapping. | 385 | // If this sampler has already been used, return the existing mapping. |
| 388 | const auto it = std::find_if(used_samplers.begin(), used_samplers.end(), | 386 | const auto it = std::find_if(used_samplers.begin(), used_samplers.end(), |
| @@ -404,20 +402,19 @@ std::optional<Sampler> ShaderIR::GetBindlessSampler(Tegra::Shader::Register reg, | |||
| 404 | const Node sampler_register = GetRegister(reg); | 402 | const Node sampler_register = GetRegister(reg); |
| 405 | const auto [base_node, tracked_sampler_info] = | 403 | const auto [base_node, tracked_sampler_info] = |
| 406 | TrackBindlessSampler(sampler_register, global_code, static_cast<s64>(global_code.size())); | 404 | TrackBindlessSampler(sampler_register, global_code, static_cast<s64>(global_code.size())); |
| 407 | ASSERT(base_node != nullptr); | 405 | if (!base_node) { |
| 408 | if (base_node == nullptr) { | 406 | UNREACHABLE(); |
| 409 | return std::nullopt; | 407 | return std::nullopt; |
| 410 | } | 408 | } |
| 411 | 409 | ||
| 412 | if (const auto bindless_sampler_info = | 410 | if (const auto sampler_info = std::get_if<BindlessSamplerNode>(&*tracked_sampler_info)) { |
| 413 | std::get_if<BindlessSamplerNode>(&*tracked_sampler_info)) { | 411 | const u32 buffer = sampler_info->index; |
| 414 | const u32 buffer = bindless_sampler_info->GetIndex(); | 412 | const u32 offset = sampler_info->offset; |
| 415 | const u32 offset = bindless_sampler_info->GetOffset(); | 413 | info = GetSamplerInfo(info, registry.ObtainBindlessSampler(buffer, offset)); |
| 416 | info = GetSamplerInfo(info, offset, buffer); | ||
| 417 | 414 | ||
| 418 | // If this sampler has already been used, return the existing mapping. | 415 | // If this sampler has already been used, return the existing mapping. |
| 419 | const auto it = std::find_if(used_samplers.begin(), used_samplers.end(), | 416 | const auto it = std::find_if(used_samplers.begin(), used_samplers.end(), |
| 420 | [buffer = buffer, offset = offset](const Sampler& entry) { | 417 | [buffer, offset](const Sampler& entry) { |
| 421 | return entry.buffer == buffer && entry.offset == offset; | 418 | return entry.buffer == buffer && entry.offset == offset; |
| 422 | }); | 419 | }); |
| 423 | if (it != used_samplers.end()) { | 420 | if (it != used_samplers.end()) { |
| @@ -431,10 +428,32 @@ std::optional<Sampler> ShaderIR::GetBindlessSampler(Tegra::Shader::Register reg, | |||
| 431 | return used_samplers.emplace_back(next_index, offset, buffer, *info.type, *info.is_array, | 428 | return used_samplers.emplace_back(next_index, offset, buffer, *info.type, *info.is_array, |
| 432 | *info.is_shadow, *info.is_buffer, false); | 429 | *info.is_shadow, *info.is_buffer, false); |
| 433 | } | 430 | } |
| 434 | if (const auto array_sampler_info = std::get_if<ArraySamplerNode>(&*tracked_sampler_info)) { | 431 | if (const auto sampler_info = std::get_if<SeparateSamplerNode>(&*tracked_sampler_info)) { |
| 435 | const u32 base_offset = array_sampler_info->GetBaseOffset() / 4; | 432 | const std::pair indices = sampler_info->indices; |
| 436 | index_var = GetCustomVariable(array_sampler_info->GetIndexVar()); | 433 | const std::pair offsets = sampler_info->offsets; |
| 437 | info = GetSamplerInfo(info, base_offset); | 434 | info = GetSamplerInfo(info, registry.ObtainSeparateSampler(indices, offsets)); |
| 435 | |||
| 436 | // Try to use an already created sampler if it exists | ||
| 437 | const auto it = std::find_if( | ||
| 438 | used_samplers.begin(), used_samplers.end(), [indices, offsets](const Sampler& entry) { | ||
| 439 | return offsets == std::pair{entry.offset, entry.secondary_offset} && | ||
| 440 | indices == std::pair{entry.buffer, entry.secondary_buffer}; | ||
| 441 | }); | ||
| 442 | if (it != used_samplers.end()) { | ||
| 443 | ASSERT(it->is_separated && it->type == info.type && it->is_array == info.is_array && | ||
| 444 | it->is_shadow == info.is_shadow && it->is_buffer == info.is_buffer); | ||
| 445 | return *it; | ||
| 446 | } | ||
| 447 | |||
| 448 | // Otherwise create a new mapping for this sampler | ||
| 449 | const u32 next_index = static_cast<u32>(used_samplers.size()); | ||
| 450 | return used_samplers.emplace_back(next_index, offsets, indices, *info.type, *info.is_array, | ||
| 451 | *info.is_shadow, *info.is_buffer); | ||
| 452 | } | ||
| 453 | if (const auto sampler_info = std::get_if<ArraySamplerNode>(&*tracked_sampler_info)) { | ||
| 454 | const u32 base_offset = sampler_info->base_offset / 4; | ||
| 455 | index_var = GetCustomVariable(sampler_info->bindless_var); | ||
| 456 | info = GetSamplerInfo(info, registry.ObtainBoundSampler(base_offset)); | ||
| 438 | 457 | ||
| 439 | // If this sampler has already been used, return the existing mapping. | 458 | // If this sampler has already been used, return the existing mapping. |
| 440 | const auto it = std::find_if( | 459 | const auto it = std::find_if( |
diff --git a/src/video_core/shader/node.h b/src/video_core/shader/node.h index c5e5165ff..8f230d57a 100644 --- a/src/video_core/shader/node.h +++ b/src/video_core/shader/node.h | |||
| @@ -275,10 +275,11 @@ using Node = std::shared_ptr<NodeData>; | |||
| 275 | using Node4 = std::array<Node, 4>; | 275 | using Node4 = std::array<Node, 4>; |
| 276 | using NodeBlock = std::vector<Node>; | 276 | using NodeBlock = std::vector<Node>; |
| 277 | 277 | ||
| 278 | class BindlessSamplerNode; | 278 | struct ArraySamplerNode; |
| 279 | class ArraySamplerNode; | 279 | struct BindlessSamplerNode; |
| 280 | struct SeparateSamplerNode; | ||
| 280 | 281 | ||
| 281 | using TrackSamplerData = std::variant<BindlessSamplerNode, ArraySamplerNode>; | 282 | using TrackSamplerData = std::variant<BindlessSamplerNode, SeparateSamplerNode, ArraySamplerNode>; |
| 282 | using TrackSampler = std::shared_ptr<TrackSamplerData>; | 283 | using TrackSampler = std::shared_ptr<TrackSamplerData>; |
| 283 | 284 | ||
| 284 | struct Sampler { | 285 | struct Sampler { |
| @@ -288,63 +289,51 @@ struct Sampler { | |||
| 288 | : index{index}, offset{offset}, type{type}, is_array{is_array}, is_shadow{is_shadow}, | 289 | : index{index}, offset{offset}, type{type}, is_array{is_array}, is_shadow{is_shadow}, |
| 289 | is_buffer{is_buffer}, is_indexed{is_indexed} {} | 290 | is_buffer{is_buffer}, is_indexed{is_indexed} {} |
| 290 | 291 | ||
| 292 | /// Separate sampler constructor | ||
| 293 | constexpr explicit Sampler(u32 index, std::pair<u32, u32> offsets, std::pair<u32, u32> buffers, | ||
| 294 | Tegra::Shader::TextureType type, bool is_array, bool is_shadow, | ||
| 295 | bool is_buffer) | ||
| 296 | : index{index}, offset{offsets.first}, secondary_offset{offsets.second}, | ||
| 297 | buffer{buffers.first}, secondary_buffer{buffers.second}, type{type}, is_array{is_array}, | ||
| 298 | is_shadow{is_shadow}, is_buffer{is_buffer}, is_separated{true} {} | ||
| 299 | |||
| 291 | /// Bindless samplers constructor | 300 | /// Bindless samplers constructor |
| 292 | constexpr explicit Sampler(u32 index, u32 offset, u32 buffer, Tegra::Shader::TextureType type, | 301 | constexpr explicit Sampler(u32 index, u32 offset, u32 buffer, Tegra::Shader::TextureType type, |
| 293 | bool is_array, bool is_shadow, bool is_buffer, bool is_indexed) | 302 | bool is_array, bool is_shadow, bool is_buffer, bool is_indexed) |
| 294 | : index{index}, offset{offset}, buffer{buffer}, type{type}, is_array{is_array}, | 303 | : index{index}, offset{offset}, buffer{buffer}, type{type}, is_array{is_array}, |
| 295 | is_shadow{is_shadow}, is_buffer{is_buffer}, is_bindless{true}, is_indexed{is_indexed} {} | 304 | is_shadow{is_shadow}, is_buffer{is_buffer}, is_bindless{true}, is_indexed{is_indexed} {} |
| 296 | 305 | ||
| 297 | u32 index = 0; ///< Emulated index given for the this sampler. | 306 | u32 index = 0; ///< Emulated index given for the this sampler. |
| 298 | u32 offset = 0; ///< Offset in the const buffer from where the sampler is being read. | 307 | u32 offset = 0; ///< Offset in the const buffer from where the sampler is being read. |
| 299 | u32 buffer = 0; ///< Buffer where the bindless sampler is being read (unused on bound samplers). | 308 | u32 secondary_offset = 0; ///< Secondary offset in the const buffer. |
| 300 | u32 size = 1; ///< Size of the sampler. | 309 | u32 buffer = 0; ///< Buffer where the bindless sampler is read. |
| 310 | u32 secondary_buffer = 0; ///< Secondary buffer where the bindless sampler is read. | ||
| 311 | u32 size = 1; ///< Size of the sampler. | ||
| 301 | 312 | ||
| 302 | Tegra::Shader::TextureType type{}; ///< The type used to sample this texture (Texture2D, etc) | 313 | Tegra::Shader::TextureType type{}; ///< The type used to sample this texture (Texture2D, etc) |
| 303 | bool is_array = false; ///< Whether the texture is being sampled as an array texture or not. | 314 | bool is_array = false; ///< Whether the texture is being sampled as an array texture or not. |
| 304 | bool is_shadow = false; ///< Whether the texture is being sampled as a depth texture or not. | 315 | bool is_shadow = false; ///< Whether the texture is being sampled as a depth texture or not. |
| 305 | bool is_buffer = false; ///< Whether the texture is a texture buffer without sampler. | 316 | bool is_buffer = false; ///< Whether the texture is a texture buffer without sampler. |
| 306 | bool is_bindless = false; ///< Whether this sampler belongs to a bindless texture or not. | 317 | bool is_bindless = false; ///< Whether this sampler belongs to a bindless texture or not. |
| 307 | bool is_indexed = false; ///< Whether this sampler is an indexed array of textures. | 318 | bool is_indexed = false; ///< Whether this sampler is an indexed array of textures. |
| 319 | bool is_separated = false; ///< Whether the image and sampler is separated or not. | ||
| 308 | }; | 320 | }; |
| 309 | 321 | ||
| 310 | /// Represents a tracked bindless sampler into a direct const buffer | 322 | /// Represents a tracked bindless sampler into a direct const buffer |
| 311 | class ArraySamplerNode final { | 323 | struct ArraySamplerNode { |
| 312 | public: | ||
| 313 | explicit ArraySamplerNode(u32 index, u32 base_offset, u32 bindless_var) | ||
| 314 | : index{index}, base_offset{base_offset}, bindless_var{bindless_var} {} | ||
| 315 | |||
| 316 | constexpr u32 GetIndex() const { | ||
| 317 | return index; | ||
| 318 | } | ||
| 319 | |||
| 320 | constexpr u32 GetBaseOffset() const { | ||
| 321 | return base_offset; | ||
| 322 | } | ||
| 323 | |||
| 324 | constexpr u32 GetIndexVar() const { | ||
| 325 | return bindless_var; | ||
| 326 | } | ||
| 327 | |||
| 328 | private: | ||
| 329 | u32 index; | 324 | u32 index; |
| 330 | u32 base_offset; | 325 | u32 base_offset; |
| 331 | u32 bindless_var; | 326 | u32 bindless_var; |
| 332 | }; | 327 | }; |
| 333 | 328 | ||
| 334 | /// Represents a tracked bindless sampler into a direct const buffer | 329 | /// Represents a tracked separate sampler image pair that was folded statically |
| 335 | class BindlessSamplerNode final { | 330 | struct SeparateSamplerNode { |
| 336 | public: | 331 | std::pair<u32, u32> indices; |
| 337 | explicit BindlessSamplerNode(u32 index, u32 offset) : index{index}, offset{offset} {} | 332 | std::pair<u32, u32> offsets; |
| 338 | 333 | }; | |
| 339 | constexpr u32 GetIndex() const { | ||
| 340 | return index; | ||
| 341 | } | ||
| 342 | |||
| 343 | constexpr u32 GetOffset() const { | ||
| 344 | return offset; | ||
| 345 | } | ||
| 346 | 334 | ||
| 347 | private: | 335 | /// Represents a tracked bindless sampler into a direct const buffer |
| 336 | struct BindlessSamplerNode { | ||
| 348 | u32 index; | 337 | u32 index; |
| 349 | u32 offset; | 338 | u32 offset; |
| 350 | }; | 339 | }; |
diff --git a/src/video_core/shader/node_helper.h b/src/video_core/shader/node_helper.h index 11231bbea..1e0886185 100644 --- a/src/video_core/shader/node_helper.h +++ b/src/video_core/shader/node_helper.h | |||
| @@ -48,7 +48,7 @@ Node MakeNode(Args&&... args) { | |||
| 48 | template <typename T, typename... Args> | 48 | template <typename T, typename... Args> |
| 49 | TrackSampler MakeTrackSampler(Args&&... args) { | 49 | TrackSampler MakeTrackSampler(Args&&... args) { |
| 50 | static_assert(std::is_convertible_v<T, TrackSamplerData>); | 50 | static_assert(std::is_convertible_v<T, TrackSamplerData>); |
| 51 | return std::make_shared<TrackSamplerData>(T(std::forward<Args>(args)...)); | 51 | return std::make_shared<TrackSamplerData>(T{std::forward<Args>(args)...}); |
| 52 | } | 52 | } |
| 53 | 53 | ||
| 54 | template <typename... Args> | 54 | template <typename... Args> |
diff --git a/src/video_core/shader/registry.cpp b/src/video_core/shader/registry.cpp index af70b3f35..cdf274e54 100644 --- a/src/video_core/shader/registry.cpp +++ b/src/video_core/shader/registry.cpp | |||
| @@ -93,6 +93,26 @@ std::optional<SamplerDescriptor> Registry::ObtainBoundSampler(u32 offset) { | |||
| 93 | return value; | 93 | return value; |
| 94 | } | 94 | } |
| 95 | 95 | ||
| 96 | std::optional<Tegra::Engines::SamplerDescriptor> Registry::ObtainSeparateSampler( | ||
| 97 | std::pair<u32, u32> buffers, std::pair<u32, u32> offsets) { | ||
| 98 | SeparateSamplerKey key; | ||
| 99 | key.buffers = buffers; | ||
| 100 | key.offsets = offsets; | ||
| 101 | const auto iter = separate_samplers.find(key); | ||
| 102 | if (iter != separate_samplers.end()) { | ||
| 103 | return iter->second; | ||
| 104 | } | ||
| 105 | if (!engine) { | ||
| 106 | return std::nullopt; | ||
| 107 | } | ||
| 108 | |||
| 109 | const u32 handle_1 = engine->AccessConstBuffer32(stage, key.buffers.first, key.offsets.first); | ||
| 110 | const u32 handle_2 = engine->AccessConstBuffer32(stage, key.buffers.second, key.offsets.second); | ||
| 111 | const SamplerDescriptor value = engine->AccessSampler(handle_1 | handle_2); | ||
| 112 | separate_samplers.emplace(key, value); | ||
| 113 | return value; | ||
| 114 | } | ||
| 115 | |||
| 96 | std::optional<Tegra::Engines::SamplerDescriptor> Registry::ObtainBindlessSampler(u32 buffer, | 116 | std::optional<Tegra::Engines::SamplerDescriptor> Registry::ObtainBindlessSampler(u32 buffer, |
| 97 | u32 offset) { | 117 | u32 offset) { |
| 98 | const std::pair key = {buffer, offset}; | 118 | const std::pair key = {buffer, offset}; |
diff --git a/src/video_core/shader/registry.h b/src/video_core/shader/registry.h index 0c80d35fd..231206765 100644 --- a/src/video_core/shader/registry.h +++ b/src/video_core/shader/registry.h | |||
| @@ -19,8 +19,39 @@ | |||
| 19 | 19 | ||
| 20 | namespace VideoCommon::Shader { | 20 | namespace VideoCommon::Shader { |
| 21 | 21 | ||
| 22 | struct SeparateSamplerKey { | ||
| 23 | std::pair<u32, u32> buffers; | ||
| 24 | std::pair<u32, u32> offsets; | ||
| 25 | }; | ||
| 26 | |||
| 27 | } // namespace VideoCommon::Shader | ||
| 28 | |||
| 29 | namespace std { | ||
| 30 | |||
| 31 | template <> | ||
| 32 | struct hash<VideoCommon::Shader::SeparateSamplerKey> { | ||
| 33 | std::size_t operator()(const VideoCommon::Shader::SeparateSamplerKey& key) const noexcept { | ||
| 34 | return std::hash<u32>{}(key.buffers.first ^ key.buffers.second ^ key.offsets.first ^ | ||
| 35 | key.offsets.second); | ||
| 36 | } | ||
| 37 | }; | ||
| 38 | |||
| 39 | template <> | ||
| 40 | struct equal_to<VideoCommon::Shader::SeparateSamplerKey> { | ||
| 41 | bool operator()(const VideoCommon::Shader::SeparateSamplerKey& lhs, | ||
| 42 | const VideoCommon::Shader::SeparateSamplerKey& rhs) const noexcept { | ||
| 43 | return lhs.buffers == rhs.buffers && lhs.offsets == rhs.offsets; | ||
| 44 | } | ||
| 45 | }; | ||
| 46 | |||
| 47 | } // namespace std | ||
| 48 | |||
| 49 | namespace VideoCommon::Shader { | ||
| 50 | |||
| 22 | using KeyMap = std::unordered_map<std::pair<u32, u32>, u32, Common::PairHash>; | 51 | using KeyMap = std::unordered_map<std::pair<u32, u32>, u32, Common::PairHash>; |
| 23 | using BoundSamplerMap = std::unordered_map<u32, Tegra::Engines::SamplerDescriptor>; | 52 | using BoundSamplerMap = std::unordered_map<u32, Tegra::Engines::SamplerDescriptor>; |
| 53 | using SeparateSamplerMap = | ||
| 54 | std::unordered_map<SeparateSamplerKey, Tegra::Engines::SamplerDescriptor>; | ||
| 24 | using BindlessSamplerMap = | 55 | using BindlessSamplerMap = |
| 25 | std::unordered_map<std::pair<u32, u32>, Tegra::Engines::SamplerDescriptor, Common::PairHash>; | 56 | std::unordered_map<std::pair<u32, u32>, Tegra::Engines::SamplerDescriptor, Common::PairHash>; |
| 26 | 57 | ||
| @@ -73,6 +104,9 @@ public: | |||
| 73 | 104 | ||
| 74 | std::optional<Tegra::Engines::SamplerDescriptor> ObtainBoundSampler(u32 offset); | 105 | std::optional<Tegra::Engines::SamplerDescriptor> ObtainBoundSampler(u32 offset); |
| 75 | 106 | ||
| 107 | std::optional<Tegra::Engines::SamplerDescriptor> ObtainSeparateSampler( | ||
| 108 | std::pair<u32, u32> buffers, std::pair<u32, u32> offsets); | ||
| 109 | |||
| 76 | std::optional<Tegra::Engines::SamplerDescriptor> ObtainBindlessSampler(u32 buffer, u32 offset); | 110 | std::optional<Tegra::Engines::SamplerDescriptor> ObtainBindlessSampler(u32 buffer, u32 offset); |
| 77 | 111 | ||
| 78 | /// Inserts a key. | 112 | /// Inserts a key. |
| @@ -128,6 +162,7 @@ private: | |||
| 128 | Tegra::Engines::ConstBufferEngineInterface* engine = nullptr; | 162 | Tegra::Engines::ConstBufferEngineInterface* engine = nullptr; |
| 129 | KeyMap keys; | 163 | KeyMap keys; |
| 130 | BoundSamplerMap bound_samplers; | 164 | BoundSamplerMap bound_samplers; |
| 165 | SeparateSamplerMap separate_samplers; | ||
| 131 | BindlessSamplerMap bindless_samplers; | 166 | BindlessSamplerMap bindless_samplers; |
| 132 | u32 bound_buffer; | 167 | u32 bound_buffer; |
| 133 | GraphicsInfo graphics_info; | 168 | GraphicsInfo graphics_info; |
diff --git a/src/video_core/shader/shader_ir.h b/src/video_core/shader/shader_ir.h index 8f522edf0..3a98b2104 100644 --- a/src/video_core/shader/shader_ir.h +++ b/src/video_core/shader/shader_ir.h | |||
| @@ -330,8 +330,8 @@ private: | |||
| 330 | OperationCode GetPredicateCombiner(Tegra::Shader::PredOperation operation); | 330 | OperationCode GetPredicateCombiner(Tegra::Shader::PredOperation operation); |
| 331 | 331 | ||
| 332 | /// Queries the missing sampler info from the execution context. | 332 | /// Queries the missing sampler info from the execution context. |
| 333 | SamplerInfo GetSamplerInfo(SamplerInfo info, u32 offset, | 333 | SamplerInfo GetSamplerInfo(SamplerInfo info, |
| 334 | std::optional<u32> buffer = std::nullopt); | 334 | std::optional<Tegra::Engines::SamplerDescriptor> sampler); |
| 335 | 335 | ||
| 336 | /// Accesses a texture sampler. | 336 | /// Accesses a texture sampler. |
| 337 | std::optional<Sampler> GetSampler(Tegra::Shader::Sampler sampler, SamplerInfo info); | 337 | std::optional<Sampler> GetSampler(Tegra::Shader::Sampler sampler, SamplerInfo info); |
diff --git a/src/video_core/shader/track.cpp b/src/video_core/shader/track.cpp index 435f4facb..d5ed81442 100644 --- a/src/video_core/shader/track.cpp +++ b/src/video_core/shader/track.cpp | |||
| @@ -64,7 +64,8 @@ bool AmendNodeCv(std::size_t amend_index, Node node) { | |||
| 64 | if (const auto operation = std::get_if<OperationNode>(&*node)) { | 64 | if (const auto operation = std::get_if<OperationNode>(&*node)) { |
| 65 | operation->SetAmendIndex(amend_index); | 65 | operation->SetAmendIndex(amend_index); |
| 66 | return true; | 66 | return true; |
| 67 | } else if (const auto conditional = std::get_if<ConditionalNode>(&*node)) { | 67 | } |
| 68 | if (const auto conditional = std::get_if<ConditionalNode>(&*node)) { | ||
| 68 | conditional->SetAmendIndex(amend_index); | 69 | conditional->SetAmendIndex(amend_index); |
| 69 | return true; | 70 | return true; |
| 70 | } | 71 | } |
| @@ -110,10 +111,23 @@ std::pair<Node, TrackSampler> ShaderIR::TrackBindlessSampler(Node tracked, const | |||
| 110 | return TrackBindlessSampler(source, code, new_cursor); | 111 | return TrackBindlessSampler(source, code, new_cursor); |
| 111 | } | 112 | } |
| 112 | if (const auto operation = std::get_if<OperationNode>(&*tracked)) { | 113 | if (const auto operation = std::get_if<OperationNode>(&*tracked)) { |
| 113 | for (std::size_t i = operation->GetOperandsCount(); i > 0; --i) { | 114 | const OperationNode& op = *operation; |
| 114 | if (auto found = TrackBindlessSampler((*operation)[i - 1], code, cursor); | 115 | |
| 115 | std::get<0>(found)) { | 116 | const OperationCode opcode = operation->GetCode(); |
| 116 | // Cbuf found in operand. | 117 | if (opcode == OperationCode::IBitwiseOr || opcode == OperationCode::UBitwiseOr) { |
| 118 | ASSERT(op.GetOperandsCount() == 2); | ||
| 119 | auto [node_a, index_a, offset_a] = TrackCbuf(op[0], code, cursor); | ||
| 120 | auto [node_b, index_b, offset_b] = TrackCbuf(op[1], code, cursor); | ||
| 121 | if (node_a && node_b) { | ||
| 122 | auto track = MakeTrackSampler<SeparateSamplerNode>(std::pair{index_a, index_b}, | ||
| 123 | std::pair{offset_a, offset_b}); | ||
| 124 | return {tracked, std::move(track)}; | ||
| 125 | } | ||
| 126 | } | ||
| 127 | std::size_t i = op.GetOperandsCount(); | ||
| 128 | while (i--) { | ||
| 129 | if (auto found = TrackBindlessSampler(op[i - 1], code, cursor); std::get<0>(found)) { | ||
| 130 | // Constant buffer found in operand. | ||
| 117 | return found; | 131 | return found; |
| 118 | } | 132 | } |
| 119 | } | 133 | } |