summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/citra_qt/debugger/wait_tree.h1
-rw-r--r--src/core/hle/kernel/client_session.cpp21
-rw-r--r--src/core/hle/kernel/server_session.h2
3 files changed, 15 insertions, 9 deletions
diff --git a/src/citra_qt/debugger/wait_tree.h b/src/citra_qt/debugger/wait_tree.h
index 06ef58ea7..2b38712b9 100644
--- a/src/citra_qt/debugger/wait_tree.h
+++ b/src/citra_qt/debugger/wait_tree.h
@@ -18,7 +18,6 @@ class WaitObject;
18class Event; 18class Event;
19class Mutex; 19class Mutex;
20class Semaphore; 20class Semaphore;
21class Session;
22class Thread; 21class Thread;
23class Timer; 22class Timer;
24} 23}
diff --git a/src/core/hle/kernel/client_session.cpp b/src/core/hle/kernel/client_session.cpp
index 6bc49ff64..fef97af1f 100644
--- a/src/core/hle/kernel/client_session.cpp
+++ b/src/core/hle/kernel/client_session.cpp
@@ -8,6 +8,7 @@
8#include "core/hle/kernel/errors.h" 8#include "core/hle/kernel/errors.h"
9#include "core/hle/kernel/hle_ipc.h" 9#include "core/hle/kernel/hle_ipc.h"
10#include "core/hle/kernel/server_session.h" 10#include "core/hle/kernel/server_session.h"
11#include "core/hle/kernel/session.h"
11 12
12namespace Kernel { 13namespace Kernel {
13 14
@@ -16,9 +17,13 @@ ClientSession::~ClientSession() {
16 // This destructor will be called automatically when the last ClientSession handle is closed by 17 // This destructor will be called automatically when the last ClientSession handle is closed by
17 // the emulated application. 18 // the emulated application.
18 19
19 if (parent->server) { 20 // Local references to ServerSession and SessionRequestHandler are necessary to guarantee they
20 if (parent->server->hle_handler) 21 // will be kept alive until after ClientDisconnected() returns.
21 parent->server->hle_handler->ClientDisconnected(parent->server); 22 SharedPtr<ServerSession> server = parent->server;
23 if (server) {
24 std::shared_ptr<SessionRequestHandler> hle_handler = server->hle_handler;
25 if (hle_handler)
26 hle_handler->ClientDisconnected(server);
22 27
23 // TODO(Subv): Force a wake up of all the ServerSession's waiting threads and set 28 // TODO(Subv): Force a wake up of all the ServerSession's waiting threads and set
24 // their WaitSynchronization result to 0xC920181A. 29 // their WaitSynchronization result to 0xC920181A.
@@ -28,11 +33,13 @@ ClientSession::~ClientSession() {
28} 33}
29 34
30ResultCode ClientSession::SendSyncRequest() { 35ResultCode ClientSession::SendSyncRequest() {
31 // Signal the server session that new data is available 36 // Keep ServerSession alive until we're done working with it.
32 if (parent->server) 37 SharedPtr<ServerSession> server = parent->server;
33 return parent->server->HandleSyncRequest(); 38 if (server == nullptr)
39 return ERR_SESSION_CLOSED_BY_REMOTE;
34 40
35 return ERR_SESSION_CLOSED_BY_REMOTE; 41 // Signal the server session that new data is available
42 return server->HandleSyncRequest();
36} 43}
37 44
38} // namespace 45} // namespace
diff --git a/src/core/hle/kernel/server_session.h b/src/core/hle/kernel/server_session.h
index 28f365b9e..5365605da 100644
--- a/src/core/hle/kernel/server_session.h
+++ b/src/core/hle/kernel/server_session.h
@@ -9,7 +9,6 @@
9#include "common/assert.h" 9#include "common/assert.h"
10#include "common/common_types.h" 10#include "common/common_types.h"
11#include "core/hle/kernel/kernel.h" 11#include "core/hle/kernel/kernel.h"
12#include "core/hle/kernel/session.h"
13#include "core/hle/kernel/wait_object.h" 12#include "core/hle/kernel/wait_object.h"
14#include "core/hle/result.h" 13#include "core/hle/result.h"
15#include "core/memory.h" 14#include "core/memory.h"
@@ -19,6 +18,7 @@ namespace Kernel {
19class ClientSession; 18class ClientSession;
20class ClientPort; 19class ClientPort;
21class ServerSession; 20class ServerSession;
21class Session;
22class SessionRequestHandler; 22class SessionRequestHandler;
23class Thread; 23class Thread;
24 24