summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/common/symbols.cpp41
-rw-r--r--src/common/symbols.h21
2 files changed, 27 insertions, 35 deletions
diff --git a/src/common/symbols.cpp b/src/common/symbols.cpp
index f23e51c9d..db8340043 100644
--- a/src/common/symbols.cpp
+++ b/src/common/symbols.cpp
@@ -8,46 +8,43 @@ TSymbolsMap g_symbols;
8 8
9namespace Symbols 9namespace Symbols
10{ 10{
11 bool HasSymbol(u32 _address) 11 bool HasSymbol(u32 address)
12 { 12 {
13 return g_symbols.find(_address) != g_symbols.end(); 13 return g_symbols.find(address) != g_symbols.end();
14 } 14 }
15 15
16 void Add(u32 _address, const std::string& _name, u32 _size, u32 _type) 16 void Add(u32 address, const std::string& name, u32 size, u32 type)
17 { 17 {
18 if (!HasSymbol(_address)) 18 if (!HasSymbol(address))
19 { 19 {
20 TSymbol symbol; 20 TSymbol symbol;
21 symbol.address = _address; 21 symbol.address = address;
22 symbol.name = _name; 22 symbol.name = name;
23 symbol.size = _size; 23 symbol.size = size;
24 symbol.type = _type; 24 symbol.type = type;
25 25
26 g_symbols.insert(TSymbolsPair(_address, symbol)); 26 g_symbols.emplace(address, symbol);
27 } 27 }
28 } 28 }
29 29
30 TSymbol GetSymbol(u32 _address) 30 TSymbol GetSymbol(u32 address)
31 { 31 {
32 TSymbolsMap::iterator foundSymbolItr; 32 const auto iter = g_symbols.find(address);
33 TSymbol symbol;
34 33
35 foundSymbolItr = g_symbols.find(_address); 34 if (iter != g_symbols.end())
36 if (foundSymbolItr != g_symbols.end()) 35 return iter->second;
37 {
38 symbol = (*foundSymbolItr).second;
39 }
40 36
41 return symbol; 37 return {};
42 } 38 }
43 const std::string GetName(u32 _address) 39
40 const std::string GetName(u32 address)
44 { 41 {
45 return GetSymbol(_address).name; 42 return GetSymbol(address).name;
46 } 43 }
47 44
48 void Remove(u32 _address) 45 void Remove(u32 address)
49 { 46 {
50 g_symbols.erase(_address); 47 g_symbols.erase(address);
51 } 48 }
52 49
53 void Clear() 50 void Clear()
diff --git a/src/common/symbols.h b/src/common/symbols.h
index 6b62b011e..5ed16009c 100644
--- a/src/common/symbols.h
+++ b/src/common/symbols.h
@@ -12,15 +12,10 @@
12 12
13struct TSymbol 13struct TSymbol
14{ 14{
15 TSymbol() : 15 u32 address = 0;
16 address(0),
17 size(0),
18 type(0)
19 {}
20 u32 address;
21 std::string name; 16 std::string name;
22 u32 size; 17 u32 size = 0;
23 u32 type; 18 u32 type = 0;
24}; 19};
25 20
26typedef std::map<u32, TSymbol> TSymbolsMap; 21typedef std::map<u32, TSymbol> TSymbolsMap;
@@ -28,12 +23,12 @@ typedef std::pair<u32, TSymbol> TSymbolsPair;
28 23
29namespace Symbols 24namespace Symbols
30{ 25{
31 bool HasSymbol(u32 _address); 26 bool HasSymbol(u32 address);
32 27
33 void Add(u32 _address, const std::string& _name, u32 _size, u32 _type); 28 void Add(u32 address, const std::string& name, u32 size, u32 type);
34 TSymbol GetSymbol(u32 _address); 29 TSymbol GetSymbol(u32 address);
35 const std::string GetName(u32 _address); 30 const std::string GetName(u32 address);
36 void Remove(u32 _address); 31 void Remove(u32 address);
37 void Clear(); 32 void Clear();
38} 33}
39 34