diff options
Diffstat (limited to 'src')
| -rw-r--r-- | src/core/hle/kernel/k_process.cpp | 25 | ||||
| -rw-r--r-- | src/core/hle/kernel/k_process.h | 7 | ||||
| -rw-r--r-- | src/core/loader/deconstructed_rom_directory.cpp | 2 | ||||
| -rw-r--r-- | src/core/loader/kip.cpp | 2 | ||||
| -rw-r--r-- | src/core/loader/nro.cpp | 2 | ||||
| -rw-r--r-- | src/core/loader/nso.cpp | 2 | ||||
| -rw-r--r-- | src/core/reporter.cpp | 4 |
7 files changed, 33 insertions, 11 deletions
diff --git a/src/core/hle/kernel/k_process.cpp b/src/core/hle/kernel/k_process.cpp index e573e2a57..703049ede 100644 --- a/src/core/hle/kernel/k_process.cpp +++ b/src/core/hle/kernel/k_process.cpp | |||
| @@ -38,7 +38,7 @@ namespace { | |||
| 38 | */ | 38 | */ |
| 39 | void SetupMainThread(Core::System& system, KProcess& owner_process, u32 priority, | 39 | void SetupMainThread(Core::System& system, KProcess& owner_process, u32 priority, |
| 40 | KProcessAddress stack_top) { | 40 | KProcessAddress stack_top) { |
| 41 | const KProcessAddress entry_point = owner_process.GetPageTable().GetCodeRegionStart(); | 41 | const KProcessAddress entry_point = owner_process.GetEntryPoint(); |
| 42 | ASSERT(owner_process.GetResourceLimit()->Reserve(LimitableResource::ThreadCountMax, 1)); | 42 | ASSERT(owner_process.GetResourceLimit()->Reserve(LimitableResource::ThreadCountMax, 1)); |
| 43 | 43 | ||
| 44 | KThread* thread = KThread::Create(system.Kernel()); | 44 | KThread* thread = KThread::Create(system.Kernel()); |
| @@ -358,6 +358,21 @@ Result KProcess::LoadFromMetadata(const FileSys::ProgramMetadata& metadata, std: | |||
| 358 | m_system_resource_size = metadata.GetSystemResourceSize(); | 358 | m_system_resource_size = metadata.GetSystemResourceSize(); |
| 359 | m_image_size = code_size; | 359 | m_image_size = code_size; |
| 360 | 360 | ||
| 361 | if (metadata.GetAddressSpaceType() == FileSys::ProgramAddressSpaceType::Is39Bit) { | ||
| 362 | // For 39-bit processes, the ASLR region starts at 0x800'0000 and is ~512GiB large. | ||
| 363 | // However, some (buggy) programs/libraries like skyline incorrectly depend on the | ||
| 364 | // existence of ASLR pages before the entry point, so we will adjust the load address | ||
| 365 | // to point to about 2GiB into the ASLR region. | ||
| 366 | m_code_address = 0x8000'0000; | ||
| 367 | } else { | ||
| 368 | // All other processes can be mapped at the beginning of the code region. | ||
| 369 | if (metadata.GetAddressSpaceType() == FileSys::ProgramAddressSpaceType::Is36Bit) { | ||
| 370 | m_code_address = 0x800'0000; | ||
| 371 | } else { | ||
| 372 | m_code_address = 0x20'0000; | ||
| 373 | } | ||
| 374 | } | ||
| 375 | |||
| 361 | KScopedResourceReservation memory_reservation( | 376 | KScopedResourceReservation memory_reservation( |
| 362 | m_resource_limit, LimitableResource::PhysicalMemoryMax, code_size + m_system_resource_size); | 377 | m_resource_limit, LimitableResource::PhysicalMemoryMax, code_size + m_system_resource_size); |
| 363 | if (!memory_reservation.Succeeded()) { | 378 | if (!memory_reservation.Succeeded()) { |
| @@ -368,15 +383,15 @@ Result KProcess::LoadFromMetadata(const FileSys::ProgramMetadata& metadata, std: | |||
| 368 | // Initialize process address space | 383 | // Initialize process address space |
| 369 | if (const Result result{m_page_table.InitializeForProcess( | 384 | if (const Result result{m_page_table.InitializeForProcess( |
| 370 | metadata.GetAddressSpaceType(), false, false, false, KMemoryManager::Pool::Application, | 385 | metadata.GetAddressSpaceType(), false, false, false, KMemoryManager::Pool::Application, |
| 371 | 0x8000000, code_size, std::addressof(m_kernel.GetAppSystemResource()), m_resource_limit, | 386 | this->GetEntryPoint(), code_size, std::addressof(m_kernel.GetAppSystemResource()), |
| 372 | m_kernel.System().ApplicationMemory())}; | 387 | m_resource_limit, m_kernel.System().ApplicationMemory())}; |
| 373 | result.IsError()) { | 388 | result.IsError()) { |
| 374 | R_RETURN(result); | 389 | R_RETURN(result); |
| 375 | } | 390 | } |
| 376 | 391 | ||
| 377 | // Map process code region | 392 | // Map process code region |
| 378 | if (const Result result{m_page_table.MapProcessCode(m_page_table.GetCodeRegionStart(), | 393 | if (const Result result{m_page_table.MapProcessCode(this->GetEntryPoint(), code_size / PageSize, |
| 379 | code_size / PageSize, KMemoryState::Code, | 394 | KMemoryState::Code, |
| 380 | KMemoryPermission::None)}; | 395 | KMemoryPermission::None)}; |
| 381 | result.IsError()) { | 396 | result.IsError()) { |
| 382 | R_RETURN(result); | 397 | R_RETURN(result); |
diff --git a/src/core/hle/kernel/k_process.h b/src/core/hle/kernel/k_process.h index c9b37e138..4fdeaf11a 100644 --- a/src/core/hle/kernel/k_process.h +++ b/src/core/hle/kernel/k_process.h | |||
| @@ -177,6 +177,10 @@ public: | |||
| 177 | return m_program_id; | 177 | return m_program_id; |
| 178 | } | 178 | } |
| 179 | 179 | ||
| 180 | KProcessAddress GetEntryPoint() const { | ||
| 181 | return m_code_address; | ||
| 182 | } | ||
| 183 | |||
| 180 | /// Gets the resource limit descriptor for this process | 184 | /// Gets the resource limit descriptor for this process |
| 181 | KResourceLimit* GetResourceLimit() const; | 185 | KResourceLimit* GetResourceLimit() const; |
| 182 | 186 | ||
| @@ -485,6 +489,9 @@ private: | |||
| 485 | /// Address indicating the location of the process' dedicated TLS region. | 489 | /// Address indicating the location of the process' dedicated TLS region. |
| 486 | KProcessAddress m_plr_address = 0; | 490 | KProcessAddress m_plr_address = 0; |
| 487 | 491 | ||
| 492 | /// Address indicating the location of the process's entry point. | ||
| 493 | KProcessAddress m_code_address = 0; | ||
| 494 | |||
| 488 | /// Random values for svcGetInfo RandomEntropy | 495 | /// Random values for svcGetInfo RandomEntropy |
| 489 | std::array<u64, RANDOM_ENTROPY_SIZE> m_random_entropy{}; | 496 | std::array<u64, RANDOM_ENTROPY_SIZE> m_random_entropy{}; |
| 490 | 497 | ||
diff --git a/src/core/loader/deconstructed_rom_directory.cpp b/src/core/loader/deconstructed_rom_directory.cpp index e04ad19db..f4eaf3331 100644 --- a/src/core/loader/deconstructed_rom_directory.cpp +++ b/src/core/loader/deconstructed_rom_directory.cpp | |||
| @@ -153,7 +153,7 @@ AppLoader_DeconstructedRomDirectory::LoadResult AppLoader_DeconstructedRomDirect | |||
| 153 | 153 | ||
| 154 | // Load NSO modules | 154 | // Load NSO modules |
| 155 | modules.clear(); | 155 | modules.clear(); |
| 156 | const VAddr base_address{GetInteger(process.GetPageTable().GetCodeRegionStart())}; | 156 | const VAddr base_address{GetInteger(process.GetEntryPoint())}; |
| 157 | VAddr next_load_addr{base_address}; | 157 | VAddr next_load_addr{base_address}; |
| 158 | const FileSys::PatchManager pm{metadata.GetTitleID(), system.GetFileSystemController(), | 158 | const FileSys::PatchManager pm{metadata.GetTitleID(), system.GetFileSystemController(), |
| 159 | system.GetContentProvider()}; | 159 | system.GetContentProvider()}; |
diff --git a/src/core/loader/kip.cpp b/src/core/loader/kip.cpp index ffe976b94..d722459c6 100644 --- a/src/core/loader/kip.cpp +++ b/src/core/loader/kip.cpp | |||
| @@ -96,7 +96,7 @@ AppLoader::LoadResult AppLoader_KIP::Load(Kernel::KProcess& process, | |||
| 96 | } | 96 | } |
| 97 | 97 | ||
| 98 | codeset.memory = std::move(program_image); | 98 | codeset.memory = std::move(program_image); |
| 99 | const VAddr base_address = GetInteger(process.GetPageTable().GetCodeRegionStart()); | 99 | const VAddr base_address = GetInteger(process.GetEntryPoint()); |
| 100 | process.LoadModule(std::move(codeset), base_address); | 100 | process.LoadModule(std::move(codeset), base_address); |
| 101 | 101 | ||
| 102 | LOG_DEBUG(Loader, "loaded module {} @ 0x{:X}", kip->GetName(), base_address); | 102 | LOG_DEBUG(Loader, "loaded module {} @ 0x{:X}", kip->GetName(), base_address); |
diff --git a/src/core/loader/nro.cpp b/src/core/loader/nro.cpp index 506808b5d..d7562b4bc 100644 --- a/src/core/loader/nro.cpp +++ b/src/core/loader/nro.cpp | |||
| @@ -203,7 +203,7 @@ static bool LoadNroImpl(Kernel::KProcess& process, const std::vector<u8>& data) | |||
| 203 | 203 | ||
| 204 | // Load codeset for current process | 204 | // Load codeset for current process |
| 205 | codeset.memory = std::move(program_image); | 205 | codeset.memory = std::move(program_image); |
| 206 | process.LoadModule(std::move(codeset), process.GetPageTable().GetCodeRegionStart()); | 206 | process.LoadModule(std::move(codeset), process.GetEntryPoint()); |
| 207 | 207 | ||
| 208 | return true; | 208 | return true; |
| 209 | } | 209 | } |
diff --git a/src/core/loader/nso.cpp b/src/core/loader/nso.cpp index 74cc9579f..549822506 100644 --- a/src/core/loader/nso.cpp +++ b/src/core/loader/nso.cpp | |||
| @@ -167,7 +167,7 @@ AppLoader_NSO::LoadResult AppLoader_NSO::Load(Kernel::KProcess& process, Core::S | |||
| 167 | modules.clear(); | 167 | modules.clear(); |
| 168 | 168 | ||
| 169 | // Load module | 169 | // Load module |
| 170 | const VAddr base_address = GetInteger(process.GetPageTable().GetCodeRegionStart()); | 170 | const VAddr base_address = GetInteger(process.GetEntryPoint()); |
| 171 | if (!LoadModule(process, system, *file, base_address, true, true)) { | 171 | if (!LoadModule(process, system, *file, base_address, true, true)) { |
| 172 | return {ResultStatus::ErrorLoadingNSO, {}}; | 172 | return {ResultStatus::ErrorLoadingNSO, {}}; |
| 173 | } | 173 | } |
diff --git a/src/core/reporter.cpp b/src/core/reporter.cpp index b5b3e7eda..ed875d444 100644 --- a/src/core/reporter.cpp +++ b/src/core/reporter.cpp | |||
| @@ -117,8 +117,8 @@ json GetProcessorStateDataAuto(Core::System& system) { | |||
| 117 | arm.SaveContext(context); | 117 | arm.SaveContext(context); |
| 118 | 118 | ||
| 119 | return GetProcessorStateData(process->Is64BitProcess() ? "AArch64" : "AArch32", | 119 | return GetProcessorStateData(process->Is64BitProcess() ? "AArch64" : "AArch32", |
| 120 | GetInteger(process->GetPageTable().GetCodeRegionStart()), | 120 | GetInteger(process->GetEntryPoint()), context.sp, context.pc, |
| 121 | context.sp, context.pc, context.pstate, context.cpu_registers); | 121 | context.pstate, context.cpu_registers); |
| 122 | } | 122 | } |
| 123 | 123 | ||
| 124 | json GetBacktraceData(Core::System& system) { | 124 | json GetBacktraceData(Core::System& system) { |