summaryrefslogtreecommitdiff
path: root/src/video_core/texture_cache
diff options
context:
space:
mode:
Diffstat (limited to 'src/video_core/texture_cache')
-rw-r--r--src/video_core/texture_cache/image_base.cpp5
-rw-r--r--src/video_core/texture_cache/image_view_base.cpp2
-rw-r--r--src/video_core/texture_cache/texture_cache.h15
-rw-r--r--src/video_core/texture_cache/util.cpp13
-rw-r--r--src/video_core/texture_cache/util.h9
5 files changed, 25 insertions, 19 deletions
diff --git a/src/video_core/texture_cache/image_base.cpp b/src/video_core/texture_cache/image_base.cpp
index 959b3f115..9914926b3 100644
--- a/src/video_core/texture_cache/image_base.cpp
+++ b/src/video_core/texture_cache/image_base.cpp
@@ -120,9 +120,10 @@ void AddImageAlias(ImageBase& lhs, ImageBase& rhs, ImageId lhs_id, ImageId rhs_i
120 if (lhs.info.type == ImageType::Linear) { 120 if (lhs.info.type == ImageType::Linear) {
121 base = SubresourceBase{.level = 0, .layer = 0}; 121 base = SubresourceBase{.level = 0, .layer = 0};
122 } else { 122 } else {
123 // We are passing relaxed formats as an option, having broken views or not won't matter 123 // We are passing relaxed formats as an option, having broken views/bgr or not won't matter
124 static constexpr bool broken_views = false; 124 static constexpr bool broken_views = false;
125 base = FindSubresource(rhs.info, lhs, rhs.gpu_addr, OPTIONS, broken_views); 125 static constexpr bool native_bgr = true;
126 base = FindSubresource(rhs.info, lhs, rhs.gpu_addr, OPTIONS, broken_views, native_bgr);
126 } 127 }
127 if (!base) { 128 if (!base) {
128 LOG_ERROR(HW_GPU, "Image alias should have been flipped"); 129 LOG_ERROR(HW_GPU, "Image alias should have been flipped");
diff --git a/src/video_core/texture_cache/image_view_base.cpp b/src/video_core/texture_cache/image_view_base.cpp
index 18f72e508..f89a40b4c 100644
--- a/src/video_core/texture_cache/image_view_base.cpp
+++ b/src/video_core/texture_cache/image_view_base.cpp
@@ -24,7 +24,7 @@ ImageViewBase::ImageViewBase(const ImageViewInfo& info, const ImageInfo& image_i
24 .height = std::max(image_info.size.height >> range.base.level, 1u), 24 .height = std::max(image_info.size.height >> range.base.level, 1u),
25 .depth = std::max(image_info.size.depth >> range.base.level, 1u), 25 .depth = std::max(image_info.size.depth >> range.base.level, 1u),
26 } { 26 } {
27 ASSERT_MSG(VideoCore::Surface::IsViewCompatible(image_info.format, info.format, false), 27 ASSERT_MSG(VideoCore::Surface::IsViewCompatible(image_info.format, info.format, false, true),
28 "Image view format {} is incompatible with image format {}", info.format, 28 "Image view format {} is incompatible with image format {}", info.format,
29 image_info.format); 29 image_info.format);
30 const bool is_async = Settings::values.use_asynchronous_gpu_emulation.GetValue(); 30 const bool is_async = Settings::values.use_asynchronous_gpu_emulation.GetValue();
diff --git a/src/video_core/texture_cache/texture_cache.h b/src/video_core/texture_cache/texture_cache.h
index b1da69971..98e33c3a0 100644
--- a/src/video_core/texture_cache/texture_cache.h
+++ b/src/video_core/texture_cache/texture_cache.h
@@ -876,6 +876,7 @@ ImageId TextureCache<P>::FindImage(const ImageInfo& info, GPUVAddr gpu_addr,
876 return ImageId{}; 876 return ImageId{};
877 } 877 }
878 const bool broken_views = runtime.HasBrokenTextureViewFormats(); 878 const bool broken_views = runtime.HasBrokenTextureViewFormats();
879 const bool native_bgr = runtime.HasNativeBgr();
879 ImageId image_id; 880 ImageId image_id;
880 const auto lambda = [&](ImageId existing_image_id, ImageBase& existing_image) { 881 const auto lambda = [&](ImageId existing_image_id, ImageBase& existing_image) {
881 if (info.type == ImageType::Linear || existing_image.info.type == ImageType::Linear) { 882 if (info.type == ImageType::Linear || existing_image.info.type == ImageType::Linear) {
@@ -885,11 +886,12 @@ ImageId TextureCache<P>::FindImage(const ImageInfo& info, GPUVAddr gpu_addr,
885 if (existing_image.gpu_addr == gpu_addr && existing.type == info.type && 886 if (existing_image.gpu_addr == gpu_addr && existing.type == info.type &&
886 existing.pitch == info.pitch && 887 existing.pitch == info.pitch &&
887 IsPitchLinearSameSize(existing, info, strict_size) && 888 IsPitchLinearSameSize(existing, info, strict_size) &&
888 IsViewCompatible(existing.format, info.format, broken_views)) { 889 IsViewCompatible(existing.format, info.format, broken_views, native_bgr)) {
889 image_id = existing_image_id; 890 image_id = existing_image_id;
890 return true; 891 return true;
891 } 892 }
892 } else if (IsSubresource(info, existing_image, gpu_addr, options, broken_views)) { 893 } else if (IsSubresource(info, existing_image, gpu_addr, options, broken_views,
894 native_bgr)) {
893 image_id = existing_image_id; 895 image_id = existing_image_id;
894 return true; 896 return true;
895 } 897 }
@@ -920,6 +922,7 @@ ImageId TextureCache<P>::JoinImages(const ImageInfo& info, GPUVAddr gpu_addr, VA
920 ImageInfo new_info = info; 922 ImageInfo new_info = info;
921 const size_t size_bytes = CalculateGuestSizeInBytes(new_info); 923 const size_t size_bytes = CalculateGuestSizeInBytes(new_info);
922 const bool broken_views = runtime.HasBrokenTextureViewFormats(); 924 const bool broken_views = runtime.HasBrokenTextureViewFormats();
925 const bool native_bgr = runtime.HasNativeBgr();
923 std::vector<ImageId> overlap_ids; 926 std::vector<ImageId> overlap_ids;
924 std::vector<ImageId> left_aliased_ids; 927 std::vector<ImageId> left_aliased_ids;
925 std::vector<ImageId> right_aliased_ids; 928 std::vector<ImageId> right_aliased_ids;
@@ -935,8 +938,8 @@ ImageId TextureCache<P>::JoinImages(const ImageInfo& info, GPUVAddr gpu_addr, VA
935 return; 938 return;
936 } 939 }
937 static constexpr bool strict_size = true; 940 static constexpr bool strict_size = true;
938 const std::optional<OverlapResult> solution = 941 const std::optional<OverlapResult> solution = ResolveOverlap(
939 ResolveOverlap(new_info, gpu_addr, cpu_addr, overlap, strict_size, broken_views); 942 new_info, gpu_addr, cpu_addr, overlap, strict_size, broken_views, native_bgr);
940 if (solution) { 943 if (solution) {
941 gpu_addr = solution->gpu_addr; 944 gpu_addr = solution->gpu_addr;
942 cpu_addr = solution->cpu_addr; 945 cpu_addr = solution->cpu_addr;
@@ -946,10 +949,10 @@ ImageId TextureCache<P>::JoinImages(const ImageInfo& info, GPUVAddr gpu_addr, VA
946 } 949 }
947 static constexpr auto options = RelaxedOptions::Size | RelaxedOptions::Format; 950 static constexpr auto options = RelaxedOptions::Size | RelaxedOptions::Format;
948 const ImageBase new_image_base(new_info, gpu_addr, cpu_addr); 951 const ImageBase new_image_base(new_info, gpu_addr, cpu_addr);
949 if (IsSubresource(new_info, overlap, gpu_addr, options, broken_views)) { 952 if (IsSubresource(new_info, overlap, gpu_addr, options, broken_views, native_bgr)) {
950 left_aliased_ids.push_back(overlap_id); 953 left_aliased_ids.push_back(overlap_id);
951 } else if (IsSubresource(overlap.info, new_image_base, overlap.gpu_addr, options, 954 } else if (IsSubresource(overlap.info, new_image_base, overlap.gpu_addr, options,
952 broken_views)) { 955 broken_views, native_bgr)) {
953 right_aliased_ids.push_back(overlap_id); 956 right_aliased_ids.push_back(overlap_id);
954 } 957 }
955 }); 958 });
diff --git a/src/video_core/texture_cache/util.cpp b/src/video_core/texture_cache/util.cpp
index a0bc1f7b6..2c42d1449 100644
--- a/src/video_core/texture_cache/util.cpp
+++ b/src/video_core/texture_cache/util.cpp
@@ -1035,13 +1035,13 @@ bool IsPitchLinearSameSize(const ImageInfo& lhs, const ImageInfo& rhs, bool stri
1035 1035
1036std::optional<OverlapResult> ResolveOverlap(const ImageInfo& new_info, GPUVAddr gpu_addr, 1036std::optional<OverlapResult> ResolveOverlap(const ImageInfo& new_info, GPUVAddr gpu_addr,
1037 VAddr cpu_addr, const ImageBase& overlap, 1037 VAddr cpu_addr, const ImageBase& overlap,
1038 bool strict_size, bool broken_views) { 1038 bool strict_size, bool broken_views, bool native_bgr) {
1039 ASSERT(new_info.type != ImageType::Linear); 1039 ASSERT(new_info.type != ImageType::Linear);
1040 ASSERT(overlap.info.type != ImageType::Linear); 1040 ASSERT(overlap.info.type != ImageType::Linear);
1041 if (!IsLayerStrideCompatible(new_info, overlap.info)) { 1041 if (!IsLayerStrideCompatible(new_info, overlap.info)) {
1042 return std::nullopt; 1042 return std::nullopt;
1043 } 1043 }
1044 if (!IsViewCompatible(overlap.info.format, new_info.format, broken_views)) { 1044 if (!IsViewCompatible(overlap.info.format, new_info.format, broken_views, native_bgr)) {
1045 return std::nullopt; 1045 return std::nullopt;
1046 } 1046 }
1047 if (gpu_addr == overlap.gpu_addr) { 1047 if (gpu_addr == overlap.gpu_addr) {
@@ -1085,14 +1085,14 @@ bool IsLayerStrideCompatible(const ImageInfo& lhs, const ImageInfo& rhs) {
1085 1085
1086std::optional<SubresourceBase> FindSubresource(const ImageInfo& candidate, const ImageBase& image, 1086std::optional<SubresourceBase> FindSubresource(const ImageInfo& candidate, const ImageBase& image,
1087 GPUVAddr candidate_addr, RelaxedOptions options, 1087 GPUVAddr candidate_addr, RelaxedOptions options,
1088 bool broken_views) { 1088 bool broken_views, bool native_bgr) {
1089 const std::optional<SubresourceBase> base = image.TryFindBase(candidate_addr); 1089 const std::optional<SubresourceBase> base = image.TryFindBase(candidate_addr);
1090 if (!base) { 1090 if (!base) {
1091 return std::nullopt; 1091 return std::nullopt;
1092 } 1092 }
1093 const ImageInfo& existing = image.info; 1093 const ImageInfo& existing = image.info;
1094 if (False(options & RelaxedOptions::Format)) { 1094 if (False(options & RelaxedOptions::Format)) {
1095 if (!IsViewCompatible(existing.format, candidate.format, broken_views)) { 1095 if (!IsViewCompatible(existing.format, candidate.format, broken_views, native_bgr)) {
1096 return std::nullopt; 1096 return std::nullopt;
1097 } 1097 }
1098 } 1098 }
@@ -1129,8 +1129,9 @@ std::optional<SubresourceBase> FindSubresource(const ImageInfo& candidate, const
1129} 1129}
1130 1130
1131bool IsSubresource(const ImageInfo& candidate, const ImageBase& image, GPUVAddr candidate_addr, 1131bool IsSubresource(const ImageInfo& candidate, const ImageBase& image, GPUVAddr candidate_addr,
1132 RelaxedOptions options, bool broken_views) { 1132 RelaxedOptions options, bool broken_views, bool native_bgr) {
1133 return FindSubresource(candidate, image, candidate_addr, options, broken_views).has_value(); 1133 return FindSubresource(candidate, image, candidate_addr, options, broken_views, native_bgr)
1134 .has_value();
1134} 1135}
1135 1136
1136void DeduceBlitImages(ImageInfo& dst_info, ImageInfo& src_info, const ImageBase* dst, 1137void DeduceBlitImages(ImageInfo& dst_info, ImageInfo& src_info, const ImageBase* dst,
diff --git a/src/video_core/texture_cache/util.h b/src/video_core/texture_cache/util.h
index 52a9207d6..4d0072867 100644
--- a/src/video_core/texture_cache/util.h
+++ b/src/video_core/texture_cache/util.h
@@ -87,7 +87,8 @@ void SwizzleImage(Tegra::MemoryManager& gpu_memory, GPUVAddr gpu_addr, const Ima
87[[nodiscard]] std::optional<OverlapResult> ResolveOverlap(const ImageInfo& new_info, 87[[nodiscard]] std::optional<OverlapResult> ResolveOverlap(const ImageInfo& new_info,
88 GPUVAddr gpu_addr, VAddr cpu_addr, 88 GPUVAddr gpu_addr, VAddr cpu_addr,
89 const ImageBase& overlap, 89 const ImageBase& overlap,
90 bool strict_size, bool broken_views); 90 bool strict_size, bool broken_views,
91 bool native_bgr);
91 92
92[[nodiscard]] bool IsLayerStrideCompatible(const ImageInfo& lhs, const ImageInfo& rhs); 93[[nodiscard]] bool IsLayerStrideCompatible(const ImageInfo& lhs, const ImageInfo& rhs);
93 94
@@ -95,11 +96,11 @@ void SwizzleImage(Tegra::MemoryManager& gpu_memory, GPUVAddr gpu_addr, const Ima
95 const ImageBase& image, 96 const ImageBase& image,
96 GPUVAddr candidate_addr, 97 GPUVAddr candidate_addr,
97 RelaxedOptions options, 98 RelaxedOptions options,
98 bool broken_views); 99 bool broken_views, bool native_bgr);
99 100
100[[nodiscard]] bool IsSubresource(const ImageInfo& candidate, const ImageBase& image, 101[[nodiscard]] bool IsSubresource(const ImageInfo& candidate, const ImageBase& image,
101 GPUVAddr candidate_addr, RelaxedOptions options, 102 GPUVAddr candidate_addr, RelaxedOptions options, bool broken_views,
102 bool broken_views); 103 bool native_bgr);
103 104
104void DeduceBlitImages(ImageInfo& dst_info, ImageInfo& src_info, const ImageBase* dst, 105void DeduceBlitImages(ImageInfo& dst_info, ImageInfo& src_info, const ImageBase* dst,
105 const ImageBase* src); 106 const ImageBase* src);