diff options
Diffstat (limited to 'src/network')
| -rw-r--r-- | src/network/CMakeLists.txt | 6 | ||||
| -rw-r--r-- | src/network/announce_multiplayer_session.cpp | 164 | ||||
| -rw-r--r-- | src/network/announce_multiplayer_session.h | 98 | ||||
| -rw-r--r-- | src/network/room.cpp | 14 | ||||
| -rw-r--r-- | src/network/room_member.cpp | 6 | ||||
| -rw-r--r-- | src/network/room_member.h | 2 |
6 files changed, 282 insertions, 8 deletions
diff --git a/src/network/CMakeLists.txt b/src/network/CMakeLists.txt index 312f79b68..6f8ca4b90 100644 --- a/src/network/CMakeLists.txt +++ b/src/network/CMakeLists.txt | |||
| @@ -2,6 +2,8 @@ | |||
| 2 | # SPDX-License-Identifier: GPL-3.0-or-later | 2 | # SPDX-License-Identifier: GPL-3.0-or-later |
| 3 | 3 | ||
| 4 | add_library(network STATIC | 4 | add_library(network STATIC |
| 5 | announce_multiplayer_session.cpp | ||
| 6 | announce_multiplayer_session.h | ||
| 5 | network.cpp | 7 | network.cpp |
| 6 | network.h | 8 | network.h |
| 7 | packet.cpp | 9 | packet.cpp |
| @@ -17,3 +19,7 @@ add_library(network STATIC | |||
| 17 | create_target_directory_groups(network) | 19 | create_target_directory_groups(network) |
| 18 | 20 | ||
| 19 | target_link_libraries(network PRIVATE common enet Boost::boost) | 21 | target_link_libraries(network PRIVATE common enet Boost::boost) |
| 22 | if (ENABLE_WEB_SERVICE) | ||
| 23 | target_compile_definitions(network PRIVATE -DENABLE_WEB_SERVICE) | ||
| 24 | target_link_libraries(network PRIVATE web_service) | ||
| 25 | endif() | ||
diff --git a/src/network/announce_multiplayer_session.cpp b/src/network/announce_multiplayer_session.cpp new file mode 100644 index 000000000..6737ce85a --- /dev/null +++ b/src/network/announce_multiplayer_session.cpp | |||
| @@ -0,0 +1,164 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2017 Citra Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #include <chrono> | ||
| 5 | #include <future> | ||
| 6 | #include <vector> | ||
| 7 | #include "announce_multiplayer_session.h" | ||
| 8 | #include "common/announce_multiplayer_room.h" | ||
| 9 | #include "common/assert.h" | ||
| 10 | #include "common/settings.h" | ||
| 11 | #include "network/network.h" | ||
| 12 | |||
| 13 | #ifdef ENABLE_WEB_SERVICE | ||
| 14 | #include "web_service/announce_room_json.h" | ||
| 15 | #endif | ||
| 16 | |||
| 17 | namespace Core { | ||
| 18 | |||
| 19 | // Time between room is announced to web_service | ||
| 20 | static constexpr std::chrono::seconds announce_time_interval(15); | ||
| 21 | |||
| 22 | AnnounceMultiplayerSession::AnnounceMultiplayerSession(Network::RoomNetwork& room_network_) | ||
| 23 | : room_network{room_network_} { | ||
| 24 | #ifdef ENABLE_WEB_SERVICE | ||
| 25 | backend = std::make_unique<WebService::RoomJson>(Settings::values.web_api_url.GetValue(), | ||
| 26 | Settings::values.yuzu_username.GetValue(), | ||
| 27 | Settings::values.yuzu_token.GetValue()); | ||
| 28 | #else | ||
| 29 | backend = std::make_unique<AnnounceMultiplayerRoom::NullBackend>(); | ||
| 30 | #endif | ||
| 31 | } | ||
| 32 | |||
| 33 | WebService::WebResult AnnounceMultiplayerSession::Register() { | ||
| 34 | auto room = room_network.GetRoom().lock(); | ||
| 35 | if (!room) { | ||
| 36 | return WebService::WebResult{WebService::WebResult::Code::LibError, | ||
| 37 | "Network is not initialized", ""}; | ||
| 38 | } | ||
| 39 | if (room->GetState() != Network::Room::State::Open) { | ||
| 40 | return WebService::WebResult{WebService::WebResult::Code::LibError, "Room is not open", ""}; | ||
| 41 | } | ||
| 42 | UpdateBackendData(room); | ||
| 43 | WebService::WebResult result = backend->Register(); | ||
| 44 | if (result.result_code != WebService::WebResult::Code::Success) { | ||
| 45 | return result; | ||
| 46 | } | ||
| 47 | LOG_INFO(WebService, "Room has been registered"); | ||
| 48 | room->SetVerifyUID(result.returned_data); | ||
| 49 | registered = true; | ||
| 50 | return WebService::WebResult{WebService::WebResult::Code::Success, "", ""}; | ||
| 51 | } | ||
| 52 | |||
| 53 | void AnnounceMultiplayerSession::Start() { | ||
| 54 | if (announce_multiplayer_thread) { | ||
| 55 | Stop(); | ||
| 56 | } | ||
| 57 | shutdown_event.Reset(); | ||
| 58 | announce_multiplayer_thread = | ||
| 59 | std::make_unique<std::thread>(&AnnounceMultiplayerSession::AnnounceMultiplayerLoop, this); | ||
| 60 | } | ||
| 61 | |||
| 62 | void AnnounceMultiplayerSession::Stop() { | ||
| 63 | if (announce_multiplayer_thread) { | ||
| 64 | shutdown_event.Set(); | ||
| 65 | announce_multiplayer_thread->join(); | ||
| 66 | announce_multiplayer_thread.reset(); | ||
| 67 | backend->Delete(); | ||
| 68 | registered = false; | ||
| 69 | } | ||
| 70 | } | ||
| 71 | |||
| 72 | AnnounceMultiplayerSession::CallbackHandle AnnounceMultiplayerSession::BindErrorCallback( | ||
| 73 | std::function<void(const WebService::WebResult&)> function) { | ||
| 74 | std::lock_guard lock(callback_mutex); | ||
| 75 | auto handle = std::make_shared<std::function<void(const WebService::WebResult&)>>(function); | ||
| 76 | error_callbacks.insert(handle); | ||
| 77 | return handle; | ||
| 78 | } | ||
| 79 | |||
| 80 | void AnnounceMultiplayerSession::UnbindErrorCallback(CallbackHandle handle) { | ||
| 81 | std::lock_guard lock(callback_mutex); | ||
| 82 | error_callbacks.erase(handle); | ||
| 83 | } | ||
| 84 | |||
| 85 | AnnounceMultiplayerSession::~AnnounceMultiplayerSession() { | ||
| 86 | Stop(); | ||
| 87 | } | ||
| 88 | |||
| 89 | void AnnounceMultiplayerSession::UpdateBackendData(std::shared_ptr<Network::Room> room) { | ||
| 90 | Network::RoomInformation room_information = room->GetRoomInformation(); | ||
| 91 | std::vector<AnnounceMultiplayerRoom::Member> memberlist = room->GetRoomMemberList(); | ||
| 92 | backend->SetRoomInformation(room_information.name, room_information.description, | ||
| 93 | room_information.port, room_information.member_slots, | ||
| 94 | Network::network_version, room->HasPassword(), | ||
| 95 | room_information.preferred_game); | ||
| 96 | backend->ClearPlayers(); | ||
| 97 | for (const auto& member : memberlist) { | ||
| 98 | backend->AddPlayer(member); | ||
| 99 | } | ||
| 100 | } | ||
| 101 | |||
| 102 | void AnnounceMultiplayerSession::AnnounceMultiplayerLoop() { | ||
| 103 | // Invokes all current bound error callbacks. | ||
| 104 | const auto ErrorCallback = [this](WebService::WebResult result) { | ||
| 105 | std::lock_guard lock(callback_mutex); | ||
| 106 | for (auto callback : error_callbacks) { | ||
| 107 | (*callback)(result); | ||
| 108 | } | ||
| 109 | }; | ||
| 110 | |||
| 111 | if (!registered) { | ||
| 112 | WebService::WebResult result = Register(); | ||
| 113 | if (result.result_code != WebService::WebResult::Code::Success) { | ||
| 114 | ErrorCallback(result); | ||
| 115 | return; | ||
| 116 | } | ||
| 117 | } | ||
| 118 | |||
| 119 | auto update_time = std::chrono::steady_clock::now(); | ||
| 120 | std::future<WebService::WebResult> future; | ||
| 121 | while (!shutdown_event.WaitUntil(update_time)) { | ||
| 122 | update_time += announce_time_interval; | ||
| 123 | auto room = room_network.GetRoom().lock(); | ||
| 124 | if (!room) { | ||
| 125 | break; | ||
| 126 | } | ||
| 127 | if (room->GetState() != Network::Room::State::Open) { | ||
| 128 | break; | ||
| 129 | } | ||
| 130 | UpdateBackendData(room); | ||
| 131 | WebService::WebResult result = backend->Update(); | ||
| 132 | if (result.result_code != WebService::WebResult::Code::Success) { | ||
| 133 | ErrorCallback(result); | ||
| 134 | } | ||
| 135 | if (result.result_string == "404") { | ||
| 136 | registered = false; | ||
| 137 | // Needs to register the room again | ||
| 138 | WebService::WebResult register_result = Register(); | ||
| 139 | if (register_result.result_code != WebService::WebResult::Code::Success) { | ||
| 140 | ErrorCallback(register_result); | ||
| 141 | } | ||
| 142 | } | ||
| 143 | } | ||
| 144 | } | ||
| 145 | |||
| 146 | AnnounceMultiplayerRoom::RoomList AnnounceMultiplayerSession::GetRoomList() { | ||
| 147 | return backend->GetRoomList(); | ||
| 148 | } | ||
| 149 | |||
| 150 | bool AnnounceMultiplayerSession::IsRunning() const { | ||
| 151 | return announce_multiplayer_thread != nullptr; | ||
| 152 | } | ||
| 153 | |||
| 154 | void AnnounceMultiplayerSession::UpdateCredentials() { | ||
| 155 | ASSERT_MSG(!IsRunning(), "Credentials can only be updated when session is not running"); | ||
| 156 | |||
| 157 | #ifdef ENABLE_WEB_SERVICE | ||
| 158 | backend = std::make_unique<WebService::RoomJson>(Settings::values.web_api_url.GetValue(), | ||
| 159 | Settings::values.yuzu_username.GetValue(), | ||
| 160 | Settings::values.yuzu_token.GetValue()); | ||
| 161 | #endif | ||
| 162 | } | ||
| 163 | |||
| 164 | } // namespace Core | ||
diff --git a/src/network/announce_multiplayer_session.h b/src/network/announce_multiplayer_session.h new file mode 100644 index 000000000..db790f7d2 --- /dev/null +++ b/src/network/announce_multiplayer_session.h | |||
| @@ -0,0 +1,98 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2017 Citra Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #pragma once | ||
| 5 | |||
| 6 | #include <atomic> | ||
| 7 | #include <functional> | ||
| 8 | #include <memory> | ||
| 9 | #include <mutex> | ||
| 10 | #include <set> | ||
| 11 | #include <thread> | ||
| 12 | #include "common/announce_multiplayer_room.h" | ||
| 13 | #include "common/common_types.h" | ||
| 14 | #include "common/thread.h" | ||
| 15 | |||
| 16 | namespace Network { | ||
| 17 | class Room; | ||
| 18 | class RoomNetwork; | ||
| 19 | } // namespace Network | ||
| 20 | |||
| 21 | namespace Core { | ||
| 22 | |||
| 23 | /** | ||
| 24 | * Instruments AnnounceMultiplayerRoom::Backend. | ||
| 25 | * Creates a thread that regularly updates the room information and submits them | ||
| 26 | * An async get of room information is also possible | ||
| 27 | */ | ||
| 28 | class AnnounceMultiplayerSession { | ||
| 29 | public: | ||
| 30 | using CallbackHandle = std::shared_ptr<std::function<void(const WebService::WebResult&)>>; | ||
| 31 | AnnounceMultiplayerSession(Network::RoomNetwork& room_network_); | ||
| 32 | ~AnnounceMultiplayerSession(); | ||
| 33 | |||
| 34 | /** | ||
| 35 | * Allows to bind a function that will get called if the announce encounters an error | ||
| 36 | * @param function The function that gets called | ||
| 37 | * @return A handle that can be used the unbind the function | ||
| 38 | */ | ||
| 39 | CallbackHandle BindErrorCallback(std::function<void(const WebService::WebResult&)> function); | ||
| 40 | |||
| 41 | /** | ||
| 42 | * Unbind a function from the error callbacks | ||
| 43 | * @param handle The handle for the function that should get unbind | ||
| 44 | */ | ||
| 45 | void UnbindErrorCallback(CallbackHandle handle); | ||
| 46 | |||
| 47 | /** | ||
| 48 | * Registers a room to web services | ||
| 49 | * @return The result of the registration attempt. | ||
| 50 | */ | ||
| 51 | WebService::WebResult Register(); | ||
| 52 | |||
| 53 | /** | ||
| 54 | * Starts the announce of a room to web services | ||
| 55 | */ | ||
| 56 | void Start(); | ||
| 57 | |||
| 58 | /** | ||
| 59 | * Stops the announce to web services | ||
| 60 | */ | ||
| 61 | void Stop(); | ||
| 62 | |||
| 63 | /** | ||
| 64 | * Returns a list of all room information the backend got | ||
| 65 | * @param func A function that gets executed when the async get finished, e.g. a signal | ||
| 66 | * @return a list of rooms received from the web service | ||
| 67 | */ | ||
| 68 | AnnounceMultiplayerRoom::RoomList GetRoomList(); | ||
| 69 | |||
| 70 | /** | ||
| 71 | * Whether the announce session is still running | ||
| 72 | */ | ||
| 73 | bool IsRunning() const; | ||
| 74 | |||
| 75 | /** | ||
| 76 | * Recreates the backend, updating the credentials. | ||
| 77 | * This can only be used when the announce session is not running. | ||
| 78 | */ | ||
| 79 | void UpdateCredentials(); | ||
| 80 | |||
| 81 | private: | ||
| 82 | void UpdateBackendData(std::shared_ptr<Network::Room> room); | ||
| 83 | void AnnounceMultiplayerLoop(); | ||
| 84 | |||
| 85 | Common::Event shutdown_event; | ||
| 86 | std::mutex callback_mutex; | ||
| 87 | std::set<CallbackHandle> error_callbacks; | ||
| 88 | std::unique_ptr<std::thread> announce_multiplayer_thread; | ||
| 89 | |||
| 90 | /// Backend interface that logs fields | ||
| 91 | std::unique_ptr<AnnounceMultiplayerRoom::Backend> backend; | ||
| 92 | |||
| 93 | std::atomic_bool registered = false; ///< Whether the room has been registered | ||
| 94 | |||
| 95 | Network::RoomNetwork& room_network; | ||
| 96 | }; | ||
| 97 | |||
| 98 | } // namespace Core | ||
diff --git a/src/network/room.cpp b/src/network/room.cpp index b06797bf1..8c63b255b 100644 --- a/src/network/room.cpp +++ b/src/network/room.cpp | |||
| @@ -221,7 +221,7 @@ public: | |||
| 221 | * Extracts the game name from a received ENet packet and broadcasts it. | 221 | * Extracts the game name from a received ENet packet and broadcasts it. |
| 222 | * @param event The ENet event that was received. | 222 | * @param event The ENet event that was received. |
| 223 | */ | 223 | */ |
| 224 | void HandleGameNamePacket(const ENetEvent* event); | 224 | void HandleGameInfoPacket(const ENetEvent* event); |
| 225 | 225 | ||
| 226 | /** | 226 | /** |
| 227 | * Removes the client from the members list if it was in it and announces the change | 227 | * Removes the client from the members list if it was in it and announces the change |
| @@ -234,7 +234,7 @@ public: | |||
| 234 | void Room::RoomImpl::ServerLoop() { | 234 | void Room::RoomImpl::ServerLoop() { |
| 235 | while (state != State::Closed) { | 235 | while (state != State::Closed) { |
| 236 | ENetEvent event; | 236 | ENetEvent event; |
| 237 | if (enet_host_service(server, &event, 50) > 0) { | 237 | if (enet_host_service(server, &event, 5) > 0) { |
| 238 | switch (event.type) { | 238 | switch (event.type) { |
| 239 | case ENET_EVENT_TYPE_RECEIVE: | 239 | case ENET_EVENT_TYPE_RECEIVE: |
| 240 | switch (event.packet->data[0]) { | 240 | switch (event.packet->data[0]) { |
| @@ -242,7 +242,7 @@ void Room::RoomImpl::ServerLoop() { | |||
| 242 | HandleJoinRequest(&event); | 242 | HandleJoinRequest(&event); |
| 243 | break; | 243 | break; |
| 244 | case IdSetGameInfo: | 244 | case IdSetGameInfo: |
| 245 | HandleGameNamePacket(&event); | 245 | HandleGameInfoPacket(&event); |
| 246 | break; | 246 | break; |
| 247 | case IdProxyPacket: | 247 | case IdProxyPacket: |
| 248 | HandleProxyPacket(&event); | 248 | HandleProxyPacket(&event); |
| @@ -778,6 +778,7 @@ void Room::RoomImpl::BroadcastRoomInformation() { | |||
| 778 | packet.Write(member.fake_ip); | 778 | packet.Write(member.fake_ip); |
| 779 | packet.Write(member.game_info.name); | 779 | packet.Write(member.game_info.name); |
| 780 | packet.Write(member.game_info.id); | 780 | packet.Write(member.game_info.id); |
| 781 | packet.Write(member.game_info.version); | ||
| 781 | packet.Write(member.user_data.username); | 782 | packet.Write(member.user_data.username); |
| 782 | packet.Write(member.user_data.display_name); | 783 | packet.Write(member.user_data.display_name); |
| 783 | packet.Write(member.user_data.avatar_url); | 784 | packet.Write(member.user_data.avatar_url); |
| @@ -817,6 +818,7 @@ void Room::RoomImpl::HandleProxyPacket(const ENetEvent* event) { | |||
| 817 | in_packet.IgnoreBytes(sizeof(u16)); // Port | 818 | in_packet.IgnoreBytes(sizeof(u16)); // Port |
| 818 | 819 | ||
| 819 | in_packet.IgnoreBytes(sizeof(u8)); // Protocol | 820 | in_packet.IgnoreBytes(sizeof(u8)); // Protocol |
| 821 | |||
| 820 | bool broadcast; | 822 | bool broadcast; |
| 821 | in_packet.Read(broadcast); // Broadcast | 823 | in_packet.Read(broadcast); // Broadcast |
| 822 | 824 | ||
| @@ -909,7 +911,7 @@ void Room::RoomImpl::HandleChatPacket(const ENetEvent* event) { | |||
| 909 | } | 911 | } |
| 910 | } | 912 | } |
| 911 | 913 | ||
| 912 | void Room::RoomImpl::HandleGameNamePacket(const ENetEvent* event) { | 914 | void Room::RoomImpl::HandleGameInfoPacket(const ENetEvent* event) { |
| 913 | Packet in_packet; | 915 | Packet in_packet; |
| 914 | in_packet.Append(event->packet->data, event->packet->dataLength); | 916 | in_packet.Append(event->packet->data, event->packet->dataLength); |
| 915 | 917 | ||
| @@ -917,6 +919,7 @@ void Room::RoomImpl::HandleGameNamePacket(const ENetEvent* event) { | |||
| 917 | GameInfo game_info; | 919 | GameInfo game_info; |
| 918 | in_packet.Read(game_info.name); | 920 | in_packet.Read(game_info.name); |
| 919 | in_packet.Read(game_info.id); | 921 | in_packet.Read(game_info.id); |
| 922 | in_packet.Read(game_info.version); | ||
| 920 | 923 | ||
| 921 | { | 924 | { |
| 922 | std::lock_guard lock(member_mutex); | 925 | std::lock_guard lock(member_mutex); |
| @@ -935,7 +938,8 @@ void Room::RoomImpl::HandleGameNamePacket(const ENetEvent* event) { | |||
| 935 | if (game_info.name.empty()) { | 938 | if (game_info.name.empty()) { |
| 936 | LOG_INFO(Network, "{} is not playing", display_name); | 939 | LOG_INFO(Network, "{} is not playing", display_name); |
| 937 | } else { | 940 | } else { |
| 938 | LOG_INFO(Network, "{} is playing {}", display_name, game_info.name); | 941 | LOG_INFO(Network, "{} is playing {} ({})", display_name, game_info.name, |
| 942 | game_info.version); | ||
| 939 | } | 943 | } |
| 940 | } | 944 | } |
| 941 | } | 945 | } |
diff --git a/src/network/room_member.cpp b/src/network/room_member.cpp index 9f08bf611..06818af78 100644 --- a/src/network/room_member.cpp +++ b/src/network/room_member.cpp | |||
| @@ -103,7 +103,7 @@ public: | |||
| 103 | 103 | ||
| 104 | /** | 104 | /** |
| 105 | * Extracts a ProxyPacket from a received ENet packet. | 105 | * Extracts a ProxyPacket from a received ENet packet. |
| 106 | * @param event The ENet event that was received. | 106 | * @param event The ENet event that was received. |
| 107 | */ | 107 | */ |
| 108 | void HandleProxyPackets(const ENetEvent* event); | 108 | void HandleProxyPackets(const ENetEvent* event); |
| 109 | 109 | ||
| @@ -159,7 +159,7 @@ void RoomMember::RoomMemberImpl::MemberLoop() { | |||
| 159 | while (IsConnected()) { | 159 | while (IsConnected()) { |
| 160 | std::lock_guard lock(network_mutex); | 160 | std::lock_guard lock(network_mutex); |
| 161 | ENetEvent event; | 161 | ENetEvent event; |
| 162 | if (enet_host_service(client, &event, 100) > 0) { | 162 | if (enet_host_service(client, &event, 5) > 0) { |
| 163 | switch (event.type) { | 163 | switch (event.type) { |
| 164 | case ENET_EVENT_TYPE_RECEIVE: | 164 | case ENET_EVENT_TYPE_RECEIVE: |
| 165 | switch (event.packet->data[0]) { | 165 | switch (event.packet->data[0]) { |
| @@ -315,6 +315,7 @@ void RoomMember::RoomMemberImpl::HandleRoomInformationPacket(const ENetEvent* ev | |||
| 315 | packet.Read(member.fake_ip); | 315 | packet.Read(member.fake_ip); |
| 316 | packet.Read(member.game_info.name); | 316 | packet.Read(member.game_info.name); |
| 317 | packet.Read(member.game_info.id); | 317 | packet.Read(member.game_info.id); |
| 318 | packet.Read(member.game_info.version); | ||
| 318 | packet.Read(member.username); | 319 | packet.Read(member.username); |
| 319 | packet.Read(member.display_name); | 320 | packet.Read(member.display_name); |
| 320 | packet.Read(member.avatar_url); | 321 | packet.Read(member.avatar_url); |
| @@ -622,6 +623,7 @@ void RoomMember::SendGameInfo(const GameInfo& game_info) { | |||
| 622 | packet.Write(static_cast<u8>(IdSetGameInfo)); | 623 | packet.Write(static_cast<u8>(IdSetGameInfo)); |
| 623 | packet.Write(game_info.name); | 624 | packet.Write(game_info.name); |
| 624 | packet.Write(game_info.id); | 625 | packet.Write(game_info.id); |
| 626 | packet.Write(game_info.version); | ||
| 625 | room_member_impl->Send(std::move(packet)); | 627 | room_member_impl->Send(std::move(packet)); |
| 626 | } | 628 | } |
| 627 | 629 | ||
diff --git a/src/network/room_member.h b/src/network/room_member.h index 4252b7146..f578f7f6a 100644 --- a/src/network/room_member.h +++ b/src/network/room_member.h | |||
| @@ -146,7 +146,7 @@ public: | |||
| 146 | const std::string& password = "", const std::string& token = ""); | 146 | const std::string& password = "", const std::string& token = ""); |
| 147 | 147 | ||
| 148 | /** | 148 | /** |
| 149 | * Sends a WiFi packet to the room. | 149 | * Sends a Proxy packet to the room. |
| 150 | * @param packet The WiFi packet to send. | 150 | * @param packet The WiFi packet to send. |
| 151 | */ | 151 | */ |
| 152 | void SendProxyPacket(const ProxyPacket& packet); | 152 | void SendProxyPacket(const ProxyPacket& packet); |