diff options
Diffstat (limited to 'src/core')
79 files changed, 695 insertions, 476 deletions
diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index 9e23afe85..c59107102 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt | |||
| @@ -458,7 +458,7 @@ add_library(core STATIC | |||
| 458 | create_target_directory_groups(core) | 458 | create_target_directory_groups(core) |
| 459 | 459 | ||
| 460 | target_link_libraries(core PUBLIC common PRIVATE audio_core video_core) | 460 | target_link_libraries(core PUBLIC common PRIVATE audio_core video_core) |
| 461 | target_link_libraries(core PUBLIC Boost::boost PRIVATE fmt lz4_static mbedtls opus unicorn open_source_archives) | 461 | target_link_libraries(core PUBLIC Boost::boost PRIVATE fmt mbedtls opus unicorn open_source_archives) |
| 462 | if (ENABLE_WEB_SERVICE) | 462 | if (ENABLE_WEB_SERVICE) |
| 463 | target_compile_definitions(core PRIVATE -DENABLE_WEB_SERVICE) | 463 | target_compile_definitions(core PRIVATE -DENABLE_WEB_SERVICE) |
| 464 | target_link_libraries(core PRIVATE web_service) | 464 | target_link_libraries(core PRIVATE web_service) |
diff --git a/src/core/arm/dynarmic/arm_dynarmic.cpp b/src/core/arm/dynarmic/arm_dynarmic.cpp index 4fdc12f11..49145911b 100644 --- a/src/core/arm/dynarmic/arm_dynarmic.cpp +++ b/src/core/arm/dynarmic/arm_dynarmic.cpp | |||
| @@ -26,7 +26,6 @@ using Vector = Dynarmic::A64::Vector; | |||
| 26 | class ARM_Dynarmic_Callbacks : public Dynarmic::A64::UserCallbacks { | 26 | class ARM_Dynarmic_Callbacks : public Dynarmic::A64::UserCallbacks { |
| 27 | public: | 27 | public: |
| 28 | explicit ARM_Dynarmic_Callbacks(ARM_Dynarmic& parent) : parent(parent) {} | 28 | explicit ARM_Dynarmic_Callbacks(ARM_Dynarmic& parent) : parent(parent) {} |
| 29 | ~ARM_Dynarmic_Callbacks() = default; | ||
| 30 | 29 | ||
| 31 | u8 MemoryRead8(u64 vaddr) override { | 30 | u8 MemoryRead8(u64 vaddr) override { |
| 32 | return Memory::Read8(vaddr); | 31 | return Memory::Read8(vaddr); |
| @@ -164,7 +163,6 @@ MICROPROFILE_DEFINE(ARM_Jit_Dynarmic, "ARM JIT", "Dynarmic", MP_RGB(255, 64, 64) | |||
| 164 | 163 | ||
| 165 | void ARM_Dynarmic::Run() { | 164 | void ARM_Dynarmic::Run() { |
| 166 | MICROPROFILE_SCOPE(ARM_Jit_Dynarmic); | 165 | MICROPROFILE_SCOPE(ARM_Jit_Dynarmic); |
| 167 | ASSERT(Memory::GetCurrentPageTable() == current_page_table); | ||
| 168 | 166 | ||
| 169 | jit->Run(); | 167 | jit->Run(); |
| 170 | } | 168 | } |
| @@ -279,7 +277,6 @@ void ARM_Dynarmic::ClearExclusiveState() { | |||
| 279 | 277 | ||
| 280 | void ARM_Dynarmic::PageTableChanged() { | 278 | void ARM_Dynarmic::PageTableChanged() { |
| 281 | jit = MakeJit(); | 279 | jit = MakeJit(); |
| 282 | current_page_table = Memory::GetCurrentPageTable(); | ||
| 283 | } | 280 | } |
| 284 | 281 | ||
| 285 | DynarmicExclusiveMonitor::DynarmicExclusiveMonitor(std::size_t core_count) : monitor(core_count) {} | 282 | DynarmicExclusiveMonitor::DynarmicExclusiveMonitor(std::size_t core_count) : monitor(core_count) {} |
diff --git a/src/core/arm/dynarmic/arm_dynarmic.h b/src/core/arm/dynarmic/arm_dynarmic.h index aada1e862..d867c2a50 100644 --- a/src/core/arm/dynarmic/arm_dynarmic.h +++ b/src/core/arm/dynarmic/arm_dynarmic.h | |||
| @@ -12,10 +12,6 @@ | |||
| 12 | #include "core/arm/exclusive_monitor.h" | 12 | #include "core/arm/exclusive_monitor.h" |
| 13 | #include "core/arm/unicorn/arm_unicorn.h" | 13 | #include "core/arm/unicorn/arm_unicorn.h" |
| 14 | 14 | ||
| 15 | namespace Common { | ||
| 16 | struct PageTable; | ||
| 17 | } | ||
| 18 | |||
| 19 | namespace Core::Timing { | 15 | namespace Core::Timing { |
| 20 | class CoreTiming; | 16 | class CoreTiming; |
| 21 | } | 17 | } |
| @@ -29,7 +25,7 @@ class ARM_Dynarmic final : public ARM_Interface { | |||
| 29 | public: | 25 | public: |
| 30 | ARM_Dynarmic(Timing::CoreTiming& core_timing, ExclusiveMonitor& exclusive_monitor, | 26 | ARM_Dynarmic(Timing::CoreTiming& core_timing, ExclusiveMonitor& exclusive_monitor, |
| 31 | std::size_t core_index); | 27 | std::size_t core_index); |
| 32 | ~ARM_Dynarmic(); | 28 | ~ARM_Dynarmic() override; |
| 33 | 29 | ||
| 34 | void MapBackingMemory(VAddr address, std::size_t size, u8* memory, | 30 | void MapBackingMemory(VAddr address, std::size_t size, u8* memory, |
| 35 | Kernel::VMAPermission perms) override; | 31 | Kernel::VMAPermission perms) override; |
| @@ -69,14 +65,12 @@ private: | |||
| 69 | std::size_t core_index; | 65 | std::size_t core_index; |
| 70 | Timing::CoreTiming& core_timing; | 66 | Timing::CoreTiming& core_timing; |
| 71 | DynarmicExclusiveMonitor& exclusive_monitor; | 67 | DynarmicExclusiveMonitor& exclusive_monitor; |
| 72 | |||
| 73 | Common::PageTable* current_page_table = nullptr; | ||
| 74 | }; | 68 | }; |
| 75 | 69 | ||
| 76 | class DynarmicExclusiveMonitor final : public ExclusiveMonitor { | 70 | class DynarmicExclusiveMonitor final : public ExclusiveMonitor { |
| 77 | public: | 71 | public: |
| 78 | explicit DynarmicExclusiveMonitor(std::size_t core_count); | 72 | explicit DynarmicExclusiveMonitor(std::size_t core_count); |
| 79 | ~DynarmicExclusiveMonitor(); | 73 | ~DynarmicExclusiveMonitor() override; |
| 80 | 74 | ||
| 81 | void SetExclusive(std::size_t core_index, VAddr addr) override; | 75 | void SetExclusive(std::size_t core_index, VAddr addr) override; |
| 82 | void ClearExclusive() override; | 76 | void ClearExclusive() override; |
diff --git a/src/core/arm/unicorn/arm_unicorn.cpp b/src/core/arm/unicorn/arm_unicorn.cpp index a542a098b..27309280c 100644 --- a/src/core/arm/unicorn/arm_unicorn.cpp +++ b/src/core/arm/unicorn/arm_unicorn.cpp | |||
| @@ -192,12 +192,13 @@ void ARM_Unicorn::ExecuteInstructions(int num_instructions) { | |||
| 192 | CHECKED(uc_emu_start(uc, GetPC(), 1ULL << 63, 0, num_instructions)); | 192 | CHECKED(uc_emu_start(uc, GetPC(), 1ULL << 63, 0, num_instructions)); |
| 193 | core_timing.AddTicks(num_instructions); | 193 | core_timing.AddTicks(num_instructions); |
| 194 | if (GDBStub::IsServerEnabled()) { | 194 | if (GDBStub::IsServerEnabled()) { |
| 195 | if (last_bkpt_hit) { | 195 | if (last_bkpt_hit && last_bkpt.type == GDBStub::BreakpointType::Execute) { |
| 196 | uc_reg_write(uc, UC_ARM64_REG_PC, &last_bkpt.address); | 196 | uc_reg_write(uc, UC_ARM64_REG_PC, &last_bkpt.address); |
| 197 | } | 197 | } |
| 198 | |||
| 198 | Kernel::Thread* thread = Kernel::GetCurrentThread(); | 199 | Kernel::Thread* thread = Kernel::GetCurrentThread(); |
| 199 | SaveContext(thread->GetContext()); | 200 | SaveContext(thread->GetContext()); |
| 200 | if (last_bkpt_hit || GDBStub::GetCpuStepFlag()) { | 201 | if (last_bkpt_hit || GDBStub::IsMemoryBreak() || GDBStub::GetCpuStepFlag()) { |
| 201 | last_bkpt_hit = false; | 202 | last_bkpt_hit = false; |
| 202 | GDBStub::Break(); | 203 | GDBStub::Break(); |
| 203 | GDBStub::SendTrap(thread, 5); | 204 | GDBStub::SendTrap(thread, 5); |
diff --git a/src/core/arm/unicorn/arm_unicorn.h b/src/core/arm/unicorn/arm_unicorn.h index dbd6955ea..1e44f0736 100644 --- a/src/core/arm/unicorn/arm_unicorn.h +++ b/src/core/arm/unicorn/arm_unicorn.h | |||
| @@ -18,7 +18,7 @@ namespace Core { | |||
| 18 | class ARM_Unicorn final : public ARM_Interface { | 18 | class ARM_Unicorn final : public ARM_Interface { |
| 19 | public: | 19 | public: |
| 20 | explicit ARM_Unicorn(Timing::CoreTiming& core_timing); | 20 | explicit ARM_Unicorn(Timing::CoreTiming& core_timing); |
| 21 | ~ARM_Unicorn(); | 21 | ~ARM_Unicorn() override; |
| 22 | 22 | ||
| 23 | void MapBackingMemory(VAddr address, std::size_t size, u8* memory, | 23 | void MapBackingMemory(VAddr address, std::size_t size, u8* memory, |
| 24 | Kernel::VMAPermission perms) override; | 24 | Kernel::VMAPermission perms) override; |
| @@ -50,7 +50,7 @@ private: | |||
| 50 | uc_engine* uc{}; | 50 | uc_engine* uc{}; |
| 51 | Timing::CoreTiming& core_timing; | 51 | Timing::CoreTiming& core_timing; |
| 52 | GDBStub::BreakpointAddress last_bkpt{}; | 52 | GDBStub::BreakpointAddress last_bkpt{}; |
| 53 | bool last_bkpt_hit; | 53 | bool last_bkpt_hit = false; |
| 54 | }; | 54 | }; |
| 55 | 55 | ||
| 56 | } // namespace Core | 56 | } // namespace Core |
diff --git a/src/core/core_cpu.cpp b/src/core/core_cpu.cpp index 1eefed6d0..e75741db0 100644 --- a/src/core/core_cpu.cpp +++ b/src/core/core_cpu.cpp | |||
| @@ -22,7 +22,7 @@ | |||
| 22 | namespace Core { | 22 | namespace Core { |
| 23 | 23 | ||
| 24 | void CpuBarrier::NotifyEnd() { | 24 | void CpuBarrier::NotifyEnd() { |
| 25 | std::unique_lock<std::mutex> lock(mutex); | 25 | std::unique_lock lock{mutex}; |
| 26 | end = true; | 26 | end = true; |
| 27 | condition.notify_all(); | 27 | condition.notify_all(); |
| 28 | } | 28 | } |
| @@ -34,7 +34,7 @@ bool CpuBarrier::Rendezvous() { | |||
| 34 | } | 34 | } |
| 35 | 35 | ||
| 36 | if (!end) { | 36 | if (!end) { |
| 37 | std::unique_lock<std::mutex> lock(mutex); | 37 | std::unique_lock lock{mutex}; |
| 38 | 38 | ||
| 39 | --cores_waiting; | 39 | --cores_waiting; |
| 40 | if (!cores_waiting) { | 40 | if (!cores_waiting) { |
| @@ -131,7 +131,7 @@ void Cpu::Reschedule() { | |||
| 131 | 131 | ||
| 132 | reschedule_pending = false; | 132 | reschedule_pending = false; |
| 133 | // Lock the global kernel mutex when we manipulate the HLE state | 133 | // Lock the global kernel mutex when we manipulate the HLE state |
| 134 | std::lock_guard<std::recursive_mutex> lock(HLE::g_hle_lock); | 134 | std::lock_guard lock{HLE::g_hle_lock}; |
| 135 | scheduler->Reschedule(); | 135 | scheduler->Reschedule(); |
| 136 | } | 136 | } |
| 137 | 137 | ||
diff --git a/src/core/file_sys/control_metadata.cpp b/src/core/file_sys/control_metadata.cpp index 83c184750..60ea9ad12 100644 --- a/src/core/file_sys/control_metadata.cpp +++ b/src/core/file_sys/control_metadata.cpp | |||
| @@ -67,7 +67,7 @@ std::string NACP::GetDeveloperName(Language language) const { | |||
| 67 | } | 67 | } |
| 68 | 68 | ||
| 69 | u64 NACP::GetTitleId() const { | 69 | u64 NACP::GetTitleId() const { |
| 70 | return raw.title_id; | 70 | return raw.save_data_owner_id; |
| 71 | } | 71 | } |
| 72 | 72 | ||
| 73 | u64 NACP::GetDLCBaseTitleId() const { | 73 | u64 NACP::GetDLCBaseTitleId() const { |
| @@ -80,11 +80,11 @@ std::string NACP::GetVersionString() const { | |||
| 80 | } | 80 | } |
| 81 | 81 | ||
| 82 | u64 NACP::GetDefaultNormalSaveSize() const { | 82 | u64 NACP::GetDefaultNormalSaveSize() const { |
| 83 | return raw.normal_save_data_size; | 83 | return raw.user_account_save_data_size; |
| 84 | } | 84 | } |
| 85 | 85 | ||
| 86 | u64 NACP::GetDefaultJournalSaveSize() const { | 86 | u64 NACP::GetDefaultJournalSaveSize() const { |
| 87 | return raw.journal_sava_data_size; | 87 | return raw.user_account_save_data_journal_size; |
| 88 | } | 88 | } |
| 89 | 89 | ||
| 90 | std::vector<u8> NACP::GetRawBytes() const { | 90 | std::vector<u8> NACP::GetRawBytes() const { |
diff --git a/src/core/file_sys/control_metadata.h b/src/core/file_sys/control_metadata.h index 7b9cdc910..280710ddf 100644 --- a/src/core/file_sys/control_metadata.h +++ b/src/core/file_sys/control_metadata.h | |||
| @@ -38,23 +38,35 @@ struct RawNACP { | |||
| 38 | u8 video_capture_mode; | 38 | u8 video_capture_mode; |
| 39 | bool data_loss_confirmation; | 39 | bool data_loss_confirmation; |
| 40 | INSERT_PADDING_BYTES(1); | 40 | INSERT_PADDING_BYTES(1); |
| 41 | u64_le title_id; | 41 | u64_le presence_group_id; |
| 42 | std::array<u8, 0x20> rating_age; | 42 | std::array<u8, 0x20> rating_age; |
| 43 | std::array<char, 0x10> version_string; | 43 | std::array<char, 0x10> version_string; |
| 44 | u64_le dlc_base_title_id; | 44 | u64_le dlc_base_title_id; |
| 45 | u64_le title_id_2; | 45 | u64_le save_data_owner_id; |
| 46 | u64_le normal_save_data_size; | 46 | u64_le user_account_save_data_size; |
| 47 | u64_le journal_sava_data_size; | 47 | u64_le user_account_save_data_journal_size; |
| 48 | INSERT_PADDING_BYTES(0x18); | 48 | u64_le device_save_data_size; |
| 49 | u64_le product_code; | 49 | u64_le device_save_data_journal_size; |
| 50 | u64_le bcat_delivery_cache_storage_size; | ||
| 51 | char application_error_code_category[8]; | ||
| 50 | std::array<u64_le, 0x8> local_communication; | 52 | std::array<u64_le, 0x8> local_communication; |
| 51 | u8 logo_type; | 53 | u8 logo_type; |
| 52 | u8 logo_handling; | 54 | u8 logo_handling; |
| 53 | bool runtime_add_on_content_install; | 55 | bool runtime_add_on_content_install; |
| 54 | INSERT_PADDING_BYTES(5); | 56 | INSERT_PADDING_BYTES(5); |
| 55 | u64_le title_id_update; | 57 | u64_le seed_for_pseudo_device_id; |
| 56 | std::array<u8, 0x40> bcat_passphrase; | 58 | std::array<u8, 0x41> bcat_passphrase; |
| 57 | INSERT_PADDING_BYTES(0xEC0); | 59 | INSERT_PADDING_BYTES(7); |
| 60 | u64_le user_account_save_data_max_size; | ||
| 61 | u64_le user_account_save_data_max_journal_size; | ||
| 62 | u64_le device_save_data_max_size; | ||
| 63 | u64_le device_save_data_max_journal_size; | ||
| 64 | u64_le temporary_storage_size; | ||
| 65 | u64_le cache_storage_size; | ||
| 66 | u64_le cache_storage_journal_size; | ||
| 67 | u64_le cache_storage_data_and_journal_max_size; | ||
| 68 | u64_le cache_storage_max_index; | ||
| 69 | INSERT_PADDING_BYTES(0xE70); | ||
| 58 | }; | 70 | }; |
| 59 | static_assert(sizeof(RawNACP) == 0x4000, "RawNACP has incorrect size."); | 71 | static_assert(sizeof(RawNACP) == 0x4000, "RawNACP has incorrect size."); |
| 60 | 72 | ||
diff --git a/src/core/file_sys/fsmitm_romfsbuild.cpp b/src/core/file_sys/fsmitm_romfsbuild.cpp index 47b7526c7..d126ae8dd 100644 --- a/src/core/file_sys/fsmitm_romfsbuild.cpp +++ b/src/core/file_sys/fsmitm_romfsbuild.cpp | |||
| @@ -23,6 +23,7 @@ | |||
| 23 | */ | 23 | */ |
| 24 | 24 | ||
| 25 | #include <cstring> | 25 | #include <cstring> |
| 26 | #include <string_view> | ||
| 26 | #include "common/alignment.h" | 27 | #include "common/alignment.h" |
| 27 | #include "common/assert.h" | 28 | #include "common/assert.h" |
| 28 | #include "core/file_sys/fsmitm_romfsbuild.h" | 29 | #include "core/file_sys/fsmitm_romfsbuild.h" |
| @@ -97,7 +98,8 @@ struct RomFSBuildFileContext { | |||
| 97 | VirtualFile source; | 98 | VirtualFile source; |
| 98 | }; | 99 | }; |
| 99 | 100 | ||
| 100 | static u32 romfs_calc_path_hash(u32 parent, std::string path, u32 start, std::size_t path_len) { | 101 | static u32 romfs_calc_path_hash(u32 parent, std::string_view path, u32 start, |
| 102 | std::size_t path_len) { | ||
| 101 | u32 hash = parent ^ 123456789; | 103 | u32 hash = parent ^ 123456789; |
| 102 | for (u32 i = 0; i < path_len; i++) { | 104 | for (u32 i = 0; i < path_len; i++) { |
| 103 | hash = (hash >> 5) | (hash << 27); | 105 | hash = (hash >> 5) | (hash << 27); |
diff --git a/src/core/file_sys/nca_metadata.cpp b/src/core/file_sys/nca_metadata.cpp index 6f34b7836..93d0df6b9 100644 --- a/src/core/file_sys/nca_metadata.cpp +++ b/src/core/file_sys/nca_metadata.cpp | |||
| @@ -10,14 +10,6 @@ | |||
| 10 | 10 | ||
| 11 | namespace FileSys { | 11 | namespace FileSys { |
| 12 | 12 | ||
| 13 | bool operator>=(TitleType lhs, TitleType rhs) { | ||
| 14 | return static_cast<std::size_t>(lhs) >= static_cast<std::size_t>(rhs); | ||
| 15 | } | ||
| 16 | |||
| 17 | bool operator<=(TitleType lhs, TitleType rhs) { | ||
| 18 | return static_cast<std::size_t>(lhs) <= static_cast<std::size_t>(rhs); | ||
| 19 | } | ||
| 20 | |||
| 21 | CNMT::CNMT(VirtualFile file) { | 13 | CNMT::CNMT(VirtualFile file) { |
| 22 | if (file->ReadObject(&header) != sizeof(CNMTHeader)) | 14 | if (file->ReadObject(&header) != sizeof(CNMTHeader)) |
| 23 | return; | 15 | return; |
diff --git a/src/core/file_sys/nca_metadata.h b/src/core/file_sys/nca_metadata.h index a05d155f4..50bf38471 100644 --- a/src/core/file_sys/nca_metadata.h +++ b/src/core/file_sys/nca_metadata.h | |||
| @@ -29,9 +29,6 @@ enum class TitleType : u8 { | |||
| 29 | DeltaTitle = 0x83, | 29 | DeltaTitle = 0x83, |
| 30 | }; | 30 | }; |
| 31 | 31 | ||
| 32 | bool operator>=(TitleType lhs, TitleType rhs); | ||
| 33 | bool operator<=(TitleType lhs, TitleType rhs); | ||
| 34 | |||
| 35 | enum class ContentRecordType : u8 { | 32 | enum class ContentRecordType : u8 { |
| 36 | Meta = 0, | 33 | Meta = 0, |
| 37 | Program = 1, | 34 | Program = 1, |
diff --git a/src/core/file_sys/program_metadata.cpp b/src/core/file_sys/program_metadata.cpp index d3e00437f..d863253f8 100644 --- a/src/core/file_sys/program_metadata.cpp +++ b/src/core/file_sys/program_metadata.cpp | |||
| @@ -3,7 +3,6 @@ | |||
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include <cstddef> | 5 | #include <cstddef> |
| 6 | #include <cstring> | ||
| 7 | #include <vector> | 6 | #include <vector> |
| 8 | 7 | ||
| 9 | #include "common/logging/log.h" | 8 | #include "common/logging/log.h" |
| @@ -17,28 +16,30 @@ ProgramMetadata::ProgramMetadata() = default; | |||
| 17 | ProgramMetadata::~ProgramMetadata() = default; | 16 | ProgramMetadata::~ProgramMetadata() = default; |
| 18 | 17 | ||
| 19 | Loader::ResultStatus ProgramMetadata::Load(VirtualFile file) { | 18 | Loader::ResultStatus ProgramMetadata::Load(VirtualFile file) { |
| 20 | std::size_t total_size = static_cast<std::size_t>(file->GetSize()); | 19 | const std::size_t total_size = file->GetSize(); |
| 21 | if (total_size < sizeof(Header)) | 20 | if (total_size < sizeof(Header)) { |
| 22 | return Loader::ResultStatus::ErrorBadNPDMHeader; | 21 | return Loader::ResultStatus::ErrorBadNPDMHeader; |
| 22 | } | ||
| 23 | 23 | ||
| 24 | // TODO(DarkLordZach): Use ReadObject when Header/AcidHeader becomes trivially copyable. | 24 | if (sizeof(Header) != file->ReadObject(&npdm_header)) { |
| 25 | std::vector<u8> npdm_header_data = file->ReadBytes(sizeof(Header)); | ||
| 26 | if (sizeof(Header) != npdm_header_data.size()) | ||
| 27 | return Loader::ResultStatus::ErrorBadNPDMHeader; | 25 | return Loader::ResultStatus::ErrorBadNPDMHeader; |
| 28 | std::memcpy(&npdm_header, npdm_header_data.data(), sizeof(Header)); | 26 | } |
| 29 | 27 | ||
| 30 | std::vector<u8> acid_header_data = file->ReadBytes(sizeof(AcidHeader), npdm_header.acid_offset); | 28 | if (sizeof(AcidHeader) != file->ReadObject(&acid_header, npdm_header.acid_offset)) { |
| 31 | if (sizeof(AcidHeader) != acid_header_data.size()) | ||
| 32 | return Loader::ResultStatus::ErrorBadACIDHeader; | 29 | return Loader::ResultStatus::ErrorBadACIDHeader; |
| 33 | std::memcpy(&acid_header, acid_header_data.data(), sizeof(AcidHeader)); | 30 | } |
| 34 | 31 | ||
| 35 | if (sizeof(AciHeader) != file->ReadObject(&aci_header, npdm_header.aci_offset)) | 32 | if (sizeof(AciHeader) != file->ReadObject(&aci_header, npdm_header.aci_offset)) { |
| 36 | return Loader::ResultStatus::ErrorBadACIHeader; | 33 | return Loader::ResultStatus::ErrorBadACIHeader; |
| 34 | } | ||
| 37 | 35 | ||
| 38 | if (sizeof(FileAccessControl) != file->ReadObject(&acid_file_access, acid_header.fac_offset)) | 36 | if (sizeof(FileAccessControl) != file->ReadObject(&acid_file_access, acid_header.fac_offset)) { |
| 39 | return Loader::ResultStatus::ErrorBadFileAccessControl; | 37 | return Loader::ResultStatus::ErrorBadFileAccessControl; |
| 40 | if (sizeof(FileAccessHeader) != file->ReadObject(&aci_file_access, aci_header.fah_offset)) | 38 | } |
| 39 | |||
| 40 | if (sizeof(FileAccessHeader) != file->ReadObject(&aci_file_access, aci_header.fah_offset)) { | ||
| 41 | return Loader::ResultStatus::ErrorBadFileAccessHeader; | 41 | return Loader::ResultStatus::ErrorBadFileAccessHeader; |
| 42 | } | ||
| 42 | 43 | ||
| 43 | aci_kernel_capabilities.resize(aci_header.kac_size / sizeof(u32)); | 44 | aci_kernel_capabilities.resize(aci_header.kac_size / sizeof(u32)); |
| 44 | const u64 read_size = aci_header.kac_size; | 45 | const u64 read_size = aci_header.kac_size; |
diff --git a/src/core/file_sys/program_metadata.h b/src/core/file_sys/program_metadata.h index 0033ba347..7de5b9cf9 100644 --- a/src/core/file_sys/program_metadata.h +++ b/src/core/file_sys/program_metadata.h | |||
| @@ -58,7 +58,6 @@ public: | |||
| 58 | void Print() const; | 58 | void Print() const; |
| 59 | 59 | ||
| 60 | private: | 60 | private: |
| 61 | // TODO(DarkLordZach): BitField is not trivially copyable. | ||
| 62 | struct Header { | 61 | struct Header { |
| 63 | std::array<char, 4> magic; | 62 | std::array<char, 4> magic; |
| 64 | std::array<u8, 8> reserved; | 63 | std::array<u8, 8> reserved; |
| @@ -85,7 +84,6 @@ private: | |||
| 85 | 84 | ||
| 86 | static_assert(sizeof(Header) == 0x80, "NPDM header structure size is wrong"); | 85 | static_assert(sizeof(Header) == 0x80, "NPDM header structure size is wrong"); |
| 87 | 86 | ||
| 88 | // TODO(DarkLordZach): BitField is not trivially copyable. | ||
| 89 | struct AcidHeader { | 87 | struct AcidHeader { |
| 90 | std::array<u8, 0x100> signature; | 88 | std::array<u8, 0x100> signature; |
| 91 | std::array<u8, 0x100> nca_modulus; | 89 | std::array<u8, 0x100> nca_modulus; |
diff --git a/src/core/file_sys/savedata_factory.cpp b/src/core/file_sys/savedata_factory.cpp index 1913dc956..7974b031d 100644 --- a/src/core/file_sys/savedata_factory.cpp +++ b/src/core/file_sys/savedata_factory.cpp | |||
| @@ -16,8 +16,10 @@ namespace FileSys { | |||
| 16 | constexpr char SAVE_DATA_SIZE_FILENAME[] = ".yuzu_save_size"; | 16 | constexpr char SAVE_DATA_SIZE_FILENAME[] = ".yuzu_save_size"; |
| 17 | 17 | ||
| 18 | std::string SaveDataDescriptor::DebugInfo() const { | 18 | std::string SaveDataDescriptor::DebugInfo() const { |
| 19 | return fmt::format("[type={:02X}, title_id={:016X}, user_id={:016X}{:016X}, save_id={:016X}]", | 19 | return fmt::format("[type={:02X}, title_id={:016X}, user_id={:016X}{:016X}, save_id={:016X}, " |
| 20 | static_cast<u8>(type), title_id, user_id[1], user_id[0], save_id); | 20 | "rank={}, index={}]", |
| 21 | static_cast<u8>(type), title_id, user_id[1], user_id[0], save_id, | ||
| 22 | static_cast<u8>(rank), index); | ||
| 21 | } | 23 | } |
| 22 | 24 | ||
| 23 | SaveDataFactory::SaveDataFactory(VirtualDir save_directory) : dir(std::move(save_directory)) { | 25 | SaveDataFactory::SaveDataFactory(VirtualDir save_directory) : dir(std::move(save_directory)) { |
| @@ -28,7 +30,7 @@ SaveDataFactory::SaveDataFactory(VirtualDir save_directory) : dir(std::move(save | |||
| 28 | 30 | ||
| 29 | SaveDataFactory::~SaveDataFactory() = default; | 31 | SaveDataFactory::~SaveDataFactory() = default; |
| 30 | 32 | ||
| 31 | ResultVal<VirtualDir> SaveDataFactory::Open(SaveDataSpaceId space, SaveDataDescriptor meta) { | 33 | ResultVal<VirtualDir> SaveDataFactory::Open(SaveDataSpaceId space, const SaveDataDescriptor& meta) { |
| 32 | if (meta.type == SaveDataType::SystemSaveData || meta.type == SaveDataType::SaveData) { | 34 | if (meta.type == SaveDataType::SystemSaveData || meta.type == SaveDataType::SaveData) { |
| 33 | if (meta.zero_1 != 0) { | 35 | if (meta.zero_1 != 0) { |
| 34 | LOG_WARNING(Service_FS, | 36 | LOG_WARNING(Service_FS, |
diff --git a/src/core/file_sys/savedata_factory.h b/src/core/file_sys/savedata_factory.h index 3a1caf292..b73654571 100644 --- a/src/core/file_sys/savedata_factory.h +++ b/src/core/file_sys/savedata_factory.h | |||
| @@ -32,12 +32,19 @@ enum class SaveDataType : u8 { | |||
| 32 | CacheStorage = 5, | 32 | CacheStorage = 5, |
| 33 | }; | 33 | }; |
| 34 | 34 | ||
| 35 | enum class SaveDataRank : u8 { | ||
| 36 | Primary, | ||
| 37 | Secondary, | ||
| 38 | }; | ||
| 39 | |||
| 35 | struct SaveDataDescriptor { | 40 | struct SaveDataDescriptor { |
| 36 | u64_le title_id; | 41 | u64_le title_id; |
| 37 | u128 user_id; | 42 | u128 user_id; |
| 38 | u64_le save_id; | 43 | u64_le save_id; |
| 39 | SaveDataType type; | 44 | SaveDataType type; |
| 40 | INSERT_PADDING_BYTES(7); | 45 | SaveDataRank rank; |
| 46 | u16_le index; | ||
| 47 | INSERT_PADDING_BYTES(4); | ||
| 41 | u64_le zero_1; | 48 | u64_le zero_1; |
| 42 | u64_le zero_2; | 49 | u64_le zero_2; |
| 43 | u64_le zero_3; | 50 | u64_le zero_3; |
| @@ -57,7 +64,7 @@ public: | |||
| 57 | explicit SaveDataFactory(VirtualDir dir); | 64 | explicit SaveDataFactory(VirtualDir dir); |
| 58 | ~SaveDataFactory(); | 65 | ~SaveDataFactory(); |
| 59 | 66 | ||
| 60 | ResultVal<VirtualDir> Open(SaveDataSpaceId space, SaveDataDescriptor meta); | 67 | ResultVal<VirtualDir> Open(SaveDataSpaceId space, const SaveDataDescriptor& meta); |
| 61 | 68 | ||
| 62 | VirtualDir GetSaveDataSpaceDirectory(SaveDataSpaceId space) const; | 69 | VirtualDir GetSaveDataSpaceDirectory(SaveDataSpaceId space) const; |
| 63 | 70 | ||
diff --git a/src/core/frontend/emu_window.cpp b/src/core/frontend/emu_window.cpp index e29afd630..1320bbe77 100644 --- a/src/core/frontend/emu_window.cpp +++ b/src/core/frontend/emu_window.cpp | |||
| @@ -30,7 +30,7 @@ private: | |||
| 30 | explicit Device(std::weak_ptr<TouchState>&& touch_state) : touch_state(touch_state) {} | 30 | explicit Device(std::weak_ptr<TouchState>&& touch_state) : touch_state(touch_state) {} |
| 31 | std::tuple<float, float, bool> GetStatus() const override { | 31 | std::tuple<float, float, bool> GetStatus() const override { |
| 32 | if (auto state = touch_state.lock()) { | 32 | if (auto state = touch_state.lock()) { |
| 33 | std::lock_guard<std::mutex> guard(state->mutex); | 33 | std::lock_guard guard{state->mutex}; |
| 34 | return std::make_tuple(state->touch_x, state->touch_y, state->touch_pressed); | 34 | return std::make_tuple(state->touch_x, state->touch_y, state->touch_pressed); |
| 35 | } | 35 | } |
| 36 | return std::make_tuple(0.0f, 0.0f, false); | 36 | return std::make_tuple(0.0f, 0.0f, false); |
| @@ -81,7 +81,7 @@ void EmuWindow::TouchPressed(unsigned framebuffer_x, unsigned framebuffer_y) { | |||
| 81 | if (!IsWithinTouchscreen(framebuffer_layout, framebuffer_x, framebuffer_y)) | 81 | if (!IsWithinTouchscreen(framebuffer_layout, framebuffer_x, framebuffer_y)) |
| 82 | return; | 82 | return; |
| 83 | 83 | ||
| 84 | std::lock_guard<std::mutex> guard(touch_state->mutex); | 84 | std::lock_guard guard{touch_state->mutex}; |
| 85 | touch_state->touch_x = static_cast<float>(framebuffer_x - framebuffer_layout.screen.left) / | 85 | touch_state->touch_x = static_cast<float>(framebuffer_x - framebuffer_layout.screen.left) / |
| 86 | (framebuffer_layout.screen.right - framebuffer_layout.screen.left); | 86 | (framebuffer_layout.screen.right - framebuffer_layout.screen.left); |
| 87 | touch_state->touch_y = static_cast<float>(framebuffer_y - framebuffer_layout.screen.top) / | 87 | touch_state->touch_y = static_cast<float>(framebuffer_y - framebuffer_layout.screen.top) / |
| @@ -91,7 +91,7 @@ void EmuWindow::TouchPressed(unsigned framebuffer_x, unsigned framebuffer_y) { | |||
| 91 | } | 91 | } |
| 92 | 92 | ||
| 93 | void EmuWindow::TouchReleased() { | 93 | void EmuWindow::TouchReleased() { |
| 94 | std::lock_guard<std::mutex> guard(touch_state->mutex); | 94 | std::lock_guard guard{touch_state->mutex}; |
| 95 | touch_state->touch_pressed = false; | 95 | touch_state->touch_pressed = false; |
| 96 | touch_state->touch_x = 0; | 96 | touch_state->touch_x = 0; |
| 97 | touch_state->touch_y = 0; | 97 | touch_state->touch_y = 0; |
diff --git a/src/core/gdbstub/gdbstub.cpp b/src/core/gdbstub/gdbstub.cpp index dafb32aae..afa812598 100644 --- a/src/core/gdbstub/gdbstub.cpp +++ b/src/core/gdbstub/gdbstub.cpp | |||
| @@ -1030,7 +1030,7 @@ static void Step() { | |||
| 1030 | 1030 | ||
| 1031 | /// Tell the CPU if we hit a memory breakpoint. | 1031 | /// Tell the CPU if we hit a memory breakpoint. |
| 1032 | bool IsMemoryBreak() { | 1032 | bool IsMemoryBreak() { |
| 1033 | if (IsConnected()) { | 1033 | if (!IsConnected()) { |
| 1034 | return false; | 1034 | return false; |
| 1035 | } | 1035 | } |
| 1036 | 1036 | ||
diff --git a/src/core/hle/ipc_helpers.h b/src/core/hle/ipc_helpers.h index 68406eb63..ac0e1d796 100644 --- a/src/core/hle/ipc_helpers.h +++ b/src/core/hle/ipc_helpers.h | |||
| @@ -139,10 +139,8 @@ public: | |||
| 139 | context->AddDomainObject(std::move(iface)); | 139 | context->AddDomainObject(std::move(iface)); |
| 140 | } else { | 140 | } else { |
| 141 | auto& kernel = Core::System::GetInstance().Kernel(); | 141 | auto& kernel = Core::System::GetInstance().Kernel(); |
| 142 | auto sessions = | 142 | auto [server, client] = |
| 143 | Kernel::ServerSession::CreateSessionPair(kernel, iface->GetServiceName()); | 143 | Kernel::ServerSession::CreateSessionPair(kernel, iface->GetServiceName()); |
| 144 | auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions); | ||
| 145 | auto client = std::get<Kernel::SharedPtr<Kernel::ClientSession>>(sessions); | ||
| 146 | iface->ClientConnected(server); | 144 | iface->ClientConnected(server); |
| 147 | context->AddMoveObject(std::move(client)); | 145 | context->AddMoveObject(std::move(client)); |
| 148 | } | 146 | } |
diff --git a/src/core/hle/kernel/address_arbiter.cpp b/src/core/hle/kernel/address_arbiter.cpp index 352190da8..c8842410b 100644 --- a/src/core/hle/kernel/address_arbiter.cpp +++ b/src/core/hle/kernel/address_arbiter.cpp | |||
| @@ -26,7 +26,7 @@ void WakeThreads(const std::vector<SharedPtr<Thread>>& waiting_threads, s32 num_ | |||
| 26 | // them all. | 26 | // them all. |
| 27 | std::size_t last = waiting_threads.size(); | 27 | std::size_t last = waiting_threads.size(); |
| 28 | if (num_to_wake > 0) { | 28 | if (num_to_wake > 0) { |
| 29 | last = num_to_wake; | 29 | last = std::min(last, static_cast<std::size_t>(num_to_wake)); |
| 30 | } | 30 | } |
| 31 | 31 | ||
| 32 | // Signal the waiting threads. | 32 | // Signal the waiting threads. |
| @@ -90,9 +90,9 @@ ResultCode AddressArbiter::ModifyByWaitingCountAndSignalToAddressIfEqual(VAddr a | |||
| 90 | // Determine the modified value depending on the waiting count. | 90 | // Determine the modified value depending on the waiting count. |
| 91 | s32 updated_value; | 91 | s32 updated_value; |
| 92 | if (waiting_threads.empty()) { | 92 | if (waiting_threads.empty()) { |
| 93 | updated_value = value - 1; | ||
| 94 | } else if (num_to_wake <= 0 || waiting_threads.size() <= static_cast<u32>(num_to_wake)) { | ||
| 95 | updated_value = value + 1; | 93 | updated_value = value + 1; |
| 94 | } else if (num_to_wake <= 0 || waiting_threads.size() <= static_cast<u32>(num_to_wake)) { | ||
| 95 | updated_value = value - 1; | ||
| 96 | } else { | 96 | } else { |
| 97 | updated_value = value; | 97 | updated_value = value; |
| 98 | } | 98 | } |
diff --git a/src/core/hle/kernel/client_port.cpp b/src/core/hle/kernel/client_port.cpp index aa432658e..744b1697d 100644 --- a/src/core/hle/kernel/client_port.cpp +++ b/src/core/hle/kernel/client_port.cpp | |||
| @@ -2,8 +2,6 @@ | |||
| 2 | // Licensed under GPLv2 or any later version | 2 | // Licensed under GPLv2 or any later version |
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include <tuple> | ||
| 6 | |||
| 7 | #include "core/hle/kernel/client_port.h" | 5 | #include "core/hle/kernel/client_port.h" |
| 8 | #include "core/hle/kernel/client_session.h" | 6 | #include "core/hle/kernel/client_session.h" |
| 9 | #include "core/hle/kernel/errors.h" | 7 | #include "core/hle/kernel/errors.h" |
| @@ -31,18 +29,18 @@ ResultVal<SharedPtr<ClientSession>> ClientPort::Connect() { | |||
| 31 | active_sessions++; | 29 | active_sessions++; |
| 32 | 30 | ||
| 33 | // Create a new session pair, let the created sessions inherit the parent port's HLE handler. | 31 | // Create a new session pair, let the created sessions inherit the parent port's HLE handler. |
| 34 | auto sessions = ServerSession::CreateSessionPair(kernel, server_port->GetName(), this); | 32 | auto [server, client] = ServerSession::CreateSessionPair(kernel, server_port->GetName(), this); |
| 35 | 33 | ||
| 36 | if (server_port->HasHLEHandler()) { | 34 | if (server_port->HasHLEHandler()) { |
| 37 | server_port->GetHLEHandler()->ClientConnected(std::get<SharedPtr<ServerSession>>(sessions)); | 35 | server_port->GetHLEHandler()->ClientConnected(server); |
| 38 | } else { | 36 | } else { |
| 39 | server_port->AppendPendingSession(std::get<SharedPtr<ServerSession>>(sessions)); | 37 | server_port->AppendPendingSession(server); |
| 40 | } | 38 | } |
| 41 | 39 | ||
| 42 | // Wake the threads waiting on the ServerPort | 40 | // Wake the threads waiting on the ServerPort |
| 43 | server_port->WakeupAllWaitingThreads(); | 41 | server_port->WakeupAllWaitingThreads(); |
| 44 | 42 | ||
| 45 | return MakeResult(std::get<SharedPtr<ClientSession>>(sessions)); | 43 | return MakeResult(client); |
| 46 | } | 44 | } |
| 47 | 45 | ||
| 48 | void ClientPort::ConnectionClosed() { | 46 | void ClientPort::ConnectionClosed() { |
diff --git a/src/core/hle/kernel/code_set.h b/src/core/hle/kernel/code_set.h index 834fd23d2..879957dcb 100644 --- a/src/core/hle/kernel/code_set.h +++ b/src/core/hle/kernel/code_set.h | |||
| @@ -5,7 +5,6 @@ | |||
| 5 | #pragma once | 5 | #pragma once |
| 6 | 6 | ||
| 7 | #include <cstddef> | 7 | #include <cstddef> |
| 8 | #include <memory> | ||
| 9 | #include <vector> | 8 | #include <vector> |
| 10 | 9 | ||
| 11 | #include "common/common_types.h" | 10 | #include "common/common_types.h" |
| @@ -78,7 +77,7 @@ struct CodeSet final { | |||
| 78 | } | 77 | } |
| 79 | 78 | ||
| 80 | /// The overall data that backs this code set. | 79 | /// The overall data that backs this code set. |
| 81 | std::shared_ptr<std::vector<u8>> memory; | 80 | std::vector<u8> memory; |
| 82 | 81 | ||
| 83 | /// The segments that comprise this code set. | 82 | /// The segments that comprise this code set. |
| 84 | std::array<Segment, 3> segments; | 83 | std::array<Segment, 3> segments; |
diff --git a/src/core/hle/kernel/kernel.cpp b/src/core/hle/kernel/kernel.cpp index a7e4ddc05..4d58e7c69 100644 --- a/src/core/hle/kernel/kernel.cpp +++ b/src/core/hle/kernel/kernel.cpp | |||
| @@ -21,6 +21,7 @@ | |||
| 21 | #include "core/hle/kernel/thread.h" | 21 | #include "core/hle/kernel/thread.h" |
| 22 | #include "core/hle/lock.h" | 22 | #include "core/hle/lock.h" |
| 23 | #include "core/hle/result.h" | 23 | #include "core/hle/result.h" |
| 24 | #include "core/memory.h" | ||
| 24 | 25 | ||
| 25 | namespace Kernel { | 26 | namespace Kernel { |
| 26 | 27 | ||
| @@ -34,7 +35,7 @@ static void ThreadWakeupCallback(u64 thread_handle, [[maybe_unused]] s64 cycles_ | |||
| 34 | const auto& system = Core::System::GetInstance(); | 35 | const auto& system = Core::System::GetInstance(); |
| 35 | 36 | ||
| 36 | // Lock the global kernel mutex when we enter the kernel HLE. | 37 | // Lock the global kernel mutex when we enter the kernel HLE. |
| 37 | std::lock_guard<std::recursive_mutex> lock(HLE::g_hle_lock); | 38 | std::lock_guard lock{HLE::g_hle_lock}; |
| 38 | 39 | ||
| 39 | SharedPtr<Thread> thread = | 40 | SharedPtr<Thread> thread = |
| 40 | system.Kernel().RetrieveThreadFromWakeupCallbackHandleTable(proper_handle); | 41 | system.Kernel().RetrieveThreadFromWakeupCallbackHandleTable(proper_handle); |
| @@ -62,7 +63,8 @@ static void ThreadWakeupCallback(u64 thread_handle, [[maybe_unused]] s64 cycles_ | |||
| 62 | 63 | ||
| 63 | if (thread->GetMutexWaitAddress() != 0 || thread->GetCondVarWaitAddress() != 0 || | 64 | if (thread->GetMutexWaitAddress() != 0 || thread->GetCondVarWaitAddress() != 0 || |
| 64 | thread->GetWaitHandle() != 0) { | 65 | thread->GetWaitHandle() != 0) { |
| 65 | ASSERT(thread->GetStatus() == ThreadStatus::WaitMutex); | 66 | ASSERT(thread->GetStatus() == ThreadStatus::WaitMutex || |
| 67 | thread->GetStatus() == ThreadStatus::WaitCondVar); | ||
| 66 | thread->SetMutexWaitAddress(0); | 68 | thread->SetMutexWaitAddress(0); |
| 67 | thread->SetCondVarWaitAddress(0); | 69 | thread->SetCondVarWaitAddress(0); |
| 68 | thread->SetWaitHandle(0); | 70 | thread->SetWaitHandle(0); |
| @@ -114,7 +116,7 @@ struct KernelCore::Impl { | |||
| 114 | 116 | ||
| 115 | // Creates the default system resource limit | 117 | // Creates the default system resource limit |
| 116 | void InitializeSystemResourceLimit(KernelCore& kernel) { | 118 | void InitializeSystemResourceLimit(KernelCore& kernel) { |
| 117 | system_resource_limit = ResourceLimit::Create(kernel, "System"); | 119 | system_resource_limit = ResourceLimit::Create(kernel); |
| 118 | 120 | ||
| 119 | // If setting the default system values fails, then something seriously wrong has occurred. | 121 | // If setting the default system values fails, then something seriously wrong has occurred. |
| 120 | ASSERT(system_resource_limit->SetLimitValue(ResourceType::PhysicalMemory, 0x200000000) | 122 | ASSERT(system_resource_limit->SetLimitValue(ResourceType::PhysicalMemory, 0x200000000) |
| @@ -180,6 +182,7 @@ void KernelCore::AppendNewProcess(SharedPtr<Process> process) { | |||
| 180 | 182 | ||
| 181 | void KernelCore::MakeCurrentProcess(Process* process) { | 183 | void KernelCore::MakeCurrentProcess(Process* process) { |
| 182 | impl->current_process = process; | 184 | impl->current_process = process; |
| 185 | Memory::SetCurrentPageTable(&process->VMManager().page_table); | ||
| 183 | } | 186 | } |
| 184 | 187 | ||
| 185 | Process* KernelCore::CurrentProcess() { | 188 | Process* KernelCore::CurrentProcess() { |
| @@ -190,6 +193,10 @@ const Process* KernelCore::CurrentProcess() const { | |||
| 190 | return impl->current_process; | 193 | return impl->current_process; |
| 191 | } | 194 | } |
| 192 | 195 | ||
| 196 | const std::vector<SharedPtr<Process>>& KernelCore::GetProcessList() const { | ||
| 197 | return impl->process_list; | ||
| 198 | } | ||
| 199 | |||
| 193 | void KernelCore::AddNamedPort(std::string name, SharedPtr<ClientPort> port) { | 200 | void KernelCore::AddNamedPort(std::string name, SharedPtr<ClientPort> port) { |
| 194 | impl->named_ports.emplace(std::move(name), std::move(port)); | 201 | impl->named_ports.emplace(std::move(name), std::move(port)); |
| 195 | } | 202 | } |
diff --git a/src/core/hle/kernel/kernel.h b/src/core/hle/kernel/kernel.h index 03ea5b659..6b8738599 100644 --- a/src/core/hle/kernel/kernel.h +++ b/src/core/hle/kernel/kernel.h | |||
| @@ -72,6 +72,9 @@ public: | |||
| 72 | /// Retrieves a const pointer to the current process. | 72 | /// Retrieves a const pointer to the current process. |
| 73 | const Process* CurrentProcess() const; | 73 | const Process* CurrentProcess() const; |
| 74 | 74 | ||
| 75 | /// Retrieves the list of processes. | ||
| 76 | const std::vector<SharedPtr<Process>>& GetProcessList() const; | ||
| 77 | |||
| 75 | /// Adds a port to the named port table | 78 | /// Adds a port to the named port table |
| 76 | void AddNamedPort(std::string name, SharedPtr<ClientPort> port); | 79 | void AddNamedPort(std::string name, SharedPtr<ClientPort> port); |
| 77 | 80 | ||
diff --git a/src/core/hle/kernel/object.cpp b/src/core/hle/kernel/object.cpp index 217144efc..10431e94c 100644 --- a/src/core/hle/kernel/object.cpp +++ b/src/core/hle/kernel/object.cpp | |||
| @@ -24,7 +24,6 @@ bool Object::IsWaitable() const { | |||
| 24 | case HandleType::WritableEvent: | 24 | case HandleType::WritableEvent: |
| 25 | case HandleType::SharedMemory: | 25 | case HandleType::SharedMemory: |
| 26 | case HandleType::TransferMemory: | 26 | case HandleType::TransferMemory: |
| 27 | case HandleType::AddressArbiter: | ||
| 28 | case HandleType::ResourceLimit: | 27 | case HandleType::ResourceLimit: |
| 29 | case HandleType::ClientPort: | 28 | case HandleType::ClientPort: |
| 30 | case HandleType::ClientSession: | 29 | case HandleType::ClientSession: |
diff --git a/src/core/hle/kernel/object.h b/src/core/hle/kernel/object.h index 3f6baa094..332876c27 100644 --- a/src/core/hle/kernel/object.h +++ b/src/core/hle/kernel/object.h | |||
| @@ -25,7 +25,6 @@ enum class HandleType : u32 { | |||
| 25 | TransferMemory, | 25 | TransferMemory, |
| 26 | Thread, | 26 | Thread, |
| 27 | Process, | 27 | Process, |
| 28 | AddressArbiter, | ||
| 29 | ResourceLimit, | 28 | ResourceLimit, |
| 30 | ClientPort, | 29 | ClientPort, |
| 31 | ServerPort, | 30 | ServerPort, |
diff --git a/src/core/hle/kernel/process.cpp b/src/core/hle/kernel/process.cpp index 0d782e4ba..26c6b95ab 100644 --- a/src/core/hle/kernel/process.cpp +++ b/src/core/hle/kernel/process.cpp | |||
| @@ -5,6 +5,7 @@ | |||
| 5 | #include <algorithm> | 5 | #include <algorithm> |
| 6 | #include <memory> | 6 | #include <memory> |
| 7 | #include <random> | 7 | #include <random> |
| 8 | #include "common/alignment.h" | ||
| 8 | #include "common/assert.h" | 9 | #include "common/assert.h" |
| 9 | #include "common/logging/log.h" | 10 | #include "common/logging/log.h" |
| 10 | #include "core/core.h" | 11 | #include "core/core.h" |
| @@ -31,9 +32,6 @@ namespace { | |||
| 31 | * @param priority The priority to give the main thread | 32 | * @param priority The priority to give the main thread |
| 32 | */ | 33 | */ |
| 33 | void SetupMainThread(Process& owner_process, KernelCore& kernel, VAddr entry_point, u32 priority) { | 34 | void SetupMainThread(Process& owner_process, KernelCore& kernel, VAddr entry_point, u32 priority) { |
| 34 | // Setup page table so we can write to memory | ||
| 35 | Memory::SetCurrentPageTable(&owner_process.VMManager().page_table); | ||
| 36 | |||
| 37 | // Initialize new "main" thread | 35 | // Initialize new "main" thread |
| 38 | const VAddr stack_top = owner_process.VMManager().GetTLSIORegionEndAddress(); | 36 | const VAddr stack_top = owner_process.VMManager().GetTLSIORegionEndAddress(); |
| 39 | auto thread_res = Thread::Create(kernel, "main", entry_point, priority, 0, | 37 | auto thread_res = Thread::Create(kernel, "main", entry_point, priority, 0, |
| @@ -75,6 +73,18 @@ SharedPtr<ResourceLimit> Process::GetResourceLimit() const { | |||
| 75 | return resource_limit; | 73 | return resource_limit; |
| 76 | } | 74 | } |
| 77 | 75 | ||
| 76 | u64 Process::GetTotalPhysicalMemoryUsed() const { | ||
| 77 | return vm_manager.GetCurrentHeapSize() + main_thread_stack_size + code_memory_size; | ||
| 78 | } | ||
| 79 | |||
| 80 | void Process::RegisterThread(const Thread* thread) { | ||
| 81 | thread_list.push_back(thread); | ||
| 82 | } | ||
| 83 | |||
| 84 | void Process::UnregisterThread(const Thread* thread) { | ||
| 85 | thread_list.remove(thread); | ||
| 86 | } | ||
| 87 | |||
| 78 | ResultCode Process::ClearSignalState() { | 88 | ResultCode Process::ClearSignalState() { |
| 79 | if (status == ProcessStatus::Exited) { | 89 | if (status == ProcessStatus::Exited) { |
| 80 | LOG_ERROR(Kernel, "called on a terminated process instance."); | 90 | LOG_ERROR(Kernel, "called on a terminated process instance."); |
| @@ -107,14 +117,17 @@ ResultCode Process::LoadFromMetadata(const FileSys::ProgramMetadata& metadata) { | |||
| 107 | return handle_table.SetSize(capabilities.GetHandleTableSize()); | 117 | return handle_table.SetSize(capabilities.GetHandleTableSize()); |
| 108 | } | 118 | } |
| 109 | 119 | ||
| 110 | void Process::Run(VAddr entry_point, s32 main_thread_priority, u32 stack_size) { | 120 | void Process::Run(VAddr entry_point, s32 main_thread_priority, u64 stack_size) { |
| 121 | // The kernel always ensures that the given stack size is page aligned. | ||
| 122 | main_thread_stack_size = Common::AlignUp(stack_size, Memory::PAGE_SIZE); | ||
| 123 | |||
| 111 | // Allocate and map the main thread stack | 124 | // Allocate and map the main thread stack |
| 112 | // TODO(bunnei): This is heap area that should be allocated by the kernel and not mapped as part | 125 | // TODO(bunnei): This is heap area that should be allocated by the kernel and not mapped as part |
| 113 | // of the user address space. | 126 | // of the user address space. |
| 127 | const VAddr mapping_address = vm_manager.GetTLSIORegionEndAddress() - main_thread_stack_size; | ||
| 114 | vm_manager | 128 | vm_manager |
| 115 | .MapMemoryBlock(vm_manager.GetTLSIORegionEndAddress() - stack_size, | 129 | .MapMemoryBlock(mapping_address, std::make_shared<std::vector<u8>>(main_thread_stack_size), |
| 116 | std::make_shared<std::vector<u8>>(stack_size, 0), 0, stack_size, | 130 | 0, main_thread_stack_size, MemoryState::Stack) |
| 117 | MemoryState::Stack) | ||
| 118 | .Unwrap(); | 131 | .Unwrap(); |
| 119 | 132 | ||
| 120 | vm_manager.LogLayout(); | 133 | vm_manager.LogLayout(); |
| @@ -210,11 +223,13 @@ void Process::FreeTLSSlot(VAddr tls_address) { | |||
| 210 | } | 223 | } |
| 211 | 224 | ||
| 212 | void Process::LoadModule(CodeSet module_, VAddr base_addr) { | 225 | void Process::LoadModule(CodeSet module_, VAddr base_addr) { |
| 226 | const auto memory = std::make_shared<std::vector<u8>>(std::move(module_.memory)); | ||
| 227 | |||
| 213 | const auto MapSegment = [&](const CodeSet::Segment& segment, VMAPermission permissions, | 228 | const auto MapSegment = [&](const CodeSet::Segment& segment, VMAPermission permissions, |
| 214 | MemoryState memory_state) { | 229 | MemoryState memory_state) { |
| 215 | const auto vma = vm_manager | 230 | const auto vma = vm_manager |
| 216 | .MapMemoryBlock(segment.addr + base_addr, module_.memory, | 231 | .MapMemoryBlock(segment.addr + base_addr, memory, segment.offset, |
| 217 | segment.offset, segment.size, memory_state) | 232 | segment.size, memory_state) |
| 218 | .Unwrap(); | 233 | .Unwrap(); |
| 219 | vm_manager.Reprotect(vma, permissions); | 234 | vm_manager.Reprotect(vma, permissions); |
| 220 | }; | 235 | }; |
| @@ -224,6 +239,8 @@ void Process::LoadModule(CodeSet module_, VAddr base_addr) { | |||
| 224 | MapSegment(module_.RODataSegment(), VMAPermission::Read, MemoryState::CodeData); | 239 | MapSegment(module_.RODataSegment(), VMAPermission::Read, MemoryState::CodeData); |
| 225 | MapSegment(module_.DataSegment(), VMAPermission::ReadWrite, MemoryState::CodeData); | 240 | MapSegment(module_.DataSegment(), VMAPermission::ReadWrite, MemoryState::CodeData); |
| 226 | 241 | ||
| 242 | code_memory_size += module_.memory.size(); | ||
| 243 | |||
| 227 | // Clear instruction cache in CPU JIT | 244 | // Clear instruction cache in CPU JIT |
| 228 | system.InvalidateCpuInstructionCaches(); | 245 | system.InvalidateCpuInstructionCaches(); |
| 229 | } | 246 | } |
| @@ -237,7 +254,7 @@ void Process::Acquire(Thread* thread) { | |||
| 237 | ASSERT_MSG(!ShouldWait(thread), "Object unavailable!"); | 254 | ASSERT_MSG(!ShouldWait(thread), "Object unavailable!"); |
| 238 | } | 255 | } |
| 239 | 256 | ||
| 240 | bool Process::ShouldWait(Thread* thread) const { | 257 | bool Process::ShouldWait(const Thread* thread) const { |
| 241 | return !is_signaled; | 258 | return !is_signaled; |
| 242 | } | 259 | } |
| 243 | 260 | ||
diff --git a/src/core/hle/kernel/process.h b/src/core/hle/kernel/process.h index a0217d3d8..f060f2a3b 100644 --- a/src/core/hle/kernel/process.h +++ b/src/core/hle/kernel/process.h | |||
| @@ -7,6 +7,7 @@ | |||
| 7 | #include <array> | 7 | #include <array> |
| 8 | #include <bitset> | 8 | #include <bitset> |
| 9 | #include <cstddef> | 9 | #include <cstddef> |
| 10 | #include <list> | ||
| 10 | #include <string> | 11 | #include <string> |
| 11 | #include <vector> | 12 | #include <vector> |
| 12 | #include <boost/container/static_vector.hpp> | 13 | #include <boost/container/static_vector.hpp> |
| @@ -186,6 +187,22 @@ public: | |||
| 186 | return random_entropy.at(index); | 187 | return random_entropy.at(index); |
| 187 | } | 188 | } |
| 188 | 189 | ||
| 190 | /// Retrieves the total physical memory used by this process in bytes. | ||
| 191 | u64 GetTotalPhysicalMemoryUsed() const; | ||
| 192 | |||
| 193 | /// Gets the list of all threads created with this process as their owner. | ||
| 194 | const std::list<const Thread*>& GetThreadList() const { | ||
| 195 | return thread_list; | ||
| 196 | } | ||
| 197 | |||
| 198 | /// Registers a thread as being created under this process, | ||
| 199 | /// adding it to this process' thread list. | ||
| 200 | void RegisterThread(const Thread* thread); | ||
| 201 | |||
| 202 | /// Unregisters a thread from this process, removing it | ||
| 203 | /// from this process' thread list. | ||
| 204 | void UnregisterThread(const Thread* thread); | ||
| 205 | |||
| 189 | /// Clears the signaled state of the process if and only if it's signaled. | 206 | /// Clears the signaled state of the process if and only if it's signaled. |
| 190 | /// | 207 | /// |
| 191 | /// @pre The process must not be already terminated. If this is called on a | 208 | /// @pre The process must not be already terminated. If this is called on a |
| @@ -210,7 +227,7 @@ public: | |||
| 210 | /** | 227 | /** |
| 211 | * Applies address space changes and launches the process main thread. | 228 | * Applies address space changes and launches the process main thread. |
| 212 | */ | 229 | */ |
| 213 | void Run(VAddr entry_point, s32 main_thread_priority, u32 stack_size); | 230 | void Run(VAddr entry_point, s32 main_thread_priority, u64 stack_size); |
| 214 | 231 | ||
| 215 | /** | 232 | /** |
| 216 | * Prepares a process for termination by stopping all of its threads | 233 | * Prepares a process for termination by stopping all of its threads |
| @@ -234,7 +251,7 @@ private: | |||
| 234 | ~Process() override; | 251 | ~Process() override; |
| 235 | 252 | ||
| 236 | /// Checks if the specified thread should wait until this process is available. | 253 | /// Checks if the specified thread should wait until this process is available. |
| 237 | bool ShouldWait(Thread* thread) const override; | 254 | bool ShouldWait(const Thread* thread) const override; |
| 238 | 255 | ||
| 239 | /// Acquires/locks this process for the specified thread if it's available. | 256 | /// Acquires/locks this process for the specified thread if it's available. |
| 240 | void Acquire(Thread* thread) override; | 257 | void Acquire(Thread* thread) override; |
| @@ -247,6 +264,12 @@ private: | |||
| 247 | /// Memory manager for this process. | 264 | /// Memory manager for this process. |
| 248 | Kernel::VMManager vm_manager; | 265 | Kernel::VMManager vm_manager; |
| 249 | 266 | ||
| 267 | /// Size of the main thread's stack in bytes. | ||
| 268 | u64 main_thread_stack_size = 0; | ||
| 269 | |||
| 270 | /// Size of the loaded code memory in bytes. | ||
| 271 | u64 code_memory_size = 0; | ||
| 272 | |||
| 250 | /// Current status of the process | 273 | /// Current status of the process |
| 251 | ProcessStatus status; | 274 | ProcessStatus status; |
| 252 | 275 | ||
| @@ -299,6 +322,9 @@ private: | |||
| 299 | /// Random values for svcGetInfo RandomEntropy | 322 | /// Random values for svcGetInfo RandomEntropy |
| 300 | std::array<u64, RANDOM_ENTROPY_SIZE> random_entropy; | 323 | std::array<u64, RANDOM_ENTROPY_SIZE> random_entropy; |
| 301 | 324 | ||
| 325 | /// List of threads that are running with this process as their owner. | ||
| 326 | std::list<const Thread*> thread_list; | ||
| 327 | |||
| 302 | /// System context | 328 | /// System context |
| 303 | Core::System& system; | 329 | Core::System& system; |
| 304 | 330 | ||
diff --git a/src/core/hle/kernel/readable_event.cpp b/src/core/hle/kernel/readable_event.cpp index 0e5083f70..c2b798a4e 100644 --- a/src/core/hle/kernel/readable_event.cpp +++ b/src/core/hle/kernel/readable_event.cpp | |||
| @@ -14,7 +14,7 @@ namespace Kernel { | |||
| 14 | ReadableEvent::ReadableEvent(KernelCore& kernel) : WaitObject{kernel} {} | 14 | ReadableEvent::ReadableEvent(KernelCore& kernel) : WaitObject{kernel} {} |
| 15 | ReadableEvent::~ReadableEvent() = default; | 15 | ReadableEvent::~ReadableEvent() = default; |
| 16 | 16 | ||
| 17 | bool ReadableEvent::ShouldWait(Thread* thread) const { | 17 | bool ReadableEvent::ShouldWait(const Thread* thread) const { |
| 18 | return !signaled; | 18 | return !signaled; |
| 19 | } | 19 | } |
| 20 | 20 | ||
diff --git a/src/core/hle/kernel/readable_event.h b/src/core/hle/kernel/readable_event.h index 77a9c362c..2eb9dcbb7 100644 --- a/src/core/hle/kernel/readable_event.h +++ b/src/core/hle/kernel/readable_event.h | |||
| @@ -36,7 +36,7 @@ public: | |||
| 36 | return HANDLE_TYPE; | 36 | return HANDLE_TYPE; |
| 37 | } | 37 | } |
| 38 | 38 | ||
| 39 | bool ShouldWait(Thread* thread) const override; | 39 | bool ShouldWait(const Thread* thread) const override; |
| 40 | void Acquire(Thread* thread) override; | 40 | void Acquire(Thread* thread) override; |
| 41 | 41 | ||
| 42 | /// Unconditionally clears the readable event's state. | 42 | /// Unconditionally clears the readable event's state. |
diff --git a/src/core/hle/kernel/resource_limit.cpp b/src/core/hle/kernel/resource_limit.cpp index 2f9695005..173f69915 100644 --- a/src/core/hle/kernel/resource_limit.cpp +++ b/src/core/hle/kernel/resource_limit.cpp | |||
| @@ -16,11 +16,8 @@ constexpr std::size_t ResourceTypeToIndex(ResourceType type) { | |||
| 16 | ResourceLimit::ResourceLimit(KernelCore& kernel) : Object{kernel} {} | 16 | ResourceLimit::ResourceLimit(KernelCore& kernel) : Object{kernel} {} |
| 17 | ResourceLimit::~ResourceLimit() = default; | 17 | ResourceLimit::~ResourceLimit() = default; |
| 18 | 18 | ||
| 19 | SharedPtr<ResourceLimit> ResourceLimit::Create(KernelCore& kernel, std::string name) { | 19 | SharedPtr<ResourceLimit> ResourceLimit::Create(KernelCore& kernel) { |
| 20 | SharedPtr<ResourceLimit> resource_limit(new ResourceLimit(kernel)); | 20 | return new ResourceLimit(kernel); |
| 21 | |||
| 22 | resource_limit->name = std::move(name); | ||
| 23 | return resource_limit; | ||
| 24 | } | 21 | } |
| 25 | 22 | ||
| 26 | s64 ResourceLimit::GetCurrentResourceValue(ResourceType resource) const { | 23 | s64 ResourceLimit::GetCurrentResourceValue(ResourceType resource) const { |
diff --git a/src/core/hle/kernel/resource_limit.h b/src/core/hle/kernel/resource_limit.h index 59dc11c22..70e09858a 100644 --- a/src/core/hle/kernel/resource_limit.h +++ b/src/core/hle/kernel/resource_limit.h | |||
| @@ -31,16 +31,14 @@ constexpr bool IsValidResourceType(ResourceType type) { | |||
| 31 | 31 | ||
| 32 | class ResourceLimit final : public Object { | 32 | class ResourceLimit final : public Object { |
| 33 | public: | 33 | public: |
| 34 | /** | 34 | /// Creates a resource limit object. |
| 35 | * Creates a resource limit object. | 35 | static SharedPtr<ResourceLimit> Create(KernelCore& kernel); |
| 36 | */ | ||
| 37 | static SharedPtr<ResourceLimit> Create(KernelCore& kernel, std::string name = "Unknown"); | ||
| 38 | 36 | ||
| 39 | std::string GetTypeName() const override { | 37 | std::string GetTypeName() const override { |
| 40 | return "ResourceLimit"; | 38 | return "ResourceLimit"; |
| 41 | } | 39 | } |
| 42 | std::string GetName() const override { | 40 | std::string GetName() const override { |
| 43 | return name; | 41 | return GetTypeName(); |
| 44 | } | 42 | } |
| 45 | 43 | ||
| 46 | static const HandleType HANDLE_TYPE = HandleType::ResourceLimit; | 44 | static const HandleType HANDLE_TYPE = HandleType::ResourceLimit; |
| @@ -95,9 +93,6 @@ private: | |||
| 95 | ResourceArray limits{}; | 93 | ResourceArray limits{}; |
| 96 | /// Current resource limit values. | 94 | /// Current resource limit values. |
| 97 | ResourceArray values{}; | 95 | ResourceArray values{}; |
| 98 | |||
| 99 | /// Name of resource limit object. | ||
| 100 | std::string name; | ||
| 101 | }; | 96 | }; |
| 102 | 97 | ||
| 103 | } // namespace Kernel | 98 | } // namespace Kernel |
diff --git a/src/core/hle/kernel/scheduler.cpp b/src/core/hle/kernel/scheduler.cpp index cc189cc64..e8447b69a 100644 --- a/src/core/hle/kernel/scheduler.cpp +++ b/src/core/hle/kernel/scheduler.cpp | |||
| @@ -29,8 +29,8 @@ Scheduler::~Scheduler() { | |||
| 29 | } | 29 | } |
| 30 | 30 | ||
| 31 | bool Scheduler::HaveReadyThreads() const { | 31 | bool Scheduler::HaveReadyThreads() const { |
| 32 | std::lock_guard<std::mutex> lock(scheduler_mutex); | 32 | std::lock_guard lock{scheduler_mutex}; |
| 33 | return ready_queue.get_first() != nullptr; | 33 | return !ready_queue.empty(); |
| 34 | } | 34 | } |
| 35 | 35 | ||
| 36 | Thread* Scheduler::GetCurrentThread() const { | 36 | Thread* Scheduler::GetCurrentThread() const { |
| @@ -46,22 +46,27 @@ Thread* Scheduler::PopNextReadyThread() { | |||
| 46 | Thread* thread = GetCurrentThread(); | 46 | Thread* thread = GetCurrentThread(); |
| 47 | 47 | ||
| 48 | if (thread && thread->GetStatus() == ThreadStatus::Running) { | 48 | if (thread && thread->GetStatus() == ThreadStatus::Running) { |
| 49 | if (ready_queue.empty()) { | ||
| 50 | return thread; | ||
| 51 | } | ||
| 49 | // We have to do better than the current thread. | 52 | // We have to do better than the current thread. |
| 50 | // This call returns null when that's not possible. | 53 | // This call returns null when that's not possible. |
| 51 | next = ready_queue.pop_first_better(thread->GetPriority()); | 54 | next = ready_queue.front(); |
| 52 | if (!next) { | 55 | if (next == nullptr || next->GetPriority() >= thread->GetPriority()) { |
| 53 | // Otherwise just keep going with the current thread | ||
| 54 | next = thread; | 56 | next = thread; |
| 55 | } | 57 | } |
| 56 | } else { | 58 | } else { |
| 57 | next = ready_queue.pop_first(); | 59 | if (ready_queue.empty()) { |
| 60 | return nullptr; | ||
| 61 | } | ||
| 62 | next = ready_queue.front(); | ||
| 58 | } | 63 | } |
| 59 | 64 | ||
| 60 | return next; | 65 | return next; |
| 61 | } | 66 | } |
| 62 | 67 | ||
| 63 | void Scheduler::SwitchContext(Thread* new_thread) { | 68 | void Scheduler::SwitchContext(Thread* new_thread) { |
| 64 | Thread* const previous_thread = GetCurrentThread(); | 69 | Thread* previous_thread = GetCurrentThread(); |
| 65 | Process* const previous_process = system.Kernel().CurrentProcess(); | 70 | Process* const previous_process = system.Kernel().CurrentProcess(); |
| 66 | 71 | ||
| 67 | UpdateLastContextSwitchTime(previous_thread, previous_process); | 72 | UpdateLastContextSwitchTime(previous_thread, previous_process); |
| @@ -75,7 +80,7 @@ void Scheduler::SwitchContext(Thread* new_thread) { | |||
| 75 | if (previous_thread->GetStatus() == ThreadStatus::Running) { | 80 | if (previous_thread->GetStatus() == ThreadStatus::Running) { |
| 76 | // This is only the case when a reschedule is triggered without the current thread | 81 | // This is only the case when a reschedule is triggered without the current thread |
| 77 | // yielding execution (i.e. an event triggered, system core time-sliced, etc) | 82 | // yielding execution (i.e. an event triggered, system core time-sliced, etc) |
| 78 | ready_queue.push_front(previous_thread->GetPriority(), previous_thread); | 83 | ready_queue.add(previous_thread, previous_thread->GetPriority(), false); |
| 79 | previous_thread->SetStatus(ThreadStatus::Ready); | 84 | previous_thread->SetStatus(ThreadStatus::Ready); |
| 80 | } | 85 | } |
| 81 | } | 86 | } |
| @@ -90,13 +95,12 @@ void Scheduler::SwitchContext(Thread* new_thread) { | |||
| 90 | 95 | ||
| 91 | current_thread = new_thread; | 96 | current_thread = new_thread; |
| 92 | 97 | ||
| 93 | ready_queue.remove(new_thread->GetPriority(), new_thread); | 98 | ready_queue.remove(new_thread, new_thread->GetPriority()); |
| 94 | new_thread->SetStatus(ThreadStatus::Running); | 99 | new_thread->SetStatus(ThreadStatus::Running); |
| 95 | 100 | ||
| 96 | auto* const thread_owner_process = current_thread->GetOwnerProcess(); | 101 | auto* const thread_owner_process = current_thread->GetOwnerProcess(); |
| 97 | if (previous_process != thread_owner_process) { | 102 | if (previous_process != thread_owner_process) { |
| 98 | system.Kernel().MakeCurrentProcess(thread_owner_process); | 103 | system.Kernel().MakeCurrentProcess(thread_owner_process); |
| 99 | Memory::SetCurrentPageTable(&thread_owner_process->VMManager().page_table); | ||
| 100 | } | 104 | } |
| 101 | 105 | ||
| 102 | cpu_core.LoadContext(new_thread->GetContext()); | 106 | cpu_core.LoadContext(new_thread->GetContext()); |
| @@ -127,7 +131,7 @@ void Scheduler::UpdateLastContextSwitchTime(Thread* thread, Process* process) { | |||
| 127 | } | 131 | } |
| 128 | 132 | ||
| 129 | void Scheduler::Reschedule() { | 133 | void Scheduler::Reschedule() { |
| 130 | std::lock_guard<std::mutex> lock(scheduler_mutex); | 134 | std::lock_guard lock{scheduler_mutex}; |
| 131 | 135 | ||
| 132 | Thread* cur = GetCurrentThread(); | 136 | Thread* cur = GetCurrentThread(); |
| 133 | Thread* next = PopNextReadyThread(); | 137 | Thread* next = PopNextReadyThread(); |
| @@ -143,51 +147,54 @@ void Scheduler::Reschedule() { | |||
| 143 | SwitchContext(next); | 147 | SwitchContext(next); |
| 144 | } | 148 | } |
| 145 | 149 | ||
| 146 | void Scheduler::AddThread(SharedPtr<Thread> thread, u32 priority) { | 150 | void Scheduler::AddThread(SharedPtr<Thread> thread) { |
| 147 | std::lock_guard<std::mutex> lock(scheduler_mutex); | 151 | std::lock_guard lock{scheduler_mutex}; |
| 148 | 152 | ||
| 149 | thread_list.push_back(std::move(thread)); | 153 | thread_list.push_back(std::move(thread)); |
| 150 | ready_queue.prepare(priority); | ||
| 151 | } | 154 | } |
| 152 | 155 | ||
| 153 | void Scheduler::RemoveThread(Thread* thread) { | 156 | void Scheduler::RemoveThread(Thread* thread) { |
| 154 | std::lock_guard<std::mutex> lock(scheduler_mutex); | 157 | std::lock_guard lock{scheduler_mutex}; |
| 155 | 158 | ||
| 156 | thread_list.erase(std::remove(thread_list.begin(), thread_list.end(), thread), | 159 | thread_list.erase(std::remove(thread_list.begin(), thread_list.end(), thread), |
| 157 | thread_list.end()); | 160 | thread_list.end()); |
| 158 | } | 161 | } |
| 159 | 162 | ||
| 160 | void Scheduler::ScheduleThread(Thread* thread, u32 priority) { | 163 | void Scheduler::ScheduleThread(Thread* thread, u32 priority) { |
| 161 | std::lock_guard<std::mutex> lock(scheduler_mutex); | 164 | std::lock_guard lock{scheduler_mutex}; |
| 162 | 165 | ||
| 163 | ASSERT(thread->GetStatus() == ThreadStatus::Ready); | 166 | ASSERT(thread->GetStatus() == ThreadStatus::Ready); |
| 164 | ready_queue.push_back(priority, thread); | 167 | ready_queue.add(thread, priority); |
| 165 | } | 168 | } |
| 166 | 169 | ||
| 167 | void Scheduler::UnscheduleThread(Thread* thread, u32 priority) { | 170 | void Scheduler::UnscheduleThread(Thread* thread, u32 priority) { |
| 168 | std::lock_guard<std::mutex> lock(scheduler_mutex); | 171 | std::lock_guard lock{scheduler_mutex}; |
| 169 | 172 | ||
| 170 | ASSERT(thread->GetStatus() == ThreadStatus::Ready); | 173 | ASSERT(thread->GetStatus() == ThreadStatus::Ready); |
| 171 | ready_queue.remove(priority, thread); | 174 | ready_queue.remove(thread, priority); |
| 172 | } | 175 | } |
| 173 | 176 | ||
| 174 | void Scheduler::SetThreadPriority(Thread* thread, u32 priority) { | 177 | void Scheduler::SetThreadPriority(Thread* thread, u32 priority) { |
| 175 | std::lock_guard<std::mutex> lock(scheduler_mutex); | 178 | std::lock_guard lock{scheduler_mutex}; |
| 179 | if (thread->GetPriority() == priority) { | ||
| 180 | return; | ||
| 181 | } | ||
| 176 | 182 | ||
| 177 | // If thread was ready, adjust queues | 183 | // If thread was ready, adjust queues |
| 178 | if (thread->GetStatus() == ThreadStatus::Ready) | 184 | if (thread->GetStatus() == ThreadStatus::Ready) |
| 179 | ready_queue.move(thread, thread->GetPriority(), priority); | 185 | ready_queue.adjust(thread, thread->GetPriority(), priority); |
| 180 | else | ||
| 181 | ready_queue.prepare(priority); | ||
| 182 | } | 186 | } |
| 183 | 187 | ||
| 184 | Thread* Scheduler::GetNextSuggestedThread(u32 core, u32 maximum_priority) const { | 188 | Thread* Scheduler::GetNextSuggestedThread(u32 core, u32 maximum_priority) const { |
| 185 | std::lock_guard<std::mutex> lock(scheduler_mutex); | 189 | std::lock_guard lock{scheduler_mutex}; |
| 186 | 190 | ||
| 187 | const u32 mask = 1U << core; | 191 | const u32 mask = 1U << core; |
| 188 | return ready_queue.get_first_filter([mask, maximum_priority](Thread const* thread) { | 192 | for (auto* thread : ready_queue) { |
| 189 | return (thread->GetAffinityMask() & mask) != 0 && thread->GetPriority() < maximum_priority; | 193 | if ((thread->GetAffinityMask() & mask) != 0 && thread->GetPriority() < maximum_priority) { |
| 190 | }); | 194 | return thread; |
| 195 | } | ||
| 196 | } | ||
| 197 | return nullptr; | ||
| 191 | } | 198 | } |
| 192 | 199 | ||
| 193 | void Scheduler::YieldWithoutLoadBalancing(Thread* thread) { | 200 | void Scheduler::YieldWithoutLoadBalancing(Thread* thread) { |
diff --git a/src/core/hle/kernel/scheduler.h b/src/core/hle/kernel/scheduler.h index 1c5bf57d9..b29bf7be8 100644 --- a/src/core/hle/kernel/scheduler.h +++ b/src/core/hle/kernel/scheduler.h | |||
| @@ -7,7 +7,7 @@ | |||
| 7 | #include <mutex> | 7 | #include <mutex> |
| 8 | #include <vector> | 8 | #include <vector> |
| 9 | #include "common/common_types.h" | 9 | #include "common/common_types.h" |
| 10 | #include "common/thread_queue_list.h" | 10 | #include "common/multi_level_queue.h" |
| 11 | #include "core/hle/kernel/object.h" | 11 | #include "core/hle/kernel/object.h" |
| 12 | #include "core/hle/kernel/thread.h" | 12 | #include "core/hle/kernel/thread.h" |
| 13 | 13 | ||
| @@ -38,7 +38,7 @@ public: | |||
| 38 | u64 GetLastContextSwitchTicks() const; | 38 | u64 GetLastContextSwitchTicks() const; |
| 39 | 39 | ||
| 40 | /// Adds a new thread to the scheduler | 40 | /// Adds a new thread to the scheduler |
| 41 | void AddThread(SharedPtr<Thread> thread, u32 priority); | 41 | void AddThread(SharedPtr<Thread> thread); |
| 42 | 42 | ||
| 43 | /// Removes a thread from the scheduler | 43 | /// Removes a thread from the scheduler |
| 44 | void RemoveThread(Thread* thread); | 44 | void RemoveThread(Thread* thread); |
| @@ -156,7 +156,7 @@ private: | |||
| 156 | std::vector<SharedPtr<Thread>> thread_list; | 156 | std::vector<SharedPtr<Thread>> thread_list; |
| 157 | 157 | ||
| 158 | /// Lists only ready thread ids. | 158 | /// Lists only ready thread ids. |
| 159 | Common::ThreadQueueList<Thread*, THREADPRIO_LOWEST + 1> ready_queue; | 159 | Common::MultiLevelQueue<Thread*, THREADPRIO_LOWEST + 1> ready_queue; |
| 160 | 160 | ||
| 161 | SharedPtr<Thread> current_thread = nullptr; | 161 | SharedPtr<Thread> current_thread = nullptr; |
| 162 | 162 | ||
diff --git a/src/core/hle/kernel/server_port.cpp b/src/core/hle/kernel/server_port.cpp index 0e1515c89..02e7c60e6 100644 --- a/src/core/hle/kernel/server_port.cpp +++ b/src/core/hle/kernel/server_port.cpp | |||
| @@ -30,7 +30,7 @@ void ServerPort::AppendPendingSession(SharedPtr<ServerSession> pending_session) | |||
| 30 | pending_sessions.push_back(std::move(pending_session)); | 30 | pending_sessions.push_back(std::move(pending_session)); |
| 31 | } | 31 | } |
| 32 | 32 | ||
| 33 | bool ServerPort::ShouldWait(Thread* thread) const { | 33 | bool ServerPort::ShouldWait(const Thread* thread) const { |
| 34 | // If there are no pending sessions, we wait until a new one is added. | 34 | // If there are no pending sessions, we wait until a new one is added. |
| 35 | return pending_sessions.empty(); | 35 | return pending_sessions.empty(); |
| 36 | } | 36 | } |
| @@ -39,9 +39,8 @@ void ServerPort::Acquire(Thread* thread) { | |||
| 39 | ASSERT_MSG(!ShouldWait(thread), "object unavailable!"); | 39 | ASSERT_MSG(!ShouldWait(thread), "object unavailable!"); |
| 40 | } | 40 | } |
| 41 | 41 | ||
| 42 | std::tuple<SharedPtr<ServerPort>, SharedPtr<ClientPort>> ServerPort::CreatePortPair( | 42 | ServerPort::PortPair ServerPort::CreatePortPair(KernelCore& kernel, u32 max_sessions, |
| 43 | KernelCore& kernel, u32 max_sessions, std::string name) { | 43 | std::string name) { |
| 44 | |||
| 45 | SharedPtr<ServerPort> server_port(new ServerPort(kernel)); | 44 | SharedPtr<ServerPort> server_port(new ServerPort(kernel)); |
| 46 | SharedPtr<ClientPort> client_port(new ClientPort(kernel)); | 45 | SharedPtr<ClientPort> client_port(new ClientPort(kernel)); |
| 47 | 46 | ||
| @@ -51,7 +50,7 @@ std::tuple<SharedPtr<ServerPort>, SharedPtr<ClientPort>> ServerPort::CreatePortP | |||
| 51 | client_port->max_sessions = max_sessions; | 50 | client_port->max_sessions = max_sessions; |
| 52 | client_port->active_sessions = 0; | 51 | client_port->active_sessions = 0; |
| 53 | 52 | ||
| 54 | return std::make_tuple(std::move(server_port), std::move(client_port)); | 53 | return std::make_pair(std::move(server_port), std::move(client_port)); |
| 55 | } | 54 | } |
| 56 | 55 | ||
| 57 | } // namespace Kernel | 56 | } // namespace Kernel |
diff --git a/src/core/hle/kernel/server_port.h b/src/core/hle/kernel/server_port.h index 9bc667cf2..fef573b71 100644 --- a/src/core/hle/kernel/server_port.h +++ b/src/core/hle/kernel/server_port.h | |||
| @@ -6,7 +6,7 @@ | |||
| 6 | 6 | ||
| 7 | #include <memory> | 7 | #include <memory> |
| 8 | #include <string> | 8 | #include <string> |
| 9 | #include <tuple> | 9 | #include <utility> |
| 10 | #include <vector> | 10 | #include <vector> |
| 11 | #include "common/common_types.h" | 11 | #include "common/common_types.h" |
| 12 | #include "core/hle/kernel/object.h" | 12 | #include "core/hle/kernel/object.h" |
| @@ -23,6 +23,7 @@ class SessionRequestHandler; | |||
| 23 | class ServerPort final : public WaitObject { | 23 | class ServerPort final : public WaitObject { |
| 24 | public: | 24 | public: |
| 25 | using HLEHandler = std::shared_ptr<SessionRequestHandler>; | 25 | using HLEHandler = std::shared_ptr<SessionRequestHandler>; |
| 26 | using PortPair = std::pair<SharedPtr<ServerPort>, SharedPtr<ClientPort>>; | ||
| 26 | 27 | ||
| 27 | /** | 28 | /** |
| 28 | * Creates a pair of ServerPort and an associated ClientPort. | 29 | * Creates a pair of ServerPort and an associated ClientPort. |
| @@ -32,8 +33,8 @@ public: | |||
| 32 | * @param name Optional name of the ports | 33 | * @param name Optional name of the ports |
| 33 | * @return The created port tuple | 34 | * @return The created port tuple |
| 34 | */ | 35 | */ |
| 35 | static std::tuple<SharedPtr<ServerPort>, SharedPtr<ClientPort>> CreatePortPair( | 36 | static PortPair CreatePortPair(KernelCore& kernel, u32 max_sessions, |
| 36 | KernelCore& kernel, u32 max_sessions, std::string name = "UnknownPort"); | 37 | std::string name = "UnknownPort"); |
| 37 | 38 | ||
| 38 | std::string GetTypeName() const override { | 39 | std::string GetTypeName() const override { |
| 39 | return "ServerPort"; | 40 | return "ServerPort"; |
| @@ -75,7 +76,7 @@ public: | |||
| 75 | /// waiting to be accepted by this port. | 76 | /// waiting to be accepted by this port. |
| 76 | void AppendPendingSession(SharedPtr<ServerSession> pending_session); | 77 | void AppendPendingSession(SharedPtr<ServerSession> pending_session); |
| 77 | 78 | ||
| 78 | bool ShouldWait(Thread* thread) const override; | 79 | bool ShouldWait(const Thread* thread) const override; |
| 79 | void Acquire(Thread* thread) override; | 80 | void Acquire(Thread* thread) override; |
| 80 | 81 | ||
| 81 | private: | 82 | private: |
diff --git a/src/core/hle/kernel/server_session.cpp b/src/core/hle/kernel/server_session.cpp index 4d8a337a7..a6b2cf06a 100644 --- a/src/core/hle/kernel/server_session.cpp +++ b/src/core/hle/kernel/server_session.cpp | |||
| @@ -46,7 +46,7 @@ ResultVal<SharedPtr<ServerSession>> ServerSession::Create(KernelCore& kernel, st | |||
| 46 | return MakeResult(std::move(server_session)); | 46 | return MakeResult(std::move(server_session)); |
| 47 | } | 47 | } |
| 48 | 48 | ||
| 49 | bool ServerSession::ShouldWait(Thread* thread) const { | 49 | bool ServerSession::ShouldWait(const Thread* thread) const { |
| 50 | // Closed sessions should never wait, an error will be returned from svcReplyAndReceive. | 50 | // Closed sessions should never wait, an error will be returned from svcReplyAndReceive. |
| 51 | if (parent->client == nullptr) | 51 | if (parent->client == nullptr) |
| 52 | return false; | 52 | return false; |
| @@ -204,6 +204,6 @@ ServerSession::SessionPair ServerSession::CreateSessionPair(KernelCore& kernel, | |||
| 204 | client_session->parent = parent; | 204 | client_session->parent = parent; |
| 205 | server_session->parent = parent; | 205 | server_session->parent = parent; |
| 206 | 206 | ||
| 207 | return std::make_tuple(std::move(server_session), std::move(client_session)); | 207 | return std::make_pair(std::move(server_session), std::move(client_session)); |
| 208 | } | 208 | } |
| 209 | } // namespace Kernel | 209 | } // namespace Kernel |
diff --git a/src/core/hle/kernel/server_session.h b/src/core/hle/kernel/server_session.h index aea4ccfeb..09b835ff8 100644 --- a/src/core/hle/kernel/server_session.h +++ b/src/core/hle/kernel/server_session.h | |||
| @@ -6,6 +6,7 @@ | |||
| 6 | 6 | ||
| 7 | #include <memory> | 7 | #include <memory> |
| 8 | #include <string> | 8 | #include <string> |
| 9 | #include <utility> | ||
| 9 | #include <vector> | 10 | #include <vector> |
| 10 | 11 | ||
| 11 | #include "core/hle/kernel/object.h" | 12 | #include "core/hle/kernel/object.h" |
| @@ -41,6 +42,10 @@ public: | |||
| 41 | return "ServerSession"; | 42 | return "ServerSession"; |
| 42 | } | 43 | } |
| 43 | 44 | ||
| 45 | std::string GetName() const override { | ||
| 46 | return name; | ||
| 47 | } | ||
| 48 | |||
| 44 | static const HandleType HANDLE_TYPE = HandleType::ServerSession; | 49 | static const HandleType HANDLE_TYPE = HandleType::ServerSession; |
| 45 | HandleType GetHandleType() const override { | 50 | HandleType GetHandleType() const override { |
| 46 | return HANDLE_TYPE; | 51 | return HANDLE_TYPE; |
| @@ -54,7 +59,7 @@ public: | |||
| 54 | return parent.get(); | 59 | return parent.get(); |
| 55 | } | 60 | } |
| 56 | 61 | ||
| 57 | using SessionPair = std::tuple<SharedPtr<ServerSession>, SharedPtr<ClientSession>>; | 62 | using SessionPair = std::pair<SharedPtr<ServerSession>, SharedPtr<ClientSession>>; |
| 58 | 63 | ||
| 59 | /** | 64 | /** |
| 60 | * Creates a pair of ServerSession and an associated ClientSession. | 65 | * Creates a pair of ServerSession and an associated ClientSession. |
| @@ -82,7 +87,7 @@ public: | |||
| 82 | */ | 87 | */ |
| 83 | ResultCode HandleSyncRequest(SharedPtr<Thread> thread); | 88 | ResultCode HandleSyncRequest(SharedPtr<Thread> thread); |
| 84 | 89 | ||
| 85 | bool ShouldWait(Thread* thread) const override; | 90 | bool ShouldWait(const Thread* thread) const override; |
| 86 | 91 | ||
| 87 | void Acquire(Thread* thread) override; | 92 | void Acquire(Thread* thread) override; |
| 88 | 93 | ||
diff --git a/src/core/hle/kernel/shared_memory.cpp b/src/core/hle/kernel/shared_memory.cpp index 62861da36..f15c5ee36 100644 --- a/src/core/hle/kernel/shared_memory.cpp +++ b/src/core/hle/kernel/shared_memory.cpp | |||
| @@ -9,7 +9,6 @@ | |||
| 9 | #include "core/hle/kernel/errors.h" | 9 | #include "core/hle/kernel/errors.h" |
| 10 | #include "core/hle/kernel/kernel.h" | 10 | #include "core/hle/kernel/kernel.h" |
| 11 | #include "core/hle/kernel/shared_memory.h" | 11 | #include "core/hle/kernel/shared_memory.h" |
| 12 | #include "core/memory.h" | ||
| 13 | 12 | ||
| 14 | namespace Kernel { | 13 | namespace Kernel { |
| 15 | 14 | ||
| @@ -119,7 +118,15 @@ ResultCode SharedMemory::Map(Process& target_process, VAddr address, MemoryPermi | |||
| 119 | ConvertPermissions(permissions)); | 118 | ConvertPermissions(permissions)); |
| 120 | } | 119 | } |
| 121 | 120 | ||
| 122 | ResultCode SharedMemory::Unmap(Process& target_process, VAddr address) { | 121 | ResultCode SharedMemory::Unmap(Process& target_process, VAddr address, u64 unmap_size) { |
| 122 | if (unmap_size != size) { | ||
| 123 | LOG_ERROR(Kernel, | ||
| 124 | "Invalid size passed to Unmap. Size must be equal to the size of the " | ||
| 125 | "memory managed. Shared memory size=0x{:016X}, Unmap size=0x{:016X}", | ||
| 126 | size, unmap_size); | ||
| 127 | return ERR_INVALID_SIZE; | ||
| 128 | } | ||
| 129 | |||
| 123 | // TODO(Subv): Verify what happens if the application tries to unmap an address that is not | 130 | // TODO(Subv): Verify what happens if the application tries to unmap an address that is not |
| 124 | // mapped to a SharedMemory. | 131 | // mapped to a SharedMemory. |
| 125 | return target_process.VMManager().UnmapRange(address, size); | 132 | return target_process.VMManager().UnmapRange(address, size); |
diff --git a/src/core/hle/kernel/shared_memory.h b/src/core/hle/kernel/shared_memory.h index dab2a6bea..37e18c443 100644 --- a/src/core/hle/kernel/shared_memory.h +++ b/src/core/hle/kernel/shared_memory.h | |||
| @@ -104,11 +104,17 @@ public: | |||
| 104 | 104 | ||
| 105 | /** | 105 | /** |
| 106 | * Unmaps a shared memory block from the specified address in system memory | 106 | * Unmaps a shared memory block from the specified address in system memory |
| 107 | * | ||
| 107 | * @param target_process Process from which to unmap the memory block. | 108 | * @param target_process Process from which to unmap the memory block. |
| 108 | * @param address Address in system memory where the shared memory block is mapped | 109 | * @param address Address in system memory where the shared memory block is mapped. |
| 110 | * @param unmap_size The amount of bytes to unmap from this shared memory instance. | ||
| 111 | * | ||
| 109 | * @return Result code of the unmap operation | 112 | * @return Result code of the unmap operation |
| 113 | * | ||
| 114 | * @pre The given size to unmap must be the same size as the amount of memory managed by | ||
| 115 | * the SharedMemory instance itself, otherwise ERR_INVALID_SIZE will be returned. | ||
| 110 | */ | 116 | */ |
| 111 | ResultCode Unmap(Process& target_process, VAddr address); | 117 | ResultCode Unmap(Process& target_process, VAddr address, u64 unmap_size); |
| 112 | 118 | ||
| 113 | /** | 119 | /** |
| 114 | * Gets a pointer to the shared memory block | 120 | * Gets a pointer to the shared memory block |
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp index e5e7f99e1..2fd07ab34 100644 --- a/src/core/hle/kernel/svc.cpp +++ b/src/core/hle/kernel/svc.cpp | |||
| @@ -175,11 +175,8 @@ static ResultCode SetHeapSize(VAddr* heap_addr, u64 heap_size) { | |||
| 175 | return ERR_INVALID_SIZE; | 175 | return ERR_INVALID_SIZE; |
| 176 | } | 176 | } |
| 177 | 177 | ||
| 178 | auto& vm_manager = Core::CurrentProcess()->VMManager(); | 178 | auto& vm_manager = Core::System::GetInstance().Kernel().CurrentProcess()->VMManager(); |
| 179 | const VAddr heap_base = vm_manager.GetHeapRegionBaseAddress(); | 179 | const auto alloc_result = vm_manager.SetHeapSize(heap_size); |
| 180 | const auto alloc_result = | ||
| 181 | vm_manager.HeapAllocate(heap_base, heap_size, VMAPermission::ReadWrite); | ||
| 182 | |||
| 183 | if (alloc_result.Failed()) { | 180 | if (alloc_result.Failed()) { |
| 184 | return alloc_result.Code(); | 181 | return alloc_result.Code(); |
| 185 | } | 182 | } |
| @@ -712,7 +709,7 @@ static ResultCode GetInfo(u64* result, u64 info_id, u64 handle, u64 info_sub_id) | |||
| 712 | HeapRegionBaseAddr = 4, | 709 | HeapRegionBaseAddr = 4, |
| 713 | HeapRegionSize = 5, | 710 | HeapRegionSize = 5, |
| 714 | TotalMemoryUsage = 6, | 711 | TotalMemoryUsage = 6, |
| 715 | TotalHeapUsage = 7, | 712 | TotalPhysicalMemoryUsed = 7, |
| 716 | IsCurrentProcessBeingDebugged = 8, | 713 | IsCurrentProcessBeingDebugged = 8, |
| 717 | RegisterResourceLimit = 9, | 714 | RegisterResourceLimit = 9, |
| 718 | IdleTickCount = 10, | 715 | IdleTickCount = 10, |
| @@ -748,7 +745,7 @@ static ResultCode GetInfo(u64* result, u64 info_id, u64 handle, u64 info_sub_id) | |||
| 748 | case GetInfoType::NewMapRegionBaseAddr: | 745 | case GetInfoType::NewMapRegionBaseAddr: |
| 749 | case GetInfoType::NewMapRegionSize: | 746 | case GetInfoType::NewMapRegionSize: |
| 750 | case GetInfoType::TotalMemoryUsage: | 747 | case GetInfoType::TotalMemoryUsage: |
| 751 | case GetInfoType::TotalHeapUsage: | 748 | case GetInfoType::TotalPhysicalMemoryUsed: |
| 752 | case GetInfoType::IsVirtualAddressMemoryEnabled: | 749 | case GetInfoType::IsVirtualAddressMemoryEnabled: |
| 753 | case GetInfoType::PersonalMmHeapUsage: | 750 | case GetInfoType::PersonalMmHeapUsage: |
| 754 | case GetInfoType::TitleId: | 751 | case GetInfoType::TitleId: |
| @@ -808,8 +805,8 @@ static ResultCode GetInfo(u64* result, u64 info_id, u64 handle, u64 info_sub_id) | |||
| 808 | *result = process->VMManager().GetTotalMemoryUsage(); | 805 | *result = process->VMManager().GetTotalMemoryUsage(); |
| 809 | return RESULT_SUCCESS; | 806 | return RESULT_SUCCESS; |
| 810 | 807 | ||
| 811 | case GetInfoType::TotalHeapUsage: | 808 | case GetInfoType::TotalPhysicalMemoryUsed: |
| 812 | *result = process->VMManager().GetTotalHeapUsage(); | 809 | *result = process->GetTotalPhysicalMemoryUsed(); |
| 813 | return RESULT_SUCCESS; | 810 | return RESULT_SUCCESS; |
| 814 | 811 | ||
| 815 | case GetInfoType::IsVirtualAddressMemoryEnabled: | 812 | case GetInfoType::IsVirtualAddressMemoryEnabled: |
| @@ -1143,7 +1140,7 @@ static ResultCode UnmapSharedMemory(Handle shared_memory_handle, VAddr addr, u64 | |||
| 1143 | return ERR_INVALID_MEMORY_RANGE; | 1140 | return ERR_INVALID_MEMORY_RANGE; |
| 1144 | } | 1141 | } |
| 1145 | 1142 | ||
| 1146 | return shared_memory->Unmap(*current_process, addr); | 1143 | return shared_memory->Unmap(*current_process, addr, size); |
| 1147 | } | 1144 | } |
| 1148 | 1145 | ||
| 1149 | static ResultCode QueryProcessMemory(VAddr memory_info_address, VAddr page_info_address, | 1146 | static ResultCode QueryProcessMemory(VAddr memory_info_address, VAddr page_info_address, |
| @@ -1342,6 +1339,20 @@ static ResultCode WaitProcessWideKeyAtomic(VAddr mutex_addr, VAddr condition_var | |||
| 1342 | "called mutex_addr={:X}, condition_variable_addr={:X}, thread_handle=0x{:08X}, timeout={}", | 1339 | "called mutex_addr={:X}, condition_variable_addr={:X}, thread_handle=0x{:08X}, timeout={}", |
| 1343 | mutex_addr, condition_variable_addr, thread_handle, nano_seconds); | 1340 | mutex_addr, condition_variable_addr, thread_handle, nano_seconds); |
| 1344 | 1341 | ||
| 1342 | if (Memory::IsKernelVirtualAddress(mutex_addr)) { | ||
| 1343 | LOG_ERROR( | ||
| 1344 | Kernel_SVC, | ||
| 1345 | "Given mutex address must not be within the kernel address space. address=0x{:016X}", | ||
| 1346 | mutex_addr); | ||
| 1347 | return ERR_INVALID_ADDRESS_STATE; | ||
| 1348 | } | ||
| 1349 | |||
| 1350 | if (!Common::IsWordAligned(mutex_addr)) { | ||
| 1351 | LOG_ERROR(Kernel_SVC, "Given mutex address must be word-aligned. address=0x{:016X}", | ||
| 1352 | mutex_addr); | ||
| 1353 | return ERR_INVALID_ADDRESS; | ||
| 1354 | } | ||
| 1355 | |||
| 1345 | auto* const current_process = Core::System::GetInstance().Kernel().CurrentProcess(); | 1356 | auto* const current_process = Core::System::GetInstance().Kernel().CurrentProcess(); |
| 1346 | const auto& handle_table = current_process->GetHandleTable(); | 1357 | const auto& handle_table = current_process->GetHandleTable(); |
| 1347 | SharedPtr<Thread> thread = handle_table.Get<Thread>(thread_handle); | 1358 | SharedPtr<Thread> thread = handle_table.Get<Thread>(thread_handle); |
| @@ -1356,7 +1367,7 @@ static ResultCode WaitProcessWideKeyAtomic(VAddr mutex_addr, VAddr condition_var | |||
| 1356 | current_thread->SetCondVarWaitAddress(condition_variable_addr); | 1367 | current_thread->SetCondVarWaitAddress(condition_variable_addr); |
| 1357 | current_thread->SetMutexWaitAddress(mutex_addr); | 1368 | current_thread->SetMutexWaitAddress(mutex_addr); |
| 1358 | current_thread->SetWaitHandle(thread_handle); | 1369 | current_thread->SetWaitHandle(thread_handle); |
| 1359 | current_thread->SetStatus(ThreadStatus::WaitMutex); | 1370 | current_thread->SetStatus(ThreadStatus::WaitCondVar); |
| 1360 | current_thread->InvalidateWakeupCallback(); | 1371 | current_thread->InvalidateWakeupCallback(); |
| 1361 | 1372 | ||
| 1362 | current_thread->WakeAfterDelay(nano_seconds); | 1373 | current_thread->WakeAfterDelay(nano_seconds); |
| @@ -1400,10 +1411,10 @@ static ResultCode SignalProcessWideKey(VAddr condition_variable_addr, s32 target | |||
| 1400 | // them all. | 1411 | // them all. |
| 1401 | std::size_t last = waiting_threads.size(); | 1412 | std::size_t last = waiting_threads.size(); |
| 1402 | if (target != -1) | 1413 | if (target != -1) |
| 1403 | last = target; | 1414 | last = std::min(waiting_threads.size(), static_cast<std::size_t>(target)); |
| 1404 | 1415 | ||
| 1405 | // If there are no threads waiting on this condition variable, just exit | 1416 | // If there are no threads waiting on this condition variable, just exit |
| 1406 | if (last > waiting_threads.size()) | 1417 | if (last == 0) |
| 1407 | return RESULT_SUCCESS; | 1418 | return RESULT_SUCCESS; |
| 1408 | 1419 | ||
| 1409 | for (std::size_t index = 0; index < last; ++index) { | 1420 | for (std::size_t index = 0; index < last; ++index) { |
| @@ -1411,6 +1422,9 @@ static ResultCode SignalProcessWideKey(VAddr condition_variable_addr, s32 target | |||
| 1411 | 1422 | ||
| 1412 | ASSERT(thread->GetCondVarWaitAddress() == condition_variable_addr); | 1423 | ASSERT(thread->GetCondVarWaitAddress() == condition_variable_addr); |
| 1413 | 1424 | ||
| 1425 | // liberate Cond Var Thread. | ||
| 1426 | thread->SetCondVarWaitAddress(0); | ||
| 1427 | |||
| 1414 | std::size_t current_core = Core::System::GetInstance().CurrentCoreIndex(); | 1428 | std::size_t current_core = Core::System::GetInstance().CurrentCoreIndex(); |
| 1415 | 1429 | ||
| 1416 | auto& monitor = Core::System::GetInstance().Monitor(); | 1430 | auto& monitor = Core::System::GetInstance().Monitor(); |
| @@ -1429,10 +1443,9 @@ static ResultCode SignalProcessWideKey(VAddr condition_variable_addr, s32 target | |||
| 1429 | } | 1443 | } |
| 1430 | } while (!monitor.ExclusiveWrite32(current_core, thread->GetMutexWaitAddress(), | 1444 | } while (!monitor.ExclusiveWrite32(current_core, thread->GetMutexWaitAddress(), |
| 1431 | thread->GetWaitHandle())); | 1445 | thread->GetWaitHandle())); |
| 1432 | |||
| 1433 | if (mutex_val == 0) { | 1446 | if (mutex_val == 0) { |
| 1434 | // We were able to acquire the mutex, resume this thread. | 1447 | // We were able to acquire the mutex, resume this thread. |
| 1435 | ASSERT(thread->GetStatus() == ThreadStatus::WaitMutex); | 1448 | ASSERT(thread->GetStatus() == ThreadStatus::WaitCondVar); |
| 1436 | thread->ResumeFromWait(); | 1449 | thread->ResumeFromWait(); |
| 1437 | 1450 | ||
| 1438 | auto* const lock_owner = thread->GetLockOwner(); | 1451 | auto* const lock_owner = thread->GetLockOwner(); |
| @@ -1442,8 +1455,8 @@ static ResultCode SignalProcessWideKey(VAddr condition_variable_addr, s32 target | |||
| 1442 | 1455 | ||
| 1443 | thread->SetLockOwner(nullptr); | 1456 | thread->SetLockOwner(nullptr); |
| 1444 | thread->SetMutexWaitAddress(0); | 1457 | thread->SetMutexWaitAddress(0); |
| 1445 | thread->SetCondVarWaitAddress(0); | ||
| 1446 | thread->SetWaitHandle(0); | 1458 | thread->SetWaitHandle(0); |
| 1459 | Core::System::GetInstance().CpuCore(thread->GetProcessorID()).PrepareReschedule(); | ||
| 1447 | } else { | 1460 | } else { |
| 1448 | // Atomically signal that the mutex now has a waiting thread. | 1461 | // Atomically signal that the mutex now has a waiting thread. |
| 1449 | do { | 1462 | do { |
| @@ -1462,12 +1475,11 @@ static ResultCode SignalProcessWideKey(VAddr condition_variable_addr, s32 target | |||
| 1462 | const auto& handle_table = Core::CurrentProcess()->GetHandleTable(); | 1475 | const auto& handle_table = Core::CurrentProcess()->GetHandleTable(); |
| 1463 | auto owner = handle_table.Get<Thread>(owner_handle); | 1476 | auto owner = handle_table.Get<Thread>(owner_handle); |
| 1464 | ASSERT(owner); | 1477 | ASSERT(owner); |
| 1465 | ASSERT(thread->GetStatus() == ThreadStatus::WaitMutex); | 1478 | ASSERT(thread->GetStatus() == ThreadStatus::WaitCondVar); |
| 1466 | thread->InvalidateWakeupCallback(); | 1479 | thread->InvalidateWakeupCallback(); |
| 1480 | thread->SetStatus(ThreadStatus::WaitMutex); | ||
| 1467 | 1481 | ||
| 1468 | owner->AddMutexWaiter(thread); | 1482 | owner->AddMutexWaiter(thread); |
| 1469 | |||
| 1470 | Core::System::GetInstance().CpuCore(thread->GetProcessorID()).PrepareReschedule(); | ||
| 1471 | } | 1483 | } |
| 1472 | } | 1484 | } |
| 1473 | 1485 | ||
| @@ -1985,6 +1997,83 @@ static ResultCode SetResourceLimitLimitValue(Handle resource_limit, u32 resource | |||
| 1985 | return RESULT_SUCCESS; | 1997 | return RESULT_SUCCESS; |
| 1986 | } | 1998 | } |
| 1987 | 1999 | ||
| 2000 | static ResultCode GetProcessList(u32* out_num_processes, VAddr out_process_ids, | ||
| 2001 | u32 out_process_ids_size) { | ||
| 2002 | LOG_DEBUG(Kernel_SVC, "called. out_process_ids=0x{:016X}, out_process_ids_size={}", | ||
| 2003 | out_process_ids, out_process_ids_size); | ||
| 2004 | |||
| 2005 | // If the supplied size is negative or greater than INT32_MAX / sizeof(u64), bail. | ||
| 2006 | if ((out_process_ids_size & 0xF0000000) != 0) { | ||
| 2007 | LOG_ERROR(Kernel_SVC, | ||
| 2008 | "Supplied size outside [0, 0x0FFFFFFF] range. out_process_ids_size={}", | ||
| 2009 | out_process_ids_size); | ||
| 2010 | return ERR_OUT_OF_RANGE; | ||
| 2011 | } | ||
| 2012 | |||
| 2013 | const auto& kernel = Core::System::GetInstance().Kernel(); | ||
| 2014 | const auto& vm_manager = kernel.CurrentProcess()->VMManager(); | ||
| 2015 | const auto total_copy_size = out_process_ids_size * sizeof(u64); | ||
| 2016 | |||
| 2017 | if (out_process_ids_size > 0 && | ||
| 2018 | !vm_manager.IsWithinAddressSpace(out_process_ids, total_copy_size)) { | ||
| 2019 | LOG_ERROR(Kernel_SVC, "Address range outside address space. begin=0x{:016X}, end=0x{:016X}", | ||
| 2020 | out_process_ids, out_process_ids + total_copy_size); | ||
| 2021 | return ERR_INVALID_ADDRESS_STATE; | ||
| 2022 | } | ||
| 2023 | |||
| 2024 | const auto& process_list = kernel.GetProcessList(); | ||
| 2025 | const auto num_processes = process_list.size(); | ||
| 2026 | const auto copy_amount = std::min(std::size_t{out_process_ids_size}, num_processes); | ||
| 2027 | |||
| 2028 | for (std::size_t i = 0; i < copy_amount; ++i) { | ||
| 2029 | Memory::Write64(out_process_ids, process_list[i]->GetProcessID()); | ||
| 2030 | out_process_ids += sizeof(u64); | ||
| 2031 | } | ||
| 2032 | |||
| 2033 | *out_num_processes = static_cast<u32>(num_processes); | ||
| 2034 | return RESULT_SUCCESS; | ||
| 2035 | } | ||
| 2036 | |||
| 2037 | ResultCode GetThreadList(u32* out_num_threads, VAddr out_thread_ids, u32 out_thread_ids_size, | ||
| 2038 | Handle debug_handle) { | ||
| 2039 | // TODO: Handle this case when debug events are supported. | ||
| 2040 | UNIMPLEMENTED_IF(debug_handle != InvalidHandle); | ||
| 2041 | |||
| 2042 | LOG_DEBUG(Kernel_SVC, "called. out_thread_ids=0x{:016X}, out_thread_ids_size={}", | ||
| 2043 | out_thread_ids, out_thread_ids_size); | ||
| 2044 | |||
| 2045 | // If the size is negative or larger than INT32_MAX / sizeof(u64) | ||
| 2046 | if ((out_thread_ids_size & 0xF0000000) != 0) { | ||
| 2047 | LOG_ERROR(Kernel_SVC, "Supplied size outside [0, 0x0FFFFFFF] range. size={}", | ||
| 2048 | out_thread_ids_size); | ||
| 2049 | return ERR_OUT_OF_RANGE; | ||
| 2050 | } | ||
| 2051 | |||
| 2052 | const auto* const current_process = Core::System::GetInstance().Kernel().CurrentProcess(); | ||
| 2053 | const auto& vm_manager = current_process->VMManager(); | ||
| 2054 | const auto total_copy_size = out_thread_ids_size * sizeof(u64); | ||
| 2055 | |||
| 2056 | if (out_thread_ids_size > 0 && | ||
| 2057 | !vm_manager.IsWithinAddressSpace(out_thread_ids, total_copy_size)) { | ||
| 2058 | LOG_ERROR(Kernel_SVC, "Address range outside address space. begin=0x{:016X}, end=0x{:016X}", | ||
| 2059 | out_thread_ids, out_thread_ids + total_copy_size); | ||
| 2060 | return ERR_INVALID_ADDRESS_STATE; | ||
| 2061 | } | ||
| 2062 | |||
| 2063 | const auto& thread_list = current_process->GetThreadList(); | ||
| 2064 | const auto num_threads = thread_list.size(); | ||
| 2065 | const auto copy_amount = std::min(std::size_t{out_thread_ids_size}, num_threads); | ||
| 2066 | |||
| 2067 | auto list_iter = thread_list.cbegin(); | ||
| 2068 | for (std::size_t i = 0; i < copy_amount; ++i, ++list_iter) { | ||
| 2069 | Memory::Write64(out_thread_ids, (*list_iter)->GetThreadID()); | ||
| 2070 | out_thread_ids += sizeof(u64); | ||
| 2071 | } | ||
| 2072 | |||
| 2073 | *out_num_threads = static_cast<u32>(num_threads); | ||
| 2074 | return RESULT_SUCCESS; | ||
| 2075 | } | ||
| 2076 | |||
| 1988 | namespace { | 2077 | namespace { |
| 1989 | struct FunctionDef { | 2078 | struct FunctionDef { |
| 1990 | using Func = void(); | 2079 | using Func = void(); |
| @@ -2097,8 +2186,8 @@ static const FunctionDef SVC_Table[] = { | |||
| 2097 | {0x62, nullptr, "TerminateDebugProcess"}, | 2186 | {0x62, nullptr, "TerminateDebugProcess"}, |
| 2098 | {0x63, nullptr, "GetDebugEvent"}, | 2187 | {0x63, nullptr, "GetDebugEvent"}, |
| 2099 | {0x64, nullptr, "ContinueDebugEvent"}, | 2188 | {0x64, nullptr, "ContinueDebugEvent"}, |
| 2100 | {0x65, nullptr, "GetProcessList"}, | 2189 | {0x65, SvcWrap<GetProcessList>, "GetProcessList"}, |
| 2101 | {0x66, nullptr, "GetThreadList"}, | 2190 | {0x66, SvcWrap<GetThreadList>, "GetThreadList"}, |
| 2102 | {0x67, nullptr, "GetDebugThreadContext"}, | 2191 | {0x67, nullptr, "GetDebugThreadContext"}, |
| 2103 | {0x68, nullptr, "SetDebugThreadContext"}, | 2192 | {0x68, nullptr, "SetDebugThreadContext"}, |
| 2104 | {0x69, nullptr, "QueryDebugProcessMemory"}, | 2193 | {0x69, nullptr, "QueryDebugProcessMemory"}, |
| @@ -2140,7 +2229,7 @@ void CallSVC(u32 immediate) { | |||
| 2140 | MICROPROFILE_SCOPE(Kernel_SVC); | 2229 | MICROPROFILE_SCOPE(Kernel_SVC); |
| 2141 | 2230 | ||
| 2142 | // Lock the global kernel mutex when we enter the kernel HLE. | 2231 | // Lock the global kernel mutex when we enter the kernel HLE. |
| 2143 | std::lock_guard<std::recursive_mutex> lock(HLE::g_hle_lock); | 2232 | std::lock_guard lock{HLE::g_hle_lock}; |
| 2144 | 2233 | ||
| 2145 | const FunctionDef* info = GetSVCInfo(immediate); | 2234 | const FunctionDef* info = GetSVCInfo(immediate); |
| 2146 | if (info) { | 2235 | if (info) { |
diff --git a/src/core/hle/kernel/svc_wrap.h b/src/core/hle/kernel/svc_wrap.h index 2a2c2c5ea..b3733680f 100644 --- a/src/core/hle/kernel/svc_wrap.h +++ b/src/core/hle/kernel/svc_wrap.h | |||
| @@ -78,6 +78,14 @@ void SvcWrap() { | |||
| 78 | FuncReturn(retval); | 78 | FuncReturn(retval); |
| 79 | } | 79 | } |
| 80 | 80 | ||
| 81 | template <ResultCode func(u32*, u64, u32)> | ||
| 82 | void SvcWrap() { | ||
| 83 | u32 param_1 = 0; | ||
| 84 | const u32 retval = func(¶m_1, Param(1), static_cast<u32>(Param(2))).raw; | ||
| 85 | Core::CurrentArmInterface().SetReg(1, param_1); | ||
| 86 | FuncReturn(retval); | ||
| 87 | } | ||
| 88 | |||
| 81 | template <ResultCode func(u64*, u32)> | 89 | template <ResultCode func(u64*, u32)> |
| 82 | void SvcWrap() { | 90 | void SvcWrap() { |
| 83 | u64 param_1 = 0; | 91 | u64 param_1 = 0; |
diff --git a/src/core/hle/kernel/thread.cpp b/src/core/hle/kernel/thread.cpp index 3b22e8e0d..1b891f632 100644 --- a/src/core/hle/kernel/thread.cpp +++ b/src/core/hle/kernel/thread.cpp | |||
| @@ -28,7 +28,7 @@ | |||
| 28 | 28 | ||
| 29 | namespace Kernel { | 29 | namespace Kernel { |
| 30 | 30 | ||
| 31 | bool Thread::ShouldWait(Thread* thread) const { | 31 | bool Thread::ShouldWait(const Thread* thread) const { |
| 32 | return status != ThreadStatus::Dead; | 32 | return status != ThreadStatus::Dead; |
| 33 | } | 33 | } |
| 34 | 34 | ||
| @@ -62,6 +62,8 @@ void Thread::Stop() { | |||
| 62 | } | 62 | } |
| 63 | wait_objects.clear(); | 63 | wait_objects.clear(); |
| 64 | 64 | ||
| 65 | owner_process->UnregisterThread(this); | ||
| 66 | |||
| 65 | // Mark the TLS slot in the thread's page as free. | 67 | // Mark the TLS slot in the thread's page as free. |
| 66 | owner_process->FreeTLSSlot(tls_address); | 68 | owner_process->FreeTLSSlot(tls_address); |
| 67 | } | 69 | } |
| @@ -105,6 +107,7 @@ void Thread::ResumeFromWait() { | |||
| 105 | case ThreadStatus::WaitSleep: | 107 | case ThreadStatus::WaitSleep: |
| 106 | case ThreadStatus::WaitIPC: | 108 | case ThreadStatus::WaitIPC: |
| 107 | case ThreadStatus::WaitMutex: | 109 | case ThreadStatus::WaitMutex: |
| 110 | case ThreadStatus::WaitCondVar: | ||
| 108 | case ThreadStatus::WaitArb: | 111 | case ThreadStatus::WaitArb: |
| 109 | break; | 112 | break; |
| 110 | 113 | ||
| @@ -198,9 +201,11 @@ ResultVal<SharedPtr<Thread>> Thread::Create(KernelCore& kernel, std::string name | |||
| 198 | thread->callback_handle = kernel.ThreadWakeupCallbackHandleTable().Create(thread).Unwrap(); | 201 | thread->callback_handle = kernel.ThreadWakeupCallbackHandleTable().Create(thread).Unwrap(); |
| 199 | thread->owner_process = &owner_process; | 202 | thread->owner_process = &owner_process; |
| 200 | thread->scheduler = &system.Scheduler(processor_id); | 203 | thread->scheduler = &system.Scheduler(processor_id); |
| 201 | thread->scheduler->AddThread(thread, priority); | 204 | thread->scheduler->AddThread(thread); |
| 202 | thread->tls_address = thread->owner_process->MarkNextAvailableTLSSlotAsUsed(*thread); | 205 | thread->tls_address = thread->owner_process->MarkNextAvailableTLSSlotAsUsed(*thread); |
| 203 | 206 | ||
| 207 | thread->owner_process->RegisterThread(thread.get()); | ||
| 208 | |||
| 204 | // TODO(peachum): move to ScheduleThread() when scheduler is added so selected core is used | 209 | // TODO(peachum): move to ScheduleThread() when scheduler is added so selected core is used |
| 205 | // to initialize the context | 210 | // to initialize the context |
| 206 | ResetThreadContext(thread->context, stack_top, entry_point, arg); | 211 | ResetThreadContext(thread->context, stack_top, entry_point, arg); |
| @@ -228,16 +233,16 @@ void Thread::SetWaitSynchronizationOutput(s32 output) { | |||
| 228 | context.cpu_registers[1] = output; | 233 | context.cpu_registers[1] = output; |
| 229 | } | 234 | } |
| 230 | 235 | ||
| 231 | s32 Thread::GetWaitObjectIndex(WaitObject* object) const { | 236 | s32 Thread::GetWaitObjectIndex(const WaitObject* object) const { |
| 232 | ASSERT_MSG(!wait_objects.empty(), "Thread is not waiting for anything"); | 237 | ASSERT_MSG(!wait_objects.empty(), "Thread is not waiting for anything"); |
| 233 | auto match = std::find(wait_objects.rbegin(), wait_objects.rend(), object); | 238 | const auto match = std::find(wait_objects.rbegin(), wait_objects.rend(), object); |
| 234 | return static_cast<s32>(std::distance(match, wait_objects.rend()) - 1); | 239 | return static_cast<s32>(std::distance(match, wait_objects.rend()) - 1); |
| 235 | } | 240 | } |
| 236 | 241 | ||
| 237 | VAddr Thread::GetCommandBufferAddress() const { | 242 | VAddr Thread::GetCommandBufferAddress() const { |
| 238 | // Offset from the start of TLS at which the IPC command buffer begins. | 243 | // Offset from the start of TLS at which the IPC command buffer begins. |
| 239 | static constexpr int CommandHeaderOffset = 0x80; | 244 | constexpr u64 command_header_offset = 0x80; |
| 240 | return GetTLSAddress() + CommandHeaderOffset; | 245 | return GetTLSAddress() + command_header_offset; |
| 241 | } | 246 | } |
| 242 | 247 | ||
| 243 | void Thread::SetStatus(ThreadStatus new_status) { | 248 | void Thread::SetStatus(ThreadStatus new_status) { |
| @@ -351,7 +356,7 @@ void Thread::ChangeScheduler() { | |||
| 351 | if (*new_processor_id != processor_id) { | 356 | if (*new_processor_id != processor_id) { |
| 352 | // Remove thread from previous core's scheduler | 357 | // Remove thread from previous core's scheduler |
| 353 | scheduler->RemoveThread(this); | 358 | scheduler->RemoveThread(this); |
| 354 | next_scheduler.AddThread(this, current_priority); | 359 | next_scheduler.AddThread(this); |
| 355 | } | 360 | } |
| 356 | 361 | ||
| 357 | processor_id = *new_processor_id; | 362 | processor_id = *new_processor_id; |
| @@ -366,7 +371,7 @@ void Thread::ChangeScheduler() { | |||
| 366 | system.CpuCore(processor_id).PrepareReschedule(); | 371 | system.CpuCore(processor_id).PrepareReschedule(); |
| 367 | } | 372 | } |
| 368 | 373 | ||
| 369 | bool Thread::AllWaitObjectsReady() { | 374 | bool Thread::AllWaitObjectsReady() const { |
| 370 | return std::none_of( | 375 | return std::none_of( |
| 371 | wait_objects.begin(), wait_objects.end(), | 376 | wait_objects.begin(), wait_objects.end(), |
| 372 | [this](const SharedPtr<WaitObject>& object) { return object->ShouldWait(this); }); | 377 | [this](const SharedPtr<WaitObject>& object) { return object->ShouldWait(this); }); |
diff --git a/src/core/hle/kernel/thread.h b/src/core/hle/kernel/thread.h index faad5f391..73e5d1bb4 100644 --- a/src/core/hle/kernel/thread.h +++ b/src/core/hle/kernel/thread.h | |||
| @@ -51,7 +51,8 @@ enum class ThreadStatus { | |||
| 51 | WaitIPC, ///< Waiting for the reply from an IPC request | 51 | WaitIPC, ///< Waiting for the reply from an IPC request |
| 52 | WaitSynchAny, ///< Waiting due to WaitSynch1 or WaitSynchN with wait_all = false | 52 | WaitSynchAny, ///< Waiting due to WaitSynch1 or WaitSynchN with wait_all = false |
| 53 | WaitSynchAll, ///< Waiting due to WaitSynchronizationN with wait_all = true | 53 | WaitSynchAll, ///< Waiting due to WaitSynchronizationN with wait_all = true |
| 54 | WaitMutex, ///< Waiting due to an ArbitrateLock/WaitProcessWideKey svc | 54 | WaitMutex, ///< Waiting due to an ArbitrateLock svc |
| 55 | WaitCondVar, ///< Waiting due to an WaitProcessWideKey svc | ||
| 55 | WaitArb, ///< Waiting due to a SignalToAddress/WaitForAddress svc | 56 | WaitArb, ///< Waiting due to a SignalToAddress/WaitForAddress svc |
| 56 | Dormant, ///< Created but not yet made ready | 57 | Dormant, ///< Created but not yet made ready |
| 57 | Dead ///< Run to completion, or forcefully terminated | 58 | Dead ///< Run to completion, or forcefully terminated |
| @@ -110,7 +111,7 @@ public: | |||
| 110 | return HANDLE_TYPE; | 111 | return HANDLE_TYPE; |
| 111 | } | 112 | } |
| 112 | 113 | ||
| 113 | bool ShouldWait(Thread* thread) const override; | 114 | bool ShouldWait(const Thread* thread) const override; |
| 114 | void Acquire(Thread* thread) override; | 115 | void Acquire(Thread* thread) override; |
| 115 | 116 | ||
| 116 | /** | 117 | /** |
| @@ -204,7 +205,7 @@ public: | |||
| 204 | * object in the list. | 205 | * object in the list. |
| 205 | * @param object Object to query the index of. | 206 | * @param object Object to query the index of. |
| 206 | */ | 207 | */ |
| 207 | s32 GetWaitObjectIndex(WaitObject* object) const; | 208 | s32 GetWaitObjectIndex(const WaitObject* object) const; |
| 208 | 209 | ||
| 209 | /** | 210 | /** |
| 210 | * Stops a thread, invalidating it from further use | 211 | * Stops a thread, invalidating it from further use |
| @@ -298,7 +299,7 @@ public: | |||
| 298 | } | 299 | } |
| 299 | 300 | ||
| 300 | /// Determines whether all the objects this thread is waiting on are ready. | 301 | /// Determines whether all the objects this thread is waiting on are ready. |
| 301 | bool AllWaitObjectsReady(); | 302 | bool AllWaitObjectsReady() const; |
| 302 | 303 | ||
| 303 | const MutexWaitingThreads& GetMutexWaitingThreads() const { | 304 | const MutexWaitingThreads& GetMutexWaitingThreads() const { |
| 304 | return wait_mutex_threads; | 305 | return wait_mutex_threads; |
diff --git a/src/core/hle/kernel/transfer_memory.cpp b/src/core/hle/kernel/transfer_memory.cpp index 23228e1b5..26c4e5e67 100644 --- a/src/core/hle/kernel/transfer_memory.cpp +++ b/src/core/hle/kernel/transfer_memory.cpp | |||
| @@ -14,8 +14,8 @@ namespace Kernel { | |||
| 14 | TransferMemory::TransferMemory(KernelCore& kernel) : Object{kernel} {} | 14 | TransferMemory::TransferMemory(KernelCore& kernel) : Object{kernel} {} |
| 15 | TransferMemory::~TransferMemory() = default; | 15 | TransferMemory::~TransferMemory() = default; |
| 16 | 16 | ||
| 17 | SharedPtr<TransferMemory> TransferMemory::Create(KernelCore& kernel, VAddr base_address, | 17 | SharedPtr<TransferMemory> TransferMemory::Create(KernelCore& kernel, VAddr base_address, u64 size, |
| 18 | size_t size, MemoryPermission permissions) { | 18 | MemoryPermission permissions) { |
| 19 | SharedPtr<TransferMemory> transfer_memory{new TransferMemory(kernel)}; | 19 | SharedPtr<TransferMemory> transfer_memory{new TransferMemory(kernel)}; |
| 20 | 20 | ||
| 21 | transfer_memory->base_address = base_address; | 21 | transfer_memory->base_address = base_address; |
| @@ -26,7 +26,15 @@ SharedPtr<TransferMemory> TransferMemory::Create(KernelCore& kernel, VAddr base_ | |||
| 26 | return transfer_memory; | 26 | return transfer_memory; |
| 27 | } | 27 | } |
| 28 | 28 | ||
| 29 | ResultCode TransferMemory::MapMemory(VAddr address, size_t size, MemoryPermission permissions) { | 29 | const u8* TransferMemory::GetPointer() const { |
| 30 | return backing_block.get()->data(); | ||
| 31 | } | ||
| 32 | |||
| 33 | u64 TransferMemory::GetSize() const { | ||
| 34 | return memory_size; | ||
| 35 | } | ||
| 36 | |||
| 37 | ResultCode TransferMemory::MapMemory(VAddr address, u64 size, MemoryPermission permissions) { | ||
| 30 | if (memory_size != size) { | 38 | if (memory_size != size) { |
| 31 | return ERR_INVALID_SIZE; | 39 | return ERR_INVALID_SIZE; |
| 32 | } | 40 | } |
| @@ -39,13 +47,13 @@ ResultCode TransferMemory::MapMemory(VAddr address, size_t size, MemoryPermissio | |||
| 39 | return ERR_INVALID_STATE; | 47 | return ERR_INVALID_STATE; |
| 40 | } | 48 | } |
| 41 | 49 | ||
| 50 | backing_block = std::make_shared<std::vector<u8>>(size); | ||
| 51 | |||
| 42 | const auto map_state = owner_permissions == MemoryPermission::None | 52 | const auto map_state = owner_permissions == MemoryPermission::None |
| 43 | ? MemoryState::TransferMemoryIsolated | 53 | ? MemoryState::TransferMemoryIsolated |
| 44 | : MemoryState::TransferMemory; | 54 | : MemoryState::TransferMemory; |
| 45 | auto& vm_manager = owner_process->VMManager(); | 55 | auto& vm_manager = owner_process->VMManager(); |
| 46 | const auto map_result = vm_manager.MapMemoryBlock( | 56 | const auto map_result = vm_manager.MapMemoryBlock(address, backing_block, 0, size, map_state); |
| 47 | address, std::make_shared<std::vector<u8>>(size), 0, size, map_state); | ||
| 48 | |||
| 49 | if (map_result.Failed()) { | 57 | if (map_result.Failed()) { |
| 50 | return map_result.Code(); | 58 | return map_result.Code(); |
| 51 | } | 59 | } |
| @@ -54,7 +62,7 @@ ResultCode TransferMemory::MapMemory(VAddr address, size_t size, MemoryPermissio | |||
| 54 | return RESULT_SUCCESS; | 62 | return RESULT_SUCCESS; |
| 55 | } | 63 | } |
| 56 | 64 | ||
| 57 | ResultCode TransferMemory::UnmapMemory(VAddr address, size_t size) { | 65 | ResultCode TransferMemory::UnmapMemory(VAddr address, u64 size) { |
| 58 | if (memory_size != size) { | 66 | if (memory_size != size) { |
| 59 | return ERR_INVALID_SIZE; | 67 | return ERR_INVALID_SIZE; |
| 60 | } | 68 | } |
diff --git a/src/core/hle/kernel/transfer_memory.h b/src/core/hle/kernel/transfer_memory.h index ec294951e..a140b1e2b 100644 --- a/src/core/hle/kernel/transfer_memory.h +++ b/src/core/hle/kernel/transfer_memory.h | |||
| @@ -4,6 +4,9 @@ | |||
| 4 | 4 | ||
| 5 | #pragma once | 5 | #pragma once |
| 6 | 6 | ||
| 7 | #include <memory> | ||
| 8 | #include <vector> | ||
| 9 | |||
| 7 | #include "core/hle/kernel/object.h" | 10 | #include "core/hle/kernel/object.h" |
| 8 | 11 | ||
| 9 | union ResultCode; | 12 | union ResultCode; |
| @@ -25,7 +28,7 @@ class TransferMemory final : public Object { | |||
| 25 | public: | 28 | public: |
| 26 | static constexpr HandleType HANDLE_TYPE = HandleType::TransferMemory; | 29 | static constexpr HandleType HANDLE_TYPE = HandleType::TransferMemory; |
| 27 | 30 | ||
| 28 | static SharedPtr<TransferMemory> Create(KernelCore& kernel, VAddr base_address, size_t size, | 31 | static SharedPtr<TransferMemory> Create(KernelCore& kernel, VAddr base_address, u64 size, |
| 29 | MemoryPermission permissions); | 32 | MemoryPermission permissions); |
| 30 | 33 | ||
| 31 | TransferMemory(const TransferMemory&) = delete; | 34 | TransferMemory(const TransferMemory&) = delete; |
| @@ -46,6 +49,12 @@ public: | |||
| 46 | return HANDLE_TYPE; | 49 | return HANDLE_TYPE; |
| 47 | } | 50 | } |
| 48 | 51 | ||
| 52 | /// Gets a pointer to the backing block of this instance. | ||
| 53 | const u8* GetPointer() const; | ||
| 54 | |||
| 55 | /// Gets the size of the memory backing this instance in bytes. | ||
| 56 | u64 GetSize() const; | ||
| 57 | |||
| 49 | /// Attempts to map transfer memory with the given range and memory permissions. | 58 | /// Attempts to map transfer memory with the given range and memory permissions. |
| 50 | /// | 59 | /// |
| 51 | /// @param address The base address to being mapping memory at. | 60 | /// @param address The base address to being mapping memory at. |
| @@ -56,7 +65,7 @@ public: | |||
| 56 | /// the same values that were given when creating the transfer memory | 65 | /// the same values that were given when creating the transfer memory |
| 57 | /// instance. | 66 | /// instance. |
| 58 | /// | 67 | /// |
| 59 | ResultCode MapMemory(VAddr address, size_t size, MemoryPermission permissions); | 68 | ResultCode MapMemory(VAddr address, u64 size, MemoryPermission permissions); |
| 60 | 69 | ||
| 61 | /// Unmaps the transfer memory with the given range | 70 | /// Unmaps the transfer memory with the given range |
| 62 | /// | 71 | /// |
| @@ -66,17 +75,20 @@ public: | |||
| 66 | /// @pre The given address and size must be the same as the ones used | 75 | /// @pre The given address and size must be the same as the ones used |
| 67 | /// to create the transfer memory instance. | 76 | /// to create the transfer memory instance. |
| 68 | /// | 77 | /// |
| 69 | ResultCode UnmapMemory(VAddr address, size_t size); | 78 | ResultCode UnmapMemory(VAddr address, u64 size); |
| 70 | 79 | ||
| 71 | private: | 80 | private: |
| 72 | explicit TransferMemory(KernelCore& kernel); | 81 | explicit TransferMemory(KernelCore& kernel); |
| 73 | ~TransferMemory() override; | 82 | ~TransferMemory() override; |
| 74 | 83 | ||
| 84 | /// Memory block backing this instance. | ||
| 85 | std::shared_ptr<std::vector<u8>> backing_block; | ||
| 86 | |||
| 75 | /// The base address for the memory managed by this instance. | 87 | /// The base address for the memory managed by this instance. |
| 76 | VAddr base_address = 0; | 88 | VAddr base_address = 0; |
| 77 | 89 | ||
| 78 | /// Size of the memory, in bytes, that this instance manages. | 90 | /// Size of the memory, in bytes, that this instance manages. |
| 79 | size_t memory_size = 0; | 91 | u64 memory_size = 0; |
| 80 | 92 | ||
| 81 | /// The memory permissions that are applied to this instance. | 93 | /// The memory permissions that are applied to this instance. |
| 82 | MemoryPermission owner_permissions{}; | 94 | MemoryPermission owner_permissions{}; |
diff --git a/src/core/hle/kernel/vm_manager.cpp b/src/core/hle/kernel/vm_manager.cpp index 22bf55ce7..ec0a480ce 100644 --- a/src/core/hle/kernel/vm_manager.cpp +++ b/src/core/hle/kernel/vm_manager.cpp | |||
| @@ -256,57 +256,50 @@ ResultCode VMManager::ReprotectRange(VAddr target, u64 size, VMAPermission new_p | |||
| 256 | return RESULT_SUCCESS; | 256 | return RESULT_SUCCESS; |
| 257 | } | 257 | } |
| 258 | 258 | ||
| 259 | ResultVal<VAddr> VMManager::HeapAllocate(VAddr target, u64 size, VMAPermission perms) { | 259 | ResultVal<VAddr> VMManager::SetHeapSize(u64 size) { |
| 260 | if (!IsWithinHeapRegion(target, size)) { | 260 | if (size > GetHeapRegionSize()) { |
| 261 | return ERR_INVALID_ADDRESS; | 261 | return ERR_OUT_OF_MEMORY; |
| 262 | } | ||
| 263 | |||
| 264 | // No need to do any additional work if the heap is already the given size. | ||
| 265 | if (size == GetCurrentHeapSize()) { | ||
| 266 | return MakeResult(heap_region_base); | ||
| 262 | } | 267 | } |
| 263 | 268 | ||
| 264 | if (heap_memory == nullptr) { | 269 | if (heap_memory == nullptr) { |
| 265 | // Initialize heap | 270 | // Initialize heap |
| 266 | heap_memory = std::make_shared<std::vector<u8>>(); | 271 | heap_memory = std::make_shared<std::vector<u8>>(size); |
| 267 | heap_start = heap_end = target; | 272 | heap_end = heap_region_base + size; |
| 268 | } else { | 273 | } else { |
| 269 | UnmapRange(heap_start, heap_end - heap_start); | 274 | UnmapRange(heap_region_base, GetCurrentHeapSize()); |
| 270 | } | ||
| 271 | |||
| 272 | // If necessary, expand backing vector to cover new heap extents. | ||
| 273 | if (target < heap_start) { | ||
| 274 | heap_memory->insert(begin(*heap_memory), heap_start - target, 0); | ||
| 275 | heap_start = target; | ||
| 276 | RefreshMemoryBlockMappings(heap_memory.get()); | ||
| 277 | } | ||
| 278 | if (target + size > heap_end) { | ||
| 279 | heap_memory->insert(end(*heap_memory), (target + size) - heap_end, 0); | ||
| 280 | heap_end = target + size; | ||
| 281 | RefreshMemoryBlockMappings(heap_memory.get()); | ||
| 282 | } | 275 | } |
| 283 | ASSERT(heap_end - heap_start == heap_memory->size()); | ||
| 284 | 276 | ||
| 285 | CASCADE_RESULT(auto vma, MapMemoryBlock(target, heap_memory, target - heap_start, size, | 277 | // If necessary, expand backing vector to cover new heap extents in |
| 286 | MemoryState::Heap)); | 278 | // the case of allocating. Otherwise, shrink the backing memory, |
| 287 | Reprotect(vma, perms); | 279 | // if a smaller heap has been requested. |
| 280 | const u64 old_heap_size = GetCurrentHeapSize(); | ||
| 281 | if (size > old_heap_size) { | ||
| 282 | const u64 alloc_size = size - old_heap_size; | ||
| 288 | 283 | ||
| 289 | heap_used = size; | 284 | heap_memory->insert(heap_memory->end(), alloc_size, 0); |
| 290 | 285 | RefreshMemoryBlockMappings(heap_memory.get()); | |
| 291 | return MakeResult<VAddr>(heap_end - size); | 286 | } else if (size < old_heap_size) { |
| 292 | } | 287 | heap_memory->resize(size); |
| 288 | heap_memory->shrink_to_fit(); | ||
| 293 | 289 | ||
| 294 | ResultCode VMManager::HeapFree(VAddr target, u64 size) { | 290 | RefreshMemoryBlockMappings(heap_memory.get()); |
| 295 | if (!IsWithinHeapRegion(target, size)) { | ||
| 296 | return ERR_INVALID_ADDRESS; | ||
| 297 | } | 291 | } |
| 298 | 292 | ||
| 299 | if (size == 0) { | 293 | heap_end = heap_region_base + size; |
| 300 | return RESULT_SUCCESS; | 294 | ASSERT(GetCurrentHeapSize() == heap_memory->size()); |
| 301 | } | ||
| 302 | 295 | ||
| 303 | const ResultCode result = UnmapRange(target, size); | 296 | const auto mapping_result = |
| 304 | if (result.IsError()) { | 297 | MapMemoryBlock(heap_region_base, heap_memory, 0, size, MemoryState::Heap); |
| 305 | return result; | 298 | if (mapping_result.Failed()) { |
| 299 | return mapping_result.Code(); | ||
| 306 | } | 300 | } |
| 307 | 301 | ||
| 308 | heap_used -= size; | 302 | return MakeResult<VAddr>(heap_region_base); |
| 309 | return RESULT_SUCCESS; | ||
| 310 | } | 303 | } |
| 311 | 304 | ||
| 312 | MemoryInfo VMManager::QueryMemory(VAddr address) const { | 305 | MemoryInfo VMManager::QueryMemory(VAddr address) const { |
| @@ -598,6 +591,7 @@ void VMManager::InitializeMemoryRegionRanges(FileSys::ProgramAddressSpaceType ty | |||
| 598 | 591 | ||
| 599 | heap_region_base = map_region_end; | 592 | heap_region_base = map_region_end; |
| 600 | heap_region_end = heap_region_base + heap_region_size; | 593 | heap_region_end = heap_region_base + heap_region_size; |
| 594 | heap_end = heap_region_base; | ||
| 601 | 595 | ||
| 602 | new_map_region_base = heap_region_end; | 596 | new_map_region_base = heap_region_end; |
| 603 | new_map_region_end = new_map_region_base + new_map_region_size; | 597 | new_map_region_end = new_map_region_base + new_map_region_size; |
| @@ -692,10 +686,6 @@ u64 VMManager::GetTotalMemoryUsage() const { | |||
| 692 | return 0xF8000000; | 686 | return 0xF8000000; |
| 693 | } | 687 | } |
| 694 | 688 | ||
| 695 | u64 VMManager::GetTotalHeapUsage() const { | ||
| 696 | return heap_used; | ||
| 697 | } | ||
| 698 | |||
| 699 | VAddr VMManager::GetAddressSpaceBaseAddress() const { | 689 | VAddr VMManager::GetAddressSpaceBaseAddress() const { |
| 700 | return address_space_base; | 690 | return address_space_base; |
| 701 | } | 691 | } |
| @@ -778,6 +768,10 @@ u64 VMManager::GetHeapRegionSize() const { | |||
| 778 | return heap_region_end - heap_region_base; | 768 | return heap_region_end - heap_region_base; |
| 779 | } | 769 | } |
| 780 | 770 | ||
| 771 | u64 VMManager::GetCurrentHeapSize() const { | ||
| 772 | return heap_end - heap_region_base; | ||
| 773 | } | ||
| 774 | |||
| 781 | bool VMManager::IsWithinHeapRegion(VAddr address, u64 size) const { | 775 | bool VMManager::IsWithinHeapRegion(VAddr address, u64 size) const { |
| 782 | return IsInsideAddressRange(address, size, GetHeapRegionBaseAddress(), | 776 | return IsInsideAddressRange(address, size, GetHeapRegionBaseAddress(), |
| 783 | GetHeapRegionEndAddress()); | 777 | GetHeapRegionEndAddress()); |
diff --git a/src/core/hle/kernel/vm_manager.h b/src/core/hle/kernel/vm_manager.h index 7cdff6094..6f484b7bf 100644 --- a/src/core/hle/kernel/vm_manager.h +++ b/src/core/hle/kernel/vm_manager.h | |||
| @@ -380,11 +380,41 @@ public: | |||
| 380 | /// Changes the permissions of a range of addresses, splitting VMAs as necessary. | 380 | /// Changes the permissions of a range of addresses, splitting VMAs as necessary. |
| 381 | ResultCode ReprotectRange(VAddr target, u64 size, VMAPermission new_perms); | 381 | ResultCode ReprotectRange(VAddr target, u64 size, VMAPermission new_perms); |
| 382 | 382 | ||
| 383 | ResultVal<VAddr> HeapAllocate(VAddr target, u64 size, VMAPermission perms); | ||
| 384 | ResultCode HeapFree(VAddr target, u64 size); | ||
| 385 | |||
| 386 | ResultCode MirrorMemory(VAddr dst_addr, VAddr src_addr, u64 size, MemoryState state); | 383 | ResultCode MirrorMemory(VAddr dst_addr, VAddr src_addr, u64 size, MemoryState state); |
| 387 | 384 | ||
| 385 | /// Attempts to allocate a heap with the given size. | ||
| 386 | /// | ||
| 387 | /// @param size The size of the heap to allocate in bytes. | ||
| 388 | /// | ||
| 389 | /// @note If a heap is currently allocated, and this is called | ||
| 390 | /// with a size that is equal to the size of the current heap, | ||
| 391 | /// then this function will do nothing and return the current | ||
| 392 | /// heap's starting address, as there's no need to perform | ||
| 393 | /// any additional heap allocation work. | ||
| 394 | /// | ||
| 395 | /// @note If a heap is currently allocated, and this is called | ||
| 396 | /// with a size less than the current heap's size, then | ||
| 397 | /// this function will attempt to shrink the heap. | ||
| 398 | /// | ||
| 399 | /// @note If a heap is currently allocated, and this is called | ||
| 400 | /// with a size larger than the current heap's size, then | ||
| 401 | /// this function will attempt to extend the size of the heap. | ||
| 402 | /// | ||
| 403 | /// @returns A result indicating either success or failure. | ||
| 404 | /// <p> | ||
| 405 | /// If successful, this function will return a result | ||
| 406 | /// containing the starting address to the allocated heap. | ||
| 407 | /// <p> | ||
| 408 | /// If unsuccessful, this function will return a result | ||
| 409 | /// containing an error code. | ||
| 410 | /// | ||
| 411 | /// @pre The given size must lie within the allowable heap | ||
| 412 | /// memory region managed by this VMManager instance. | ||
| 413 | /// Failure to abide by this will result in ERR_OUT_OF_MEMORY | ||
| 414 | /// being returned as the result. | ||
| 415 | /// | ||
| 416 | ResultVal<VAddr> SetHeapSize(u64 size); | ||
| 417 | |||
| 388 | /// Queries the memory manager for information about the given address. | 418 | /// Queries the memory manager for information about the given address. |
| 389 | /// | 419 | /// |
| 390 | /// @param address The address to query the memory manager about for information. | 420 | /// @param address The address to query the memory manager about for information. |
| @@ -418,9 +448,6 @@ public: | |||
| 418 | /// Gets the total memory usage, used by svcGetInfo | 448 | /// Gets the total memory usage, used by svcGetInfo |
| 419 | u64 GetTotalMemoryUsage() const; | 449 | u64 GetTotalMemoryUsage() const; |
| 420 | 450 | ||
| 421 | /// Gets the total heap usage, used by svcGetInfo | ||
| 422 | u64 GetTotalHeapUsage() const; | ||
| 423 | |||
| 424 | /// Gets the address space base address | 451 | /// Gets the address space base address |
| 425 | VAddr GetAddressSpaceBaseAddress() const; | 452 | VAddr GetAddressSpaceBaseAddress() const; |
| 426 | 453 | ||
| @@ -469,6 +496,13 @@ public: | |||
| 469 | /// Gets the total size of the heap region in bytes. | 496 | /// Gets the total size of the heap region in bytes. |
| 470 | u64 GetHeapRegionSize() const; | 497 | u64 GetHeapRegionSize() const; |
| 471 | 498 | ||
| 499 | /// Gets the total size of the current heap in bytes. | ||
| 500 | /// | ||
| 501 | /// @note This is the current allocated heap size, not the size | ||
| 502 | /// of the region it's allowed to exist within. | ||
| 503 | /// | ||
| 504 | u64 GetCurrentHeapSize() const; | ||
| 505 | |||
| 472 | /// Determines whether or not the specified range is within the heap region. | 506 | /// Determines whether or not the specified range is within the heap region. |
| 473 | bool IsWithinHeapRegion(VAddr address, u64 size) const; | 507 | bool IsWithinHeapRegion(VAddr address, u64 size) const; |
| 474 | 508 | ||
| @@ -617,9 +651,6 @@ private: | |||
| 617 | VAddr new_map_region_base = 0; | 651 | VAddr new_map_region_base = 0; |
| 618 | VAddr new_map_region_end = 0; | 652 | VAddr new_map_region_end = 0; |
| 619 | 653 | ||
| 620 | VAddr main_code_region_base = 0; | ||
| 621 | VAddr main_code_region_end = 0; | ||
| 622 | |||
| 623 | VAddr tls_io_region_base = 0; | 654 | VAddr tls_io_region_base = 0; |
| 624 | VAddr tls_io_region_end = 0; | 655 | VAddr tls_io_region_end = 0; |
| 625 | 656 | ||
| @@ -628,9 +659,9 @@ private: | |||
| 628 | // This makes deallocation and reallocation of holes fast and keeps process memory contiguous | 659 | // This makes deallocation and reallocation of holes fast and keeps process memory contiguous |
| 629 | // in the emulator address space, allowing Memory::GetPointer to be reasonably safe. | 660 | // in the emulator address space, allowing Memory::GetPointer to be reasonably safe. |
| 630 | std::shared_ptr<std::vector<u8>> heap_memory; | 661 | std::shared_ptr<std::vector<u8>> heap_memory; |
| 631 | // The left/right bounds of the address space covered by heap_memory. | 662 | |
| 632 | VAddr heap_start = 0; | 663 | // The end of the currently allocated heap. This is not an inclusive |
| 664 | // end of the range. This is essentially 'base_address + current_size'. | ||
| 633 | VAddr heap_end = 0; | 665 | VAddr heap_end = 0; |
| 634 | u64 heap_used = 0; | ||
| 635 | }; | 666 | }; |
| 636 | } // namespace Kernel | 667 | } // namespace Kernel |
diff --git a/src/core/hle/kernel/wait_object.h b/src/core/hle/kernel/wait_object.h index 5987fb971..04464a51a 100644 --- a/src/core/hle/kernel/wait_object.h +++ b/src/core/hle/kernel/wait_object.h | |||
| @@ -24,7 +24,7 @@ public: | |||
| 24 | * @param thread The thread about which we're deciding. | 24 | * @param thread The thread about which we're deciding. |
| 25 | * @return True if the current thread should wait due to this object being unavailable | 25 | * @return True if the current thread should wait due to this object being unavailable |
| 26 | */ | 26 | */ |
| 27 | virtual bool ShouldWait(Thread* thread) const = 0; | 27 | virtual bool ShouldWait(const Thread* thread) const = 0; |
| 28 | 28 | ||
| 29 | /// Acquire/lock the object for the specified thread if it is available | 29 | /// Acquire/lock the object for the specified thread if it is available |
| 30 | virtual void Acquire(Thread* thread) = 0; | 30 | virtual void Acquire(Thread* thread) = 0; |
diff --git a/src/core/hle/result.h b/src/core/hle/result.h index ab84f5ddc..8a3701151 100644 --- a/src/core/hle/result.h +++ b/src/core/hle/result.h | |||
| @@ -119,10 +119,6 @@ union ResultCode { | |||
| 119 | BitField<0, 9, ErrorModule> module; | 119 | BitField<0, 9, ErrorModule> module; |
| 120 | BitField<9, 13, u32> description; | 120 | BitField<9, 13, u32> description; |
| 121 | 121 | ||
| 122 | // The last bit of `level` is checked by apps and the kernel to determine if a result code is an | ||
| 123 | // error | ||
| 124 | BitField<31, 1, u32> is_error; | ||
| 125 | |||
| 126 | constexpr explicit ResultCode(u32 raw) : raw(raw) {} | 122 | constexpr explicit ResultCode(u32 raw) : raw(raw) {} |
| 127 | 123 | ||
| 128 | constexpr ResultCode(ErrorModule module_, u32 description_) | 124 | constexpr ResultCode(ErrorModule module_, u32 description_) |
diff --git a/src/core/hle/service/am/am.cpp b/src/core/hle/service/am/am.cpp index 9c44e27c6..85271d418 100644 --- a/src/core/hle/service/am/am.cpp +++ b/src/core/hle/service/am/am.cpp | |||
| @@ -13,7 +13,7 @@ | |||
| 13 | #include "core/hle/kernel/kernel.h" | 13 | #include "core/hle/kernel/kernel.h" |
| 14 | #include "core/hle/kernel/process.h" | 14 | #include "core/hle/kernel/process.h" |
| 15 | #include "core/hle/kernel/readable_event.h" | 15 | #include "core/hle/kernel/readable_event.h" |
| 16 | #include "core/hle/kernel/shared_memory.h" | 16 | #include "core/hle/kernel/transfer_memory.h" |
| 17 | #include "core/hle/kernel/writable_event.h" | 17 | #include "core/hle/kernel/writable_event.h" |
| 18 | #include "core/hle/service/acc/profile_manager.h" | 18 | #include "core/hle/service/acc/profile_manager.h" |
| 19 | #include "core/hle/service/am/am.h" | 19 | #include "core/hle/service/am/am.h" |
| @@ -239,8 +239,8 @@ ISelfController::ISelfController(std::shared_ptr<NVFlinger::NVFlinger> nvflinger | |||
| 239 | {0, nullptr, "Exit"}, | 239 | {0, nullptr, "Exit"}, |
| 240 | {1, &ISelfController::LockExit, "LockExit"}, | 240 | {1, &ISelfController::LockExit, "LockExit"}, |
| 241 | {2, &ISelfController::UnlockExit, "UnlockExit"}, | 241 | {2, &ISelfController::UnlockExit, "UnlockExit"}, |
| 242 | {3, nullptr, "EnterFatalSection"}, | 242 | {3, &ISelfController::EnterFatalSection, "EnterFatalSection"}, |
| 243 | {4, nullptr, "LeaveFatalSection"}, | 243 | {4, &ISelfController::LeaveFatalSection, "LeaveFatalSection"}, |
| 244 | {9, &ISelfController::GetLibraryAppletLaunchableEvent, "GetLibraryAppletLaunchableEvent"}, | 244 | {9, &ISelfController::GetLibraryAppletLaunchableEvent, "GetLibraryAppletLaunchableEvent"}, |
| 245 | {10, &ISelfController::SetScreenShotPermission, "SetScreenShotPermission"}, | 245 | {10, &ISelfController::SetScreenShotPermission, "SetScreenShotPermission"}, |
| 246 | {11, &ISelfController::SetOperationModeChangedNotification, "SetOperationModeChangedNotification"}, | 246 | {11, &ISelfController::SetOperationModeChangedNotification, "SetOperationModeChangedNotification"}, |
| @@ -285,41 +285,54 @@ ISelfController::ISelfController(std::shared_ptr<NVFlinger::NVFlinger> nvflinger | |||
| 285 | 285 | ||
| 286 | ISelfController::~ISelfController() = default; | 286 | ISelfController::~ISelfController() = default; |
| 287 | 287 | ||
| 288 | void ISelfController::SetFocusHandlingMode(Kernel::HLERequestContext& ctx) { | 288 | void ISelfController::LockExit(Kernel::HLERequestContext& ctx) { |
| 289 | // Takes 3 input u8s with each field located immediately after the previous | ||
| 290 | // u8, these are bool flags. No output. | ||
| 291 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 289 | LOG_WARNING(Service_AM, "(STUBBED) called"); |
| 292 | 290 | ||
| 293 | IPC::RequestParser rp{ctx}; | 291 | IPC::ResponseBuilder rb{ctx, 2}; |
| 292 | rb.Push(RESULT_SUCCESS); | ||
| 293 | } | ||
| 294 | 294 | ||
| 295 | struct FocusHandlingModeParams { | 295 | void ISelfController::UnlockExit(Kernel::HLERequestContext& ctx) { |
| 296 | u8 unknown0; | 296 | LOG_WARNING(Service_AM, "(STUBBED) called"); |
| 297 | u8 unknown1; | ||
| 298 | u8 unknown2; | ||
| 299 | }; | ||
| 300 | auto flags = rp.PopRaw<FocusHandlingModeParams>(); | ||
| 301 | 297 | ||
| 302 | IPC::ResponseBuilder rb{ctx, 2}; | 298 | IPC::ResponseBuilder rb{ctx, 2}; |
| 303 | rb.Push(RESULT_SUCCESS); | 299 | rb.Push(RESULT_SUCCESS); |
| 304 | } | 300 | } |
| 305 | 301 | ||
| 306 | void ISelfController::SetRestartMessageEnabled(Kernel::HLERequestContext& ctx) { | 302 | void ISelfController::EnterFatalSection(Kernel::HLERequestContext& ctx) { |
| 307 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 303 | ++num_fatal_sections_entered; |
| 304 | LOG_DEBUG(Service_AM, "called. Num fatal sections entered: {}", num_fatal_sections_entered); | ||
| 308 | 305 | ||
| 309 | IPC::ResponseBuilder rb{ctx, 2}; | 306 | IPC::ResponseBuilder rb{ctx, 2}; |
| 310 | rb.Push(RESULT_SUCCESS); | 307 | rb.Push(RESULT_SUCCESS); |
| 311 | } | 308 | } |
| 312 | 309 | ||
| 313 | void ISelfController::SetPerformanceModeChangedNotification(Kernel::HLERequestContext& ctx) { | 310 | void ISelfController::LeaveFatalSection(Kernel::HLERequestContext& ctx) { |
| 314 | IPC::RequestParser rp{ctx}; | 311 | LOG_DEBUG(Service_AM, "called."); |
| 315 | 312 | ||
| 316 | bool flag = rp.Pop<bool>(); | 313 | // Entry and exit of fatal sections must be balanced. |
| 317 | LOG_WARNING(Service_AM, "(STUBBED) called flag={}", flag); | 314 | if (num_fatal_sections_entered == 0) { |
| 315 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 316 | rb.Push(ResultCode{ErrorModule::AM, 512}); | ||
| 317 | return; | ||
| 318 | } | ||
| 319 | |||
| 320 | --num_fatal_sections_entered; | ||
| 318 | 321 | ||
| 319 | IPC::ResponseBuilder rb{ctx, 2}; | 322 | IPC::ResponseBuilder rb{ctx, 2}; |
| 320 | rb.Push(RESULT_SUCCESS); | 323 | rb.Push(RESULT_SUCCESS); |
| 321 | } | 324 | } |
| 322 | 325 | ||
| 326 | void ISelfController::GetLibraryAppletLaunchableEvent(Kernel::HLERequestContext& ctx) { | ||
| 327 | LOG_WARNING(Service_AM, "(STUBBED) called"); | ||
| 328 | |||
| 329 | launchable_event.writable->Signal(); | ||
| 330 | |||
| 331 | IPC::ResponseBuilder rb{ctx, 2, 1}; | ||
| 332 | rb.Push(RESULT_SUCCESS); | ||
| 333 | rb.PushCopyObjects(launchable_event.readable); | ||
| 334 | } | ||
| 335 | |||
| 323 | void ISelfController::SetScreenShotPermission(Kernel::HLERequestContext& ctx) { | 336 | void ISelfController::SetScreenShotPermission(Kernel::HLERequestContext& ctx) { |
| 324 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 337 | LOG_WARNING(Service_AM, "(STUBBED) called"); |
| 325 | 338 | ||
| @@ -337,40 +350,52 @@ void ISelfController::SetOperationModeChangedNotification(Kernel::HLERequestCont | |||
| 337 | rb.Push(RESULT_SUCCESS); | 350 | rb.Push(RESULT_SUCCESS); |
| 338 | } | 351 | } |
| 339 | 352 | ||
| 340 | void ISelfController::SetOutOfFocusSuspendingEnabled(Kernel::HLERequestContext& ctx) { | 353 | void ISelfController::SetPerformanceModeChangedNotification(Kernel::HLERequestContext& ctx) { |
| 341 | // Takes 3 input u8s with each field located immediately after the previous | ||
| 342 | // u8, these are bool flags. No output. | ||
| 343 | IPC::RequestParser rp{ctx}; | 354 | IPC::RequestParser rp{ctx}; |
| 344 | 355 | ||
| 345 | bool enabled = rp.Pop<bool>(); | 356 | bool flag = rp.Pop<bool>(); |
| 346 | LOG_WARNING(Service_AM, "(STUBBED) called enabled={}", enabled); | 357 | LOG_WARNING(Service_AM, "(STUBBED) called flag={}", flag); |
| 347 | 358 | ||
| 348 | IPC::ResponseBuilder rb{ctx, 2}; | 359 | IPC::ResponseBuilder rb{ctx, 2}; |
| 349 | rb.Push(RESULT_SUCCESS); | 360 | rb.Push(RESULT_SUCCESS); |
| 350 | } | 361 | } |
| 351 | 362 | ||
| 352 | void ISelfController::LockExit(Kernel::HLERequestContext& ctx) { | 363 | void ISelfController::SetFocusHandlingMode(Kernel::HLERequestContext& ctx) { |
| 353 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 364 | // Takes 3 input u8s with each field located immediately after the previous |
| 365 | // u8, these are bool flags. No output. | ||
| 366 | IPC::RequestParser rp{ctx}; | ||
| 367 | |||
| 368 | struct FocusHandlingModeParams { | ||
| 369 | u8 unknown0; | ||
| 370 | u8 unknown1; | ||
| 371 | u8 unknown2; | ||
| 372 | }; | ||
| 373 | const auto flags = rp.PopRaw<FocusHandlingModeParams>(); | ||
| 374 | |||
| 375 | LOG_WARNING(Service_AM, "(STUBBED) called. unknown0={}, unknown1={}, unknown2={}", | ||
| 376 | flags.unknown0, flags.unknown1, flags.unknown2); | ||
| 354 | 377 | ||
| 355 | IPC::ResponseBuilder rb{ctx, 2}; | 378 | IPC::ResponseBuilder rb{ctx, 2}; |
| 356 | rb.Push(RESULT_SUCCESS); | 379 | rb.Push(RESULT_SUCCESS); |
| 357 | } | 380 | } |
| 358 | 381 | ||
| 359 | void ISelfController::UnlockExit(Kernel::HLERequestContext& ctx) { | 382 | void ISelfController::SetRestartMessageEnabled(Kernel::HLERequestContext& ctx) { |
| 360 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 383 | LOG_WARNING(Service_AM, "(STUBBED) called"); |
| 361 | 384 | ||
| 362 | IPC::ResponseBuilder rb{ctx, 2}; | 385 | IPC::ResponseBuilder rb{ctx, 2}; |
| 363 | rb.Push(RESULT_SUCCESS); | 386 | rb.Push(RESULT_SUCCESS); |
| 364 | } | 387 | } |
| 365 | 388 | ||
| 366 | void ISelfController::GetLibraryAppletLaunchableEvent(Kernel::HLERequestContext& ctx) { | 389 | void ISelfController::SetOutOfFocusSuspendingEnabled(Kernel::HLERequestContext& ctx) { |
| 367 | LOG_WARNING(Service_AM, "(STUBBED) called"); | 390 | // Takes 3 input u8s with each field located immediately after the previous |
| 391 | // u8, these are bool flags. No output. | ||
| 392 | IPC::RequestParser rp{ctx}; | ||
| 368 | 393 | ||
| 369 | launchable_event.writable->Signal(); | 394 | bool enabled = rp.Pop<bool>(); |
| 395 | LOG_WARNING(Service_AM, "(STUBBED) called enabled={}", enabled); | ||
| 370 | 396 | ||
| 371 | IPC::ResponseBuilder rb{ctx, 2, 1}; | 397 | IPC::ResponseBuilder rb{ctx, 2}; |
| 372 | rb.Push(RESULT_SUCCESS); | 398 | rb.Push(RESULT_SUCCESS); |
| 373 | rb.PushCopyObjects(launchable_event.readable); | ||
| 374 | } | 399 | } |
| 375 | 400 | ||
| 376 | void ISelfController::SetScreenShotImageOrientation(Kernel::HLERequestContext& ctx) { | 401 | void ISelfController::SetScreenShotImageOrientation(Kernel::HLERequestContext& ctx) { |
| @@ -907,19 +932,19 @@ void ILibraryAppletCreator::CreateTransferMemoryStorage(Kernel::HLERequestContex | |||
| 907 | rp.SetCurrentOffset(3); | 932 | rp.SetCurrentOffset(3); |
| 908 | const auto handle{rp.Pop<Kernel::Handle>()}; | 933 | const auto handle{rp.Pop<Kernel::Handle>()}; |
| 909 | 934 | ||
| 910 | const auto shared_mem = | 935 | const auto transfer_mem = |
| 911 | Core::System::GetInstance().CurrentProcess()->GetHandleTable().Get<Kernel::SharedMemory>( | 936 | Core::System::GetInstance().CurrentProcess()->GetHandleTable().Get<Kernel::TransferMemory>( |
| 912 | handle); | 937 | handle); |
| 913 | 938 | ||
| 914 | if (shared_mem == nullptr) { | 939 | if (transfer_mem == nullptr) { |
| 915 | LOG_ERROR(Service_AM, "shared_mem is a nullpr for handle={:08X}", handle); | 940 | LOG_ERROR(Service_AM, "shared_mem is a nullpr for handle={:08X}", handle); |
| 916 | IPC::ResponseBuilder rb{ctx, 2}; | 941 | IPC::ResponseBuilder rb{ctx, 2}; |
| 917 | rb.Push(ResultCode(-1)); | 942 | rb.Push(ResultCode(-1)); |
| 918 | return; | 943 | return; |
| 919 | } | 944 | } |
| 920 | 945 | ||
| 921 | const u8* mem_begin = shared_mem->GetPointer(); | 946 | const u8* const mem_begin = transfer_mem->GetPointer(); |
| 922 | const u8* mem_end = mem_begin + shared_mem->GetSize(); | 947 | const u8* const mem_end = mem_begin + transfer_mem->GetSize(); |
| 923 | std::vector<u8> memory{mem_begin, mem_end}; | 948 | std::vector<u8> memory{mem_begin, mem_end}; |
| 924 | 949 | ||
| 925 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | 950 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; |
diff --git a/src/core/hle/service/am/am.h b/src/core/hle/service/am/am.h index 565dd8e9e..991b7d47c 100644 --- a/src/core/hle/service/am/am.h +++ b/src/core/hle/service/am/am.h | |||
| @@ -117,17 +117,19 @@ public: | |||
| 117 | ~ISelfController() override; | 117 | ~ISelfController() override; |
| 118 | 118 | ||
| 119 | private: | 119 | private: |
| 120 | void SetFocusHandlingMode(Kernel::HLERequestContext& ctx); | ||
| 121 | void SetRestartMessageEnabled(Kernel::HLERequestContext& ctx); | ||
| 122 | void SetPerformanceModeChangedNotification(Kernel::HLERequestContext& ctx); | ||
| 123 | void SetOperationModeChangedNotification(Kernel::HLERequestContext& ctx); | ||
| 124 | void SetOutOfFocusSuspendingEnabled(Kernel::HLERequestContext& ctx); | ||
| 125 | void LockExit(Kernel::HLERequestContext& ctx); | 120 | void LockExit(Kernel::HLERequestContext& ctx); |
| 126 | void UnlockExit(Kernel::HLERequestContext& ctx); | 121 | void UnlockExit(Kernel::HLERequestContext& ctx); |
| 122 | void EnterFatalSection(Kernel::HLERequestContext& ctx); | ||
| 123 | void LeaveFatalSection(Kernel::HLERequestContext& ctx); | ||
| 127 | void GetLibraryAppletLaunchableEvent(Kernel::HLERequestContext& ctx); | 124 | void GetLibraryAppletLaunchableEvent(Kernel::HLERequestContext& ctx); |
| 125 | void SetScreenShotPermission(Kernel::HLERequestContext& ctx); | ||
| 126 | void SetOperationModeChangedNotification(Kernel::HLERequestContext& ctx); | ||
| 127 | void SetPerformanceModeChangedNotification(Kernel::HLERequestContext& ctx); | ||
| 128 | void SetFocusHandlingMode(Kernel::HLERequestContext& ctx); | ||
| 129 | void SetRestartMessageEnabled(Kernel::HLERequestContext& ctx); | ||
| 130 | void SetOutOfFocusSuspendingEnabled(Kernel::HLERequestContext& ctx); | ||
| 128 | void SetScreenShotImageOrientation(Kernel::HLERequestContext& ctx); | 131 | void SetScreenShotImageOrientation(Kernel::HLERequestContext& ctx); |
| 129 | void CreateManagedDisplayLayer(Kernel::HLERequestContext& ctx); | 132 | void CreateManagedDisplayLayer(Kernel::HLERequestContext& ctx); |
| 130 | void SetScreenShotPermission(Kernel::HLERequestContext& ctx); | ||
| 131 | void SetHandlesRequestToDisplay(Kernel::HLERequestContext& ctx); | 133 | void SetHandlesRequestToDisplay(Kernel::HLERequestContext& ctx); |
| 132 | void SetIdleTimeDetectionExtension(Kernel::HLERequestContext& ctx); | 134 | void SetIdleTimeDetectionExtension(Kernel::HLERequestContext& ctx); |
| 133 | void GetIdleTimeDetectionExtension(Kernel::HLERequestContext& ctx); | 135 | void GetIdleTimeDetectionExtension(Kernel::HLERequestContext& ctx); |
| @@ -135,6 +137,7 @@ private: | |||
| 135 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; | 137 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; |
| 136 | Kernel::EventPair launchable_event; | 138 | Kernel::EventPair launchable_event; |
| 137 | u32 idle_time_detection_extension = 0; | 139 | u32 idle_time_detection_extension = 0; |
| 140 | u64 num_fatal_sections_entered = 0; | ||
| 138 | }; | 141 | }; |
| 139 | 142 | ||
| 140 | class ICommonStateGetter final : public ServiceFramework<ICommonStateGetter> { | 143 | class ICommonStateGetter final : public ServiceFramework<ICommonStateGetter> { |
diff --git a/src/core/hle/service/audio/audin_u.cpp b/src/core/hle/service/audio/audin_u.cpp index 088410564..e5daefdde 100644 --- a/src/core/hle/service/audio/audin_u.cpp +++ b/src/core/hle/service/audio/audin_u.cpp | |||
| @@ -2,9 +2,6 @@ | |||
| 2 | // Licensed under GPLv2 or any later version | 2 | // Licensed under GPLv2 or any later version |
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include "common/logging/log.h" | ||
| 6 | #include "core/hle/ipc_helpers.h" | ||
| 7 | #include "core/hle/kernel/hle_ipc.h" | ||
| 8 | #include "core/hle/service/audio/audin_u.h" | 5 | #include "core/hle/service/audio/audin_u.h" |
| 9 | 6 | ||
| 10 | namespace Service::Audio { | 7 | namespace Service::Audio { |
| @@ -33,7 +30,6 @@ public: | |||
| 33 | 30 | ||
| 34 | RegisterHandlers(functions); | 31 | RegisterHandlers(functions); |
| 35 | } | 32 | } |
| 36 | ~IAudioIn() = default; | ||
| 37 | }; | 33 | }; |
| 38 | 34 | ||
| 39 | AudInU::AudInU() : ServiceFramework("audin:u") { | 35 | AudInU::AudInU() : ServiceFramework("audin:u") { |
diff --git a/src/core/hle/service/audio/audout_u.cpp b/src/core/hle/service/audio/audout_u.cpp index 21f5e64c7..39acb7b23 100644 --- a/src/core/hle/service/audio/audout_u.cpp +++ b/src/core/hle/service/audio/audout_u.cpp | |||
| @@ -150,7 +150,6 @@ private: | |||
| 150 | void GetReleasedAudioOutBufferImpl(Kernel::HLERequestContext& ctx) { | 150 | void GetReleasedAudioOutBufferImpl(Kernel::HLERequestContext& ctx) { |
| 151 | LOG_DEBUG(Service_Audio, "called {}", ctx.Description()); | 151 | LOG_DEBUG(Service_Audio, "called {}", ctx.Description()); |
| 152 | 152 | ||
| 153 | IPC::RequestParser rp{ctx}; | ||
| 154 | const u64 max_count{ctx.GetWriteBufferSize() / sizeof(u64)}; | 153 | const u64 max_count{ctx.GetWriteBufferSize() / sizeof(u64)}; |
| 155 | const auto released_buffers{audio_core.GetTagsAndReleaseBuffers(stream, max_count)}; | 154 | const auto released_buffers{audio_core.GetTagsAndReleaseBuffers(stream, max_count)}; |
| 156 | 155 | ||
| @@ -194,12 +193,9 @@ private: | |||
| 194 | void AudOutU::ListAudioOutsImpl(Kernel::HLERequestContext& ctx) { | 193 | void AudOutU::ListAudioOutsImpl(Kernel::HLERequestContext& ctx) { |
| 195 | LOG_DEBUG(Service_Audio, "called"); | 194 | LOG_DEBUG(Service_Audio, "called"); |
| 196 | 195 | ||
| 197 | IPC::RequestParser rp{ctx}; | ||
| 198 | |||
| 199 | ctx.WriteBuffer(DefaultDevice); | 196 | ctx.WriteBuffer(DefaultDevice); |
| 200 | 197 | ||
| 201 | IPC::ResponseBuilder rb{ctx, 3}; | 198 | IPC::ResponseBuilder rb{ctx, 3}; |
| 202 | |||
| 203 | rb.Push(RESULT_SUCCESS); | 199 | rb.Push(RESULT_SUCCESS); |
| 204 | rb.Push<u32>(1); // Amount of audio devices | 200 | rb.Push<u32>(1); // Amount of audio devices |
| 205 | } | 201 | } |
diff --git a/src/core/hle/service/audio/audrec_u.cpp b/src/core/hle/service/audio/audrec_u.cpp index 6956a2e64..1a5aed9ed 100644 --- a/src/core/hle/service/audio/audrec_u.cpp +++ b/src/core/hle/service/audio/audrec_u.cpp | |||
| @@ -2,9 +2,6 @@ | |||
| 2 | // Licensed under GPLv2 or any later version | 2 | // Licensed under GPLv2 or any later version |
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include "common/logging/log.h" | ||
| 6 | #include "core/hle/ipc_helpers.h" | ||
| 7 | #include "core/hle/kernel/hle_ipc.h" | ||
| 8 | #include "core/hle/service/audio/audrec_u.h" | 5 | #include "core/hle/service/audio/audrec_u.h" |
| 9 | 6 | ||
| 10 | namespace Service::Audio { | 7 | namespace Service::Audio { |
| @@ -30,7 +27,6 @@ public: | |||
| 30 | 27 | ||
| 31 | RegisterHandlers(functions); | 28 | RegisterHandlers(functions); |
| 32 | } | 29 | } |
| 33 | ~IFinalOutputRecorder() = default; | ||
| 34 | }; | 30 | }; |
| 35 | 31 | ||
| 36 | AudRecU::AudRecU() : ServiceFramework("audrec:u") { | 32 | AudRecU::AudRecU() : ServiceFramework("audrec:u") { |
diff --git a/src/core/hle/service/audio/audren_u.cpp b/src/core/hle/service/audio/audren_u.cpp index c9de10a24..1dde6edb7 100644 --- a/src/core/hle/service/audio/audren_u.cpp +++ b/src/core/hle/service/audio/audren_u.cpp | |||
| @@ -10,6 +10,7 @@ | |||
| 10 | #include "common/alignment.h" | 10 | #include "common/alignment.h" |
| 11 | #include "common/common_funcs.h" | 11 | #include "common/common_funcs.h" |
| 12 | #include "common/logging/log.h" | 12 | #include "common/logging/log.h" |
| 13 | #include "common/string_util.h" | ||
| 13 | #include "core/core.h" | 14 | #include "core/core.h" |
| 14 | #include "core/hle/ipc_helpers.h" | 15 | #include "core/hle/ipc_helpers.h" |
| 15 | #include "core/hle/kernel/hle_ipc.h" | 16 | #include "core/hle/kernel/hle_ipc.h" |
| @@ -184,7 +185,6 @@ public: | |||
| 184 | private: | 185 | private: |
| 185 | void ListAudioDeviceName(Kernel::HLERequestContext& ctx) { | 186 | void ListAudioDeviceName(Kernel::HLERequestContext& ctx) { |
| 186 | LOG_WARNING(Service_Audio, "(STUBBED) called"); | 187 | LOG_WARNING(Service_Audio, "(STUBBED) called"); |
| 187 | IPC::RequestParser rp{ctx}; | ||
| 188 | 188 | ||
| 189 | constexpr std::array<char, 15> audio_interface{{"AudioInterface"}}; | 189 | constexpr std::array<char, 15> audio_interface{{"AudioInterface"}}; |
| 190 | ctx.WriteBuffer(audio_interface); | 190 | ctx.WriteBuffer(audio_interface); |
| @@ -195,13 +195,13 @@ private: | |||
| 195 | } | 195 | } |
| 196 | 196 | ||
| 197 | void SetAudioDeviceOutputVolume(Kernel::HLERequestContext& ctx) { | 197 | void SetAudioDeviceOutputVolume(Kernel::HLERequestContext& ctx) { |
| 198 | LOG_WARNING(Service_Audio, "(STUBBED) called"); | ||
| 199 | |||
| 200 | IPC::RequestParser rp{ctx}; | 198 | IPC::RequestParser rp{ctx}; |
| 201 | f32 volume = static_cast<f32>(rp.Pop<u32>()); | 199 | const f32 volume = rp.Pop<f32>(); |
| 202 | 200 | ||
| 203 | auto file_buffer = ctx.ReadBuffer(); | 201 | const auto device_name_buffer = ctx.ReadBuffer(); |
| 204 | auto end = std::find(file_buffer.begin(), file_buffer.end(), '\0'); | 202 | const std::string name = Common::StringFromBuffer(device_name_buffer); |
| 203 | |||
| 204 | LOG_WARNING(Service_Audio, "(STUBBED) called. name={}, volume={}", name, volume); | ||
| 205 | 205 | ||
| 206 | IPC::ResponseBuilder rb{ctx, 2}; | 206 | IPC::ResponseBuilder rb{ctx, 2}; |
| 207 | rb.Push(RESULT_SUCCESS); | 207 | rb.Push(RESULT_SUCCESS); |
| @@ -209,7 +209,6 @@ private: | |||
| 209 | 209 | ||
| 210 | void GetActiveAudioDeviceName(Kernel::HLERequestContext& ctx) { | 210 | void GetActiveAudioDeviceName(Kernel::HLERequestContext& ctx) { |
| 211 | LOG_WARNING(Service_Audio, "(STUBBED) called"); | 211 | LOG_WARNING(Service_Audio, "(STUBBED) called"); |
| 212 | IPC::RequestParser rp{ctx}; | ||
| 213 | 212 | ||
| 214 | constexpr std::array<char, 12> audio_interface{{"AudioDevice"}}; | 213 | constexpr std::array<char, 12> audio_interface{{"AudioDevice"}}; |
| 215 | ctx.WriteBuffer(audio_interface); | 214 | ctx.WriteBuffer(audio_interface); |
diff --git a/src/core/hle/service/fatal/fatal.cpp b/src/core/hle/service/fatal/fatal.cpp index 770590d0b..2c229bcad 100644 --- a/src/core/hle/service/fatal/fatal.cpp +++ b/src/core/hle/service/fatal/fatal.cpp | |||
| @@ -25,21 +25,34 @@ Module::Interface::Interface(std::shared_ptr<Module> module, const char* name) | |||
| 25 | Module::Interface::~Interface() = default; | 25 | Module::Interface::~Interface() = default; |
| 26 | 26 | ||
| 27 | struct FatalInfo { | 27 | struct FatalInfo { |
| 28 | std::array<u64_le, 31> registers{}; // TODO(ogniK): See if this actually is registers or | 28 | enum class Architecture : s32 { |
| 29 | // not(find a game which has non zero valeus) | 29 | AArch64, |
| 30 | u64_le unk0{}; | 30 | AArch32, |
| 31 | u64_le unk1{}; | 31 | }; |
| 32 | u64_le unk2{}; | 32 | |
| 33 | u64_le unk3{}; | 33 | const char* ArchAsString() const { |
| 34 | u64_le unk4{}; | 34 | return arch == Architecture::AArch64 ? "AArch64" : "AArch32"; |
| 35 | u64_le unk5{}; | 35 | } |
| 36 | u64_le unk6{}; | 36 | |
| 37 | std::array<u64_le, 31> registers{}; | ||
| 38 | u64_le sp{}; | ||
| 39 | u64_le pc{}; | ||
| 40 | u64_le pstate{}; | ||
| 41 | u64_le afsr0{}; | ||
| 42 | u64_le afsr1{}; | ||
| 43 | u64_le esr{}; | ||
| 44 | u64_le far{}; | ||
| 37 | 45 | ||
| 38 | std::array<u64_le, 32> backtrace{}; | 46 | std::array<u64_le, 32> backtrace{}; |
| 39 | u64_le unk7{}; | 47 | u64_le program_entry_point{}; |
| 40 | u64_le unk8{}; | 48 | |
| 49 | // Bit flags that indicate which registers have been set with values | ||
| 50 | // for this context. The service itself uses these to determine which | ||
| 51 | // registers to specifically print out. | ||
| 52 | u64_le set_flags{}; | ||
| 53 | |||
| 41 | u32_le backtrace_size{}; | 54 | u32_le backtrace_size{}; |
| 42 | u32_le unk9{}; | 55 | Architecture arch{}; |
| 43 | u32_le unk10{}; // TODO(ogniK): Is this even used or is it just padding? | 56 | u32_le unk10{}; // TODO(ogniK): Is this even used or is it just padding? |
| 44 | }; | 57 | }; |
| 45 | static_assert(sizeof(FatalInfo) == 0x250, "FatalInfo is an invalid size"); | 58 | static_assert(sizeof(FatalInfo) == 0x250, "FatalInfo is an invalid size"); |
| @@ -52,36 +65,36 @@ enum class FatalType : u32 { | |||
| 52 | 65 | ||
| 53 | static void GenerateErrorReport(ResultCode error_code, const FatalInfo& info) { | 66 | static void GenerateErrorReport(ResultCode error_code, const FatalInfo& info) { |
| 54 | const auto title_id = Core::CurrentProcess()->GetTitleID(); | 67 | const auto title_id = Core::CurrentProcess()->GetTitleID(); |
| 55 | std::string crash_report = | 68 | std::string crash_report = fmt::format( |
| 56 | fmt::format("Yuzu {}-{} crash report\n" | 69 | "Yuzu {}-{} crash report\n" |
| 57 | "Title ID: {:016x}\n" | 70 | "Title ID: {:016x}\n" |
| 58 | "Result: 0x{:X} ({:04}-{:04d})\n" | 71 | "Result: 0x{:X} ({:04}-{:04d})\n" |
| 59 | "\n", | 72 | "Set flags: 0x{:16X}\n" |
| 60 | Common::g_scm_branch, Common::g_scm_desc, title_id, error_code.raw, | 73 | "Program entry point: 0x{:16X}\n" |
| 61 | 2000 + static_cast<u32>(error_code.module.Value()), | 74 | "\n", |
| 62 | static_cast<u32>(error_code.description.Value()), info.unk8, info.unk7); | 75 | Common::g_scm_branch, Common::g_scm_desc, title_id, error_code.raw, |
| 76 | 2000 + static_cast<u32>(error_code.module.Value()), | ||
| 77 | static_cast<u32>(error_code.description.Value()), info.set_flags, info.program_entry_point); | ||
| 63 | if (info.backtrace_size != 0x0) { | 78 | if (info.backtrace_size != 0x0) { |
| 64 | crash_report += "Registers:\n"; | 79 | crash_report += "Registers:\n"; |
| 65 | // TODO(ogniK): This is just a guess, find a game which actually has non zero values | ||
| 66 | for (size_t i = 0; i < info.registers.size(); i++) { | 80 | for (size_t i = 0; i < info.registers.size(); i++) { |
| 67 | crash_report += | 81 | crash_report += |
| 68 | fmt::format(" X[{:02d}]: {:016x}\n", i, info.registers[i]); | 82 | fmt::format(" X[{:02d}]: {:016x}\n", i, info.registers[i]); |
| 69 | } | 83 | } |
| 70 | crash_report += fmt::format(" Unknown 0: {:016x}\n", info.unk0); | 84 | crash_report += fmt::format(" SP: {:016x}\n", info.sp); |
| 71 | crash_report += fmt::format(" Unknown 1: {:016x}\n", info.unk1); | 85 | crash_report += fmt::format(" PC: {:016x}\n", info.pc); |
| 72 | crash_report += fmt::format(" Unknown 2: {:016x}\n", info.unk2); | 86 | crash_report += fmt::format(" PSTATE: {:016x}\n", info.pstate); |
| 73 | crash_report += fmt::format(" Unknown 3: {:016x}\n", info.unk3); | 87 | crash_report += fmt::format(" AFSR0: {:016x}\n", info.afsr0); |
| 74 | crash_report += fmt::format(" Unknown 4: {:016x}\n", info.unk4); | 88 | crash_report += fmt::format(" AFSR1: {:016x}\n", info.afsr1); |
| 75 | crash_report += fmt::format(" Unknown 5: {:016x}\n", info.unk5); | 89 | crash_report += fmt::format(" ESR: {:016x}\n", info.esr); |
| 76 | crash_report += fmt::format(" Unknown 6: {:016x}\n", info.unk6); | 90 | crash_report += fmt::format(" FAR: {:016x}\n", info.far); |
| 77 | crash_report += "\nBacktrace:\n"; | 91 | crash_report += "\nBacktrace:\n"; |
| 78 | for (size_t i = 0; i < info.backtrace_size; i++) { | 92 | for (size_t i = 0; i < info.backtrace_size; i++) { |
| 79 | crash_report += | 93 | crash_report += |
| 80 | fmt::format(" Backtrace[{:02d}]: {:016x}\n", i, info.backtrace[i]); | 94 | fmt::format(" Backtrace[{:02d}]: {:016x}\n", i, info.backtrace[i]); |
| 81 | } | 95 | } |
| 82 | crash_report += fmt::format("\nUnknown 7: 0x{:016x}\n", info.unk7); | 96 | |
| 83 | crash_report += fmt::format("Unknown 8: 0x{:016x}\n", info.unk8); | 97 | crash_report += fmt::format("Architecture: {}\n", info.ArchAsString()); |
| 84 | crash_report += fmt::format("Unknown 9: 0x{:016x}\n", info.unk9); | ||
| 85 | crash_report += fmt::format("Unknown 10: 0x{:016x}\n", info.unk10); | 98 | crash_report += fmt::format("Unknown 10: 0x{:016x}\n", info.unk10); |
| 86 | } | 99 | } |
| 87 | 100 | ||
| @@ -125,13 +138,13 @@ static void ThrowFatalError(ResultCode error_code, FatalType fatal_type, const F | |||
| 125 | case FatalType::ErrorReport: | 138 | case FatalType::ErrorReport: |
| 126 | GenerateErrorReport(error_code, info); | 139 | GenerateErrorReport(error_code, info); |
| 127 | break; | 140 | break; |
| 128 | }; | 141 | } |
| 129 | } | 142 | } |
| 130 | 143 | ||
| 131 | void Module::Interface::ThrowFatal(Kernel::HLERequestContext& ctx) { | 144 | void Module::Interface::ThrowFatal(Kernel::HLERequestContext& ctx) { |
| 132 | LOG_ERROR(Service_Fatal, "called"); | 145 | LOG_ERROR(Service_Fatal, "called"); |
| 133 | IPC::RequestParser rp{ctx}; | 146 | IPC::RequestParser rp{ctx}; |
| 134 | auto error_code = rp.Pop<ResultCode>(); | 147 | const auto error_code = rp.Pop<ResultCode>(); |
| 135 | 148 | ||
| 136 | ThrowFatalError(error_code, FatalType::ErrorScreen, {}); | 149 | ThrowFatalError(error_code, FatalType::ErrorScreen, {}); |
| 137 | IPC::ResponseBuilder rb{ctx, 2}; | 150 | IPC::ResponseBuilder rb{ctx, 2}; |
| @@ -141,8 +154,8 @@ void Module::Interface::ThrowFatal(Kernel::HLERequestContext& ctx) { | |||
| 141 | void Module::Interface::ThrowFatalWithPolicy(Kernel::HLERequestContext& ctx) { | 154 | void Module::Interface::ThrowFatalWithPolicy(Kernel::HLERequestContext& ctx) { |
| 142 | LOG_ERROR(Service_Fatal, "called"); | 155 | LOG_ERROR(Service_Fatal, "called"); |
| 143 | IPC::RequestParser rp(ctx); | 156 | IPC::RequestParser rp(ctx); |
| 144 | auto error_code = rp.Pop<ResultCode>(); | 157 | const auto error_code = rp.Pop<ResultCode>(); |
| 145 | auto fatal_type = rp.PopEnum<FatalType>(); | 158 | const auto fatal_type = rp.PopEnum<FatalType>(); |
| 146 | 159 | ||
| 147 | ThrowFatalError(error_code, fatal_type, {}); // No info is passed with ThrowFatalWithPolicy | 160 | ThrowFatalError(error_code, fatal_type, {}); // No info is passed with ThrowFatalWithPolicy |
| 148 | IPC::ResponseBuilder rb{ctx, 2}; | 161 | IPC::ResponseBuilder rb{ctx, 2}; |
| @@ -152,9 +165,9 @@ void Module::Interface::ThrowFatalWithPolicy(Kernel::HLERequestContext& ctx) { | |||
| 152 | void Module::Interface::ThrowFatalWithCpuContext(Kernel::HLERequestContext& ctx) { | 165 | void Module::Interface::ThrowFatalWithCpuContext(Kernel::HLERequestContext& ctx) { |
| 153 | LOG_ERROR(Service_Fatal, "called"); | 166 | LOG_ERROR(Service_Fatal, "called"); |
| 154 | IPC::RequestParser rp(ctx); | 167 | IPC::RequestParser rp(ctx); |
| 155 | auto error_code = rp.Pop<ResultCode>(); | 168 | const auto error_code = rp.Pop<ResultCode>(); |
| 156 | auto fatal_type = rp.PopEnum<FatalType>(); | 169 | const auto fatal_type = rp.PopEnum<FatalType>(); |
| 157 | auto fatal_info = ctx.ReadBuffer(); | 170 | const auto fatal_info = ctx.ReadBuffer(); |
| 158 | FatalInfo info{}; | 171 | FatalInfo info{}; |
| 159 | 172 | ||
| 160 | ASSERT_MSG(fatal_info.size() == sizeof(FatalInfo), "Invalid fatal info buffer size!"); | 173 | ASSERT_MSG(fatal_info.size() == sizeof(FatalInfo), "Invalid fatal info buffer size!"); |
diff --git a/src/core/hle/service/filesystem/filesystem.cpp b/src/core/hle/service/filesystem/filesystem.cpp index c6da2df43..4c2b371c3 100644 --- a/src/core/hle/service/filesystem/filesystem.cpp +++ b/src/core/hle/service/filesystem/filesystem.cpp | |||
| @@ -197,13 +197,16 @@ ResultCode VfsDirectoryServiceWrapper::RenameDirectory(const std::string& src_pa | |||
| 197 | 197 | ||
| 198 | ResultVal<FileSys::VirtualFile> VfsDirectoryServiceWrapper::OpenFile(const std::string& path_, | 198 | ResultVal<FileSys::VirtualFile> VfsDirectoryServiceWrapper::OpenFile(const std::string& path_, |
| 199 | FileSys::Mode mode) const { | 199 | FileSys::Mode mode) const { |
| 200 | std::string path(FileUtil::SanitizePath(path_)); | 200 | const std::string path(FileUtil::SanitizePath(path_)); |
| 201 | auto npath = path; | 201 | std::string_view npath = path; |
| 202 | while (npath.size() > 0 && (npath[0] == '/' || npath[0] == '\\')) | 202 | while (!npath.empty() && (npath[0] == '/' || npath[0] == '\\')) { |
| 203 | npath = npath.substr(1); | 203 | npath.remove_prefix(1); |
| 204 | } | ||
| 205 | |||
| 204 | auto file = backing->GetFileRelative(npath); | 206 | auto file = backing->GetFileRelative(npath); |
| 205 | if (file == nullptr) | 207 | if (file == nullptr) { |
| 206 | return FileSys::ERROR_PATH_NOT_FOUND; | 208 | return FileSys::ERROR_PATH_NOT_FOUND; |
| 209 | } | ||
| 207 | 210 | ||
| 208 | if (mode == FileSys::Mode::Append) { | 211 | if (mode == FileSys::Mode::Append) { |
| 209 | return MakeResult<FileSys::VirtualFile>( | 212 | return MakeResult<FileSys::VirtualFile>( |
| @@ -319,15 +322,15 @@ ResultVal<FileSys::VirtualFile> OpenRomFS(u64 title_id, FileSys::StorageId stora | |||
| 319 | } | 322 | } |
| 320 | 323 | ||
| 321 | ResultVal<FileSys::VirtualDir> OpenSaveData(FileSys::SaveDataSpaceId space, | 324 | ResultVal<FileSys::VirtualDir> OpenSaveData(FileSys::SaveDataSpaceId space, |
| 322 | FileSys::SaveDataDescriptor save_struct) { | 325 | const FileSys::SaveDataDescriptor& descriptor) { |
| 323 | LOG_TRACE(Service_FS, "Opening Save Data for space_id={:01X}, save_struct={}", | 326 | LOG_TRACE(Service_FS, "Opening Save Data for space_id={:01X}, save_struct={}", |
| 324 | static_cast<u8>(space), save_struct.DebugInfo()); | 327 | static_cast<u8>(space), descriptor.DebugInfo()); |
| 325 | 328 | ||
| 326 | if (save_data_factory == nullptr) { | 329 | if (save_data_factory == nullptr) { |
| 327 | return FileSys::ERROR_ENTITY_NOT_FOUND; | 330 | return FileSys::ERROR_ENTITY_NOT_FOUND; |
| 328 | } | 331 | } |
| 329 | 332 | ||
| 330 | return save_data_factory->Open(space, save_struct); | 333 | return save_data_factory->Open(space, descriptor); |
| 331 | } | 334 | } |
| 332 | 335 | ||
| 333 | ResultVal<FileSys::VirtualDir> OpenSaveDataSpace(FileSys::SaveDataSpaceId space) { | 336 | ResultVal<FileSys::VirtualDir> OpenSaveDataSpace(FileSys::SaveDataSpaceId space) { |
diff --git a/src/core/hle/service/filesystem/filesystem.h b/src/core/hle/service/filesystem/filesystem.h index 6fd5e7b23..7cfc0d902 100644 --- a/src/core/hle/service/filesystem/filesystem.h +++ b/src/core/hle/service/filesystem/filesystem.h | |||
| @@ -46,7 +46,7 @@ ResultVal<FileSys::VirtualFile> OpenRomFSCurrentProcess(); | |||
| 46 | ResultVal<FileSys::VirtualFile> OpenRomFS(u64 title_id, FileSys::StorageId storage_id, | 46 | ResultVal<FileSys::VirtualFile> OpenRomFS(u64 title_id, FileSys::StorageId storage_id, |
| 47 | FileSys::ContentRecordType type); | 47 | FileSys::ContentRecordType type); |
| 48 | ResultVal<FileSys::VirtualDir> OpenSaveData(FileSys::SaveDataSpaceId space, | 48 | ResultVal<FileSys::VirtualDir> OpenSaveData(FileSys::SaveDataSpaceId space, |
| 49 | FileSys::SaveDataDescriptor save_struct); | 49 | const FileSys::SaveDataDescriptor& descriptor); |
| 50 | ResultVal<FileSys::VirtualDir> OpenSaveDataSpace(FileSys::SaveDataSpaceId space); | 50 | ResultVal<FileSys::VirtualDir> OpenSaveDataSpace(FileSys::SaveDataSpaceId space); |
| 51 | ResultVal<FileSys::VirtualDir> OpenSDMC(); | 51 | ResultVal<FileSys::VirtualDir> OpenSDMC(); |
| 52 | 52 | ||
diff --git a/src/core/hle/service/filesystem/fsp_srv.cpp b/src/core/hle/service/filesystem/fsp_srv.cpp index f03fb629c..657baddb8 100644 --- a/src/core/hle/service/filesystem/fsp_srv.cpp +++ b/src/core/hle/service/filesystem/fsp_srv.cpp | |||
| @@ -315,61 +315,53 @@ public: | |||
| 315 | void CreateFile(Kernel::HLERequestContext& ctx) { | 315 | void CreateFile(Kernel::HLERequestContext& ctx) { |
| 316 | IPC::RequestParser rp{ctx}; | 316 | IPC::RequestParser rp{ctx}; |
| 317 | 317 | ||
| 318 | auto file_buffer = ctx.ReadBuffer(); | 318 | const auto file_buffer = ctx.ReadBuffer(); |
| 319 | std::string name = Common::StringFromBuffer(file_buffer); | 319 | const std::string name = Common::StringFromBuffer(file_buffer); |
| 320 | 320 | ||
| 321 | u64 mode = rp.Pop<u64>(); | 321 | const u64 mode = rp.Pop<u64>(); |
| 322 | u32 size = rp.Pop<u32>(); | 322 | const u32 size = rp.Pop<u32>(); |
| 323 | 323 | ||
| 324 | LOG_DEBUG(Service_FS, "called file {} mode 0x{:X} size 0x{:08X}", name, mode, size); | 324 | LOG_DEBUG(Service_FS, "called. file={}, mode=0x{:X}, size=0x{:08X}", name, mode, size); |
| 325 | 325 | ||
| 326 | IPC::ResponseBuilder rb{ctx, 2}; | 326 | IPC::ResponseBuilder rb{ctx, 2}; |
| 327 | rb.Push(backend.CreateFile(name, size)); | 327 | rb.Push(backend.CreateFile(name, size)); |
| 328 | } | 328 | } |
| 329 | 329 | ||
| 330 | void DeleteFile(Kernel::HLERequestContext& ctx) { | 330 | void DeleteFile(Kernel::HLERequestContext& ctx) { |
| 331 | IPC::RequestParser rp{ctx}; | 331 | const auto file_buffer = ctx.ReadBuffer(); |
| 332 | 332 | const std::string name = Common::StringFromBuffer(file_buffer); | |
| 333 | auto file_buffer = ctx.ReadBuffer(); | ||
| 334 | std::string name = Common::StringFromBuffer(file_buffer); | ||
| 335 | 333 | ||
| 336 | LOG_DEBUG(Service_FS, "called file {}", name); | 334 | LOG_DEBUG(Service_FS, "called. file={}", name); |
| 337 | 335 | ||
| 338 | IPC::ResponseBuilder rb{ctx, 2}; | 336 | IPC::ResponseBuilder rb{ctx, 2}; |
| 339 | rb.Push(backend.DeleteFile(name)); | 337 | rb.Push(backend.DeleteFile(name)); |
| 340 | } | 338 | } |
| 341 | 339 | ||
| 342 | void CreateDirectory(Kernel::HLERequestContext& ctx) { | 340 | void CreateDirectory(Kernel::HLERequestContext& ctx) { |
| 343 | IPC::RequestParser rp{ctx}; | 341 | const auto file_buffer = ctx.ReadBuffer(); |
| 344 | 342 | const std::string name = Common::StringFromBuffer(file_buffer); | |
| 345 | auto file_buffer = ctx.ReadBuffer(); | ||
| 346 | std::string name = Common::StringFromBuffer(file_buffer); | ||
| 347 | 343 | ||
| 348 | LOG_DEBUG(Service_FS, "called directory {}", name); | 344 | LOG_DEBUG(Service_FS, "called. directory={}", name); |
| 349 | 345 | ||
| 350 | IPC::ResponseBuilder rb{ctx, 2}; | 346 | IPC::ResponseBuilder rb{ctx, 2}; |
| 351 | rb.Push(backend.CreateDirectory(name)); | 347 | rb.Push(backend.CreateDirectory(name)); |
| 352 | } | 348 | } |
| 353 | 349 | ||
| 354 | void DeleteDirectory(Kernel::HLERequestContext& ctx) { | 350 | void DeleteDirectory(Kernel::HLERequestContext& ctx) { |
| 355 | const IPC::RequestParser rp{ctx}; | ||
| 356 | |||
| 357 | const auto file_buffer = ctx.ReadBuffer(); | 351 | const auto file_buffer = ctx.ReadBuffer(); |
| 358 | std::string name = Common::StringFromBuffer(file_buffer); | 352 | const std::string name = Common::StringFromBuffer(file_buffer); |
| 359 | 353 | ||
| 360 | LOG_DEBUG(Service_FS, "called directory {}", name); | 354 | LOG_DEBUG(Service_FS, "called. directory={}", name); |
| 361 | 355 | ||
| 362 | IPC::ResponseBuilder rb{ctx, 2}; | 356 | IPC::ResponseBuilder rb{ctx, 2}; |
| 363 | rb.Push(backend.DeleteDirectory(name)); | 357 | rb.Push(backend.DeleteDirectory(name)); |
| 364 | } | 358 | } |
| 365 | 359 | ||
| 366 | void DeleteDirectoryRecursively(Kernel::HLERequestContext& ctx) { | 360 | void DeleteDirectoryRecursively(Kernel::HLERequestContext& ctx) { |
| 367 | const IPC::RequestParser rp{ctx}; | ||
| 368 | |||
| 369 | const auto file_buffer = ctx.ReadBuffer(); | 361 | const auto file_buffer = ctx.ReadBuffer(); |
| 370 | std::string name = Common::StringFromBuffer(file_buffer); | 362 | const std::string name = Common::StringFromBuffer(file_buffer); |
| 371 | 363 | ||
| 372 | LOG_DEBUG(Service_FS, "called directory {}", name); | 364 | LOG_DEBUG(Service_FS, "called. directory={}", name); |
| 373 | 365 | ||
| 374 | IPC::ResponseBuilder rb{ctx, 2}; | 366 | IPC::ResponseBuilder rb{ctx, 2}; |
| 375 | rb.Push(backend.DeleteDirectoryRecursively(name)); | 367 | rb.Push(backend.DeleteDirectoryRecursively(name)); |
| @@ -386,18 +378,16 @@ public: | |||
| 386 | } | 378 | } |
| 387 | 379 | ||
| 388 | void RenameFile(Kernel::HLERequestContext& ctx) { | 380 | void RenameFile(Kernel::HLERequestContext& ctx) { |
| 389 | IPC::RequestParser rp{ctx}; | ||
| 390 | |||
| 391 | std::vector<u8> buffer; | 381 | std::vector<u8> buffer; |
| 392 | buffer.resize(ctx.BufferDescriptorX()[0].Size()); | 382 | buffer.resize(ctx.BufferDescriptorX()[0].Size()); |
| 393 | Memory::ReadBlock(ctx.BufferDescriptorX()[0].Address(), buffer.data(), buffer.size()); | 383 | Memory::ReadBlock(ctx.BufferDescriptorX()[0].Address(), buffer.data(), buffer.size()); |
| 394 | std::string src_name = Common::StringFromBuffer(buffer); | 384 | const std::string src_name = Common::StringFromBuffer(buffer); |
| 395 | 385 | ||
| 396 | buffer.resize(ctx.BufferDescriptorX()[1].Size()); | 386 | buffer.resize(ctx.BufferDescriptorX()[1].Size()); |
| 397 | Memory::ReadBlock(ctx.BufferDescriptorX()[1].Address(), buffer.data(), buffer.size()); | 387 | Memory::ReadBlock(ctx.BufferDescriptorX()[1].Address(), buffer.data(), buffer.size()); |
| 398 | std::string dst_name = Common::StringFromBuffer(buffer); | 388 | const std::string dst_name = Common::StringFromBuffer(buffer); |
| 399 | 389 | ||
| 400 | LOG_DEBUG(Service_FS, "called file '{}' to file '{}'", src_name, dst_name); | 390 | LOG_DEBUG(Service_FS, "called. file '{}' to file '{}'", src_name, dst_name); |
| 401 | 391 | ||
| 402 | IPC::ResponseBuilder rb{ctx, 2}; | 392 | IPC::ResponseBuilder rb{ctx, 2}; |
| 403 | rb.Push(backend.RenameFile(src_name, dst_name)); | 393 | rb.Push(backend.RenameFile(src_name, dst_name)); |
| @@ -406,12 +396,12 @@ public: | |||
| 406 | void OpenFile(Kernel::HLERequestContext& ctx) { | 396 | void OpenFile(Kernel::HLERequestContext& ctx) { |
| 407 | IPC::RequestParser rp{ctx}; | 397 | IPC::RequestParser rp{ctx}; |
| 408 | 398 | ||
| 409 | auto file_buffer = ctx.ReadBuffer(); | 399 | const auto file_buffer = ctx.ReadBuffer(); |
| 410 | std::string name = Common::StringFromBuffer(file_buffer); | 400 | const std::string name = Common::StringFromBuffer(file_buffer); |
| 411 | 401 | ||
| 412 | auto mode = static_cast<FileSys::Mode>(rp.Pop<u32>()); | 402 | const auto mode = static_cast<FileSys::Mode>(rp.Pop<u32>()); |
| 413 | 403 | ||
| 414 | LOG_DEBUG(Service_FS, "called file {} mode {}", name, static_cast<u32>(mode)); | 404 | LOG_DEBUG(Service_FS, "called. file={}, mode={}", name, static_cast<u32>(mode)); |
| 415 | 405 | ||
| 416 | auto result = backend.OpenFile(name, mode); | 406 | auto result = backend.OpenFile(name, mode); |
| 417 | if (result.Failed()) { | 407 | if (result.Failed()) { |
| @@ -430,13 +420,13 @@ public: | |||
| 430 | void OpenDirectory(Kernel::HLERequestContext& ctx) { | 420 | void OpenDirectory(Kernel::HLERequestContext& ctx) { |
| 431 | IPC::RequestParser rp{ctx}; | 421 | IPC::RequestParser rp{ctx}; |
| 432 | 422 | ||
| 433 | auto file_buffer = ctx.ReadBuffer(); | 423 | const auto file_buffer = ctx.ReadBuffer(); |
| 434 | std::string name = Common::StringFromBuffer(file_buffer); | 424 | const std::string name = Common::StringFromBuffer(file_buffer); |
| 435 | 425 | ||
| 436 | // TODO(Subv): Implement this filter. | 426 | // TODO(Subv): Implement this filter. |
| 437 | u32 filter_flags = rp.Pop<u32>(); | 427 | const u32 filter_flags = rp.Pop<u32>(); |
| 438 | 428 | ||
| 439 | LOG_DEBUG(Service_FS, "called directory {} filter {}", name, filter_flags); | 429 | LOG_DEBUG(Service_FS, "called. directory={}, filter={}", name, filter_flags); |
| 440 | 430 | ||
| 441 | auto result = backend.OpenDirectory(name); | 431 | auto result = backend.OpenDirectory(name); |
| 442 | if (result.Failed()) { | 432 | if (result.Failed()) { |
| @@ -453,12 +443,10 @@ public: | |||
| 453 | } | 443 | } |
| 454 | 444 | ||
| 455 | void GetEntryType(Kernel::HLERequestContext& ctx) { | 445 | void GetEntryType(Kernel::HLERequestContext& ctx) { |
| 456 | IPC::RequestParser rp{ctx}; | 446 | const auto file_buffer = ctx.ReadBuffer(); |
| 457 | 447 | const std::string name = Common::StringFromBuffer(file_buffer); | |
| 458 | auto file_buffer = ctx.ReadBuffer(); | ||
| 459 | std::string name = Common::StringFromBuffer(file_buffer); | ||
| 460 | 448 | ||
| 461 | LOG_DEBUG(Service_FS, "called file {}", name); | 449 | LOG_DEBUG(Service_FS, "called. file={}", name); |
| 462 | 450 | ||
| 463 | auto result = backend.GetEntryType(name); | 451 | auto result = backend.GetEntryType(name); |
| 464 | if (result.Failed()) { | 452 | if (result.Failed()) { |
| @@ -616,7 +604,9 @@ private: | |||
| 616 | u64_le save_id; | 604 | u64_le save_id; |
| 617 | u64_le title_id; | 605 | u64_le title_id; |
| 618 | u64_le save_image_size; | 606 | u64_le save_image_size; |
| 619 | INSERT_PADDING_BYTES(0x28); | 607 | u16_le index; |
| 608 | FileSys::SaveDataRank rank; | ||
| 609 | INSERT_PADDING_BYTES(0x25); | ||
| 620 | }; | 610 | }; |
| 621 | static_assert(sizeof(SaveDataInfo) == 0x60, "SaveDataInfo has incorrect size."); | 611 | static_assert(sizeof(SaveDataInfo) == 0x60, "SaveDataInfo has incorrect size."); |
| 622 | 612 | ||
| @@ -779,16 +769,17 @@ void FSP_SRV::CreateSaveDataFileSystem(Kernel::HLERequestContext& ctx) { | |||
| 779 | } | 769 | } |
| 780 | 770 | ||
| 781 | void FSP_SRV::OpenSaveDataFileSystem(Kernel::HLERequestContext& ctx) { | 771 | void FSP_SRV::OpenSaveDataFileSystem(Kernel::HLERequestContext& ctx) { |
| 782 | IPC::RequestParser rp{ctx}; | 772 | LOG_INFO(Service_FS, "called."); |
| 783 | |||
| 784 | auto space_id = rp.PopRaw<FileSys::SaveDataSpaceId>(); | ||
| 785 | auto unk = rp.Pop<u32>(); | ||
| 786 | LOG_INFO(Service_FS, "called with unknown={:08X}", unk); | ||
| 787 | 773 | ||
| 788 | auto save_struct = rp.PopRaw<FileSys::SaveDataDescriptor>(); | 774 | struct Parameters { |
| 775 | FileSys::SaveDataSpaceId save_data_space_id; | ||
| 776 | FileSys::SaveDataDescriptor descriptor; | ||
| 777 | }; | ||
| 789 | 778 | ||
| 790 | auto dir = OpenSaveData(space_id, save_struct); | 779 | IPC::RequestParser rp{ctx}; |
| 780 | const auto parameters = rp.PopRaw<Parameters>(); | ||
| 791 | 781 | ||
| 782 | auto dir = OpenSaveData(parameters.save_data_space_id, parameters.descriptor); | ||
| 792 | if (dir.Failed()) { | 783 | if (dir.Failed()) { |
| 793 | IPC::ResponseBuilder rb{ctx, 2, 0, 0}; | 784 | IPC::ResponseBuilder rb{ctx, 2, 0, 0}; |
| 794 | rb.Push(FileSys::ERROR_ENTITY_NOT_FOUND); | 785 | rb.Push(FileSys::ERROR_ENTITY_NOT_FOUND); |
diff --git a/src/core/hle/service/nfc/nfc.cpp b/src/core/hle/service/nfc/nfc.cpp index 5c62d42ba..ca88bf97f 100644 --- a/src/core/hle/service/nfc/nfc.cpp +++ b/src/core/hle/service/nfc/nfc.cpp | |||
| @@ -150,7 +150,7 @@ private: | |||
| 150 | 150 | ||
| 151 | IPC::ResponseBuilder rb{ctx, 3}; | 151 | IPC::ResponseBuilder rb{ctx, 3}; |
| 152 | rb.Push(RESULT_SUCCESS); | 152 | rb.Push(RESULT_SUCCESS); |
| 153 | rb.PushRaw<u8>(Settings::values.enable_nfc); | 153 | rb.PushRaw<u8>(true); |
| 154 | } | 154 | } |
| 155 | 155 | ||
| 156 | void GetStateOld(Kernel::HLERequestContext& ctx) { | 156 | void GetStateOld(Kernel::HLERequestContext& ctx) { |
diff --git a/src/core/hle/service/nfp/nfp.cpp b/src/core/hle/service/nfp/nfp.cpp index 1c4482e47..c6babdd4d 100644 --- a/src/core/hle/service/nfp/nfp.cpp +++ b/src/core/hle/service/nfp/nfp.cpp | |||
| @@ -335,7 +335,7 @@ void Module::Interface::CreateUserInterface(Kernel::HLERequestContext& ctx) { | |||
| 335 | } | 335 | } |
| 336 | 336 | ||
| 337 | bool Module::Interface::LoadAmiibo(const std::vector<u8>& buffer) { | 337 | bool Module::Interface::LoadAmiibo(const std::vector<u8>& buffer) { |
| 338 | std::lock_guard<std::recursive_mutex> lock(HLE::g_hle_lock); | 338 | std::lock_guard lock{HLE::g_hle_lock}; |
| 339 | if (buffer.size() < sizeof(AmiiboFile)) { | 339 | if (buffer.size() < sizeof(AmiiboFile)) { |
| 340 | return false; | 340 | return false; |
| 341 | } | 341 | } |
diff --git a/src/core/hle/service/nvdrv/devices/nvdisp_disp0.h b/src/core/hle/service/nvdrv/devices/nvdisp_disp0.h index ace71169f..12f3ef825 100644 --- a/src/core/hle/service/nvdrv/devices/nvdisp_disp0.h +++ b/src/core/hle/service/nvdrv/devices/nvdisp_disp0.h | |||
| @@ -18,7 +18,7 @@ class nvmap; | |||
| 18 | class nvdisp_disp0 final : public nvdevice { | 18 | class nvdisp_disp0 final : public nvdevice { |
| 19 | public: | 19 | public: |
| 20 | explicit nvdisp_disp0(std::shared_ptr<nvmap> nvmap_dev); | 20 | explicit nvdisp_disp0(std::shared_ptr<nvmap> nvmap_dev); |
| 21 | ~nvdisp_disp0(); | 21 | ~nvdisp_disp0() override; |
| 22 | 22 | ||
| 23 | u32 ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) override; | 23 | u32 ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) override; |
| 24 | 24 | ||
diff --git a/src/core/hle/service/nvdrv/interface.h b/src/core/hle/service/nvdrv/interface.h index fe311b069..5b4889910 100644 --- a/src/core/hle/service/nvdrv/interface.h +++ b/src/core/hle/service/nvdrv/interface.h | |||
| @@ -17,7 +17,7 @@ namespace Service::Nvidia { | |||
| 17 | class NVDRV final : public ServiceFramework<NVDRV> { | 17 | class NVDRV final : public ServiceFramework<NVDRV> { |
| 18 | public: | 18 | public: |
| 19 | NVDRV(std::shared_ptr<Module> nvdrv, const char* name); | 19 | NVDRV(std::shared_ptr<Module> nvdrv, const char* name); |
| 20 | ~NVDRV(); | 20 | ~NVDRV() override; |
| 21 | 21 | ||
| 22 | private: | 22 | private: |
| 23 | void Open(Kernel::HLERequestContext& ctx); | 23 | void Open(Kernel::HLERequestContext& ctx); |
diff --git a/src/core/hle/service/nvdrv/nvmemp.h b/src/core/hle/service/nvdrv/nvmemp.h index 5a4dfc1f9..6eafb1346 100644 --- a/src/core/hle/service/nvdrv/nvmemp.h +++ b/src/core/hle/service/nvdrv/nvmemp.h | |||
| @@ -11,7 +11,7 @@ namespace Service::Nvidia { | |||
| 11 | class NVMEMP final : public ServiceFramework<NVMEMP> { | 11 | class NVMEMP final : public ServiceFramework<NVMEMP> { |
| 12 | public: | 12 | public: |
| 13 | NVMEMP(); | 13 | NVMEMP(); |
| 14 | ~NVMEMP(); | 14 | ~NVMEMP() override; |
| 15 | 15 | ||
| 16 | private: | 16 | private: |
| 17 | void Cmd0(Kernel::HLERequestContext& ctx); | 17 | void Cmd0(Kernel::HLERequestContext& ctx); |
diff --git a/src/core/hle/service/service.h b/src/core/hle/service/service.h index 830790269..abbfe5524 100644 --- a/src/core/hle/service/service.h +++ b/src/core/hle/service/service.h | |||
| @@ -90,7 +90,7 @@ private: | |||
| 90 | Kernel::HLERequestContext& ctx); | 90 | Kernel::HLERequestContext& ctx); |
| 91 | 91 | ||
| 92 | ServiceFrameworkBase(const char* service_name, u32 max_sessions, InvokerFn* handler_invoker); | 92 | ServiceFrameworkBase(const char* service_name, u32 max_sessions, InvokerFn* handler_invoker); |
| 93 | ~ServiceFrameworkBase(); | 93 | ~ServiceFrameworkBase() override; |
| 94 | 94 | ||
| 95 | void RegisterHandlersBase(const FunctionInfoBase* functions, std::size_t n); | 95 | void RegisterHandlersBase(const FunctionInfoBase* functions, std::size_t n); |
| 96 | void ReportUnimplementedFunction(Kernel::HLERequestContext& ctx, const FunctionInfoBase* info); | 96 | void ReportUnimplementedFunction(Kernel::HLERequestContext& ctx, const FunctionInfoBase* info); |
diff --git a/src/core/hle/service/set/set_cal.h b/src/core/hle/service/set/set_cal.h index 583036eac..a0677e815 100644 --- a/src/core/hle/service/set/set_cal.h +++ b/src/core/hle/service/set/set_cal.h | |||
| @@ -11,7 +11,7 @@ namespace Service::Set { | |||
| 11 | class SET_CAL final : public ServiceFramework<SET_CAL> { | 11 | class SET_CAL final : public ServiceFramework<SET_CAL> { |
| 12 | public: | 12 | public: |
| 13 | explicit SET_CAL(); | 13 | explicit SET_CAL(); |
| 14 | ~SET_CAL(); | 14 | ~SET_CAL() override; |
| 15 | }; | 15 | }; |
| 16 | 16 | ||
| 17 | } // namespace Service::Set | 17 | } // namespace Service::Set |
diff --git a/src/core/hle/service/sockets/sfdnsres.cpp b/src/core/hle/service/sockets/sfdnsres.cpp index 13ab1d31e..852e71e4b 100644 --- a/src/core/hle/service/sockets/sfdnsres.cpp +++ b/src/core/hle/service/sockets/sfdnsres.cpp | |||
| @@ -8,12 +8,20 @@ | |||
| 8 | namespace Service::Sockets { | 8 | namespace Service::Sockets { |
| 9 | 9 | ||
| 10 | void SFDNSRES::GetAddrInfo(Kernel::HLERequestContext& ctx) { | 10 | void SFDNSRES::GetAddrInfo(Kernel::HLERequestContext& ctx) { |
| 11 | struct Parameters { | ||
| 12 | u8 use_nsd_resolve; | ||
| 13 | u32 unknown; | ||
| 14 | u64 process_id; | ||
| 15 | }; | ||
| 16 | |||
| 11 | IPC::RequestParser rp{ctx}; | 17 | IPC::RequestParser rp{ctx}; |
| 18 | const auto parameters = rp.PopRaw<Parameters>(); | ||
| 12 | 19 | ||
| 13 | LOG_WARNING(Service, "(STUBBED) called"); | 20 | LOG_WARNING(Service, |
| 21 | "(STUBBED) called. use_nsd_resolve={}, unknown=0x{:08X}, process_id=0x{:016X}", | ||
| 22 | parameters.use_nsd_resolve, parameters.unknown, parameters.process_id); | ||
| 14 | 23 | ||
| 15 | IPC::ResponseBuilder rb{ctx, 2}; | 24 | IPC::ResponseBuilder rb{ctx, 2}; |
| 16 | |||
| 17 | rb.Push(RESULT_SUCCESS); | 25 | rb.Push(RESULT_SUCCESS); |
| 18 | } | 26 | } |
| 19 | 27 | ||
diff --git a/src/core/hle/service/spl/module.cpp b/src/core/hle/service/spl/module.cpp index 8db0c2f13..e724d4ab8 100644 --- a/src/core/hle/service/spl/module.cpp +++ b/src/core/hle/service/spl/module.cpp | |||
| @@ -26,9 +26,7 @@ Module::Interface::~Interface() = default; | |||
| 26 | void Module::Interface::GetRandomBytes(Kernel::HLERequestContext& ctx) { | 26 | void Module::Interface::GetRandomBytes(Kernel::HLERequestContext& ctx) { |
| 27 | LOG_DEBUG(Service_SPL, "called"); | 27 | LOG_DEBUG(Service_SPL, "called"); |
| 28 | 28 | ||
| 29 | IPC::RequestParser rp{ctx}; | 29 | const std::size_t size = ctx.GetWriteBufferSize(); |
| 30 | |||
| 31 | std::size_t size = ctx.GetWriteBufferSize(); | ||
| 32 | 30 | ||
| 33 | std::uniform_int_distribution<u16> distribution(0, std::numeric_limits<u8>::max()); | 31 | std::uniform_int_distribution<u16> distribution(0, std::numeric_limits<u8>::max()); |
| 34 | std::vector<u8> data(size); | 32 | std::vector<u8> data(size); |
diff --git a/src/core/hle/service/ssl/ssl.cpp b/src/core/hle/service/ssl/ssl.cpp index af40a1815..f7f87a958 100644 --- a/src/core/hle/service/ssl/ssl.cpp +++ b/src/core/hle/service/ssl/ssl.cpp | |||
| @@ -64,13 +64,19 @@ public: | |||
| 64 | }; | 64 | }; |
| 65 | RegisterHandlers(functions); | 65 | RegisterHandlers(functions); |
| 66 | } | 66 | } |
| 67 | ~ISslContext() = default; | ||
| 68 | 67 | ||
| 69 | private: | 68 | private: |
| 70 | void SetOption(Kernel::HLERequestContext& ctx) { | 69 | void SetOption(Kernel::HLERequestContext& ctx) { |
| 71 | LOG_WARNING(Service_SSL, "(STUBBED) called"); | 70 | struct Parameters { |
| 71 | u8 enable; | ||
| 72 | u32 option; | ||
| 73 | }; | ||
| 72 | 74 | ||
| 73 | IPC::RequestParser rp{ctx}; | 75 | IPC::RequestParser rp{ctx}; |
| 76 | const auto parameters = rp.PopRaw<Parameters>(); | ||
| 77 | |||
| 78 | LOG_WARNING(Service_SSL, "(STUBBED) called. enable={}, option={}", parameters.enable, | ||
| 79 | parameters.option); | ||
| 74 | 80 | ||
| 75 | IPC::ResponseBuilder rb{ctx, 2}; | 81 | IPC::ResponseBuilder rb{ctx, 2}; |
| 76 | rb.Push(RESULT_SUCCESS); | 82 | rb.Push(RESULT_SUCCESS); |
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp index 566cd6006..4e17249a9 100644 --- a/src/core/hle/service/vi/vi.cpp +++ b/src/core/hle/service/vi/vi.cpp | |||
| @@ -498,7 +498,6 @@ public: | |||
| 498 | }; | 498 | }; |
| 499 | RegisterHandlers(functions); | 499 | RegisterHandlers(functions); |
| 500 | } | 500 | } |
| 501 | ~IHOSBinderDriver() = default; | ||
| 502 | 501 | ||
| 503 | private: | 502 | private: |
| 504 | enum class TransactionId { | 503 | enum class TransactionId { |
| @@ -692,7 +691,6 @@ public: | |||
| 692 | }; | 691 | }; |
| 693 | RegisterHandlers(functions); | 692 | RegisterHandlers(functions); |
| 694 | } | 693 | } |
| 695 | ~ISystemDisplayService() = default; | ||
| 696 | 694 | ||
| 697 | private: | 695 | private: |
| 698 | void SetLayerZ(Kernel::HLERequestContext& ctx) { | 696 | void SetLayerZ(Kernel::HLERequestContext& ctx) { |
| @@ -818,7 +816,6 @@ public: | |||
| 818 | }; | 816 | }; |
| 819 | RegisterHandlers(functions); | 817 | RegisterHandlers(functions); |
| 820 | } | 818 | } |
| 821 | ~IManagerDisplayService() = default; | ||
| 822 | 819 | ||
| 823 | private: | 820 | private: |
| 824 | void CloseDisplay(Kernel::HLERequestContext& ctx) { | 821 | void CloseDisplay(Kernel::HLERequestContext& ctx) { |
| @@ -884,7 +881,6 @@ private: | |||
| 884 | class IApplicationDisplayService final : public ServiceFramework<IApplicationDisplayService> { | 881 | class IApplicationDisplayService final : public ServiceFramework<IApplicationDisplayService> { |
| 885 | public: | 882 | public: |
| 886 | explicit IApplicationDisplayService(std::shared_ptr<NVFlinger::NVFlinger> nv_flinger); | 883 | explicit IApplicationDisplayService(std::shared_ptr<NVFlinger::NVFlinger> nv_flinger); |
| 887 | ~IApplicationDisplayService() = default; | ||
| 888 | 884 | ||
| 889 | private: | 885 | private: |
| 890 | enum class ConvertedScaleMode : u64 { | 886 | enum class ConvertedScaleMode : u64 { |
| @@ -1037,7 +1033,6 @@ private: | |||
| 1037 | void ListDisplays(Kernel::HLERequestContext& ctx) { | 1033 | void ListDisplays(Kernel::HLERequestContext& ctx) { |
| 1038 | LOG_WARNING(Service_VI, "(STUBBED) called"); | 1034 | LOG_WARNING(Service_VI, "(STUBBED) called"); |
| 1039 | 1035 | ||
| 1040 | IPC::RequestParser rp{ctx}; | ||
| 1041 | DisplayInfo display_info; | 1036 | DisplayInfo display_info; |
| 1042 | display_info.width *= static_cast<u64>(Settings::values.resolution_factor); | 1037 | display_info.width *= static_cast<u64>(Settings::values.resolution_factor); |
| 1043 | display_info.height *= static_cast<u64>(Settings::values.resolution_factor); | 1038 | display_info.height *= static_cast<u64>(Settings::values.resolution_factor); |
diff --git a/src/core/loader/elf.cpp b/src/core/loader/elf.cpp index 8b1920f22..46ac372f6 100644 --- a/src/core/loader/elf.cpp +++ b/src/core/loader/elf.cpp | |||
| @@ -341,7 +341,7 @@ Kernel::CodeSet ElfReader::LoadInto(VAddr vaddr) { | |||
| 341 | } | 341 | } |
| 342 | 342 | ||
| 343 | codeset.entrypoint = base_addr + header->e_entry; | 343 | codeset.entrypoint = base_addr + header->e_entry; |
| 344 | codeset.memory = std::make_shared<std::vector<u8>>(std::move(program_image)); | 344 | codeset.memory = std::move(program_image); |
| 345 | 345 | ||
| 346 | LOG_DEBUG(Loader, "Done loading."); | 346 | LOG_DEBUG(Loader, "Done loading."); |
| 347 | 347 | ||
diff --git a/src/core/loader/nro.cpp b/src/core/loader/nro.cpp index 5de02a94b..31e4a0c84 100644 --- a/src/core/loader/nro.cpp +++ b/src/core/loader/nro.cpp | |||
| @@ -187,7 +187,7 @@ static bool LoadNroImpl(Kernel::Process& process, const std::vector<u8>& data, | |||
| 187 | program_image.resize(static_cast<u32>(program_image.size()) + bss_size); | 187 | program_image.resize(static_cast<u32>(program_image.size()) + bss_size); |
| 188 | 188 | ||
| 189 | // Load codeset for current process | 189 | // Load codeset for current process |
| 190 | codeset.memory = std::make_shared<std::vector<u8>>(std::move(program_image)); | 190 | codeset.memory = std::move(program_image); |
| 191 | process.LoadModule(std::move(codeset), load_base); | 191 | process.LoadModule(std::move(codeset), load_base); |
| 192 | 192 | ||
| 193 | // Register module with GDBStub | 193 | // Register module with GDBStub |
diff --git a/src/core/loader/nso.cpp b/src/core/loader/nso.cpp index 714d85a59..ffe2eea8a 100644 --- a/src/core/loader/nso.cpp +++ b/src/core/loader/nso.cpp | |||
| @@ -4,11 +4,12 @@ | |||
| 4 | 4 | ||
| 5 | #include <cinttypes> | 5 | #include <cinttypes> |
| 6 | #include <vector> | 6 | #include <vector> |
| 7 | #include <lz4.h> | 7 | |
| 8 | #include "common/common_funcs.h" | 8 | #include "common/common_funcs.h" |
| 9 | #include "common/file_util.h" | 9 | #include "common/file_util.h" |
| 10 | #include "common/hex_util.h" | 10 | #include "common/hex_util.h" |
| 11 | #include "common/logging/log.h" | 11 | #include "common/logging/log.h" |
| 12 | #include "common/lz4_compression.h" | ||
| 12 | #include "common/swap.h" | 13 | #include "common/swap.h" |
| 13 | #include "core/core.h" | 14 | #include "core/core.h" |
| 14 | #include "core/file_sys/patch_manager.h" | 15 | #include "core/file_sys/patch_manager.h" |
| @@ -35,15 +36,11 @@ static_assert(sizeof(MODHeader) == 0x1c, "MODHeader has incorrect size."); | |||
| 35 | 36 | ||
| 36 | std::vector<u8> DecompressSegment(const std::vector<u8>& compressed_data, | 37 | std::vector<u8> DecompressSegment(const std::vector<u8>& compressed_data, |
| 37 | const NSOSegmentHeader& header) { | 38 | const NSOSegmentHeader& header) { |
| 38 | std::vector<u8> uncompressed_data(header.size); | 39 | const std::vector<u8> uncompressed_data = |
| 39 | const int bytes_uncompressed = | 40 | Common::Compression::DecompressDataLZ4(compressed_data, header.size); |
| 40 | LZ4_decompress_safe(reinterpret_cast<const char*>(compressed_data.data()), | ||
| 41 | reinterpret_cast<char*>(uncompressed_data.data()), | ||
| 42 | static_cast<int>(compressed_data.size()), header.size); | ||
| 43 | 41 | ||
| 44 | ASSERT_MSG(bytes_uncompressed == static_cast<int>(header.size) && | 42 | ASSERT_MSG(uncompressed_data.size() == static_cast<int>(header.size), "{} != {}", header.size, |
| 45 | bytes_uncompressed == static_cast<int>(uncompressed_data.size()), | 43 | uncompressed_data.size()); |
| 46 | "{} != {} != {}", bytes_uncompressed, header.size, uncompressed_data.size()); | ||
| 47 | 44 | ||
| 48 | return uncompressed_data; | 45 | return uncompressed_data; |
| 49 | } | 46 | } |
| @@ -161,7 +158,7 @@ std::optional<VAddr> AppLoader_NSO::LoadModule(Kernel::Process& process, | |||
| 161 | } | 158 | } |
| 162 | 159 | ||
| 163 | // Load codeset for current process | 160 | // Load codeset for current process |
| 164 | codeset.memory = std::make_shared<std::vector<u8>>(std::move(program_image)); | 161 | codeset.memory = std::move(program_image); |
| 165 | process.LoadModule(std::move(codeset), load_base); | 162 | process.LoadModule(std::move(codeset), load_base); |
| 166 | 163 | ||
| 167 | // Register module with GDBStub | 164 | // Register module with GDBStub |
diff --git a/src/core/loader/xci.h b/src/core/loader/xci.h index d6995b61e..436f7387c 100644 --- a/src/core/loader/xci.h +++ b/src/core/loader/xci.h | |||
| @@ -22,7 +22,7 @@ class AppLoader_NCA; | |||
| 22 | class AppLoader_XCI final : public AppLoader { | 22 | class AppLoader_XCI final : public AppLoader { |
| 23 | public: | 23 | public: |
| 24 | explicit AppLoader_XCI(FileSys::VirtualFile file); | 24 | explicit AppLoader_XCI(FileSys::VirtualFile file); |
| 25 | ~AppLoader_XCI(); | 25 | ~AppLoader_XCI() override; |
| 26 | 26 | ||
| 27 | /** | 27 | /** |
| 28 | * Returns the type of the file | 28 | * Returns the type of the file |
diff --git a/src/core/memory.cpp b/src/core/memory.cpp index 332c1037c..4e0538bc2 100644 --- a/src/core/memory.cpp +++ b/src/core/memory.cpp | |||
| @@ -38,10 +38,6 @@ void SetCurrentPageTable(Common::PageTable* page_table) { | |||
| 38 | } | 38 | } |
| 39 | } | 39 | } |
| 40 | 40 | ||
| 41 | Common::PageTable* GetCurrentPageTable() { | ||
| 42 | return current_page_table; | ||
| 43 | } | ||
| 44 | |||
| 45 | static void MapPages(Common::PageTable& page_table, VAddr base, u64 size, u8* memory, | 41 | static void MapPages(Common::PageTable& page_table, VAddr base, u64 size, u8* memory, |
| 46 | Common::PageType type) { | 42 | Common::PageType type) { |
| 47 | LOG_DEBUG(HW_Memory, "Mapping {} onto {:016X}-{:016X}", fmt::ptr(memory), base * PAGE_SIZE, | 43 | LOG_DEBUG(HW_Memory, "Mapping {} onto {:016X}-{:016X}", fmt::ptr(memory), base * PAGE_SIZE, |
diff --git a/src/core/memory.h b/src/core/memory.h index 1d38cdca8..6845f5fe1 100644 --- a/src/core/memory.h +++ b/src/core/memory.h | |||
| @@ -28,16 +28,6 @@ constexpr u64 PAGE_MASK = PAGE_SIZE - 1; | |||
| 28 | 28 | ||
| 29 | /// Virtual user-space memory regions | 29 | /// Virtual user-space memory regions |
| 30 | enum : VAddr { | 30 | enum : VAddr { |
| 31 | /// Read-only page containing kernel and system configuration values. | ||
| 32 | CONFIG_MEMORY_VADDR = 0x1FF80000, | ||
| 33 | CONFIG_MEMORY_SIZE = 0x00001000, | ||
| 34 | CONFIG_MEMORY_VADDR_END = CONFIG_MEMORY_VADDR + CONFIG_MEMORY_SIZE, | ||
| 35 | |||
| 36 | /// Usually read-only page containing mostly values read from hardware. | ||
| 37 | SHARED_PAGE_VADDR = 0x1FF81000, | ||
| 38 | SHARED_PAGE_SIZE = 0x00001000, | ||
| 39 | SHARED_PAGE_VADDR_END = SHARED_PAGE_VADDR + SHARED_PAGE_SIZE, | ||
| 40 | |||
| 41 | /// TLS (Thread-Local Storage) related. | 31 | /// TLS (Thread-Local Storage) related. |
| 42 | TLS_ENTRY_SIZE = 0x200, | 32 | TLS_ENTRY_SIZE = 0x200, |
| 43 | 33 | ||
| @@ -50,9 +40,8 @@ enum : VAddr { | |||
| 50 | KERNEL_REGION_END = KERNEL_REGION_VADDR + KERNEL_REGION_SIZE, | 40 | KERNEL_REGION_END = KERNEL_REGION_VADDR + KERNEL_REGION_SIZE, |
| 51 | }; | 41 | }; |
| 52 | 42 | ||
| 53 | /// Currently active page table | 43 | /// Changes the currently active page table. |
| 54 | void SetCurrentPageTable(Common::PageTable* page_table); | 44 | void SetCurrentPageTable(Common::PageTable* page_table); |
| 55 | Common::PageTable* GetCurrentPageTable(); | ||
| 56 | 45 | ||
| 57 | /// Determines if the given VAddr is valid for the specified process. | 46 | /// Determines if the given VAddr is valid for the specified process. |
| 58 | bool IsValidVirtualAddress(const Kernel::Process& process, VAddr vaddr); | 47 | bool IsValidVirtualAddress(const Kernel::Process& process, VAddr vaddr); |
diff --git a/src/core/perf_stats.cpp b/src/core/perf_stats.cpp index c716a462b..4afd6c8a3 100644 --- a/src/core/perf_stats.cpp +++ b/src/core/perf_stats.cpp | |||
| @@ -18,13 +18,13 @@ using std::chrono::microseconds; | |||
| 18 | namespace Core { | 18 | namespace Core { |
| 19 | 19 | ||
| 20 | void PerfStats::BeginSystemFrame() { | 20 | void PerfStats::BeginSystemFrame() { |
| 21 | std::lock_guard<std::mutex> lock(object_mutex); | 21 | std::lock_guard lock{object_mutex}; |
| 22 | 22 | ||
| 23 | frame_begin = Clock::now(); | 23 | frame_begin = Clock::now(); |
| 24 | } | 24 | } |
| 25 | 25 | ||
| 26 | void PerfStats::EndSystemFrame() { | 26 | void PerfStats::EndSystemFrame() { |
| 27 | std::lock_guard<std::mutex> lock(object_mutex); | 27 | std::lock_guard lock{object_mutex}; |
| 28 | 28 | ||
| 29 | auto frame_end = Clock::now(); | 29 | auto frame_end = Clock::now(); |
| 30 | accumulated_frametime += frame_end - frame_begin; | 30 | accumulated_frametime += frame_end - frame_begin; |
| @@ -35,13 +35,13 @@ void PerfStats::EndSystemFrame() { | |||
| 35 | } | 35 | } |
| 36 | 36 | ||
| 37 | void PerfStats::EndGameFrame() { | 37 | void PerfStats::EndGameFrame() { |
| 38 | std::lock_guard<std::mutex> lock(object_mutex); | 38 | std::lock_guard lock{object_mutex}; |
| 39 | 39 | ||
| 40 | game_frames += 1; | 40 | game_frames += 1; |
| 41 | } | 41 | } |
| 42 | 42 | ||
| 43 | PerfStatsResults PerfStats::GetAndResetStats(microseconds current_system_time_us) { | 43 | PerfStatsResults PerfStats::GetAndResetStats(microseconds current_system_time_us) { |
| 44 | std::lock_guard<std::mutex> lock(object_mutex); | 44 | std::lock_guard lock{object_mutex}; |
| 45 | 45 | ||
| 46 | const auto now = Clock::now(); | 46 | const auto now = Clock::now(); |
| 47 | // Walltime elapsed since stats were reset | 47 | // Walltime elapsed since stats were reset |
| @@ -67,7 +67,7 @@ PerfStatsResults PerfStats::GetAndResetStats(microseconds current_system_time_us | |||
| 67 | } | 67 | } |
| 68 | 68 | ||
| 69 | double PerfStats::GetLastFrameTimeScale() { | 69 | double PerfStats::GetLastFrameTimeScale() { |
| 70 | std::lock_guard<std::mutex> lock(object_mutex); | 70 | std::lock_guard lock{object_mutex}; |
| 71 | 71 | ||
| 72 | constexpr double FRAME_LENGTH = 1.0 / 60; | 72 | constexpr double FRAME_LENGTH = 1.0 / 60; |
| 73 | return duration_cast<DoubleSecs>(previous_frame_length).count() / FRAME_LENGTH; | 73 | return duration_cast<DoubleSecs>(previous_frame_length).count() / FRAME_LENGTH; |
diff --git a/src/core/settings.cpp b/src/core/settings.cpp index 6dd3139cc..6d32ebea3 100644 --- a/src/core/settings.cpp +++ b/src/core/settings.cpp | |||
| @@ -82,7 +82,6 @@ void LogSetting(const std::string& name, const T& value) { | |||
| 82 | void LogSettings() { | 82 | void LogSettings() { |
| 83 | LOG_INFO(Config, "yuzu Configuration:"); | 83 | LOG_INFO(Config, "yuzu Configuration:"); |
| 84 | LogSetting("System_UseDockedMode", Settings::values.use_docked_mode); | 84 | LogSetting("System_UseDockedMode", Settings::values.use_docked_mode); |
| 85 | LogSetting("System_EnableNfc", Settings::values.enable_nfc); | ||
| 86 | LogSetting("System_RngSeed", Settings::values.rng_seed.value_or(0)); | 85 | LogSetting("System_RngSeed", Settings::values.rng_seed.value_or(0)); |
| 87 | LogSetting("System_CurrentUser", Settings::values.current_user); | 86 | LogSetting("System_CurrentUser", Settings::values.current_user); |
| 88 | LogSetting("System_LanguageIndex", Settings::values.language_index); | 87 | LogSetting("System_LanguageIndex", Settings::values.language_index); |
diff --git a/src/core/settings.h b/src/core/settings.h index cdfb2f742..d543eb32f 100644 --- a/src/core/settings.h +++ b/src/core/settings.h | |||
| @@ -349,7 +349,6 @@ struct TouchscreenInput { | |||
| 349 | struct Values { | 349 | struct Values { |
| 350 | // System | 350 | // System |
| 351 | bool use_docked_mode; | 351 | bool use_docked_mode; |
| 352 | bool enable_nfc; | ||
| 353 | std::optional<u32> rng_seed; | 352 | std::optional<u32> rng_seed; |
| 354 | // Measured in seconds since epoch | 353 | // Measured in seconds since epoch |
| 355 | std::optional<std::chrono::seconds> custom_rtc; | 354 | std::optional<std::chrono::seconds> custom_rtc; |