diff options
Diffstat (limited to 'src/core')
| -rw-r--r-- | src/core/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | src/core/file_sys/program_metadata.cpp | 2 | ||||
| -rw-r--r-- | src/core/hid/emulated_controller.cpp | 22 | ||||
| -rw-r--r-- | src/core/hle/kernel/svc.cpp | 4 | ||||
| -rw-r--r-- | src/core/hle/service/am/applets/applets.h | 2 | ||||
| -rw-r--r-- | src/core/hle/service/hid/controllers/npad.cpp | 20 |
6 files changed, 26 insertions, 25 deletions
diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index 72da9cb56..113e663b5 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt | |||
| @@ -774,6 +774,7 @@ if (MSVC) | |||
| 774 | /we4244 # 'conversion': conversion from 'type1' to 'type2', possible loss of data | 774 | /we4244 # 'conversion': conversion from 'type1' to 'type2', possible loss of data |
| 775 | /we4245 # 'conversion': conversion from 'type1' to 'type2', signed/unsigned mismatch | 775 | /we4245 # 'conversion': conversion from 'type1' to 'type2', signed/unsigned mismatch |
| 776 | /we4254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data | 776 | /we4254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data |
| 777 | /we4800 # Implicit conversion from 'type' to bool. Possible information loss | ||
| 777 | ) | 778 | ) |
| 778 | else() | 779 | else() |
| 779 | target_compile_options(core PRIVATE | 780 | target_compile_options(core PRIVATE |
diff --git a/src/core/file_sys/program_metadata.cpp b/src/core/file_sys/program_metadata.cpp index 08d489eab..f00479bd3 100644 --- a/src/core/file_sys/program_metadata.cpp +++ b/src/core/file_sys/program_metadata.cpp | |||
| @@ -127,7 +127,7 @@ void ProgramMetadata::LoadManual(bool is_64_bit, ProgramAddressSpaceType address | |||
| 127 | } | 127 | } |
| 128 | 128 | ||
| 129 | bool ProgramMetadata::Is64BitProgram() const { | 129 | bool ProgramMetadata::Is64BitProgram() const { |
| 130 | return npdm_header.has_64_bit_instructions; | 130 | return npdm_header.has_64_bit_instructions.As<bool>(); |
| 131 | } | 131 | } |
| 132 | 132 | ||
| 133 | ProgramAddressSpaceType ProgramMetadata::GetAddressSpaceType() const { | 133 | ProgramAddressSpaceType ProgramMetadata::GetAddressSpaceType() const { |
diff --git a/src/core/hid/emulated_controller.cpp b/src/core/hid/emulated_controller.cpp index 025f1c78e..57eff72fe 100644 --- a/src/core/hid/emulated_controller.cpp +++ b/src/core/hid/emulated_controller.cpp | |||
| @@ -1158,27 +1158,27 @@ bool EmulatedController::IsControllerSupported(bool use_temporary_value) const { | |||
| 1158 | const auto type = is_configuring && use_temporary_value ? tmp_npad_type : npad_type; | 1158 | const auto type = is_configuring && use_temporary_value ? tmp_npad_type : npad_type; |
| 1159 | switch (type) { | 1159 | switch (type) { |
| 1160 | case NpadStyleIndex::ProController: | 1160 | case NpadStyleIndex::ProController: |
| 1161 | return supported_style_tag.fullkey; | 1161 | return supported_style_tag.fullkey.As<bool>(); |
| 1162 | case NpadStyleIndex::Handheld: | 1162 | case NpadStyleIndex::Handheld: |
| 1163 | return supported_style_tag.handheld; | 1163 | return supported_style_tag.handheld.As<bool>(); |
| 1164 | case NpadStyleIndex::JoyconDual: | 1164 | case NpadStyleIndex::JoyconDual: |
| 1165 | return supported_style_tag.joycon_dual; | 1165 | return supported_style_tag.joycon_dual.As<bool>(); |
| 1166 | case NpadStyleIndex::JoyconLeft: | 1166 | case NpadStyleIndex::JoyconLeft: |
| 1167 | return supported_style_tag.joycon_left; | 1167 | return supported_style_tag.joycon_left.As<bool>(); |
| 1168 | case NpadStyleIndex::JoyconRight: | 1168 | case NpadStyleIndex::JoyconRight: |
| 1169 | return supported_style_tag.joycon_right; | 1169 | return supported_style_tag.joycon_right.As<bool>(); |
| 1170 | case NpadStyleIndex::GameCube: | 1170 | case NpadStyleIndex::GameCube: |
| 1171 | return supported_style_tag.gamecube; | 1171 | return supported_style_tag.gamecube.As<bool>(); |
| 1172 | case NpadStyleIndex::Pokeball: | 1172 | case NpadStyleIndex::Pokeball: |
| 1173 | return supported_style_tag.palma; | 1173 | return supported_style_tag.palma.As<bool>(); |
| 1174 | case NpadStyleIndex::NES: | 1174 | case NpadStyleIndex::NES: |
| 1175 | return supported_style_tag.lark; | 1175 | return supported_style_tag.lark.As<bool>(); |
| 1176 | case NpadStyleIndex::SNES: | 1176 | case NpadStyleIndex::SNES: |
| 1177 | return supported_style_tag.lucia; | 1177 | return supported_style_tag.lucia.As<bool>(); |
| 1178 | case NpadStyleIndex::N64: | 1178 | case NpadStyleIndex::N64: |
| 1179 | return supported_style_tag.lagoon; | 1179 | return supported_style_tag.lagoon.As<bool>(); |
| 1180 | case NpadStyleIndex::SegaGenesis: | 1180 | case NpadStyleIndex::SegaGenesis: |
| 1181 | return supported_style_tag.lager; | 1181 | return supported_style_tag.lager.As<bool>(); |
| 1182 | default: | 1182 | default: |
| 1183 | return false; | 1183 | return false; |
| 1184 | } | 1184 | } |
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp index b07ae3f02..4aca5b27d 100644 --- a/src/core/hle/kernel/svc.cpp +++ b/src/core/hle/kernel/svc.cpp | |||
| @@ -751,8 +751,8 @@ static void Break(Core::System& system, u32 reason, u64 info1, u64 info2) { | |||
| 751 | } | 751 | } |
| 752 | 752 | ||
| 753 | system.GetReporter().SaveSvcBreakReport( | 753 | system.GetReporter().SaveSvcBreakReport( |
| 754 | static_cast<u32>(break_reason.break_type.Value()), break_reason.signal_debugger, info1, | 754 | static_cast<u32>(break_reason.break_type.Value()), break_reason.signal_debugger.As<bool>(), |
| 755 | info2, has_dumped_buffer ? std::make_optional(debug_buffer) : std::nullopt); | 755 | info1, info2, has_dumped_buffer ? std::make_optional(debug_buffer) : std::nullopt); |
| 756 | 756 | ||
| 757 | if (!break_reason.signal_debugger) { | 757 | if (!break_reason.signal_debugger) { |
| 758 | LOG_CRITICAL( | 758 | LOG_CRITICAL( |
diff --git a/src/core/hle/service/am/applets/applets.h b/src/core/hle/service/am/applets/applets.h index e78a57657..12c6a5b1a 100644 --- a/src/core/hle/service/am/applets/applets.h +++ b/src/core/hle/service/am/applets/applets.h | |||
| @@ -164,7 +164,7 @@ protected: | |||
| 164 | u32_le size; | 164 | u32_le size; |
| 165 | u32_le library_version; | 165 | u32_le library_version; |
| 166 | u32_le theme_color; | 166 | u32_le theme_color; |
| 167 | u8 play_startup_sound; | 167 | bool play_startup_sound; |
| 168 | u64_le system_tick; | 168 | u64_le system_tick; |
| 169 | }; | 169 | }; |
| 170 | static_assert(sizeof(CommonArguments) == 0x20, "CommonArguments has incorrect size."); | 170 | static_assert(sizeof(CommonArguments) == 0x20, "CommonArguments has incorrect size."); |
diff --git a/src/core/hle/service/hid/controllers/npad.cpp b/src/core/hle/service/hid/controllers/npad.cpp index ba8a1f786..3b26e96de 100644 --- a/src/core/hle/service/hid/controllers/npad.cpp +++ b/src/core/hle/service/hid/controllers/npad.cpp | |||
| @@ -1502,25 +1502,25 @@ bool Controller_NPad::IsControllerSupported(Core::HID::NpadStyleIndex controller | |||
| 1502 | Core::HID::NpadStyleTag style = GetSupportedStyleSet(); | 1502 | Core::HID::NpadStyleTag style = GetSupportedStyleSet(); |
| 1503 | switch (controller) { | 1503 | switch (controller) { |
| 1504 | case Core::HID::NpadStyleIndex::ProController: | 1504 | case Core::HID::NpadStyleIndex::ProController: |
| 1505 | return style.fullkey; | 1505 | return style.fullkey.As<bool>(); |
| 1506 | case Core::HID::NpadStyleIndex::JoyconDual: | 1506 | case Core::HID::NpadStyleIndex::JoyconDual: |
| 1507 | return style.joycon_dual; | 1507 | return style.joycon_dual.As<bool>(); |
| 1508 | case Core::HID::NpadStyleIndex::JoyconLeft: | 1508 | case Core::HID::NpadStyleIndex::JoyconLeft: |
| 1509 | return style.joycon_left; | 1509 | return style.joycon_left.As<bool>(); |
| 1510 | case Core::HID::NpadStyleIndex::JoyconRight: | 1510 | case Core::HID::NpadStyleIndex::JoyconRight: |
| 1511 | return style.joycon_right; | 1511 | return style.joycon_right.As<bool>(); |
| 1512 | case Core::HID::NpadStyleIndex::GameCube: | 1512 | case Core::HID::NpadStyleIndex::GameCube: |
| 1513 | return style.gamecube; | 1513 | return style.gamecube.As<bool>(); |
| 1514 | case Core::HID::NpadStyleIndex::Pokeball: | 1514 | case Core::HID::NpadStyleIndex::Pokeball: |
| 1515 | return style.palma; | 1515 | return style.palma.As<bool>(); |
| 1516 | case Core::HID::NpadStyleIndex::NES: | 1516 | case Core::HID::NpadStyleIndex::NES: |
| 1517 | return style.lark; | 1517 | return style.lark.As<bool>(); |
| 1518 | case Core::HID::NpadStyleIndex::SNES: | 1518 | case Core::HID::NpadStyleIndex::SNES: |
| 1519 | return style.lucia; | 1519 | return style.lucia.As<bool>(); |
| 1520 | case Core::HID::NpadStyleIndex::N64: | 1520 | case Core::HID::NpadStyleIndex::N64: |
| 1521 | return style.lagoon; | 1521 | return style.lagoon.As<bool>(); |
| 1522 | case Core::HID::NpadStyleIndex::SegaGenesis: | 1522 | case Core::HID::NpadStyleIndex::SegaGenesis: |
| 1523 | return style.lager; | 1523 | return style.lager.As<bool>(); |
| 1524 | default: | 1524 | default: |
| 1525 | return false; | 1525 | return false; |
| 1526 | } | 1526 | } |