diff options
Diffstat (limited to 'src/core')
| -rw-r--r-- | src/core/file_sys/vfs.cpp | 8 | ||||
| -rw-r--r-- | src/core/file_sys/vfs_real.cpp | 8 | ||||
| -rw-r--r-- | src/core/hle/service/filesystem/filesystem.cpp | 6 |
3 files changed, 5 insertions, 17 deletions
diff --git a/src/core/file_sys/vfs.cpp b/src/core/file_sys/vfs.cpp index 639842401..b7105c8ff 100644 --- a/src/core/file_sys/vfs.cpp +++ b/src/core/file_sys/vfs.cpp | |||
| @@ -201,8 +201,6 @@ std::string VfsFile::GetFullPath() const { | |||
| 201 | 201 | ||
| 202 | VirtualFile VfsDirectory::GetFileRelative(std::string_view path) const { | 202 | VirtualFile VfsDirectory::GetFileRelative(std::string_view path) const { |
| 203 | auto vec = Common::FS::SplitPathComponents(path); | 203 | auto vec = Common::FS::SplitPathComponents(path); |
| 204 | vec.erase(std::remove_if(vec.begin(), vec.end(), [](const auto& str) { return str.empty(); }), | ||
| 205 | vec.end()); | ||
| 206 | if (vec.empty()) { | 204 | if (vec.empty()) { |
| 207 | return nullptr; | 205 | return nullptr; |
| 208 | } | 206 | } |
| @@ -237,8 +235,6 @@ VirtualFile VfsDirectory::GetFileAbsolute(std::string_view path) const { | |||
| 237 | 235 | ||
| 238 | VirtualDir VfsDirectory::GetDirectoryRelative(std::string_view path) const { | 236 | VirtualDir VfsDirectory::GetDirectoryRelative(std::string_view path) const { |
| 239 | auto vec = Common::FS::SplitPathComponents(path); | 237 | auto vec = Common::FS::SplitPathComponents(path); |
| 240 | vec.erase(std::remove_if(vec.begin(), vec.end(), [](const auto& str) { return str.empty(); }), | ||
| 241 | vec.end()); | ||
| 242 | if (vec.empty()) { | 238 | if (vec.empty()) { |
| 243 | // TODO(DarkLordZach): Return this directory if path is '/' or similar. Can't currently | 239 | // TODO(DarkLordZach): Return this directory if path is '/' or similar. Can't currently |
| 244 | // because of const-ness | 240 | // because of const-ness |
| @@ -303,8 +299,6 @@ std::size_t VfsDirectory::GetSize() const { | |||
| 303 | 299 | ||
| 304 | VirtualFile VfsDirectory::CreateFileRelative(std::string_view path) { | 300 | VirtualFile VfsDirectory::CreateFileRelative(std::string_view path) { |
| 305 | auto vec = Common::FS::SplitPathComponents(path); | 301 | auto vec = Common::FS::SplitPathComponents(path); |
| 306 | vec.erase(std::remove_if(vec.begin(), vec.end(), [](const auto& str) { return str.empty(); }), | ||
| 307 | vec.end()); | ||
| 308 | if (vec.empty()) { | 302 | if (vec.empty()) { |
| 309 | return nullptr; | 303 | return nullptr; |
| 310 | } | 304 | } |
| @@ -334,8 +328,6 @@ VirtualFile VfsDirectory::CreateFileAbsolute(std::string_view path) { | |||
| 334 | 328 | ||
| 335 | VirtualDir VfsDirectory::CreateDirectoryRelative(std::string_view path) { | 329 | VirtualDir VfsDirectory::CreateDirectoryRelative(std::string_view path) { |
| 336 | auto vec = Common::FS::SplitPathComponents(path); | 330 | auto vec = Common::FS::SplitPathComponents(path); |
| 337 | vec.erase(std::remove_if(vec.begin(), vec.end(), [](const auto& str) { return str.empty(); }), | ||
| 338 | vec.end()); | ||
| 339 | if (vec.empty()) { | 331 | if (vec.empty()) { |
| 340 | return nullptr; | 332 | return nullptr; |
| 341 | } | 333 | } |
diff --git a/src/core/file_sys/vfs_real.cpp b/src/core/file_sys/vfs_real.cpp index 1c706e4d8..cd9b79786 100644 --- a/src/core/file_sys/vfs_real.cpp +++ b/src/core/file_sys/vfs_real.cpp | |||
| @@ -268,7 +268,7 @@ void RealVfsFilesystem::RemoveReferenceFromListLocked(FileReference& reference) | |||
| 268 | RealVfsFile::RealVfsFile(RealVfsFilesystem& base_, std::unique_ptr<FileReference> reference_, | 268 | RealVfsFile::RealVfsFile(RealVfsFilesystem& base_, std::unique_ptr<FileReference> reference_, |
| 269 | const std::string& path_, Mode perms_, std::optional<u64> size_) | 269 | const std::string& path_, Mode perms_, std::optional<u64> size_) |
| 270 | : base(base_), reference(std::move(reference_)), path(path_), | 270 | : base(base_), reference(std::move(reference_)), path(path_), |
| 271 | parent_path(FS::GetParentPath(path_)), path_components(FS::SplitPathComponents(path_)), | 271 | parent_path(FS::GetParentPath(path_)), path_components(FS::SplitPathComponentsCopy(path_)), |
| 272 | size(size_), perms(perms_) {} | 272 | size(size_), perms(perms_) {} |
| 273 | 273 | ||
| 274 | RealVfsFile::~RealVfsFile() { | 274 | RealVfsFile::~RealVfsFile() { |
| @@ -276,7 +276,7 @@ RealVfsFile::~RealVfsFile() { | |||
| 276 | } | 276 | } |
| 277 | 277 | ||
| 278 | std::string RealVfsFile::GetName() const { | 278 | std::string RealVfsFile::GetName() const { |
| 279 | return path_components.back(); | 279 | return path_components.empty() ? "" : std::string(path_components.back()); |
| 280 | } | 280 | } |
| 281 | 281 | ||
| 282 | std::size_t RealVfsFile::GetSize() const { | 282 | std::size_t RealVfsFile::GetSize() const { |
| @@ -375,7 +375,7 @@ std::vector<VirtualDir> RealVfsDirectory::IterateEntries<RealVfsDirectory, VfsDi | |||
| 375 | 375 | ||
| 376 | RealVfsDirectory::RealVfsDirectory(RealVfsFilesystem& base_, const std::string& path_, Mode perms_) | 376 | RealVfsDirectory::RealVfsDirectory(RealVfsFilesystem& base_, const std::string& path_, Mode perms_) |
| 377 | : base(base_), path(FS::RemoveTrailingSlash(path_)), parent_path(FS::GetParentPath(path)), | 377 | : base(base_), path(FS::RemoveTrailingSlash(path_)), parent_path(FS::GetParentPath(path)), |
| 378 | path_components(FS::SplitPathComponents(path)), perms(perms_) { | 378 | path_components(FS::SplitPathComponentsCopy(path)), perms(perms_) { |
| 379 | if (!FS::Exists(path) && True(perms & Mode::Write)) { | 379 | if (!FS::Exists(path) && True(perms & Mode::Write)) { |
| 380 | void(FS::CreateDirs(path)); | 380 | void(FS::CreateDirs(path)); |
| 381 | } | 381 | } |
| @@ -464,7 +464,7 @@ bool RealVfsDirectory::IsReadable() const { | |||
| 464 | } | 464 | } |
| 465 | 465 | ||
| 466 | std::string RealVfsDirectory::GetName() const { | 466 | std::string RealVfsDirectory::GetName() const { |
| 467 | return path_components.back(); | 467 | return path_components.empty() ? "" : std::string(path_components.back()); |
| 468 | } | 468 | } |
| 469 | 469 | ||
| 470 | VirtualDir RealVfsDirectory::GetParentDirectory() const { | 470 | VirtualDir RealVfsDirectory::GetParentDirectory() const { |
diff --git a/src/core/hle/service/filesystem/filesystem.cpp b/src/core/hle/service/filesystem/filesystem.cpp index 508db7360..780f8c74d 100644 --- a/src/core/hle/service/filesystem/filesystem.cpp +++ b/src/core/hle/service/filesystem/filesystem.cpp | |||
| @@ -104,11 +104,7 @@ Result VfsDirectoryServiceWrapper::CreateDirectory(const std::string& path_) con | |||
| 104 | const auto components = Common::FS::SplitPathComponents(path); | 104 | const auto components = Common::FS::SplitPathComponents(path); |
| 105 | std::string relative_path; | 105 | std::string relative_path; |
| 106 | for (const auto& component : components) { | 106 | for (const auto& component : components) { |
| 107 | // Skip empty path components | 107 | relative_path = Common::FS::SanitizePath(fmt::format("{}/{}", relative_path, component)); |
| 108 | if (component.empty()) { | ||
| 109 | continue; | ||
| 110 | } | ||
| 111 | relative_path = Common::FS::SanitizePath(relative_path + '/' + component); | ||
| 112 | auto new_dir = backing->CreateSubdirectory(relative_path); | 108 | auto new_dir = backing->CreateSubdirectory(relative_path); |
| 113 | if (new_dir == nullptr) { | 109 | if (new_dir == nullptr) { |
| 114 | // TODO(DarkLordZach): Find a better error code for this | 110 | // TODO(DarkLordZach): Find a better error code for this |