diff options
Diffstat (limited to 'src/core/loader/nso.cpp')
| -rw-r--r-- | src/core/loader/nso.cpp | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/src/core/loader/nso.cpp b/src/core/loader/nso.cpp index ba57db9bf..d26fa482c 100644 --- a/src/core/loader/nso.cpp +++ b/src/core/loader/nso.cpp | |||
| @@ -93,17 +93,14 @@ static constexpr u32 PageAlignSize(u32 size) { | |||
| 93 | return (size + Memory::PAGE_MASK) & ~Memory::PAGE_MASK; | 93 | return (size + Memory::PAGE_MASK) & ~Memory::PAGE_MASK; |
| 94 | } | 94 | } |
| 95 | 95 | ||
| 96 | VAddr AppLoader_NSO::LoadModule(FileSys::VirtualFile file, VAddr load_base, | 96 | VAddr AppLoader_NSO::LoadModule(const FileSys::VfsFile& file, VAddr load_base, |
| 97 | bool should_pass_arguments, | 97 | bool should_pass_arguments, |
| 98 | boost::optional<FileSys::PatchManager> pm) { | 98 | boost::optional<FileSys::PatchManager> pm) { |
| 99 | if (file == nullptr) | 99 | if (file.GetSize() < sizeof(NsoHeader)) |
| 100 | return {}; | ||
| 101 | |||
| 102 | if (file->GetSize() < sizeof(NsoHeader)) | ||
| 103 | return {}; | 100 | return {}; |
| 104 | 101 | ||
| 105 | NsoHeader nso_header{}; | 102 | NsoHeader nso_header{}; |
| 106 | if (sizeof(NsoHeader) != file->ReadObject(&nso_header)) | 103 | if (sizeof(NsoHeader) != file.ReadObject(&nso_header)) |
| 107 | return {}; | 104 | return {}; |
| 108 | 105 | ||
| 109 | if (nso_header.magic != Common::MakeMagic('N', 'S', 'O', '0')) | 106 | if (nso_header.magic != Common::MakeMagic('N', 'S', 'O', '0')) |
| @@ -114,7 +111,7 @@ VAddr AppLoader_NSO::LoadModule(FileSys::VirtualFile file, VAddr load_base, | |||
| 114 | std::vector<u8> program_image; | 111 | std::vector<u8> program_image; |
| 115 | for (std::size_t i = 0; i < nso_header.segments.size(); ++i) { | 112 | for (std::size_t i = 0; i < nso_header.segments.size(); ++i) { |
| 116 | std::vector<u8> data = | 113 | std::vector<u8> data = |
| 117 | file->ReadBytes(nso_header.segments_compressed_size[i], nso_header.segments[i].offset); | 114 | file.ReadBytes(nso_header.segments_compressed_size[i], nso_header.segments[i].offset); |
| 118 | if (nso_header.IsSegmentCompressed(i)) { | 115 | if (nso_header.IsSegmentCompressed(i)) { |
| 119 | data = DecompressSegment(data, nso_header.segments[i]); | 116 | data = DecompressSegment(data, nso_header.segments[i]); |
| 120 | } | 117 | } |
| @@ -172,7 +169,7 @@ VAddr AppLoader_NSO::LoadModule(FileSys::VirtualFile file, VAddr load_base, | |||
| 172 | Core::CurrentProcess()->LoadModule(std::move(codeset), load_base); | 169 | Core::CurrentProcess()->LoadModule(std::move(codeset), load_base); |
| 173 | 170 | ||
| 174 | // Register module with GDBStub | 171 | // Register module with GDBStub |
| 175 | GDBStub::RegisterModule(file->GetName(), load_base, load_base); | 172 | GDBStub::RegisterModule(file.GetName(), load_base, load_base); |
| 176 | 173 | ||
| 177 | return load_base + image_size; | 174 | return load_base + image_size; |
| 178 | } | 175 | } |
| @@ -184,7 +181,7 @@ ResultStatus AppLoader_NSO::Load(Kernel::Process& process) { | |||
| 184 | 181 | ||
| 185 | // Load module | 182 | // Load module |
| 186 | const VAddr base_address = process.VMManager().GetCodeRegionBaseAddress(); | 183 | const VAddr base_address = process.VMManager().GetCodeRegionBaseAddress(); |
| 187 | LoadModule(file, base_address, true); | 184 | LoadModule(*file, base_address, true); |
| 188 | LOG_DEBUG(Loader, "loaded module {} @ 0x{:X}", file->GetName(), base_address); | 185 | LOG_DEBUG(Loader, "loaded module {} @ 0x{:X}", file->GetName(), base_address); |
| 189 | 186 | ||
| 190 | process.Run(base_address, Kernel::THREADPRIO_DEFAULT, Memory::DEFAULT_STACK_SIZE); | 187 | process.Run(base_address, Kernel::THREADPRIO_DEFAULT, Memory::DEFAULT_STACK_SIZE); |