summaryrefslogtreecommitdiff
path: root/src/core/loader/elf.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'src/core/loader/elf.cpp')
-rw-r--r--src/core/loader/elf.cpp24
1 files changed, 7 insertions, 17 deletions
diff --git a/src/core/loader/elf.cpp b/src/core/loader/elf.cpp
index b69e5c6ef..4bfd5f536 100644
--- a/src/core/loader/elf.cpp
+++ b/src/core/loader/elf.cpp
@@ -365,20 +365,17 @@ SectionID ElfReader::GetSectionByName(const char* name, int firstSection) const
365 365
366namespace Loader { 366namespace Loader {
367 367
368AppLoader_ELF::AppLoader_ELF(FileUtil::IOFile&& file, std::string filename) 368AppLoader_ELF::AppLoader_ELF(FileSys::VirtualFile file) : AppLoader(std::move(file)) {}
369 : AppLoader(std::move(file)), filename(std::move(filename)) {}
370 369
371FileType AppLoader_ELF::IdentifyType(FileUtil::IOFile& file, const std::string&) { 370FileType AppLoader_ELF::IdentifyType(const FileSys::VirtualFile& file) {
372 static constexpr u16 ELF_MACHINE_ARM{0x28}; 371 static constexpr u16 ELF_MACHINE_ARM{0x28};
373 372
374 u32 magic = 0; 373 u32 magic = 0;
375 file.Seek(0, SEEK_SET); 374 if (4 != file->ReadObject(&magic))
376 if (1 != file.ReadArray<u32>(&magic, 1))
377 return FileType::Error; 375 return FileType::Error;
378 376
379 u16 machine = 0; 377 u16 machine = 0;
380 file.Seek(18, SEEK_SET); 378 if (2 != file->ReadObject(&machine, 18))
381 if (1 != file.ReadArray<u16>(&machine, 1))
382 return FileType::Error; 379 return FileType::Error;
383 380
384 if (Common::MakeMagic('\x7f', 'E', 'L', 'F') == magic && ELF_MACHINE_ARM == machine) 381 if (Common::MakeMagic('\x7f', 'E', 'L', 'F') == magic && ELF_MACHINE_ARM == machine)
@@ -391,20 +388,13 @@ ResultStatus AppLoader_ELF::Load(Kernel::SharedPtr<Kernel::Process>& process) {
391 if (is_loaded) 388 if (is_loaded)
392 return ResultStatus::ErrorAlreadyLoaded; 389 return ResultStatus::ErrorAlreadyLoaded;
393 390
394 if (!file.IsOpen()) 391 std::vector<u8> buffer = file->ReadAllBytes();
395 return ResultStatus::Error; 392 if (buffer.size() != file->GetSize())
396
397 // Reset read pointer in case this file has been read before.
398 file.Seek(0, SEEK_SET);
399
400 size_t size = file.GetSize();
401 std::unique_ptr<u8[]> buffer(new u8[size]);
402 if (file.ReadBytes(&buffer[0], size) != size)
403 return ResultStatus::Error; 393 return ResultStatus::Error;
404 394
405 ElfReader elf_reader(&buffer[0]); 395 ElfReader elf_reader(&buffer[0]);
406 SharedPtr<CodeSet> codeset = elf_reader.LoadInto(Memory::PROCESS_IMAGE_VADDR); 396 SharedPtr<CodeSet> codeset = elf_reader.LoadInto(Memory::PROCESS_IMAGE_VADDR);
407 codeset->name = filename; 397 codeset->name = file->GetName();
408 398
409 process->LoadModule(codeset, codeset->entrypoint); 399 process->LoadModule(codeset, codeset->entrypoint);
410 process->svc_access_mask.set(); 400 process->svc_access_mask.set();