diff options
Diffstat (limited to 'src/common/input.h')
| -rw-r--r-- | src/common/input.h | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/src/common/input.h b/src/common/input.h index eaee0bdea..f775a4c01 100644 --- a/src/common/input.h +++ b/src/common/input.h | |||
| @@ -227,7 +227,7 @@ struct CallbackStatus { | |||
| 227 | 227 | ||
| 228 | // Triggered once every input change | 228 | // Triggered once every input change |
| 229 | struct InputCallback { | 229 | struct InputCallback { |
| 230 | std::function<void(CallbackStatus)> on_change; | 230 | std::function<void(const CallbackStatus&)> on_change; |
| 231 | }; | 231 | }; |
| 232 | 232 | ||
| 233 | /// An abstract class template for an input device (a button, an analog input, etc.). | 233 | /// An abstract class template for an input device (a button, an analog input, etc.). |
| @@ -236,14 +236,10 @@ public: | |||
| 236 | virtual ~InputDevice() = default; | 236 | virtual ~InputDevice() = default; |
| 237 | 237 | ||
| 238 | // Request input device to update if necessary | 238 | // Request input device to update if necessary |
| 239 | virtual void SoftUpdate() { | 239 | virtual void SoftUpdate() {} |
| 240 | return; | ||
| 241 | } | ||
| 242 | 240 | ||
| 243 | // Force input device to update data regardless of the current state | 241 | // Force input device to update data regardless of the current state |
| 244 | virtual void ForceUpdate() { | 242 | virtual void ForceUpdate() {} |
| 245 | return; | ||
| 246 | } | ||
| 247 | 243 | ||
| 248 | // Sets the function to be triggered when input changes | 244 | // Sets the function to be triggered when input changes |
| 249 | void SetCallback(InputCallback callback_) { | 245 | void SetCallback(InputCallback callback_) { |
| @@ -251,7 +247,7 @@ public: | |||
| 251 | } | 247 | } |
| 252 | 248 | ||
| 253 | // Triggers the function set in the callback | 249 | // Triggers the function set in the callback |
| 254 | void TriggerOnChange(CallbackStatus status) { | 250 | void TriggerOnChange(const CallbackStatus& status) { |
| 255 | if (callback.on_change) { | 251 | if (callback.on_change) { |
| 256 | callback.on_change(status); | 252 | callback.on_change(status); |
| 257 | } | 253 | } |
| @@ -266,11 +262,9 @@ class OutputDevice { | |||
| 266 | public: | 262 | public: |
| 267 | virtual ~OutputDevice() = default; | 263 | virtual ~OutputDevice() = default; |
| 268 | 264 | ||
| 269 | virtual void SetLED([[maybe_unused]] LedStatus led_status) { | 265 | virtual void SetLED([[maybe_unused]] const LedStatus& led_status) {} |
| 270 | return; | ||
| 271 | } | ||
| 272 | 266 | ||
| 273 | virtual VibrationError SetVibration([[maybe_unused]] VibrationStatus vibration_status) { | 267 | virtual VibrationError SetVibration([[maybe_unused]] const VibrationStatus& vibration_status) { |
| 274 | return VibrationError::NotSupported; | 268 | return VibrationError::NotSupported; |
| 275 | } | 269 | } |
| 276 | 270 | ||