diff options
Diffstat (limited to 'src/citra_qt')
| -rw-r--r-- | src/citra_qt/CMakeLists.txt | 7 | ||||
| -rw-r--r-- | src/citra_qt/bootmanager.cpp | 15 | ||||
| -rw-r--r-- | src/citra_qt/debugger/graphics_breakpoints.cpp | 261 | ||||
| -rw-r--r-- | src/citra_qt/debugger/graphics_breakpoints.hxx | 53 | ||||
| -rw-r--r-- | src/citra_qt/debugger/graphics_breakpoints_p.hxx | 38 | ||||
| -rw-r--r-- | src/citra_qt/debugger/graphics_cmdlists.cpp | 241 | ||||
| -rw-r--r-- | src/citra_qt/debugger/graphics_cmdlists.hxx | 37 | ||||
| -rw-r--r-- | src/citra_qt/debugger/graphics_framebuffer.cpp | 282 | ||||
| -rw-r--r-- | src/citra_qt/debugger/graphics_framebuffer.hxx | 92 | ||||
| -rw-r--r-- | src/citra_qt/hotkeys.cpp | 4 | ||||
| -rw-r--r-- | src/citra_qt/main.cpp | 26 | ||||
| -rw-r--r-- | src/citra_qt/util/spinbox.cpp | 303 | ||||
| -rw-r--r-- | src/citra_qt/util/spinbox.hxx | 88 |
13 files changed, 1418 insertions, 29 deletions
diff --git a/src/citra_qt/CMakeLists.txt b/src/citra_qt/CMakeLists.txt index 98a48a69a..90e5c6aa6 100644 --- a/src/citra_qt/CMakeLists.txt +++ b/src/citra_qt/CMakeLists.txt | |||
| @@ -8,9 +8,12 @@ set(SRCS | |||
| 8 | debugger/callstack.cpp | 8 | debugger/callstack.cpp |
| 9 | debugger/disassembler.cpp | 9 | debugger/disassembler.cpp |
| 10 | debugger/graphics.cpp | 10 | debugger/graphics.cpp |
| 11 | debugger/graphics_breakpoints.cpp | ||
| 11 | debugger/graphics_cmdlists.cpp | 12 | debugger/graphics_cmdlists.cpp |
| 13 | debugger/graphics_framebuffer.cpp | ||
| 12 | debugger/ramview.cpp | 14 | debugger/ramview.cpp |
| 13 | debugger/registers.cpp | 15 | debugger/registers.cpp |
| 16 | util/spinbox.cpp | ||
| 14 | bootmanager.cpp | 17 | bootmanager.cpp |
| 15 | hotkeys.cpp | 18 | hotkeys.cpp |
| 16 | main.cpp | 19 | main.cpp |
| @@ -23,9 +26,13 @@ set(HEADERS | |||
| 23 | debugger/callstack.hxx | 26 | debugger/callstack.hxx |
| 24 | debugger/disassembler.hxx | 27 | debugger/disassembler.hxx |
| 25 | debugger/graphics.hxx | 28 | debugger/graphics.hxx |
| 29 | debugger/graphics_breakpoints.hxx | ||
| 30 | debugger/graphics_breakpoints_p.hxx | ||
| 26 | debugger/graphics_cmdlists.hxx | 31 | debugger/graphics_cmdlists.hxx |
| 32 | debugger/graphics_framebuffer.hxx | ||
| 27 | debugger/ramview.hxx | 33 | debugger/ramview.hxx |
| 28 | debugger/registers.hxx | 34 | debugger/registers.hxx |
| 35 | util/spinbox.hxx | ||
| 29 | bootmanager.hxx | 36 | bootmanager.hxx |
| 30 | hotkeys.hxx | 37 | hotkeys.hxx |
| 31 | main.hxx | 38 | main.hxx |
diff --git a/src/citra_qt/bootmanager.cpp b/src/citra_qt/bootmanager.cpp index 9bf079919..b53206be6 100644 --- a/src/citra_qt/bootmanager.cpp +++ b/src/citra_qt/bootmanager.cpp | |||
| @@ -14,6 +14,8 @@ | |||
| 14 | #include "core/core.h" | 14 | #include "core/core.h" |
| 15 | #include "core/settings.h" | 15 | #include "core/settings.h" |
| 16 | 16 | ||
| 17 | #include "video_core/debug_utils/debug_utils.h" | ||
| 18 | |||
| 17 | #include "video_core/video_core.h" | 19 | #include "video_core/video_core.h" |
| 18 | 20 | ||
| 19 | #include "citra_qt/version.h" | 21 | #include "citra_qt/version.h" |
| @@ -65,14 +67,21 @@ void EmuThread::Stop() | |||
| 65 | } | 67 | } |
| 66 | stop_run = true; | 68 | stop_run = true; |
| 67 | 69 | ||
| 70 | // Release emu threads from any breakpoints, so that this doesn't hang forever. | ||
| 71 | Pica::g_debug_context->ClearBreakpoints(); | ||
| 72 | |||
| 68 | //core::g_state = core::SYS_DIE; | 73 | //core::g_state = core::SYS_DIE; |
| 69 | 74 | ||
| 70 | wait(500); | 75 | // TODO: Waiting here is just a bad workaround for retarded shutdown logic. |
| 76 | wait(1000); | ||
| 71 | if (isRunning()) | 77 | if (isRunning()) |
| 72 | { | 78 | { |
| 73 | WARN_LOG(MASTER_LOG, "EmuThread still running, terminating..."); | 79 | WARN_LOG(MASTER_LOG, "EmuThread still running, terminating..."); |
| 74 | quit(); | 80 | quit(); |
| 75 | wait(1000); | 81 | |
| 82 | // TODO: Waiting 50 seconds can be necessary if the logging subsystem has a lot of spam | ||
| 83 | // queued... This should be fixed. | ||
| 84 | wait(50000); | ||
| 76 | if (isRunning()) | 85 | if (isRunning()) |
| 77 | { | 86 | { |
| 78 | WARN_LOG(MASTER_LOG, "EmuThread STILL running, something is wrong here..."); | 87 | WARN_LOG(MASTER_LOG, "EmuThread STILL running, something is wrong here..."); |
| @@ -230,7 +239,7 @@ QByteArray GRenderWindow::saveGeometry() | |||
| 230 | { | 239 | { |
| 231 | // If we are a top-level widget, store the current geometry | 240 | // If we are a top-level widget, store the current geometry |
| 232 | // otherwise, store the last backup | 241 | // otherwise, store the last backup |
| 233 | if (parent() == NULL) | 242 | if (parent() == nullptr) |
| 234 | return ((QGLWidget*)this)->saveGeometry(); | 243 | return ((QGLWidget*)this)->saveGeometry(); |
| 235 | else | 244 | else |
| 236 | return geometry; | 245 | return geometry; |
diff --git a/src/citra_qt/debugger/graphics_breakpoints.cpp b/src/citra_qt/debugger/graphics_breakpoints.cpp new file mode 100644 index 000000000..df5579e15 --- /dev/null +++ b/src/citra_qt/debugger/graphics_breakpoints.cpp | |||
| @@ -0,0 +1,261 @@ | |||
| 1 | // Copyright 2014 Citra Emulator Project | ||
| 2 | // Licensed under GPLv2 | ||
| 3 | // Refer to the license.txt file included. | ||
| 4 | |||
| 5 | #include <QMetaType> | ||
| 6 | #include <QPushButton> | ||
| 7 | #include <QTreeWidget> | ||
| 8 | #include <QVBoxLayout> | ||
| 9 | #include <QLabel> | ||
| 10 | |||
| 11 | #include "graphics_breakpoints.hxx" | ||
| 12 | #include "graphics_breakpoints_p.hxx" | ||
| 13 | |||
| 14 | BreakPointModel::BreakPointModel(std::shared_ptr<Pica::DebugContext> debug_context, QObject* parent) | ||
| 15 | : QAbstractListModel(parent), context_weak(debug_context), | ||
| 16 | at_breakpoint(debug_context->at_breakpoint), | ||
| 17 | active_breakpoint(debug_context->active_breakpoint) | ||
| 18 | { | ||
| 19 | |||
| 20 | } | ||
| 21 | |||
| 22 | int BreakPointModel::columnCount(const QModelIndex& parent) const | ||
| 23 | { | ||
| 24 | return 2; | ||
| 25 | } | ||
| 26 | |||
| 27 | int BreakPointModel::rowCount(const QModelIndex& parent) const | ||
| 28 | { | ||
| 29 | return static_cast<int>(Pica::DebugContext::Event::NumEvents); | ||
| 30 | } | ||
| 31 | |||
| 32 | QVariant BreakPointModel::data(const QModelIndex& index, int role) const | ||
| 33 | { | ||
| 34 | const auto event = static_cast<Pica::DebugContext::Event>(index.row()); | ||
| 35 | |||
| 36 | switch (role) { | ||
| 37 | case Qt::DisplayRole: | ||
| 38 | { | ||
| 39 | switch (index.column()) { | ||
| 40 | case 0: | ||
| 41 | { | ||
| 42 | std::map<Pica::DebugContext::Event, QString> map; | ||
| 43 | map.insert({Pica::DebugContext::Event::CommandLoaded, tr("Pica command loaded")}); | ||
| 44 | map.insert({Pica::DebugContext::Event::CommandProcessed, tr("Pica command processed")}); | ||
| 45 | map.insert({Pica::DebugContext::Event::IncomingPrimitiveBatch, tr("Incoming primitive batch")}); | ||
| 46 | map.insert({Pica::DebugContext::Event::FinishedPrimitiveBatch, tr("Finished primitive batch")}); | ||
| 47 | |||
| 48 | _dbg_assert_(GUI, map.size() == static_cast<size_t>(Pica::DebugContext::Event::NumEvents)); | ||
| 49 | |||
| 50 | return map[event]; | ||
| 51 | } | ||
| 52 | |||
| 53 | case 1: | ||
| 54 | return data(index, Role_IsEnabled).toBool() ? tr("Enabled") : tr("Disabled"); | ||
| 55 | |||
| 56 | default: | ||
| 57 | break; | ||
| 58 | } | ||
| 59 | |||
| 60 | break; | ||
| 61 | } | ||
| 62 | |||
| 63 | case Qt::BackgroundRole: | ||
| 64 | { | ||
| 65 | if (at_breakpoint && index.row() == static_cast<int>(active_breakpoint)) { | ||
| 66 | return QBrush(QColor(0xE0, 0xE0, 0x10)); | ||
| 67 | } | ||
| 68 | break; | ||
| 69 | } | ||
| 70 | |||
| 71 | case Role_IsEnabled: | ||
| 72 | { | ||
| 73 | auto context = context_weak.lock(); | ||
| 74 | return context && context->breakpoints[event].enabled; | ||
| 75 | } | ||
| 76 | |||
| 77 | default: | ||
| 78 | break; | ||
| 79 | } | ||
| 80 | return QVariant(); | ||
| 81 | } | ||
| 82 | |||
| 83 | QVariant BreakPointModel::headerData(int section, Qt::Orientation orientation, int role) const | ||
| 84 | { | ||
| 85 | switch(role) { | ||
| 86 | case Qt::DisplayRole: | ||
| 87 | { | ||
| 88 | if (section == 0) { | ||
| 89 | return tr("Event"); | ||
| 90 | } else if (section == 1) { | ||
| 91 | return tr("Status"); | ||
| 92 | } | ||
| 93 | |||
| 94 | break; | ||
| 95 | } | ||
| 96 | } | ||
| 97 | |||
| 98 | return QVariant(); | ||
| 99 | } | ||
| 100 | |||
| 101 | bool BreakPointModel::setData(const QModelIndex& index, const QVariant& value, int role) | ||
| 102 | { | ||
| 103 | const auto event = static_cast<Pica::DebugContext::Event>(index.row()); | ||
| 104 | |||
| 105 | switch (role) { | ||
| 106 | case Role_IsEnabled: | ||
| 107 | { | ||
| 108 | auto context = context_weak.lock(); | ||
| 109 | if (!context) | ||
| 110 | return false; | ||
| 111 | |||
| 112 | context->breakpoints[event].enabled = value.toBool(); | ||
| 113 | QModelIndex changed_index = createIndex(index.row(), 1); | ||
| 114 | emit dataChanged(changed_index, changed_index); | ||
| 115 | return true; | ||
| 116 | } | ||
| 117 | } | ||
| 118 | |||
| 119 | return false; | ||
| 120 | } | ||
| 121 | |||
| 122 | |||
| 123 | void BreakPointModel::OnBreakPointHit(Pica::DebugContext::Event event) | ||
| 124 | { | ||
| 125 | auto context = context_weak.lock(); | ||
| 126 | if (!context) | ||
| 127 | return; | ||
| 128 | |||
| 129 | active_breakpoint = context->active_breakpoint; | ||
| 130 | at_breakpoint = context->at_breakpoint; | ||
| 131 | emit dataChanged(createIndex(static_cast<int>(event), 0), | ||
| 132 | createIndex(static_cast<int>(event), 1)); | ||
| 133 | } | ||
| 134 | |||
| 135 | void BreakPointModel::OnResumed() | ||
| 136 | { | ||
| 137 | auto context = context_weak.lock(); | ||
| 138 | if (!context) | ||
| 139 | return; | ||
| 140 | |||
| 141 | at_breakpoint = context->at_breakpoint; | ||
| 142 | emit dataChanged(createIndex(static_cast<int>(active_breakpoint), 0), | ||
| 143 | createIndex(static_cast<int>(active_breakpoint), 1)); | ||
| 144 | active_breakpoint = context->active_breakpoint; | ||
| 145 | } | ||
| 146 | |||
| 147 | |||
| 148 | GraphicsBreakPointsWidget::GraphicsBreakPointsWidget(std::shared_ptr<Pica::DebugContext> debug_context, | ||
| 149 | QWidget* parent) | ||
| 150 | : QDockWidget(tr("Pica Breakpoints"), parent), | ||
| 151 | Pica::DebugContext::BreakPointObserver(debug_context) | ||
| 152 | { | ||
| 153 | setObjectName("PicaBreakPointsWidget"); | ||
| 154 | |||
| 155 | status_text = new QLabel(tr("Emulation running")); | ||
| 156 | resume_button = new QPushButton(tr("Resume")); | ||
| 157 | resume_button->setEnabled(false); | ||
| 158 | |||
| 159 | breakpoint_model = new BreakPointModel(debug_context, this); | ||
| 160 | breakpoint_list = new QTreeView; | ||
| 161 | breakpoint_list->setModel(breakpoint_model); | ||
| 162 | |||
| 163 | toggle_breakpoint_button = new QPushButton(tr("Enable")); | ||
| 164 | toggle_breakpoint_button->setEnabled(false); | ||
| 165 | |||
| 166 | qRegisterMetaType<Pica::DebugContext::Event>("Pica::DebugContext::Event"); | ||
| 167 | |||
| 168 | connect(resume_button, SIGNAL(clicked()), this, SLOT(OnResumeRequested())); | ||
| 169 | |||
| 170 | connect(this, SIGNAL(BreakPointHit(Pica::DebugContext::Event,void*)), | ||
| 171 | this, SLOT(OnBreakPointHit(Pica::DebugContext::Event,void*)), | ||
| 172 | Qt::BlockingQueuedConnection); | ||
| 173 | connect(this, SIGNAL(Resumed()), this, SLOT(OnResumed())); | ||
| 174 | |||
| 175 | connect(this, SIGNAL(BreakPointHit(Pica::DebugContext::Event,void*)), | ||
| 176 | breakpoint_model, SLOT(OnBreakPointHit(Pica::DebugContext::Event)), | ||
| 177 | Qt::BlockingQueuedConnection); | ||
| 178 | connect(this, SIGNAL(Resumed()), breakpoint_model, SLOT(OnResumed())); | ||
| 179 | |||
| 180 | connect(this, SIGNAL(BreakPointsChanged(const QModelIndex&,const QModelIndex&)), | ||
| 181 | breakpoint_model, SIGNAL(dataChanged(const QModelIndex&,const QModelIndex&))); | ||
| 182 | |||
| 183 | connect(breakpoint_list->selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)), | ||
| 184 | this, SLOT(OnBreakpointSelectionChanged(QModelIndex))); | ||
| 185 | |||
| 186 | connect(toggle_breakpoint_button, SIGNAL(clicked()), this, SLOT(OnToggleBreakpointEnabled())); | ||
| 187 | |||
| 188 | QWidget* main_widget = new QWidget; | ||
| 189 | auto main_layout = new QVBoxLayout; | ||
| 190 | { | ||
| 191 | auto sub_layout = new QHBoxLayout; | ||
| 192 | sub_layout->addWidget(status_text); | ||
| 193 | sub_layout->addWidget(resume_button); | ||
| 194 | main_layout->addLayout(sub_layout); | ||
| 195 | } | ||
| 196 | main_layout->addWidget(breakpoint_list); | ||
| 197 | main_layout->addWidget(toggle_breakpoint_button); | ||
| 198 | main_widget->setLayout(main_layout); | ||
| 199 | |||
| 200 | setWidget(main_widget); | ||
| 201 | } | ||
| 202 | |||
| 203 | void GraphicsBreakPointsWidget::OnPicaBreakPointHit(Event event, void* data) | ||
| 204 | { | ||
| 205 | // Process in GUI thread | ||
| 206 | emit BreakPointHit(event, data); | ||
| 207 | } | ||
| 208 | |||
| 209 | void GraphicsBreakPointsWidget::OnBreakPointHit(Pica::DebugContext::Event event, void* data) | ||
| 210 | { | ||
| 211 | status_text->setText(tr("Emulation halted at breakpoint")); | ||
| 212 | resume_button->setEnabled(true); | ||
| 213 | } | ||
| 214 | |||
| 215 | void GraphicsBreakPointsWidget::OnPicaResume() | ||
| 216 | { | ||
| 217 | // Process in GUI thread | ||
| 218 | emit Resumed(); | ||
| 219 | } | ||
| 220 | |||
| 221 | void GraphicsBreakPointsWidget::OnResumed() | ||
| 222 | { | ||
| 223 | status_text->setText(tr("Emulation running")); | ||
| 224 | resume_button->setEnabled(false); | ||
| 225 | } | ||
| 226 | |||
| 227 | void GraphicsBreakPointsWidget::OnResumeRequested() | ||
| 228 | { | ||
| 229 | if (auto context = context_weak.lock()) | ||
| 230 | context->Resume(); | ||
| 231 | } | ||
| 232 | |||
| 233 | void GraphicsBreakPointsWidget::OnBreakpointSelectionChanged(const QModelIndex& index) | ||
| 234 | { | ||
| 235 | if (!index.isValid()) { | ||
| 236 | toggle_breakpoint_button->setEnabled(false); | ||
| 237 | return; | ||
| 238 | } | ||
| 239 | |||
| 240 | toggle_breakpoint_button->setEnabled(true); | ||
| 241 | UpdateToggleBreakpointButton(index); | ||
| 242 | } | ||
| 243 | |||
| 244 | void GraphicsBreakPointsWidget::OnToggleBreakpointEnabled() | ||
| 245 | { | ||
| 246 | QModelIndex index = breakpoint_list->selectionModel()->currentIndex(); | ||
| 247 | bool new_state = !(breakpoint_model->data(index, BreakPointModel::Role_IsEnabled).toBool()); | ||
| 248 | |||
| 249 | breakpoint_model->setData(index, new_state, | ||
| 250 | BreakPointModel::Role_IsEnabled); | ||
| 251 | UpdateToggleBreakpointButton(index); | ||
| 252 | } | ||
| 253 | |||
| 254 | void GraphicsBreakPointsWidget::UpdateToggleBreakpointButton(const QModelIndex& index) | ||
| 255 | { | ||
| 256 | if (true == breakpoint_model->data(index, BreakPointModel::Role_IsEnabled).toBool()) { | ||
| 257 | toggle_breakpoint_button->setText(tr("Disable")); | ||
| 258 | } else { | ||
| 259 | toggle_breakpoint_button->setText(tr("Enable")); | ||
| 260 | } | ||
| 261 | } | ||
diff --git a/src/citra_qt/debugger/graphics_breakpoints.hxx b/src/citra_qt/debugger/graphics_breakpoints.hxx new file mode 100644 index 000000000..2142c6fa1 --- /dev/null +++ b/src/citra_qt/debugger/graphics_breakpoints.hxx | |||
| @@ -0,0 +1,53 @@ | |||
| 1 | // Copyright 2014 Citra Emulator Project | ||
| 2 | // Licensed under GPLv2 | ||
| 3 | // Refer to the license.txt file included. | ||
| 4 | |||
| 5 | #pragma once | ||
| 6 | |||
| 7 | #include <memory> | ||
| 8 | |||
| 9 | #include <QAbstractListModel> | ||
| 10 | #include <QDockWidget> | ||
| 11 | |||
| 12 | #include "video_core/debug_utils/debug_utils.h" | ||
| 13 | |||
| 14 | class QLabel; | ||
| 15 | class QPushButton; | ||
| 16 | class QTreeView; | ||
| 17 | |||
| 18 | class BreakPointModel; | ||
| 19 | |||
| 20 | class GraphicsBreakPointsWidget : public QDockWidget, Pica::DebugContext::BreakPointObserver { | ||
| 21 | Q_OBJECT | ||
| 22 | |||
| 23 | using Event = Pica::DebugContext::Event; | ||
| 24 | |||
| 25 | public: | ||
| 26 | GraphicsBreakPointsWidget(std::shared_ptr<Pica::DebugContext> debug_context, | ||
| 27 | QWidget* parent = nullptr); | ||
| 28 | |||
| 29 | void OnPicaBreakPointHit(Pica::DebugContext::Event event, void* data) override; | ||
| 30 | void OnPicaResume() override; | ||
| 31 | |||
| 32 | public slots: | ||
| 33 | void OnBreakPointHit(Pica::DebugContext::Event event, void* data); | ||
| 34 | void OnResumeRequested(); | ||
| 35 | void OnResumed(); | ||
| 36 | void OnBreakpointSelectionChanged(const QModelIndex&); | ||
| 37 | void OnToggleBreakpointEnabled(); | ||
| 38 | |||
| 39 | signals: | ||
| 40 | void Resumed(); | ||
| 41 | void BreakPointHit(Pica::DebugContext::Event event, void* data); | ||
| 42 | void BreakPointsChanged(const QModelIndex& topLeft, const QModelIndex& bottomRight); | ||
| 43 | |||
| 44 | private: | ||
| 45 | void UpdateToggleBreakpointButton(const QModelIndex& index); | ||
| 46 | |||
| 47 | QLabel* status_text; | ||
| 48 | QPushButton* resume_button; | ||
| 49 | QPushButton* toggle_breakpoint_button; | ||
| 50 | |||
| 51 | BreakPointModel* breakpoint_model; | ||
| 52 | QTreeView* breakpoint_list; | ||
| 53 | }; | ||
diff --git a/src/citra_qt/debugger/graphics_breakpoints_p.hxx b/src/citra_qt/debugger/graphics_breakpoints_p.hxx new file mode 100644 index 000000000..bf5daf73d --- /dev/null +++ b/src/citra_qt/debugger/graphics_breakpoints_p.hxx | |||
| @@ -0,0 +1,38 @@ | |||
| 1 | // Copyright 2014 Citra Emulator Project | ||
| 2 | // Licensed under GPLv2 | ||
| 3 | // Refer to the license.txt file included. | ||
| 4 | |||
| 5 | #pragma once | ||
| 6 | |||
| 7 | #include <memory> | ||
| 8 | |||
| 9 | #include <QAbstractListModel> | ||
| 10 | |||
| 11 | #include "video_core/debug_utils/debug_utils.h" | ||
| 12 | |||
| 13 | class BreakPointModel : public QAbstractListModel { | ||
| 14 | Q_OBJECT | ||
| 15 | |||
| 16 | public: | ||
| 17 | enum { | ||
| 18 | Role_IsEnabled = Qt::UserRole, | ||
| 19 | }; | ||
| 20 | |||
| 21 | BreakPointModel(std::shared_ptr<Pica::DebugContext> context, QObject* parent); | ||
| 22 | |||
| 23 | int columnCount(const QModelIndex& parent = QModelIndex()) const override; | ||
| 24 | int rowCount(const QModelIndex& parent = QModelIndex()) const override; | ||
| 25 | QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override; | ||
| 26 | QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override; | ||
| 27 | |||
| 28 | bool setData(const QModelIndex& index, const QVariant& value, int role = Qt::EditRole); | ||
| 29 | |||
| 30 | public slots: | ||
| 31 | void OnBreakPointHit(Pica::DebugContext::Event event); | ||
| 32 | void OnResumed(); | ||
| 33 | |||
| 34 | private: | ||
| 35 | std::weak_ptr<Pica::DebugContext> context_weak; | ||
| 36 | bool at_breakpoint; | ||
| 37 | Pica::DebugContext::Event active_breakpoint; | ||
| 38 | }; | ||
diff --git a/src/citra_qt/debugger/graphics_cmdlists.cpp b/src/citra_qt/debugger/graphics_cmdlists.cpp index 71dd166cd..7f97cf143 100644 --- a/src/citra_qt/debugger/graphics_cmdlists.cpp +++ b/src/citra_qt/debugger/graphics_cmdlists.cpp | |||
| @@ -2,30 +2,171 @@ | |||
| 2 | // Licensed under GPLv2 | 2 | // Licensed under GPLv2 |
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include <QLabel> | ||
| 5 | #include <QListView> | 6 | #include <QListView> |
| 7 | #include <QMainWindow> | ||
| 6 | #include <QPushButton> | 8 | #include <QPushButton> |
| 7 | #include <QVBoxLayout> | 9 | #include <QVBoxLayout> |
| 8 | #include <QTreeView> | 10 | #include <QTreeView> |
| 11 | #include <QSpinBox> | ||
| 12 | #include <QComboBox> | ||
| 13 | |||
| 14 | #include "video_core/pica.h" | ||
| 15 | #include "video_core/math.h" | ||
| 16 | |||
| 17 | #include "video_core/debug_utils/debug_utils.h" | ||
| 9 | 18 | ||
| 10 | #include "graphics_cmdlists.hxx" | 19 | #include "graphics_cmdlists.hxx" |
| 11 | 20 | ||
| 12 | GPUCommandListModel::GPUCommandListModel(QObject* parent) : QAbstractListModel(parent) | 21 | #include "util/spinbox.hxx" |
| 13 | { | 22 | |
| 23 | QImage LoadTexture(u8* src, const Pica::DebugUtils::TextureInfo& info) { | ||
| 24 | QImage decoded_image(info.width, info.height, QImage::Format_ARGB32); | ||
| 25 | for (int y = 0; y < info.height; ++y) { | ||
| 26 | for (int x = 0; x < info.width; ++x) { | ||
| 27 | Math::Vec4<u8> color = Pica::DebugUtils::LookupTexture(src, x, y, info); | ||
| 28 | decoded_image.setPixel(x, y, qRgba(color.r(), color.g(), color.b(), color.a())); | ||
| 29 | } | ||
| 30 | } | ||
| 31 | |||
| 32 | return decoded_image; | ||
| 33 | } | ||
| 34 | |||
| 35 | class TextureInfoWidget : public QWidget { | ||
| 36 | public: | ||
| 37 | TextureInfoWidget(u8* src, const Pica::DebugUtils::TextureInfo& info, QWidget* parent = nullptr) : QWidget(parent) { | ||
| 38 | QLabel* image_widget = new QLabel; | ||
| 39 | QPixmap image_pixmap = QPixmap::fromImage(LoadTexture(src, info)); | ||
| 40 | image_pixmap = image_pixmap.scaled(200, 100, Qt::KeepAspectRatio, Qt::SmoothTransformation); | ||
| 41 | image_widget->setPixmap(image_pixmap); | ||
| 42 | |||
| 43 | QVBoxLayout* layout = new QVBoxLayout; | ||
| 44 | layout->addWidget(image_widget); | ||
| 45 | setLayout(layout); | ||
| 46 | } | ||
| 47 | }; | ||
| 48 | |||
| 49 | TextureInfoDockWidget::TextureInfoDockWidget(const Pica::DebugUtils::TextureInfo& info, QWidget* parent) | ||
| 50 | : QDockWidget(tr("Texture 0x%1").arg(info.address, 8, 16, QLatin1Char('0'))), | ||
| 51 | info(info) { | ||
| 52 | |||
| 53 | QWidget* main_widget = new QWidget; | ||
| 54 | |||
| 55 | QLabel* image_widget = new QLabel; | ||
| 56 | |||
| 57 | connect(this, SIGNAL(UpdatePixmap(const QPixmap&)), image_widget, SLOT(setPixmap(const QPixmap&))); | ||
| 58 | |||
| 59 | CSpinBox* phys_address_spinbox = new CSpinBox; | ||
| 60 | phys_address_spinbox->SetBase(16); | ||
| 61 | phys_address_spinbox->SetRange(0, 0xFFFFFFFF); | ||
| 62 | phys_address_spinbox->SetPrefix("0x"); | ||
| 63 | phys_address_spinbox->SetValue(info.address); | ||
| 64 | connect(phys_address_spinbox, SIGNAL(ValueChanged(qint64)), this, SLOT(OnAddressChanged(qint64))); | ||
| 65 | |||
| 66 | QComboBox* format_choice = new QComboBox; | ||
| 67 | format_choice->addItem(tr("RGBA8")); | ||
| 68 | format_choice->addItem(tr("RGB8")); | ||
| 69 | format_choice->addItem(tr("RGBA5551")); | ||
| 70 | format_choice->addItem(tr("RGB565")); | ||
| 71 | format_choice->addItem(tr("RGBA4")); | ||
| 72 | format_choice->setCurrentIndex(static_cast<int>(info.format)); | ||
| 73 | connect(format_choice, SIGNAL(currentIndexChanged(int)), this, SLOT(OnFormatChanged(int))); | ||
| 74 | |||
| 75 | QSpinBox* width_spinbox = new QSpinBox; | ||
| 76 | width_spinbox->setMaximum(65535); | ||
| 77 | width_spinbox->setValue(info.width); | ||
| 78 | connect(width_spinbox, SIGNAL(valueChanged(int)), this, SLOT(OnWidthChanged(int))); | ||
| 79 | |||
| 80 | QSpinBox* height_spinbox = new QSpinBox; | ||
| 81 | height_spinbox->setMaximum(65535); | ||
| 82 | height_spinbox->setValue(info.height); | ||
| 83 | connect(height_spinbox, SIGNAL(valueChanged(int)), this, SLOT(OnHeightChanged(int))); | ||
| 84 | |||
| 85 | QSpinBox* stride_spinbox = new QSpinBox; | ||
| 86 | stride_spinbox->setMaximum(65535 * 4); | ||
| 87 | stride_spinbox->setValue(info.stride); | ||
| 88 | connect(stride_spinbox, SIGNAL(valueChanged(int)), this, SLOT(OnStrideChanged(int))); | ||
| 89 | |||
| 90 | QVBoxLayout* main_layout = new QVBoxLayout; | ||
| 91 | main_layout->addWidget(image_widget); | ||
| 92 | |||
| 93 | { | ||
| 94 | QHBoxLayout* sub_layout = new QHBoxLayout; | ||
| 95 | sub_layout->addWidget(new QLabel(tr("Source Address:"))); | ||
| 96 | sub_layout->addWidget(phys_address_spinbox); | ||
| 97 | main_layout->addLayout(sub_layout); | ||
| 98 | } | ||
| 99 | |||
| 100 | { | ||
| 101 | QHBoxLayout* sub_layout = new QHBoxLayout; | ||
| 102 | sub_layout->addWidget(new QLabel(tr("Format"))); | ||
| 103 | sub_layout->addWidget(format_choice); | ||
| 104 | main_layout->addLayout(sub_layout); | ||
| 105 | } | ||
| 106 | |||
| 107 | { | ||
| 108 | QHBoxLayout* sub_layout = new QHBoxLayout; | ||
| 109 | sub_layout->addWidget(new QLabel(tr("Width:"))); | ||
| 110 | sub_layout->addWidget(width_spinbox); | ||
| 111 | sub_layout->addStretch(); | ||
| 112 | sub_layout->addWidget(new QLabel(tr("Height:"))); | ||
| 113 | sub_layout->addWidget(height_spinbox); | ||
| 114 | sub_layout->addStretch(); | ||
| 115 | sub_layout->addWidget(new QLabel(tr("Stride:"))); | ||
| 116 | sub_layout->addWidget(stride_spinbox); | ||
| 117 | main_layout->addLayout(sub_layout); | ||
| 118 | } | ||
| 119 | |||
| 120 | main_widget->setLayout(main_layout); | ||
| 121 | |||
| 122 | emit UpdatePixmap(ReloadPixmap()); | ||
| 123 | |||
| 124 | setWidget(main_widget); | ||
| 125 | } | ||
| 126 | |||
| 127 | void TextureInfoDockWidget::OnAddressChanged(qint64 value) { | ||
| 128 | info.address = value; | ||
| 129 | emit UpdatePixmap(ReloadPixmap()); | ||
| 130 | } | ||
| 131 | |||
| 132 | void TextureInfoDockWidget::OnFormatChanged(int value) { | ||
| 133 | info.format = static_cast<Pica::Regs::TextureFormat>(value); | ||
| 134 | emit UpdatePixmap(ReloadPixmap()); | ||
| 135 | } | ||
| 136 | |||
| 137 | void TextureInfoDockWidget::OnWidthChanged(int value) { | ||
| 138 | info.width = value; | ||
| 139 | emit UpdatePixmap(ReloadPixmap()); | ||
| 140 | } | ||
| 141 | |||
| 142 | void TextureInfoDockWidget::OnHeightChanged(int value) { | ||
| 143 | info.height = value; | ||
| 144 | emit UpdatePixmap(ReloadPixmap()); | ||
| 145 | } | ||
| 14 | 146 | ||
| 147 | void TextureInfoDockWidget::OnStrideChanged(int value) { | ||
| 148 | info.stride = value; | ||
| 149 | emit UpdatePixmap(ReloadPixmap()); | ||
| 15 | } | 150 | } |
| 16 | 151 | ||
| 17 | int GPUCommandListModel::rowCount(const QModelIndex& parent) const | 152 | QPixmap TextureInfoDockWidget::ReloadPixmap() const { |
| 18 | { | 153 | u8* src = Memory::GetPointer(info.address); |
| 154 | return QPixmap::fromImage(LoadTexture(src, info)); | ||
| 155 | } | ||
| 156 | |||
| 157 | GPUCommandListModel::GPUCommandListModel(QObject* parent) : QAbstractListModel(parent) { | ||
| 158 | |||
| 159 | } | ||
| 160 | |||
| 161 | int GPUCommandListModel::rowCount(const QModelIndex& parent) const { | ||
| 19 | return pica_trace.writes.size(); | 162 | return pica_trace.writes.size(); |
| 20 | } | 163 | } |
| 21 | 164 | ||
| 22 | int GPUCommandListModel::columnCount(const QModelIndex& parent) const | 165 | int GPUCommandListModel::columnCount(const QModelIndex& parent) const { |
| 23 | { | ||
| 24 | return 2; | 166 | return 2; |
| 25 | } | 167 | } |
| 26 | 168 | ||
| 27 | QVariant GPUCommandListModel::data(const QModelIndex& index, int role) const | 169 | QVariant GPUCommandListModel::data(const QModelIndex& index, int role) const { |
| 28 | { | ||
| 29 | if (!index.isValid()) | 170 | if (!index.isValid()) |
| 30 | return QVariant(); | 171 | return QVariant(); |
| 31 | 172 | ||
| @@ -36,21 +177,39 @@ QVariant GPUCommandListModel::data(const QModelIndex& index, int role) const | |||
| 36 | if (role == Qt::DisplayRole) { | 177 | if (role == Qt::DisplayRole) { |
| 37 | QString content; | 178 | QString content; |
| 38 | if (index.column() == 0) { | 179 | if (index.column() == 0) { |
| 39 | content = QString::fromLatin1(Pica::Regs::GetCommandName(cmd.cmd_id).c_str()); | 180 | QString content = QString::fromLatin1(Pica::Regs::GetCommandName(cmd.cmd_id).c_str()); |
| 40 | content.append(" "); | 181 | content.append(" "); |
| 182 | return content; | ||
| 41 | } else if (index.column() == 1) { | 183 | } else if (index.column() == 1) { |
| 42 | content.append(QString("%1 ").arg(cmd.hex, 8, 16, QLatin1Char('0'))); | 184 | QString content = QString("%1 ").arg(cmd.hex, 8, 16, QLatin1Char('0')); |
| 43 | content.append(QString("%1 ").arg(val, 8, 16, QLatin1Char('0'))); | 185 | content.append(QString("%1 ").arg(val, 8, 16, QLatin1Char('0'))); |
| 186 | return content; | ||
| 44 | } | 187 | } |
| 188 | } else if (role == CommandIdRole) { | ||
| 189 | return QVariant::fromValue<int>(cmd.cmd_id.Value()); | ||
| 190 | } | ||
| 45 | 191 | ||
| 46 | return QVariant(content); | 192 | return QVariant(); |
| 193 | } | ||
| 194 | |||
| 195 | QVariant GPUCommandListModel::headerData(int section, Qt::Orientation orientation, int role) const { | ||
| 196 | switch(role) { | ||
| 197 | case Qt::DisplayRole: | ||
| 198 | { | ||
| 199 | if (section == 0) { | ||
| 200 | return tr("Command Name"); | ||
| 201 | } else if (section == 1) { | ||
| 202 | return tr("Data"); | ||
| 203 | } | ||
| 204 | |||
| 205 | break; | ||
| 206 | } | ||
| 47 | } | 207 | } |
| 48 | 208 | ||
| 49 | return QVariant(); | 209 | return QVariant(); |
| 50 | } | 210 | } |
| 51 | 211 | ||
| 52 | void GPUCommandListModel::OnPicaTraceFinished(const Pica::DebugUtils::PicaTrace& trace) | 212 | void GPUCommandListModel::OnPicaTraceFinished(const Pica::DebugUtils::PicaTrace& trace) { |
| 53 | { | ||
| 54 | beginResetModel(); | 213 | beginResetModel(); |
| 55 | 214 | ||
| 56 | pica_trace = trace; | 215 | pica_trace = trace; |
| @@ -58,38 +217,82 @@ void GPUCommandListModel::OnPicaTraceFinished(const Pica::DebugUtils::PicaTrace& | |||
| 58 | endResetModel(); | 217 | endResetModel(); |
| 59 | } | 218 | } |
| 60 | 219 | ||
| 220 | #define COMMAND_IN_RANGE(cmd_id, reg_name) \ | ||
| 221 | (cmd_id >= PICA_REG_INDEX(reg_name) && \ | ||
| 222 | cmd_id < PICA_REG_INDEX(reg_name) + sizeof(decltype(Pica::registers.reg_name)) / 4) | ||
| 223 | |||
| 224 | void GPUCommandListWidget::OnCommandDoubleClicked(const QModelIndex& index) { | ||
| 225 | const int command_id = list_widget->model()->data(index, GPUCommandListModel::CommandIdRole).toInt(); | ||
| 226 | if (COMMAND_IN_RANGE(command_id, texture0)) { | ||
| 227 | auto info = Pica::DebugUtils::TextureInfo::FromPicaRegister(Pica::registers.texture0, | ||
| 228 | Pica::registers.texture0_format); | ||
| 229 | |||
| 230 | // TODO: Instead, emit a signal here to be caught by the main window widget. | ||
| 231 | auto main_window = static_cast<QMainWindow*>(parent()); | ||
| 232 | main_window->tabifyDockWidget(this, new TextureInfoDockWidget(info, main_window)); | ||
| 233 | } | ||
| 234 | } | ||
| 235 | |||
| 236 | void GPUCommandListWidget::SetCommandInfo(const QModelIndex& index) { | ||
| 237 | QWidget* new_info_widget; | ||
| 238 | |||
| 239 | const int command_id = list_widget->model()->data(index, GPUCommandListModel::CommandIdRole).toInt(); | ||
| 240 | if (COMMAND_IN_RANGE(command_id, texture0)) { | ||
| 241 | u8* src = Memory::GetPointer(Pica::registers.texture0.GetPhysicalAddress()); | ||
| 242 | auto info = Pica::DebugUtils::TextureInfo::FromPicaRegister(Pica::registers.texture0, | ||
| 243 | Pica::registers.texture0_format); | ||
| 244 | new_info_widget = new TextureInfoWidget(src, info); | ||
| 245 | } else { | ||
| 246 | new_info_widget = new QWidget; | ||
| 247 | } | ||
| 248 | |||
| 249 | widget()->layout()->removeWidget(command_info_widget); | ||
| 250 | delete command_info_widget; | ||
| 251 | widget()->layout()->addWidget(new_info_widget); | ||
| 252 | command_info_widget = new_info_widget; | ||
| 253 | } | ||
| 254 | #undef COMMAND_IN_RANGE | ||
| 61 | 255 | ||
| 62 | GPUCommandListWidget::GPUCommandListWidget(QWidget* parent) : QDockWidget(tr("Pica Command List"), parent) | 256 | GPUCommandListWidget::GPUCommandListWidget(QWidget* parent) : QDockWidget(tr("Pica Command List"), parent) { |
| 63 | { | 257 | setObjectName("Pica Command List"); |
| 64 | GPUCommandListModel* model = new GPUCommandListModel(this); | 258 | GPUCommandListModel* model = new GPUCommandListModel(this); |
| 65 | 259 | ||
| 66 | QWidget* main_widget = new QWidget; | 260 | QWidget* main_widget = new QWidget; |
| 67 | 261 | ||
| 68 | QTreeView* list_widget = new QTreeView; | 262 | list_widget = new QTreeView; |
| 69 | list_widget->setModel(model); | 263 | list_widget->setModel(model); |
| 70 | list_widget->setFont(QFont("monospace")); | 264 | list_widget->setFont(QFont("monospace")); |
| 71 | list_widget->setRootIsDecorated(false); | 265 | list_widget->setRootIsDecorated(false); |
| 72 | 266 | ||
| 73 | QPushButton* toggle_tracing = new QPushButton(tr("Start Tracing")); | 267 | connect(list_widget->selectionModel(), SIGNAL(currentChanged(const QModelIndex&,const QModelIndex&)), |
| 268 | this, SLOT(SetCommandInfo(const QModelIndex&))); | ||
| 269 | connect(list_widget, SIGNAL(doubleClicked(const QModelIndex&)), | ||
| 270 | this, SLOT(OnCommandDoubleClicked(const QModelIndex&))); | ||
| 271 | |||
| 272 | toggle_tracing = new QPushButton(tr("Start Tracing")); | ||
| 74 | 273 | ||
| 75 | connect(toggle_tracing, SIGNAL(clicked()), this, SLOT(OnToggleTracing())); | 274 | connect(toggle_tracing, SIGNAL(clicked()), this, SLOT(OnToggleTracing())); |
| 76 | connect(this, SIGNAL(TracingFinished(const Pica::DebugUtils::PicaTrace&)), | 275 | connect(this, SIGNAL(TracingFinished(const Pica::DebugUtils::PicaTrace&)), |
| 77 | model, SLOT(OnPicaTraceFinished(const Pica::DebugUtils::PicaTrace&))); | 276 | model, SLOT(OnPicaTraceFinished(const Pica::DebugUtils::PicaTrace&))); |
| 78 | 277 | ||
| 278 | command_info_widget = new QWidget; | ||
| 279 | |||
| 79 | QVBoxLayout* main_layout = new QVBoxLayout; | 280 | QVBoxLayout* main_layout = new QVBoxLayout; |
| 80 | main_layout->addWidget(list_widget); | 281 | main_layout->addWidget(list_widget); |
| 81 | main_layout->addWidget(toggle_tracing); | 282 | main_layout->addWidget(toggle_tracing); |
| 283 | main_layout->addWidget(command_info_widget); | ||
| 82 | main_widget->setLayout(main_layout); | 284 | main_widget->setLayout(main_layout); |
| 83 | 285 | ||
| 84 | setWidget(main_widget); | 286 | setWidget(main_widget); |
| 85 | } | 287 | } |
| 86 | 288 | ||
| 87 | void GPUCommandListWidget::OnToggleTracing() | 289 | void GPUCommandListWidget::OnToggleTracing() { |
| 88 | { | ||
| 89 | if (!Pica::DebugUtils::IsPicaTracing()) { | 290 | if (!Pica::DebugUtils::IsPicaTracing()) { |
| 90 | Pica::DebugUtils::StartPicaTracing(); | 291 | Pica::DebugUtils::StartPicaTracing(); |
| 292 | toggle_tracing->setText(tr("Finish Tracing")); | ||
| 91 | } else { | 293 | } else { |
| 92 | pica_trace = Pica::DebugUtils::FinishPicaTracing(); | 294 | pica_trace = Pica::DebugUtils::FinishPicaTracing(); |
| 93 | emit TracingFinished(*pica_trace); | 295 | emit TracingFinished(*pica_trace); |
| 296 | toggle_tracing->setText(tr("Start Tracing")); | ||
| 94 | } | 297 | } |
| 95 | } | 298 | } |
diff --git a/src/citra_qt/debugger/graphics_cmdlists.hxx b/src/citra_qt/debugger/graphics_cmdlists.hxx index 1523e724f..a459bba64 100644 --- a/src/citra_qt/debugger/graphics_cmdlists.hxx +++ b/src/citra_qt/debugger/graphics_cmdlists.hxx | |||
| @@ -10,16 +10,24 @@ | |||
| 10 | #include "video_core/gpu_debugger.h" | 10 | #include "video_core/gpu_debugger.h" |
| 11 | #include "video_core/debug_utils/debug_utils.h" | 11 | #include "video_core/debug_utils/debug_utils.h" |
| 12 | 12 | ||
| 13 | class QPushButton; | ||
| 14 | class QTreeView; | ||
| 15 | |||
| 13 | class GPUCommandListModel : public QAbstractListModel | 16 | class GPUCommandListModel : public QAbstractListModel |
| 14 | { | 17 | { |
| 15 | Q_OBJECT | 18 | Q_OBJECT |
| 16 | 19 | ||
| 17 | public: | 20 | public: |
| 21 | enum { | ||
| 22 | CommandIdRole = Qt::UserRole, | ||
| 23 | }; | ||
| 24 | |||
| 18 | GPUCommandListModel(QObject* parent); | 25 | GPUCommandListModel(QObject* parent); |
| 19 | 26 | ||
| 20 | int columnCount(const QModelIndex& parent = QModelIndex()) const override; | 27 | int columnCount(const QModelIndex& parent = QModelIndex()) const override; |
| 21 | int rowCount(const QModelIndex& parent = QModelIndex()) const override; | 28 | int rowCount(const QModelIndex& parent = QModelIndex()) const override; |
| 22 | QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override; | 29 | QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override; |
| 30 | QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override; | ||
| 23 | 31 | ||
| 24 | public slots: | 32 | public slots: |
| 25 | void OnPicaTraceFinished(const Pica::DebugUtils::PicaTrace& trace); | 33 | void OnPicaTraceFinished(const Pica::DebugUtils::PicaTrace& trace); |
| @@ -37,10 +45,39 @@ public: | |||
| 37 | 45 | ||
| 38 | public slots: | 46 | public slots: |
| 39 | void OnToggleTracing(); | 47 | void OnToggleTracing(); |
| 48 | void OnCommandDoubleClicked(const QModelIndex&); | ||
| 49 | |||
| 50 | void SetCommandInfo(const QModelIndex&); | ||
| 40 | 51 | ||
| 41 | signals: | 52 | signals: |
| 42 | void TracingFinished(const Pica::DebugUtils::PicaTrace&); | 53 | void TracingFinished(const Pica::DebugUtils::PicaTrace&); |
| 43 | 54 | ||
| 44 | private: | 55 | private: |
| 45 | std::unique_ptr<Pica::DebugUtils::PicaTrace> pica_trace; | 56 | std::unique_ptr<Pica::DebugUtils::PicaTrace> pica_trace; |
| 57 | |||
| 58 | QTreeView* list_widget; | ||
| 59 | QWidget* command_info_widget; | ||
| 60 | QPushButton* toggle_tracing; | ||
| 61 | }; | ||
| 62 | |||
| 63 | class TextureInfoDockWidget : public QDockWidget { | ||
| 64 | Q_OBJECT | ||
| 65 | |||
| 66 | public: | ||
| 67 | TextureInfoDockWidget(const Pica::DebugUtils::TextureInfo& info, QWidget* parent = nullptr); | ||
| 68 | |||
| 69 | signals: | ||
| 70 | void UpdatePixmap(const QPixmap& pixmap); | ||
| 71 | |||
| 72 | private slots: | ||
| 73 | void OnAddressChanged(qint64 value); | ||
| 74 | void OnFormatChanged(int value); | ||
| 75 | void OnWidthChanged(int value); | ||
| 76 | void OnHeightChanged(int value); | ||
| 77 | void OnStrideChanged(int value); | ||
| 78 | |||
| 79 | private: | ||
| 80 | QPixmap ReloadPixmap() const; | ||
| 81 | |||
| 82 | Pica::DebugUtils::TextureInfo info; | ||
| 46 | }; | 83 | }; |
diff --git a/src/citra_qt/debugger/graphics_framebuffer.cpp b/src/citra_qt/debugger/graphics_framebuffer.cpp new file mode 100644 index 000000000..ac47f298d --- /dev/null +++ b/src/citra_qt/debugger/graphics_framebuffer.cpp | |||
| @@ -0,0 +1,282 @@ | |||
| 1 | // Copyright 2014 Citra Emulator Project | ||
| 2 | // Licensed under GPLv2 | ||
| 3 | // Refer to the license.txt file included. | ||
| 4 | |||
| 5 | #include <QBoxLayout> | ||
| 6 | #include <QComboBox> | ||
| 7 | #include <QDebug> | ||
| 8 | #include <QLabel> | ||
| 9 | #include <QMetaType> | ||
| 10 | #include <QPushButton> | ||
| 11 | #include <QSpinBox> | ||
| 12 | |||
| 13 | #include "video_core/pica.h" | ||
| 14 | |||
| 15 | #include "graphics_framebuffer.hxx" | ||
| 16 | |||
| 17 | #include "util/spinbox.hxx" | ||
| 18 | |||
| 19 | BreakPointObserverDock::BreakPointObserverDock(std::shared_ptr<Pica::DebugContext> debug_context, | ||
| 20 | const QString& title, QWidget* parent) | ||
| 21 | : QDockWidget(title, parent), BreakPointObserver(debug_context) | ||
| 22 | { | ||
| 23 | qRegisterMetaType<Pica::DebugContext::Event>("Pica::DebugContext::Event"); | ||
| 24 | |||
| 25 | connect(this, SIGNAL(Resumed()), this, SLOT(OnResumed())); | ||
| 26 | |||
| 27 | // NOTE: This signal is emitted from a non-GUI thread, but connect() takes | ||
| 28 | // care of delaying its handling to the GUI thread. | ||
| 29 | connect(this, SIGNAL(BreakPointHit(Pica::DebugContext::Event,void*)), | ||
| 30 | this, SLOT(OnBreakPointHit(Pica::DebugContext::Event,void*)), | ||
| 31 | Qt::BlockingQueuedConnection); | ||
| 32 | } | ||
| 33 | |||
| 34 | void BreakPointObserverDock::OnPicaBreakPointHit(Pica::DebugContext::Event event, void* data) | ||
| 35 | { | ||
| 36 | emit BreakPointHit(event, data); | ||
| 37 | } | ||
| 38 | |||
| 39 | void BreakPointObserverDock::OnPicaResume() | ||
| 40 | { | ||
| 41 | emit Resumed(); | ||
| 42 | } | ||
| 43 | |||
| 44 | |||
| 45 | GraphicsFramebufferWidget::GraphicsFramebufferWidget(std::shared_ptr<Pica::DebugContext> debug_context, | ||
| 46 | QWidget* parent) | ||
| 47 | : BreakPointObserverDock(debug_context, tr("Pica Framebuffer"), parent), | ||
| 48 | framebuffer_source(Source::PicaTarget) | ||
| 49 | { | ||
| 50 | setObjectName("PicaFramebuffer"); | ||
| 51 | |||
| 52 | framebuffer_source_list = new QComboBox; | ||
| 53 | framebuffer_source_list->addItem(tr("Active Render Target")); | ||
| 54 | framebuffer_source_list->addItem(tr("Custom")); | ||
| 55 | framebuffer_source_list->setCurrentIndex(static_cast<int>(framebuffer_source)); | ||
| 56 | |||
| 57 | framebuffer_address_control = new CSpinBox; | ||
| 58 | framebuffer_address_control->SetBase(16); | ||
| 59 | framebuffer_address_control->SetRange(0, 0xFFFFFFFF); | ||
| 60 | framebuffer_address_control->SetPrefix("0x"); | ||
| 61 | |||
| 62 | framebuffer_width_control = new QSpinBox; | ||
| 63 | framebuffer_width_control->setMinimum(1); | ||
| 64 | framebuffer_width_control->setMaximum(std::numeric_limits<int>::max()); // TODO: Find actual maximum | ||
| 65 | |||
| 66 | framebuffer_height_control = new QSpinBox; | ||
| 67 | framebuffer_height_control->setMinimum(1); | ||
| 68 | framebuffer_height_control->setMaximum(std::numeric_limits<int>::max()); // TODO: Find actual maximum | ||
| 69 | |||
| 70 | framebuffer_format_control = new QComboBox; | ||
| 71 | framebuffer_format_control->addItem(tr("RGBA8")); | ||
| 72 | framebuffer_format_control->addItem(tr("RGB8")); | ||
| 73 | framebuffer_format_control->addItem(tr("RGBA5551")); | ||
| 74 | framebuffer_format_control->addItem(tr("RGB565")); | ||
| 75 | framebuffer_format_control->addItem(tr("RGBA4")); | ||
| 76 | |||
| 77 | // TODO: This QLabel should shrink the image to the available space rather than just expanding... | ||
| 78 | framebuffer_picture_label = new QLabel; | ||
| 79 | |||
| 80 | auto enlarge_button = new QPushButton(tr("Enlarge")); | ||
| 81 | |||
| 82 | // Connections | ||
| 83 | connect(this, SIGNAL(Update()), this, SLOT(OnUpdate())); | ||
| 84 | connect(framebuffer_source_list, SIGNAL(currentIndexChanged(int)), this, SLOT(OnFramebufferSourceChanged(int))); | ||
| 85 | connect(framebuffer_address_control, SIGNAL(ValueChanged(qint64)), this, SLOT(OnFramebufferAddressChanged(qint64))); | ||
| 86 | connect(framebuffer_width_control, SIGNAL(valueChanged(int)), this, SLOT(OnFramebufferWidthChanged(int))); | ||
| 87 | connect(framebuffer_height_control, SIGNAL(valueChanged(int)), this, SLOT(OnFramebufferHeightChanged(int))); | ||
| 88 | connect(framebuffer_format_control, SIGNAL(currentIndexChanged(int)), this, SLOT(OnFramebufferFormatChanged(int))); | ||
| 89 | |||
| 90 | auto main_widget = new QWidget; | ||
| 91 | auto main_layout = new QVBoxLayout; | ||
| 92 | { | ||
| 93 | auto sub_layout = new QHBoxLayout; | ||
| 94 | sub_layout->addWidget(new QLabel(tr("Source:"))); | ||
| 95 | sub_layout->addWidget(framebuffer_source_list); | ||
| 96 | main_layout->addLayout(sub_layout); | ||
| 97 | } | ||
| 98 | { | ||
| 99 | auto sub_layout = new QHBoxLayout; | ||
| 100 | sub_layout->addWidget(new QLabel(tr("Virtual Address:"))); | ||
| 101 | sub_layout->addWidget(framebuffer_address_control); | ||
| 102 | main_layout->addLayout(sub_layout); | ||
| 103 | } | ||
| 104 | { | ||
| 105 | auto sub_layout = new QHBoxLayout; | ||
| 106 | sub_layout->addWidget(new QLabel(tr("Width:"))); | ||
| 107 | sub_layout->addWidget(framebuffer_width_control); | ||
| 108 | main_layout->addLayout(sub_layout); | ||
| 109 | } | ||
| 110 | { | ||
| 111 | auto sub_layout = new QHBoxLayout; | ||
| 112 | sub_layout->addWidget(new QLabel(tr("Height:"))); | ||
| 113 | sub_layout->addWidget(framebuffer_height_control); | ||
| 114 | main_layout->addLayout(sub_layout); | ||
| 115 | } | ||
| 116 | { | ||
| 117 | auto sub_layout = new QHBoxLayout; | ||
| 118 | sub_layout->addWidget(new QLabel(tr("Format:"))); | ||
| 119 | sub_layout->addWidget(framebuffer_format_control); | ||
| 120 | main_layout->addLayout(sub_layout); | ||
| 121 | } | ||
| 122 | main_layout->addWidget(framebuffer_picture_label); | ||
| 123 | main_layout->addWidget(enlarge_button); | ||
| 124 | main_widget->setLayout(main_layout); | ||
| 125 | setWidget(main_widget); | ||
| 126 | |||
| 127 | // Load current data - TODO: Make sure this works when emulation is not running | ||
| 128 | emit Update(); | ||
| 129 | widget()->setEnabled(false); // TODO: Only enable if currently at breakpoint | ||
| 130 | } | ||
| 131 | |||
| 132 | void GraphicsFramebufferWidget::OnBreakPointHit(Pica::DebugContext::Event event, void* data) | ||
| 133 | { | ||
| 134 | emit Update(); | ||
| 135 | widget()->setEnabled(true); | ||
| 136 | } | ||
| 137 | |||
| 138 | void GraphicsFramebufferWidget::OnResumed() | ||
| 139 | { | ||
| 140 | widget()->setEnabled(false); | ||
| 141 | } | ||
| 142 | |||
| 143 | void GraphicsFramebufferWidget::OnFramebufferSourceChanged(int new_value) | ||
| 144 | { | ||
| 145 | framebuffer_source = static_cast<Source>(new_value); | ||
| 146 | emit Update(); | ||
| 147 | } | ||
| 148 | |||
| 149 | void GraphicsFramebufferWidget::OnFramebufferAddressChanged(qint64 new_value) | ||
| 150 | { | ||
| 151 | if (framebuffer_address != new_value) { | ||
| 152 | framebuffer_address = static_cast<unsigned>(new_value); | ||
| 153 | |||
| 154 | framebuffer_source_list->setCurrentIndex(static_cast<int>(Source::Custom)); | ||
| 155 | emit Update(); | ||
| 156 | } | ||
| 157 | } | ||
| 158 | |||
| 159 | void GraphicsFramebufferWidget::OnFramebufferWidthChanged(int new_value) | ||
| 160 | { | ||
| 161 | if (framebuffer_width != new_value) { | ||
| 162 | framebuffer_width = new_value; | ||
| 163 | |||
| 164 | framebuffer_source_list->setCurrentIndex(static_cast<int>(Source::Custom)); | ||
| 165 | emit Update(); | ||
| 166 | } | ||
| 167 | } | ||
| 168 | |||
| 169 | void GraphicsFramebufferWidget::OnFramebufferHeightChanged(int new_value) | ||
| 170 | { | ||
| 171 | if (framebuffer_height != new_value) { | ||
| 172 | framebuffer_height = new_value; | ||
| 173 | |||
| 174 | framebuffer_source_list->setCurrentIndex(static_cast<int>(Source::Custom)); | ||
| 175 | emit Update(); | ||
| 176 | } | ||
| 177 | } | ||
| 178 | |||
| 179 | void GraphicsFramebufferWidget::OnFramebufferFormatChanged(int new_value) | ||
| 180 | { | ||
| 181 | if (framebuffer_format != static_cast<Format>(new_value)) { | ||
| 182 | framebuffer_format = static_cast<Format>(new_value); | ||
| 183 | |||
| 184 | framebuffer_source_list->setCurrentIndex(static_cast<int>(Source::Custom)); | ||
| 185 | emit Update(); | ||
| 186 | } | ||
| 187 | } | ||
| 188 | |||
| 189 | void GraphicsFramebufferWidget::OnUpdate() | ||
| 190 | { | ||
| 191 | QPixmap pixmap; | ||
| 192 | |||
| 193 | switch (framebuffer_source) { | ||
| 194 | case Source::PicaTarget: | ||
| 195 | { | ||
| 196 | // TODO: Store a reference to the registers in the debug context instead of accessing them directly... | ||
| 197 | |||
| 198 | auto framebuffer = Pica::registers.framebuffer; | ||
| 199 | using Framebuffer = decltype(framebuffer); | ||
| 200 | |||
| 201 | framebuffer_address = framebuffer.GetColorBufferAddress(); | ||
| 202 | framebuffer_width = framebuffer.GetWidth(); | ||
| 203 | framebuffer_height = framebuffer.GetHeight(); | ||
| 204 | framebuffer_format = static_cast<Format>(framebuffer.color_format); | ||
| 205 | |||
| 206 | break; | ||
| 207 | } | ||
| 208 | |||
| 209 | case Source::Custom: | ||
| 210 | { | ||
| 211 | // Keep user-specified values | ||
| 212 | break; | ||
| 213 | } | ||
| 214 | |||
| 215 | default: | ||
| 216 | qDebug() << "Unknown framebuffer source " << static_cast<int>(framebuffer_source); | ||
| 217 | break; | ||
| 218 | } | ||
| 219 | |||
| 220 | // TODO: Implement a good way to visualize alpha components! | ||
| 221 | // TODO: Unify this decoding code with the texture decoder | ||
| 222 | switch (framebuffer_format) { | ||
| 223 | case Format::RGBA8: | ||
| 224 | { | ||
| 225 | QImage decoded_image(framebuffer_width, framebuffer_height, QImage::Format_ARGB32); | ||
| 226 | u32* color_buffer = (u32*)Memory::GetPointer(framebuffer_address); | ||
| 227 | for (int y = 0; y < framebuffer_height; ++y) { | ||
| 228 | for (int x = 0; x < framebuffer_width; ++x) { | ||
| 229 | u32 value = *(color_buffer + x + y * framebuffer_width); | ||
| 230 | |||
| 231 | decoded_image.setPixel(x, y, qRgba((value >> 16) & 0xFF, (value >> 8) & 0xFF, value & 0xFF, 255/*value >> 24*/)); | ||
| 232 | } | ||
| 233 | } | ||
| 234 | pixmap = QPixmap::fromImage(decoded_image); | ||
| 235 | break; | ||
| 236 | } | ||
| 237 | |||
| 238 | case Format::RGB8: | ||
| 239 | { | ||
| 240 | QImage decoded_image(framebuffer_width, framebuffer_height, QImage::Format_ARGB32); | ||
| 241 | u8* color_buffer = Memory::GetPointer(framebuffer_address); | ||
| 242 | for (int y = 0; y < framebuffer_height; ++y) { | ||
| 243 | for (int x = 0; x < framebuffer_width; ++x) { | ||
| 244 | u8* pixel_pointer = color_buffer + x * 3 + y * 3 * framebuffer_width; | ||
| 245 | |||
| 246 | decoded_image.setPixel(x, y, qRgba(pixel_pointer[0], pixel_pointer[1], pixel_pointer[2], 255/*value >> 24*/)); | ||
| 247 | } | ||
| 248 | } | ||
| 249 | pixmap = QPixmap::fromImage(decoded_image); | ||
| 250 | break; | ||
| 251 | } | ||
| 252 | |||
| 253 | case Format::RGBA5551: | ||
| 254 | { | ||
| 255 | QImage decoded_image(framebuffer_width, framebuffer_height, QImage::Format_ARGB32); | ||
| 256 | u32* color_buffer = (u32*)Memory::GetPointer(framebuffer_address); | ||
| 257 | for (int y = 0; y < framebuffer_height; ++y) { | ||
| 258 | for (int x = 0; x < framebuffer_width; ++x) { | ||
| 259 | u16 value = *(u16*)(((u8*)color_buffer) + x * 2 + y * framebuffer_width * 2); | ||
| 260 | u8 r = (value >> 11) & 0x1F; | ||
| 261 | u8 g = (value >> 6) & 0x1F; | ||
| 262 | u8 b = (value >> 1) & 0x1F; | ||
| 263 | u8 a = value & 1; | ||
| 264 | |||
| 265 | decoded_image.setPixel(x, y, qRgba(r, g, b, 255/*a*/)); | ||
| 266 | } | ||
| 267 | } | ||
| 268 | pixmap = QPixmap::fromImage(decoded_image); | ||
| 269 | break; | ||
| 270 | } | ||
| 271 | |||
| 272 | default: | ||
| 273 | qDebug() << "Unknown fb color format " << static_cast<int>(framebuffer_format); | ||
| 274 | break; | ||
| 275 | } | ||
| 276 | |||
| 277 | framebuffer_address_control->SetValue(framebuffer_address); | ||
| 278 | framebuffer_width_control->setValue(framebuffer_width); | ||
| 279 | framebuffer_height_control->setValue(framebuffer_height); | ||
| 280 | framebuffer_format_control->setCurrentIndex(static_cast<int>(framebuffer_format)); | ||
| 281 | framebuffer_picture_label->setPixmap(pixmap); | ||
| 282 | } | ||
diff --git a/src/citra_qt/debugger/graphics_framebuffer.hxx b/src/citra_qt/debugger/graphics_framebuffer.hxx new file mode 100644 index 000000000..1151ee7a1 --- /dev/null +++ b/src/citra_qt/debugger/graphics_framebuffer.hxx | |||
| @@ -0,0 +1,92 @@ | |||
| 1 | // Copyright 2014 Citra Emulator Project | ||
| 2 | // Licensed under GPLv2 | ||
| 3 | // Refer to the license.txt file included. | ||
| 4 | |||
| 5 | #pragma once | ||
| 6 | |||
| 7 | #include <QDockWidget> | ||
| 8 | |||
| 9 | #include "video_core/debug_utils/debug_utils.h" | ||
| 10 | |||
| 11 | class QComboBox; | ||
| 12 | class QLabel; | ||
| 13 | class QSpinBox; | ||
| 14 | |||
| 15 | class CSpinBox; | ||
| 16 | |||
| 17 | // Utility class which forwards calls to OnPicaBreakPointHit and OnPicaResume to public slots. | ||
| 18 | // This is because the Pica breakpoint callbacks are called from a non-GUI thread, while | ||
| 19 | // the widget usually wants to perform reactions in the GUI thread. | ||
| 20 | class BreakPointObserverDock : public QDockWidget, Pica::DebugContext::BreakPointObserver { | ||
| 21 | Q_OBJECT | ||
| 22 | |||
| 23 | public: | ||
| 24 | BreakPointObserverDock(std::shared_ptr<Pica::DebugContext> debug_context, const QString& title, | ||
| 25 | QWidget* parent = nullptr); | ||
| 26 | |||
| 27 | void OnPicaBreakPointHit(Pica::DebugContext::Event event, void* data) override; | ||
| 28 | void OnPicaResume() override; | ||
| 29 | |||
| 30 | private slots: | ||
| 31 | virtual void OnBreakPointHit(Pica::DebugContext::Event event, void* data) = 0; | ||
| 32 | virtual void OnResumed() = 0; | ||
| 33 | |||
| 34 | signals: | ||
| 35 | void Resumed(); | ||
| 36 | void BreakPointHit(Pica::DebugContext::Event event, void* data); | ||
| 37 | }; | ||
| 38 | |||
| 39 | class GraphicsFramebufferWidget : public BreakPointObserverDock { | ||
| 40 | Q_OBJECT | ||
| 41 | |||
| 42 | using Event = Pica::DebugContext::Event; | ||
| 43 | |||
| 44 | enum class Source { | ||
| 45 | PicaTarget = 0, | ||
| 46 | Custom = 1, | ||
| 47 | |||
| 48 | // TODO: Add GPU framebuffer sources! | ||
| 49 | }; | ||
| 50 | |||
| 51 | enum class Format { | ||
| 52 | RGBA8 = 0, | ||
| 53 | RGB8 = 1, | ||
| 54 | RGBA5551 = 2, | ||
| 55 | RGB565 = 3, | ||
| 56 | RGBA4 = 4, | ||
| 57 | }; | ||
| 58 | |||
| 59 | public: | ||
| 60 | GraphicsFramebufferWidget(std::shared_ptr<Pica::DebugContext> debug_context, QWidget* parent = nullptr); | ||
| 61 | |||
| 62 | public slots: | ||
| 63 | void OnFramebufferSourceChanged(int new_value); | ||
| 64 | void OnFramebufferAddressChanged(qint64 new_value); | ||
| 65 | void OnFramebufferWidthChanged(int new_value); | ||
| 66 | void OnFramebufferHeightChanged(int new_value); | ||
| 67 | void OnFramebufferFormatChanged(int new_value); | ||
| 68 | void OnUpdate(); | ||
| 69 | |||
| 70 | private slots: | ||
| 71 | void OnBreakPointHit(Pica::DebugContext::Event event, void* data) override; | ||
| 72 | void OnResumed() override; | ||
| 73 | |||
| 74 | signals: | ||
| 75 | void Update(); | ||
| 76 | |||
| 77 | private: | ||
| 78 | |||
| 79 | QComboBox* framebuffer_source_list; | ||
| 80 | CSpinBox* framebuffer_address_control; | ||
| 81 | QSpinBox* framebuffer_width_control; | ||
| 82 | QSpinBox* framebuffer_height_control; | ||
| 83 | QComboBox* framebuffer_format_control; | ||
| 84 | |||
| 85 | QLabel* framebuffer_picture_label; | ||
| 86 | |||
| 87 | Source framebuffer_source; | ||
| 88 | unsigned framebuffer_address; | ||
| 89 | unsigned framebuffer_width; | ||
| 90 | unsigned framebuffer_height; | ||
| 91 | Format framebuffer_format; | ||
| 92 | }; | ||
diff --git a/src/citra_qt/hotkeys.cpp b/src/citra_qt/hotkeys.cpp index bbaa4a8dc..5d0b52e4f 100644 --- a/src/citra_qt/hotkeys.cpp +++ b/src/citra_qt/hotkeys.cpp | |||
| @@ -5,7 +5,7 @@ | |||
| 5 | 5 | ||
| 6 | struct Hotkey | 6 | struct Hotkey |
| 7 | { | 7 | { |
| 8 | Hotkey() : shortcut(NULL), context(Qt::WindowShortcut) {} | 8 | Hotkey() : shortcut(nullptr), context(Qt::WindowShortcut) {} |
| 9 | 9 | ||
| 10 | QKeySequence keyseq; | 10 | QKeySequence keyseq; |
| 11 | QShortcut* shortcut; | 11 | QShortcut* shortcut; |
| @@ -81,7 +81,7 @@ QShortcut* GetHotkey(const QString& group, const QString& action, QWidget* widge | |||
| 81 | Hotkey& hk = hotkey_groups[group][action]; | 81 | Hotkey& hk = hotkey_groups[group][action]; |
| 82 | 82 | ||
| 83 | if (!hk.shortcut) | 83 | if (!hk.shortcut) |
| 84 | hk.shortcut = new QShortcut(hk.keyseq, widget, NULL, NULL, hk.context); | 84 | hk.shortcut = new QShortcut(hk.keyseq, widget, nullptr, nullptr, hk.context); |
| 85 | 85 | ||
| 86 | return hk.shortcut; | 86 | return hk.shortcut; |
| 87 | } | 87 | } |
diff --git a/src/citra_qt/main.cpp b/src/citra_qt/main.cpp index d5554d917..b4e3ad964 100644 --- a/src/citra_qt/main.cpp +++ b/src/citra_qt/main.cpp | |||
| @@ -20,7 +20,9 @@ | |||
| 20 | #include "debugger/callstack.hxx" | 20 | #include "debugger/callstack.hxx" |
| 21 | #include "debugger/ramview.hxx" | 21 | #include "debugger/ramview.hxx" |
| 22 | #include "debugger/graphics.hxx" | 22 | #include "debugger/graphics.hxx" |
| 23 | #include "debugger/graphics_breakpoints.hxx" | ||
| 23 | #include "debugger/graphics_cmdlists.hxx" | 24 | #include "debugger/graphics_cmdlists.hxx" |
| 25 | #include "debugger/graphics_framebuffer.hxx" | ||
| 24 | 26 | ||
| 25 | #include "core/settings.h" | 27 | #include "core/settings.h" |
| 26 | #include "core/system.h" | 28 | #include "core/system.h" |
| @@ -36,6 +38,8 @@ GMainWindow::GMainWindow() | |||
| 36 | { | 38 | { |
| 37 | LogManager::Init(); | 39 | LogManager::Init(); |
| 38 | 40 | ||
| 41 | Pica::g_debug_context = Pica::DebugContext::Construct(); | ||
| 42 | |||
| 39 | Config config; | 43 | Config config; |
| 40 | 44 | ||
| 41 | if (!Settings::values.enable_log) | 45 | if (!Settings::values.enable_log) |
| @@ -67,12 +71,22 @@ GMainWindow::GMainWindow() | |||
| 67 | addDockWidget(Qt::RightDockWidgetArea, graphicsCommandsWidget); | 71 | addDockWidget(Qt::RightDockWidgetArea, graphicsCommandsWidget); |
| 68 | graphicsCommandsWidget->hide(); | 72 | graphicsCommandsWidget->hide(); |
| 69 | 73 | ||
| 74 | auto graphicsBreakpointsWidget = new GraphicsBreakPointsWidget(Pica::g_debug_context, this); | ||
| 75 | addDockWidget(Qt::RightDockWidgetArea, graphicsBreakpointsWidget); | ||
| 76 | graphicsBreakpointsWidget->hide(); | ||
| 77 | |||
| 78 | auto graphicsFramebufferWidget = new GraphicsFramebufferWidget(Pica::g_debug_context, this); | ||
| 79 | addDockWidget(Qt::RightDockWidgetArea, graphicsFramebufferWidget); | ||
| 80 | graphicsFramebufferWidget->hide(); | ||
| 81 | |||
| 70 | QMenu* debug_menu = ui.menu_View->addMenu(tr("Debugging")); | 82 | QMenu* debug_menu = ui.menu_View->addMenu(tr("Debugging")); |
| 71 | debug_menu->addAction(disasmWidget->toggleViewAction()); | 83 | debug_menu->addAction(disasmWidget->toggleViewAction()); |
| 72 | debug_menu->addAction(registersWidget->toggleViewAction()); | 84 | debug_menu->addAction(registersWidget->toggleViewAction()); |
| 73 | debug_menu->addAction(callstackWidget->toggleViewAction()); | 85 | debug_menu->addAction(callstackWidget->toggleViewAction()); |
| 74 | debug_menu->addAction(graphicsWidget->toggleViewAction()); | 86 | debug_menu->addAction(graphicsWidget->toggleViewAction()); |
| 75 | debug_menu->addAction(graphicsCommandsWidget->toggleViewAction()); | 87 | debug_menu->addAction(graphicsCommandsWidget->toggleViewAction()); |
| 88 | debug_menu->addAction(graphicsBreakpointsWidget->toggleViewAction()); | ||
| 89 | debug_menu->addAction(graphicsFramebufferWidget->toggleViewAction()); | ||
| 76 | 90 | ||
| 77 | // Set default UI state | 91 | // Set default UI state |
| 78 | // geometry: 55% of the window contents are in the upper screen half, 45% in the lower half | 92 | // geometry: 55% of the window contents are in the upper screen half, 45% in the lower half |
| @@ -131,8 +145,10 @@ GMainWindow::GMainWindow() | |||
| 131 | GMainWindow::~GMainWindow() | 145 | GMainWindow::~GMainWindow() |
| 132 | { | 146 | { |
| 133 | // will get automatically deleted otherwise | 147 | // will get automatically deleted otherwise |
| 134 | if (render_window->parent() == NULL) | 148 | if (render_window->parent() == nullptr) |
| 135 | delete render_window; | 149 | delete render_window; |
| 150 | |||
| 151 | Pica::g_debug_context.reset(); | ||
| 136 | } | 152 | } |
| 137 | 153 | ||
| 138 | void GMainWindow::BootGame(std::string filename) | 154 | void GMainWindow::BootGame(std::string filename) |
| @@ -164,7 +180,7 @@ void GMainWindow::BootGame(std::string filename) | |||
| 164 | 180 | ||
| 165 | void GMainWindow::OnMenuLoadFile() | 181 | void GMainWindow::OnMenuLoadFile() |
| 166 | { | 182 | { |
| 167 | QString filename = QFileDialog::getOpenFileName(this, tr("Load file"), QString(), tr("3DS executable (*.elf *.axf *.bin *.cci *.cxi)")); | 183 | QString filename = QFileDialog::getOpenFileName(this, tr("Load file"), QString(), tr("3DS executable (*.3dsx *.elf *.axf *.bin *.cci *.cxi)")); |
| 168 | if (filename.size()) | 184 | if (filename.size()) |
| 169 | BootGame(filename.toLatin1().data()); | 185 | BootGame(filename.toLatin1().data()); |
| 170 | } | 186 | } |
| @@ -213,14 +229,14 @@ void GMainWindow::OnOpenHotkeysDialog() | |||
| 213 | void GMainWindow::ToggleWindowMode() | 229 | void GMainWindow::ToggleWindowMode() |
| 214 | { | 230 | { |
| 215 | bool enable = ui.action_Popout_Window_Mode->isChecked(); | 231 | bool enable = ui.action_Popout_Window_Mode->isChecked(); |
| 216 | if (enable && render_window->parent() != NULL) | 232 | if (enable && render_window->parent() != nullptr) |
| 217 | { | 233 | { |
| 218 | ui.horizontalLayout->removeWidget(render_window); | 234 | ui.horizontalLayout->removeWidget(render_window); |
| 219 | render_window->setParent(NULL); | 235 | render_window->setParent(nullptr); |
| 220 | render_window->setVisible(true); | 236 | render_window->setVisible(true); |
| 221 | render_window->RestoreGeometry(); | 237 | render_window->RestoreGeometry(); |
| 222 | } | 238 | } |
| 223 | else if (!enable && render_window->parent() == NULL) | 239 | else if (!enable && render_window->parent() == nullptr) |
| 224 | { | 240 | { |
| 225 | render_window->BackupGeometry(); | 241 | render_window->BackupGeometry(); |
| 226 | ui.horizontalLayout->addWidget(render_window); | 242 | ui.horizontalLayout->addWidget(render_window); |
diff --git a/src/citra_qt/util/spinbox.cpp b/src/citra_qt/util/spinbox.cpp new file mode 100644 index 000000000..80dc67d7d --- /dev/null +++ b/src/citra_qt/util/spinbox.cpp | |||
| @@ -0,0 +1,303 @@ | |||
| 1 | // Licensed under GPLv2+ | ||
| 2 | // Refer to the license.txt file included. | ||
| 3 | |||
| 4 | |||
| 5 | // Copyright 2014 Tony Wasserka | ||
| 6 | // All rights reserved. | ||
| 7 | // | ||
| 8 | // Redistribution and use in source and binary forms, with or without | ||
| 9 | // modification, are permitted provided that the following conditions are met: | ||
| 10 | // | ||
| 11 | // * Redistributions of source code must retain the above copyright | ||
| 12 | // notice, this list of conditions and the following disclaimer. | ||
| 13 | // * Redistributions in binary form must reproduce the above copyright | ||
| 14 | // notice, this list of conditions and the following disclaimer in the | ||
| 15 | // documentation and/or other materials provided with the distribution. | ||
| 16 | // * Neither the name of the owner nor the names of its contributors may | ||
| 17 | // be used to endorse or promote products derived from this software | ||
| 18 | // without specific prior written permission. | ||
| 19 | // | ||
| 20 | // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| 21 | // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| 22 | // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
| 23 | // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
| 24 | // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
| 25 | // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| 26 | // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
| 27 | // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| 28 | // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| 29 | // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| 30 | // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| 31 | |||
| 32 | #include <QLineEdit> | ||
| 33 | #include <QRegExpValidator> | ||
| 34 | |||
| 35 | #include "common/log.h" | ||
| 36 | |||
| 37 | #include "spinbox.hxx" | ||
| 38 | |||
| 39 | CSpinBox::CSpinBox(QWidget* parent) : QAbstractSpinBox(parent), base(10), min_value(-100), max_value(100), value(0), num_digits(0) | ||
| 40 | { | ||
| 41 | // TODO: Might be nice to not immediately call the slot. | ||
| 42 | // Think of an address that is being replaced by a different one, in which case a lot | ||
| 43 | // invalid intermediate addresses would be read from during editing. | ||
| 44 | connect(lineEdit(), SIGNAL(textEdited(QString)), this, SLOT(OnEditingFinished())); | ||
| 45 | |||
| 46 | UpdateText(); | ||
| 47 | } | ||
| 48 | |||
| 49 | void CSpinBox::SetValue(qint64 val) | ||
| 50 | { | ||
| 51 | auto old_value = value; | ||
| 52 | value = std::max(std::min(val, max_value), min_value); | ||
| 53 | |||
| 54 | if (old_value != value) { | ||
| 55 | UpdateText(); | ||
| 56 | emit ValueChanged(value); | ||
| 57 | } | ||
| 58 | } | ||
| 59 | |||
| 60 | void CSpinBox::SetRange(qint64 min, qint64 max) | ||
| 61 | { | ||
| 62 | min_value = min; | ||
| 63 | max_value = max; | ||
| 64 | |||
| 65 | SetValue(value); | ||
| 66 | UpdateText(); | ||
| 67 | } | ||
| 68 | |||
| 69 | void CSpinBox::stepBy(int steps) | ||
| 70 | { | ||
| 71 | auto new_value = value; | ||
| 72 | // Scale number of steps by the currently selected digit | ||
| 73 | // TODO: Move this code elsewhere and enable it. | ||
| 74 | // TODO: Support for num_digits==0, too | ||
| 75 | // TODO: Support base!=16, too | ||
| 76 | // TODO: Make the cursor not jump back to the end of the line... | ||
| 77 | /*if (base == 16 && num_digits > 0) { | ||
| 78 | int digit = num_digits - (lineEdit()->cursorPosition() - prefix.length()) - 1; | ||
| 79 | digit = std::max(0, std::min(digit, num_digits - 1)); | ||
| 80 | steps <<= digit * 4; | ||
| 81 | }*/ | ||
| 82 | |||
| 83 | // Increment "new_value" by "steps", and perform annoying overflow checks, too. | ||
| 84 | if (steps < 0 && new_value + steps > new_value) { | ||
| 85 | new_value = std::numeric_limits<qint64>::min(); | ||
| 86 | } else if (steps > 0 && new_value + steps < new_value) { | ||
| 87 | new_value = std::numeric_limits<qint64>::max(); | ||
| 88 | } else { | ||
| 89 | new_value += steps; | ||
| 90 | } | ||
| 91 | |||
| 92 | SetValue(new_value); | ||
| 93 | UpdateText(); | ||
| 94 | } | ||
| 95 | |||
| 96 | QAbstractSpinBox::StepEnabled CSpinBox::stepEnabled() const | ||
| 97 | { | ||
| 98 | StepEnabled ret = StepNone; | ||
| 99 | |||
| 100 | if (value > min_value) | ||
| 101 | ret |= StepDownEnabled; | ||
| 102 | |||
| 103 | if (value < max_value) | ||
| 104 | ret |= StepUpEnabled; | ||
| 105 | |||
| 106 | return ret; | ||
| 107 | } | ||
| 108 | |||
| 109 | void CSpinBox::SetBase(int base) | ||
| 110 | { | ||
| 111 | this->base = base; | ||
| 112 | |||
| 113 | UpdateText(); | ||
| 114 | } | ||
| 115 | |||
| 116 | void CSpinBox::SetNumDigits(int num_digits) | ||
| 117 | { | ||
| 118 | this->num_digits = num_digits; | ||
| 119 | |||
| 120 | UpdateText(); | ||
| 121 | } | ||
| 122 | |||
| 123 | void CSpinBox::SetPrefix(const QString& prefix) | ||
| 124 | { | ||
| 125 | this->prefix = prefix; | ||
| 126 | |||
| 127 | UpdateText(); | ||
| 128 | } | ||
| 129 | |||
| 130 | void CSpinBox::SetSuffix(const QString& suffix) | ||
| 131 | { | ||
| 132 | this->suffix = suffix; | ||
| 133 | |||
| 134 | UpdateText(); | ||
| 135 | } | ||
| 136 | |||
| 137 | static QString StringToInputMask(const QString& input) { | ||
| 138 | QString mask = input; | ||
| 139 | |||
| 140 | // ... replace any special characters by their escaped counterparts ... | ||
| 141 | mask.replace("\\", "\\\\"); | ||
| 142 | mask.replace("A", "\\A"); | ||
| 143 | mask.replace("a", "\\a"); | ||
| 144 | mask.replace("N", "\\N"); | ||
| 145 | mask.replace("n", "\\n"); | ||
| 146 | mask.replace("X", "\\X"); | ||
| 147 | mask.replace("x", "\\x"); | ||
| 148 | mask.replace("9", "\\9"); | ||
| 149 | mask.replace("0", "\\0"); | ||
| 150 | mask.replace("D", "\\D"); | ||
| 151 | mask.replace("d", "\\d"); | ||
| 152 | mask.replace("#", "\\#"); | ||
| 153 | mask.replace("H", "\\H"); | ||
| 154 | mask.replace("h", "\\h"); | ||
| 155 | mask.replace("B", "\\B"); | ||
| 156 | mask.replace("b", "\\b"); | ||
| 157 | mask.replace(">", "\\>"); | ||
| 158 | mask.replace("<", "\\<"); | ||
| 159 | mask.replace("!", "\\!"); | ||
| 160 | |||
| 161 | return mask; | ||
| 162 | } | ||
| 163 | |||
| 164 | void CSpinBox::UpdateText() | ||
| 165 | { | ||
| 166 | // If a fixed number of digits is used, we put the line edit in insertion mode by setting an | ||
| 167 | // input mask. | ||
| 168 | QString mask; | ||
| 169 | if (num_digits != 0) { | ||
| 170 | mask += StringToInputMask(prefix); | ||
| 171 | |||
| 172 | // For base 10 and negative range, demand a single sign character | ||
| 173 | if (HasSign()) | ||
| 174 | mask += "X"; // identified as "-" or "+" in the validator | ||
| 175 | |||
| 176 | // Uppercase digits greater than 9. | ||
| 177 | mask += ">"; | ||
| 178 | |||
| 179 | // The greatest signed 64-bit number has 19 decimal digits. | ||
| 180 | // TODO: Could probably make this more generic with some logarithms. | ||
| 181 | // For reference, unsigned 64-bit can have up to 20 decimal digits. | ||
| 182 | int digits = (num_digits != 0) ? num_digits | ||
| 183 | : (base == 16) ? 16 | ||
| 184 | : (base == 10) ? 19 | ||
| 185 | : 0xFF; // fallback case... | ||
| 186 | |||
| 187 | // Match num_digits digits | ||
| 188 | // Digits irrelevant to the chosen number base are filtered in the validator | ||
| 189 | mask += QString("H").repeated(std::max(num_digits, 1)); | ||
| 190 | |||
| 191 | // Switch off case conversion | ||
| 192 | mask += "!"; | ||
| 193 | |||
| 194 | mask += StringToInputMask(suffix); | ||
| 195 | } | ||
| 196 | lineEdit()->setInputMask(mask); | ||
| 197 | |||
| 198 | // Set new text without changing the cursor position. This will cause the cursor to briefly | ||
| 199 | // appear at the end of the line and then to jump back to its original position. That's | ||
| 200 | // a bit ugly, but better than having setText() move the cursor permanently all the time. | ||
| 201 | int cursor_position = lineEdit()->cursorPosition(); | ||
| 202 | lineEdit()->setText(TextFromValue()); | ||
| 203 | lineEdit()->setCursorPosition(cursor_position); | ||
| 204 | } | ||
| 205 | |||
| 206 | QString CSpinBox::TextFromValue() | ||
| 207 | { | ||
| 208 | return prefix | ||
| 209 | + QString(HasSign() ? ((value < 0) ? "-" : "+") : "") | ||
| 210 | + QString("%1").arg(abs(value), num_digits, base, QLatin1Char('0')).toUpper() | ||
| 211 | + suffix; | ||
| 212 | } | ||
| 213 | |||
| 214 | qint64 CSpinBox::ValueFromText() | ||
| 215 | { | ||
| 216 | unsigned strpos = prefix.length(); | ||
| 217 | |||
| 218 | QString num_string = text().mid(strpos, text().length() - strpos - suffix.length()); | ||
| 219 | return num_string.toLongLong(nullptr, base); | ||
| 220 | } | ||
| 221 | |||
| 222 | bool CSpinBox::HasSign() const | ||
| 223 | { | ||
| 224 | return base == 10 && min_value < 0; | ||
| 225 | } | ||
| 226 | |||
| 227 | void CSpinBox::OnEditingFinished() | ||
| 228 | { | ||
| 229 | // Only update for valid input | ||
| 230 | QString input = lineEdit()->text(); | ||
| 231 | int pos = 0; | ||
| 232 | if (QValidator::Acceptable == validate(input, pos)) | ||
| 233 | SetValue(ValueFromText()); | ||
| 234 | } | ||
| 235 | |||
| 236 | QValidator::State CSpinBox::validate(QString& input, int& pos) const | ||
| 237 | { | ||
| 238 | if (!prefix.isEmpty() && input.left(prefix.length()) != prefix) | ||
| 239 | return QValidator::Invalid; | ||
| 240 | |||
| 241 | unsigned strpos = prefix.length(); | ||
| 242 | |||
| 243 | // Empty "numbers" allowed as intermediate values | ||
| 244 | if (strpos >= input.length() - HasSign() - suffix.length()) | ||
| 245 | return QValidator::Intermediate; | ||
| 246 | |||
| 247 | _dbg_assert_(GUI, base <= 10 || base == 16); | ||
| 248 | QString regexp; | ||
| 249 | |||
| 250 | // Demand sign character for negative ranges | ||
| 251 | if (HasSign()) | ||
| 252 | regexp += "[+\\-]"; | ||
| 253 | |||
| 254 | // Match digits corresponding to the chosen number base. | ||
| 255 | regexp += QString("[0-%1").arg(std::min(base, 9)); | ||
| 256 | if (base == 16) { | ||
| 257 | regexp += "a-fA-F"; | ||
| 258 | } | ||
| 259 | regexp += "]"; | ||
| 260 | |||
| 261 | // Specify number of digits | ||
| 262 | if (num_digits > 0) { | ||
| 263 | regexp += QString("{%1}").arg(num_digits); | ||
| 264 | } else { | ||
| 265 | regexp += "+"; | ||
| 266 | } | ||
| 267 | |||
| 268 | // Match string | ||
| 269 | QRegExp num_regexp(regexp); | ||
| 270 | int num_pos = strpos; | ||
| 271 | QString sub_input = input.mid(strpos, input.length() - strpos - suffix.length()); | ||
| 272 | |||
| 273 | if (!num_regexp.exactMatch(sub_input) && num_regexp.matchedLength() == 0) | ||
| 274 | return QValidator::Invalid; | ||
| 275 | |||
| 276 | sub_input = sub_input.left(num_regexp.matchedLength()); | ||
| 277 | bool ok; | ||
| 278 | qint64 val = sub_input.toLongLong(&ok, base); | ||
| 279 | |||
| 280 | if (!ok) | ||
| 281 | return QValidator::Invalid; | ||
| 282 | |||
| 283 | // Outside boundaries => don't accept | ||
| 284 | if (val < min_value || val > max_value) | ||
| 285 | return QValidator::Invalid; | ||
| 286 | |||
| 287 | // Make sure we are actually at the end of this string... | ||
| 288 | strpos += num_regexp.matchedLength(); | ||
| 289 | |||
| 290 | if (!suffix.isEmpty() && input.mid(strpos) != suffix) { | ||
| 291 | return QValidator::Invalid; | ||
| 292 | } else { | ||
| 293 | strpos += suffix.length(); | ||
| 294 | } | ||
| 295 | |||
| 296 | if (strpos != input.length()) | ||
| 297 | return QValidator::Invalid; | ||
| 298 | |||
| 299 | // At this point we can say for sure that the input is fine. Let's fix it up a bit though | ||
| 300 | input.replace(num_pos, sub_input.length(), sub_input.toUpper()); | ||
| 301 | |||
| 302 | return QValidator::Acceptable; | ||
| 303 | } | ||
diff --git a/src/citra_qt/util/spinbox.hxx b/src/citra_qt/util/spinbox.hxx new file mode 100644 index 000000000..68f5b9894 --- /dev/null +++ b/src/citra_qt/util/spinbox.hxx | |||
| @@ -0,0 +1,88 @@ | |||
| 1 | // Licensed under GPLv2+ | ||
| 2 | // Refer to the license.txt file included. | ||
| 3 | |||
| 4 | |||
| 5 | // Copyright 2014 Tony Wasserka | ||
| 6 | // All rights reserved. | ||
| 7 | // | ||
| 8 | // Redistribution and use in source and binary forms, with or without | ||
| 9 | // modification, are permitted provided that the following conditions are met: | ||
| 10 | // | ||
| 11 | // * Redistributions of source code must retain the above copyright | ||
| 12 | // notice, this list of conditions and the following disclaimer. | ||
| 13 | // * Redistributions in binary form must reproduce the above copyright | ||
| 14 | // notice, this list of conditions and the following disclaimer in the | ||
| 15 | // documentation and/or other materials provided with the distribution. | ||
| 16 | // * Neither the name of the owner nor the names of its contributors may | ||
| 17 | // be used to endorse or promote products derived from this software | ||
| 18 | // without specific prior written permission. | ||
| 19 | // | ||
| 20 | // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| 21 | // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| 22 | // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
| 23 | // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
| 24 | // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
| 25 | // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| 26 | // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
| 27 | // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| 28 | // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| 29 | // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| 30 | // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| 31 | |||
| 32 | |||
| 33 | #pragma once | ||
| 34 | |||
| 35 | #include <QAbstractSpinBox> | ||
| 36 | #include <QtGlobal> | ||
| 37 | |||
| 38 | class QVariant; | ||
| 39 | |||
| 40 | /** | ||
| 41 | * A custom spin box widget with enhanced functionality over Qt's QSpinBox | ||
| 42 | */ | ||
| 43 | class CSpinBox : public QAbstractSpinBox { | ||
| 44 | Q_OBJECT | ||
| 45 | |||
| 46 | public: | ||
| 47 | CSpinBox(QWidget* parent = nullptr); | ||
| 48 | |||
| 49 | void stepBy(int steps) override; | ||
| 50 | StepEnabled stepEnabled() const override; | ||
| 51 | |||
| 52 | void SetValue(qint64 val); | ||
| 53 | |||
| 54 | void SetRange(qint64 min, qint64 max); | ||
| 55 | |||
| 56 | void SetBase(int base); | ||
| 57 | |||
| 58 | void SetPrefix(const QString& prefix); | ||
| 59 | void SetSuffix(const QString& suffix); | ||
| 60 | |||
| 61 | void SetNumDigits(int num_digits); | ||
| 62 | |||
| 63 | QValidator::State validate(QString& input, int& pos) const override; | ||
| 64 | |||
| 65 | signals: | ||
| 66 | void ValueChanged(qint64 val); | ||
| 67 | |||
| 68 | private slots: | ||
| 69 | void OnEditingFinished(); | ||
| 70 | |||
| 71 | private: | ||
| 72 | void UpdateText(); | ||
| 73 | |||
| 74 | bool HasSign() const; | ||
| 75 | |||
| 76 | QString TextFromValue(); | ||
| 77 | qint64 ValueFromText(); | ||
| 78 | |||
| 79 | qint64 min_value, max_value; | ||
| 80 | |||
| 81 | qint64 value; | ||
| 82 | |||
| 83 | QString prefix, suffix; | ||
| 84 | |||
| 85 | int base; | ||
| 86 | |||
| 87 | int num_digits; | ||
| 88 | }; | ||