diff options
Diffstat (limited to 'src/audio_core')
4 files changed, 4 insertions, 13 deletions
diff --git a/src/audio_core/CMakeLists.txt b/src/audio_core/CMakeLists.txt index 144f1bab2..0a1f3bf18 100644 --- a/src/audio_core/CMakeLists.txt +++ b/src/audio_core/CMakeLists.txt | |||
| @@ -206,20 +206,11 @@ if (MSVC) | |||
| 206 | /we4244 # 'conversion': conversion from 'type1' to 'type2', possible loss of data | 206 | /we4244 # 'conversion': conversion from 'type1' to 'type2', possible loss of data |
| 207 | /we4245 # 'conversion': conversion from 'type1' to 'type2', signed/unsigned mismatch | 207 | /we4245 # 'conversion': conversion from 'type1' to 'type2', signed/unsigned mismatch |
| 208 | /we4254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data | 208 | /we4254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data |
| 209 | /we4456 # Declaration of 'identifier' hides previous local declaration | 209 | /we4800 # Implicit conversion from 'type' to bool. Possible information loss |
| 210 | /we4457 # Declaration of 'identifier' hides function parameter | ||
| 211 | /we4458 # Declaration of 'identifier' hides class member | ||
| 212 | /we4459 # Declaration of 'identifier' hides global declaration | ||
| 213 | ) | 210 | ) |
| 214 | else() | 211 | else() |
| 215 | target_compile_options(audio_core PRIVATE | 212 | target_compile_options(audio_core PRIVATE |
| 216 | -Werror=conversion | 213 | -Werror=conversion |
| 217 | -Werror=ignored-qualifiers | ||
| 218 | -Werror=shadow | ||
| 219 | -Werror=unused-variable | ||
| 220 | |||
| 221 | $<$<CXX_COMPILER_ID:GNU>:-Werror=unused-but-set-parameter> | ||
| 222 | $<$<CXX_COMPILER_ID:GNU>:-Werror=unused-but-set-variable> | ||
| 223 | 214 | ||
| 224 | -Wno-sign-conversion | 215 | -Wno-sign-conversion |
| 225 | ) | 216 | ) |
diff --git a/src/audio_core/renderer/behavior/info_updater.cpp b/src/audio_core/renderer/behavior/info_updater.cpp index c0a307b89..574cf0982 100644 --- a/src/audio_core/renderer/behavior/info_updater.cpp +++ b/src/audio_core/renderer/behavior/info_updater.cpp | |||
| @@ -91,7 +91,7 @@ Result InfoUpdater::UpdateVoices(VoiceContext& voice_context, | |||
| 91 | voice_info.Initialize(); | 91 | voice_info.Initialize(); |
| 92 | 92 | ||
| 93 | for (u32 channel = 0; channel < in_param.channel_count; channel++) { | 93 | for (u32 channel = 0; channel < in_param.channel_count; channel++) { |
| 94 | std::memset(voice_states[channel], 0, sizeof(VoiceState)); | 94 | *voice_states[channel] = {}; |
| 95 | } | 95 | } |
| 96 | } | 96 | } |
| 97 | 97 | ||
diff --git a/src/audio_core/renderer/command/effect/biquad_filter.cpp b/src/audio_core/renderer/command/effect/biquad_filter.cpp index 1baae74fd..edb30ce72 100644 --- a/src/audio_core/renderer/command/effect/biquad_filter.cpp +++ b/src/audio_core/renderer/command/effect/biquad_filter.cpp | |||
| @@ -94,7 +94,7 @@ void BiquadFilterCommand::Dump([[maybe_unused]] const ADSP::CommandListProcessor | |||
| 94 | void BiquadFilterCommand::Process(const ADSP::CommandListProcessor& processor) { | 94 | void BiquadFilterCommand::Process(const ADSP::CommandListProcessor& processor) { |
| 95 | auto state_{reinterpret_cast<VoiceState::BiquadFilterState*>(state)}; | 95 | auto state_{reinterpret_cast<VoiceState::BiquadFilterState*>(state)}; |
| 96 | if (needs_init) { | 96 | if (needs_init) { |
| 97 | std::memset(state_, 0, sizeof(VoiceState::BiquadFilterState)); | 97 | *state_ = {}; |
| 98 | } | 98 | } |
| 99 | 99 | ||
| 100 | auto input_buffer{ | 100 | auto input_buffer{ |
diff --git a/src/audio_core/renderer/command/effect/multi_tap_biquad_filter.cpp b/src/audio_core/renderer/command/effect/multi_tap_biquad_filter.cpp index b3c3ba4ba..48a7cba8a 100644 --- a/src/audio_core/renderer/command/effect/multi_tap_biquad_filter.cpp +++ b/src/audio_core/renderer/command/effect/multi_tap_biquad_filter.cpp | |||
| @@ -30,7 +30,7 @@ void MultiTapBiquadFilterCommand::Process(const ADSP::CommandListProcessor& proc | |||
| 30 | for (u32 i = 0; i < filter_tap_count; i++) { | 30 | for (u32 i = 0; i < filter_tap_count; i++) { |
| 31 | auto state{reinterpret_cast<VoiceState::BiquadFilterState*>(states[i])}; | 31 | auto state{reinterpret_cast<VoiceState::BiquadFilterState*>(states[i])}; |
| 32 | if (needs_init[i]) { | 32 | if (needs_init[i]) { |
| 33 | std::memset(state, 0, sizeof(VoiceState::BiquadFilterState)); | 33 | *state = {}; |
| 34 | } | 34 | } |
| 35 | 35 | ||
| 36 | ApplyBiquadFilterFloat(output_buffer, input_buffer, biquads[i].b, biquads[i].a, *state, | 36 | ApplyBiquadFilterFloat(output_buffer, input_buffer, biquads[i].b, biquads[i].a, *state, |