diff options
| -rw-r--r-- | src/common/lz4_compression.cpp | 21 | ||||
| -rw-r--r-- | src/common/lz4_compression.h | 10 | ||||
| -rw-r--r-- | src/common/zstd_compression.cpp | 13 | ||||
| -rw-r--r-- | src/common/zstd_compression.h | 7 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/gl_shader_disk_cache.cpp | 3 |
5 files changed, 24 insertions, 30 deletions
diff --git a/src/common/lz4_compression.cpp b/src/common/lz4_compression.cpp index ade6759bb..8e2e4094b 100644 --- a/src/common/lz4_compression.cpp +++ b/src/common/lz4_compression.cpp | |||
| @@ -10,14 +10,14 @@ | |||
| 10 | 10 | ||
| 11 | namespace Common::Compression { | 11 | namespace Common::Compression { |
| 12 | 12 | ||
| 13 | std::vector<u8> CompressDataLZ4(const u8* source, std::size_t source_size) { | 13 | std::vector<u8> CompressDataLZ4(std::span<const u8> source) { |
| 14 | ASSERT_MSG(source_size <= LZ4_MAX_INPUT_SIZE, "Source size exceeds LZ4 maximum input size"); | 14 | ASSERT_MSG(source.size() <= LZ4_MAX_INPUT_SIZE, "Source size exceeds LZ4 maximum input size"); |
| 15 | 15 | ||
| 16 | const auto source_size_int = static_cast<int>(source_size); | 16 | const auto source_size_int = static_cast<int>(source.size()); |
| 17 | const int max_compressed_size = LZ4_compressBound(source_size_int); | 17 | const int max_compressed_size = LZ4_compressBound(source_size_int); |
| 18 | std::vector<u8> compressed(max_compressed_size); | 18 | std::vector<u8> compressed(max_compressed_size); |
| 19 | 19 | ||
| 20 | const int compressed_size = LZ4_compress_default(reinterpret_cast<const char*>(source), | 20 | const int compressed_size = LZ4_compress_default(reinterpret_cast<const char*>(source.data()), |
| 21 | reinterpret_cast<char*>(compressed.data()), | 21 | reinterpret_cast<char*>(compressed.data()), |
| 22 | source_size_int, max_compressed_size); | 22 | source_size_int, max_compressed_size); |
| 23 | 23 | ||
| @@ -31,18 +31,17 @@ std::vector<u8> CompressDataLZ4(const u8* source, std::size_t source_size) { | |||
| 31 | return compressed; | 31 | return compressed; |
| 32 | } | 32 | } |
| 33 | 33 | ||
| 34 | std::vector<u8> CompressDataLZ4HC(const u8* source, std::size_t source_size, | 34 | std::vector<u8> CompressDataLZ4HC(std::span<const u8> source, s32 compression_level) { |
| 35 | s32 compression_level) { | 35 | ASSERT_MSG(source.size() <= LZ4_MAX_INPUT_SIZE, "Source size exceeds LZ4 maximum input size"); |
| 36 | ASSERT_MSG(source_size <= LZ4_MAX_INPUT_SIZE, "Source size exceeds LZ4 maximum input size"); | ||
| 37 | 36 | ||
| 38 | compression_level = std::clamp(compression_level, LZ4HC_CLEVEL_MIN, LZ4HC_CLEVEL_MAX); | 37 | compression_level = std::clamp(compression_level, LZ4HC_CLEVEL_MIN, LZ4HC_CLEVEL_MAX); |
| 39 | 38 | ||
| 40 | const auto source_size_int = static_cast<int>(source_size); | 39 | const auto source_size_int = static_cast<int>(source.size()); |
| 41 | const int max_compressed_size = LZ4_compressBound(source_size_int); | 40 | const int max_compressed_size = LZ4_compressBound(source_size_int); |
| 42 | std::vector<u8> compressed(max_compressed_size); | 41 | std::vector<u8> compressed(max_compressed_size); |
| 43 | 42 | ||
| 44 | const int compressed_size = LZ4_compress_HC( | 43 | const int compressed_size = LZ4_compress_HC( |
| 45 | reinterpret_cast<const char*>(source), reinterpret_cast<char*>(compressed.data()), | 44 | reinterpret_cast<const char*>(source.data()), reinterpret_cast<char*>(compressed.data()), |
| 46 | source_size_int, max_compressed_size, compression_level); | 45 | source_size_int, max_compressed_size, compression_level); |
| 47 | 46 | ||
| 48 | if (compressed_size <= 0) { | 47 | if (compressed_size <= 0) { |
| @@ -55,8 +54,8 @@ std::vector<u8> CompressDataLZ4HC(const u8* source, std::size_t source_size, | |||
| 55 | return compressed; | 54 | return compressed; |
| 56 | } | 55 | } |
| 57 | 56 | ||
| 58 | std::vector<u8> CompressDataLZ4HCMax(const u8* source, std::size_t source_size) { | 57 | std::vector<u8> CompressDataLZ4HCMax(std::span<const u8> source) { |
| 59 | return CompressDataLZ4HC(source, source_size, LZ4HC_CLEVEL_MAX); | 58 | return CompressDataLZ4HC(source, LZ4HC_CLEVEL_MAX); |
| 60 | } | 59 | } |
| 61 | 60 | ||
| 62 | std::vector<u8> DecompressDataLZ4(const std::vector<u8>& compressed, | 61 | std::vector<u8> DecompressDataLZ4(const std::vector<u8>& compressed, |
diff --git a/src/common/lz4_compression.h b/src/common/lz4_compression.h index 4c16f6e03..173f9b9ad 100644 --- a/src/common/lz4_compression.h +++ b/src/common/lz4_compression.h | |||
| @@ -4,6 +4,7 @@ | |||
| 4 | 4 | ||
| 5 | #pragma once | 5 | #pragma once |
| 6 | 6 | ||
| 7 | #include <span> | ||
| 7 | #include <vector> | 8 | #include <vector> |
| 8 | 9 | ||
| 9 | #include "common/common_types.h" | 10 | #include "common/common_types.h" |
| @@ -14,11 +15,10 @@ namespace Common::Compression { | |||
| 14 | * Compresses a source memory region with LZ4 and returns the compressed data in a vector. | 15 | * Compresses a source memory region with LZ4 and returns the compressed data in a vector. |
| 15 | * | 16 | * |
| 16 | * @param source the uncompressed source memory region. | 17 | * @param source the uncompressed source memory region. |
| 17 | * @param source_size the size in bytes of the uncompressed source memory region. | ||
| 18 | * | 18 | * |
| 19 | * @return the compressed data. | 19 | * @return the compressed data. |
| 20 | */ | 20 | */ |
| 21 | std::vector<u8> CompressDataLZ4(const u8* source, std::size_t source_size); | 21 | std::vector<u8> CompressDataLZ4(std::span<const u8> source); |
| 22 | 22 | ||
| 23 | /** | 23 | /** |
| 24 | * Utilizes the LZ4 subalgorithm LZ4HC with the specified compression level. Higher compression | 24 | * Utilizes the LZ4 subalgorithm LZ4HC with the specified compression level. Higher compression |
| @@ -27,22 +27,20 @@ std::vector<u8> CompressDataLZ4(const u8* source, std::size_t source_size); | |||
| 27 | * also be decompressed with the default LZ4 decompression. | 27 | * also be decompressed with the default LZ4 decompression. |
| 28 | * | 28 | * |
| 29 | * @param source the uncompressed source memory region. | 29 | * @param source the uncompressed source memory region. |
| 30 | * @param source_size the size in bytes of the uncompressed source memory region. | ||
| 31 | * @param compression_level the used compression level. Should be between 3 and 12. | 30 | * @param compression_level the used compression level. Should be between 3 and 12. |
| 32 | * | 31 | * |
| 33 | * @return the compressed data. | 32 | * @return the compressed data. |
| 34 | */ | 33 | */ |
| 35 | std::vector<u8> CompressDataLZ4HC(const u8* source, std::size_t source_size, s32 compression_level); | 34 | std::vector<u8> CompressDataLZ4HC(std::span<const u8> source, s32 compression_level); |
| 36 | 35 | ||
| 37 | /** | 36 | /** |
| 38 | * Utilizes the LZ4 subalgorithm LZ4HC with the highest possible compression level. | 37 | * Utilizes the LZ4 subalgorithm LZ4HC with the highest possible compression level. |
| 39 | * | 38 | * |
| 40 | * @param source the uncompressed source memory region. | 39 | * @param source the uncompressed source memory region. |
| 41 | * @param source_size the size in bytes of the uncompressed source memory region. | ||
| 42 | * | 40 | * |
| 43 | * @return the compressed data. | 41 | * @return the compressed data. |
| 44 | */ | 42 | */ |
| 45 | std::vector<u8> CompressDataLZ4HCMax(const u8* source, std::size_t source_size); | 43 | std::vector<u8> CompressDataLZ4HCMax(std::span<const u8> source); |
| 46 | 44 | ||
| 47 | /** | 45 | /** |
| 48 | * Decompresses a source memory region with LZ4 and returns the uncompressed data in a vector. | 46 | * Decompresses a source memory region with LZ4 and returns the uncompressed data in a vector. |
diff --git a/src/common/zstd_compression.cpp b/src/common/zstd_compression.cpp index 978526492..770833ee7 100644 --- a/src/common/zstd_compression.cpp +++ b/src/common/zstd_compression.cpp | |||
| @@ -5,19 +5,18 @@ | |||
| 5 | #include <algorithm> | 5 | #include <algorithm> |
| 6 | #include <zstd.h> | 6 | #include <zstd.h> |
| 7 | 7 | ||
| 8 | #include "common/assert.h" | ||
| 9 | #include "common/zstd_compression.h" | 8 | #include "common/zstd_compression.h" |
| 10 | 9 | ||
| 11 | namespace Common::Compression { | 10 | namespace Common::Compression { |
| 12 | 11 | ||
| 13 | std::vector<u8> CompressDataZSTD(const u8* source, std::size_t source_size, s32 compression_level) { | 12 | std::vector<u8> CompressDataZSTD(std::span<const u8> source, s32 compression_level) { |
| 14 | compression_level = std::clamp(compression_level, 1, ZSTD_maxCLevel()); | 13 | compression_level = std::clamp(compression_level, 1, ZSTD_maxCLevel()); |
| 15 | 14 | ||
| 16 | const std::size_t max_compressed_size = ZSTD_compressBound(source_size); | 15 | const std::size_t max_compressed_size = ZSTD_compressBound(source.size()); |
| 17 | std::vector<u8> compressed(max_compressed_size); | 16 | std::vector<u8> compressed(max_compressed_size); |
| 18 | 17 | ||
| 19 | const std::size_t compressed_size = | 18 | const std::size_t compressed_size = ZSTD_compress( |
| 20 | ZSTD_compress(compressed.data(), compressed.size(), source, source_size, compression_level); | 19 | compressed.data(), compressed.size(), source.data(), source.size(), compression_level); |
| 21 | 20 | ||
| 22 | if (ZSTD_isError(compressed_size)) { | 21 | if (ZSTD_isError(compressed_size)) { |
| 23 | // Compression failed | 22 | // Compression failed |
| @@ -29,8 +28,8 @@ std::vector<u8> CompressDataZSTD(const u8* source, std::size_t source_size, s32 | |||
| 29 | return compressed; | 28 | return compressed; |
| 30 | } | 29 | } |
| 31 | 30 | ||
| 32 | std::vector<u8> CompressDataZSTDDefault(const u8* source, std::size_t source_size) { | 31 | std::vector<u8> CompressDataZSTDDefault(std::span<const u8> source) { |
| 33 | return CompressDataZSTD(source, source_size, ZSTD_CLEVEL_DEFAULT); | 32 | return CompressDataZSTD(source, ZSTD_CLEVEL_DEFAULT); |
| 34 | } | 33 | } |
| 35 | 34 | ||
| 36 | std::vector<u8> DecompressDataZSTD(const std::vector<u8>& compressed) { | 35 | std::vector<u8> DecompressDataZSTD(const std::vector<u8>& compressed) { |
diff --git a/src/common/zstd_compression.h b/src/common/zstd_compression.h index e9de941c8..b5edf19e7 100644 --- a/src/common/zstd_compression.h +++ b/src/common/zstd_compression.h | |||
| @@ -4,6 +4,7 @@ | |||
| 4 | 4 | ||
| 5 | #pragma once | 5 | #pragma once |
| 6 | 6 | ||
| 7 | #include <span> | ||
| 7 | #include <vector> | 8 | #include <vector> |
| 8 | 9 | ||
| 9 | #include "common/common_types.h" | 10 | #include "common/common_types.h" |
| @@ -14,23 +15,21 @@ namespace Common::Compression { | |||
| 14 | * Compresses a source memory region with Zstandard and returns the compressed data in a vector. | 15 | * Compresses a source memory region with Zstandard and returns the compressed data in a vector. |
| 15 | * | 16 | * |
| 16 | * @param source the uncompressed source memory region. | 17 | * @param source the uncompressed source memory region. |
| 17 | * @param source_size the size in bytes of the uncompressed source memory region. | ||
| 18 | * @param compression_level the used compression level. Should be between 1 and 22. | 18 | * @param compression_level the used compression level. Should be between 1 and 22. |
| 19 | * | 19 | * |
| 20 | * @return the compressed data. | 20 | * @return the compressed data. |
| 21 | */ | 21 | */ |
| 22 | std::vector<u8> CompressDataZSTD(const u8* source, std::size_t source_size, s32 compression_level); | 22 | std::vector<u8> CompressDataZSTD(std::span<const u8> source, s32 compression_level); |
| 23 | 23 | ||
| 24 | /** | 24 | /** |
| 25 | * Compresses a source memory region with Zstandard with the default compression level and returns | 25 | * Compresses a source memory region with Zstandard with the default compression level and returns |
| 26 | * the compressed data in a vector. | 26 | * the compressed data in a vector. |
| 27 | * | 27 | * |
| 28 | * @param source the uncompressed source memory region. | 28 | * @param source the uncompressed source memory region. |
| 29 | * @param source_size the size in bytes of the uncompressed source memory region. | ||
| 30 | * | 29 | * |
| 31 | * @return the compressed data. | 30 | * @return the compressed data. |
| 32 | */ | 31 | */ |
| 33 | std::vector<u8> CompressDataZSTDDefault(const u8* source, std::size_t source_size); | 32 | std::vector<u8> CompressDataZSTDDefault(std::span<const u8> source); |
| 34 | 33 | ||
| 35 | /** | 34 | /** |
| 36 | * Decompresses a source memory region with Zstandard and returns the uncompressed data in a vector. | 35 | * Decompresses a source memory region with Zstandard and returns the uncompressed data in a vector. |
diff --git a/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp b/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp index 2dcc2b0eb..c0e73789b 100644 --- a/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp +++ b/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp | |||
| @@ -422,8 +422,7 @@ void ShaderDiskCacheOpenGL::SavePrecompiledHeaderToVirtualPrecompiledCache() { | |||
| 422 | void ShaderDiskCacheOpenGL::SaveVirtualPrecompiledFile() { | 422 | void ShaderDiskCacheOpenGL::SaveVirtualPrecompiledFile() { |
| 423 | precompiled_cache_virtual_file_offset = 0; | 423 | precompiled_cache_virtual_file_offset = 0; |
| 424 | const std::vector<u8> uncompressed = precompiled_cache_virtual_file.ReadAllBytes(); | 424 | const std::vector<u8> uncompressed = precompiled_cache_virtual_file.ReadAllBytes(); |
| 425 | const std::vector<u8> compressed = | 425 | const std::vector<u8> compressed = Common::Compression::CompressDataZSTDDefault(uncompressed); |
| 426 | Common::Compression::CompressDataZSTDDefault(uncompressed.data(), uncompressed.size()); | ||
| 427 | 426 | ||
| 428 | const auto precompiled_path{GetPrecompiledPath()}; | 427 | const auto precompiled_path{GetPrecompiledPath()}; |
| 429 | FileUtil::IOFile file(precompiled_path, "wb"); | 428 | FileUtil::IOFile file(precompiled_path, "wb"); |