diff options
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_master_semaphore.cpp | 18 | ||||
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_master_semaphore.h | 9 |
2 files changed, 8 insertions, 19 deletions
diff --git a/src/video_core/renderer_vulkan/vk_master_semaphore.cpp b/src/video_core/renderer_vulkan/vk_master_semaphore.cpp index db78ce3d9..6852c11b0 100644 --- a/src/video_core/renderer_vulkan/vk_master_semaphore.cpp +++ b/src/video_core/renderer_vulkan/vk_master_semaphore.cpp | |||
| @@ -2,8 +2,7 @@ | |||
| 2 | // Licensed under GPLv2 or any later version | 2 | // Licensed under GPLv2 or any later version |
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include <atomic> | 5 | #include <thread> |
| 6 | #include <chrono> | ||
| 7 | 6 | ||
| 8 | #include "common/settings.h" | 7 | #include "common/settings.h" |
| 9 | #include "video_core/renderer_vulkan/vk_master_semaphore.h" | 8 | #include "video_core/renderer_vulkan/vk_master_semaphore.h" |
| @@ -12,8 +11,6 @@ | |||
| 12 | 11 | ||
| 13 | namespace Vulkan { | 12 | namespace Vulkan { |
| 14 | 13 | ||
| 15 | using namespace std::chrono_literals; | ||
| 16 | |||
| 17 | MasterSemaphore::MasterSemaphore(const Device& device) { | 14 | MasterSemaphore::MasterSemaphore(const Device& device) { |
| 18 | static constexpr VkSemaphoreTypeCreateInfoKHR semaphore_type_ci{ | 15 | static constexpr VkSemaphoreTypeCreateInfoKHR semaphore_type_ci{ |
| 19 | .sType = VK_STRUCTURE_TYPE_SEMAPHORE_TYPE_CREATE_INFO_KHR, | 16 | .sType = VK_STRUCTURE_TYPE_SEMAPHORE_TYPE_CREATE_INFO_KHR, |
| @@ -34,9 +31,9 @@ MasterSemaphore::MasterSemaphore(const Device& device) { | |||
| 34 | // Validation layers have a bug where they fail to track resource usage when using timeline | 31 | // Validation layers have a bug where they fail to track resource usage when using timeline |
| 35 | // semaphores and synchronizing with GetSemaphoreCounterValueKHR. To workaround this issue, have | 32 | // semaphores and synchronizing with GetSemaphoreCounterValueKHR. To workaround this issue, have |
| 36 | // a separate thread waiting for each timeline semaphore value. | 33 | // a separate thread waiting for each timeline semaphore value. |
| 37 | debug_thread = std::thread([this] { | 34 | debug_thread = std::jthread([this](std::stop_token stop_token) { |
| 38 | u64 counter = 0; | 35 | u64 counter = 0; |
| 39 | while (!shutdown) { | 36 | while (!stop_token.stop_requested()) { |
| 40 | if (semaphore.Wait(counter, 10'000'000)) { | 37 | if (semaphore.Wait(counter, 10'000'000)) { |
| 41 | ++counter; | 38 | ++counter; |
| 42 | } | 39 | } |
| @@ -44,13 +41,6 @@ MasterSemaphore::MasterSemaphore(const Device& device) { | |||
| 44 | }); | 41 | }); |
| 45 | } | 42 | } |
| 46 | 43 | ||
| 47 | MasterSemaphore::~MasterSemaphore() { | 44 | MasterSemaphore::~MasterSemaphore() = default; |
| 48 | shutdown = true; | ||
| 49 | |||
| 50 | // This thread might not be started | ||
| 51 | if (debug_thread.joinable()) { | ||
| 52 | debug_thread.join(); | ||
| 53 | } | ||
| 54 | } | ||
| 55 | 45 | ||
| 56 | } // namespace Vulkan | 46 | } // namespace Vulkan |
diff --git a/src/video_core/renderer_vulkan/vk_master_semaphore.h b/src/video_core/renderer_vulkan/vk_master_semaphore.h index 4b6d64daa..ee3cd35d0 100644 --- a/src/video_core/renderer_vulkan/vk_master_semaphore.h +++ b/src/video_core/renderer_vulkan/vk_master_semaphore.h | |||
| @@ -65,11 +65,10 @@ public: | |||
| 65 | } | 65 | } |
| 66 | 66 | ||
| 67 | private: | 67 | private: |
| 68 | vk::Semaphore semaphore; ///< Timeline semaphore. | 68 | vk::Semaphore semaphore; ///< Timeline semaphore. |
| 69 | std::atomic<u64> gpu_tick{0}; ///< Current known GPU tick. | 69 | std::atomic<u64> gpu_tick{0}; ///< Current known GPU tick. |
| 70 | std::atomic<u64> current_tick{1}; ///< Current logical tick. | 70 | std::atomic<u64> current_tick{1}; ///< Current logical tick. |
| 71 | std::atomic<bool> shutdown{false}; ///< True when the object is being destroyed. | 71 | std::jthread debug_thread; ///< Debug thread to workaround validation layer bugs. |
| 72 | std::thread debug_thread; ///< Debug thread to workaround validation layer bugs. | ||
| 73 | }; | 72 | }; |
| 74 | 73 | ||
| 75 | } // namespace Vulkan | 74 | } // namespace Vulkan |