diff options
24 files changed, 240 insertions, 30 deletions
diff --git a/src/core/core.cpp b/src/core/core.cpp index 06fba4ce5..b5f62690e 100644 --- a/src/core/core.cpp +++ b/src/core/core.cpp | |||
| @@ -612,6 +612,10 @@ void System::PrepareReschedule(const u32 core_index) { | |||
| 612 | impl->kernel.PrepareReschedule(core_index); | 612 | impl->kernel.PrepareReschedule(core_index); |
| 613 | } | 613 | } |
| 614 | 614 | ||
| 615 | size_t System::GetCurrentHostThreadID() const { | ||
| 616 | return impl->kernel.GetCurrentHostThreadID(); | ||
| 617 | } | ||
| 618 | |||
| 615 | PerfStatsResults System::GetAndResetPerfStats() { | 619 | PerfStatsResults System::GetAndResetPerfStats() { |
| 616 | return impl->GetAndResetPerfStats(); | 620 | return impl->GetAndResetPerfStats(); |
| 617 | } | 621 | } |
diff --git a/src/core/core.h b/src/core/core.h index 4a5aba032..4f153154f 100644 --- a/src/core/core.h +++ b/src/core/core.h | |||
| @@ -222,6 +222,8 @@ public: | |||
| 222 | /// Prepare the core emulation for a reschedule | 222 | /// Prepare the core emulation for a reschedule |
| 223 | void PrepareReschedule(u32 core_index); | 223 | void PrepareReschedule(u32 core_index); |
| 224 | 224 | ||
| 225 | [[nodiscard]] size_t GetCurrentHostThreadID() const; | ||
| 226 | |||
| 225 | /// Gets and resets core performance statistics | 227 | /// Gets and resets core performance statistics |
| 226 | [[nodiscard]] PerfStatsResults GetAndResetPerfStats(); | 228 | [[nodiscard]] PerfStatsResults GetAndResetPerfStats(); |
| 227 | 229 | ||
diff --git a/src/core/memory.cpp b/src/core/memory.cpp index a9667463f..7b79cb8bc 100644 --- a/src/core/memory.cpp +++ b/src/core/memory.cpp | |||
| @@ -13,10 +13,13 @@ | |||
| 13 | #include "common/swap.h" | 13 | #include "common/swap.h" |
| 14 | #include "core/core.h" | 14 | #include "core/core.h" |
| 15 | #include "core/device_memory.h" | 15 | #include "core/device_memory.h" |
| 16 | #include "core/hardware_properties.h" | ||
| 16 | #include "core/hle/kernel/k_page_table.h" | 17 | #include "core/hle/kernel/k_page_table.h" |
| 17 | #include "core/hle/kernel/k_process.h" | 18 | #include "core/hle/kernel/k_process.h" |
| 18 | #include "core/memory.h" | 19 | #include "core/memory.h" |
| 19 | #include "video_core/gpu.h" | 20 | #include "video_core/gpu.h" |
| 21 | #include "video_core/rasterizer_download_area.h" | ||
| 22 | |||
| 20 | 23 | ||
| 21 | namespace Core::Memory { | 24 | namespace Core::Memory { |
| 22 | 25 | ||
| @@ -243,7 +246,7 @@ struct Memory::Impl { | |||
| 243 | [&](const Common::ProcessAddress current_vaddr, const std::size_t copy_amount, | 246 | [&](const Common::ProcessAddress current_vaddr, const std::size_t copy_amount, |
| 244 | const u8* const host_ptr) { | 247 | const u8* const host_ptr) { |
| 245 | if constexpr (!UNSAFE) { | 248 | if constexpr (!UNSAFE) { |
| 246 | system.GPU().FlushRegion(GetInteger(current_vaddr), copy_amount); | 249 | HandleRasterizerDownload(GetInteger(current_vaddr), copy_amount); |
| 247 | } | 250 | } |
| 248 | std::memcpy(dest_buffer, host_ptr, copy_amount); | 251 | std::memcpy(dest_buffer, host_ptr, copy_amount); |
| 249 | }, | 252 | }, |
| @@ -334,7 +337,7 @@ struct Memory::Impl { | |||
| 334 | }, | 337 | }, |
| 335 | [&](const Common::ProcessAddress current_vaddr, const std::size_t copy_amount, | 338 | [&](const Common::ProcessAddress current_vaddr, const std::size_t copy_amount, |
| 336 | u8* const host_ptr) { | 339 | u8* const host_ptr) { |
| 337 | system.GPU().FlushRegion(GetInteger(current_vaddr), copy_amount); | 340 | HandleRasterizerDownload(GetInteger(current_vaddr), copy_amount); |
| 338 | WriteBlockImpl<false>(process, dest_addr, host_ptr, copy_amount); | 341 | WriteBlockImpl<false>(process, dest_addr, host_ptr, copy_amount); |
| 339 | }, | 342 | }, |
| 340 | [&](const std::size_t copy_amount) { | 343 | [&](const std::size_t copy_amount) { |
| @@ -373,7 +376,7 @@ struct Memory::Impl { | |||
| 373 | const std::size_t block_size) { | 376 | const std::size_t block_size) { |
| 374 | // dc ivac: Invalidate to point of coherency | 377 | // dc ivac: Invalidate to point of coherency |
| 375 | // GPU flush -> CPU invalidate | 378 | // GPU flush -> CPU invalidate |
| 376 | system.GPU().FlushRegion(GetInteger(current_vaddr), block_size); | 379 | HandleRasterizerDownload(GetInteger(current_vaddr), block_size); |
| 377 | }; | 380 | }; |
| 378 | return PerformCacheOperation(process, dest_addr, size, on_rasterizer); | 381 | return PerformCacheOperation(process, dest_addr, size, on_rasterizer); |
| 379 | } | 382 | } |
| @@ -462,8 +465,7 @@ struct Memory::Impl { | |||
| 462 | } | 465 | } |
| 463 | 466 | ||
| 464 | if (Settings::IsFastmemEnabled()) { | 467 | if (Settings::IsFastmemEnabled()) { |
| 465 | const bool is_read_enable = !Settings::IsGPULevelExtreme() || !cached; | 468 | system.DeviceMemory().buffer.Protect(vaddr, size, !cached, !cached); |
| 466 | system.DeviceMemory().buffer.Protect(vaddr, size, is_read_enable, !cached); | ||
| 467 | } | 469 | } |
| 468 | 470 | ||
| 469 | // Iterate over a contiguous CPU address space, which corresponds to the specified GPU | 471 | // Iterate over a contiguous CPU address space, which corresponds to the specified GPU |
| @@ -651,7 +653,9 @@ struct Memory::Impl { | |||
| 651 | LOG_ERROR(HW_Memory, "Unmapped Read{} @ 0x{:016X}", sizeof(T) * 8, | 653 | LOG_ERROR(HW_Memory, "Unmapped Read{} @ 0x{:016X}", sizeof(T) * 8, |
| 652 | GetInteger(vaddr)); | 654 | GetInteger(vaddr)); |
| 653 | }, | 655 | }, |
| 654 | [&]() { system.GPU().FlushRegion(GetInteger(vaddr), sizeof(T)); }); | 656 | [&]() { |
| 657 | HandleRasterizerDownload(GetInteger(vaddr), sizeof(T)); | ||
| 658 | }); | ||
| 655 | if (ptr) { | 659 | if (ptr) { |
| 656 | std::memcpy(&result, ptr, sizeof(T)); | 660 | std::memcpy(&result, ptr, sizeof(T)); |
| 657 | } | 661 | } |
| @@ -712,7 +716,18 @@ struct Memory::Impl { | |||
| 712 | return true; | 716 | return true; |
| 713 | } | 717 | } |
| 714 | 718 | ||
| 719 | void HandleRasterizerDownload(VAddr address, size_t size) { | ||
| 720 | const size_t core = system.GetCurrentHostThreadID(); | ||
| 721 | auto& current_area = rasterizer_areas[core]; | ||
| 722 | const VAddr end_address = address + size; | ||
| 723 | if (current_area.start_address <= address && end_address <= current_area.end_address) [[likely]] { | ||
| 724 | return; | ||
| 725 | } | ||
| 726 | current_area = system.GPU().OnCPURead(address, size); | ||
| 727 | } | ||
| 728 | |||
| 715 | Common::PageTable* current_page_table = nullptr; | 729 | Common::PageTable* current_page_table = nullptr; |
| 730 | std::array<VideoCore::RasterizerDownloadArea, Core::Hardware::NUM_CPU_CORES> rasterizer_areas{}; | ||
| 716 | Core::System& system; | 731 | Core::System& system; |
| 717 | }; | 732 | }; |
| 718 | 733 | ||
diff --git a/src/video_core/buffer_cache/buffer_base.h b/src/video_core/buffer_cache/buffer_base.h index 9cbd95c4b..0bb3bf8ae 100644 --- a/src/video_core/buffer_cache/buffer_base.h +++ b/src/video_core/buffer_cache/buffer_base.h | |||
| @@ -18,6 +18,7 @@ namespace VideoCommon { | |||
| 18 | enum class BufferFlagBits { | 18 | enum class BufferFlagBits { |
| 19 | Picked = 1 << 0, | 19 | Picked = 1 << 0, |
| 20 | CachedWrites = 1 << 1, | 20 | CachedWrites = 1 << 1, |
| 21 | PreemtiveDownload = 1 << 2, | ||
| 21 | }; | 22 | }; |
| 22 | DECLARE_ENUM_FLAG_OPERATORS(BufferFlagBits) | 23 | DECLARE_ENUM_FLAG_OPERATORS(BufferFlagBits) |
| 23 | 24 | ||
| @@ -54,6 +55,10 @@ public: | |||
| 54 | flags |= BufferFlagBits::Picked; | 55 | flags |= BufferFlagBits::Picked; |
| 55 | } | 56 | } |
| 56 | 57 | ||
| 58 | void MarkPreemtiveDownload() noexcept { | ||
| 59 | flags |= BufferFlagBits::PreemtiveDownload; | ||
| 60 | } | ||
| 61 | |||
| 57 | /// Unmark buffer as picked | 62 | /// Unmark buffer as picked |
| 58 | void Unpick() noexcept { | 63 | void Unpick() noexcept { |
| 59 | flags &= ~BufferFlagBits::Picked; | 64 | flags &= ~BufferFlagBits::Picked; |
| @@ -84,6 +89,10 @@ public: | |||
| 84 | return True(flags & BufferFlagBits::CachedWrites); | 89 | return True(flags & BufferFlagBits::CachedWrites); |
| 85 | } | 90 | } |
| 86 | 91 | ||
| 92 | bool IsPreemtiveDownload() const noexcept { | ||
| 93 | return True(flags & BufferFlagBits::PreemtiveDownload); | ||
| 94 | } | ||
| 95 | |||
| 87 | /// Returns the base CPU address of the buffer | 96 | /// Returns the base CPU address of the buffer |
| 88 | [[nodiscard]] VAddr CpuAddr() const noexcept { | 97 | [[nodiscard]] VAddr CpuAddr() const noexcept { |
| 89 | return cpu_addr; | 98 | return cpu_addr; |
diff --git a/src/video_core/buffer_cache/buffer_cache.h b/src/video_core/buffer_cache/buffer_cache.h index e534e1e9c..479a1a508 100644 --- a/src/video_core/buffer_cache/buffer_cache.h +++ b/src/video_core/buffer_cache/buffer_cache.h | |||
| @@ -111,9 +111,24 @@ void BufferCache<P>::WriteMemory(VAddr cpu_addr, u64 size) { | |||
| 111 | template <class P> | 111 | template <class P> |
| 112 | void BufferCache<P>::CachedWriteMemory(VAddr cpu_addr, u64 size) { | 112 | void BufferCache<P>::CachedWriteMemory(VAddr cpu_addr, u64 size) { |
| 113 | memory_tracker.CachedCpuWrite(cpu_addr, size); | 113 | memory_tracker.CachedCpuWrite(cpu_addr, size); |
| 114 | const IntervalType add_interval{Common::AlignDown(cpu_addr, YUZU_PAGESIZE), | 114 | } |
| 115 | Common::AlignUp(cpu_addr + size, YUZU_PAGESIZE)}; | 115 | |
| 116 | cached_ranges.add(add_interval); | 116 | template <class P> |
| 117 | std::optional<VideoCore::RasterizerDownloadArea> BufferCache<P>::GetFlushArea(VAddr cpu_addr, | ||
| 118 | u64 size) { | ||
| 119 | std::optional<VideoCore::RasterizerDownloadArea> area{}; | ||
| 120 | area.emplace(); | ||
| 121 | VAddr cpu_addr_start_aligned = Common::AlignDown(cpu_addr, Core::Memory::YUZU_PAGESIZE); | ||
| 122 | VAddr cpu_addr_end_aligned = Common::AlignUp(cpu_addr + size, Core::Memory::YUZU_PAGESIZE); | ||
| 123 | area->start_address = cpu_addr_start_aligned; | ||
| 124 | area->end_address = cpu_addr_end_aligned; | ||
| 125 | if (memory_tracker.IsRegionPreflushable(cpu_addr, size)) { | ||
| 126 | area->preemtive = true; | ||
| 127 | return area; | ||
| 128 | }; | ||
| 129 | memory_tracker.MarkRegionAsPreflushable(cpu_addr_start_aligned, cpu_addr_end_aligned - cpu_addr_start_aligned); | ||
| 130 | area->preemtive = !IsRegionGpuModified(cpu_addr, size); | ||
| 131 | return area; | ||
| 117 | } | 132 | } |
| 118 | 133 | ||
| 119 | template <class P> | 134 | template <class P> |
| @@ -191,8 +206,10 @@ bool BufferCache<P>::DMACopy(GPUVAddr src_address, GPUVAddr dest_address, u64 am | |||
| 191 | const VAddr new_base_address = *cpu_dest_address + diff; | 206 | const VAddr new_base_address = *cpu_dest_address + diff; |
| 192 | const IntervalType add_interval{new_base_address, new_base_address + size}; | 207 | const IntervalType add_interval{new_base_address, new_base_address + size}; |
| 193 | tmp_intervals.push_back(add_interval); | 208 | tmp_intervals.push_back(add_interval); |
| 194 | uncommitted_ranges.add(add_interval); | 209 | if (memory_tracker.IsRegionPreflushable(new_base_address, new_base_address + size)) { |
| 195 | pending_ranges.add(add_interval); | 210 | uncommitted_ranges.add(add_interval); |
| 211 | pending_ranges.add(add_interval); | ||
| 212 | } | ||
| 196 | }; | 213 | }; |
| 197 | ForEachInRangeSet(common_ranges, *cpu_src_address, amount, mirror); | 214 | ForEachInRangeSet(common_ranges, *cpu_src_address, amount, mirror); |
| 198 | // This subtraction in this order is important for overlapping copies. | 215 | // This subtraction in this order is important for overlapping copies. |
| @@ -205,7 +222,7 @@ bool BufferCache<P>::DMACopy(GPUVAddr src_address, GPUVAddr dest_address, u64 am | |||
| 205 | if (has_new_downloads) { | 222 | if (has_new_downloads) { |
| 206 | memory_tracker.MarkRegionAsGpuModified(*cpu_dest_address, amount); | 223 | memory_tracker.MarkRegionAsGpuModified(*cpu_dest_address, amount); |
| 207 | } | 224 | } |
| 208 | std::vector<u8> tmp_buffer(amount); | 225 | tmp_buffer.resize(amount); |
| 209 | cpu_memory.ReadBlockUnsafe(*cpu_src_address, tmp_buffer.data(), amount); | 226 | cpu_memory.ReadBlockUnsafe(*cpu_src_address, tmp_buffer.data(), amount); |
| 210 | cpu_memory.WriteBlockUnsafe(*cpu_dest_address, tmp_buffer.data(), amount); | 227 | cpu_memory.WriteBlockUnsafe(*cpu_dest_address, tmp_buffer.data(), amount); |
| 211 | return true; | 228 | return true; |
| @@ -441,9 +458,7 @@ void BufferCache<P>::BindComputeTextureBuffer(size_t tbo_index, GPUVAddr gpu_add | |||
| 441 | 458 | ||
| 442 | template <class P> | 459 | template <class P> |
| 443 | void BufferCache<P>::FlushCachedWrites() { | 460 | void BufferCache<P>::FlushCachedWrites() { |
| 444 | cached_write_buffer_ids.clear(); | ||
| 445 | memory_tracker.FlushCachedWrites(); | 461 | memory_tracker.FlushCachedWrites(); |
| 446 | cached_ranges.clear(); | ||
| 447 | } | 462 | } |
| 448 | 463 | ||
| 449 | template <class P> | 464 | template <class P> |
| @@ -1221,6 +1236,9 @@ void BufferCache<P>::MarkWrittenBuffer(BufferId buffer_id, VAddr cpu_addr, u32 s | |||
| 1221 | 1236 | ||
| 1222 | const IntervalType base_interval{cpu_addr, cpu_addr + size}; | 1237 | const IntervalType base_interval{cpu_addr, cpu_addr + size}; |
| 1223 | common_ranges.add(base_interval); | 1238 | common_ranges.add(base_interval); |
| 1239 | if (!memory_tracker.IsRegionPreflushable(cpu_addr, cpu_addr + size)) { | ||
| 1240 | return; | ||
| 1241 | } | ||
| 1224 | uncommitted_ranges.add(base_interval); | 1242 | uncommitted_ranges.add(base_interval); |
| 1225 | pending_ranges.add(base_interval); | 1243 | pending_ranges.add(base_interval); |
| 1226 | } | 1244 | } |
| @@ -1629,7 +1647,6 @@ void BufferCache<P>::DeleteBuffer(BufferId buffer_id, bool do_not_mark) { | |||
| 1629 | replace(transform_feedback_buffers); | 1647 | replace(transform_feedback_buffers); |
| 1630 | replace(compute_uniform_buffers); | 1648 | replace(compute_uniform_buffers); |
| 1631 | replace(compute_storage_buffers); | 1649 | replace(compute_storage_buffers); |
| 1632 | std::erase(cached_write_buffer_ids, buffer_id); | ||
| 1633 | 1650 | ||
| 1634 | // Mark the whole buffer as CPU written to stop tracking CPU writes | 1651 | // Mark the whole buffer as CPU written to stop tracking CPU writes |
| 1635 | if (!do_not_mark) { | 1652 | if (!do_not_mark) { |
diff --git a/src/video_core/buffer_cache/buffer_cache_base.h b/src/video_core/buffer_cache/buffer_cache_base.h index 656baa550..e3914a53a 100644 --- a/src/video_core/buffer_cache/buffer_cache_base.h +++ b/src/video_core/buffer_cache/buffer_cache_base.h | |||
| @@ -188,6 +188,8 @@ public: | |||
| 188 | 188 | ||
| 189 | void DownloadMemory(VAddr cpu_addr, u64 size); | 189 | void DownloadMemory(VAddr cpu_addr, u64 size); |
| 190 | 190 | ||
| 191 | std::optional<VideoCore::RasterizerDownloadArea> GetFlushArea(VAddr cpu_addr, u64 size); | ||
| 192 | |||
| 191 | bool InlineMemory(VAddr dest_address, size_t copy_size, std::span<const u8> inlined_buffer); | 193 | bool InlineMemory(VAddr dest_address, size_t copy_size, std::span<const u8> inlined_buffer); |
| 192 | 194 | ||
| 193 | void BindGraphicsUniformBuffer(size_t stage, u32 index, GPUVAddr gpu_addr, u32 size); | 195 | void BindGraphicsUniformBuffer(size_t stage, u32 index, GPUVAddr gpu_addr, u32 size); |
| @@ -541,8 +543,6 @@ private: | |||
| 541 | std::array<std::array<u32, NUM_GRAPHICS_UNIFORM_BUFFERS>, NUM_STAGES>, Empty> | 543 | std::array<std::array<u32, NUM_GRAPHICS_UNIFORM_BUFFERS>, NUM_STAGES>, Empty> |
| 542 | uniform_buffer_binding_sizes{}; | 544 | uniform_buffer_binding_sizes{}; |
| 543 | 545 | ||
| 544 | std::vector<BufferId> cached_write_buffer_ids; | ||
| 545 | |||
| 546 | MemoryTracker memory_tracker; | 546 | MemoryTracker memory_tracker; |
| 547 | IntervalSet uncommitted_ranges; | 547 | IntervalSet uncommitted_ranges; |
| 548 | IntervalSet common_ranges; | 548 | IntervalSet common_ranges; |
| @@ -575,6 +575,7 @@ private: | |||
| 575 | bool active_async_buffers = false; | 575 | bool active_async_buffers = false; |
| 576 | 576 | ||
| 577 | std::array<BufferId, ((1ULL << 39) >> CACHING_PAGEBITS)> page_table; | 577 | std::array<BufferId, ((1ULL << 39) >> CACHING_PAGEBITS)> page_table; |
| 578 | std::vector<u8> tmp_buffer; | ||
| 578 | }; | 579 | }; |
| 579 | 580 | ||
| 580 | } // namespace VideoCommon | 581 | } // namespace VideoCommon |
diff --git a/src/video_core/buffer_cache/memory_tracker_base.h b/src/video_core/buffer_cache/memory_tracker_base.h index dc4ebfcaa..6036b21c9 100644 --- a/src/video_core/buffer_cache/memory_tracker_base.h +++ b/src/video_core/buffer_cache/memory_tracker_base.h | |||
| @@ -66,6 +66,14 @@ public: | |||
| 66 | }); | 66 | }); |
| 67 | } | 67 | } |
| 68 | 68 | ||
| 69 | /// Returns true if a region has been marked as Preflushable | ||
| 70 | [[nodiscard]] bool IsRegionPreflushable(VAddr query_cpu_addr, u64 query_size) noexcept { | ||
| 71 | return IteratePages<false>( | ||
| 72 | query_cpu_addr, query_size, [](Manager* manager, u64 offset, size_t size) { | ||
| 73 | return manager->template IsRegionModified<Type::Preflushable>(offset, size); | ||
| 74 | }); | ||
| 75 | } | ||
| 76 | |||
| 69 | /// Mark region as CPU modified, notifying the rasterizer about this change | 77 | /// Mark region as CPU modified, notifying the rasterizer about this change |
| 70 | void MarkRegionAsCpuModified(VAddr dirty_cpu_addr, u64 query_size) { | 78 | void MarkRegionAsCpuModified(VAddr dirty_cpu_addr, u64 query_size) { |
| 71 | IteratePages<true>(dirty_cpu_addr, query_size, | 79 | IteratePages<true>(dirty_cpu_addr, query_size, |
| @@ -93,6 +101,15 @@ public: | |||
| 93 | }); | 101 | }); |
| 94 | } | 102 | } |
| 95 | 103 | ||
| 104 | /// Mark region as modified from the host GPU | ||
| 105 | void MarkRegionAsPreflushable(VAddr dirty_cpu_addr, u64 query_size) noexcept { | ||
| 106 | IteratePages<true>(dirty_cpu_addr, query_size, | ||
| 107 | [](Manager* manager, u64 offset, size_t size) { | ||
| 108 | manager->template ChangeRegionState<Type::Preflushable, true>( | ||
| 109 | manager->GetCpuAddr() + offset, size); | ||
| 110 | }); | ||
| 111 | } | ||
| 112 | |||
| 96 | /// Unmark region as modified from the host GPU | 113 | /// Unmark region as modified from the host GPU |
| 97 | void UnmarkRegionAsGpuModified(VAddr dirty_cpu_addr, u64 query_size) noexcept { | 114 | void UnmarkRegionAsGpuModified(VAddr dirty_cpu_addr, u64 query_size) noexcept { |
| 98 | IteratePages<true>(dirty_cpu_addr, query_size, | 115 | IteratePages<true>(dirty_cpu_addr, query_size, |
| @@ -102,6 +119,15 @@ public: | |||
| 102 | }); | 119 | }); |
| 103 | } | 120 | } |
| 104 | 121 | ||
| 122 | /// Unmark region as modified from the host GPU | ||
| 123 | void UnmarkRegionAsPreflushable(VAddr dirty_cpu_addr, u64 query_size) noexcept { | ||
| 124 | IteratePages<true>(dirty_cpu_addr, query_size, | ||
| 125 | [](Manager* manager, u64 offset, size_t size) { | ||
| 126 | manager->template ChangeRegionState<Type::Preflushable, false>( | ||
| 127 | manager->GetCpuAddr() + offset, size); | ||
| 128 | }); | ||
| 129 | } | ||
| 130 | |||
| 105 | /// Mark region as modified from the CPU | 131 | /// Mark region as modified from the CPU |
| 106 | /// but don't mark it as modified until FlusHCachedWrites is called. | 132 | /// but don't mark it as modified until FlusHCachedWrites is called. |
| 107 | void CachedCpuWrite(VAddr dirty_cpu_addr, u64 query_size) { | 133 | void CachedCpuWrite(VAddr dirty_cpu_addr, u64 query_size) { |
diff --git a/src/video_core/buffer_cache/word_manager.h b/src/video_core/buffer_cache/word_manager.h index a42455045..0fb199a54 100644 --- a/src/video_core/buffer_cache/word_manager.h +++ b/src/video_core/buffer_cache/word_manager.h | |||
| @@ -26,6 +26,7 @@ enum class Type { | |||
| 26 | GPU, | 26 | GPU, |
| 27 | CachedCPU, | 27 | CachedCPU, |
| 28 | Untracked, | 28 | Untracked, |
| 29 | Preflushable, | ||
| 29 | }; | 30 | }; |
| 30 | 31 | ||
| 31 | /// Vector tracking modified pages tightly packed with small vector optimization | 32 | /// Vector tracking modified pages tightly packed with small vector optimization |
| @@ -55,17 +56,20 @@ struct Words { | |||
| 55 | gpu.stack.fill(0); | 56 | gpu.stack.fill(0); |
| 56 | cached_cpu.stack.fill(0); | 57 | cached_cpu.stack.fill(0); |
| 57 | untracked.stack.fill(~u64{0}); | 58 | untracked.stack.fill(~u64{0}); |
| 59 | preflushable.stack.fill(0); | ||
| 58 | } else { | 60 | } else { |
| 59 | // Share allocation between CPU and GPU pages and set their default values | 61 | // Share allocation between CPU and GPU pages and set their default values |
| 60 | u64* const alloc = new u64[num_words * 4]; | 62 | u64* const alloc = new u64[num_words * 5]; |
| 61 | cpu.heap = alloc; | 63 | cpu.heap = alloc; |
| 62 | gpu.heap = alloc + num_words; | 64 | gpu.heap = alloc + num_words; |
| 63 | cached_cpu.heap = alloc + num_words * 2; | 65 | cached_cpu.heap = alloc + num_words * 2; |
| 64 | untracked.heap = alloc + num_words * 3; | 66 | untracked.heap = alloc + num_words * 3; |
| 67 | preflushable.heap = alloc + num_words * 4; | ||
| 65 | std::fill_n(cpu.heap, num_words, ~u64{0}); | 68 | std::fill_n(cpu.heap, num_words, ~u64{0}); |
| 66 | std::fill_n(gpu.heap, num_words, 0); | 69 | std::fill_n(gpu.heap, num_words, 0); |
| 67 | std::fill_n(cached_cpu.heap, num_words, 0); | 70 | std::fill_n(cached_cpu.heap, num_words, 0); |
| 68 | std::fill_n(untracked.heap, num_words, ~u64{0}); | 71 | std::fill_n(untracked.heap, num_words, ~u64{0}); |
| 72 | std::fill_n(preflushable.heap, num_words, 0); | ||
| 69 | } | 73 | } |
| 70 | // Clean up tailing bits | 74 | // Clean up tailing bits |
| 71 | const u64 last_word_size = size_bytes % BYTES_PER_WORD; | 75 | const u64 last_word_size = size_bytes % BYTES_PER_WORD; |
| @@ -88,13 +92,14 @@ struct Words { | |||
| 88 | gpu = rhs.gpu; | 92 | gpu = rhs.gpu; |
| 89 | cached_cpu = rhs.cached_cpu; | 93 | cached_cpu = rhs.cached_cpu; |
| 90 | untracked = rhs.untracked; | 94 | untracked = rhs.untracked; |
| 95 | preflushable = rhs.preflushable; | ||
| 91 | rhs.cpu.heap = nullptr; | 96 | rhs.cpu.heap = nullptr; |
| 92 | return *this; | 97 | return *this; |
| 93 | } | 98 | } |
| 94 | 99 | ||
| 95 | Words(Words&& rhs) noexcept | 100 | Words(Words&& rhs) noexcept |
| 96 | : size_bytes{rhs.size_bytes}, num_words{rhs.num_words}, cpu{rhs.cpu}, gpu{rhs.gpu}, | 101 | : size_bytes{rhs.size_bytes}, num_words{rhs.num_words}, cpu{rhs.cpu}, gpu{rhs.gpu}, |
| 97 | cached_cpu{rhs.cached_cpu}, untracked{rhs.untracked} { | 102 | cached_cpu{rhs.cached_cpu}, untracked{rhs.untracked}, preflushable{rhs.preflushable} { |
| 98 | rhs.cpu.heap = nullptr; | 103 | rhs.cpu.heap = nullptr; |
| 99 | } | 104 | } |
| 100 | 105 | ||
| @@ -129,6 +134,8 @@ struct Words { | |||
| 129 | return std::span<u64>(cached_cpu.Pointer(IsShort()), num_words); | 134 | return std::span<u64>(cached_cpu.Pointer(IsShort()), num_words); |
| 130 | } else if constexpr (type == Type::Untracked) { | 135 | } else if constexpr (type == Type::Untracked) { |
| 131 | return std::span<u64>(untracked.Pointer(IsShort()), num_words); | 136 | return std::span<u64>(untracked.Pointer(IsShort()), num_words); |
| 137 | } else if constexpr (type == Type::Preflushable) { | ||
| 138 | return std::span<u64>(preflushable.Pointer(IsShort()), num_words); | ||
| 132 | } | 139 | } |
| 133 | } | 140 | } |
| 134 | 141 | ||
| @@ -142,6 +149,8 @@ struct Words { | |||
| 142 | return std::span<const u64>(cached_cpu.Pointer(IsShort()), num_words); | 149 | return std::span<const u64>(cached_cpu.Pointer(IsShort()), num_words); |
| 143 | } else if constexpr (type == Type::Untracked) { | 150 | } else if constexpr (type == Type::Untracked) { |
| 144 | return std::span<const u64>(untracked.Pointer(IsShort()), num_words); | 151 | return std::span<const u64>(untracked.Pointer(IsShort()), num_words); |
| 152 | } else if constexpr (type == Type::Preflushable) { | ||
| 153 | return std::span<const u64>(preflushable.Pointer(IsShort()), num_words); | ||
| 145 | } | 154 | } |
| 146 | } | 155 | } |
| 147 | 156 | ||
| @@ -151,6 +160,7 @@ struct Words { | |||
| 151 | WordsArray<stack_words> gpu; | 160 | WordsArray<stack_words> gpu; |
| 152 | WordsArray<stack_words> cached_cpu; | 161 | WordsArray<stack_words> cached_cpu; |
| 153 | WordsArray<stack_words> untracked; | 162 | WordsArray<stack_words> untracked; |
| 163 | WordsArray<stack_words> preflushable; | ||
| 154 | }; | 164 | }; |
| 155 | 165 | ||
| 156 | template <class RasterizerInterface, size_t stack_words = 1> | 166 | template <class RasterizerInterface, size_t stack_words = 1> |
diff --git a/src/video_core/engines/maxwell_dma.cpp b/src/video_core/engines/maxwell_dma.cpp index e68850dc5..f7400aac8 100644 --- a/src/video_core/engines/maxwell_dma.cpp +++ b/src/video_core/engines/maxwell_dma.cpp | |||
| @@ -223,7 +223,7 @@ void MaxwellDMA::CopyBlockLinearToPitch() { | |||
| 223 | write_buffer.resize_destructive(dst_size); | 223 | write_buffer.resize_destructive(dst_size); |
| 224 | 224 | ||
| 225 | memory_manager.ReadBlock(src_operand.address, read_buffer.data(), src_size); | 225 | memory_manager.ReadBlock(src_operand.address, read_buffer.data(), src_size); |
| 226 | memory_manager.ReadBlockUnsafe(dst_operand.address, write_buffer.data(), dst_size); | 226 | memory_manager.ReadBlock(dst_operand.address, write_buffer.data(), dst_size); |
| 227 | 227 | ||
| 228 | UnswizzleSubrect(write_buffer, read_buffer, bytes_per_pixel, width, height, depth, x_offset, | 228 | UnswizzleSubrect(write_buffer, read_buffer, bytes_per_pixel, width, height, depth, x_offset, |
| 229 | src_params.origin.y, x_elements, regs.line_count, block_height, block_depth, | 229 | src_params.origin.y, x_elements, regs.line_count, block_height, block_depth, |
| @@ -288,11 +288,7 @@ void MaxwellDMA::CopyPitchToBlockLinear() { | |||
| 288 | write_buffer.resize_destructive(dst_size); | 288 | write_buffer.resize_destructive(dst_size); |
| 289 | 289 | ||
| 290 | memory_manager.ReadBlock(regs.offset_in, read_buffer.data(), src_size); | 290 | memory_manager.ReadBlock(regs.offset_in, read_buffer.data(), src_size); |
| 291 | if (Settings::IsGPULevelExtreme()) { | 291 | memory_manager.ReadBlock(regs.offset_out, write_buffer.data(), dst_size); |
| 292 | memory_manager.ReadBlock(regs.offset_out, write_buffer.data(), dst_size); | ||
| 293 | } else { | ||
| 294 | memory_manager.ReadBlockUnsafe(regs.offset_out, write_buffer.data(), dst_size); | ||
| 295 | } | ||
| 296 | 292 | ||
| 297 | // If the input is linear and the output is tiled, swizzle the input and copy it over. | 293 | // If the input is linear and the output is tiled, swizzle the input and copy it over. |
| 298 | SwizzleSubrect(write_buffer, read_buffer, bytes_per_pixel, width, height, depth, x_offset, | 294 | SwizzleSubrect(write_buffer, read_buffer, bytes_per_pixel, width, height, depth, x_offset, |
diff --git a/src/video_core/fence_manager.h b/src/video_core/fence_manager.h index 3b2f6aab6..850d6f27d 100644 --- a/src/video_core/fence_manager.h +++ b/src/video_core/fence_manager.h | |||
| @@ -55,8 +55,8 @@ public: | |||
| 55 | 55 | ||
| 56 | // Unlike other fences, this one doesn't | 56 | // Unlike other fences, this one doesn't |
| 57 | void SignalOrdering() { | 57 | void SignalOrdering() { |
| 58 | std::scoped_lock lock{buffer_cache.mutex}; | 58 | std::function<void()> do_nothing([]{}); |
| 59 | buffer_cache.AccumulateFlushes(); | 59 | SignalFence(std::move(do_nothing)); |
| 60 | } | 60 | } |
| 61 | 61 | ||
| 62 | void SyncOperation(std::function<void()>&& func) { | 62 | void SyncOperation(std::function<void()>&& func) { |
diff --git a/src/video_core/gpu.cpp b/src/video_core/gpu.cpp index 2e7f9c5ed..295a416a8 100644 --- a/src/video_core/gpu.cpp +++ b/src/video_core/gpu.cpp | |||
| @@ -283,6 +283,21 @@ struct GPU::Impl { | |||
| 283 | gpu_thread.FlushRegion(addr, size); | 283 | gpu_thread.FlushRegion(addr, size); |
| 284 | } | 284 | } |
| 285 | 285 | ||
| 286 | VideoCore::RasterizerDownloadArea OnCPURead(VAddr addr, u64 size) { | ||
| 287 | auto raster_area = rasterizer->GetFlushArea(addr, size); | ||
| 288 | if (raster_area.preemtive) { | ||
| 289 | return raster_area; | ||
| 290 | } | ||
| 291 | raster_area.preemtive = true; | ||
| 292 | const u64 fence = RequestSyncOperation([this, &raster_area]() { | ||
| 293 | rasterizer->FlushRegion(raster_area.start_address, | ||
| 294 | raster_area.end_address - raster_area.start_address); | ||
| 295 | }); | ||
| 296 | gpu_thread.TickGPU(); | ||
| 297 | WaitForSyncOperation(fence); | ||
| 298 | return raster_area; | ||
| 299 | } | ||
| 300 | |||
| 286 | /// Notify rasterizer that any caches of the specified region should be invalidated | 301 | /// Notify rasterizer that any caches of the specified region should be invalidated |
| 287 | void InvalidateRegion(VAddr addr, u64 size) { | 302 | void InvalidateRegion(VAddr addr, u64 size) { |
| 288 | gpu_thread.InvalidateRegion(addr, size); | 303 | gpu_thread.InvalidateRegion(addr, size); |
| @@ -538,6 +553,10 @@ void GPU::SwapBuffers(const Tegra::FramebufferConfig* framebuffer) { | |||
| 538 | impl->SwapBuffers(framebuffer); | 553 | impl->SwapBuffers(framebuffer); |
| 539 | } | 554 | } |
| 540 | 555 | ||
| 556 | VideoCore::RasterizerDownloadArea GPU::OnCPURead(VAddr addr, u64 size) { | ||
| 557 | return impl->OnCPURead(addr, size); | ||
| 558 | } | ||
| 559 | |||
| 541 | void GPU::FlushRegion(VAddr addr, u64 size) { | 560 | void GPU::FlushRegion(VAddr addr, u64 size) { |
| 542 | impl->FlushRegion(addr, size); | 561 | impl->FlushRegion(addr, size); |
| 543 | } | 562 | } |
diff --git a/src/video_core/gpu.h b/src/video_core/gpu.h index 8a871593a..e49c40cf2 100644 --- a/src/video_core/gpu.h +++ b/src/video_core/gpu.h | |||
| @@ -10,6 +10,7 @@ | |||
| 10 | #include "core/hle/service/nvdrv/nvdata.h" | 10 | #include "core/hle/service/nvdrv/nvdata.h" |
| 11 | #include "video_core/cdma_pusher.h" | 11 | #include "video_core/cdma_pusher.h" |
| 12 | #include "video_core/framebuffer_config.h" | 12 | #include "video_core/framebuffer_config.h" |
| 13 | #include "video_core/rasterizer_download_area.h" | ||
| 13 | 14 | ||
| 14 | namespace Core { | 15 | namespace Core { |
| 15 | class System; | 16 | class System; |
| @@ -241,6 +242,9 @@ public: | |||
| 241 | void SwapBuffers(const Tegra::FramebufferConfig* framebuffer); | 242 | void SwapBuffers(const Tegra::FramebufferConfig* framebuffer); |
| 242 | 243 | ||
| 243 | /// Notify rasterizer that any caches of the specified region should be flushed to Switch memory | 244 | /// Notify rasterizer that any caches of the specified region should be flushed to Switch memory |
| 245 | [[nodiscard]] VideoCore::RasterizerDownloadArea OnCPURead(VAddr addr, u64 size); | ||
| 246 | |||
| 247 | /// Notify rasterizer that any caches of the specified region should be flushed to Switch memory | ||
| 244 | void FlushRegion(VAddr addr, u64 size); | 248 | void FlushRegion(VAddr addr, u64 size); |
| 245 | 249 | ||
| 246 | /// Notify rasterizer that any caches of the specified region should be invalidated | 250 | /// Notify rasterizer that any caches of the specified region should be invalidated |
diff --git a/src/video_core/rasterizer_download_area.h b/src/video_core/rasterizer_download_area.h new file mode 100644 index 000000000..771ce903d --- /dev/null +++ b/src/video_core/rasterizer_download_area.h | |||
| @@ -0,0 +1,13 @@ | |||
| 1 | #pragma once | ||
| 2 | |||
| 3 | #include "common/common_types.h" | ||
| 4 | |||
| 5 | namespace VideoCore { | ||
| 6 | |||
| 7 | struct RasterizerDownloadArea { | ||
| 8 | VAddr start_address; | ||
| 9 | VAddr end_address; | ||
| 10 | bool preemtive; | ||
| 11 | }; | ||
| 12 | |||
| 13 | } // namespace VideoCore \ No newline at end of file | ||
diff --git a/src/video_core/rasterizer_interface.h b/src/video_core/rasterizer_interface.h index 33e2610bc..7566a8c4e 100644 --- a/src/video_core/rasterizer_interface.h +++ b/src/video_core/rasterizer_interface.h | |||
| @@ -12,6 +12,7 @@ | |||
| 12 | #include "video_core/cache_types.h" | 12 | #include "video_core/cache_types.h" |
| 13 | #include "video_core/engines/fermi_2d.h" | 13 | #include "video_core/engines/fermi_2d.h" |
| 14 | #include "video_core/gpu.h" | 14 | #include "video_core/gpu.h" |
| 15 | #include "video_core/rasterizer_download_area.h" | ||
| 15 | 16 | ||
| 16 | namespace Tegra { | 17 | namespace Tegra { |
| 17 | class MemoryManager; | 18 | class MemoryManager; |
| @@ -95,6 +96,8 @@ public: | |||
| 95 | virtual bool MustFlushRegion(VAddr addr, u64 size, | 96 | virtual bool MustFlushRegion(VAddr addr, u64 size, |
| 96 | VideoCommon::CacheType which = VideoCommon::CacheType::All) = 0; | 97 | VideoCommon::CacheType which = VideoCommon::CacheType::All) = 0; |
| 97 | 98 | ||
| 99 | virtual RasterizerDownloadArea GetFlushArea(VAddr addr, u64 size) = 0; | ||
| 100 | |||
| 98 | /// Notify rasterizer that any caches of the specified region should be invalidated | 101 | /// Notify rasterizer that any caches of the specified region should be invalidated |
| 99 | virtual void InvalidateRegion(VAddr addr, u64 size, | 102 | virtual void InvalidateRegion(VAddr addr, u64 size, |
| 100 | VideoCommon::CacheType which = VideoCommon::CacheType::All) = 0; | 103 | VideoCommon::CacheType which = VideoCommon::CacheType::All) = 0; |
diff --git a/src/video_core/renderer_null/null_rasterizer.cpp b/src/video_core/renderer_null/null_rasterizer.cpp index 2b5c7defa..bf2ce4c49 100644 --- a/src/video_core/renderer_null/null_rasterizer.cpp +++ b/src/video_core/renderer_null/null_rasterizer.cpp | |||
| @@ -1,6 +1,8 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2022 yuzu Emulator Project | 1 | // SPDX-FileCopyrightText: Copyright 2022 yuzu Emulator Project |
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | 2 | // SPDX-License-Identifier: GPL-2.0-or-later |
| 3 | 3 | ||
| 4 | #include "common/alignment.h" | ||
| 5 | #include "core/memory.h" | ||
| 4 | #include "video_core/host1x/host1x.h" | 6 | #include "video_core/host1x/host1x.h" |
| 5 | #include "video_core/memory_manager.h" | 7 | #include "video_core/memory_manager.h" |
| 6 | #include "video_core/renderer_null/null_rasterizer.h" | 8 | #include "video_core/renderer_null/null_rasterizer.h" |
| @@ -46,6 +48,14 @@ bool RasterizerNull::MustFlushRegion(VAddr addr, u64 size, VideoCommon::CacheTyp | |||
| 46 | } | 48 | } |
| 47 | void RasterizerNull::InvalidateRegion(VAddr addr, u64 size, VideoCommon::CacheType) {} | 49 | void RasterizerNull::InvalidateRegion(VAddr addr, u64 size, VideoCommon::CacheType) {} |
| 48 | void RasterizerNull::OnCPUWrite(VAddr addr, u64 size) {} | 50 | void RasterizerNull::OnCPUWrite(VAddr addr, u64 size) {} |
| 51 | VideoCore::RasterizerDownloadArea RasterizerNull::GetFlushArea(VAddr addr, u64 size) { | ||
| 52 | VideoCore::RasterizerDownloadArea new_area{ | ||
| 53 | .start_address = Common::AlignDown(addr, Core::Memory::YUZU_PAGESIZE), | ||
| 54 | .end_address = Common::AlignUp(addr + size, Core::Memory::YUZU_PAGESIZE), | ||
| 55 | .preemtive = true, | ||
| 56 | }; | ||
| 57 | return new_area; | ||
| 58 | } | ||
| 49 | void RasterizerNull::InvalidateGPUCache() {} | 59 | void RasterizerNull::InvalidateGPUCache() {} |
| 50 | void RasterizerNull::UnmapMemory(VAddr addr, u64 size) {} | 60 | void RasterizerNull::UnmapMemory(VAddr addr, u64 size) {} |
| 51 | void RasterizerNull::ModifyGPUMemory(size_t as_id, GPUVAddr addr, u64 size) {} | 61 | void RasterizerNull::ModifyGPUMemory(size_t as_id, GPUVAddr addr, u64 size) {} |
diff --git a/src/video_core/renderer_null/null_rasterizer.h b/src/video_core/renderer_null/null_rasterizer.h index 0c59e6a1f..a8d35d2c1 100644 --- a/src/video_core/renderer_null/null_rasterizer.h +++ b/src/video_core/renderer_null/null_rasterizer.h | |||
| @@ -54,6 +54,7 @@ public: | |||
| 54 | void InvalidateRegion(VAddr addr, u64 size, | 54 | void InvalidateRegion(VAddr addr, u64 size, |
| 55 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; | 55 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; |
| 56 | void OnCPUWrite(VAddr addr, u64 size) override; | 56 | void OnCPUWrite(VAddr addr, u64 size) override; |
| 57 | VideoCore::RasterizerDownloadArea GetFlushArea(VAddr addr, u64 size) override; | ||
| 57 | void InvalidateGPUCache() override; | 58 | void InvalidateGPUCache() override; |
| 58 | void UnmapMemory(VAddr addr, u64 size) override; | 59 | void UnmapMemory(VAddr addr, u64 size) override; |
| 59 | void ModifyGPUMemory(size_t as_id, GPUVAddr addr, u64 size) override; | 60 | void ModifyGPUMemory(size_t as_id, GPUVAddr addr, u64 size) override; |
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.cpp b/src/video_core/renderer_opengl/gl_rasterizer.cpp index 0089b4b27..3f07fe8bb 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.cpp +++ b/src/video_core/renderer_opengl/gl_rasterizer.cpp | |||
| @@ -433,6 +433,29 @@ bool RasterizerOpenGL::MustFlushRegion(VAddr addr, u64 size, VideoCommon::CacheT | |||
| 433 | return false; | 433 | return false; |
| 434 | } | 434 | } |
| 435 | 435 | ||
| 436 | VideoCore::RasterizerDownloadArea RasterizerOpenGL::GetFlushArea(VAddr addr, u64 size) { | ||
| 437 | { | ||
| 438 | std::scoped_lock lock{texture_cache.mutex}; | ||
| 439 | auto area = texture_cache.GetFlushArea(addr, size); | ||
| 440 | if (area) { | ||
| 441 | return *area; | ||
| 442 | } | ||
| 443 | } | ||
| 444 | { | ||
| 445 | std::scoped_lock lock{buffer_cache.mutex}; | ||
| 446 | auto area = buffer_cache.GetFlushArea(addr, size); | ||
| 447 | if (area) { | ||
| 448 | return *area; | ||
| 449 | } | ||
| 450 | } | ||
| 451 | VideoCore::RasterizerDownloadArea new_area{ | ||
| 452 | .start_address = Common::AlignDown(addr, Core::Memory::YUZU_PAGESIZE), | ||
| 453 | .end_address = Common::AlignUp(addr + size, Core::Memory::YUZU_PAGESIZE), | ||
| 454 | .preemtive = true, | ||
| 455 | }; | ||
| 456 | return new_area; | ||
| 457 | } | ||
| 458 | |||
| 436 | void RasterizerOpenGL::InvalidateRegion(VAddr addr, u64 size, VideoCommon::CacheType which) { | 459 | void RasterizerOpenGL::InvalidateRegion(VAddr addr, u64 size, VideoCommon::CacheType which) { |
| 437 | MICROPROFILE_SCOPE(OpenGL_CacheManagement); | 460 | MICROPROFILE_SCOPE(OpenGL_CacheManagement); |
| 438 | if (addr == 0 || size == 0) { | 461 | if (addr == 0 || size == 0) { |
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.h b/src/video_core/renderer_opengl/gl_rasterizer.h index ad6978bd0..410d8ffc5 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.h +++ b/src/video_core/renderer_opengl/gl_rasterizer.h | |||
| @@ -95,6 +95,7 @@ public: | |||
| 95 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; | 95 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; |
| 96 | bool MustFlushRegion(VAddr addr, u64 size, | 96 | bool MustFlushRegion(VAddr addr, u64 size, |
| 97 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; | 97 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; |
| 98 | VideoCore::RasterizerDownloadArea GetFlushArea(VAddr addr, u64 size) override; | ||
| 98 | void InvalidateRegion(VAddr addr, u64 size, | 99 | void InvalidateRegion(VAddr addr, u64 size, |
| 99 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; | 100 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; |
| 100 | void OnCPUWrite(VAddr addr, u64 size) override; | 101 | void OnCPUWrite(VAddr addr, u64 size) override; |
diff --git a/src/video_core/renderer_vulkan/vk_rasterizer.cpp b/src/video_core/renderer_vulkan/vk_rasterizer.cpp index d1489fc95..bae4aa611 100644 --- a/src/video_core/renderer_vulkan/vk_rasterizer.cpp +++ b/src/video_core/renderer_vulkan/vk_rasterizer.cpp | |||
| @@ -502,6 +502,29 @@ bool RasterizerVulkan::MustFlushRegion(VAddr addr, u64 size, VideoCommon::CacheT | |||
| 502 | return false; | 502 | return false; |
| 503 | } | 503 | } |
| 504 | 504 | ||
| 505 | VideoCore::RasterizerDownloadArea RasterizerVulkan::GetFlushArea(VAddr addr, u64 size) { | ||
| 506 | { | ||
| 507 | std::scoped_lock lock{texture_cache.mutex}; | ||
| 508 | auto area = texture_cache.GetFlushArea(addr, size); | ||
| 509 | if (area) { | ||
| 510 | return *area; | ||
| 511 | } | ||
| 512 | } | ||
| 513 | { | ||
| 514 | std::scoped_lock lock{buffer_cache.mutex}; | ||
| 515 | auto area = buffer_cache.GetFlushArea(addr, size); | ||
| 516 | if (area) { | ||
| 517 | return *area; | ||
| 518 | } | ||
| 519 | } | ||
| 520 | VideoCore::RasterizerDownloadArea new_area{ | ||
| 521 | .start_address = Common::AlignDown(addr, Core::Memory::YUZU_PAGESIZE), | ||
| 522 | .end_address = Common::AlignUp(addr + size, Core::Memory::YUZU_PAGESIZE), | ||
| 523 | .preemtive = true, | ||
| 524 | }; | ||
| 525 | return new_area; | ||
| 526 | } | ||
| 527 | |||
| 505 | void RasterizerVulkan::InvalidateRegion(VAddr addr, u64 size, VideoCommon::CacheType which) { | 528 | void RasterizerVulkan::InvalidateRegion(VAddr addr, u64 size, VideoCommon::CacheType which) { |
| 506 | if (addr == 0 || size == 0) { | 529 | if (addr == 0 || size == 0) { |
| 507 | return; | 530 | return; |
diff --git a/src/video_core/renderer_vulkan/vk_rasterizer.h b/src/video_core/renderer_vulkan/vk_rasterizer.h index 1659fbc13..9bd422850 100644 --- a/src/video_core/renderer_vulkan/vk_rasterizer.h +++ b/src/video_core/renderer_vulkan/vk_rasterizer.h | |||
| @@ -92,6 +92,7 @@ public: | |||
| 92 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; | 92 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; |
| 93 | bool MustFlushRegion(VAddr addr, u64 size, | 93 | bool MustFlushRegion(VAddr addr, u64 size, |
| 94 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; | 94 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; |
| 95 | VideoCore::RasterizerDownloadArea GetFlushArea(VAddr addr, u64 size) override; | ||
| 95 | void InvalidateRegion(VAddr addr, u64 size, | 96 | void InvalidateRegion(VAddr addr, u64 size, |
| 96 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; | 97 | VideoCommon::CacheType which = VideoCommon::CacheType::All) override; |
| 97 | void InnerInvalidation(std::span<const std::pair<VAddr, std::size_t>> sequences) override; | 98 | void InnerInvalidation(std::span<const std::pair<VAddr, std::size_t>> sequences) override; |
diff --git a/src/video_core/texture_cache/image_info.h b/src/video_core/texture_cache/image_info.h index 4b7dfa315..cfb85a3dc 100644 --- a/src/video_core/texture_cache/image_info.h +++ b/src/video_core/texture_cache/image_info.h | |||
| @@ -39,6 +39,7 @@ struct ImageInfo { | |||
| 39 | u32 tile_width_spacing = 0; | 39 | u32 tile_width_spacing = 0; |
| 40 | bool rescaleable = false; | 40 | bool rescaleable = false; |
| 41 | bool downscaleable = false; | 41 | bool downscaleable = false; |
| 42 | bool forced_flushed = false; | ||
| 42 | }; | 43 | }; |
| 43 | 44 | ||
| 44 | } // namespace VideoCommon | 45 | } // namespace VideoCommon |
diff --git a/src/video_core/texture_cache/image_view_base.cpp b/src/video_core/texture_cache/image_view_base.cpp index bcad40353..8f28342d5 100644 --- a/src/video_core/texture_cache/image_view_base.cpp +++ b/src/video_core/texture_cache/image_view_base.cpp | |||
| @@ -26,8 +26,7 @@ ImageViewBase::ImageViewBase(const ImageViewInfo& info, const ImageInfo& image_i | |||
| 26 | ASSERT_MSG(VideoCore::Surface::IsViewCompatible(image_info.format, info.format, false, true), | 26 | ASSERT_MSG(VideoCore::Surface::IsViewCompatible(image_info.format, info.format, false, true), |
| 27 | "Image view format {} is incompatible with image format {}", info.format, | 27 | "Image view format {} is incompatible with image format {}", info.format, |
| 28 | image_info.format); | 28 | image_info.format); |
| 29 | const bool is_async = Settings::values.use_asynchronous_gpu_emulation.GetValue(); | 29 | if (image_info.forced_flushed) { |
| 30 | if (image_info.type == ImageType::Linear && is_async) { | ||
| 31 | flags |= ImageViewFlagBits::PreemtiveDownload; | 30 | flags |= ImageViewFlagBits::PreemtiveDownload; |
| 32 | } | 31 | } |
| 33 | if (image_info.type == ImageType::e3D && info.type != ImageViewType::e3D) { | 32 | if (image_info.type == ImageType::e3D && info.type != ImageViewType::e3D) { |
diff --git a/src/video_core/texture_cache/texture_cache.h b/src/video_core/texture_cache/texture_cache.h index b5297e76b..fb8ffc002 100644 --- a/src/video_core/texture_cache/texture_cache.h +++ b/src/video_core/texture_cache/texture_cache.h | |||
| @@ -491,6 +491,32 @@ void TextureCache<P>::DownloadMemory(VAddr cpu_addr, size_t size) { | |||
| 491 | } | 491 | } |
| 492 | 492 | ||
| 493 | template <class P> | 493 | template <class P> |
| 494 | std::optional<VideoCore::RasterizerDownloadArea> TextureCache<P>::GetFlushArea(VAddr cpu_addr, | ||
| 495 | u64 size) { | ||
| 496 | std::optional<VideoCore::RasterizerDownloadArea> area{}; | ||
| 497 | ForEachImageInRegion(cpu_addr, size, [&](ImageId, ImageBase& image) { | ||
| 498 | if (False(image.flags & ImageFlagBits::GpuModified)) { | ||
| 499 | return; | ||
| 500 | } | ||
| 501 | if (!area) { | ||
| 502 | area.emplace(); | ||
| 503 | area->start_address = cpu_addr; | ||
| 504 | area->end_address = cpu_addr + size; | ||
| 505 | area->preemtive = true; | ||
| 506 | } | ||
| 507 | area->start_address = std::min(area->start_address, image.cpu_addr); | ||
| 508 | area->end_address = std::max(area->end_address, image.cpu_addr_end); | ||
| 509 | for (auto image_view_id : image.image_view_ids) { | ||
| 510 | auto& image_view = slot_image_views[image_view_id]; | ||
| 511 | image_view.flags |= ImageViewFlagBits::PreemtiveDownload; | ||
| 512 | } | ||
| 513 | area->preemtive &= image.info.forced_flushed; | ||
| 514 | image.info.forced_flushed = true; | ||
| 515 | }); | ||
| 516 | return area; | ||
| 517 | } | ||
| 518 | |||
| 519 | template <class P> | ||
| 494 | void TextureCache<P>::UnmapMemory(VAddr cpu_addr, size_t size) { | 520 | void TextureCache<P>::UnmapMemory(VAddr cpu_addr, size_t size) { |
| 495 | std::vector<ImageId> deleted_images; | 521 | std::vector<ImageId> deleted_images; |
| 496 | ForEachImageInRegion(cpu_addr, size, [&](ImageId id, Image&) { deleted_images.push_back(id); }); | 522 | ForEachImageInRegion(cpu_addr, size, [&](ImageId id, Image&) { deleted_images.push_back(id); }); |
| @@ -789,11 +815,15 @@ ImageId TextureCache<P>::DmaImageId(const Tegra::DMA::ImageOperand& operand) { | |||
| 789 | if (!dst_id) { | 815 | if (!dst_id) { |
| 790 | return NULL_IMAGE_ID; | 816 | return NULL_IMAGE_ID; |
| 791 | } | 817 | } |
| 792 | const auto& image = slot_images[dst_id]; | 818 | auto& image = slot_images[dst_id]; |
| 793 | if (False(image.flags & ImageFlagBits::GpuModified)) { | 819 | if (False(image.flags & ImageFlagBits::GpuModified)) { |
| 794 | // No need to waste time on an image that's synced with guest | 820 | // No need to waste time on an image that's synced with guest |
| 795 | return NULL_IMAGE_ID; | 821 | return NULL_IMAGE_ID; |
| 796 | } | 822 | } |
| 823 | if (!image.info.forced_flushed) { | ||
| 824 | image.info.forced_flushed = true; | ||
| 825 | return NULL_IMAGE_ID; | ||
| 826 | } | ||
| 797 | const auto base = image.TryFindBase(operand.address); | 827 | const auto base = image.TryFindBase(operand.address); |
| 798 | if (!base) { | 828 | if (!base) { |
| 799 | return NULL_IMAGE_ID; | 829 | return NULL_IMAGE_ID; |
diff --git a/src/video_core/texture_cache/texture_cache_base.h b/src/video_core/texture_cache/texture_cache_base.h index 758b7e212..01f5ac588 100644 --- a/src/video_core/texture_cache/texture_cache_base.h +++ b/src/video_core/texture_cache/texture_cache_base.h | |||
| @@ -179,6 +179,8 @@ public: | |||
| 179 | /// Download contents of host images to guest memory in a region | 179 | /// Download contents of host images to guest memory in a region |
| 180 | void DownloadMemory(VAddr cpu_addr, size_t size); | 180 | void DownloadMemory(VAddr cpu_addr, size_t size); |
| 181 | 181 | ||
| 182 | std::optional<VideoCore::RasterizerDownloadArea> GetFlushArea(VAddr cpu_addr, u64 size); | ||
| 183 | |||
| 182 | /// Remove images in a region | 184 | /// Remove images in a region |
| 183 | void UnmapMemory(VAddr cpu_addr, size_t size); | 185 | void UnmapMemory(VAddr cpu_addr, size_t size); |
| 184 | 186 | ||