summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--CMakeLists.txt2
m---------externals/dynarmic0
-rw-r--r--src/common/CMakeLists.txt1
-rw-r--r--src/common/logging/formatter.h23
-rw-r--r--src/common/logging/log.h3
-rw-r--r--src/core/hid/emulated_controller.cpp8
-rw-r--r--src/core/hid/motion_input.cpp1
-rw-r--r--src/input_common/drivers/tas_input.cpp31
-rw-r--r--src/input_common/drivers/udp_client.cpp24
-rw-r--r--src/input_common/input_engine.cpp12
-rw-r--r--src/shader_recompiler/exception.h2
-rw-r--r--src/video_core/memory_manager.cpp96
-rw-r--r--src/video_core/memory_manager.h5
-rw-r--r--src/video_core/texture_cache/texture_cache.h4
-rw-r--r--src/yuzu/configuration/configure_input_player.cpp15
-rw-r--r--src/yuzu/configuration/configure_per_game.cpp24
16 files changed, 146 insertions, 105 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 707d514c3..47bd282fb 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -169,7 +169,7 @@ macro(yuzu_find_packages)
169 set(REQUIRED_LIBS 169 set(REQUIRED_LIBS
170 # Cmake Pkg Prefix Version Conan Pkg 170 # Cmake Pkg Prefix Version Conan Pkg
171 "Catch2 2.13.7 catch2/2.13.7" 171 "Catch2 2.13.7 catch2/2.13.7"
172 "fmt 8.0.1 fmt/8.0.1" 172 "fmt 8.0.1 fmt/8.1.1"
173 "lz4 1.8 lz4/1.9.2" 173 "lz4 1.8 lz4/1.9.2"
174 "nlohmann_json 3.8 nlohmann_json/3.8.0" 174 "nlohmann_json 3.8 nlohmann_json/3.8.0"
175 "ZLIB 1.2 zlib/1.2.11" 175 "ZLIB 1.2 zlib/1.2.11"
diff --git a/externals/dynarmic b/externals/dynarmic
Subproject 28714ee75aa079cbb706e38bdabc8ee1f6c6951 Subproject 1635958d0613da376046532e0db5aed6316fbc1
diff --git a/src/common/CMakeLists.txt b/src/common/CMakeLists.txt
index 790193b00..adf70eb8b 100644
--- a/src/common/CMakeLists.txt
+++ b/src/common/CMakeLists.txt
@@ -85,6 +85,7 @@ add_library(common STATIC
85 logging/backend.h 85 logging/backend.h
86 logging/filter.cpp 86 logging/filter.cpp
87 logging/filter.h 87 logging/filter.h
88 logging/formatter.h
88 logging/log.h 89 logging/log.h
89 logging/log_entry.h 90 logging/log_entry.h
90 logging/text_formatter.cpp 91 logging/text_formatter.cpp
diff --git a/src/common/logging/formatter.h b/src/common/logging/formatter.h
new file mode 100644
index 000000000..552cde75a
--- /dev/null
+++ b/src/common/logging/formatter.h
@@ -0,0 +1,23 @@
1// Copyright 2022 yuzu Emulator Project
2// Licensed under GPLv2 or any later version
3// Refer to the license.txt file included.
4
5#pragma once
6
7#include <type_traits>
8
9#include <fmt/format.h>
10
11// adapted from https://github.com/fmtlib/fmt/issues/2704
12// a generic formatter for enum classes
13#if FMT_VERSION >= 80100
14template <typename T>
15struct fmt::formatter<T, std::enable_if_t<std::is_enum_v<T>, char>>
16 : formatter<std::underlying_type_t<T>> {
17 template <typename FormatContext>
18 auto format(const T& value, FormatContext& ctx) -> decltype(ctx.out()) {
19 return fmt::formatter<std::underlying_type_t<T>>::format(
20 static_cast<std::underlying_type_t<T>>(value), ctx);
21 }
22};
23#endif
diff --git a/src/common/logging/log.h b/src/common/logging/log.h
index c186d55ef..0c80d01ee 100644
--- a/src/common/logging/log.h
+++ b/src/common/logging/log.h
@@ -7,8 +7,9 @@
7#include <algorithm> 7#include <algorithm>
8#include <string_view> 8#include <string_view>
9 9
10#include <fmt/core.h> 10#include <fmt/format.h>
11 11
12#include "common/logging/formatter.h"
12#include "common/logging/types.h" 13#include "common/logging/types.h"
13 14
14namespace Common::Log { 15namespace Common::Log {
diff --git a/src/core/hid/emulated_controller.cpp b/src/core/hid/emulated_controller.cpp
index 6209c707e..13edb7332 100644
--- a/src/core/hid/emulated_controller.cpp
+++ b/src/core/hid/emulated_controller.cpp
@@ -402,7 +402,8 @@ std::vector<Common::ParamPackage> EmulatedController::GetMappedDevices(
402 devices.begin(), devices.end(), [param](const Common::ParamPackage param_) { 402 devices.begin(), devices.end(), [param](const Common::ParamPackage param_) {
403 return param.Get("engine", "") == param_.Get("engine", "") && 403 return param.Get("engine", "") == param_.Get("engine", "") &&
404 param.Get("guid", "") == param_.Get("guid", "") && 404 param.Get("guid", "") == param_.Get("guid", "") &&
405 param.Get("port", 0) == param_.Get("port", 0); 405 param.Get("port", 0) == param_.Get("port", 0) &&
406 param.Get("pad", 0) == param_.Get("pad", 0);
406 }); 407 });
407 if (devices_it != devices.end()) { 408 if (devices_it != devices.end()) {
408 continue; 409 continue;
@@ -411,6 +412,7 @@ std::vector<Common::ParamPackage> EmulatedController::GetMappedDevices(
411 device.Set("engine", param.Get("engine", "")); 412 device.Set("engine", param.Get("engine", ""));
412 device.Set("guid", param.Get("guid", "")); 413 device.Set("guid", param.Get("guid", ""));
413 device.Set("port", param.Get("port", 0)); 414 device.Set("port", param.Get("port", 0));
415 device.Set("pad", param.Get("pad", 0));
414 devices.push_back(device); 416 devices.push_back(device);
415 } 417 }
416 418
@@ -425,7 +427,8 @@ std::vector<Common::ParamPackage> EmulatedController::GetMappedDevices(
425 devices.begin(), devices.end(), [param](const Common::ParamPackage param_) { 427 devices.begin(), devices.end(), [param](const Common::ParamPackage param_) {
426 return param.Get("engine", "") == param_.Get("engine", "") && 428 return param.Get("engine", "") == param_.Get("engine", "") &&
427 param.Get("guid", "") == param_.Get("guid", "") && 429 param.Get("guid", "") == param_.Get("guid", "") &&
428 param.Get("port", 0) == param_.Get("port", 0); 430 param.Get("port", 0) == param_.Get("port", 0) &&
431 param.Get("pad", 0) == param_.Get("pad", 0);
429 }); 432 });
430 if (devices_it != devices.end()) { 433 if (devices_it != devices.end()) {
431 continue; 434 continue;
@@ -434,6 +437,7 @@ std::vector<Common::ParamPackage> EmulatedController::GetMappedDevices(
434 device.Set("engine", param.Get("engine", "")); 437 device.Set("engine", param.Get("engine", ""));
435 device.Set("guid", param.Get("guid", "")); 438 device.Set("guid", param.Get("guid", ""));
436 device.Set("port", param.Get("port", 0)); 439 device.Set("port", param.Get("port", 0));
440 device.Set("pad", param.Get("pad", 0));
437 devices.push_back(device); 441 devices.push_back(device);
438 } 442 }
439 return devices; 443 return devices;
diff --git a/src/core/hid/motion_input.cpp b/src/core/hid/motion_input.cpp
index a23f192d7..43152492e 100644
--- a/src/core/hid/motion_input.cpp
+++ b/src/core/hid/motion_input.cpp
@@ -10,6 +10,7 @@ namespace Core::HID {
10MotionInput::MotionInput() { 10MotionInput::MotionInput() {
11 // Initialize PID constants with default values 11 // Initialize PID constants with default values
12 SetPID(0.3f, 0.005f, 0.0f); 12 SetPID(0.3f, 0.005f, 0.0f);
13 SetGyroThreshold(0.001f);
13} 14}
14 15
15void MotionInput::SetPID(f32 new_kp, f32 new_ki, f32 new_kd) { 16void MotionInput::SetPID(f32 new_kp, f32 new_ki, f32 new_kd) {
diff --git a/src/input_common/drivers/tas_input.cpp b/src/input_common/drivers/tas_input.cpp
index 579fd9473..944e141bf 100644
--- a/src/input_common/drivers/tas_input.cpp
+++ b/src/input_common/drivers/tas_input.cpp
@@ -106,10 +106,16 @@ void Tas::LoadTasFile(size_t player_index, size_t file_index) {
106 continue; 106 continue;
107 } 107 }
108 108
109 const auto num_frames = std::stoi(seg_list[0]); 109 try {
110 while (frame_no < num_frames) { 110 const auto num_frames = std::stoi(seg_list[0]);
111 commands[player_index].emplace_back(); 111 while (frame_no < num_frames) {
112 frame_no++; 112 commands[player_index].emplace_back();
113 frame_no++;
114 }
115 } catch (const std::invalid_argument&) {
116 LOG_ERROR(Input, "Invalid argument: '{}' at command {}", seg_list[0], frame_no);
117 } catch (const std::out_of_range&) {
118 LOG_ERROR(Input, "Out of range: '{}' at command {}", seg_list[0], frame_no);
113 } 119 }
114 120
115 TASCommand command = { 121 TASCommand command = {
@@ -234,10 +240,21 @@ TasAnalog Tas::ReadCommandAxis(const std::string& line) const {
234 } 240 }
235 } 241 }
236 242
237 const float x = std::stof(seg_list.at(0)) / 32767.0f; 243 if (seg_list.size() < 2) {
238 const float y = std::stof(seg_list.at(1)) / 32767.0f; 244 LOG_ERROR(Input, "Invalid axis data: '{}'", line);
245 return {};
246 }
239 247
240 return {x, y}; 248 try {
249 const float x = std::stof(seg_list.at(0)) / 32767.0f;
250 const float y = std::stof(seg_list.at(1)) / 32767.0f;
251 return {x, y};
252 } catch (const std::invalid_argument&) {
253 LOG_ERROR(Input, "Invalid argument: '{}'", line);
254 } catch (const std::out_of_range&) {
255 LOG_ERROR(Input, "Out of range: '{}'", line);
256 }
257 return {};
241} 258}
242 259
243u64 Tas::ReadCommandButtons(const std::string& line) const { 260u64 Tas::ReadCommandButtons(const std::string& line) const {
diff --git a/src/input_common/drivers/udp_client.cpp b/src/input_common/drivers/udp_client.cpp
index a1ce4525d..c8a12c7d5 100644
--- a/src/input_common/drivers/udp_client.cpp
+++ b/src/input_common/drivers/udp_client.cpp
@@ -442,14 +442,22 @@ MotionMapping UDPClient::GetMotionMappingForDevice(const Common::ParamPackage& p
442 } 442 }
443 443
444 MotionMapping mapping = {}; 444 MotionMapping mapping = {};
445 Common::ParamPackage motion_params; 445 Common::ParamPackage left_motion_params;
446 motion_params.Set("engine", GetEngineName()); 446 left_motion_params.Set("engine", GetEngineName());
447 motion_params.Set("guid", params.Get("guid", "")); 447 left_motion_params.Set("guid", params.Get("guid", ""));
448 motion_params.Set("port", params.Get("port", 0)); 448 left_motion_params.Set("port", params.Get("port", 0));
449 motion_params.Set("pad", params.Get("pad", 0)); 449 left_motion_params.Set("pad", params.Get("pad", 0));
450 motion_params.Set("motion", 0); 450 left_motion_params.Set("motion", 0);
451 mapping.insert_or_assign(Settings::NativeMotion::MotionLeft, std::move(motion_params)); 451
452 mapping.insert_or_assign(Settings::NativeMotion::MotionRight, std::move(motion_params)); 452 Common::ParamPackage right_motion_params;
453 right_motion_params.Set("engine", GetEngineName());
454 right_motion_params.Set("guid", params.Get("guid", ""));
455 right_motion_params.Set("port", params.Get("port", 0));
456 right_motion_params.Set("pad", params.Get("pad", 0));
457 right_motion_params.Set("motion", 0);
458
459 mapping.insert_or_assign(Settings::NativeMotion::MotionLeft, std::move(left_motion_params));
460 mapping.insert_or_assign(Settings::NativeMotion::MotionRight, std::move(right_motion_params));
453 return mapping; 461 return mapping;
454} 462}
455 463
diff --git a/src/input_common/input_engine.cpp b/src/input_common/input_engine.cpp
index 9c17ca4f7..b57330e51 100644
--- a/src/input_common/input_engine.cpp
+++ b/src/input_common/input_engine.cpp
@@ -298,8 +298,16 @@ void InputEngine::TriggerOnMotionChange(const PadIdentifier& identifier, int mot
298 if (!configuring || !mapping_callback.on_data) { 298 if (!configuring || !mapping_callback.on_data) {
299 return; 299 return;
300 } 300 }
301 if (std::abs(value.gyro_x) < 0.6f && std::abs(value.gyro_y) < 0.6f && 301 bool is_active = false;
302 std::abs(value.gyro_z) < 0.6f) { 302 if (std::abs(value.accel_x) > 1.5f || std::abs(value.accel_y) > 1.5f ||
303 std::abs(value.accel_z) > 1.5f) {
304 is_active = true;
305 }
306 if (std::abs(value.gyro_x) > 0.6f || std::abs(value.gyro_y) > 0.6f ||
307 std::abs(value.gyro_z) > 0.6f) {
308 is_active = true;
309 }
310 if (!is_active) {
303 return; 311 return;
304 } 312 }
305 mapping_callback.on_data(MappingData{ 313 mapping_callback.on_data(MappingData{
diff --git a/src/shader_recompiler/exception.h b/src/shader_recompiler/exception.h
index 277be8541..d98b6029b 100644
--- a/src/shader_recompiler/exception.h
+++ b/src/shader_recompiler/exception.h
@@ -9,7 +9,7 @@
9#include <string_view> 9#include <string_view>
10#include <utility> 10#include <utility>
11 11
12#include <fmt/format.h> 12#include "common/logging/formatter.h"
13 13
14namespace Shader { 14namespace Shader {
15 15
diff --git a/src/video_core/memory_manager.cpp b/src/video_core/memory_manager.cpp
index dce00e829..4ff3fa268 100644
--- a/src/video_core/memory_manager.cpp
+++ b/src/video_core/memory_manager.cpp
@@ -73,12 +73,12 @@ void MemoryManager::Unmap(GPUVAddr gpu_addr, std::size_t size) {
73 } 73 }
74 const auto submapped_ranges = GetSubmappedRange(gpu_addr, size); 74 const auto submapped_ranges = GetSubmappedRange(gpu_addr, size);
75 75
76 for (const auto& map : submapped_ranges) { 76 for (const auto& [map_addr, map_size] : submapped_ranges) {
77 // Flush and invalidate through the GPU interface, to be asynchronous if possible. 77 // Flush and invalidate through the GPU interface, to be asynchronous if possible.
78 const std::optional<VAddr> cpu_addr = GpuToCpuAddress(map.first); 78 const std::optional<VAddr> cpu_addr = GpuToCpuAddress(map_addr);
79 ASSERT(cpu_addr); 79 ASSERT(cpu_addr);
80 80
81 rasterizer->UnmapMemory(*cpu_addr, map.second); 81 rasterizer->UnmapMemory(*cpu_addr, map_size);
82 } 82 }
83 83
84 UpdateRange(gpu_addr, PageEntry::State::Unmapped, size); 84 UpdateRange(gpu_addr, PageEntry::State::Unmapped, size);
@@ -265,7 +265,8 @@ size_t MemoryManager::BytesToMapEnd(GPUVAddr gpu_addr) const noexcept {
265 return it->second - (gpu_addr - it->first); 265 return it->second - (gpu_addr - it->first);
266} 266}
267 267
268void MemoryManager::ReadBlock(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size) const { 268void MemoryManager::ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size,
269 bool is_safe) const {
269 std::size_t remaining_size{size}; 270 std::size_t remaining_size{size};
270 std::size_t page_index{gpu_src_addr >> page_bits}; 271 std::size_t page_index{gpu_src_addr >> page_bits};
271 std::size_t page_offset{gpu_src_addr & page_mask}; 272 std::size_t page_offset{gpu_src_addr & page_mask};
@@ -273,14 +274,18 @@ void MemoryManager::ReadBlock(GPUVAddr gpu_src_addr, void* dest_buffer, std::siz
273 while (remaining_size > 0) { 274 while (remaining_size > 0) {
274 const std::size_t copy_amount{ 275 const std::size_t copy_amount{
275 std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)}; 276 std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)};
276 277 const auto page_addr{GpuToCpuAddress(page_index << page_bits)};
277 if (const auto page_addr{GpuToCpuAddress(page_index << page_bits)}; page_addr) { 278 if (page_addr && *page_addr != 0) {
278 const auto src_addr{*page_addr + page_offset}; 279 const auto src_addr{*page_addr + page_offset};
279 280 if (is_safe) {
280 // Flush must happen on the rasterizer interface, such that memory is always synchronous 281 // Flush must happen on the rasterizer interface, such that memory is always
281 // when it is read (even when in asynchronous GPU mode). Fixes Dead Cells title menu. 282 // synchronous when it is read (even when in asynchronous GPU mode).
282 rasterizer->FlushRegion(src_addr, copy_amount); 283 // Fixes Dead Cells title menu.
284 rasterizer->FlushRegion(src_addr, copy_amount);
285 }
283 system.Memory().ReadBlockUnsafe(src_addr, dest_buffer, copy_amount); 286 system.Memory().ReadBlockUnsafe(src_addr, dest_buffer, copy_amount);
287 } else {
288 std::memset(dest_buffer, 0, copy_amount);
284 } 289 }
285 290
286 page_index++; 291 page_index++;
@@ -290,31 +295,17 @@ void MemoryManager::ReadBlock(GPUVAddr gpu_src_addr, void* dest_buffer, std::siz
290 } 295 }
291} 296}
292 297
298void MemoryManager::ReadBlock(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size) const {
299 ReadBlockImpl(gpu_src_addr, dest_buffer, size, true);
300}
301
293void MemoryManager::ReadBlockUnsafe(GPUVAddr gpu_src_addr, void* dest_buffer, 302void MemoryManager::ReadBlockUnsafe(GPUVAddr gpu_src_addr, void* dest_buffer,
294 const std::size_t size) const { 303 const std::size_t size) const {
295 std::size_t remaining_size{size}; 304 ReadBlockImpl(gpu_src_addr, dest_buffer, size, false);
296 std::size_t page_index{gpu_src_addr >> page_bits};
297 std::size_t page_offset{gpu_src_addr & page_mask};
298
299 while (remaining_size > 0) {
300 const std::size_t copy_amount{
301 std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)};
302
303 if (const auto page_addr{GpuToCpuAddress(page_index << page_bits)}; page_addr) {
304 const auto src_addr{*page_addr + page_offset};
305 system.Memory().ReadBlockUnsafe(src_addr, dest_buffer, copy_amount);
306 } else {
307 std::memset(dest_buffer, 0, copy_amount);
308 }
309
310 page_index++;
311 page_offset = 0;
312 dest_buffer = static_cast<u8*>(dest_buffer) + copy_amount;
313 remaining_size -= copy_amount;
314 }
315} 305}
316 306
317void MemoryManager::WriteBlock(GPUVAddr gpu_dest_addr, const void* src_buffer, std::size_t size) { 307void MemoryManager::WriteBlockImpl(GPUVAddr gpu_dest_addr, const void* src_buffer, std::size_t size,
308 bool is_safe) {
318 std::size_t remaining_size{size}; 309 std::size_t remaining_size{size};
319 std::size_t page_index{gpu_dest_addr >> page_bits}; 310 std::size_t page_index{gpu_dest_addr >> page_bits};
320 std::size_t page_offset{gpu_dest_addr & page_mask}; 311 std::size_t page_offset{gpu_dest_addr & page_mask};
@@ -322,13 +313,15 @@ void MemoryManager::WriteBlock(GPUVAddr gpu_dest_addr, const void* src_buffer, s
322 while (remaining_size > 0) { 313 while (remaining_size > 0) {
323 const std::size_t copy_amount{ 314 const std::size_t copy_amount{
324 std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)}; 315 std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)};
325 316 const auto page_addr{GpuToCpuAddress(page_index << page_bits)};
326 if (const auto page_addr{GpuToCpuAddress(page_index << page_bits)}; page_addr) { 317 if (page_addr && *page_addr != 0) {
327 const auto dest_addr{*page_addr + page_offset}; 318 const auto dest_addr{*page_addr + page_offset};
328 319
329 // Invalidate must happen on the rasterizer interface, such that memory is always 320 if (is_safe) {
330 // synchronous when it is written (even when in asynchronous GPU mode). 321 // Invalidate must happen on the rasterizer interface, such that memory is always
331 rasterizer->InvalidateRegion(dest_addr, copy_amount); 322 // synchronous when it is written (even when in asynchronous GPU mode).
323 rasterizer->InvalidateRegion(dest_addr, copy_amount);
324 }
332 system.Memory().WriteBlockUnsafe(dest_addr, src_buffer, copy_amount); 325 system.Memory().WriteBlockUnsafe(dest_addr, src_buffer, copy_amount);
333 } 326 }
334 327
@@ -339,26 +332,13 @@ void MemoryManager::WriteBlock(GPUVAddr gpu_dest_addr, const void* src_buffer, s
339 } 332 }
340} 333}
341 334
335void MemoryManager::WriteBlock(GPUVAddr gpu_dest_addr, const void* src_buffer, std::size_t size) {
336 WriteBlockImpl(gpu_dest_addr, src_buffer, size, true);
337}
338
342void MemoryManager::WriteBlockUnsafe(GPUVAddr gpu_dest_addr, const void* src_buffer, 339void MemoryManager::WriteBlockUnsafe(GPUVAddr gpu_dest_addr, const void* src_buffer,
343 std::size_t size) { 340 std::size_t size) {
344 std::size_t remaining_size{size}; 341 WriteBlockImpl(gpu_dest_addr, src_buffer, size, false);
345 std::size_t page_index{gpu_dest_addr >> page_bits};
346 std::size_t page_offset{gpu_dest_addr & page_mask};
347
348 while (remaining_size > 0) {
349 const std::size_t copy_amount{
350 std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)};
351
352 if (const auto page_addr{GpuToCpuAddress(page_index << page_bits)}; page_addr) {
353 const auto dest_addr{*page_addr + page_offset};
354 system.Memory().WriteBlockUnsafe(dest_addr, src_buffer, copy_amount);
355 }
356
357 page_index++;
358 page_offset = 0;
359 src_buffer = static_cast<const u8*>(src_buffer) + copy_amount;
360 remaining_size -= copy_amount;
361 }
362} 342}
363 343
364void MemoryManager::FlushRegion(GPUVAddr gpu_addr, size_t size) const { 344void MemoryManager::FlushRegion(GPUVAddr gpu_addr, size_t size) const {
@@ -435,15 +415,15 @@ std::vector<std::pair<GPUVAddr, std::size_t>> MemoryManager::GetSubmappedRange(
435 size_t page_offset{gpu_addr & page_mask}; 415 size_t page_offset{gpu_addr & page_mask};
436 std::optional<std::pair<GPUVAddr, std::size_t>> last_segment{}; 416 std::optional<std::pair<GPUVAddr, std::size_t>> last_segment{};
437 std::optional<VAddr> old_page_addr{}; 417 std::optional<VAddr> old_page_addr{};
438 const auto extend_size = [this, &last_segment, &page_index](std::size_t bytes) { 418 const auto extend_size = [&last_segment, &page_index, &page_offset](std::size_t bytes) {
439 if (!last_segment) { 419 if (!last_segment) {
440 GPUVAddr new_base_addr = page_index << page_bits; 420 const GPUVAddr new_base_addr = (page_index << page_bits) + page_offset;
441 last_segment = {new_base_addr, bytes}; 421 last_segment = {new_base_addr, bytes};
442 } else { 422 } else {
443 last_segment->second += bytes; 423 last_segment->second += bytes;
444 } 424 }
445 }; 425 };
446 const auto split = [this, &last_segment, &result] { 426 const auto split = [&last_segment, &result] {
447 if (last_segment) { 427 if (last_segment) {
448 result.push_back(*last_segment); 428 result.push_back(*last_segment);
449 last_segment = std::nullopt; 429 last_segment = std::nullopt;
@@ -452,7 +432,7 @@ std::vector<std::pair<GPUVAddr, std::size_t>> MemoryManager::GetSubmappedRange(
452 while (remaining_size > 0) { 432 while (remaining_size > 0) {
453 const size_t num_bytes{std::min(page_size - page_offset, remaining_size)}; 433 const size_t num_bytes{std::min(page_size - page_offset, remaining_size)};
454 const auto page_addr{GpuToCpuAddress(page_index << page_bits)}; 434 const auto page_addr{GpuToCpuAddress(page_index << page_bits)};
455 if (!page_addr) { 435 if (!page_addr || *page_addr == 0) {
456 split(); 436 split();
457 } else if (old_page_addr) { 437 } else if (old_page_addr) {
458 if (*old_page_addr + page_size != *page_addr) { 438 if (*old_page_addr + page_size != *page_addr) {
diff --git a/src/video_core/memory_manager.h b/src/video_core/memory_manager.h
index 99d13e7f6..38d8d9d74 100644
--- a/src/video_core/memory_manager.h
+++ b/src/video_core/memory_manager.h
@@ -155,6 +155,11 @@ private:
155 155
156 void FlushRegion(GPUVAddr gpu_addr, size_t size) const; 156 void FlushRegion(GPUVAddr gpu_addr, size_t size) const;
157 157
158 void ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size,
159 bool is_safe) const;
160 void WriteBlockImpl(GPUVAddr gpu_dest_addr, const void* src_buffer, std::size_t size,
161 bool is_safe);
162
158 [[nodiscard]] static constexpr std::size_t PageEntryIndex(GPUVAddr gpu_addr) { 163 [[nodiscard]] static constexpr std::size_t PageEntryIndex(GPUVAddr gpu_addr) {
159 return (gpu_addr >> page_bits) & page_table_mask; 164 return (gpu_addr >> page_bits) & page_table_mask;
160 } 165 }
diff --git a/src/video_core/texture_cache/texture_cache.h b/src/video_core/texture_cache/texture_cache.h
index b494152b8..198bb0cfb 100644
--- a/src/video_core/texture_cache/texture_cache.h
+++ b/src/video_core/texture_cache/texture_cache.h
@@ -1376,9 +1376,7 @@ void TextureCache<P>::ForEachSparseSegment(ImageBase& image, Func&& func) {
1376 using FuncReturn = typename std::invoke_result<Func, GPUVAddr, VAddr, size_t>::type; 1376 using FuncReturn = typename std::invoke_result<Func, GPUVAddr, VAddr, size_t>::type;
1377 static constexpr bool RETURNS_BOOL = std::is_same_v<FuncReturn, bool>; 1377 static constexpr bool RETURNS_BOOL = std::is_same_v<FuncReturn, bool>;
1378 const auto segments = gpu_memory.GetSubmappedRange(image.gpu_addr, image.guest_size_bytes); 1378 const auto segments = gpu_memory.GetSubmappedRange(image.gpu_addr, image.guest_size_bytes);
1379 for (auto& segment : segments) { 1379 for (const auto& [gpu_addr, size] : segments) {
1380 const auto gpu_addr = segment.first;
1381 const auto size = segment.second;
1382 std::optional<VAddr> cpu_addr = gpu_memory.GpuToCpuAddress(gpu_addr); 1380 std::optional<VAddr> cpu_addr = gpu_memory.GpuToCpuAddress(gpu_addr);
1383 ASSERT(cpu_addr); 1381 ASSERT(cpu_addr);
1384 if constexpr (RETURNS_BOOL) { 1382 if constexpr (RETURNS_BOOL) {
diff --git a/src/yuzu/configuration/configure_input_player.cpp b/src/yuzu/configuration/configure_input_player.cpp
index 8c6249fc2..b9342466e 100644
--- a/src/yuzu/configuration/configure_input_player.cpp
+++ b/src/yuzu/configuration/configure_input_player.cpp
@@ -747,15 +747,16 @@ void ConfigureInputPlayer::UpdateInputDeviceCombobox() {
747 const auto first_engine = devices[0].Get("engine", ""); 747 const auto first_engine = devices[0].Get("engine", "");
748 const auto first_guid = devices[0].Get("guid", ""); 748 const auto first_guid = devices[0].Get("guid", "");
749 const auto first_port = devices[0].Get("port", 0); 749 const auto first_port = devices[0].Get("port", 0);
750 const auto first_pad = devices[0].Get("pad", 0);
750 751
751 if (devices.size() == 1) { 752 if (devices.size() == 1) {
752 const auto devices_it = 753 const auto devices_it = std::find_if(
753 std::find_if(input_devices.begin(), input_devices.end(), 754 input_devices.begin(), input_devices.end(),
754 [first_engine, first_guid, first_port](const Common::ParamPackage param) { 755 [first_engine, first_guid, first_port, first_pad](const Common::ParamPackage param) {
755 return param.Get("engine", "") == first_engine && 756 return param.Get("engine", "") == first_engine &&
756 param.Get("guid", "") == first_guid && 757 param.Get("guid", "") == first_guid && param.Get("port", 0) == first_port &&
757 param.Get("port", 0) == first_port; 758 param.Get("pad", 0) == first_pad;
758 }); 759 });
759 const int device_index = 760 const int device_index =
760 devices_it != input_devices.end() 761 devices_it != input_devices.end()
761 ? static_cast<int>(std::distance(input_devices.begin(), devices_it)) 762 ? static_cast<int>(std::distance(input_devices.begin(), devices_it))
diff --git a/src/yuzu/configuration/configure_per_game.cpp b/src/yuzu/configuration/configure_per_game.cpp
index 12699c126..f4cf25f05 100644
--- a/src/yuzu/configuration/configure_per_game.cpp
+++ b/src/yuzu/configuration/configure_per_game.cpp
@@ -45,20 +45,21 @@
45ConfigurePerGame::ConfigurePerGame(QWidget* parent, u64 title_id, const std::string& file_name, 45ConfigurePerGame::ConfigurePerGame(QWidget* parent, u64 title_id, const std::string& file_name,
46 Core::System& system_) 46 Core::System& system_)
47 : QDialog(parent), ui(std::make_unique<Ui::ConfigurePerGame>()), 47 : QDialog(parent), ui(std::make_unique<Ui::ConfigurePerGame>()),
48 title_id(title_id), system{system_}, addons_tab{std::make_unique<ConfigurePerGameAddons>( 48 title_id(title_id), system{system_} {
49 system_, this)},
50 audio_tab{std::make_unique<ConfigureAudio>(system_, this)},
51 cpu_tab{std::make_unique<ConfigureCpu>(system_, this)},
52 general_tab{std::make_unique<ConfigureGeneral>(system_, this)},
53 graphics_tab{std::make_unique<ConfigureGraphics>(system_, this)},
54 graphics_advanced_tab{std::make_unique<ConfigureGraphicsAdvanced>(system_, this)},
55 system_tab{std::make_unique<ConfigureSystem>(system_, this)} {
56 const auto file_path = std::filesystem::path(Common::FS::ToU8String(file_name)); 49 const auto file_path = std::filesystem::path(Common::FS::ToU8String(file_name));
57 const auto config_file_name = title_id == 0 ? Common::FS::PathToUTF8String(file_path.filename()) 50 const auto config_file_name = title_id == 0 ? Common::FS::PathToUTF8String(file_path.filename())
58 : fmt::format("{:016X}", title_id); 51 : fmt::format("{:016X}", title_id);
59 game_config = 52 game_config =
60 std::make_unique<Config>(system, config_file_name, Config::ConfigType::PerGameConfig); 53 std::make_unique<Config>(system, config_file_name, Config::ConfigType::PerGameConfig);
61 54
55 addons_tab = std::make_unique<ConfigurePerGameAddons>(system_, this);
56 audio_tab = std::make_unique<ConfigureAudio>(system_, this);
57 cpu_tab = std::make_unique<ConfigureCpu>(system_, this);
58 general_tab = std::make_unique<ConfigureGeneral>(system_, this);
59 graphics_tab = std::make_unique<ConfigureGraphics>(system_, this);
60 graphics_advanced_tab = std::make_unique<ConfigureGraphicsAdvanced>(system_, this);
61 system_tab = std::make_unique<ConfigureSystem>(system_, this);
62
62 ui->setupUi(this); 63 ui->setupUi(this);
63 64
64 ui->tabWidget->addTab(addons_tab.get(), tr("Add-Ons")); 65 ui->tabWidget->addTab(addons_tab.get(), tr("Add-Ons"));
@@ -187,11 +188,4 @@ void ConfigurePerGame::LoadConfiguration() {
187 188
188 const auto valueText = ReadableByteSize(file->GetSize()); 189 const auto valueText = ReadableByteSize(file->GetSize());
189 ui->display_size->setText(valueText); 190 ui->display_size->setText(valueText);
190
191 general_tab->SetConfiguration();
192 cpu_tab->SetConfiguration();
193 system_tab->SetConfiguration();
194 graphics_tab->SetConfiguration();
195 graphics_advanced_tab->SetConfiguration();
196 audio_tab->SetConfiguration();
197} 191}