diff options
132 files changed, 997 insertions, 593 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index c8e9ebf8a..3faa2b5ac 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt | |||
| @@ -12,6 +12,8 @@ project(yuzu) | |||
| 12 | # OFF by default, but if ENABLE_SDL2 and MSVC are true then ON | 12 | # OFF by default, but if ENABLE_SDL2 and MSVC are true then ON |
| 13 | option(ENABLE_SDL2 "Enable the SDL2 frontend" ON) | 13 | option(ENABLE_SDL2 "Enable the SDL2 frontend" ON) |
| 14 | CMAKE_DEPENDENT_OPTION(YUZU_USE_BUNDLED_SDL2 "Download bundled SDL2 binaries" ON "ENABLE_SDL2;MSVC" OFF) | 14 | CMAKE_DEPENDENT_OPTION(YUZU_USE_BUNDLED_SDL2 "Download bundled SDL2 binaries" ON "ENABLE_SDL2;MSVC" OFF) |
| 15 | # On Linux system SDL2 is likely to be lacking HIDAPI support which have drawbacks but is needed for SDL motion | ||
| 16 | CMAKE_DEPENDENT_OPTION(YUZU_ALLOW_SYSTEM_SDL2 "Try using system SDL2 before fallling back to one from externals" NOT UNIX "ENABLE_SDL2" OFF) | ||
| 15 | 17 | ||
| 16 | option(ENABLE_QT "Enable the Qt frontend" ON) | 18 | option(ENABLE_QT "Enable the Qt frontend" ON) |
| 17 | option(ENABLE_QT_TRANSLATION "Enable translations for the Qt frontend" OFF) | 19 | option(ENABLE_QT_TRANSLATION "Enable translations for the Qt frontend" OFF) |
| @@ -292,20 +294,24 @@ if (ENABLE_SDL2) | |||
| 292 | target_link_libraries(SDL2 INTERFACE "${SDL2_LIBRARY}") | 294 | target_link_libraries(SDL2 INTERFACE "${SDL2_LIBRARY}") |
| 293 | target_include_directories(SDL2 INTERFACE "${SDL2_INCLUDE_DIR}") | 295 | target_include_directories(SDL2 INTERFACE "${SDL2_INCLUDE_DIR}") |
| 294 | else() | 296 | else() |
| 295 | find_package(SDL2 2.0.15 QUIET) | 297 | if (YUZU_ALLOW_SYSTEM_SDL2) |
| 296 | 298 | find_package(SDL2 2.0.15 QUIET) | |
| 297 | if (SDL2_FOUND) | 299 | |
| 298 | # Some installations don't set SDL2_LIBRARIES | 300 | if (SDL2_FOUND) |
| 299 | if("${SDL2_LIBRARIES}" STREQUAL "") | 301 | # Some installations don't set SDL2_LIBRARIES |
| 300 | message(WARNING "SDL2_LIBRARIES wasn't set, manually setting to SDL2::SDL2") | 302 | if("${SDL2_LIBRARIES}" STREQUAL "") |
| 301 | set(SDL2_LIBRARIES "SDL2::SDL2") | 303 | message(WARNING "SDL2_LIBRARIES wasn't set, manually setting to SDL2::SDL2") |
| 304 | set(SDL2_LIBRARIES "SDL2::SDL2") | ||
| 305 | endif() | ||
| 306 | |||
| 307 | include_directories(SYSTEM ${SDL2_INCLUDE_DIRS}) | ||
| 308 | add_library(SDL2 INTERFACE) | ||
| 309 | target_link_libraries(SDL2 INTERFACE "${SDL2_LIBRARIES}") | ||
| 310 | else() | ||
| 311 | message(STATUS "SDL2 2.0.15 or newer not found, falling back to externals.") | ||
| 302 | endif() | 312 | endif() |
| 303 | |||
| 304 | include_directories(SYSTEM ${SDL2_INCLUDE_DIRS}) | ||
| 305 | add_library(SDL2 INTERFACE) | ||
| 306 | target_link_libraries(SDL2 INTERFACE "${SDL2_LIBRARIES}") | ||
| 307 | else() | 313 | else() |
| 308 | message(STATUS "SDL2 2.0.15 or newer not found, falling back to externals.") | 314 | message(STATUS "Using SDL2 from externals.") |
| 309 | endif() | 315 | endif() |
| 310 | endif() | 316 | endif() |
| 311 | endif() | 317 | endif() |
diff --git a/externals/CMakeLists.txt b/externals/CMakeLists.txt index e280e53d7..fe1c088ca 100644 --- a/externals/CMakeLists.txt +++ b/externals/CMakeLists.txt | |||
| @@ -47,8 +47,20 @@ target_include_directories(unicorn-headers INTERFACE ./unicorn/include) | |||
| 47 | 47 | ||
| 48 | # SDL2 | 48 | # SDL2 |
| 49 | if (NOT SDL2_FOUND AND ENABLE_SDL2) | 49 | if (NOT SDL2_FOUND AND ENABLE_SDL2) |
| 50 | # Yuzu itself needs: Events Joystick Haptic Sensor Timers | ||
| 51 | # Yuzu-cmd also needs: Video (depends on Loadso/Dlopen) | ||
| 52 | set(SDL_UNUSED_SUBSYSTEMS | ||
| 53 | Atomic Audio Render Power Threads | ||
| 54 | File CPUinfo Filesystem Locale) | ||
| 55 | foreach(_SUB ${SDL_UNUSED_SUBSYSTEMS}) | ||
| 56 | string(TOUPPER ${_SUB} _OPT) | ||
| 57 | option(SDL_${_OPT} "" OFF) | ||
| 58 | endforeach() | ||
| 59 | |||
| 50 | set(SDL_STATIC ON) | 60 | set(SDL_STATIC ON) |
| 51 | set(SDL_SHARED OFF) | 61 | set(SDL_SHARED OFF) |
| 62 | option(HIDAPI "" ON) | ||
| 63 | |||
| 52 | add_subdirectory(SDL EXCLUDE_FROM_ALL) | 64 | add_subdirectory(SDL EXCLUDE_FROM_ALL) |
| 53 | add_library(SDL2 ALIAS SDL2-static) | 65 | add_library(SDL2 ALIAS SDL2-static) |
| 54 | endif() | 66 | endif() |
diff --git a/src/common/tree.h b/src/common/tree.h index 3da49e422..9d2d0df4e 100644 --- a/src/common/tree.h +++ b/src/common/tree.h | |||
| @@ -322,7 +322,7 @@ void RB_INSERT_COLOR(RBHead<Node>* head, Node* elm) { | |||
| 322 | template <typename Node> | 322 | template <typename Node> |
| 323 | void RB_REMOVE_COLOR(RBHead<Node>* head, Node* parent, Node* elm) { | 323 | void RB_REMOVE_COLOR(RBHead<Node>* head, Node* parent, Node* elm) { |
| 324 | Node* tmp; | 324 | Node* tmp; |
| 325 | while ((elm == nullptr || RB_IS_BLACK(elm)) && elm != head->Root()) { | 325 | while ((elm == nullptr || RB_IS_BLACK(elm)) && elm != head->Root() && parent != nullptr) { |
| 326 | if (RB_LEFT(parent) == elm) { | 326 | if (RB_LEFT(parent) == elm) { |
| 327 | tmp = RB_RIGHT(parent); | 327 | tmp = RB_RIGHT(parent); |
| 328 | if (RB_IS_RED(tmp)) { | 328 | if (RB_IS_RED(tmp)) { |
diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index 83da30418..efb851f5a 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt | |||
| @@ -651,20 +651,17 @@ endif() | |||
| 651 | 651 | ||
| 652 | if (MSVC) | 652 | if (MSVC) |
| 653 | target_compile_options(core PRIVATE | 653 | target_compile_options(core PRIVATE |
| 654 | # 'expression' : signed/unsigned mismatch | 654 | /we4018 # 'expression' : signed/unsigned mismatch |
| 655 | /we4018 | 655 | /we4244 # 'argument' : conversion from 'type1' to 'type2', possible loss of data (floating-point) |
| 656 | # 'argument' : conversion from 'type1' to 'type2', possible loss of data (floating-point) | 656 | /we4245 # 'conversion' : conversion from 'type1' to 'type2', signed/unsigned mismatch |
| 657 | /we4244 | 657 | /we4254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data |
| 658 | # 'conversion' : conversion from 'type1' to 'type2', signed/unsigned mismatch | 658 | /we4267 # 'var' : conversion from 'size_t' to 'type', possible loss of data |
| 659 | /we4245 | 659 | /we4305 # 'context' : truncation from 'type1' to 'type2' |
| 660 | # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data | 660 | /we4456 # Declaration of 'identifier' hides previous local declaration |
| 661 | /we4254 | 661 | /we4457 # Declaration of 'identifier' hides function parameter |
| 662 | # 'var' : conversion from 'size_t' to 'type', possible loss of data | 662 | /we4458 # Declaration of 'identifier' hides class member |
| 663 | /we4267 | 663 | /we4459 # Declaration of 'identifier' hides global declaration |
| 664 | # 'context' : truncation from 'type1' to 'type2' | 664 | /we4715 # 'function' : not all control paths return a value |
| 665 | /we4305 | ||
| 666 | # 'function' : not all control paths return a value | ||
| 667 | /we4715 | ||
| 668 | ) | 665 | ) |
| 669 | else() | 666 | else() |
| 670 | target_compile_options(core PRIVATE | 667 | target_compile_options(core PRIVATE |
| @@ -672,6 +669,7 @@ else() | |||
| 672 | -Werror=ignored-qualifiers | 669 | -Werror=ignored-qualifiers |
| 673 | -Werror=implicit-fallthrough | 670 | -Werror=implicit-fallthrough |
| 674 | -Werror=sign-compare | 671 | -Werror=sign-compare |
| 672 | -Werror=shadow | ||
| 675 | 673 | ||
| 676 | $<$<CXX_COMPILER_ID:GNU>:-Werror=class-memaccess> | 674 | $<$<CXX_COMPILER_ID:GNU>:-Werror=class-memaccess> |
| 677 | $<$<CXX_COMPILER_ID:GNU>:-Werror=unused-but-set-parameter> | 675 | $<$<CXX_COMPILER_ID:GNU>:-Werror=unused-but-set-parameter> |
diff --git a/src/core/arm/dynarmic/arm_dynarmic_32.cpp b/src/core/arm/dynarmic/arm_dynarmic_32.cpp index 42a37e84f..ab3266916 100644 --- a/src/core/arm/dynarmic/arm_dynarmic_32.cpp +++ b/src/core/arm/dynarmic/arm_dynarmic_32.cpp | |||
| @@ -24,7 +24,7 @@ namespace Core { | |||
| 24 | 24 | ||
| 25 | class DynarmicCallbacks32 : public Dynarmic::A32::UserCallbacks { | 25 | class DynarmicCallbacks32 : public Dynarmic::A32::UserCallbacks { |
| 26 | public: | 26 | public: |
| 27 | explicit DynarmicCallbacks32(ARM_Dynarmic_32& parent) : parent(parent) {} | 27 | explicit DynarmicCallbacks32(ARM_Dynarmic_32& parent_) : parent{parent_} {} |
| 28 | 28 | ||
| 29 | u8 MemoryRead8(u32 vaddr) override { | 29 | u8 MemoryRead8(u32 vaddr) override { |
| 30 | return parent.system.Memory().Read8(vaddr); | 30 | return parent.system.Memory().Read8(vaddr); |
diff --git a/src/core/arm/dynarmic/arm_dynarmic_64.cpp b/src/core/arm/dynarmic/arm_dynarmic_64.cpp index 653bb7a77..a4d830e48 100644 --- a/src/core/arm/dynarmic/arm_dynarmic_64.cpp +++ b/src/core/arm/dynarmic/arm_dynarmic_64.cpp | |||
| @@ -27,7 +27,7 @@ using Vector = Dynarmic::A64::Vector; | |||
| 27 | 27 | ||
| 28 | class DynarmicCallbacks64 : public Dynarmic::A64::UserCallbacks { | 28 | class DynarmicCallbacks64 : public Dynarmic::A64::UserCallbacks { |
| 29 | public: | 29 | public: |
| 30 | explicit DynarmicCallbacks64(ARM_Dynarmic_64& parent) : parent(parent) {} | 30 | explicit DynarmicCallbacks64(ARM_Dynarmic_64& parent_) : parent{parent_} {} |
| 31 | 31 | ||
| 32 | u8 MemoryRead8(u64 vaddr) override { | 32 | u8 MemoryRead8(u64 vaddr) override { |
| 33 | return parent.system.Memory().Read8(vaddr); | 33 | return parent.system.Memory().Read8(vaddr); |
diff --git a/src/core/arm/dynarmic/arm_dynarmic_cp15.h b/src/core/arm/dynarmic/arm_dynarmic_cp15.h index dc6f4af3a..8597beddf 100644 --- a/src/core/arm/dynarmic/arm_dynarmic_cp15.h +++ b/src/core/arm/dynarmic/arm_dynarmic_cp15.h | |||
| @@ -18,7 +18,7 @@ class DynarmicCP15 final : public Dynarmic::A32::Coprocessor { | |||
| 18 | public: | 18 | public: |
| 19 | using CoprocReg = Dynarmic::A32::CoprocReg; | 19 | using CoprocReg = Dynarmic::A32::CoprocReg; |
| 20 | 20 | ||
| 21 | explicit DynarmicCP15(ARM_Dynarmic_32& parent) : parent(parent) {} | 21 | explicit DynarmicCP15(ARM_Dynarmic_32& parent_) : parent{parent_} {} |
| 22 | 22 | ||
| 23 | std::optional<Callback> CompileInternalOperation(bool two, unsigned opc1, CoprocReg CRd, | 23 | std::optional<Callback> CompileInternalOperation(bool two, unsigned opc1, CoprocReg CRd, |
| 24 | CoprocReg CRn, CoprocReg CRm, | 24 | CoprocReg CRn, CoprocReg CRm, |
diff --git a/src/core/arm/dynarmic/arm_exclusive_monitor.cpp b/src/core/arm/dynarmic/arm_exclusive_monitor.cpp index 4e209f6a5..9426a3edf 100644 --- a/src/core/arm/dynarmic/arm_exclusive_monitor.cpp +++ b/src/core/arm/dynarmic/arm_exclusive_monitor.cpp | |||
| @@ -9,8 +9,8 @@ | |||
| 9 | 9 | ||
| 10 | namespace Core { | 10 | namespace Core { |
| 11 | 11 | ||
| 12 | DynarmicExclusiveMonitor::DynarmicExclusiveMonitor(Memory::Memory& memory, std::size_t core_count) | 12 | DynarmicExclusiveMonitor::DynarmicExclusiveMonitor(Memory::Memory& memory_, std::size_t core_count_) |
| 13 | : monitor(core_count), memory{memory} {} | 13 | : monitor{core_count_}, memory{memory_} {} |
| 14 | 14 | ||
| 15 | DynarmicExclusiveMonitor::~DynarmicExclusiveMonitor() = default; | 15 | DynarmicExclusiveMonitor::~DynarmicExclusiveMonitor() = default; |
| 16 | 16 | ||
diff --git a/src/core/arm/dynarmic/arm_exclusive_monitor.h b/src/core/arm/dynarmic/arm_exclusive_monitor.h index 964f4a55d..f9f056a59 100644 --- a/src/core/arm/dynarmic/arm_exclusive_monitor.h +++ b/src/core/arm/dynarmic/arm_exclusive_monitor.h | |||
| @@ -22,7 +22,7 @@ namespace Core { | |||
| 22 | 22 | ||
| 23 | class DynarmicExclusiveMonitor final : public ExclusiveMonitor { | 23 | class DynarmicExclusiveMonitor final : public ExclusiveMonitor { |
| 24 | public: | 24 | public: |
| 25 | explicit DynarmicExclusiveMonitor(Memory::Memory& memory, std::size_t core_count); | 25 | explicit DynarmicExclusiveMonitor(Memory::Memory& memory_, std::size_t core_count_); |
| 26 | ~DynarmicExclusiveMonitor() override; | 26 | ~DynarmicExclusiveMonitor() override; |
| 27 | 27 | ||
| 28 | u8 ExclusiveRead8(std::size_t core_index, VAddr addr) override; | 28 | u8 ExclusiveRead8(std::size_t core_index, VAddr addr) override; |
diff --git a/src/core/cpu_manager.cpp b/src/core/cpu_manager.cpp index bdb374792..7e195346b 100644 --- a/src/core/cpu_manager.cpp +++ b/src/core/cpu_manager.cpp | |||
| @@ -18,7 +18,7 @@ | |||
| 18 | 18 | ||
| 19 | namespace Core { | 19 | namespace Core { |
| 20 | 20 | ||
| 21 | CpuManager::CpuManager(System& system) : system{system} {} | 21 | CpuManager::CpuManager(System& system_) : system{system_} {} |
| 22 | CpuManager::~CpuManager() = default; | 22 | CpuManager::~CpuManager() = default; |
| 23 | 23 | ||
| 24 | void CpuManager::ThreadStart(CpuManager& cpu_manager, std::size_t core) { | 24 | void CpuManager::ThreadStart(CpuManager& cpu_manager, std::size_t core) { |
diff --git a/src/core/cpu_manager.h b/src/core/cpu_manager.h index 9817017c0..140263b09 100644 --- a/src/core/cpu_manager.h +++ b/src/core/cpu_manager.h | |||
| @@ -25,7 +25,7 @@ class System; | |||
| 25 | 25 | ||
| 26 | class CpuManager { | 26 | class CpuManager { |
| 27 | public: | 27 | public: |
| 28 | explicit CpuManager(System& system); | 28 | explicit CpuManager(System& system_); |
| 29 | CpuManager(const CpuManager&) = delete; | 29 | CpuManager(const CpuManager&) = delete; |
| 30 | CpuManager(CpuManager&&) = delete; | 30 | CpuManager(CpuManager&&) = delete; |
| 31 | 31 | ||
diff --git a/src/core/crypto/ctr_encryption_layer.cpp b/src/core/crypto/ctr_encryption_layer.cpp index 5c84bb0a4..1231da8e3 100644 --- a/src/core/crypto/ctr_encryption_layer.cpp +++ b/src/core/crypto/ctr_encryption_layer.cpp | |||
| @@ -10,8 +10,8 @@ | |||
| 10 | namespace Core::Crypto { | 10 | namespace Core::Crypto { |
| 11 | 11 | ||
| 12 | CTREncryptionLayer::CTREncryptionLayer(FileSys::VirtualFile base_, Key128 key_, | 12 | CTREncryptionLayer::CTREncryptionLayer(FileSys::VirtualFile base_, Key128 key_, |
| 13 | std::size_t base_offset) | 13 | std::size_t base_offset_) |
| 14 | : EncryptionLayer(std::move(base_)), base_offset(base_offset), cipher(key_, Mode::CTR) {} | 14 | : EncryptionLayer(std::move(base_)), base_offset(base_offset_), cipher(key_, Mode::CTR) {} |
| 15 | 15 | ||
| 16 | std::size_t CTREncryptionLayer::Read(u8* data, std::size_t length, std::size_t offset) const { | 16 | std::size_t CTREncryptionLayer::Read(u8* data, std::size_t length, std::size_t offset) const { |
| 17 | if (length == 0) | 17 | if (length == 0) |
diff --git a/src/core/crypto/ctr_encryption_layer.h b/src/core/crypto/ctr_encryption_layer.h index a2429f001..f86f01b6f 100644 --- a/src/core/crypto/ctr_encryption_layer.h +++ b/src/core/crypto/ctr_encryption_layer.h | |||
| @@ -17,7 +17,7 @@ class CTREncryptionLayer : public EncryptionLayer { | |||
| 17 | public: | 17 | public: |
| 18 | using IVData = std::array<u8, 16>; | 18 | using IVData = std::array<u8, 16>; |
| 19 | 19 | ||
| 20 | CTREncryptionLayer(FileSys::VirtualFile base, Key128 key, std::size_t base_offset); | 20 | CTREncryptionLayer(FileSys::VirtualFile base_, Key128 key_, std::size_t base_offset_); |
| 21 | 21 | ||
| 22 | std::size_t Read(u8* data, std::size_t length, std::size_t offset) const override; | 22 | std::size_t Read(u8* data, std::size_t length, std::size_t offset) const override; |
| 23 | 23 | ||
diff --git a/src/core/crypto/key_manager.cpp b/src/core/crypto/key_manager.cpp index 070ed439e..a4b739c63 100644 --- a/src/core/crypto/key_manager.cpp +++ b/src/core/crypto/key_manager.cpp | |||
| @@ -458,7 +458,7 @@ static std::array<u8, size> operator^(const std::array<u8, size>& lhs, | |||
| 458 | const std::array<u8, size>& rhs) { | 458 | const std::array<u8, size>& rhs) { |
| 459 | std::array<u8, size> out; | 459 | std::array<u8, size> out; |
| 460 | std::transform(lhs.begin(), lhs.end(), rhs.begin(), out.begin(), | 460 | std::transform(lhs.begin(), lhs.end(), rhs.begin(), out.begin(), |
| 461 | [](u8 lhs, u8 rhs) { return u8(lhs ^ rhs); }); | 461 | [](u8 lhs_elem, u8 rhs_elem) { return u8(lhs_elem ^ rhs_elem); }); |
| 462 | return out; | 462 | return out; |
| 463 | } | 463 | } |
| 464 | 464 | ||
diff --git a/src/core/file_sys/nca_metadata.cpp b/src/core/file_sys/nca_metadata.cpp index 3596541b2..f5cb4aa8c 100644 --- a/src/core/file_sys/nca_metadata.cpp +++ b/src/core/file_sys/nca_metadata.cpp | |||
| @@ -39,10 +39,10 @@ CNMT::CNMT(VirtualFile file) { | |||
| 39 | } | 39 | } |
| 40 | } | 40 | } |
| 41 | 41 | ||
| 42 | CNMT::CNMT(CNMTHeader header, OptionalHeader opt_header, std::vector<ContentRecord> content_records, | 42 | CNMT::CNMT(CNMTHeader header_, OptionalHeader opt_header_, |
| 43 | std::vector<MetaRecord> meta_records) | 43 | std::vector<ContentRecord> content_records_, std::vector<MetaRecord> meta_records_) |
| 44 | : header(std::move(header)), opt_header(std::move(opt_header)), | 44 | : header(std::move(header_)), opt_header(std::move(opt_header_)), |
| 45 | content_records(std::move(content_records)), meta_records(std::move(meta_records)) {} | 45 | content_records(std::move(content_records_)), meta_records(std::move(meta_records_)) {} |
| 46 | 46 | ||
| 47 | CNMT::~CNMT() = default; | 47 | CNMT::~CNMT() = default; |
| 48 | 48 | ||
diff --git a/src/core/file_sys/nca_metadata.h b/src/core/file_sys/nca_metadata.h index 53535e5f5..ce1138a17 100644 --- a/src/core/file_sys/nca_metadata.h +++ b/src/core/file_sys/nca_metadata.h | |||
| @@ -87,8 +87,8 @@ static_assert(sizeof(CNMTHeader) == 0x20, "CNMTHeader has incorrect size."); | |||
| 87 | class CNMT { | 87 | class CNMT { |
| 88 | public: | 88 | public: |
| 89 | explicit CNMT(VirtualFile file); | 89 | explicit CNMT(VirtualFile file); |
| 90 | CNMT(CNMTHeader header, OptionalHeader opt_header, std::vector<ContentRecord> content_records, | 90 | CNMT(CNMTHeader header_, OptionalHeader opt_header_, |
| 91 | std::vector<MetaRecord> meta_records); | 91 | std::vector<ContentRecord> content_records_, std::vector<MetaRecord> meta_records_); |
| 92 | ~CNMT(); | 92 | ~CNMT(); |
| 93 | 93 | ||
| 94 | u64 GetTitleID() const; | 94 | u64 GetTitleID() const; |
diff --git a/src/core/file_sys/submission_package.cpp b/src/core/file_sys/submission_package.cpp index 80e560970..d51d469e3 100644 --- a/src/core/file_sys/submission_package.cpp +++ b/src/core/file_sys/submission_package.cpp | |||
| @@ -20,8 +20,8 @@ | |||
| 20 | 20 | ||
| 21 | namespace FileSys { | 21 | namespace FileSys { |
| 22 | 22 | ||
| 23 | NSP::NSP(VirtualFile file_, std::size_t program_index) | 23 | NSP::NSP(VirtualFile file_, std::size_t program_index_) |
| 24 | : file(std::move(file_)), program_index(program_index), status{Loader::ResultStatus::Success}, | 24 | : file(std::move(file_)), program_index(program_index_), status{Loader::ResultStatus::Success}, |
| 25 | pfs(std::make_shared<PartitionFilesystem>(file)), keys{Core::Crypto::KeyManager::Instance()} { | 25 | pfs(std::make_shared<PartitionFilesystem>(file)), keys{Core::Crypto::KeyManager::Instance()} { |
| 26 | if (pfs->GetStatus() != Loader::ResultStatus::Success) { | 26 | if (pfs->GetStatus() != Loader::ResultStatus::Success) { |
| 27 | status = pfs->GetStatus(); | 27 | status = pfs->GetStatus(); |
diff --git a/src/core/file_sys/submission_package.h b/src/core/file_sys/submission_package.h index 54581a6f3..ecb3b6f15 100644 --- a/src/core/file_sys/submission_package.h +++ b/src/core/file_sys/submission_package.h | |||
| @@ -27,7 +27,7 @@ enum class ContentRecordType : u8; | |||
| 27 | 27 | ||
| 28 | class NSP : public ReadOnlyVfsDirectory { | 28 | class NSP : public ReadOnlyVfsDirectory { |
| 29 | public: | 29 | public: |
| 30 | explicit NSP(VirtualFile file, std::size_t program_index = 0); | 30 | explicit NSP(VirtualFile file_, std::size_t program_index_ = 0); |
| 31 | ~NSP() override; | 31 | ~NSP() override; |
| 32 | 32 | ||
| 33 | Loader::ResultStatus GetStatus() const; | 33 | Loader::ResultStatus GetStatus() const; |
diff --git a/src/core/file_sys/vfs_concat.cpp b/src/core/file_sys/vfs_concat.cpp index 619081502..5f8c09124 100644 --- a/src/core/file_sys/vfs_concat.cpp +++ b/src/core/file_sys/vfs_concat.cpp | |||
| @@ -23,8 +23,8 @@ static bool VerifyConcatenationMapContinuity(const std::multimap<u64, VirtualFil | |||
| 23 | return map.begin()->first == 0; | 23 | return map.begin()->first == 0; |
| 24 | } | 24 | } |
| 25 | 25 | ||
| 26 | ConcatenatedVfsFile::ConcatenatedVfsFile(std::vector<VirtualFile> files_, std::string name) | 26 | ConcatenatedVfsFile::ConcatenatedVfsFile(std::vector<VirtualFile> files_, std::string name_) |
| 27 | : name(std::move(name)) { | 27 | : name(std::move(name_)) { |
| 28 | std::size_t next_offset = 0; | 28 | std::size_t next_offset = 0; |
| 29 | for (const auto& file : files_) { | 29 | for (const auto& file : files_) { |
| 30 | files.emplace(next_offset, file); | 30 | files.emplace(next_offset, file); |
| @@ -32,8 +32,8 @@ ConcatenatedVfsFile::ConcatenatedVfsFile(std::vector<VirtualFile> files_, std::s | |||
| 32 | } | 32 | } |
| 33 | } | 33 | } |
| 34 | 34 | ||
| 35 | ConcatenatedVfsFile::ConcatenatedVfsFile(std::multimap<u64, VirtualFile> files_, std::string name) | 35 | ConcatenatedVfsFile::ConcatenatedVfsFile(std::multimap<u64, VirtualFile> files_, std::string name_) |
| 36 | : files(std::move(files_)), name(std::move(name)) { | 36 | : files(std::move(files_)), name(std::move(name_)) { |
| 37 | ASSERT(VerifyConcatenationMapContinuity(files)); | 37 | ASSERT(VerifyConcatenationMapContinuity(files)); |
| 38 | } | 38 | } |
| 39 | 39 | ||
diff --git a/src/core/file_sys/vfs_concat.h b/src/core/file_sys/vfs_concat.h index 3397d32cd..cd32960a5 100644 --- a/src/core/file_sys/vfs_concat.h +++ b/src/core/file_sys/vfs_concat.h | |||
| @@ -14,8 +14,8 @@ namespace FileSys { | |||
| 14 | // Class that wraps multiple vfs files and concatenates them, making reads seamless. Currently | 14 | // Class that wraps multiple vfs files and concatenates them, making reads seamless. Currently |
| 15 | // read-only. | 15 | // read-only. |
| 16 | class ConcatenatedVfsFile : public VfsFile { | 16 | class ConcatenatedVfsFile : public VfsFile { |
| 17 | ConcatenatedVfsFile(std::vector<VirtualFile> files, std::string name); | 17 | explicit ConcatenatedVfsFile(std::vector<VirtualFile> files, std::string name_); |
| 18 | ConcatenatedVfsFile(std::multimap<u64, VirtualFile> files, std::string name); | 18 | explicit ConcatenatedVfsFile(std::multimap<u64, VirtualFile> files, std::string name_); |
| 19 | 19 | ||
| 20 | public: | 20 | public: |
| 21 | ~ConcatenatedVfsFile() override; | 21 | ~ConcatenatedVfsFile() override; |
diff --git a/src/core/file_sys/vfs_layered.cpp b/src/core/file_sys/vfs_layered.cpp index 192740058..e093c4db2 100644 --- a/src/core/file_sys/vfs_layered.cpp +++ b/src/core/file_sys/vfs_layered.cpp | |||
| @@ -8,8 +8,8 @@ | |||
| 8 | 8 | ||
| 9 | namespace FileSys { | 9 | namespace FileSys { |
| 10 | 10 | ||
| 11 | LayeredVfsDirectory::LayeredVfsDirectory(std::vector<VirtualDir> dirs, std::string name) | 11 | LayeredVfsDirectory::LayeredVfsDirectory(std::vector<VirtualDir> dirs_, std::string name_) |
| 12 | : dirs(std::move(dirs)), name(std::move(name)) {} | 12 | : dirs(std::move(dirs_)), name(std::move(name_)) {} |
| 13 | 13 | ||
| 14 | LayeredVfsDirectory::~LayeredVfsDirectory() = default; | 14 | LayeredVfsDirectory::~LayeredVfsDirectory() = default; |
| 15 | 15 | ||
diff --git a/src/core/file_sys/vfs_layered.h b/src/core/file_sys/vfs_layered.h index cb4b32e91..cd6baf28c 100644 --- a/src/core/file_sys/vfs_layered.h +++ b/src/core/file_sys/vfs_layered.h | |||
| @@ -13,7 +13,7 @@ namespace FileSys { | |||
| 13 | // one and falling back to the one after. The highest priority directory (overwrites all others) | 13 | // one and falling back to the one after. The highest priority directory (overwrites all others) |
| 14 | // should be element 0 in the dirs vector. | 14 | // should be element 0 in the dirs vector. |
| 15 | class LayeredVfsDirectory : public VfsDirectory { | 15 | class LayeredVfsDirectory : public VfsDirectory { |
| 16 | LayeredVfsDirectory(std::vector<VirtualDir> dirs, std::string name); | 16 | explicit LayeredVfsDirectory(std::vector<VirtualDir> dirs_, std::string name_); |
| 17 | 17 | ||
| 18 | public: | 18 | public: |
| 19 | ~LayeredVfsDirectory() override; | 19 | ~LayeredVfsDirectory() override; |
diff --git a/src/core/file_sys/vfs_libzip.cpp b/src/core/file_sys/vfs_libzip.cpp index 429d7bc8b..618eb658a 100644 --- a/src/core/file_sys/vfs_libzip.cpp +++ b/src/core/file_sys/vfs_libzip.cpp | |||
| @@ -3,7 +3,16 @@ | |||
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include <string> | 5 | #include <string> |
| 6 | |||
| 7 | #ifdef __GNUC__ | ||
| 8 | #pragma GCC diagnostic push | ||
| 9 | #pragma GCC diagnostic ignored "-Wshadow" | ||
| 10 | #endif | ||
| 6 | #include <zip.h> | 11 | #include <zip.h> |
| 12 | #ifdef __GNUC__ | ||
| 13 | #pragma GCC diagnostic pop | ||
| 14 | #endif | ||
| 15 | |||
| 7 | #include "common/logging/backend.h" | 16 | #include "common/logging/backend.h" |
| 8 | #include "core/file_sys/vfs.h" | 17 | #include "core/file_sys/vfs.h" |
| 9 | #include "core/file_sys/vfs_libzip.h" | 18 | #include "core/file_sys/vfs_libzip.h" |
diff --git a/src/core/file_sys/vfs_static.h b/src/core/file_sys/vfs_static.h index c840b24b9..f5b66cf71 100644 --- a/src/core/file_sys/vfs_static.h +++ b/src/core/file_sys/vfs_static.h | |||
| @@ -14,9 +14,9 @@ namespace FileSys { | |||
| 14 | 14 | ||
| 15 | class StaticVfsFile : public VfsFile { | 15 | class StaticVfsFile : public VfsFile { |
| 16 | public: | 16 | public: |
| 17 | explicit StaticVfsFile(u8 value, std::size_t size = 0, std::string name = "", | 17 | explicit StaticVfsFile(u8 value_, std::size_t size_ = 0, std::string name_ = "", |
| 18 | VirtualDir parent = nullptr) | 18 | VirtualDir parent_ = nullptr) |
| 19 | : value{value}, size{size}, name{std::move(name)}, parent{std::move(parent)} {} | 19 | : value{value_}, size{size_}, name{std::move(name_)}, parent{std::move(parent_)} {} |
| 20 | 20 | ||
| 21 | std::string GetName() const override { | 21 | std::string GetName() const override { |
| 22 | return name; | 22 | return name; |
diff --git a/src/core/file_sys/vfs_vector.cpp b/src/core/file_sys/vfs_vector.cpp index 1a3f06227..f64b88639 100644 --- a/src/core/file_sys/vfs_vector.cpp +++ b/src/core/file_sys/vfs_vector.cpp | |||
| @@ -7,8 +7,8 @@ | |||
| 7 | #include "core/file_sys/vfs_vector.h" | 7 | #include "core/file_sys/vfs_vector.h" |
| 8 | 8 | ||
| 9 | namespace FileSys { | 9 | namespace FileSys { |
| 10 | VectorVfsFile::VectorVfsFile(std::vector<u8> initial_data, std::string name, VirtualDir parent) | 10 | VectorVfsFile::VectorVfsFile(std::vector<u8> initial_data, std::string name_, VirtualDir parent_) |
| 11 | : data(std::move(initial_data)), parent(std::move(parent)), name(std::move(name)) {} | 11 | : data(std::move(initial_data)), parent(std::move(parent_)), name(std::move(name_)) {} |
| 12 | 12 | ||
| 13 | VectorVfsFile::~VectorVfsFile() = default; | 13 | VectorVfsFile::~VectorVfsFile() = default; |
| 14 | 14 | ||
diff --git a/src/core/file_sys/vfs_vector.h b/src/core/file_sys/vfs_vector.h index c10c527b6..73f180070 100644 --- a/src/core/file_sys/vfs_vector.h +++ b/src/core/file_sys/vfs_vector.h | |||
| @@ -75,8 +75,8 @@ std::shared_ptr<ArrayVfsFile<Size>> MakeArrayFile(const std::array<u8, Size>& da | |||
| 75 | // An implementation of VfsFile that is backed by a vector optionally supplied upon construction | 75 | // An implementation of VfsFile that is backed by a vector optionally supplied upon construction |
| 76 | class VectorVfsFile : public VfsFile { | 76 | class VectorVfsFile : public VfsFile { |
| 77 | public: | 77 | public: |
| 78 | explicit VectorVfsFile(std::vector<u8> initial_data = {}, std::string name = "", | 78 | explicit VectorVfsFile(std::vector<u8> initial_data = {}, std::string name_ = "", |
| 79 | VirtualDir parent = nullptr); | 79 | VirtualDir parent_ = nullptr); |
| 80 | ~VectorVfsFile() override; | 80 | ~VectorVfsFile() override; |
| 81 | 81 | ||
| 82 | std::string GetName() const override; | 82 | std::string GetName() const override; |
diff --git a/src/core/frontend/emu_window.cpp b/src/core/frontend/emu_window.cpp index cff49899a..e11ec0b0b 100644 --- a/src/core/frontend/emu_window.cpp +++ b/src/core/frontend/emu_window.cpp | |||
| @@ -26,7 +26,7 @@ public: | |||
| 26 | private: | 26 | private: |
| 27 | class Device : public Input::TouchDevice { | 27 | class Device : public Input::TouchDevice { |
| 28 | public: | 28 | public: |
| 29 | explicit Device(std::weak_ptr<TouchState>&& touch_state) : touch_state(touch_state) {} | 29 | explicit Device(std::weak_ptr<TouchState>&& touch_state_) : touch_state(touch_state_) {} |
| 30 | Input::TouchStatus GetStatus() const override { | 30 | Input::TouchStatus GetStatus() const override { |
| 31 | if (auto state = touch_state.lock()) { | 31 | if (auto state = touch_state.lock()) { |
| 32 | std::lock_guard guard{state->mutex}; | 32 | std::lock_guard guard{state->mutex}; |
diff --git a/src/core/hle/ipc.h b/src/core/hle/ipc.h index 55b1716e4..602e12606 100644 --- a/src/core/hle/ipc.h +++ b/src/core/hle/ipc.h | |||
| @@ -32,7 +32,8 @@ enum class CommandType : u32 { | |||
| 32 | Control = 5, | 32 | Control = 5, |
| 33 | RequestWithContext = 6, | 33 | RequestWithContext = 6, |
| 34 | ControlWithContext = 7, | 34 | ControlWithContext = 7, |
| 35 | Unspecified, | 35 | TIPC_Close = 15, |
| 36 | TIPC_CommandRegion = 16, // Start of TIPC commands, this is an offset. | ||
| 36 | }; | 37 | }; |
| 37 | 38 | ||
| 38 | struct CommandHeader { | 39 | struct CommandHeader { |
| @@ -57,6 +58,20 @@ struct CommandHeader { | |||
| 57 | BitField<10, 4, BufferDescriptorCFlag> buf_c_descriptor_flags; | 58 | BitField<10, 4, BufferDescriptorCFlag> buf_c_descriptor_flags; |
| 58 | BitField<31, 1, u32> enable_handle_descriptor; | 59 | BitField<31, 1, u32> enable_handle_descriptor; |
| 59 | }; | 60 | }; |
| 61 | |||
| 62 | bool IsTipc() const { | ||
| 63 | return type.Value() >= CommandType::TIPC_CommandRegion; | ||
| 64 | } | ||
| 65 | |||
| 66 | bool IsCloseCommand() const { | ||
| 67 | switch (type.Value()) { | ||
| 68 | case CommandType::Close: | ||
| 69 | case CommandType::TIPC_Close: | ||
| 70 | return true; | ||
| 71 | default: | ||
| 72 | return false; | ||
| 73 | } | ||
| 74 | } | ||
| 60 | }; | 75 | }; |
| 61 | static_assert(sizeof(CommandHeader) == 8, "CommandHeader size is incorrect"); | 76 | static_assert(sizeof(CommandHeader) == 8, "CommandHeader size is incorrect"); |
| 62 | 77 | ||
diff --git a/src/core/hle/ipc_helpers.h b/src/core/hle/ipc_helpers.h index d136be452..497f35d23 100644 --- a/src/core/hle/ipc_helpers.h +++ b/src/core/hle/ipc_helpers.h | |||
| @@ -15,6 +15,8 @@ | |||
| 15 | #include "core/hle/ipc.h" | 15 | #include "core/hle/ipc.h" |
| 16 | #include "core/hle/kernel/hle_ipc.h" | 16 | #include "core/hle/kernel/hle_ipc.h" |
| 17 | #include "core/hle/kernel/k_client_port.h" | 17 | #include "core/hle/kernel/k_client_port.h" |
| 18 | #include "core/hle/kernel/k_process.h" | ||
| 19 | #include "core/hle/kernel/k_resource_limit.h" | ||
| 18 | #include "core/hle/kernel/k_session.h" | 20 | #include "core/hle/kernel/k_session.h" |
| 19 | #include "core/hle/result.h" | 21 | #include "core/hle/result.h" |
| 20 | 22 | ||
| @@ -26,19 +28,19 @@ class RequestHelperBase { | |||
| 26 | protected: | 28 | protected: |
| 27 | Kernel::HLERequestContext* context = nullptr; | 29 | Kernel::HLERequestContext* context = nullptr; |
| 28 | u32* cmdbuf; | 30 | u32* cmdbuf; |
| 29 | ptrdiff_t index = 0; | 31 | u32 index = 0; |
| 30 | 32 | ||
| 31 | public: | 33 | public: |
| 32 | explicit RequestHelperBase(u32* command_buffer) : cmdbuf(command_buffer) {} | 34 | explicit RequestHelperBase(u32* command_buffer) : cmdbuf(command_buffer) {} |
| 33 | 35 | ||
| 34 | explicit RequestHelperBase(Kernel::HLERequestContext& context) | 36 | explicit RequestHelperBase(Kernel::HLERequestContext& ctx) |
| 35 | : context(&context), cmdbuf(context.CommandBuffer()) {} | 37 | : context(&ctx), cmdbuf(ctx.CommandBuffer()) {} |
| 36 | 38 | ||
| 37 | void Skip(u32 size_in_words, bool set_to_null) { | 39 | void Skip(u32 size_in_words, bool set_to_null) { |
| 38 | if (set_to_null) { | 40 | if (set_to_null) { |
| 39 | memset(cmdbuf + index, 0, size_in_words * sizeof(u32)); | 41 | memset(cmdbuf + index, 0, size_in_words * sizeof(u32)); |
| 40 | } | 42 | } |
| 41 | index += static_cast<ptrdiff_t>(size_in_words); | 43 | index += size_in_words; |
| 42 | } | 44 | } |
| 43 | 45 | ||
| 44 | /** | 46 | /** |
| @@ -51,11 +53,11 @@ public: | |||
| 51 | } | 53 | } |
| 52 | 54 | ||
| 53 | u32 GetCurrentOffset() const { | 55 | u32 GetCurrentOffset() const { |
| 54 | return static_cast<u32>(index); | 56 | return index; |
| 55 | } | 57 | } |
| 56 | 58 | ||
| 57 | void SetCurrentOffset(u32 offset) { | 59 | void SetCurrentOffset(u32 offset) { |
| 58 | index = static_cast<ptrdiff_t>(offset); | 60 | index = offset; |
| 59 | } | 61 | } |
| 60 | }; | 62 | }; |
| 61 | 63 | ||
| @@ -69,12 +71,12 @@ public: | |||
| 69 | AlwaysMoveHandles = 1, | 71 | AlwaysMoveHandles = 1, |
| 70 | }; | 72 | }; |
| 71 | 73 | ||
| 72 | explicit ResponseBuilder(Kernel::HLERequestContext& ctx, u32 normal_params_size, | 74 | explicit ResponseBuilder(Kernel::HLERequestContext& ctx, u32 normal_params_size_, |
| 73 | u32 num_handles_to_copy = 0, u32 num_objects_to_move = 0, | 75 | u32 num_handles_to_copy_ = 0, u32 num_objects_to_move_ = 0, |
| 74 | Flags flags = Flags::None) | 76 | Flags flags = Flags::None) |
| 75 | : RequestHelperBase(ctx), normal_params_size(normal_params_size), | 77 | : RequestHelperBase(ctx), normal_params_size(normal_params_size_), |
| 76 | num_handles_to_copy(num_handles_to_copy), | 78 | num_handles_to_copy(num_handles_to_copy_), |
| 77 | num_objects_to_move(num_objects_to_move), kernel{ctx.kernel} { | 79 | num_objects_to_move(num_objects_to_move_), kernel{ctx.kernel} { |
| 78 | 80 | ||
| 79 | memset(cmdbuf, 0, sizeof(u32) * IPC::COMMAND_BUFFER_LENGTH); | 81 | memset(cmdbuf, 0, sizeof(u32) * IPC::COMMAND_BUFFER_LENGTH); |
| 80 | 82 | ||
| @@ -84,7 +86,9 @@ public: | |||
| 84 | 86 | ||
| 85 | // The entire size of the raw data section in u32 units, including the 16 bytes of mandatory | 87 | // The entire size of the raw data section in u32 units, including the 16 bytes of mandatory |
| 86 | // padding. | 88 | // padding. |
| 87 | u64 raw_data_size = sizeof(IPC::DataPayloadHeader) / 4 + 4 + normal_params_size; | 89 | u32 raw_data_size = ctx.IsTipc() |
| 90 | ? normal_params_size - 1 | ||
| 91 | : sizeof(IPC::DataPayloadHeader) / 4 + 4 + normal_params_size; | ||
| 88 | 92 | ||
| 89 | u32 num_handles_to_move{}; | 93 | u32 num_handles_to_move{}; |
| 90 | u32 num_domain_objects{}; | 94 | u32 num_domain_objects{}; |
| @@ -97,36 +101,49 @@ public: | |||
| 97 | } | 101 | } |
| 98 | 102 | ||
| 99 | if (ctx.Session()->IsDomain()) { | 103 | if (ctx.Session()->IsDomain()) { |
| 100 | raw_data_size += sizeof(DomainMessageHeader) / 4 + num_domain_objects; | 104 | raw_data_size += static_cast<u32>(sizeof(DomainMessageHeader) / 4 + num_domain_objects); |
| 101 | } | 105 | } |
| 102 | 106 | ||
| 107 | if (ctx.IsTipc()) { | ||
| 108 | header.type.Assign(ctx.GetCommandType()); | ||
| 109 | } | ||
| 110 | |||
| 111 | ctx.data_size = static_cast<u32>(raw_data_size); | ||
| 103 | header.data_size.Assign(static_cast<u32>(raw_data_size)); | 112 | header.data_size.Assign(static_cast<u32>(raw_data_size)); |
| 104 | if (num_handles_to_copy || num_handles_to_move) { | 113 | if (num_handles_to_copy != 0 || num_handles_to_move != 0) { |
| 105 | header.enable_handle_descriptor.Assign(1); | 114 | header.enable_handle_descriptor.Assign(1); |
| 106 | } | 115 | } |
| 107 | PushRaw(header); | 116 | PushRaw(header); |
| 108 | 117 | ||
| 109 | if (header.enable_handle_descriptor) { | 118 | if (header.enable_handle_descriptor) { |
| 110 | IPC::HandleDescriptorHeader handle_descriptor_header{}; | 119 | IPC::HandleDescriptorHeader handle_descriptor_header{}; |
| 111 | handle_descriptor_header.num_handles_to_copy.Assign(num_handles_to_copy); | 120 | handle_descriptor_header.num_handles_to_copy.Assign(num_handles_to_copy_); |
| 112 | handle_descriptor_header.num_handles_to_move.Assign(num_handles_to_move); | 121 | handle_descriptor_header.num_handles_to_move.Assign(num_handles_to_move); |
| 113 | PushRaw(handle_descriptor_header); | 122 | PushRaw(handle_descriptor_header); |
| 123 | |||
| 124 | ctx.handles_offset = index; | ||
| 125 | |||
| 114 | Skip(num_handles_to_copy + num_handles_to_move, true); | 126 | Skip(num_handles_to_copy + num_handles_to_move, true); |
| 115 | } | 127 | } |
| 116 | 128 | ||
| 117 | AlignWithPadding(); | 129 | if (!ctx.IsTipc()) { |
| 130 | AlignWithPadding(); | ||
| 118 | 131 | ||
| 119 | if (ctx.Session()->IsDomain() && ctx.HasDomainMessageHeader()) { | 132 | if (ctx.Session()->IsDomain() && ctx.HasDomainMessageHeader()) { |
| 120 | IPC::DomainMessageHeader domain_header{}; | 133 | IPC::DomainMessageHeader domain_header{}; |
| 121 | domain_header.num_objects = num_domain_objects; | 134 | domain_header.num_objects = num_domain_objects; |
| 122 | PushRaw(domain_header); | 135 | PushRaw(domain_header); |
| 136 | } | ||
| 137 | |||
| 138 | IPC::DataPayloadHeader data_payload_header{}; | ||
| 139 | data_payload_header.magic = Common::MakeMagic('S', 'F', 'C', 'O'); | ||
| 140 | PushRaw(data_payload_header); | ||
| 123 | } | 141 | } |
| 124 | 142 | ||
| 125 | IPC::DataPayloadHeader data_payload_header{}; | 143 | data_payload_index = index; |
| 126 | data_payload_header.magic = Common::MakeMagic('S', 'F', 'C', 'O'); | ||
| 127 | PushRaw(data_payload_header); | ||
| 128 | 144 | ||
| 129 | datapayload_index = index; | 145 | ctx.data_payload_offset = index; |
| 146 | ctx.domain_offset = index + raw_data_size / 4; | ||
| 130 | } | 147 | } |
| 131 | 148 | ||
| 132 | template <class T> | 149 | template <class T> |
| @@ -134,6 +151,9 @@ public: | |||
| 134 | if (context->Session()->IsDomain()) { | 151 | if (context->Session()->IsDomain()) { |
| 135 | context->AddDomainObject(std::move(iface)); | 152 | context->AddDomainObject(std::move(iface)); |
| 136 | } else { | 153 | } else { |
| 154 | // kernel.CurrentProcess()->GetResourceLimit()->Reserve( | ||
| 155 | // Kernel::LimitableResource::Sessions, 1); | ||
| 156 | |||
| 137 | auto* session = Kernel::KSession::Create(kernel); | 157 | auto* session = Kernel::KSession::Create(kernel); |
| 138 | session->Initialize(nullptr, iface->GetServiceName()); | 158 | session->Initialize(nullptr, iface->GetServiceName()); |
| 139 | 159 | ||
| @@ -152,7 +172,7 @@ public: | |||
| 152 | const std::size_t num_move_objects = context->NumMoveObjects(); | 172 | const std::size_t num_move_objects = context->NumMoveObjects(); |
| 153 | ASSERT_MSG(!num_domain_objects || !num_move_objects, | 173 | ASSERT_MSG(!num_domain_objects || !num_move_objects, |
| 154 | "cannot move normal handles and domain objects"); | 174 | "cannot move normal handles and domain objects"); |
| 155 | ASSERT_MSG((index - datapayload_index) == normal_params_size, | 175 | ASSERT_MSG((index - data_payload_index) == normal_params_size, |
| 156 | "normal_params_size value is incorrect"); | 176 | "normal_params_size value is incorrect"); |
| 157 | ASSERT_MSG((num_domain_objects + num_move_objects) == num_objects_to_move, | 177 | ASSERT_MSG((num_domain_objects + num_move_objects) == num_objects_to_move, |
| 158 | "num_objects_to_move value is incorrect"); | 178 | "num_objects_to_move value is incorrect"); |
| @@ -229,14 +249,14 @@ private: | |||
| 229 | u32 normal_params_size{}; | 249 | u32 normal_params_size{}; |
| 230 | u32 num_handles_to_copy{}; | 250 | u32 num_handles_to_copy{}; |
| 231 | u32 num_objects_to_move{}; ///< Domain objects or move handles, context dependent | 251 | u32 num_objects_to_move{}; ///< Domain objects or move handles, context dependent |
| 232 | std::ptrdiff_t datapayload_index{}; | 252 | u32 data_payload_index{}; |
| 233 | Kernel::KernelCore& kernel; | 253 | Kernel::KernelCore& kernel; |
| 234 | }; | 254 | }; |
| 235 | 255 | ||
| 236 | /// Push /// | 256 | /// Push /// |
| 237 | 257 | ||
| 238 | inline void ResponseBuilder::PushImpl(s32 value) { | 258 | inline void ResponseBuilder::PushImpl(s32 value) { |
| 239 | cmdbuf[index++] = static_cast<u32>(value); | 259 | cmdbuf[index++] = value; |
| 240 | } | 260 | } |
| 241 | 261 | ||
| 242 | inline void ResponseBuilder::PushImpl(u32 value) { | 262 | inline void ResponseBuilder::PushImpl(u32 value) { |
diff --git a/src/core/hle/kernel/global_scheduler_context.cpp b/src/core/hle/kernel/global_scheduler_context.cpp index 7c87cbada..4f4e338e3 100644 --- a/src/core/hle/kernel/global_scheduler_context.cpp +++ b/src/core/hle/kernel/global_scheduler_context.cpp | |||
| @@ -12,8 +12,8 @@ | |||
| 12 | 12 | ||
| 13 | namespace Kernel { | 13 | namespace Kernel { |
| 14 | 14 | ||
| 15 | GlobalSchedulerContext::GlobalSchedulerContext(KernelCore& kernel) | 15 | GlobalSchedulerContext::GlobalSchedulerContext(KernelCore& kernel_) |
| 16 | : kernel{kernel}, scheduler_lock{kernel} {} | 16 | : kernel{kernel_}, scheduler_lock{kernel_} {} |
| 17 | 17 | ||
| 18 | GlobalSchedulerContext::~GlobalSchedulerContext() = default; | 18 | GlobalSchedulerContext::~GlobalSchedulerContext() = default; |
| 19 | 19 | ||
diff --git a/src/core/hle/kernel/global_scheduler_context.h b/src/core/hle/kernel/global_scheduler_context.h index ba8b67fd1..6f44b534f 100644 --- a/src/core/hle/kernel/global_scheduler_context.h +++ b/src/core/hle/kernel/global_scheduler_context.h | |||
| @@ -34,7 +34,7 @@ class GlobalSchedulerContext final { | |||
| 34 | public: | 34 | public: |
| 35 | using LockType = KAbstractSchedulerLock<KScheduler>; | 35 | using LockType = KAbstractSchedulerLock<KScheduler>; |
| 36 | 36 | ||
| 37 | explicit GlobalSchedulerContext(KernelCore& kernel); | 37 | explicit GlobalSchedulerContext(KernelCore& kernel_); |
| 38 | ~GlobalSchedulerContext(); | 38 | ~GlobalSchedulerContext(); |
| 39 | 39 | ||
| 40 | /// Adds a new thread to the scheduler | 40 | /// Adds a new thread to the scheduler |
diff --git a/src/core/hle/kernel/hle_ipc.cpp b/src/core/hle/kernel/hle_ipc.cpp index 93907f75e..ce3466df8 100644 --- a/src/core/hle/kernel/hle_ipc.cpp +++ b/src/core/hle/kernel/hle_ipc.cpp | |||
| @@ -55,7 +55,7 @@ void HLERequestContext::ParseCommandBuffer(const KHandleTable& handle_table, u32 | |||
| 55 | IPC::RequestParser rp(src_cmdbuf); | 55 | IPC::RequestParser rp(src_cmdbuf); |
| 56 | command_header = rp.PopRaw<IPC::CommandHeader>(); | 56 | command_header = rp.PopRaw<IPC::CommandHeader>(); |
| 57 | 57 | ||
| 58 | if (command_header->type == IPC::CommandType::Close) { | 58 | if (command_header->IsCloseCommand()) { |
| 59 | // Close does not populate the rest of the IPC header | 59 | // Close does not populate the rest of the IPC header |
| 60 | return; | 60 | return; |
| 61 | } | 61 | } |
| @@ -99,39 +99,43 @@ void HLERequestContext::ParseCommandBuffer(const KHandleTable& handle_table, u32 | |||
| 99 | buffer_w_desciptors.push_back(rp.PopRaw<IPC::BufferDescriptorABW>()); | 99 | buffer_w_desciptors.push_back(rp.PopRaw<IPC::BufferDescriptorABW>()); |
| 100 | } | 100 | } |
| 101 | 101 | ||
| 102 | buffer_c_offset = rp.GetCurrentOffset() + command_header->data_size; | 102 | const auto buffer_c_offset = rp.GetCurrentOffset() + command_header->data_size; |
| 103 | 103 | ||
| 104 | // Padding to align to 16 bytes | 104 | if (!command_header->IsTipc()) { |
| 105 | rp.AlignWithPadding(); | 105 | // Padding to align to 16 bytes |
| 106 | 106 | rp.AlignWithPadding(); | |
| 107 | if (Session()->IsDomain() && ((command_header->type == IPC::CommandType::Request || | 107 | |
| 108 | command_header->type == IPC::CommandType::RequestWithContext) || | 108 | if (Session()->IsDomain() && |
| 109 | !incoming)) { | 109 | ((command_header->type == IPC::CommandType::Request || |
| 110 | // If this is an incoming message, only CommandType "Request" has a domain header | 110 | command_header->type == IPC::CommandType::RequestWithContext) || |
| 111 | // All outgoing domain messages have the domain header, if only incoming has it | 111 | !incoming)) { |
| 112 | if (incoming || domain_message_header) { | 112 | // If this is an incoming message, only CommandType "Request" has a domain header |
| 113 | domain_message_header = rp.PopRaw<IPC::DomainMessageHeader>(); | 113 | // All outgoing domain messages have the domain header, if only incoming has it |
| 114 | } else { | 114 | if (incoming || domain_message_header) { |
| 115 | if (Session()->IsDomain()) { | 115 | domain_message_header = rp.PopRaw<IPC::DomainMessageHeader>(); |
| 116 | LOG_WARNING(IPC, "Domain request has no DomainMessageHeader!"); | 116 | } else { |
| 117 | if (Session()->IsDomain()) { | ||
| 118 | LOG_WARNING(IPC, "Domain request has no DomainMessageHeader!"); | ||
| 119 | } | ||
| 117 | } | 120 | } |
| 118 | } | 121 | } |
| 119 | } | ||
| 120 | 122 | ||
| 121 | data_payload_header = rp.PopRaw<IPC::DataPayloadHeader>(); | 123 | data_payload_header = rp.PopRaw<IPC::DataPayloadHeader>(); |
| 122 | 124 | ||
| 123 | data_payload_offset = rp.GetCurrentOffset(); | 125 | data_payload_offset = rp.GetCurrentOffset(); |
| 124 | 126 | ||
| 125 | if (domain_message_header && domain_message_header->command == | 127 | if (domain_message_header && |
| 126 | IPC::DomainMessageHeader::CommandType::CloseVirtualHandle) { | 128 | domain_message_header->command == |
| 127 | // CloseVirtualHandle command does not have SFC* or any data | 129 | IPC::DomainMessageHeader::CommandType::CloseVirtualHandle) { |
| 128 | return; | 130 | // CloseVirtualHandle command does not have SFC* or any data |
| 129 | } | 131 | return; |
| 132 | } | ||
| 130 | 133 | ||
| 131 | if (incoming) { | 134 | if (incoming) { |
| 132 | ASSERT(data_payload_header->magic == Common::MakeMagic('S', 'F', 'C', 'I')); | 135 | ASSERT(data_payload_header->magic == Common::MakeMagic('S', 'F', 'C', 'I')); |
| 133 | } else { | 136 | } else { |
| 134 | ASSERT(data_payload_header->magic == Common::MakeMagic('S', 'F', 'C', 'O')); | 137 | ASSERT(data_payload_header->magic == Common::MakeMagic('S', 'F', 'C', 'O')); |
| 138 | } | ||
| 135 | } | 139 | } |
| 136 | 140 | ||
| 137 | rp.SetCurrentOffset(buffer_c_offset); | 141 | rp.SetCurrentOffset(buffer_c_offset); |
| @@ -166,84 +170,67 @@ void HLERequestContext::ParseCommandBuffer(const KHandleTable& handle_table, u32 | |||
| 166 | ResultCode HLERequestContext::PopulateFromIncomingCommandBuffer(const KHandleTable& handle_table, | 170 | ResultCode HLERequestContext::PopulateFromIncomingCommandBuffer(const KHandleTable& handle_table, |
| 167 | u32_le* src_cmdbuf) { | 171 | u32_le* src_cmdbuf) { |
| 168 | ParseCommandBuffer(handle_table, src_cmdbuf, true); | 172 | ParseCommandBuffer(handle_table, src_cmdbuf, true); |
| 169 | if (command_header->type == IPC::CommandType::Close) { | 173 | |
| 174 | if (command_header->IsCloseCommand()) { | ||
| 170 | // Close does not populate the rest of the IPC header | 175 | // Close does not populate the rest of the IPC header |
| 171 | return RESULT_SUCCESS; | 176 | return RESULT_SUCCESS; |
| 172 | } | 177 | } |
| 173 | 178 | ||
| 174 | // The data_size already includes the payload header, the padding and the domain header. | 179 | std::copy_n(src_cmdbuf, IPC::COMMAND_BUFFER_LENGTH, cmd_buf.begin()); |
| 175 | std::size_t size = data_payload_offset + command_header->data_size - | 180 | |
| 176 | sizeof(IPC::DataPayloadHeader) / sizeof(u32) - 4; | ||
| 177 | if (domain_message_header) | ||
| 178 | size -= sizeof(IPC::DomainMessageHeader) / sizeof(u32); | ||
| 179 | std::copy_n(src_cmdbuf, size, cmd_buf.begin()); | ||
| 180 | return RESULT_SUCCESS; | 181 | return RESULT_SUCCESS; |
| 181 | } | 182 | } |
| 182 | 183 | ||
| 183 | ResultCode HLERequestContext::WriteToOutgoingCommandBuffer(KThread& requesting_thread) { | 184 | ResultCode HLERequestContext::WriteToOutgoingCommandBuffer(KThread& requesting_thread) { |
| 185 | auto current_offset = handles_offset; | ||
| 184 | auto& owner_process = *requesting_thread.GetOwnerProcess(); | 186 | auto& owner_process = *requesting_thread.GetOwnerProcess(); |
| 185 | auto& handle_table = owner_process.GetHandleTable(); | 187 | auto& handle_table = owner_process.GetHandleTable(); |
| 186 | 188 | ||
| 187 | std::array<u32, IPC::COMMAND_BUFFER_LENGTH> dst_cmdbuf; | ||
| 188 | memory.ReadBlock(owner_process, requesting_thread.GetTLSAddress(), dst_cmdbuf.data(), | ||
| 189 | dst_cmdbuf.size() * sizeof(u32)); | ||
| 190 | |||
| 191 | // The header was already built in the internal command buffer. Attempt to parse it to verify | ||
| 192 | // the integrity and then copy it over to the target command buffer. | ||
| 193 | ParseCommandBuffer(handle_table, cmd_buf.data(), false); | ||
| 194 | |||
| 195 | // The data_size already includes the payload header, the padding and the domain header. | 189 | // The data_size already includes the payload header, the padding and the domain header. |
| 196 | std::size_t size = data_payload_offset + command_header->data_size - | 190 | std::size_t size{}; |
| 197 | sizeof(IPC::DataPayloadHeader) / sizeof(u32) - 4; | ||
| 198 | if (domain_message_header) | ||
| 199 | size -= sizeof(IPC::DomainMessageHeader) / sizeof(u32); | ||
| 200 | |||
| 201 | std::copy_n(cmd_buf.begin(), size, dst_cmdbuf.data()); | ||
| 202 | 191 | ||
| 203 | if (command_header->enable_handle_descriptor) { | 192 | if (IsTipc()) { |
| 204 | ASSERT_MSG(!move_objects.empty() || !copy_objects.empty(), | 193 | size = cmd_buf.size(); |
| 205 | "Handle descriptor bit set but no handles to translate"); | 194 | } else { |
| 206 | // We write the translated handles at a specific offset in the command buffer, this space | 195 | size = data_payload_offset + data_size - sizeof(IPC::DataPayloadHeader) / sizeof(u32) - 4; |
| 207 | // was already reserved when writing the header. | 196 | if (Session()->IsDomain()) { |
| 208 | std::size_t current_offset = | 197 | size -= sizeof(IPC::DomainMessageHeader) / sizeof(u32); |
| 209 | (sizeof(IPC::CommandHeader) + sizeof(IPC::HandleDescriptorHeader)) / sizeof(u32); | ||
| 210 | ASSERT_MSG(!handle_descriptor_header->send_current_pid, "Sending PID is not implemented"); | ||
| 211 | |||
| 212 | ASSERT(copy_objects.size() == handle_descriptor_header->num_handles_to_copy); | ||
| 213 | ASSERT(move_objects.size() == handle_descriptor_header->num_handles_to_move); | ||
| 214 | |||
| 215 | // We don't make a distinction between copy and move handles when translating since HLE | ||
| 216 | // services don't deal with handles directly. However, the guest applications might check | ||
| 217 | // for specific values in each of these descriptors. | ||
| 218 | for (auto& object : copy_objects) { | ||
| 219 | ASSERT(object != nullptr); | ||
| 220 | R_TRY(handle_table.Add(&dst_cmdbuf[current_offset++], object)); | ||
| 221 | } | 198 | } |
| 199 | } | ||
| 222 | 200 | ||
| 223 | for (auto& object : move_objects) { | 201 | for (auto& object : copy_objects) { |
| 224 | ASSERT(object != nullptr); | 202 | Handle handle{}; |
| 225 | R_TRY(handle_table.Add(&dst_cmdbuf[current_offset++], object)); | 203 | if (object) { |
| 204 | R_TRY(handle_table.Add(&handle, object)); | ||
| 226 | } | 205 | } |
| 206 | cmd_buf[current_offset++] = handle; | ||
| 227 | } | 207 | } |
| 208 | for (auto& object : move_objects) { | ||
| 209 | Handle handle{}; | ||
| 210 | if (object) { | ||
| 211 | R_TRY(handle_table.Add(&handle, object)); | ||
| 228 | 212 | ||
| 229 | // TODO(Subv): Translate the X/A/B/W buffers. | 213 | // Close our reference to the object, as it is being moved to the caller. |
| 214 | object->Close(); | ||
| 215 | } | ||
| 216 | cmd_buf[current_offset++] = handle; | ||
| 217 | } | ||
| 230 | 218 | ||
| 231 | if (Session()->IsDomain() && domain_message_header) { | 219 | // Write the domain objects to the command buffer, these go after the raw untranslated data. |
| 232 | ASSERT(domain_message_header->num_objects == domain_objects.size()); | 220 | // TODO(Subv): This completely ignores C buffers. |
| 233 | // Write the domain objects to the command buffer, these go after the raw untranslated data. | ||
| 234 | // TODO(Subv): This completely ignores C buffers. | ||
| 235 | std::size_t domain_offset = size - domain_message_header->num_objects; | ||
| 236 | 221 | ||
| 222 | if (Session()->IsDomain()) { | ||
| 223 | current_offset = domain_offset - static_cast<u32>(domain_objects.size()); | ||
| 237 | for (const auto& object : domain_objects) { | 224 | for (const auto& object : domain_objects) { |
| 238 | server_session->AppendDomainRequestHandler(object); | 225 | server_session->AppendDomainRequestHandler(object); |
| 239 | dst_cmdbuf[domain_offset++] = | 226 | cmd_buf[current_offset++] = |
| 240 | static_cast<u32_le>(server_session->NumDomainRequestHandlers()); | 227 | static_cast<u32_le>(server_session->NumDomainRequestHandlers()); |
| 241 | } | 228 | } |
| 242 | } | 229 | } |
| 243 | 230 | ||
| 244 | // Copy the translated command buffer back into the thread's command buffer area. | 231 | // Copy the translated command buffer back into the thread's command buffer area. |
| 245 | memory.WriteBlock(owner_process, requesting_thread.GetTLSAddress(), dst_cmdbuf.data(), | 232 | memory.WriteBlock(owner_process, requesting_thread.GetTLSAddress(), cmd_buf.data(), |
| 246 | dst_cmdbuf.size() * sizeof(u32)); | 233 | size * sizeof(u32)); |
| 247 | 234 | ||
| 248 | return RESULT_SUCCESS; | 235 | return RESULT_SUCCESS; |
| 249 | } | 236 | } |
diff --git a/src/core/hle/kernel/hle_ipc.h b/src/core/hle/kernel/hle_ipc.h index 21e384706..4fba300dc 100644 --- a/src/core/hle/kernel/hle_ipc.h +++ b/src/core/hle/kernel/hle_ipc.h | |||
| @@ -66,7 +66,8 @@ public: | |||
| 66 | * this request (ServerSession, Originator thread, Translated command buffer, etc). | 66 | * this request (ServerSession, Originator thread, Translated command buffer, etc). |
| 67 | * @returns ResultCode the result code of the translate operation. | 67 | * @returns ResultCode the result code of the translate operation. |
| 68 | */ | 68 | */ |
| 69 | virtual ResultCode HandleSyncRequest(Kernel::HLERequestContext& context) = 0; | 69 | virtual ResultCode HandleSyncRequest(Kernel::KServerSession& session, |
| 70 | Kernel::HLERequestContext& context) = 0; | ||
| 70 | 71 | ||
| 71 | /** | 72 | /** |
| 72 | * Signals that a client has just connected to this HLE handler and keeps the | 73 | * Signals that a client has just connected to this HLE handler and keeps the |
| @@ -128,15 +129,28 @@ public: | |||
| 128 | /// Writes data from this context back to the requesting process/thread. | 129 | /// Writes data from this context back to the requesting process/thread. |
| 129 | ResultCode WriteToOutgoingCommandBuffer(KThread& requesting_thread); | 130 | ResultCode WriteToOutgoingCommandBuffer(KThread& requesting_thread); |
| 130 | 131 | ||
| 131 | u32_le GetCommand() const { | 132 | u32_le GetHipcCommand() const { |
| 132 | return command; | 133 | return command; |
| 133 | } | 134 | } |
| 134 | 135 | ||
| 136 | u32_le GetTipcCommand() const { | ||
| 137 | return static_cast<u32_le>(command_header->type.Value()) - | ||
| 138 | static_cast<u32_le>(IPC::CommandType::TIPC_CommandRegion); | ||
| 139 | } | ||
| 140 | |||
| 141 | u32_le GetCommand() const { | ||
| 142 | return command_header->IsTipc() ? GetTipcCommand() : GetHipcCommand(); | ||
| 143 | } | ||
| 144 | |||
| 145 | bool IsTipc() const { | ||
| 146 | return command_header->IsTipc(); | ||
| 147 | } | ||
| 148 | |||
| 135 | IPC::CommandType GetCommandType() const { | 149 | IPC::CommandType GetCommandType() const { |
| 136 | return command_header->type; | 150 | return command_header->type; |
| 137 | } | 151 | } |
| 138 | 152 | ||
| 139 | unsigned GetDataPayloadOffset() const { | 153 | u32 GetDataPayloadOffset() const { |
| 140 | return data_payload_offset; | 154 | return data_payload_offset; |
| 141 | } | 155 | } |
| 142 | 156 | ||
| @@ -291,8 +305,10 @@ private: | |||
| 291 | std::vector<IPC::BufferDescriptorABW> buffer_w_desciptors; | 305 | std::vector<IPC::BufferDescriptorABW> buffer_w_desciptors; |
| 292 | std::vector<IPC::BufferDescriptorC> buffer_c_desciptors; | 306 | std::vector<IPC::BufferDescriptorC> buffer_c_desciptors; |
| 293 | 307 | ||
| 294 | unsigned data_payload_offset{}; | 308 | u32 data_payload_offset{}; |
| 295 | unsigned buffer_c_offset{}; | 309 | u32 handles_offset{}; |
| 310 | u32 domain_offset{}; | ||
| 311 | u32 data_size{}; | ||
| 296 | u32_le command{}; | 312 | u32_le command{}; |
| 297 | 313 | ||
| 298 | std::vector<std::shared_ptr<SessionRequestHandler>> domain_request_handlers; | 314 | std::vector<std::shared_ptr<SessionRequestHandler>> domain_request_handlers; |
diff --git a/src/core/hle/kernel/k_client_port.cpp b/src/core/hle/kernel/k_client_port.cpp index e14b915b9..ad01cf67e 100644 --- a/src/core/hle/kernel/k_client_port.cpp +++ b/src/core/hle/kernel/k_client_port.cpp | |||
| @@ -58,9 +58,9 @@ bool KClientPort::IsSignaled() const { | |||
| 58 | 58 | ||
| 59 | ResultCode KClientPort::CreateSession(KClientSession** out) { | 59 | ResultCode KClientPort::CreateSession(KClientSession** out) { |
| 60 | // Reserve a new session from the resource limit. | 60 | // Reserve a new session from the resource limit. |
| 61 | KScopedResourceReservation session_reservation(kernel.CurrentProcess()->GetResourceLimit(), | 61 | // KScopedResourceReservation session_reservation(kernel.CurrentProcess()->GetResourceLimit(), |
| 62 | LimitableResource::Sessions); | 62 | // LimitableResource::Sessions); |
| 63 | R_UNLESS(session_reservation.Succeeded(), ResultLimitReached); | 63 | // R_UNLESS(session_reservation.Succeeded(), ResultLimitReached); |
| 64 | 64 | ||
| 65 | // Update the session counts. | 65 | // Update the session counts. |
| 66 | { | 66 | { |
| @@ -91,7 +91,7 @@ ResultCode KClientPort::CreateSession(KClientSession** out) { | |||
| 91 | // Create a new session. | 91 | // Create a new session. |
| 92 | KSession* session = KSession::Create(kernel); | 92 | KSession* session = KSession::Create(kernel); |
| 93 | if (session == nullptr) { | 93 | if (session == nullptr) { |
| 94 | /* Decrement the session count. */ | 94 | // Decrement the session count. |
| 95 | const auto prev = num_sessions--; | 95 | const auto prev = num_sessions--; |
| 96 | if (prev == max_sessions) { | 96 | if (prev == max_sessions) { |
| 97 | this->NotifyAvailable(); | 97 | this->NotifyAvailable(); |
| @@ -104,7 +104,7 @@ ResultCode KClientPort::CreateSession(KClientSession** out) { | |||
| 104 | session->Initialize(this, parent->GetName()); | 104 | session->Initialize(this, parent->GetName()); |
| 105 | 105 | ||
| 106 | // Commit the session reservation. | 106 | // Commit the session reservation. |
| 107 | session_reservation.Commit(); | 107 | // session_reservation.Commit(); |
| 108 | 108 | ||
| 109 | // Register the session. | 109 | // Register the session. |
| 110 | KSession::Register(kernel, session); | 110 | KSession::Register(kernel, session); |
diff --git a/src/core/hle/kernel/k_light_condition_variable.h b/src/core/hle/kernel/k_light_condition_variable.h index 362d0db28..ca2e539a7 100644 --- a/src/core/hle/kernel/k_light_condition_variable.h +++ b/src/core/hle/kernel/k_light_condition_variable.h | |||
| @@ -18,7 +18,8 @@ class KernelCore; | |||
| 18 | 18 | ||
| 19 | class KLightConditionVariable { | 19 | class KLightConditionVariable { |
| 20 | public: | 20 | public: |
| 21 | explicit KLightConditionVariable(KernelCore& kernel) : thread_queue(kernel), kernel(kernel) {} | 21 | explicit KLightConditionVariable(KernelCore& kernel_) |
| 22 | : thread_queue(kernel_), kernel(kernel_) {} | ||
| 22 | 23 | ||
| 23 | void Wait(KLightLock* lock, s64 timeout = -1) { | 24 | void Wait(KLightLock* lock, s64 timeout = -1) { |
| 24 | WaitImpl(lock, timeout); | 25 | WaitImpl(lock, timeout); |
diff --git a/src/core/hle/kernel/k_linked_list.h b/src/core/hle/kernel/k_linked_list.h index 540e518cd..6adfe1e34 100644 --- a/src/core/hle/kernel/k_linked_list.h +++ b/src/core/hle/kernel/k_linked_list.h | |||
| @@ -201,10 +201,10 @@ public: | |||
| 201 | } | 201 | } |
| 202 | 202 | ||
| 203 | iterator insert(const_iterator pos, reference ref) { | 203 | iterator insert(const_iterator pos, reference ref) { |
| 204 | KLinkedListNode* node = KLinkedListNode::Allocate(kernel); | 204 | KLinkedListNode* new_node = KLinkedListNode::Allocate(kernel); |
| 205 | ASSERT(node != nullptr); | 205 | ASSERT(new_node != nullptr); |
| 206 | node->Initialize(std::addressof(ref)); | 206 | new_node->Initialize(std::addressof(ref)); |
| 207 | return iterator(BaseList::insert(pos.m_base_it, *node)); | 207 | return iterator(BaseList::insert(pos.m_base_it, *new_node)); |
| 208 | } | 208 | } |
| 209 | 209 | ||
| 210 | void push_back(reference ref) { | 210 | void push_back(reference ref) { |
diff --git a/src/core/hle/kernel/k_memory_block_manager.cpp b/src/core/hle/kernel/k_memory_block_manager.cpp index 44bfeb0d5..fc7033564 100644 --- a/src/core/hle/kernel/k_memory_block_manager.cpp +++ b/src/core/hle/kernel/k_memory_block_manager.cpp | |||
| @@ -7,8 +7,8 @@ | |||
| 7 | 7 | ||
| 8 | namespace Kernel { | 8 | namespace Kernel { |
| 9 | 9 | ||
| 10 | KMemoryBlockManager::KMemoryBlockManager(VAddr start_addr, VAddr end_addr) | 10 | KMemoryBlockManager::KMemoryBlockManager(VAddr start_addr_, VAddr end_addr_) |
| 11 | : start_addr{start_addr}, end_addr{end_addr} { | 11 | : start_addr{start_addr_}, end_addr{end_addr_} { |
| 12 | const u64 num_pages{(end_addr - start_addr) / PageSize}; | 12 | const u64 num_pages{(end_addr - start_addr) / PageSize}; |
| 13 | memory_block_tree.emplace_back(start_addr, num_pages, KMemoryState::Free, | 13 | memory_block_tree.emplace_back(start_addr, num_pages, KMemoryState::Free, |
| 14 | KMemoryPermission::None, KMemoryAttribute::None); | 14 | KMemoryPermission::None, KMemoryAttribute::None); |
diff --git a/src/core/hle/kernel/k_memory_block_manager.h b/src/core/hle/kernel/k_memory_block_manager.h index e11cc70c8..d222da919 100644 --- a/src/core/hle/kernel/k_memory_block_manager.h +++ b/src/core/hle/kernel/k_memory_block_manager.h | |||
| @@ -19,7 +19,7 @@ public: | |||
| 19 | using const_iterator = MemoryBlockTree::const_iterator; | 19 | using const_iterator = MemoryBlockTree::const_iterator; |
| 20 | 20 | ||
| 21 | public: | 21 | public: |
| 22 | KMemoryBlockManager(VAddr start_addr, VAddr end_addr); | 22 | KMemoryBlockManager(VAddr start_addr_, VAddr end_addr_); |
| 23 | 23 | ||
| 24 | iterator end() { | 24 | iterator end() { |
| 25 | return memory_block_tree.end(); | 25 | return memory_block_tree.end(); |
diff --git a/src/core/hle/kernel/k_page_linked_list.h b/src/core/hle/kernel/k_page_linked_list.h index 64024d01f..dfdac5321 100644 --- a/src/core/hle/kernel/k_page_linked_list.h +++ b/src/core/hle/kernel/k_page_linked_list.h | |||
| @@ -17,7 +17,7 @@ class KPageLinkedList final { | |||
| 17 | public: | 17 | public: |
| 18 | class Node final { | 18 | class Node final { |
| 19 | public: | 19 | public: |
| 20 | constexpr Node(u64 addr, std::size_t num_pages) : addr{addr}, num_pages{num_pages} {} | 20 | constexpr Node(u64 addr_, std::size_t num_pages_) : addr{addr_}, num_pages{num_pages_} {} |
| 21 | 21 | ||
| 22 | constexpr u64 GetAddress() const { | 22 | constexpr u64 GetAddress() const { |
| 23 | return addr; | 23 | return addr; |
diff --git a/src/core/hle/kernel/k_page_table.cpp b/src/core/hle/kernel/k_page_table.cpp index d4ce98ee3..27dbf0ebc 100644 --- a/src/core/hle/kernel/k_page_table.cpp +++ b/src/core/hle/kernel/k_page_table.cpp | |||
| @@ -58,7 +58,7 @@ constexpr std::size_t GetSizeInRange(const KMemoryInfo& info, VAddr start, VAddr | |||
| 58 | 58 | ||
| 59 | } // namespace | 59 | } // namespace |
| 60 | 60 | ||
| 61 | KPageTable::KPageTable(Core::System& system) : system{system} {} | 61 | KPageTable::KPageTable(Core::System& system_) : system{system_} {} |
| 62 | 62 | ||
| 63 | ResultCode KPageTable::InitializeForProcess(FileSys::ProgramAddressSpaceType as_type, | 63 | ResultCode KPageTable::InitializeForProcess(FileSys::ProgramAddressSpaceType as_type, |
| 64 | bool enable_aslr, VAddr code_addr, | 64 | bool enable_aslr, VAddr code_addr, |
| @@ -906,8 +906,8 @@ ResultCode KPageTable::LockForDeviceAddressSpace(VAddr addr, std::size_t size) { | |||
| 906 | 906 | ||
| 907 | block_manager->UpdateLock( | 907 | block_manager->UpdateLock( |
| 908 | addr, size / PageSize, | 908 | addr, size / PageSize, |
| 909 | [](KMemoryBlockManager::iterator block, KMemoryPermission perm) { | 909 | [](KMemoryBlockManager::iterator block, KMemoryPermission permission) { |
| 910 | block->ShareToDevice(perm); | 910 | block->ShareToDevice(permission); |
| 911 | }, | 911 | }, |
| 912 | perm); | 912 | perm); |
| 913 | 913 | ||
| @@ -929,8 +929,8 @@ ResultCode KPageTable::UnlockForDeviceAddressSpace(VAddr addr, std::size_t size) | |||
| 929 | 929 | ||
| 930 | block_manager->UpdateLock( | 930 | block_manager->UpdateLock( |
| 931 | addr, size / PageSize, | 931 | addr, size / PageSize, |
| 932 | [](KMemoryBlockManager::iterator block, KMemoryPermission perm) { | 932 | [](KMemoryBlockManager::iterator block, KMemoryPermission permission) { |
| 933 | block->UnshareToDevice(perm); | 933 | block->UnshareToDevice(permission); |
| 934 | }, | 934 | }, |
| 935 | perm); | 935 | perm); |
| 936 | 936 | ||
diff --git a/src/core/hle/kernel/k_page_table.h b/src/core/hle/kernel/k_page_table.h index 8c2cc03eb..770c4841c 100644 --- a/src/core/hle/kernel/k_page_table.h +++ b/src/core/hle/kernel/k_page_table.h | |||
| @@ -24,7 +24,7 @@ class KMemoryBlockManager; | |||
| 24 | 24 | ||
| 25 | class KPageTable final : NonCopyable { | 25 | class KPageTable final : NonCopyable { |
| 26 | public: | 26 | public: |
| 27 | explicit KPageTable(Core::System& system); | 27 | explicit KPageTable(Core::System& system_); |
| 28 | 28 | ||
| 29 | ResultCode InitializeForProcess(FileSys::ProgramAddressSpaceType as_type, bool enable_aslr, | 29 | ResultCode InitializeForProcess(FileSys::ProgramAddressSpaceType as_type, bool enable_aslr, |
| 30 | VAddr code_addr, std::size_t code_size, | 30 | VAddr code_addr, std::size_t code_size, |
diff --git a/src/core/hle/kernel/k_scheduler.cpp b/src/core/hle/kernel/k_scheduler.cpp index e256e9415..2f82fbcd6 100644 --- a/src/core/hle/kernel/k_scheduler.cpp +++ b/src/core/hle/kernel/k_scheduler.cpp | |||
| @@ -607,7 +607,7 @@ void KScheduler::YieldToAnyThread(KernelCore& kernel) { | |||
| 607 | } | 607 | } |
| 608 | } | 608 | } |
| 609 | 609 | ||
| 610 | KScheduler::KScheduler(Core::System& system, s32 core_id) : system(system), core_id(core_id) { | 610 | KScheduler::KScheduler(Core::System& system_, s32 core_id_) : system{system_}, core_id{core_id_} { |
| 611 | switch_fiber = std::make_shared<Common::Fiber>(OnSwitch, this); | 611 | switch_fiber = std::make_shared<Common::Fiber>(OnSwitch, this); |
| 612 | state.needs_scheduling.store(true); | 612 | state.needs_scheduling.store(true); |
| 613 | state.interrupt_task_thread_runnable = false; | 613 | state.interrupt_task_thread_runnable = false; |
diff --git a/src/core/hle/kernel/k_scheduler.h b/src/core/hle/kernel/k_scheduler.h index 13a2414e6..12cfae919 100644 --- a/src/core/hle/kernel/k_scheduler.h +++ b/src/core/hle/kernel/k_scheduler.h | |||
| @@ -30,7 +30,7 @@ class KThread; | |||
| 30 | 30 | ||
| 31 | class KScheduler final { | 31 | class KScheduler final { |
| 32 | public: | 32 | public: |
| 33 | explicit KScheduler(Core::System& system, s32 core_id); | 33 | explicit KScheduler(Core::System& system_, s32 core_id_); |
| 34 | ~KScheduler(); | 34 | ~KScheduler(); |
| 35 | 35 | ||
| 36 | /// Reschedules to the next available thread (call after current thread is suspended) | 36 | /// Reschedules to the next available thread (call after current thread is suspended) |
diff --git a/src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h b/src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h index b5d405744..a86af56dd 100644 --- a/src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h +++ b/src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h | |||
| @@ -17,8 +17,8 @@ namespace Kernel { | |||
| 17 | 17 | ||
| 18 | class [[nodiscard]] KScopedSchedulerLockAndSleep { | 18 | class [[nodiscard]] KScopedSchedulerLockAndSleep { |
| 19 | public: | 19 | public: |
| 20 | explicit KScopedSchedulerLockAndSleep(KernelCore & kernel, KThread * t, s64 timeout) | 20 | explicit KScopedSchedulerLockAndSleep(KernelCore & kernel_, KThread * t, s64 timeout) |
| 21 | : kernel(kernel), thread(t), timeout_tick(timeout) { | 21 | : kernel(kernel_), thread(t), timeout_tick(timeout) { |
| 22 | // Lock the scheduler. | 22 | // Lock the scheduler. |
| 23 | kernel.GlobalSchedulerContext().scheduler_lock.Lock(); | 23 | kernel.GlobalSchedulerContext().scheduler_lock.Lock(); |
| 24 | } | 24 | } |
diff --git a/src/core/hle/kernel/k_server_session.cpp b/src/core/hle/kernel/k_server_session.cpp index b28cc2499..8850d9af5 100644 --- a/src/core/hle/kernel/k_server_session.cpp +++ b/src/core/hle/kernel/k_server_session.cpp | |||
| @@ -95,7 +95,7 @@ ResultCode KServerSession::HandleDomainSyncRequest(Kernel::HLERequestContext& co | |||
| 95 | UNREACHABLE(); | 95 | UNREACHABLE(); |
| 96 | return RESULT_SUCCESS; // Ignore error if asserts are off | 96 | return RESULT_SUCCESS; // Ignore error if asserts are off |
| 97 | } | 97 | } |
| 98 | return domain_request_handlers[object_id - 1]->HandleSyncRequest(context); | 98 | return domain_request_handlers[object_id - 1]->HandleSyncRequest(*this, context); |
| 99 | 99 | ||
| 100 | case IPC::DomainMessageHeader::CommandType::CloseVirtualHandle: { | 100 | case IPC::DomainMessageHeader::CommandType::CloseVirtualHandle: { |
| 101 | LOG_DEBUG(IPC, "CloseVirtualHandle, object_id=0x{:08X}", object_id); | 101 | LOG_DEBUG(IPC, "CloseVirtualHandle, object_id=0x{:08X}", object_id); |
| @@ -135,7 +135,7 @@ ResultCode KServerSession::CompleteSyncRequest(HLERequestContext& context) { | |||
| 135 | // If there is no domain header, the regular session handler is used | 135 | // If there is no domain header, the regular session handler is used |
| 136 | } else if (hle_handler != nullptr) { | 136 | } else if (hle_handler != nullptr) { |
| 137 | // If this ServerSession has an associated HLE handler, forward the request to it. | 137 | // If this ServerSession has an associated HLE handler, forward the request to it. |
| 138 | result = hle_handler->HandleSyncRequest(context); | 138 | result = hle_handler->HandleSyncRequest(*this, context); |
| 139 | } | 139 | } |
| 140 | 140 | ||
| 141 | if (convert_to_domain) { | 141 | if (convert_to_domain) { |
diff --git a/src/core/hle/kernel/k_session.cpp b/src/core/hle/kernel/k_session.cpp index 025b8b555..b7ce27a0b 100644 --- a/src/core/hle/kernel/k_session.cpp +++ b/src/core/hle/kernel/k_session.cpp | |||
| @@ -78,7 +78,7 @@ void KSession::OnClientClosed() { | |||
| 78 | void KSession::PostDestroy(uintptr_t arg) { | 78 | void KSession::PostDestroy(uintptr_t arg) { |
| 79 | // Release the session count resource the owner process holds. | 79 | // Release the session count resource the owner process holds. |
| 80 | KProcess* owner = reinterpret_cast<KProcess*>(arg); | 80 | KProcess* owner = reinterpret_cast<KProcess*>(arg); |
| 81 | owner->GetResourceLimit()->Release(LimitableResource::Sessions, 1); | 81 | // owner->GetResourceLimit()->Release(LimitableResource::Sessions, 1); |
| 82 | owner->Close(); | 82 | owner->Close(); |
| 83 | } | 83 | } |
| 84 | 84 | ||
diff --git a/src/core/hle/kernel/k_thread_queue.h b/src/core/hle/kernel/k_thread_queue.h index c52eba249..35d471dc5 100644 --- a/src/core/hle/kernel/k_thread_queue.h +++ b/src/core/hle/kernel/k_thread_queue.h | |||
| @@ -10,7 +10,7 @@ namespace Kernel { | |||
| 10 | 10 | ||
| 11 | class KThreadQueue { | 11 | class KThreadQueue { |
| 12 | public: | 12 | public: |
| 13 | explicit KThreadQueue(KernelCore& kernel) : kernel{kernel} {} | 13 | explicit KThreadQueue(KernelCore& kernel_) : kernel{kernel_} {} |
| 14 | 14 | ||
| 15 | bool IsEmpty() const { | 15 | bool IsEmpty() const { |
| 16 | return wait_list.empty(); | 16 | return wait_list.empty(); |
diff --git a/src/core/hle/kernel/kernel.cpp b/src/core/hle/kernel/kernel.cpp index bd4e4d350..8b55df82e 100644 --- a/src/core/hle/kernel/kernel.cpp +++ b/src/core/hle/kernel/kernel.cpp | |||
| @@ -44,6 +44,7 @@ | |||
| 44 | #include "core/hle/kernel/time_manager.h" | 44 | #include "core/hle/kernel/time_manager.h" |
| 45 | #include "core/hle/lock.h" | 45 | #include "core/hle/lock.h" |
| 46 | #include "core/hle/result.h" | 46 | #include "core/hle/result.h" |
| 47 | #include "core/hle/service/sm/sm.h" | ||
| 47 | #include "core/memory.h" | 48 | #include "core/memory.h" |
| 48 | 49 | ||
| 49 | MICROPROFILE_DEFINE(Kernel_SVC, "Kernel", "SVC", MP_RGB(70, 200, 70)); | 50 | MICROPROFILE_DEFINE(Kernel_SVC, "Kernel", "SVC", MP_RGB(70, 200, 70)); |
| @@ -656,6 +657,7 @@ struct KernelCore::Impl { | |||
| 656 | 657 | ||
| 657 | /// Map of named ports managed by the kernel, which can be retrieved using | 658 | /// Map of named ports managed by the kernel, which can be retrieved using |
| 658 | /// the ConnectToPort SVC. | 659 | /// the ConnectToPort SVC. |
| 660 | std::unordered_map<std::string, ServiceInterfaceFactory> service_interface_factory; | ||
| 659 | NamedPortTable named_ports; | 661 | NamedPortTable named_ports; |
| 660 | 662 | ||
| 661 | std::unique_ptr<Core::ExclusiveMonitor> exclusive_monitor; | 663 | std::unique_ptr<Core::ExclusiveMonitor> exclusive_monitor; |
| @@ -844,18 +846,17 @@ void KernelCore::PrepareReschedule(std::size_t id) { | |||
| 844 | // TODO: Reimplement, this | 846 | // TODO: Reimplement, this |
| 845 | } | 847 | } |
| 846 | 848 | ||
| 847 | void KernelCore::AddNamedPort(std::string name, KClientPort* port) { | 849 | void KernelCore::RegisterNamedService(std::string name, ServiceInterfaceFactory&& factory) { |
| 848 | port->Open(); | 850 | impl->service_interface_factory.emplace(std::move(name), factory); |
| 849 | impl->named_ports.emplace(std::move(name), port); | ||
| 850 | } | 851 | } |
| 851 | 852 | ||
| 852 | KernelCore::NamedPortTable::iterator KernelCore::FindNamedPort(const std::string& name) { | 853 | KClientPort* KernelCore::CreateNamedServicePort(std::string name) { |
| 853 | return impl->named_ports.find(name); | 854 | auto search = impl->service_interface_factory.find(name); |
| 854 | } | 855 | if (search == impl->service_interface_factory.end()) { |
| 855 | 856 | UNIMPLEMENTED(); | |
| 856 | KernelCore::NamedPortTable::const_iterator KernelCore::FindNamedPort( | 857 | return {}; |
| 857 | const std::string& name) const { | 858 | } |
| 858 | return impl->named_ports.find(name); | 859 | return &search->second(impl->system.ServiceManager(), impl->system); |
| 859 | } | 860 | } |
| 860 | 861 | ||
| 861 | bool KernelCore::IsValidNamedPort(NamedPortTable::const_iterator port) const { | 862 | bool KernelCore::IsValidNamedPort(NamedPortTable::const_iterator port) const { |
diff --git a/src/core/hle/kernel/kernel.h b/src/core/hle/kernel/kernel.h index 51aaccbc7..2d01e1ae0 100644 --- a/src/core/hle/kernel/kernel.h +++ b/src/core/hle/kernel/kernel.h | |||
| @@ -27,6 +27,10 @@ class CoreTiming; | |||
| 27 | struct EventType; | 27 | struct EventType; |
| 28 | } // namespace Core::Timing | 28 | } // namespace Core::Timing |
| 29 | 29 | ||
| 30 | namespace Service::SM { | ||
| 31 | class ServiceManager; | ||
| 32 | } | ||
| 33 | |||
| 30 | namespace Kernel { | 34 | namespace Kernel { |
| 31 | 35 | ||
| 32 | class KClientPort; | 36 | class KClientPort; |
| @@ -51,6 +55,9 @@ class ServiceThread; | |||
| 51 | class Synchronization; | 55 | class Synchronization; |
| 52 | class TimeManager; | 56 | class TimeManager; |
| 53 | 57 | ||
| 58 | using ServiceInterfaceFactory = | ||
| 59 | std::function<KClientPort&(Service::SM::ServiceManager&, Core::System&)>; | ||
| 60 | |||
| 54 | namespace Init { | 61 | namespace Init { |
| 55 | struct KSlabResourceCounts; | 62 | struct KSlabResourceCounts; |
| 56 | } | 63 | } |
| @@ -172,14 +179,11 @@ public: | |||
| 172 | 179 | ||
| 173 | void InvalidateCpuInstructionCacheRange(VAddr addr, std::size_t size); | 180 | void InvalidateCpuInstructionCacheRange(VAddr addr, std::size_t size); |
| 174 | 181 | ||
| 175 | /// Adds a port to the named port table | 182 | /// Registers a named HLE service, passing a factory used to open a port to that service. |
| 176 | void AddNamedPort(std::string name, KClientPort* port); | 183 | void RegisterNamedService(std::string name, ServiceInterfaceFactory&& factory); |
| 177 | |||
| 178 | /// Finds a port within the named port table with the given name. | ||
| 179 | NamedPortTable::iterator FindNamedPort(const std::string& name); | ||
| 180 | 184 | ||
| 181 | /// Finds a port within the named port table with the given name. | 185 | /// Opens a port to a service previously registered with RegisterNamedService. |
| 182 | NamedPortTable::const_iterator FindNamedPort(const std::string& name) const; | 186 | KClientPort* CreateNamedServicePort(std::string name); |
| 183 | 187 | ||
| 184 | /// Determines whether or not the given port is a valid named port. | 188 | /// Determines whether or not the given port is a valid named port. |
| 185 | bool IsValidNamedPort(NamedPortTable::const_iterator port) const; | 189 | bool IsValidNamedPort(NamedPortTable::const_iterator port) const; |
diff --git a/src/core/hle/kernel/physical_core.cpp b/src/core/hle/kernel/physical_core.cpp index 7fea45f96..7f02d9471 100644 --- a/src/core/hle/kernel/physical_core.cpp +++ b/src/core/hle/kernel/physical_core.cpp | |||
| @@ -13,10 +13,10 @@ | |||
| 13 | 13 | ||
| 14 | namespace Kernel { | 14 | namespace Kernel { |
| 15 | 15 | ||
| 16 | PhysicalCore::PhysicalCore(std::size_t core_index, Core::System& system, | 16 | PhysicalCore::PhysicalCore(std::size_t core_index_, Core::System& system_, KScheduler& scheduler_, |
| 17 | Kernel::KScheduler& scheduler, Core::CPUInterrupts& interrupts) | 17 | Core::CPUInterrupts& interrupts_) |
| 18 | : core_index{core_index}, system{system}, scheduler{scheduler}, | 18 | : core_index{core_index_}, system{system_}, scheduler{scheduler_}, |
| 19 | interrupts{interrupts}, guard{std::make_unique<Common::SpinLock>()} {} | 19 | interrupts{interrupts_}, guard{std::make_unique<Common::SpinLock>()} {} |
| 20 | 20 | ||
| 21 | PhysicalCore::~PhysicalCore() = default; | 21 | PhysicalCore::~PhysicalCore() = default; |
| 22 | 22 | ||
diff --git a/src/core/hle/kernel/physical_core.h b/src/core/hle/kernel/physical_core.h index f2b0911aa..901f7e3b0 100644 --- a/src/core/hle/kernel/physical_core.h +++ b/src/core/hle/kernel/physical_core.h | |||
| @@ -28,8 +28,8 @@ namespace Kernel { | |||
| 28 | 28 | ||
| 29 | class PhysicalCore { | 29 | class PhysicalCore { |
| 30 | public: | 30 | public: |
| 31 | PhysicalCore(std::size_t core_index, Core::System& system, Kernel::KScheduler& scheduler, | 31 | PhysicalCore(std::size_t core_index_, Core::System& system_, KScheduler& scheduler_, |
| 32 | Core::CPUInterrupts& interrupts); | 32 | Core::CPUInterrupts& interrupts_); |
| 33 | ~PhysicalCore(); | 33 | ~PhysicalCore(); |
| 34 | 34 | ||
| 35 | PhysicalCore(const PhysicalCore&) = delete; | 35 | PhysicalCore(const PhysicalCore&) = delete; |
diff --git a/src/core/hle/kernel/slab_helpers.h b/src/core/hle/kernel/slab_helpers.h index 0c5995db0..d0f7f084b 100644 --- a/src/core/hle/kernel/slab_helpers.h +++ b/src/core/hle/kernel/slab_helpers.h | |||
| @@ -67,11 +67,11 @@ class KAutoObjectWithSlabHeapAndContainer : public Base { | |||
| 67 | 67 | ||
| 68 | private: | 68 | private: |
| 69 | static Derived* Allocate(KernelCore& kernel) { | 69 | static Derived* Allocate(KernelCore& kernel) { |
| 70 | return kernel.SlabHeap<Derived>().AllocateWithKernel(kernel); | 70 | return new Derived(kernel); |
| 71 | } | 71 | } |
| 72 | 72 | ||
| 73 | static void Free(KernelCore& kernel, Derived* obj) { | 73 | static void Free(KernelCore& kernel, Derived* obj) { |
| 74 | kernel.SlabHeap<Derived>().Free(obj); | 74 | delete obj; |
| 75 | } | 75 | } |
| 76 | 76 | ||
| 77 | public: | 77 | public: |
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp index 52011be9c..81e23f700 100644 --- a/src/core/hle/kernel/svc.cpp +++ b/src/core/hle/kernel/svc.cpp | |||
| @@ -284,12 +284,11 @@ static ResultCode ConnectToNamedPort(Core::System& system, Handle* out, VAddr po | |||
| 284 | auto& handle_table = kernel.CurrentProcess()->GetHandleTable(); | 284 | auto& handle_table = kernel.CurrentProcess()->GetHandleTable(); |
| 285 | 285 | ||
| 286 | // Find the client port. | 286 | // Find the client port. |
| 287 | const auto it = kernel.FindNamedPort(port_name); | 287 | auto port = kernel.CreateNamedServicePort(port_name); |
| 288 | if (!kernel.IsValidNamedPort(it)) { | 288 | if (!port) { |
| 289 | LOG_WARNING(Kernel_SVC, "tried to connect to unknown port: {}", port_name); | 289 | LOG_ERROR(Kernel_SVC, "tried to connect to unknown port: {}", port_name); |
| 290 | return ResultNotFound; | 290 | return ResultNotFound; |
| 291 | } | 291 | } |
| 292 | auto port = it->second; | ||
| 293 | 292 | ||
| 294 | // Reserve a handle for the port. | 293 | // Reserve a handle for the port. |
| 295 | // NOTE: Nintendo really does write directly to the output handle here. | 294 | // NOTE: Nintendo really does write directly to the output handle here. |
| @@ -820,10 +819,10 @@ static ResultCode GetInfo(Core::System& system, u64* result, u64 info_id, Handle | |||
| 820 | return RESULT_SUCCESS; | 819 | return RESULT_SUCCESS; |
| 821 | } | 820 | } |
| 822 | 821 | ||
| 823 | Handle handle{}; | 822 | Handle resource_handle{}; |
| 824 | R_TRY(handle_table.Add(&handle, resource_limit)); | 823 | R_TRY(handle_table.Add(&resource_handle, resource_limit)); |
| 825 | 824 | ||
| 826 | *result = handle; | 825 | *result = resource_handle; |
| 827 | return RESULT_SUCCESS; | 826 | return RESULT_SUCCESS; |
| 828 | } | 827 | } |
| 829 | 828 | ||
diff --git a/src/core/hle/result.h b/src/core/hle/result.h index 8feda7ad7..43968386f 100644 --- a/src/core/hle/result.h +++ b/src/core/hle/result.h | |||
| @@ -56,7 +56,7 @@ enum class ErrorModule : u32 { | |||
| 56 | PCIe = 120, | 56 | PCIe = 120, |
| 57 | Friends = 121, | 57 | Friends = 121, |
| 58 | BCAT = 122, | 58 | BCAT = 122, |
| 59 | SSL = 123, | 59 | SSLSrv = 123, |
| 60 | Account = 124, | 60 | Account = 124, |
| 61 | News = 125, | 61 | News = 125, |
| 62 | Mii = 126, | 62 | Mii = 126, |
diff --git a/src/core/hle/service/am/am.cpp b/src/core/hle/service/am/am.cpp index 408e441dc..234173297 100644 --- a/src/core/hle/service/am/am.cpp +++ b/src/core/hle/service/am/am.cpp | |||
| @@ -833,7 +833,7 @@ IStorageImpl::~IStorageImpl() = default; | |||
| 833 | 833 | ||
| 834 | class StorageDataImpl final : public IStorageImpl { | 834 | class StorageDataImpl final : public IStorageImpl { |
| 835 | public: | 835 | public: |
| 836 | explicit StorageDataImpl(std::vector<u8>&& buffer) : buffer{std::move(buffer)} {} | 836 | explicit StorageDataImpl(std::vector<u8>&& buffer_) : buffer{std::move(buffer_)} {} |
| 837 | 837 | ||
| 838 | std::vector<u8>& GetData() override { | 838 | std::vector<u8>& GetData() override { |
| 839 | return buffer; | 839 | return buffer; |
| @@ -1513,9 +1513,9 @@ void IApplicationFunctions::GetDisplayVersion(Kernel::HLERequestContext& ctx) { | |||
| 1513 | 1513 | ||
| 1514 | const FileSys::PatchManager pm{title_id, system.GetFileSystemController(), | 1514 | const FileSys::PatchManager pm{title_id, system.GetFileSystemController(), |
| 1515 | system.GetContentProvider()}; | 1515 | system.GetContentProvider()}; |
| 1516 | auto res = pm.GetControlMetadata(); | 1516 | auto metadata = pm.GetControlMetadata(); |
| 1517 | if (res.first != nullptr) { | 1517 | if (metadata.first != nullptr) { |
| 1518 | return res; | 1518 | return metadata; |
| 1519 | } | 1519 | } |
| 1520 | 1520 | ||
| 1521 | const FileSys::PatchManager pm_update{FileSys::GetUpdateTitleID(title_id), | 1521 | const FileSys::PatchManager pm_update{FileSys::GetUpdateTitleID(title_id), |
| @@ -1550,9 +1550,9 @@ void IApplicationFunctions::GetDesiredLanguage(Kernel::HLERequestContext& ctx) { | |||
| 1550 | 1550 | ||
| 1551 | const FileSys::PatchManager pm{title_id, system.GetFileSystemController(), | 1551 | const FileSys::PatchManager pm{title_id, system.GetFileSystemController(), |
| 1552 | system.GetContentProvider()}; | 1552 | system.GetContentProvider()}; |
| 1553 | auto res = pm.GetControlMetadata(); | 1553 | auto metadata = pm.GetControlMetadata(); |
| 1554 | if (res.first != nullptr) { | 1554 | if (metadata.first != nullptr) { |
| 1555 | return res; | 1555 | return metadata; |
| 1556 | } | 1556 | } |
| 1557 | 1557 | ||
| 1558 | const FileSys::PatchManager pm_update{FileSys::GetUpdateTitleID(title_id), | 1558 | const FileSys::PatchManager pm_update{FileSys::GetUpdateTitleID(title_id), |
diff --git a/src/core/hle/service/apm/controller.cpp b/src/core/hle/service/apm/controller.cpp index 00c174bb0..8bfa7c0e4 100644 --- a/src/core/hle/service/apm/controller.cpp +++ b/src/core/hle/service/apm/controller.cpp | |||
| @@ -15,11 +15,11 @@ namespace Service::APM { | |||
| 15 | 15 | ||
| 16 | constexpr auto DEFAULT_PERFORMANCE_CONFIGURATION = PerformanceConfiguration::Config7; | 16 | constexpr auto DEFAULT_PERFORMANCE_CONFIGURATION = PerformanceConfiguration::Config7; |
| 17 | 17 | ||
| 18 | Controller::Controller(Core::Timing::CoreTiming& core_timing) | 18 | Controller::Controller(Core::Timing::CoreTiming& core_timing_) |
| 19 | : core_timing{core_timing}, configs{ | 19 | : core_timing{core_timing_}, configs{ |
| 20 | {PerformanceMode::Handheld, DEFAULT_PERFORMANCE_CONFIGURATION}, | 20 | {PerformanceMode::Handheld, DEFAULT_PERFORMANCE_CONFIGURATION}, |
| 21 | {PerformanceMode::Docked, DEFAULT_PERFORMANCE_CONFIGURATION}, | 21 | {PerformanceMode::Docked, DEFAULT_PERFORMANCE_CONFIGURATION}, |
| 22 | } {} | 22 | } {} |
| 23 | 23 | ||
| 24 | Controller::~Controller() = default; | 24 | Controller::~Controller() = default; |
| 25 | 25 | ||
diff --git a/src/core/hle/service/apm/controller.h b/src/core/hle/service/apm/controller.h index af0c4cd34..8d48e0104 100644 --- a/src/core/hle/service/apm/controller.h +++ b/src/core/hle/service/apm/controller.h | |||
| @@ -50,7 +50,7 @@ enum class PerformanceMode : u8 { | |||
| 50 | // system during times of high load -- this simply maps to different PerformanceConfigs to use. | 50 | // system during times of high load -- this simply maps to different PerformanceConfigs to use. |
| 51 | class Controller { | 51 | class Controller { |
| 52 | public: | 52 | public: |
| 53 | explicit Controller(Core::Timing::CoreTiming& core_timing); | 53 | explicit Controller(Core::Timing::CoreTiming& core_timing_); |
| 54 | ~Controller(); | 54 | ~Controller(); |
| 55 | 55 | ||
| 56 | void SetPerformanceConfiguration(PerformanceMode mode, PerformanceConfiguration config); | 56 | void SetPerformanceConfiguration(PerformanceMode mode, PerformanceConfiguration config); |
diff --git a/src/core/hle/service/audio/audren_u.cpp b/src/core/hle/service/audio/audren_u.cpp index 513bd3730..ae4284adf 100644 --- a/src/core/hle/service/audio/audren_u.cpp +++ b/src/core/hle/service/audio/audren_u.cpp | |||
| @@ -169,10 +169,9 @@ private: | |||
| 169 | 169 | ||
| 170 | class IAudioDevice final : public ServiceFramework<IAudioDevice> { | 170 | class IAudioDevice final : public ServiceFramework<IAudioDevice> { |
| 171 | public: | 171 | public: |
| 172 | explicit IAudioDevice(Core::System& system_, u32_le revision_num) | 172 | explicit IAudioDevice(Core::System& system_, Kernel::KEvent& buffer_event_, u32_le revision_) |
| 173 | : ServiceFramework{system_, "IAudioDevice"}, revision{revision_num}, | 173 | : ServiceFramework{system_, "IAudioDevice"}, buffer_event{buffer_event_}, revision{ |
| 174 | buffer_event{system.Kernel()}, audio_input_device_switch_event{system.Kernel()}, | 174 | revision_} { |
| 175 | audio_output_device_switch_event{system.Kernel()} { | ||
| 176 | static const FunctionInfo functions[] = { | 175 | static const FunctionInfo functions[] = { |
| 177 | {0, &IAudioDevice::ListAudioDeviceName, "ListAudioDeviceName"}, | 176 | {0, &IAudioDevice::ListAudioDeviceName, "ListAudioDeviceName"}, |
| 178 | {1, &IAudioDevice::SetAudioDeviceOutputVolume, "SetAudioDeviceOutputVolume"}, | 177 | {1, &IAudioDevice::SetAudioDeviceOutputVolume, "SetAudioDeviceOutputVolume"}, |
| @@ -189,18 +188,6 @@ public: | |||
| 189 | {13, nullptr, "GetAudioSystemMasterVolumeSetting"}, | 188 | {13, nullptr, "GetAudioSystemMasterVolumeSetting"}, |
| 190 | }; | 189 | }; |
| 191 | RegisterHandlers(functions); | 190 | RegisterHandlers(functions); |
| 192 | |||
| 193 | Kernel::KAutoObject::Create(std::addressof(buffer_event)); | ||
| 194 | buffer_event.Initialize("IAudioOutBufferReleasedEvent"); | ||
| 195 | |||
| 196 | // Should be similar to audio_output_device_switch_event | ||
| 197 | Kernel::KAutoObject::Create(std::addressof(audio_input_device_switch_event)); | ||
| 198 | audio_input_device_switch_event.Initialize("IAudioDevice:AudioInputDeviceSwitchedEvent"); | ||
| 199 | |||
| 200 | // Should only be signalled when an audio output device has been changed, example: speaker | ||
| 201 | // to headset | ||
| 202 | Kernel::KAutoObject::Create(std::addressof(audio_output_device_switch_event)); | ||
| 203 | audio_output_device_switch_event.Initialize("IAudioDevice:AudioOutputDeviceSwitchedEvent"); | ||
| 204 | } | 191 | } |
| 205 | 192 | ||
| 206 | private: | 193 | private: |
| @@ -310,7 +297,7 @@ private: | |||
| 310 | 297 | ||
| 311 | IPC::ResponseBuilder rb{ctx, 2, 1}; | 298 | IPC::ResponseBuilder rb{ctx, 2, 1}; |
| 312 | rb.Push(RESULT_SUCCESS); | 299 | rb.Push(RESULT_SUCCESS); |
| 313 | rb.PushCopyObjects(audio_input_device_switch_event.GetReadableEvent()); | 300 | rb.PushCopyObjects(buffer_event.GetReadableEvent()); |
| 314 | } | 301 | } |
| 315 | 302 | ||
| 316 | void QueryAudioDeviceOutputEvent(Kernel::HLERequestContext& ctx) { | 303 | void QueryAudioDeviceOutputEvent(Kernel::HLERequestContext& ctx) { |
| @@ -318,17 +305,16 @@ private: | |||
| 318 | 305 | ||
| 319 | IPC::ResponseBuilder rb{ctx, 2, 1}; | 306 | IPC::ResponseBuilder rb{ctx, 2, 1}; |
| 320 | rb.Push(RESULT_SUCCESS); | 307 | rb.Push(RESULT_SUCCESS); |
| 321 | rb.PushCopyObjects(audio_output_device_switch_event.GetReadableEvent()); | 308 | rb.PushCopyObjects(buffer_event.GetReadableEvent()); |
| 322 | } | 309 | } |
| 323 | 310 | ||
| 311 | Kernel::KEvent& buffer_event; | ||
| 324 | u32_le revision = 0; | 312 | u32_le revision = 0; |
| 325 | Kernel::KEvent buffer_event; | 313 | }; |
| 326 | Kernel::KEvent audio_input_device_switch_event; | ||
| 327 | Kernel::KEvent audio_output_device_switch_event; | ||
| 328 | 314 | ||
| 329 | }; // namespace Audio | 315 | AudRenU::AudRenU(Core::System& system_) |
| 316 | : ServiceFramework{system_, "audren:u"}, buffer_event{system.Kernel()} { | ||
| 330 | 317 | ||
| 331 | AudRenU::AudRenU(Core::System& system_) : ServiceFramework{system_, "audren:u"} { | ||
| 332 | // clang-format off | 318 | // clang-format off |
| 333 | static const FunctionInfo functions[] = { | 319 | static const FunctionInfo functions[] = { |
| 334 | {0, &AudRenU::OpenAudioRenderer, "OpenAudioRenderer"}, | 320 | {0, &AudRenU::OpenAudioRenderer, "OpenAudioRenderer"}, |
| @@ -340,6 +326,9 @@ AudRenU::AudRenU(Core::System& system_) : ServiceFramework{system_, "audren:u"} | |||
| 340 | // clang-format on | 326 | // clang-format on |
| 341 | 327 | ||
| 342 | RegisterHandlers(functions); | 328 | RegisterHandlers(functions); |
| 329 | |||
| 330 | Kernel::KAutoObject::Create(std::addressof(buffer_event)); | ||
| 331 | buffer_event.Initialize("IAudioOutBufferReleasedEvent"); | ||
| 343 | } | 332 | } |
| 344 | 333 | ||
| 345 | AudRenU::~AudRenU() = default; | 334 | AudRenU::~AudRenU() = default; |
| @@ -373,7 +362,7 @@ void AudRenU::GetAudioRendererWorkBufferSize(Kernel::HLERequestContext& ctx) { | |||
| 373 | static constexpr u64 max_perf_detail_entries = 100; | 362 | static constexpr u64 max_perf_detail_entries = 100; |
| 374 | 363 | ||
| 375 | // Size of the data structure representing the bulk of the voice-related state. | 364 | // Size of the data structure representing the bulk of the voice-related state. |
| 376 | static constexpr u64 voice_state_size = 0x100; | 365 | static constexpr u64 voice_state_size_bytes = 0x100; |
| 377 | 366 | ||
| 378 | // Size of the upsampler manager data structure | 367 | // Size of the upsampler manager data structure |
| 379 | constexpr u64 upsampler_manager_size = 0x48; | 368 | constexpr u64 upsampler_manager_size = 0x48; |
| @@ -460,7 +449,8 @@ void AudRenU::GetAudioRendererWorkBufferSize(Kernel::HLERequestContext& ctx) { | |||
| 460 | size += Common::AlignUp(voice_info_size * params.voice_count, info_field_alignment_size); | 449 | size += Common::AlignUp(voice_info_size * params.voice_count, info_field_alignment_size); |
| 461 | size += | 450 | size += |
| 462 | Common::AlignUp(voice_resource_size * params.voice_count, info_field_alignment_size); | 451 | Common::AlignUp(voice_resource_size * params.voice_count, info_field_alignment_size); |
| 463 | size += Common::AlignUp(voice_state_size * params.voice_count, info_field_alignment_size); | 452 | size += |
| 453 | Common::AlignUp(voice_state_size_bytes * params.voice_count, info_field_alignment_size); | ||
| 464 | return size; | 454 | return size; |
| 465 | }; | 455 | }; |
| 466 | 456 | ||
| @@ -662,7 +652,7 @@ void AudRenU::GetAudioDeviceService(Kernel::HLERequestContext& ctx) { | |||
| 662 | // always assumes the initial release revision (REV1). | 652 | // always assumes the initial release revision (REV1). |
| 663 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | 653 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; |
| 664 | rb.Push(RESULT_SUCCESS); | 654 | rb.Push(RESULT_SUCCESS); |
| 665 | rb.PushIpcInterface<IAudioDevice>(system, Common::MakeMagic('R', 'E', 'V', '1')); | 655 | rb.PushIpcInterface<IAudioDevice>(system, buffer_event, Common::MakeMagic('R', 'E', 'V', '1')); |
| 666 | } | 656 | } |
| 667 | 657 | ||
| 668 | void AudRenU::OpenAudioRendererForManualExecution(Kernel::HLERequestContext& ctx) { | 658 | void AudRenU::OpenAudioRendererForManualExecution(Kernel::HLERequestContext& ctx) { |
| @@ -684,7 +674,7 @@ void AudRenU::GetAudioDeviceServiceWithRevisionInfo(Kernel::HLERequestContext& c | |||
| 684 | 674 | ||
| 685 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; | 675 | IPC::ResponseBuilder rb{ctx, 2, 0, 1}; |
| 686 | rb.Push(RESULT_SUCCESS); | 676 | rb.Push(RESULT_SUCCESS); |
| 687 | rb.PushIpcInterface<IAudioDevice>(system, revision); | 677 | rb.PushIpcInterface<IAudioDevice>(system, buffer_event, revision); |
| 688 | } | 678 | } |
| 689 | 679 | ||
| 690 | void AudRenU::OpenAudioRendererImpl(Kernel::HLERequestContext& ctx) { | 680 | void AudRenU::OpenAudioRendererImpl(Kernel::HLERequestContext& ctx) { |
diff --git a/src/core/hle/service/audio/audren_u.h b/src/core/hle/service/audio/audren_u.h index 37e8b4716..0ee6f9542 100644 --- a/src/core/hle/service/audio/audren_u.h +++ b/src/core/hle/service/audio/audren_u.h | |||
| @@ -4,6 +4,7 @@ | |||
| 4 | 4 | ||
| 5 | #pragma once | 5 | #pragma once |
| 6 | 6 | ||
| 7 | #include "core/hle/kernel/k_event.h" | ||
| 7 | #include "core/hle/service/service.h" | 8 | #include "core/hle/service/service.h" |
| 8 | 9 | ||
| 9 | namespace Core { | 10 | namespace Core { |
| @@ -31,6 +32,7 @@ private: | |||
| 31 | void OpenAudioRendererImpl(Kernel::HLERequestContext& ctx); | 32 | void OpenAudioRendererImpl(Kernel::HLERequestContext& ctx); |
| 32 | 33 | ||
| 33 | std::size_t audren_instance_count = 0; | 34 | std::size_t audren_instance_count = 0; |
| 35 | Kernel::KEvent buffer_event; | ||
| 34 | }; | 36 | }; |
| 35 | 37 | ||
| 36 | // Describes a particular audio feature that may be supported in a particular revision. | 38 | // Describes a particular audio feature that may be supported in a particular revision. |
diff --git a/src/core/hle/service/audio/hwopus.cpp b/src/core/hle/service/audio/hwopus.cpp index 19c578b3a..ee5ec8cd6 100644 --- a/src/core/hle/service/audio/hwopus.cpp +++ b/src/core/hle/service/audio/hwopus.cpp | |||
| @@ -50,8 +50,8 @@ public: | |||
| 50 | Enabled, | 50 | Enabled, |
| 51 | }; | 51 | }; |
| 52 | 52 | ||
| 53 | explicit OpusDecoderState(OpusDecoderPtr decoder, u32 sample_rate, u32 channel_count) | 53 | explicit OpusDecoderState(OpusDecoderPtr decoder_, u32 sample_rate_, u32 channel_count_) |
| 54 | : decoder{std::move(decoder)}, sample_rate{sample_rate}, channel_count{channel_count} {} | 54 | : decoder{std::move(decoder_)}, sample_rate{sample_rate_}, channel_count{channel_count_} {} |
| 55 | 55 | ||
| 56 | // Decodes interleaved Opus packets. Optionally allows reporting time taken to | 56 | // Decodes interleaved Opus packets. Optionally allows reporting time taken to |
| 57 | // perform the decoding, as well as any relevant extra behavior. | 57 | // perform the decoding, as well as any relevant extra behavior. |
| @@ -160,9 +160,9 @@ private: | |||
| 160 | 160 | ||
| 161 | class IHardwareOpusDecoderManager final : public ServiceFramework<IHardwareOpusDecoderManager> { | 161 | class IHardwareOpusDecoderManager final : public ServiceFramework<IHardwareOpusDecoderManager> { |
| 162 | public: | 162 | public: |
| 163 | explicit IHardwareOpusDecoderManager(Core::System& system_, OpusDecoderState decoder_state) | 163 | explicit IHardwareOpusDecoderManager(Core::System& system_, OpusDecoderState decoder_state_) |
| 164 | : ServiceFramework{system_, "IHardwareOpusDecoderManager"}, decoder_state{ | 164 | : ServiceFramework{system_, "IHardwareOpusDecoderManager"}, decoder_state{ |
| 165 | std::move(decoder_state)} { | 165 | std::move(decoder_state_)} { |
| 166 | // clang-format off | 166 | // clang-format off |
| 167 | static const FunctionInfo functions[] = { | 167 | static const FunctionInfo functions[] = { |
| 168 | {0, &IHardwareOpusDecoderManager::DecodeInterleavedOld, "DecodeInterleavedOld"}, | 168 | {0, &IHardwareOpusDecoderManager::DecodeInterleavedOld, "DecodeInterleavedOld"}, |
diff --git a/src/core/hle/service/bcat/backend/boxcat.cpp b/src/core/hle/service/bcat/backend/boxcat.cpp index cee1774d1..d6d2f52e5 100644 --- a/src/core/hle/service/bcat/backend/boxcat.cpp +++ b/src/core/hle/service/bcat/backend/boxcat.cpp | |||
| @@ -3,9 +3,18 @@ | |||
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include <fmt/ostream.h> | 5 | #include <fmt/ostream.h> |
| 6 | |||
| 7 | #ifdef __GNUC__ | ||
| 8 | #pragma GCC diagnostic push | ||
| 9 | #pragma GCC diagnostic ignored "-Wshadow" | ||
| 10 | #endif | ||
| 6 | #include <httplib.h> | 11 | #include <httplib.h> |
| 7 | #include <mbedtls/sha256.h> | 12 | #include <mbedtls/sha256.h> |
| 8 | #include <nlohmann/json.hpp> | 13 | #include <nlohmann/json.hpp> |
| 14 | #ifdef __GNUC__ | ||
| 15 | #pragma GCC diagnostic pop | ||
| 16 | #endif | ||
| 17 | |||
| 9 | #include "common/hex_util.h" | 18 | #include "common/hex_util.h" |
| 10 | #include "common/logging/backend.h" | 19 | #include "common/logging/backend.h" |
| 11 | #include "common/logging/log.h" | 20 | #include "common/logging/log.h" |
| @@ -178,8 +187,8 @@ bool VfsRawCopyDProgress(FileSys::VirtualDir src, FileSys::VirtualDir dest, | |||
| 178 | 187 | ||
| 179 | class Boxcat::Client { | 188 | class Boxcat::Client { |
| 180 | public: | 189 | public: |
| 181 | Client(std::string path, u64 title_id, u64 build_id) | 190 | Client(std::string path_, u64 title_id_, u64 build_id_) |
| 182 | : path(std::move(path)), title_id(title_id), build_id(build_id) {} | 191 | : path(std::move(path_)), title_id(title_id_), build_id(build_id_) {} |
| 183 | 192 | ||
| 184 | DownloadResult DownloadDataZip() { | 193 | DownloadResult DownloadDataZip() { |
| 185 | return DownloadInternal(fmt::format(BOXCAT_PATHNAME_DATA, title_id), TIMEOUT_SECONDS, | 194 | return DownloadInternal(fmt::format(BOXCAT_PATHNAME_DATA, title_id), TIMEOUT_SECONDS, |
diff --git a/src/core/hle/service/hid/controllers/controller_base.cpp b/src/core/hle/service/hid/controllers/controller_base.cpp index 8091db9d7..9d1e6db6a 100644 --- a/src/core/hle/service/hid/controllers/controller_base.cpp +++ b/src/core/hle/service/hid/controllers/controller_base.cpp | |||
| @@ -6,7 +6,7 @@ | |||
| 6 | 6 | ||
| 7 | namespace Service::HID { | 7 | namespace Service::HID { |
| 8 | 8 | ||
| 9 | ControllerBase::ControllerBase(Core::System& system) : system(system) {} | 9 | ControllerBase::ControllerBase(Core::System& system_) : system(system_) {} |
| 10 | ControllerBase::~ControllerBase() = default; | 10 | ControllerBase::~ControllerBase() = default; |
| 11 | 11 | ||
| 12 | void ControllerBase::ActivateController() { | 12 | void ControllerBase::ActivateController() { |
diff --git a/src/core/hle/service/hid/controllers/controller_base.h b/src/core/hle/service/hid/controllers/controller_base.h index f47a9e61c..1556fb08e 100644 --- a/src/core/hle/service/hid/controllers/controller_base.h +++ b/src/core/hle/service/hid/controllers/controller_base.h | |||
| @@ -18,7 +18,7 @@ class System; | |||
| 18 | namespace Service::HID { | 18 | namespace Service::HID { |
| 19 | class ControllerBase { | 19 | class ControllerBase { |
| 20 | public: | 20 | public: |
| 21 | explicit ControllerBase(Core::System& system); | 21 | explicit ControllerBase(Core::System& system_); |
| 22 | virtual ~ControllerBase(); | 22 | virtual ~ControllerBase(); |
| 23 | 23 | ||
| 24 | // Called when the controller is initialized | 24 | // Called when the controller is initialized |
diff --git a/src/core/hle/service/hid/controllers/gesture.cpp b/src/core/hle/service/hid/controllers/gesture.cpp index 9e5df3bb7..d311f754b 100644 --- a/src/core/hle/service/hid/controllers/gesture.cpp +++ b/src/core/hle/service/hid/controllers/gesture.cpp | |||
| @@ -23,7 +23,7 @@ constexpr f32 Square(s32 num) { | |||
| 23 | return static_cast<f32>(num * num); | 23 | return static_cast<f32>(num * num); |
| 24 | } | 24 | } |
| 25 | 25 | ||
| 26 | Controller_Gesture::Controller_Gesture(Core::System& system) : ControllerBase(system) {} | 26 | Controller_Gesture::Controller_Gesture(Core::System& system_) : ControllerBase(system_) {} |
| 27 | Controller_Gesture::~Controller_Gesture() = default; | 27 | Controller_Gesture::~Controller_Gesture() = default; |
| 28 | 28 | ||
| 29 | void Controller_Gesture::OnInit() { | 29 | void Controller_Gesture::OnInit() { |
| @@ -211,15 +211,16 @@ void Controller_Gesture::UpdateExistingGesture(GestureProperties& gesture, Touch | |||
| 211 | } | 211 | } |
| 212 | } | 212 | } |
| 213 | 213 | ||
| 214 | void Controller_Gesture::EndGesture(GestureProperties& gesture, GestureProperties& last_gesture, | 214 | void Controller_Gesture::EndGesture(GestureProperties& gesture, |
| 215 | TouchType& type, Attribute& attributes, f32 time_difference) { | 215 | GestureProperties& last_gesture_props, TouchType& type, |
| 216 | Attribute& attributes, f32 time_difference) { | ||
| 216 | const auto& last_entry = | 217 | const auto& last_entry = |
| 217 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; | 218 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; |
| 218 | if (last_gesture.active_points != 0) { | 219 | if (last_gesture_props.active_points != 0) { |
| 219 | switch (last_entry.type) { | 220 | switch (last_entry.type) { |
| 220 | case TouchType::Touch: | 221 | case TouchType::Touch: |
| 221 | if (enable_press_and_tap) { | 222 | if (enable_press_and_tap) { |
| 222 | SetTapEvent(gesture, last_gesture, type, attributes); | 223 | SetTapEvent(gesture, last_gesture_props, type, attributes); |
| 223 | return; | 224 | return; |
| 224 | } | 225 | } |
| 225 | type = TouchType::Cancel; | 226 | type = TouchType::Cancel; |
| @@ -234,7 +235,7 @@ void Controller_Gesture::EndGesture(GestureProperties& gesture, GesturePropertie | |||
| 234 | force_update = true; | 235 | force_update = true; |
| 235 | break; | 236 | break; |
| 236 | case TouchType::Pan: | 237 | case TouchType::Pan: |
| 237 | EndPanEvent(gesture, last_gesture, type, time_difference); | 238 | EndPanEvent(gesture, last_gesture_props, type, time_difference); |
| 238 | break; | 239 | break; |
| 239 | default: | 240 | default: |
| 240 | break; | 241 | break; |
| @@ -246,10 +247,11 @@ void Controller_Gesture::EndGesture(GestureProperties& gesture, GesturePropertie | |||
| 246 | } | 247 | } |
| 247 | } | 248 | } |
| 248 | 249 | ||
| 249 | void Controller_Gesture::SetTapEvent(GestureProperties& gesture, GestureProperties& last_gesture, | 250 | void Controller_Gesture::SetTapEvent(GestureProperties& gesture, |
| 250 | TouchType& type, Attribute& attributes) { | 251 | GestureProperties& last_gesture_props, TouchType& type, |
| 252 | Attribute& attributes) { | ||
| 251 | type = TouchType::Tap; | 253 | type = TouchType::Tap; |
| 252 | gesture = last_gesture; | 254 | gesture = last_gesture_props; |
| 253 | force_update = true; | 255 | force_update = true; |
| 254 | f32 tap_time_difference = | 256 | f32 tap_time_difference = |
| 255 | static_cast<f32>(last_update_timestamp - last_tap_timestamp) / (1000 * 1000 * 1000); | 257 | static_cast<f32>(last_update_timestamp - last_tap_timestamp) / (1000 * 1000 * 1000); |
| @@ -259,8 +261,9 @@ void Controller_Gesture::SetTapEvent(GestureProperties& gesture, GestureProperti | |||
| 259 | } | 261 | } |
| 260 | } | 262 | } |
| 261 | 263 | ||
| 262 | void Controller_Gesture::UpdatePanEvent(GestureProperties& gesture, GestureProperties& last_gesture, | 264 | void Controller_Gesture::UpdatePanEvent(GestureProperties& gesture, |
| 263 | TouchType& type, f32 time_difference) { | 265 | GestureProperties& last_gesture_props, TouchType& type, |
| 266 | f32 time_difference) { | ||
| 264 | auto& cur_entry = shared_memory.gesture_states[shared_memory.header.last_entry_index]; | 267 | auto& cur_entry = shared_memory.gesture_states[shared_memory.header.last_entry_index]; |
| 265 | const auto& last_entry = | 268 | const auto& last_entry = |
| 266 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; | 269 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; |
| @@ -272,13 +275,14 @@ void Controller_Gesture::UpdatePanEvent(GestureProperties& gesture, GesturePrope | |||
| 272 | last_pan_time_difference = time_difference; | 275 | last_pan_time_difference = time_difference; |
| 273 | 276 | ||
| 274 | // Promote to pinch type | 277 | // Promote to pinch type |
| 275 | if (std::abs(gesture.average_distance - last_gesture.average_distance) > pinch_threshold) { | 278 | if (std::abs(gesture.average_distance - last_gesture_props.average_distance) > |
| 279 | pinch_threshold) { | ||
| 276 | type = TouchType::Pinch; | 280 | type = TouchType::Pinch; |
| 277 | cur_entry.scale = gesture.average_distance / last_gesture.average_distance; | 281 | cur_entry.scale = gesture.average_distance / last_gesture_props.average_distance; |
| 278 | } | 282 | } |
| 279 | 283 | ||
| 280 | const f32 angle_between_two_lines = std::atan((gesture.angle - last_gesture.angle) / | 284 | const f32 angle_between_two_lines = std::atan((gesture.angle - last_gesture_props.angle) / |
| 281 | (1 + (gesture.angle * last_gesture.angle))); | 285 | (1 + (gesture.angle * last_gesture_props.angle))); |
| 282 | // Promote to rotate type | 286 | // Promote to rotate type |
| 283 | if (std::abs(angle_between_two_lines) > angle_threshold) { | 287 | if (std::abs(angle_between_two_lines) > angle_threshold) { |
| 284 | type = TouchType::Rotate; | 288 | type = TouchType::Rotate; |
| @@ -287,8 +291,9 @@ void Controller_Gesture::UpdatePanEvent(GestureProperties& gesture, GesturePrope | |||
| 287 | } | 291 | } |
| 288 | } | 292 | } |
| 289 | 293 | ||
| 290 | void Controller_Gesture::EndPanEvent(GestureProperties& gesture, GestureProperties& last_gesture, | 294 | void Controller_Gesture::EndPanEvent(GestureProperties& gesture, |
| 291 | TouchType& type, f32 time_difference) { | 295 | GestureProperties& last_gesture_props, TouchType& type, |
| 296 | f32 time_difference) { | ||
| 292 | auto& cur_entry = shared_memory.gesture_states[shared_memory.header.last_entry_index]; | 297 | auto& cur_entry = shared_memory.gesture_states[shared_memory.header.last_entry_index]; |
| 293 | const auto& last_entry = | 298 | const auto& last_entry = |
| 294 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; | 299 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; |
| @@ -301,7 +306,7 @@ void Controller_Gesture::EndPanEvent(GestureProperties& gesture, GestureProperti | |||
| 301 | 306 | ||
| 302 | // Set swipe event with parameters | 307 | // Set swipe event with parameters |
| 303 | if (curr_vel > swipe_threshold) { | 308 | if (curr_vel > swipe_threshold) { |
| 304 | SetSwipeEvent(gesture, last_gesture, type); | 309 | SetSwipeEvent(gesture, last_gesture_props, type); |
| 305 | return; | 310 | return; |
| 306 | } | 311 | } |
| 307 | 312 | ||
| @@ -312,13 +317,13 @@ void Controller_Gesture::EndPanEvent(GestureProperties& gesture, GestureProperti | |||
| 312 | force_update = true; | 317 | force_update = true; |
| 313 | } | 318 | } |
| 314 | 319 | ||
| 315 | void Controller_Gesture::SetSwipeEvent(GestureProperties& gesture, GestureProperties& last_gesture, | 320 | void Controller_Gesture::SetSwipeEvent(GestureProperties& gesture, |
| 316 | TouchType& type) { | 321 | GestureProperties& last_gesture_props, TouchType& type) { |
| 317 | auto& cur_entry = shared_memory.gesture_states[shared_memory.header.last_entry_index]; | 322 | auto& cur_entry = shared_memory.gesture_states[shared_memory.header.last_entry_index]; |
| 318 | const auto& last_entry = | 323 | const auto& last_entry = |
| 319 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; | 324 | shared_memory.gesture_states[(shared_memory.header.last_entry_index + 16) % 17]; |
| 320 | type = TouchType::Swipe; | 325 | type = TouchType::Swipe; |
| 321 | gesture = last_gesture; | 326 | gesture = last_gesture_props; |
| 322 | force_update = true; | 327 | force_update = true; |
| 323 | cur_entry.delta_x = last_entry.delta_x; | 328 | cur_entry.delta_x = last_entry.delta_x; |
| 324 | cur_entry.delta_y = last_entry.delta_y; | 329 | cur_entry.delta_y = last_entry.delta_y; |
diff --git a/src/core/hle/service/hid/controllers/gesture.h b/src/core/hle/service/hid/controllers/gesture.h index 18110a6ad..f46e29411 100644 --- a/src/core/hle/service/hid/controllers/gesture.h +++ b/src/core/hle/service/hid/controllers/gesture.h | |||
| @@ -128,32 +128,34 @@ private: | |||
| 128 | void UpdateExistingGesture(GestureProperties& gesture, TouchType& type, f32 time_difference); | 128 | void UpdateExistingGesture(GestureProperties& gesture, TouchType& type, f32 time_difference); |
| 129 | 129 | ||
| 130 | // Terminates exiting gesture | 130 | // Terminates exiting gesture |
| 131 | void EndGesture(GestureProperties& gesture, GestureProperties& last_gesture, TouchType& type, | 131 | void EndGesture(GestureProperties& gesture, GestureProperties& last_gesture_props, |
| 132 | Attribute& attributes, f32 time_difference); | 132 | TouchType& type, Attribute& attributes, f32 time_difference); |
| 133 | 133 | ||
| 134 | // Set current event to a tap event | 134 | // Set current event to a tap event |
| 135 | void SetTapEvent(GestureProperties& gesture, GestureProperties& last_gesture, TouchType& type, | 135 | void SetTapEvent(GestureProperties& gesture, GestureProperties& last_gesture_props, |
| 136 | Attribute& attributes); | 136 | TouchType& type, Attribute& attributes); |
| 137 | 137 | ||
| 138 | // Calculates and set the extra parameters related to a pan event | 138 | // Calculates and set the extra parameters related to a pan event |
| 139 | void UpdatePanEvent(GestureProperties& gesture, GestureProperties& last_gesture, | 139 | void UpdatePanEvent(GestureProperties& gesture, GestureProperties& last_gesture_props, |
| 140 | TouchType& type, f32 time_difference); | 140 | TouchType& type, f32 time_difference); |
| 141 | 141 | ||
| 142 | // Terminates the pan event | 142 | // Terminates the pan event |
| 143 | void EndPanEvent(GestureProperties& gesture, GestureProperties& last_gesture, TouchType& type, | 143 | void EndPanEvent(GestureProperties& gesture, GestureProperties& last_gesture_props, |
| 144 | f32 time_difference); | 144 | TouchType& type, f32 time_difference); |
| 145 | 145 | ||
| 146 | // Set current event to a swipe event | 146 | // Set current event to a swipe event |
| 147 | void SetSwipeEvent(GestureProperties& gesture, GestureProperties& last_gesture, | 147 | void SetSwipeEvent(GestureProperties& gesture, GestureProperties& last_gesture_props, |
| 148 | TouchType& type); | 148 | TouchType& type); |
| 149 | 149 | ||
| 150 | // Returns an unused finger id, if there is no fingers avaliable MAX_FINGERS will be returned | 150 | // Returns an unused finger id, if there is no fingers available std::nullopt is returned. |
| 151 | std::optional<size_t> GetUnusedFingerID() const; | 151 | std::optional<size_t> GetUnusedFingerID() const; |
| 152 | 152 | ||
| 153 | /** If the touch is new it tries to assing a new finger id, if there is no fingers avaliable no | 153 | /** |
| 154 | * If the touch is new it tries to assign a new finger id, if there is no fingers available no | ||
| 154 | * changes will be made. Updates the coordinates if the finger id it's already set. If the touch | 155 | * changes will be made. Updates the coordinates if the finger id it's already set. If the touch |
| 155 | * ends delays the output by one frame to set the end_touch flag before finally freeing the | 156 | * ends delays the output by one frame to set the end_touch flag before finally freeing the |
| 156 | * finger id */ | 157 | * finger id |
| 158 | */ | ||
| 157 | size_t UpdateTouchInputEvent(const std::tuple<float, float, bool>& touch_input, | 159 | size_t UpdateTouchInputEvent(const std::tuple<float, float, bool>& touch_input, |
| 158 | size_t finger_id); | 160 | size_t finger_id); |
| 159 | 161 | ||
diff --git a/src/core/hle/service/mii/manager.h b/src/core/hle/service/mii/manager.h index 2106a528a..ec7efa5f7 100644 --- a/src/core/hle/service/mii/manager.h +++ b/src/core/hle/service/mii/manager.h | |||
| @@ -89,7 +89,7 @@ static_assert(std::has_unique_object_representations_v<MiiInfo>, | |||
| 89 | #pragma pack(push, 4) | 89 | #pragma pack(push, 4) |
| 90 | 90 | ||
| 91 | struct MiiInfoElement { | 91 | struct MiiInfoElement { |
| 92 | MiiInfoElement(const MiiInfo& info, Source source) : info{info}, source{source} {} | 92 | MiiInfoElement(const MiiInfo& info_, Source source_) : info{info_}, source{source_} {} |
| 93 | 93 | ||
| 94 | MiiInfo info{}; | 94 | MiiInfo info{}; |
| 95 | Source source{}; | 95 | Source source{}; |
diff --git a/src/core/hle/service/mii/mii.cpp b/src/core/hle/service/mii/mii.cpp index 26be9e45b..81f150a88 100644 --- a/src/core/hle/service/mii/mii.cpp +++ b/src/core/hle/service/mii/mii.cpp | |||
| @@ -253,8 +253,8 @@ private: | |||
| 253 | 253 | ||
| 254 | class MiiDBModule final : public ServiceFramework<MiiDBModule> { | 254 | class MiiDBModule final : public ServiceFramework<MiiDBModule> { |
| 255 | public: | 255 | public: |
| 256 | explicit MiiDBModule(Core::System& system_, const char* name) | 256 | explicit MiiDBModule(Core::System& system_, const char* name_) |
| 257 | : ServiceFramework{system_, name} { | 257 | : ServiceFramework{system_, name_} { |
| 258 | // clang-format off | 258 | // clang-format off |
| 259 | static const FunctionInfo functions[] = { | 259 | static const FunctionInfo functions[] = { |
| 260 | {0, &MiiDBModule::GetDatabaseService, "GetDatabaseService"}, | 260 | {0, &MiiDBModule::GetDatabaseService, "GetDatabaseService"}, |
diff --git a/src/core/hle/service/nifm/nifm.cpp b/src/core/hle/service/nifm/nifm.cpp index 94ef3983a..76e3832df 100644 --- a/src/core/hle/service/nifm/nifm.cpp +++ b/src/core/hle/service/nifm/nifm.cpp | |||
| @@ -368,7 +368,7 @@ private: | |||
| 368 | }, | 368 | }, |
| 369 | }; | 369 | }; |
| 370 | 370 | ||
| 371 | IPC::ResponseBuilder rb{ctx, 2 + sizeof(IpConfigInfo) / sizeof(u32)}; | 371 | IPC::ResponseBuilder rb{ctx, 2 + (sizeof(IpConfigInfo) + 3) / sizeof(u32)}; |
| 372 | rb.Push(RESULT_SUCCESS); | 372 | rb.Push(RESULT_SUCCESS); |
| 373 | rb.PushRaw<IpConfigInfo>(ip_config_info); | 373 | rb.PushRaw<IpConfigInfo>(ip_config_info); |
| 374 | } | 374 | } |
diff --git a/src/core/hle/service/nvdrv/devices/nvdevice.h b/src/core/hle/service/nvdrv/devices/nvdevice.h index b37f023df..5b73a5a34 100644 --- a/src/core/hle/service/nvdrv/devices/nvdevice.h +++ b/src/core/hle/service/nvdrv/devices/nvdevice.h | |||
| @@ -21,7 +21,7 @@ namespace Service::Nvidia::Devices { | |||
| 21 | /// implement the ioctl interface. | 21 | /// implement the ioctl interface. |
| 22 | class nvdevice { | 22 | class nvdevice { |
| 23 | public: | 23 | public: |
| 24 | explicit nvdevice(Core::System& system) : system{system} {} | 24 | explicit nvdevice(Core::System& system_) : system{system_} {} |
| 25 | virtual ~nvdevice() = default; | 25 | virtual ~nvdevice() = default; |
| 26 | 26 | ||
| 27 | /** | 27 | /** |
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.h b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.h index 229bf6350..24e3151cb 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.h +++ b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.h | |||
| @@ -48,13 +48,13 @@ private: | |||
| 48 | public: | 48 | public: |
| 49 | constexpr BufferMap() = default; | 49 | constexpr BufferMap() = default; |
| 50 | 50 | ||
| 51 | constexpr BufferMap(GPUVAddr start_addr, std::size_t size) | 51 | constexpr BufferMap(GPUVAddr start_addr_, std::size_t size_) |
| 52 | : start_addr{start_addr}, end_addr{start_addr + size} {} | 52 | : start_addr{start_addr_}, end_addr{start_addr_ + size_} {} |
| 53 | 53 | ||
| 54 | constexpr BufferMap(GPUVAddr start_addr, std::size_t size, VAddr cpu_addr, | 54 | constexpr BufferMap(GPUVAddr start_addr_, std::size_t size_, VAddr cpu_addr_, |
| 55 | bool is_allocated) | 55 | bool is_allocated_) |
| 56 | : start_addr{start_addr}, end_addr{start_addr + size}, cpu_addr{cpu_addr}, | 56 | : start_addr{start_addr_}, end_addr{start_addr_ + size_}, cpu_addr{cpu_addr_}, |
| 57 | is_allocated{is_allocated} {} | 57 | is_allocated{is_allocated_} {} |
| 58 | 58 | ||
| 59 | constexpr VAddr StartAddr() const { | 59 | constexpr VAddr StartAddr() const { |
| 60 | return start_addr; | 60 | return start_addr; |
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_nvdec_common.h b/src/core/hle/service/nvdrv/devices/nvhost_nvdec_common.h index 14d0d210a..da10f5f41 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_nvdec_common.h +++ b/src/core/hle/service/nvdrv/devices/nvhost_nvdec_common.h | |||
| @@ -27,13 +27,13 @@ protected: | |||
| 27 | public: | 27 | public: |
| 28 | constexpr BufferMap() = default; | 28 | constexpr BufferMap() = default; |
| 29 | 29 | ||
| 30 | constexpr BufferMap(GPUVAddr start_addr, std::size_t size) | 30 | constexpr BufferMap(GPUVAddr start_addr_, std::size_t size_) |
| 31 | : start_addr{start_addr}, end_addr{start_addr + size} {} | 31 | : start_addr{start_addr_}, end_addr{start_addr_ + size_} {} |
| 32 | 32 | ||
| 33 | constexpr BufferMap(GPUVAddr start_addr, std::size_t size, VAddr cpu_addr, | 33 | constexpr BufferMap(GPUVAddr start_addr_, std::size_t size_, VAddr cpu_addr_, |
| 34 | bool is_allocated) | 34 | bool is_allocated_) |
| 35 | : start_addr{start_addr}, end_addr{start_addr + size}, cpu_addr{cpu_addr}, | 35 | : start_addr{start_addr_}, end_addr{start_addr_ + size_}, cpu_addr{cpu_addr_}, |
| 36 | is_allocated{is_allocated} {} | 36 | is_allocated{is_allocated_} {} |
| 37 | 37 | ||
| 38 | constexpr VAddr StartAddr() const { | 38 | constexpr VAddr StartAddr() const { |
| 39 | return start_addr; | 39 | return start_addr; |
diff --git a/src/core/hle/service/nvdrv/syncpoint_manager.cpp b/src/core/hle/service/nvdrv/syncpoint_manager.cpp index 0151a03b7..3b6f55526 100644 --- a/src/core/hle/service/nvdrv/syncpoint_manager.cpp +++ b/src/core/hle/service/nvdrv/syncpoint_manager.cpp | |||
| @@ -8,7 +8,7 @@ | |||
| 8 | 8 | ||
| 9 | namespace Service::Nvidia { | 9 | namespace Service::Nvidia { |
| 10 | 10 | ||
| 11 | SyncpointManager::SyncpointManager(Tegra::GPU& gpu) : gpu{gpu} {} | 11 | SyncpointManager::SyncpointManager(Tegra::GPU& gpu_) : gpu{gpu_} {} |
| 12 | 12 | ||
| 13 | SyncpointManager::~SyncpointManager() = default; | 13 | SyncpointManager::~SyncpointManager() = default; |
| 14 | 14 | ||
diff --git a/src/core/hle/service/nvdrv/syncpoint_manager.h b/src/core/hle/service/nvdrv/syncpoint_manager.h index d395c5d0b..99f286474 100644 --- a/src/core/hle/service/nvdrv/syncpoint_manager.h +++ b/src/core/hle/service/nvdrv/syncpoint_manager.h | |||
| @@ -18,7 +18,7 @@ namespace Service::Nvidia { | |||
| 18 | 18 | ||
| 19 | class SyncpointManager final { | 19 | class SyncpointManager final { |
| 20 | public: | 20 | public: |
| 21 | explicit SyncpointManager(Tegra::GPU& gpu); | 21 | explicit SyncpointManager(Tegra::GPU& gpu_); |
| 22 | ~SyncpointManager(); | 22 | ~SyncpointManager(); |
| 23 | 23 | ||
| 24 | /** | 24 | /** |
diff --git a/src/core/hle/service/nvflinger/buffer_queue.cpp b/src/core/hle/service/nvflinger/buffer_queue.cpp index 0b6e7430b..59ddf6298 100644 --- a/src/core/hle/service/nvflinger/buffer_queue.cpp +++ b/src/core/hle/service/nvflinger/buffer_queue.cpp | |||
| @@ -13,8 +13,8 @@ | |||
| 13 | 13 | ||
| 14 | namespace Service::NVFlinger { | 14 | namespace Service::NVFlinger { |
| 15 | 15 | ||
| 16 | BufferQueue::BufferQueue(Kernel::KernelCore& kernel, u32 id, u64 layer_id) | 16 | BufferQueue::BufferQueue(Kernel::KernelCore& kernel, u32 id_, u64 layer_id_) |
| 17 | : id(id), layer_id(layer_id), buffer_wait_event{kernel} { | 17 | : id(id_), layer_id(layer_id_), buffer_wait_event{kernel} { |
| 18 | Kernel::KAutoObject::Create(std::addressof(buffer_wait_event)); | 18 | Kernel::KAutoObject::Create(std::addressof(buffer_wait_event)); |
| 19 | buffer_wait_event.Initialize("BufferQueue:WaitEvent"); | 19 | buffer_wait_event.Initialize("BufferQueue:WaitEvent"); |
| 20 | } | 20 | } |
diff --git a/src/core/hle/service/nvflinger/buffer_queue.h b/src/core/hle/service/nvflinger/buffer_queue.h index 4ec0b1506..61e337ac5 100644 --- a/src/core/hle/service/nvflinger/buffer_queue.h +++ b/src/core/hle/service/nvflinger/buffer_queue.h | |||
| @@ -54,7 +54,7 @@ public: | |||
| 54 | NativeWindowFormat = 2, | 54 | NativeWindowFormat = 2, |
| 55 | }; | 55 | }; |
| 56 | 56 | ||
| 57 | explicit BufferQueue(Kernel::KernelCore& kernel, u32 id, u64 layer_id); | 57 | explicit BufferQueue(Kernel::KernelCore& kernel, u32 id_, u64 layer_id_); |
| 58 | ~BufferQueue(); | 58 | ~BufferQueue(); |
| 59 | 59 | ||
| 60 | enum class BufferTransformFlags : u32 { | 60 | enum class BufferTransformFlags : u32 { |
diff --git a/src/core/hle/service/nvflinger/nvflinger.cpp b/src/core/hle/service/nvflinger/nvflinger.cpp index 7fb9133c7..d1dbc659b 100644 --- a/src/core/hle/service/nvflinger/nvflinger.cpp +++ b/src/core/hle/service/nvflinger/nvflinger.cpp | |||
| @@ -61,7 +61,7 @@ void NVFlinger::SplitVSync() { | |||
| 61 | } | 61 | } |
| 62 | } | 62 | } |
| 63 | 63 | ||
| 64 | NVFlinger::NVFlinger(Core::System& system) : system(system) { | 64 | NVFlinger::NVFlinger(Core::System& system_) : system(system_) { |
| 65 | displays.emplace_back(0, "Default", system); | 65 | displays.emplace_back(0, "Default", system); |
| 66 | displays.emplace_back(1, "External", system); | 66 | displays.emplace_back(1, "External", system); |
| 67 | displays.emplace_back(2, "Edid", system); | 67 | displays.emplace_back(2, "Edid", system); |
| @@ -139,11 +139,15 @@ std::optional<u64> NVFlinger::CreateLayer(u64 display_id) { | |||
| 139 | } | 139 | } |
| 140 | 140 | ||
| 141 | const u64 layer_id = next_layer_id++; | 141 | const u64 layer_id = next_layer_id++; |
| 142 | CreateLayerAtId(*display, layer_id); | ||
| 143 | return layer_id; | ||
| 144 | } | ||
| 145 | |||
| 146 | void NVFlinger::CreateLayerAtId(VI::Display& display, u64 layer_id) { | ||
| 142 | const u32 buffer_queue_id = next_buffer_queue_id++; | 147 | const u32 buffer_queue_id = next_buffer_queue_id++; |
| 143 | buffer_queues.emplace_back( | 148 | buffer_queues.emplace_back( |
| 144 | std::make_unique<BufferQueue>(system.Kernel(), buffer_queue_id, layer_id)); | 149 | std::make_unique<BufferQueue>(system.Kernel(), buffer_queue_id, layer_id)); |
| 145 | display->CreateLayer(layer_id, *buffer_queues.back()); | 150 | display.CreateLayer(layer_id, *buffer_queues.back()); |
| 146 | return layer_id; | ||
| 147 | } | 151 | } |
| 148 | 152 | ||
| 149 | void NVFlinger::CloseLayer(u64 layer_id) { | 153 | void NVFlinger::CloseLayer(u64 layer_id) { |
| @@ -154,9 +158,9 @@ void NVFlinger::CloseLayer(u64 layer_id) { | |||
| 154 | } | 158 | } |
| 155 | } | 159 | } |
| 156 | 160 | ||
| 157 | std::optional<u32> NVFlinger::FindBufferQueueId(u64 display_id, u64 layer_id) const { | 161 | std::optional<u32> NVFlinger::FindBufferQueueId(u64 display_id, u64 layer_id) { |
| 158 | const auto lock_guard = Lock(); | 162 | const auto lock_guard = Lock(); |
| 159 | const auto* const layer = FindLayer(display_id, layer_id); | 163 | const auto* const layer = FindOrCreateLayer(display_id, layer_id); |
| 160 | 164 | ||
| 161 | if (layer == nullptr) { | 165 | if (layer == nullptr) { |
| 162 | return std::nullopt; | 166 | return std::nullopt; |
| @@ -232,6 +236,24 @@ const VI::Layer* NVFlinger::FindLayer(u64 display_id, u64 layer_id) const { | |||
| 232 | return display->FindLayer(layer_id); | 236 | return display->FindLayer(layer_id); |
| 233 | } | 237 | } |
| 234 | 238 | ||
| 239 | VI::Layer* NVFlinger::FindOrCreateLayer(u64 display_id, u64 layer_id) { | ||
| 240 | auto* const display = FindDisplay(display_id); | ||
| 241 | |||
| 242 | if (display == nullptr) { | ||
| 243 | return nullptr; | ||
| 244 | } | ||
| 245 | |||
| 246 | auto* layer = display->FindLayer(layer_id); | ||
| 247 | |||
| 248 | if (layer == nullptr) { | ||
| 249 | LOG_DEBUG(Service, "Layer at id {} not found. Trying to create it.", layer_id); | ||
| 250 | CreateLayerAtId(*display, layer_id); | ||
| 251 | return display->FindLayer(layer_id); | ||
| 252 | } | ||
| 253 | |||
| 254 | return layer; | ||
| 255 | } | ||
| 256 | |||
| 235 | void NVFlinger::Compose() { | 257 | void NVFlinger::Compose() { |
| 236 | for (auto& display : displays) { | 258 | for (auto& display : displays) { |
| 237 | // Trigger vsync for this display at the end of drawing | 259 | // Trigger vsync for this display at the end of drawing |
diff --git a/src/core/hle/service/nvflinger/nvflinger.h b/src/core/hle/service/nvflinger/nvflinger.h index b0febdaec..d80fd07ef 100644 --- a/src/core/hle/service/nvflinger/nvflinger.h +++ b/src/core/hle/service/nvflinger/nvflinger.h | |||
| @@ -45,7 +45,7 @@ class BufferQueue; | |||
| 45 | 45 | ||
| 46 | class NVFlinger final { | 46 | class NVFlinger final { |
| 47 | public: | 47 | public: |
| 48 | explicit NVFlinger(Core::System& system); | 48 | explicit NVFlinger(Core::System& system_); |
| 49 | ~NVFlinger(); | 49 | ~NVFlinger(); |
| 50 | 50 | ||
| 51 | /// Sets the NVDrv module instance to use to send buffers to the GPU. | 51 | /// Sets the NVDrv module instance to use to send buffers to the GPU. |
| @@ -67,7 +67,7 @@ public: | |||
| 67 | /// Finds the buffer queue ID of the specified layer in the specified display. | 67 | /// Finds the buffer queue ID of the specified layer in the specified display. |
| 68 | /// | 68 | /// |
| 69 | /// If an invalid display ID or layer ID is provided, then an empty optional is returned. | 69 | /// If an invalid display ID or layer ID is provided, then an empty optional is returned. |
| 70 | [[nodiscard]] std::optional<u32> FindBufferQueueId(u64 display_id, u64 layer_id) const; | 70 | [[nodiscard]] std::optional<u32> FindBufferQueueId(u64 display_id, u64 layer_id); |
| 71 | 71 | ||
| 72 | /// Gets the vsync event for the specified display. | 72 | /// Gets the vsync event for the specified display. |
| 73 | /// | 73 | /// |
| @@ -100,6 +100,14 @@ private: | |||
| 100 | /// Finds the layer identified by the specified ID in the desired display. | 100 | /// Finds the layer identified by the specified ID in the desired display. |
| 101 | [[nodiscard]] const VI::Layer* FindLayer(u64 display_id, u64 layer_id) const; | 101 | [[nodiscard]] const VI::Layer* FindLayer(u64 display_id, u64 layer_id) const; |
| 102 | 102 | ||
| 103 | /// Finds the layer identified by the specified ID in the desired display, | ||
| 104 | /// or creates the layer if it is not found. | ||
| 105 | /// To be used when the system expects the specified ID to already exist. | ||
| 106 | [[nodiscard]] VI::Layer* FindOrCreateLayer(u64 display_id, u64 layer_id); | ||
| 107 | |||
| 108 | /// Creates a layer with the specified layer ID in the desired display. | ||
| 109 | void CreateLayerAtId(VI::Display& display, u64 layer_id); | ||
| 110 | |||
| 103 | static void VSyncThread(NVFlinger& nv_flinger); | 111 | static void VSyncThread(NVFlinger& nv_flinger); |
| 104 | 112 | ||
| 105 | void SplitVSync(); | 113 | void SplitVSync(); |
diff --git a/src/core/hle/service/pctl/pctl.cpp b/src/core/hle/service/pctl/pctl.cpp index e4d155c86..908e0a1e3 100644 --- a/src/core/hle/service/pctl/pctl.cpp +++ b/src/core/hle/service/pctl/pctl.cpp | |||
| @@ -7,8 +7,8 @@ | |||
| 7 | namespace Service::PCTL { | 7 | namespace Service::PCTL { |
| 8 | 8 | ||
| 9 | PCTL::PCTL(Core::System& system_, std::shared_ptr<Module> module_, const char* name, | 9 | PCTL::PCTL(Core::System& system_, std::shared_ptr<Module> module_, const char* name, |
| 10 | Capability capability) | 10 | Capability capability_) |
| 11 | : Interface{system_, std::move(module_), name, capability} { | 11 | : Interface{system_, std::move(module_), name, capability_} { |
| 12 | static const FunctionInfo functions[] = { | 12 | static const FunctionInfo functions[] = { |
| 13 | {0, &PCTL::CreateService, "CreateService"}, | 13 | {0, &PCTL::CreateService, "CreateService"}, |
| 14 | {1, &PCTL::CreateServiceWithoutInitialize, "CreateServiceWithoutInitialize"}, | 14 | {1, &PCTL::CreateServiceWithoutInitialize, "CreateServiceWithoutInitialize"}, |
diff --git a/src/core/hle/service/pctl/pctl.h b/src/core/hle/service/pctl/pctl.h index fd0a1e486..ea3b97823 100644 --- a/src/core/hle/service/pctl/pctl.h +++ b/src/core/hle/service/pctl/pctl.h | |||
| @@ -15,7 +15,7 @@ namespace Service::PCTL { | |||
| 15 | class PCTL final : public Module::Interface { | 15 | class PCTL final : public Module::Interface { |
| 16 | public: | 16 | public: |
| 17 | explicit PCTL(Core::System& system_, std::shared_ptr<Module> module_, const char* name, | 17 | explicit PCTL(Core::System& system_, std::shared_ptr<Module> module_, const char* name, |
| 18 | Capability capability); | 18 | Capability capability_); |
| 19 | ~PCTL() override; | 19 | ~PCTL() override; |
| 20 | }; | 20 | }; |
| 21 | 21 | ||
diff --git a/src/core/hle/service/pm/pm.cpp b/src/core/hle/service/pm/pm.cpp index f4715935d..a43185c44 100644 --- a/src/core/hle/service/pm/pm.cpp +++ b/src/core/hle/service/pm/pm.cpp | |||
| @@ -31,8 +31,8 @@ std::optional<Kernel::KProcess*> SearchProcessList( | |||
| 31 | 31 | ||
| 32 | void GetApplicationPidGeneric(Kernel::HLERequestContext& ctx, | 32 | void GetApplicationPidGeneric(Kernel::HLERequestContext& ctx, |
| 33 | const std::vector<Kernel::KProcess*>& process_list) { | 33 | const std::vector<Kernel::KProcess*>& process_list) { |
| 34 | const auto process = SearchProcessList(process_list, [](const auto& process) { | 34 | const auto process = SearchProcessList(process_list, [](const auto& proc) { |
| 35 | return process->GetProcessID() == Kernel::KProcess::ProcessIDMin; | 35 | return proc->GetProcessID() == Kernel::KProcess::ProcessIDMin; |
| 36 | }); | 36 | }); |
| 37 | 37 | ||
| 38 | IPC::ResponseBuilder rb{ctx, 4}; | 38 | IPC::ResponseBuilder rb{ctx, 4}; |
| @@ -100,8 +100,8 @@ private: | |||
| 100 | LOG_DEBUG(Service_PM, "called, title_id={:016X}", title_id); | 100 | LOG_DEBUG(Service_PM, "called, title_id={:016X}", title_id); |
| 101 | 101 | ||
| 102 | const auto process = | 102 | const auto process = |
| 103 | SearchProcessList(kernel.GetProcessList(), [title_id](const auto& process) { | 103 | SearchProcessList(kernel.GetProcessList(), [title_id](const auto& proc) { |
| 104 | return process->GetTitleID() == title_id; | 104 | return proc->GetTitleID() == title_id; |
| 105 | }); | 105 | }); |
| 106 | 106 | ||
| 107 | if (!process.has_value()) { | 107 | if (!process.has_value()) { |
| @@ -140,8 +140,8 @@ private: | |||
| 140 | 140 | ||
| 141 | LOG_DEBUG(Service_PM, "called, process_id={:016X}", process_id); | 141 | LOG_DEBUG(Service_PM, "called, process_id={:016X}", process_id); |
| 142 | 142 | ||
| 143 | const auto process = SearchProcessList(process_list, [process_id](const auto& process) { | 143 | const auto process = SearchProcessList(process_list, [process_id](const auto& proc) { |
| 144 | return process->GetProcessID() == process_id; | 144 | return proc->GetProcessID() == process_id; |
| 145 | }); | 145 | }); |
| 146 | 146 | ||
| 147 | if (!process.has_value()) { | 147 | if (!process.has_value()) { |
diff --git a/src/core/hle/service/service.cpp b/src/core/hle/service/service.cpp index 00e683c2f..2c9b2ce6d 100644 --- a/src/core/hle/service/service.cpp +++ b/src/core/hle/service/service.cpp | |||
| @@ -111,7 +111,7 @@ void ServiceFrameworkBase::InstallAsService(SM::ServiceManager& service_manager) | |||
| 111 | port_installed = true; | 111 | port_installed = true; |
| 112 | } | 112 | } |
| 113 | 113 | ||
| 114 | void ServiceFrameworkBase::InstallAsNamedPort(Kernel::KernelCore& kernel) { | 114 | Kernel::KClientPort& ServiceFrameworkBase::CreatePort(Kernel::KernelCore& kernel) { |
| 115 | const auto guard = LockService(); | 115 | const auto guard = LockService(); |
| 116 | 116 | ||
| 117 | ASSERT(!port_installed); | 117 | ASSERT(!port_installed); |
| @@ -119,9 +119,10 @@ void ServiceFrameworkBase::InstallAsNamedPort(Kernel::KernelCore& kernel) { | |||
| 119 | auto* port = Kernel::KPort::Create(kernel); | 119 | auto* port = Kernel::KPort::Create(kernel); |
| 120 | port->Initialize(max_sessions, false, service_name); | 120 | port->Initialize(max_sessions, false, service_name); |
| 121 | port->GetServerPort().SetHleHandler(shared_from_this()); | 121 | port->GetServerPort().SetHleHandler(shared_from_this()); |
| 122 | kernel.AddNamedPort(service_name, &port->GetClientPort()); | ||
| 123 | 122 | ||
| 124 | port_installed = true; | 123 | port_installed = true; |
| 124 | |||
| 125 | return port->GetClientPort(); | ||
| 125 | } | 126 | } |
| 126 | 127 | ||
| 127 | void ServiceFrameworkBase::RegisterHandlersBase(const FunctionInfoBase* functions, std::size_t n) { | 128 | void ServiceFrameworkBase::RegisterHandlersBase(const FunctionInfoBase* functions, std::size_t n) { |
| @@ -132,6 +133,16 @@ void ServiceFrameworkBase::RegisterHandlersBase(const FunctionInfoBase* function | |||
| 132 | } | 133 | } |
| 133 | } | 134 | } |
| 134 | 135 | ||
| 136 | void ServiceFrameworkBase::RegisterHandlersBaseTipc(const FunctionInfoBase* functions, | ||
| 137 | std::size_t n) { | ||
| 138 | handlers_tipc.reserve(handlers_tipc.size() + n); | ||
| 139 | for (std::size_t i = 0; i < n; ++i) { | ||
| 140 | // Usually this array is sorted by id already, so hint to insert at the end | ||
| 141 | handlers_tipc.emplace_hint(handlers_tipc.cend(), functions[i].expected_header, | ||
| 142 | functions[i]); | ||
| 143 | } | ||
| 144 | } | ||
| 145 | |||
| 135 | void ServiceFrameworkBase::ReportUnimplementedFunction(Kernel::HLERequestContext& ctx, | 146 | void ServiceFrameworkBase::ReportUnimplementedFunction(Kernel::HLERequestContext& ctx, |
| 136 | const FunctionInfoBase* info) { | 147 | const FunctionInfoBase* info) { |
| 137 | auto cmd_buf = ctx.CommandBuffer(); | 148 | auto cmd_buf = ctx.CommandBuffer(); |
| @@ -166,33 +177,55 @@ void ServiceFrameworkBase::InvokeRequest(Kernel::HLERequestContext& ctx) { | |||
| 166 | handler_invoker(this, info->handler_callback, ctx); | 177 | handler_invoker(this, info->handler_callback, ctx); |
| 167 | } | 178 | } |
| 168 | 179 | ||
| 169 | ResultCode ServiceFrameworkBase::HandleSyncRequest(Kernel::HLERequestContext& context) { | 180 | void ServiceFrameworkBase::InvokeRequestTipc(Kernel::HLERequestContext& ctx) { |
| 181 | boost::container::flat_map<u32, FunctionInfoBase>::iterator itr; | ||
| 182 | |||
| 183 | itr = handlers_tipc.find(ctx.GetCommand()); | ||
| 184 | |||
| 185 | const FunctionInfoBase* info = itr == handlers_tipc.end() ? nullptr : &itr->second; | ||
| 186 | if (info == nullptr || info->handler_callback == nullptr) { | ||
| 187 | return ReportUnimplementedFunction(ctx, info); | ||
| 188 | } | ||
| 189 | |||
| 190 | LOG_TRACE(Service, "{}", MakeFunctionString(info->name, GetServiceName(), ctx.CommandBuffer())); | ||
| 191 | handler_invoker(this, info->handler_callback, ctx); | ||
| 192 | } | ||
| 193 | |||
| 194 | ResultCode ServiceFrameworkBase::HandleSyncRequest(Kernel::KServerSession& session, | ||
| 195 | Kernel::HLERequestContext& ctx) { | ||
| 170 | const auto guard = LockService(); | 196 | const auto guard = LockService(); |
| 171 | 197 | ||
| 172 | switch (context.GetCommandType()) { | 198 | switch (ctx.GetCommandType()) { |
| 173 | case IPC::CommandType::Close: { | 199 | case IPC::CommandType::Close: |
| 174 | IPC::ResponseBuilder rb{context, 2}; | 200 | case IPC::CommandType::TIPC_Close: { |
| 201 | session.Close(); | ||
| 202 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 175 | rb.Push(RESULT_SUCCESS); | 203 | rb.Push(RESULT_SUCCESS); |
| 176 | return IPC::ERR_REMOTE_PROCESS_DEAD; | 204 | return IPC::ERR_REMOTE_PROCESS_DEAD; |
| 177 | } | 205 | } |
| 178 | case IPC::CommandType::ControlWithContext: | 206 | case IPC::CommandType::ControlWithContext: |
| 179 | case IPC::CommandType::Control: { | 207 | case IPC::CommandType::Control: { |
| 180 | system.ServiceManager().InvokeControlRequest(context); | 208 | system.ServiceManager().InvokeControlRequest(ctx); |
| 181 | break; | 209 | break; |
| 182 | } | 210 | } |
| 183 | case IPC::CommandType::RequestWithContext: | 211 | case IPC::CommandType::RequestWithContext: |
| 184 | case IPC::CommandType::Request: { | 212 | case IPC::CommandType::Request: { |
| 185 | InvokeRequest(context); | 213 | InvokeRequest(ctx); |
| 186 | break; | 214 | break; |
| 187 | } | 215 | } |
| 188 | default: | 216 | default: |
| 189 | UNIMPLEMENTED_MSG("command_type={}", context.GetCommandType()); | 217 | if (ctx.IsTipc()) { |
| 218 | InvokeRequestTipc(ctx); | ||
| 219 | break; | ||
| 220 | } | ||
| 221 | |||
| 222 | UNIMPLEMENTED_MSG("command_type={}", ctx.GetCommandType()); | ||
| 190 | } | 223 | } |
| 191 | 224 | ||
| 192 | // If emulation was shutdown, we are closing service threads, do not write the response back to | 225 | // If emulation was shutdown, we are closing service threads, do not write the response back to |
| 193 | // memory that may be shutting down as well. | 226 | // memory that may be shutting down as well. |
| 194 | if (system.IsPoweredOn()) { | 227 | if (system.IsPoweredOn()) { |
| 195 | context.WriteToOutgoingCommandBuffer(context.GetThread()); | 228 | ctx.WriteToOutgoingCommandBuffer(ctx.GetThread()); |
| 196 | } | 229 | } |
| 197 | 230 | ||
| 198 | return RESULT_SUCCESS; | 231 | return RESULT_SUCCESS; |
| @@ -207,7 +240,7 @@ Services::Services(std::shared_ptr<SM::ServiceManager>& sm, Core::System& system | |||
| 207 | 240 | ||
| 208 | system.GetFileSystemController().CreateFactories(*system.GetFilesystem(), false); | 241 | system.GetFileSystemController().CreateFactories(*system.GetFilesystem(), false); |
| 209 | 242 | ||
| 210 | SM::ServiceManager::InstallInterfaces(sm, system); | 243 | system.Kernel().RegisterNamedService("sm:", SM::ServiceManager::InterfaceFactory); |
| 211 | 244 | ||
| 212 | Account::InstallInterfaces(system); | 245 | Account::InstallInterfaces(system); |
| 213 | AM::InstallInterfaces(*sm, *nv_flinger, system); | 246 | AM::InstallInterfaces(*sm, *nv_flinger, system); |
diff --git a/src/core/hle/service/service.h b/src/core/hle/service/service.h index 884951428..4c048173b 100644 --- a/src/core/hle/service/service.h +++ b/src/core/hle/service/service.h | |||
| @@ -21,7 +21,9 @@ class System; | |||
| 21 | 21 | ||
| 22 | namespace Kernel { | 22 | namespace Kernel { |
| 23 | class HLERequestContext; | 23 | class HLERequestContext; |
| 24 | } | 24 | class KClientPort; |
| 25 | class KServerSession; | ||
| 26 | } // namespace Kernel | ||
| 25 | 27 | ||
| 26 | namespace Service { | 28 | namespace Service { |
| 27 | 29 | ||
| @@ -64,12 +66,19 @@ public: | |||
| 64 | 66 | ||
| 65 | /// Creates a port pair and registers this service with the given ServiceManager. | 67 | /// Creates a port pair and registers this service with the given ServiceManager. |
| 66 | void InstallAsService(SM::ServiceManager& service_manager); | 68 | void InstallAsService(SM::ServiceManager& service_manager); |
| 67 | /// Creates a port pair and registers it on the kernel's global port registry. | 69 | |
| 68 | void InstallAsNamedPort(Kernel::KernelCore& kernel); | 70 | /// Invokes a service request routine using the HIPC protocol. |
| 69 | /// Invokes a service request routine. | ||
| 70 | void InvokeRequest(Kernel::HLERequestContext& ctx); | 71 | void InvokeRequest(Kernel::HLERequestContext& ctx); |
| 72 | |||
| 73 | /// Invokes a service request routine using the HIPC protocol. | ||
| 74 | void InvokeRequestTipc(Kernel::HLERequestContext& ctx); | ||
| 75 | |||
| 76 | /// Creates a port pair and registers it on the kernel's global port registry. | ||
| 77 | Kernel::KClientPort& CreatePort(Kernel::KernelCore& kernel); | ||
| 78 | |||
| 71 | /// Handles a synchronization request for the service. | 79 | /// Handles a synchronization request for the service. |
| 72 | ResultCode HandleSyncRequest(Kernel::HLERequestContext& context) override; | 80 | ResultCode HandleSyncRequest(Kernel::KServerSession& session, |
| 81 | Kernel::HLERequestContext& context) override; | ||
| 73 | 82 | ||
| 74 | protected: | 83 | protected: |
| 75 | /// Member-function pointer type of SyncRequest handlers. | 84 | /// Member-function pointer type of SyncRequest handlers. |
| @@ -102,6 +111,7 @@ private: | |||
| 102 | ~ServiceFrameworkBase() override; | 111 | ~ServiceFrameworkBase() override; |
| 103 | 112 | ||
| 104 | void RegisterHandlersBase(const FunctionInfoBase* functions, std::size_t n); | 113 | void RegisterHandlersBase(const FunctionInfoBase* functions, std::size_t n); |
| 114 | void RegisterHandlersBaseTipc(const FunctionInfoBase* functions, std::size_t n); | ||
| 105 | void ReportUnimplementedFunction(Kernel::HLERequestContext& ctx, const FunctionInfoBase* info); | 115 | void ReportUnimplementedFunction(Kernel::HLERequestContext& ctx, const FunctionInfoBase* info); |
| 106 | 116 | ||
| 107 | /// Identifier string used to connect to the service. | 117 | /// Identifier string used to connect to the service. |
| @@ -116,6 +126,7 @@ private: | |||
| 116 | /// Function used to safely up-cast pointers to the derived class before invoking a handler. | 126 | /// Function used to safely up-cast pointers to the derived class before invoking a handler. |
| 117 | InvokerFn* handler_invoker; | 127 | InvokerFn* handler_invoker; |
| 118 | boost::container::flat_map<u32, FunctionInfoBase> handlers; | 128 | boost::container::flat_map<u32, FunctionInfoBase> handlers; |
| 129 | boost::container::flat_map<u32, FunctionInfoBase> handlers_tipc; | ||
| 119 | 130 | ||
| 120 | /// Used to gain exclusive access to the service members, e.g. from CoreTiming thread. | 131 | /// Used to gain exclusive access to the service members, e.g. from CoreTiming thread. |
| 121 | Common::SpinLock lock_service; | 132 | Common::SpinLock lock_service; |
| @@ -144,17 +155,17 @@ protected: | |||
| 144 | /** | 155 | /** |
| 145 | * Constructs a FunctionInfo for a function. | 156 | * Constructs a FunctionInfo for a function. |
| 146 | * | 157 | * |
| 147 | * @param expected_header request header in the command buffer which will trigger dispatch | 158 | * @param expected_header_ request header in the command buffer which will trigger dispatch |
| 148 | * to this handler | 159 | * to this handler |
| 149 | * @param handler_callback member function in this service which will be called to handle | 160 | * @param handler_callback_ member function in this service which will be called to handle |
| 150 | * the request | 161 | * the request |
| 151 | * @param name human-friendly name for the request. Used mostly for logging purposes. | 162 | * @param name_ human-friendly name for the request. Used mostly for logging purposes. |
| 152 | */ | 163 | */ |
| 153 | FunctionInfo(u32 expected_header, HandlerFnP<Self> handler_callback, const char* name) | 164 | FunctionInfo(u32 expected_header_, HandlerFnP<Self> handler_callback_, const char* name_) |
| 154 | : FunctionInfoBase{ | 165 | : FunctionInfoBase{ |
| 155 | expected_header, | 166 | expected_header_, |
| 156 | // Type-erase member function pointer by casting it down to the base class. | 167 | // Type-erase member function pointer by casting it down to the base class. |
| 157 | static_cast<HandlerFnP<ServiceFrameworkBase>>(handler_callback), name} {} | 168 | static_cast<HandlerFnP<ServiceFrameworkBase>>(handler_callback_), name_} {} |
| 158 | }; | 169 | }; |
| 159 | 170 | ||
| 160 | /** | 171 | /** |
| @@ -183,6 +194,20 @@ protected: | |||
| 183 | RegisterHandlersBase(functions, n); | 194 | RegisterHandlersBase(functions, n); |
| 184 | } | 195 | } |
| 185 | 196 | ||
| 197 | /// Registers handlers in the service. | ||
| 198 | template <std::size_t N> | ||
| 199 | void RegisterHandlersTipc(const FunctionInfo (&functions)[N]) { | ||
| 200 | RegisterHandlersTipc(functions, N); | ||
| 201 | } | ||
| 202 | |||
| 203 | /** | ||
| 204 | * Registers handlers in the service. Usually prefer using the other RegisterHandlers | ||
| 205 | * overload in order to avoid needing to specify the array size. | ||
| 206 | */ | ||
| 207 | void RegisterHandlersTipc(const FunctionInfo* functions, std::size_t n) { | ||
| 208 | RegisterHandlersBaseTipc(functions, n); | ||
| 209 | } | ||
| 210 | |||
| 186 | private: | 211 | private: |
| 187 | /** | 212 | /** |
| 188 | * This function is used to allow invocation of pointers to handlers stored in the base class | 213 | * This function is used to allow invocation of pointers to handlers stored in the base class |
diff --git a/src/core/hle/service/sm/controller.cpp b/src/core/hle/service/sm/controller.cpp index ee026e22f..de530cbfb 100644 --- a/src/core/hle/service/sm/controller.cpp +++ b/src/core/hle/service/sm/controller.cpp | |||
| @@ -26,15 +26,23 @@ void Controller::CloneCurrentObject(Kernel::HLERequestContext& ctx) { | |||
| 26 | // TODO(bunnei): This is just creating a new handle to the same Session. I assume this is wrong | 26 | // TODO(bunnei): This is just creating a new handle to the same Session. I assume this is wrong |
| 27 | // and that we probably want to actually make an entirely new Session, but we still need to | 27 | // and that we probably want to actually make an entirely new Session, but we still need to |
| 28 | // verify this on hardware. | 28 | // verify this on hardware. |
| 29 | |||
| 29 | LOG_DEBUG(Service, "called"); | 30 | LOG_DEBUG(Service, "called"); |
| 30 | 31 | ||
| 32 | auto session = ctx.Session()->GetParent(); | ||
| 33 | |||
| 34 | // Open a reference to the session to simulate a new one being created. | ||
| 35 | session->Open(); | ||
| 36 | session->GetClientSession().Open(); | ||
| 37 | session->GetServerSession().Open(); | ||
| 38 | |||
| 31 | IPC::ResponseBuilder rb{ctx, 2, 0, 1, IPC::ResponseBuilder::Flags::AlwaysMoveHandles}; | 39 | IPC::ResponseBuilder rb{ctx, 2, 0, 1, IPC::ResponseBuilder::Flags::AlwaysMoveHandles}; |
| 32 | rb.Push(RESULT_SUCCESS); | 40 | rb.Push(RESULT_SUCCESS); |
| 33 | rb.PushMoveObjects(ctx.Session()->GetParent()->GetClientSession()); | 41 | rb.PushMoveObjects(session->GetClientSession()); |
| 34 | } | 42 | } |
| 35 | 43 | ||
| 36 | void Controller::CloneCurrentObjectEx(Kernel::HLERequestContext& ctx) { | 44 | void Controller::CloneCurrentObjectEx(Kernel::HLERequestContext& ctx) { |
| 37 | LOG_WARNING(Service, "(STUBBED) called, using CloneCurrentObject"); | 45 | LOG_DEBUG(Service, "called"); |
| 38 | 46 | ||
| 39 | CloneCurrentObject(ctx); | 47 | CloneCurrentObject(ctx); |
| 40 | } | 48 | } |
| @@ -44,7 +52,7 @@ void Controller::QueryPointerBufferSize(Kernel::HLERequestContext& ctx) { | |||
| 44 | 52 | ||
| 45 | IPC::ResponseBuilder rb{ctx, 3}; | 53 | IPC::ResponseBuilder rb{ctx, 3}; |
| 46 | rb.Push(RESULT_SUCCESS); | 54 | rb.Push(RESULT_SUCCESS); |
| 47 | rb.Push<u16>(0x1000); | 55 | rb.Push<u16>(0x8000); |
| 48 | } | 56 | } |
| 49 | 57 | ||
| 50 | // https://switchbrew.org/wiki/IPC_Marshalling | 58 | // https://switchbrew.org/wiki/IPC_Marshalling |
diff --git a/src/core/hle/service/sm/sm.cpp b/src/core/hle/service/sm/sm.cpp index 568effbc9..8cc9aee8a 100644 --- a/src/core/hle/service/sm/sm.cpp +++ b/src/core/hle/service/sm/sm.cpp | |||
| @@ -9,6 +9,7 @@ | |||
| 9 | #include "core/hle/kernel/k_client_port.h" | 9 | #include "core/hle/kernel/k_client_port.h" |
| 10 | #include "core/hle/kernel/k_client_session.h" | 10 | #include "core/hle/kernel/k_client_session.h" |
| 11 | #include "core/hle/kernel/k_port.h" | 11 | #include "core/hle/kernel/k_port.h" |
| 12 | #include "core/hle/kernel/k_scoped_resource_reservation.h" | ||
| 12 | #include "core/hle/kernel/k_server_port.h" | 13 | #include "core/hle/kernel/k_server_port.h" |
| 13 | #include "core/hle/kernel/k_server_session.h" | 14 | #include "core/hle/kernel/k_server_session.h" |
| 14 | #include "core/hle/kernel/k_session.h" | 15 | #include "core/hle/kernel/k_session.h" |
| @@ -18,6 +19,7 @@ | |||
| 18 | 19 | ||
| 19 | namespace Service::SM { | 20 | namespace Service::SM { |
| 20 | 21 | ||
| 22 | constexpr ResultCode ERR_NOT_INITIALIZED(ErrorModule::SM, 2); | ||
| 21 | constexpr ResultCode ERR_ALREADY_REGISTERED(ErrorModule::SM, 4); | 23 | constexpr ResultCode ERR_ALREADY_REGISTERED(ErrorModule::SM, 4); |
| 22 | constexpr ResultCode ERR_INVALID_NAME(ErrorModule::SM, 6); | 24 | constexpr ResultCode ERR_INVALID_NAME(ErrorModule::SM, 6); |
| 23 | constexpr ResultCode ERR_SERVICE_NOT_REGISTERED(ErrorModule::SM, 7); | 25 | constexpr ResultCode ERR_SERVICE_NOT_REGISTERED(ErrorModule::SM, 7); |
| @@ -34,20 +36,17 @@ static ResultCode ValidateServiceName(const std::string& name) { | |||
| 34 | LOG_ERROR(Service_SM, "Invalid service name! service={}", name); | 36 | LOG_ERROR(Service_SM, "Invalid service name! service={}", name); |
| 35 | return ERR_INVALID_NAME; | 37 | return ERR_INVALID_NAME; |
| 36 | } | 38 | } |
| 37 | if (name.rfind('\0') != std::string::npos) { | ||
| 38 | LOG_ERROR(Service_SM, "A non null terminated service was passed"); | ||
| 39 | return ERR_INVALID_NAME; | ||
| 40 | } | ||
| 41 | return RESULT_SUCCESS; | 39 | return RESULT_SUCCESS; |
| 42 | } | 40 | } |
| 43 | 41 | ||
| 44 | void ServiceManager::InstallInterfaces(std::shared_ptr<ServiceManager> self, Core::System& system) { | 42 | Kernel::KClientPort& ServiceManager::InterfaceFactory(ServiceManager& self, Core::System& system) { |
| 45 | ASSERT(self->sm_interface.expired()); | 43 | ASSERT(self.sm_interface.expired()); |
| 46 | 44 | ||
| 47 | auto sm = std::make_shared<SM>(self, system); | 45 | auto sm = std::make_shared<SM>(self, system); |
| 48 | sm->InstallAsNamedPort(system.Kernel()); | 46 | self.sm_interface = sm; |
| 49 | self->sm_interface = sm; | 47 | self.controller_interface = std::make_unique<Controller>(system); |
| 50 | self->controller_interface = std::make_unique<Controller>(system); | 48 | |
| 49 | return sm->CreatePort(system.Kernel()); | ||
| 51 | } | 50 | } |
| 52 | 51 | ||
| 53 | ResultVal<Kernel::KServerPort*> ServiceManager::RegisterService(std::string name, | 52 | ResultVal<Kernel::KServerPort*> ServiceManager::RegisterService(std::string name, |
| @@ -107,33 +106,68 @@ SM::~SM() = default; | |||
| 107 | void SM::Initialize(Kernel::HLERequestContext& ctx) { | 106 | void SM::Initialize(Kernel::HLERequestContext& ctx) { |
| 108 | LOG_DEBUG(Service_SM, "called"); | 107 | LOG_DEBUG(Service_SM, "called"); |
| 109 | 108 | ||
| 109 | is_initialized = true; | ||
| 110 | |||
| 110 | IPC::ResponseBuilder rb{ctx, 2}; | 111 | IPC::ResponseBuilder rb{ctx, 2}; |
| 111 | rb.Push(RESULT_SUCCESS); | 112 | rb.Push(RESULT_SUCCESS); |
| 112 | } | 113 | } |
| 113 | 114 | ||
| 114 | void SM::GetService(Kernel::HLERequestContext& ctx) { | 115 | void SM::GetService(Kernel::HLERequestContext& ctx) { |
| 115 | IPC::RequestParser rp{ctx}; | 116 | auto result = GetServiceImpl(ctx); |
| 117 | if (result.Succeeded()) { | ||
| 118 | IPC::ResponseBuilder rb{ctx, 2, 0, 1, IPC::ResponseBuilder::Flags::AlwaysMoveHandles}; | ||
| 119 | rb.Push(result.Code()); | ||
| 120 | rb.PushMoveObjects(result.Unwrap()); | ||
| 121 | } else { | ||
| 122 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 123 | rb.Push(result.Code()); | ||
| 124 | } | ||
| 125 | } | ||
| 126 | |||
| 127 | void SM::GetServiceTipc(Kernel::HLERequestContext& ctx) { | ||
| 128 | auto result = GetServiceImpl(ctx); | ||
| 129 | IPC::ResponseBuilder rb{ctx, 2, 0, 1, IPC::ResponseBuilder::Flags::AlwaysMoveHandles}; | ||
| 130 | rb.Push(result.Code()); | ||
| 131 | rb.PushMoveObjects(result.Succeeded() ? result.Unwrap() : nullptr); | ||
| 132 | } | ||
| 133 | |||
| 134 | static std::string PopServiceName(IPC::RequestParser& rp) { | ||
| 116 | auto name_buf = rp.PopRaw<std::array<char, 8>>(); | 135 | auto name_buf = rp.PopRaw<std::array<char, 8>>(); |
| 117 | auto end = std::find(name_buf.begin(), name_buf.end(), '\0'); | 136 | std::string result; |
| 137 | for (const auto& c : name_buf) { | ||
| 138 | if (c >= ' ' && c <= '~') { | ||
| 139 | result.push_back(c); | ||
| 140 | } | ||
| 141 | } | ||
| 142 | return result; | ||
| 143 | } | ||
| 118 | 144 | ||
| 119 | std::string name(name_buf.begin(), end); | 145 | ResultVal<Kernel::KClientSession*> SM::GetServiceImpl(Kernel::HLERequestContext& ctx) { |
| 146 | if (!is_initialized) { | ||
| 147 | return ERR_NOT_INITIALIZED; | ||
| 148 | } | ||
| 149 | |||
| 150 | IPC::RequestParser rp{ctx}; | ||
| 151 | std::string name(PopServiceName(rp)); | ||
| 120 | 152 | ||
| 121 | auto result = service_manager->GetServicePort(name); | 153 | auto result = service_manager.GetServicePort(name); |
| 122 | if (result.Failed()) { | 154 | if (result.Failed()) { |
| 123 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 124 | rb.Push(result.Code()); | ||
| 125 | LOG_ERROR(Service_SM, "called service={} -> error 0x{:08X}", name, result.Code().raw); | 155 | LOG_ERROR(Service_SM, "called service={} -> error 0x{:08X}", name, result.Code().raw); |
| 126 | if (name.length() == 0) | 156 | return result.Code(); |
| 127 | return; // LibNX Fix | ||
| 128 | UNIMPLEMENTED(); | ||
| 129 | return; | ||
| 130 | } | 157 | } |
| 131 | 158 | ||
| 132 | auto* port = result.Unwrap(); | 159 | auto* port = result.Unwrap(); |
| 133 | 160 | ||
| 161 | // Kernel::KScopedResourceReservation session_reservation( | ||
| 162 | // kernel.CurrentProcess()->GetResourceLimit(), Kernel::LimitableResource::Sessions); | ||
| 163 | // R_UNLESS(session_reservation.Succeeded(), Kernel::ResultLimitReached); | ||
| 164 | |||
| 134 | auto* session = Kernel::KSession::Create(kernel); | 165 | auto* session = Kernel::KSession::Create(kernel); |
| 135 | session->Initialize(&port->GetClientPort(), std::move(name)); | 166 | session->Initialize(&port->GetClientPort(), std::move(name)); |
| 136 | 167 | ||
| 168 | // Commit the session reservation. | ||
| 169 | // session_reservation.Commit(); | ||
| 170 | |||
| 137 | if (port->GetServerPort().GetHLEHandler()) { | 171 | if (port->GetServerPort().GetHLEHandler()) { |
| 138 | port->GetServerPort().GetHLEHandler()->ClientConnected(&session->GetServerSession()); | 172 | port->GetServerPort().GetHLEHandler()->ClientConnected(&session->GetServerSession()); |
| 139 | } else { | 173 | } else { |
| @@ -141,18 +175,12 @@ void SM::GetService(Kernel::HLERequestContext& ctx) { | |||
| 141 | } | 175 | } |
| 142 | 176 | ||
| 143 | LOG_DEBUG(Service_SM, "called service={} -> session={}", name, session->GetId()); | 177 | LOG_DEBUG(Service_SM, "called service={} -> session={}", name, session->GetId()); |
| 144 | IPC::ResponseBuilder rb{ctx, 2, 0, 1, IPC::ResponseBuilder::Flags::AlwaysMoveHandles}; | 178 | return MakeResult(&session->GetClientSession()); |
| 145 | rb.Push(RESULT_SUCCESS); | ||
| 146 | rb.PushMoveObjects(session->GetClientSession()); | ||
| 147 | } | 179 | } |
| 148 | 180 | ||
| 149 | void SM::RegisterService(Kernel::HLERequestContext& ctx) { | 181 | void SM::RegisterService(Kernel::HLERequestContext& ctx) { |
| 150 | IPC::RequestParser rp{ctx}; | 182 | IPC::RequestParser rp{ctx}; |
| 151 | 183 | std::string name(PopServiceName(rp)); | |
| 152 | const auto name_buf = rp.PopRaw<std::array<char, 8>>(); | ||
| 153 | const auto end = std::find(name_buf.begin(), name_buf.end(), '\0'); | ||
| 154 | |||
| 155 | const std::string name(name_buf.begin(), end); | ||
| 156 | 184 | ||
| 157 | const auto is_light = static_cast<bool>(rp.PopRaw<u32>()); | 185 | const auto is_light = static_cast<bool>(rp.PopRaw<u32>()); |
| 158 | const auto max_session_count = rp.PopRaw<u32>(); | 186 | const auto max_session_count = rp.PopRaw<u32>(); |
| @@ -160,7 +188,7 @@ void SM::RegisterService(Kernel::HLERequestContext& ctx) { | |||
| 160 | LOG_DEBUG(Service_SM, "called with name={}, max_session_count={}, is_light={}", name, | 188 | LOG_DEBUG(Service_SM, "called with name={}, max_session_count={}, is_light={}", name, |
| 161 | max_session_count, is_light); | 189 | max_session_count, is_light); |
| 162 | 190 | ||
| 163 | auto handle = service_manager->RegisterService(name, max_session_count); | 191 | auto handle = service_manager.RegisterService(name, max_session_count); |
| 164 | if (handle.Failed()) { | 192 | if (handle.Failed()) { |
| 165 | LOG_ERROR(Service_SM, "failed to register service with error_code={:08X}", | 193 | LOG_ERROR(Service_SM, "failed to register service with error_code={:08X}", |
| 166 | handle.Code().raw); | 194 | handle.Code().raw); |
| @@ -178,28 +206,31 @@ void SM::RegisterService(Kernel::HLERequestContext& ctx) { | |||
| 178 | 206 | ||
| 179 | void SM::UnregisterService(Kernel::HLERequestContext& ctx) { | 207 | void SM::UnregisterService(Kernel::HLERequestContext& ctx) { |
| 180 | IPC::RequestParser rp{ctx}; | 208 | IPC::RequestParser rp{ctx}; |
| 209 | std::string name(PopServiceName(rp)); | ||
| 181 | 210 | ||
| 182 | const auto name_buf = rp.PopRaw<std::array<char, 8>>(); | ||
| 183 | const auto end = std::find(name_buf.begin(), name_buf.end(), '\0'); | ||
| 184 | |||
| 185 | const std::string name(name_buf.begin(), end); | ||
| 186 | LOG_DEBUG(Service_SM, "called with name={}", name); | 211 | LOG_DEBUG(Service_SM, "called with name={}", name); |
| 187 | 212 | ||
| 188 | IPC::ResponseBuilder rb{ctx, 2}; | 213 | IPC::ResponseBuilder rb{ctx, 2}; |
| 189 | rb.Push(service_manager->UnregisterService(name)); | 214 | rb.Push(service_manager.UnregisterService(name)); |
| 190 | } | 215 | } |
| 191 | 216 | ||
| 192 | SM::SM(std::shared_ptr<ServiceManager> service_manager_, Core::System& system_) | 217 | SM::SM(ServiceManager& service_manager_, Core::System& system_) |
| 193 | : ServiceFramework{system_, "sm:", 4}, | 218 | : ServiceFramework{system_, "sm:", 4}, |
| 194 | service_manager{std::move(service_manager_)}, kernel{system_.Kernel()} { | 219 | service_manager{service_manager_}, kernel{system_.Kernel()} { |
| 195 | static const FunctionInfo functions[] = { | 220 | RegisterHandlers({ |
| 196 | {0, &SM::Initialize, "Initialize"}, | 221 | {0, &SM::Initialize, "Initialize"}, |
| 197 | {1, &SM::GetService, "GetService"}, | 222 | {1, &SM::GetService, "GetService"}, |
| 198 | {2, &SM::RegisterService, "RegisterService"}, | 223 | {2, &SM::RegisterService, "RegisterService"}, |
| 199 | {3, &SM::UnregisterService, "UnregisterService"}, | 224 | {3, &SM::UnregisterService, "UnregisterService"}, |
| 200 | {4, nullptr, "DetachClient"}, | 225 | {4, nullptr, "DetachClient"}, |
| 201 | }; | 226 | }); |
| 202 | RegisterHandlers(functions); | 227 | RegisterHandlersTipc({ |
| 228 | {0, &SM::Initialize, "Initialize"}, | ||
| 229 | {1, &SM::GetServiceTipc, "GetService"}, | ||
| 230 | {2, &SM::RegisterService, "RegisterService"}, | ||
| 231 | {3, &SM::UnregisterService, "UnregisterService"}, | ||
| 232 | {4, nullptr, "DetachClient"}, | ||
| 233 | }); | ||
| 203 | } | 234 | } |
| 204 | 235 | ||
| 205 | } // namespace Service::SM | 236 | } // namespace Service::SM |
diff --git a/src/core/hle/service/sm/sm.h b/src/core/hle/service/sm/sm.h index af5010c3b..60f0b3f8a 100644 --- a/src/core/hle/service/sm/sm.h +++ b/src/core/hle/service/sm/sm.h | |||
| @@ -34,22 +34,26 @@ class Controller; | |||
| 34 | /// Interface to "sm:" service | 34 | /// Interface to "sm:" service |
| 35 | class SM final : public ServiceFramework<SM> { | 35 | class SM final : public ServiceFramework<SM> { |
| 36 | public: | 36 | public: |
| 37 | explicit SM(std::shared_ptr<ServiceManager> service_manager_, Core::System& system_); | 37 | explicit SM(ServiceManager& service_manager_, Core::System& system_); |
| 38 | ~SM() override; | 38 | ~SM() override; |
| 39 | 39 | ||
| 40 | private: | 40 | private: |
| 41 | void Initialize(Kernel::HLERequestContext& ctx); | 41 | void Initialize(Kernel::HLERequestContext& ctx); |
| 42 | void GetService(Kernel::HLERequestContext& ctx); | 42 | void GetService(Kernel::HLERequestContext& ctx); |
| 43 | void GetServiceTipc(Kernel::HLERequestContext& ctx); | ||
| 43 | void RegisterService(Kernel::HLERequestContext& ctx); | 44 | void RegisterService(Kernel::HLERequestContext& ctx); |
| 44 | void UnregisterService(Kernel::HLERequestContext& ctx); | 45 | void UnregisterService(Kernel::HLERequestContext& ctx); |
| 45 | 46 | ||
| 46 | std::shared_ptr<ServiceManager> service_manager; | 47 | ResultVal<Kernel::KClientSession*> GetServiceImpl(Kernel::HLERequestContext& ctx); |
| 48 | |||
| 49 | ServiceManager& service_manager; | ||
| 50 | bool is_initialized{}; | ||
| 47 | Kernel::KernelCore& kernel; | 51 | Kernel::KernelCore& kernel; |
| 48 | }; | 52 | }; |
| 49 | 53 | ||
| 50 | class ServiceManager { | 54 | class ServiceManager { |
| 51 | public: | 55 | public: |
| 52 | static void InstallInterfaces(std::shared_ptr<ServiceManager> self, Core::System& system); | 56 | static Kernel::KClientPort& InterfaceFactory(ServiceManager& self, Core::System& system); |
| 53 | 57 | ||
| 54 | explicit ServiceManager(Kernel::KernelCore& kernel_); | 58 | explicit ServiceManager(Kernel::KernelCore& kernel_); |
| 55 | ~ServiceManager(); | 59 | ~ServiceManager(); |
diff --git a/src/core/hle/service/ssl/ssl.cpp b/src/core/hle/service/ssl/ssl.cpp index 2c8899ae0..3b072f6bc 100644 --- a/src/core/hle/service/ssl/ssl.cpp +++ b/src/core/hle/service/ssl/ssl.cpp | |||
| @@ -128,7 +128,7 @@ private: | |||
| 128 | 128 | ||
| 129 | LOG_WARNING(Service_SSL, "(STUBBED) called"); | 129 | LOG_WARNING(Service_SSL, "(STUBBED) called"); |
| 130 | 130 | ||
| 131 | IPC::ResponseBuilder rb{ctx, 2}; | 131 | IPC::ResponseBuilder rb{ctx, 4}; |
| 132 | rb.Push(RESULT_SUCCESS); | 132 | rb.Push(RESULT_SUCCESS); |
| 133 | rb.Push(client_id); | 133 | rb.Push(client_id); |
| 134 | } | 134 | } |
diff --git a/src/core/hle/service/time/ephemeral_network_system_clock_core.h b/src/core/hle/service/time/ephemeral_network_system_clock_core.h index 4c6cdef86..d12cb5335 100644 --- a/src/core/hle/service/time/ephemeral_network_system_clock_core.h +++ b/src/core/hle/service/time/ephemeral_network_system_clock_core.h | |||
| @@ -10,8 +10,8 @@ namespace Service::Time::Clock { | |||
| 10 | 10 | ||
| 11 | class EphemeralNetworkSystemClockCore final : public SystemClockCore { | 11 | class EphemeralNetworkSystemClockCore final : public SystemClockCore { |
| 12 | public: | 12 | public: |
| 13 | explicit EphemeralNetworkSystemClockCore(SteadyClockCore& steady_clock_core) | 13 | explicit EphemeralNetworkSystemClockCore(SteadyClockCore& steady_clock_core_) |
| 14 | : SystemClockCore{steady_clock_core} {} | 14 | : SystemClockCore{steady_clock_core_} {} |
| 15 | }; | 15 | }; |
| 16 | 16 | ||
| 17 | } // namespace Service::Time::Clock | 17 | } // namespace Service::Time::Clock |
diff --git a/src/core/hle/service/time/local_system_clock_context_writer.h b/src/core/hle/service/time/local_system_clock_context_writer.h index 7050844c6..490d0ef3e 100644 --- a/src/core/hle/service/time/local_system_clock_context_writer.h +++ b/src/core/hle/service/time/local_system_clock_context_writer.h | |||
| @@ -12,8 +12,8 @@ namespace Service::Time::Clock { | |||
| 12 | 12 | ||
| 13 | class LocalSystemClockContextWriter final : public SystemClockContextUpdateCallback { | 13 | class LocalSystemClockContextWriter final : public SystemClockContextUpdateCallback { |
| 14 | public: | 14 | public: |
| 15 | explicit LocalSystemClockContextWriter(SharedMemory& shared_memory) | 15 | explicit LocalSystemClockContextWriter(SharedMemory& shared_memory_) |
| 16 | : SystemClockContextUpdateCallback{}, shared_memory{shared_memory} {} | 16 | : SystemClockContextUpdateCallback{}, shared_memory{shared_memory_} {} |
| 17 | 17 | ||
| 18 | protected: | 18 | protected: |
| 19 | ResultCode Update() override { | 19 | ResultCode Update() override { |
diff --git a/src/core/hle/service/time/network_system_clock_context_writer.h b/src/core/hle/service/time/network_system_clock_context_writer.h index 94d8788ff..e2920b8eb 100644 --- a/src/core/hle/service/time/network_system_clock_context_writer.h +++ b/src/core/hle/service/time/network_system_clock_context_writer.h | |||
| @@ -12,8 +12,8 @@ namespace Service::Time::Clock { | |||
| 12 | 12 | ||
| 13 | class NetworkSystemClockContextWriter final : public SystemClockContextUpdateCallback { | 13 | class NetworkSystemClockContextWriter final : public SystemClockContextUpdateCallback { |
| 14 | public: | 14 | public: |
| 15 | explicit NetworkSystemClockContextWriter(SharedMemory& shared_memory) | 15 | explicit NetworkSystemClockContextWriter(SharedMemory& shared_memory_) |
| 16 | : SystemClockContextUpdateCallback{}, shared_memory{shared_memory} {} | 16 | : SystemClockContextUpdateCallback{}, shared_memory{shared_memory_} {} |
| 17 | 17 | ||
| 18 | protected: | 18 | protected: |
| 19 | ResultCode Update() override { | 19 | ResultCode Update() override { |
diff --git a/src/core/hle/service/time/standard_local_system_clock_core.h b/src/core/hle/service/time/standard_local_system_clock_core.h index 8c1882eb1..6320c7af1 100644 --- a/src/core/hle/service/time/standard_local_system_clock_core.h +++ b/src/core/hle/service/time/standard_local_system_clock_core.h | |||
| @@ -10,8 +10,8 @@ namespace Service::Time::Clock { | |||
| 10 | 10 | ||
| 11 | class StandardLocalSystemClockCore final : public SystemClockCore { | 11 | class StandardLocalSystemClockCore final : public SystemClockCore { |
| 12 | public: | 12 | public: |
| 13 | explicit StandardLocalSystemClockCore(SteadyClockCore& steady_clock_core) | 13 | explicit StandardLocalSystemClockCore(SteadyClockCore& steady_clock_core_) |
| 14 | : SystemClockCore{steady_clock_core} {} | 14 | : SystemClockCore{steady_clock_core_} {} |
| 15 | }; | 15 | }; |
| 16 | 16 | ||
| 17 | } // namespace Service::Time::Clock | 17 | } // namespace Service::Time::Clock |
diff --git a/src/core/hle/service/time/standard_network_system_clock_core.h b/src/core/hle/service/time/standard_network_system_clock_core.h index c993bdf79..9d0aeaedb 100644 --- a/src/core/hle/service/time/standard_network_system_clock_core.h +++ b/src/core/hle/service/time/standard_network_system_clock_core.h | |||
| @@ -16,21 +16,21 @@ namespace Service::Time::Clock { | |||
| 16 | 16 | ||
| 17 | class StandardNetworkSystemClockCore final : public SystemClockCore { | 17 | class StandardNetworkSystemClockCore final : public SystemClockCore { |
| 18 | public: | 18 | public: |
| 19 | explicit StandardNetworkSystemClockCore(SteadyClockCore& steady_clock_core) | 19 | explicit StandardNetworkSystemClockCore(SteadyClockCore& steady_clock_core_) |
| 20 | : SystemClockCore{steady_clock_core} {} | 20 | : SystemClockCore{steady_clock_core_} {} |
| 21 | 21 | ||
| 22 | void SetStandardNetworkClockSufficientAccuracy(TimeSpanType value) { | 22 | void SetStandardNetworkClockSufficientAccuracy(TimeSpanType value) { |
| 23 | standard_network_clock_sufficient_accuracy = value; | 23 | standard_network_clock_sufficient_accuracy = value; |
| 24 | } | 24 | } |
| 25 | 25 | ||
| 26 | bool IsStandardNetworkSystemClockAccuracySufficient(Core::System& system) const { | 26 | bool IsStandardNetworkSystemClockAccuracySufficient(Core::System& system) const { |
| 27 | SystemClockContext context{}; | 27 | SystemClockContext clock_ctx{}; |
| 28 | if (GetClockContext(system, context) != RESULT_SUCCESS) { | 28 | if (GetClockContext(system, clock_ctx) != RESULT_SUCCESS) { |
| 29 | return {}; | 29 | return {}; |
| 30 | } | 30 | } |
| 31 | 31 | ||
| 32 | s64 span{}; | 32 | s64 span{}; |
| 33 | if (context.steady_time_point.GetSpanBetween( | 33 | if (clock_ctx.steady_time_point.GetSpanBetween( |
| 34 | GetSteadyClockCore().GetCurrentTimePoint(system), span) != RESULT_SUCCESS) { | 34 | GetSteadyClockCore().GetCurrentTimePoint(system), span) != RESULT_SUCCESS) { |
| 35 | return {}; | 35 | return {}; |
| 36 | } | 36 | } |
diff --git a/src/core/hle/service/time/standard_user_system_clock_core.cpp b/src/core/hle/service/time/standard_user_system_clock_core.cpp index 7f47b12b8..41bc01abd 100644 --- a/src/core/hle/service/time/standard_user_system_clock_core.cpp +++ b/src/core/hle/service/time/standard_user_system_clock_core.cpp | |||
| @@ -11,13 +11,13 @@ | |||
| 11 | namespace Service::Time::Clock { | 11 | namespace Service::Time::Clock { |
| 12 | 12 | ||
| 13 | StandardUserSystemClockCore::StandardUserSystemClockCore( | 13 | StandardUserSystemClockCore::StandardUserSystemClockCore( |
| 14 | StandardLocalSystemClockCore& local_system_clock_core, | 14 | StandardLocalSystemClockCore& local_system_clock_core_, |
| 15 | StandardNetworkSystemClockCore& network_system_clock_core, Core::System& system) | 15 | StandardNetworkSystemClockCore& network_system_clock_core_, Core::System& system_) |
| 16 | : SystemClockCore(local_system_clock_core.GetSteadyClockCore()), | 16 | : SystemClockCore(local_system_clock_core_.GetSteadyClockCore()), |
| 17 | local_system_clock_core{local_system_clock_core}, | 17 | local_system_clock_core{local_system_clock_core_}, |
| 18 | network_system_clock_core{network_system_clock_core}, auto_correction_enabled{}, | 18 | network_system_clock_core{network_system_clock_core_}, |
| 19 | auto_correction_time{SteadyClockTimePoint::GetRandom()}, auto_correction_event{ | 19 | auto_correction_time{SteadyClockTimePoint::GetRandom()}, auto_correction_event{ |
| 20 | system.Kernel()} { | 20 | system_.Kernel()} { |
| 21 | Kernel::KAutoObject::Create(std::addressof(auto_correction_event)); | 21 | Kernel::KAutoObject::Create(std::addressof(auto_correction_event)); |
| 22 | auto_correction_event.Initialize("StandardUserSystemClockCore:AutoCorrectionEvent"); | 22 | auto_correction_event.Initialize("StandardUserSystemClockCore:AutoCorrectionEvent"); |
| 23 | } | 23 | } |
| @@ -35,13 +35,13 @@ ResultCode StandardUserSystemClockCore::SetAutomaticCorrectionEnabled(Core::Syst | |||
| 35 | } | 35 | } |
| 36 | 36 | ||
| 37 | ResultCode StandardUserSystemClockCore::GetClockContext(Core::System& system, | 37 | ResultCode StandardUserSystemClockCore::GetClockContext(Core::System& system, |
| 38 | SystemClockContext& context) const { | 38 | SystemClockContext& ctx) const { |
| 39 | if (const ResultCode result{ApplyAutomaticCorrection(system, false)}; | 39 | if (const ResultCode result{ApplyAutomaticCorrection(system, false)}; |
| 40 | result != RESULT_SUCCESS) { | 40 | result != RESULT_SUCCESS) { |
| 41 | return result; | 41 | return result; |
| 42 | } | 42 | } |
| 43 | 43 | ||
| 44 | return local_system_clock_core.GetClockContext(system, context); | 44 | return local_system_clock_core.GetClockContext(system, ctx); |
| 45 | } | 45 | } |
| 46 | 46 | ||
| 47 | ResultCode StandardUserSystemClockCore::Flush(const SystemClockContext&) { | 47 | ResultCode StandardUserSystemClockCore::Flush(const SystemClockContext&) { |
| @@ -64,13 +64,13 @@ ResultCode StandardUserSystemClockCore::ApplyAutomaticCorrection(Core::System& s | |||
| 64 | return ERROR_UNINITIALIZED_CLOCK; | 64 | return ERROR_UNINITIALIZED_CLOCK; |
| 65 | } | 65 | } |
| 66 | 66 | ||
| 67 | SystemClockContext context{}; | 67 | SystemClockContext ctx{}; |
| 68 | if (const ResultCode result{network_system_clock_core.GetClockContext(system, context)}; | 68 | if (const ResultCode result{network_system_clock_core.GetClockContext(system, ctx)}; |
| 69 | result != RESULT_SUCCESS) { | 69 | result != RESULT_SUCCESS) { |
| 70 | return result; | 70 | return result; |
| 71 | } | 71 | } |
| 72 | 72 | ||
| 73 | local_system_clock_core.SetClockContext(context); | 73 | local_system_clock_core.SetClockContext(ctx); |
| 74 | 74 | ||
| 75 | return RESULT_SUCCESS; | 75 | return RESULT_SUCCESS; |
| 76 | } | 76 | } |
diff --git a/src/core/hle/service/time/standard_user_system_clock_core.h b/src/core/hle/service/time/standard_user_system_clock_core.h index 1bff8a5af..bf9ec5e42 100644 --- a/src/core/hle/service/time/standard_user_system_clock_core.h +++ b/src/core/hle/service/time/standard_user_system_clock_core.h | |||
| @@ -23,13 +23,13 @@ class StandardNetworkSystemClockCore; | |||
| 23 | 23 | ||
| 24 | class StandardUserSystemClockCore final : public SystemClockCore { | 24 | class StandardUserSystemClockCore final : public SystemClockCore { |
| 25 | public: | 25 | public: |
| 26 | StandardUserSystemClockCore(StandardLocalSystemClockCore& local_system_clock_core, | 26 | StandardUserSystemClockCore(StandardLocalSystemClockCore& local_system_clock_core_, |
| 27 | StandardNetworkSystemClockCore& network_system_clock_core, | 27 | StandardNetworkSystemClockCore& network_system_clock_core_, |
| 28 | Core::System& system); | 28 | Core::System& system_); |
| 29 | 29 | ||
| 30 | ResultCode SetAutomaticCorrectionEnabled(Core::System& system, bool value); | 30 | ResultCode SetAutomaticCorrectionEnabled(Core::System& system, bool value); |
| 31 | 31 | ||
| 32 | ResultCode GetClockContext(Core::System& system, SystemClockContext& context) const override; | 32 | ResultCode GetClockContext(Core::System& system, SystemClockContext& ctx) const override; |
| 33 | 33 | ||
| 34 | bool IsAutomaticCorrectionEnabled() const { | 34 | bool IsAutomaticCorrectionEnabled() const { |
| 35 | return auto_correction_enabled; | 35 | return auto_correction_enabled; |
diff --git a/src/core/hle/service/time/system_clock_core.cpp b/src/core/hle/service/time/system_clock_core.cpp index 46fc8c6c3..2ef442b56 100644 --- a/src/core/hle/service/time/system_clock_core.cpp +++ b/src/core/hle/service/time/system_clock_core.cpp | |||
| @@ -8,8 +8,8 @@ | |||
| 8 | 8 | ||
| 9 | namespace Service::Time::Clock { | 9 | namespace Service::Time::Clock { |
| 10 | 10 | ||
| 11 | SystemClockCore::SystemClockCore(SteadyClockCore& steady_clock_core) | 11 | SystemClockCore::SystemClockCore(SteadyClockCore& steady_clock_core_) |
| 12 | : steady_clock_core{steady_clock_core} { | 12 | : steady_clock_core{steady_clock_core_} { |
| 13 | context.steady_time_point.clock_source_id = steady_clock_core.GetClockSourceId(); | 13 | context.steady_time_point.clock_source_id = steady_clock_core.GetClockSourceId(); |
| 14 | } | 14 | } |
| 15 | 15 | ||
diff --git a/src/core/hle/service/time/system_clock_core.h b/src/core/hle/service/time/system_clock_core.h index 82a8b79ff..b8e6122bf 100644 --- a/src/core/hle/service/time/system_clock_core.h +++ b/src/core/hle/service/time/system_clock_core.h | |||
| @@ -21,7 +21,7 @@ class SystemClockContextUpdateCallback; | |||
| 21 | 21 | ||
| 22 | class SystemClockCore { | 22 | class SystemClockCore { |
| 23 | public: | 23 | public: |
| 24 | explicit SystemClockCore(SteadyClockCore& steady_clock_core); | 24 | explicit SystemClockCore(SteadyClockCore& steady_clock_core_); |
| 25 | virtual ~SystemClockCore(); | 25 | virtual ~SystemClockCore(); |
| 26 | 26 | ||
| 27 | SteadyClockCore& GetSteadyClockCore() const { | 27 | SteadyClockCore& GetSteadyClockCore() const { |
diff --git a/src/core/hle/service/time/time_manager.cpp b/src/core/hle/service/time/time_manager.cpp index fe01a3739..4f9684de8 100644 --- a/src/core/hle/service/time/time_manager.cpp +++ b/src/core/hle/service/time/time_manager.cpp | |||
| @@ -223,7 +223,7 @@ struct TimeManager::Impl final { | |||
| 223 | TimeZone::TimeZoneContentManager time_zone_content_manager; | 223 | TimeZone::TimeZoneContentManager time_zone_content_manager; |
| 224 | }; | 224 | }; |
| 225 | 225 | ||
| 226 | TimeManager::TimeManager(Core::System& system) : system{system} {} | 226 | TimeManager::TimeManager(Core::System& system_) : system{system_} {} |
| 227 | 227 | ||
| 228 | TimeManager::~TimeManager() = default; | 228 | TimeManager::~TimeManager() = default; |
| 229 | 229 | ||
diff --git a/src/core/hle/service/time/time_manager.h b/src/core/hle/service/time/time_manager.h index 4db8cc0e1..3af868d87 100644 --- a/src/core/hle/service/time/time_manager.h +++ b/src/core/hle/service/time/time_manager.h | |||
| @@ -30,7 +30,7 @@ class NetworkSystemClockContextWriter; | |||
| 30 | 30 | ||
| 31 | class TimeManager final { | 31 | class TimeManager final { |
| 32 | public: | 32 | public: |
| 33 | explicit TimeManager(Core::System& system); | 33 | explicit TimeManager(Core::System& system_); |
| 34 | ~TimeManager(); | 34 | ~TimeManager(); |
| 35 | 35 | ||
| 36 | void Initialize(); | 36 | void Initialize(); |
diff --git a/src/core/hle/service/time/time_sharedmemory.cpp b/src/core/hle/service/time/time_sharedmemory.cpp index eb57899f6..176ad0eee 100644 --- a/src/core/hle/service/time/time_sharedmemory.cpp +++ b/src/core/hle/service/time/time_sharedmemory.cpp | |||
| @@ -15,7 +15,7 @@ namespace Service::Time { | |||
| 15 | 15 | ||
| 16 | static constexpr std::size_t SHARED_MEMORY_SIZE{0x1000}; | 16 | static constexpr std::size_t SHARED_MEMORY_SIZE{0x1000}; |
| 17 | 17 | ||
| 18 | SharedMemory::SharedMemory(Core::System& system) : system(system) { | 18 | SharedMemory::SharedMemory(Core::System& system_) : system(system_) { |
| 19 | std::memset(system.Kernel().GetTimeSharedMem().GetPointer(), 0, SHARED_MEMORY_SIZE); | 19 | std::memset(system.Kernel().GetTimeSharedMem().GetPointer(), 0, SHARED_MEMORY_SIZE); |
| 20 | } | 20 | } |
| 21 | 21 | ||
diff --git a/src/core/hle/service/time/time_sharedmemory.h b/src/core/hle/service/time/time_sharedmemory.h index 1ad9a286d..d471b5d18 100644 --- a/src/core/hle/service/time/time_sharedmemory.h +++ b/src/core/hle/service/time/time_sharedmemory.h | |||
| @@ -14,7 +14,7 @@ namespace Service::Time { | |||
| 14 | 14 | ||
| 15 | class SharedMemory final { | 15 | class SharedMemory final { |
| 16 | public: | 16 | public: |
| 17 | explicit SharedMemory(Core::System& system); | 17 | explicit SharedMemory(Core::System& system_); |
| 18 | ~SharedMemory(); | 18 | ~SharedMemory(); |
| 19 | 19 | ||
| 20 | // TODO(ogniK): We have to properly simulate memory barriers, how are we going to do this? | 20 | // TODO(ogniK): We have to properly simulate memory barriers, how are we going to do this? |
diff --git a/src/core/hle/service/time/time_zone_content_manager.cpp b/src/core/hle/service/time/time_zone_content_manager.cpp index 3c8e71a3c..57f71e6f0 100644 --- a/src/core/hle/service/time/time_zone_content_manager.cpp +++ b/src/core/hle/service/time/time_zone_content_manager.cpp | |||
| @@ -68,8 +68,8 @@ static std::vector<std::string> BuildLocationNameCache(Core::System& system) { | |||
| 68 | return location_name_cache; | 68 | return location_name_cache; |
| 69 | } | 69 | } |
| 70 | 70 | ||
| 71 | TimeZoneContentManager::TimeZoneContentManager(Core::System& system) | 71 | TimeZoneContentManager::TimeZoneContentManager(Core::System& system_) |
| 72 | : system{system}, location_name_cache{BuildLocationNameCache(system)} {} | 72 | : system{system_}, location_name_cache{BuildLocationNameCache(system)} {} |
| 73 | 73 | ||
| 74 | void TimeZoneContentManager::Initialize(TimeManager& time_manager) { | 74 | void TimeZoneContentManager::Initialize(TimeManager& time_manager) { |
| 75 | std::string location_name; | 75 | std::string location_name; |
diff --git a/src/core/hle/service/time/time_zone_content_manager.h b/src/core/hle/service/time/time_zone_content_manager.h index 52dd1a020..cfa601084 100644 --- a/src/core/hle/service/time/time_zone_content_manager.h +++ b/src/core/hle/service/time/time_zone_content_manager.h | |||
| @@ -21,7 +21,7 @@ namespace Service::Time::TimeZone { | |||
| 21 | 21 | ||
| 22 | class TimeZoneContentManager final { | 22 | class TimeZoneContentManager final { |
| 23 | public: | 23 | public: |
| 24 | explicit TimeZoneContentManager(Core::System& system); | 24 | explicit TimeZoneContentManager(Core::System& system_); |
| 25 | 25 | ||
| 26 | void Initialize(TimeManager& time_manager); | 26 | void Initialize(TimeManager& time_manager); |
| 27 | 27 | ||
diff --git a/src/core/hle/service/vi/display/vi_display.cpp b/src/core/hle/service/vi/display/vi_display.cpp index becbd36c1..0dd342dbf 100644 --- a/src/core/hle/service/vi/display/vi_display.cpp +++ b/src/core/hle/service/vi/display/vi_display.cpp | |||
| @@ -17,8 +17,8 @@ | |||
| 17 | 17 | ||
| 18 | namespace Service::VI { | 18 | namespace Service::VI { |
| 19 | 19 | ||
| 20 | Display::Display(u64 id, std::string name, Core::System& system) | 20 | Display::Display(u64 id, std::string name_, Core::System& system) |
| 21 | : id{id}, name{std::move(name)}, vsync_event{system.Kernel()} { | 21 | : display_id{id}, name{std::move(name_)}, vsync_event{system.Kernel()} { |
| 22 | Kernel::KAutoObject::Create(std::addressof(vsync_event)); | 22 | Kernel::KAutoObject::Create(std::addressof(vsync_event)); |
| 23 | vsync_event.Initialize(fmt::format("Display VSync Event {}", id)); | 23 | vsync_event.Initialize(fmt::format("Display VSync Event {}", id)); |
| 24 | } | 24 | } |
diff --git a/src/core/hle/service/vi/display/vi_display.h b/src/core/hle/service/vi/display/vi_display.h index 388ce6083..166f2a4cc 100644 --- a/src/core/hle/service/vi/display/vi_display.h +++ b/src/core/hle/service/vi/display/vi_display.h | |||
| @@ -32,14 +32,14 @@ public: | |||
| 32 | /// Constructs a display with a given unique ID and name. | 32 | /// Constructs a display with a given unique ID and name. |
| 33 | /// | 33 | /// |
| 34 | /// @param id The unique ID for this display. | 34 | /// @param id The unique ID for this display. |
| 35 | /// @param name The name for this display. | 35 | /// @param name_ The name for this display. |
| 36 | /// | 36 | /// |
| 37 | Display(u64 id, std::string name, Core::System& system); | 37 | Display(u64 id, std::string name_, Core::System& system); |
| 38 | ~Display(); | 38 | ~Display(); |
| 39 | 39 | ||
| 40 | /// Gets the unique ID assigned to this display. | 40 | /// Gets the unique ID assigned to this display. |
| 41 | u64 GetID() const { | 41 | u64 GetID() const { |
| 42 | return id; | 42 | return display_id; |
| 43 | } | 43 | } |
| 44 | 44 | ||
| 45 | /// Gets the name of this display | 45 | /// Gets the name of this display |
| @@ -96,7 +96,7 @@ public: | |||
| 96 | const Layer* FindLayer(u64 layer_id) const; | 96 | const Layer* FindLayer(u64 layer_id) const; |
| 97 | 97 | ||
| 98 | private: | 98 | private: |
| 99 | u64 id; | 99 | u64 display_id; |
| 100 | std::string name; | 100 | std::string name; |
| 101 | 101 | ||
| 102 | std::vector<std::shared_ptr<Layer>> layers; | 102 | std::vector<std::shared_ptr<Layer>> layers; |
diff --git a/src/core/hle/service/vi/layer/vi_layer.cpp b/src/core/hle/service/vi/layer/vi_layer.cpp index 954225c26..9bc382587 100644 --- a/src/core/hle/service/vi/layer/vi_layer.cpp +++ b/src/core/hle/service/vi/layer/vi_layer.cpp | |||
| @@ -6,7 +6,7 @@ | |||
| 6 | 6 | ||
| 7 | namespace Service::VI { | 7 | namespace Service::VI { |
| 8 | 8 | ||
| 9 | Layer::Layer(u64 id, NVFlinger::BufferQueue& queue) : id{id}, buffer_queue{queue} {} | 9 | Layer::Layer(u64 id, NVFlinger::BufferQueue& queue) : layer_id{id}, buffer_queue{queue} {} |
| 10 | 10 | ||
| 11 | Layer::~Layer() = default; | 11 | Layer::~Layer() = default; |
| 12 | 12 | ||
diff --git a/src/core/hle/service/vi/layer/vi_layer.h b/src/core/hle/service/vi/layer/vi_layer.h index c6bfd01f6..ebdd85505 100644 --- a/src/core/hle/service/vi/layer/vi_layer.h +++ b/src/core/hle/service/vi/layer/vi_layer.h | |||
| @@ -31,7 +31,7 @@ public: | |||
| 31 | 31 | ||
| 32 | /// Gets the ID for this layer. | 32 | /// Gets the ID for this layer. |
| 33 | u64 GetID() const { | 33 | u64 GetID() const { |
| 34 | return id; | 34 | return layer_id; |
| 35 | } | 35 | } |
| 36 | 36 | ||
| 37 | /// Gets a reference to the buffer queue this layer is using. | 37 | /// Gets a reference to the buffer queue this layer is using. |
| @@ -45,7 +45,7 @@ public: | |||
| 45 | } | 45 | } |
| 46 | 46 | ||
| 47 | private: | 47 | private: |
| 48 | u64 id; | 48 | u64 layer_id; |
| 49 | NVFlinger::BufferQueue& buffer_queue; | 49 | NVFlinger::BufferQueue& buffer_queue; |
| 50 | }; | 50 | }; |
| 51 | 51 | ||
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp index 32e47a43e..fdd2b4b4f 100644 --- a/src/core/hle/service/vi/vi.cpp +++ b/src/core/hle/service/vi/vi.cpp | |||
| @@ -212,7 +212,7 @@ private: | |||
| 212 | 212 | ||
| 213 | class IGBPConnectRequestParcel : public Parcel { | 213 | class IGBPConnectRequestParcel : public Parcel { |
| 214 | public: | 214 | public: |
| 215 | explicit IGBPConnectRequestParcel(std::vector<u8> buffer) : Parcel(std::move(buffer)) { | 215 | explicit IGBPConnectRequestParcel(std::vector<u8> buffer_) : Parcel(std::move(buffer_)) { |
| 216 | Deserialize(); | 216 | Deserialize(); |
| 217 | } | 217 | } |
| 218 | 218 | ||
| @@ -274,8 +274,8 @@ private: | |||
| 274 | 274 | ||
| 275 | class IGBPSetPreallocatedBufferRequestParcel : public Parcel { | 275 | class IGBPSetPreallocatedBufferRequestParcel : public Parcel { |
| 276 | public: | 276 | public: |
| 277 | explicit IGBPSetPreallocatedBufferRequestParcel(std::vector<u8> buffer) | 277 | explicit IGBPSetPreallocatedBufferRequestParcel(std::vector<u8> buffer_) |
| 278 | : Parcel(std::move(buffer)) { | 278 | : Parcel(std::move(buffer_)) { |
| 279 | Deserialize(); | 279 | Deserialize(); |
| 280 | } | 280 | } |
| 281 | 281 | ||
| @@ -312,7 +312,7 @@ protected: | |||
| 312 | 312 | ||
| 313 | class IGBPCancelBufferRequestParcel : public Parcel { | 313 | class IGBPCancelBufferRequestParcel : public Parcel { |
| 314 | public: | 314 | public: |
| 315 | explicit IGBPCancelBufferRequestParcel(std::vector<u8> buffer) : Parcel(std::move(buffer)) { | 315 | explicit IGBPCancelBufferRequestParcel(std::vector<u8> buffer_) : Parcel(std::move(buffer_)) { |
| 316 | Deserialize(); | 316 | Deserialize(); |
| 317 | } | 317 | } |
| 318 | 318 | ||
| @@ -338,7 +338,7 @@ protected: | |||
| 338 | 338 | ||
| 339 | class IGBPDequeueBufferRequestParcel : public Parcel { | 339 | class IGBPDequeueBufferRequestParcel : public Parcel { |
| 340 | public: | 340 | public: |
| 341 | explicit IGBPDequeueBufferRequestParcel(std::vector<u8> buffer) : Parcel(std::move(buffer)) { | 341 | explicit IGBPDequeueBufferRequestParcel(std::vector<u8> buffer_) : Parcel(std::move(buffer_)) { |
| 342 | Deserialize(); | 342 | Deserialize(); |
| 343 | } | 343 | } |
| 344 | 344 | ||
| @@ -360,8 +360,8 @@ public: | |||
| 360 | 360 | ||
| 361 | class IGBPDequeueBufferResponseParcel : public Parcel { | 361 | class IGBPDequeueBufferResponseParcel : public Parcel { |
| 362 | public: | 362 | public: |
| 363 | explicit IGBPDequeueBufferResponseParcel(u32 slot, Service::Nvidia::MultiFence& multi_fence) | 363 | explicit IGBPDequeueBufferResponseParcel(u32 slot_, Nvidia::MultiFence& multi_fence_) |
| 364 | : slot(slot), multi_fence(multi_fence) {} | 364 | : slot(slot_), multi_fence(multi_fence_) {} |
| 365 | 365 | ||
| 366 | protected: | 366 | protected: |
| 367 | void SerializeData() override { | 367 | void SerializeData() override { |
| @@ -377,7 +377,7 @@ protected: | |||
| 377 | 377 | ||
| 378 | class IGBPRequestBufferRequestParcel : public Parcel { | 378 | class IGBPRequestBufferRequestParcel : public Parcel { |
| 379 | public: | 379 | public: |
| 380 | explicit IGBPRequestBufferRequestParcel(std::vector<u8> buffer) : Parcel(std::move(buffer)) { | 380 | explicit IGBPRequestBufferRequestParcel(std::vector<u8> buffer_) : Parcel(std::move(buffer_)) { |
| 381 | Deserialize(); | 381 | Deserialize(); |
| 382 | } | 382 | } |
| 383 | 383 | ||
| @@ -391,7 +391,7 @@ public: | |||
| 391 | 391 | ||
| 392 | class IGBPRequestBufferResponseParcel : public Parcel { | 392 | class IGBPRequestBufferResponseParcel : public Parcel { |
| 393 | public: | 393 | public: |
| 394 | explicit IGBPRequestBufferResponseParcel(NVFlinger::IGBPBuffer buffer) : buffer(buffer) {} | 394 | explicit IGBPRequestBufferResponseParcel(NVFlinger::IGBPBuffer buffer_) : buffer(buffer_) {} |
| 395 | ~IGBPRequestBufferResponseParcel() override = default; | 395 | ~IGBPRequestBufferResponseParcel() override = default; |
| 396 | 396 | ||
| 397 | protected: | 397 | protected: |
| @@ -408,7 +408,7 @@ protected: | |||
| 408 | 408 | ||
| 409 | class IGBPQueueBufferRequestParcel : public Parcel { | 409 | class IGBPQueueBufferRequestParcel : public Parcel { |
| 410 | public: | 410 | public: |
| 411 | explicit IGBPQueueBufferRequestParcel(std::vector<u8> buffer) : Parcel(std::move(buffer)) { | 411 | explicit IGBPQueueBufferRequestParcel(std::vector<u8> buffer_) : Parcel(std::move(buffer_)) { |
| 412 | Deserialize(); | 412 | Deserialize(); |
| 413 | } | 413 | } |
| 414 | 414 | ||
| @@ -470,7 +470,7 @@ private: | |||
| 470 | 470 | ||
| 471 | class IGBPQueryRequestParcel : public Parcel { | 471 | class IGBPQueryRequestParcel : public Parcel { |
| 472 | public: | 472 | public: |
| 473 | explicit IGBPQueryRequestParcel(std::vector<u8> buffer) : Parcel(std::move(buffer)) { | 473 | explicit IGBPQueryRequestParcel(std::vector<u8> buffer_) : Parcel(std::move(buffer_)) { |
| 474 | Deserialize(); | 474 | Deserialize(); |
| 475 | } | 475 | } |
| 476 | 476 | ||
| @@ -484,7 +484,7 @@ public: | |||
| 484 | 484 | ||
| 485 | class IGBPQueryResponseParcel : public Parcel { | 485 | class IGBPQueryResponseParcel : public Parcel { |
| 486 | public: | 486 | public: |
| 487 | explicit IGBPQueryResponseParcel(u32 value) : value(value) {} | 487 | explicit IGBPQueryResponseParcel(u32 value_) : value{value_} {} |
| 488 | ~IGBPQueryResponseParcel() override = default; | 488 | ~IGBPQueryResponseParcel() override = default; |
| 489 | 489 | ||
| 490 | protected: | 490 | protected: |
diff --git a/src/core/loader/deconstructed_rom_directory.cpp b/src/core/loader/deconstructed_rom_directory.cpp index 42f023258..022885c1b 100644 --- a/src/core/loader/deconstructed_rom_directory.cpp +++ b/src/core/loader/deconstructed_rom_directory.cpp | |||
| @@ -22,8 +22,8 @@ | |||
| 22 | namespace Loader { | 22 | namespace Loader { |
| 23 | 23 | ||
| 24 | AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory(FileSys::VirtualFile file_, | 24 | AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory(FileSys::VirtualFile file_, |
| 25 | bool override_update) | 25 | bool override_update_) |
| 26 | : AppLoader(std::move(file_)), override_update(override_update) { | 26 | : AppLoader(std::move(file_)), override_update(override_update_) { |
| 27 | const auto file_dir = file->GetContainingDirectory(); | 27 | const auto file_dir = file->GetContainingDirectory(); |
| 28 | 28 | ||
| 29 | // Title ID | 29 | // Title ID |
| @@ -48,9 +48,9 @@ AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory(FileSys | |||
| 48 | // Any png, jpeg, or bmp file | 48 | // Any png, jpeg, or bmp file |
| 49 | const auto& files = file_dir->GetFiles(); | 49 | const auto& files = file_dir->GetFiles(); |
| 50 | const auto icon_iter = | 50 | const auto icon_iter = |
| 51 | std::find_if(files.begin(), files.end(), [](const FileSys::VirtualFile& file) { | 51 | std::find_if(files.begin(), files.end(), [](const FileSys::VirtualFile& f) { |
| 52 | return file->GetExtension() == "png" || file->GetExtension() == "jpg" || | 52 | return f->GetExtension() == "png" || f->GetExtension() == "jpg" || |
| 53 | file->GetExtension() == "bmp" || file->GetExtension() == "jpeg"; | 53 | f->GetExtension() == "bmp" || f->GetExtension() == "jpeg"; |
| 54 | }); | 54 | }); |
| 55 | if (icon_iter != files.end()) | 55 | if (icon_iter != files.end()) |
| 56 | icon_data = (*icon_iter)->ReadAllBytes(); | 56 | icon_data = (*icon_iter)->ReadAllBytes(); |
| @@ -61,9 +61,8 @@ AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory(FileSys | |||
| 61 | if (nacp_file == nullptr) { | 61 | if (nacp_file == nullptr) { |
| 62 | const auto& files = file_dir->GetFiles(); | 62 | const auto& files = file_dir->GetFiles(); |
| 63 | const auto nacp_iter = | 63 | const auto nacp_iter = |
| 64 | std::find_if(files.begin(), files.end(), [](const FileSys::VirtualFile& file) { | 64 | std::find_if(files.begin(), files.end(), |
| 65 | return file->GetExtension() == "nacp"; | 65 | [](const FileSys::VirtualFile& f) { return f->GetExtension() == "nacp"; }); |
| 66 | }); | ||
| 67 | if (nacp_iter != files.end()) | 66 | if (nacp_iter != files.end()) |
| 68 | nacp_file = *nacp_iter; | 67 | nacp_file = *nacp_iter; |
| 69 | } | 68 | } |
| @@ -75,9 +74,9 @@ AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory(FileSys | |||
| 75 | } | 74 | } |
| 76 | 75 | ||
| 77 | AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory( | 76 | AppLoader_DeconstructedRomDirectory::AppLoader_DeconstructedRomDirectory( |
| 78 | FileSys::VirtualDir directory, bool override_update) | 77 | FileSys::VirtualDir directory, bool override_update_) |
| 79 | : AppLoader(directory->GetFile("main")), dir(std::move(directory)), | 78 | : AppLoader(directory->GetFile("main")), dir(std::move(directory)), |
| 80 | override_update(override_update) {} | 79 | override_update(override_update_) {} |
| 81 | 80 | ||
| 82 | FileType AppLoader_DeconstructedRomDirectory::IdentifyType(const FileSys::VirtualFile& dir_file) { | 81 | FileType AppLoader_DeconstructedRomDirectory::IdentifyType(const FileSys::VirtualFile& dir_file) { |
| 83 | if (FileSys::IsDirectoryExeFS(dir_file->GetContainingDirectory())) { | 82 | if (FileSys::IsDirectoryExeFS(dir_file->GetContainingDirectory())) { |
| @@ -184,8 +183,8 @@ AppLoader_DeconstructedRomDirectory::LoadResult AppLoader_DeconstructedRomDirect | |||
| 184 | // Find the RomFS by searching for a ".romfs" file in this directory | 183 | // Find the RomFS by searching for a ".romfs" file in this directory |
| 185 | const auto& files = dir->GetFiles(); | 184 | const auto& files = dir->GetFiles(); |
| 186 | const auto romfs_iter = | 185 | const auto romfs_iter = |
| 187 | std::find_if(files.begin(), files.end(), [](const FileSys::VirtualFile& file) { | 186 | std::find_if(files.begin(), files.end(), [](const FileSys::VirtualFile& f) { |
| 188 | return file->GetName().find(".romfs") != std::string::npos; | 187 | return f->GetName().find(".romfs") != std::string::npos; |
| 189 | }); | 188 | }); |
| 190 | 189 | ||
| 191 | // Register the RomFS if a ".romfs" file was found | 190 | // Register the RomFS if a ".romfs" file was found |
diff --git a/src/core/loader/deconstructed_rom_directory.h b/src/core/loader/deconstructed_rom_directory.h index a49a8b001..79a4d4db5 100644 --- a/src/core/loader/deconstructed_rom_directory.h +++ b/src/core/loader/deconstructed_rom_directory.h | |||
| @@ -24,11 +24,11 @@ namespace Loader { | |||
| 24 | class AppLoader_DeconstructedRomDirectory final : public AppLoader { | 24 | class AppLoader_DeconstructedRomDirectory final : public AppLoader { |
| 25 | public: | 25 | public: |
| 26 | explicit AppLoader_DeconstructedRomDirectory(FileSys::VirtualFile main_file, | 26 | explicit AppLoader_DeconstructedRomDirectory(FileSys::VirtualFile main_file, |
| 27 | bool override_update = false); | 27 | bool override_update_ = false); |
| 28 | 28 | ||
| 29 | // Overload to accept exefs directory. Must contain 'main' and 'main.npdm' | 29 | // Overload to accept exefs directory. Must contain 'main' and 'main.npdm' |
| 30 | explicit AppLoader_DeconstructedRomDirectory(FileSys::VirtualDir directory, | 30 | explicit AppLoader_DeconstructedRomDirectory(FileSys::VirtualDir directory, |
| 31 | bool override_update = false); | 31 | bool override_update_ = false); |
| 32 | 32 | ||
| 33 | /** | 33 | /** |
| 34 | * Identifies whether or not the given file is a deconstructed ROM directory. | 34 | * Identifies whether or not the given file is a deconstructed ROM directory. |
diff --git a/src/core/loader/loader.cpp b/src/core/loader/loader.cpp index 11b2d0837..d4808fb5b 100644 --- a/src/core/loader/loader.cpp +++ b/src/core/loader/loader.cpp | |||
| @@ -194,7 +194,7 @@ std::ostream& operator<<(std::ostream& os, ResultStatus status) { | |||
| 194 | return os; | 194 | return os; |
| 195 | } | 195 | } |
| 196 | 196 | ||
| 197 | AppLoader::AppLoader(FileSys::VirtualFile file) : file(std::move(file)) {} | 197 | AppLoader::AppLoader(FileSys::VirtualFile file_) : file(std::move(file_)) {} |
| 198 | AppLoader::~AppLoader() = default; | 198 | AppLoader::~AppLoader() = default; |
| 199 | 199 | ||
| 200 | /** | 200 | /** |
diff --git a/src/core/loader/loader.h b/src/core/loader/loader.h index 9eac11dec..edc8bb257 100644 --- a/src/core/loader/loader.h +++ b/src/core/loader/loader.h | |||
| @@ -147,7 +147,7 @@ public: | |||
| 147 | }; | 147 | }; |
| 148 | using LoadResult = std::pair<ResultStatus, std::optional<LoadParameters>>; | 148 | using LoadResult = std::pair<ResultStatus, std::optional<LoadParameters>>; |
| 149 | 149 | ||
| 150 | explicit AppLoader(FileSys::VirtualFile file); | 150 | explicit AppLoader(FileSys::VirtualFile file_); |
| 151 | virtual ~AppLoader(); | 151 | virtual ~AppLoader(); |
| 152 | 152 | ||
| 153 | /** | 153 | /** |
diff --git a/src/core/memory/cheat_engine.cpp b/src/core/memory/cheat_engine.cpp index 0f5ef7954..46a7e09b4 100644 --- a/src/core/memory/cheat_engine.cpp +++ b/src/core/memory/cheat_engine.cpp | |||
| @@ -37,8 +37,8 @@ std::string_view ExtractName(std::string_view data, std::size_t start_index, cha | |||
| 37 | } | 37 | } |
| 38 | } // Anonymous namespace | 38 | } // Anonymous namespace |
| 39 | 39 | ||
| 40 | StandardVmCallbacks::StandardVmCallbacks(Core::System& system, const CheatProcessMetadata& metadata) | 40 | StandardVmCallbacks::StandardVmCallbacks(System& system_, const CheatProcessMetadata& metadata_) |
| 41 | : metadata(metadata), system(system) {} | 41 | : metadata{metadata_}, system{system_} {} |
| 42 | 42 | ||
| 43 | StandardVmCallbacks::~StandardVmCallbacks() = default; | 43 | StandardVmCallbacks::~StandardVmCallbacks() = default; |
| 44 | 44 | ||
| @@ -174,11 +174,11 @@ std::vector<CheatEntry> TextCheatParser::Parse(std::string_view data) const { | |||
| 174 | return out; | 174 | return out; |
| 175 | } | 175 | } |
| 176 | 176 | ||
| 177 | CheatEngine::CheatEngine(Core::System& system, std::vector<CheatEntry> cheats, | 177 | CheatEngine::CheatEngine(System& system_, std::vector<CheatEntry> cheats_, |
| 178 | const std::array<u8, 0x20>& build_id) | 178 | const std::array<u8, 0x20>& build_id_) |
| 179 | : vm{std::make_unique<StandardVmCallbacks>(system, metadata)}, | 179 | : vm{std::make_unique<StandardVmCallbacks>(system_, metadata)}, |
| 180 | cheats(std::move(cheats)), core_timing{system.CoreTiming()}, system{system} { | 180 | cheats(std::move(cheats_)), core_timing{system_.CoreTiming()}, system{system_} { |
| 181 | metadata.main_nso_build_id = build_id; | 181 | metadata.main_nso_build_id = build_id_; |
| 182 | } | 182 | } |
| 183 | 183 | ||
| 184 | CheatEngine::~CheatEngine() { | 184 | CheatEngine::~CheatEngine() { |
diff --git a/src/core/memory/cheat_engine.h b/src/core/memory/cheat_engine.h index 5e6f901ec..a8e041d9d 100644 --- a/src/core/memory/cheat_engine.h +++ b/src/core/memory/cheat_engine.h | |||
| @@ -25,7 +25,7 @@ namespace Core::Memory { | |||
| 25 | 25 | ||
| 26 | class StandardVmCallbacks : public DmntCheatVm::Callbacks { | 26 | class StandardVmCallbacks : public DmntCheatVm::Callbacks { |
| 27 | public: | 27 | public: |
| 28 | StandardVmCallbacks(Core::System& system, const CheatProcessMetadata& metadata); | 28 | StandardVmCallbacks(System& system_, const CheatProcessMetadata& metadata_); |
| 29 | ~StandardVmCallbacks() override; | 29 | ~StandardVmCallbacks() override; |
| 30 | 30 | ||
| 31 | void MemoryRead(VAddr address, void* data, u64 size) override; | 31 | void MemoryRead(VAddr address, void* data, u64 size) override; |
| @@ -38,7 +38,7 @@ private: | |||
| 38 | VAddr SanitizeAddress(VAddr address) const; | 38 | VAddr SanitizeAddress(VAddr address) const; |
| 39 | 39 | ||
| 40 | const CheatProcessMetadata& metadata; | 40 | const CheatProcessMetadata& metadata; |
| 41 | Core::System& system; | 41 | System& system; |
| 42 | }; | 42 | }; |
| 43 | 43 | ||
| 44 | // Intermediary class that parses a text file or other disk format for storing cheats into a | 44 | // Intermediary class that parses a text file or other disk format for storing cheats into a |
| @@ -61,8 +61,8 @@ public: | |||
| 61 | // Class that encapsulates a CheatList and manages its interaction with memory and CoreTiming | 61 | // Class that encapsulates a CheatList and manages its interaction with memory and CoreTiming |
| 62 | class CheatEngine final { | 62 | class CheatEngine final { |
| 63 | public: | 63 | public: |
| 64 | CheatEngine(Core::System& system_, std::vector<CheatEntry> cheats_, | 64 | CheatEngine(System& system_, std::vector<CheatEntry> cheats_, |
| 65 | const std::array<u8, 0x20>& build_id); | 65 | const std::array<u8, 0x20>& build_id_); |
| 66 | ~CheatEngine(); | 66 | ~CheatEngine(); |
| 67 | 67 | ||
| 68 | void Initialize(); | 68 | void Initialize(); |
diff --git a/src/core/memory/dmnt_cheat_vm.cpp b/src/core/memory/dmnt_cheat_vm.cpp index 48be80c12..dc04e37d2 100644 --- a/src/core/memory/dmnt_cheat_vm.cpp +++ b/src/core/memory/dmnt_cheat_vm.cpp | |||
| @@ -29,7 +29,8 @@ | |||
| 29 | 29 | ||
| 30 | namespace Core::Memory { | 30 | namespace Core::Memory { |
| 31 | 31 | ||
| 32 | DmntCheatVm::DmntCheatVm(std::unique_ptr<Callbacks> callbacks) : callbacks(std::move(callbacks)) {} | 32 | DmntCheatVm::DmntCheatVm(std::unique_ptr<Callbacks> callbacks_) |
| 33 | : callbacks(std::move(callbacks_)) {} | ||
| 33 | 34 | ||
| 34 | DmntCheatVm::~DmntCheatVm() = default; | 35 | DmntCheatVm::~DmntCheatVm() = default; |
| 35 | 36 | ||
diff --git a/src/core/memory/dmnt_cheat_vm.h b/src/core/memory/dmnt_cheat_vm.h index 21b86b72c..707bee82b 100644 --- a/src/core/memory/dmnt_cheat_vm.h +++ b/src/core/memory/dmnt_cheat_vm.h | |||
| @@ -293,7 +293,7 @@ public: | |||
| 293 | static constexpr std::size_t NumStaticRegisters = | 293 | static constexpr std::size_t NumStaticRegisters = |
| 294 | NumReadableStaticRegisters + NumWritableStaticRegisters; | 294 | NumReadableStaticRegisters + NumWritableStaticRegisters; |
| 295 | 295 | ||
| 296 | explicit DmntCheatVm(std::unique_ptr<Callbacks> callbacks); | 296 | explicit DmntCheatVm(std::unique_ptr<Callbacks> callbacks_); |
| 297 | ~DmntCheatVm(); | 297 | ~DmntCheatVm(); |
| 298 | 298 | ||
| 299 | std::size_t GetProgramSize() const { | 299 | std::size_t GetProgramSize() const { |
diff --git a/src/core/perf_stats.cpp b/src/core/perf_stats.cpp index c92337079..b185a3884 100644 --- a/src/core/perf_stats.cpp +++ b/src/core/perf_stats.cpp | |||
| @@ -27,7 +27,7 @@ constexpr std::size_t IgnoreFrames = 5; | |||
| 27 | 27 | ||
| 28 | namespace Core { | 28 | namespace Core { |
| 29 | 29 | ||
| 30 | PerfStats::PerfStats(u64 title_id) : title_id(title_id) {} | 30 | PerfStats::PerfStats(u64 title_id_) : title_id(title_id_) {} |
| 31 | 31 | ||
| 32 | PerfStats::~PerfStats() { | 32 | PerfStats::~PerfStats() { |
| 33 | if (!Settings::values.record_frame_times || title_id == 0) { | 33 | if (!Settings::values.record_frame_times || title_id == 0) { |
diff --git a/src/core/perf_stats.h b/src/core/perf_stats.h index 69256b960..ae4698696 100644 --- a/src/core/perf_stats.h +++ b/src/core/perf_stats.h | |||
| @@ -29,7 +29,7 @@ struct PerfStatsResults { | |||
| 29 | */ | 29 | */ |
| 30 | class PerfStats { | 30 | class PerfStats { |
| 31 | public: | 31 | public: |
| 32 | explicit PerfStats(u64 title_id); | 32 | explicit PerfStats(u64 title_id_); |
| 33 | ~PerfStats(); | 33 | ~PerfStats(); |
| 34 | 34 | ||
| 35 | using Clock = std::chrono::high_resolution_clock; | 35 | using Clock = std::chrono::high_resolution_clock; |
diff --git a/src/core/reporter.cpp b/src/core/reporter.cpp index 896add892..d1e807dd4 100644 --- a/src/core/reporter.cpp +++ b/src/core/reporter.cpp | |||
| @@ -192,7 +192,7 @@ json GetHLERequestContextData(Kernel::HLERequestContext& ctx, Core::Memory::Memo | |||
| 192 | 192 | ||
| 193 | namespace Core { | 193 | namespace Core { |
| 194 | 194 | ||
| 195 | Reporter::Reporter(System& system) : system(system) {} | 195 | Reporter::Reporter(System& system_) : system(system_) {} |
| 196 | 196 | ||
| 197 | Reporter::~Reporter() = default; | 197 | Reporter::~Reporter() = default; |
| 198 | 198 | ||
diff --git a/src/core/reporter.h b/src/core/reporter.h index b2c2d9a2e..6fb6ebffa 100644 --- a/src/core/reporter.h +++ b/src/core/reporter.h | |||
| @@ -30,7 +30,7 @@ class System; | |||
| 30 | 30 | ||
| 31 | class Reporter { | 31 | class Reporter { |
| 32 | public: | 32 | public: |
| 33 | explicit Reporter(System& system); | 33 | explicit Reporter(System& system_); |
| 34 | ~Reporter(); | 34 | ~Reporter(); |
| 35 | 35 | ||
| 36 | // Used by fatal services | 36 | // Used by fatal services |
diff --git a/src/input_common/main.cpp b/src/input_common/main.cpp index 7c4e7dd3b..7399c3648 100644 --- a/src/input_common/main.cpp +++ b/src/input_common/main.cpp | |||
| @@ -153,6 +153,11 @@ struct InputSubsystem::Impl { | |||
| 153 | // TODO return the correct motion device | 153 | // TODO return the correct motion device |
| 154 | return {}; | 154 | return {}; |
| 155 | } | 155 | } |
| 156 | #ifdef HAVE_SDL2 | ||
| 157 | if (params.Get("class", "") == "sdl") { | ||
| 158 | return sdl->GetMotionMappingForDevice(params); | ||
| 159 | } | ||
| 160 | #endif | ||
| 156 | return {}; | 161 | return {}; |
| 157 | } | 162 | } |
| 158 | 163 | ||
diff --git a/src/input_common/sdl/sdl.h b/src/input_common/sdl/sdl.h index 42bbf14d4..b5d41bba4 100644 --- a/src/input_common/sdl/sdl.h +++ b/src/input_common/sdl/sdl.h | |||
| @@ -37,6 +37,9 @@ public: | |||
| 37 | virtual AnalogMapping GetAnalogMappingForDevice(const Common::ParamPackage&) { | 37 | virtual AnalogMapping GetAnalogMappingForDevice(const Common::ParamPackage&) { |
| 38 | return {}; | 38 | return {}; |
| 39 | } | 39 | } |
| 40 | virtual MotionMapping GetMotionMappingForDevice(const Common::ParamPackage&) { | ||
| 41 | return {}; | ||
| 42 | } | ||
| 40 | }; | 43 | }; |
| 41 | 44 | ||
| 42 | class NullState : public State { | 45 | class NullState : public State { |
diff --git a/src/input_common/sdl/sdl_impl.cpp b/src/input_common/sdl/sdl_impl.cpp index f682a6db4..822d0b555 100644 --- a/src/input_common/sdl/sdl_impl.cpp +++ b/src/input_common/sdl/sdl_impl.cpp | |||
| @@ -29,6 +29,7 @@ | |||
| 29 | #endif | 29 | #endif |
| 30 | 30 | ||
| 31 | #include "common/logging/log.h" | 31 | #include "common/logging/log.h" |
| 32 | #include "common/math_util.h" | ||
| 32 | #include "common/param_package.h" | 33 | #include "common/param_package.h" |
| 33 | #include "common/settings_input.h" | 34 | #include "common/settings_input.h" |
| 34 | #include "common/threadsafe_queue.h" | 35 | #include "common/threadsafe_queue.h" |
| @@ -68,13 +69,57 @@ public: | |||
| 68 | SDLJoystick(std::string guid_, int port_, SDL_Joystick* joystick, | 69 | SDLJoystick(std::string guid_, int port_, SDL_Joystick* joystick, |
| 69 | SDL_GameController* game_controller) | 70 | SDL_GameController* game_controller) |
| 70 | : guid{std::move(guid_)}, port{port_}, sdl_joystick{joystick, &SDL_JoystickClose}, | 71 | : guid{std::move(guid_)}, port{port_}, sdl_joystick{joystick, &SDL_JoystickClose}, |
| 71 | sdl_controller{game_controller, &SDL_GameControllerClose} {} | 72 | sdl_controller{game_controller, &SDL_GameControllerClose} { |
| 73 | EnableMotion(); | ||
| 74 | } | ||
| 75 | |||
| 76 | void EnableMotion() { | ||
| 77 | if (sdl_controller) { | ||
| 78 | SDL_GameController* controller = sdl_controller.get(); | ||
| 79 | if (SDL_GameControllerHasSensor(controller, SDL_SENSOR_ACCEL) && !has_accel) { | ||
| 80 | SDL_GameControllerSetSensorEnabled(controller, SDL_SENSOR_ACCEL, SDL_TRUE); | ||
| 81 | has_accel = true; | ||
| 82 | } | ||
| 83 | if (SDL_GameControllerHasSensor(controller, SDL_SENSOR_GYRO) && !has_gyro) { | ||
| 84 | SDL_GameControllerSetSensorEnabled(controller, SDL_SENSOR_GYRO, SDL_TRUE); | ||
| 85 | has_gyro = true; | ||
| 86 | } | ||
| 87 | } | ||
| 88 | } | ||
| 72 | 89 | ||
| 73 | void SetButton(int button, bool value) { | 90 | void SetButton(int button, bool value) { |
| 74 | std::lock_guard lock{mutex}; | 91 | std::lock_guard lock{mutex}; |
| 75 | state.buttons.insert_or_assign(button, value); | 92 | state.buttons.insert_or_assign(button, value); |
| 76 | } | 93 | } |
| 77 | 94 | ||
| 95 | void SetMotion(SDL_ControllerSensorEvent event) { | ||
| 96 | constexpr float gravity_constant = 9.80665f; | ||
| 97 | std::lock_guard lock{mutex}; | ||
| 98 | u64 time_difference = event.timestamp - last_motion_update; | ||
| 99 | last_motion_update = event.timestamp; | ||
| 100 | switch (event.sensor) { | ||
| 101 | case SDL_SENSOR_ACCEL: { | ||
| 102 | const Common::Vec3f acceleration = {-event.data[0], event.data[2], -event.data[1]}; | ||
| 103 | motion.SetAcceleration(acceleration / gravity_constant); | ||
| 104 | break; | ||
| 105 | } | ||
| 106 | case SDL_SENSOR_GYRO: { | ||
| 107 | const Common::Vec3f gyroscope = {event.data[0], -event.data[2], event.data[1]}; | ||
| 108 | motion.SetGyroscope(gyroscope / (Common::PI * 2)); | ||
| 109 | break; | ||
| 110 | } | ||
| 111 | } | ||
| 112 | |||
| 113 | // Ignore duplicated timestamps | ||
| 114 | if (time_difference == 0) { | ||
| 115 | return; | ||
| 116 | } | ||
| 117 | |||
| 118 | motion.SetGyroThreshold(0.0001f); | ||
| 119 | motion.UpdateRotation(time_difference * 1000); | ||
| 120 | motion.UpdateOrientation(time_difference * 1000); | ||
| 121 | } | ||
| 122 | |||
| 78 | bool GetButton(int button) const { | 123 | bool GetButton(int button) const { |
| 79 | std::lock_guard lock{mutex}; | 124 | std::lock_guard lock{mutex}; |
| 80 | return state.buttons.at(button); | 125 | return state.buttons.at(button); |
| @@ -121,6 +166,14 @@ public: | |||
| 121 | return std::make_tuple(x, y); | 166 | return std::make_tuple(x, y); |
| 122 | } | 167 | } |
| 123 | 168 | ||
| 169 | bool HasGyro() const { | ||
| 170 | return has_gyro; | ||
| 171 | } | ||
| 172 | |||
| 173 | bool HasAccel() const { | ||
| 174 | return has_accel; | ||
| 175 | } | ||
| 176 | |||
| 124 | const MotionInput& GetMotion() const { | 177 | const MotionInput& GetMotion() const { |
| 125 | return motion; | 178 | return motion; |
| 126 | } | 179 | } |
| @@ -173,8 +226,11 @@ private: | |||
| 173 | std::unique_ptr<SDL_GameController, decltype(&SDL_GameControllerClose)> sdl_controller; | 226 | std::unique_ptr<SDL_GameController, decltype(&SDL_GameControllerClose)> sdl_controller; |
| 174 | mutable std::mutex mutex; | 227 | mutable std::mutex mutex; |
| 175 | 228 | ||
| 176 | // Motion is initialized without PID values as motion input is not aviable for SDL2 | 229 | // Motion is initialized with the PID values |
| 177 | MotionInput motion{0.0f, 0.0f, 0.0f}; | 230 | MotionInput motion{0.3f, 0.005f, 0.0f}; |
| 231 | u64 last_motion_update{}; | ||
| 232 | bool has_gyro{false}; | ||
| 233 | bool has_accel{false}; | ||
| 178 | }; | 234 | }; |
| 179 | 235 | ||
| 180 | std::shared_ptr<SDLJoystick> SDLState::GetSDLJoystickByGUID(const std::string& guid, int port) { | 236 | std::shared_ptr<SDLJoystick> SDLState::GetSDLJoystickByGUID(const std::string& guid, int port) { |
| @@ -296,6 +352,12 @@ void SDLState::HandleGameControllerEvent(const SDL_Event& event) { | |||
| 296 | } | 352 | } |
| 297 | break; | 353 | break; |
| 298 | } | 354 | } |
| 355 | case SDL_CONTROLLERSENSORUPDATE: { | ||
| 356 | if (auto joystick = GetSDLJoystickBySDLID(event.csensor.which)) { | ||
| 357 | joystick->SetMotion(event.csensor); | ||
| 358 | } | ||
| 359 | break; | ||
| 360 | } | ||
| 299 | case SDL_JOYDEVICEREMOVED: | 361 | case SDL_JOYDEVICEREMOVED: |
| 300 | LOG_DEBUG(Input, "Controller removed with Instance_ID {}", event.jdevice.which); | 362 | LOG_DEBUG(Input, "Controller removed with Instance_ID {}", event.jdevice.which); |
| 301 | CloseJoystick(SDL_JoystickFromInstanceID(event.jdevice.which)); | 363 | CloseJoystick(SDL_JoystickFromInstanceID(event.jdevice.which)); |
| @@ -449,6 +511,18 @@ private: | |||
| 449 | std::shared_ptr<SDLJoystick> joystick; | 511 | std::shared_ptr<SDLJoystick> joystick; |
| 450 | }; | 512 | }; |
| 451 | 513 | ||
| 514 | class SDLMotion final : public Input::MotionDevice { | ||
| 515 | public: | ||
| 516 | explicit SDLMotion(std::shared_ptr<SDLJoystick> joystick_) : joystick(std::move(joystick_)) {} | ||
| 517 | |||
| 518 | Input::MotionStatus GetStatus() const override { | ||
| 519 | return joystick->GetMotion().GetMotion(); | ||
| 520 | } | ||
| 521 | |||
| 522 | private: | ||
| 523 | std::shared_ptr<SDLJoystick> joystick; | ||
| 524 | }; | ||
| 525 | |||
| 452 | class SDLDirectionMotion final : public Input::MotionDevice { | 526 | class SDLDirectionMotion final : public Input::MotionDevice { |
| 453 | public: | 527 | public: |
| 454 | explicit SDLDirectionMotion(std::shared_ptr<SDLJoystick> joystick_, int hat_, Uint8 direction_) | 528 | explicit SDLDirectionMotion(std::shared_ptr<SDLJoystick> joystick_, int hat_, Uint8 direction_) |
| @@ -658,6 +732,10 @@ public: | |||
| 658 | 732 | ||
| 659 | auto joystick = state.GetSDLJoystickByGUID(guid, port); | 733 | auto joystick = state.GetSDLJoystickByGUID(guid, port); |
| 660 | 734 | ||
| 735 | if (params.Has("motion")) { | ||
| 736 | return std::make_unique<SDLMotion>(joystick); | ||
| 737 | } | ||
| 738 | |||
| 661 | if (params.Has("hat")) { | 739 | if (params.Has("hat")) { |
| 662 | const int hat = params.Get("hat", 0); | 740 | const int hat = params.Get("hat", 0); |
| 663 | const std::string direction_name = params.Get("direction", ""); | 741 | const std::string direction_name = params.Get("direction", ""); |
| @@ -717,6 +795,17 @@ SDLState::SDLState() { | |||
| 717 | RegisterFactory<VibrationDevice>("sdl", vibration_factory); | 795 | RegisterFactory<VibrationDevice>("sdl", vibration_factory); |
| 718 | RegisterFactory<MotionDevice>("sdl", motion_factory); | 796 | RegisterFactory<MotionDevice>("sdl", motion_factory); |
| 719 | 797 | ||
| 798 | // Enable HIDAPI rumble. This prevents SDL from disabling motion on PS4 and PS5 controllers | ||
| 799 | SDL_SetHint(SDL_HINT_JOYSTICK_HIDAPI_PS4_RUMBLE, "1"); | ||
| 800 | SDL_SetHint(SDL_HINT_JOYSTICK_HIDAPI_PS5_RUMBLE, "1"); | ||
| 801 | |||
| 802 | // Tell SDL2 to use the hidapi driver. This will allow joycons to be detected as a | ||
| 803 | // GameController and not a generic one | ||
| 804 | SDL_SetHint("SDL_JOYSTICK_HIDAPI_JOY_CONS", "1"); | ||
| 805 | |||
| 806 | // Turn off Pro controller home led | ||
| 807 | SDL_SetHint("SDL_JOYSTICK_HIDAPI_SWITCH_HOME_LED", "0"); | ||
| 808 | |||
| 720 | // If the frontend is going to manage the event loop, then we don't start one here | 809 | // If the frontend is going to manage the event loop, then we don't start one here |
| 721 | start_thread = SDL_WasInit(SDL_INIT_JOYSTICK) == 0; | 810 | start_thread = SDL_WasInit(SDL_INIT_JOYSTICK) == 0; |
| 722 | if (start_thread && SDL_Init(SDL_INIT_JOYSTICK) < 0) { | 811 | if (start_thread && SDL_Init(SDL_INIT_JOYSTICK) < 0) { |
| @@ -853,6 +942,13 @@ Common::ParamPackage BuildHatParamPackageForButton(int port, std::string guid, s | |||
| 853 | return params; | 942 | return params; |
| 854 | } | 943 | } |
| 855 | 944 | ||
| 945 | Common::ParamPackage BuildMotionParam(int port, std::string guid) { | ||
| 946 | Common::ParamPackage params({{"engine", "sdl"}, {"motion", "0"}}); | ||
| 947 | params.Set("port", port); | ||
| 948 | params.Set("guid", std::move(guid)); | ||
| 949 | return params; | ||
| 950 | } | ||
| 951 | |||
| 856 | Common::ParamPackage SDLEventToButtonParamPackage(SDLState& state, const SDL_Event& event) { | 952 | Common::ParamPackage SDLEventToButtonParamPackage(SDLState& state, const SDL_Event& event) { |
| 857 | switch (event.type) { | 953 | switch (event.type) { |
| 858 | case SDL_JOYAXISMOTION: { | 954 | case SDL_JOYAXISMOTION: { |
| @@ -907,6 +1003,35 @@ Common::ParamPackage SDLEventToMotionParamPackage(SDLState& state, const SDL_Eve | |||
| 907 | } | 1003 | } |
| 908 | break; | 1004 | break; |
| 909 | } | 1005 | } |
| 1006 | case SDL_CONTROLLERSENSORUPDATE: { | ||
| 1007 | bool is_motion_shaking = false; | ||
| 1008 | constexpr float gyro_threshold = 5.0f; | ||
| 1009 | constexpr float accel_threshold = 11.0f; | ||
| 1010 | if (event.csensor.sensor == SDL_SENSOR_ACCEL) { | ||
| 1011 | const Common::Vec3f acceleration = {-event.csensor.data[0], event.csensor.data[2], | ||
| 1012 | -event.csensor.data[1]}; | ||
| 1013 | if (acceleration.Length() > accel_threshold) { | ||
| 1014 | is_motion_shaking = true; | ||
| 1015 | } | ||
| 1016 | } | ||
| 1017 | |||
| 1018 | if (event.csensor.sensor == SDL_SENSOR_GYRO) { | ||
| 1019 | const Common::Vec3f gyroscope = {event.csensor.data[0], -event.csensor.data[2], | ||
| 1020 | event.csensor.data[1]}; | ||
| 1021 | if (gyroscope.Length() > gyro_threshold) { | ||
| 1022 | is_motion_shaking = true; | ||
| 1023 | } | ||
| 1024 | } | ||
| 1025 | |||
| 1026 | if (!is_motion_shaking) { | ||
| 1027 | break; | ||
| 1028 | } | ||
| 1029 | |||
| 1030 | if (const auto joystick = state.GetSDLJoystickBySDLID(event.csensor.which)) { | ||
| 1031 | return BuildMotionParam(joystick->GetPort(), joystick->GetGUID()); | ||
| 1032 | } | ||
| 1033 | break; | ||
| 1034 | } | ||
| 910 | } | 1035 | } |
| 911 | return {}; | 1036 | return {}; |
| 912 | } | 1037 | } |
| @@ -1036,6 +1161,27 @@ AnalogMapping SDLState::GetAnalogMappingForDevice(const Common::ParamPackage& pa | |||
| 1036 | return mapping; | 1161 | return mapping; |
| 1037 | } | 1162 | } |
| 1038 | 1163 | ||
| 1164 | MotionMapping SDLState::GetMotionMappingForDevice(const Common::ParamPackage& params) { | ||
| 1165 | if (!params.Has("guid") || !params.Has("port")) { | ||
| 1166 | return {}; | ||
| 1167 | } | ||
| 1168 | const auto joystick = GetSDLJoystickByGUID(params.Get("guid", ""), params.Get("port", 0)); | ||
| 1169 | auto* controller = joystick->GetSDLGameController(); | ||
| 1170 | if (controller == nullptr) { | ||
| 1171 | return {}; | ||
| 1172 | } | ||
| 1173 | |||
| 1174 | joystick->EnableMotion(); | ||
| 1175 | |||
| 1176 | if (!joystick->HasGyro() && !joystick->HasAccel()) { | ||
| 1177 | return {}; | ||
| 1178 | } | ||
| 1179 | |||
| 1180 | MotionMapping mapping = {}; | ||
| 1181 | mapping.insert_or_assign(Settings::NativeMotion::MotionLeft, | ||
| 1182 | BuildMotionParam(joystick->GetPort(), joystick->GetGUID())); | ||
| 1183 | return mapping; | ||
| 1184 | } | ||
| 1039 | namespace Polling { | 1185 | namespace Polling { |
| 1040 | class SDLPoller : public InputCommon::Polling::DevicePoller { | 1186 | class SDLPoller : public InputCommon::Polling::DevicePoller { |
| 1041 | public: | 1187 | public: |
| @@ -1149,6 +1295,7 @@ public: | |||
| 1149 | [[fallthrough]]; | 1295 | [[fallthrough]]; |
| 1150 | case SDL_JOYBUTTONUP: | 1296 | case SDL_JOYBUTTONUP: |
| 1151 | case SDL_JOYHATMOTION: | 1297 | case SDL_JOYHATMOTION: |
| 1298 | case SDL_CONTROLLERSENSORUPDATE: | ||
| 1152 | return {SDLEventToMotionParamPackage(state, event)}; | 1299 | return {SDLEventToMotionParamPackage(state, event)}; |
| 1153 | } | 1300 | } |
| 1154 | return std::nullopt; | 1301 | return std::nullopt; |
diff --git a/src/input_common/sdl/sdl_impl.h b/src/input_common/sdl/sdl_impl.h index 8b7363f56..121e01913 100644 --- a/src/input_common/sdl/sdl_impl.h +++ b/src/input_common/sdl/sdl_impl.h | |||
| @@ -57,6 +57,7 @@ public: | |||
| 57 | 57 | ||
| 58 | ButtonMapping GetButtonMappingForDevice(const Common::ParamPackage& params) override; | 58 | ButtonMapping GetButtonMappingForDevice(const Common::ParamPackage& params) override; |
| 59 | AnalogMapping GetAnalogMappingForDevice(const Common::ParamPackage& params) override; | 59 | AnalogMapping GetAnalogMappingForDevice(const Common::ParamPackage& params) override; |
| 60 | MotionMapping GetMotionMappingForDevice(const Common::ParamPackage& params) override; | ||
| 60 | 61 | ||
| 61 | private: | 62 | private: |
| 62 | void InitJoystick(int joystick_index); | 63 | void InitJoystick(int joystick_index); |
diff --git a/src/video_core/renderer_opengl/gl_texture_cache.cpp b/src/video_core/renderer_opengl/gl_texture_cache.cpp index 623b43d8a..ffe9edc1b 100644 --- a/src/video_core/renderer_opengl/gl_texture_cache.cpp +++ b/src/video_core/renderer_opengl/gl_texture_cache.cpp | |||
| @@ -543,8 +543,7 @@ void TextureCacheRuntime::EmulateCopyImage(Image& dst, Image& src, | |||
| 543 | } | 543 | } |
| 544 | 544 | ||
| 545 | void TextureCacheRuntime::BlitFramebuffer(Framebuffer* dst, Framebuffer* src, | 545 | void TextureCacheRuntime::BlitFramebuffer(Framebuffer* dst, Framebuffer* src, |
| 546 | const std::array<Offset2D, 2>& dst_region, | 546 | const Region2D& dst_region, const Region2D& src_region, |
| 547 | const std::array<Offset2D, 2>& src_region, | ||
| 548 | Tegra::Engines::Fermi2D::Filter filter, | 547 | Tegra::Engines::Fermi2D::Filter filter, |
| 549 | Tegra::Engines::Fermi2D::Operation operation) { | 548 | Tegra::Engines::Fermi2D::Operation operation) { |
| 550 | state_tracker.NotifyScissor0(); | 549 | state_tracker.NotifyScissor0(); |
| @@ -560,9 +559,9 @@ void TextureCacheRuntime::BlitFramebuffer(Framebuffer* dst, Framebuffer* src, | |||
| 560 | const GLbitfield buffer_bits = dst->BufferBits(); | 559 | const GLbitfield buffer_bits = dst->BufferBits(); |
| 561 | const bool has_depth = (buffer_bits & ~GL_COLOR_BUFFER_BIT) != 0; | 560 | const bool has_depth = (buffer_bits & ~GL_COLOR_BUFFER_BIT) != 0; |
| 562 | const bool is_linear = !has_depth && filter == Tegra::Engines::Fermi2D::Filter::Bilinear; | 561 | const bool is_linear = !has_depth && filter == Tegra::Engines::Fermi2D::Filter::Bilinear; |
| 563 | glBlitNamedFramebuffer(src->Handle(), dst->Handle(), src_region[0].x, src_region[0].y, | 562 | glBlitNamedFramebuffer(src->Handle(), dst->Handle(), src_region.start.x, src_region.start.y, |
| 564 | src_region[1].x, src_region[1].y, dst_region[0].x, dst_region[0].y, | 563 | src_region.end.x, src_region.end.y, dst_region.start.x, |
| 565 | dst_region[1].x, dst_region[1].y, buffer_bits, | 564 | dst_region.start.y, dst_region.end.x, dst_region.end.y, buffer_bits, |
| 566 | is_linear ? GL_LINEAR : GL_NEAREST); | 565 | is_linear ? GL_LINEAR : GL_NEAREST); |
| 567 | } | 566 | } |
| 568 | 567 | ||
diff --git a/src/video_core/renderer_opengl/gl_texture_cache.h b/src/video_core/renderer_opengl/gl_texture_cache.h index 3c871541b..df8be12ff 100644 --- a/src/video_core/renderer_opengl/gl_texture_cache.h +++ b/src/video_core/renderer_opengl/gl_texture_cache.h | |||
| @@ -28,7 +28,7 @@ using VideoCommon::ImageId; | |||
| 28 | using VideoCommon::ImageViewId; | 28 | using VideoCommon::ImageViewId; |
| 29 | using VideoCommon::ImageViewType; | 29 | using VideoCommon::ImageViewType; |
| 30 | using VideoCommon::NUM_RT; | 30 | using VideoCommon::NUM_RT; |
| 31 | using VideoCommon::Offset2D; | 31 | using VideoCommon::Region2D; |
| 32 | using VideoCommon::RenderTargets; | 32 | using VideoCommon::RenderTargets; |
| 33 | 33 | ||
| 34 | struct ImageBufferMap { | 34 | struct ImageBufferMap { |
| @@ -73,10 +73,8 @@ public: | |||
| 73 | 73 | ||
| 74 | void EmulateCopyImage(Image& dst, Image& src, std::span<const VideoCommon::ImageCopy> copies); | 74 | void EmulateCopyImage(Image& dst, Image& src, std::span<const VideoCommon::ImageCopy> copies); |
| 75 | 75 | ||
| 76 | void BlitFramebuffer(Framebuffer* dst, Framebuffer* src, | 76 | void BlitFramebuffer(Framebuffer* dst, Framebuffer* src, const Region2D& dst_region, |
| 77 | const std::array<Offset2D, 2>& dst_region, | 77 | const Region2D& src_region, Tegra::Engines::Fermi2D::Filter filter, |
| 78 | const std::array<Offset2D, 2>& src_region, | ||
| 79 | Tegra::Engines::Fermi2D::Filter filter, | ||
| 80 | Tegra::Engines::Fermi2D::Operation operation); | 78 | Tegra::Engines::Fermi2D::Operation operation); |
| 81 | 79 | ||
| 82 | void AccelerateImageUpload(Image& image, const ImageBufferMap& map, | 80 | void AccelerateImageUpload(Image& image, const ImageBufferMap& map, |
diff --git a/src/video_core/renderer_vulkan/blit_image.cpp b/src/video_core/renderer_vulkan/blit_image.cpp index 1f6a169ae..b7f5b8bc2 100644 --- a/src/video_core/renderer_vulkan/blit_image.cpp +++ b/src/video_core/renderer_vulkan/blit_image.cpp | |||
| @@ -289,16 +289,15 @@ void UpdateTwoTexturesDescriptorSet(const Device& device, VkDescriptorSet descri | |||
| 289 | device.GetLogical().UpdateDescriptorSets(write_descriptor_sets, nullptr); | 289 | device.GetLogical().UpdateDescriptorSets(write_descriptor_sets, nullptr); |
| 290 | } | 290 | } |
| 291 | 291 | ||
| 292 | void BindBlitState(vk::CommandBuffer cmdbuf, VkPipelineLayout layout, | 292 | void BindBlitState(vk::CommandBuffer cmdbuf, VkPipelineLayout layout, const Region2D& dst_region, |
| 293 | const std::array<Offset2D, 2>& dst_region, | 293 | const Region2D& src_region) { |
| 294 | const std::array<Offset2D, 2>& src_region) { | ||
| 295 | const VkOffset2D offset{ | 294 | const VkOffset2D offset{ |
| 296 | .x = std::min(dst_region[0].x, dst_region[1].x), | 295 | .x = std::min(dst_region.start.x, dst_region.end.x), |
| 297 | .y = std::min(dst_region[0].y, dst_region[1].y), | 296 | .y = std::min(dst_region.start.y, dst_region.end.y), |
| 298 | }; | 297 | }; |
| 299 | const VkExtent2D extent{ | 298 | const VkExtent2D extent{ |
| 300 | .width = static_cast<u32>(std::abs(dst_region[1].x - dst_region[0].x)), | 299 | .width = static_cast<u32>(std::abs(dst_region.end.x - dst_region.start.x)), |
| 301 | .height = static_cast<u32>(std::abs(dst_region[1].y - dst_region[0].y)), | 300 | .height = static_cast<u32>(std::abs(dst_region.end.y - dst_region.start.y)), |
| 302 | }; | 301 | }; |
| 303 | const VkViewport viewport{ | 302 | const VkViewport viewport{ |
| 304 | .x = static_cast<float>(offset.x), | 303 | .x = static_cast<float>(offset.x), |
| @@ -313,11 +312,12 @@ void BindBlitState(vk::CommandBuffer cmdbuf, VkPipelineLayout layout, | |||
| 313 | .offset = offset, | 312 | .offset = offset, |
| 314 | .extent = extent, | 313 | .extent = extent, |
| 315 | }; | 314 | }; |
| 316 | const float scale_x = static_cast<float>(src_region[1].x - src_region[0].x); | 315 | const float scale_x = static_cast<float>(src_region.end.x - src_region.start.x); |
| 317 | const float scale_y = static_cast<float>(src_region[1].y - src_region[0].y); | 316 | const float scale_y = static_cast<float>(src_region.end.y - src_region.start.y); |
| 318 | const PushConstants push_constants{ | 317 | const PushConstants push_constants{ |
| 319 | .tex_scale = {scale_x, scale_y}, | 318 | .tex_scale = {scale_x, scale_y}, |
| 320 | .tex_offset = {static_cast<float>(src_region[0].x), static_cast<float>(src_region[0].y)}, | 319 | .tex_offset = {static_cast<float>(src_region.start.x), |
| 320 | static_cast<float>(src_region.start.y)}, | ||
| 321 | }; | 321 | }; |
| 322 | cmdbuf.SetViewport(0, viewport); | 322 | cmdbuf.SetViewport(0, viewport); |
| 323 | cmdbuf.SetScissor(0, scissor); | 323 | cmdbuf.SetScissor(0, scissor); |
| @@ -353,8 +353,7 @@ BlitImageHelper::BlitImageHelper(const Device& device_, VKScheduler& scheduler_, | |||
| 353 | BlitImageHelper::~BlitImageHelper() = default; | 353 | BlitImageHelper::~BlitImageHelper() = default; |
| 354 | 354 | ||
| 355 | void BlitImageHelper::BlitColor(const Framebuffer* dst_framebuffer, const ImageView& src_image_view, | 355 | void BlitImageHelper::BlitColor(const Framebuffer* dst_framebuffer, const ImageView& src_image_view, |
| 356 | const std::array<Offset2D, 2>& dst_region, | 356 | const Region2D& dst_region, const Region2D& src_region, |
| 357 | const std::array<Offset2D, 2>& src_region, | ||
| 358 | Tegra::Engines::Fermi2D::Filter filter, | 357 | Tegra::Engines::Fermi2D::Filter filter, |
| 359 | Tegra::Engines::Fermi2D::Operation operation) { | 358 | Tegra::Engines::Fermi2D::Operation operation) { |
| 360 | const bool is_linear = filter == Tegra::Engines::Fermi2D::Filter::Bilinear; | 359 | const bool is_linear = filter == Tegra::Engines::Fermi2D::Filter::Bilinear; |
| @@ -383,8 +382,7 @@ void BlitImageHelper::BlitColor(const Framebuffer* dst_framebuffer, const ImageV | |||
| 383 | 382 | ||
| 384 | void BlitImageHelper::BlitDepthStencil(const Framebuffer* dst_framebuffer, | 383 | void BlitImageHelper::BlitDepthStencil(const Framebuffer* dst_framebuffer, |
| 385 | VkImageView src_depth_view, VkImageView src_stencil_view, | 384 | VkImageView src_depth_view, VkImageView src_stencil_view, |
| 386 | const std::array<Offset2D, 2>& dst_region, | 385 | const Region2D& dst_region, const Region2D& src_region, |
| 387 | const std::array<Offset2D, 2>& src_region, | ||
| 388 | Tegra::Engines::Fermi2D::Filter filter, | 386 | Tegra::Engines::Fermi2D::Filter filter, |
| 389 | Tegra::Engines::Fermi2D::Operation operation) { | 387 | Tegra::Engines::Fermi2D::Operation operation) { |
| 390 | ASSERT(filter == Tegra::Engines::Fermi2D::Filter::Point); | 388 | ASSERT(filter == Tegra::Engines::Fermi2D::Filter::Point); |
diff --git a/src/video_core/renderer_vulkan/blit_image.h b/src/video_core/renderer_vulkan/blit_image.h index 43fd3d737..0d81a06ed 100644 --- a/src/video_core/renderer_vulkan/blit_image.h +++ b/src/video_core/renderer_vulkan/blit_image.h | |||
| @@ -13,7 +13,7 @@ | |||
| 13 | 13 | ||
| 14 | namespace Vulkan { | 14 | namespace Vulkan { |
| 15 | 15 | ||
| 16 | using VideoCommon::Offset2D; | 16 | using VideoCommon::Region2D; |
| 17 | 17 | ||
| 18 | class Device; | 18 | class Device; |
| 19 | class Framebuffer; | 19 | class Framebuffer; |
| @@ -35,15 +35,13 @@ public: | |||
| 35 | ~BlitImageHelper(); | 35 | ~BlitImageHelper(); |
| 36 | 36 | ||
| 37 | void BlitColor(const Framebuffer* dst_framebuffer, const ImageView& src_image_view, | 37 | void BlitColor(const Framebuffer* dst_framebuffer, const ImageView& src_image_view, |
| 38 | const std::array<Offset2D, 2>& dst_region, | 38 | const Region2D& dst_region, const Region2D& src_region, |
| 39 | const std::array<Offset2D, 2>& src_region, | ||
| 40 | Tegra::Engines::Fermi2D::Filter filter, | 39 | Tegra::Engines::Fermi2D::Filter filter, |
| 41 | Tegra::Engines::Fermi2D::Operation operation); | 40 | Tegra::Engines::Fermi2D::Operation operation); |
| 42 | 41 | ||
| 43 | void BlitDepthStencil(const Framebuffer* dst_framebuffer, VkImageView src_depth_view, | 42 | void BlitDepthStencil(const Framebuffer* dst_framebuffer, VkImageView src_depth_view, |
| 44 | VkImageView src_stencil_view, const std::array<Offset2D, 2>& dst_region, | 43 | VkImageView src_stencil_view, const Region2D& dst_region, |
| 45 | const std::array<Offset2D, 2>& src_region, | 44 | const Region2D& src_region, Tegra::Engines::Fermi2D::Filter filter, |
| 46 | Tegra::Engines::Fermi2D::Filter filter, | ||
| 47 | Tegra::Engines::Fermi2D::Operation operation); | 45 | Tegra::Engines::Fermi2D::Operation operation); |
| 48 | 46 | ||
| 49 | void ConvertD32ToR32(const Framebuffer* dst_framebuffer, const ImageView& src_image_view); | 47 | void ConvertD32ToR32(const Framebuffer* dst_framebuffer, const ImageView& src_image_view); |
diff --git a/src/video_core/renderer_vulkan/vk_texture_cache.cpp b/src/video_core/renderer_vulkan/vk_texture_cache.cpp index 017348e05..bdd0ce8bc 100644 --- a/src/video_core/renderer_vulkan/vk_texture_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_texture_cache.cpp | |||
| @@ -490,8 +490,7 @@ void CopyBufferToImage(vk::CommandBuffer cmdbuf, VkBuffer src_buffer, VkImage im | |||
| 490 | write_barrier); | 490 | write_barrier); |
| 491 | } | 491 | } |
| 492 | 492 | ||
| 493 | [[nodiscard]] VkImageBlit MakeImageBlit(const std::array<Offset2D, 2>& dst_region, | 493 | [[nodiscard]] VkImageBlit MakeImageBlit(const Region2D& dst_region, const Region2D& src_region, |
| 494 | const std::array<Offset2D, 2>& src_region, | ||
| 495 | const VkImageSubresourceLayers& dst_layers, | 494 | const VkImageSubresourceLayers& dst_layers, |
| 496 | const VkImageSubresourceLayers& src_layers) { | 495 | const VkImageSubresourceLayers& src_layers) { |
| 497 | return VkImageBlit{ | 496 | return VkImageBlit{ |
| @@ -499,13 +498,13 @@ void CopyBufferToImage(vk::CommandBuffer cmdbuf, VkBuffer src_buffer, VkImage im | |||
| 499 | .srcOffsets = | 498 | .srcOffsets = |
| 500 | { | 499 | { |
| 501 | { | 500 | { |
| 502 | .x = src_region[0].x, | 501 | .x = src_region.start.x, |
| 503 | .y = src_region[0].y, | 502 | .y = src_region.start.y, |
| 504 | .z = 0, | 503 | .z = 0, |
| 505 | }, | 504 | }, |
| 506 | { | 505 | { |
| 507 | .x = src_region[1].x, | 506 | .x = src_region.end.x, |
| 508 | .y = src_region[1].y, | 507 | .y = src_region.end.y, |
| 509 | .z = 1, | 508 | .z = 1, |
| 510 | }, | 509 | }, |
| 511 | }, | 510 | }, |
| @@ -513,42 +512,42 @@ void CopyBufferToImage(vk::CommandBuffer cmdbuf, VkBuffer src_buffer, VkImage im | |||
| 513 | .dstOffsets = | 512 | .dstOffsets = |
| 514 | { | 513 | { |
| 515 | { | 514 | { |
| 516 | .x = dst_region[0].x, | 515 | .x = dst_region.start.x, |
| 517 | .y = dst_region[0].y, | 516 | .y = dst_region.start.y, |
| 518 | .z = 0, | 517 | .z = 0, |
| 519 | }, | 518 | }, |
| 520 | { | 519 | { |
| 521 | .x = dst_region[1].x, | 520 | .x = dst_region.end.x, |
| 522 | .y = dst_region[1].y, | 521 | .y = dst_region.end.y, |
| 523 | .z = 1, | 522 | .z = 1, |
| 524 | }, | 523 | }, |
| 525 | }, | 524 | }, |
| 526 | }; | 525 | }; |
| 527 | } | 526 | } |
| 528 | 527 | ||
| 529 | [[nodiscard]] VkImageResolve MakeImageResolve(const std::array<Offset2D, 2>& dst_region, | 528 | [[nodiscard]] VkImageResolve MakeImageResolve(const Region2D& dst_region, |
| 530 | const std::array<Offset2D, 2>& src_region, | 529 | const Region2D& src_region, |
| 531 | const VkImageSubresourceLayers& dst_layers, | 530 | const VkImageSubresourceLayers& dst_layers, |
| 532 | const VkImageSubresourceLayers& src_layers) { | 531 | const VkImageSubresourceLayers& src_layers) { |
| 533 | return VkImageResolve{ | 532 | return VkImageResolve{ |
| 534 | .srcSubresource = src_layers, | 533 | .srcSubresource = src_layers, |
| 535 | .srcOffset = | 534 | .srcOffset = |
| 536 | { | 535 | { |
| 537 | .x = src_region[0].x, | 536 | .x = src_region.start.x, |
| 538 | .y = src_region[0].y, | 537 | .y = src_region.start.y, |
| 539 | .z = 0, | 538 | .z = 0, |
| 540 | }, | 539 | }, |
| 541 | .dstSubresource = dst_layers, | 540 | .dstSubresource = dst_layers, |
| 542 | .dstOffset = | 541 | .dstOffset = |
| 543 | { | 542 | { |
| 544 | .x = dst_region[0].x, | 543 | .x = dst_region.start.x, |
| 545 | .y = dst_region[0].y, | 544 | .y = dst_region.start.y, |
| 546 | .z = 0, | 545 | .z = 0, |
| 547 | }, | 546 | }, |
| 548 | .extent = | 547 | .extent = |
| 549 | { | 548 | { |
| 550 | .width = static_cast<u32>(dst_region[1].x - dst_region[0].x), | 549 | .width = static_cast<u32>(dst_region.end.x - dst_region.start.x), |
| 551 | .height = static_cast<u32>(dst_region[1].y - dst_region[0].y), | 550 | .height = static_cast<u32>(dst_region.end.y - dst_region.start.y), |
| 552 | .depth = 1, | 551 | .depth = 1, |
| 553 | }, | 552 | }, |
| 554 | }; | 553 | }; |
| @@ -602,8 +601,7 @@ StagingBufferRef TextureCacheRuntime::DownloadStagingBuffer(size_t size) { | |||
| 602 | } | 601 | } |
| 603 | 602 | ||
| 604 | void TextureCacheRuntime::BlitImage(Framebuffer* dst_framebuffer, ImageView& dst, ImageView& src, | 603 | void TextureCacheRuntime::BlitImage(Framebuffer* dst_framebuffer, ImageView& dst, ImageView& src, |
| 605 | const std::array<Offset2D, 2>& dst_region, | 604 | const Region2D& dst_region, const Region2D& src_region, |
| 606 | const std::array<Offset2D, 2>& src_region, | ||
| 607 | Tegra::Engines::Fermi2D::Filter filter, | 605 | Tegra::Engines::Fermi2D::Filter filter, |
| 608 | Tegra::Engines::Fermi2D::Operation operation) { | 606 | Tegra::Engines::Fermi2D::Operation operation) { |
| 609 | const VkImageAspectFlags aspect_mask = ImageAspectMask(src.format); | 607 | const VkImageAspectFlags aspect_mask = ImageAspectMask(src.format); |
diff --git a/src/video_core/renderer_vulkan/vk_texture_cache.h b/src/video_core/renderer_vulkan/vk_texture_cache.h index 628785d5e..4a57d378b 100644 --- a/src/video_core/renderer_vulkan/vk_texture_cache.h +++ b/src/video_core/renderer_vulkan/vk_texture_cache.h | |||
| @@ -16,7 +16,7 @@ namespace Vulkan { | |||
| 16 | 16 | ||
| 17 | using VideoCommon::ImageId; | 17 | using VideoCommon::ImageId; |
| 18 | using VideoCommon::NUM_RT; | 18 | using VideoCommon::NUM_RT; |
| 19 | using VideoCommon::Offset2D; | 19 | using VideoCommon::Region2D; |
| 20 | using VideoCommon::RenderTargets; | 20 | using VideoCommon::RenderTargets; |
| 21 | using VideoCore::Surface::PixelFormat; | 21 | using VideoCore::Surface::PixelFormat; |
| 22 | 22 | ||
| @@ -71,8 +71,7 @@ struct TextureCacheRuntime { | |||
| 71 | [[nodiscard]] StagingBufferRef DownloadStagingBuffer(size_t size); | 71 | [[nodiscard]] StagingBufferRef DownloadStagingBuffer(size_t size); |
| 72 | 72 | ||
| 73 | void BlitImage(Framebuffer* dst_framebuffer, ImageView& dst, ImageView& src, | 73 | void BlitImage(Framebuffer* dst_framebuffer, ImageView& dst, ImageView& src, |
| 74 | const std::array<Offset2D, 2>& dst_region, | 74 | const Region2D& dst_region, const Region2D& src_region, |
| 75 | const std::array<Offset2D, 2>& src_region, | ||
| 76 | Tegra::Engines::Fermi2D::Filter filter, | 75 | Tegra::Engines::Fermi2D::Filter filter, |
| 77 | Tegra::Engines::Fermi2D::Operation operation); | 76 | Tegra::Engines::Fermi2D::Operation operation); |
| 78 | 77 | ||
diff --git a/src/video_core/texture_cache/texture_cache.h b/src/video_core/texture_cache/texture_cache.h index 98e33c3a0..59b7c678b 100644 --- a/src/video_core/texture_cache/texture_cache.h +++ b/src/video_core/texture_cache/texture_cache.h | |||
| @@ -148,7 +148,9 @@ public: | |||
| 148 | /// Blit an image with the given parameters | 148 | /// Blit an image with the given parameters |
| 149 | void BlitImage(const Tegra::Engines::Fermi2D::Surface& dst, | 149 | void BlitImage(const Tegra::Engines::Fermi2D::Surface& dst, |
| 150 | const Tegra::Engines::Fermi2D::Surface& src, | 150 | const Tegra::Engines::Fermi2D::Surface& src, |
| 151 | const Tegra::Engines::Fermi2D::Config& copy); | 151 | const Tegra::Engines::Fermi2D::Config& copy, |
| 152 | std::optional<Region2D> src_region_override = {}, | ||
| 153 | std::optional<Region2D> dst_region_override = {}); | ||
| 152 | 154 | ||
| 153 | /// Invalidate the contents of the color buffer index | 155 | /// Invalidate the contents of the color buffer index |
| 154 | /// These contents become unspecified, the cache can assume aggressive optimizations. | 156 | /// These contents become unspecified, the cache can assume aggressive optimizations. |
| @@ -615,7 +617,9 @@ void TextureCache<P>::UnmapMemory(VAddr cpu_addr, size_t size) { | |||
| 615 | template <class P> | 617 | template <class P> |
| 616 | void TextureCache<P>::BlitImage(const Tegra::Engines::Fermi2D::Surface& dst, | 618 | void TextureCache<P>::BlitImage(const Tegra::Engines::Fermi2D::Surface& dst, |
| 617 | const Tegra::Engines::Fermi2D::Surface& src, | 619 | const Tegra::Engines::Fermi2D::Surface& src, |
| 618 | const Tegra::Engines::Fermi2D::Config& copy) { | 620 | const Tegra::Engines::Fermi2D::Config& copy, |
| 621 | std::optional<Region2D> src_override, | ||
| 622 | std::optional<Region2D> dst_override) { | ||
| 619 | const BlitImages images = GetBlitImages(dst, src); | 623 | const BlitImages images = GetBlitImages(dst, src); |
| 620 | const ImageId dst_id = images.dst_id; | 624 | const ImageId dst_id = images.dst_id; |
| 621 | const ImageId src_id = images.src_id; | 625 | const ImageId src_id = images.src_id; |
| @@ -631,20 +635,42 @@ void TextureCache<P>::BlitImage(const Tegra::Engines::Fermi2D::Surface& dst, | |||
| 631 | const ImageViewInfo dst_view_info(ImageViewType::e2D, images.dst_format, dst_range); | 635 | const ImageViewInfo dst_view_info(ImageViewType::e2D, images.dst_format, dst_range); |
| 632 | const auto [dst_framebuffer_id, dst_view_id] = RenderTargetFromImage(dst_id, dst_view_info); | 636 | const auto [dst_framebuffer_id, dst_view_id] = RenderTargetFromImage(dst_id, dst_view_info); |
| 633 | const auto [src_samples_x, src_samples_y] = SamplesLog2(src_image.info.num_samples); | 637 | const auto [src_samples_x, src_samples_y] = SamplesLog2(src_image.info.num_samples); |
| 634 | const std::array src_region{ | 638 | |
| 635 | Offset2D{.x = copy.src_x0 >> src_samples_x, .y = copy.src_y0 >> src_samples_y}, | 639 | // out of bounds texture blit checking |
| 636 | Offset2D{.x = copy.src_x1 >> src_samples_x, .y = copy.src_y1 >> src_samples_y}, | 640 | const bool use_override = src_override.has_value(); |
| 641 | const s32 src_x0 = copy.src_x0 >> src_samples_x; | ||
| 642 | s32 src_x1 = use_override ? src_override->end.x : copy.src_x1 >> src_samples_x; | ||
| 643 | const s32 src_y0 = copy.src_y0 >> src_samples_y; | ||
| 644 | const s32 src_y1 = copy.src_y1 >> src_samples_y; | ||
| 645 | |||
| 646 | const auto src_width = static_cast<s32>(src_image.info.size.width); | ||
| 647 | const bool width_oob = src_x1 > src_width; | ||
| 648 | const auto width_diff = width_oob ? src_x1 - src_width : 0; | ||
| 649 | if (width_oob) { | ||
| 650 | src_x1 = src_width; | ||
| 651 | } | ||
| 652 | |||
| 653 | const Region2D src_dimensions{ | ||
| 654 | Offset2D{.x = src_x0, .y = src_y0}, | ||
| 655 | Offset2D{.x = src_x1, .y = src_y1}, | ||
| 637 | }; | 656 | }; |
| 657 | const auto src_region = use_override ? *src_override : src_dimensions; | ||
| 638 | 658 | ||
| 639 | const std::optional src_base = src_image.TryFindBase(src.Address()); | 659 | const std::optional src_base = src_image.TryFindBase(src.Address()); |
| 640 | const SubresourceRange src_range{.base = src_base.value(), .extent = {1, 1}}; | 660 | const SubresourceRange src_range{.base = src_base.value(), .extent = {1, 1}}; |
| 641 | const ImageViewInfo src_view_info(ImageViewType::e2D, images.src_format, src_range); | 661 | const ImageViewInfo src_view_info(ImageViewType::e2D, images.src_format, src_range); |
| 642 | const auto [src_framebuffer_id, src_view_id] = RenderTargetFromImage(src_id, src_view_info); | 662 | const auto [src_framebuffer_id, src_view_id] = RenderTargetFromImage(src_id, src_view_info); |
| 643 | const auto [dst_samples_x, dst_samples_y] = SamplesLog2(dst_image.info.num_samples); | 663 | const auto [dst_samples_x, dst_samples_y] = SamplesLog2(dst_image.info.num_samples); |
| 644 | const std::array dst_region{ | 664 | |
| 645 | Offset2D{.x = copy.dst_x0 >> dst_samples_x, .y = copy.dst_y0 >> dst_samples_y}, | 665 | const s32 dst_x0 = copy.dst_x0 >> dst_samples_x; |
| 646 | Offset2D{.x = copy.dst_x1 >> dst_samples_x, .y = copy.dst_y1 >> dst_samples_y}, | 666 | const s32 dst_x1 = copy.dst_x1 >> dst_samples_x; |
| 667 | const s32 dst_y0 = copy.dst_y0 >> dst_samples_y; | ||
| 668 | const s32 dst_y1 = copy.dst_y1 >> dst_samples_y; | ||
| 669 | const Region2D dst_dimensions{ | ||
| 670 | Offset2D{.x = dst_x0, .y = dst_y0}, | ||
| 671 | Offset2D{.x = dst_x1 - width_diff, .y = dst_y1}, | ||
| 647 | }; | 672 | }; |
| 673 | const auto dst_region = use_override ? *dst_override : dst_dimensions; | ||
| 648 | 674 | ||
| 649 | // Always call this after src_framebuffer_id was queried, as the address might be invalidated. | 675 | // Always call this after src_framebuffer_id was queried, as the address might be invalidated. |
| 650 | Framebuffer* const dst_framebuffer = &slot_framebuffers[dst_framebuffer_id]; | 676 | Framebuffer* const dst_framebuffer = &slot_framebuffers[dst_framebuffer_id]; |
| @@ -661,6 +687,21 @@ void TextureCache<P>::BlitImage(const Tegra::Engines::Fermi2D::Surface& dst, | |||
| 661 | runtime.BlitImage(dst_framebuffer, dst_view, src_view, dst_region, src_region, copy.filter, | 687 | runtime.BlitImage(dst_framebuffer, dst_view, src_view, dst_region, src_region, copy.filter, |
| 662 | copy.operation); | 688 | copy.operation); |
| 663 | } | 689 | } |
| 690 | |||
| 691 | if (width_oob) { | ||
| 692 | // Continue copy of the oob region of the texture on the next row | ||
| 693 | auto oob_src = src; | ||
| 694 | oob_src.height++; | ||
| 695 | const Region2D src_region_override{ | ||
| 696 | Offset2D{.x = 0, .y = src_y0 + 1}, | ||
| 697 | Offset2D{.x = width_diff, .y = src_y1 + 1}, | ||
| 698 | }; | ||
| 699 | const Region2D dst_region_override{ | ||
| 700 | Offset2D{.x = dst_x1 - width_diff, .y = dst_y0}, | ||
| 701 | Offset2D{.x = dst_x1, .y = dst_y1}, | ||
| 702 | }; | ||
| 703 | BlitImage(dst, oob_src, copy, src_region_override, dst_region_override); | ||
| 704 | } | ||
| 664 | } | 705 | } |
| 665 | 706 | ||
| 666 | template <class P> | 707 | template <class P> |
diff --git a/src/video_core/texture_cache/types.h b/src/video_core/texture_cache/types.h index 2ad2d72a6..c9571f7e4 100644 --- a/src/video_core/texture_cache/types.h +++ b/src/video_core/texture_cache/types.h | |||
| @@ -64,6 +64,13 @@ struct Offset3D { | |||
| 64 | s32 z; | 64 | s32 z; |
| 65 | }; | 65 | }; |
| 66 | 66 | ||
| 67 | struct Region2D { | ||
| 68 | constexpr auto operator<=>(const Region2D&) const noexcept = default; | ||
| 69 | |||
| 70 | Offset2D start; | ||
| 71 | Offset2D end; | ||
| 72 | }; | ||
| 73 | |||
| 67 | struct Extent2D { | 74 | struct Extent2D { |
| 68 | constexpr auto operator<=>(const Extent2D&) const noexcept = default; | 75 | constexpr auto operator<=>(const Extent2D&) const noexcept = default; |
| 69 | 76 | ||
diff --git a/src/yuzu/configuration/configure_input_player.cpp b/src/yuzu/configuration/configure_input_player.cpp index c9318c562..ab3512810 100644 --- a/src/yuzu/configuration/configure_input_player.cpp +++ b/src/yuzu/configuration/configure_input_player.cpp | |||
| @@ -153,6 +153,10 @@ QString ButtonToText(const Common::ParamPackage& param) { | |||
| 153 | return QObject::tr("Button %1").arg(button_str); | 153 | return QObject::tr("Button %1").arg(button_str); |
| 154 | } | 154 | } |
| 155 | 155 | ||
| 156 | if (param.Has("motion")) { | ||
| 157 | return QObject::tr("SDL Motion"); | ||
| 158 | } | ||
| 159 | |||
| 156 | return {}; | 160 | return {}; |
| 157 | } | 161 | } |
| 158 | 162 | ||
| @@ -1245,12 +1249,16 @@ void ConfigureInputPlayer::UpdateMappingWithDefaults() { | |||
| 1245 | const auto& device = input_devices[ui->comboDevices->currentIndex()]; | 1249 | const auto& device = input_devices[ui->comboDevices->currentIndex()]; |
| 1246 | auto button_mapping = input_subsystem->GetButtonMappingForDevice(device); | 1250 | auto button_mapping = input_subsystem->GetButtonMappingForDevice(device); |
| 1247 | auto analog_mapping = input_subsystem->GetAnalogMappingForDevice(device); | 1251 | auto analog_mapping = input_subsystem->GetAnalogMappingForDevice(device); |
| 1252 | auto motion_mapping = input_subsystem->GetMotionMappingForDevice(device); | ||
| 1248 | for (std::size_t i = 0; i < buttons_param.size(); ++i) { | 1253 | for (std::size_t i = 0; i < buttons_param.size(); ++i) { |
| 1249 | buttons_param[i] = button_mapping[static_cast<Settings::NativeButton::Values>(i)]; | 1254 | buttons_param[i] = button_mapping[static_cast<Settings::NativeButton::Values>(i)]; |
| 1250 | } | 1255 | } |
| 1251 | for (std::size_t i = 0; i < analogs_param.size(); ++i) { | 1256 | for (std::size_t i = 0; i < analogs_param.size(); ++i) { |
| 1252 | analogs_param[i] = analog_mapping[static_cast<Settings::NativeAnalog::Values>(i)]; | 1257 | analogs_param[i] = analog_mapping[static_cast<Settings::NativeAnalog::Values>(i)]; |
| 1253 | } | 1258 | } |
| 1259 | for (std::size_t i = 0; i < motions_param.size(); ++i) { | ||
| 1260 | motions_param[i] = motion_mapping[static_cast<Settings::NativeMotion::Values>(i)]; | ||
| 1261 | } | ||
| 1254 | 1262 | ||
| 1255 | UpdateUI(); | 1263 | UpdateUI(); |
| 1256 | } | 1264 | } |
diff --git a/src/yuzu/main.cpp b/src/yuzu/main.cpp index 9e72acbf7..30bb1aac7 100644 --- a/src/yuzu/main.cpp +++ b/src/yuzu/main.cpp | |||
| @@ -2751,24 +2751,19 @@ void GMainWindow::MigrateConfigFiles() { | |||
| 2751 | 2751 | ||
| 2752 | void GMainWindow::UpdateWindowTitle(const std::string& title_name, | 2752 | void GMainWindow::UpdateWindowTitle(const std::string& title_name, |
| 2753 | const std::string& title_version) { | 2753 | const std::string& title_version) { |
| 2754 | const auto full_name = std::string(Common::g_build_fullname); | ||
| 2755 | const auto branch_name = std::string(Common::g_scm_branch); | 2754 | const auto branch_name = std::string(Common::g_scm_branch); |
| 2756 | const auto description = std::string(Common::g_scm_desc); | 2755 | const auto description = std::string(Common::g_scm_desc); |
| 2757 | const auto build_id = std::string(Common::g_build_id); | 2756 | const auto build_id = std::string(Common::g_build_id); |
| 2758 | 2757 | ||
| 2759 | const auto date = | 2758 | const auto yuzu_title = fmt::format("yuzu | {}-{}", branch_name, description); |
| 2760 | QDateTime::currentDateTime().toString(QStringLiteral("yyyy-MM-dd")).toStdString(); | 2759 | const auto override_title = fmt::format(std::string(Common::g_title_bar_format_idle), build_id); |
| 2760 | const auto window_title = override_title.empty() ? yuzu_title : override_title; | ||
| 2761 | 2761 | ||
| 2762 | if (title_name.empty()) { | 2762 | if (title_name.empty()) { |
| 2763 | const auto fmt = std::string(Common::g_title_bar_format_idle); | 2763 | setWindowTitle(QString::fromStdString(window_title)); |
| 2764 | setWindowTitle(QString::fromStdString(fmt::format(fmt.empty() ? "yuzu {0}| {1}-{2}" : fmt, | ||
| 2765 | full_name, branch_name, description, | ||
| 2766 | std::string{}, date, build_id))); | ||
| 2767 | } else { | 2764 | } else { |
| 2768 | const auto fmt = std::string(Common::g_title_bar_format_running); | 2765 | const auto run_title = fmt::format("{} | {} | {}", window_title, title_name, title_version); |
| 2769 | setWindowTitle(QString::fromStdString( | 2766 | setWindowTitle(QString::fromStdString(run_title)); |
| 2770 | fmt::format(fmt.empty() ? "yuzu {0}| {3} | {6} | {1}-{2}" : fmt, full_name, branch_name, | ||
| 2771 | description, title_name, date, build_id, title_version))); | ||
| 2772 | } | 2767 | } |
| 2773 | } | 2768 | } |
| 2774 | 2769 | ||