diff options
| -rw-r--r-- | dist/qt_themes/default/style.qss | 4 | ||||
| -rw-r--r-- | src/video_core/host_shaders/astc_decoder.comp | 271 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/util_shaders.cpp | 31 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/util_shaders.h | 1 | ||||
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_compute_pass.cpp | 97 | ||||
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_compute_pass.h | 5 | ||||
| -rw-r--r-- | src/video_core/textures/astc.cpp | 156 | ||||
| -rw-r--r-- | src/video_core/textures/astc.h | 111 | ||||
| -rw-r--r-- | src/yuzu/configuration/configure_input_player_widget.cpp | 61 | ||||
| -rw-r--r-- | src/yuzu/configuration/configure_input_player_widget.h | 6 | ||||
| -rw-r--r-- | src/yuzu_cmd/emu_window/emu_window_sdl2.cpp | 4 | ||||
| -rw-r--r-- | src/yuzu_cmd/emu_window/emu_window_sdl2.h | 3 | ||||
| -rw-r--r-- | src/yuzu_cmd/emu_window/emu_window_sdl2_gl.cpp | 1 | ||||
| -rw-r--r-- | src/yuzu_cmd/emu_window/emu_window_sdl2_vk.cpp | 1 |
14 files changed, 308 insertions, 444 deletions
diff --git a/dist/qt_themes/default/style.qss b/dist/qt_themes/default/style.qss index 9915a40ba..f0908a7f1 100644 --- a/dist/qt_themes/default/style.qss +++ b/dist/qt_themes/default/style.qss | |||
| @@ -51,11 +51,11 @@ QPushButton#GPUStatusBarButton:hover { | |||
| 51 | } | 51 | } |
| 52 | 52 | ||
| 53 | QPushButton#GPUStatusBarButton:checked { | 53 | QPushButton#GPUStatusBarButton:checked { |
| 54 | color: #ff8040; | 54 | color: #b06020; |
| 55 | } | 55 | } |
| 56 | 56 | ||
| 57 | QPushButton#GPUStatusBarButton:!checked { | 57 | QPushButton#GPUStatusBarButton:!checked { |
| 58 | color: #40dd40; | 58 | color: #109010; |
| 59 | } | 59 | } |
| 60 | 60 | ||
| 61 | QPushButton#buttonRefreshDevices { | 61 | QPushButton#buttonRefreshDevices { |
diff --git a/src/video_core/host_shaders/astc_decoder.comp b/src/video_core/host_shaders/astc_decoder.comp index c37f15bfd..f34c5f5d9 100644 --- a/src/video_core/host_shaders/astc_decoder.comp +++ b/src/video_core/host_shaders/astc_decoder.comp | |||
| @@ -10,33 +10,27 @@ | |||
| 10 | #define END_PUSH_CONSTANTS }; | 10 | #define END_PUSH_CONSTANTS }; |
| 11 | #define UNIFORM(n) | 11 | #define UNIFORM(n) |
| 12 | #define BINDING_INPUT_BUFFER 0 | 12 | #define BINDING_INPUT_BUFFER 0 |
| 13 | #define BINDING_ENC_BUFFER 1 | 13 | #define BINDING_OUTPUT_IMAGE 1 |
| 14 | #define BINDING_SWIZZLE_BUFFER 2 | ||
| 15 | #define BINDING_OUTPUT_IMAGE 3 | ||
| 16 | 14 | ||
| 17 | #else // ^^^ Vulkan ^^^ // vvv OpenGL vvv | 15 | #else // ^^^ Vulkan ^^^ // vvv OpenGL vvv |
| 18 | 16 | ||
| 19 | #define BEGIN_PUSH_CONSTANTS | 17 | #define BEGIN_PUSH_CONSTANTS |
| 20 | #define END_PUSH_CONSTANTS | 18 | #define END_PUSH_CONSTANTS |
| 21 | #define UNIFORM(n) layout(location = n) uniform | 19 | #define UNIFORM(n) layout(location = n) uniform |
| 22 | #define BINDING_SWIZZLE_BUFFER 0 | 20 | #define BINDING_INPUT_BUFFER 0 |
| 23 | #define BINDING_INPUT_BUFFER 1 | ||
| 24 | #define BINDING_ENC_BUFFER 2 | ||
| 25 | #define BINDING_OUTPUT_IMAGE 0 | 21 | #define BINDING_OUTPUT_IMAGE 0 |
| 26 | 22 | ||
| 27 | #endif | 23 | #endif |
| 28 | 24 | ||
| 29 | layout(local_size_x = 32, local_size_y = 32, local_size_z = 1) in; | 25 | layout(local_size_x = 8, local_size_y = 8, local_size_z = 1) in; |
| 30 | 26 | ||
| 31 | BEGIN_PUSH_CONSTANTS | 27 | BEGIN_PUSH_CONSTANTS |
| 32 | UNIFORM(1) uvec2 block_dims; | 28 | UNIFORM(1) uvec2 block_dims; |
| 33 | 29 | UNIFORM(2) uint layer_stride; | |
| 34 | UNIFORM(2) uint bytes_per_block_log2; | 30 | UNIFORM(3) uint block_size; |
| 35 | UNIFORM(3) uint layer_stride; | 31 | UNIFORM(4) uint x_shift; |
| 36 | UNIFORM(4) uint block_size; | 32 | UNIFORM(5) uint block_height; |
| 37 | UNIFORM(5) uint x_shift; | 33 | UNIFORM(6) uint block_height_mask; |
| 38 | UNIFORM(6) uint block_height; | ||
| 39 | UNIFORM(7) uint block_height_mask; | ||
| 40 | END_PUSH_CONSTANTS | 34 | END_PUSH_CONSTANTS |
| 41 | 35 | ||
| 42 | struct EncodingData { | 36 | struct EncodingData { |
| @@ -55,45 +49,35 @@ struct TexelWeightParams { | |||
| 55 | bool void_extent_hdr; | 49 | bool void_extent_hdr; |
| 56 | }; | 50 | }; |
| 57 | 51 | ||
| 58 | // Swizzle data | ||
| 59 | layout(binding = BINDING_SWIZZLE_BUFFER, std430) readonly buffer SwizzleTable { | ||
| 60 | uint swizzle_table[]; | ||
| 61 | }; | ||
| 62 | |||
| 63 | layout(binding = BINDING_INPUT_BUFFER, std430) readonly buffer InputBufferU32 { | 52 | layout(binding = BINDING_INPUT_BUFFER, std430) readonly buffer InputBufferU32 { |
| 64 | uint astc_data[]; | 53 | uvec4 astc_data[]; |
| 65 | }; | ||
| 66 | |||
| 67 | // ASTC Encodings data | ||
| 68 | layout(binding = BINDING_ENC_BUFFER, std430) readonly buffer EncodingsValues { | ||
| 69 | EncodingData encoding_values[]; | ||
| 70 | }; | 54 | }; |
| 71 | 55 | ||
| 72 | layout(binding = BINDING_OUTPUT_IMAGE, rgba8) uniform writeonly image2DArray dest_image; | 56 | layout(binding = BINDING_OUTPUT_IMAGE, rgba8) uniform writeonly image2DArray dest_image; |
| 73 | 57 | ||
| 74 | const uint GOB_SIZE_X = 64; | ||
| 75 | const uint GOB_SIZE_Y = 8; | ||
| 76 | const uint GOB_SIZE_Z = 1; | ||
| 77 | const uint GOB_SIZE = GOB_SIZE_X * GOB_SIZE_Y * GOB_SIZE_Z; | ||
| 78 | |||
| 79 | const uint GOB_SIZE_X_SHIFT = 6; | 58 | const uint GOB_SIZE_X_SHIFT = 6; |
| 80 | const uint GOB_SIZE_Y_SHIFT = 3; | 59 | const uint GOB_SIZE_Y_SHIFT = 3; |
| 81 | const uint GOB_SIZE_Z_SHIFT = 0; | 60 | const uint GOB_SIZE_SHIFT = GOB_SIZE_X_SHIFT + GOB_SIZE_Y_SHIFT; |
| 82 | const uint GOB_SIZE_SHIFT = GOB_SIZE_X_SHIFT + GOB_SIZE_Y_SHIFT + GOB_SIZE_Z_SHIFT; | ||
| 83 | |||
| 84 | const uvec2 SWIZZLE_MASK = uvec2(GOB_SIZE_X - 1, GOB_SIZE_Y - 1); | ||
| 85 | 61 | ||
| 86 | const int BLOCK_SIZE_IN_BYTES = 16; | 62 | const uint BYTES_PER_BLOCK_LOG2 = 4; |
| 87 | |||
| 88 | const int BLOCK_INFO_ERROR = 0; | ||
| 89 | const int BLOCK_INFO_VOID_EXTENT_HDR = 1; | ||
| 90 | const int BLOCK_INFO_VOID_EXTENT_LDR = 2; | ||
| 91 | const int BLOCK_INFO_NORMAL = 3; | ||
| 92 | 63 | ||
| 93 | const int JUST_BITS = 0; | 64 | const int JUST_BITS = 0; |
| 94 | const int QUINT = 1; | 65 | const int QUINT = 1; |
| 95 | const int TRIT = 2; | 66 | const int TRIT = 2; |
| 96 | 67 | ||
| 68 | // ASTC Encodings data, sorted in ascending order based on their BitLength value | ||
| 69 | // (see GetBitLength() function) | ||
| 70 | EncodingData encoding_values[22] = EncodingData[]( | ||
| 71 | EncodingData(JUST_BITS, 0, 0, 0), EncodingData(JUST_BITS, 1, 0, 0), EncodingData(TRIT, 0, 0, 0), | ||
| 72 | EncodingData(JUST_BITS, 2, 0, 0), EncodingData(QUINT, 0, 0, 0), EncodingData(TRIT, 1, 0, 0), | ||
| 73 | EncodingData(JUST_BITS, 3, 0, 0), EncodingData(QUINT, 1, 0, 0), EncodingData(TRIT, 2, 0, 0), | ||
| 74 | EncodingData(JUST_BITS, 4, 0, 0), EncodingData(QUINT, 2, 0, 0), EncodingData(TRIT, 3, 0, 0), | ||
| 75 | EncodingData(JUST_BITS, 5, 0, 0), EncodingData(QUINT, 3, 0, 0), EncodingData(TRIT, 4, 0, 0), | ||
| 76 | EncodingData(JUST_BITS, 6, 0, 0), EncodingData(QUINT, 4, 0, 0), EncodingData(TRIT, 5, 0, 0), | ||
| 77 | EncodingData(JUST_BITS, 7, 0, 0), EncodingData(QUINT, 5, 0, 0), EncodingData(TRIT, 6, 0, 0), | ||
| 78 | EncodingData(JUST_BITS, 8, 0, 0) | ||
| 79 | ); | ||
| 80 | |||
| 97 | // The following constants are expanded variants of the Replicate() | 81 | // The following constants are expanded variants of the Replicate() |
| 98 | // function calls corresponding to the following arguments: | 82 | // function calls corresponding to the following arguments: |
| 99 | // value: index into the generated table | 83 | // value: index into the generated table |
| @@ -135,44 +119,37 @@ const uint REPLICATE_7_BIT_TO_8_TABLE[128] = | |||
| 135 | // Input ASTC texture globals | 119 | // Input ASTC texture globals |
| 136 | uint current_index = 0; | 120 | uint current_index = 0; |
| 137 | int bitsread = 0; | 121 | int bitsread = 0; |
| 138 | uint total_bitsread = 0; | 122 | int total_bitsread = 0; |
| 139 | uint local_buff[16]; | 123 | uvec4 local_buff; |
| 140 | 124 | ||
| 141 | // Color data globals | 125 | // Color data globals |
| 142 | uint color_endpoint_data[16]; | 126 | uvec4 color_endpoint_data; |
| 143 | int color_bitsread = 0; | 127 | int color_bitsread = 0; |
| 144 | uint total_color_bitsread = 0; | ||
| 145 | int color_index = 0; | ||
| 146 | 128 | ||
| 147 | // Four values, two endpoints, four maximum paritions | 129 | // Four values, two endpoints, four maximum paritions |
| 148 | uint color_values[32]; | 130 | uint color_values[32]; |
| 149 | int colvals_index = 0; | 131 | int colvals_index = 0; |
| 150 | 132 | ||
| 151 | // Weight data globals | 133 | // Weight data globals |
| 152 | uint texel_weight_data[16]; | 134 | uvec4 texel_weight_data; |
| 153 | int texel_bitsread = 0; | 135 | int texel_bitsread = 0; |
| 154 | uint total_texel_bitsread = 0; | ||
| 155 | int texel_index = 0; | ||
| 156 | 136 | ||
| 157 | bool texel_flag = false; | 137 | bool texel_flag = false; |
| 158 | 138 | ||
| 159 | // Global "vectors" to be pushed into when decoding | 139 | // Global "vectors" to be pushed into when decoding |
| 160 | EncodingData result_vector[100]; | 140 | EncodingData result_vector[144]; |
| 161 | int result_index = 0; | 141 | int result_index = 0; |
| 162 | 142 | ||
| 163 | EncodingData texel_vector[100]; | 143 | EncodingData texel_vector[144]; |
| 164 | int texel_vector_index = 0; | 144 | int texel_vector_index = 0; |
| 165 | 145 | ||
| 166 | uint unquantized_texel_weights[2][144]; | 146 | uint unquantized_texel_weights[2][144]; |
| 167 | 147 | ||
| 168 | uint SwizzleOffset(uvec2 pos) { | 148 | uint SwizzleOffset(uvec2 pos) { |
| 169 | pos = pos & SWIZZLE_MASK; | 149 | uint x = pos.x; |
| 170 | return swizzle_table[pos.y * 64 + pos.x]; | 150 | uint y = pos.y; |
| 171 | } | 151 | return ((x % 64) / 32) * 256 + ((y % 8) / 2) * 64 + ((x % 32) / 16) * 32 + |
| 172 | 152 | (y % 2) * 16 + (x % 16); | |
| 173 | uint ReadTexel(uint offset) { | ||
| 174 | // extract the 8-bit value from the 32-bit packed data. | ||
| 175 | return bitfieldExtract(astc_data[offset / 4], int((offset * 8) & 24), 8); | ||
| 176 | } | 153 | } |
| 177 | 154 | ||
| 178 | // Replicates low num_bits such that [(to_bit - 1):(to_bit - 1 - from_bit)] | 155 | // Replicates low num_bits such that [(to_bit - 1):(to_bit - 1 - from_bit)] |
| @@ -278,14 +255,10 @@ uint Hash52(uint p) { | |||
| 278 | return p; | 255 | return p; |
| 279 | } | 256 | } |
| 280 | 257 | ||
| 281 | uint SelectPartition(uint seed, uint x, uint y, uint z, uint partition_count, bool small_block) { | 258 | uint Select2DPartition(uint seed, uint x, uint y, uint partition_count, bool small_block) { |
| 282 | if (partition_count == 1) { | ||
| 283 | return 0; | ||
| 284 | } | ||
| 285 | if (small_block) { | 259 | if (small_block) { |
| 286 | x <<= 1; | 260 | x <<= 1; |
| 287 | y <<= 1; | 261 | y <<= 1; |
| 288 | z <<= 1; | ||
| 289 | } | 262 | } |
| 290 | 263 | ||
| 291 | seed += (partition_count - 1) * 1024; | 264 | seed += (partition_count - 1) * 1024; |
| @@ -299,10 +272,6 @@ uint SelectPartition(uint seed, uint x, uint y, uint z, uint partition_count, bo | |||
| 299 | uint seed6 = uint((rnum >> 20) & 0xF); | 272 | uint seed6 = uint((rnum >> 20) & 0xF); |
| 300 | uint seed7 = uint((rnum >> 24) & 0xF); | 273 | uint seed7 = uint((rnum >> 24) & 0xF); |
| 301 | uint seed8 = uint((rnum >> 28) & 0xF); | 274 | uint seed8 = uint((rnum >> 28) & 0xF); |
| 302 | uint seed9 = uint((rnum >> 18) & 0xF); | ||
| 303 | uint seed10 = uint((rnum >> 22) & 0xF); | ||
| 304 | uint seed11 = uint((rnum >> 26) & 0xF); | ||
| 305 | uint seed12 = uint(((rnum >> 30) | (rnum << 2)) & 0xF); | ||
| 306 | 275 | ||
| 307 | seed1 = (seed1 * seed1); | 276 | seed1 = (seed1 * seed1); |
| 308 | seed2 = (seed2 * seed2); | 277 | seed2 = (seed2 * seed2); |
| @@ -312,12 +281,8 @@ uint SelectPartition(uint seed, uint x, uint y, uint z, uint partition_count, bo | |||
| 312 | seed6 = (seed6 * seed6); | 281 | seed6 = (seed6 * seed6); |
| 313 | seed7 = (seed7 * seed7); | 282 | seed7 = (seed7 * seed7); |
| 314 | seed8 = (seed8 * seed8); | 283 | seed8 = (seed8 * seed8); |
| 315 | seed9 = (seed9 * seed9); | ||
| 316 | seed10 = (seed10 * seed10); | ||
| 317 | seed11 = (seed11 * seed11); | ||
| 318 | seed12 = (seed12 * seed12); | ||
| 319 | 284 | ||
| 320 | int sh1, sh2, sh3; | 285 | uint sh1, sh2; |
| 321 | if ((seed & 1) > 0) { | 286 | if ((seed & 1) > 0) { |
| 322 | sh1 = (seed & 2) > 0 ? 4 : 5; | 287 | sh1 = (seed & 2) > 0 ? 4 : 5; |
| 323 | sh2 = (partition_count == 3) ? 6 : 5; | 288 | sh2 = (partition_count == 3) ? 6 : 5; |
| @@ -325,25 +290,19 @@ uint SelectPartition(uint seed, uint x, uint y, uint z, uint partition_count, bo | |||
| 325 | sh1 = (partition_count == 3) ? 6 : 5; | 290 | sh1 = (partition_count == 3) ? 6 : 5; |
| 326 | sh2 = (seed & 2) > 0 ? 4 : 5; | 291 | sh2 = (seed & 2) > 0 ? 4 : 5; |
| 327 | } | 292 | } |
| 328 | sh3 = (seed & 0x10) > 0 ? sh1 : sh2; | 293 | seed1 >>= sh1; |
| 329 | 294 | seed2 >>= sh2; | |
| 330 | seed1 = (seed1 >> sh1); | 295 | seed3 >>= sh1; |
| 331 | seed2 = (seed2 >> sh2); | 296 | seed4 >>= sh2; |
| 332 | seed3 = (seed3 >> sh1); | 297 | seed5 >>= sh1; |
| 333 | seed4 = (seed4 >> sh2); | 298 | seed6 >>= sh2; |
| 334 | seed5 = (seed5 >> sh1); | 299 | seed7 >>= sh1; |
| 335 | seed6 = (seed6 >> sh2); | 300 | seed8 >>= sh2; |
| 336 | seed7 = (seed7 >> sh1); | 301 | |
| 337 | seed8 = (seed8 >> sh2); | 302 | uint a = seed1 * x + seed2 * y + (rnum >> 14); |
| 338 | seed9 = (seed9 >> sh3); | 303 | uint b = seed3 * x + seed4 * y + (rnum >> 10); |
| 339 | seed10 = (seed10 >> sh3); | 304 | uint c = seed5 * x + seed6 * y + (rnum >> 6); |
| 340 | seed11 = (seed11 >> sh3); | 305 | uint d = seed7 * x + seed8 * y + (rnum >> 2); |
| 341 | seed12 = (seed12 >> sh3); | ||
| 342 | |||
| 343 | uint a = seed1 * x + seed2 * y + seed11 * z + (rnum >> 14); | ||
| 344 | uint b = seed3 * x + seed4 * y + seed12 * z + (rnum >> 10); | ||
| 345 | uint c = seed5 * x + seed6 * y + seed9 * z + (rnum >> 6); | ||
| 346 | uint d = seed7 * x + seed8 * y + seed10 * z + (rnum >> 2); | ||
| 347 | 306 | ||
| 348 | a &= 0x3F; | 307 | a &= 0x3F; |
| 349 | b &= 0x3F; | 308 | b &= 0x3F; |
| @@ -368,58 +327,37 @@ uint SelectPartition(uint seed, uint x, uint y, uint z, uint partition_count, bo | |||
| 368 | } | 327 | } |
| 369 | } | 328 | } |
| 370 | 329 | ||
| 371 | uint Select2DPartition(uint seed, uint x, uint y, uint partition_count, bool small_block) { | 330 | uint ExtractBits(uvec4 payload, int offset, int bits) { |
| 372 | return SelectPartition(seed, x, y, 0, partition_count, small_block); | 331 | if (bits <= 0) { |
| 373 | } | ||
| 374 | |||
| 375 | uint ReadBit() { | ||
| 376 | if (current_index >= local_buff.length()) { | ||
| 377 | return 0; | 332 | return 0; |
| 378 | } | 333 | } |
| 379 | uint bit = bitfieldExtract(local_buff[current_index], bitsread, 1); | 334 | int last_offset = offset + bits - 1; |
| 380 | ++bitsread; | 335 | int shifted_offset = offset >> 5; |
| 381 | ++total_bitsread; | 336 | if ((last_offset >> 5) == shifted_offset) { |
| 382 | if (bitsread == 8) { | 337 | return bitfieldExtract(payload[shifted_offset], offset & 31, bits); |
| 383 | ++current_index; | ||
| 384 | bitsread = 0; | ||
| 385 | } | 338 | } |
| 386 | return bit; | 339 | int first_bits = 32 - (offset & 31); |
| 340 | int result_first = int(bitfieldExtract(payload[shifted_offset], offset & 31, first_bits)); | ||
| 341 | int result_second = int(bitfieldExtract(payload[shifted_offset + 1], 0, bits - first_bits)); | ||
| 342 | return result_first | (result_second << first_bits); | ||
| 387 | } | 343 | } |
| 388 | 344 | ||
| 389 | uint StreamBits(uint num_bits) { | 345 | uint StreamBits(uint num_bits) { |
| 390 | uint ret = 0; | 346 | int int_bits = int(num_bits); |
| 391 | for (uint i = 0; i < num_bits; i++) { | 347 | uint ret = ExtractBits(local_buff, total_bitsread, int_bits); |
| 392 | ret |= ((ReadBit() & 1) << i); | 348 | total_bitsread += int_bits; |
| 393 | } | ||
| 394 | return ret; | 349 | return ret; |
| 395 | } | 350 | } |
| 396 | 351 | ||
| 397 | uint ReadColorBit() { | ||
| 398 | uint bit = 0; | ||
| 399 | if (texel_flag) { | ||
| 400 | bit = bitfieldExtract(texel_weight_data[texel_index], texel_bitsread, 1); | ||
| 401 | ++texel_bitsread; | ||
| 402 | ++total_texel_bitsread; | ||
| 403 | if (texel_bitsread == 8) { | ||
| 404 | ++texel_index; | ||
| 405 | texel_bitsread = 0; | ||
| 406 | } | ||
| 407 | } else { | ||
| 408 | bit = bitfieldExtract(color_endpoint_data[color_index], color_bitsread, 1); | ||
| 409 | ++color_bitsread; | ||
| 410 | ++total_color_bitsread; | ||
| 411 | if (color_bitsread == 8) { | ||
| 412 | ++color_index; | ||
| 413 | color_bitsread = 0; | ||
| 414 | } | ||
| 415 | } | ||
| 416 | return bit; | ||
| 417 | } | ||
| 418 | |||
| 419 | uint StreamColorBits(uint num_bits) { | 352 | uint StreamColorBits(uint num_bits) { |
| 420 | uint ret = 0; | 353 | uint ret = 0; |
| 421 | for (uint i = 0; i < num_bits; i++) { | 354 | int int_bits = int(num_bits); |
| 422 | ret |= ((ReadColorBit() & 1) << i); | 355 | if (texel_flag) { |
| 356 | ret = ExtractBits(texel_weight_data, texel_bitsread, int_bits); | ||
| 357 | texel_bitsread += int_bits; | ||
| 358 | } else { | ||
| 359 | ret = ExtractBits(color_endpoint_data, color_bitsread, int_bits); | ||
| 360 | color_bitsread += int_bits; | ||
| 423 | } | 361 | } |
| 424 | return ret; | 362 | return ret; |
| 425 | } | 363 | } |
| @@ -596,22 +534,16 @@ void DecodeColorValues(uvec4 modes, uint num_partitions, uint color_data_bits) { | |||
| 596 | for (uint i = 0; i < num_partitions; i++) { | 534 | for (uint i = 0; i < num_partitions; i++) { |
| 597 | num_values += ((modes[i] >> 2) + 1) << 1; | 535 | num_values += ((modes[i] >> 2) + 1) << 1; |
| 598 | } | 536 | } |
| 599 | int range = 256; | 537 | // Find the largest encoding that's within color_data_bits |
| 600 | while (--range > 0) { | 538 | // TODO(ameerj): profile with binary search |
| 601 | EncodingData val = encoding_values[range]; | 539 | int range = 0; |
| 540 | while (++range < encoding_values.length()) { | ||
| 602 | uint bit_length = GetBitLength(num_values, range); | 541 | uint bit_length = GetBitLength(num_values, range); |
| 603 | if (bit_length <= color_data_bits) { | 542 | if (bit_length > color_data_bits) { |
| 604 | while (--range > 0) { | ||
| 605 | EncodingData newval = encoding_values[range]; | ||
| 606 | if (newval.encoding != val.encoding && newval.num_bits != val.num_bits) { | ||
| 607 | break; | ||
| 608 | } | ||
| 609 | } | ||
| 610 | ++range; | ||
| 611 | break; | 543 | break; |
| 612 | } | 544 | } |
| 613 | } | 545 | } |
| 614 | DecodeIntegerSequence(range, num_values); | 546 | DecodeIntegerSequence(range - 1, num_values); |
| 615 | uint out_index = 0; | 547 | uint out_index = 0; |
| 616 | for (int itr = 0; itr < result_index; ++itr) { | 548 | for (int itr = 0; itr < result_index; ++itr) { |
| 617 | if (out_index >= num_values) { | 549 | if (out_index >= num_values) { |
| @@ -1028,7 +960,7 @@ int FindLayout(uint mode) { | |||
| 1028 | return 5; | 960 | return 5; |
| 1029 | } | 961 | } |
| 1030 | 962 | ||
| 1031 | TexelWeightParams DecodeBlockInfo(uint block_index) { | 963 | TexelWeightParams DecodeBlockInfo() { |
| 1032 | TexelWeightParams params = TexelWeightParams(uvec2(0), 0, false, false, false, false); | 964 | TexelWeightParams params = TexelWeightParams(uvec2(0), 0, false, false, false, false); |
| 1033 | uint mode = StreamBits(11); | 965 | uint mode = StreamBits(11); |
| 1034 | if ((mode & 0x1ff) == 0x1fc) { | 966 | if ((mode & 0x1ff) == 0x1fc) { |
| @@ -1110,10 +1042,10 @@ TexelWeightParams DecodeBlockInfo(uint block_index) { | |||
| 1110 | } | 1042 | } |
| 1111 | weight_index -= 2; | 1043 | weight_index -= 2; |
| 1112 | if ((mode_layout != 9) && ((mode & 0x200) != 0)) { | 1044 | if ((mode_layout != 9) && ((mode & 0x200) != 0)) { |
| 1113 | const int max_weights[6] = int[6](9, 11, 15, 19, 23, 31); | 1045 | const int max_weights[6] = int[6](7, 8, 9, 10, 11, 12); |
| 1114 | params.max_weight = max_weights[weight_index]; | 1046 | params.max_weight = max_weights[weight_index]; |
| 1115 | } else { | 1047 | } else { |
| 1116 | const int max_weights[6] = int[6](1, 2, 3, 4, 5, 7); | 1048 | const int max_weights[6] = int[6](1, 2, 3, 4, 5, 6); |
| 1117 | params.max_weight = max_weights[weight_index]; | 1049 | params.max_weight = max_weights[weight_index]; |
| 1118 | } | 1050 | } |
| 1119 | return params; | 1051 | return params; |
| @@ -1144,8 +1076,8 @@ void FillVoidExtentLDR(ivec3 coord) { | |||
| 1144 | } | 1076 | } |
| 1145 | } | 1077 | } |
| 1146 | 1078 | ||
| 1147 | void DecompressBlock(ivec3 coord, uint block_index) { | 1079 | void DecompressBlock(ivec3 coord) { |
| 1148 | TexelWeightParams params = DecodeBlockInfo(block_index); | 1080 | TexelWeightParams params = DecodeBlockInfo(); |
| 1149 | if (params.error_state) { | 1081 | if (params.error_state) { |
| 1150 | FillError(coord); | 1082 | FillError(coord); |
| 1151 | return; | 1083 | return; |
| @@ -1212,7 +1144,7 @@ void DecompressBlock(ivec3 coord, uint block_index) { | |||
| 1212 | // Read color data... | 1144 | // Read color data... |
| 1213 | uint color_data_bits = remaining_bits; | 1145 | uint color_data_bits = remaining_bits; |
| 1214 | while (remaining_bits > 0) { | 1146 | while (remaining_bits > 0) { |
| 1215 | int nb = int(min(remaining_bits, 8U)); | 1147 | int nb = int(min(remaining_bits, 32U)); |
| 1216 | uint b = StreamBits(nb); | 1148 | uint b = StreamBits(nb); |
| 1217 | color_endpoint_data[ced_pointer] = uint(bitfieldExtract(b, 0, nb)); | 1149 | color_endpoint_data[ced_pointer] = uint(bitfieldExtract(b, 0, nb)); |
| 1218 | ++ced_pointer; | 1150 | ++ced_pointer; |
| @@ -1254,25 +1186,20 @@ void DecompressBlock(ivec3 coord, uint block_index) { | |||
| 1254 | ComputeEndpoints(endpoints[i][0], endpoints[i][1], color_endpoint_mode[i]); | 1186 | ComputeEndpoints(endpoints[i][0], endpoints[i][1], color_endpoint_mode[i]); |
| 1255 | } | 1187 | } |
| 1256 | 1188 | ||
| 1257 | for (uint i = 0; i < 16; i++) { | 1189 | texel_weight_data = local_buff; |
| 1258 | texel_weight_data[i] = local_buff[i]; | 1190 | texel_weight_data = bitfieldReverse(texel_weight_data).wzyx; |
| 1259 | } | ||
| 1260 | for (uint i = 0; i < 8; i++) { | ||
| 1261 | #define REVERSE_BYTE(b) ((b * 0x0802U & 0x22110U) | (b * 0x8020U & 0x88440U)) * 0x10101U >> 16 | ||
| 1262 | uint a = REVERSE_BYTE(texel_weight_data[i]); | ||
| 1263 | uint b = REVERSE_BYTE(texel_weight_data[15 - i]); | ||
| 1264 | #undef REVERSE_BYTE | ||
| 1265 | texel_weight_data[i] = uint(bitfieldExtract(b, 0, 8)); | ||
| 1266 | texel_weight_data[15 - i] = uint(bitfieldExtract(a, 0, 8)); | ||
| 1267 | } | ||
| 1268 | uint clear_byte_start = | 1191 | uint clear_byte_start = |
| 1269 | (GetPackedBitSize(params.size, params.dual_plane, params.max_weight) >> 3) + 1; | 1192 | (GetPackedBitSize(params.size, params.dual_plane, params.max_weight) >> 3) + 1; |
| 1270 | texel_weight_data[clear_byte_start - 1] = | 1193 | |
| 1271 | texel_weight_data[clear_byte_start - 1] & | 1194 | uint byte_insert = ExtractBits(texel_weight_data, int(clear_byte_start - 1) * 8, 8) & |
| 1272 | uint( | 1195 | uint( |
| 1273 | ((1 << (GetPackedBitSize(params.size, params.dual_plane, params.max_weight) % 8)) - 1)); | 1196 | ((1 << (GetPackedBitSize(params.size, params.dual_plane, params.max_weight) % 8)) - 1)); |
| 1274 | for (uint i = 0; i < 16 - clear_byte_start; i++) { | 1197 | uint vec_index = (clear_byte_start - 1) >> 2; |
| 1275 | texel_weight_data[clear_byte_start + i] = 0U; | 1198 | texel_weight_data[vec_index] = |
| 1199 | bitfieldInsert(texel_weight_data[vec_index], byte_insert, int((clear_byte_start - 1) % 4) * 8, 8); | ||
| 1200 | for (uint i = clear_byte_start; i < 16; ++i) { | ||
| 1201 | uint idx = i >> 2; | ||
| 1202 | texel_weight_data[idx] = bitfieldInsert(texel_weight_data[idx], 0, int(i % 4) * 8, 8); | ||
| 1276 | } | 1203 | } |
| 1277 | texel_flag = true; // use texel "vector" and bit stream in integer decoding | 1204 | texel_flag = true; // use texel "vector" and bit stream in integer decoding |
| 1278 | DecodeIntegerSequence(params.max_weight, GetNumWeightValues(params.size, params.dual_plane)); | 1205 | DecodeIntegerSequence(params.max_weight, GetNumWeightValues(params.size, params.dual_plane)); |
| @@ -1281,8 +1208,11 @@ void DecompressBlock(ivec3 coord, uint block_index) { | |||
| 1281 | 1208 | ||
| 1282 | for (uint j = 0; j < block_dims.y; j++) { | 1209 | for (uint j = 0; j < block_dims.y; j++) { |
| 1283 | for (uint i = 0; i < block_dims.x; i++) { | 1210 | for (uint i = 0; i < block_dims.x; i++) { |
| 1284 | uint local_partition = Select2DPartition(partition_index, i, j, num_partitions, | 1211 | uint local_partition = 0; |
| 1212 | if (num_partitions > 1) { | ||
| 1213 | local_partition = Select2DPartition(partition_index, i, j, num_partitions, | ||
| 1285 | (block_dims.y * block_dims.x) < 32); | 1214 | (block_dims.y * block_dims.x) < 32); |
| 1215 | } | ||
| 1286 | vec4 p; | 1216 | vec4 p; |
| 1287 | uvec4 C0 = ReplicateByteTo16(endpoints[local_partition][0]); | 1217 | uvec4 C0 = ReplicateByteTo16(endpoints[local_partition][0]); |
| 1288 | uvec4 C1 = ReplicateByteTo16(endpoints[local_partition][1]); | 1218 | uvec4 C1 = ReplicateByteTo16(endpoints[local_partition][1]); |
| @@ -1303,7 +1233,7 @@ void DecompressBlock(ivec3 coord, uint block_index) { | |||
| 1303 | 1233 | ||
| 1304 | void main() { | 1234 | void main() { |
| 1305 | uvec3 pos = gl_GlobalInvocationID; | 1235 | uvec3 pos = gl_GlobalInvocationID; |
| 1306 | pos.x <<= bytes_per_block_log2; | 1236 | pos.x <<= BYTES_PER_BLOCK_LOG2; |
| 1307 | 1237 | ||
| 1308 | // Read as soon as possible due to its latency | 1238 | // Read as soon as possible due to its latency |
| 1309 | const uint swizzle = SwizzleOffset(pos.xy); | 1239 | const uint swizzle = SwizzleOffset(pos.xy); |
| @@ -1321,13 +1251,8 @@ void main() { | |||
| 1321 | if (any(greaterThanEqual(coord, imageSize(dest_image)))) { | 1251 | if (any(greaterThanEqual(coord, imageSize(dest_image)))) { |
| 1322 | return; | 1252 | return; |
| 1323 | } | 1253 | } |
| 1324 | uint block_index = | ||
| 1325 | pos.z * gl_WorkGroupSize.x * gl_WorkGroupSize.y + pos.y * gl_WorkGroupSize.x + pos.x; | ||
| 1326 | |||
| 1327 | current_index = 0; | 1254 | current_index = 0; |
| 1328 | bitsread = 0; | 1255 | bitsread = 0; |
| 1329 | for (int i = 0; i < 16; i++) { | 1256 | local_buff = astc_data[offset / 16]; |
| 1330 | local_buff[i] = ReadTexel(offset + i); | 1257 | DecompressBlock(coord); |
| 1331 | } | ||
| 1332 | DecompressBlock(coord, block_index); | ||
| 1333 | } | 1258 | } |
diff --git a/src/video_core/renderer_opengl/util_shaders.cpp b/src/video_core/renderer_opengl/util_shaders.cpp index 37a4d1d9d..333f35a1c 100644 --- a/src/video_core/renderer_opengl/util_shaders.cpp +++ b/src/video_core/renderer_opengl/util_shaders.cpp | |||
| @@ -60,19 +60,14 @@ UtilShaders::UtilShaders(ProgramManager& program_manager_) | |||
| 60 | copy_bc4_program(MakeProgram(OPENGL_COPY_BC4_COMP)) { | 60 | copy_bc4_program(MakeProgram(OPENGL_COPY_BC4_COMP)) { |
| 61 | const auto swizzle_table = Tegra::Texture::MakeSwizzleTable(); | 61 | const auto swizzle_table = Tegra::Texture::MakeSwizzleTable(); |
| 62 | swizzle_table_buffer.Create(); | 62 | swizzle_table_buffer.Create(); |
| 63 | astc_buffer.Create(); | ||
| 64 | glNamedBufferStorage(swizzle_table_buffer.handle, sizeof(swizzle_table), &swizzle_table, 0); | 63 | glNamedBufferStorage(swizzle_table_buffer.handle, sizeof(swizzle_table), &swizzle_table, 0); |
| 65 | glNamedBufferStorage(astc_buffer.handle, sizeof(ASTC_ENCODINGS_VALUES), &ASTC_ENCODINGS_VALUES, | ||
| 66 | 0); | ||
| 67 | } | 64 | } |
| 68 | 65 | ||
| 69 | UtilShaders::~UtilShaders() = default; | 66 | UtilShaders::~UtilShaders() = default; |
| 70 | 67 | ||
| 71 | void UtilShaders::ASTCDecode(Image& image, const ImageBufferMap& map, | 68 | void UtilShaders::ASTCDecode(Image& image, const ImageBufferMap& map, |
| 72 | std::span<const VideoCommon::SwizzleParameters> swizzles) { | 69 | std::span<const VideoCommon::SwizzleParameters> swizzles) { |
| 73 | static constexpr GLuint BINDING_SWIZZLE_BUFFER = 0; | 70 | static constexpr GLuint BINDING_INPUT_BUFFER = 0; |
| 74 | static constexpr GLuint BINDING_INPUT_BUFFER = 1; | ||
| 75 | static constexpr GLuint BINDING_ENC_BUFFER = 2; | ||
| 76 | static constexpr GLuint BINDING_OUTPUT_IMAGE = 0; | 71 | static constexpr GLuint BINDING_OUTPUT_IMAGE = 0; |
| 77 | 72 | ||
| 78 | const Extent2D tile_size{ | 73 | const Extent2D tile_size{ |
| @@ -80,34 +75,32 @@ void UtilShaders::ASTCDecode(Image& image, const ImageBufferMap& map, | |||
| 80 | .height = VideoCore::Surface::DefaultBlockHeight(image.info.format), | 75 | .height = VideoCore::Surface::DefaultBlockHeight(image.info.format), |
| 81 | }; | 76 | }; |
| 82 | program_manager.BindComputeProgram(astc_decoder_program.handle); | 77 | program_manager.BindComputeProgram(astc_decoder_program.handle); |
| 83 | glBindBufferBase(GL_SHADER_STORAGE_BUFFER, BINDING_SWIZZLE_BUFFER, swizzle_table_buffer.handle); | ||
| 84 | glBindBufferBase(GL_SHADER_STORAGE_BUFFER, BINDING_ENC_BUFFER, astc_buffer.handle); | ||
| 85 | |||
| 86 | glFlushMappedNamedBufferRange(map.buffer, map.offset, image.guest_size_bytes); | 78 | glFlushMappedNamedBufferRange(map.buffer, map.offset, image.guest_size_bytes); |
| 87 | glUniform2ui(1, tile_size.width, tile_size.height); | 79 | glUniform2ui(1, tile_size.width, tile_size.height); |
| 80 | |||
| 88 | // Ensure buffer data is valid before dispatching | 81 | // Ensure buffer data is valid before dispatching |
| 89 | glFlush(); | 82 | glFlush(); |
| 90 | for (const SwizzleParameters& swizzle : swizzles) { | 83 | for (const SwizzleParameters& swizzle : swizzles) { |
| 91 | const size_t input_offset = swizzle.buffer_offset + map.offset; | 84 | const size_t input_offset = swizzle.buffer_offset + map.offset; |
| 92 | const u32 num_dispatches_x = Common::DivCeil(swizzle.num_tiles.width, 32U); | 85 | const u32 num_dispatches_x = Common::DivCeil(swizzle.num_tiles.width, 8U); |
| 93 | const u32 num_dispatches_y = Common::DivCeil(swizzle.num_tiles.height, 32U); | 86 | const u32 num_dispatches_y = Common::DivCeil(swizzle.num_tiles.height, 8U); |
| 94 | 87 | ||
| 95 | const auto params = MakeBlockLinearSwizzle2DParams(swizzle, image.info); | 88 | const auto params = MakeBlockLinearSwizzle2DParams(swizzle, image.info); |
| 96 | ASSERT(params.origin == (std::array<u32, 3>{0, 0, 0})); | 89 | ASSERT(params.origin == (std::array<u32, 3>{0, 0, 0})); |
| 97 | ASSERT(params.destination == (std::array<s32, 3>{0, 0, 0})); | 90 | ASSERT(params.destination == (std::array<s32, 3>{0, 0, 0})); |
| 91 | ASSERT(params.bytes_per_block_log2 == 4); | ||
| 98 | 92 | ||
| 99 | glUniform1ui(2, params.bytes_per_block_log2); | 93 | glUniform1ui(2, params.layer_stride); |
| 100 | glUniform1ui(3, params.layer_stride); | 94 | glUniform1ui(3, params.block_size); |
| 101 | glUniform1ui(4, params.block_size); | 95 | glUniform1ui(4, params.x_shift); |
| 102 | glUniform1ui(5, params.x_shift); | 96 | glUniform1ui(5, params.block_height); |
| 103 | glUniform1ui(6, params.block_height); | 97 | glUniform1ui(6, params.block_height_mask); |
| 104 | glUniform1ui(7, params.block_height_mask); | ||
| 105 | 98 | ||
| 106 | glBindImageTexture(BINDING_OUTPUT_IMAGE, image.StorageHandle(), swizzle.level, GL_TRUE, 0, | ||
| 107 | GL_WRITE_ONLY, GL_RGBA8); | ||
| 108 | // ASTC texture data | 99 | // ASTC texture data |
| 109 | glBindBufferRange(GL_SHADER_STORAGE_BUFFER, BINDING_INPUT_BUFFER, map.buffer, input_offset, | 100 | glBindBufferRange(GL_SHADER_STORAGE_BUFFER, BINDING_INPUT_BUFFER, map.buffer, input_offset, |
| 110 | image.guest_size_bytes - swizzle.buffer_offset); | 101 | image.guest_size_bytes - swizzle.buffer_offset); |
| 102 | glBindImageTexture(BINDING_OUTPUT_IMAGE, image.StorageHandle(), swizzle.level, GL_TRUE, 0, | ||
| 103 | GL_WRITE_ONLY, GL_RGBA8); | ||
| 111 | 104 | ||
| 112 | glDispatchCompute(num_dispatches_x, num_dispatches_y, image.info.resources.layers); | 105 | glDispatchCompute(num_dispatches_x, num_dispatches_y, image.info.resources.layers); |
| 113 | } | 106 | } |
diff --git a/src/video_core/renderer_opengl/util_shaders.h b/src/video_core/renderer_opengl/util_shaders.h index 53d65f368..ef881e35f 100644 --- a/src/video_core/renderer_opengl/util_shaders.h +++ b/src/video_core/renderer_opengl/util_shaders.h | |||
| @@ -62,7 +62,6 @@ private: | |||
| 62 | ProgramManager& program_manager; | 62 | ProgramManager& program_manager; |
| 63 | 63 | ||
| 64 | OGLBuffer swizzle_table_buffer; | 64 | OGLBuffer swizzle_table_buffer; |
| 65 | OGLBuffer astc_buffer; | ||
| 66 | 65 | ||
| 67 | OGLProgram astc_decoder_program; | 66 | OGLProgram astc_decoder_program; |
| 68 | OGLProgram block_linear_unswizzle_2d_program; | 67 | OGLProgram block_linear_unswizzle_2d_program; |
diff --git a/src/video_core/renderer_vulkan/vk_compute_pass.cpp b/src/video_core/renderer_vulkan/vk_compute_pass.cpp index 561cf5e11..3e96c0f60 100644 --- a/src/video_core/renderer_vulkan/vk_compute_pass.cpp +++ b/src/video_core/renderer_vulkan/vk_compute_pass.cpp | |||
| @@ -30,16 +30,12 @@ | |||
| 30 | namespace Vulkan { | 30 | namespace Vulkan { |
| 31 | 31 | ||
| 32 | using Tegra::Texture::SWIZZLE_TABLE; | 32 | using Tegra::Texture::SWIZZLE_TABLE; |
| 33 | using Tegra::Texture::ASTC::ASTC_ENCODINGS_VALUES; | ||
| 34 | using namespace Tegra::Texture::ASTC; | ||
| 35 | 33 | ||
| 36 | namespace { | 34 | namespace { |
| 37 | 35 | ||
| 38 | constexpr u32 ASTC_BINDING_INPUT_BUFFER = 0; | 36 | constexpr u32 ASTC_BINDING_INPUT_BUFFER = 0; |
| 39 | constexpr u32 ASTC_BINDING_ENC_BUFFER = 1; | 37 | constexpr u32 ASTC_BINDING_OUTPUT_IMAGE = 1; |
| 40 | constexpr u32 ASTC_BINDING_SWIZZLE_BUFFER = 2; | 38 | constexpr size_t ASTC_NUM_BINDINGS = 2; |
| 41 | constexpr u32 ASTC_BINDING_OUTPUT_IMAGE = 3; | ||
| 42 | constexpr size_t ASTC_NUM_BINDINGS = 4; | ||
| 43 | 39 | ||
| 44 | template <size_t size> | 40 | template <size_t size> |
| 45 | inline constexpr VkPushConstantRange COMPUTE_PUSH_CONSTANT_RANGE{ | 41 | inline constexpr VkPushConstantRange COMPUTE_PUSH_CONSTANT_RANGE{ |
| @@ -75,7 +71,7 @@ constexpr DescriptorBankInfo INPUT_OUTPUT_BANK_INFO{ | |||
| 75 | .score = 2, | 71 | .score = 2, |
| 76 | }; | 72 | }; |
| 77 | 73 | ||
| 78 | constexpr std::array<VkDescriptorSetLayoutBinding, 4> ASTC_DESCRIPTOR_SET_BINDINGS{{ | 74 | constexpr std::array<VkDescriptorSetLayoutBinding, ASTC_NUM_BINDINGS> ASTC_DESCRIPTOR_SET_BINDINGS{{ |
| 79 | { | 75 | { |
| 80 | .binding = ASTC_BINDING_INPUT_BUFFER, | 76 | .binding = ASTC_BINDING_INPUT_BUFFER, |
| 81 | .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, | 77 | .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, |
| @@ -84,20 +80,6 @@ constexpr std::array<VkDescriptorSetLayoutBinding, 4> ASTC_DESCRIPTOR_SET_BINDIN | |||
| 84 | .pImmutableSamplers = nullptr, | 80 | .pImmutableSamplers = nullptr, |
| 85 | }, | 81 | }, |
| 86 | { | 82 | { |
| 87 | .binding = ASTC_BINDING_ENC_BUFFER, | ||
| 88 | .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, | ||
| 89 | .descriptorCount = 1, | ||
| 90 | .stageFlags = VK_SHADER_STAGE_COMPUTE_BIT, | ||
| 91 | .pImmutableSamplers = nullptr, | ||
| 92 | }, | ||
| 93 | { | ||
| 94 | .binding = ASTC_BINDING_SWIZZLE_BUFFER, | ||
| 95 | .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, | ||
| 96 | .descriptorCount = 1, | ||
| 97 | .stageFlags = VK_SHADER_STAGE_COMPUTE_BIT, | ||
| 98 | .pImmutableSamplers = nullptr, | ||
| 99 | }, | ||
| 100 | { | ||
| 101 | .binding = ASTC_BINDING_OUTPUT_IMAGE, | 83 | .binding = ASTC_BINDING_OUTPUT_IMAGE, |
| 102 | .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE, | 84 | .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE, |
| 103 | .descriptorCount = 1, | 85 | .descriptorCount = 1, |
| @@ -108,12 +90,12 @@ constexpr std::array<VkDescriptorSetLayoutBinding, 4> ASTC_DESCRIPTOR_SET_BINDIN | |||
| 108 | 90 | ||
| 109 | constexpr DescriptorBankInfo ASTC_BANK_INFO{ | 91 | constexpr DescriptorBankInfo ASTC_BANK_INFO{ |
| 110 | .uniform_buffers = 0, | 92 | .uniform_buffers = 0, |
| 111 | .storage_buffers = 3, | 93 | .storage_buffers = 1, |
| 112 | .texture_buffers = 0, | 94 | .texture_buffers = 0, |
| 113 | .image_buffers = 0, | 95 | .image_buffers = 0, |
| 114 | .textures = 0, | 96 | .textures = 0, |
| 115 | .images = 1, | 97 | .images = 1, |
| 116 | .score = 4, | 98 | .score = 2, |
| 117 | }; | 99 | }; |
| 118 | 100 | ||
| 119 | constexpr VkDescriptorUpdateTemplateEntryKHR INPUT_OUTPUT_DESCRIPTOR_UPDATE_TEMPLATE{ | 101 | constexpr VkDescriptorUpdateTemplateEntryKHR INPUT_OUTPUT_DESCRIPTOR_UPDATE_TEMPLATE{ |
| @@ -136,22 +118,6 @@ constexpr std::array<VkDescriptorUpdateTemplateEntryKHR, ASTC_NUM_BINDINGS> | |||
| 136 | .stride = sizeof(DescriptorUpdateEntry), | 118 | .stride = sizeof(DescriptorUpdateEntry), |
| 137 | }, | 119 | }, |
| 138 | { | 120 | { |
| 139 | .dstBinding = ASTC_BINDING_ENC_BUFFER, | ||
| 140 | .dstArrayElement = 0, | ||
| 141 | .descriptorCount = 1, | ||
| 142 | .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, | ||
| 143 | .offset = ASTC_BINDING_ENC_BUFFER * sizeof(DescriptorUpdateEntry), | ||
| 144 | .stride = sizeof(DescriptorUpdateEntry), | ||
| 145 | }, | ||
| 146 | { | ||
| 147 | .dstBinding = ASTC_BINDING_SWIZZLE_BUFFER, | ||
| 148 | .dstArrayElement = 0, | ||
| 149 | .descriptorCount = 1, | ||
| 150 | .descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, | ||
| 151 | .offset = ASTC_BINDING_SWIZZLE_BUFFER * sizeof(DescriptorUpdateEntry), | ||
| 152 | .stride = sizeof(DescriptorUpdateEntry), | ||
| 153 | }, | ||
| 154 | { | ||
| 155 | .dstBinding = ASTC_BINDING_OUTPUT_IMAGE, | 121 | .dstBinding = ASTC_BINDING_OUTPUT_IMAGE, |
| 156 | .dstArrayElement = 0, | 122 | .dstArrayElement = 0, |
| 157 | .descriptorCount = 1, | 123 | .descriptorCount = 1, |
| @@ -163,7 +129,6 @@ constexpr std::array<VkDescriptorUpdateTemplateEntryKHR, ASTC_NUM_BINDINGS> | |||
| 163 | 129 | ||
| 164 | struct AstcPushConstants { | 130 | struct AstcPushConstants { |
| 165 | std::array<u32, 2> blocks_dims; | 131 | std::array<u32, 2> blocks_dims; |
| 166 | u32 bytes_per_block_log2; | ||
| 167 | u32 layer_stride; | 132 | u32 layer_stride; |
| 168 | u32 block_size; | 133 | u32 block_size; |
| 169 | u32 x_shift; | 134 | u32 x_shift; |
| @@ -354,46 +319,6 @@ ASTCDecoderPass::ASTCDecoderPass(const Device& device_, VKScheduler& scheduler_, | |||
| 354 | 319 | ||
| 355 | ASTCDecoderPass::~ASTCDecoderPass() = default; | 320 | ASTCDecoderPass::~ASTCDecoderPass() = default; |
| 356 | 321 | ||
| 357 | void ASTCDecoderPass::MakeDataBuffer() { | ||
| 358 | constexpr size_t TOTAL_BUFFER_SIZE = sizeof(ASTC_ENCODINGS_VALUES) + sizeof(SWIZZLE_TABLE); | ||
| 359 | data_buffer = device.GetLogical().CreateBuffer(VkBufferCreateInfo{ | ||
| 360 | .sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO, | ||
| 361 | .pNext = nullptr, | ||
| 362 | .flags = 0, | ||
| 363 | .size = TOTAL_BUFFER_SIZE, | ||
| 364 | .usage = VK_BUFFER_USAGE_STORAGE_BUFFER_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT, | ||
| 365 | .sharingMode = VK_SHARING_MODE_EXCLUSIVE, | ||
| 366 | .queueFamilyIndexCount = 0, | ||
| 367 | .pQueueFamilyIndices = nullptr, | ||
| 368 | }); | ||
| 369 | data_buffer_commit = memory_allocator.Commit(data_buffer, MemoryUsage::Upload); | ||
| 370 | |||
| 371 | const auto staging_ref = staging_buffer_pool.Request(TOTAL_BUFFER_SIZE, MemoryUsage::Upload); | ||
| 372 | std::memcpy(staging_ref.mapped_span.data(), &ASTC_ENCODINGS_VALUES, | ||
| 373 | sizeof(ASTC_ENCODINGS_VALUES)); | ||
| 374 | // Tack on the swizzle table at the end of the buffer | ||
| 375 | std::memcpy(staging_ref.mapped_span.data() + sizeof(ASTC_ENCODINGS_VALUES), &SWIZZLE_TABLE, | ||
| 376 | sizeof(SWIZZLE_TABLE)); | ||
| 377 | |||
| 378 | scheduler.Record([src = staging_ref.buffer, offset = staging_ref.offset, dst = *data_buffer, | ||
| 379 | TOTAL_BUFFER_SIZE](vk::CommandBuffer cmdbuf) { | ||
| 380 | static constexpr VkMemoryBarrier write_barrier{ | ||
| 381 | .sType = VK_STRUCTURE_TYPE_MEMORY_BARRIER, | ||
| 382 | .pNext = nullptr, | ||
| 383 | .srcAccessMask = VK_ACCESS_TRANSFER_WRITE_BIT, | ||
| 384 | .dstAccessMask = VK_ACCESS_SHADER_READ_BIT, | ||
| 385 | }; | ||
| 386 | const VkBufferCopy copy{ | ||
| 387 | .srcOffset = offset, | ||
| 388 | .dstOffset = 0, | ||
| 389 | .size = TOTAL_BUFFER_SIZE, | ||
| 390 | }; | ||
| 391 | cmdbuf.CopyBuffer(src, dst, copy); | ||
| 392 | cmdbuf.PipelineBarrier(VK_PIPELINE_STAGE_TRANSFER_BIT, VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, | ||
| 393 | 0, write_barrier); | ||
| 394 | }); | ||
| 395 | } | ||
| 396 | |||
| 397 | void ASTCDecoderPass::Assemble(Image& image, const StagingBufferRef& map, | 322 | void ASTCDecoderPass::Assemble(Image& image, const StagingBufferRef& map, |
| 398 | std::span<const VideoCommon::SwizzleParameters> swizzles) { | 323 | std::span<const VideoCommon::SwizzleParameters> swizzles) { |
| 399 | using namespace VideoCommon::Accelerated; | 324 | using namespace VideoCommon::Accelerated; |
| @@ -402,9 +327,6 @@ void ASTCDecoderPass::Assemble(Image& image, const StagingBufferRef& map, | |||
| 402 | VideoCore::Surface::DefaultBlockHeight(image.info.format), | 327 | VideoCore::Surface::DefaultBlockHeight(image.info.format), |
| 403 | }; | 328 | }; |
| 404 | scheduler.RequestOutsideRenderPassOperationContext(); | 329 | scheduler.RequestOutsideRenderPassOperationContext(); |
| 405 | if (!data_buffer) { | ||
| 406 | MakeDataBuffer(); | ||
| 407 | } | ||
| 408 | const VkPipeline vk_pipeline = *pipeline; | 330 | const VkPipeline vk_pipeline = *pipeline; |
| 409 | const VkImageAspectFlags aspect_mask = image.AspectMask(); | 331 | const VkImageAspectFlags aspect_mask = image.AspectMask(); |
| 410 | const VkImage vk_image = image.Handle(); | 332 | const VkImage vk_image = image.Handle(); |
| @@ -436,16 +358,13 @@ void ASTCDecoderPass::Assemble(Image& image, const StagingBufferRef& map, | |||
| 436 | }); | 358 | }); |
| 437 | for (const VideoCommon::SwizzleParameters& swizzle : swizzles) { | 359 | for (const VideoCommon::SwizzleParameters& swizzle : swizzles) { |
| 438 | const size_t input_offset = swizzle.buffer_offset + map.offset; | 360 | const size_t input_offset = swizzle.buffer_offset + map.offset; |
| 439 | const u32 num_dispatches_x = Common::DivCeil(swizzle.num_tiles.width, 32U); | 361 | const u32 num_dispatches_x = Common::DivCeil(swizzle.num_tiles.width, 8U); |
| 440 | const u32 num_dispatches_y = Common::DivCeil(swizzle.num_tiles.height, 32U); | 362 | const u32 num_dispatches_y = Common::DivCeil(swizzle.num_tiles.height, 8U); |
| 441 | const u32 num_dispatches_z = image.info.resources.layers; | 363 | const u32 num_dispatches_z = image.info.resources.layers; |
| 442 | 364 | ||
| 443 | update_descriptor_queue.Acquire(); | 365 | update_descriptor_queue.Acquire(); |
| 444 | update_descriptor_queue.AddBuffer(map.buffer, input_offset, | 366 | update_descriptor_queue.AddBuffer(map.buffer, input_offset, |
| 445 | image.guest_size_bytes - swizzle.buffer_offset); | 367 | image.guest_size_bytes - swizzle.buffer_offset); |
| 446 | update_descriptor_queue.AddBuffer(*data_buffer, 0, sizeof(ASTC_ENCODINGS_VALUES)); | ||
| 447 | update_descriptor_queue.AddBuffer(*data_buffer, sizeof(ASTC_ENCODINGS_VALUES), | ||
| 448 | sizeof(SWIZZLE_TABLE)); | ||
| 449 | update_descriptor_queue.AddImage(image.StorageImageView(swizzle.level)); | 368 | update_descriptor_queue.AddImage(image.StorageImageView(swizzle.level)); |
| 450 | const void* const descriptor_data{update_descriptor_queue.UpdateData()}; | 369 | const void* const descriptor_data{update_descriptor_queue.UpdateData()}; |
| 451 | 370 | ||
| @@ -453,11 +372,11 @@ void ASTCDecoderPass::Assemble(Image& image, const StagingBufferRef& map, | |||
| 453 | const auto params = MakeBlockLinearSwizzle2DParams(swizzle, image.info); | 372 | const auto params = MakeBlockLinearSwizzle2DParams(swizzle, image.info); |
| 454 | ASSERT(params.origin == (std::array<u32, 3>{0, 0, 0})); | 373 | ASSERT(params.origin == (std::array<u32, 3>{0, 0, 0})); |
| 455 | ASSERT(params.destination == (std::array<s32, 3>{0, 0, 0})); | 374 | ASSERT(params.destination == (std::array<s32, 3>{0, 0, 0})); |
| 375 | ASSERT(params.bytes_per_block_log2 == 4); | ||
| 456 | scheduler.Record([this, num_dispatches_x, num_dispatches_y, num_dispatches_z, block_dims, | 376 | scheduler.Record([this, num_dispatches_x, num_dispatches_y, num_dispatches_z, block_dims, |
| 457 | params, descriptor_data](vk::CommandBuffer cmdbuf) { | 377 | params, descriptor_data](vk::CommandBuffer cmdbuf) { |
| 458 | const AstcPushConstants uniforms{ | 378 | const AstcPushConstants uniforms{ |
| 459 | .blocks_dims = block_dims, | 379 | .blocks_dims = block_dims, |
| 460 | .bytes_per_block_log2 = params.bytes_per_block_log2, | ||
| 461 | .layer_stride = params.layer_stride, | 380 | .layer_stride = params.layer_stride, |
| 462 | .block_size = params.block_size, | 381 | .block_size = params.block_size, |
| 463 | .x_shift = params.x_shift, | 382 | .x_shift = params.x_shift, |
diff --git a/src/video_core/renderer_vulkan/vk_compute_pass.h b/src/video_core/renderer_vulkan/vk_compute_pass.h index 114aef2bd..c7b92cce0 100644 --- a/src/video_core/renderer_vulkan/vk_compute_pass.h +++ b/src/video_core/renderer_vulkan/vk_compute_pass.h | |||
| @@ -96,15 +96,10 @@ public: | |||
| 96 | std::span<const VideoCommon::SwizzleParameters> swizzles); | 96 | std::span<const VideoCommon::SwizzleParameters> swizzles); |
| 97 | 97 | ||
| 98 | private: | 98 | private: |
| 99 | void MakeDataBuffer(); | ||
| 100 | |||
| 101 | VKScheduler& scheduler; | 99 | VKScheduler& scheduler; |
| 102 | StagingBufferPool& staging_buffer_pool; | 100 | StagingBufferPool& staging_buffer_pool; |
| 103 | VKUpdateDescriptorQueue& update_descriptor_queue; | 101 | VKUpdateDescriptorQueue& update_descriptor_queue; |
| 104 | MemoryAllocator& memory_allocator; | 102 | MemoryAllocator& memory_allocator; |
| 105 | |||
| 106 | vk::Buffer data_buffer; | ||
| 107 | MemoryCommit data_buffer_commit; | ||
| 108 | }; | 103 | }; |
| 109 | 104 | ||
| 110 | } // namespace Vulkan | 105 | } // namespace Vulkan |
diff --git a/src/video_core/textures/astc.cpp b/src/video_core/textures/astc.cpp index 3ab500760..25161df1f 100644 --- a/src/video_core/textures/astc.cpp +++ b/src/video_core/textures/astc.cpp | |||
| @@ -151,6 +151,76 @@ private: | |||
| 151 | const IntType& m_Bits; | 151 | const IntType& m_Bits; |
| 152 | }; | 152 | }; |
| 153 | 153 | ||
| 154 | enum class IntegerEncoding { JustBits, Quint, Trit }; | ||
| 155 | |||
| 156 | struct IntegerEncodedValue { | ||
| 157 | constexpr IntegerEncodedValue() = default; | ||
| 158 | |||
| 159 | constexpr IntegerEncodedValue(IntegerEncoding encoding_, u32 num_bits_) | ||
| 160 | : encoding{encoding_}, num_bits{num_bits_} {} | ||
| 161 | |||
| 162 | constexpr bool MatchesEncoding(const IntegerEncodedValue& other) const { | ||
| 163 | return encoding == other.encoding && num_bits == other.num_bits; | ||
| 164 | } | ||
| 165 | |||
| 166 | // Returns the number of bits required to encode num_vals values. | ||
| 167 | u32 GetBitLength(u32 num_vals) const { | ||
| 168 | u32 total_bits = num_bits * num_vals; | ||
| 169 | if (encoding == IntegerEncoding::Trit) { | ||
| 170 | total_bits += (num_vals * 8 + 4) / 5; | ||
| 171 | } else if (encoding == IntegerEncoding::Quint) { | ||
| 172 | total_bits += (num_vals * 7 + 2) / 3; | ||
| 173 | } | ||
| 174 | return total_bits; | ||
| 175 | } | ||
| 176 | |||
| 177 | IntegerEncoding encoding{}; | ||
| 178 | u32 num_bits = 0; | ||
| 179 | u32 bit_value = 0; | ||
| 180 | union { | ||
| 181 | u32 quint_value = 0; | ||
| 182 | u32 trit_value; | ||
| 183 | }; | ||
| 184 | }; | ||
| 185 | |||
| 186 | // Returns a new instance of this struct that corresponds to the | ||
| 187 | // can take no more than mav_value values | ||
| 188 | static constexpr IntegerEncodedValue CreateEncoding(u32 mav_value) { | ||
| 189 | while (mav_value > 0) { | ||
| 190 | u32 check = mav_value + 1; | ||
| 191 | |||
| 192 | // Is mav_value a power of two? | ||
| 193 | if (!(check & (check - 1))) { | ||
| 194 | return IntegerEncodedValue(IntegerEncoding::JustBits, std::popcount(mav_value)); | ||
| 195 | } | ||
| 196 | |||
| 197 | // Is mav_value of the type 3*2^n - 1? | ||
| 198 | if ((check % 3 == 0) && !((check / 3) & ((check / 3) - 1))) { | ||
| 199 | return IntegerEncodedValue(IntegerEncoding::Trit, std::popcount(check / 3 - 1)); | ||
| 200 | } | ||
| 201 | |||
| 202 | // Is mav_value of the type 5*2^n - 1? | ||
| 203 | if ((check % 5 == 0) && !((check / 5) & ((check / 5) - 1))) { | ||
| 204 | return IntegerEncodedValue(IntegerEncoding::Quint, std::popcount(check / 5 - 1)); | ||
| 205 | } | ||
| 206 | |||
| 207 | // Apparently it can't be represented with a bounded integer sequence... | ||
| 208 | // just iterate. | ||
| 209 | mav_value--; | ||
| 210 | } | ||
| 211 | return IntegerEncodedValue(IntegerEncoding::JustBits, 0); | ||
| 212 | } | ||
| 213 | |||
| 214 | static constexpr std::array<IntegerEncodedValue, 256> MakeEncodedValues() { | ||
| 215 | std::array<IntegerEncodedValue, 256> encodings{}; | ||
| 216 | for (std::size_t i = 0; i < encodings.size(); ++i) { | ||
| 217 | encodings[i] = CreateEncoding(static_cast<u32>(i)); | ||
| 218 | } | ||
| 219 | return encodings; | ||
| 220 | } | ||
| 221 | |||
| 222 | static constexpr std::array<IntegerEncodedValue, 256> ASTC_ENCODINGS_VALUES = MakeEncodedValues(); | ||
| 223 | |||
| 154 | namespace Tegra::Texture::ASTC { | 224 | namespace Tegra::Texture::ASTC { |
| 155 | using IntegerEncodedVector = boost::container::static_vector< | 225 | using IntegerEncodedVector = boost::container::static_vector< |
| 156 | IntegerEncodedValue, 256, | 226 | IntegerEncodedValue, 256, |
| @@ -521,35 +591,41 @@ static TexelWeightParams DecodeBlockInfo(InputBitStream& strm) { | |||
| 521 | return params; | 591 | return params; |
| 522 | } | 592 | } |
| 523 | 593 | ||
| 524 | static void FillVoidExtentLDR(InputBitStream& strm, std::span<u32> outBuf, u32 blockWidth, | 594 | // Replicates low num_bits such that [(to_bit - 1):(to_bit - 1 - from_bit)] |
| 525 | u32 blockHeight) { | 595 | // is the same as [(num_bits - 1):0] and repeats all the way down. |
| 526 | // Don't actually care about the void extent, just read the bits... | 596 | template <typename IntType> |
| 527 | for (s32 i = 0; i < 4; ++i) { | 597 | static constexpr IntType Replicate(IntType val, u32 num_bits, u32 to_bit) { |
| 528 | strm.ReadBits<13>(); | 598 | if (num_bits == 0 || to_bit == 0) { |
| 599 | return 0; | ||
| 529 | } | 600 | } |
| 530 | 601 | const IntType v = val & static_cast<IntType>((1 << num_bits) - 1); | |
| 531 | // Decode the RGBA components and renormalize them to the range [0, 255] | 602 | IntType res = v; |
| 532 | u16 r = static_cast<u16>(strm.ReadBits<16>()); | 603 | u32 reslen = num_bits; |
| 533 | u16 g = static_cast<u16>(strm.ReadBits<16>()); | 604 | while (reslen < to_bit) { |
| 534 | u16 b = static_cast<u16>(strm.ReadBits<16>()); | 605 | u32 comp = 0; |
| 535 | u16 a = static_cast<u16>(strm.ReadBits<16>()); | 606 | if (num_bits > to_bit - reslen) { |
| 536 | 607 | u32 newshift = to_bit - reslen; | |
| 537 | u32 rgba = (r >> 8) | (g & 0xFF00) | (static_cast<u32>(b) & 0xFF00) << 8 | | 608 | comp = num_bits - newshift; |
| 538 | (static_cast<u32>(a) & 0xFF00) << 16; | 609 | num_bits = newshift; |
| 539 | |||
| 540 | for (u32 j = 0; j < blockHeight; j++) { | ||
| 541 | for (u32 i = 0; i < blockWidth; i++) { | ||
| 542 | outBuf[j * blockWidth + i] = rgba; | ||
| 543 | } | 610 | } |
| 611 | res = static_cast<IntType>(res << num_bits); | ||
| 612 | res = static_cast<IntType>(res | (v >> comp)); | ||
| 613 | reslen += num_bits; | ||
| 544 | } | 614 | } |
| 615 | return res; | ||
| 545 | } | 616 | } |
| 546 | 617 | ||
| 547 | static void FillError(std::span<u32> outBuf, u32 blockWidth, u32 blockHeight) { | 618 | static constexpr std::size_t NumReplicateEntries(u32 num_bits) { |
| 548 | for (u32 j = 0; j < blockHeight; j++) { | 619 | return std::size_t(1) << num_bits; |
| 549 | for (u32 i = 0; i < blockWidth; i++) { | 620 | } |
| 550 | outBuf[j * blockWidth + i] = 0xFFFF00FF; | 621 | |
| 551 | } | 622 | template <typename IntType, u32 num_bits, u32 to_bit> |
| 623 | static constexpr auto MakeReplicateTable() { | ||
| 624 | std::array<IntType, NumReplicateEntries(num_bits)> table{}; | ||
| 625 | for (IntType value = 0; value < static_cast<IntType>(std::size(table)); ++value) { | ||
| 626 | table[value] = Replicate(value, num_bits, to_bit); | ||
| 552 | } | 627 | } |
| 628 | return table; | ||
| 553 | } | 629 | } |
| 554 | 630 | ||
| 555 | static constexpr auto REPLICATE_BYTE_TO_16_TABLE = MakeReplicateTable<u32, 8, 16>(); | 631 | static constexpr auto REPLICATE_BYTE_TO_16_TABLE = MakeReplicateTable<u32, 8, 16>(); |
| @@ -572,6 +648,9 @@ static constexpr auto REPLICATE_2_BIT_TO_8_TABLE = MakeReplicateTable<u32, 2, 8> | |||
| 572 | static constexpr auto REPLICATE_3_BIT_TO_8_TABLE = MakeReplicateTable<u32, 3, 8>(); | 648 | static constexpr auto REPLICATE_3_BIT_TO_8_TABLE = MakeReplicateTable<u32, 3, 8>(); |
| 573 | static constexpr auto REPLICATE_4_BIT_TO_8_TABLE = MakeReplicateTable<u32, 4, 8>(); | 649 | static constexpr auto REPLICATE_4_BIT_TO_8_TABLE = MakeReplicateTable<u32, 4, 8>(); |
| 574 | static constexpr auto REPLICATE_5_BIT_TO_8_TABLE = MakeReplicateTable<u32, 5, 8>(); | 650 | static constexpr auto REPLICATE_5_BIT_TO_8_TABLE = MakeReplicateTable<u32, 5, 8>(); |
| 651 | static constexpr auto REPLICATE_6_BIT_TO_8_TABLE = MakeReplicateTable<u32, 6, 8>(); | ||
| 652 | static constexpr auto REPLICATE_7_BIT_TO_8_TABLE = MakeReplicateTable<u32, 7, 8>(); | ||
| 653 | static constexpr auto REPLICATE_8_BIT_TO_8_TABLE = MakeReplicateTable<u32, 8, 8>(); | ||
| 575 | /// Use a precompiled table with the most common usages, if it's not in the expected range, fallback | 654 | /// Use a precompiled table with the most common usages, if it's not in the expected range, fallback |
| 576 | /// to the runtime implementation | 655 | /// to the runtime implementation |
| 577 | static constexpr u32 FastReplicateTo8(u32 value, u32 num_bits) { | 656 | static constexpr u32 FastReplicateTo8(u32 value, u32 num_bits) { |
| @@ -1316,6 +1395,37 @@ static void ComputeEndpoints(Pixel& ep1, Pixel& ep2, const u32*& colorValues, | |||
| 1316 | #undef READ_INT_VALUES | 1395 | #undef READ_INT_VALUES |
| 1317 | } | 1396 | } |
| 1318 | 1397 | ||
| 1398 | static void FillVoidExtentLDR(InputBitStream& strm, std::span<u32> outBuf, u32 blockWidth, | ||
| 1399 | u32 blockHeight) { | ||
| 1400 | // Don't actually care about the void extent, just read the bits... | ||
| 1401 | for (s32 i = 0; i < 4; ++i) { | ||
| 1402 | strm.ReadBits<13>(); | ||
| 1403 | } | ||
| 1404 | |||
| 1405 | // Decode the RGBA components and renormalize them to the range [0, 255] | ||
| 1406 | u16 r = static_cast<u16>(strm.ReadBits<16>()); | ||
| 1407 | u16 g = static_cast<u16>(strm.ReadBits<16>()); | ||
| 1408 | u16 b = static_cast<u16>(strm.ReadBits<16>()); | ||
| 1409 | u16 a = static_cast<u16>(strm.ReadBits<16>()); | ||
| 1410 | |||
| 1411 | u32 rgba = (r >> 8) | (g & 0xFF00) | (static_cast<u32>(b) & 0xFF00) << 8 | | ||
| 1412 | (static_cast<u32>(a) & 0xFF00) << 16; | ||
| 1413 | |||
| 1414 | for (u32 j = 0; j < blockHeight; j++) { | ||
| 1415 | for (u32 i = 0; i < blockWidth; i++) { | ||
| 1416 | outBuf[j * blockWidth + i] = rgba; | ||
| 1417 | } | ||
| 1418 | } | ||
| 1419 | } | ||
| 1420 | |||
| 1421 | static void FillError(std::span<u32> outBuf, u32 blockWidth, u32 blockHeight) { | ||
| 1422 | for (u32 j = 0; j < blockHeight; j++) { | ||
| 1423 | for (u32 i = 0; i < blockWidth; i++) { | ||
| 1424 | outBuf[j * blockWidth + i] = 0xFFFF00FF; | ||
| 1425 | } | ||
| 1426 | } | ||
| 1427 | } | ||
| 1428 | |||
| 1319 | static void DecompressBlock(std::span<const u8, 16> inBuf, const u32 blockWidth, | 1429 | static void DecompressBlock(std::span<const u8, 16> inBuf, const u32 blockWidth, |
| 1320 | const u32 blockHeight, std::span<u32, 12 * 12> outBuf) { | 1430 | const u32 blockHeight, std::span<u32, 12 * 12> outBuf) { |
| 1321 | InputBitStream strm(inBuf); | 1431 | InputBitStream strm(inBuf); |
diff --git a/src/video_core/textures/astc.h b/src/video_core/textures/astc.h index 0229ae122..14d2beec0 100644 --- a/src/video_core/textures/astc.h +++ b/src/video_core/textures/astc.h | |||
| @@ -9,117 +9,6 @@ | |||
| 9 | 9 | ||
| 10 | namespace Tegra::Texture::ASTC { | 10 | namespace Tegra::Texture::ASTC { |
| 11 | 11 | ||
| 12 | enum class IntegerEncoding { JustBits, Quint, Trit }; | ||
| 13 | |||
| 14 | struct IntegerEncodedValue { | ||
| 15 | constexpr IntegerEncodedValue() = default; | ||
| 16 | |||
| 17 | constexpr IntegerEncodedValue(IntegerEncoding encoding_, u32 num_bits_) | ||
| 18 | : encoding{encoding_}, num_bits{num_bits_} {} | ||
| 19 | |||
| 20 | constexpr bool MatchesEncoding(const IntegerEncodedValue& other) const { | ||
| 21 | return encoding == other.encoding && num_bits == other.num_bits; | ||
| 22 | } | ||
| 23 | |||
| 24 | // Returns the number of bits required to encode num_vals values. | ||
| 25 | u32 GetBitLength(u32 num_vals) const { | ||
| 26 | u32 total_bits = num_bits * num_vals; | ||
| 27 | if (encoding == IntegerEncoding::Trit) { | ||
| 28 | total_bits += (num_vals * 8 + 4) / 5; | ||
| 29 | } else if (encoding == IntegerEncoding::Quint) { | ||
| 30 | total_bits += (num_vals * 7 + 2) / 3; | ||
| 31 | } | ||
| 32 | return total_bits; | ||
| 33 | } | ||
| 34 | |||
| 35 | IntegerEncoding encoding{}; | ||
| 36 | u32 num_bits = 0; | ||
| 37 | u32 bit_value = 0; | ||
| 38 | union { | ||
| 39 | u32 quint_value = 0; | ||
| 40 | u32 trit_value; | ||
| 41 | }; | ||
| 42 | }; | ||
| 43 | |||
| 44 | // Returns a new instance of this struct that corresponds to the | ||
| 45 | // can take no more than mav_value values | ||
| 46 | constexpr IntegerEncodedValue CreateEncoding(u32 mav_value) { | ||
| 47 | while (mav_value > 0) { | ||
| 48 | u32 check = mav_value + 1; | ||
| 49 | |||
| 50 | // Is mav_value a power of two? | ||
| 51 | if (!(check & (check - 1))) { | ||
| 52 | return IntegerEncodedValue(IntegerEncoding::JustBits, std::popcount(mav_value)); | ||
| 53 | } | ||
| 54 | |||
| 55 | // Is mav_value of the type 3*2^n - 1? | ||
| 56 | if ((check % 3 == 0) && !((check / 3) & ((check / 3) - 1))) { | ||
| 57 | return IntegerEncodedValue(IntegerEncoding::Trit, std::popcount(check / 3 - 1)); | ||
| 58 | } | ||
| 59 | |||
| 60 | // Is mav_value of the type 5*2^n - 1? | ||
| 61 | if ((check % 5 == 0) && !((check / 5) & ((check / 5) - 1))) { | ||
| 62 | return IntegerEncodedValue(IntegerEncoding::Quint, std::popcount(check / 5 - 1)); | ||
| 63 | } | ||
| 64 | |||
| 65 | // Apparently it can't be represented with a bounded integer sequence... | ||
| 66 | // just iterate. | ||
| 67 | mav_value--; | ||
| 68 | } | ||
| 69 | return IntegerEncodedValue(IntegerEncoding::JustBits, 0); | ||
| 70 | } | ||
| 71 | |||
| 72 | constexpr std::array<IntegerEncodedValue, 256> MakeEncodedValues() { | ||
| 73 | std::array<IntegerEncodedValue, 256> encodings{}; | ||
| 74 | for (std::size_t i = 0; i < encodings.size(); ++i) { | ||
| 75 | encodings[i] = CreateEncoding(static_cast<u32>(i)); | ||
| 76 | } | ||
| 77 | return encodings; | ||
| 78 | } | ||
| 79 | |||
| 80 | constexpr std::array<IntegerEncodedValue, 256> ASTC_ENCODINGS_VALUES = MakeEncodedValues(); | ||
| 81 | |||
| 82 | // Replicates low num_bits such that [(to_bit - 1):(to_bit - 1 - from_bit)] | ||
| 83 | // is the same as [(num_bits - 1):0] and repeats all the way down. | ||
| 84 | template <typename IntType> | ||
| 85 | constexpr IntType Replicate(IntType val, u32 num_bits, u32 to_bit) { | ||
| 86 | if (num_bits == 0 || to_bit == 0) { | ||
| 87 | return 0; | ||
| 88 | } | ||
| 89 | const IntType v = val & static_cast<IntType>((1 << num_bits) - 1); | ||
| 90 | IntType res = v; | ||
| 91 | u32 reslen = num_bits; | ||
| 92 | while (reslen < to_bit) { | ||
| 93 | u32 comp = 0; | ||
| 94 | if (num_bits > to_bit - reslen) { | ||
| 95 | u32 newshift = to_bit - reslen; | ||
| 96 | comp = num_bits - newshift; | ||
| 97 | num_bits = newshift; | ||
| 98 | } | ||
| 99 | res = static_cast<IntType>(res << num_bits); | ||
| 100 | res = static_cast<IntType>(res | (v >> comp)); | ||
| 101 | reslen += num_bits; | ||
| 102 | } | ||
| 103 | return res; | ||
| 104 | } | ||
| 105 | |||
| 106 | constexpr std::size_t NumReplicateEntries(u32 num_bits) { | ||
| 107 | return std::size_t(1) << num_bits; | ||
| 108 | } | ||
| 109 | |||
| 110 | template <typename IntType, u32 num_bits, u32 to_bit> | ||
| 111 | constexpr auto MakeReplicateTable() { | ||
| 112 | std::array<IntType, NumReplicateEntries(num_bits)> table{}; | ||
| 113 | for (IntType value = 0; value < static_cast<IntType>(std::size(table)); ++value) { | ||
| 114 | table[value] = Replicate(value, num_bits, to_bit); | ||
| 115 | } | ||
| 116 | return table; | ||
| 117 | } | ||
| 118 | |||
| 119 | constexpr auto REPLICATE_6_BIT_TO_8_TABLE = MakeReplicateTable<u32, 6, 8>(); | ||
| 120 | constexpr auto REPLICATE_7_BIT_TO_8_TABLE = MakeReplicateTable<u32, 7, 8>(); | ||
| 121 | constexpr auto REPLICATE_8_BIT_TO_8_TABLE = MakeReplicateTable<u32, 8, 8>(); | ||
| 122 | |||
| 123 | void Decompress(std::span<const uint8_t> data, uint32_t width, uint32_t height, uint32_t depth, | 12 | void Decompress(std::span<const uint8_t> data, uint32_t width, uint32_t height, uint32_t depth, |
| 124 | uint32_t block_width, uint32_t block_height, std::span<uint8_t> output); | 13 | uint32_t block_width, uint32_t block_height, std::span<uint8_t> output); |
| 125 | 14 | ||
diff --git a/src/yuzu/configuration/configure_input_player_widget.cpp b/src/yuzu/configuration/configure_input_player_widget.cpp index f50cda2f3..cd633e45f 100644 --- a/src/yuzu/configuration/configure_input_player_widget.cpp +++ b/src/yuzu/configuration/configure_input_player_widget.cpp | |||
| @@ -122,6 +122,7 @@ void PlayerControlPreview::UpdateColors() { | |||
| 122 | colors.slider_arrow = QColor(14, 15, 18); | 122 | colors.slider_arrow = QColor(14, 15, 18); |
| 123 | colors.font2 = QColor(255, 255, 255); | 123 | colors.font2 = QColor(255, 255, 255); |
| 124 | colors.indicator = QColor(170, 238, 255); | 124 | colors.indicator = QColor(170, 238, 255); |
| 125 | colors.indicator2 = QColor(100, 255, 100); | ||
| 125 | colors.deadzone = QColor(204, 136, 136); | 126 | colors.deadzone = QColor(204, 136, 136); |
| 126 | colors.slider_button = colors.button; | 127 | colors.slider_button = colors.button; |
| 127 | } | 128 | } |
| @@ -139,6 +140,7 @@ void PlayerControlPreview::UpdateColors() { | |||
| 139 | colors.slider_arrow = QColor(65, 68, 73); | 140 | colors.slider_arrow = QColor(65, 68, 73); |
| 140 | colors.font2 = QColor(0, 0, 0); | 141 | colors.font2 = QColor(0, 0, 0); |
| 141 | colors.indicator = QColor(0, 0, 200); | 142 | colors.indicator = QColor(0, 0, 200); |
| 143 | colors.indicator2 = QColor(0, 150, 0); | ||
| 142 | colors.deadzone = QColor(170, 0, 0); | 144 | colors.deadzone = QColor(170, 0, 0); |
| 143 | colors.slider_button = QColor(153, 149, 149); | 145 | colors.slider_button = QColor(153, 149, 149); |
| 144 | } | 146 | } |
| @@ -317,8 +319,7 @@ void PlayerControlPreview::DrawLeftController(QPainter& p, const QPointF center) | |||
| 317 | using namespace Settings::NativeAnalog; | 319 | using namespace Settings::NativeAnalog; |
| 318 | DrawJoystick(p, center + QPointF(9, -69) + (axis_values[LStick].value * 8), 1.8f, | 320 | DrawJoystick(p, center + QPointF(9, -69) + (axis_values[LStick].value * 8), 1.8f, |
| 319 | button_values[Settings::NativeButton::LStick]); | 321 | button_values[Settings::NativeButton::LStick]); |
| 320 | DrawRawJoystick(p, center + QPointF(-140, 90), axis_values[LStick].raw_value, | 322 | DrawRawJoystick(p, center + QPointF(-140, 90), QPointF(0, 0)); |
| 321 | axis_values[LStick].properties); | ||
| 322 | } | 323 | } |
| 323 | 324 | ||
| 324 | using namespace Settings::NativeButton; | 325 | using namespace Settings::NativeButton; |
| @@ -432,8 +433,7 @@ void PlayerControlPreview::DrawRightController(QPainter& p, const QPointF center | |||
| 432 | using namespace Settings::NativeAnalog; | 433 | using namespace Settings::NativeAnalog; |
| 433 | DrawJoystick(p, center + QPointF(-9, 11) + (axis_values[RStick].value * 8), 1.8f, | 434 | DrawJoystick(p, center + QPointF(-9, 11) + (axis_values[RStick].value * 8), 1.8f, |
| 434 | button_values[Settings::NativeButton::RStick]); | 435 | button_values[Settings::NativeButton::RStick]); |
| 435 | DrawRawJoystick(p, center + QPointF(140, 90), axis_values[RStick].raw_value, | 436 | DrawRawJoystick(p, QPointF(0, 0), center + QPointF(140, 90)); |
| 436 | axis_values[RStick].properties); | ||
| 437 | } | 437 | } |
| 438 | 438 | ||
| 439 | using namespace Settings::NativeButton; | 439 | using namespace Settings::NativeButton; |
| @@ -547,8 +547,7 @@ void PlayerControlPreview::DrawDualController(QPainter& p, const QPointF center) | |||
| 547 | 547 | ||
| 548 | DrawJoystick(p, center + QPointF(-65, -65) + (l_stick.value * 7), 1.62f, l_button); | 548 | DrawJoystick(p, center + QPointF(-65, -65) + (l_stick.value * 7), 1.62f, l_button); |
| 549 | DrawJoystick(p, center + QPointF(65, 12) + (r_stick.value * 7), 1.62f, r_button); | 549 | DrawJoystick(p, center + QPointF(65, 12) + (r_stick.value * 7), 1.62f, r_button); |
| 550 | DrawRawJoystick(p, center + QPointF(-180, 90), l_stick.raw_value, l_stick.properties); | 550 | DrawRawJoystick(p, center + QPointF(-180, 90), center + QPointF(180, 90)); |
| 551 | DrawRawJoystick(p, center + QPointF(180, 90), r_stick.raw_value, r_stick.properties); | ||
| 552 | } | 551 | } |
| 553 | 552 | ||
| 554 | using namespace Settings::NativeButton; | 553 | using namespace Settings::NativeButton; |
| @@ -634,8 +633,7 @@ void PlayerControlPreview::DrawHandheldController(QPainter& p, const QPointF cen | |||
| 634 | 633 | ||
| 635 | DrawJoystick(p, center + QPointF(-171, -41) + (l_stick.value * 4), 1.0f, l_button); | 634 | DrawJoystick(p, center + QPointF(-171, -41) + (l_stick.value * 4), 1.0f, l_button); |
| 636 | DrawJoystick(p, center + QPointF(171, 8) + (r_stick.value * 4), 1.0f, r_button); | 635 | DrawJoystick(p, center + QPointF(171, 8) + (r_stick.value * 4), 1.0f, r_button); |
| 637 | DrawRawJoystick(p, center + QPointF(-50, 0), l_stick.raw_value, l_stick.properties); | 636 | DrawRawJoystick(p, center + QPointF(-50, 0), center + QPointF(50, 0)); |
| 638 | DrawRawJoystick(p, center + QPointF(50, 0), r_stick.raw_value, r_stick.properties); | ||
| 639 | } | 637 | } |
| 640 | 638 | ||
| 641 | using namespace Settings::NativeButton; | 639 | using namespace Settings::NativeButton; |
| @@ -728,10 +726,7 @@ void PlayerControlPreview::DrawProController(QPainter& p, const QPointF center) | |||
| 728 | button_values[Settings::NativeButton::LStick]); | 726 | button_values[Settings::NativeButton::LStick]); |
| 729 | DrawProJoystick(p, center + QPointF(51, 0), axis_values[RStick].value, 11, | 727 | DrawProJoystick(p, center + QPointF(51, 0), axis_values[RStick].value, 11, |
| 730 | button_values[Settings::NativeButton::RStick]); | 728 | button_values[Settings::NativeButton::RStick]); |
| 731 | DrawRawJoystick(p, center + QPointF(-50, 105), axis_values[LStick].raw_value, | 729 | DrawRawJoystick(p, center + QPointF(-50, 105), center + QPointF(50, 105)); |
| 732 | axis_values[LStick].properties); | ||
| 733 | DrawRawJoystick(p, center + QPointF(50, 105), axis_values[RStick].raw_value, | ||
| 734 | axis_values[RStick].properties); | ||
| 735 | } | 730 | } |
| 736 | 731 | ||
| 737 | using namespace Settings::NativeButton; | 732 | using namespace Settings::NativeButton; |
| @@ -821,10 +816,7 @@ void PlayerControlPreview::DrawGCController(QPainter& p, const QPointF center) { | |||
| 821 | p.setBrush(colors.font); | 816 | p.setBrush(colors.font); |
| 822 | DrawSymbol(p, center + QPointF(61, 37) + (axis_values[RStick].value * 9.5f), Symbol::C, | 817 | DrawSymbol(p, center + QPointF(61, 37) + (axis_values[RStick].value * 9.5f), Symbol::C, |
| 823 | 1.0f); | 818 | 1.0f); |
| 824 | DrawRawJoystick(p, center + QPointF(-198, -125), axis_values[LStick].raw_value, | 819 | DrawRawJoystick(p, center + QPointF(-198, -125), center + QPointF(198, -125)); |
| 825 | axis_values[LStick].properties); | ||
| 826 | DrawRawJoystick(p, center + QPointF(198, -125), axis_values[RStick].raw_value, | ||
| 827 | axis_values[RStick].properties); | ||
| 828 | } | 820 | } |
| 829 | 821 | ||
| 830 | using namespace Settings::NativeButton; | 822 | using namespace Settings::NativeButton; |
| @@ -2358,8 +2350,33 @@ void PlayerControlPreview::DrawGCJoystick(QPainter& p, const QPointF center, boo | |||
| 2358 | DrawCircle(p, center, 7.5f); | 2350 | DrawCircle(p, center, 7.5f); |
| 2359 | } | 2351 | } |
| 2360 | 2352 | ||
| 2361 | void PlayerControlPreview::DrawRawJoystick(QPainter& p, const QPointF center, const QPointF value, | 2353 | void PlayerControlPreview::DrawRawJoystick(QPainter& p, QPointF center_left, QPointF center_right) { |
| 2362 | const Input::AnalogProperties& properties) { | 2354 | using namespace Settings::NativeAnalog; |
| 2355 | if (controller_type != Settings::ControllerType::LeftJoycon) { | ||
| 2356 | DrawJoystickProperties(p, center_right, axis_values[RStick].properties); | ||
| 2357 | p.setPen(colors.indicator); | ||
| 2358 | p.setBrush(colors.indicator); | ||
| 2359 | DrawJoystickDot(p, center_right, axis_values[RStick].raw_value, | ||
| 2360 | axis_values[RStick].properties); | ||
| 2361 | p.setPen(colors.indicator2); | ||
| 2362 | p.setBrush(colors.indicator2); | ||
| 2363 | DrawJoystickDot(p, center_right, axis_values[RStick].value, axis_values[RStick].properties); | ||
| 2364 | } | ||
| 2365 | |||
| 2366 | if (controller_type != Settings::ControllerType::RightJoycon) { | ||
| 2367 | DrawJoystickProperties(p, center_left, axis_values[LStick].properties); | ||
| 2368 | p.setPen(colors.indicator); | ||
| 2369 | p.setBrush(colors.indicator); | ||
| 2370 | DrawJoystickDot(p, center_left, axis_values[LStick].raw_value, | ||
| 2371 | axis_values[LStick].properties); | ||
| 2372 | p.setPen(colors.indicator2); | ||
| 2373 | p.setBrush(colors.indicator2); | ||
| 2374 | DrawJoystickDot(p, center_left, axis_values[LStick].value, axis_values[LStick].properties); | ||
| 2375 | } | ||
| 2376 | } | ||
| 2377 | |||
| 2378 | void PlayerControlPreview::DrawJoystickProperties(QPainter& p, const QPointF center, | ||
| 2379 | const Input::AnalogProperties& properties) { | ||
| 2363 | constexpr float size = 45.0f; | 2380 | constexpr float size = 45.0f; |
| 2364 | const float range = size * properties.range; | 2381 | const float range = size * properties.range; |
| 2365 | const float deadzone = size * properties.deadzone; | 2382 | const float deadzone = size * properties.deadzone; |
| @@ -2376,10 +2393,14 @@ void PlayerControlPreview::DrawRawJoystick(QPainter& p, const QPointF center, co | |||
| 2376 | pen.setColor(colors.deadzone); | 2393 | pen.setColor(colors.deadzone); |
| 2377 | p.setPen(pen); | 2394 | p.setPen(pen); |
| 2378 | DrawCircle(p, center, deadzone); | 2395 | DrawCircle(p, center, deadzone); |
| 2396 | } | ||
| 2397 | |||
| 2398 | void PlayerControlPreview::DrawJoystickDot(QPainter& p, const QPointF center, const QPointF value, | ||
| 2399 | const Input::AnalogProperties& properties) { | ||
| 2400 | constexpr float size = 45.0f; | ||
| 2401 | const float range = size * properties.range; | ||
| 2379 | 2402 | ||
| 2380 | // Dot pointer | 2403 | // Dot pointer |
| 2381 | p.setPen(colors.indicator); | ||
| 2382 | p.setBrush(colors.indicator); | ||
| 2383 | DrawCircle(p, center + (value * range), 2); | 2404 | DrawCircle(p, center + (value * range), 2); |
| 2384 | } | 2405 | } |
| 2385 | 2406 | ||
diff --git a/src/yuzu/configuration/configure_input_player_widget.h b/src/yuzu/configuration/configure_input_player_widget.h index 5fc16d8af..f4a6a5e1b 100644 --- a/src/yuzu/configuration/configure_input_player_widget.h +++ b/src/yuzu/configuration/configure_input_player_widget.h | |||
| @@ -90,6 +90,7 @@ private: | |||
| 90 | QColor highlight2{}; | 90 | QColor highlight2{}; |
| 91 | QColor transparent{}; | 91 | QColor transparent{}; |
| 92 | QColor indicator{}; | 92 | QColor indicator{}; |
| 93 | QColor indicator2{}; | ||
| 93 | QColor led_on{}; | 94 | QColor led_on{}; |
| 94 | QColor led_off{}; | 95 | QColor led_off{}; |
| 95 | QColor slider{}; | 96 | QColor slider{}; |
| @@ -139,7 +140,10 @@ private: | |||
| 139 | // Draw joystick functions | 140 | // Draw joystick functions |
| 140 | void DrawJoystick(QPainter& p, QPointF center, float size, bool pressed); | 141 | void DrawJoystick(QPainter& p, QPointF center, float size, bool pressed); |
| 141 | void DrawJoystickSideview(QPainter& p, QPointF center, float angle, float size, bool pressed); | 142 | void DrawJoystickSideview(QPainter& p, QPointF center, float angle, float size, bool pressed); |
| 142 | void DrawRawJoystick(QPainter& p, QPointF center, QPointF value, | 143 | void DrawRawJoystick(QPainter& p, QPointF center_left, QPointF center_right); |
| 144 | void DrawJoystickProperties(QPainter& p, QPointF center, | ||
| 145 | const Input::AnalogProperties& properties); | ||
| 146 | void DrawJoystickDot(QPainter& p, QPointF center, QPointF value, | ||
| 143 | const Input::AnalogProperties& properties); | 147 | const Input::AnalogProperties& properties); |
| 144 | void DrawProJoystick(QPainter& p, QPointF center, QPointF offset, float scalar, bool pressed); | 148 | void DrawProJoystick(QPainter& p, QPointF center, QPointF offset, float scalar, bool pressed); |
| 145 | void DrawGCJoystick(QPainter& p, QPointF center, bool pressed); | 149 | void DrawGCJoystick(QPainter& p, QPointF center, bool pressed); |
diff --git a/src/yuzu_cmd/emu_window/emu_window_sdl2.cpp b/src/yuzu_cmd/emu_window/emu_window_sdl2.cpp index f643a4b0b..c80f7791c 100644 --- a/src/yuzu_cmd/emu_window/emu_window_sdl2.cpp +++ b/src/yuzu_cmd/emu_window/emu_window_sdl2.cpp | |||
| @@ -122,6 +122,10 @@ void EmuWindow_SDL2::OnResize() { | |||
| 122 | UpdateCurrentFramebufferLayout(width, height); | 122 | UpdateCurrentFramebufferLayout(width, height); |
| 123 | } | 123 | } |
| 124 | 124 | ||
| 125 | void EmuWindow_SDL2::ShowCursor(bool show_cursor) { | ||
| 126 | SDL_ShowCursor(show_cursor ? SDL_ENABLE : SDL_DISABLE); | ||
| 127 | } | ||
| 128 | |||
| 125 | void EmuWindow_SDL2::Fullscreen() { | 129 | void EmuWindow_SDL2::Fullscreen() { |
| 126 | switch (Settings::values.fullscreen_mode.GetValue()) { | 130 | switch (Settings::values.fullscreen_mode.GetValue()) { |
| 127 | case Settings::FullscreenMode::Exclusive: | 131 | case Settings::FullscreenMode::Exclusive: |
diff --git a/src/yuzu_cmd/emu_window/emu_window_sdl2.h b/src/yuzu_cmd/emu_window/emu_window_sdl2.h index aa0d52ae4..4810f8775 100644 --- a/src/yuzu_cmd/emu_window/emu_window_sdl2.h +++ b/src/yuzu_cmd/emu_window/emu_window_sdl2.h | |||
| @@ -67,6 +67,9 @@ protected: | |||
| 67 | /// Called by WaitEvent when any event that may cause the window to be resized occurs | 67 | /// Called by WaitEvent when any event that may cause the window to be resized occurs |
| 68 | void OnResize(); | 68 | void OnResize(); |
| 69 | 69 | ||
| 70 | /// Called when users want to hide the mouse cursor | ||
| 71 | void ShowCursor(bool show_cursor); | ||
| 72 | |||
| 70 | /// Called when user passes the fullscreen parameter flag | 73 | /// Called when user passes the fullscreen parameter flag |
| 71 | void Fullscreen(); | 74 | void Fullscreen(); |
| 72 | 75 | ||
diff --git a/src/yuzu_cmd/emu_window/emu_window_sdl2_gl.cpp b/src/yuzu_cmd/emu_window/emu_window_sdl2_gl.cpp index 5b98c255b..a075ad08a 100644 --- a/src/yuzu_cmd/emu_window/emu_window_sdl2_gl.cpp +++ b/src/yuzu_cmd/emu_window/emu_window_sdl2_gl.cpp | |||
| @@ -111,6 +111,7 @@ EmuWindow_SDL2_GL::EmuWindow_SDL2_GL(InputCommon::InputSubsystem* input_subsyste | |||
| 111 | 111 | ||
| 112 | if (fullscreen) { | 112 | if (fullscreen) { |
| 113 | Fullscreen(); | 113 | Fullscreen(); |
| 114 | ShowCursor(false); | ||
| 114 | } | 115 | } |
| 115 | 116 | ||
| 116 | window_context = SDL_GL_CreateContext(render_window); | 117 | window_context = SDL_GL_CreateContext(render_window); |
diff --git a/src/yuzu_cmd/emu_window/emu_window_sdl2_vk.cpp b/src/yuzu_cmd/emu_window/emu_window_sdl2_vk.cpp index cdda375d8..de40b76bf 100644 --- a/src/yuzu_cmd/emu_window/emu_window_sdl2_vk.cpp +++ b/src/yuzu_cmd/emu_window/emu_window_sdl2_vk.cpp | |||
| @@ -45,6 +45,7 @@ EmuWindow_SDL2_VK::EmuWindow_SDL2_VK(InputCommon::InputSubsystem* input_subsyste | |||
| 45 | 45 | ||
| 46 | if (fullscreen) { | 46 | if (fullscreen) { |
| 47 | Fullscreen(); | 47 | Fullscreen(); |
| 48 | ShowCursor(false); | ||
| 48 | } | 49 | } |
| 49 | 50 | ||
| 50 | switch (wm.subsystem) { | 51 | switch (wm.subsystem) { |