summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--dist/qt_themes/default/style.qss5
-rw-r--r--dist/qt_themes/qdarkstyle_midnight_blue/style.qss4
-rw-r--r--externals/CMakeLists.txt14
-rw-r--r--src/CMakeLists.txt19
-rw-r--r--src/android/app/src/main/jni/config.cpp5
-rw-r--r--src/android/app/src/main/jni/native.cpp2
-rw-r--r--src/audio_core/sink/cubeb_sink.cpp52
-rw-r--r--src/audio_core/sink/cubeb_sink.h7
-rw-r--r--src/audio_core/sink/sdl2_sink.cpp40
-rw-r--r--src/audio_core/sink/sdl2_sink.h7
-rw-r--r--src/audio_core/sink/sink_details.cpp49
-rw-r--r--src/common/settings.cpp5
-rw-r--r--src/common/settings.h10
-rw-r--r--src/common/settings_common.h1
-rw-r--r--src/common/settings_enums.h2
-rw-r--r--src/common/swap.h5
-rw-r--r--src/core/frontend/applets/controller.cpp4
-rw-r--r--src/core/frontend/framebuffer_layout.cpp3
-rw-r--r--src/core/hle/service/am/am.cpp5
-rw-r--r--src/core/hle/service/apm/apm_controller.cpp4
-rw-r--r--src/core/hle/service/hid/controllers/gesture.cpp2
-rw-r--r--src/core/hle/service/hid/controllers/npad.cpp2
-rw-r--r--src/core/hle/service/vi/vi.cpp2
-rw-r--r--src/core/telemetry_session.cpp3
-rw-r--r--src/input_common/input_poller.cpp10
-rw-r--r--src/video_core/macro/macro.cpp24
-rw-r--r--src/video_core/renderer_vulkan/vk_pipeline_cache.cpp7
-rw-r--r--src/web_service/verify_user_jwt.cpp1
-rw-r--r--src/yuzu/applets/qt_controller.cpp14
-rw-r--r--src/yuzu/bootmanager.cpp4
-rw-r--r--src/yuzu/configuration/config.cpp9
-rw-r--r--src/yuzu/configuration/config.h3
-rw-r--r--src/yuzu/configuration/configure_input.cpp14
-rw-r--r--src/yuzu/configuration/configure_per_game.cpp7
-rw-r--r--src/yuzu/configuration/configure_system.cpp5
-rw-r--r--src/yuzu/configuration/shared_translation.cpp5
-rw-r--r--src/yuzu/configuration/shared_widget.cpp68
-rw-r--r--src/yuzu/configuration/shared_widget.h6
-rw-r--r--src/yuzu/main.cpp17
39 files changed, 339 insertions, 107 deletions
diff --git a/dist/qt_themes/default/style.qss b/dist/qt_themes/default/style.qss
index 12e681648..79960ee0c 100644
--- a/dist/qt_themes/default/style.qss
+++ b/dist/qt_themes/default/style.qss
@@ -78,6 +78,11 @@ QPushButton#buttonRefreshDevices {
78 max-height: 21px; 78 max-height: 21px;
79} 79}
80 80
81QPushButton#button_reset_defaults {
82 min-width: 57px;
83 padding: 4px 8px;
84}
85
81QWidget#bottomPerGameInput, 86QWidget#bottomPerGameInput,
82QWidget#topControllerApplet, 87QWidget#topControllerApplet,
83QWidget#bottomControllerApplet, 88QWidget#bottomControllerApplet,
diff --git a/dist/qt_themes/qdarkstyle_midnight_blue/style.qss b/dist/qt_themes/qdarkstyle_midnight_blue/style.qss
index 49b05c8ba..0c53115f6 100644
--- a/dist/qt_themes/qdarkstyle_midnight_blue/style.qss
+++ b/dist/qt_themes/qdarkstyle_midnight_blue/style.qss
@@ -2228,6 +2228,10 @@ QPushButton#buttonRefreshDevices {
2228 padding: 0px 0px; 2228 padding: 0px 0px;
2229} 2229}
2230 2230
2231QPushButton#button_reset_defaults {
2232 padding: 3px 6px;
2233}
2234
2231QSpinBox#spinboxLStickRange, 2235QSpinBox#spinboxLStickRange,
2232QSpinBox#spinboxRStickRange, 2236QSpinBox#spinboxRStickRange,
2233QSpinBox#vibrationSpinPlayer1, 2237QSpinBox#vibrationSpinPlayer1,
diff --git a/externals/CMakeLists.txt b/externals/CMakeLists.txt
index 1f7cd598e..82a6da9fd 100644
--- a/externals/CMakeLists.txt
+++ b/externals/CMakeLists.txt
@@ -42,6 +42,11 @@ endif()
42# mbedtls 42# mbedtls
43add_subdirectory(mbedtls) 43add_subdirectory(mbedtls)
44target_include_directories(mbedtls PUBLIC ./mbedtls/include) 44target_include_directories(mbedtls PUBLIC ./mbedtls/include)
45if (NOT MSVC)
46 target_compile_options(mbedcrypto PRIVATE
47 -Wno-unused-but-set-variable
48 -Wno-string-concatenation)
49endif()
45 50
46# MicroProfile 51# MicroProfile
47add_library(microprofile INTERFACE) 52add_library(microprofile INTERFACE)
@@ -94,6 +99,12 @@ if (ENABLE_CUBEB AND NOT TARGET cubeb::cubeb)
94 set(BUILD_TOOLS OFF) 99 set(BUILD_TOOLS OFF)
95 add_subdirectory(cubeb) 100 add_subdirectory(cubeb)
96 add_library(cubeb::cubeb ALIAS cubeb) 101 add_library(cubeb::cubeb ALIAS cubeb)
102 if (NOT MSVC)
103 if (TARGET speex)
104 target_compile_options(speex PRIVATE -Wno-sign-compare)
105 endif()
106 target_compile_options(cubeb PRIVATE -Wno-implicit-const-int-float-conversion)
107 endif()
97endif() 108endif()
98 109
99# DiscordRPC 110# DiscordRPC
@@ -151,6 +162,9 @@ endif()
151if (NOT TARGET LLVM::Demangle) 162if (NOT TARGET LLVM::Demangle)
152 add_library(demangle demangle/ItaniumDemangle.cpp) 163 add_library(demangle demangle/ItaniumDemangle.cpp)
153 target_include_directories(demangle PUBLIC ./demangle) 164 target_include_directories(demangle PUBLIC ./demangle)
165 if (NOT MSVC)
166 target_compile_options(demangle PRIVATE -Wno-deprecated-declarations) # std::is_pod
167 endif()
154 add_library(LLVM::Demangle ALIAS demangle) 168 add_library(LLVM::Demangle ALIAS demangle)
155endif() 169endif()
156 170
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 7bb88c8ea..6068c7a1f 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -114,16 +114,19 @@ else()
114 -Wno-attributes 114 -Wno-attributes
115 -Wno-invalid-offsetof 115 -Wno-invalid-offsetof
116 -Wno-unused-parameter 116 -Wno-unused-parameter
117
118 $<$<CXX_COMPILER_ID:Clang>:-Wno-braced-scalar-init>
119 $<$<CXX_COMPILER_ID:Clang>:-Wno-unused-private-field>
120 $<$<CXX_COMPILER_ID:Clang>:-Werror=shadow-uncaptured-local>
121 $<$<CXX_COMPILER_ID:Clang>:-Werror=implicit-fallthrough>
122 $<$<CXX_COMPILER_ID:Clang>:-Werror=type-limits>
123 $<$<CXX_COMPILER_ID:AppleClang>:-Wno-braced-scalar-init>
124 $<$<CXX_COMPILER_ID:AppleClang>:-Wno-unused-private-field>
125 ) 117 )
126 118
119 if (CMAKE_CXX_COMPILER_ID MATCHES Clang) # Clang or AppleClang
120 add_compile_options(
121 -Wno-braced-scalar-init
122 -Wno-unused-private-field
123 -Wno-nullability-completeness
124 -Werror=shadow-uncaptured-local
125 -Werror=implicit-fallthrough
126 -Werror=type-limits
127 )
128 endif()
129
127 if (ARCHITECTURE_x86_64) 130 if (ARCHITECTURE_x86_64)
128 add_compile_options("-mcx16") 131 add_compile_options("-mcx16")
129 add_compile_options("-fwrapv") 132 add_compile_options("-fwrapv")
diff --git a/src/android/app/src/main/jni/config.cpp b/src/android/app/src/main/jni/config.cpp
index 5e1f10f99..9de9bd93e 100644
--- a/src/android/app/src/main/jni/config.cpp
+++ b/src/android/app/src/main/jni/config.cpp
@@ -11,6 +11,7 @@
11#include "common/fs/path_util.h" 11#include "common/fs/path_util.h"
12#include "common/logging/log.h" 12#include "common/logging/log.h"
13#include "common/settings.h" 13#include "common/settings.h"
14#include "common/settings_enums.h"
14#include "core/hle/service/acc/profile_manager.h" 15#include "core/hle/service/acc/profile_manager.h"
15#include "input_common/main.h" 16#include "input_common/main.h"
16#include "jni/config.h" 17#include "jni/config.h"
@@ -144,7 +145,9 @@ void Config::ReadValues() {
144 Service::Account::MAX_USERS - 1); 145 Service::Account::MAX_USERS - 1);
145 146
146 // Disable docked mode by default on Android 147 // Disable docked mode by default on Android
147 Settings::values.use_docked_mode = config->GetBoolean("System", "use_docked_mode", false); 148 Settings::values.use_docked_mode.SetValue(config->GetBoolean("System", "use_docked_mode", false)
149 ? Settings::ConsoleMode::Docked
150 : Settings::ConsoleMode::Handheld);
148 151
149 const auto rng_seed_enabled = config->GetBoolean("System", "rng_seed_enabled", false); 152 const auto rng_seed_enabled = config->GetBoolean("System", "rng_seed_enabled", false);
150 if (rng_seed_enabled) { 153 if (rng_seed_enabled) {
diff --git a/src/android/app/src/main/jni/native.cpp b/src/android/app/src/main/jni/native.cpp
index 8b99d1d6e..7e17833a0 100644
--- a/src/android/app/src/main/jni/native.cpp
+++ b/src/android/app/src/main/jni/native.cpp
@@ -420,7 +420,7 @@ public:
420 return false; 420 return false;
421 } 421 }
422 422
423 return !Settings::values.use_docked_mode.GetValue(); 423 return !Settings::IsDockedMode();
424 } 424 }
425 425
426 void SetDeviceType([[maybe_unused]] int index, int type) { 426 void SetDeviceType([[maybe_unused]] int index, int type) {
diff --git a/src/audio_core/sink/cubeb_sink.cpp b/src/audio_core/sink/cubeb_sink.cpp
index 9a0801888..04d98a865 100644
--- a/src/audio_core/sink/cubeb_sink.cpp
+++ b/src/audio_core/sink/cubeb_sink.cpp
@@ -8,6 +8,7 @@
8#include "audio_core/sink/cubeb_sink.h" 8#include "audio_core/sink/cubeb_sink.h"
9#include "audio_core/sink/sink_stream.h" 9#include "audio_core/sink/sink_stream.h"
10#include "common/logging/log.h" 10#include "common/logging/log.h"
11#include "common/scope_exit.h"
11#include "core/core.h" 12#include "core/core.h"
12 13
13#ifdef _WIN32 14#ifdef _WIN32
@@ -332,25 +333,38 @@ std::vector<std::string> ListCubebSinkDevices(bool capture) {
332 return device_list; 333 return device_list;
333} 334}
334 335
335u32 GetCubebLatency() { 336namespace {
336 cubeb* ctx; 337static long TmpDataCallback(cubeb_stream*, void*, const void*, void*, long) {
338 return TargetSampleCount;
339}
340static void TmpStateCallback(cubeb_stream*, void*, cubeb_state) {}
341} // namespace
342
343bool IsCubebSuitable() {
344#if !defined(HAVE_CUBEB)
345 return false;
346#else
347 cubeb* ctx{nullptr};
337 348
338#ifdef _WIN32 349#ifdef _WIN32
339 auto com_init_result = CoInitializeEx(nullptr, COINIT_MULTITHREADED); 350 auto com_init_result = CoInitializeEx(nullptr, COINIT_MULTITHREADED);
340#endif 351#endif
341 352
353 // Init cubeb
342 if (cubeb_init(&ctx, "yuzu Latency Getter", nullptr) != CUBEB_OK) { 354 if (cubeb_init(&ctx, "yuzu Latency Getter", nullptr) != CUBEB_OK) {
343 LOG_CRITICAL(Audio_Sink, "cubeb_init failed"); 355 LOG_ERROR(Audio_Sink, "Cubeb failed to init, it is not suitable.");
344 // Return a large latency so we choose SDL instead. 356 return false;
345 return 10000u;
346 } 357 }
347 358
359 SCOPE_EXIT({ cubeb_destroy(ctx); });
360
348#ifdef _WIN32 361#ifdef _WIN32
349 if (SUCCEEDED(com_init_result)) { 362 if (SUCCEEDED(com_init_result)) {
350 CoUninitialize(); 363 CoUninitialize();
351 } 364 }
352#endif 365#endif
353 366
367 // Test min latency
354 cubeb_stream_params params{}; 368 cubeb_stream_params params{};
355 params.rate = TargetSampleRate; 369 params.rate = TargetSampleRate;
356 params.channels = 2; 370 params.channels = 2;
@@ -361,12 +375,32 @@ u32 GetCubebLatency() {
361 u32 latency{0}; 375 u32 latency{0};
362 const auto latency_error = cubeb_get_min_latency(ctx, &params, &latency); 376 const auto latency_error = cubeb_get_min_latency(ctx, &params, &latency);
363 if (latency_error != CUBEB_OK) { 377 if (latency_error != CUBEB_OK) {
364 LOG_CRITICAL(Audio_Sink, "Error getting minimum latency, error: {}", latency_error); 378 LOG_ERROR(Audio_Sink, "Cubeb could not get min latency, it is not suitable.");
365 latency = TargetSampleCount * 2; 379 return false;
366 } 380 }
367 latency = std::max(latency, TargetSampleCount * 2); 381 latency = std::max(latency, TargetSampleCount * 2);
368 cubeb_destroy(ctx); 382
369 return latency; 383 if (latency > TargetSampleCount * 3) {
384 LOG_ERROR(Audio_Sink, "Cubeb latency is too high, it is not suitable.");
385 return false;
386 }
387
388 // Test opening a device with standard parameters
389 cubeb_devid output_device{0};
390 cubeb_devid input_device{0};
391 std::string name{"Yuzu test"};
392 cubeb_stream* stream{nullptr};
393
394 if (cubeb_stream_init(ctx, &stream, name.c_str(), input_device, nullptr, output_device, &params,
395 latency, &TmpDataCallback, &TmpStateCallback, nullptr) != CUBEB_OK) {
396 LOG_CRITICAL(Audio_Sink, "Cubeb could not open a device, it is not suitable.");
397 return false;
398 }
399
400 cubeb_stream_stop(stream);
401 cubeb_stream_destroy(stream);
402 return true;
403#endif
370} 404}
371 405
372} // namespace AudioCore::Sink 406} // namespace AudioCore::Sink
diff --git a/src/audio_core/sink/cubeb_sink.h b/src/audio_core/sink/cubeb_sink.h
index 3302cb98d..f49a6fdaa 100644
--- a/src/audio_core/sink/cubeb_sink.h
+++ b/src/audio_core/sink/cubeb_sink.h
@@ -97,10 +97,11 @@ private:
97std::vector<std::string> ListCubebSinkDevices(bool capture); 97std::vector<std::string> ListCubebSinkDevices(bool capture);
98 98
99/** 99/**
100 * Get the reported latency for this sink. 100 * Check if this backend is suitable for use.
101 * Checks if enabled, its latency, whether it opens successfully, etc.
101 * 102 *
102 * @return Minimum latency for this sink. 103 * @return True is this backend is suitable, false otherwise.
103 */ 104 */
104u32 GetCubebLatency(); 105bool IsCubebSuitable();
105 106
106} // namespace AudioCore::Sink 107} // namespace AudioCore::Sink
diff --git a/src/audio_core/sink/sdl2_sink.cpp b/src/audio_core/sink/sdl2_sink.cpp
index c1529d1f9..7b89151de 100644
--- a/src/audio_core/sink/sdl2_sink.cpp
+++ b/src/audio_core/sink/sdl2_sink.cpp
@@ -9,6 +9,7 @@
9#include "audio_core/sink/sdl2_sink.h" 9#include "audio_core/sink/sdl2_sink.h"
10#include "audio_core/sink/sink_stream.h" 10#include "audio_core/sink/sink_stream.h"
11#include "common/logging/log.h" 11#include "common/logging/log.h"
12#include "common/scope_exit.h"
12#include "core/core.h" 13#include "core/core.h"
13 14
14namespace AudioCore::Sink { 15namespace AudioCore::Sink {
@@ -84,6 +85,7 @@ public:
84 } 85 }
85 86
86 Stop(); 87 Stop();
88 SDL_ClearQueuedAudio(device);
87 SDL_CloseAudioDevice(device); 89 SDL_CloseAudioDevice(device);
88 } 90 }
89 91
@@ -227,8 +229,42 @@ std::vector<std::string> ListSDLSinkDevices(bool capture) {
227 return device_list; 229 return device_list;
228} 230}
229 231
230u32 GetSDLLatency() { 232bool IsSDLSuitable() {
231 return TargetSampleCount * 2; 233#if !defined(HAVE_SDL2)
234 return false;
235#else
236 // Check SDL can init
237 if (!SDL_WasInit(SDL_INIT_AUDIO)) {
238 if (SDL_InitSubSystem(SDL_INIT_AUDIO) < 0) {
239 LOG_ERROR(Audio_Sink, "SDL failed to init, it is not suitable. Error: {}",
240 SDL_GetError());
241 return false;
242 }
243 }
244
245 // We can set any latency frequency we want with SDL, so no need to check that.
246
247 // Check we can open a device with standard parameters
248 SDL_AudioSpec spec;
249 spec.freq = TargetSampleRate;
250 spec.channels = 2u;
251 spec.format = AUDIO_S16SYS;
252 spec.samples = TargetSampleCount * 2;
253 spec.callback = nullptr;
254 spec.userdata = nullptr;
255
256 SDL_AudioSpec obtained;
257 auto device = SDL_OpenAudioDevice(nullptr, false, &spec, &obtained, false);
258
259 if (device == 0) {
260 LOG_ERROR(Audio_Sink, "SDL failed to open a device, it is not suitable. Error: {}",
261 SDL_GetError());
262 return false;
263 }
264
265 SDL_CloseAudioDevice(device);
266 return true;
267#endif
232} 268}
233 269
234} // namespace AudioCore::Sink 270} // namespace AudioCore::Sink
diff --git a/src/audio_core/sink/sdl2_sink.h b/src/audio_core/sink/sdl2_sink.h
index 27ed1ab94..9211d2e97 100644
--- a/src/audio_core/sink/sdl2_sink.h
+++ b/src/audio_core/sink/sdl2_sink.h
@@ -88,10 +88,11 @@ private:
88std::vector<std::string> ListSDLSinkDevices(bool capture); 88std::vector<std::string> ListSDLSinkDevices(bool capture);
89 89
90/** 90/**
91 * Get the reported latency for this sink. 91 * Check if this backend is suitable for use.
92 * Checks if enabled, its latency, whether it opens successfully, etc.
92 * 93 *
93 * @return Minimum latency for this sink. 94 * @return True is this backend is suitable, false otherwise.
94 */ 95 */
95u32 GetSDLLatency(); 96bool IsSDLSuitable();
96 97
97} // namespace AudioCore::Sink 98} // namespace AudioCore::Sink
diff --git a/src/audio_core/sink/sink_details.cpp b/src/audio_core/sink/sink_details.cpp
index 027bfa517..6bec8ee7c 100644
--- a/src/audio_core/sink/sink_details.cpp
+++ b/src/audio_core/sink/sink_details.cpp
@@ -22,7 +22,7 @@ namespace {
22struct SinkDetails { 22struct SinkDetails {
23 using FactoryFn = std::unique_ptr<Sink> (*)(std::string_view); 23 using FactoryFn = std::unique_ptr<Sink> (*)(std::string_view);
24 using ListDevicesFn = std::vector<std::string> (*)(bool); 24 using ListDevicesFn = std::vector<std::string> (*)(bool);
25 using LatencyFn = u32 (*)(); 25 using SuitableFn = bool (*)();
26 26
27 /// Name for this sink. 27 /// Name for this sink.
28 Settings::AudioEngine id; 28 Settings::AudioEngine id;
@@ -30,8 +30,8 @@ struct SinkDetails {
30 FactoryFn factory; 30 FactoryFn factory;
31 /// A method to call to list available devices. 31 /// A method to call to list available devices.
32 ListDevicesFn list_devices; 32 ListDevicesFn list_devices;
33 /// Method to get the latency of this backend. 33 /// Check whether this backend is suitable to be used.
34 LatencyFn latency; 34 SuitableFn is_suitable;
35}; 35};
36 36
37// sink_details is ordered in terms of desirability, with the best choice at the top. 37// sink_details is ordered in terms of desirability, with the best choice at the top.
@@ -43,7 +43,7 @@ constexpr SinkDetails sink_details[] = {
43 return std::make_unique<CubebSink>(device_id); 43 return std::make_unique<CubebSink>(device_id);
44 }, 44 },
45 &ListCubebSinkDevices, 45 &ListCubebSinkDevices,
46 &GetCubebLatency, 46 &IsCubebSuitable,
47 }, 47 },
48#endif 48#endif
49#ifdef HAVE_SDL2 49#ifdef HAVE_SDL2
@@ -53,14 +53,17 @@ constexpr SinkDetails sink_details[] = {
53 return std::make_unique<SDLSink>(device_id); 53 return std::make_unique<SDLSink>(device_id);
54 }, 54 },
55 &ListSDLSinkDevices, 55 &ListSDLSinkDevices,
56 &GetSDLLatency, 56 &IsSDLSuitable,
57 }, 57 },
58#endif 58#endif
59 SinkDetails{Settings::AudioEngine::Null, 59 SinkDetails{
60 [](std::string_view device_id) -> std::unique_ptr<Sink> { 60 Settings::AudioEngine::Null,
61 return std::make_unique<NullSink>(device_id); 61 [](std::string_view device_id) -> std::unique_ptr<Sink> {
62 }, 62 return std::make_unique<NullSink>(device_id);
63 [](bool capture) { return std::vector<std::string>{"null"}; }, []() { return 0u; }}, 63 },
64 [](bool capture) { return std::vector<std::string>{"null"}; },
65 []() { return true; },
66 },
64}; 67};
65 68
66const SinkDetails& GetOutputSinkDetails(Settings::AudioEngine sink_id) { 69const SinkDetails& GetOutputSinkDetails(Settings::AudioEngine sink_id) {
@@ -72,18 +75,22 @@ const SinkDetails& GetOutputSinkDetails(Settings::AudioEngine sink_id) {
72 auto iter = find_backend(sink_id); 75 auto iter = find_backend(sink_id);
73 76
74 if (sink_id == Settings::AudioEngine::Auto) { 77 if (sink_id == Settings::AudioEngine::Auto) {
75 // Auto-select a backend. Prefer CubeB, but it may report a large minimum latency which 78 // Auto-select a backend. Use the sink details ordering, preferring cubeb first, checking
76 // causes audio issues, in that case go with SDL. 79 // that the backend is available and suitable to use.
77#if defined(HAVE_CUBEB) && defined(HAVE_SDL2) 80 for (auto& details : sink_details) {
78 iter = find_backend(Settings::AudioEngine::Cubeb); 81 if (details.is_suitable()) {
79 if (iter->latency() > TargetSampleCount * 3) { 82 iter = &details;
80 iter = find_backend(Settings::AudioEngine::Sdl2); 83 break;
84 }
85 }
86 LOG_ERROR(Service_Audio, "Auto-selecting the {} backend",
87 Settings::CanonicalizeEnum(iter->id));
88 } else {
89 if (iter != std::end(sink_details) && !iter->is_suitable()) {
90 LOG_ERROR(Service_Audio, "Selected backend {} is not suitable, falling back to null",
91 Settings::CanonicalizeEnum(iter->id));
92 iter = find_backend(Settings::AudioEngine::Null);
81 } 93 }
82#else
83 iter = std::begin(sink_details);
84#endif
85 LOG_INFO(Service_Audio, "Auto-selecting the {} backend",
86 Settings::CanonicalizeEnum(iter->id));
87 } 94 }
88 95
89 if (iter == std::end(sink_details)) { 96 if (iter == std::end(sink_details)) {
diff --git a/src/common/settings.cpp b/src/common/settings.cpp
index 16a58a750..524056841 100644
--- a/src/common/settings.cpp
+++ b/src/common/settings.cpp
@@ -2,6 +2,7 @@
2// SPDX-License-Identifier: GPL-2.0-or-later 2// SPDX-License-Identifier: GPL-2.0-or-later
3 3
4#include <version> 4#include <version>
5#include "common/settings_enums.h"
5#if __cpp_lib_chrono >= 201907L 6#if __cpp_lib_chrono >= 201907L
6#include <chrono> 7#include <chrono>
7#include <exception> 8#include <exception>
@@ -145,6 +146,10 @@ bool IsFastmemEnabled() {
145 return true; 146 return true;
146} 147}
147 148
149bool IsDockedMode() {
150 return values.use_docked_mode.GetValue() == Settings::ConsoleMode::Docked;
151}
152
148float Volume() { 153float Volume() {
149 if (values.audio_muted) { 154 if (values.audio_muted) {
150 return 0.0f; 155 return 0.0f;
diff --git a/src/common/settings.h b/src/common/settings.h
index 4407c1e6d..b15213bd7 100644
--- a/src/common/settings.h
+++ b/src/common/settings.h
@@ -379,7 +379,13 @@ struct Values {
379 379
380 Setting<s32> current_user{linkage, 0, "current_user", Category::System}; 380 Setting<s32> current_user{linkage, 0, "current_user", Category::System};
381 381
382 SwitchableSetting<bool> use_docked_mode{linkage, true, "use_docked_mode", Category::System}; 382 SwitchableSetting<ConsoleMode> use_docked_mode{linkage,
383 ConsoleMode::Docked,
384 "use_docked_mode",
385 Category::System,
386 Specialization::Radio,
387 true,
388 true};
383 389
384 // Controls 390 // Controls
385 InputSetting<std::array<PlayerInput, 10>> players; 391 InputSetting<std::array<PlayerInput, 10>> players;
@@ -519,6 +525,8 @@ bool IsGPULevelHigh();
519 525
520bool IsFastmemEnabled(); 526bool IsFastmemEnabled();
521 527
528bool IsDockedMode();
529
522float Volume(); 530float Volume();
523 531
524std::string GetTimeZoneString(TimeZone time_zone); 532std::string GetTimeZoneString(TimeZone time_zone);
diff --git a/src/common/settings_common.h b/src/common/settings_common.h
index 2efb329b0..3082e0ce1 100644
--- a/src/common/settings_common.h
+++ b/src/common/settings_common.h
@@ -56,6 +56,7 @@ enum Specialization : u8 {
56 Scalar = 5, // Values are continuous 56 Scalar = 5, // Values are continuous
57 Countable = 6, // Can be stepped through 57 Countable = 6, // Can be stepped through
58 Paired = 7, // Another setting is associated with this setting 58 Paired = 7, // Another setting is associated with this setting
59 Radio = 8, // Setting should be presented in a radio group
59 60
60 Percentage = (1 << SpecializationAttributeOffset), // Should be represented as a percentage 61 Percentage = (1 << SpecializationAttributeOffset), // Should be represented as a percentage
61}; 62};
diff --git a/src/common/settings_enums.h b/src/common/settings_enums.h
index e7cb59ea5..815cafe15 100644
--- a/src/common/settings_enums.h
+++ b/src/common/settings_enums.h
@@ -146,6 +146,8 @@ ENUM(AntiAliasing, None, Fxaa, Smaa, MaxEnum);
146 146
147ENUM(AspectRatio, R16_9, R4_3, R21_9, R16_10, Stretch); 147ENUM(AspectRatio, R16_9, R4_3, R21_9, R16_10, Stretch);
148 148
149ENUM(ConsoleMode, Handheld, Docked);
150
149template <typename Type> 151template <typename Type>
150inline std::string CanonicalizeEnum(Type id) { 152inline std::string CanonicalizeEnum(Type id) {
151 const auto group = EnumMetadata<Type>::Canonicalizations(); 153 const auto group = EnumMetadata<Type>::Canonicalizations();
diff --git a/src/common/swap.h b/src/common/swap.h
index 085baaf9a..fde343e45 100644
--- a/src/common/swap.h
+++ b/src/common/swap.h
@@ -460,11 +460,6 @@ S operator&(const S& i, const swap_struct_t<T, F> v) {
460 return i & v.swap(); 460 return i & v.swap();
461} 461}
462 462
463template <typename S, typename T, typename F>
464S operator&(const swap_struct_t<T, F> v, const S& i) {
465 return static_cast<S>(v.swap() & i);
466}
467
468// Comparison 463// Comparison
469template <typename S, typename T, typename F> 464template <typename S, typename T, typename F>
470bool operator<(const S& p, const swap_struct_t<T, F> v) { 465bool operator<(const S& p, const swap_struct_t<T, F> v) {
diff --git a/src/core/frontend/applets/controller.cpp b/src/core/frontend/applets/controller.cpp
index 3300d4f79..27755cb58 100644
--- a/src/core/frontend/applets/controller.cpp
+++ b/src/core/frontend/applets/controller.cpp
@@ -3,6 +3,8 @@
3 3
4#include "common/assert.h" 4#include "common/assert.h"
5#include "common/logging/log.h" 5#include "common/logging/log.h"
6#include "common/settings.h"
7#include "common/settings_enums.h"
6#include "core/frontend/applets/controller.h" 8#include "core/frontend/applets/controller.h"
7#include "core/hid/emulated_controller.h" 9#include "core/hid/emulated_controller.h"
8#include "core/hid/hid_core.h" 10#include "core/hid/hid_core.h"
@@ -62,7 +64,7 @@ void DefaultControllerApplet::ReconfigureControllers(ReconfigureCallback callbac
62 controller->Connect(true); 64 controller->Connect(true);
63 } 65 }
64 } else if (index == 0 && parameters.enable_single_mode && parameters.allow_handheld && 66 } else if (index == 0 && parameters.enable_single_mode && parameters.allow_handheld &&
65 !Settings::values.use_docked_mode.GetValue()) { 67 !Settings::IsDockedMode()) {
66 // We should *never* reach here under any normal circumstances. 68 // We should *never* reach here under any normal circumstances.
67 controller->SetNpadStyleIndex(Core::HID::NpadStyleIndex::Handheld); 69 controller->SetNpadStyleIndex(Core::HID::NpadStyleIndex::Handheld);
68 controller->Connect(true); 70 controller->Connect(true);
diff --git a/src/core/frontend/framebuffer_layout.cpp b/src/core/frontend/framebuffer_layout.cpp
index b4081fc39..2590b20da 100644
--- a/src/core/frontend/framebuffer_layout.cpp
+++ b/src/core/frontend/framebuffer_layout.cpp
@@ -5,6 +5,7 @@
5 5
6#include "common/assert.h" 6#include "common/assert.h"
7#include "common/settings.h" 7#include "common/settings.h"
8#include "common/settings_enums.h"
8#include "core/frontend/framebuffer_layout.h" 9#include "core/frontend/framebuffer_layout.h"
9 10
10namespace Layout { 11namespace Layout {
@@ -49,7 +50,7 @@ FramebufferLayout DefaultFrameLayout(u32 width, u32 height) {
49} 50}
50 51
51FramebufferLayout FrameLayoutFromResolutionScale(f32 res_scale) { 52FramebufferLayout FrameLayoutFromResolutionScale(f32 res_scale) {
52 const bool is_docked = Settings::values.use_docked_mode.GetValue(); 53 const bool is_docked = Settings::IsDockedMode();
53 const u32 screen_width = is_docked ? ScreenDocked::Width : ScreenUndocked::Width; 54 const u32 screen_width = is_docked ? ScreenDocked::Width : ScreenUndocked::Width;
54 const u32 screen_height = is_docked ? ScreenDocked::Height : ScreenUndocked::Height; 55 const u32 screen_height = is_docked ? ScreenDocked::Height : ScreenUndocked::Height;
55 56
diff --git a/src/core/hle/service/am/am.cpp b/src/core/hle/service/am/am.cpp
index 8d057b3a8..da33f0e44 100644
--- a/src/core/hle/service/am/am.cpp
+++ b/src/core/hle/service/am/am.cpp
@@ -6,6 +6,7 @@
6#include <cinttypes> 6#include <cinttypes>
7#include <cstring> 7#include <cstring>
8#include "common/settings.h" 8#include "common/settings.h"
9#include "common/settings_enums.h"
9#include "core/core.h" 10#include "core/core.h"
10#include "core/file_sys/control_metadata.h" 11#include "core/file_sys/control_metadata.h"
11#include "core/file_sys/patch_manager.h" 12#include "core/file_sys/patch_manager.h"
@@ -833,7 +834,7 @@ void ICommonStateGetter::GetDefaultDisplayResolution(HLERequestContext& ctx) {
833 IPC::ResponseBuilder rb{ctx, 4}; 834 IPC::ResponseBuilder rb{ctx, 4};
834 rb.Push(ResultSuccess); 835 rb.Push(ResultSuccess);
835 836
836 if (Settings::values.use_docked_mode.GetValue()) { 837 if (Settings::IsDockedMode()) {
837 rb.Push(static_cast<u32>(Service::VI::DisplayResolution::DockedWidth)); 838 rb.Push(static_cast<u32>(Service::VI::DisplayResolution::DockedWidth));
838 rb.Push(static_cast<u32>(Service::VI::DisplayResolution::DockedHeight)); 839 rb.Push(static_cast<u32>(Service::VI::DisplayResolution::DockedHeight));
839 } else { 840 } else {
@@ -921,7 +922,7 @@ void IStorage::Open(HLERequestContext& ctx) {
921} 922}
922 923
923void ICommonStateGetter::GetOperationMode(HLERequestContext& ctx) { 924void ICommonStateGetter::GetOperationMode(HLERequestContext& ctx) {
924 const bool use_docked_mode{Settings::values.use_docked_mode.GetValue()}; 925 const bool use_docked_mode{Settings::IsDockedMode()};
925 LOG_DEBUG(Service_AM, "called, use_docked_mode={}", use_docked_mode); 926 LOG_DEBUG(Service_AM, "called, use_docked_mode={}", use_docked_mode);
926 927
927 IPC::ResponseBuilder rb{ctx, 3}; 928 IPC::ResponseBuilder rb{ctx, 3};
diff --git a/src/core/hle/service/apm/apm_controller.cpp b/src/core/hle/service/apm/apm_controller.cpp
index 227fdd0cf..4f1aa5cc2 100644
--- a/src/core/hle/service/apm/apm_controller.cpp
+++ b/src/core/hle/service/apm/apm_controller.cpp
@@ -7,6 +7,7 @@
7 7
8#include "common/logging/log.h" 8#include "common/logging/log.h"
9#include "common/settings.h" 9#include "common/settings.h"
10#include "common/settings_enums.h"
10#include "core/core_timing.h" 11#include "core/core_timing.h"
11#include "core/hle/service/apm/apm_controller.h" 12#include "core/hle/service/apm/apm_controller.h"
12 13
@@ -67,8 +68,7 @@ void Controller::SetFromCpuBoostMode(CpuBoostMode mode) {
67} 68}
68 69
69PerformanceMode Controller::GetCurrentPerformanceMode() const { 70PerformanceMode Controller::GetCurrentPerformanceMode() const {
70 return Settings::values.use_docked_mode.GetValue() ? PerformanceMode::Boost 71 return Settings::IsDockedMode() ? PerformanceMode::Boost : PerformanceMode::Normal;
71 : PerformanceMode::Normal;
72} 72}
73 73
74PerformanceConfiguration Controller::GetCurrentPerformanceConfiguration(PerformanceMode mode) { 74PerformanceConfiguration Controller::GetCurrentPerformanceConfiguration(PerformanceMode mode) {
diff --git a/src/core/hle/service/hid/controllers/gesture.cpp b/src/core/hle/service/hid/controllers/gesture.cpp
index 03432f7cb..63eecd42b 100644
--- a/src/core/hle/service/hid/controllers/gesture.cpp
+++ b/src/core/hle/service/hid/controllers/gesture.cpp
@@ -331,7 +331,7 @@ Controller_Gesture::GestureProperties Controller_Gesture::GetGestureProperties()
331 }; 331 };
332 332
333 // Hack: There is no touch in docked but games still allow it 333 // Hack: There is no touch in docked but games still allow it
334 if (Settings::values.use_docked_mode.GetValue()) { 334 if (Settings::IsDockedMode()) {
335 gesture.points[id] = { 335 gesture.points[id] = {
336 .x = static_cast<s32>(active_x * Layout::ScreenDocked::Width), 336 .x = static_cast<s32>(active_x * Layout::ScreenDocked::Width),
337 .y = static_cast<s32>(active_y * Layout::ScreenDocked::Height), 337 .y = static_cast<s32>(active_y * Layout::ScreenDocked::Height),
diff --git a/src/core/hle/service/hid/controllers/npad.cpp b/src/core/hle/service/hid/controllers/npad.cpp
index 28818c813..3b349b4c4 100644
--- a/src/core/hle/service/hid/controllers/npad.cpp
+++ b/src/core/hle/service/hid/controllers/npad.cpp
@@ -1518,7 +1518,7 @@ bool Controller_NPad::IsControllerSupported(Core::HID::NpadStyleIndex controller
1518 return false; 1518 return false;
1519 } 1519 }
1520 // Handheld shouldn't be supported in docked mode 1520 // Handheld shouldn't be supported in docked mode
1521 if (Settings::values.use_docked_mode.GetValue()) { 1521 if (Settings::IsDockedMode()) {
1522 return false; 1522 return false;
1523 } 1523 }
1524 1524
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp
index 6bb02393c..2eb978379 100644
--- a/src/core/hle/service/vi/vi.cpp
+++ b/src/core/hle/service/vi/vi.cpp
@@ -217,7 +217,7 @@ private:
217 IPC::ResponseBuilder rb{ctx, 6}; 217 IPC::ResponseBuilder rb{ctx, 6};
218 rb.Push(ResultSuccess); 218 rb.Push(ResultSuccess);
219 219
220 if (Settings::values.use_docked_mode.GetValue()) { 220 if (Settings::IsDockedMode()) {
221 rb.Push(static_cast<u32>(Service::VI::DisplayResolution::DockedWidth)); 221 rb.Push(static_cast<u32>(Service::VI::DisplayResolution::DockedWidth));
222 rb.Push(static_cast<u32>(Service::VI::DisplayResolution::DockedHeight)); 222 rb.Push(static_cast<u32>(Service::VI::DisplayResolution::DockedHeight));
223 } else { 223 } else {
diff --git a/src/core/telemetry_session.cpp b/src/core/telemetry_session.cpp
index 62b3f6636..c26179e03 100644
--- a/src/core/telemetry_session.cpp
+++ b/src/core/telemetry_session.cpp
@@ -14,6 +14,7 @@
14#include "common/logging/log.h" 14#include "common/logging/log.h"
15 15
16#include "common/settings.h" 16#include "common/settings.h"
17#include "common/settings_enums.h"
17#include "core/file_sys/control_metadata.h" 18#include "core/file_sys/control_metadata.h"
18#include "core/file_sys/patch_manager.h" 19#include "core/file_sys/patch_manager.h"
19#include "core/loader/loader.h" 20#include "core/loader/loader.h"
@@ -275,7 +276,7 @@ void TelemetrySession::AddInitialInfo(Loader::AppLoader& app_loader,
275 static_cast<u32>(Settings::values.shader_backend.GetValue())); 276 static_cast<u32>(Settings::values.shader_backend.GetValue()));
276 AddField(field_type, "Renderer_UseAsynchronousShaders", 277 AddField(field_type, "Renderer_UseAsynchronousShaders",
277 Settings::values.use_asynchronous_shaders.GetValue()); 278 Settings::values.use_asynchronous_shaders.GetValue());
278 AddField(field_type, "System_UseDockedMode", Settings::values.use_docked_mode.GetValue()); 279 AddField(field_type, "System_UseDockedMode", Settings::IsDockedMode());
279} 280}
280 281
281bool TelemetrySession::SubmitTestcase() { 282bool TelemetrySession::SubmitTestcase() {
diff --git a/src/input_common/input_poller.cpp b/src/input_common/input_poller.cpp
index 870e76ab0..188e862d7 100644
--- a/src/input_common/input_poller.cpp
+++ b/src/input_common/input_poller.cpp
@@ -835,15 +835,15 @@ public:
835 return input_engine->SupportsNfc(identifier); 835 return input_engine->SupportsNfc(identifier);
836 } 836 }
837 837
838 Common::Input::NfcState StartNfcPolling() { 838 Common::Input::NfcState StartNfcPolling() override {
839 return input_engine->StartNfcPolling(identifier); 839 return input_engine->StartNfcPolling(identifier);
840 } 840 }
841 841
842 Common::Input::NfcState StopNfcPolling() { 842 Common::Input::NfcState StopNfcPolling() override {
843 return input_engine->StopNfcPolling(identifier); 843 return input_engine->StopNfcPolling(identifier);
844 } 844 }
845 845
846 Common::Input::NfcState ReadAmiiboData(std::vector<u8>& out_data) { 846 Common::Input::NfcState ReadAmiiboData(std::vector<u8>& out_data) override {
847 return input_engine->ReadAmiiboData(identifier, out_data); 847 return input_engine->ReadAmiiboData(identifier, out_data);
848 } 848 }
849 849
@@ -852,11 +852,11 @@ public:
852 } 852 }
853 853
854 Common::Input::NfcState ReadMifareData(const Common::Input::MifareRequest& request, 854 Common::Input::NfcState ReadMifareData(const Common::Input::MifareRequest& request,
855 Common::Input::MifareRequest& out_data) { 855 Common::Input::MifareRequest& out_data) override {
856 return input_engine->ReadMifareData(identifier, request, out_data); 856 return input_engine->ReadMifareData(identifier, request, out_data);
857 } 857 }
858 858
859 Common::Input::NfcState WriteMifareData(const Common::Input::MifareRequest& request) { 859 Common::Input::NfcState WriteMifareData(const Common::Input::MifareRequest& request) override {
860 return input_engine->WriteMifareData(identifier, request); 860 return input_engine->WriteMifareData(identifier, request);
861 } 861 }
862 862
diff --git a/src/video_core/macro/macro.cpp b/src/video_core/macro/macro.cpp
index 905505ca1..5d0bb9cc4 100644
--- a/src/video_core/macro/macro.cpp
+++ b/src/video_core/macro/macro.cpp
@@ -27,14 +27,24 @@ MICROPROFILE_DEFINE(MacroHLE, "GPU", "Execute macro HLE", MP_RGB(128, 192, 192))
27 27
28namespace Tegra { 28namespace Tegra {
29 29
30static void Dump(u64 hash, std::span<const u32> code) { 30static void Dump(u64 hash, std::span<const u32> code, bool decompiled = false) {
31 const auto base_dir{Common::FS::GetYuzuPath(Common::FS::YuzuPath::DumpDir)}; 31 const auto base_dir{Common::FS::GetYuzuPath(Common::FS::YuzuPath::DumpDir)};
32 const auto macro_dir{base_dir / "macros"}; 32 const auto macro_dir{base_dir / "macros"};
33 if (!Common::FS::CreateDir(base_dir) || !Common::FS::CreateDir(macro_dir)) { 33 if (!Common::FS::CreateDir(base_dir) || !Common::FS::CreateDir(macro_dir)) {
34 LOG_ERROR(Common_Filesystem, "Failed to create macro dump directories"); 34 LOG_ERROR(Common_Filesystem, "Failed to create macro dump directories");
35 return; 35 return;
36 } 36 }
37 const auto name{macro_dir / fmt::format("{:016x}.macro", hash)}; 37 auto name{macro_dir / fmt::format("{:016x}.macro", hash)};
38
39 if (decompiled) {
40 auto new_name{macro_dir / fmt::format("decompiled_{:016x}.macro", hash)};
41 if (Common::FS::Exists(name)) {
42 (void)Common::FS::RenameFile(name, new_name);
43 return;
44 }
45 name = new_name;
46 }
47
38 std::fstream macro_file(name, std::ios::out | std::ios::binary); 48 std::fstream macro_file(name, std::ios::out | std::ios::binary);
39 if (!macro_file) { 49 if (!macro_file) {
40 LOG_ERROR(Common_Filesystem, "Unable to open or create file at {}", 50 LOG_ERROR(Common_Filesystem, "Unable to open or create file at {}",
@@ -90,9 +100,6 @@ void MacroEngine::Execute(u32 method, const std::vector<u32>& parameters) {
90 if (!mid_method.has_value()) { 100 if (!mid_method.has_value()) {
91 cache_info.lle_program = Compile(macro_code->second); 101 cache_info.lle_program = Compile(macro_code->second);
92 cache_info.hash = Common::HashValue(macro_code->second); 102 cache_info.hash = Common::HashValue(macro_code->second);
93 if (Settings::values.dump_macros) {
94 Dump(cache_info.hash, macro_code->second);
95 }
96 } else { 103 } else {
97 const auto& macro_cached = uploaded_macro_code[mid_method.value()]; 104 const auto& macro_cached = uploaded_macro_code[mid_method.value()];
98 const auto rebased_method = method - mid_method.value(); 105 const auto rebased_method = method - mid_method.value();
@@ -102,9 +109,6 @@ void MacroEngine::Execute(u32 method, const std::vector<u32>& parameters) {
102 code.size() * sizeof(u32)); 109 code.size() * sizeof(u32));
103 cache_info.hash = Common::HashValue(code); 110 cache_info.hash = Common::HashValue(code);
104 cache_info.lle_program = Compile(code); 111 cache_info.lle_program = Compile(code);
105 if (Settings::values.dump_macros) {
106 Dump(cache_info.hash, code);
107 }
108 } 112 }
109 113
110 auto hle_program = hle_macros->GetHLEProgram(cache_info.hash); 114 auto hle_program = hle_macros->GetHLEProgram(cache_info.hash);
@@ -117,6 +121,10 @@ void MacroEngine::Execute(u32 method, const std::vector<u32>& parameters) {
117 MICROPROFILE_SCOPE(MacroHLE); 121 MICROPROFILE_SCOPE(MacroHLE);
118 cache_info.hle_program->Execute(parameters, method); 122 cache_info.hle_program->Execute(parameters, method);
119 } 123 }
124
125 if (Settings::values.dump_macros) {
126 Dump(cache_info.hash, macro_code->second, cache_info.has_hle_program);
127 }
120 } 128 }
121} 129}
122 130
diff --git a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp
index c1314ca99..fe432dfe1 100644
--- a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp
+++ b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp
@@ -611,9 +611,6 @@ std::unique_ptr<GraphicsPipeline> PipelineCache::CreateGraphicsPipeline(
611 611
612 const u32 cfg_offset{static_cast<u32>(env.StartAddress() + sizeof(Shader::ProgramHeader))}; 612 const u32 cfg_offset{static_cast<u32>(env.StartAddress() + sizeof(Shader::ProgramHeader))};
613 Shader::Maxwell::Flow::CFG cfg(env, pools.flow_block, cfg_offset, index == 0); 613 Shader::Maxwell::Flow::CFG cfg(env, pools.flow_block, cfg_offset, index == 0);
614 if (Settings::values.dump_shaders) {
615 env.Dump(hash, key.unique_hashes[index]);
616 }
617 if (!uses_vertex_a || index != 1) { 614 if (!uses_vertex_a || index != 1) {
618 // Normal path 615 // Normal path
619 programs[index] = TranslateProgram(pools.inst, pools.block, env, cfg, host_info); 616 programs[index] = TranslateProgram(pools.inst, pools.block, env, cfg, host_info);
@@ -624,6 +621,10 @@ std::unique_ptr<GraphicsPipeline> PipelineCache::CreateGraphicsPipeline(
624 programs[index] = MergeDualVertexPrograms(program_va, program_vb, env); 621 programs[index] = MergeDualVertexPrograms(program_va, program_vb, env);
625 } 622 }
626 623
624 if (Settings::values.dump_shaders) {
625 env.Dump(hash, key.unique_hashes[index]);
626 }
627
627 if (programs[index].info.requires_layer_emulation) { 628 if (programs[index].info.requires_layer_emulation) {
628 layer_source_program = &programs[index]; 629 layer_source_program = &programs[index];
629 } 630 }
diff --git a/src/web_service/verify_user_jwt.cpp b/src/web_service/verify_user_jwt.cpp
index 129eb1968..f88f67620 100644
--- a/src/web_service/verify_user_jwt.cpp
+++ b/src/web_service/verify_user_jwt.cpp
@@ -4,6 +4,7 @@
4#if defined(__GNUC__) || defined(__clang__) 4#if defined(__GNUC__) || defined(__clang__)
5#pragma GCC diagnostic push 5#pragma GCC diagnostic push
6#pragma GCC diagnostic ignored "-Wimplicit-fallthrough" 6#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
7#pragma GCC diagnostic ignored "-Wdeprecated-declarations" // for deprecated OpenSSL functions
7#endif 8#endif
8#include <jwt/jwt.hpp> 9#include <jwt/jwt.hpp>
9#if defined(__GNUC__) || defined(__clang__) 10#if defined(__GNUC__) || defined(__clang__)
diff --git a/src/yuzu/applets/qt_controller.cpp b/src/yuzu/applets/qt_controller.cpp
index 00aafb8f8..d15559518 100644
--- a/src/yuzu/applets/qt_controller.cpp
+++ b/src/yuzu/applets/qt_controller.cpp
@@ -5,6 +5,8 @@
5#include <thread> 5#include <thread>
6 6
7#include "common/assert.h" 7#include "common/assert.h"
8#include "common/settings.h"
9#include "common/settings_enums.h"
8#include "common/string_util.h" 10#include "common/string_util.h"
9#include "core/core.h" 11#include "core/core.h"
10#include "core/hid/emulated_controller.h" 12#include "core/hid/emulated_controller.h"
@@ -226,9 +228,11 @@ int QtControllerSelectorDialog::exec() {
226} 228}
227 229
228void QtControllerSelectorDialog::ApplyConfiguration() { 230void QtControllerSelectorDialog::ApplyConfiguration() {
229 const bool pre_docked_mode = Settings::values.use_docked_mode.GetValue(); 231 const bool pre_docked_mode = Settings::IsDockedMode();
230 Settings::values.use_docked_mode.SetValue(ui->radioDocked->isChecked()); 232 const bool docked_mode_selected = ui->radioDocked->isChecked();
231 OnDockedModeChanged(pre_docked_mode, Settings::values.use_docked_mode.GetValue(), system); 233 Settings::values.use_docked_mode.SetValue(
234 docked_mode_selected ? Settings::ConsoleMode::Docked : Settings::ConsoleMode::Handheld);
235 OnDockedModeChanged(pre_docked_mode, docked_mode_selected, system);
232 236
233 Settings::values.vibration_enabled.SetValue(ui->vibrationGroup->isChecked()); 237 Settings::values.vibration_enabled.SetValue(ui->vibrationGroup->isChecked());
234 Settings::values.motion_enabled.SetValue(ui->motionGroup->isChecked()); 238 Settings::values.motion_enabled.SetValue(ui->motionGroup->isChecked());
@@ -616,8 +620,8 @@ void QtControllerSelectorDialog::UpdateDockedState(bool is_handheld) {
616 ui->radioDocked->setEnabled(!is_handheld); 620 ui->radioDocked->setEnabled(!is_handheld);
617 ui->radioUndocked->setEnabled(!is_handheld); 621 ui->radioUndocked->setEnabled(!is_handheld);
618 622
619 ui->radioDocked->setChecked(Settings::values.use_docked_mode.GetValue()); 623 ui->radioDocked->setChecked(Settings::IsDockedMode());
620 ui->radioUndocked->setChecked(!Settings::values.use_docked_mode.GetValue()); 624 ui->radioUndocked->setChecked(!Settings::IsDockedMode());
621 625
622 // Also force into undocked mode if the controller type is handheld. 626 // Also force into undocked mode if the controller type is handheld.
623 if (is_handheld) { 627 if (is_handheld) {
diff --git a/src/yuzu/bootmanager.cpp b/src/yuzu/bootmanager.cpp
index 407988b8f..2afa72140 100644
--- a/src/yuzu/bootmanager.cpp
+++ b/src/yuzu/bootmanager.cpp
@@ -928,8 +928,8 @@ void GRenderWindow::CaptureScreenshot(const QString& screenshot_path) {
928 const Layout::FramebufferLayout layout{[]() { 928 const Layout::FramebufferLayout layout{[]() {
929 u32 height = UISettings::values.screenshot_height.GetValue(); 929 u32 height = UISettings::values.screenshot_height.GetValue();
930 if (height == 0) { 930 if (height == 0) {
931 height = Settings::values.use_docked_mode.GetValue() ? Layout::ScreenDocked::Height 931 height = Settings::IsDockedMode() ? Layout::ScreenDocked::Height
932 : Layout::ScreenUndocked::Height; 932 : Layout::ScreenUndocked::Height;
933 height *= Settings::values.resolution_info.up_factor; 933 height *= Settings::values.resolution_info.up_factor;
934 } 934 }
935 const u32 width = 935 const u32 width =
diff --git a/src/yuzu/configuration/config.cpp b/src/yuzu/configuration/config.cpp
index b22c83303..1de093447 100644
--- a/src/yuzu/configuration/config.cpp
+++ b/src/yuzu/configuration/config.cpp
@@ -9,6 +9,7 @@
9#include "common/fs/path_util.h" 9#include "common/fs/path_util.h"
10#include "common/settings.h" 10#include "common/settings.h"
11#include "common/settings_common.h" 11#include "common/settings_common.h"
12#include "common/settings_enums.h"
12#include "core/core.h" 13#include "core/core.h"
13#include "core/hle/service/acc/profile_manager.h" 14#include "core/hle/service/acc/profile_manager.h"
14#include "core/hle/service/hid/controllers/npad.h" 15#include "core/hle/service/hid/controllers/npad.h"
@@ -85,9 +86,9 @@ const std::map<Settings::ScalingFilter, QString> Config::scaling_filter_texts_ma
85 {Settings::ScalingFilter::Fsr, QStringLiteral(QT_TRANSLATE_NOOP("GMainWindow", "FSR"))}, 86 {Settings::ScalingFilter::Fsr, QStringLiteral(QT_TRANSLATE_NOOP("GMainWindow", "FSR"))},
86}; 87};
87 88
88const std::map<bool, QString> Config::use_docked_mode_texts_map = { 89const std::map<Settings::ConsoleMode, QString> Config::use_docked_mode_texts_map = {
89 {true, QStringLiteral(QT_TRANSLATE_NOOP("GMainWindow", "Docked"))}, 90 {Settings::ConsoleMode::Docked, QStringLiteral(QT_TRANSLATE_NOOP("GMainWindow", "Docked"))},
90 {false, QStringLiteral(QT_TRANSLATE_NOOP("GMainWindow", "Handheld"))}, 91 {Settings::ConsoleMode::Handheld, QStringLiteral(QT_TRANSLATE_NOOP("GMainWindow", "Handheld"))},
91}; 92};
92 93
93const std::map<Settings::GpuAccuracy, QString> Config::gpu_accuracy_texts_map = { 94const std::map<Settings::GpuAccuracy, QString> Config::gpu_accuracy_texts_map = {
@@ -376,7 +377,7 @@ void Config::ReadControlValues() {
376 const auto controller_type = Settings::values.players.GetValue()[0].controller_type; 377 const auto controller_type = Settings::values.players.GetValue()[0].controller_type;
377 if (controller_type == Settings::ControllerType::Handheld) { 378 if (controller_type == Settings::ControllerType::Handheld) {
378 Settings::values.use_docked_mode.SetGlobal(!IsCustomConfig()); 379 Settings::values.use_docked_mode.SetGlobal(!IsCustomConfig());
379 Settings::values.use_docked_mode.SetValue(false); 380 Settings::values.use_docked_mode.SetValue(Settings::ConsoleMode::Handheld);
380 } 381 }
381 382
382 if (IsCustomConfig()) { 383 if (IsCustomConfig()) {
diff --git a/src/yuzu/configuration/config.h b/src/yuzu/configuration/config.h
index 0ac74c8e7..727feebfb 100644
--- a/src/yuzu/configuration/config.h
+++ b/src/yuzu/configuration/config.h
@@ -9,6 +9,7 @@
9#include <QMetaType> 9#include <QMetaType>
10#include <QVariant> 10#include <QVariant>
11#include "common/settings.h" 11#include "common/settings.h"
12#include "common/settings_enums.h"
12#include "yuzu/uisettings.h" 13#include "yuzu/uisettings.h"
13 14
14class QSettings; 15class QSettings;
@@ -51,7 +52,7 @@ public:
51 52
52 static const std::map<Settings::AntiAliasing, QString> anti_aliasing_texts_map; 53 static const std::map<Settings::AntiAliasing, QString> anti_aliasing_texts_map;
53 static const std::map<Settings::ScalingFilter, QString> scaling_filter_texts_map; 54 static const std::map<Settings::ScalingFilter, QString> scaling_filter_texts_map;
54 static const std::map<bool, QString> use_docked_mode_texts_map; 55 static const std::map<Settings::ConsoleMode, QString> use_docked_mode_texts_map;
55 static const std::map<Settings::GpuAccuracy, QString> gpu_accuracy_texts_map; 56 static const std::map<Settings::GpuAccuracy, QString> gpu_accuracy_texts_map;
56 static const std::map<Settings::RendererBackend, QString> renderer_backend_texts_map; 57 static const std::map<Settings::RendererBackend, QString> renderer_backend_texts_map;
57 static const std::map<Settings::ShaderBackend, QString> shader_backend_texts_map; 58 static const std::map<Settings::ShaderBackend, QString> shader_backend_texts_map;
diff --git a/src/yuzu/configuration/configure_input.cpp b/src/yuzu/configuration/configure_input.cpp
index 7fce85bca..e8f9ebfd8 100644
--- a/src/yuzu/configuration/configure_input.cpp
+++ b/src/yuzu/configuration/configure_input.cpp
@@ -4,6 +4,8 @@
4#include <memory> 4#include <memory>
5#include <thread> 5#include <thread>
6 6
7#include "common/settings.h"
8#include "common/settings_enums.h"
7#include "core/core.h" 9#include "core/core.h"
8#include "core/hid/emulated_controller.h" 10#include "core/hid/emulated_controller.h"
9#include "core/hid/hid_core.h" 11#include "core/hid/hid_core.h"
@@ -197,9 +199,11 @@ void ConfigureInput::ApplyConfiguration() {
197 199
198 advanced->ApplyConfiguration(); 200 advanced->ApplyConfiguration();
199 201
200 const bool pre_docked_mode = Settings::values.use_docked_mode.GetValue(); 202 const bool pre_docked_mode = Settings::IsDockedMode();
201 Settings::values.use_docked_mode.SetValue(ui->radioDocked->isChecked()); 203 const bool docked_mode_selected = ui->radioDocked->isChecked();
202 OnDockedModeChanged(pre_docked_mode, Settings::values.use_docked_mode.GetValue(), system); 204 Settings::values.use_docked_mode.SetValue(
205 docked_mode_selected ? Settings::ConsoleMode::Docked : Settings::ConsoleMode::Handheld);
206 OnDockedModeChanged(pre_docked_mode, docked_mode_selected, system);
203 207
204 Settings::values.vibration_enabled.SetValue(ui->vibrationGroup->isChecked()); 208 Settings::values.vibration_enabled.SetValue(ui->vibrationGroup->isChecked());
205 Settings::values.motion_enabled.SetValue(ui->motionGroup->isChecked()); 209 Settings::values.motion_enabled.SetValue(ui->motionGroup->isChecked());
@@ -267,8 +271,8 @@ void ConfigureInput::UpdateDockedState(bool is_handheld) {
267 ui->radioDocked->setEnabled(!is_handheld); 271 ui->radioDocked->setEnabled(!is_handheld);
268 ui->radioUndocked->setEnabled(!is_handheld); 272 ui->radioUndocked->setEnabled(!is_handheld);
269 273
270 ui->radioDocked->setChecked(Settings::values.use_docked_mode.GetValue()); 274 ui->radioDocked->setChecked(Settings::IsDockedMode());
271 ui->radioUndocked->setChecked(!Settings::values.use_docked_mode.GetValue()); 275 ui->radioUndocked->setChecked(!Settings::IsDockedMode());
272 276
273 // Also force into undocked mode if the controller type is handheld. 277 // Also force into undocked mode if the controller type is handheld.
274 if (is_handheld) { 278 if (is_handheld) {
diff --git a/src/yuzu/configuration/configure_per_game.cpp b/src/yuzu/configuration/configure_per_game.cpp
index 4f9e8db08..b91d6ad4a 100644
--- a/src/yuzu/configuration/configure_per_game.cpp
+++ b/src/yuzu/configuration/configure_per_game.cpp
@@ -18,6 +18,7 @@
18 18
19#include "common/fs/fs_util.h" 19#include "common/fs/fs_util.h"
20#include "common/settings_enums.h" 20#include "common/settings_enums.h"
21#include "common/settings_input.h"
21#include "configuration/shared_widget.h" 22#include "configuration/shared_widget.h"
22#include "core/core.h" 23#include "core/core.h"
23#include "core/file_sys/control_metadata.h" 24#include "core/file_sys/control_metadata.h"
@@ -98,6 +99,12 @@ void ConfigurePerGame::ApplyConfiguration() {
98 addons_tab->ApplyConfiguration(); 99 addons_tab->ApplyConfiguration();
99 input_tab->ApplyConfiguration(); 100 input_tab->ApplyConfiguration();
100 101
102 if (Settings::IsDockedMode() && Settings::values.players.GetValue()[0].controller_type ==
103 Settings::ControllerType::Handheld) {
104 Settings::values.use_docked_mode.SetValue(Settings::ConsoleMode::Handheld);
105 Settings::values.use_docked_mode.SetGlobal(true);
106 }
107
101 system.ApplySettings(); 108 system.ApplySettings();
102 Settings::LogSettings(); 109 Settings::LogSettings();
103 110
diff --git a/src/yuzu/configuration/configure_system.cpp b/src/yuzu/configuration/configure_system.cpp
index c4833f4e7..0c8e5c8b4 100644
--- a/src/yuzu/configuration/configure_system.cpp
+++ b/src/yuzu/configuration/configure_system.cpp
@@ -106,6 +106,11 @@ void ConfigureSystem::Setup(const ConfigurationShared::Builder& builder) {
106 push(Settings::values.linkage.by_category[Settings::Category::System]); 106 push(Settings::values.linkage.by_category[Settings::Category::System]);
107 107
108 for (auto setting : settings) { 108 for (auto setting : settings) {
109 if (setting->Id() == Settings::values.use_docked_mode.Id() &&
110 Settings::IsConfiguringGlobal()) {
111 continue;
112 }
113
109 ConfigurationShared::Widget* widget = builder.BuildWidget(setting, apply_funcs); 114 ConfigurationShared::Widget* widget = builder.BuildWidget(setting, apply_funcs);
110 115
111 if (widget == nullptr) { 116 if (widget == nullptr) {
diff --git a/src/yuzu/configuration/shared_translation.cpp b/src/yuzu/configuration/shared_translation.cpp
index 335810788..276bdbaba 100644
--- a/src/yuzu/configuration/shared_translation.cpp
+++ b/src/yuzu/configuration/shared_translation.cpp
@@ -135,7 +135,7 @@ std::unique_ptr<TranslationMap> InitializeTranslations(QWidget* parent) {
135 INSERT(Settings, region_index, "Region:", ""); 135 INSERT(Settings, region_index, "Region:", "");
136 INSERT(Settings, time_zone_index, "Time Zone:", ""); 136 INSERT(Settings, time_zone_index, "Time Zone:", "");
137 INSERT(Settings, sound_index, "Sound Output Mode:", ""); 137 INSERT(Settings, sound_index, "Sound Output Mode:", "");
138 INSERT(Settings, use_docked_mode, "", ""); 138 INSERT(Settings, use_docked_mode, "Console Mode:", "");
139 INSERT(Settings, current_user, "", ""); 139 INSERT(Settings, current_user, "", "");
140 140
141 // Controls 141 // Controls
@@ -379,6 +379,9 @@ std::unique_ptr<ComboboxTranslationMap> ComboboxEnumeration(QWidget* parent) {
379 PAIR(MemoryLayout, Memory_6Gb, "6GB DRAM (Unsafe)"), 379 PAIR(MemoryLayout, Memory_6Gb, "6GB DRAM (Unsafe)"),
380 PAIR(MemoryLayout, Memory_8Gb, "8GB DRAM (Unsafe)"), 380 PAIR(MemoryLayout, Memory_8Gb, "8GB DRAM (Unsafe)"),
381 }}); 381 }});
382 translations->insert(
383 {Settings::EnumMetadata<Settings::ConsoleMode>::Index(),
384 {PAIR(ConsoleMode, Docked, "Docked"), PAIR(ConsoleMode, Handheld, "Handheld")}});
382 385
383#undef PAIR 386#undef PAIR
384#undef CTX_PAIR 387#undef CTX_PAIR
diff --git a/src/yuzu/configuration/shared_widget.cpp b/src/yuzu/configuration/shared_widget.cpp
index 4e45bc844..7721e58f9 100644
--- a/src/yuzu/configuration/shared_widget.cpp
+++ b/src/yuzu/configuration/shared_widget.cpp
@@ -23,6 +23,7 @@
23#include <QLineEdit> 23#include <QLineEdit>
24#include <QObject> 24#include <QObject>
25#include <QPushButton> 25#include <QPushButton>
26#include <QRadioButton>
26#include <QRegularExpression> 27#include <QRegularExpression>
27#include <QSizePolicy> 28#include <QSizePolicy>
28#include <QSlider> 29#include <QSlider>
@@ -171,6 +172,65 @@ QWidget* Widget::CreateCombobox(std::function<std::string()>& serializer,
171 return combobox; 172 return combobox;
172} 173}
173 174
175QWidget* Widget::CreateRadioGroup(std::function<std::string()>& serializer,
176 std::function<void()>& restore_func,
177 const std::function<void()>& touch) {
178 const auto type = setting.EnumIndex();
179
180 QWidget* group = new QWidget(this);
181 QHBoxLayout* layout = new QHBoxLayout(group);
182 layout->setContentsMargins(0, 0, 0, 0);
183 group->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Preferred);
184
185 const ComboboxTranslations* enumeration{nullptr};
186 if (combobox_enumerations.contains(type)) {
187 enumeration = &combobox_enumerations.at(type);
188 for (const auto& [id, name] : *enumeration) {
189 QRadioButton* radio_button = new QRadioButton(name, group);
190 layout->addWidget(radio_button);
191 radio_buttons.push_back({id, radio_button});
192 }
193 } else {
194 return group;
195 }
196
197 const auto get_selected = [=]() -> u32 {
198 for (const auto& [id, button] : radio_buttons) {
199 if (button->isChecked()) {
200 return id;
201 }
202 }
203 return -1;
204 };
205
206 const auto set_index = [=](u32 value) {
207 for (const auto& [id, button] : radio_buttons) {
208 button->setChecked(id == value);
209 }
210 };
211
212 const u32 setting_value = std::stoi(setting.ToString());
213 set_index(setting_value);
214
215 serializer = [get_selected]() {
216 int current = get_selected();
217 return std::to_string(current);
218 };
219
220 restore_func = [this, set_index]() {
221 const u32 global_value = std::stoi(RelevantDefault(setting));
222 set_index(global_value);
223 };
224
225 if (!Settings::IsConfiguringGlobal()) {
226 for (const auto& [id, button] : radio_buttons) {
227 QObject::connect(button, &QAbstractButton::clicked, [touch]() { touch(); });
228 }
229 }
230
231 return group;
232}
233
174QWidget* Widget::CreateLineEdit(std::function<std::string()>& serializer, 234QWidget* Widget::CreateLineEdit(std::function<std::string()>& serializer,
175 std::function<void()>& restore_func, 235 std::function<void()>& restore_func,
176 const std::function<void()>& touch, bool managed) { 236 const std::function<void()>& touch, bool managed) {
@@ -411,6 +471,8 @@ void Widget::SetupComponent(const QString& label, std::function<void()>& load_fu
411 return RequestType::Slider; 471 return RequestType::Slider;
412 case Settings::Specialization::Countable: 472 case Settings::Specialization::Countable:
413 return RequestType::SpinBox; 473 return RequestType::SpinBox;
474 case Settings::Specialization::Radio:
475 return RequestType::RadioGroup;
414 default: 476 default:
415 break; 477 break;
416 } 478 }
@@ -439,7 +501,11 @@ void Widget::SetupComponent(const QString& label, std::function<void()>& load_fu
439 if (setting.TypeId() == typeid(bool)) { 501 if (setting.TypeId() == typeid(bool)) {
440 data_component = CreateCheckBox(&setting, label, serializer, restore_func, touch); 502 data_component = CreateCheckBox(&setting, label, serializer, restore_func, touch);
441 } else if (setting.IsEnum()) { 503 } else if (setting.IsEnum()) {
442 data_component = CreateCombobox(serializer, restore_func, touch); 504 if (request == RequestType::RadioGroup) {
505 data_component = CreateRadioGroup(serializer, restore_func, touch);
506 } else {
507 data_component = CreateCombobox(serializer, restore_func, touch);
508 }
443 } else if (type == typeid(u32) || type == typeid(int) || type == typeid(u16) || 509 } else if (type == typeid(u32) || type == typeid(int) || type == typeid(u16) ||
444 type == typeid(s64) || type == typeid(u8)) { 510 type == typeid(s64) || type == typeid(u8)) {
445 switch (request) { 511 switch (request) {
diff --git a/src/yuzu/configuration/shared_widget.h b/src/yuzu/configuration/shared_widget.h
index e64693bab..5303dd898 100644
--- a/src/yuzu/configuration/shared_widget.h
+++ b/src/yuzu/configuration/shared_widget.h
@@ -22,6 +22,7 @@ class QObject;
22class QPushButton; 22class QPushButton;
23class QSlider; 23class QSlider;
24class QSpinBox; 24class QSpinBox;
25class QRadioButton;
25 26
26namespace Settings { 27namespace Settings {
27class BasicSetting; 28class BasicSetting;
@@ -38,6 +39,7 @@ enum class RequestType {
38 LineEdit, 39 LineEdit,
39 HexEdit, 40 HexEdit,
40 DateTimeEdit, 41 DateTimeEdit,
42 RadioGroup,
41 MaxEnum, 43 MaxEnum,
42}; 44};
43 45
@@ -91,6 +93,7 @@ public:
91 QSlider* slider{}; 93 QSlider* slider{};
92 QComboBox* combobox{}; 94 QComboBox* combobox{};
93 QDateTimeEdit* date_time_edit{}; 95 QDateTimeEdit* date_time_edit{};
96 std::vector<std::pair<u32, QRadioButton*>> radio_buttons{};
94 97
95private: 98private:
96 void SetupComponent(const QString& label, std::function<void()>& load_func, bool managed, 99 void SetupComponent(const QString& label, std::function<void()>& load_func, bool managed,
@@ -106,6 +109,9 @@ private:
106 QWidget* CreateCombobox(std::function<std::string()>& serializer, 109 QWidget* CreateCombobox(std::function<std::string()>& serializer,
107 std::function<void()>& restore_func, 110 std::function<void()>& restore_func,
108 const std::function<void()>& touch); 111 const std::function<void()>& touch);
112 QWidget* CreateRadioGroup(std::function<std::string()>& serializer,
113 std::function<void()>& restore_func,
114 const std::function<void()>& touch);
109 QWidget* CreateLineEdit(std::function<std::string()>& serializer, 115 QWidget* CreateLineEdit(std::function<std::string()>& serializer,
110 std::function<void()>& restore_func, const std::function<void()>& touch, 116 std::function<void()>& restore_func, const std::function<void()>& touch,
111 bool managed = true); 117 bool managed = true);
diff --git a/src/yuzu/main.cpp b/src/yuzu/main.cpp
index 8e933af64..33c9fd0af 100644
--- a/src/yuzu/main.cpp
+++ b/src/yuzu/main.cpp
@@ -1158,9 +1158,9 @@ void GMainWindow::InitializeWidgets() {
1158 [this](const QPoint& menu_location) { 1158 [this](const QPoint& menu_location) {
1159 QMenu context_menu; 1159 QMenu context_menu;
1160 1160
1161 for (auto const& docked_mode_pair : Config::use_docked_mode_texts_map) { 1161 for (auto const& pair : Config::use_docked_mode_texts_map) {
1162 context_menu.addAction(docked_mode_pair.second, [this, docked_mode_pair] { 1162 context_menu.addAction(pair.second, [this, &pair] {
1163 if (docked_mode_pair.first != Settings::values.use_docked_mode.GetValue()) { 1163 if (pair.first != Settings::values.use_docked_mode.GetValue()) {
1164 OnToggleDockedMode(); 1164 OnToggleDockedMode();
1165 } 1165 }
1166 }); 1166 });
@@ -3674,7 +3674,7 @@ void GMainWindow::OnTasReset() {
3674} 3674}
3675 3675
3676void GMainWindow::OnToggleDockedMode() { 3676void GMainWindow::OnToggleDockedMode() {
3677 const bool is_docked = Settings::values.use_docked_mode.GetValue(); 3677 const bool is_docked = Settings::IsDockedMode();
3678 auto* player_1 = system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Player1); 3678 auto* player_1 = system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Player1);
3679 auto* handheld = system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Handheld); 3679 auto* handheld = system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Handheld);
3680 3680
@@ -3688,7 +3688,8 @@ void GMainWindow::OnToggleDockedMode() {
3688 controller_dialog->refreshConfiguration(); 3688 controller_dialog->refreshConfiguration();
3689 } 3689 }
3690 3690
3691 Settings::values.use_docked_mode.SetValue(!is_docked); 3691 Settings::values.use_docked_mode.SetValue(is_docked ? Settings::ConsoleMode::Handheld
3692 : Settings::ConsoleMode::Docked);
3692 UpdateDockedButton(); 3693 UpdateDockedButton();
3693 OnDockedModeChanged(is_docked, !is_docked, *system); 3694 OnDockedModeChanged(is_docked, !is_docked, *system);
3694} 3695}
@@ -4118,10 +4119,10 @@ void GMainWindow::UpdateGPUAccuracyButton() {
4118} 4119}
4119 4120
4120void GMainWindow::UpdateDockedButton() { 4121void GMainWindow::UpdateDockedButton() {
4121 const bool is_docked = Settings::values.use_docked_mode.GetValue(); 4122 const auto console_mode = Settings::values.use_docked_mode.GetValue();
4122 dock_status_button->setChecked(is_docked); 4123 dock_status_button->setChecked(Settings::IsDockedMode());
4123 dock_status_button->setText( 4124 dock_status_button->setText(
4124 Config::use_docked_mode_texts_map.find(is_docked)->second.toUpper()); 4125 Config::use_docked_mode_texts_map.find(console_mode)->second.toUpper());
4125} 4126}
4126 4127
4127void GMainWindow::UpdateAPIText() { 4128void GMainWindow::UpdateAPIText() {