diff options
21 files changed, 772 insertions, 226 deletions
diff --git a/src/common/settings.cpp b/src/common/settings.cpp index 84955030b..77ff21128 100644 --- a/src/common/settings.cpp +++ b/src/common/settings.cpp | |||
| @@ -205,6 +205,7 @@ void RestoreGlobalState(bool is_powered_on) { | |||
| 205 | // Renderer | 205 | // Renderer |
| 206 | values.fsr_sharpening_slider.SetGlobal(true); | 206 | values.fsr_sharpening_slider.SetGlobal(true); |
| 207 | values.renderer_backend.SetGlobal(true); | 207 | values.renderer_backend.SetGlobal(true); |
| 208 | values.async_presentation.SetGlobal(true); | ||
| 208 | values.renderer_force_max_clock.SetGlobal(true); | 209 | values.renderer_force_max_clock.SetGlobal(true); |
| 209 | values.vulkan_device.SetGlobal(true); | 210 | values.vulkan_device.SetGlobal(true); |
| 210 | values.fullscreen_mode.SetGlobal(true); | 211 | values.fullscreen_mode.SetGlobal(true); |
diff --git a/src/common/settings.h b/src/common/settings.h index b77a1580a..5379d0dd5 100644 --- a/src/common/settings.h +++ b/src/common/settings.h | |||
| @@ -422,6 +422,7 @@ struct Values { | |||
| 422 | // Renderer | 422 | // Renderer |
| 423 | SwitchableSetting<RendererBackend, true> renderer_backend{ | 423 | SwitchableSetting<RendererBackend, true> renderer_backend{ |
| 424 | RendererBackend::Vulkan, RendererBackend::OpenGL, RendererBackend::Null, "backend"}; | 424 | RendererBackend::Vulkan, RendererBackend::OpenGL, RendererBackend::Null, "backend"}; |
| 425 | SwitchableSetting<bool> async_presentation{false, "async_presentation"}; | ||
| 425 | SwitchableSetting<bool> renderer_force_max_clock{false, "force_max_clock"}; | 426 | SwitchableSetting<bool> renderer_force_max_clock{false, "force_max_clock"}; |
| 426 | Setting<bool> renderer_debug{false, "debug"}; | 427 | Setting<bool> renderer_debug{false, "debug"}; |
| 427 | Setting<bool> renderer_shader_feedback{false, "shader_feedback"}; | 428 | Setting<bool> renderer_shader_feedback{false, "shader_feedback"}; |
diff --git a/src/video_core/CMakeLists.txt b/src/video_core/CMakeLists.txt index 92cab93f3..a0009a36f 100644 --- a/src/video_core/CMakeLists.txt +++ b/src/video_core/CMakeLists.txt | |||
| @@ -179,6 +179,8 @@ add_library(video_core STATIC | |||
| 179 | renderer_vulkan/vk_master_semaphore.h | 179 | renderer_vulkan/vk_master_semaphore.h |
| 180 | renderer_vulkan/vk_pipeline_cache.cpp | 180 | renderer_vulkan/vk_pipeline_cache.cpp |
| 181 | renderer_vulkan/vk_pipeline_cache.h | 181 | renderer_vulkan/vk_pipeline_cache.h |
| 182 | renderer_vulkan/vk_present_manager.cpp | ||
| 183 | renderer_vulkan/vk_present_manager.h | ||
| 182 | renderer_vulkan/vk_query_cache.cpp | 184 | renderer_vulkan/vk_query_cache.cpp |
| 183 | renderer_vulkan/vk_query_cache.h | 185 | renderer_vulkan/vk_query_cache.h |
| 184 | renderer_vulkan/vk_rasterizer.cpp | 186 | renderer_vulkan/vk_rasterizer.cpp |
diff --git a/src/video_core/renderer_vulkan/renderer_vulkan.cpp b/src/video_core/renderer_vulkan/renderer_vulkan.cpp index 2a8d9e377..69dc76180 100644 --- a/src/video_core/renderer_vulkan/renderer_vulkan.cpp +++ b/src/video_core/renderer_vulkan/renderer_vulkan.cpp | |||
| @@ -93,8 +93,9 @@ RendererVulkan::RendererVulkan(Core::TelemetrySession& telemetry_session_, | |||
| 93 | state_tracker(), scheduler(device, state_tracker), | 93 | state_tracker(), scheduler(device, state_tracker), |
| 94 | swapchain(*surface, device, scheduler, render_window.GetFramebufferLayout().width, | 94 | swapchain(*surface, device, scheduler, render_window.GetFramebufferLayout().width, |
| 95 | render_window.GetFramebufferLayout().height, false), | 95 | render_window.GetFramebufferLayout().height, false), |
| 96 | blit_screen(cpu_memory, render_window, device, memory_allocator, swapchain, scheduler, | 96 | present_manager(render_window, device, memory_allocator, scheduler, swapchain), |
| 97 | screen_info), | 97 | blit_screen(cpu_memory, render_window, device, memory_allocator, swapchain, present_manager, |
| 98 | scheduler, screen_info), | ||
| 98 | rasterizer(render_window, gpu, cpu_memory, screen_info, device, memory_allocator, | 99 | rasterizer(render_window, gpu, cpu_memory, screen_info, device, memory_allocator, |
| 99 | state_tracker, scheduler) { | 100 | state_tracker, scheduler) { |
| 100 | if (Settings::values.renderer_force_max_clock.GetValue() && device.ShouldBoostClocks()) { | 101 | if (Settings::values.renderer_force_max_clock.GetValue() && device.ShouldBoostClocks()) { |
| @@ -121,46 +122,19 @@ void RendererVulkan::SwapBuffers(const Tegra::FramebufferConfig* framebuffer) { | |||
| 121 | return; | 122 | return; |
| 122 | } | 123 | } |
| 123 | // Update screen info if the framebuffer size has changed. | 124 | // Update screen info if the framebuffer size has changed. |
| 124 | if (screen_info.width != framebuffer->width || screen_info.height != framebuffer->height) { | 125 | screen_info.width = framebuffer->width; |
| 125 | screen_info.width = framebuffer->width; | 126 | screen_info.height = framebuffer->height; |
| 126 | screen_info.height = framebuffer->height; | 127 | |
| 127 | } | ||
| 128 | const VAddr framebuffer_addr = framebuffer->address + framebuffer->offset; | 128 | const VAddr framebuffer_addr = framebuffer->address + framebuffer->offset; |
| 129 | const bool use_accelerated = | 129 | const bool use_accelerated = |
| 130 | rasterizer.AccelerateDisplay(*framebuffer, framebuffer_addr, framebuffer->stride); | 130 | rasterizer.AccelerateDisplay(*framebuffer, framebuffer_addr, framebuffer->stride); |
| 131 | const bool is_srgb = use_accelerated && screen_info.is_srgb; | 131 | const bool is_srgb = use_accelerated && screen_info.is_srgb; |
| 132 | RenderScreenshot(*framebuffer, use_accelerated); | 132 | RenderScreenshot(*framebuffer, use_accelerated); |
| 133 | 133 | ||
| 134 | bool has_been_recreated = false; | 134 | Frame* frame = present_manager.GetRenderFrame(); |
| 135 | const auto recreate_swapchain = [&](u32 width, u32 height) { | 135 | blit_screen.DrawToSwapchain(frame, *framebuffer, use_accelerated, is_srgb); |
| 136 | if (!has_been_recreated) { | 136 | scheduler.Flush(*frame->render_ready); |
| 137 | has_been_recreated = true; | 137 | scheduler.Record([this, frame](vk::CommandBuffer) { present_manager.PushFrame(frame); }); |
| 138 | scheduler.Finish(); | ||
| 139 | } | ||
| 140 | swapchain.Create(width, height, is_srgb); | ||
| 141 | }; | ||
| 142 | |||
| 143 | const Layout::FramebufferLayout layout = render_window.GetFramebufferLayout(); | ||
| 144 | if (swapchain.NeedsRecreation(is_srgb) || swapchain.GetWidth() != layout.width || | ||
| 145 | swapchain.GetHeight() != layout.height) { | ||
| 146 | recreate_swapchain(layout.width, layout.height); | ||
| 147 | } | ||
| 148 | bool is_outdated; | ||
| 149 | do { | ||
| 150 | swapchain.AcquireNextImage(); | ||
| 151 | is_outdated = swapchain.IsOutDated(); | ||
| 152 | if (is_outdated) { | ||
| 153 | recreate_swapchain(layout.width, layout.height); | ||
| 154 | } | ||
| 155 | } while (is_outdated); | ||
| 156 | if (has_been_recreated) { | ||
| 157 | blit_screen.Recreate(); | ||
| 158 | } | ||
| 159 | const VkSemaphore render_semaphore = blit_screen.DrawToSwapchain(*framebuffer, use_accelerated); | ||
| 160 | const VkSemaphore present_semaphore = swapchain.CurrentPresentSemaphore(); | ||
| 161 | scheduler.Flush(render_semaphore, present_semaphore); | ||
| 162 | scheduler.WaitWorker(); | ||
| 163 | swapchain.Present(render_semaphore); | ||
| 164 | 138 | ||
| 165 | gpu.RendererFrameEndNotify(); | 139 | gpu.RendererFrameEndNotify(); |
| 166 | rasterizer.TickFrame(); | 140 | rasterizer.TickFrame(); |
| @@ -246,8 +220,7 @@ void Vulkan::RendererVulkan::RenderScreenshot(const Tegra::FramebufferConfig& fr | |||
| 246 | }); | 220 | }); |
| 247 | const VkExtent2D render_area{.width = layout.width, .height = layout.height}; | 221 | const VkExtent2D render_area{.width = layout.width, .height = layout.height}; |
| 248 | const vk::Framebuffer screenshot_fb = blit_screen.CreateFramebuffer(*dst_view, render_area); | 222 | const vk::Framebuffer screenshot_fb = blit_screen.CreateFramebuffer(*dst_view, render_area); |
| 249 | // Since we're not rendering to the screen, ignore the render semaphore. | 223 | blit_screen.Draw(framebuffer, *screenshot_fb, layout, render_area, use_accelerated); |
| 250 | void(blit_screen.Draw(framebuffer, *screenshot_fb, layout, render_area, use_accelerated)); | ||
| 251 | 224 | ||
| 252 | const auto buffer_size = static_cast<VkDeviceSize>(layout.width * layout.height * 4); | 225 | const auto buffer_size = static_cast<VkDeviceSize>(layout.width * layout.height * 4); |
| 253 | const VkBufferCreateInfo dst_buffer_info{ | 226 | const VkBufferCreateInfo dst_buffer_info{ |
| @@ -270,7 +243,7 @@ void Vulkan::RendererVulkan::RenderScreenshot(const Tegra::FramebufferConfig& fr | |||
| 270 | .pNext = nullptr, | 243 | .pNext = nullptr, |
| 271 | .srcAccessMask = VK_ACCESS_MEMORY_WRITE_BIT, | 244 | .srcAccessMask = VK_ACCESS_MEMORY_WRITE_BIT, |
| 272 | .dstAccessMask = VK_ACCESS_TRANSFER_READ_BIT, | 245 | .dstAccessMask = VK_ACCESS_TRANSFER_READ_BIT, |
| 273 | .oldLayout = VK_IMAGE_LAYOUT_PRESENT_SRC_KHR, | 246 | .oldLayout = VK_IMAGE_LAYOUT_GENERAL, |
| 274 | .newLayout = VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, | 247 | .newLayout = VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, |
| 275 | .srcQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, | 248 | .srcQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, |
| 276 | .dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, | 249 | .dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, |
diff --git a/src/video_core/renderer_vulkan/renderer_vulkan.h b/src/video_core/renderer_vulkan/renderer_vulkan.h index 009e75e0d..f44367cb2 100644 --- a/src/video_core/renderer_vulkan/renderer_vulkan.h +++ b/src/video_core/renderer_vulkan/renderer_vulkan.h | |||
| @@ -9,6 +9,7 @@ | |||
| 9 | #include "common/dynamic_library.h" | 9 | #include "common/dynamic_library.h" |
| 10 | #include "video_core/renderer_base.h" | 10 | #include "video_core/renderer_base.h" |
| 11 | #include "video_core/renderer_vulkan/vk_blit_screen.h" | 11 | #include "video_core/renderer_vulkan/vk_blit_screen.h" |
| 12 | #include "video_core/renderer_vulkan/vk_present_manager.h" | ||
| 12 | #include "video_core/renderer_vulkan/vk_rasterizer.h" | 13 | #include "video_core/renderer_vulkan/vk_rasterizer.h" |
| 13 | #include "video_core/renderer_vulkan/vk_scheduler.h" | 14 | #include "video_core/renderer_vulkan/vk_scheduler.h" |
| 14 | #include "video_core/renderer_vulkan/vk_state_tracker.h" | 15 | #include "video_core/renderer_vulkan/vk_state_tracker.h" |
| @@ -76,6 +77,7 @@ private: | |||
| 76 | StateTracker state_tracker; | 77 | StateTracker state_tracker; |
| 77 | Scheduler scheduler; | 78 | Scheduler scheduler; |
| 78 | Swapchain swapchain; | 79 | Swapchain swapchain; |
| 80 | PresentManager present_manager; | ||
| 79 | BlitScreen blit_screen; | 81 | BlitScreen blit_screen; |
| 80 | RasterizerVulkan rasterizer; | 82 | RasterizerVulkan rasterizer; |
| 81 | std::optional<TurboMode> turbo_mode; | 83 | std::optional<TurboMode> turbo_mode; |
diff --git a/src/video_core/renderer_vulkan/vk_blit_screen.cpp b/src/video_core/renderer_vulkan/vk_blit_screen.cpp index 2f0cc27e8..1e0fdd3d9 100644 --- a/src/video_core/renderer_vulkan/vk_blit_screen.cpp +++ b/src/video_core/renderer_vulkan/vk_blit_screen.cpp | |||
| @@ -122,10 +122,12 @@ struct BlitScreen::BufferData { | |||
| 122 | 122 | ||
| 123 | BlitScreen::BlitScreen(Core::Memory::Memory& cpu_memory_, Core::Frontend::EmuWindow& render_window_, | 123 | BlitScreen::BlitScreen(Core::Memory::Memory& cpu_memory_, Core::Frontend::EmuWindow& render_window_, |
| 124 | const Device& device_, MemoryAllocator& memory_allocator_, | 124 | const Device& device_, MemoryAllocator& memory_allocator_, |
| 125 | Swapchain& swapchain_, Scheduler& scheduler_, const ScreenInfo& screen_info_) | 125 | Swapchain& swapchain_, PresentManager& present_manager_, |
| 126 | Scheduler& scheduler_, const ScreenInfo& screen_info_) | ||
| 126 | : cpu_memory{cpu_memory_}, render_window{render_window_}, device{device_}, | 127 | : cpu_memory{cpu_memory_}, render_window{render_window_}, device{device_}, |
| 127 | memory_allocator{memory_allocator_}, swapchain{swapchain_}, scheduler{scheduler_}, | 128 | memory_allocator{memory_allocator_}, swapchain{swapchain_}, present_manager{present_manager_}, |
| 128 | image_count{swapchain.GetImageCount()}, screen_info{screen_info_} { | 129 | scheduler{scheduler_}, image_count{swapchain.GetImageCount()}, screen_info{screen_info_}, |
| 130 | current_srgb{swapchain.IsSrgb()}, image_view_format{swapchain.GetImageViewFormat()} { | ||
| 129 | resource_ticks.resize(image_count); | 131 | resource_ticks.resize(image_count); |
| 130 | 132 | ||
| 131 | CreateStaticResources(); | 133 | CreateStaticResources(); |
| @@ -135,25 +137,20 @@ BlitScreen::BlitScreen(Core::Memory::Memory& cpu_memory_, Core::Frontend::EmuWin | |||
| 135 | BlitScreen::~BlitScreen() = default; | 137 | BlitScreen::~BlitScreen() = default; |
| 136 | 138 | ||
| 137 | void BlitScreen::Recreate() { | 139 | void BlitScreen::Recreate() { |
| 140 | present_manager.WaitPresent(); | ||
| 141 | scheduler.Finish(); | ||
| 142 | device.GetLogical().WaitIdle(); | ||
| 138 | CreateDynamicResources(); | 143 | CreateDynamicResources(); |
| 139 | } | 144 | } |
| 140 | 145 | ||
| 141 | VkSemaphore BlitScreen::Draw(const Tegra::FramebufferConfig& framebuffer, | 146 | void BlitScreen::Draw(const Tegra::FramebufferConfig& framebuffer, |
| 142 | const VkFramebuffer& host_framebuffer, | 147 | const VkFramebuffer& host_framebuffer, const Layout::FramebufferLayout layout, |
| 143 | const Layout::FramebufferLayout layout, VkExtent2D render_area, | 148 | VkExtent2D render_area, bool use_accelerated) { |
| 144 | bool use_accelerated) { | ||
| 145 | RefreshResources(framebuffer); | 149 | RefreshResources(framebuffer); |
| 146 | 150 | ||
| 147 | // Finish any pending renderpass | 151 | // Finish any pending renderpass |
| 148 | scheduler.RequestOutsideRenderPassOperationContext(); | 152 | scheduler.RequestOutsideRenderPassOperationContext(); |
| 149 | 153 | ||
| 150 | if (const auto swapchain_images = swapchain.GetImageCount(); swapchain_images != image_count) { | ||
| 151 | image_count = swapchain_images; | ||
| 152 | Recreate(); | ||
| 153 | } | ||
| 154 | |||
| 155 | const std::size_t image_index = swapchain.GetImageIndex(); | ||
| 156 | |||
| 157 | scheduler.Wait(resource_ticks[image_index]); | 154 | scheduler.Wait(resource_ticks[image_index]); |
| 158 | resource_ticks[image_index] = scheduler.CurrentTick(); | 155 | resource_ticks[image_index] = scheduler.CurrentTick(); |
| 159 | 156 | ||
| @@ -169,7 +166,7 @@ VkSemaphore BlitScreen::Draw(const Tegra::FramebufferConfig& framebuffer, | |||
| 169 | std::memcpy(mapped_span.data(), &data, sizeof(data)); | 166 | std::memcpy(mapped_span.data(), &data, sizeof(data)); |
| 170 | 167 | ||
| 171 | if (!use_accelerated) { | 168 | if (!use_accelerated) { |
| 172 | const u64 image_offset = GetRawImageOffset(framebuffer, image_index); | 169 | const u64 image_offset = GetRawImageOffset(framebuffer); |
| 173 | 170 | ||
| 174 | const VAddr framebuffer_addr = framebuffer.address + framebuffer.offset; | 171 | const VAddr framebuffer_addr = framebuffer.address + framebuffer.offset; |
| 175 | const u8* const host_ptr = cpu_memory.GetPointer(framebuffer_addr); | 172 | const u8* const host_ptr = cpu_memory.GetPointer(framebuffer_addr); |
| @@ -204,8 +201,8 @@ VkSemaphore BlitScreen::Draw(const Tegra::FramebufferConfig& framebuffer, | |||
| 204 | .depth = 1, | 201 | .depth = 1, |
| 205 | }, | 202 | }, |
| 206 | }; | 203 | }; |
| 207 | scheduler.Record([this, copy, image_index](vk::CommandBuffer cmdbuf) { | 204 | scheduler.Record([this, copy, index = image_index](vk::CommandBuffer cmdbuf) { |
| 208 | const VkImage image = *raw_images[image_index]; | 205 | const VkImage image = *raw_images[index]; |
| 209 | const VkImageMemoryBarrier base_barrier{ | 206 | const VkImageMemoryBarrier base_barrier{ |
| 210 | .sType = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER, | 207 | .sType = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER, |
| 211 | .pNext = nullptr, | 208 | .pNext = nullptr, |
| @@ -245,14 +242,15 @@ VkSemaphore BlitScreen::Draw(const Tegra::FramebufferConfig& framebuffer, | |||
| 245 | 242 | ||
| 246 | const auto anti_alias_pass = Settings::values.anti_aliasing.GetValue(); | 243 | const auto anti_alias_pass = Settings::values.anti_aliasing.GetValue(); |
| 247 | if (use_accelerated && anti_alias_pass == Settings::AntiAliasing::Fxaa) { | 244 | if (use_accelerated && anti_alias_pass == Settings::AntiAliasing::Fxaa) { |
| 248 | UpdateAADescriptorSet(image_index, source_image_view, false); | 245 | UpdateAADescriptorSet(source_image_view, false); |
| 249 | const u32 up_scale = Settings::values.resolution_info.up_scale; | 246 | const u32 up_scale = Settings::values.resolution_info.up_scale; |
| 250 | const u32 down_shift = Settings::values.resolution_info.down_shift; | 247 | const u32 down_shift = Settings::values.resolution_info.down_shift; |
| 251 | VkExtent2D size{ | 248 | VkExtent2D size{ |
| 252 | .width = (up_scale * framebuffer.width) >> down_shift, | 249 | .width = (up_scale * framebuffer.width) >> down_shift, |
| 253 | .height = (up_scale * framebuffer.height) >> down_shift, | 250 | .height = (up_scale * framebuffer.height) >> down_shift, |
| 254 | }; | 251 | }; |
| 255 | scheduler.Record([this, image_index, size, anti_alias_pass](vk::CommandBuffer cmdbuf) { | 252 | scheduler.Record([this, index = image_index, size, |
| 253 | anti_alias_pass](vk::CommandBuffer cmdbuf) { | ||
| 256 | const VkImageMemoryBarrier base_barrier{ | 254 | const VkImageMemoryBarrier base_barrier{ |
| 257 | .sType = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER, | 255 | .sType = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER, |
| 258 | .pNext = nullptr, | 256 | .pNext = nullptr, |
| @@ -326,7 +324,7 @@ VkSemaphore BlitScreen::Draw(const Tegra::FramebufferConfig& framebuffer, | |||
| 326 | 324 | ||
| 327 | cmdbuf.BindVertexBuffer(0, *buffer, offsetof(BufferData, vertices)); | 325 | cmdbuf.BindVertexBuffer(0, *buffer, offsetof(BufferData, vertices)); |
| 328 | cmdbuf.BindDescriptorSets(VK_PIPELINE_BIND_POINT_GRAPHICS, *aa_pipeline_layout, 0, | 326 | cmdbuf.BindDescriptorSets(VK_PIPELINE_BIND_POINT_GRAPHICS, *aa_pipeline_layout, 0, |
| 329 | aa_descriptor_sets[image_index], {}); | 327 | aa_descriptor_sets[index], {}); |
| 330 | cmdbuf.Draw(4, 1, 0, 0); | 328 | cmdbuf.Draw(4, 1, 0, 0); |
| 331 | cmdbuf.EndRenderPass(); | 329 | cmdbuf.EndRenderPass(); |
| 332 | 330 | ||
| @@ -369,81 +367,99 @@ VkSemaphore BlitScreen::Draw(const Tegra::FramebufferConfig& framebuffer, | |||
| 369 | }; | 367 | }; |
| 370 | VkImageView fsr_image_view = | 368 | VkImageView fsr_image_view = |
| 371 | fsr->Draw(scheduler, image_index, source_image_view, fsr_input_size, crop_rect); | 369 | fsr->Draw(scheduler, image_index, source_image_view, fsr_input_size, crop_rect); |
| 372 | UpdateDescriptorSet(image_index, fsr_image_view, true); | 370 | UpdateDescriptorSet(fsr_image_view, true); |
| 373 | } else { | 371 | } else { |
| 374 | const bool is_nn = | 372 | const bool is_nn = |
| 375 | Settings::values.scaling_filter.GetValue() == Settings::ScalingFilter::NearestNeighbor; | 373 | Settings::values.scaling_filter.GetValue() == Settings::ScalingFilter::NearestNeighbor; |
| 376 | UpdateDescriptorSet(image_index, source_image_view, is_nn); | 374 | UpdateDescriptorSet(source_image_view, is_nn); |
| 377 | } | 375 | } |
| 378 | 376 | ||
| 379 | scheduler.Record( | 377 | scheduler.Record([this, host_framebuffer, index = image_index, |
| 380 | [this, host_framebuffer, image_index, size = render_area](vk::CommandBuffer cmdbuf) { | 378 | size = render_area](vk::CommandBuffer cmdbuf) { |
| 381 | const f32 bg_red = Settings::values.bg_red.GetValue() / 255.0f; | 379 | const f32 bg_red = Settings::values.bg_red.GetValue() / 255.0f; |
| 382 | const f32 bg_green = Settings::values.bg_green.GetValue() / 255.0f; | 380 | const f32 bg_green = Settings::values.bg_green.GetValue() / 255.0f; |
| 383 | const f32 bg_blue = Settings::values.bg_blue.GetValue() / 255.0f; | 381 | const f32 bg_blue = Settings::values.bg_blue.GetValue() / 255.0f; |
| 384 | const VkClearValue clear_color{ | 382 | const VkClearValue clear_color{ |
| 385 | .color = {.float32 = {bg_red, bg_green, bg_blue, 1.0f}}, | 383 | .color = {.float32 = {bg_red, bg_green, bg_blue, 1.0f}}, |
| 386 | }; | 384 | }; |
| 387 | const VkRenderPassBeginInfo renderpass_bi{ | 385 | const VkRenderPassBeginInfo renderpass_bi{ |
| 388 | .sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO, | 386 | .sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO, |
| 389 | .pNext = nullptr, | 387 | .pNext = nullptr, |
| 390 | .renderPass = *renderpass, | 388 | .renderPass = *renderpass, |
| 391 | .framebuffer = host_framebuffer, | 389 | .framebuffer = host_framebuffer, |
| 392 | .renderArea = | 390 | .renderArea = |
| 393 | { | 391 | { |
| 394 | .offset = {0, 0}, | 392 | .offset = {0, 0}, |
| 395 | .extent = size, | 393 | .extent = size, |
| 396 | }, | 394 | }, |
| 397 | .clearValueCount = 1, | 395 | .clearValueCount = 1, |
| 398 | .pClearValues = &clear_color, | 396 | .pClearValues = &clear_color, |
| 399 | }; | 397 | }; |
| 400 | const VkViewport viewport{ | 398 | const VkViewport viewport{ |
| 401 | .x = 0.0f, | 399 | .x = 0.0f, |
| 402 | .y = 0.0f, | 400 | .y = 0.0f, |
| 403 | .width = static_cast<float>(size.width), | 401 | .width = static_cast<float>(size.width), |
| 404 | .height = static_cast<float>(size.height), | 402 | .height = static_cast<float>(size.height), |
| 405 | .minDepth = 0.0f, | 403 | .minDepth = 0.0f, |
| 406 | .maxDepth = 1.0f, | 404 | .maxDepth = 1.0f, |
| 407 | }; | 405 | }; |
| 408 | const VkRect2D scissor{ | 406 | const VkRect2D scissor{ |
| 409 | .offset = {0, 0}, | 407 | .offset = {0, 0}, |
| 410 | .extent = size, | 408 | .extent = size, |
| 411 | }; | 409 | }; |
| 412 | cmdbuf.BeginRenderPass(renderpass_bi, VK_SUBPASS_CONTENTS_INLINE); | 410 | cmdbuf.BeginRenderPass(renderpass_bi, VK_SUBPASS_CONTENTS_INLINE); |
| 413 | auto graphics_pipeline = [this]() { | 411 | auto graphics_pipeline = [this]() { |
| 414 | switch (Settings::values.scaling_filter.GetValue()) { | 412 | switch (Settings::values.scaling_filter.GetValue()) { |
| 415 | case Settings::ScalingFilter::NearestNeighbor: | 413 | case Settings::ScalingFilter::NearestNeighbor: |
| 416 | case Settings::ScalingFilter::Bilinear: | 414 | case Settings::ScalingFilter::Bilinear: |
| 417 | return *bilinear_pipeline; | 415 | return *bilinear_pipeline; |
| 418 | case Settings::ScalingFilter::Bicubic: | 416 | case Settings::ScalingFilter::Bicubic: |
| 419 | return *bicubic_pipeline; | 417 | return *bicubic_pipeline; |
| 420 | case Settings::ScalingFilter::Gaussian: | 418 | case Settings::ScalingFilter::Gaussian: |
| 421 | return *gaussian_pipeline; | 419 | return *gaussian_pipeline; |
| 422 | case Settings::ScalingFilter::ScaleForce: | 420 | case Settings::ScalingFilter::ScaleForce: |
| 423 | return *scaleforce_pipeline; | 421 | return *scaleforce_pipeline; |
| 424 | default: | 422 | default: |
| 425 | return *bilinear_pipeline; | 423 | return *bilinear_pipeline; |
| 426 | } | 424 | } |
| 427 | }(); | 425 | }(); |
| 428 | cmdbuf.BindPipeline(VK_PIPELINE_BIND_POINT_GRAPHICS, graphics_pipeline); | 426 | cmdbuf.BindPipeline(VK_PIPELINE_BIND_POINT_GRAPHICS, graphics_pipeline); |
| 429 | cmdbuf.SetViewport(0, viewport); | 427 | cmdbuf.SetViewport(0, viewport); |
| 430 | cmdbuf.SetScissor(0, scissor); | 428 | cmdbuf.SetScissor(0, scissor); |
| 431 | 429 | ||
| 432 | cmdbuf.BindVertexBuffer(0, *buffer, offsetof(BufferData, vertices)); | 430 | cmdbuf.BindVertexBuffer(0, *buffer, offsetof(BufferData, vertices)); |
| 433 | cmdbuf.BindDescriptorSets(VK_PIPELINE_BIND_POINT_GRAPHICS, *pipeline_layout, 0, | 431 | cmdbuf.BindDescriptorSets(VK_PIPELINE_BIND_POINT_GRAPHICS, *pipeline_layout, 0, |
| 434 | descriptor_sets[image_index], {}); | 432 | descriptor_sets[index], {}); |
| 435 | cmdbuf.Draw(4, 1, 0, 0); | 433 | cmdbuf.Draw(4, 1, 0, 0); |
| 436 | cmdbuf.EndRenderPass(); | 434 | cmdbuf.EndRenderPass(); |
| 437 | }); | 435 | }); |
| 438 | return *semaphores[image_index]; | ||
| 439 | } | 436 | } |
| 440 | 437 | ||
| 441 | VkSemaphore BlitScreen::DrawToSwapchain(const Tegra::FramebufferConfig& framebuffer, | 438 | void BlitScreen::DrawToSwapchain(Frame* frame, const Tegra::FramebufferConfig& framebuffer, |
| 442 | bool use_accelerated) { | 439 | bool use_accelerated, bool is_srgb) { |
| 443 | const std::size_t image_index = swapchain.GetImageIndex(); | 440 | // Recreate dynamic resources if the the image count or colorspace changed |
| 444 | const VkExtent2D render_area = swapchain.GetSize(); | 441 | if (const std::size_t swapchain_images = swapchain.GetImageCount(); |
| 442 | swapchain_images != image_count || current_srgb != is_srgb) { | ||
| 443 | current_srgb = is_srgb; | ||
| 444 | image_view_format = current_srgb ? VK_FORMAT_B8G8R8A8_SRGB : VK_FORMAT_B8G8R8A8_UNORM; | ||
| 445 | image_count = swapchain_images; | ||
| 446 | Recreate(); | ||
| 447 | } | ||
| 448 | |||
| 449 | // Recreate the presentation frame if the dimensions of the window changed | ||
| 445 | const Layout::FramebufferLayout layout = render_window.GetFramebufferLayout(); | 450 | const Layout::FramebufferLayout layout = render_window.GetFramebufferLayout(); |
| 446 | return Draw(framebuffer, *framebuffers[image_index], layout, render_area, use_accelerated); | 451 | if (layout.width != frame->width || layout.height != frame->height || |
| 452 | is_srgb != frame->is_srgb) { | ||
| 453 | Recreate(); | ||
| 454 | present_manager.RecreateFrame(frame, layout.width, layout.height, is_srgb, | ||
| 455 | image_view_format, *renderpass); | ||
| 456 | } | ||
| 457 | |||
| 458 | const VkExtent2D render_area{frame->width, frame->height}; | ||
| 459 | Draw(framebuffer, *frame->framebuffer, layout, render_area, use_accelerated); | ||
| 460 | if (++image_index >= image_count) { | ||
| 461 | image_index = 0; | ||
| 462 | } | ||
| 447 | } | 463 | } |
| 448 | 464 | ||
| 449 | vk::Framebuffer BlitScreen::CreateFramebuffer(const VkImageView& image_view, VkExtent2D extent) { | 465 | vk::Framebuffer BlitScreen::CreateFramebuffer(const VkImageView& image_view, VkExtent2D extent) { |
| @@ -471,13 +487,11 @@ void BlitScreen::CreateStaticResources() { | |||
| 471 | } | 487 | } |
| 472 | 488 | ||
| 473 | void BlitScreen::CreateDynamicResources() { | 489 | void BlitScreen::CreateDynamicResources() { |
| 474 | CreateSemaphores(); | ||
| 475 | CreateDescriptorPool(); | 490 | CreateDescriptorPool(); |
| 476 | CreateDescriptorSetLayout(); | 491 | CreateDescriptorSetLayout(); |
| 477 | CreateDescriptorSets(); | 492 | CreateDescriptorSets(); |
| 478 | CreatePipelineLayout(); | 493 | CreatePipelineLayout(); |
| 479 | CreateRenderPass(); | 494 | CreateRenderPass(); |
| 480 | CreateFramebuffers(); | ||
| 481 | CreateGraphicsPipeline(); | 495 | CreateGraphicsPipeline(); |
| 482 | fsr.reset(); | 496 | fsr.reset(); |
| 483 | smaa.reset(); | 497 | smaa.reset(); |
| @@ -525,11 +539,6 @@ void BlitScreen::CreateShaders() { | |||
| 525 | } | 539 | } |
| 526 | } | 540 | } |
| 527 | 541 | ||
| 528 | void BlitScreen::CreateSemaphores() { | ||
| 529 | semaphores.resize(image_count); | ||
| 530 | std::ranges::generate(semaphores, [this] { return device.GetLogical().CreateSemaphore(); }); | ||
| 531 | } | ||
| 532 | |||
| 533 | void BlitScreen::CreateDescriptorPool() { | 542 | void BlitScreen::CreateDescriptorPool() { |
| 534 | const std::array<VkDescriptorPoolSize, 2> pool_sizes{{ | 543 | const std::array<VkDescriptorPoolSize, 2> pool_sizes{{ |
| 535 | { | 544 | { |
| @@ -571,10 +580,10 @@ void BlitScreen::CreateDescriptorPool() { | |||
| 571 | } | 580 | } |
| 572 | 581 | ||
| 573 | void BlitScreen::CreateRenderPass() { | 582 | void BlitScreen::CreateRenderPass() { |
| 574 | renderpass = CreateRenderPassImpl(swapchain.GetImageViewFormat()); | 583 | renderpass = CreateRenderPassImpl(image_view_format); |
| 575 | } | 584 | } |
| 576 | 585 | ||
| 577 | vk::RenderPass BlitScreen::CreateRenderPassImpl(VkFormat format, bool is_present) { | 586 | vk::RenderPass BlitScreen::CreateRenderPassImpl(VkFormat format) { |
| 578 | const VkAttachmentDescription color_attachment{ | 587 | const VkAttachmentDescription color_attachment{ |
| 579 | .flags = 0, | 588 | .flags = 0, |
| 580 | .format = format, | 589 | .format = format, |
| @@ -584,7 +593,7 @@ vk::RenderPass BlitScreen::CreateRenderPassImpl(VkFormat format, bool is_present | |||
| 584 | .stencilLoadOp = VK_ATTACHMENT_LOAD_OP_DONT_CARE, | 593 | .stencilLoadOp = VK_ATTACHMENT_LOAD_OP_DONT_CARE, |
| 585 | .stencilStoreOp = VK_ATTACHMENT_STORE_OP_DONT_CARE, | 594 | .stencilStoreOp = VK_ATTACHMENT_STORE_OP_DONT_CARE, |
| 586 | .initialLayout = VK_IMAGE_LAYOUT_UNDEFINED, | 595 | .initialLayout = VK_IMAGE_LAYOUT_UNDEFINED, |
| 587 | .finalLayout = is_present ? VK_IMAGE_LAYOUT_PRESENT_SRC_KHR : VK_IMAGE_LAYOUT_GENERAL, | 596 | .finalLayout = VK_IMAGE_LAYOUT_GENERAL, |
| 588 | }; | 597 | }; |
| 589 | 598 | ||
| 590 | const VkAttachmentReference color_attachment_ref{ | 599 | const VkAttachmentReference color_attachment_ref{ |
| @@ -1052,16 +1061,6 @@ void BlitScreen::CreateSampler() { | |||
| 1052 | nn_sampler = device.GetLogical().CreateSampler(ci_nn); | 1061 | nn_sampler = device.GetLogical().CreateSampler(ci_nn); |
| 1053 | } | 1062 | } |
| 1054 | 1063 | ||
| 1055 | void BlitScreen::CreateFramebuffers() { | ||
| 1056 | const VkExtent2D size{swapchain.GetSize()}; | ||
| 1057 | framebuffers.resize(image_count); | ||
| 1058 | |||
| 1059 | for (std::size_t i = 0; i < image_count; ++i) { | ||
| 1060 | const VkImageView image_view{swapchain.GetImageViewIndex(i)}; | ||
| 1061 | framebuffers[i] = CreateFramebuffer(image_view, size, renderpass); | ||
| 1062 | } | ||
| 1063 | } | ||
| 1064 | |||
| 1065 | void BlitScreen::ReleaseRawImages() { | 1064 | void BlitScreen::ReleaseRawImages() { |
| 1066 | for (const u64 tick : resource_ticks) { | 1065 | for (const u64 tick : resource_ticks) { |
| 1067 | scheduler.Wait(tick); | 1066 | scheduler.Wait(tick); |
| @@ -1175,7 +1174,7 @@ void BlitScreen::CreateRawImages(const Tegra::FramebufferConfig& framebuffer) { | |||
| 1175 | aa_framebuffer = CreateFramebuffer(*aa_image_view, size, aa_renderpass); | 1174 | aa_framebuffer = CreateFramebuffer(*aa_image_view, size, aa_renderpass); |
| 1176 | return; | 1175 | return; |
| 1177 | } | 1176 | } |
| 1178 | aa_renderpass = CreateRenderPassImpl(GetFormat(framebuffer), false); | 1177 | aa_renderpass = CreateRenderPassImpl(GetFormat(framebuffer)); |
| 1179 | aa_framebuffer = CreateFramebuffer(*aa_image_view, size, aa_renderpass); | 1178 | aa_framebuffer = CreateFramebuffer(*aa_image_view, size, aa_renderpass); |
| 1180 | 1179 | ||
| 1181 | const std::array<VkPipelineShaderStageCreateInfo, 2> fxaa_shader_stages{{ | 1180 | const std::array<VkPipelineShaderStageCreateInfo, 2> fxaa_shader_stages{{ |
| @@ -1319,8 +1318,7 @@ void BlitScreen::CreateRawImages(const Tegra::FramebufferConfig& framebuffer) { | |||
| 1319 | aa_pipeline = device.GetLogical().CreateGraphicsPipeline(fxaa_pipeline_ci); | 1318 | aa_pipeline = device.GetLogical().CreateGraphicsPipeline(fxaa_pipeline_ci); |
| 1320 | } | 1319 | } |
| 1321 | 1320 | ||
| 1322 | void BlitScreen::UpdateAADescriptorSet(std::size_t image_index, VkImageView image_view, | 1321 | void BlitScreen::UpdateAADescriptorSet(VkImageView image_view, bool nn) const { |
| 1323 | bool nn) const { | ||
| 1324 | const VkDescriptorImageInfo image_info{ | 1322 | const VkDescriptorImageInfo image_info{ |
| 1325 | .sampler = nn ? *nn_sampler : *sampler, | 1323 | .sampler = nn ? *nn_sampler : *sampler, |
| 1326 | .imageView = image_view, | 1324 | .imageView = image_view, |
| @@ -1356,8 +1354,7 @@ void BlitScreen::UpdateAADescriptorSet(std::size_t image_index, VkImageView imag | |||
| 1356 | device.GetLogical().UpdateDescriptorSets(std::array{sampler_write, sampler_write_2}, {}); | 1354 | device.GetLogical().UpdateDescriptorSets(std::array{sampler_write, sampler_write_2}, {}); |
| 1357 | } | 1355 | } |
| 1358 | 1356 | ||
| 1359 | void BlitScreen::UpdateDescriptorSet(std::size_t image_index, VkImageView image_view, | 1357 | void BlitScreen::UpdateDescriptorSet(VkImageView image_view, bool nn) const { |
| 1360 | bool nn) const { | ||
| 1361 | const VkDescriptorBufferInfo buffer_info{ | 1358 | const VkDescriptorBufferInfo buffer_info{ |
| 1362 | .buffer = *buffer, | 1359 | .buffer = *buffer, |
| 1363 | .offset = offsetof(BufferData, uniform), | 1360 | .offset = offsetof(BufferData, uniform), |
| @@ -1480,8 +1477,7 @@ u64 BlitScreen::CalculateBufferSize(const Tegra::FramebufferConfig& framebuffer) | |||
| 1480 | return sizeof(BufferData) + GetSizeInBytes(framebuffer) * image_count; | 1477 | return sizeof(BufferData) + GetSizeInBytes(framebuffer) * image_count; |
| 1481 | } | 1478 | } |
| 1482 | 1479 | ||
| 1483 | u64 BlitScreen::GetRawImageOffset(const Tegra::FramebufferConfig& framebuffer, | 1480 | u64 BlitScreen::GetRawImageOffset(const Tegra::FramebufferConfig& framebuffer) const { |
| 1484 | std::size_t image_index) const { | ||
| 1485 | constexpr auto first_image_offset = static_cast<u64>(sizeof(BufferData)); | 1481 | constexpr auto first_image_offset = static_cast<u64>(sizeof(BufferData)); |
| 1486 | return first_image_offset + GetSizeInBytes(framebuffer) * image_index; | 1482 | return first_image_offset + GetSizeInBytes(framebuffer) * image_index; |
| 1487 | } | 1483 | } |
diff --git a/src/video_core/renderer_vulkan/vk_blit_screen.h b/src/video_core/renderer_vulkan/vk_blit_screen.h index ebe10b08b..68ec20253 100644 --- a/src/video_core/renderer_vulkan/vk_blit_screen.h +++ b/src/video_core/renderer_vulkan/vk_blit_screen.h | |||
| @@ -5,6 +5,7 @@ | |||
| 5 | 5 | ||
| 6 | #include <memory> | 6 | #include <memory> |
| 7 | 7 | ||
| 8 | #include "core/frontend/framebuffer_layout.h" | ||
| 8 | #include "video_core/vulkan_common/vulkan_memory_allocator.h" | 9 | #include "video_core/vulkan_common/vulkan_memory_allocator.h" |
| 9 | #include "video_core/vulkan_common/vulkan_wrapper.h" | 10 | #include "video_core/vulkan_common/vulkan_wrapper.h" |
| 10 | 11 | ||
| @@ -42,6 +43,9 @@ class RasterizerVulkan; | |||
| 42 | class Scheduler; | 43 | class Scheduler; |
| 43 | class SMAA; | 44 | class SMAA; |
| 44 | class Swapchain; | 45 | class Swapchain; |
| 46 | class PresentManager; | ||
| 47 | |||
| 48 | struct Frame; | ||
| 45 | 49 | ||
| 46 | struct ScreenInfo { | 50 | struct ScreenInfo { |
| 47 | VkImage image{}; | 51 | VkImage image{}; |
| @@ -55,18 +59,17 @@ class BlitScreen { | |||
| 55 | public: | 59 | public: |
| 56 | explicit BlitScreen(Core::Memory::Memory& cpu_memory, Core::Frontend::EmuWindow& render_window, | 60 | explicit BlitScreen(Core::Memory::Memory& cpu_memory, Core::Frontend::EmuWindow& render_window, |
| 57 | const Device& device, MemoryAllocator& memory_manager, Swapchain& swapchain, | 61 | const Device& device, MemoryAllocator& memory_manager, Swapchain& swapchain, |
| 58 | Scheduler& scheduler, const ScreenInfo& screen_info); | 62 | PresentManager& present_manager, Scheduler& scheduler, |
| 63 | const ScreenInfo& screen_info); | ||
| 59 | ~BlitScreen(); | 64 | ~BlitScreen(); |
| 60 | 65 | ||
| 61 | void Recreate(); | 66 | void Recreate(); |
| 62 | 67 | ||
| 63 | [[nodiscard]] VkSemaphore Draw(const Tegra::FramebufferConfig& framebuffer, | 68 | void Draw(const Tegra::FramebufferConfig& framebuffer, const VkFramebuffer& host_framebuffer, |
| 64 | const VkFramebuffer& host_framebuffer, | 69 | const Layout::FramebufferLayout layout, VkExtent2D render_area, bool use_accelerated); |
| 65 | const Layout::FramebufferLayout layout, VkExtent2D render_area, | ||
| 66 | bool use_accelerated); | ||
| 67 | 70 | ||
| 68 | [[nodiscard]] VkSemaphore DrawToSwapchain(const Tegra::FramebufferConfig& framebuffer, | 71 | void DrawToSwapchain(Frame* frame, const Tegra::FramebufferConfig& framebuffer, |
| 69 | bool use_accelerated); | 72 | bool use_accelerated, bool is_srgb); |
| 70 | 73 | ||
| 71 | [[nodiscard]] vk::Framebuffer CreateFramebuffer(const VkImageView& image_view, | 74 | [[nodiscard]] vk::Framebuffer CreateFramebuffer(const VkImageView& image_view, |
| 72 | VkExtent2D extent); | 75 | VkExtent2D extent); |
| @@ -79,10 +82,9 @@ private: | |||
| 79 | 82 | ||
| 80 | void CreateStaticResources(); | 83 | void CreateStaticResources(); |
| 81 | void CreateShaders(); | 84 | void CreateShaders(); |
| 82 | void CreateSemaphores(); | ||
| 83 | void CreateDescriptorPool(); | 85 | void CreateDescriptorPool(); |
| 84 | void CreateRenderPass(); | 86 | void CreateRenderPass(); |
| 85 | vk::RenderPass CreateRenderPassImpl(VkFormat, bool is_present = true); | 87 | vk::RenderPass CreateRenderPassImpl(VkFormat format); |
| 86 | void CreateDescriptorSetLayout(); | 88 | void CreateDescriptorSetLayout(); |
| 87 | void CreateDescriptorSets(); | 89 | void CreateDescriptorSets(); |
| 88 | void CreatePipelineLayout(); | 90 | void CreatePipelineLayout(); |
| @@ -90,15 +92,14 @@ private: | |||
| 90 | void CreateSampler(); | 92 | void CreateSampler(); |
| 91 | 93 | ||
| 92 | void CreateDynamicResources(); | 94 | void CreateDynamicResources(); |
| 93 | void CreateFramebuffers(); | ||
| 94 | 95 | ||
| 95 | void RefreshResources(const Tegra::FramebufferConfig& framebuffer); | 96 | void RefreshResources(const Tegra::FramebufferConfig& framebuffer); |
| 96 | void ReleaseRawImages(); | 97 | void ReleaseRawImages(); |
| 97 | void CreateStagingBuffer(const Tegra::FramebufferConfig& framebuffer); | 98 | void CreateStagingBuffer(const Tegra::FramebufferConfig& framebuffer); |
| 98 | void CreateRawImages(const Tegra::FramebufferConfig& framebuffer); | 99 | void CreateRawImages(const Tegra::FramebufferConfig& framebuffer); |
| 99 | 100 | ||
| 100 | void UpdateDescriptorSet(std::size_t image_index, VkImageView image_view, bool nn) const; | 101 | void UpdateDescriptorSet(VkImageView image_view, bool nn) const; |
| 101 | void UpdateAADescriptorSet(std::size_t image_index, VkImageView image_view, bool nn) const; | 102 | void UpdateAADescriptorSet(VkImageView image_view, bool nn) const; |
| 102 | void SetUniformData(BufferData& data, const Layout::FramebufferLayout layout) const; | 103 | void SetUniformData(BufferData& data, const Layout::FramebufferLayout layout) const; |
| 103 | void SetVertexData(BufferData& data, const Tegra::FramebufferConfig& framebuffer, | 104 | void SetVertexData(BufferData& data, const Tegra::FramebufferConfig& framebuffer, |
| 104 | const Layout::FramebufferLayout layout) const; | 105 | const Layout::FramebufferLayout layout) const; |
| @@ -107,16 +108,17 @@ private: | |||
| 107 | void CreateFSR(); | 108 | void CreateFSR(); |
| 108 | 109 | ||
| 109 | u64 CalculateBufferSize(const Tegra::FramebufferConfig& framebuffer) const; | 110 | u64 CalculateBufferSize(const Tegra::FramebufferConfig& framebuffer) const; |
| 110 | u64 GetRawImageOffset(const Tegra::FramebufferConfig& framebuffer, | 111 | u64 GetRawImageOffset(const Tegra::FramebufferConfig& framebuffer) const; |
| 111 | std::size_t image_index) const; | ||
| 112 | 112 | ||
| 113 | Core::Memory::Memory& cpu_memory; | 113 | Core::Memory::Memory& cpu_memory; |
| 114 | Core::Frontend::EmuWindow& render_window; | 114 | Core::Frontend::EmuWindow& render_window; |
| 115 | const Device& device; | 115 | const Device& device; |
| 116 | MemoryAllocator& memory_allocator; | 116 | MemoryAllocator& memory_allocator; |
| 117 | Swapchain& swapchain; | 117 | Swapchain& swapchain; |
| 118 | PresentManager& present_manager; | ||
| 118 | Scheduler& scheduler; | 119 | Scheduler& scheduler; |
| 119 | std::size_t image_count; | 120 | std::size_t image_count; |
| 121 | std::size_t image_index{}; | ||
| 120 | const ScreenInfo& screen_info; | 122 | const ScreenInfo& screen_info; |
| 121 | 123 | ||
| 122 | vk::ShaderModule vertex_shader; | 124 | vk::ShaderModule vertex_shader; |
| @@ -135,7 +137,6 @@ private: | |||
| 135 | vk::Pipeline gaussian_pipeline; | 137 | vk::Pipeline gaussian_pipeline; |
| 136 | vk::Pipeline scaleforce_pipeline; | 138 | vk::Pipeline scaleforce_pipeline; |
| 137 | vk::RenderPass renderpass; | 139 | vk::RenderPass renderpass; |
| 138 | std::vector<vk::Framebuffer> framebuffers; | ||
| 139 | vk::DescriptorSets descriptor_sets; | 140 | vk::DescriptorSets descriptor_sets; |
| 140 | vk::Sampler nn_sampler; | 141 | vk::Sampler nn_sampler; |
| 141 | vk::Sampler sampler; | 142 | vk::Sampler sampler; |
| @@ -145,7 +146,6 @@ private: | |||
| 145 | 146 | ||
| 146 | std::vector<u64> resource_ticks; | 147 | std::vector<u64> resource_ticks; |
| 147 | 148 | ||
| 148 | std::vector<vk::Semaphore> semaphores; | ||
| 149 | std::vector<vk::Image> raw_images; | 149 | std::vector<vk::Image> raw_images; |
| 150 | std::vector<vk::ImageView> raw_image_views; | 150 | std::vector<vk::ImageView> raw_image_views; |
| 151 | std::vector<MemoryCommit> raw_buffer_commits; | 151 | std::vector<MemoryCommit> raw_buffer_commits; |
| @@ -164,6 +164,8 @@ private: | |||
| 164 | u32 raw_width = 0; | 164 | u32 raw_width = 0; |
| 165 | u32 raw_height = 0; | 165 | u32 raw_height = 0; |
| 166 | Service::android::PixelFormat pixel_format{}; | 166 | Service::android::PixelFormat pixel_format{}; |
| 167 | bool current_srgb; | ||
| 168 | VkFormat image_view_format; | ||
| 167 | 169 | ||
| 168 | std::unique_ptr<FSR> fsr; | 170 | std::unique_ptr<FSR> fsr; |
| 169 | std::unique_ptr<SMAA> smaa; | 171 | std::unique_ptr<SMAA> smaa; |
diff --git a/src/video_core/renderer_vulkan/vk_present_manager.cpp b/src/video_core/renderer_vulkan/vk_present_manager.cpp new file mode 100644 index 000000000..a137c66f2 --- /dev/null +++ b/src/video_core/renderer_vulkan/vk_present_manager.cpp | |||
| @@ -0,0 +1,454 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #include "common/microprofile.h" | ||
| 5 | #include "common/settings.h" | ||
| 6 | #include "common/thread.h" | ||
| 7 | #include "video_core/renderer_vulkan/vk_present_manager.h" | ||
| 8 | #include "video_core/renderer_vulkan/vk_scheduler.h" | ||
| 9 | #include "video_core/renderer_vulkan/vk_swapchain.h" | ||
| 10 | #include "video_core/vulkan_common/vulkan_device.h" | ||
| 11 | |||
| 12 | namespace Vulkan { | ||
| 13 | |||
| 14 | MICROPROFILE_DEFINE(Vulkan_WaitPresent, "Vulkan", "Wait For Present", MP_RGB(128, 128, 128)); | ||
| 15 | MICROPROFILE_DEFINE(Vulkan_CopyToSwapchain, "Vulkan", "Copy to swapchain", MP_RGB(192, 255, 192)); | ||
| 16 | |||
| 17 | namespace { | ||
| 18 | |||
| 19 | bool CanBlitToSwapchain(const vk::PhysicalDevice& physical_device, VkFormat format) { | ||
| 20 | const VkFormatProperties props{physical_device.GetFormatProperties(format)}; | ||
| 21 | return (props.optimalTilingFeatures & VK_FORMAT_FEATURE_BLIT_DST_BIT); | ||
| 22 | } | ||
| 23 | |||
| 24 | [[nodiscard]] VkImageSubresourceLayers MakeImageSubresourceLayers() { | ||
| 25 | return VkImageSubresourceLayers{ | ||
| 26 | .aspectMask = VK_IMAGE_ASPECT_COLOR_BIT, | ||
| 27 | .mipLevel = 0, | ||
| 28 | .baseArrayLayer = 0, | ||
| 29 | .layerCount = 1, | ||
| 30 | }; | ||
| 31 | } | ||
| 32 | |||
| 33 | [[nodiscard]] VkImageBlit MakeImageBlit(s32 frame_width, s32 frame_height, s32 swapchain_width, | ||
| 34 | s32 swapchain_height) { | ||
| 35 | return VkImageBlit{ | ||
| 36 | .srcSubresource = MakeImageSubresourceLayers(), | ||
| 37 | .srcOffsets = | ||
| 38 | { | ||
| 39 | { | ||
| 40 | .x = 0, | ||
| 41 | .y = 0, | ||
| 42 | .z = 0, | ||
| 43 | }, | ||
| 44 | { | ||
| 45 | .x = frame_width, | ||
| 46 | .y = frame_height, | ||
| 47 | .z = 1, | ||
| 48 | }, | ||
| 49 | }, | ||
| 50 | .dstSubresource = MakeImageSubresourceLayers(), | ||
| 51 | .dstOffsets = | ||
| 52 | { | ||
| 53 | { | ||
| 54 | .x = 0, | ||
| 55 | .y = 0, | ||
| 56 | .z = 0, | ||
| 57 | }, | ||
| 58 | { | ||
| 59 | .x = swapchain_width, | ||
| 60 | .y = swapchain_height, | ||
| 61 | .z = 1, | ||
| 62 | }, | ||
| 63 | }, | ||
| 64 | }; | ||
| 65 | } | ||
| 66 | |||
| 67 | [[nodiscard]] VkImageCopy MakeImageCopy(u32 frame_width, u32 frame_height, u32 swapchain_width, | ||
| 68 | u32 swapchain_height) { | ||
| 69 | return VkImageCopy{ | ||
| 70 | .srcSubresource = MakeImageSubresourceLayers(), | ||
| 71 | .srcOffset = | ||
| 72 | { | ||
| 73 | .x = 0, | ||
| 74 | .y = 0, | ||
| 75 | .z = 0, | ||
| 76 | }, | ||
| 77 | .dstSubresource = MakeImageSubresourceLayers(), | ||
| 78 | .dstOffset = | ||
| 79 | { | ||
| 80 | .x = 0, | ||
| 81 | .y = 0, | ||
| 82 | .z = 0, | ||
| 83 | }, | ||
| 84 | .extent = | ||
| 85 | { | ||
| 86 | .width = std::min(frame_width, swapchain_width), | ||
| 87 | .height = std::min(frame_height, swapchain_height), | ||
| 88 | .depth = 1, | ||
| 89 | }, | ||
| 90 | }; | ||
| 91 | } | ||
| 92 | |||
| 93 | } // Anonymous namespace | ||
| 94 | |||
| 95 | PresentManager::PresentManager(Core::Frontend::EmuWindow& render_window_, const Device& device_, | ||
| 96 | MemoryAllocator& memory_allocator_, Scheduler& scheduler_, | ||
| 97 | Swapchain& swapchain_) | ||
| 98 | : render_window{render_window_}, device{device_}, | ||
| 99 | memory_allocator{memory_allocator_}, scheduler{scheduler_}, swapchain{swapchain_}, | ||
| 100 | blit_supported{CanBlitToSwapchain(device.GetPhysical(), swapchain.GetImageViewFormat())}, | ||
| 101 | use_present_thread{Settings::values.async_presentation.GetValue()}, | ||
| 102 | image_count{swapchain.GetImageCount()} { | ||
| 103 | |||
| 104 | auto& dld = device.GetLogical(); | ||
| 105 | cmdpool = dld.CreateCommandPool({ | ||
| 106 | .sType = VK_STRUCTURE_TYPE_COMMAND_POOL_CREATE_INFO, | ||
| 107 | .pNext = nullptr, | ||
| 108 | .flags = | ||
| 109 | VK_COMMAND_POOL_CREATE_TRANSIENT_BIT | VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT, | ||
| 110 | .queueFamilyIndex = device.GetGraphicsFamily(), | ||
| 111 | }); | ||
| 112 | auto cmdbuffers = cmdpool.Allocate(image_count); | ||
| 113 | |||
| 114 | frames.resize(image_count); | ||
| 115 | for (u32 i = 0; i < frames.size(); i++) { | ||
| 116 | Frame& frame = frames[i]; | ||
| 117 | frame.cmdbuf = vk::CommandBuffer{cmdbuffers[i], device.GetDispatchLoader()}; | ||
| 118 | frame.render_ready = dld.CreateSemaphore({ | ||
| 119 | .sType = VK_STRUCTURE_TYPE_SEMAPHORE_CREATE_INFO, | ||
| 120 | .pNext = nullptr, | ||
| 121 | .flags = 0, | ||
| 122 | }); | ||
| 123 | frame.present_done = dld.CreateFence({ | ||
| 124 | .sType = VK_STRUCTURE_TYPE_FENCE_CREATE_INFO, | ||
| 125 | .pNext = nullptr, | ||
| 126 | .flags = VK_FENCE_CREATE_SIGNALED_BIT, | ||
| 127 | }); | ||
| 128 | free_queue.push(&frame); | ||
| 129 | } | ||
| 130 | |||
| 131 | if (use_present_thread) { | ||
| 132 | present_thread = std::jthread([this](std::stop_token token) { PresentThread(token); }); | ||
| 133 | } | ||
| 134 | } | ||
| 135 | |||
| 136 | PresentManager::~PresentManager() = default; | ||
| 137 | |||
| 138 | Frame* PresentManager::GetRenderFrame() { | ||
| 139 | MICROPROFILE_SCOPE(Vulkan_WaitPresent); | ||
| 140 | |||
| 141 | // Wait for free presentation frames | ||
| 142 | std::unique_lock lock{free_mutex}; | ||
| 143 | free_cv.wait(lock, [this] { return !free_queue.empty(); }); | ||
| 144 | |||
| 145 | // Take the frame from the queue | ||
| 146 | Frame* frame = free_queue.front(); | ||
| 147 | free_queue.pop(); | ||
| 148 | |||
| 149 | // Wait for the presentation to be finished so all frame resources are free | ||
| 150 | frame->present_done.Wait(); | ||
| 151 | frame->present_done.Reset(); | ||
| 152 | |||
| 153 | return frame; | ||
| 154 | } | ||
| 155 | |||
| 156 | void PresentManager::PushFrame(Frame* frame) { | ||
| 157 | if (!use_present_thread) { | ||
| 158 | CopyToSwapchain(frame); | ||
| 159 | free_queue.push(frame); | ||
| 160 | return; | ||
| 161 | } | ||
| 162 | |||
| 163 | std::unique_lock lock{queue_mutex}; | ||
| 164 | present_queue.push(frame); | ||
| 165 | frame_cv.notify_one(); | ||
| 166 | } | ||
| 167 | |||
| 168 | void PresentManager::RecreateFrame(Frame* frame, u32 width, u32 height, bool is_srgb, | ||
| 169 | VkFormat image_view_format, VkRenderPass rd) { | ||
| 170 | auto& dld = device.GetLogical(); | ||
| 171 | |||
| 172 | frame->width = width; | ||
| 173 | frame->height = height; | ||
| 174 | frame->is_srgb = is_srgb; | ||
| 175 | |||
| 176 | frame->image = dld.CreateImage({ | ||
| 177 | .sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO, | ||
| 178 | .pNext = nullptr, | ||
| 179 | .flags = VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT, | ||
| 180 | .imageType = VK_IMAGE_TYPE_2D, | ||
| 181 | .format = swapchain.GetImageFormat(), | ||
| 182 | .extent = | ||
| 183 | { | ||
| 184 | .width = width, | ||
| 185 | .height = height, | ||
| 186 | .depth = 1, | ||
| 187 | }, | ||
| 188 | .mipLevels = 1, | ||
| 189 | .arrayLayers = 1, | ||
| 190 | .samples = VK_SAMPLE_COUNT_1_BIT, | ||
| 191 | .tiling = VK_IMAGE_TILING_OPTIMAL, | ||
| 192 | .usage = VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, | ||
| 193 | .sharingMode = VK_SHARING_MODE_EXCLUSIVE, | ||
| 194 | .queueFamilyIndexCount = 0, | ||
| 195 | .pQueueFamilyIndices = nullptr, | ||
| 196 | .initialLayout = VK_IMAGE_LAYOUT_UNDEFINED, | ||
| 197 | }); | ||
| 198 | |||
| 199 | frame->image_commit = memory_allocator.Commit(frame->image, MemoryUsage::DeviceLocal); | ||
| 200 | |||
| 201 | frame->image_view = dld.CreateImageView({ | ||
| 202 | .sType = VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO, | ||
| 203 | .pNext = nullptr, | ||
| 204 | .flags = 0, | ||
| 205 | .image = *frame->image, | ||
| 206 | .viewType = VK_IMAGE_VIEW_TYPE_2D, | ||
| 207 | .format = image_view_format, | ||
| 208 | .components = | ||
| 209 | { | ||
| 210 | .r = VK_COMPONENT_SWIZZLE_IDENTITY, | ||
| 211 | .g = VK_COMPONENT_SWIZZLE_IDENTITY, | ||
| 212 | .b = VK_COMPONENT_SWIZZLE_IDENTITY, | ||
| 213 | .a = VK_COMPONENT_SWIZZLE_IDENTITY, | ||
| 214 | }, | ||
| 215 | .subresourceRange = | ||
| 216 | { | ||
| 217 | .aspectMask = VK_IMAGE_ASPECT_COLOR_BIT, | ||
| 218 | .baseMipLevel = 0, | ||
| 219 | .levelCount = 1, | ||
| 220 | .baseArrayLayer = 0, | ||
| 221 | .layerCount = 1, | ||
| 222 | }, | ||
| 223 | }); | ||
| 224 | |||
| 225 | const VkImageView image_view{*frame->image_view}; | ||
| 226 | frame->framebuffer = dld.CreateFramebuffer({ | ||
| 227 | .sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO, | ||
| 228 | .pNext = nullptr, | ||
| 229 | .flags = 0, | ||
| 230 | .renderPass = rd, | ||
| 231 | .attachmentCount = 1, | ||
| 232 | .pAttachments = &image_view, | ||
| 233 | .width = width, | ||
| 234 | .height = height, | ||
| 235 | .layers = 1, | ||
| 236 | }); | ||
| 237 | } | ||
| 238 | |||
| 239 | void PresentManager::WaitPresent() { | ||
| 240 | if (!use_present_thread) { | ||
| 241 | return; | ||
| 242 | } | ||
| 243 | |||
| 244 | // Wait for the present queue to be empty | ||
| 245 | { | ||
| 246 | std::unique_lock queue_lock{queue_mutex}; | ||
| 247 | frame_cv.wait(queue_lock, [this] { return present_queue.empty(); }); | ||
| 248 | } | ||
| 249 | |||
| 250 | // The above condition will be satisfied when the last frame is taken from the queue. | ||
| 251 | // To ensure that frame has been presented as well take hold of the swapchain | ||
| 252 | // mutex. | ||
| 253 | std::scoped_lock swapchain_lock{swapchain_mutex}; | ||
| 254 | } | ||
| 255 | |||
| 256 | void PresentManager::PresentThread(std::stop_token token) { | ||
| 257 | Common::SetCurrentThreadName("VulkanPresent"); | ||
| 258 | while (!token.stop_requested()) { | ||
| 259 | std::unique_lock lock{queue_mutex}; | ||
| 260 | |||
| 261 | // Wait for presentation frames | ||
| 262 | Common::CondvarWait(frame_cv, lock, token, [this] { return !present_queue.empty(); }); | ||
| 263 | if (token.stop_requested()) { | ||
| 264 | return; | ||
| 265 | } | ||
| 266 | |||
| 267 | // Take the frame and notify anyone waiting | ||
| 268 | Frame* frame = present_queue.front(); | ||
| 269 | present_queue.pop(); | ||
| 270 | frame_cv.notify_one(); | ||
| 271 | |||
| 272 | // By exchanging the lock ownership we take the swapchain lock | ||
| 273 | // before the queue lock goes out of scope. This way the swapchain | ||
| 274 | // lock in WaitPresent is guaranteed to occur after here. | ||
| 275 | std::exchange(lock, std::unique_lock{swapchain_mutex}); | ||
| 276 | |||
| 277 | CopyToSwapchain(frame); | ||
| 278 | |||
| 279 | // Free the frame for reuse | ||
| 280 | std::scoped_lock fl{free_mutex}; | ||
| 281 | free_queue.push(frame); | ||
| 282 | free_cv.notify_one(); | ||
| 283 | } | ||
| 284 | } | ||
| 285 | |||
| 286 | void PresentManager::CopyToSwapchain(Frame* frame) { | ||
| 287 | MICROPROFILE_SCOPE(Vulkan_CopyToSwapchain); | ||
| 288 | |||
| 289 | const auto recreate_swapchain = [&] { | ||
| 290 | swapchain.Create(frame->width, frame->height, frame->is_srgb); | ||
| 291 | image_count = swapchain.GetImageCount(); | ||
| 292 | }; | ||
| 293 | |||
| 294 | // If the size or colorspace of the incoming frames has changed, recreate the swapchain | ||
| 295 | // to account for that. | ||
| 296 | const bool srgb_changed = swapchain.NeedsRecreation(frame->is_srgb); | ||
| 297 | const bool size_changed = | ||
| 298 | swapchain.GetWidth() != frame->width || swapchain.GetHeight() != frame->height; | ||
| 299 | if (srgb_changed || size_changed) { | ||
| 300 | recreate_swapchain(); | ||
| 301 | } | ||
| 302 | |||
| 303 | while (swapchain.AcquireNextImage()) { | ||
| 304 | recreate_swapchain(); | ||
| 305 | } | ||
| 306 | |||
| 307 | const vk::CommandBuffer cmdbuf{frame->cmdbuf}; | ||
| 308 | cmdbuf.Begin({ | ||
| 309 | .sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO, | ||
| 310 | .pNext = nullptr, | ||
| 311 | .flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT, | ||
| 312 | .pInheritanceInfo = nullptr, | ||
| 313 | }); | ||
| 314 | |||
| 315 | const VkImage image{swapchain.CurrentImage()}; | ||
| 316 | const VkExtent2D extent = swapchain.GetExtent(); | ||
| 317 | const std::array pre_barriers{ | ||
| 318 | VkImageMemoryBarrier{ | ||
| 319 | .sType = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER, | ||
| 320 | .pNext = nullptr, | ||
| 321 | .srcAccessMask = 0, | ||
| 322 | .dstAccessMask = VK_ACCESS_TRANSFER_WRITE_BIT, | ||
| 323 | .oldLayout = VK_IMAGE_LAYOUT_UNDEFINED, | ||
| 324 | .newLayout = VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, | ||
| 325 | .srcQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, | ||
| 326 | .dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, | ||
| 327 | .image = image, | ||
| 328 | .subresourceRange{ | ||
| 329 | .aspectMask = VK_IMAGE_ASPECT_COLOR_BIT, | ||
| 330 | .baseMipLevel = 0, | ||
| 331 | .levelCount = 1, | ||
| 332 | .baseArrayLayer = 0, | ||
| 333 | .layerCount = VK_REMAINING_ARRAY_LAYERS, | ||
| 334 | }, | ||
| 335 | }, | ||
| 336 | VkImageMemoryBarrier{ | ||
| 337 | .sType = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER, | ||
| 338 | .pNext = nullptr, | ||
| 339 | .srcAccessMask = VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, | ||
| 340 | .dstAccessMask = VK_ACCESS_TRANSFER_READ_BIT, | ||
| 341 | .oldLayout = VK_IMAGE_LAYOUT_GENERAL, | ||
| 342 | .newLayout = VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, | ||
| 343 | .srcQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, | ||
| 344 | .dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, | ||
| 345 | .image = *frame->image, | ||
| 346 | .subresourceRange{ | ||
| 347 | .aspectMask = VK_IMAGE_ASPECT_COLOR_BIT, | ||
| 348 | .baseMipLevel = 0, | ||
| 349 | .levelCount = 1, | ||
| 350 | .baseArrayLayer = 0, | ||
| 351 | .layerCount = VK_REMAINING_ARRAY_LAYERS, | ||
| 352 | }, | ||
| 353 | }, | ||
| 354 | }; | ||
| 355 | const std::array post_barriers{ | ||
| 356 | VkImageMemoryBarrier{ | ||
| 357 | .sType = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER, | ||
| 358 | .pNext = nullptr, | ||
| 359 | .srcAccessMask = VK_ACCESS_TRANSFER_WRITE_BIT, | ||
| 360 | .dstAccessMask = VK_ACCESS_MEMORY_READ_BIT, | ||
| 361 | .oldLayout = VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, | ||
| 362 | .newLayout = VK_IMAGE_LAYOUT_PRESENT_SRC_KHR, | ||
| 363 | .srcQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, | ||
| 364 | .dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, | ||
| 365 | .image = image, | ||
| 366 | .subresourceRange{ | ||
| 367 | .aspectMask = VK_IMAGE_ASPECT_COLOR_BIT, | ||
| 368 | .baseMipLevel = 0, | ||
| 369 | .levelCount = 1, | ||
| 370 | .baseArrayLayer = 0, | ||
| 371 | .layerCount = VK_REMAINING_ARRAY_LAYERS, | ||
| 372 | }, | ||
| 373 | }, | ||
| 374 | VkImageMemoryBarrier{ | ||
| 375 | .sType = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER, | ||
| 376 | .pNext = nullptr, | ||
| 377 | .srcAccessMask = VK_ACCESS_TRANSFER_READ_BIT, | ||
| 378 | .dstAccessMask = VK_ACCESS_MEMORY_WRITE_BIT, | ||
| 379 | .oldLayout = VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, | ||
| 380 | .newLayout = VK_IMAGE_LAYOUT_GENERAL, | ||
| 381 | .srcQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, | ||
| 382 | .dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED, | ||
| 383 | .image = *frame->image, | ||
| 384 | .subresourceRange{ | ||
| 385 | .aspectMask = VK_IMAGE_ASPECT_COLOR_BIT, | ||
| 386 | .baseMipLevel = 0, | ||
| 387 | .levelCount = 1, | ||
| 388 | .baseArrayLayer = 0, | ||
| 389 | .layerCount = VK_REMAINING_ARRAY_LAYERS, | ||
| 390 | }, | ||
| 391 | }, | ||
| 392 | }; | ||
| 393 | |||
| 394 | cmdbuf.PipelineBarrier(VK_PIPELINE_STAGE_ALL_COMMANDS_BIT, VK_PIPELINE_STAGE_TRANSFER_BIT, {}, | ||
| 395 | {}, {}, pre_barriers); | ||
| 396 | |||
| 397 | if (blit_supported) { | ||
| 398 | cmdbuf.BlitImage(*frame->image, VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, image, | ||
| 399 | VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, | ||
| 400 | MakeImageBlit(frame->width, frame->height, extent.width, extent.height), | ||
| 401 | VK_FILTER_LINEAR); | ||
| 402 | } else { | ||
| 403 | cmdbuf.CopyImage(*frame->image, VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, image, | ||
| 404 | VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, | ||
| 405 | MakeImageCopy(frame->width, frame->height, extent.width, extent.height)); | ||
| 406 | } | ||
| 407 | |||
| 408 | cmdbuf.PipelineBarrier(VK_PIPELINE_STAGE_TRANSFER_BIT, VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT, {}, | ||
| 409 | {}, {}, post_barriers); | ||
| 410 | |||
| 411 | cmdbuf.End(); | ||
| 412 | |||
| 413 | const VkSemaphore present_semaphore = swapchain.CurrentPresentSemaphore(); | ||
| 414 | const VkSemaphore render_semaphore = swapchain.CurrentRenderSemaphore(); | ||
| 415 | const std::array wait_semaphores = {present_semaphore, *frame->render_ready}; | ||
| 416 | |||
| 417 | static constexpr std::array<VkPipelineStageFlags, 2> wait_stage_masks{ | ||
| 418 | VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, | ||
| 419 | VK_PIPELINE_STAGE_ALL_COMMANDS_BIT, | ||
| 420 | }; | ||
| 421 | |||
| 422 | const VkSubmitInfo submit_info{ | ||
| 423 | .sType = VK_STRUCTURE_TYPE_SUBMIT_INFO, | ||
| 424 | .pNext = nullptr, | ||
| 425 | .waitSemaphoreCount = 2U, | ||
| 426 | .pWaitSemaphores = wait_semaphores.data(), | ||
| 427 | .pWaitDstStageMask = wait_stage_masks.data(), | ||
| 428 | .commandBufferCount = 1, | ||
| 429 | .pCommandBuffers = cmdbuf.address(), | ||
| 430 | .signalSemaphoreCount = 1U, | ||
| 431 | .pSignalSemaphores = &render_semaphore, | ||
| 432 | }; | ||
| 433 | |||
| 434 | // Submit the image copy/blit to the swapchain | ||
| 435 | { | ||
| 436 | std::scoped_lock lock{scheduler.submit_mutex}; | ||
| 437 | switch (const VkResult result = | ||
| 438 | device.GetGraphicsQueue().Submit(submit_info, *frame->present_done)) { | ||
| 439 | case VK_SUCCESS: | ||
| 440 | break; | ||
| 441 | case VK_ERROR_DEVICE_LOST: | ||
| 442 | device.ReportLoss(); | ||
| 443 | [[fallthrough]]; | ||
| 444 | default: | ||
| 445 | vk::Check(result); | ||
| 446 | break; | ||
| 447 | } | ||
| 448 | } | ||
| 449 | |||
| 450 | // Present | ||
| 451 | swapchain.Present(render_semaphore); | ||
| 452 | } | ||
| 453 | |||
| 454 | } // namespace Vulkan | ||
diff --git a/src/video_core/renderer_vulkan/vk_present_manager.h b/src/video_core/renderer_vulkan/vk_present_manager.h new file mode 100644 index 000000000..9885fd7c6 --- /dev/null +++ b/src/video_core/renderer_vulkan/vk_present_manager.h | |||
| @@ -0,0 +1,83 @@ | |||
| 1 | // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project | ||
| 2 | // SPDX-License-Identifier: GPL-2.0-or-later | ||
| 3 | |||
| 4 | #pragma once | ||
| 5 | |||
| 6 | #include <condition_variable> | ||
| 7 | #include <mutex> | ||
| 8 | #include <queue> | ||
| 9 | |||
| 10 | #include "common/common_types.h" | ||
| 11 | #include "common/polyfill_thread.h" | ||
| 12 | #include "video_core/vulkan_common/vulkan_memory_allocator.h" | ||
| 13 | #include "video_core/vulkan_common/vulkan_wrapper.h" | ||
| 14 | |||
| 15 | namespace Core::Frontend { | ||
| 16 | class EmuWindow; | ||
| 17 | } // namespace Core::Frontend | ||
| 18 | |||
| 19 | namespace Vulkan { | ||
| 20 | |||
| 21 | class Device; | ||
| 22 | class Scheduler; | ||
| 23 | class Swapchain; | ||
| 24 | |||
| 25 | struct Frame { | ||
| 26 | u32 width; | ||
| 27 | u32 height; | ||
| 28 | bool is_srgb; | ||
| 29 | vk::Image image; | ||
| 30 | vk::ImageView image_view; | ||
| 31 | vk::Framebuffer framebuffer; | ||
| 32 | MemoryCommit image_commit; | ||
| 33 | vk::CommandBuffer cmdbuf; | ||
| 34 | vk::Semaphore render_ready; | ||
| 35 | vk::Fence present_done; | ||
| 36 | }; | ||
| 37 | |||
| 38 | class PresentManager { | ||
| 39 | public: | ||
| 40 | PresentManager(Core::Frontend::EmuWindow& render_window, const Device& device, | ||
| 41 | MemoryAllocator& memory_allocator, Scheduler& scheduler, Swapchain& swapchain); | ||
| 42 | ~PresentManager(); | ||
| 43 | |||
| 44 | /// Returns the last used presentation frame | ||
| 45 | Frame* GetRenderFrame(); | ||
| 46 | |||
| 47 | /// Pushes a frame for presentation | ||
| 48 | void PushFrame(Frame* frame); | ||
| 49 | |||
| 50 | /// Recreates the present frame to match the provided parameters | ||
| 51 | void RecreateFrame(Frame* frame, u32 width, u32 height, bool is_srgb, | ||
| 52 | VkFormat image_view_format, VkRenderPass rd); | ||
| 53 | |||
| 54 | /// Waits for the present thread to finish presenting all queued frames. | ||
| 55 | void WaitPresent(); | ||
| 56 | |||
| 57 | private: | ||
| 58 | void PresentThread(std::stop_token token); | ||
| 59 | |||
| 60 | void CopyToSwapchain(Frame* frame); | ||
| 61 | |||
| 62 | private: | ||
| 63 | Core::Frontend::EmuWindow& render_window; | ||
| 64 | const Device& device; | ||
| 65 | MemoryAllocator& memory_allocator; | ||
| 66 | Scheduler& scheduler; | ||
| 67 | Swapchain& swapchain; | ||
| 68 | vk::CommandPool cmdpool; | ||
| 69 | std::vector<Frame> frames; | ||
| 70 | std::queue<Frame*> present_queue; | ||
| 71 | std::queue<Frame*> free_queue; | ||
| 72 | std::condition_variable_any frame_cv; | ||
| 73 | std::condition_variable free_cv; | ||
| 74 | std::mutex swapchain_mutex; | ||
| 75 | std::mutex queue_mutex; | ||
| 76 | std::mutex free_mutex; | ||
| 77 | std::jthread present_thread; | ||
| 78 | bool blit_supported; | ||
| 79 | bool use_present_thread; | ||
| 80 | std::size_t image_count; | ||
| 81 | }; | ||
| 82 | |||
| 83 | } // namespace Vulkan | ||
diff --git a/src/video_core/renderer_vulkan/vk_scheduler.cpp b/src/video_core/renderer_vulkan/vk_scheduler.cpp index 057e16967..80455ec08 100644 --- a/src/video_core/renderer_vulkan/vk_scheduler.cpp +++ b/src/video_core/renderer_vulkan/vk_scheduler.cpp | |||
| @@ -46,10 +46,11 @@ Scheduler::Scheduler(const Device& device_, StateTracker& state_tracker_) | |||
| 46 | 46 | ||
| 47 | Scheduler::~Scheduler() = default; | 47 | Scheduler::~Scheduler() = default; |
| 48 | 48 | ||
| 49 | void Scheduler::Flush(VkSemaphore signal_semaphore, VkSemaphore wait_semaphore) { | 49 | u64 Scheduler::Flush(VkSemaphore signal_semaphore, VkSemaphore wait_semaphore) { |
| 50 | // When flushing, we only send data to the worker thread; no waiting is necessary. | 50 | // When flushing, we only send data to the worker thread; no waiting is necessary. |
| 51 | SubmitExecution(signal_semaphore, wait_semaphore); | 51 | const u64 signal_value = SubmitExecution(signal_semaphore, wait_semaphore); |
| 52 | AllocateNewContext(); | 52 | AllocateNewContext(); |
| 53 | return signal_value; | ||
| 53 | } | 54 | } |
| 54 | 55 | ||
| 55 | void Scheduler::Finish(VkSemaphore signal_semaphore, VkSemaphore wait_semaphore) { | 56 | void Scheduler::Finish(VkSemaphore signal_semaphore, VkSemaphore wait_semaphore) { |
| @@ -205,7 +206,7 @@ void Scheduler::AllocateWorkerCommandBuffer() { | |||
| 205 | }); | 206 | }); |
| 206 | } | 207 | } |
| 207 | 208 | ||
| 208 | void Scheduler::SubmitExecution(VkSemaphore signal_semaphore, VkSemaphore wait_semaphore) { | 209 | u64 Scheduler::SubmitExecution(VkSemaphore signal_semaphore, VkSemaphore wait_semaphore) { |
| 209 | EndPendingOperations(); | 210 | EndPendingOperations(); |
| 210 | InvalidateState(); | 211 | InvalidateState(); |
| 211 | 212 | ||
| @@ -217,6 +218,7 @@ void Scheduler::SubmitExecution(VkSemaphore signal_semaphore, VkSemaphore wait_s | |||
| 217 | on_submit(); | 218 | on_submit(); |
| 218 | } | 219 | } |
| 219 | 220 | ||
| 221 | std::scoped_lock lock{submit_mutex}; | ||
| 220 | switch (const VkResult result = master_semaphore->SubmitQueue( | 222 | switch (const VkResult result = master_semaphore->SubmitQueue( |
| 221 | cmdbuf, signal_semaphore, wait_semaphore, signal_value)) { | 223 | cmdbuf, signal_semaphore, wait_semaphore, signal_value)) { |
| 222 | case VK_SUCCESS: | 224 | case VK_SUCCESS: |
| @@ -231,6 +233,7 @@ void Scheduler::SubmitExecution(VkSemaphore signal_semaphore, VkSemaphore wait_s | |||
| 231 | }); | 233 | }); |
| 232 | chunk->MarkSubmit(); | 234 | chunk->MarkSubmit(); |
| 233 | DispatchWork(); | 235 | DispatchWork(); |
| 236 | return signal_value; | ||
| 234 | } | 237 | } |
| 235 | 238 | ||
| 236 | void Scheduler::AllocateNewContext() { | 239 | void Scheduler::AllocateNewContext() { |
diff --git a/src/video_core/renderer_vulkan/vk_scheduler.h b/src/video_core/renderer_vulkan/vk_scheduler.h index 8d75ce987..475c682eb 100644 --- a/src/video_core/renderer_vulkan/vk_scheduler.h +++ b/src/video_core/renderer_vulkan/vk_scheduler.h | |||
| @@ -34,7 +34,7 @@ public: | |||
| 34 | ~Scheduler(); | 34 | ~Scheduler(); |
| 35 | 35 | ||
| 36 | /// Sends the current execution context to the GPU. | 36 | /// Sends the current execution context to the GPU. |
| 37 | void Flush(VkSemaphore signal_semaphore = nullptr, VkSemaphore wait_semaphore = nullptr); | 37 | u64 Flush(VkSemaphore signal_semaphore = nullptr, VkSemaphore wait_semaphore = nullptr); |
| 38 | 38 | ||
| 39 | /// Sends the current execution context to the GPU and waits for it to complete. | 39 | /// Sends the current execution context to the GPU and waits for it to complete. |
| 40 | void Finish(VkSemaphore signal_semaphore = nullptr, VkSemaphore wait_semaphore = nullptr); | 40 | void Finish(VkSemaphore signal_semaphore = nullptr, VkSemaphore wait_semaphore = nullptr); |
| @@ -106,6 +106,8 @@ public: | |||
| 106 | return *master_semaphore; | 106 | return *master_semaphore; |
| 107 | } | 107 | } |
| 108 | 108 | ||
| 109 | std::mutex submit_mutex; | ||
| 110 | |||
| 109 | private: | 111 | private: |
| 110 | class Command { | 112 | class Command { |
| 111 | public: | 113 | public: |
| @@ -201,7 +203,7 @@ private: | |||
| 201 | 203 | ||
| 202 | void AllocateWorkerCommandBuffer(); | 204 | void AllocateWorkerCommandBuffer(); |
| 203 | 205 | ||
| 204 | void SubmitExecution(VkSemaphore signal_semaphore, VkSemaphore wait_semaphore); | 206 | u64 SubmitExecution(VkSemaphore signal_semaphore, VkSemaphore wait_semaphore); |
| 205 | 207 | ||
| 206 | void AllocateNewContext(); | 208 | void AllocateNewContext(); |
| 207 | 209 | ||
diff --git a/src/video_core/renderer_vulkan/vk_swapchain.cpp b/src/video_core/renderer_vulkan/vk_swapchain.cpp index b1465e35c..23bbea7f1 100644 --- a/src/video_core/renderer_vulkan/vk_swapchain.cpp +++ b/src/video_core/renderer_vulkan/vk_swapchain.cpp | |||
| @@ -99,18 +99,16 @@ void Swapchain::Create(u32 width_, u32 height_, bool srgb) { | |||
| 99 | return; | 99 | return; |
| 100 | } | 100 | } |
| 101 | 101 | ||
| 102 | device.GetLogical().WaitIdle(); | ||
| 103 | Destroy(); | 102 | Destroy(); |
| 104 | 103 | ||
| 105 | CreateSwapchain(capabilities, srgb); | 104 | CreateSwapchain(capabilities, srgb); |
| 106 | CreateSemaphores(); | 105 | CreateSemaphores(); |
| 107 | CreateImageViews(); | ||
| 108 | 106 | ||
| 109 | resource_ticks.clear(); | 107 | resource_ticks.clear(); |
| 110 | resource_ticks.resize(image_count); | 108 | resource_ticks.resize(image_count); |
| 111 | } | 109 | } |
| 112 | 110 | ||
| 113 | void Swapchain::AcquireNextImage() { | 111 | bool Swapchain::AcquireNextImage() { |
| 114 | const VkResult result = device.GetLogical().AcquireNextImageKHR( | 112 | const VkResult result = device.GetLogical().AcquireNextImageKHR( |
| 115 | *swapchain, std::numeric_limits<u64>::max(), *present_semaphores[frame_index], | 113 | *swapchain, std::numeric_limits<u64>::max(), *present_semaphores[frame_index], |
| 116 | VK_NULL_HANDLE, &image_index); | 114 | VK_NULL_HANDLE, &image_index); |
| @@ -127,8 +125,11 @@ void Swapchain::AcquireNextImage() { | |||
| 127 | LOG_ERROR(Render_Vulkan, "vkAcquireNextImageKHR returned {}", vk::ToString(result)); | 125 | LOG_ERROR(Render_Vulkan, "vkAcquireNextImageKHR returned {}", vk::ToString(result)); |
| 128 | break; | 126 | break; |
| 129 | } | 127 | } |
| 128 | |||
| 130 | scheduler.Wait(resource_ticks[image_index]); | 129 | scheduler.Wait(resource_ticks[image_index]); |
| 131 | resource_ticks[image_index] = scheduler.CurrentTick(); | 130 | resource_ticks[image_index] = scheduler.CurrentTick(); |
| 131 | |||
| 132 | return is_suboptimal || is_outdated; | ||
| 132 | } | 133 | } |
| 133 | 134 | ||
| 134 | void Swapchain::Present(VkSemaphore render_semaphore) { | 135 | void Swapchain::Present(VkSemaphore render_semaphore) { |
| @@ -143,6 +144,7 @@ void Swapchain::Present(VkSemaphore render_semaphore) { | |||
| 143 | .pImageIndices = &image_index, | 144 | .pImageIndices = &image_index, |
| 144 | .pResults = nullptr, | 145 | .pResults = nullptr, |
| 145 | }; | 146 | }; |
| 147 | std::scoped_lock lock{scheduler.submit_mutex}; | ||
| 146 | switch (const VkResult result = present_queue.Present(present_info)) { | 148 | switch (const VkResult result = present_queue.Present(present_info)) { |
| 147 | case VK_SUCCESS: | 149 | case VK_SUCCESS: |
| 148 | break; | 150 | break; |
| @@ -168,7 +170,7 @@ void Swapchain::CreateSwapchain(const VkSurfaceCapabilitiesKHR& capabilities, bo | |||
| 168 | const auto present_modes{physical_device.GetSurfacePresentModesKHR(surface)}; | 170 | const auto present_modes{physical_device.GetSurfacePresentModesKHR(surface)}; |
| 169 | 171 | ||
| 170 | const VkCompositeAlphaFlagBitsKHR alpha_flags{ChooseAlphaFlags(capabilities)}; | 172 | const VkCompositeAlphaFlagBitsKHR alpha_flags{ChooseAlphaFlags(capabilities)}; |
| 171 | const VkSurfaceFormatKHR surface_format{ChooseSwapSurfaceFormat(formats)}; | 173 | surface_format = ChooseSwapSurfaceFormat(formats); |
| 172 | present_mode = ChooseSwapPresentMode(present_modes); | 174 | present_mode = ChooseSwapPresentMode(present_modes); |
| 173 | 175 | ||
| 174 | u32 requested_image_count{capabilities.minImageCount + 1}; | 176 | u32 requested_image_count{capabilities.minImageCount + 1}; |
| @@ -193,7 +195,7 @@ void Swapchain::CreateSwapchain(const VkSurfaceCapabilitiesKHR& capabilities, bo | |||
| 193 | .imageColorSpace = surface_format.colorSpace, | 195 | .imageColorSpace = surface_format.colorSpace, |
| 194 | .imageExtent = {}, | 196 | .imageExtent = {}, |
| 195 | .imageArrayLayers = 1, | 197 | .imageArrayLayers = 1, |
| 196 | .imageUsage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, | 198 | .imageUsage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT, |
| 197 | .imageSharingMode = VK_SHARING_MODE_EXCLUSIVE, | 199 | .imageSharingMode = VK_SHARING_MODE_EXCLUSIVE, |
| 198 | .queueFamilyIndexCount = 0, | 200 | .queueFamilyIndexCount = 0, |
| 199 | .pQueueFamilyIndices = nullptr, | 201 | .pQueueFamilyIndices = nullptr, |
| @@ -241,45 +243,14 @@ void Swapchain::CreateSemaphores() { | |||
| 241 | present_semaphores.resize(image_count); | 243 | present_semaphores.resize(image_count); |
| 242 | std::ranges::generate(present_semaphores, | 244 | std::ranges::generate(present_semaphores, |
| 243 | [this] { return device.GetLogical().CreateSemaphore(); }); | 245 | [this] { return device.GetLogical().CreateSemaphore(); }); |
| 244 | } | 246 | render_semaphores.resize(image_count); |
| 245 | 247 | std::ranges::generate(render_semaphores, | |
| 246 | void Swapchain::CreateImageViews() { | 248 | [this] { return device.GetLogical().CreateSemaphore(); }); |
| 247 | VkImageViewCreateInfo ci{ | ||
| 248 | .sType = VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO, | ||
| 249 | .pNext = nullptr, | ||
| 250 | .flags = 0, | ||
| 251 | .image = {}, | ||
| 252 | .viewType = VK_IMAGE_VIEW_TYPE_2D, | ||
| 253 | .format = image_view_format, | ||
| 254 | .components = | ||
| 255 | { | ||
| 256 | .r = VK_COMPONENT_SWIZZLE_IDENTITY, | ||
| 257 | .g = VK_COMPONENT_SWIZZLE_IDENTITY, | ||
| 258 | .b = VK_COMPONENT_SWIZZLE_IDENTITY, | ||
| 259 | .a = VK_COMPONENT_SWIZZLE_IDENTITY, | ||
| 260 | }, | ||
| 261 | .subresourceRange = | ||
| 262 | { | ||
| 263 | .aspectMask = VK_IMAGE_ASPECT_COLOR_BIT, | ||
| 264 | .baseMipLevel = 0, | ||
| 265 | .levelCount = 1, | ||
| 266 | .baseArrayLayer = 0, | ||
| 267 | .layerCount = 1, | ||
| 268 | }, | ||
| 269 | }; | ||
| 270 | |||
| 271 | image_views.resize(image_count); | ||
| 272 | for (std::size_t i = 0; i < image_count; i++) { | ||
| 273 | ci.image = images[i]; | ||
| 274 | image_views[i] = device.GetLogical().CreateImageView(ci); | ||
| 275 | } | ||
| 276 | } | 249 | } |
| 277 | 250 | ||
| 278 | void Swapchain::Destroy() { | 251 | void Swapchain::Destroy() { |
| 279 | frame_index = 0; | 252 | frame_index = 0; |
| 280 | present_semaphores.clear(); | 253 | present_semaphores.clear(); |
| 281 | framebuffers.clear(); | ||
| 282 | image_views.clear(); | ||
| 283 | swapchain.reset(); | 254 | swapchain.reset(); |
| 284 | } | 255 | } |
| 285 | 256 | ||
diff --git a/src/video_core/renderer_vulkan/vk_swapchain.h b/src/video_core/renderer_vulkan/vk_swapchain.h index caf1ff32b..419742586 100644 --- a/src/video_core/renderer_vulkan/vk_swapchain.h +++ b/src/video_core/renderer_vulkan/vk_swapchain.h | |||
| @@ -27,7 +27,7 @@ public: | |||
| 27 | void Create(u32 width, u32 height, bool srgb); | 27 | void Create(u32 width, u32 height, bool srgb); |
| 28 | 28 | ||
| 29 | /// Acquires the next image in the swapchain, waits as needed. | 29 | /// Acquires the next image in the swapchain, waits as needed. |
| 30 | void AcquireNextImage(); | 30 | bool AcquireNextImage(); |
| 31 | 31 | ||
| 32 | /// Presents the rendered image to the swapchain. | 32 | /// Presents the rendered image to the swapchain. |
| 33 | void Present(VkSemaphore render_semaphore); | 33 | void Present(VkSemaphore render_semaphore); |
| @@ -52,6 +52,11 @@ public: | |||
| 52 | return is_suboptimal; | 52 | return is_suboptimal; |
| 53 | } | 53 | } |
| 54 | 54 | ||
| 55 | /// Returns true when the swapchain format is in the srgb color space | ||
| 56 | bool IsSrgb() const { | ||
| 57 | return current_srgb; | ||
| 58 | } | ||
| 59 | |||
| 55 | VkExtent2D GetSize() const { | 60 | VkExtent2D GetSize() const { |
| 56 | return extent; | 61 | return extent; |
| 57 | } | 62 | } |
| @@ -64,22 +69,34 @@ public: | |||
| 64 | return image_index; | 69 | return image_index; |
| 65 | } | 70 | } |
| 66 | 71 | ||
| 72 | std::size_t GetFrameIndex() const { | ||
| 73 | return frame_index; | ||
| 74 | } | ||
| 75 | |||
| 67 | VkImage GetImageIndex(std::size_t index) const { | 76 | VkImage GetImageIndex(std::size_t index) const { |
| 68 | return images[index]; | 77 | return images[index]; |
| 69 | } | 78 | } |
| 70 | 79 | ||
| 71 | VkImageView GetImageViewIndex(std::size_t index) const { | 80 | VkImage CurrentImage() const { |
| 72 | return *image_views[index]; | 81 | return images[image_index]; |
| 73 | } | 82 | } |
| 74 | 83 | ||
| 75 | VkFormat GetImageViewFormat() const { | 84 | VkFormat GetImageViewFormat() const { |
| 76 | return image_view_format; | 85 | return image_view_format; |
| 77 | } | 86 | } |
| 78 | 87 | ||
| 88 | VkFormat GetImageFormat() const { | ||
| 89 | return surface_format.format; | ||
| 90 | } | ||
| 91 | |||
| 79 | VkSemaphore CurrentPresentSemaphore() const { | 92 | VkSemaphore CurrentPresentSemaphore() const { |
| 80 | return *present_semaphores[frame_index]; | 93 | return *present_semaphores[frame_index]; |
| 81 | } | 94 | } |
| 82 | 95 | ||
| 96 | VkSemaphore CurrentRenderSemaphore() const { | ||
| 97 | return *render_semaphores[frame_index]; | ||
| 98 | } | ||
| 99 | |||
| 83 | u32 GetWidth() const { | 100 | u32 GetWidth() const { |
| 84 | return width; | 101 | return width; |
| 85 | } | 102 | } |
| @@ -88,6 +105,10 @@ public: | |||
| 88 | return height; | 105 | return height; |
| 89 | } | 106 | } |
| 90 | 107 | ||
| 108 | VkExtent2D GetExtent() const { | ||
| 109 | return extent; | ||
| 110 | } | ||
| 111 | |||
| 91 | private: | 112 | private: |
| 92 | void CreateSwapchain(const VkSurfaceCapabilitiesKHR& capabilities, bool srgb); | 113 | void CreateSwapchain(const VkSurfaceCapabilitiesKHR& capabilities, bool srgb); |
| 93 | void CreateSemaphores(); | 114 | void CreateSemaphores(); |
| @@ -107,10 +128,9 @@ private: | |||
| 107 | 128 | ||
| 108 | std::size_t image_count{}; | 129 | std::size_t image_count{}; |
| 109 | std::vector<VkImage> images; | 130 | std::vector<VkImage> images; |
| 110 | std::vector<vk::ImageView> image_views; | ||
| 111 | std::vector<vk::Framebuffer> framebuffers; | ||
| 112 | std::vector<u64> resource_ticks; | 131 | std::vector<u64> resource_ticks; |
| 113 | std::vector<vk::Semaphore> present_semaphores; | 132 | std::vector<vk::Semaphore> present_semaphores; |
| 133 | std::vector<vk::Semaphore> render_semaphores; | ||
| 114 | 134 | ||
| 115 | u32 width; | 135 | u32 width; |
| 116 | u32 height; | 136 | u32 height; |
| @@ -121,6 +141,7 @@ private: | |||
| 121 | VkFormat image_view_format{}; | 141 | VkFormat image_view_format{}; |
| 122 | VkExtent2D extent{}; | 142 | VkExtent2D extent{}; |
| 123 | VkPresentModeKHR present_mode{}; | 143 | VkPresentModeKHR present_mode{}; |
| 144 | VkSurfaceFormatKHR surface_format{}; | ||
| 124 | 145 | ||
| 125 | bool current_srgb{}; | 146 | bool current_srgb{}; |
| 126 | bool current_fps_unlocked{}; | 147 | bool current_fps_unlocked{}; |
diff --git a/src/video_core/renderer_vulkan/vk_update_descriptor.cpp b/src/video_core/renderer_vulkan/vk_update_descriptor.cpp index 009dab0b6..0630ebda5 100644 --- a/src/video_core/renderer_vulkan/vk_update_descriptor.cpp +++ b/src/video_core/renderer_vulkan/vk_update_descriptor.cpp | |||
| @@ -14,13 +14,18 @@ namespace Vulkan { | |||
| 14 | 14 | ||
| 15 | UpdateDescriptorQueue::UpdateDescriptorQueue(const Device& device_, Scheduler& scheduler_) | 15 | UpdateDescriptorQueue::UpdateDescriptorQueue(const Device& device_, Scheduler& scheduler_) |
| 16 | : device{device_}, scheduler{scheduler_} { | 16 | : device{device_}, scheduler{scheduler_} { |
| 17 | payload_start = payload.data(); | ||
| 17 | payload_cursor = payload.data(); | 18 | payload_cursor = payload.data(); |
| 18 | } | 19 | } |
| 19 | 20 | ||
| 20 | UpdateDescriptorQueue::~UpdateDescriptorQueue() = default; | 21 | UpdateDescriptorQueue::~UpdateDescriptorQueue() = default; |
| 21 | 22 | ||
| 22 | void UpdateDescriptorQueue::TickFrame() { | 23 | void UpdateDescriptorQueue::TickFrame() { |
| 23 | payload_cursor = payload.data(); | 24 | if (++frame_index >= FRAMES_IN_FLIGHT) { |
| 25 | frame_index = 0; | ||
| 26 | } | ||
| 27 | payload_start = payload.data() + frame_index * FRAME_PAYLOAD_SIZE; | ||
| 28 | payload_cursor = payload_start; | ||
| 24 | } | 29 | } |
| 25 | 30 | ||
| 26 | void UpdateDescriptorQueue::Acquire() { | 31 | void UpdateDescriptorQueue::Acquire() { |
| @@ -28,10 +33,10 @@ void UpdateDescriptorQueue::Acquire() { | |||
| 28 | // This is the maximum number of entries a single draw call might use. | 33 | // This is the maximum number of entries a single draw call might use. |
| 29 | static constexpr size_t MIN_ENTRIES = 0x400; | 34 | static constexpr size_t MIN_ENTRIES = 0x400; |
| 30 | 35 | ||
| 31 | if (std::distance(payload.data(), payload_cursor) + MIN_ENTRIES >= payload.max_size()) { | 36 | if (std::distance(payload_start, payload_cursor) + MIN_ENTRIES >= FRAME_PAYLOAD_SIZE) { |
| 32 | LOG_WARNING(Render_Vulkan, "Payload overflow, waiting for worker thread"); | 37 | LOG_WARNING(Render_Vulkan, "Payload overflow, waiting for worker thread"); |
| 33 | scheduler.WaitWorker(); | 38 | scheduler.WaitWorker(); |
| 34 | payload_cursor = payload.data(); | 39 | payload_cursor = payload_start; |
| 35 | } | 40 | } |
| 36 | upload_start = payload_cursor; | 41 | upload_start = payload_cursor; |
| 37 | } | 42 | } |
diff --git a/src/video_core/renderer_vulkan/vk_update_descriptor.h b/src/video_core/renderer_vulkan/vk_update_descriptor.h index 625bcc809..1c1a7020b 100644 --- a/src/video_core/renderer_vulkan/vk_update_descriptor.h +++ b/src/video_core/renderer_vulkan/vk_update_descriptor.h | |||
| @@ -29,6 +29,12 @@ struct DescriptorUpdateEntry { | |||
| 29 | }; | 29 | }; |
| 30 | 30 | ||
| 31 | class UpdateDescriptorQueue final { | 31 | class UpdateDescriptorQueue final { |
| 32 | // This should be plenty for the vast majority of cases. Most desktop platforms only | ||
| 33 | // provide up to 3 swapchain images. | ||
| 34 | static constexpr size_t FRAMES_IN_FLIGHT = 5; | ||
| 35 | static constexpr size_t FRAME_PAYLOAD_SIZE = 0x10000; | ||
| 36 | static constexpr size_t PAYLOAD_SIZE = FRAME_PAYLOAD_SIZE * FRAMES_IN_FLIGHT; | ||
| 37 | |||
| 32 | public: | 38 | public: |
| 33 | explicit UpdateDescriptorQueue(const Device& device_, Scheduler& scheduler_); | 39 | explicit UpdateDescriptorQueue(const Device& device_, Scheduler& scheduler_); |
| 34 | ~UpdateDescriptorQueue(); | 40 | ~UpdateDescriptorQueue(); |
| @@ -73,9 +79,11 @@ private: | |||
| 73 | const Device& device; | 79 | const Device& device; |
| 74 | Scheduler& scheduler; | 80 | Scheduler& scheduler; |
| 75 | 81 | ||
| 82 | size_t frame_index{0}; | ||
| 76 | DescriptorUpdateEntry* payload_cursor = nullptr; | 83 | DescriptorUpdateEntry* payload_cursor = nullptr; |
| 84 | DescriptorUpdateEntry* payload_start = nullptr; | ||
| 77 | const DescriptorUpdateEntry* upload_start = nullptr; | 85 | const DescriptorUpdateEntry* upload_start = nullptr; |
| 78 | std::array<DescriptorUpdateEntry, 0x10000> payload; | 86 | std::array<DescriptorUpdateEntry, PAYLOAD_SIZE> payload; |
| 79 | }; | 87 | }; |
| 80 | 88 | ||
| 81 | } // namespace Vulkan | 89 | } // namespace Vulkan |
diff --git a/src/yuzu/configuration/config.cpp b/src/yuzu/configuration/config.cpp index bb731276e..305891d18 100644 --- a/src/yuzu/configuration/config.cpp +++ b/src/yuzu/configuration/config.cpp | |||
| @@ -692,6 +692,7 @@ void Config::ReadRendererValues() { | |||
| 692 | qt_config->beginGroup(QStringLiteral("Renderer")); | 692 | qt_config->beginGroup(QStringLiteral("Renderer")); |
| 693 | 693 | ||
| 694 | ReadGlobalSetting(Settings::values.renderer_backend); | 694 | ReadGlobalSetting(Settings::values.renderer_backend); |
| 695 | ReadGlobalSetting(Settings::values.async_presentation); | ||
| 695 | ReadGlobalSetting(Settings::values.renderer_force_max_clock); | 696 | ReadGlobalSetting(Settings::values.renderer_force_max_clock); |
| 696 | ReadGlobalSetting(Settings::values.vulkan_device); | 697 | ReadGlobalSetting(Settings::values.vulkan_device); |
| 697 | ReadGlobalSetting(Settings::values.fullscreen_mode); | 698 | ReadGlobalSetting(Settings::values.fullscreen_mode); |
| @@ -1313,6 +1314,7 @@ void Config::SaveRendererValues() { | |||
| 1313 | static_cast<u32>(Settings::values.renderer_backend.GetValue(global)), | 1314 | static_cast<u32>(Settings::values.renderer_backend.GetValue(global)), |
| 1314 | static_cast<u32>(Settings::values.renderer_backend.GetDefault()), | 1315 | static_cast<u32>(Settings::values.renderer_backend.GetDefault()), |
| 1315 | Settings::values.renderer_backend.UsingGlobal()); | 1316 | Settings::values.renderer_backend.UsingGlobal()); |
| 1317 | WriteGlobalSetting(Settings::values.async_presentation); | ||
| 1316 | WriteGlobalSetting(Settings::values.renderer_force_max_clock); | 1318 | WriteGlobalSetting(Settings::values.renderer_force_max_clock); |
| 1317 | WriteGlobalSetting(Settings::values.vulkan_device); | 1319 | WriteGlobalSetting(Settings::values.vulkan_device); |
| 1318 | WriteSetting(QString::fromStdString(Settings::values.fullscreen_mode.GetLabel()), | 1320 | WriteSetting(QString::fromStdString(Settings::values.fullscreen_mode.GetLabel()), |
diff --git a/src/yuzu/configuration/configure_graphics_advanced.cpp b/src/yuzu/configuration/configure_graphics_advanced.cpp index 59fb1b334..7f7bf0e4d 100644 --- a/src/yuzu/configuration/configure_graphics_advanced.cpp +++ b/src/yuzu/configuration/configure_graphics_advanced.cpp | |||
| @@ -22,11 +22,13 @@ ConfigureGraphicsAdvanced::~ConfigureGraphicsAdvanced() = default; | |||
| 22 | void ConfigureGraphicsAdvanced::SetConfiguration() { | 22 | void ConfigureGraphicsAdvanced::SetConfiguration() { |
| 23 | const bool runtime_lock = !system.IsPoweredOn(); | 23 | const bool runtime_lock = !system.IsPoweredOn(); |
| 24 | ui->use_vsync->setEnabled(runtime_lock); | 24 | ui->use_vsync->setEnabled(runtime_lock); |
| 25 | ui->async_present->setEnabled(runtime_lock); | ||
| 25 | ui->renderer_force_max_clock->setEnabled(runtime_lock); | 26 | ui->renderer_force_max_clock->setEnabled(runtime_lock); |
| 26 | ui->async_astc->setEnabled(runtime_lock); | 27 | ui->async_astc->setEnabled(runtime_lock); |
| 27 | ui->use_asynchronous_shaders->setEnabled(runtime_lock); | 28 | ui->use_asynchronous_shaders->setEnabled(runtime_lock); |
| 28 | ui->anisotropic_filtering_combobox->setEnabled(runtime_lock); | 29 | ui->anisotropic_filtering_combobox->setEnabled(runtime_lock); |
| 29 | 30 | ||
| 31 | ui->async_present->setChecked(Settings::values.async_presentation.GetValue()); | ||
| 30 | ui->renderer_force_max_clock->setChecked(Settings::values.renderer_force_max_clock.GetValue()); | 32 | ui->renderer_force_max_clock->setChecked(Settings::values.renderer_force_max_clock.GetValue()); |
| 31 | ui->use_vsync->setChecked(Settings::values.use_vsync.GetValue()); | 33 | ui->use_vsync->setChecked(Settings::values.use_vsync.GetValue()); |
| 32 | ui->async_astc->setChecked(Settings::values.async_astc.GetValue()); | 34 | ui->async_astc->setChecked(Settings::values.async_astc.GetValue()); |
| @@ -54,6 +56,8 @@ void ConfigureGraphicsAdvanced::SetConfiguration() { | |||
| 54 | 56 | ||
| 55 | void ConfigureGraphicsAdvanced::ApplyConfiguration() { | 57 | void ConfigureGraphicsAdvanced::ApplyConfiguration() { |
| 56 | ConfigurationShared::ApplyPerGameSetting(&Settings::values.gpu_accuracy, ui->gpu_accuracy); | 58 | ConfigurationShared::ApplyPerGameSetting(&Settings::values.gpu_accuracy, ui->gpu_accuracy); |
| 59 | ConfigurationShared::ApplyPerGameSetting(&Settings::values.async_presentation, | ||
| 60 | ui->async_present, async_present); | ||
| 57 | ConfigurationShared::ApplyPerGameSetting(&Settings::values.renderer_force_max_clock, | 61 | ConfigurationShared::ApplyPerGameSetting(&Settings::values.renderer_force_max_clock, |
| 58 | ui->renderer_force_max_clock, | 62 | ui->renderer_force_max_clock, |
| 59 | renderer_force_max_clock); | 63 | renderer_force_max_clock); |
| @@ -90,6 +94,7 @@ void ConfigureGraphicsAdvanced::SetupPerGameUI() { | |||
| 90 | // Disable if not global (only happens during game) | 94 | // Disable if not global (only happens during game) |
| 91 | if (Settings::IsConfiguringGlobal()) { | 95 | if (Settings::IsConfiguringGlobal()) { |
| 92 | ui->gpu_accuracy->setEnabled(Settings::values.gpu_accuracy.UsingGlobal()); | 96 | ui->gpu_accuracy->setEnabled(Settings::values.gpu_accuracy.UsingGlobal()); |
| 97 | ui->async_present->setEnabled(Settings::values.async_presentation.UsingGlobal()); | ||
| 93 | ui->renderer_force_max_clock->setEnabled( | 98 | ui->renderer_force_max_clock->setEnabled( |
| 94 | Settings::values.renderer_force_max_clock.UsingGlobal()); | 99 | Settings::values.renderer_force_max_clock.UsingGlobal()); |
| 95 | ui->use_vsync->setEnabled(Settings::values.use_vsync.UsingGlobal()); | 100 | ui->use_vsync->setEnabled(Settings::values.use_vsync.UsingGlobal()); |
| @@ -107,6 +112,8 @@ void ConfigureGraphicsAdvanced::SetupPerGameUI() { | |||
| 107 | return; | 112 | return; |
| 108 | } | 113 | } |
| 109 | 114 | ||
| 115 | ConfigurationShared::SetColoredTristate(ui->async_present, Settings::values.async_presentation, | ||
| 116 | async_present); | ||
| 110 | ConfigurationShared::SetColoredTristate(ui->renderer_force_max_clock, | 117 | ConfigurationShared::SetColoredTristate(ui->renderer_force_max_clock, |
| 111 | Settings::values.renderer_force_max_clock, | 118 | Settings::values.renderer_force_max_clock, |
| 112 | renderer_force_max_clock); | 119 | renderer_force_max_clock); |
diff --git a/src/yuzu/configuration/configure_graphics_advanced.h b/src/yuzu/configuration/configure_graphics_advanced.h index bf1b04749..5394ed40a 100644 --- a/src/yuzu/configuration/configure_graphics_advanced.h +++ b/src/yuzu/configuration/configure_graphics_advanced.h | |||
| @@ -36,6 +36,7 @@ private: | |||
| 36 | 36 | ||
| 37 | std::unique_ptr<Ui::ConfigureGraphicsAdvanced> ui; | 37 | std::unique_ptr<Ui::ConfigureGraphicsAdvanced> ui; |
| 38 | 38 | ||
| 39 | ConfigurationShared::CheckState async_present; | ||
| 39 | ConfigurationShared::CheckState renderer_force_max_clock; | 40 | ConfigurationShared::CheckState renderer_force_max_clock; |
| 40 | ConfigurationShared::CheckState use_vsync; | 41 | ConfigurationShared::CheckState use_vsync; |
| 41 | ConfigurationShared::CheckState async_astc; | 42 | ConfigurationShared::CheckState async_astc; |
diff --git a/src/yuzu/configuration/configure_graphics_advanced.ui b/src/yuzu/configuration/configure_graphics_advanced.ui index a7dbdc18c..d7ec18939 100644 --- a/src/yuzu/configuration/configure_graphics_advanced.ui +++ b/src/yuzu/configuration/configure_graphics_advanced.ui | |||
| @@ -7,7 +7,7 @@ | |||
| 7 | <x>0</x> | 7 | <x>0</x> |
| 8 | <y>0</y> | 8 | <y>0</y> |
| 9 | <width>404</width> | 9 | <width>404</width> |
| 10 | <height>321</height> | 10 | <height>376</height> |
| 11 | </rect> | 11 | </rect> |
| 12 | </property> | 12 | </property> |
| 13 | <property name="windowTitle"> | 13 | <property name="windowTitle"> |
| @@ -70,6 +70,13 @@ | |||
| 70 | </widget> | 70 | </widget> |
| 71 | </item> | 71 | </item> |
| 72 | <item> | 72 | <item> |
| 73 | <widget class="QCheckBox" name="async_present"> | ||
| 74 | <property name="text"> | ||
| 75 | <string>Enable asynchronous presentation (Vulkan only)</string> | ||
| 76 | </property> | ||
| 77 | </widget> | ||
| 78 | </item> | ||
| 79 | <item> | ||
| 73 | <widget class="QCheckBox" name="renderer_force_max_clock"> | 80 | <widget class="QCheckBox" name="renderer_force_max_clock"> |
| 74 | <property name="toolTip"> | 81 | <property name="toolTip"> |
| 75 | <string>Runs work in the background while waiting for graphics commands to keep the GPU from lowering its clock speed.</string> | 82 | <string>Runs work in the background while waiting for graphics commands to keep the GPU from lowering its clock speed.</string> |
| @@ -112,7 +119,7 @@ | |||
| 112 | <item> | 119 | <item> |
| 113 | <widget class="QCheckBox" name="use_fast_gpu_time"> | 120 | <widget class="QCheckBox" name="use_fast_gpu_time"> |
| 114 | <property name="toolTip"> | 121 | <property name="toolTip"> |
| 115 | <string>Enables Fast GPU Time. This option will force most games to run at their highest native resolution.</string> | 122 | <string>Enables Fast GPU Time. This option will force most games to run at their highest native resolution.</string> |
| 116 | </property> | 123 | </property> |
| 117 | <property name="text"> | 124 | <property name="text"> |
| 118 | <string>Use Fast GPU Time (Hack)</string> | 125 | <string>Use Fast GPU Time (Hack)</string> |
| @@ -122,7 +129,7 @@ | |||
| 122 | <item> | 129 | <item> |
| 123 | <widget class="QCheckBox" name="use_pessimistic_flushes"> | 130 | <widget class="QCheckBox" name="use_pessimistic_flushes"> |
| 124 | <property name="toolTip"> | 131 | <property name="toolTip"> |
| 125 | <string>Enables pessimistic buffer flushes. This option will force unmodified buffers to be flushed, which can cost performance.</string> | 132 | <string>Enables pessimistic buffer flushes. This option will force unmodified buffers to be flushed, which can cost performance.</string> |
| 126 | </property> | 133 | </property> |
| 127 | <property name="text"> | 134 | <property name="text"> |
| 128 | <string>Use pessimistic buffer flushes (Hack)</string> | 135 | <string>Use pessimistic buffer flushes (Hack)</string> |
| @@ -132,7 +139,7 @@ | |||
| 132 | <item> | 139 | <item> |
| 133 | <widget class="QCheckBox" name="use_vulkan_driver_pipeline_cache"> | 140 | <widget class="QCheckBox" name="use_vulkan_driver_pipeline_cache"> |
| 134 | <property name="toolTip"> | 141 | <property name="toolTip"> |
| 135 | <string>Enables GPU vendor-specific pipeline cache. This option can improve shader loading time significantly in cases where the Vulkan driver does not store pipeline cache files internally.</string> | 142 | <string>Enables GPU vendor-specific pipeline cache. This option can improve shader loading time significantly in cases where the Vulkan driver does not store pipeline cache files internally.</string> |
| 136 | </property> | 143 | </property> |
| 137 | <property name="text"> | 144 | <property name="text"> |
| 138 | <string>Use Vulkan pipeline cache</string> | 145 | <string>Use Vulkan pipeline cache</string> |
diff --git a/src/yuzu_cmd/config.cpp b/src/yuzu_cmd/config.cpp index 464da3231..fa347fb8c 100644 --- a/src/yuzu_cmd/config.cpp +++ b/src/yuzu_cmd/config.cpp | |||
| @@ -300,6 +300,7 @@ void Config::ReadValues() { | |||
| 300 | 300 | ||
| 301 | // Renderer | 301 | // Renderer |
| 302 | ReadSetting("Renderer", Settings::values.renderer_backend); | 302 | ReadSetting("Renderer", Settings::values.renderer_backend); |
| 303 | ReadSetting("Renderer", Settings::values.async_presentation); | ||
| 303 | ReadSetting("Renderer", Settings::values.renderer_force_max_clock); | 304 | ReadSetting("Renderer", Settings::values.renderer_force_max_clock); |
| 304 | ReadSetting("Renderer", Settings::values.renderer_debug); | 305 | ReadSetting("Renderer", Settings::values.renderer_debug); |
| 305 | ReadSetting("Renderer", Settings::values.renderer_shader_feedback); | 306 | ReadSetting("Renderer", Settings::values.renderer_shader_feedback); |
diff --git a/src/yuzu_cmd/default_ini.h b/src/yuzu_cmd/default_ini.h index 209cfc28a..c0c89fbb9 100644 --- a/src/yuzu_cmd/default_ini.h +++ b/src/yuzu_cmd/default_ini.h | |||
| @@ -264,6 +264,10 @@ cpuopt_unsafe_ignore_global_monitor = | |||
| 264 | # 0: OpenGL, 1 (default): Vulkan | 264 | # 0: OpenGL, 1 (default): Vulkan |
| 265 | backend = | 265 | backend = |
| 266 | 266 | ||
| 267 | # Whether to enable asynchronous presentation (Vulkan only) | ||
| 268 | # 0 (default): Off, 1: On | ||
| 269 | async_presentation = | ||
| 270 | |||
| 267 | # Enable graphics API debugging mode. | 271 | # Enable graphics API debugging mode. |
| 268 | # 0 (default): Disabled, 1: Enabled | 272 | # 0 (default): Disabled, 1: Enabled |
| 269 | debug = | 273 | debug = |