diff options
82 files changed, 1531 insertions, 1204 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index 7a49318aa..3282ae9d4 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt | |||
| @@ -159,15 +159,15 @@ macro(yuzu_find_packages) | |||
| 159 | # Capitalization matters here. We need the naming to match the generated paths from Conan | 159 | # Capitalization matters here. We need the naming to match the generated paths from Conan |
| 160 | set(REQUIRED_LIBS | 160 | set(REQUIRED_LIBS |
| 161 | # Cmake Pkg Prefix Version Conan Pkg | 161 | # Cmake Pkg Prefix Version Conan Pkg |
| 162 | "Boost 1.71 boost/1.72.0" | 162 | "Boost 1.73 boost/1.73.0" |
| 163 | "Catch2 2.11 catch2/2.11.0" | 163 | "Catch2 2.13 catch2/2.13.0" |
| 164 | "fmt 7.0 fmt/7.0.1" | 164 | "fmt 7.0 fmt/7.0.1" |
| 165 | # can't use until https://github.com/bincrafters/community/issues/1173 | 165 | # can't use until https://github.com/bincrafters/community/issues/1173 |
| 166 | #"libzip 1.5 libzip/1.5.2@bincrafters/stable" | 166 | #"libzip 1.5 libzip/1.5.2@bincrafters/stable" |
| 167 | "lz4 1.8 lz4/1.9.2" | 167 | "lz4 1.8 lz4/1.9.2" |
| 168 | "nlohmann_json 3.7 nlohmann_json/3.7.3" | 168 | "nlohmann_json 3.8 nlohmann_json/3.8.0" |
| 169 | "ZLIB 1.2 zlib/1.2.11" | 169 | "ZLIB 1.2 zlib/1.2.11" |
| 170 | "zstd 1.4 zstd/1.4.4" | 170 | "zstd 1.4 zstd/1.4.5" |
| 171 | ) | 171 | ) |
| 172 | 172 | ||
| 173 | foreach(PACKAGE ${REQUIRED_LIBS}) | 173 | foreach(PACKAGE ${REQUIRED_LIBS}) |
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 1e977e8a8..71efbb40d 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt | |||
| @@ -62,6 +62,12 @@ else() | |||
| 62 | -Wno-unused-parameter | 62 | -Wno-unused-parameter |
| 63 | ) | 63 | ) |
| 64 | 64 | ||
| 65 | # TODO: Remove when we update to a GCC compiler that enables this | ||
| 66 | # by default (i.e. GCC 10 or newer). | ||
| 67 | if (CMAKE_CXX_COMPILER_ID STREQUAL GNU) | ||
| 68 | add_compile_options(-fconcepts) | ||
| 69 | endif() | ||
| 70 | |||
| 65 | if (ARCHITECTURE_x86_64) | 71 | if (ARCHITECTURE_x86_64) |
| 66 | add_compile_options("-mcx16") | 72 | add_compile_options("-mcx16") |
| 67 | endif() | 73 | endif() |
diff --git a/src/common/CMakeLists.txt b/src/common/CMakeLists.txt index d120c8d3d..78c3bfb3b 100644 --- a/src/common/CMakeLists.txt +++ b/src/common/CMakeLists.txt | |||
| @@ -110,6 +110,7 @@ add_library(common STATIC | |||
| 110 | common_funcs.h | 110 | common_funcs.h |
| 111 | common_paths.h | 111 | common_paths.h |
| 112 | common_types.h | 112 | common_types.h |
| 113 | concepts.h | ||
| 113 | dynamic_library.cpp | 114 | dynamic_library.cpp |
| 114 | dynamic_library.h | 115 | dynamic_library.h |
| 115 | fiber.cpp | 116 | fiber.cpp |
diff --git a/src/common/atomic_ops.cpp b/src/common/atomic_ops.cpp index 1098e21ff..1612d0e67 100644 --- a/src/common/atomic_ops.cpp +++ b/src/common/atomic_ops.cpp | |||
| @@ -14,50 +14,55 @@ namespace Common { | |||
| 14 | 14 | ||
| 15 | #if _MSC_VER | 15 | #if _MSC_VER |
| 16 | 16 | ||
| 17 | bool AtomicCompareAndSwap(u8 volatile* pointer, u8 value, u8 expected) { | 17 | bool AtomicCompareAndSwap(volatile u8* pointer, u8 value, u8 expected) { |
| 18 | u8 result = _InterlockedCompareExchange8((char*)pointer, value, expected); | 18 | const u8 result = |
| 19 | _InterlockedCompareExchange8(reinterpret_cast<volatile char*>(pointer), value, expected); | ||
| 19 | return result == expected; | 20 | return result == expected; |
| 20 | } | 21 | } |
| 21 | 22 | ||
| 22 | bool AtomicCompareAndSwap(u16 volatile* pointer, u16 value, u16 expected) { | 23 | bool AtomicCompareAndSwap(volatile u16* pointer, u16 value, u16 expected) { |
| 23 | u16 result = _InterlockedCompareExchange16((short*)pointer, value, expected); | 24 | const u16 result = |
| 25 | _InterlockedCompareExchange16(reinterpret_cast<volatile short*>(pointer), value, expected); | ||
| 24 | return result == expected; | 26 | return result == expected; |
| 25 | } | 27 | } |
| 26 | 28 | ||
| 27 | bool AtomicCompareAndSwap(u32 volatile* pointer, u32 value, u32 expected) { | 29 | bool AtomicCompareAndSwap(volatile u32* pointer, u32 value, u32 expected) { |
| 28 | u32 result = _InterlockedCompareExchange((long*)pointer, value, expected); | 30 | const u32 result = |
| 31 | _InterlockedCompareExchange(reinterpret_cast<volatile long*>(pointer), value, expected); | ||
| 29 | return result == expected; | 32 | return result == expected; |
| 30 | } | 33 | } |
| 31 | 34 | ||
| 32 | bool AtomicCompareAndSwap(u64 volatile* pointer, u64 value, u64 expected) { | 35 | bool AtomicCompareAndSwap(volatile u64* pointer, u64 value, u64 expected) { |
| 33 | u64 result = _InterlockedCompareExchange64((__int64*)pointer, value, expected); | 36 | const u64 result = _InterlockedCompareExchange64(reinterpret_cast<volatile __int64*>(pointer), |
| 37 | value, expected); | ||
| 34 | return result == expected; | 38 | return result == expected; |
| 35 | } | 39 | } |
| 36 | 40 | ||
| 37 | bool AtomicCompareAndSwap(u64 volatile* pointer, u128 value, u128 expected) { | 41 | bool AtomicCompareAndSwap(volatile u64* pointer, u128 value, u128 expected) { |
| 38 | return _InterlockedCompareExchange128((__int64*)pointer, value[1], value[0], | 42 | return _InterlockedCompareExchange128(reinterpret_cast<volatile __int64*>(pointer), value[1], |
| 39 | (__int64*)expected.data()) != 0; | 43 | value[0], |
| 44 | reinterpret_cast<__int64*>(expected.data())) != 0; | ||
| 40 | } | 45 | } |
| 41 | 46 | ||
| 42 | #else | 47 | #else |
| 43 | 48 | ||
| 44 | bool AtomicCompareAndSwap(u8 volatile* pointer, u8 value, u8 expected) { | 49 | bool AtomicCompareAndSwap(volatile u8* pointer, u8 value, u8 expected) { |
| 45 | return __sync_bool_compare_and_swap(pointer, expected, value); | 50 | return __sync_bool_compare_and_swap(pointer, expected, value); |
| 46 | } | 51 | } |
| 47 | 52 | ||
| 48 | bool AtomicCompareAndSwap(u16 volatile* pointer, u16 value, u16 expected) { | 53 | bool AtomicCompareAndSwap(volatile u16* pointer, u16 value, u16 expected) { |
| 49 | return __sync_bool_compare_and_swap(pointer, expected, value); | 54 | return __sync_bool_compare_and_swap(pointer, expected, value); |
| 50 | } | 55 | } |
| 51 | 56 | ||
| 52 | bool AtomicCompareAndSwap(u32 volatile* pointer, u32 value, u32 expected) { | 57 | bool AtomicCompareAndSwap(volatile u32* pointer, u32 value, u32 expected) { |
| 53 | return __sync_bool_compare_and_swap(pointer, expected, value); | 58 | return __sync_bool_compare_and_swap(pointer, expected, value); |
| 54 | } | 59 | } |
| 55 | 60 | ||
| 56 | bool AtomicCompareAndSwap(u64 volatile* pointer, u64 value, u64 expected) { | 61 | bool AtomicCompareAndSwap(volatile u64* pointer, u64 value, u64 expected) { |
| 57 | return __sync_bool_compare_and_swap(pointer, expected, value); | 62 | return __sync_bool_compare_and_swap(pointer, expected, value); |
| 58 | } | 63 | } |
| 59 | 64 | ||
| 60 | bool AtomicCompareAndSwap(u64 volatile* pointer, u128 value, u128 expected) { | 65 | bool AtomicCompareAndSwap(volatile u64* pointer, u128 value, u128 expected) { |
| 61 | unsigned __int128 value_a; | 66 | unsigned __int128 value_a; |
| 62 | unsigned __int128 expected_a; | 67 | unsigned __int128 expected_a; |
| 63 | std::memcpy(&value_a, value.data(), sizeof(u128)); | 68 | std::memcpy(&value_a, value.data(), sizeof(u128)); |
diff --git a/src/common/atomic_ops.h b/src/common/atomic_ops.h index e6181d521..8d6b73c00 100644 --- a/src/common/atomic_ops.h +++ b/src/common/atomic_ops.h | |||
| @@ -8,10 +8,10 @@ | |||
| 8 | 8 | ||
| 9 | namespace Common { | 9 | namespace Common { |
| 10 | 10 | ||
| 11 | bool AtomicCompareAndSwap(u8 volatile* pointer, u8 value, u8 expected); | 11 | bool AtomicCompareAndSwap(volatile u8* pointer, u8 value, u8 expected); |
| 12 | bool AtomicCompareAndSwap(u16 volatile* pointer, u16 value, u16 expected); | 12 | bool AtomicCompareAndSwap(volatile u16* pointer, u16 value, u16 expected); |
| 13 | bool AtomicCompareAndSwap(u32 volatile* pointer, u32 value, u32 expected); | 13 | bool AtomicCompareAndSwap(volatile u32* pointer, u32 value, u32 expected); |
| 14 | bool AtomicCompareAndSwap(u64 volatile* pointer, u64 value, u64 expected); | 14 | bool AtomicCompareAndSwap(volatile u64* pointer, u64 value, u64 expected); |
| 15 | bool AtomicCompareAndSwap(u64 volatile* pointer, u128 value, u128 expected); | 15 | bool AtomicCompareAndSwap(volatile u64* pointer, u128 value, u128 expected); |
| 16 | 16 | ||
| 17 | } // namespace Common | 17 | } // namespace Common |
diff --git a/src/common/common_paths.h b/src/common/common_paths.h index 076752d3b..3c593d5f6 100644 --- a/src/common/common_paths.h +++ b/src/common/common_paths.h | |||
| @@ -35,6 +35,7 @@ | |||
| 35 | #define KEYS_DIR "keys" | 35 | #define KEYS_DIR "keys" |
| 36 | #define LOAD_DIR "load" | 36 | #define LOAD_DIR "load" |
| 37 | #define DUMP_DIR "dump" | 37 | #define DUMP_DIR "dump" |
| 38 | #define SCREENSHOTS_DIR "screenshots" | ||
| 38 | #define SHADER_DIR "shader" | 39 | #define SHADER_DIR "shader" |
| 39 | #define LOG_DIR "log" | 40 | #define LOG_DIR "log" |
| 40 | 41 | ||
diff --git a/src/common/concepts.h b/src/common/concepts.h new file mode 100644 index 000000000..db5fb373d --- /dev/null +++ b/src/common/concepts.h | |||
| @@ -0,0 +1,32 @@ | |||
| 1 | // Copyright 2020 yuzu emulator team | ||
| 2 | // Licensed under GPLv2 or any later version | ||
| 3 | // Refer to the license.txt file included. | ||
| 4 | |||
| 5 | #pragma once | ||
| 6 | |||
| 7 | namespace Common { | ||
| 8 | |||
| 9 | #include <type_traits> | ||
| 10 | |||
| 11 | // Check if type is like an STL container | ||
| 12 | template <typename T> | ||
| 13 | concept IsSTLContainer = requires(T t) { | ||
| 14 | typename T::value_type; | ||
| 15 | typename T::iterator; | ||
| 16 | typename T::const_iterator; | ||
| 17 | // TODO(ogniK): Replace below is std::same_as<void> when MSVC supports it. | ||
| 18 | t.begin(); | ||
| 19 | t.end(); | ||
| 20 | t.cbegin(); | ||
| 21 | t.cend(); | ||
| 22 | t.data(); | ||
| 23 | t.size(); | ||
| 24 | }; | ||
| 25 | |||
| 26 | // Check if type T is derived from T2 | ||
| 27 | template <typename T, typename T2> | ||
| 28 | concept IsBaseOf = requires { | ||
| 29 | std::is_base_of_v<T, T2>; | ||
| 30 | }; | ||
| 31 | |||
| 32 | } // namespace Common | ||
diff --git a/src/common/file_util.cpp b/src/common/file_util.cpp index 45b750e1e..4ede9f72c 100644 --- a/src/common/file_util.cpp +++ b/src/common/file_util.cpp | |||
| @@ -695,6 +695,7 @@ const std::string& GetUserPath(UserPath path, const std::string& new_path) { | |||
| 695 | paths.emplace(UserPath::NANDDir, user_path + NAND_DIR DIR_SEP); | 695 | paths.emplace(UserPath::NANDDir, user_path + NAND_DIR DIR_SEP); |
| 696 | paths.emplace(UserPath::LoadDir, user_path + LOAD_DIR DIR_SEP); | 696 | paths.emplace(UserPath::LoadDir, user_path + LOAD_DIR DIR_SEP); |
| 697 | paths.emplace(UserPath::DumpDir, user_path + DUMP_DIR DIR_SEP); | 697 | paths.emplace(UserPath::DumpDir, user_path + DUMP_DIR DIR_SEP); |
| 698 | paths.emplace(UserPath::ScreenshotsDir, user_path + SCREENSHOTS_DIR DIR_SEP); | ||
| 698 | paths.emplace(UserPath::ShaderDir, user_path + SHADER_DIR DIR_SEP); | 699 | paths.emplace(UserPath::ShaderDir, user_path + SHADER_DIR DIR_SEP); |
| 699 | paths.emplace(UserPath::SysDataDir, user_path + SYSDATA_DIR DIR_SEP); | 700 | paths.emplace(UserPath::SysDataDir, user_path + SYSDATA_DIR DIR_SEP); |
| 700 | paths.emplace(UserPath::KeysDir, user_path + KEYS_DIR DIR_SEP); | 701 | paths.emplace(UserPath::KeysDir, user_path + KEYS_DIR DIR_SEP); |
diff --git a/src/common/file_util.h b/src/common/file_util.h index f7a0c33fa..187b93161 100644 --- a/src/common/file_util.h +++ b/src/common/file_util.h | |||
| @@ -32,6 +32,7 @@ enum class UserPath { | |||
| 32 | SDMCDir, | 32 | SDMCDir, |
| 33 | LoadDir, | 33 | LoadDir, |
| 34 | DumpDir, | 34 | DumpDir, |
| 35 | ScreenshotsDir, | ||
| 35 | ShaderDir, | 36 | ShaderDir, |
| 36 | SysDataDir, | 37 | SysDataDir, |
| 37 | UserDir, | 38 | UserDir, |
diff --git a/src/core/core.cpp b/src/core/core.cpp index e598c0e2b..42277e2cd 100644 --- a/src/core/core.cpp +++ b/src/core/core.cpp | |||
| @@ -146,7 +146,7 @@ struct System::Impl { | |||
| 146 | ResultStatus Init(System& system, Frontend::EmuWindow& emu_window) { | 146 | ResultStatus Init(System& system, Frontend::EmuWindow& emu_window) { |
| 147 | LOG_DEBUG(HW_Memory, "initialized OK"); | 147 | LOG_DEBUG(HW_Memory, "initialized OK"); |
| 148 | 148 | ||
| 149 | device_memory = std::make_unique<Core::DeviceMemory>(system); | 149 | device_memory = std::make_unique<Core::DeviceMemory>(); |
| 150 | 150 | ||
| 151 | is_multicore = Settings::values.use_multi_core.GetValue(); | 151 | is_multicore = Settings::values.use_multi_core.GetValue(); |
| 152 | is_async_gpu = is_multicore || Settings::values.use_asynchronous_gpu_emulation.GetValue(); | 152 | is_async_gpu = is_multicore || Settings::values.use_asynchronous_gpu_emulation.GetValue(); |
diff --git a/src/core/cpu_manager.cpp b/src/core/cpu_manager.cpp index 32afcf3ae..358943429 100644 --- a/src/core/cpu_manager.cpp +++ b/src/core/cpu_manager.cpp | |||
| @@ -52,15 +52,15 @@ void CpuManager::Shutdown() { | |||
| 52 | } | 52 | } |
| 53 | 53 | ||
| 54 | std::function<void(void*)> CpuManager::GetGuestThreadStartFunc() { | 54 | std::function<void(void*)> CpuManager::GetGuestThreadStartFunc() { |
| 55 | return std::function<void(void*)>(GuestThreadFunction); | 55 | return GuestThreadFunction; |
| 56 | } | 56 | } |
| 57 | 57 | ||
| 58 | std::function<void(void*)> CpuManager::GetIdleThreadStartFunc() { | 58 | std::function<void(void*)> CpuManager::GetIdleThreadStartFunc() { |
| 59 | return std::function<void(void*)>(IdleThreadFunction); | 59 | return IdleThreadFunction; |
| 60 | } | 60 | } |
| 61 | 61 | ||
| 62 | std::function<void(void*)> CpuManager::GetSuspendThreadStartFunc() { | 62 | std::function<void(void*)> CpuManager::GetSuspendThreadStartFunc() { |
| 63 | return std::function<void(void*)>(SuspendThreadFunction); | 63 | return SuspendThreadFunction; |
| 64 | } | 64 | } |
| 65 | 65 | ||
| 66 | void CpuManager::GuestThreadFunction(void* cpu_manager_) { | 66 | void CpuManager::GuestThreadFunction(void* cpu_manager_) { |
diff --git a/src/core/device_memory.cpp b/src/core/device_memory.cpp index 51097ced3..0c4b440ed 100644 --- a/src/core/device_memory.cpp +++ b/src/core/device_memory.cpp | |||
| @@ -2,14 +2,11 @@ | |||
| 2 | // Licensed under GPLv2 or any later version | 2 | // Licensed under GPLv2 or any later version |
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include "core/core.h" | ||
| 6 | #include "core/device_memory.h" | 5 | #include "core/device_memory.h" |
| 7 | #include "core/memory.h" | ||
| 8 | 6 | ||
| 9 | namespace Core { | 7 | namespace Core { |
| 10 | 8 | ||
| 11 | DeviceMemory::DeviceMemory(System& system) : buffer{DramMemoryMap::Size}, system{system} {} | 9 | DeviceMemory::DeviceMemory() : buffer{DramMemoryMap::Size} {} |
| 12 | |||
| 13 | DeviceMemory::~DeviceMemory() = default; | 10 | DeviceMemory::~DeviceMemory() = default; |
| 14 | 11 | ||
| 15 | } // namespace Core | 12 | } // namespace Core |
diff --git a/src/core/device_memory.h b/src/core/device_memory.h index 9efa088d0..5b1ae28f3 100644 --- a/src/core/device_memory.h +++ b/src/core/device_memory.h | |||
| @@ -4,14 +4,11 @@ | |||
| 4 | 4 | ||
| 5 | #pragma once | 5 | #pragma once |
| 6 | 6 | ||
| 7 | #include "common/assert.h" | 7 | #include "common/common_types.h" |
| 8 | #include "common/common_funcs.h" | ||
| 9 | #include "common/virtual_buffer.h" | 8 | #include "common/virtual_buffer.h" |
| 10 | 9 | ||
| 11 | namespace Core { | 10 | namespace Core { |
| 12 | 11 | ||
| 13 | class System; | ||
| 14 | |||
| 15 | namespace DramMemoryMap { | 12 | namespace DramMemoryMap { |
| 16 | enum : u64 { | 13 | enum : u64 { |
| 17 | Base = 0x80000000ULL, | 14 | Base = 0x80000000ULL, |
| @@ -26,7 +23,7 @@ enum : u64 { | |||
| 26 | 23 | ||
| 27 | class DeviceMemory : NonCopyable { | 24 | class DeviceMemory : NonCopyable { |
| 28 | public: | 25 | public: |
| 29 | explicit DeviceMemory(Core::System& system); | 26 | explicit DeviceMemory(); |
| 30 | ~DeviceMemory(); | 27 | ~DeviceMemory(); |
| 31 | 28 | ||
| 32 | template <typename T> | 29 | template <typename T> |
| @@ -45,7 +42,6 @@ public: | |||
| 45 | 42 | ||
| 46 | private: | 43 | private: |
| 47 | Common::VirtualBuffer<u8> buffer; | 44 | Common::VirtualBuffer<u8> buffer; |
| 48 | Core::System& system; | ||
| 49 | }; | 45 | }; |
| 50 | 46 | ||
| 51 | } // namespace Core | 47 | } // namespace Core |
diff --git a/src/core/file_sys/mode.h b/src/core/file_sys/mode.h index c95205668..2b4f21073 100644 --- a/src/core/file_sys/mode.h +++ b/src/core/file_sys/mode.h | |||
| @@ -4,6 +4,7 @@ | |||
| 4 | 4 | ||
| 5 | #pragma once | 5 | #pragma once |
| 6 | 6 | ||
| 7 | #include "common/common_funcs.h" | ||
| 7 | #include "common/common_types.h" | 8 | #include "common/common_types.h" |
| 8 | 9 | ||
| 9 | namespace FileSys { | 10 | namespace FileSys { |
| @@ -11,13 +12,11 @@ namespace FileSys { | |||
| 11 | enum class Mode : u32 { | 12 | enum class Mode : u32 { |
| 12 | Read = 1, | 13 | Read = 1, |
| 13 | Write = 2, | 14 | Write = 2, |
| 14 | ReadWrite = 3, | 15 | ReadWrite = Read | Write, |
| 15 | Append = 4, | 16 | Append = 4, |
| 16 | WriteAppend = 6, | 17 | WriteAppend = Write | Append, |
| 17 | }; | 18 | }; |
| 18 | 19 | ||
| 19 | inline u32 operator&(Mode lhs, Mode rhs) { | 20 | DECLARE_ENUM_FLAG_OPERATORS(Mode) |
| 20 | return static_cast<u32>(lhs) & static_cast<u32>(rhs); | ||
| 21 | } | ||
| 22 | 21 | ||
| 23 | } // namespace FileSys | 22 | } // namespace FileSys |
diff --git a/src/core/file_sys/patch_manager.cpp b/src/core/file_sys/patch_manager.cpp index c47ff863e..729dbb5f4 100644 --- a/src/core/file_sys/patch_manager.cpp +++ b/src/core/file_sys/patch_manager.cpp | |||
| @@ -288,8 +288,8 @@ std::optional<std::vector<Core::Memory::CheatEntry>> ReadCheatFileFromFolder( | |||
| 288 | } | 288 | } |
| 289 | 289 | ||
| 290 | Core::Memory::TextCheatParser parser; | 290 | Core::Memory::TextCheatParser parser; |
| 291 | return parser.Parse( | 291 | return parser.Parse(system, |
| 292 | system, std::string_view(reinterpret_cast<const char* const>(data.data()), data.size())); | 292 | std::string_view(reinterpret_cast<const char*>(data.data()), data.size())); |
| 293 | } | 293 | } |
| 294 | 294 | ||
| 295 | } // Anonymous namespace | 295 | } // Anonymous namespace |
diff --git a/src/core/file_sys/registered_cache.cpp b/src/core/file_sys/registered_cache.cpp index 37351c561..f831487dd 100644 --- a/src/core/file_sys/registered_cache.cpp +++ b/src/core/file_sys/registered_cache.cpp | |||
| @@ -344,15 +344,18 @@ VirtualFile RegisteredCache::GetFileAtID(NcaID id) const { | |||
| 344 | 344 | ||
| 345 | static std::optional<NcaID> CheckMapForContentRecord(const std::map<u64, CNMT>& map, u64 title_id, | 345 | static std::optional<NcaID> CheckMapForContentRecord(const std::map<u64, CNMT>& map, u64 title_id, |
| 346 | ContentRecordType type) { | 346 | ContentRecordType type) { |
| 347 | if (map.find(title_id) == map.end()) | 347 | const auto cmnt_iter = map.find(title_id); |
| 348 | return {}; | 348 | if (cmnt_iter == map.cend()) { |
| 349 | 349 | return std::nullopt; | |
| 350 | const auto& cnmt = map.at(title_id); | 350 | } |
| 351 | 351 | ||
| 352 | const auto iter = std::find_if(cnmt.GetContentRecords().begin(), cnmt.GetContentRecords().end(), | 352 | const auto& cnmt = cmnt_iter->second; |
| 353 | const auto& content_records = cnmt.GetContentRecords(); | ||
| 354 | const auto iter = std::find_if(content_records.cbegin(), content_records.cend(), | ||
| 353 | [type](const ContentRecord& rec) { return rec.type == type; }); | 355 | [type](const ContentRecord& rec) { return rec.type == type; }); |
| 354 | if (iter == cnmt.GetContentRecords().end()) | 356 | if (iter == content_records.cend()) { |
| 355 | return {}; | 357 | return std::nullopt; |
| 358 | } | ||
| 356 | 359 | ||
| 357 | return std::make_optional(iter->nca_id); | 360 | return std::make_optional(iter->nca_id); |
| 358 | } | 361 | } |
| @@ -467,14 +470,16 @@ VirtualFile RegisteredCache::GetEntryUnparsed(u64 title_id, ContentRecordType ty | |||
| 467 | 470 | ||
| 468 | std::optional<u32> RegisteredCache::GetEntryVersion(u64 title_id) const { | 471 | std::optional<u32> RegisteredCache::GetEntryVersion(u64 title_id) const { |
| 469 | const auto meta_iter = meta.find(title_id); | 472 | const auto meta_iter = meta.find(title_id); |
| 470 | if (meta_iter != meta.end()) | 473 | if (meta_iter != meta.cend()) { |
| 471 | return meta_iter->second.GetTitleVersion(); | 474 | return meta_iter->second.GetTitleVersion(); |
| 475 | } | ||
| 472 | 476 | ||
| 473 | const auto yuzu_meta_iter = yuzu_meta.find(title_id); | 477 | const auto yuzu_meta_iter = yuzu_meta.find(title_id); |
| 474 | if (yuzu_meta_iter != yuzu_meta.end()) | 478 | if (yuzu_meta_iter != yuzu_meta.cend()) { |
| 475 | return yuzu_meta_iter->second.GetTitleVersion(); | 479 | return yuzu_meta_iter->second.GetTitleVersion(); |
| 480 | } | ||
| 476 | 481 | ||
| 477 | return {}; | 482 | return std::nullopt; |
| 478 | } | 483 | } |
| 479 | 484 | ||
| 480 | VirtualFile RegisteredCache::GetEntryRaw(u64 title_id, ContentRecordType type) const { | 485 | VirtualFile RegisteredCache::GetEntryRaw(u64 title_id, ContentRecordType type) const { |
| @@ -547,56 +552,6 @@ InstallResult RegisteredCache::InstallEntry(const XCI& xci, bool overwrite_if_ex | |||
| 547 | return InstallEntry(*xci.GetSecurePartitionNSP(), overwrite_if_exists, copy); | 552 | return InstallEntry(*xci.GetSecurePartitionNSP(), overwrite_if_exists, copy); |
| 548 | } | 553 | } |
| 549 | 554 | ||
| 550 | bool RegisteredCache::RemoveExistingEntry(u64 title_id) { | ||
| 551 | const auto delete_nca = [this](const NcaID& id) { | ||
| 552 | const auto path = GetRelativePathFromNcaID(id, false, true, false); | ||
| 553 | |||
| 554 | if (dir->GetFileRelative(path) == nullptr) { | ||
| 555 | return false; | ||
| 556 | } | ||
| 557 | |||
| 558 | Core::Crypto::SHA256Hash hash{}; | ||
| 559 | mbedtls_sha256_ret(id.data(), id.size(), hash.data(), 0); | ||
| 560 | const auto dirname = fmt::format("000000{:02X}", hash[0]); | ||
| 561 | |||
| 562 | const auto dir2 = GetOrCreateDirectoryRelative(dir, dirname); | ||
| 563 | |||
| 564 | const auto res = dir2->DeleteFile(fmt::format("{}.nca", Common::HexToString(id, false))); | ||
| 565 | |||
| 566 | return res; | ||
| 567 | }; | ||
| 568 | |||
| 569 | // If an entry exists in the registered cache, remove it | ||
| 570 | if (HasEntry(title_id, ContentRecordType::Meta)) { | ||
| 571 | LOG_INFO(Loader, | ||
| 572 | "Previously installed entry (v{}) for title_id={:016X} detected! " | ||
| 573 | "Attempting to remove...", | ||
| 574 | GetEntryVersion(title_id).value_or(0), title_id); | ||
| 575 | // Get all the ncas associated with the current CNMT and delete them | ||
| 576 | const auto meta_old_id = | ||
| 577 | GetNcaIDFromMetadata(title_id, ContentRecordType::Meta).value_or(NcaID{}); | ||
| 578 | const auto program_id = | ||
| 579 | GetNcaIDFromMetadata(title_id, ContentRecordType::Program).value_or(NcaID{}); | ||
| 580 | const auto data_id = | ||
| 581 | GetNcaIDFromMetadata(title_id, ContentRecordType::Data).value_or(NcaID{}); | ||
| 582 | const auto control_id = | ||
| 583 | GetNcaIDFromMetadata(title_id, ContentRecordType::Control).value_or(NcaID{}); | ||
| 584 | const auto html_id = | ||
| 585 | GetNcaIDFromMetadata(title_id, ContentRecordType::HtmlDocument).value_or(NcaID{}); | ||
| 586 | const auto legal_id = | ||
| 587 | GetNcaIDFromMetadata(title_id, ContentRecordType::LegalInformation).value_or(NcaID{}); | ||
| 588 | |||
| 589 | delete_nca(meta_old_id); | ||
| 590 | delete_nca(program_id); | ||
| 591 | delete_nca(data_id); | ||
| 592 | delete_nca(control_id); | ||
| 593 | delete_nca(html_id); | ||
| 594 | delete_nca(legal_id); | ||
| 595 | return true; | ||
| 596 | } | ||
| 597 | return false; | ||
| 598 | } | ||
| 599 | |||
| 600 | InstallResult RegisteredCache::InstallEntry(const NSP& nsp, bool overwrite_if_exists, | 555 | InstallResult RegisteredCache::InstallEntry(const NSP& nsp, bool overwrite_if_exists, |
| 601 | const VfsCopyFunction& copy) { | 556 | const VfsCopyFunction& copy) { |
| 602 | const auto ncas = nsp.GetNCAsCollapsed(); | 557 | const auto ncas = nsp.GetNCAsCollapsed(); |
| @@ -692,6 +647,57 @@ InstallResult RegisteredCache::InstallEntry(const NCA& nca, TitleType type, | |||
| 692 | return RawInstallNCA(nca, copy, overwrite_if_exists, c_rec.nca_id); | 647 | return RawInstallNCA(nca, copy, overwrite_if_exists, c_rec.nca_id); |
| 693 | } | 648 | } |
| 694 | 649 | ||
| 650 | bool RegisteredCache::RemoveExistingEntry(u64 title_id) const { | ||
| 651 | const auto delete_nca = [this](const NcaID& id) { | ||
| 652 | const auto path = GetRelativePathFromNcaID(id, false, true, false); | ||
| 653 | |||
| 654 | const bool isFile = dir->GetFileRelative(path) != nullptr; | ||
| 655 | const bool isDir = dir->GetDirectoryRelative(path) != nullptr; | ||
| 656 | |||
| 657 | if (isFile) { | ||
| 658 | return dir->DeleteFile(path); | ||
| 659 | } else if (isDir) { | ||
| 660 | return dir->DeleteSubdirectoryRecursive(path); | ||
| 661 | } | ||
| 662 | |||
| 663 | return false; | ||
| 664 | }; | ||
| 665 | |||
| 666 | // If an entry exists in the registered cache, remove it | ||
| 667 | if (HasEntry(title_id, ContentRecordType::Meta)) { | ||
| 668 | LOG_INFO(Loader, | ||
| 669 | "Previously installed entry (v{}) for title_id={:016X} detected! " | ||
| 670 | "Attempting to remove...", | ||
| 671 | GetEntryVersion(title_id).value_or(0), title_id); | ||
| 672 | |||
| 673 | // Get all the ncas associated with the current CNMT and delete them | ||
| 674 | const auto meta_old_id = | ||
| 675 | GetNcaIDFromMetadata(title_id, ContentRecordType::Meta).value_or(NcaID{}); | ||
| 676 | const auto program_id = | ||
| 677 | GetNcaIDFromMetadata(title_id, ContentRecordType::Program).value_or(NcaID{}); | ||
| 678 | const auto data_id = | ||
| 679 | GetNcaIDFromMetadata(title_id, ContentRecordType::Data).value_or(NcaID{}); | ||
| 680 | const auto control_id = | ||
| 681 | GetNcaIDFromMetadata(title_id, ContentRecordType::Control).value_or(NcaID{}); | ||
| 682 | const auto html_id = | ||
| 683 | GetNcaIDFromMetadata(title_id, ContentRecordType::HtmlDocument).value_or(NcaID{}); | ||
| 684 | const auto legal_id = | ||
| 685 | GetNcaIDFromMetadata(title_id, ContentRecordType::LegalInformation).value_or(NcaID{}); | ||
| 686 | |||
| 687 | const auto deleted_meta = delete_nca(meta_old_id); | ||
| 688 | const auto deleted_program = delete_nca(program_id); | ||
| 689 | const auto deleted_data = delete_nca(data_id); | ||
| 690 | const auto deleted_control = delete_nca(control_id); | ||
| 691 | const auto deleted_html = delete_nca(html_id); | ||
| 692 | const auto deleted_legal = delete_nca(legal_id); | ||
| 693 | |||
| 694 | return deleted_meta && (deleted_meta || deleted_program || deleted_data || | ||
| 695 | deleted_control || deleted_html || deleted_legal); | ||
| 696 | } | ||
| 697 | |||
| 698 | return false; | ||
| 699 | } | ||
| 700 | |||
| 695 | InstallResult RegisteredCache::RawInstallNCA(const NCA& nca, const VfsCopyFunction& copy, | 701 | InstallResult RegisteredCache::RawInstallNCA(const NCA& nca, const VfsCopyFunction& copy, |
| 696 | bool overwrite_if_exists, | 702 | bool overwrite_if_exists, |
| 697 | std::optional<NcaID> override_id) { | 703 | std::optional<NcaID> override_id) { |
diff --git a/src/core/file_sys/registered_cache.h b/src/core/file_sys/registered_cache.h index 29cf0d40c..ec1d54f27 100644 --- a/src/core/file_sys/registered_cache.h +++ b/src/core/file_sys/registered_cache.h | |||
| @@ -155,9 +155,6 @@ public: | |||
| 155 | std::optional<TitleType> title_type = {}, std::optional<ContentRecordType> record_type = {}, | 155 | std::optional<TitleType> title_type = {}, std::optional<ContentRecordType> record_type = {}, |
| 156 | std::optional<u64> title_id = {}) const override; | 156 | std::optional<u64> title_id = {}) const override; |
| 157 | 157 | ||
| 158 | // Removes an existing entry based on title id | ||
| 159 | bool RemoveExistingEntry(u64 title_id); | ||
| 160 | |||
| 161 | // Raw copies all the ncas from the xci/nsp to the csache. Does some quick checks to make sure | 158 | // Raw copies all the ncas from the xci/nsp to the csache. Does some quick checks to make sure |
| 162 | // there is a meta NCA and all of them are accessible. | 159 | // there is a meta NCA and all of them are accessible. |
| 163 | InstallResult InstallEntry(const XCI& xci, bool overwrite_if_exists = false, | 160 | InstallResult InstallEntry(const XCI& xci, bool overwrite_if_exists = false, |
| @@ -172,6 +169,9 @@ public: | |||
| 172 | InstallResult InstallEntry(const NCA& nca, TitleType type, bool overwrite_if_exists = false, | 169 | InstallResult InstallEntry(const NCA& nca, TitleType type, bool overwrite_if_exists = false, |
| 173 | const VfsCopyFunction& copy = &VfsRawCopy); | 170 | const VfsCopyFunction& copy = &VfsRawCopy); |
| 174 | 171 | ||
| 172 | // Removes an existing entry based on title id | ||
| 173 | bool RemoveExistingEntry(u64 title_id) const; | ||
| 174 | |||
| 175 | private: | 175 | private: |
| 176 | template <typename T> | 176 | template <typename T> |
| 177 | void IterateAllMetadata(std::vector<T>& out, | 177 | void IterateAllMetadata(std::vector<T>& out, |
diff --git a/src/core/file_sys/savedata_factory.cpp b/src/core/file_sys/savedata_factory.cpp index adfd2c1a4..ba4efee3a 100644 --- a/src/core/file_sys/savedata_factory.cpp +++ b/src/core/file_sys/savedata_factory.cpp | |||
| @@ -17,23 +17,23 @@ constexpr char SAVE_DATA_SIZE_FILENAME[] = ".yuzu_save_size"; | |||
| 17 | 17 | ||
| 18 | namespace { | 18 | namespace { |
| 19 | 19 | ||
| 20 | void PrintSaveDataDescriptorWarnings(SaveDataDescriptor meta) { | 20 | void PrintSaveDataAttributeWarnings(SaveDataAttribute meta) { |
| 21 | if (meta.type == SaveDataType::SystemSaveData || meta.type == SaveDataType::SaveData) { | 21 | if (meta.type == SaveDataType::SystemSaveData || meta.type == SaveDataType::SaveData) { |
| 22 | if (meta.zero_1 != 0) { | 22 | if (meta.zero_1 != 0) { |
| 23 | LOG_WARNING(Service_FS, | 23 | LOG_WARNING(Service_FS, |
| 24 | "Possibly incorrect SaveDataDescriptor, type is " | 24 | "Possibly incorrect SaveDataAttribute, type is " |
| 25 | "SystemSaveData||SaveData but offset 0x28 is non-zero ({:016X}).", | 25 | "SystemSaveData||SaveData but offset 0x28 is non-zero ({:016X}).", |
| 26 | meta.zero_1); | 26 | meta.zero_1); |
| 27 | } | 27 | } |
| 28 | if (meta.zero_2 != 0) { | 28 | if (meta.zero_2 != 0) { |
| 29 | LOG_WARNING(Service_FS, | 29 | LOG_WARNING(Service_FS, |
| 30 | "Possibly incorrect SaveDataDescriptor, type is " | 30 | "Possibly incorrect SaveDataAttribute, type is " |
| 31 | "SystemSaveData||SaveData but offset 0x30 is non-zero ({:016X}).", | 31 | "SystemSaveData||SaveData but offset 0x30 is non-zero ({:016X}).", |
| 32 | meta.zero_2); | 32 | meta.zero_2); |
| 33 | } | 33 | } |
| 34 | if (meta.zero_3 != 0) { | 34 | if (meta.zero_3 != 0) { |
| 35 | LOG_WARNING(Service_FS, | 35 | LOG_WARNING(Service_FS, |
| 36 | "Possibly incorrect SaveDataDescriptor, type is " | 36 | "Possibly incorrect SaveDataAttribute, type is " |
| 37 | "SystemSaveData||SaveData but offset 0x38 is non-zero ({:016X}).", | 37 | "SystemSaveData||SaveData but offset 0x38 is non-zero ({:016X}).", |
| 38 | meta.zero_3); | 38 | meta.zero_3); |
| 39 | } | 39 | } |
| @@ -41,33 +41,32 @@ void PrintSaveDataDescriptorWarnings(SaveDataDescriptor meta) { | |||
| 41 | 41 | ||
| 42 | if (meta.type == SaveDataType::SystemSaveData && meta.title_id != 0) { | 42 | if (meta.type == SaveDataType::SystemSaveData && meta.title_id != 0) { |
| 43 | LOG_WARNING(Service_FS, | 43 | LOG_WARNING(Service_FS, |
| 44 | "Possibly incorrect SaveDataDescriptor, type is SystemSaveData but title_id is " | 44 | "Possibly incorrect SaveDataAttribute, type is SystemSaveData but title_id is " |
| 45 | "non-zero ({:016X}).", | 45 | "non-zero ({:016X}).", |
| 46 | meta.title_id); | 46 | meta.title_id); |
| 47 | } | 47 | } |
| 48 | 48 | ||
| 49 | if (meta.type == SaveDataType::DeviceSaveData && meta.user_id != u128{0, 0}) { | 49 | if (meta.type == SaveDataType::DeviceSaveData && meta.user_id != u128{0, 0}) { |
| 50 | LOG_WARNING(Service_FS, | 50 | LOG_WARNING(Service_FS, |
| 51 | "Possibly incorrect SaveDataDescriptor, type is DeviceSaveData but user_id is " | 51 | "Possibly incorrect SaveDataAttribute, type is DeviceSaveData but user_id is " |
| 52 | "non-zero ({:016X}{:016X})", | 52 | "non-zero ({:016X}{:016X})", |
| 53 | meta.user_id[1], meta.user_id[0]); | 53 | meta.user_id[1], meta.user_id[0]); |
| 54 | } | 54 | } |
| 55 | } | 55 | } |
| 56 | 56 | ||
| 57 | bool ShouldSaveDataBeAutomaticallyCreated(SaveDataSpaceId space, const SaveDataDescriptor& desc) { | 57 | bool ShouldSaveDataBeAutomaticallyCreated(SaveDataSpaceId space, const SaveDataAttribute& attr) { |
| 58 | return desc.type == SaveDataType::CacheStorage || desc.type == SaveDataType::TemporaryStorage || | 58 | return attr.type == SaveDataType::CacheStorage || attr.type == SaveDataType::TemporaryStorage || |
| 59 | (space == SaveDataSpaceId::NandUser && ///< Normal Save Data -- Current Title & User | 59 | (space == SaveDataSpaceId::NandUser && ///< Normal Save Data -- Current Title & User |
| 60 | (desc.type == SaveDataType::SaveData || desc.type == SaveDataType::DeviceSaveData) && | 60 | (attr.type == SaveDataType::SaveData || attr.type == SaveDataType::DeviceSaveData) && |
| 61 | desc.title_id == 0 && desc.save_id == 0); | 61 | attr.title_id == 0 && attr.save_id == 0); |
| 62 | } | 62 | } |
| 63 | 63 | ||
| 64 | } // Anonymous namespace | 64 | } // Anonymous namespace |
| 65 | 65 | ||
| 66 | std::string SaveDataDescriptor::DebugInfo() const { | 66 | std::string SaveDataAttribute::DebugInfo() const { |
| 67 | return fmt::format("[type={:02X}, title_id={:016X}, user_id={:016X}{:016X}, " | 67 | return fmt::format("[title_id={:016X}, user_id={:016X}{:016X}, save_id={:016X}, type={:02X}, " |
| 68 | "save_id={:016X}, " | ||
| 69 | "rank={}, index={}]", | 68 | "rank={}, index={}]", |
| 70 | static_cast<u8>(type), title_id, user_id[1], user_id[0], save_id, | 69 | title_id, user_id[1], user_id[0], save_id, static_cast<u8>(type), |
| 71 | static_cast<u8>(rank), index); | 70 | static_cast<u8>(rank), index); |
| 72 | } | 71 | } |
| 73 | 72 | ||
| @@ -80,8 +79,8 @@ SaveDataFactory::SaveDataFactory(VirtualDir save_directory) : dir(std::move(save | |||
| 80 | SaveDataFactory::~SaveDataFactory() = default; | 79 | SaveDataFactory::~SaveDataFactory() = default; |
| 81 | 80 | ||
| 82 | ResultVal<VirtualDir> SaveDataFactory::Create(SaveDataSpaceId space, | 81 | ResultVal<VirtualDir> SaveDataFactory::Create(SaveDataSpaceId space, |
| 83 | const SaveDataDescriptor& meta) const { | 82 | const SaveDataAttribute& meta) const { |
| 84 | PrintSaveDataDescriptorWarnings(meta); | 83 | PrintSaveDataAttributeWarnings(meta); |
| 85 | 84 | ||
| 86 | const auto save_directory = | 85 | const auto save_directory = |
| 87 | GetFullPath(space, meta.type, meta.title_id, meta.user_id, meta.save_id); | 86 | GetFullPath(space, meta.type, meta.title_id, meta.user_id, meta.save_id); |
| @@ -98,7 +97,7 @@ ResultVal<VirtualDir> SaveDataFactory::Create(SaveDataSpaceId space, | |||
| 98 | } | 97 | } |
| 99 | 98 | ||
| 100 | ResultVal<VirtualDir> SaveDataFactory::Open(SaveDataSpaceId space, | 99 | ResultVal<VirtualDir> SaveDataFactory::Open(SaveDataSpaceId space, |
| 101 | const SaveDataDescriptor& meta) const { | 100 | const SaveDataAttribute& meta) const { |
| 102 | 101 | ||
| 103 | const auto save_directory = | 102 | const auto save_directory = |
| 104 | GetFullPath(space, meta.type, meta.title_id, meta.user_id, meta.save_id); | 103 | GetFullPath(space, meta.type, meta.title_id, meta.user_id, meta.save_id); |
diff --git a/src/core/file_sys/savedata_factory.h b/src/core/file_sys/savedata_factory.h index 991e57aa1..6625bbbd8 100644 --- a/src/core/file_sys/savedata_factory.h +++ b/src/core/file_sys/savedata_factory.h | |||
| @@ -21,6 +21,7 @@ enum class SaveDataSpaceId : u8 { | |||
| 21 | TemporaryStorage = 3, | 21 | TemporaryStorage = 3, |
| 22 | SdCardUser = 4, | 22 | SdCardUser = 4, |
| 23 | ProperSystem = 100, | 23 | ProperSystem = 100, |
| 24 | SafeMode = 101, | ||
| 24 | }; | 25 | }; |
| 25 | 26 | ||
| 26 | enum class SaveDataType : u8 { | 27 | enum class SaveDataType : u8 { |
| @@ -30,28 +31,50 @@ enum class SaveDataType : u8 { | |||
| 30 | DeviceSaveData = 3, | 31 | DeviceSaveData = 3, |
| 31 | TemporaryStorage = 4, | 32 | TemporaryStorage = 4, |
| 32 | CacheStorage = 5, | 33 | CacheStorage = 5, |
| 34 | SystemBcat = 6, | ||
| 33 | }; | 35 | }; |
| 34 | 36 | ||
| 35 | enum class SaveDataRank : u8 { | 37 | enum class SaveDataRank : u8 { |
| 36 | Primary, | 38 | Primary = 0, |
| 37 | Secondary, | 39 | Secondary = 1, |
| 38 | }; | 40 | }; |
| 39 | 41 | ||
| 40 | struct SaveDataDescriptor { | 42 | enum class SaveDataFlags : u32 { |
| 41 | u64_le title_id; | 43 | None = (0 << 0), |
| 44 | KeepAfterResettingSystemSaveData = (1 << 0), | ||
| 45 | KeepAfterRefurbishment = (1 << 1), | ||
| 46 | KeepAfterResettingSystemSaveDataWithoutUserSaveData = (1 << 2), | ||
| 47 | NeedsSecureDelete = (1 << 3), | ||
| 48 | }; | ||
| 49 | |||
| 50 | struct SaveDataAttribute { | ||
| 51 | u64 title_id; | ||
| 42 | u128 user_id; | 52 | u128 user_id; |
| 43 | u64_le save_id; | 53 | u64 save_id; |
| 44 | SaveDataType type; | 54 | SaveDataType type; |
| 45 | SaveDataRank rank; | 55 | SaveDataRank rank; |
| 46 | u16_le index; | 56 | u16 index; |
| 47 | INSERT_PADDING_BYTES(4); | 57 | INSERT_PADDING_BYTES(4); |
| 48 | u64_le zero_1; | 58 | u64 zero_1; |
| 49 | u64_le zero_2; | 59 | u64 zero_2; |
| 50 | u64_le zero_3; | 60 | u64 zero_3; |
| 51 | 61 | ||
| 52 | std::string DebugInfo() const; | 62 | std::string DebugInfo() const; |
| 53 | }; | 63 | }; |
| 54 | static_assert(sizeof(SaveDataDescriptor) == 0x40, "SaveDataDescriptor has incorrect size."); | 64 | static_assert(sizeof(SaveDataAttribute) == 0x40, "SaveDataAttribute has incorrect size."); |
| 65 | |||
| 66 | struct SaveDataExtraData { | ||
| 67 | SaveDataAttribute attr; | ||
| 68 | u64 owner_id; | ||
| 69 | s64 timestamp; | ||
| 70 | SaveDataFlags flags; | ||
| 71 | INSERT_PADDING_BYTES(4); | ||
| 72 | s64 available_size; | ||
| 73 | s64 journal_size; | ||
| 74 | s64 commit_id; | ||
| 75 | std::array<u8, 0x190> unused; | ||
| 76 | }; | ||
| 77 | static_assert(sizeof(SaveDataExtraData) == 0x200, "SaveDataExtraData has incorrect size."); | ||
| 55 | 78 | ||
| 56 | struct SaveDataSize { | 79 | struct SaveDataSize { |
| 57 | u64 normal; | 80 | u64 normal; |
| @@ -64,8 +87,8 @@ public: | |||
| 64 | explicit SaveDataFactory(VirtualDir dir); | 87 | explicit SaveDataFactory(VirtualDir dir); |
| 65 | ~SaveDataFactory(); | 88 | ~SaveDataFactory(); |
| 66 | 89 | ||
| 67 | ResultVal<VirtualDir> Create(SaveDataSpaceId space, const SaveDataDescriptor& meta) const; | 90 | ResultVal<VirtualDir> Create(SaveDataSpaceId space, const SaveDataAttribute& meta) const; |
| 68 | ResultVal<VirtualDir> Open(SaveDataSpaceId space, const SaveDataDescriptor& meta) const; | 91 | ResultVal<VirtualDir> Open(SaveDataSpaceId space, const SaveDataAttribute& meta) const; |
| 69 | 92 | ||
| 70 | VirtualDir GetSaveDataSpaceDirectory(SaveDataSpaceId space) const; | 93 | VirtualDir GetSaveDataSpaceDirectory(SaveDataSpaceId space) const; |
| 71 | 94 | ||
diff --git a/src/core/file_sys/system_archive/time_zone_binary.cpp b/src/core/file_sys/system_archive/time_zone_binary.cpp index 9806bd197..d1de63f20 100644 --- a/src/core/file_sys/system_archive/time_zone_binary.cpp +++ b/src/core/file_sys/system_archive/time_zone_binary.cpp | |||
| @@ -2,6 +2,9 @@ | |||
| 2 | // Licensed under GPLv2 or any later version | 2 | // Licensed under GPLv2 or any later version |
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include <array> | ||
| 6 | #include <vector> | ||
| 7 | |||
| 5 | #include "common/swap.h" | 8 | #include "common/swap.h" |
| 6 | #include "core/file_sys/system_archive/time_zone_binary.h" | 9 | #include "core/file_sys/system_archive/time_zone_binary.h" |
| 7 | #include "core/file_sys/vfs_vector.h" | 10 | #include "core/file_sys/vfs_vector.h" |
| @@ -615,31 +618,36 @@ static constexpr std::array<u8, 9633> LOCATION_NAMES{ | |||
| 615 | 0x0a}; | 618 | 0x0a}; |
| 616 | 619 | ||
| 617 | static VirtualFile GenerateDefaultTimeZoneFile() { | 620 | static VirtualFile GenerateDefaultTimeZoneFile() { |
| 618 | struct { | 621 | struct TimeZoneInfo { |
| 619 | s64_be at; | 622 | s64_be at; |
| 620 | INSERT_PADDING_BYTES(7); | 623 | std::array<u8, 7> padding1; |
| 621 | std::array<char, 4> time_zone_chars; | 624 | std::array<char, 4> time_zone_chars; |
| 622 | INSERT_PADDING_BYTES(2); | 625 | std::array<u8, 2> padding2; |
| 623 | std::array<char, 6> time_zone_name; | 626 | std::array<char, 6> time_zone_name; |
| 624 | } time_zone_info{}; | 627 | }; |
| 625 | 628 | ||
| 626 | const VirtualFile file{std::make_shared<VectorVfsFile>( | 629 | VirtualFile file{std::make_shared<VectorVfsFile>( |
| 627 | std::vector<u8>(sizeof(Service::Time::TimeZone::TzifHeader) + sizeof(time_zone_info)), | 630 | std::vector<u8>(sizeof(Service::Time::TimeZone::TzifHeader) + sizeof(TimeZoneInfo)), |
| 628 | "GMT")}; | 631 | "GMT")}; |
| 629 | 632 | ||
| 630 | Service::Time::TimeZone::TzifHeader header{}; | 633 | const Service::Time::TimeZone::TzifHeader header{ |
| 631 | header.magic = 0x545a6966; | 634 | .magic = 0x545a6966, |
| 632 | header.version = 0x32; | 635 | .version = 0x32, |
| 633 | header.ttis_gmt_count = 0x1; | 636 | .ttis_gmt_count = 1, |
| 634 | header.ttis_std_count = 0x1; | 637 | .ttis_std_count = 1, |
| 635 | header.time_count = 0x1; | 638 | .time_count = 1, |
| 636 | header.type_count = 0x1; | 639 | .type_count = 1, |
| 637 | header.char_count = 0x4; | 640 | .char_count = 4, |
| 641 | }; | ||
| 638 | file->WriteObject(header, 0); | 642 | file->WriteObject(header, 0); |
| 639 | 643 | ||
| 640 | time_zone_info.at = 0xf8; | 644 | const TimeZoneInfo time_zone_info{ |
| 641 | time_zone_info.time_zone_chars = {'G', 'M', 'T', '\0'}; | 645 | .at = 0xf8, |
| 642 | time_zone_info.time_zone_name = {'\n', 'G', 'M', 'T', '0', '\n'}; | 646 | .padding1 = {}, |
| 647 | .time_zone_chars = {'G', 'M', 'T', '\0'}, | ||
| 648 | .padding2 = {}, | ||
| 649 | .time_zone_name = {'\n', 'G', 'M', 'T', '0', '\n'}, | ||
| 650 | }; | ||
| 643 | file->WriteObject(time_zone_info, sizeof(Service::Time::TimeZone::TzifHeader)); | 651 | file->WriteObject(time_zone_info, sizeof(Service::Time::TimeZone::TzifHeader)); |
| 644 | 652 | ||
| 645 | return file; | 653 | return file; |
diff --git a/src/core/file_sys/vfs_real.cpp b/src/core/file_sys/vfs_real.cpp index 96ce5957c..0db0091f6 100644 --- a/src/core/file_sys/vfs_real.cpp +++ b/src/core/file_sys/vfs_real.cpp | |||
| @@ -18,20 +18,22 @@ static std::string ModeFlagsToString(Mode mode) { | |||
| 18 | std::string mode_str; | 18 | std::string mode_str; |
| 19 | 19 | ||
| 20 | // Calculate the correct open mode for the file. | 20 | // Calculate the correct open mode for the file. |
| 21 | if (mode & Mode::Read && mode & Mode::Write) { | 21 | if (True(mode & Mode::Read) && True(mode & Mode::Write)) { |
| 22 | if (mode & Mode::Append) | 22 | if (True(mode & Mode::Append)) { |
| 23 | mode_str = "a+"; | 23 | mode_str = "a+"; |
| 24 | else | 24 | } else { |
| 25 | mode_str = "r+"; | 25 | mode_str = "r+"; |
| 26 | } | ||
| 26 | } else { | 27 | } else { |
| 27 | if (mode & Mode::Read) | 28 | if (True(mode & Mode::Read)) { |
| 28 | mode_str = "r"; | 29 | mode_str = "r"; |
| 29 | else if (mode & Mode::Append) | 30 | } else if (True(mode & Mode::Append)) { |
| 30 | mode_str = "a"; | 31 | mode_str = "a"; |
| 31 | else if (mode & Mode::Write) | 32 | } else if (True(mode & Mode::Write)) { |
| 32 | mode_str = "w"; | 33 | mode_str = "w"; |
| 33 | else | 34 | } else { |
| 34 | UNREACHABLE_MSG("Invalid file open mode: {:02X}", static_cast<u8>(mode)); | 35 | UNREACHABLE_MSG("Invalid file open mode: {:02X}", static_cast<u8>(mode)); |
| 36 | } | ||
| 35 | } | 37 | } |
| 36 | 38 | ||
| 37 | mode_str += "b"; | 39 | mode_str += "b"; |
| @@ -73,8 +75,9 @@ VirtualFile RealVfsFilesystem::OpenFile(std::string_view path_, Mode perms) { | |||
| 73 | } | 75 | } |
| 74 | } | 76 | } |
| 75 | 77 | ||
| 76 | if (!FileUtil::Exists(path) && (perms & Mode::WriteAppend) != 0) | 78 | if (!FileUtil::Exists(path) && True(perms & Mode::WriteAppend)) { |
| 77 | FileUtil::CreateEmptyFile(path); | 79 | FileUtil::CreateEmptyFile(path); |
| 80 | } | ||
| 78 | 81 | ||
| 79 | auto backing = std::make_shared<FileUtil::IOFile>(path, ModeFlagsToString(perms).c_str()); | 82 | auto backing = std::make_shared<FileUtil::IOFile>(path, ModeFlagsToString(perms).c_str()); |
| 80 | cache[path] = backing; | 83 | cache[path] = backing; |
| @@ -247,11 +250,11 @@ std::shared_ptr<VfsDirectory> RealVfsFile::GetContainingDirectory() const { | |||
| 247 | } | 250 | } |
| 248 | 251 | ||
| 249 | bool RealVfsFile::IsWritable() const { | 252 | bool RealVfsFile::IsWritable() const { |
| 250 | return (perms & Mode::WriteAppend) != 0; | 253 | return True(perms & Mode::WriteAppend); |
| 251 | } | 254 | } |
| 252 | 255 | ||
| 253 | bool RealVfsFile::IsReadable() const { | 256 | bool RealVfsFile::IsReadable() const { |
| 254 | return (perms & Mode::ReadWrite) != 0; | 257 | return True(perms & Mode::ReadWrite); |
| 255 | } | 258 | } |
| 256 | 259 | ||
| 257 | std::size_t RealVfsFile::Read(u8* data, std::size_t length, std::size_t offset) const { | 260 | std::size_t RealVfsFile::Read(u8* data, std::size_t length, std::size_t offset) const { |
| @@ -319,8 +322,9 @@ RealVfsDirectory::RealVfsDirectory(RealVfsFilesystem& base_, const std::string& | |||
| 319 | path_components(FileUtil::SplitPathComponents(path)), | 322 | path_components(FileUtil::SplitPathComponents(path)), |
| 320 | parent_components(FileUtil::SliceVector(path_components, 0, path_components.size() - 1)), | 323 | parent_components(FileUtil::SliceVector(path_components, 0, path_components.size() - 1)), |
| 321 | perms(perms_) { | 324 | perms(perms_) { |
| 322 | if (!FileUtil::Exists(path) && perms & Mode::WriteAppend) | 325 | if (!FileUtil::Exists(path) && True(perms & Mode::WriteAppend)) { |
| 323 | FileUtil::CreateDir(path); | 326 | FileUtil::CreateDir(path); |
| 327 | } | ||
| 324 | } | 328 | } |
| 325 | 329 | ||
| 326 | RealVfsDirectory::~RealVfsDirectory() = default; | 330 | RealVfsDirectory::~RealVfsDirectory() = default; |
| @@ -371,11 +375,11 @@ std::vector<std::shared_ptr<VfsDirectory>> RealVfsDirectory::GetSubdirectories() | |||
| 371 | } | 375 | } |
| 372 | 376 | ||
| 373 | bool RealVfsDirectory::IsWritable() const { | 377 | bool RealVfsDirectory::IsWritable() const { |
| 374 | return (perms & Mode::WriteAppend) != 0; | 378 | return True(perms & Mode::WriteAppend); |
| 375 | } | 379 | } |
| 376 | 380 | ||
| 377 | bool RealVfsDirectory::IsReadable() const { | 381 | bool RealVfsDirectory::IsReadable() const { |
| 378 | return (perms & Mode::ReadWrite) != 0; | 382 | return True(perms & Mode::ReadWrite); |
| 379 | } | 383 | } |
| 380 | 384 | ||
| 381 | std::string RealVfsDirectory::GetName() const { | 385 | std::string RealVfsDirectory::GetName() const { |
diff --git a/src/core/file_sys/xts_archive.cpp b/src/core/file_sys/xts_archive.cpp index 86e06ccb9..81413c684 100644 --- a/src/core/file_sys/xts_archive.cpp +++ b/src/core/file_sys/xts_archive.cpp | |||
| @@ -70,14 +70,18 @@ NAX::NAX(VirtualFile file_, std::array<u8, 0x10> nca_id) | |||
| 70 | NAX::~NAX() = default; | 70 | NAX::~NAX() = default; |
| 71 | 71 | ||
| 72 | Loader::ResultStatus NAX::Parse(std::string_view path) { | 72 | Loader::ResultStatus NAX::Parse(std::string_view path) { |
| 73 | if (file->ReadObject(header.get()) != sizeof(NAXHeader)) | 73 | if (file == nullptr) { |
| 74 | return Loader::ResultStatus::ErrorNullFile; | ||
| 75 | } | ||
| 76 | if (file->ReadObject(header.get()) != sizeof(NAXHeader)) { | ||
| 74 | return Loader::ResultStatus::ErrorBadNAXHeader; | 77 | return Loader::ResultStatus::ErrorBadNAXHeader; |
| 75 | 78 | } | |
| 76 | if (header->magic != Common::MakeMagic('N', 'A', 'X', '0')) | 79 | if (header->magic != Common::MakeMagic('N', 'A', 'X', '0')) { |
| 77 | return Loader::ResultStatus::ErrorBadNAXHeader; | 80 | return Loader::ResultStatus::ErrorBadNAXHeader; |
| 78 | 81 | } | |
| 79 | if (file->GetSize() < NAX_HEADER_PADDING_SIZE + header->file_size) | 82 | if (file->GetSize() < NAX_HEADER_PADDING_SIZE + header->file_size) { |
| 80 | return Loader::ResultStatus::ErrorIncorrectNAXFileSize; | 83 | return Loader::ResultStatus::ErrorIncorrectNAXFileSize; |
| 84 | } | ||
| 81 | 85 | ||
| 82 | keys.DeriveSDSeedLazy(); | 86 | keys.DeriveSDSeedLazy(); |
| 83 | std::array<Core::Crypto::Key256, 2> sd_keys{}; | 87 | std::array<Core::Crypto::Key256, 2> sd_keys{}; |
diff --git a/src/core/hle/kernel/hle_ipc.h b/src/core/hle/kernel/hle_ipc.h index b31673928..f3277b766 100644 --- a/src/core/hle/kernel/hle_ipc.h +++ b/src/core/hle/kernel/hle_ipc.h | |||
| @@ -13,6 +13,7 @@ | |||
| 13 | #include <vector> | 13 | #include <vector> |
| 14 | #include <boost/container/small_vector.hpp> | 14 | #include <boost/container/small_vector.hpp> |
| 15 | #include "common/common_types.h" | 15 | #include "common/common_types.h" |
| 16 | #include "common/concepts.h" | ||
| 16 | #include "common/swap.h" | 17 | #include "common/swap.h" |
| 17 | #include "core/hle/ipc.h" | 18 | #include "core/hle/ipc.h" |
| 18 | #include "core/hle/kernel/object.h" | 19 | #include "core/hle/kernel/object.h" |
| @@ -193,23 +194,24 @@ public: | |||
| 193 | 194 | ||
| 194 | /* Helper function to write a buffer using the appropriate buffer descriptor | 195 | /* Helper function to write a buffer using the appropriate buffer descriptor |
| 195 | * | 196 | * |
| 196 | * @tparam ContiguousContainer an arbitrary container that satisfies the | 197 | * @tparam T an arbitrary container that satisfies the |
| 197 | * ContiguousContainer concept in the C++ standard library. | 198 | * ContiguousContainer concept in the C++ standard library or a trivially copyable type. |
| 198 | * | 199 | * |
| 199 | * @param container The container to write the data of into a buffer. | 200 | * @param data The container/data to write into a buffer. |
| 200 | * @param buffer_index The buffer in particular to write to. | 201 | * @param buffer_index The buffer in particular to write to. |
| 201 | */ | 202 | */ |
| 202 | template <typename ContiguousContainer, | 203 | template <typename T, typename = std::enable_if_t<!std::is_pointer_v<T>>> |
| 203 | typename = std::enable_if_t<!std::is_pointer_v<ContiguousContainer>>> | 204 | std::size_t WriteBuffer(const T& data, std::size_t buffer_index = 0) const { |
| 204 | std::size_t WriteBuffer(const ContiguousContainer& container, | 205 | if constexpr (Common::IsSTLContainer<T>) { |
| 205 | std::size_t buffer_index = 0) const { | 206 | using ContiguousType = typename T::value_type; |
| 206 | using ContiguousType = typename ContiguousContainer::value_type; | 207 | static_assert(std::is_trivially_copyable_v<ContiguousType>, |
| 207 | 208 | "Container to WriteBuffer must contain trivially copyable objects"); | |
| 208 | static_assert(std::is_trivially_copyable_v<ContiguousType>, | 209 | return WriteBuffer(std::data(data), std::size(data) * sizeof(ContiguousType), |
| 209 | "Container to WriteBuffer must contain trivially copyable objects"); | 210 | buffer_index); |
| 210 | 211 | } else { | |
| 211 | return WriteBuffer(std::data(container), std::size(container) * sizeof(ContiguousType), | 212 | static_assert(std::is_trivially_copyable_v<T>, "T must be trivially copyable"); |
| 212 | buffer_index); | 213 | return WriteBuffer(&data, sizeof(T), buffer_index); |
| 214 | } | ||
| 213 | } | 215 | } |
| 214 | 216 | ||
| 215 | /// Helper function to get the size of the input buffer | 217 | /// Helper function to get the size of the input buffer |
diff --git a/src/core/hle/service/acc/acc.cpp b/src/core/hle/service/acc/acc.cpp index 8ac856ec3..63e4aeca0 100644 --- a/src/core/hle/service/acc/acc.cpp +++ b/src/core/hle/service/acc/acc.cpp | |||
| @@ -286,9 +286,7 @@ protected: | |||
| 286 | ProfileBase profile_base{}; | 286 | ProfileBase profile_base{}; |
| 287 | ProfileData data{}; | 287 | ProfileData data{}; |
| 288 | if (profile_manager.GetProfileBaseAndData(user_id, profile_base, data)) { | 288 | if (profile_manager.GetProfileBaseAndData(user_id, profile_base, data)) { |
| 289 | std::array<u8, sizeof(ProfileData)> raw_data; | 289 | ctx.WriteBuffer(data); |
| 290 | std::memcpy(raw_data.data(), &data, sizeof(ProfileData)); | ||
| 291 | ctx.WriteBuffer(raw_data); | ||
| 292 | IPC::ResponseBuilder rb{ctx, 16}; | 290 | IPC::ResponseBuilder rb{ctx, 16}; |
| 293 | rb.Push(RESULT_SUCCESS); | 291 | rb.Push(RESULT_SUCCESS); |
| 294 | rb.PushRaw(profile_base); | 292 | rb.PushRaw(profile_base); |
| @@ -333,7 +331,7 @@ protected: | |||
| 333 | std::vector<u8> buffer(size); | 331 | std::vector<u8> buffer(size); |
| 334 | image.ReadBytes(buffer.data(), buffer.size()); | 332 | image.ReadBytes(buffer.data(), buffer.size()); |
| 335 | 333 | ||
| 336 | ctx.WriteBuffer(buffer.data(), buffer.size()); | 334 | ctx.WriteBuffer(buffer); |
| 337 | rb.Push<u32>(size); | 335 | rb.Push<u32>(size); |
| 338 | } | 336 | } |
| 339 | 337 | ||
diff --git a/src/core/hle/service/acc/profile_manager.cpp b/src/core/hle/service/acc/profile_manager.cpp index eb8c81645..a98d57b5c 100644 --- a/src/core/hle/service/acc/profile_manager.cpp +++ b/src/core/hle/service/acc/profile_manager.cpp | |||
| @@ -58,7 +58,7 @@ ProfileManager::~ProfileManager() { | |||
| 58 | /// internal management of the users profiles | 58 | /// internal management of the users profiles |
| 59 | std::optional<std::size_t> ProfileManager::AddToProfiles(const ProfileInfo& profile) { | 59 | std::optional<std::size_t> ProfileManager::AddToProfiles(const ProfileInfo& profile) { |
| 60 | if (user_count >= MAX_USERS) { | 60 | if (user_count >= MAX_USERS) { |
| 61 | return {}; | 61 | return std::nullopt; |
| 62 | } | 62 | } |
| 63 | profiles[user_count] = profile; | 63 | profiles[user_count] = profile; |
| 64 | return user_count++; | 64 | return user_count++; |
| @@ -101,13 +101,14 @@ ResultCode ProfileManager::CreateNewUser(UUID uuid, const ProfileUsername& usern | |||
| 101 | [&uuid](const ProfileInfo& profile) { return uuid == profile.user_uuid; })) { | 101 | [&uuid](const ProfileInfo& profile) { return uuid == profile.user_uuid; })) { |
| 102 | return ERROR_USER_ALREADY_EXISTS; | 102 | return ERROR_USER_ALREADY_EXISTS; |
| 103 | } | 103 | } |
| 104 | ProfileInfo profile; | 104 | |
| 105 | profile.user_uuid = uuid; | 105 | return AddUser({ |
| 106 | profile.username = username; | 106 | .user_uuid = uuid, |
| 107 | profile.data = {}; | 107 | .username = username, |
| 108 | profile.creation_time = 0x0; | 108 | .creation_time = 0, |
| 109 | profile.is_open = false; | 109 | .data = {}, |
| 110 | return AddUser(profile); | 110 | .is_open = false, |
| 111 | }); | ||
| 111 | } | 112 | } |
| 112 | 113 | ||
| 113 | /// Creates a new user on the system. This function allows a much simpler method of registration | 114 | /// Creates a new user on the system. This function allows a much simpler method of registration |
| @@ -126,7 +127,7 @@ ResultCode ProfileManager::CreateNewUser(UUID uuid, const std::string& username) | |||
| 126 | 127 | ||
| 127 | std::optional<UUID> ProfileManager::GetUser(std::size_t index) const { | 128 | std::optional<UUID> ProfileManager::GetUser(std::size_t index) const { |
| 128 | if (index >= MAX_USERS) { | 129 | if (index >= MAX_USERS) { |
| 129 | return {}; | 130 | return std::nullopt; |
| 130 | } | 131 | } |
| 131 | 132 | ||
| 132 | return profiles[index].user_uuid; | 133 | return profiles[index].user_uuid; |
| @@ -135,13 +136,13 @@ std::optional<UUID> ProfileManager::GetUser(std::size_t index) const { | |||
| 135 | /// Returns a users profile index based on their user id. | 136 | /// Returns a users profile index based on their user id. |
| 136 | std::optional<std::size_t> ProfileManager::GetUserIndex(const UUID& uuid) const { | 137 | std::optional<std::size_t> ProfileManager::GetUserIndex(const UUID& uuid) const { |
| 137 | if (!uuid) { | 138 | if (!uuid) { |
| 138 | return {}; | 139 | return std::nullopt; |
| 139 | } | 140 | } |
| 140 | 141 | ||
| 141 | const auto iter = std::find_if(profiles.begin(), profiles.end(), | 142 | const auto iter = std::find_if(profiles.begin(), profiles.end(), |
| 142 | [&uuid](const ProfileInfo& p) { return p.user_uuid == uuid; }); | 143 | [&uuid](const ProfileInfo& p) { return p.user_uuid == uuid; }); |
| 143 | if (iter == profiles.end()) { | 144 | if (iter == profiles.end()) { |
| 144 | return {}; | 145 | return std::nullopt; |
| 145 | } | 146 | } |
| 146 | 147 | ||
| 147 | return static_cast<std::size_t>(std::distance(profiles.begin(), iter)); | 148 | return static_cast<std::size_t>(std::distance(profiles.begin(), iter)); |
| @@ -339,7 +340,13 @@ void ProfileManager::ParseUserSaveFile() { | |||
| 339 | continue; | 340 | continue; |
| 340 | } | 341 | } |
| 341 | 342 | ||
| 342 | AddUser({user.uuid, user.username, user.timestamp, user.extra_data, false}); | 343 | AddUser({ |
| 344 | .user_uuid = user.uuid, | ||
| 345 | .username = user.username, | ||
| 346 | .creation_time = user.timestamp, | ||
| 347 | .data = user.extra_data, | ||
| 348 | .is_open = false, | ||
| 349 | }); | ||
| 343 | } | 350 | } |
| 344 | 351 | ||
| 345 | std::stable_partition(profiles.begin(), profiles.end(), | 352 | std::stable_partition(profiles.begin(), profiles.end(), |
| @@ -350,11 +357,13 @@ void ProfileManager::WriteUserSaveFile() { | |||
| 350 | ProfileDataRaw raw{}; | 357 | ProfileDataRaw raw{}; |
| 351 | 358 | ||
| 352 | for (std::size_t i = 0; i < MAX_USERS; ++i) { | 359 | for (std::size_t i = 0; i < MAX_USERS; ++i) { |
| 353 | raw.users[i].username = profiles[i].username; | 360 | raw.users[i] = { |
| 354 | raw.users[i].uuid2 = profiles[i].user_uuid; | 361 | .uuid = profiles[i].user_uuid, |
| 355 | raw.users[i].uuid = profiles[i].user_uuid; | 362 | .uuid2 = profiles[i].user_uuid, |
| 356 | raw.users[i].timestamp = profiles[i].creation_time; | 363 | .timestamp = profiles[i].creation_time, |
| 357 | raw.users[i].extra_data = profiles[i].data; | 364 | .username = profiles[i].username, |
| 365 | .extra_data = profiles[i].data, | ||
| 366 | }; | ||
| 358 | } | 367 | } |
| 359 | 368 | ||
| 360 | const auto raw_path = | 369 | const auto raw_path = |
diff --git a/src/core/hle/service/am/am.cpp b/src/core/hle/service/am/am.cpp index ceed20609..55a1edf1a 100644 --- a/src/core/hle/service/am/am.cpp +++ b/src/core/hle/service/am/am.cpp | |||
| @@ -1342,12 +1342,12 @@ void IApplicationFunctions::EnsureSaveData(Kernel::HLERequestContext& ctx) { | |||
| 1342 | 1342 | ||
| 1343 | LOG_DEBUG(Service_AM, "called, uid={:016X}{:016X}", user_id[1], user_id[0]); | 1343 | LOG_DEBUG(Service_AM, "called, uid={:016X}{:016X}", user_id[1], user_id[0]); |
| 1344 | 1344 | ||
| 1345 | FileSys::SaveDataDescriptor descriptor{}; | 1345 | FileSys::SaveDataAttribute attribute{}; |
| 1346 | descriptor.title_id = system.CurrentProcess()->GetTitleID(); | 1346 | attribute.title_id = system.CurrentProcess()->GetTitleID(); |
| 1347 | descriptor.user_id = user_id; | 1347 | attribute.user_id = user_id; |
| 1348 | descriptor.type = FileSys::SaveDataType::SaveData; | 1348 | attribute.type = FileSys::SaveDataType::SaveData; |
| 1349 | const auto res = system.GetFileSystemController().CreateSaveData( | 1349 | const auto res = system.GetFileSystemController().CreateSaveData( |
| 1350 | FileSys::SaveDataSpaceId::NandUser, descriptor); | 1350 | FileSys::SaveDataSpaceId::NandUser, attribute); |
| 1351 | 1351 | ||
| 1352 | IPC::ResponseBuilder rb{ctx, 4}; | 1352 | IPC::ResponseBuilder rb{ctx, 4}; |
| 1353 | rb.Push(res.Code()); | 1353 | rb.Push(res.Code()); |
diff --git a/src/core/hle/service/audio/audout_u.cpp b/src/core/hle/service/audio/audout_u.cpp index 106e89743..dd80dd1dc 100644 --- a/src/core/hle/service/audio/audout_u.cpp +++ b/src/core/hle/service/audio/audout_u.cpp | |||
| @@ -71,7 +71,7 @@ public: | |||
| 71 | 71 | ||
| 72 | stream = audio_core.OpenStream(system.CoreTiming(), audio_params.sample_rate, | 72 | stream = audio_core.OpenStream(system.CoreTiming(), audio_params.sample_rate, |
| 73 | audio_params.channel_count, std::move(unique_name), | 73 | audio_params.channel_count, std::move(unique_name), |
| 74 | [=]() { buffer_event.writable->Signal(); }); | 74 | [this] { buffer_event.writable->Signal(); }); |
| 75 | } | 75 | } |
| 76 | 76 | ||
| 77 | private: | 77 | private: |
diff --git a/src/core/hle/service/audio/hwopus.cpp b/src/core/hle/service/audio/hwopus.cpp index d19513cbb..f1d81602c 100644 --- a/src/core/hle/service/audio/hwopus.cpp +++ b/src/core/hle/service/audio/hwopus.cpp | |||
| @@ -92,7 +92,7 @@ private: | |||
| 92 | if (performance) { | 92 | if (performance) { |
| 93 | rb.Push<u64>(*performance); | 93 | rb.Push<u64>(*performance); |
| 94 | } | 94 | } |
| 95 | ctx.WriteBuffer(samples.data(), samples.size() * sizeof(s16)); | 95 | ctx.WriteBuffer(samples); |
| 96 | } | 96 | } |
| 97 | 97 | ||
| 98 | bool DecodeOpusData(u32& consumed, u32& sample_count, const std::vector<u8>& input, | 98 | bool DecodeOpusData(u32& consumed, u32& sample_count, const std::vector<u8>& input, |
diff --git a/src/core/hle/service/bcat/module.cpp b/src/core/hle/service/bcat/module.cpp index 603b64d4f..db0e06ca1 100644 --- a/src/core/hle/service/bcat/module.cpp +++ b/src/core/hle/service/bcat/module.cpp | |||
| @@ -112,7 +112,7 @@ private: | |||
| 112 | void GetImpl(Kernel::HLERequestContext& ctx) { | 112 | void GetImpl(Kernel::HLERequestContext& ctx) { |
| 113 | LOG_DEBUG(Service_BCAT, "called"); | 113 | LOG_DEBUG(Service_BCAT, "called"); |
| 114 | 114 | ||
| 115 | ctx.WriteBuffer(&impl, sizeof(DeliveryCacheProgressImpl)); | 115 | ctx.WriteBuffer(impl); |
| 116 | 116 | ||
| 117 | IPC::ResponseBuilder rb{ctx, 2}; | 117 | IPC::ResponseBuilder rb{ctx, 2}; |
| 118 | rb.Push(RESULT_SUCCESS); | 118 | rb.Push(RESULT_SUCCESS); |
diff --git a/src/core/hle/service/es/es.cpp b/src/core/hle/service/es/es.cpp index a41c73c48..c2737a365 100644 --- a/src/core/hle/service/es/es.cpp +++ b/src/core/hle/service/es/es.cpp | |||
| @@ -160,7 +160,7 @@ private: | |||
| 160 | return; | 160 | return; |
| 161 | } | 161 | } |
| 162 | 162 | ||
| 163 | ctx.WriteBuffer(key.data(), key.size()); | 163 | ctx.WriteBuffer(key); |
| 164 | 164 | ||
| 165 | IPC::ResponseBuilder rb{ctx, 2}; | 165 | IPC::ResponseBuilder rb{ctx, 2}; |
| 166 | rb.Push(RESULT_SUCCESS); | 166 | rb.Push(RESULT_SUCCESS); |
diff --git a/src/core/hle/service/filesystem/filesystem.cpp b/src/core/hle/service/filesystem/filesystem.cpp index c66124998..4490f8e4c 100644 --- a/src/core/hle/service/filesystem/filesystem.cpp +++ b/src/core/hle/service/filesystem/filesystem.cpp | |||
| @@ -311,7 +311,7 @@ ResultVal<FileSys::VirtualFile> FileSystemController::OpenRomFS( | |||
| 311 | } | 311 | } |
| 312 | 312 | ||
| 313 | ResultVal<FileSys::VirtualDir> FileSystemController::CreateSaveData( | 313 | ResultVal<FileSys::VirtualDir> FileSystemController::CreateSaveData( |
| 314 | FileSys::SaveDataSpaceId space, const FileSys::SaveDataDescriptor& save_struct) const { | 314 | FileSys::SaveDataSpaceId space, const FileSys::SaveDataAttribute& save_struct) const { |
| 315 | LOG_TRACE(Service_FS, "Creating Save Data for space_id={:01X}, save_struct={}", | 315 | LOG_TRACE(Service_FS, "Creating Save Data for space_id={:01X}, save_struct={}", |
| 316 | static_cast<u8>(space), save_struct.DebugInfo()); | 316 | static_cast<u8>(space), save_struct.DebugInfo()); |
| 317 | 317 | ||
| @@ -323,15 +323,15 @@ ResultVal<FileSys::VirtualDir> FileSystemController::CreateSaveData( | |||
| 323 | } | 323 | } |
| 324 | 324 | ||
| 325 | ResultVal<FileSys::VirtualDir> FileSystemController::OpenSaveData( | 325 | ResultVal<FileSys::VirtualDir> FileSystemController::OpenSaveData( |
| 326 | FileSys::SaveDataSpaceId space, const FileSys::SaveDataDescriptor& descriptor) const { | 326 | FileSys::SaveDataSpaceId space, const FileSys::SaveDataAttribute& attribute) const { |
| 327 | LOG_TRACE(Service_FS, "Opening Save Data for space_id={:01X}, save_struct={}", | 327 | LOG_TRACE(Service_FS, "Opening Save Data for space_id={:01X}, save_struct={}", |
| 328 | static_cast<u8>(space), descriptor.DebugInfo()); | 328 | static_cast<u8>(space), attribute.DebugInfo()); |
| 329 | 329 | ||
| 330 | if (save_data_factory == nullptr) { | 330 | if (save_data_factory == nullptr) { |
| 331 | return FileSys::ERROR_ENTITY_NOT_FOUND; | 331 | return FileSys::ERROR_ENTITY_NOT_FOUND; |
| 332 | } | 332 | } |
| 333 | 333 | ||
| 334 | return save_data_factory->Open(space, descriptor); | 334 | return save_data_factory->Open(space, attribute); |
| 335 | } | 335 | } |
| 336 | 336 | ||
| 337 | ResultVal<FileSys::VirtualDir> FileSystemController::OpenSaveDataSpace( | 337 | ResultVal<FileSys::VirtualDir> FileSystemController::OpenSaveDataSpace( |
diff --git a/src/core/hle/service/filesystem/filesystem.h b/src/core/hle/service/filesystem/filesystem.h index 1b0a6a949..6dbbf0b2b 100644 --- a/src/core/hle/service/filesystem/filesystem.h +++ b/src/core/hle/service/filesystem/filesystem.h | |||
| @@ -31,7 +31,7 @@ enum class SaveDataSpaceId : u8; | |||
| 31 | enum class SaveDataType : u8; | 31 | enum class SaveDataType : u8; |
| 32 | enum class StorageId : u8; | 32 | enum class StorageId : u8; |
| 33 | 33 | ||
| 34 | struct SaveDataDescriptor; | 34 | struct SaveDataAttribute; |
| 35 | struct SaveDataSize; | 35 | struct SaveDataSize; |
| 36 | } // namespace FileSys | 36 | } // namespace FileSys |
| 37 | 37 | ||
| @@ -69,9 +69,9 @@ public: | |||
| 69 | ResultVal<FileSys::VirtualFile> OpenRomFS(u64 title_id, FileSys::StorageId storage_id, | 69 | ResultVal<FileSys::VirtualFile> OpenRomFS(u64 title_id, FileSys::StorageId storage_id, |
| 70 | FileSys::ContentRecordType type) const; | 70 | FileSys::ContentRecordType type) const; |
| 71 | ResultVal<FileSys::VirtualDir> CreateSaveData( | 71 | ResultVal<FileSys::VirtualDir> CreateSaveData( |
| 72 | FileSys::SaveDataSpaceId space, const FileSys::SaveDataDescriptor& save_struct) const; | 72 | FileSys::SaveDataSpaceId space, const FileSys::SaveDataAttribute& save_struct) const; |
| 73 | ResultVal<FileSys::VirtualDir> OpenSaveData( | 73 | ResultVal<FileSys::VirtualDir> OpenSaveData( |
| 74 | FileSys::SaveDataSpaceId space, const FileSys::SaveDataDescriptor& save_struct) const; | 74 | FileSys::SaveDataSpaceId space, const FileSys::SaveDataAttribute& save_struct) const; |
| 75 | ResultVal<FileSys::VirtualDir> OpenSaveDataSpace(FileSys::SaveDataSpaceId space) const; | 75 | ResultVal<FileSys::VirtualDir> OpenSaveDataSpace(FileSys::SaveDataSpaceId space) const; |
| 76 | ResultVal<FileSys::VirtualDir> OpenSDMC() const; | 76 | ResultVal<FileSys::VirtualDir> OpenSDMC() const; |
| 77 | ResultVal<FileSys::VirtualDir> OpenBISPartition(FileSys::BisPartitionId id) const; | 77 | ResultVal<FileSys::VirtualDir> OpenBISPartition(FileSys::BisPartitionId id) const; |
diff --git a/src/core/hle/service/filesystem/fsp_srv.cpp b/src/core/hle/service/filesystem/fsp_srv.cpp index 20c331b77..26fd87f58 100644 --- a/src/core/hle/service/filesystem/fsp_srv.cpp +++ b/src/core/hle/service/filesystem/fsp_srv.cpp | |||
| @@ -696,8 +696,8 @@ FSP_SRV::FSP_SRV(FileSystemController& fsc, const Core::Reporter& reporter) | |||
| 696 | {67, nullptr, "FindSaveDataWithFilter"}, | 696 | {67, nullptr, "FindSaveDataWithFilter"}, |
| 697 | {68, nullptr, "OpenSaveDataInfoReaderBySaveDataFilter"}, | 697 | {68, nullptr, "OpenSaveDataInfoReaderBySaveDataFilter"}, |
| 698 | {69, nullptr, "ReadSaveDataFileSystemExtraDataBySaveDataAttribute"}, | 698 | {69, nullptr, "ReadSaveDataFileSystemExtraDataBySaveDataAttribute"}, |
| 699 | {70, nullptr, "WriteSaveDataFileSystemExtraDataBySaveDataAttribute"}, | 699 | {70, &FSP_SRV::WriteSaveDataFileSystemExtraDataBySaveDataAttribute, "WriteSaveDataFileSystemExtraDataBySaveDataAttribute"}, |
| 700 | {71, nullptr, "ReadSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute"}, | 700 | {71, &FSP_SRV::ReadSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute, "ReadSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute"}, |
| 701 | {80, nullptr, "OpenSaveDataMetaFile"}, | 701 | {80, nullptr, "OpenSaveDataMetaFile"}, |
| 702 | {81, nullptr, "OpenSaveDataTransferManager"}, | 702 | {81, nullptr, "OpenSaveDataTransferManager"}, |
| 703 | {82, nullptr, "OpenSaveDataTransferManagerVersion2"}, | 703 | {82, nullptr, "OpenSaveDataTransferManagerVersion2"}, |
| @@ -812,7 +812,7 @@ void FSP_SRV::OpenSdCardFileSystem(Kernel::HLERequestContext& ctx) { | |||
| 812 | void FSP_SRV::CreateSaveDataFileSystem(Kernel::HLERequestContext& ctx) { | 812 | void FSP_SRV::CreateSaveDataFileSystem(Kernel::HLERequestContext& ctx) { |
| 813 | IPC::RequestParser rp{ctx}; | 813 | IPC::RequestParser rp{ctx}; |
| 814 | 814 | ||
| 815 | auto save_struct = rp.PopRaw<FileSys::SaveDataDescriptor>(); | 815 | auto save_struct = rp.PopRaw<FileSys::SaveDataAttribute>(); |
| 816 | [[maybe_unused]] auto save_create_struct = rp.PopRaw<std::array<u8, 0x40>>(); | 816 | [[maybe_unused]] auto save_create_struct = rp.PopRaw<std::array<u8, 0x40>>(); |
| 817 | u128 uid = rp.PopRaw<u128>(); | 817 | u128 uid = rp.PopRaw<u128>(); |
| 818 | 818 | ||
| @@ -826,17 +826,18 @@ void FSP_SRV::CreateSaveDataFileSystem(Kernel::HLERequestContext& ctx) { | |||
| 826 | } | 826 | } |
| 827 | 827 | ||
| 828 | void FSP_SRV::OpenSaveDataFileSystem(Kernel::HLERequestContext& ctx) { | 828 | void FSP_SRV::OpenSaveDataFileSystem(Kernel::HLERequestContext& ctx) { |
| 829 | LOG_INFO(Service_FS, "called."); | 829 | IPC::RequestParser rp{ctx}; |
| 830 | 830 | ||
| 831 | struct Parameters { | 831 | struct Parameters { |
| 832 | FileSys::SaveDataSpaceId save_data_space_id; | 832 | FileSys::SaveDataSpaceId space_id; |
| 833 | FileSys::SaveDataDescriptor descriptor; | 833 | FileSys::SaveDataAttribute attribute; |
| 834 | }; | 834 | }; |
| 835 | 835 | ||
| 836 | IPC::RequestParser rp{ctx}; | ||
| 837 | const auto parameters = rp.PopRaw<Parameters>(); | 836 | const auto parameters = rp.PopRaw<Parameters>(); |
| 838 | 837 | ||
| 839 | auto dir = fsc.OpenSaveData(parameters.save_data_space_id, parameters.descriptor); | 838 | LOG_INFO(Service_FS, "called."); |
| 839 | |||
| 840 | auto dir = fsc.OpenSaveData(parameters.space_id, parameters.attribute); | ||
| 840 | if (dir.Failed()) { | 841 | if (dir.Failed()) { |
| 841 | IPC::ResponseBuilder rb{ctx, 2, 0, 0}; | 842 | IPC::ResponseBuilder rb{ctx, 2, 0, 0}; |
| 842 | rb.Push(FileSys::ERROR_ENTITY_NOT_FOUND); | 843 | rb.Push(FileSys::ERROR_ENTITY_NOT_FOUND); |
| @@ -844,13 +845,18 @@ void FSP_SRV::OpenSaveDataFileSystem(Kernel::HLERequestContext& ctx) { | |||
| 844 | } | 845 | } |
| 845 | 846 | ||
| 846 | FileSys::StorageId id; | 847 | FileSys::StorageId id; |
| 847 | if (parameters.save_data_space_id == FileSys::SaveDataSpaceId::NandUser) { | 848 | |
| 849 | switch (parameters.space_id) { | ||
| 850 | case FileSys::SaveDataSpaceId::NandUser: | ||
| 848 | id = FileSys::StorageId::NandUser; | 851 | id = FileSys::StorageId::NandUser; |
| 849 | } else if (parameters.save_data_space_id == FileSys::SaveDataSpaceId::SdCardSystem || | 852 | break; |
| 850 | parameters.save_data_space_id == FileSys::SaveDataSpaceId::SdCardUser) { | 853 | case FileSys::SaveDataSpaceId::SdCardSystem: |
| 854 | case FileSys::SaveDataSpaceId::SdCardUser: | ||
| 851 | id = FileSys::StorageId::SdCard; | 855 | id = FileSys::StorageId::SdCard; |
| 852 | } else { | 856 | break; |
| 857 | case FileSys::SaveDataSpaceId::NandSystem: | ||
| 853 | id = FileSys::StorageId::NandSystem; | 858 | id = FileSys::StorageId::NandSystem; |
| 859 | break; | ||
| 854 | } | 860 | } |
| 855 | 861 | ||
| 856 | auto filesystem = | 862 | auto filesystem = |
| @@ -876,22 +882,31 @@ void FSP_SRV::OpenSaveDataInfoReaderBySaveDataSpaceId(Kernel::HLERequestContext& | |||
| 876 | rb.PushIpcInterface<ISaveDataInfoReader>(std::make_shared<ISaveDataInfoReader>(space, fsc)); | 882 | rb.PushIpcInterface<ISaveDataInfoReader>(std::make_shared<ISaveDataInfoReader>(space, fsc)); |
| 877 | } | 883 | } |
| 878 | 884 | ||
| 879 | void FSP_SRV::SetGlobalAccessLogMode(Kernel::HLERequestContext& ctx) { | 885 | void FSP_SRV::WriteSaveDataFileSystemExtraDataBySaveDataAttribute(Kernel::HLERequestContext& ctx) { |
| 880 | IPC::RequestParser rp{ctx}; | 886 | LOG_WARNING(Service_FS, "(STUBBED) called."); |
| 881 | log_mode = rp.PopEnum<LogMode>(); | ||
| 882 | |||
| 883 | LOG_DEBUG(Service_FS, "called, log_mode={:08X}", static_cast<u32>(log_mode)); | ||
| 884 | 887 | ||
| 885 | IPC::ResponseBuilder rb{ctx, 2}; | 888 | IPC::ResponseBuilder rb{ctx, 2}; |
| 886 | rb.Push(RESULT_SUCCESS); | 889 | rb.Push(RESULT_SUCCESS); |
| 887 | } | 890 | } |
| 888 | 891 | ||
| 889 | void FSP_SRV::GetGlobalAccessLogMode(Kernel::HLERequestContext& ctx) { | 892 | void FSP_SRV::ReadSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute( |
| 890 | LOG_DEBUG(Service_FS, "called"); | 893 | Kernel::HLERequestContext& ctx) { |
| 894 | IPC::RequestParser rp{ctx}; | ||
| 895 | |||
| 896 | struct Parameters { | ||
| 897 | FileSys::SaveDataSpaceId space_id; | ||
| 898 | FileSys::SaveDataAttribute attribute; | ||
| 899 | }; | ||
| 900 | |||
| 901 | const auto parameters = rp.PopRaw<Parameters>(); | ||
| 902 | // Stub this to None for now, backend needs an impl to read/write the SaveDataExtraData | ||
| 903 | constexpr auto flags = static_cast<u32>(FileSys::SaveDataFlags::None); | ||
| 904 | |||
| 905 | LOG_WARNING(Service_FS, "(STUBBED) called, flags={}", flags); | ||
| 891 | 906 | ||
| 892 | IPC::ResponseBuilder rb{ctx, 3}; | 907 | IPC::ResponseBuilder rb{ctx, 3}; |
| 893 | rb.Push(RESULT_SUCCESS); | 908 | rb.Push(RESULT_SUCCESS); |
| 894 | rb.PushEnum(log_mode); | 909 | rb.Push(flags); |
| 895 | } | 910 | } |
| 896 | 911 | ||
| 897 | void FSP_SRV::OpenDataStorageByCurrentProcess(Kernel::HLERequestContext& ctx) { | 912 | void FSP_SRV::OpenDataStorageByCurrentProcess(Kernel::HLERequestContext& ctx) { |
| @@ -966,6 +981,24 @@ void FSP_SRV::OpenPatchDataStorageByCurrentProcess(Kernel::HLERequestContext& ct | |||
| 966 | rb.Push(FileSys::ERROR_ENTITY_NOT_FOUND); | 981 | rb.Push(FileSys::ERROR_ENTITY_NOT_FOUND); |
| 967 | } | 982 | } |
| 968 | 983 | ||
| 984 | void FSP_SRV::SetGlobalAccessLogMode(Kernel::HLERequestContext& ctx) { | ||
| 985 | IPC::RequestParser rp{ctx}; | ||
| 986 | log_mode = rp.PopEnum<LogMode>(); | ||
| 987 | |||
| 988 | LOG_DEBUG(Service_FS, "called, log_mode={:08X}", static_cast<u32>(log_mode)); | ||
| 989 | |||
| 990 | IPC::ResponseBuilder rb{ctx, 2}; | ||
| 991 | rb.Push(RESULT_SUCCESS); | ||
| 992 | } | ||
| 993 | |||
| 994 | void FSP_SRV::GetGlobalAccessLogMode(Kernel::HLERequestContext& ctx) { | ||
| 995 | LOG_DEBUG(Service_FS, "called"); | ||
| 996 | |||
| 997 | IPC::ResponseBuilder rb{ctx, 3}; | ||
| 998 | rb.Push(RESULT_SUCCESS); | ||
| 999 | rb.PushEnum(log_mode); | ||
| 1000 | } | ||
| 1001 | |||
| 969 | void FSP_SRV::OutputAccessLogToSdCard(Kernel::HLERequestContext& ctx) { | 1002 | void FSP_SRV::OutputAccessLogToSdCard(Kernel::HLERequestContext& ctx) { |
| 970 | const auto raw = ctx.ReadBuffer(); | 1003 | const auto raw = ctx.ReadBuffer(); |
| 971 | auto log = Common::StringFromFixedZeroTerminatedBuffer( | 1004 | auto log = Common::StringFromFixedZeroTerminatedBuffer( |
diff --git a/src/core/hle/service/filesystem/fsp_srv.h b/src/core/hle/service/filesystem/fsp_srv.h index dfb3e395b..4964e874e 100644 --- a/src/core/hle/service/filesystem/fsp_srv.h +++ b/src/core/hle/service/filesystem/fsp_srv.h | |||
| @@ -43,11 +43,13 @@ private: | |||
| 43 | void OpenSaveDataFileSystem(Kernel::HLERequestContext& ctx); | 43 | void OpenSaveDataFileSystem(Kernel::HLERequestContext& ctx); |
| 44 | void OpenReadOnlySaveDataFileSystem(Kernel::HLERequestContext& ctx); | 44 | void OpenReadOnlySaveDataFileSystem(Kernel::HLERequestContext& ctx); |
| 45 | void OpenSaveDataInfoReaderBySaveDataSpaceId(Kernel::HLERequestContext& ctx); | 45 | void OpenSaveDataInfoReaderBySaveDataSpaceId(Kernel::HLERequestContext& ctx); |
| 46 | void SetGlobalAccessLogMode(Kernel::HLERequestContext& ctx); | 46 | void WriteSaveDataFileSystemExtraDataBySaveDataAttribute(Kernel::HLERequestContext& ctx); |
| 47 | void GetGlobalAccessLogMode(Kernel::HLERequestContext& ctx); | 47 | void ReadSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute(Kernel::HLERequestContext& ctx); |
| 48 | void OpenDataStorageByCurrentProcess(Kernel::HLERequestContext& ctx); | 48 | void OpenDataStorageByCurrentProcess(Kernel::HLERequestContext& ctx); |
| 49 | void OpenDataStorageByDataId(Kernel::HLERequestContext& ctx); | 49 | void OpenDataStorageByDataId(Kernel::HLERequestContext& ctx); |
| 50 | void OpenPatchDataStorageByCurrentProcess(Kernel::HLERequestContext& ctx); | 50 | void OpenPatchDataStorageByCurrentProcess(Kernel::HLERequestContext& ctx); |
| 51 | void SetGlobalAccessLogMode(Kernel::HLERequestContext& ctx); | ||
| 52 | void GetGlobalAccessLogMode(Kernel::HLERequestContext& ctx); | ||
| 51 | void OutputAccessLogToSdCard(Kernel::HLERequestContext& ctx); | 53 | void OutputAccessLogToSdCard(Kernel::HLERequestContext& ctx); |
| 52 | void GetAccessLogVersionInfo(Kernel::HLERequestContext& ctx); | 54 | void GetAccessLogVersionInfo(Kernel::HLERequestContext& ctx); |
| 53 | void OpenMultiCommitManager(Kernel::HLERequestContext& ctx); | 55 | void OpenMultiCommitManager(Kernel::HLERequestContext& ctx); |
diff --git a/src/core/hle/service/ldr/ldr.cpp b/src/core/hle/service/ldr/ldr.cpp index 64a526b9e..d8cd10e31 100644 --- a/src/core/hle/service/ldr/ldr.cpp +++ b/src/core/hle/service/ldr/ldr.cpp | |||
| @@ -310,7 +310,7 @@ public: | |||
| 310 | 310 | ||
| 311 | ResultVal<VAddr> MapProcessCodeMemory(Kernel::Process* process, VAddr baseAddress, | 311 | ResultVal<VAddr> MapProcessCodeMemory(Kernel::Process* process, VAddr baseAddress, |
| 312 | u64 size) const { | 312 | u64 size) const { |
| 313 | for (int retry{}; retry < MAXIMUM_MAP_RETRIES; retry++) { | 313 | for (std::size_t retry = 0; retry < MAXIMUM_MAP_RETRIES; retry++) { |
| 314 | auto& page_table{process->PageTable()}; | 314 | auto& page_table{process->PageTable()}; |
| 315 | const VAddr addr{GetRandomMapRegion(page_table, size)}; | 315 | const VAddr addr{GetRandomMapRegion(page_table, size)}; |
| 316 | const ResultCode result{page_table.MapProcessCodeMemory(addr, baseAddress, size)}; | 316 | const ResultCode result{page_table.MapProcessCodeMemory(addr, baseAddress, size)}; |
| @@ -331,8 +331,7 @@ public: | |||
| 331 | 331 | ||
| 332 | ResultVal<VAddr> MapNro(Kernel::Process* process, VAddr nro_addr, std::size_t nro_size, | 332 | ResultVal<VAddr> MapNro(Kernel::Process* process, VAddr nro_addr, std::size_t nro_size, |
| 333 | VAddr bss_addr, std::size_t bss_size, std::size_t size) const { | 333 | VAddr bss_addr, std::size_t bss_size, std::size_t size) const { |
| 334 | 334 | for (std::size_t retry = 0; retry < MAXIMUM_MAP_RETRIES; retry++) { | |
| 335 | for (int retry{}; retry < MAXIMUM_MAP_RETRIES; retry++) { | ||
| 336 | auto& page_table{process->PageTable()}; | 335 | auto& page_table{process->PageTable()}; |
| 337 | VAddr addr{}; | 336 | VAddr addr{}; |
| 338 | 337 | ||
diff --git a/src/core/hle/service/nfp/nfp.cpp b/src/core/hle/service/nfp/nfp.cpp index 4b79eb81d..5e2d769a4 100644 --- a/src/core/hle/service/nfp/nfp.cpp +++ b/src/core/hle/service/nfp/nfp.cpp | |||
| @@ -127,7 +127,7 @@ private: | |||
| 127 | const u32 array_size = rp.Pop<u32>(); | 127 | const u32 array_size = rp.Pop<u32>(); |
| 128 | LOG_DEBUG(Service_NFP, "called, array_size={}", array_size); | 128 | LOG_DEBUG(Service_NFP, "called, array_size={}", array_size); |
| 129 | 129 | ||
| 130 | ctx.WriteBuffer(&device_handle, sizeof(device_handle)); | 130 | ctx.WriteBuffer(device_handle); |
| 131 | 131 | ||
| 132 | IPC::ResponseBuilder rb{ctx, 3}; | 132 | IPC::ResponseBuilder rb{ctx, 3}; |
| 133 | rb.Push(RESULT_SUCCESS); | 133 | rb.Push(RESULT_SUCCESS); |
| @@ -220,7 +220,7 @@ private: | |||
| 220 | 220 | ||
| 221 | tag_info.protocol = 1; // TODO(ogniK): Figure out actual values | 221 | tag_info.protocol = 1; // TODO(ogniK): Figure out actual values |
| 222 | tag_info.tag_type = 2; | 222 | tag_info.tag_type = 2; |
| 223 | ctx.WriteBuffer(&tag_info, sizeof(TagInfo)); | 223 | ctx.WriteBuffer(tag_info); |
| 224 | rb.Push(RESULT_SUCCESS); | 224 | rb.Push(RESULT_SUCCESS); |
| 225 | } | 225 | } |
| 226 | 226 | ||
| @@ -237,7 +237,7 @@ private: | |||
| 237 | 237 | ||
| 238 | IPC::ResponseBuilder rb{ctx, 2}; | 238 | IPC::ResponseBuilder rb{ctx, 2}; |
| 239 | auto amiibo = nfp_interface.GetAmiiboBuffer(); | 239 | auto amiibo = nfp_interface.GetAmiiboBuffer(); |
| 240 | ctx.WriteBuffer(&amiibo.model_info, sizeof(amiibo.model_info)); | 240 | ctx.WriteBuffer(amiibo.model_info); |
| 241 | rb.Push(RESULT_SUCCESS); | 241 | rb.Push(RESULT_SUCCESS); |
| 242 | } | 242 | } |
| 243 | 243 | ||
| @@ -283,7 +283,7 @@ private: | |||
| 283 | 283 | ||
| 284 | CommonInfo common_info{}; | 284 | CommonInfo common_info{}; |
| 285 | common_info.application_area_size = 0; | 285 | common_info.application_area_size = 0; |
| 286 | ctx.WriteBuffer(&common_info, sizeof(CommonInfo)); | 286 | ctx.WriteBuffer(common_info); |
| 287 | 287 | ||
| 288 | IPC::ResponseBuilder rb{ctx, 2}; | 288 | IPC::ResponseBuilder rb{ctx, 2}; |
| 289 | rb.Push(RESULT_SUCCESS); | 289 | rb.Push(RESULT_SUCCESS); |
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp index 195421cc0..d4ba88147 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp +++ b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp | |||
| @@ -16,11 +16,12 @@ | |||
| 16 | #include "video_core/renderer_base.h" | 16 | #include "video_core/renderer_base.h" |
| 17 | 17 | ||
| 18 | namespace Service::Nvidia::Devices { | 18 | namespace Service::Nvidia::Devices { |
| 19 | |||
| 19 | namespace NvErrCodes { | 20 | namespace NvErrCodes { |
| 20 | enum { | 21 | constexpr u32 Success{}; |
| 21 | InvalidNmapHandle = -22, | 22 | constexpr u32 OutOfMemory{static_cast<u32>(-12)}; |
| 22 | }; | 23 | constexpr u32 InvalidInput{static_cast<u32>(-22)}; |
| 23 | } | 24 | } // namespace NvErrCodes |
| 24 | 25 | ||
| 25 | nvhost_as_gpu::nvhost_as_gpu(Core::System& system, std::shared_ptr<nvmap> nvmap_dev) | 26 | nvhost_as_gpu::nvhost_as_gpu(Core::System& system, std::shared_ptr<nvmap> nvmap_dev) |
| 26 | : nvdevice(system), nvmap_dev(std::move(nvmap_dev)) {} | 27 | : nvdevice(system), nvmap_dev(std::move(nvmap_dev)) {} |
| @@ -49,8 +50,9 @@ u32 nvhost_as_gpu::ioctl(Ioctl command, const std::vector<u8>& input, const std: | |||
| 49 | break; | 50 | break; |
| 50 | } | 51 | } |
| 51 | 52 | ||
| 52 | if (static_cast<IoctlCommand>(command.cmd.Value()) == IoctlCommand::IocRemapCommand) | 53 | if (static_cast<IoctlCommand>(command.cmd.Value()) == IoctlCommand::IocRemapCommand) { |
| 53 | return Remap(input, output); | 54 | return Remap(input, output); |
| 55 | } | ||
| 54 | 56 | ||
| 55 | UNIMPLEMENTED_MSG("Unimplemented ioctl command"); | 57 | UNIMPLEMENTED_MSG("Unimplemented ioctl command"); |
| 56 | return 0; | 58 | return 0; |
| @@ -59,6 +61,7 @@ u32 nvhost_as_gpu::ioctl(Ioctl command, const std::vector<u8>& input, const std: | |||
| 59 | u32 nvhost_as_gpu::InitalizeEx(const std::vector<u8>& input, std::vector<u8>& output) { | 61 | u32 nvhost_as_gpu::InitalizeEx(const std::vector<u8>& input, std::vector<u8>& output) { |
| 60 | IoctlInitalizeEx params{}; | 62 | IoctlInitalizeEx params{}; |
| 61 | std::memcpy(¶ms, input.data(), input.size()); | 63 | std::memcpy(¶ms, input.data(), input.size()); |
| 64 | |||
| 62 | LOG_WARNING(Service_NVDRV, "(STUBBED) called, big_page_size=0x{:X}", params.big_page_size); | 65 | LOG_WARNING(Service_NVDRV, "(STUBBED) called, big_page_size=0x{:X}", params.big_page_size); |
| 63 | 66 | ||
| 64 | return 0; | 67 | return 0; |
| @@ -67,53 +70,61 @@ u32 nvhost_as_gpu::InitalizeEx(const std::vector<u8>& input, std::vector<u8>& ou | |||
| 67 | u32 nvhost_as_gpu::AllocateSpace(const std::vector<u8>& input, std::vector<u8>& output) { | 70 | u32 nvhost_as_gpu::AllocateSpace(const std::vector<u8>& input, std::vector<u8>& output) { |
| 68 | IoctlAllocSpace params{}; | 71 | IoctlAllocSpace params{}; |
| 69 | std::memcpy(¶ms, input.data(), input.size()); | 72 | std::memcpy(¶ms, input.data(), input.size()); |
| 73 | |||
| 70 | LOG_DEBUG(Service_NVDRV, "called, pages={:X}, page_size={:X}, flags={:X}", params.pages, | 74 | LOG_DEBUG(Service_NVDRV, "called, pages={:X}, page_size={:X}, flags={:X}", params.pages, |
| 71 | params.page_size, params.flags); | 75 | params.page_size, params.flags); |
| 72 | 76 | ||
| 73 | auto& gpu = system.GPU(); | 77 | const auto size{static_cast<u64>(params.pages) * static_cast<u64>(params.page_size)}; |
| 74 | const u64 size{static_cast<u64>(params.pages) * static_cast<u64>(params.page_size)}; | 78 | if ((params.flags & AddressSpaceFlags::FixedOffset) != AddressSpaceFlags::None) { |
| 75 | if (params.flags & 1) { | 79 | params.offset = *system.GPU().MemoryManager().AllocateFixed(params.offset, size); |
| 76 | params.offset = gpu.MemoryManager().AllocateSpace(params.offset, size, 1); | ||
| 77 | } else { | 80 | } else { |
| 78 | params.offset = gpu.MemoryManager().AllocateSpace(size, params.align); | 81 | params.offset = system.GPU().MemoryManager().Allocate(size, params.align); |
| 82 | } | ||
| 83 | |||
| 84 | auto result{NvErrCodes::Success}; | ||
| 85 | if (!params.offset) { | ||
| 86 | LOG_CRITICAL(Service_NVDRV, "allocation failed for size {}", size); | ||
| 87 | result = NvErrCodes::OutOfMemory; | ||
| 79 | } | 88 | } |
| 80 | 89 | ||
| 81 | std::memcpy(output.data(), ¶ms, output.size()); | 90 | std::memcpy(output.data(), ¶ms, output.size()); |
| 82 | return 0; | 91 | return result; |
| 83 | } | 92 | } |
| 84 | 93 | ||
| 85 | u32 nvhost_as_gpu::Remap(const std::vector<u8>& input, std::vector<u8>& output) { | 94 | u32 nvhost_as_gpu::Remap(const std::vector<u8>& input, std::vector<u8>& output) { |
| 86 | std::size_t num_entries = input.size() / sizeof(IoctlRemapEntry); | 95 | const auto num_entries = input.size() / sizeof(IoctlRemapEntry); |
| 87 | 96 | ||
| 88 | LOG_WARNING(Service_NVDRV, "(STUBBED) called, num_entries=0x{:X}", num_entries); | 97 | LOG_DEBUG(Service_NVDRV, "called, num_entries=0x{:X}", num_entries); |
| 89 | 98 | ||
| 99 | auto result{NvErrCodes::Success}; | ||
| 90 | std::vector<IoctlRemapEntry> entries(num_entries); | 100 | std::vector<IoctlRemapEntry> entries(num_entries); |
| 91 | std::memcpy(entries.data(), input.data(), input.size()); | 101 | std::memcpy(entries.data(), input.data(), input.size()); |
| 92 | 102 | ||
| 93 | auto& gpu = system.GPU(); | ||
| 94 | for (const auto& entry : entries) { | 103 | for (const auto& entry : entries) { |
| 95 | LOG_WARNING(Service_NVDRV, "remap entry, offset=0x{:X} handle=0x{:X} pages=0x{:X}", | 104 | LOG_DEBUG(Service_NVDRV, "remap entry, offset=0x{:X} handle=0x{:X} pages=0x{:X}", |
| 96 | entry.offset, entry.nvmap_handle, entry.pages); | 105 | entry.offset, entry.nvmap_handle, entry.pages); |
| 97 | GPUVAddr offset = static_cast<GPUVAddr>(entry.offset) << 0x10; | 106 | |
| 98 | auto object = nvmap_dev->GetObject(entry.nvmap_handle); | 107 | const auto object{nvmap_dev->GetObject(entry.nvmap_handle)}; |
| 99 | if (!object) { | 108 | if (!object) { |
| 100 | LOG_CRITICAL(Service_NVDRV, "nvmap {} is an invalid handle!", entry.nvmap_handle); | 109 | LOG_CRITICAL(Service_NVDRV, "invalid nvmap_handle={:X}", entry.nvmap_handle); |
| 101 | std::memcpy(output.data(), entries.data(), output.size()); | 110 | result = NvErrCodes::InvalidInput; |
| 102 | return static_cast<u32>(NvErrCodes::InvalidNmapHandle); | 111 | break; |
| 103 | } | 112 | } |
| 104 | 113 | ||
| 105 | ASSERT(object->status == nvmap::Object::Status::Allocated); | 114 | const auto offset{static_cast<GPUVAddr>(entry.offset) << 0x10}; |
| 115 | const auto size{static_cast<u64>(entry.pages) << 0x10}; | ||
| 116 | const auto map_offset{static_cast<u64>(entry.map_offset) << 0x10}; | ||
| 117 | const auto addr{system.GPU().MemoryManager().Map(object->addr + map_offset, offset, size)}; | ||
| 106 | 118 | ||
| 107 | const u64 size = static_cast<u64>(entry.pages) << 0x10; | 119 | if (!addr) { |
| 108 | ASSERT(size <= object->size); | 120 | LOG_CRITICAL(Service_NVDRV, "map returned an invalid address!"); |
| 109 | const u64 map_offset = static_cast<u64>(entry.map_offset) << 0x10; | 121 | result = NvErrCodes::InvalidInput; |
| 110 | 122 | break; | |
| 111 | const GPUVAddr returned = | 123 | } |
| 112 | gpu.MemoryManager().MapBufferEx(object->addr + map_offset, offset, size); | ||
| 113 | ASSERT(returned == offset); | ||
| 114 | } | 124 | } |
| 125 | |||
| 115 | std::memcpy(output.data(), entries.data(), output.size()); | 126 | std::memcpy(output.data(), entries.data(), output.size()); |
| 116 | return 0; | 127 | return result; |
| 117 | } | 128 | } |
| 118 | 129 | ||
| 119 | u32 nvhost_as_gpu::MapBufferEx(const std::vector<u8>& input, std::vector<u8>& output) { | 130 | u32 nvhost_as_gpu::MapBufferEx(const std::vector<u8>& input, std::vector<u8>& output) { |
| @@ -126,44 +137,76 @@ u32 nvhost_as_gpu::MapBufferEx(const std::vector<u8>& input, std::vector<u8>& ou | |||
| 126 | params.flags, params.nvmap_handle, params.buffer_offset, params.mapping_size, | 137 | params.flags, params.nvmap_handle, params.buffer_offset, params.mapping_size, |
| 127 | params.offset); | 138 | params.offset); |
| 128 | 139 | ||
| 129 | if (!params.nvmap_handle) { | 140 | const auto object{nvmap_dev->GetObject(params.nvmap_handle)}; |
| 130 | return 0; | 141 | if (!object) { |
| 142 | LOG_CRITICAL(Service_NVDRV, "invalid nvmap_handle={:X}", params.nvmap_handle); | ||
| 143 | std::memcpy(output.data(), ¶ms, output.size()); | ||
| 144 | return NvErrCodes::InvalidInput; | ||
| 131 | } | 145 | } |
| 132 | 146 | ||
| 133 | auto object = nvmap_dev->GetObject(params.nvmap_handle); | ||
| 134 | ASSERT(object); | ||
| 135 | |||
| 136 | // We can only map objects that have already been assigned a CPU address. | ||
| 137 | ASSERT(object->status == nvmap::Object::Status::Allocated); | ||
| 138 | |||
| 139 | ASSERT(params.buffer_offset == 0); | ||
| 140 | |||
| 141 | // The real nvservices doesn't make a distinction between handles and ids, and | 147 | // The real nvservices doesn't make a distinction between handles and ids, and |
| 142 | // object can only have one handle and it will be the same as its id. Assert that this is the | 148 | // object can only have one handle and it will be the same as its id. Assert that this is the |
| 143 | // case to prevent unexpected behavior. | 149 | // case to prevent unexpected behavior. |
| 144 | ASSERT(object->id == params.nvmap_handle); | 150 | ASSERT(object->id == params.nvmap_handle); |
| 145 | |||
| 146 | auto& gpu = system.GPU(); | 151 | auto& gpu = system.GPU(); |
| 147 | 152 | ||
| 148 | if (params.flags & 1) { | 153 | u64 page_size{params.page_size}; |
| 149 | params.offset = gpu.MemoryManager().MapBufferEx(object->addr, params.offset, object->size); | 154 | if (!page_size) { |
| 150 | } else { | 155 | page_size = object->align; |
| 151 | params.offset = gpu.MemoryManager().MapBufferEx(object->addr, object->size); | 156 | } |
| 157 | |||
| 158 | if ((params.flags & AddressSpaceFlags::Remap) != AddressSpaceFlags::None) { | ||
| 159 | if (const auto buffer_map{FindBufferMap(params.offset)}; buffer_map) { | ||
| 160 | const auto cpu_addr{static_cast<VAddr>(buffer_map->CpuAddr() + params.buffer_offset)}; | ||
| 161 | const auto gpu_addr{static_cast<GPUVAddr>(params.offset + params.buffer_offset)}; | ||
| 162 | |||
| 163 | if (!gpu.MemoryManager().Map(cpu_addr, gpu_addr, params.mapping_size)) { | ||
| 164 | LOG_CRITICAL(Service_NVDRV, | ||
| 165 | "remap failed, flags={:X}, nvmap_handle={:X}, buffer_offset={}, " | ||
| 166 | "mapping_size = {}, offset={}", | ||
| 167 | params.flags, params.nvmap_handle, params.buffer_offset, | ||
| 168 | params.mapping_size, params.offset); | ||
| 169 | |||
| 170 | std::memcpy(output.data(), ¶ms, output.size()); | ||
| 171 | return NvErrCodes::InvalidInput; | ||
| 172 | } | ||
| 173 | |||
| 174 | std::memcpy(output.data(), ¶ms, output.size()); | ||
| 175 | return NvErrCodes::Success; | ||
| 176 | } else { | ||
| 177 | LOG_CRITICAL(Service_NVDRV, "address not mapped offset={}", params.offset); | ||
| 178 | |||
| 179 | std::memcpy(output.data(), ¶ms, output.size()); | ||
| 180 | return NvErrCodes::InvalidInput; | ||
| 181 | } | ||
| 152 | } | 182 | } |
| 153 | 183 | ||
| 154 | // Create a new mapping entry for this operation. | 184 | // We can only map objects that have already been assigned a CPU address. |
| 155 | ASSERT_MSG(buffer_mappings.find(params.offset) == buffer_mappings.end(), | 185 | ASSERT(object->status == nvmap::Object::Status::Allocated); |
| 156 | "Offset is already mapped"); | 186 | |
| 187 | const auto physical_address{object->addr + params.buffer_offset}; | ||
| 188 | u64 size{params.mapping_size}; | ||
| 189 | if (!size) { | ||
| 190 | size = object->size; | ||
| 191 | } | ||
| 157 | 192 | ||
| 158 | BufferMapping mapping{}; | 193 | const bool is_alloc{(params.flags & AddressSpaceFlags::FixedOffset) == AddressSpaceFlags::None}; |
| 159 | mapping.nvmap_handle = params.nvmap_handle; | 194 | if (is_alloc) { |
| 160 | mapping.offset = params.offset; | 195 | params.offset = gpu.MemoryManager().MapAllocate(physical_address, size, page_size); |
| 161 | mapping.size = object->size; | 196 | } else { |
| 197 | params.offset = gpu.MemoryManager().Map(physical_address, params.offset, size); | ||
| 198 | } | ||
| 162 | 199 | ||
| 163 | buffer_mappings[params.offset] = mapping; | 200 | auto result{NvErrCodes::Success}; |
| 201 | if (!params.offset) { | ||
| 202 | LOG_CRITICAL(Service_NVDRV, "failed to map size={}", size); | ||
| 203 | result = NvErrCodes::InvalidInput; | ||
| 204 | } else { | ||
| 205 | AddBufferMap(params.offset, size, physical_address, is_alloc); | ||
| 206 | } | ||
| 164 | 207 | ||
| 165 | std::memcpy(output.data(), ¶ms, output.size()); | 208 | std::memcpy(output.data(), ¶ms, output.size()); |
| 166 | return 0; | 209 | return result; |
| 167 | } | 210 | } |
| 168 | 211 | ||
| 169 | u32 nvhost_as_gpu::UnmapBuffer(const std::vector<u8>& input, std::vector<u8>& output) { | 212 | u32 nvhost_as_gpu::UnmapBuffer(const std::vector<u8>& input, std::vector<u8>& output) { |
| @@ -172,24 +215,20 @@ u32 nvhost_as_gpu::UnmapBuffer(const std::vector<u8>& input, std::vector<u8>& ou | |||
| 172 | 215 | ||
| 173 | LOG_DEBUG(Service_NVDRV, "called, offset=0x{:X}", params.offset); | 216 | LOG_DEBUG(Service_NVDRV, "called, offset=0x{:X}", params.offset); |
| 174 | 217 | ||
| 175 | const auto itr = buffer_mappings.find(params.offset); | 218 | if (const auto size{RemoveBufferMap(params.offset)}; size) { |
| 176 | if (itr == buffer_mappings.end()) { | 219 | system.GPU().MemoryManager().Unmap(params.offset, *size); |
| 177 | LOG_WARNING(Service_NVDRV, "Tried to unmap an invalid offset 0x{:X}", params.offset); | 220 | } else { |
| 178 | // Hardware tests shows that unmapping an already unmapped buffer always returns successful | 221 | LOG_ERROR(Service_NVDRV, "invalid offset=0x{:X}", params.offset); |
| 179 | // and doesn't fail. | ||
| 180 | return 0; | ||
| 181 | } | 222 | } |
| 182 | 223 | ||
| 183 | params.offset = system.GPU().MemoryManager().UnmapBuffer(params.offset, itr->second.size); | ||
| 184 | buffer_mappings.erase(itr->second.offset); | ||
| 185 | |||
| 186 | std::memcpy(output.data(), ¶ms, output.size()); | 224 | std::memcpy(output.data(), ¶ms, output.size()); |
| 187 | return 0; | 225 | return NvErrCodes::Success; |
| 188 | } | 226 | } |
| 189 | 227 | ||
| 190 | u32 nvhost_as_gpu::BindChannel(const std::vector<u8>& input, std::vector<u8>& output) { | 228 | u32 nvhost_as_gpu::BindChannel(const std::vector<u8>& input, std::vector<u8>& output) { |
| 191 | IoctlBindChannel params{}; | 229 | IoctlBindChannel params{}; |
| 192 | std::memcpy(¶ms, input.data(), input.size()); | 230 | std::memcpy(¶ms, input.data(), input.size()); |
| 231 | |||
| 193 | LOG_DEBUG(Service_NVDRV, "called, fd={:X}", params.fd); | 232 | LOG_DEBUG(Service_NVDRV, "called, fd={:X}", params.fd); |
| 194 | 233 | ||
| 195 | channel = params.fd; | 234 | channel = params.fd; |
| @@ -199,6 +238,7 @@ u32 nvhost_as_gpu::BindChannel(const std::vector<u8>& input, std::vector<u8>& ou | |||
| 199 | u32 nvhost_as_gpu::GetVARegions(const std::vector<u8>& input, std::vector<u8>& output) { | 238 | u32 nvhost_as_gpu::GetVARegions(const std::vector<u8>& input, std::vector<u8>& output) { |
| 200 | IoctlGetVaRegions params{}; | 239 | IoctlGetVaRegions params{}; |
| 201 | std::memcpy(¶ms, input.data(), input.size()); | 240 | std::memcpy(¶ms, input.data(), input.size()); |
| 241 | |||
| 202 | LOG_WARNING(Service_NVDRV, "(STUBBED) called, buf_addr={:X}, buf_size={:X}", params.buf_addr, | 242 | LOG_WARNING(Service_NVDRV, "(STUBBED) called, buf_addr={:X}, buf_size={:X}", params.buf_addr, |
| 203 | params.buf_size); | 243 | params.buf_size); |
| 204 | 244 | ||
| @@ -210,9 +250,43 @@ u32 nvhost_as_gpu::GetVARegions(const std::vector<u8>& input, std::vector<u8>& o | |||
| 210 | params.regions[1].offset = 0x04000000; | 250 | params.regions[1].offset = 0x04000000; |
| 211 | params.regions[1].page_size = 0x10000; | 251 | params.regions[1].page_size = 0x10000; |
| 212 | params.regions[1].pages = 0x1bffff; | 252 | params.regions[1].pages = 0x1bffff; |
| 253 | |||
| 213 | // TODO(ogniK): This probably can stay stubbed but should add support way way later | 254 | // TODO(ogniK): This probably can stay stubbed but should add support way way later |
| 255 | |||
| 214 | std::memcpy(output.data(), ¶ms, output.size()); | 256 | std::memcpy(output.data(), ¶ms, output.size()); |
| 215 | return 0; | 257 | return 0; |
| 216 | } | 258 | } |
| 217 | 259 | ||
| 260 | std::optional<nvhost_as_gpu::BufferMap> nvhost_as_gpu::FindBufferMap(GPUVAddr gpu_addr) const { | ||
| 261 | const auto end{buffer_mappings.upper_bound(gpu_addr)}; | ||
| 262 | for (auto iter{buffer_mappings.begin()}; iter != end; ++iter) { | ||
| 263 | if (gpu_addr >= iter->second.StartAddr() && gpu_addr < iter->second.EndAddr()) { | ||
| 264 | return iter->second; | ||
| 265 | } | ||
| 266 | } | ||
| 267 | |||
| 268 | return {}; | ||
| 269 | } | ||
| 270 | |||
| 271 | void nvhost_as_gpu::AddBufferMap(GPUVAddr gpu_addr, std::size_t size, VAddr cpu_addr, | ||
| 272 | bool is_allocated) { | ||
| 273 | buffer_mappings[gpu_addr] = {gpu_addr, size, cpu_addr, is_allocated}; | ||
| 274 | } | ||
| 275 | |||
| 276 | std::optional<std::size_t> nvhost_as_gpu::RemoveBufferMap(GPUVAddr gpu_addr) { | ||
| 277 | if (const auto iter{buffer_mappings.find(gpu_addr)}; iter != buffer_mappings.end()) { | ||
| 278 | std::size_t size{}; | ||
| 279 | |||
| 280 | if (iter->second.IsAllocated()) { | ||
| 281 | size = iter->second.Size(); | ||
| 282 | } | ||
| 283 | |||
| 284 | buffer_mappings.erase(iter); | ||
| 285 | |||
| 286 | return size; | ||
| 287 | } | ||
| 288 | |||
| 289 | return {}; | ||
| 290 | } | ||
| 291 | |||
| 218 | } // namespace Service::Nvidia::Devices | 292 | } // namespace Service::Nvidia::Devices |
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.h b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.h index f79fcc065..9a0cdff0c 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.h +++ b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.h | |||
| @@ -4,9 +4,12 @@ | |||
| 4 | 4 | ||
| 5 | #pragma once | 5 | #pragma once |
| 6 | 6 | ||
| 7 | #include <map> | ||
| 7 | #include <memory> | 8 | #include <memory> |
| 8 | #include <unordered_map> | 9 | #include <optional> |
| 9 | #include <vector> | 10 | #include <vector> |
| 11 | |||
| 12 | #include "common/common_funcs.h" | ||
| 10 | #include "common/common_types.h" | 13 | #include "common/common_types.h" |
| 11 | #include "common/swap.h" | 14 | #include "common/swap.h" |
| 12 | #include "core/hle/service/nvdrv/devices/nvdevice.h" | 15 | #include "core/hle/service/nvdrv/devices/nvdevice.h" |
| @@ -15,6 +18,13 @@ namespace Service::Nvidia::Devices { | |||
| 15 | 18 | ||
| 16 | class nvmap; | 19 | class nvmap; |
| 17 | 20 | ||
| 21 | enum class AddressSpaceFlags : u32 { | ||
| 22 | None = 0x0, | ||
| 23 | FixedOffset = 0x1, | ||
| 24 | Remap = 0x100, | ||
| 25 | }; | ||
| 26 | DECLARE_ENUM_FLAG_OPERATORS(AddressSpaceFlags); | ||
| 27 | |||
| 18 | class nvhost_as_gpu final : public nvdevice { | 28 | class nvhost_as_gpu final : public nvdevice { |
| 19 | public: | 29 | public: |
| 20 | explicit nvhost_as_gpu(Core::System& system, std::shared_ptr<nvmap> nvmap_dev); | 30 | explicit nvhost_as_gpu(Core::System& system, std::shared_ptr<nvmap> nvmap_dev); |
| @@ -25,6 +35,45 @@ public: | |||
| 25 | IoctlVersion version) override; | 35 | IoctlVersion version) override; |
| 26 | 36 | ||
| 27 | private: | 37 | private: |
| 38 | class BufferMap final { | ||
| 39 | public: | ||
| 40 | constexpr BufferMap() = default; | ||
| 41 | |||
| 42 | constexpr BufferMap(GPUVAddr start_addr, std::size_t size) | ||
| 43 | : start_addr{start_addr}, end_addr{start_addr + size} {} | ||
| 44 | |||
| 45 | constexpr BufferMap(GPUVAddr start_addr, std::size_t size, VAddr cpu_addr, | ||
| 46 | bool is_allocated) | ||
| 47 | : start_addr{start_addr}, end_addr{start_addr + size}, cpu_addr{cpu_addr}, | ||
| 48 | is_allocated{is_allocated} {} | ||
| 49 | |||
| 50 | constexpr VAddr StartAddr() const { | ||
| 51 | return start_addr; | ||
| 52 | } | ||
| 53 | |||
| 54 | constexpr VAddr EndAddr() const { | ||
| 55 | return end_addr; | ||
| 56 | } | ||
| 57 | |||
| 58 | constexpr std::size_t Size() const { | ||
| 59 | return end_addr - start_addr; | ||
| 60 | } | ||
| 61 | |||
| 62 | constexpr VAddr CpuAddr() const { | ||
| 63 | return cpu_addr; | ||
| 64 | } | ||
| 65 | |||
| 66 | constexpr bool IsAllocated() const { | ||
| 67 | return is_allocated; | ||
| 68 | } | ||
| 69 | |||
| 70 | private: | ||
| 71 | GPUVAddr start_addr{}; | ||
| 72 | GPUVAddr end_addr{}; | ||
| 73 | VAddr cpu_addr{}; | ||
| 74 | bool is_allocated{}; | ||
| 75 | }; | ||
| 76 | |||
| 28 | enum class IoctlCommand : u32_le { | 77 | enum class IoctlCommand : u32_le { |
| 29 | IocInitalizeExCommand = 0x40284109, | 78 | IocInitalizeExCommand = 0x40284109, |
| 30 | IocAllocateSpaceCommand = 0xC0184102, | 79 | IocAllocateSpaceCommand = 0xC0184102, |
| @@ -49,7 +98,7 @@ private: | |||
| 49 | struct IoctlAllocSpace { | 98 | struct IoctlAllocSpace { |
| 50 | u32_le pages; | 99 | u32_le pages; |
| 51 | u32_le page_size; | 100 | u32_le page_size; |
| 52 | u32_le flags; | 101 | AddressSpaceFlags flags; |
| 53 | INSERT_PADDING_WORDS(1); | 102 | INSERT_PADDING_WORDS(1); |
| 54 | union { | 103 | union { |
| 55 | u64_le offset; | 104 | u64_le offset; |
| @@ -69,18 +118,18 @@ private: | |||
| 69 | static_assert(sizeof(IoctlRemapEntry) == 20, "IoctlRemapEntry is incorrect size"); | 118 | static_assert(sizeof(IoctlRemapEntry) == 20, "IoctlRemapEntry is incorrect size"); |
| 70 | 119 | ||
| 71 | struct IoctlMapBufferEx { | 120 | struct IoctlMapBufferEx { |
| 72 | u32_le flags; // bit0: fixed_offset, bit2: cacheable | 121 | AddressSpaceFlags flags; // bit0: fixed_offset, bit2: cacheable |
| 73 | u32_le kind; // -1 is default | 122 | u32_le kind; // -1 is default |
| 74 | u32_le nvmap_handle; | 123 | u32_le nvmap_handle; |
| 75 | u32_le page_size; // 0 means don't care | 124 | u32_le page_size; // 0 means don't care |
| 76 | u64_le buffer_offset; | 125 | s64_le buffer_offset; |
| 77 | u64_le mapping_size; | 126 | u64_le mapping_size; |
| 78 | u64_le offset; | 127 | s64_le offset; |
| 79 | }; | 128 | }; |
| 80 | static_assert(sizeof(IoctlMapBufferEx) == 40, "IoctlMapBufferEx is incorrect size"); | 129 | static_assert(sizeof(IoctlMapBufferEx) == 40, "IoctlMapBufferEx is incorrect size"); |
| 81 | 130 | ||
| 82 | struct IoctlUnmapBuffer { | 131 | struct IoctlUnmapBuffer { |
| 83 | u64_le offset; | 132 | s64_le offset; |
| 84 | }; | 133 | }; |
| 85 | static_assert(sizeof(IoctlUnmapBuffer) == 8, "IoctlUnmapBuffer is incorrect size"); | 134 | static_assert(sizeof(IoctlUnmapBuffer) == 8, "IoctlUnmapBuffer is incorrect size"); |
| 86 | 135 | ||
| @@ -106,15 +155,6 @@ private: | |||
| 106 | static_assert(sizeof(IoctlGetVaRegions) == 16 + sizeof(IoctlVaRegion) * 2, | 155 | static_assert(sizeof(IoctlGetVaRegions) == 16 + sizeof(IoctlVaRegion) * 2, |
| 107 | "IoctlGetVaRegions is incorrect size"); | 156 | "IoctlGetVaRegions is incorrect size"); |
| 108 | 157 | ||
| 109 | struct BufferMapping { | ||
| 110 | u64 offset; | ||
| 111 | u64 size; | ||
| 112 | u32 nvmap_handle; | ||
| 113 | }; | ||
| 114 | |||
| 115 | /// Map containing the nvmap object mappings in GPU memory. | ||
| 116 | std::unordered_map<u64, BufferMapping> buffer_mappings; | ||
| 117 | |||
| 118 | u32 channel{}; | 158 | u32 channel{}; |
| 119 | 159 | ||
| 120 | u32 InitalizeEx(const std::vector<u8>& input, std::vector<u8>& output); | 160 | u32 InitalizeEx(const std::vector<u8>& input, std::vector<u8>& output); |
| @@ -125,7 +165,14 @@ private: | |||
| 125 | u32 BindChannel(const std::vector<u8>& input, std::vector<u8>& output); | 165 | u32 BindChannel(const std::vector<u8>& input, std::vector<u8>& output); |
| 126 | u32 GetVARegions(const std::vector<u8>& input, std::vector<u8>& output); | 166 | u32 GetVARegions(const std::vector<u8>& input, std::vector<u8>& output); |
| 127 | 167 | ||
| 168 | std::optional<BufferMap> FindBufferMap(GPUVAddr gpu_addr) const; | ||
| 169 | void AddBufferMap(GPUVAddr gpu_addr, std::size_t size, VAddr cpu_addr, bool is_allocated); | ||
| 170 | std::optional<std::size_t> RemoveBufferMap(GPUVAddr gpu_addr); | ||
| 171 | |||
| 128 | std::shared_ptr<nvmap> nvmap_dev; | 172 | std::shared_ptr<nvmap> nvmap_dev; |
| 173 | |||
| 174 | // This is expected to be ordered, therefore we must use a map, not unordered_map | ||
| 175 | std::map<GPUVAddr, BufferMap> buffer_mappings; | ||
| 129 | }; | 176 | }; |
| 130 | 177 | ||
| 131 | } // namespace Service::Nvidia::Devices | 178 | } // namespace Service::Nvidia::Devices |
diff --git a/src/core/hle/service/nvdrv/devices/nvmap.cpp b/src/core/hle/service/nvdrv/devices/nvmap.cpp index 8c742316c..9436e16ad 100644 --- a/src/core/hle/service/nvdrv/devices/nvmap.cpp +++ b/src/core/hle/service/nvdrv/devices/nvmap.cpp | |||
| @@ -18,7 +18,12 @@ enum { | |||
| 18 | }; | 18 | }; |
| 19 | } | 19 | } |
| 20 | 20 | ||
| 21 | nvmap::nvmap(Core::System& system) : nvdevice(system) {} | 21 | nvmap::nvmap(Core::System& system) : nvdevice(system) { |
| 22 | // Handle 0 appears to be used when remapping, so we create a placeholder empty nvmap object to | ||
| 23 | // represent this. | ||
| 24 | CreateObject(0); | ||
| 25 | } | ||
| 26 | |||
| 22 | nvmap::~nvmap() = default; | 27 | nvmap::~nvmap() = default; |
| 23 | 28 | ||
| 24 | VAddr nvmap::GetObjectAddress(u32 handle) const { | 29 | VAddr nvmap::GetObjectAddress(u32 handle) const { |
| @@ -50,6 +55,21 @@ u32 nvmap::ioctl(Ioctl command, const std::vector<u8>& input, const std::vector< | |||
| 50 | return 0; | 55 | return 0; |
| 51 | } | 56 | } |
| 52 | 57 | ||
| 58 | u32 nvmap::CreateObject(u32 size) { | ||
| 59 | // Create a new nvmap object and obtain a handle to it. | ||
| 60 | auto object = std::make_shared<Object>(); | ||
| 61 | object->id = next_id++; | ||
| 62 | object->size = size; | ||
| 63 | object->status = Object::Status::Created; | ||
| 64 | object->refcount = 1; | ||
| 65 | |||
| 66 | const u32 handle = next_handle++; | ||
| 67 | |||
| 68 | handles.insert_or_assign(handle, std::move(object)); | ||
| 69 | |||
| 70 | return handle; | ||
| 71 | } | ||
| 72 | |||
| 53 | u32 nvmap::IocCreate(const std::vector<u8>& input, std::vector<u8>& output) { | 73 | u32 nvmap::IocCreate(const std::vector<u8>& input, std::vector<u8>& output) { |
| 54 | IocCreateParams params; | 74 | IocCreateParams params; |
| 55 | std::memcpy(¶ms, input.data(), sizeof(params)); | 75 | std::memcpy(¶ms, input.data(), sizeof(params)); |
| @@ -59,17 +79,8 @@ u32 nvmap::IocCreate(const std::vector<u8>& input, std::vector<u8>& output) { | |||
| 59 | LOG_ERROR(Service_NVDRV, "Size is 0"); | 79 | LOG_ERROR(Service_NVDRV, "Size is 0"); |
| 60 | return static_cast<u32>(NvErrCodes::InvalidValue); | 80 | return static_cast<u32>(NvErrCodes::InvalidValue); |
| 61 | } | 81 | } |
| 62 | // Create a new nvmap object and obtain a handle to it. | ||
| 63 | auto object = std::make_shared<Object>(); | ||
| 64 | object->id = next_id++; | ||
| 65 | object->size = params.size; | ||
| 66 | object->status = Object::Status::Created; | ||
| 67 | object->refcount = 1; | ||
| 68 | |||
| 69 | u32 handle = next_handle++; | ||
| 70 | handles[handle] = std::move(object); | ||
| 71 | 82 | ||
| 72 | params.handle = handle; | 83 | params.handle = CreateObject(params.size); |
| 73 | 84 | ||
| 74 | std::memcpy(output.data(), ¶ms, sizeof(params)); | 85 | std::memcpy(output.data(), ¶ms, sizeof(params)); |
| 75 | return 0; | 86 | return 0; |
diff --git a/src/core/hle/service/nvdrv/devices/nvmap.h b/src/core/hle/service/nvdrv/devices/nvmap.h index 73c2e8809..84624be00 100644 --- a/src/core/hle/service/nvdrv/devices/nvmap.h +++ b/src/core/hle/service/nvdrv/devices/nvmap.h | |||
| @@ -49,10 +49,10 @@ public: | |||
| 49 | 49 | ||
| 50 | private: | 50 | private: |
| 51 | /// Id to use for the next handle that is created. | 51 | /// Id to use for the next handle that is created. |
| 52 | u32 next_handle = 1; | 52 | u32 next_handle = 0; |
| 53 | 53 | ||
| 54 | /// Id to use for the next object that is created. | 54 | /// Id to use for the next object that is created. |
| 55 | u32 next_id = 1; | 55 | u32 next_id = 0; |
| 56 | 56 | ||
| 57 | /// Mapping of currently allocated handles to the objects they represent. | 57 | /// Mapping of currently allocated handles to the objects they represent. |
| 58 | std::unordered_map<u32, std::shared_ptr<Object>> handles; | 58 | std::unordered_map<u32, std::shared_ptr<Object>> handles; |
| @@ -119,6 +119,8 @@ private: | |||
| 119 | }; | 119 | }; |
| 120 | static_assert(sizeof(IocGetIdParams) == 8, "IocGetIdParams has wrong size"); | 120 | static_assert(sizeof(IocGetIdParams) == 8, "IocGetIdParams has wrong size"); |
| 121 | 121 | ||
| 122 | u32 CreateObject(u32 size); | ||
| 123 | |||
| 122 | u32 IocCreate(const std::vector<u8>& input, std::vector<u8>& output); | 124 | u32 IocCreate(const std::vector<u8>& input, std::vector<u8>& output); |
| 123 | u32 IocAlloc(const std::vector<u8>& input, std::vector<u8>& output); | 125 | u32 IocAlloc(const std::vector<u8>& input, std::vector<u8>& output); |
| 124 | u32 IocGetId(const std::vector<u8>& input, std::vector<u8>& output); | 126 | u32 IocGetId(const std::vector<u8>& input, std::vector<u8>& output); |
diff --git a/src/core/hle/service/nvdrv/interface.cpp b/src/core/hle/service/nvdrv/interface.cpp index deaf0808b..88fbfa9b0 100644 --- a/src/core/hle/service/nvdrv/interface.cpp +++ b/src/core/hle/service/nvdrv/interface.cpp | |||
| @@ -60,24 +60,24 @@ void NVDRV::IoctlBase(Kernel::HLERequestContext& ctx, IoctlVersion version) { | |||
| 60 | 60 | ||
| 61 | if (ctrl.must_delay) { | 61 | if (ctrl.must_delay) { |
| 62 | ctrl.fresh_call = false; | 62 | ctrl.fresh_call = false; |
| 63 | ctx.SleepClientThread("NVServices::DelayedResponse", ctrl.timeout, | 63 | ctx.SleepClientThread( |
| 64 | [=](std::shared_ptr<Kernel::Thread> thread, | 64 | "NVServices::DelayedResponse", ctrl.timeout, |
| 65 | Kernel::HLERequestContext& ctx, | 65 | [=, this](std::shared_ptr<Kernel::Thread> thread, Kernel::HLERequestContext& ctx_, |
| 66 | Kernel::ThreadWakeupReason reason) { | 66 | Kernel::ThreadWakeupReason reason) { |
| 67 | IoctlCtrl ctrl2{ctrl}; | 67 | IoctlCtrl ctrl2{ctrl}; |
| 68 | std::vector<u8> tmp_output = output; | 68 | std::vector<u8> tmp_output = output; |
| 69 | std::vector<u8> tmp_output2 = output2; | 69 | std::vector<u8> tmp_output2 = output2; |
| 70 | u32 result = nvdrv->Ioctl(fd, command, input, input2, tmp_output, | 70 | const u32 ioctl_result = nvdrv->Ioctl(fd, command, input, input2, tmp_output, |
| 71 | tmp_output2, ctrl2, version); | 71 | tmp_output2, ctrl2, version); |
| 72 | ctx.WriteBuffer(tmp_output, 0); | 72 | ctx_.WriteBuffer(tmp_output, 0); |
| 73 | if (version == IoctlVersion::Version3) { | 73 | if (version == IoctlVersion::Version3) { |
| 74 | ctx.WriteBuffer(tmp_output2, 1); | 74 | ctx_.WriteBuffer(tmp_output2, 1); |
| 75 | } | 75 | } |
| 76 | IPC::ResponseBuilder rb{ctx, 3}; | 76 | IPC::ResponseBuilder rb{ctx_, 3}; |
| 77 | rb.Push(RESULT_SUCCESS); | 77 | rb.Push(RESULT_SUCCESS); |
| 78 | rb.Push(result); | 78 | rb.Push(ioctl_result); |
| 79 | }, | 79 | }, |
| 80 | nvdrv->GetEventWriteable(ctrl.event_id)); | 80 | nvdrv->GetEventWriteable(ctrl.event_id)); |
| 81 | } else { | 81 | } else { |
| 82 | ctx.WriteBuffer(output); | 82 | ctx.WriteBuffer(output); |
| 83 | if (version == IoctlVersion::Version3) { | 83 | if (version == IoctlVersion::Version3) { |
diff --git a/src/core/hle/service/set/set.cpp b/src/core/hle/service/set/set.cpp index 34fe2fd82..e64777668 100644 --- a/src/core/hle/service/set/set.cpp +++ b/src/core/hle/service/set/set.cpp | |||
| @@ -106,7 +106,7 @@ void GetKeyCodeMapImpl(Kernel::HLERequestContext& ctx) { | |||
| 106 | 106 | ||
| 107 | IPC::ResponseBuilder rb{ctx, 2}; | 107 | IPC::ResponseBuilder rb{ctx, 2}; |
| 108 | rb.Push(RESULT_SUCCESS); | 108 | rb.Push(RESULT_SUCCESS); |
| 109 | ctx.WriteBuffer(&layout, sizeof(KeyboardLayout)); | 109 | ctx.WriteBuffer(layout); |
| 110 | } | 110 | } |
| 111 | } // Anonymous namespace | 111 | } // Anonymous namespace |
| 112 | 112 | ||
diff --git a/src/core/hle/service/sm/sm.h b/src/core/hle/service/sm/sm.h index b06d2f103..b526a94fe 100644 --- a/src/core/hle/service/sm/sm.h +++ b/src/core/hle/service/sm/sm.h | |||
| @@ -9,6 +9,7 @@ | |||
| 9 | #include <type_traits> | 9 | #include <type_traits> |
| 10 | #include <unordered_map> | 10 | #include <unordered_map> |
| 11 | 11 | ||
| 12 | #include "common/concepts.h" | ||
| 12 | #include "core/hle/kernel/client_port.h" | 13 | #include "core/hle/kernel/client_port.h" |
| 13 | #include "core/hle/kernel/object.h" | 14 | #include "core/hle/kernel/object.h" |
| 14 | #include "core/hle/kernel/server_port.h" | 15 | #include "core/hle/kernel/server_port.h" |
| @@ -56,10 +57,8 @@ public: | |||
| 56 | ResultVal<std::shared_ptr<Kernel::ClientPort>> GetServicePort(const std::string& name); | 57 | ResultVal<std::shared_ptr<Kernel::ClientPort>> GetServicePort(const std::string& name); |
| 57 | ResultVal<std::shared_ptr<Kernel::ClientSession>> ConnectToService(const std::string& name); | 58 | ResultVal<std::shared_ptr<Kernel::ClientSession>> ConnectToService(const std::string& name); |
| 58 | 59 | ||
| 59 | template <typename T> | 60 | template <Common::IsBaseOf<Kernel::SessionRequestHandler> T> |
| 60 | std::shared_ptr<T> GetService(const std::string& service_name) const { | 61 | std::shared_ptr<T> GetService(const std::string& service_name) const { |
| 61 | static_assert(std::is_base_of_v<Kernel::SessionRequestHandler, T>, | ||
| 62 | "Not a base of ServiceFrameworkBase"); | ||
| 63 | auto service = registered_services.find(service_name); | 62 | auto service = registered_services.find(service_name); |
| 64 | if (service == registered_services.end()) { | 63 | if (service == registered_services.end()) { |
| 65 | LOG_DEBUG(Service, "Can't find service: {}", service_name); | 64 | LOG_DEBUG(Service, "Can't find service: {}", service_name); |
diff --git a/src/core/hle/service/time/time.cpp b/src/core/hle/service/time/time.cpp index 13e4b3818..ee4fa4b48 100644 --- a/src/core/hle/service/time/time.cpp +++ b/src/core/hle/service/time/time.cpp | |||
| @@ -290,7 +290,7 @@ void Module::Interface::GetClockSnapshot(Kernel::HLERequestContext& ctx) { | |||
| 290 | 290 | ||
| 291 | IPC::ResponseBuilder rb{ctx, 2}; | 291 | IPC::ResponseBuilder rb{ctx, 2}; |
| 292 | rb.Push(RESULT_SUCCESS); | 292 | rb.Push(RESULT_SUCCESS); |
| 293 | ctx.WriteBuffer(&clock_snapshot, sizeof(Clock::ClockSnapshot)); | 293 | ctx.WriteBuffer(clock_snapshot); |
| 294 | } | 294 | } |
| 295 | 295 | ||
| 296 | void Module::Interface::GetClockSnapshotFromSystemClockContext(Kernel::HLERequestContext& ctx) { | 296 | void Module::Interface::GetClockSnapshotFromSystemClockContext(Kernel::HLERequestContext& ctx) { |
| @@ -313,7 +313,7 @@ void Module::Interface::GetClockSnapshotFromSystemClockContext(Kernel::HLEReques | |||
| 313 | 313 | ||
| 314 | IPC::ResponseBuilder rb{ctx, 2}; | 314 | IPC::ResponseBuilder rb{ctx, 2}; |
| 315 | rb.Push(RESULT_SUCCESS); | 315 | rb.Push(RESULT_SUCCESS); |
| 316 | ctx.WriteBuffer(&clock_snapshot, sizeof(Clock::ClockSnapshot)); | 316 | ctx.WriteBuffer(clock_snapshot); |
| 317 | } | 317 | } |
| 318 | 318 | ||
| 319 | void Module::Interface::CalculateStandardUserSystemClockDifferenceByUser( | 319 | void Module::Interface::CalculateStandardUserSystemClockDifferenceByUser( |
diff --git a/src/core/hle/service/time/time_zone_service.cpp b/src/core/hle/service/time/time_zone_service.cpp index db57ae069..ff3a10b3e 100644 --- a/src/core/hle/service/time/time_zone_service.cpp +++ b/src/core/hle/service/time/time_zone_service.cpp | |||
| @@ -142,7 +142,7 @@ void ITimeZoneService::ToPosixTime(Kernel::HLERequestContext& ctx) { | |||
| 142 | IPC::ResponseBuilder rb{ctx, 3}; | 142 | IPC::ResponseBuilder rb{ctx, 3}; |
| 143 | rb.Push(RESULT_SUCCESS); | 143 | rb.Push(RESULT_SUCCESS); |
| 144 | rb.PushRaw<u32>(1); // Number of times we're returning | 144 | rb.PushRaw<u32>(1); // Number of times we're returning |
| 145 | ctx.WriteBuffer(&posix_time, sizeof(s64)); | 145 | ctx.WriteBuffer(posix_time); |
| 146 | } | 146 | } |
| 147 | 147 | ||
| 148 | void ITimeZoneService::ToPosixTimeWithMyRule(Kernel::HLERequestContext& ctx) { | 148 | void ITimeZoneService::ToPosixTimeWithMyRule(Kernel::HLERequestContext& ctx) { |
| @@ -164,7 +164,7 @@ void ITimeZoneService::ToPosixTimeWithMyRule(Kernel::HLERequestContext& ctx) { | |||
| 164 | IPC::ResponseBuilder rb{ctx, 3}; | 164 | IPC::ResponseBuilder rb{ctx, 3}; |
| 165 | rb.Push(RESULT_SUCCESS); | 165 | rb.Push(RESULT_SUCCESS); |
| 166 | rb.PushRaw<u32>(1); // Number of times we're returning | 166 | rb.PushRaw<u32>(1); // Number of times we're returning |
| 167 | ctx.WriteBuffer(&posix_time, sizeof(s64)); | 167 | ctx.WriteBuffer(posix_time); |
| 168 | } | 168 | } |
| 169 | 169 | ||
| 170 | } // namespace Service::Time | 170 | } // namespace Service::Time |
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp index 825d11a3f..480d34725 100644 --- a/src/core/hle/service/vi/vi.cpp +++ b/src/core/hle/service/vi/vi.cpp | |||
| @@ -548,8 +548,8 @@ private: | |||
| 548 | // Wait the current thread until a buffer becomes available | 548 | // Wait the current thread until a buffer becomes available |
| 549 | ctx.SleepClientThread( | 549 | ctx.SleepClientThread( |
| 550 | "IHOSBinderDriver::DequeueBuffer", UINT64_MAX, | 550 | "IHOSBinderDriver::DequeueBuffer", UINT64_MAX, |
| 551 | [=](std::shared_ptr<Kernel::Thread> thread, Kernel::HLERequestContext& ctx, | 551 | [=, this](std::shared_ptr<Kernel::Thread> thread, |
| 552 | Kernel::ThreadWakeupReason reason) { | 552 | Kernel::HLERequestContext& ctx, Kernel::ThreadWakeupReason reason) { |
| 553 | // Repeat TransactParcel DequeueBuffer when a buffer is available | 553 | // Repeat TransactParcel DequeueBuffer when a buffer is available |
| 554 | const auto guard = nv_flinger->Lock(); | 554 | const auto guard = nv_flinger->Lock(); |
| 555 | auto& buffer_queue = nv_flinger->FindBufferQueue(id); | 555 | auto& buffer_queue = nv_flinger->FindBufferQueue(id); |
| @@ -1199,6 +1199,23 @@ private: | |||
| 1199 | } | 1199 | } |
| 1200 | } | 1200 | } |
| 1201 | 1201 | ||
| 1202 | void GetIndirectLayerImageRequiredMemoryInfo(Kernel::HLERequestContext& ctx) { | ||
| 1203 | IPC::RequestParser rp{ctx}; | ||
| 1204 | const auto width = rp.Pop<u64>(); | ||
| 1205 | const auto height = rp.Pop<u64>(); | ||
| 1206 | LOG_DEBUG(Service_VI, "called width={}, height={}", width, height); | ||
| 1207 | |||
| 1208 | constexpr std::size_t base_size = 0x20000; | ||
| 1209 | constexpr std::size_t alignment = 0x1000; | ||
| 1210 | const auto texture_size = width * height * 4; | ||
| 1211 | const auto out_size = (texture_size + base_size - 1) / base_size * base_size; | ||
| 1212 | |||
| 1213 | IPC::ResponseBuilder rb{ctx, 6}; | ||
| 1214 | rb.Push(RESULT_SUCCESS); | ||
| 1215 | rb.Push(out_size); | ||
| 1216 | rb.Push(alignment); | ||
| 1217 | } | ||
| 1218 | |||
| 1202 | static ResultVal<ConvertedScaleMode> ConvertScalingModeImpl(NintendoScaleMode mode) { | 1219 | static ResultVal<ConvertedScaleMode> ConvertScalingModeImpl(NintendoScaleMode mode) { |
| 1203 | switch (mode) { | 1220 | switch (mode) { |
| 1204 | case NintendoScaleMode::None: | 1221 | case NintendoScaleMode::None: |
| @@ -1243,7 +1260,8 @@ IApplicationDisplayService::IApplicationDisplayService( | |||
| 1243 | {2102, &IApplicationDisplayService::ConvertScalingMode, "ConvertScalingMode"}, | 1260 | {2102, &IApplicationDisplayService::ConvertScalingMode, "ConvertScalingMode"}, |
| 1244 | {2450, nullptr, "GetIndirectLayerImageMap"}, | 1261 | {2450, nullptr, "GetIndirectLayerImageMap"}, |
| 1245 | {2451, nullptr, "GetIndirectLayerImageCropMap"}, | 1262 | {2451, nullptr, "GetIndirectLayerImageCropMap"}, |
| 1246 | {2460, nullptr, "GetIndirectLayerImageRequiredMemoryInfo"}, | 1263 | {2460, &IApplicationDisplayService::GetIndirectLayerImageRequiredMemoryInfo, |
| 1264 | "GetIndirectLayerImageRequiredMemoryInfo"}, | ||
| 1247 | {5202, &IApplicationDisplayService::GetDisplayVsyncEvent, "GetDisplayVsyncEvent"}, | 1265 | {5202, &IApplicationDisplayService::GetDisplayVsyncEvent, "GetDisplayVsyncEvent"}, |
| 1248 | {5203, nullptr, "GetDisplayVsyncEventForDebug"}, | 1266 | {5203, nullptr, "GetDisplayVsyncEventForDebug"}, |
| 1249 | }; | 1267 | }; |
diff --git a/src/core/loader/loader.cpp b/src/core/loader/loader.cpp index 59ca7091a..b8f8f1448 100644 --- a/src/core/loader/loader.cpp +++ b/src/core/loader/loader.cpp | |||
| @@ -3,8 +3,10 @@ | |||
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include <memory> | 5 | #include <memory> |
| 6 | #include <optional> | ||
| 6 | #include <ostream> | 7 | #include <ostream> |
| 7 | #include <string> | 8 | #include <string> |
| 9 | #include "common/concepts.h" | ||
| 8 | #include "common/file_util.h" | 10 | #include "common/file_util.h" |
| 9 | #include "common/logging/log.h" | 11 | #include "common/logging/log.h" |
| 10 | #include "common/string_util.h" | 12 | #include "common/string_util.h" |
| @@ -21,27 +23,41 @@ | |||
| 21 | 23 | ||
| 22 | namespace Loader { | 24 | namespace Loader { |
| 23 | 25 | ||
| 24 | FileType IdentifyFile(FileSys::VirtualFile file) { | 26 | namespace { |
| 25 | FileType type; | ||
| 26 | |||
| 27 | #define CHECK_TYPE(loader) \ | ||
| 28 | type = AppLoader_##loader::IdentifyType(file); \ | ||
| 29 | if (FileType::Error != type) \ | ||
| 30 | return type; | ||
| 31 | 27 | ||
| 32 | CHECK_TYPE(DeconstructedRomDirectory) | 28 | template <Common::IsBaseOf<AppLoader> T> |
| 33 | CHECK_TYPE(ELF) | 29 | std::optional<FileType> IdentifyFileLoader(FileSys::VirtualFile file) { |
| 34 | CHECK_TYPE(NSO) | 30 | const auto file_type = T::IdentifyType(file); |
| 35 | CHECK_TYPE(NRO) | 31 | if (file_type != FileType::Error) { |
| 36 | CHECK_TYPE(NCA) | 32 | return file_type; |
| 37 | CHECK_TYPE(XCI) | 33 | } |
| 38 | CHECK_TYPE(NAX) | 34 | return std::nullopt; |
| 39 | CHECK_TYPE(NSP) | 35 | } |
| 40 | CHECK_TYPE(KIP) | ||
| 41 | 36 | ||
| 42 | #undef CHECK_TYPE | 37 | } // namespace |
| 43 | 38 | ||
| 44 | return FileType::Unknown; | 39 | FileType IdentifyFile(FileSys::VirtualFile file) { |
| 40 | if (const auto romdir_type = IdentifyFileLoader<AppLoader_DeconstructedRomDirectory>(file)) { | ||
| 41 | return *romdir_type; | ||
| 42 | } else if (const auto elf_type = IdentifyFileLoader<AppLoader_ELF>(file)) { | ||
| 43 | return *elf_type; | ||
| 44 | } else if (const auto nso_type = IdentifyFileLoader<AppLoader_NSO>(file)) { | ||
| 45 | return *nso_type; | ||
| 46 | } else if (const auto nro_type = IdentifyFileLoader<AppLoader_NRO>(file)) { | ||
| 47 | return *nro_type; | ||
| 48 | } else if (const auto nca_type = IdentifyFileLoader<AppLoader_NCA>(file)) { | ||
| 49 | return *nca_type; | ||
| 50 | } else if (const auto xci_type = IdentifyFileLoader<AppLoader_XCI>(file)) { | ||
| 51 | return *xci_type; | ||
| 52 | } else if (const auto nax_type = IdentifyFileLoader<AppLoader_NAX>(file)) { | ||
| 53 | return *nax_type; | ||
| 54 | } else if (const auto nsp_type = IdentifyFileLoader<AppLoader_NSP>(file)) { | ||
| 55 | return *nsp_type; | ||
| 56 | } else if (const auto kip_type = IdentifyFileLoader<AppLoader_KIP>(file)) { | ||
| 57 | return *kip_type; | ||
| 58 | } else { | ||
| 59 | return FileType::Unknown; | ||
| 60 | } | ||
| 45 | } | 61 | } |
| 46 | 62 | ||
| 47 | FileType GuessFromFilename(const std::string& name) { | 63 | FileType GuessFromFilename(const std::string& name) { |
diff --git a/src/core/memory.cpp b/src/core/memory.cpp index 2c5588933..86d17c6cb 100644 --- a/src/core/memory.cpp +++ b/src/core/memory.cpp | |||
| @@ -704,7 +704,7 @@ struct Memory::Impl { | |||
| 704 | u8* page_pointer = current_page_table->pointers[vaddr >> PAGE_BITS]; | 704 | u8* page_pointer = current_page_table->pointers[vaddr >> PAGE_BITS]; |
| 705 | if (page_pointer != nullptr) { | 705 | if (page_pointer != nullptr) { |
| 706 | // NOTE: Avoid adding any extra logic to this fast-path block | 706 | // NOTE: Avoid adding any extra logic to this fast-path block |
| 707 | T volatile* pointer = reinterpret_cast<T volatile*>(&page_pointer[vaddr]); | 707 | auto* pointer = reinterpret_cast<volatile T*>(&page_pointer[vaddr]); |
| 708 | return Common::AtomicCompareAndSwap(pointer, data, expected); | 708 | return Common::AtomicCompareAndSwap(pointer, data, expected); |
| 709 | } | 709 | } |
| 710 | 710 | ||
| @@ -720,9 +720,8 @@ struct Memory::Impl { | |||
| 720 | case Common::PageType::RasterizerCachedMemory: { | 720 | case Common::PageType::RasterizerCachedMemory: { |
| 721 | u8* host_ptr{GetPointerFromRasterizerCachedMemory(vaddr)}; | 721 | u8* host_ptr{GetPointerFromRasterizerCachedMemory(vaddr)}; |
| 722 | system.GPU().InvalidateRegion(vaddr, sizeof(T)); | 722 | system.GPU().InvalidateRegion(vaddr, sizeof(T)); |
| 723 | T volatile* pointer = reinterpret_cast<T volatile*>(&host_ptr); | 723 | auto* pointer = reinterpret_cast<volatile T*>(&host_ptr); |
| 724 | return Common::AtomicCompareAndSwap(pointer, data, expected); | 724 | return Common::AtomicCompareAndSwap(pointer, data, expected); |
| 725 | break; | ||
| 726 | } | 725 | } |
| 727 | default: | 726 | default: |
| 728 | UNREACHABLE(); | 727 | UNREACHABLE(); |
| @@ -734,7 +733,7 @@ struct Memory::Impl { | |||
| 734 | u8* const page_pointer = current_page_table->pointers[vaddr >> PAGE_BITS]; | 733 | u8* const page_pointer = current_page_table->pointers[vaddr >> PAGE_BITS]; |
| 735 | if (page_pointer != nullptr) { | 734 | if (page_pointer != nullptr) { |
| 736 | // NOTE: Avoid adding any extra logic to this fast-path block | 735 | // NOTE: Avoid adding any extra logic to this fast-path block |
| 737 | u64 volatile* pointer = reinterpret_cast<u64 volatile*>(&page_pointer[vaddr]); | 736 | auto* pointer = reinterpret_cast<volatile u64*>(&page_pointer[vaddr]); |
| 738 | return Common::AtomicCompareAndSwap(pointer, data, expected); | 737 | return Common::AtomicCompareAndSwap(pointer, data, expected); |
| 739 | } | 738 | } |
| 740 | 739 | ||
| @@ -750,9 +749,8 @@ struct Memory::Impl { | |||
| 750 | case Common::PageType::RasterizerCachedMemory: { | 749 | case Common::PageType::RasterizerCachedMemory: { |
| 751 | u8* host_ptr{GetPointerFromRasterizerCachedMemory(vaddr)}; | 750 | u8* host_ptr{GetPointerFromRasterizerCachedMemory(vaddr)}; |
| 752 | system.GPU().InvalidateRegion(vaddr, sizeof(u128)); | 751 | system.GPU().InvalidateRegion(vaddr, sizeof(u128)); |
| 753 | u64 volatile* pointer = reinterpret_cast<u64 volatile*>(&host_ptr); | 752 | auto* pointer = reinterpret_cast<volatile u64*>(&host_ptr); |
| 754 | return Common::AtomicCompareAndSwap(pointer, data, expected); | 753 | return Common::AtomicCompareAndSwap(pointer, data, expected); |
| 755 | break; | ||
| 756 | } | 754 | } |
| 757 | default: | 755 | default: |
| 758 | UNREACHABLE(); | 756 | UNREACHABLE(); |
diff --git a/src/core/memory/dmnt_cheat_vm.cpp b/src/core/memory/dmnt_cheat_vm.cpp index 2e7da23fe..48be80c12 100644 --- a/src/core/memory/dmnt_cheat_vm.cpp +++ b/src/core/memory/dmnt_cheat_vm.cpp | |||
| @@ -313,30 +313,32 @@ bool DmntCheatVm::DecodeNextOpcode(CheatVmOpcode& out) { | |||
| 313 | 313 | ||
| 314 | switch (opcode_type) { | 314 | switch (opcode_type) { |
| 315 | case CheatVmOpcodeType::StoreStatic: { | 315 | case CheatVmOpcodeType::StoreStatic: { |
| 316 | StoreStaticOpcode store_static{}; | ||
| 317 | // 0TMR00AA AAAAAAAA YYYYYYYY (YYYYYYYY) | 316 | // 0TMR00AA AAAAAAAA YYYYYYYY (YYYYYYYY) |
| 318 | // Read additional words. | 317 | // Read additional words. |
| 319 | const u32 second_dword = GetNextDword(); | 318 | const u32 second_dword = GetNextDword(); |
| 320 | store_static.bit_width = (first_dword >> 24) & 0xF; | 319 | const u32 bit_width = (first_dword >> 24) & 0xF; |
| 321 | store_static.mem_type = static_cast<MemoryAccessType>((first_dword >> 20) & 0xF); | 320 | |
| 322 | store_static.offset_register = ((first_dword >> 16) & 0xF); | 321 | opcode.opcode = StoreStaticOpcode{ |
| 323 | store_static.rel_address = | 322 | .bit_width = bit_width, |
| 324 | (static_cast<u64>(first_dword & 0xFF) << 32ul) | static_cast<u64>(second_dword); | 323 | .mem_type = static_cast<MemoryAccessType>((first_dword >> 20) & 0xF), |
| 325 | store_static.value = GetNextVmInt(store_static.bit_width); | 324 | .offset_register = (first_dword >> 16) & 0xF, |
| 326 | opcode.opcode = store_static; | 325 | .rel_address = (static_cast<u64>(first_dword & 0xFF) << 32) | second_dword, |
| 326 | .value = GetNextVmInt(bit_width), | ||
| 327 | }; | ||
| 327 | } break; | 328 | } break; |
| 328 | case CheatVmOpcodeType::BeginConditionalBlock: { | 329 | case CheatVmOpcodeType::BeginConditionalBlock: { |
| 329 | BeginConditionalOpcode begin_cond{}; | ||
| 330 | // 1TMC00AA AAAAAAAA YYYYYYYY (YYYYYYYY) | 330 | // 1TMC00AA AAAAAAAA YYYYYYYY (YYYYYYYY) |
| 331 | // Read additional words. | 331 | // Read additional words. |
| 332 | const u32 second_dword = GetNextDword(); | 332 | const u32 second_dword = GetNextDword(); |
| 333 | begin_cond.bit_width = (first_dword >> 24) & 0xF; | 333 | const u32 bit_width = (first_dword >> 24) & 0xF; |
| 334 | begin_cond.mem_type = static_cast<MemoryAccessType>((first_dword >> 20) & 0xF); | 334 | |
| 335 | begin_cond.cond_type = static_cast<ConditionalComparisonType>((first_dword >> 16) & 0xF); | 335 | opcode.opcode = BeginConditionalOpcode{ |
| 336 | begin_cond.rel_address = | 336 | .bit_width = bit_width, |
| 337 | (static_cast<u64>(first_dword & 0xFF) << 32ul) | static_cast<u64>(second_dword); | 337 | .mem_type = static_cast<MemoryAccessType>((first_dword >> 20) & 0xF), |
| 338 | begin_cond.value = GetNextVmInt(begin_cond.bit_width); | 338 | .cond_type = static_cast<ConditionalComparisonType>((first_dword >> 16) & 0xF), |
| 339 | opcode.opcode = begin_cond; | 339 | .rel_address = (static_cast<u64>(first_dword & 0xFF) << 32) | second_dword, |
| 340 | .value = GetNextVmInt(bit_width), | ||
| 341 | }; | ||
| 340 | } break; | 342 | } break; |
| 341 | case CheatVmOpcodeType::EndConditionalBlock: { | 343 | case CheatVmOpcodeType::EndConditionalBlock: { |
| 342 | // 20000000 | 344 | // 20000000 |
| @@ -344,12 +346,14 @@ bool DmntCheatVm::DecodeNextOpcode(CheatVmOpcode& out) { | |||
| 344 | opcode.opcode = EndConditionalOpcode{}; | 346 | opcode.opcode = EndConditionalOpcode{}; |
| 345 | } break; | 347 | } break; |
| 346 | case CheatVmOpcodeType::ControlLoop: { | 348 | case CheatVmOpcodeType::ControlLoop: { |
| 347 | ControlLoopOpcode ctrl_loop{}; | ||
| 348 | // 300R0000 VVVVVVVV | 349 | // 300R0000 VVVVVVVV |
| 349 | // 310R0000 | 350 | // 310R0000 |
| 350 | // Parse register, whether loop start or loop end. | 351 | // Parse register, whether loop start or loop end. |
| 351 | ctrl_loop.start_loop = ((first_dword >> 24) & 0xF) == 0; | 352 | ControlLoopOpcode ctrl_loop{ |
| 352 | ctrl_loop.reg_index = ((first_dword >> 20) & 0xF); | 353 | .start_loop = ((first_dword >> 24) & 0xF) == 0, |
| 354 | .reg_index = (first_dword >> 20) & 0xF, | ||
| 355 | .num_iters = 0, | ||
| 356 | }; | ||
| 353 | 357 | ||
| 354 | // Read number of iters if loop start. | 358 | // Read number of iters if loop start. |
| 355 | if (ctrl_loop.start_loop) { | 359 | if (ctrl_loop.start_loop) { |
| @@ -358,66 +362,65 @@ bool DmntCheatVm::DecodeNextOpcode(CheatVmOpcode& out) { | |||
| 358 | opcode.opcode = ctrl_loop; | 362 | opcode.opcode = ctrl_loop; |
| 359 | } break; | 363 | } break; |
| 360 | case CheatVmOpcodeType::LoadRegisterStatic: { | 364 | case CheatVmOpcodeType::LoadRegisterStatic: { |
| 361 | LoadRegisterStaticOpcode ldr_static{}; | ||
| 362 | // 400R0000 VVVVVVVV VVVVVVVV | 365 | // 400R0000 VVVVVVVV VVVVVVVV |
| 363 | // Read additional words. | 366 | // Read additional words. |
| 364 | ldr_static.reg_index = ((first_dword >> 16) & 0xF); | 367 | opcode.opcode = LoadRegisterStaticOpcode{ |
| 365 | ldr_static.value = | 368 | .reg_index = (first_dword >> 16) & 0xF, |
| 366 | (static_cast<u64>(GetNextDword()) << 32ul) | static_cast<u64>(GetNextDword()); | 369 | .value = (static_cast<u64>(GetNextDword()) << 32) | GetNextDword(), |
| 367 | opcode.opcode = ldr_static; | 370 | }; |
| 368 | } break; | 371 | } break; |
| 369 | case CheatVmOpcodeType::LoadRegisterMemory: { | 372 | case CheatVmOpcodeType::LoadRegisterMemory: { |
| 370 | LoadRegisterMemoryOpcode ldr_memory{}; | ||
| 371 | // 5TMRI0AA AAAAAAAA | 373 | // 5TMRI0AA AAAAAAAA |
| 372 | // Read additional words. | 374 | // Read additional words. |
| 373 | const u32 second_dword = GetNextDword(); | 375 | const u32 second_dword = GetNextDword(); |
| 374 | ldr_memory.bit_width = (first_dword >> 24) & 0xF; | 376 | opcode.opcode = LoadRegisterMemoryOpcode{ |
| 375 | ldr_memory.mem_type = static_cast<MemoryAccessType>((first_dword >> 20) & 0xF); | 377 | .bit_width = (first_dword >> 24) & 0xF, |
| 376 | ldr_memory.reg_index = ((first_dword >> 16) & 0xF); | 378 | .mem_type = static_cast<MemoryAccessType>((first_dword >> 20) & 0xF), |
| 377 | ldr_memory.load_from_reg = ((first_dword >> 12) & 0xF) != 0; | 379 | .reg_index = ((first_dword >> 16) & 0xF), |
| 378 | ldr_memory.rel_address = | 380 | .load_from_reg = ((first_dword >> 12) & 0xF) != 0, |
| 379 | (static_cast<u64>(first_dword & 0xFF) << 32ul) | static_cast<u64>(second_dword); | 381 | .rel_address = (static_cast<u64>(first_dword & 0xFF) << 32) | second_dword, |
| 380 | opcode.opcode = ldr_memory; | 382 | }; |
| 381 | } break; | 383 | } break; |
| 382 | case CheatVmOpcodeType::StoreStaticToAddress: { | 384 | case CheatVmOpcodeType::StoreStaticToAddress: { |
| 383 | StoreStaticToAddressOpcode str_static{}; | ||
| 384 | // 6T0RIor0 VVVVVVVV VVVVVVVV | 385 | // 6T0RIor0 VVVVVVVV VVVVVVVV |
| 385 | // Read additional words. | 386 | // Read additional words. |
| 386 | str_static.bit_width = (first_dword >> 24) & 0xF; | 387 | opcode.opcode = StoreStaticToAddressOpcode{ |
| 387 | str_static.reg_index = ((first_dword >> 16) & 0xF); | 388 | .bit_width = (first_dword >> 24) & 0xF, |
| 388 | str_static.increment_reg = ((first_dword >> 12) & 0xF) != 0; | 389 | .reg_index = (first_dword >> 16) & 0xF, |
| 389 | str_static.add_offset_reg = ((first_dword >> 8) & 0xF) != 0; | 390 | .increment_reg = ((first_dword >> 12) & 0xF) != 0, |
| 390 | str_static.offset_reg_index = ((first_dword >> 4) & 0xF); | 391 | .add_offset_reg = ((first_dword >> 8) & 0xF) != 0, |
| 391 | str_static.value = | 392 | .offset_reg_index = (first_dword >> 4) & 0xF, |
| 392 | (static_cast<u64>(GetNextDword()) << 32ul) | static_cast<u64>(GetNextDword()); | 393 | .value = (static_cast<u64>(GetNextDword()) << 32) | GetNextDword(), |
| 393 | opcode.opcode = str_static; | 394 | }; |
| 394 | } break; | 395 | } break; |
| 395 | case CheatVmOpcodeType::PerformArithmeticStatic: { | 396 | case CheatVmOpcodeType::PerformArithmeticStatic: { |
| 396 | PerformArithmeticStaticOpcode perform_math_static{}; | ||
| 397 | // 7T0RC000 VVVVVVVV | 397 | // 7T0RC000 VVVVVVVV |
| 398 | // Read additional words. | 398 | // Read additional words. |
| 399 | perform_math_static.bit_width = (first_dword >> 24) & 0xF; | 399 | opcode.opcode = PerformArithmeticStaticOpcode{ |
| 400 | perform_math_static.reg_index = ((first_dword >> 16) & 0xF); | 400 | .bit_width = (first_dword >> 24) & 0xF, |
| 401 | perform_math_static.math_type = | 401 | .reg_index = ((first_dword >> 16) & 0xF), |
| 402 | static_cast<RegisterArithmeticType>((first_dword >> 12) & 0xF); | 402 | .math_type = static_cast<RegisterArithmeticType>((first_dword >> 12) & 0xF), |
| 403 | perform_math_static.value = GetNextDword(); | 403 | .value = GetNextDword(), |
| 404 | opcode.opcode = perform_math_static; | 404 | }; |
| 405 | } break; | 405 | } break; |
| 406 | case CheatVmOpcodeType::BeginKeypressConditionalBlock: { | 406 | case CheatVmOpcodeType::BeginKeypressConditionalBlock: { |
| 407 | BeginKeypressConditionalOpcode begin_keypress_cond{}; | ||
| 408 | // 8kkkkkkk | 407 | // 8kkkkkkk |
| 409 | // Just parse the mask. | 408 | // Just parse the mask. |
| 410 | begin_keypress_cond.key_mask = first_dword & 0x0FFFFFFF; | 409 | opcode.opcode = BeginKeypressConditionalOpcode{ |
| 411 | opcode.opcode = begin_keypress_cond; | 410 | .key_mask = first_dword & 0x0FFFFFFF, |
| 411 | }; | ||
| 412 | } break; | 412 | } break; |
| 413 | case CheatVmOpcodeType::PerformArithmeticRegister: { | 413 | case CheatVmOpcodeType::PerformArithmeticRegister: { |
| 414 | PerformArithmeticRegisterOpcode perform_math_reg{}; | ||
| 415 | // 9TCRSIs0 (VVVVVVVV (VVVVVVVV)) | 414 | // 9TCRSIs0 (VVVVVVVV (VVVVVVVV)) |
| 416 | perform_math_reg.bit_width = (first_dword >> 24) & 0xF; | 415 | PerformArithmeticRegisterOpcode perform_math_reg{ |
| 417 | perform_math_reg.math_type = static_cast<RegisterArithmeticType>((first_dword >> 20) & 0xF); | 416 | .bit_width = (first_dword >> 24) & 0xF, |
| 418 | perform_math_reg.dst_reg_index = ((first_dword >> 16) & 0xF); | 417 | .math_type = static_cast<RegisterArithmeticType>((first_dword >> 20) & 0xF), |
| 419 | perform_math_reg.src_reg_1_index = ((first_dword >> 12) & 0xF); | 418 | .dst_reg_index = (first_dword >> 16) & 0xF, |
| 420 | perform_math_reg.has_immediate = ((first_dword >> 8) & 0xF) != 0; | 419 | .src_reg_1_index = (first_dword >> 12) & 0xF, |
| 420 | .src_reg_2_index = 0, | ||
| 421 | .has_immediate = ((first_dword >> 8) & 0xF) != 0, | ||
| 422 | .value = {}, | ||
| 423 | }; | ||
| 421 | if (perform_math_reg.has_immediate) { | 424 | if (perform_math_reg.has_immediate) { |
| 422 | perform_math_reg.src_reg_2_index = 0; | 425 | perform_math_reg.src_reg_2_index = 0; |
| 423 | perform_math_reg.value = GetNextVmInt(perform_math_reg.bit_width); | 426 | perform_math_reg.value = GetNextVmInt(perform_math_reg.bit_width); |
| @@ -427,7 +430,6 @@ bool DmntCheatVm::DecodeNextOpcode(CheatVmOpcode& out) { | |||
| 427 | opcode.opcode = perform_math_reg; | 430 | opcode.opcode = perform_math_reg; |
| 428 | } break; | 431 | } break; |
| 429 | case CheatVmOpcodeType::StoreRegisterToAddress: { | 432 | case CheatVmOpcodeType::StoreRegisterToAddress: { |
| 430 | StoreRegisterToAddressOpcode str_register{}; | ||
| 431 | // ATSRIOxa (aaaaaaaa) | 433 | // ATSRIOxa (aaaaaaaa) |
| 432 | // A = opcode 10 | 434 | // A = opcode 10 |
| 433 | // T = bit width | 435 | // T = bit width |
| @@ -439,20 +441,23 @@ bool DmntCheatVm::DecodeNextOpcode(CheatVmOpcode& out) { | |||
| 439 | // Relative Address | 441 | // Relative Address |
| 440 | // x = offset register (for offset type 1), memory type (for offset type 3) | 442 | // x = offset register (for offset type 1), memory type (for offset type 3) |
| 441 | // a = relative address (for offset type 2+3) | 443 | // a = relative address (for offset type 2+3) |
| 442 | str_register.bit_width = (first_dword >> 24) & 0xF; | 444 | StoreRegisterToAddressOpcode str_register{ |
| 443 | str_register.str_reg_index = ((first_dword >> 20) & 0xF); | 445 | .bit_width = (first_dword >> 24) & 0xF, |
| 444 | str_register.addr_reg_index = ((first_dword >> 16) & 0xF); | 446 | .str_reg_index = (first_dword >> 20) & 0xF, |
| 445 | str_register.increment_reg = ((first_dword >> 12) & 0xF) != 0; | 447 | .addr_reg_index = (first_dword >> 16) & 0xF, |
| 446 | str_register.ofs_type = static_cast<StoreRegisterOffsetType>(((first_dword >> 8) & 0xF)); | 448 | .increment_reg = ((first_dword >> 12) & 0xF) != 0, |
| 447 | str_register.ofs_reg_index = ((first_dword >> 4) & 0xF); | 449 | .ofs_type = static_cast<StoreRegisterOffsetType>(((first_dword >> 8) & 0xF)), |
| 450 | .mem_type = MemoryAccessType::MainNso, | ||
| 451 | .ofs_reg_index = (first_dword >> 4) & 0xF, | ||
| 452 | .rel_address = 0, | ||
| 453 | }; | ||
| 448 | switch (str_register.ofs_type) { | 454 | switch (str_register.ofs_type) { |
| 449 | case StoreRegisterOffsetType::None: | 455 | case StoreRegisterOffsetType::None: |
| 450 | case StoreRegisterOffsetType::Reg: | 456 | case StoreRegisterOffsetType::Reg: |
| 451 | // Nothing more to do | 457 | // Nothing more to do |
| 452 | break; | 458 | break; |
| 453 | case StoreRegisterOffsetType::Imm: | 459 | case StoreRegisterOffsetType::Imm: |
| 454 | str_register.rel_address = | 460 | str_register.rel_address = (static_cast<u64>(first_dword & 0xF) << 32) | GetNextDword(); |
| 455 | ((static_cast<u64>(first_dword & 0xF) << 32ul) | static_cast<u64>(GetNextDword())); | ||
| 456 | break; | 461 | break; |
| 457 | case StoreRegisterOffsetType::MemReg: | 462 | case StoreRegisterOffsetType::MemReg: |
| 458 | str_register.mem_type = static_cast<MemoryAccessType>((first_dword >> 4) & 0xF); | 463 | str_register.mem_type = static_cast<MemoryAccessType>((first_dword >> 4) & 0xF); |
| @@ -460,8 +465,7 @@ bool DmntCheatVm::DecodeNextOpcode(CheatVmOpcode& out) { | |||
| 460 | case StoreRegisterOffsetType::MemImm: | 465 | case StoreRegisterOffsetType::MemImm: |
| 461 | case StoreRegisterOffsetType::MemImmReg: | 466 | case StoreRegisterOffsetType::MemImmReg: |
| 462 | str_register.mem_type = static_cast<MemoryAccessType>((first_dword >> 4) & 0xF); | 467 | str_register.mem_type = static_cast<MemoryAccessType>((first_dword >> 4) & 0xF); |
| 463 | str_register.rel_address = | 468 | str_register.rel_address = (static_cast<u64>(first_dword & 0xF) << 32) | GetNextDword(); |
| 464 | ((static_cast<u64>(first_dword & 0xF) << 32ul) | static_cast<u64>(GetNextDword())); | ||
| 465 | break; | 469 | break; |
| 466 | default: | 470 | default: |
| 467 | str_register.ofs_type = StoreRegisterOffsetType::None; | 471 | str_register.ofs_type = StoreRegisterOffsetType::None; |
| @@ -470,7 +474,6 @@ bool DmntCheatVm::DecodeNextOpcode(CheatVmOpcode& out) { | |||
| 470 | opcode.opcode = str_register; | 474 | opcode.opcode = str_register; |
| 471 | } break; | 475 | } break; |
| 472 | case CheatVmOpcodeType::BeginRegisterConditionalBlock: { | 476 | case CheatVmOpcodeType::BeginRegisterConditionalBlock: { |
| 473 | BeginRegisterConditionalOpcode begin_reg_cond{}; | ||
| 474 | // C0TcSX## | 477 | // C0TcSX## |
| 475 | // C0TcS0Ma aaaaaaaa | 478 | // C0TcS0Ma aaaaaaaa |
| 476 | // C0TcS1Mr | 479 | // C0TcS1Mr |
| @@ -492,11 +495,19 @@ bool DmntCheatVm::DecodeNextOpcode(CheatVmOpcode& out) { | |||
| 492 | // r = offset register. | 495 | // r = offset register. |
| 493 | // X = other register. | 496 | // X = other register. |
| 494 | // V = value. | 497 | // V = value. |
| 495 | begin_reg_cond.bit_width = (first_dword >> 20) & 0xF; | 498 | |
| 496 | begin_reg_cond.cond_type = | 499 | BeginRegisterConditionalOpcode begin_reg_cond{ |
| 497 | static_cast<ConditionalComparisonType>((first_dword >> 16) & 0xF); | 500 | .bit_width = (first_dword >> 20) & 0xF, |
| 498 | begin_reg_cond.val_reg_index = ((first_dword >> 12) & 0xF); | 501 | .cond_type = static_cast<ConditionalComparisonType>((first_dword >> 16) & 0xF), |
| 499 | begin_reg_cond.comp_type = static_cast<CompareRegisterValueType>((first_dword >> 8) & 0xF); | 502 | .val_reg_index = (first_dword >> 12) & 0xF, |
| 503 | .comp_type = static_cast<CompareRegisterValueType>((first_dword >> 8) & 0xF), | ||
| 504 | .mem_type = MemoryAccessType::MainNso, | ||
| 505 | .addr_reg_index = 0, | ||
| 506 | .other_reg_index = 0, | ||
| 507 | .ofs_reg_index = 0, | ||
| 508 | .rel_address = 0, | ||
| 509 | .value = {}, | ||
| 510 | }; | ||
| 500 | 511 | ||
| 501 | switch (begin_reg_cond.comp_type) { | 512 | switch (begin_reg_cond.comp_type) { |
| 502 | case CompareRegisterValueType::StaticValue: | 513 | case CompareRegisterValueType::StaticValue: |
| @@ -508,26 +519,25 @@ bool DmntCheatVm::DecodeNextOpcode(CheatVmOpcode& out) { | |||
| 508 | case CompareRegisterValueType::MemoryRelAddr: | 519 | case CompareRegisterValueType::MemoryRelAddr: |
| 509 | begin_reg_cond.mem_type = static_cast<MemoryAccessType>((first_dword >> 4) & 0xF); | 520 | begin_reg_cond.mem_type = static_cast<MemoryAccessType>((first_dword >> 4) & 0xF); |
| 510 | begin_reg_cond.rel_address = | 521 | begin_reg_cond.rel_address = |
| 511 | ((static_cast<u64>(first_dword & 0xF) << 32ul) | static_cast<u64>(GetNextDword())); | 522 | (static_cast<u64>(first_dword & 0xF) << 32) | GetNextDword(); |
| 512 | break; | 523 | break; |
| 513 | case CompareRegisterValueType::MemoryOfsReg: | 524 | case CompareRegisterValueType::MemoryOfsReg: |
| 514 | begin_reg_cond.mem_type = static_cast<MemoryAccessType>((first_dword >> 4) & 0xF); | 525 | begin_reg_cond.mem_type = static_cast<MemoryAccessType>((first_dword >> 4) & 0xF); |
| 515 | begin_reg_cond.ofs_reg_index = (first_dword & 0xF); | 526 | begin_reg_cond.ofs_reg_index = (first_dword & 0xF); |
| 516 | break; | 527 | break; |
| 517 | case CompareRegisterValueType::RegisterRelAddr: | 528 | case CompareRegisterValueType::RegisterRelAddr: |
| 518 | begin_reg_cond.addr_reg_index = ((first_dword >> 4) & 0xF); | 529 | begin_reg_cond.addr_reg_index = (first_dword >> 4) & 0xF; |
| 519 | begin_reg_cond.rel_address = | 530 | begin_reg_cond.rel_address = |
| 520 | ((static_cast<u64>(first_dword & 0xF) << 32ul) | static_cast<u64>(GetNextDword())); | 531 | (static_cast<u64>(first_dword & 0xF) << 32) | GetNextDword(); |
| 521 | break; | 532 | break; |
| 522 | case CompareRegisterValueType::RegisterOfsReg: | 533 | case CompareRegisterValueType::RegisterOfsReg: |
| 523 | begin_reg_cond.addr_reg_index = ((first_dword >> 4) & 0xF); | 534 | begin_reg_cond.addr_reg_index = (first_dword >> 4) & 0xF; |
| 524 | begin_reg_cond.ofs_reg_index = (first_dword & 0xF); | 535 | begin_reg_cond.ofs_reg_index = first_dword & 0xF; |
| 525 | break; | 536 | break; |
| 526 | } | 537 | } |
| 527 | opcode.opcode = begin_reg_cond; | 538 | opcode.opcode = begin_reg_cond; |
| 528 | } break; | 539 | } break; |
| 529 | case CheatVmOpcodeType::SaveRestoreRegister: { | 540 | case CheatVmOpcodeType::SaveRestoreRegister: { |
| 530 | SaveRestoreRegisterOpcode save_restore_reg{}; | ||
| 531 | // C10D0Sx0 | 541 | // C10D0Sx0 |
| 532 | // C1 = opcode 0xC1 | 542 | // C1 = opcode 0xC1 |
| 533 | // D = destination index. | 543 | // D = destination index. |
| @@ -535,36 +545,37 @@ bool DmntCheatVm::DecodeNextOpcode(CheatVmOpcode& out) { | |||
| 535 | // x = 3 if clearing reg, 2 if clearing saved value, 1 if saving a register, 0 if restoring | 545 | // x = 3 if clearing reg, 2 if clearing saved value, 1 if saving a register, 0 if restoring |
| 536 | // a register. | 546 | // a register. |
| 537 | // NOTE: If we add more save slots later, current encoding is backwards compatible. | 547 | // NOTE: If we add more save slots later, current encoding is backwards compatible. |
| 538 | save_restore_reg.dst_index = (first_dword >> 16) & 0xF; | 548 | opcode.opcode = SaveRestoreRegisterOpcode{ |
| 539 | save_restore_reg.src_index = (first_dword >> 8) & 0xF; | 549 | .dst_index = (first_dword >> 16) & 0xF, |
| 540 | save_restore_reg.op_type = static_cast<SaveRestoreRegisterOpType>((first_dword >> 4) & 0xF); | 550 | .src_index = (first_dword >> 8) & 0xF, |
| 541 | opcode.opcode = save_restore_reg; | 551 | .op_type = static_cast<SaveRestoreRegisterOpType>((first_dword >> 4) & 0xF), |
| 552 | }; | ||
| 542 | } break; | 553 | } break; |
| 543 | case CheatVmOpcodeType::SaveRestoreRegisterMask: { | 554 | case CheatVmOpcodeType::SaveRestoreRegisterMask: { |
| 544 | SaveRestoreRegisterMaskOpcode save_restore_regmask{}; | ||
| 545 | // C2x0XXXX | 555 | // C2x0XXXX |
| 546 | // C2 = opcode 0xC2 | 556 | // C2 = opcode 0xC2 |
| 547 | // x = 3 if clearing reg, 2 if clearing saved value, 1 if saving, 0 if restoring. | 557 | // x = 3 if clearing reg, 2 if clearing saved value, 1 if saving, 0 if restoring. |
| 548 | // X = 16-bit bitmask, bit i --> save or restore register i. | 558 | // X = 16-bit bitmask, bit i --> save or restore register i. |
| 549 | save_restore_regmask.op_type = | 559 | SaveRestoreRegisterMaskOpcode save_restore_regmask{ |
| 550 | static_cast<SaveRestoreRegisterOpType>((first_dword >> 20) & 0xF); | 560 | .op_type = static_cast<SaveRestoreRegisterOpType>((first_dword >> 20) & 0xF), |
| 561 | .should_operate = {}, | ||
| 562 | }; | ||
| 551 | for (std::size_t i = 0; i < NumRegisters; i++) { | 563 | for (std::size_t i = 0; i < NumRegisters; i++) { |
| 552 | save_restore_regmask.should_operate[i] = (first_dword & (1u << i)) != 0; | 564 | save_restore_regmask.should_operate[i] = (first_dword & (1U << i)) != 0; |
| 553 | } | 565 | } |
| 554 | opcode.opcode = save_restore_regmask; | 566 | opcode.opcode = save_restore_regmask; |
| 555 | } break; | 567 | } break; |
| 556 | case CheatVmOpcodeType::ReadWriteStaticRegister: { | 568 | case CheatVmOpcodeType::ReadWriteStaticRegister: { |
| 557 | ReadWriteStaticRegisterOpcode rw_static_reg{}; | ||
| 558 | // C3000XXx | 569 | // C3000XXx |
| 559 | // C3 = opcode 0xC3. | 570 | // C3 = opcode 0xC3. |
| 560 | // XX = static register index. | 571 | // XX = static register index. |
| 561 | // x = register index. | 572 | // x = register index. |
| 562 | rw_static_reg.static_idx = ((first_dword >> 4) & 0xFF); | 573 | opcode.opcode = ReadWriteStaticRegisterOpcode{ |
| 563 | rw_static_reg.idx = (first_dword & 0xF); | 574 | .static_idx = (first_dword >> 4) & 0xFF, |
| 564 | opcode.opcode = rw_static_reg; | 575 | .idx = first_dword & 0xF, |
| 576 | }; | ||
| 565 | } break; | 577 | } break; |
| 566 | case CheatVmOpcodeType::DebugLog: { | 578 | case CheatVmOpcodeType::DebugLog: { |
| 567 | DebugLogOpcode debug_log{}; | ||
| 568 | // FFFTIX## | 579 | // FFFTIX## |
| 569 | // FFFTI0Ma aaaaaaaa | 580 | // FFFTI0Ma aaaaaaaa |
| 570 | // FFFTI1Mr | 581 | // FFFTI1Mr |
| @@ -583,31 +594,36 @@ bool DmntCheatVm::DecodeNextOpcode(CheatVmOpcode& out) { | |||
| 583 | // a = relative address. | 594 | // a = relative address. |
| 584 | // r = offset register. | 595 | // r = offset register. |
| 585 | // X = value register. | 596 | // X = value register. |
| 586 | debug_log.bit_width = (first_dword >> 16) & 0xF; | 597 | DebugLogOpcode debug_log{ |
| 587 | debug_log.log_id = ((first_dword >> 12) & 0xF); | 598 | .bit_width = (first_dword >> 16) & 0xF, |
| 588 | debug_log.val_type = static_cast<DebugLogValueType>((first_dword >> 8) & 0xF); | 599 | .log_id = (first_dword >> 12) & 0xF, |
| 600 | .val_type = static_cast<DebugLogValueType>((first_dword >> 8) & 0xF), | ||
| 601 | .mem_type = MemoryAccessType::MainNso, | ||
| 602 | .addr_reg_index = 0, | ||
| 603 | .val_reg_index = 0, | ||
| 604 | .ofs_reg_index = 0, | ||
| 605 | .rel_address = 0, | ||
| 606 | }; | ||
| 589 | 607 | ||
| 590 | switch (debug_log.val_type) { | 608 | switch (debug_log.val_type) { |
| 591 | case DebugLogValueType::RegisterValue: | 609 | case DebugLogValueType::RegisterValue: |
| 592 | debug_log.val_reg_index = ((first_dword >> 4) & 0xF); | 610 | debug_log.val_reg_index = (first_dword >> 4) & 0xF; |
| 593 | break; | 611 | break; |
| 594 | case DebugLogValueType::MemoryRelAddr: | 612 | case DebugLogValueType::MemoryRelAddr: |
| 595 | debug_log.mem_type = static_cast<MemoryAccessType>((first_dword >> 4) & 0xF); | 613 | debug_log.mem_type = static_cast<MemoryAccessType>((first_dword >> 4) & 0xF); |
| 596 | debug_log.rel_address = | 614 | debug_log.rel_address = (static_cast<u64>(first_dword & 0xF) << 32) | GetNextDword(); |
| 597 | ((static_cast<u64>(first_dword & 0xF) << 32ul) | static_cast<u64>(GetNextDword())); | ||
| 598 | break; | 615 | break; |
| 599 | case DebugLogValueType::MemoryOfsReg: | 616 | case DebugLogValueType::MemoryOfsReg: |
| 600 | debug_log.mem_type = static_cast<MemoryAccessType>((first_dword >> 4) & 0xF); | 617 | debug_log.mem_type = static_cast<MemoryAccessType>((first_dword >> 4) & 0xF); |
| 601 | debug_log.ofs_reg_index = (first_dword & 0xF); | 618 | debug_log.ofs_reg_index = first_dword & 0xF; |
| 602 | break; | 619 | break; |
| 603 | case DebugLogValueType::RegisterRelAddr: | 620 | case DebugLogValueType::RegisterRelAddr: |
| 604 | debug_log.addr_reg_index = ((first_dword >> 4) & 0xF); | 621 | debug_log.addr_reg_index = (first_dword >> 4) & 0xF; |
| 605 | debug_log.rel_address = | 622 | debug_log.rel_address = (static_cast<u64>(first_dword & 0xF) << 32) | GetNextDword(); |
| 606 | ((static_cast<u64>(first_dword & 0xF) << 32ul) | static_cast<u64>(GetNextDword())); | ||
| 607 | break; | 623 | break; |
| 608 | case DebugLogValueType::RegisterOfsReg: | 624 | case DebugLogValueType::RegisterOfsReg: |
| 609 | debug_log.addr_reg_index = ((first_dword >> 4) & 0xF); | 625 | debug_log.addr_reg_index = (first_dword >> 4) & 0xF; |
| 610 | debug_log.ofs_reg_index = (first_dword & 0xF); | 626 | debug_log.ofs_reg_index = first_dword & 0xF; |
| 611 | break; | 627 | break; |
| 612 | } | 628 | } |
| 613 | opcode.opcode = debug_log; | 629 | opcode.opcode = debug_log; |
diff --git a/src/core/perf_stats.cpp b/src/core/perf_stats.cpp index 29339ead7..b899ac884 100644 --- a/src/core/perf_stats.cpp +++ b/src/core/perf_stats.cpp | |||
| @@ -74,15 +74,16 @@ void PerfStats::EndGameFrame() { | |||
| 74 | game_frames += 1; | 74 | game_frames += 1; |
| 75 | } | 75 | } |
| 76 | 76 | ||
| 77 | double PerfStats::GetMeanFrametime() { | 77 | double PerfStats::GetMeanFrametime() const { |
| 78 | std::lock_guard lock{object_mutex}; | 78 | std::lock_guard lock{object_mutex}; |
| 79 | 79 | ||
| 80 | if (current_index <= IgnoreFrames) { | 80 | if (current_index <= IgnoreFrames) { |
| 81 | return 0; | 81 | return 0; |
| 82 | } | 82 | } |
| 83 | |||
| 83 | const double sum = std::accumulate(perf_history.begin() + IgnoreFrames, | 84 | const double sum = std::accumulate(perf_history.begin() + IgnoreFrames, |
| 84 | perf_history.begin() + current_index, 0.0); | 85 | perf_history.begin() + current_index, 0.0); |
| 85 | return sum / (current_index - IgnoreFrames); | 86 | return sum / static_cast<double>(current_index - IgnoreFrames); |
| 86 | } | 87 | } |
| 87 | 88 | ||
| 88 | PerfStatsResults PerfStats::GetAndResetStats(microseconds current_system_time_us) { | 89 | PerfStatsResults PerfStats::GetAndResetStats(microseconds current_system_time_us) { |
| @@ -94,12 +95,13 @@ PerfStatsResults PerfStats::GetAndResetStats(microseconds current_system_time_us | |||
| 94 | 95 | ||
| 95 | const auto system_us_per_second = (current_system_time_us - reset_point_system_us) / interval; | 96 | const auto system_us_per_second = (current_system_time_us - reset_point_system_us) / interval; |
| 96 | 97 | ||
| 97 | PerfStatsResults results{}; | 98 | const PerfStatsResults results{ |
| 98 | results.system_fps = static_cast<double>(system_frames) / interval; | 99 | .system_fps = static_cast<double>(system_frames) / interval, |
| 99 | results.game_fps = static_cast<double>(game_frames) / interval; | 100 | .game_fps = static_cast<double>(game_frames) / interval, |
| 100 | results.frametime = duration_cast<DoubleSecs>(accumulated_frametime).count() / | 101 | .frametime = duration_cast<DoubleSecs>(accumulated_frametime).count() / |
| 101 | static_cast<double>(system_frames); | 102 | static_cast<double>(system_frames), |
| 102 | results.emulation_speed = system_us_per_second.count() / 1'000'000.0; | 103 | .emulation_speed = system_us_per_second.count() / 1'000'000.0, |
| 104 | }; | ||
| 103 | 105 | ||
| 104 | // Reset counters | 106 | // Reset counters |
| 105 | reset_point = now; | 107 | reset_point = now; |
| @@ -111,7 +113,7 @@ PerfStatsResults PerfStats::GetAndResetStats(microseconds current_system_time_us | |||
| 111 | return results; | 113 | return results; |
| 112 | } | 114 | } |
| 113 | 115 | ||
| 114 | double PerfStats::GetLastFrameTimeScale() { | 116 | double PerfStats::GetLastFrameTimeScale() const { |
| 115 | std::lock_guard lock{object_mutex}; | 117 | std::lock_guard lock{object_mutex}; |
| 116 | 118 | ||
| 117 | constexpr double FRAME_LENGTH = 1.0 / 60; | 119 | constexpr double FRAME_LENGTH = 1.0 / 60; |
diff --git a/src/core/perf_stats.h b/src/core/perf_stats.h index d9a64f072..69256b960 100644 --- a/src/core/perf_stats.h +++ b/src/core/perf_stats.h | |||
| @@ -30,7 +30,6 @@ struct PerfStatsResults { | |||
| 30 | class PerfStats { | 30 | class PerfStats { |
| 31 | public: | 31 | public: |
| 32 | explicit PerfStats(u64 title_id); | 32 | explicit PerfStats(u64 title_id); |
| 33 | |||
| 34 | ~PerfStats(); | 33 | ~PerfStats(); |
| 35 | 34 | ||
| 36 | using Clock = std::chrono::high_resolution_clock; | 35 | using Clock = std::chrono::high_resolution_clock; |
| @@ -42,18 +41,18 @@ public: | |||
| 42 | PerfStatsResults GetAndResetStats(std::chrono::microseconds current_system_time_us); | 41 | PerfStatsResults GetAndResetStats(std::chrono::microseconds current_system_time_us); |
| 43 | 42 | ||
| 44 | /** | 43 | /** |
| 45 | * Returns the Arthimetic Mean of all frametime values stored in the performance history. | 44 | * Returns the arithmetic mean of all frametime values stored in the performance history. |
| 46 | */ | 45 | */ |
| 47 | double GetMeanFrametime(); | 46 | double GetMeanFrametime() const; |
| 48 | 47 | ||
| 49 | /** | 48 | /** |
| 50 | * Gets the ratio between walltime and the emulated time of the previous system frame. This is | 49 | * Gets the ratio between walltime and the emulated time of the previous system frame. This is |
| 51 | * useful for scaling inputs or outputs moving between the two time domains. | 50 | * useful for scaling inputs or outputs moving between the two time domains. |
| 52 | */ | 51 | */ |
| 53 | double GetLastFrameTimeScale(); | 52 | double GetLastFrameTimeScale() const; |
| 54 | 53 | ||
| 55 | private: | 54 | private: |
| 56 | std::mutex object_mutex{}; | 55 | mutable std::mutex object_mutex; |
| 57 | 56 | ||
| 58 | /// Title ID for the game that is running. 0 if there is no game running yet | 57 | /// Title ID for the game that is running. 0 if there is no game running yet |
| 59 | u64 title_id{0}; | 58 | u64 title_id{0}; |
| @@ -61,7 +60,7 @@ private: | |||
| 61 | std::size_t current_index{0}; | 60 | std::size_t current_index{0}; |
| 62 | /// Stores an hour of historical frametime data useful for processing and tracking performance | 61 | /// Stores an hour of historical frametime data useful for processing and tracking performance |
| 63 | /// regressions with code changes. | 62 | /// regressions with code changes. |
| 64 | std::array<double, 216000> perf_history = {}; | 63 | std::array<double, 216000> perf_history{}; |
| 65 | 64 | ||
| 66 | /// Point when the cumulative counters were reset | 65 | /// Point when the cumulative counters were reset |
| 67 | Clock::time_point reset_point = Clock::now(); | 66 | Clock::time_point reset_point = Clock::now(); |
diff --git a/src/core/settings.cpp b/src/core/settings.cpp index 44252dd81..416b2d866 100644 --- a/src/core/settings.cpp +++ b/src/core/settings.cpp | |||
| @@ -173,7 +173,6 @@ void RestoreGlobalState() { | |||
| 173 | values.use_assembly_shaders.SetGlobal(true); | 173 | values.use_assembly_shaders.SetGlobal(true); |
| 174 | values.use_asynchronous_shaders.SetGlobal(true); | 174 | values.use_asynchronous_shaders.SetGlobal(true); |
| 175 | values.use_fast_gpu_time.SetGlobal(true); | 175 | values.use_fast_gpu_time.SetGlobal(true); |
| 176 | values.force_30fps_mode.SetGlobal(true); | ||
| 177 | values.bg_red.SetGlobal(true); | 176 | values.bg_red.SetGlobal(true); |
| 178 | values.bg_green.SetGlobal(true); | 177 | values.bg_green.SetGlobal(true); |
| 179 | values.bg_blue.SetGlobal(true); | 178 | values.bg_blue.SetGlobal(true); |
diff --git a/src/core/settings.h b/src/core/settings.h index 386233fdf..bb145f193 100644 --- a/src/core/settings.h +++ b/src/core/settings.h | |||
| @@ -435,7 +435,6 @@ struct Values { | |||
| 435 | Setting<bool> use_vsync; | 435 | Setting<bool> use_vsync; |
| 436 | Setting<bool> use_assembly_shaders; | 436 | Setting<bool> use_assembly_shaders; |
| 437 | Setting<bool> use_asynchronous_shaders; | 437 | Setting<bool> use_asynchronous_shaders; |
| 438 | Setting<bool> force_30fps_mode; | ||
| 439 | Setting<bool> use_fast_gpu_time; | 438 | Setting<bool> use_fast_gpu_time; |
| 440 | 439 | ||
| 441 | Setting<float> bg_red; | 440 | Setting<float> bg_red; |
diff --git a/src/tests/core/core_timing.cpp b/src/tests/core/core_timing.cpp index 022b26e6d..b35459152 100644 --- a/src/tests/core/core_timing.cpp +++ b/src/tests/core/core_timing.cpp | |||
| @@ -46,20 +46,16 @@ struct ScopeInit final { | |||
| 46 | Core::Timing::CoreTiming core_timing; | 46 | Core::Timing::CoreTiming core_timing; |
| 47 | }; | 47 | }; |
| 48 | 48 | ||
| 49 | #pragma optimize("", off) | ||
| 50 | |||
| 51 | u64 TestTimerSpeed(Core::Timing::CoreTiming& core_timing) { | 49 | u64 TestTimerSpeed(Core::Timing::CoreTiming& core_timing) { |
| 52 | u64 start = core_timing.GetGlobalTimeNs().count(); | 50 | const u64 start = core_timing.GetGlobalTimeNs().count(); |
| 53 | u64 placebo = 0; | 51 | volatile u64 placebo = 0; |
| 54 | for (std::size_t i = 0; i < 1000; i++) { | 52 | for (std::size_t i = 0; i < 1000; i++) { |
| 55 | placebo += core_timing.GetGlobalTimeNs().count(); | 53 | placebo = placebo + core_timing.GetGlobalTimeNs().count(); |
| 56 | } | 54 | } |
| 57 | u64 end = core_timing.GetGlobalTimeNs().count(); | 55 | const u64 end = core_timing.GetGlobalTimeNs().count(); |
| 58 | return (end - start); | 56 | return end - start; |
| 59 | } | 57 | } |
| 60 | 58 | ||
| 61 | #pragma optimize("", on) | ||
| 62 | |||
| 63 | } // Anonymous namespace | 59 | } // Anonymous namespace |
| 64 | 60 | ||
| 65 | TEST_CASE("CoreTiming[BasicOrder]", "[core]") { | 61 | TEST_CASE("CoreTiming[BasicOrder]", "[core]") { |
diff --git a/src/video_core/compatible_formats.h b/src/video_core/compatible_formats.h index d1082566d..51766349b 100644 --- a/src/video_core/compatible_formats.h +++ b/src/video_core/compatible_formats.h | |||
| @@ -2,6 +2,8 @@ | |||
| 2 | // Licensed under GPLv2 or any later version | 2 | // Licensed under GPLv2 or any later version |
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #pragma once | ||
| 6 | |||
| 5 | #include <array> | 7 | #include <array> |
| 6 | #include <bitset> | 8 | #include <bitset> |
| 7 | #include <cstddef> | 9 | #include <cstddef> |
diff --git a/src/video_core/gpu.cpp b/src/video_core/gpu.cpp index 8e19c3373..512578c8b 100644 --- a/src/video_core/gpu.cpp +++ b/src/video_core/gpu.cpp | |||
| @@ -81,7 +81,7 @@ void GPU::WaitFence(u32 syncpoint_id, u32 value) { | |||
| 81 | } | 81 | } |
| 82 | MICROPROFILE_SCOPE(GPU_wait); | 82 | MICROPROFILE_SCOPE(GPU_wait); |
| 83 | std::unique_lock lock{sync_mutex}; | 83 | std::unique_lock lock{sync_mutex}; |
| 84 | sync_cv.wait(lock, [=]() { return syncpoints[syncpoint_id].load() >= value; }); | 84 | sync_cv.wait(lock, [=, this] { return syncpoints[syncpoint_id].load() >= value; }); |
| 85 | } | 85 | } |
| 86 | 86 | ||
| 87 | void GPU::IncrementSyncPoint(const u32 syncpoint_id) { | 87 | void GPU::IncrementSyncPoint(const u32 syncpoint_id) { |
diff --git a/src/video_core/memory_manager.cpp b/src/video_core/memory_manager.cpp index ff5505d12..844164645 100644 --- a/src/video_core/memory_manager.cpp +++ b/src/video_core/memory_manager.cpp | |||
| @@ -4,7 +4,6 @@ | |||
| 4 | 4 | ||
| 5 | #include "common/alignment.h" | 5 | #include "common/alignment.h" |
| 6 | #include "common/assert.h" | 6 | #include "common/assert.h" |
| 7 | #include "common/logging/log.h" | ||
| 8 | #include "core/core.h" | 7 | #include "core/core.h" |
| 9 | #include "core/hle/kernel/memory/page_table.h" | 8 | #include "core/hle/kernel/memory/page_table.h" |
| 10 | #include "core/hle/kernel/process.h" | 9 | #include "core/hle/kernel/process.h" |
| @@ -16,121 +15,137 @@ | |||
| 16 | namespace Tegra { | 15 | namespace Tegra { |
| 17 | 16 | ||
| 18 | MemoryManager::MemoryManager(Core::System& system, VideoCore::RasterizerInterface& rasterizer) | 17 | MemoryManager::MemoryManager(Core::System& system, VideoCore::RasterizerInterface& rasterizer) |
| 19 | : rasterizer{rasterizer}, system{system} { | 18 | : system{system}, rasterizer{rasterizer}, page_table(page_table_size) {} |
| 20 | page_table.Resize(address_space_width, page_bits, false); | ||
| 21 | |||
| 22 | // Initialize the map with a single free region covering the entire managed space. | ||
| 23 | VirtualMemoryArea initial_vma; | ||
| 24 | initial_vma.size = address_space_end; | ||
| 25 | vma_map.emplace(initial_vma.base, initial_vma); | ||
| 26 | |||
| 27 | UpdatePageTableForVMA(initial_vma); | ||
| 28 | } | ||
| 29 | 19 | ||
| 30 | MemoryManager::~MemoryManager() = default; | 20 | MemoryManager::~MemoryManager() = default; |
| 31 | 21 | ||
| 32 | GPUVAddr MemoryManager::AllocateSpace(u64 size, u64 align) { | 22 | GPUVAddr MemoryManager::UpdateRange(GPUVAddr gpu_addr, PageEntry page_entry, std::size_t size) { |
| 33 | const u64 aligned_size{Common::AlignUp(size, page_size)}; | 23 | u64 remaining_size{size}; |
| 34 | const GPUVAddr gpu_addr{FindFreeRegion(address_space_base, aligned_size)}; | 24 | for (u64 offset{}; offset < size; offset += page_size) { |
| 35 | 25 | if (remaining_size < page_size) { | |
| 36 | AllocateMemory(gpu_addr, 0, aligned_size); | 26 | SetPageEntry(gpu_addr + offset, page_entry + offset, remaining_size); |
| 37 | 27 | } else { | |
| 28 | SetPageEntry(gpu_addr + offset, page_entry + offset); | ||
| 29 | } | ||
| 30 | remaining_size -= page_size; | ||
| 31 | } | ||
| 38 | return gpu_addr; | 32 | return gpu_addr; |
| 39 | } | 33 | } |
| 40 | 34 | ||
| 41 | GPUVAddr MemoryManager::AllocateSpace(GPUVAddr gpu_addr, u64 size, u64 align) { | 35 | GPUVAddr MemoryManager::Map(VAddr cpu_addr, GPUVAddr gpu_addr, std::size_t size) { |
| 42 | const u64 aligned_size{Common::AlignUp(size, page_size)}; | 36 | return UpdateRange(gpu_addr, cpu_addr, size); |
| 43 | 37 | } | |
| 44 | AllocateMemory(gpu_addr, 0, aligned_size); | ||
| 45 | 38 | ||
| 46 | return gpu_addr; | 39 | GPUVAddr MemoryManager::MapAllocate(VAddr cpu_addr, std::size_t size, std::size_t align) { |
| 40 | return Map(cpu_addr, *FindFreeRange(size, align), size); | ||
| 47 | } | 41 | } |
| 48 | 42 | ||
| 49 | GPUVAddr MemoryManager::MapBufferEx(VAddr cpu_addr, u64 size) { | 43 | void MemoryManager::Unmap(GPUVAddr gpu_addr, std::size_t size) { |
| 50 | const u64 aligned_size{Common::AlignUp(size, page_size)}; | 44 | if (!size) { |
| 51 | const GPUVAddr gpu_addr{FindFreeRegion(address_space_base, aligned_size)}; | 45 | return; |
| 46 | } | ||
| 52 | 47 | ||
| 53 | MapBackingMemory(gpu_addr, system.Memory().GetPointer(cpu_addr), aligned_size, cpu_addr); | 48 | // Flush and invalidate through the GPU interface, to be asynchronous if possible. |
| 54 | ASSERT( | 49 | system.GPU().FlushAndInvalidateRegion(*GpuToCpuAddress(gpu_addr), size); |
| 55 | system.CurrentProcess()->PageTable().LockForDeviceAddressSpace(cpu_addr, size).IsSuccess()); | ||
| 56 | 50 | ||
| 57 | return gpu_addr; | 51 | UpdateRange(gpu_addr, PageEntry::State::Unmapped, size); |
| 58 | } | 52 | } |
| 59 | 53 | ||
| 60 | GPUVAddr MemoryManager::MapBufferEx(VAddr cpu_addr, GPUVAddr gpu_addr, u64 size) { | 54 | std::optional<GPUVAddr> MemoryManager::AllocateFixed(GPUVAddr gpu_addr, std::size_t size) { |
| 61 | ASSERT((gpu_addr & page_mask) == 0); | 55 | for (u64 offset{}; offset < size; offset += page_size) { |
| 56 | if (!GetPageEntry(gpu_addr + offset).IsUnmapped()) { | ||
| 57 | return {}; | ||
| 58 | } | ||
| 59 | } | ||
| 62 | 60 | ||
| 63 | const u64 aligned_size{Common::AlignUp(size, page_size)}; | 61 | return UpdateRange(gpu_addr, PageEntry::State::Allocated, size); |
| 62 | } | ||
| 64 | 63 | ||
| 65 | MapBackingMemory(gpu_addr, system.Memory().GetPointer(cpu_addr), aligned_size, cpu_addr); | 64 | GPUVAddr MemoryManager::Allocate(std::size_t size, std::size_t align) { |
| 66 | ASSERT( | 65 | return *AllocateFixed(*FindFreeRange(size, align), size); |
| 67 | system.CurrentProcess()->PageTable().LockForDeviceAddressSpace(cpu_addr, size).IsSuccess()); | ||
| 68 | return gpu_addr; | ||
| 69 | } | 66 | } |
| 70 | 67 | ||
| 71 | GPUVAddr MemoryManager::UnmapBuffer(GPUVAddr gpu_addr, u64 size) { | 68 | void MemoryManager::TryLockPage(PageEntry page_entry, std::size_t size) { |
| 72 | ASSERT((gpu_addr & page_mask) == 0); | 69 | if (!page_entry.IsValid()) { |
| 70 | return; | ||
| 71 | } | ||
| 73 | 72 | ||
| 74 | const u64 aligned_size{Common::AlignUp(size, page_size)}; | 73 | ASSERT(system.CurrentProcess() |
| 75 | const auto cpu_addr = GpuToCpuAddress(gpu_addr); | 74 | ->PageTable() |
| 76 | ASSERT(cpu_addr); | 75 | .LockForDeviceAddressSpace(page_entry.ToAddress(), size) |
| 76 | .IsSuccess()); | ||
| 77 | } | ||
| 77 | 78 | ||
| 78 | // Flush and invalidate through the GPU interface, to be asynchronous if possible. | 79 | void MemoryManager::TryUnlockPage(PageEntry page_entry, std::size_t size) { |
| 79 | system.GPU().FlushAndInvalidateRegion(*cpu_addr, aligned_size); | 80 | if (!page_entry.IsValid()) { |
| 81 | return; | ||
| 82 | } | ||
| 80 | 83 | ||
| 81 | UnmapRange(gpu_addr, aligned_size); | ||
| 82 | ASSERT(system.CurrentProcess() | 84 | ASSERT(system.CurrentProcess() |
| 83 | ->PageTable() | 85 | ->PageTable() |
| 84 | .UnlockForDeviceAddressSpace(cpu_addr.value(), size) | 86 | .UnlockForDeviceAddressSpace(page_entry.ToAddress(), size) |
| 85 | .IsSuccess()); | 87 | .IsSuccess()); |
| 86 | |||
| 87 | return gpu_addr; | ||
| 88 | } | 88 | } |
| 89 | 89 | ||
| 90 | GPUVAddr MemoryManager::FindFreeRegion(GPUVAddr region_start, u64 size) const { | 90 | PageEntry MemoryManager::GetPageEntry(GPUVAddr gpu_addr) const { |
| 91 | // Find the first Free VMA. | 91 | return page_table[PageEntryIndex(gpu_addr)]; |
| 92 | const VMAHandle vma_handle{ | 92 | } |
| 93 | std::find_if(vma_map.begin(), vma_map.end(), [region_start, size](const auto& vma) { | ||
| 94 | if (vma.second.type != VirtualMemoryArea::Type::Unmapped) { | ||
| 95 | return false; | ||
| 96 | } | ||
| 97 | 93 | ||
| 98 | const VAddr vma_end{vma.second.base + vma.second.size}; | 94 | void MemoryManager::SetPageEntry(GPUVAddr gpu_addr, PageEntry page_entry, std::size_t size) { |
| 99 | return vma_end > region_start && vma_end >= region_start + size; | 95 | // TODO(bunnei): We should lock/unlock device regions. This currently causes issues due to |
| 100 | })}; | 96 | // improper tracking, but should be fixed in the future. |
| 101 | 97 | ||
| 102 | if (vma_handle == vma_map.end()) { | 98 | //// Unlock the old page |
| 103 | return {}; | 99 | // TryUnlockPage(page_table[PageEntryIndex(gpu_addr)], size); |
| 104 | } | ||
| 105 | 100 | ||
| 106 | return std::max(region_start, vma_handle->second.base); | 101 | //// Lock the new page |
| 107 | } | 102 | // TryLockPage(page_entry, size); |
| 108 | 103 | ||
| 109 | bool MemoryManager::IsAddressValid(GPUVAddr addr) const { | 104 | page_table[PageEntryIndex(gpu_addr)] = page_entry; |
| 110 | return (addr >> page_bits) < page_table.pointers.size(); | ||
| 111 | } | 105 | } |
| 112 | 106 | ||
| 113 | std::optional<VAddr> MemoryManager::GpuToCpuAddress(GPUVAddr addr) const { | 107 | std::optional<GPUVAddr> MemoryManager::FindFreeRange(std::size_t size, std::size_t align) const { |
| 114 | if (!IsAddressValid(addr)) { | 108 | if (!align) { |
| 115 | return {}; | 109 | align = page_size; |
| 110 | } else { | ||
| 111 | align = Common::AlignUp(align, page_size); | ||
| 116 | } | 112 | } |
| 117 | 113 | ||
| 118 | const VAddr cpu_addr{page_table.backing_addr[addr >> page_bits]}; | 114 | u64 available_size{}; |
| 119 | if (cpu_addr) { | 115 | GPUVAddr gpu_addr{address_space_start}; |
| 120 | return cpu_addr + (addr & page_mask); | 116 | while (gpu_addr + available_size < address_space_size) { |
| 117 | if (GetPageEntry(gpu_addr + available_size).IsUnmapped()) { | ||
| 118 | available_size += page_size; | ||
| 119 | |||
| 120 | if (available_size >= size) { | ||
| 121 | return gpu_addr; | ||
| 122 | } | ||
| 123 | } else { | ||
| 124 | gpu_addr += available_size + page_size; | ||
| 125 | available_size = 0; | ||
| 126 | |||
| 127 | const auto remainder{gpu_addr % align}; | ||
| 128 | if (remainder) { | ||
| 129 | gpu_addr = (gpu_addr - remainder) + align; | ||
| 130 | } | ||
| 131 | } | ||
| 121 | } | 132 | } |
| 122 | 133 | ||
| 123 | return {}; | 134 | return {}; |
| 124 | } | 135 | } |
| 125 | 136 | ||
| 126 | template <typename T> | 137 | std::optional<VAddr> MemoryManager::GpuToCpuAddress(GPUVAddr gpu_addr) const { |
| 127 | T MemoryManager::Read(GPUVAddr addr) const { | 138 | const auto page_entry{GetPageEntry(gpu_addr)}; |
| 128 | if (!IsAddressValid(addr)) { | 139 | if (!page_entry.IsValid()) { |
| 129 | return {}; | 140 | return {}; |
| 130 | } | 141 | } |
| 131 | 142 | ||
| 132 | const u8* page_pointer{GetPointer(addr)}; | 143 | return page_entry.ToAddress() + (gpu_addr & page_mask); |
| 133 | if (page_pointer) { | 144 | } |
| 145 | |||
| 146 | template <typename T> | ||
| 147 | T MemoryManager::Read(GPUVAddr addr) const { | ||
| 148 | if (auto page_pointer{GetPointer(addr)}; page_pointer) { | ||
| 134 | // NOTE: Avoid adding any extra logic to this fast-path block | 149 | // NOTE: Avoid adding any extra logic to this fast-path block |
| 135 | T value; | 150 | T value; |
| 136 | std::memcpy(&value, page_pointer, sizeof(T)); | 151 | std::memcpy(&value, page_pointer, sizeof(T)); |
| @@ -144,12 +159,7 @@ T MemoryManager::Read(GPUVAddr addr) const { | |||
| 144 | 159 | ||
| 145 | template <typename T> | 160 | template <typename T> |
| 146 | void MemoryManager::Write(GPUVAddr addr, T data) { | 161 | void MemoryManager::Write(GPUVAddr addr, T data) { |
| 147 | if (!IsAddressValid(addr)) { | 162 | if (auto page_pointer{GetPointer(addr)}; page_pointer) { |
| 148 | return; | ||
| 149 | } | ||
| 150 | |||
| 151 | u8* page_pointer{GetPointer(addr)}; | ||
| 152 | if (page_pointer) { | ||
| 153 | // NOTE: Avoid adding any extra logic to this fast-path block | 163 | // NOTE: Avoid adding any extra logic to this fast-path block |
| 154 | std::memcpy(page_pointer, &data, sizeof(T)); | 164 | std::memcpy(page_pointer, &data, sizeof(T)); |
| 155 | return; | 165 | return; |
| @@ -167,66 +177,49 @@ template void MemoryManager::Write<u16>(GPUVAddr addr, u16 data); | |||
| 167 | template void MemoryManager::Write<u32>(GPUVAddr addr, u32 data); | 177 | template void MemoryManager::Write<u32>(GPUVAddr addr, u32 data); |
| 168 | template void MemoryManager::Write<u64>(GPUVAddr addr, u64 data); | 178 | template void MemoryManager::Write<u64>(GPUVAddr addr, u64 data); |
| 169 | 179 | ||
| 170 | u8* MemoryManager::GetPointer(GPUVAddr addr) { | 180 | u8* MemoryManager::GetPointer(GPUVAddr gpu_addr) { |
| 171 | if (!IsAddressValid(addr)) { | 181 | if (!GetPageEntry(gpu_addr).IsValid()) { |
| 172 | return {}; | 182 | return {}; |
| 173 | } | 183 | } |
| 174 | 184 | ||
| 175 | auto& memory = system.Memory(); | 185 | const auto address{GpuToCpuAddress(gpu_addr)}; |
| 176 | 186 | if (!address) { | |
| 177 | const VAddr page_addr{page_table.backing_addr[addr >> page_bits]}; | 187 | return {}; |
| 178 | |||
| 179 | if (page_addr != 0) { | ||
| 180 | return memory.GetPointer(page_addr + (addr & page_mask)); | ||
| 181 | } | 188 | } |
| 182 | 189 | ||
| 183 | LOG_ERROR(HW_GPU, "Unknown GetPointer @ 0x{:016X}", addr); | 190 | return system.Memory().GetPointer(*address); |
| 184 | return {}; | ||
| 185 | } | 191 | } |
| 186 | 192 | ||
| 187 | const u8* MemoryManager::GetPointer(GPUVAddr addr) const { | 193 | const u8* MemoryManager::GetPointer(GPUVAddr gpu_addr) const { |
| 188 | if (!IsAddressValid(addr)) { | 194 | if (!GetPageEntry(gpu_addr).IsValid()) { |
| 189 | return {}; | 195 | return {}; |
| 190 | } | 196 | } |
| 191 | 197 | ||
| 192 | const auto& memory = system.Memory(); | 198 | const auto address{GpuToCpuAddress(gpu_addr)}; |
| 193 | 199 | if (!address) { | |
| 194 | const VAddr page_addr{page_table.backing_addr[addr >> page_bits]}; | 200 | return {}; |
| 195 | |||
| 196 | if (page_addr != 0) { | ||
| 197 | return memory.GetPointer(page_addr + (addr & page_mask)); | ||
| 198 | } | 201 | } |
| 199 | 202 | ||
| 200 | LOG_ERROR(HW_GPU, "Unknown GetPointer @ 0x{:016X}", addr); | 203 | return system.Memory().GetPointer(*address); |
| 201 | return {}; | ||
| 202 | } | ||
| 203 | |||
| 204 | bool MemoryManager::IsBlockContinuous(const GPUVAddr start, const std::size_t size) const { | ||
| 205 | const std::size_t inner_size = size - 1; | ||
| 206 | const GPUVAddr end = start + inner_size; | ||
| 207 | const auto host_ptr_start = reinterpret_cast<std::uintptr_t>(GetPointer(start)); | ||
| 208 | const auto host_ptr_end = reinterpret_cast<std::uintptr_t>(GetPointer(end)); | ||
| 209 | const auto range = static_cast<std::size_t>(host_ptr_end - host_ptr_start); | ||
| 210 | return range == inner_size; | ||
| 211 | } | 204 | } |
| 212 | 205 | ||
| 213 | void MemoryManager::ReadBlock(GPUVAddr gpu_src_addr, void* dest_buffer, | 206 | void MemoryManager::ReadBlock(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size) const { |
| 214 | const std::size_t size) const { | ||
| 215 | std::size_t remaining_size{size}; | 207 | std::size_t remaining_size{size}; |
| 216 | std::size_t page_index{gpu_src_addr >> page_bits}; | 208 | std::size_t page_index{gpu_src_addr >> page_bits}; |
| 217 | std::size_t page_offset{gpu_src_addr & page_mask}; | 209 | std::size_t page_offset{gpu_src_addr & page_mask}; |
| 218 | 210 | ||
| 219 | auto& memory = system.Memory(); | ||
| 220 | |||
| 221 | while (remaining_size > 0) { | 211 | while (remaining_size > 0) { |
| 222 | const std::size_t copy_amount{ | 212 | const std::size_t copy_amount{ |
| 223 | std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)}; | 213 | std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)}; |
| 224 | 214 | ||
| 225 | const VAddr src_addr{page_table.backing_addr[page_index] + page_offset}; | 215 | if (const auto page_addr{GpuToCpuAddress(page_index << page_bits)}; page_addr) { |
| 226 | // Flush must happen on the rasterizer interface, such that memory is always synchronous | 216 | const auto src_addr{*page_addr + page_offset}; |
| 227 | // when it is read (even when in asynchronous GPU mode). Fixes Dead Cells title menu. | 217 | |
| 228 | rasterizer.FlushRegion(src_addr, copy_amount); | 218 | // Flush must happen on the rasterizer interface, such that memory is always synchronous |
| 229 | memory.ReadBlockUnsafe(src_addr, dest_buffer, copy_amount); | 219 | // when it is read (even when in asynchronous GPU mode). Fixes Dead Cells title menu. |
| 220 | rasterizer.FlushRegion(src_addr, copy_amount); | ||
| 221 | system.Memory().ReadBlockUnsafe(src_addr, dest_buffer, copy_amount); | ||
| 222 | } | ||
| 230 | 223 | ||
| 231 | page_index++; | 224 | page_index++; |
| 232 | page_offset = 0; | 225 | page_offset = 0; |
| @@ -241,18 +234,17 @@ void MemoryManager::ReadBlockUnsafe(GPUVAddr gpu_src_addr, void* dest_buffer, | |||
| 241 | std::size_t page_index{gpu_src_addr >> page_bits}; | 234 | std::size_t page_index{gpu_src_addr >> page_bits}; |
| 242 | std::size_t page_offset{gpu_src_addr & page_mask}; | 235 | std::size_t page_offset{gpu_src_addr & page_mask}; |
| 243 | 236 | ||
| 244 | auto& memory = system.Memory(); | ||
| 245 | |||
| 246 | while (remaining_size > 0) { | 237 | while (remaining_size > 0) { |
| 247 | const std::size_t copy_amount{ | 238 | const std::size_t copy_amount{ |
| 248 | std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)}; | 239 | std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)}; |
| 249 | const u8* page_pointer = page_table.pointers[page_index]; | 240 | |
| 250 | if (page_pointer) { | 241 | if (const auto page_addr{GpuToCpuAddress(page_index << page_bits)}; page_addr) { |
| 251 | const VAddr src_addr{page_table.backing_addr[page_index] + page_offset}; | 242 | const auto src_addr{*page_addr + page_offset}; |
| 252 | memory.ReadBlockUnsafe(src_addr, dest_buffer, copy_amount); | 243 | system.Memory().ReadBlockUnsafe(src_addr, dest_buffer, copy_amount); |
| 253 | } else { | 244 | } else { |
| 254 | std::memset(dest_buffer, 0, copy_amount); | 245 | std::memset(dest_buffer, 0, copy_amount); |
| 255 | } | 246 | } |
| 247 | |||
| 256 | page_index++; | 248 | page_index++; |
| 257 | page_offset = 0; | 249 | page_offset = 0; |
| 258 | dest_buffer = static_cast<u8*>(dest_buffer) + copy_amount; | 250 | dest_buffer = static_cast<u8*>(dest_buffer) + copy_amount; |
| @@ -260,23 +252,23 @@ void MemoryManager::ReadBlockUnsafe(GPUVAddr gpu_src_addr, void* dest_buffer, | |||
| 260 | } | 252 | } |
| 261 | } | 253 | } |
| 262 | 254 | ||
| 263 | void MemoryManager::WriteBlock(GPUVAddr gpu_dest_addr, const void* src_buffer, | 255 | void MemoryManager::WriteBlock(GPUVAddr gpu_dest_addr, const void* src_buffer, std::size_t size) { |
| 264 | const std::size_t size) { | ||
| 265 | std::size_t remaining_size{size}; | 256 | std::size_t remaining_size{size}; |
| 266 | std::size_t page_index{gpu_dest_addr >> page_bits}; | 257 | std::size_t page_index{gpu_dest_addr >> page_bits}; |
| 267 | std::size_t page_offset{gpu_dest_addr & page_mask}; | 258 | std::size_t page_offset{gpu_dest_addr & page_mask}; |
| 268 | 259 | ||
| 269 | auto& memory = system.Memory(); | ||
| 270 | |||
| 271 | while (remaining_size > 0) { | 260 | while (remaining_size > 0) { |
| 272 | const std::size_t copy_amount{ | 261 | const std::size_t copy_amount{ |
| 273 | std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)}; | 262 | std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)}; |
| 274 | 263 | ||
| 275 | const VAddr dest_addr{page_table.backing_addr[page_index] + page_offset}; | 264 | if (const auto page_addr{GpuToCpuAddress(page_index << page_bits)}; page_addr) { |
| 276 | // Invalidate must happen on the rasterizer interface, such that memory is always | 265 | const auto dest_addr{*page_addr + page_offset}; |
| 277 | // synchronous when it is written (even when in asynchronous GPU mode). | 266 | |
| 278 | rasterizer.InvalidateRegion(dest_addr, copy_amount); | 267 | // Invalidate must happen on the rasterizer interface, such that memory is always |
| 279 | memory.WriteBlockUnsafe(dest_addr, src_buffer, copy_amount); | 268 | // synchronous when it is written (even when in asynchronous GPU mode). |
| 269 | rasterizer.InvalidateRegion(dest_addr, copy_amount); | ||
| 270 | system.Memory().WriteBlockUnsafe(dest_addr, src_buffer, copy_amount); | ||
| 271 | } | ||
| 280 | 272 | ||
| 281 | page_index++; | 273 | page_index++; |
| 282 | page_offset = 0; | 274 | page_offset = 0; |
| @@ -286,21 +278,20 @@ void MemoryManager::WriteBlock(GPUVAddr gpu_dest_addr, const void* src_buffer, | |||
| 286 | } | 278 | } |
| 287 | 279 | ||
| 288 | void MemoryManager::WriteBlockUnsafe(GPUVAddr gpu_dest_addr, const void* src_buffer, | 280 | void MemoryManager::WriteBlockUnsafe(GPUVAddr gpu_dest_addr, const void* src_buffer, |
| 289 | const std::size_t size) { | 281 | std::size_t size) { |
| 290 | std::size_t remaining_size{size}; | 282 | std::size_t remaining_size{size}; |
| 291 | std::size_t page_index{gpu_dest_addr >> page_bits}; | 283 | std::size_t page_index{gpu_dest_addr >> page_bits}; |
| 292 | std::size_t page_offset{gpu_dest_addr & page_mask}; | 284 | std::size_t page_offset{gpu_dest_addr & page_mask}; |
| 293 | 285 | ||
| 294 | auto& memory = system.Memory(); | ||
| 295 | |||
| 296 | while (remaining_size > 0) { | 286 | while (remaining_size > 0) { |
| 297 | const std::size_t copy_amount{ | 287 | const std::size_t copy_amount{ |
| 298 | std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)}; | 288 | std::min(static_cast<std::size_t>(page_size) - page_offset, remaining_size)}; |
| 299 | u8* page_pointer = page_table.pointers[page_index]; | 289 | |
| 300 | if (page_pointer) { | 290 | if (const auto page_addr{GpuToCpuAddress(page_index << page_bits)}; page_addr) { |
| 301 | const VAddr dest_addr{page_table.backing_addr[page_index] + page_offset}; | 291 | const auto dest_addr{*page_addr + page_offset}; |
| 302 | memory.WriteBlockUnsafe(dest_addr, src_buffer, copy_amount); | 292 | system.Memory().WriteBlockUnsafe(dest_addr, src_buffer, copy_amount); |
| 303 | } | 293 | } |
| 294 | |||
| 304 | page_index++; | 295 | page_index++; |
| 305 | page_offset = 0; | 296 | page_offset = 0; |
| 306 | src_buffer = static_cast<const u8*>(src_buffer) + copy_amount; | 297 | src_buffer = static_cast<const u8*>(src_buffer) + copy_amount; |
| @@ -308,273 +299,26 @@ void MemoryManager::WriteBlockUnsafe(GPUVAddr gpu_dest_addr, const void* src_buf | |||
| 308 | } | 299 | } |
| 309 | } | 300 | } |
| 310 | 301 | ||
| 311 | void MemoryManager::CopyBlock(GPUVAddr gpu_dest_addr, GPUVAddr gpu_src_addr, | 302 | void MemoryManager::CopyBlock(GPUVAddr gpu_dest_addr, GPUVAddr gpu_src_addr, std::size_t size) { |
| 312 | const std::size_t size) { | ||
| 313 | std::vector<u8> tmp_buffer(size); | 303 | std::vector<u8> tmp_buffer(size); |
| 314 | ReadBlock(gpu_src_addr, tmp_buffer.data(), size); | 304 | ReadBlock(gpu_src_addr, tmp_buffer.data(), size); |
| 315 | WriteBlock(gpu_dest_addr, tmp_buffer.data(), size); | 305 | WriteBlock(gpu_dest_addr, tmp_buffer.data(), size); |
| 316 | } | 306 | } |
| 317 | 307 | ||
| 318 | void MemoryManager::CopyBlockUnsafe(GPUVAddr gpu_dest_addr, GPUVAddr gpu_src_addr, | 308 | void MemoryManager::CopyBlockUnsafe(GPUVAddr gpu_dest_addr, GPUVAddr gpu_src_addr, |
| 319 | const std::size_t size) { | 309 | std::size_t size) { |
| 320 | std::vector<u8> tmp_buffer(size); | 310 | std::vector<u8> tmp_buffer(size); |
| 321 | ReadBlockUnsafe(gpu_src_addr, tmp_buffer.data(), size); | 311 | ReadBlockUnsafe(gpu_src_addr, tmp_buffer.data(), size); |
| 322 | WriteBlockUnsafe(gpu_dest_addr, tmp_buffer.data(), size); | 312 | WriteBlockUnsafe(gpu_dest_addr, tmp_buffer.data(), size); |
| 323 | } | 313 | } |
| 324 | 314 | ||
| 325 | bool MemoryManager::IsGranularRange(GPUVAddr gpu_addr, std::size_t size) { | 315 | bool MemoryManager::IsGranularRange(GPUVAddr gpu_addr, std::size_t size) { |
| 326 | const VAddr addr = page_table.backing_addr[gpu_addr >> page_bits]; | 316 | const auto cpu_addr{GpuToCpuAddress(gpu_addr)}; |
| 327 | const std::size_t page = (addr & Core::Memory::PAGE_MASK) + size; | 317 | if (!cpu_addr) { |
| 328 | return page <= Core::Memory::PAGE_SIZE; | ||
| 329 | } | ||
| 330 | |||
| 331 | void MemoryManager::MapPages(GPUVAddr base, u64 size, u8* memory, Common::PageType type, | ||
| 332 | VAddr backing_addr) { | ||
| 333 | LOG_DEBUG(HW_GPU, "Mapping {} onto {:016X}-{:016X}", fmt::ptr(memory), base * page_size, | ||
| 334 | (base + size) * page_size); | ||
| 335 | |||
| 336 | const VAddr end{base + size}; | ||
| 337 | ASSERT_MSG(end <= page_table.pointers.size(), "out of range mapping at {:016X}", | ||
| 338 | base + page_table.pointers.size()); | ||
| 339 | |||
| 340 | if (memory == nullptr) { | ||
| 341 | while (base != end) { | ||
| 342 | page_table.pointers[base] = nullptr; | ||
| 343 | page_table.backing_addr[base] = 0; | ||
| 344 | |||
| 345 | base += 1; | ||
| 346 | } | ||
| 347 | } else { | ||
| 348 | while (base != end) { | ||
| 349 | page_table.pointers[base] = memory; | ||
| 350 | page_table.backing_addr[base] = backing_addr; | ||
| 351 | |||
| 352 | base += 1; | ||
| 353 | memory += page_size; | ||
| 354 | backing_addr += page_size; | ||
| 355 | } | ||
| 356 | } | ||
| 357 | } | ||
| 358 | |||
| 359 | void MemoryManager::MapMemoryRegion(GPUVAddr base, u64 size, u8* target, VAddr backing_addr) { | ||
| 360 | ASSERT_MSG((size & page_mask) == 0, "non-page aligned size: {:016X}", size); | ||
| 361 | ASSERT_MSG((base & page_mask) == 0, "non-page aligned base: {:016X}", base); | ||
| 362 | MapPages(base / page_size, size / page_size, target, Common::PageType::Memory, backing_addr); | ||
| 363 | } | ||
| 364 | |||
| 365 | void MemoryManager::UnmapRegion(GPUVAddr base, u64 size) { | ||
| 366 | ASSERT_MSG((size & page_mask) == 0, "non-page aligned size: {:016X}", size); | ||
| 367 | ASSERT_MSG((base & page_mask) == 0, "non-page aligned base: {:016X}", base); | ||
| 368 | MapPages(base / page_size, size / page_size, nullptr, Common::PageType::Unmapped); | ||
| 369 | } | ||
| 370 | |||
| 371 | bool VirtualMemoryArea::CanBeMergedWith(const VirtualMemoryArea& next) const { | ||
| 372 | ASSERT(base + size == next.base); | ||
| 373 | if (type != next.type) { | ||
| 374 | return {}; | ||
| 375 | } | ||
| 376 | if (type == VirtualMemoryArea::Type::Allocated && (offset + size != next.offset)) { | ||
| 377 | return {}; | ||
| 378 | } | ||
| 379 | if (type == VirtualMemoryArea::Type::Mapped && backing_memory + size != next.backing_memory) { | ||
| 380 | return {}; | ||
| 381 | } | ||
| 382 | return true; | ||
| 383 | } | ||
| 384 | |||
| 385 | MemoryManager::VMAHandle MemoryManager::FindVMA(GPUVAddr target) const { | ||
| 386 | if (target >= address_space_end) { | ||
| 387 | return vma_map.end(); | ||
| 388 | } else { | ||
| 389 | return std::prev(vma_map.upper_bound(target)); | ||
| 390 | } | ||
| 391 | } | ||
| 392 | |||
| 393 | MemoryManager::VMAIter MemoryManager::Allocate(VMAIter vma_handle) { | ||
| 394 | VirtualMemoryArea& vma{vma_handle->second}; | ||
| 395 | |||
| 396 | vma.type = VirtualMemoryArea::Type::Allocated; | ||
| 397 | vma.backing_addr = 0; | ||
| 398 | vma.backing_memory = {}; | ||
| 399 | UpdatePageTableForVMA(vma); | ||
| 400 | |||
| 401 | return MergeAdjacent(vma_handle); | ||
| 402 | } | ||
| 403 | |||
| 404 | MemoryManager::VMAHandle MemoryManager::AllocateMemory(GPUVAddr target, std::size_t offset, | ||
| 405 | u64 size) { | ||
| 406 | |||
| 407 | // This is the appropriately sized VMA that will turn into our allocation. | ||
| 408 | VMAIter vma_handle{CarveVMA(target, size)}; | ||
| 409 | VirtualMemoryArea& vma{vma_handle->second}; | ||
| 410 | |||
| 411 | ASSERT(vma.size == size); | ||
| 412 | |||
| 413 | vma.offset = offset; | ||
| 414 | |||
| 415 | return Allocate(vma_handle); | ||
| 416 | } | ||
| 417 | |||
| 418 | MemoryManager::VMAHandle MemoryManager::MapBackingMemory(GPUVAddr target, u8* memory, u64 size, | ||
| 419 | VAddr backing_addr) { | ||
| 420 | // This is the appropriately sized VMA that will turn into our allocation. | ||
| 421 | VMAIter vma_handle{CarveVMA(target, size)}; | ||
| 422 | VirtualMemoryArea& vma{vma_handle->second}; | ||
| 423 | |||
| 424 | ASSERT(vma.size == size); | ||
| 425 | |||
| 426 | vma.type = VirtualMemoryArea::Type::Mapped; | ||
| 427 | vma.backing_memory = memory; | ||
| 428 | vma.backing_addr = backing_addr; | ||
| 429 | UpdatePageTableForVMA(vma); | ||
| 430 | |||
| 431 | return MergeAdjacent(vma_handle); | ||
| 432 | } | ||
| 433 | |||
| 434 | void MemoryManager::UnmapRange(GPUVAddr target, u64 size) { | ||
| 435 | VMAIter vma{CarveVMARange(target, size)}; | ||
| 436 | const VAddr target_end{target + size}; | ||
| 437 | const VMAIter end{vma_map.end()}; | ||
| 438 | |||
| 439 | // The comparison against the end of the range must be done using addresses since VMAs can be | ||
| 440 | // merged during this process, causing invalidation of the iterators. | ||
| 441 | while (vma != end && vma->second.base < target_end) { | ||
| 442 | // Unmapped ranges return to allocated state and can be reused | ||
| 443 | // This behavior is used by Super Mario Odyssey, Sonic Forces, and likely other games | ||
| 444 | vma = std::next(Allocate(vma)); | ||
| 445 | } | ||
| 446 | |||
| 447 | ASSERT(FindVMA(target)->second.size >= size); | ||
| 448 | } | ||
| 449 | |||
| 450 | MemoryManager::VMAIter MemoryManager::StripIterConstness(const VMAHandle& iter) { | ||
| 451 | // This uses a neat C++ trick to convert a const_iterator to a regular iterator, given | ||
| 452 | // non-const access to its container. | ||
| 453 | return vma_map.erase(iter, iter); // Erases an empty range of elements | ||
| 454 | } | ||
| 455 | |||
| 456 | MemoryManager::VMAIter MemoryManager::CarveVMA(GPUVAddr base, u64 size) { | ||
| 457 | ASSERT_MSG((size & page_mask) == 0, "non-page aligned size: 0x{:016X}", size); | ||
| 458 | ASSERT_MSG((base & page_mask) == 0, "non-page aligned base: 0x{:016X}", base); | ||
| 459 | |||
| 460 | VMAIter vma_handle{StripIterConstness(FindVMA(base))}; | ||
| 461 | if (vma_handle == vma_map.end()) { | ||
| 462 | // Target address is outside the managed range | ||
| 463 | return {}; | ||
| 464 | } | ||
| 465 | |||
| 466 | const VirtualMemoryArea& vma{vma_handle->second}; | ||
| 467 | if (vma.type == VirtualMemoryArea::Type::Mapped) { | ||
| 468 | // Region is already allocated | ||
| 469 | return vma_handle; | ||
| 470 | } | ||
| 471 | |||
| 472 | const VAddr start_in_vma{base - vma.base}; | ||
| 473 | const VAddr end_in_vma{start_in_vma + size}; | ||
| 474 | |||
| 475 | ASSERT_MSG(end_in_vma <= vma.size, "region size 0x{:016X} is less than required size 0x{:016X}", | ||
| 476 | vma.size, end_in_vma); | ||
| 477 | |||
| 478 | if (end_in_vma < vma.size) { | ||
| 479 | // Split VMA at the end of the allocated region | ||
| 480 | SplitVMA(vma_handle, end_in_vma); | ||
| 481 | } | ||
| 482 | if (start_in_vma != 0) { | ||
| 483 | // Split VMA at the start of the allocated region | ||
| 484 | vma_handle = SplitVMA(vma_handle, start_in_vma); | ||
| 485 | } | ||
| 486 | |||
| 487 | return vma_handle; | ||
| 488 | } | ||
| 489 | |||
| 490 | MemoryManager::VMAIter MemoryManager::CarveVMARange(GPUVAddr target, u64 size) { | ||
| 491 | ASSERT_MSG((size & page_mask) == 0, "non-page aligned size: 0x{:016X}", size); | ||
| 492 | ASSERT_MSG((target & page_mask) == 0, "non-page aligned base: 0x{:016X}", target); | ||
| 493 | |||
| 494 | const VAddr target_end{target + size}; | ||
| 495 | ASSERT(target_end >= target); | ||
| 496 | ASSERT(size > 0); | ||
| 497 | |||
| 498 | VMAIter begin_vma{StripIterConstness(FindVMA(target))}; | ||
| 499 | const VMAIter i_end{vma_map.lower_bound(target_end)}; | ||
| 500 | if (std::any_of(begin_vma, i_end, [](const auto& entry) { | ||
| 501 | return entry.second.type == VirtualMemoryArea::Type::Unmapped; | ||
| 502 | })) { | ||
| 503 | return {}; | 318 | return {}; |
| 504 | } | 319 | } |
| 505 | 320 | const std::size_t page{(*cpu_addr & Core::Memory::PAGE_MASK) + size}; | |
| 506 | if (target != begin_vma->second.base) { | 321 | return page <= Core::Memory::PAGE_SIZE; |
| 507 | begin_vma = SplitVMA(begin_vma, target - begin_vma->second.base); | ||
| 508 | } | ||
| 509 | |||
| 510 | VMAIter end_vma{StripIterConstness(FindVMA(target_end))}; | ||
| 511 | if (end_vma != vma_map.end() && target_end != end_vma->second.base) { | ||
| 512 | end_vma = SplitVMA(end_vma, target_end - end_vma->second.base); | ||
| 513 | } | ||
| 514 | |||
| 515 | return begin_vma; | ||
| 516 | } | ||
| 517 | |||
| 518 | MemoryManager::VMAIter MemoryManager::SplitVMA(VMAIter vma_handle, u64 offset_in_vma) { | ||
| 519 | VirtualMemoryArea& old_vma{vma_handle->second}; | ||
| 520 | VirtualMemoryArea new_vma{old_vma}; // Make a copy of the VMA | ||
| 521 | |||
| 522 | // For now, don't allow no-op VMA splits (trying to split at a boundary) because it's probably | ||
| 523 | // a bug. This restriction might be removed later. | ||
| 524 | ASSERT(offset_in_vma < old_vma.size); | ||
| 525 | ASSERT(offset_in_vma > 0); | ||
| 526 | |||
| 527 | old_vma.size = offset_in_vma; | ||
| 528 | new_vma.base += offset_in_vma; | ||
| 529 | new_vma.size -= offset_in_vma; | ||
| 530 | |||
| 531 | switch (new_vma.type) { | ||
| 532 | case VirtualMemoryArea::Type::Unmapped: | ||
| 533 | break; | ||
| 534 | case VirtualMemoryArea::Type::Allocated: | ||
| 535 | new_vma.offset += offset_in_vma; | ||
| 536 | break; | ||
| 537 | case VirtualMemoryArea::Type::Mapped: | ||
| 538 | new_vma.backing_memory += offset_in_vma; | ||
| 539 | break; | ||
| 540 | } | ||
| 541 | |||
| 542 | ASSERT(old_vma.CanBeMergedWith(new_vma)); | ||
| 543 | |||
| 544 | return vma_map.emplace_hint(std::next(vma_handle), new_vma.base, new_vma); | ||
| 545 | } | ||
| 546 | |||
| 547 | MemoryManager::VMAIter MemoryManager::MergeAdjacent(VMAIter iter) { | ||
| 548 | const VMAIter next_vma{std::next(iter)}; | ||
| 549 | if (next_vma != vma_map.end() && iter->second.CanBeMergedWith(next_vma->second)) { | ||
| 550 | iter->second.size += next_vma->second.size; | ||
| 551 | vma_map.erase(next_vma); | ||
| 552 | } | ||
| 553 | |||
| 554 | if (iter != vma_map.begin()) { | ||
| 555 | VMAIter prev_vma{std::prev(iter)}; | ||
| 556 | if (prev_vma->second.CanBeMergedWith(iter->second)) { | ||
| 557 | prev_vma->second.size += iter->second.size; | ||
| 558 | vma_map.erase(iter); | ||
| 559 | iter = prev_vma; | ||
| 560 | } | ||
| 561 | } | ||
| 562 | |||
| 563 | return iter; | ||
| 564 | } | ||
| 565 | |||
| 566 | void MemoryManager::UpdatePageTableForVMA(const VirtualMemoryArea& vma) { | ||
| 567 | switch (vma.type) { | ||
| 568 | case VirtualMemoryArea::Type::Unmapped: | ||
| 569 | UnmapRegion(vma.base, vma.size); | ||
| 570 | break; | ||
| 571 | case VirtualMemoryArea::Type::Allocated: | ||
| 572 | MapMemoryRegion(vma.base, vma.size, nullptr, vma.backing_addr); | ||
| 573 | break; | ||
| 574 | case VirtualMemoryArea::Type::Mapped: | ||
| 575 | MapMemoryRegion(vma.base, vma.size, vma.backing_memory, vma.backing_addr); | ||
| 576 | break; | ||
| 577 | } | ||
| 578 | } | 322 | } |
| 579 | 323 | ||
| 580 | } // namespace Tegra | 324 | } // namespace Tegra |
diff --git a/src/video_core/memory_manager.h b/src/video_core/memory_manager.h index 87658e87a..681bd9588 100644 --- a/src/video_core/memory_manager.h +++ b/src/video_core/memory_manager.h | |||
| @@ -6,9 +6,9 @@ | |||
| 6 | 6 | ||
| 7 | #include <map> | 7 | #include <map> |
| 8 | #include <optional> | 8 | #include <optional> |
| 9 | #include <vector> | ||
| 9 | 10 | ||
| 10 | #include "common/common_types.h" | 11 | #include "common/common_types.h" |
| 11 | #include "common/page_table.h" | ||
| 12 | 12 | ||
| 13 | namespace VideoCore { | 13 | namespace VideoCore { |
| 14 | class RasterizerInterface; | 14 | class RasterizerInterface; |
| @@ -20,45 +20,57 @@ class System; | |||
| 20 | 20 | ||
| 21 | namespace Tegra { | 21 | namespace Tegra { |
| 22 | 22 | ||
| 23 | /** | 23 | class PageEntry final { |
| 24 | * Represents a VMA in an address space. A VMA is a contiguous region of virtual addressing space | 24 | public: |
| 25 | * with homogeneous attributes across its extents. In this particular implementation each VMA is | 25 | enum class State : u32 { |
| 26 | * also backed by a single host memory allocation. | 26 | Unmapped = static_cast<u32>(-1), |
| 27 | */ | 27 | Allocated = static_cast<u32>(-2), |
| 28 | struct VirtualMemoryArea { | ||
| 29 | enum class Type : u8 { | ||
| 30 | Unmapped, | ||
| 31 | Allocated, | ||
| 32 | Mapped, | ||
| 33 | }; | 28 | }; |
| 34 | 29 | ||
| 35 | /// Virtual base address of the region. | 30 | constexpr PageEntry() = default; |
| 36 | GPUVAddr base{}; | 31 | constexpr PageEntry(State state) : state{state} {} |
| 37 | /// Size of the region. | 32 | constexpr PageEntry(VAddr addr) : state{static_cast<State>(addr >> ShiftBits)} {} |
| 38 | u64 size{}; | 33 | |
| 39 | /// Memory area mapping type. | 34 | constexpr bool IsUnmapped() const { |
| 40 | Type type{Type::Unmapped}; | 35 | return state == State::Unmapped; |
| 41 | /// CPU memory mapped address corresponding to this memory area. | 36 | } |
| 42 | VAddr backing_addr{}; | 37 | |
| 43 | /// Offset into the backing_memory the mapping starts from. | 38 | constexpr bool IsAllocated() const { |
| 44 | std::size_t offset{}; | 39 | return state == State::Allocated; |
| 45 | /// Pointer backing this VMA. | 40 | } |
| 46 | u8* backing_memory{}; | 41 | |
| 47 | 42 | constexpr bool IsValid() const { | |
| 48 | /// Tests if this area can be merged to the right with `next`. | 43 | return !IsUnmapped() && !IsAllocated(); |
| 49 | bool CanBeMergedWith(const VirtualMemoryArea& next) const; | 44 | } |
| 45 | |||
| 46 | constexpr VAddr ToAddress() const { | ||
| 47 | if (!IsValid()) { | ||
| 48 | return {}; | ||
| 49 | } | ||
| 50 | |||
| 51 | return static_cast<VAddr>(state) << ShiftBits; | ||
| 52 | } | ||
| 53 | |||
| 54 | constexpr PageEntry operator+(u64 offset) { | ||
| 55 | // If this is a reserved value, offsets do not apply | ||
| 56 | if (!IsValid()) { | ||
| 57 | return *this; | ||
| 58 | } | ||
| 59 | return PageEntry{(static_cast<VAddr>(state) << ShiftBits) + offset}; | ||
| 60 | } | ||
| 61 | |||
| 62 | private: | ||
| 63 | static constexpr std::size_t ShiftBits{12}; | ||
| 64 | |||
| 65 | State state{State::Unmapped}; | ||
| 50 | }; | 66 | }; |
| 67 | static_assert(sizeof(PageEntry) == 4, "PageEntry is too large"); | ||
| 51 | 68 | ||
| 52 | class MemoryManager final { | 69 | class MemoryManager final { |
| 53 | public: | 70 | public: |
| 54 | explicit MemoryManager(Core::System& system, VideoCore::RasterizerInterface& rasterizer); | 71 | explicit MemoryManager(Core::System& system, VideoCore::RasterizerInterface& rasterizer); |
| 55 | ~MemoryManager(); | 72 | ~MemoryManager(); |
| 56 | 73 | ||
| 57 | GPUVAddr AllocateSpace(u64 size, u64 align); | ||
| 58 | GPUVAddr AllocateSpace(GPUVAddr addr, u64 size, u64 align); | ||
| 59 | GPUVAddr MapBufferEx(VAddr cpu_addr, u64 size); | ||
| 60 | GPUVAddr MapBufferEx(VAddr cpu_addr, GPUVAddr addr, u64 size); | ||
| 61 | GPUVAddr UnmapBuffer(GPUVAddr addr, u64 size); | ||
| 62 | std::optional<VAddr> GpuToCpuAddress(GPUVAddr addr) const; | 74 | std::optional<VAddr> GpuToCpuAddress(GPUVAddr addr) const; |
| 63 | 75 | ||
| 64 | template <typename T> | 76 | template <typename T> |
| @@ -70,9 +82,6 @@ public: | |||
| 70 | u8* GetPointer(GPUVAddr addr); | 82 | u8* GetPointer(GPUVAddr addr); |
| 71 | const u8* GetPointer(GPUVAddr addr) const; | 83 | const u8* GetPointer(GPUVAddr addr) const; |
| 72 | 84 | ||
| 73 | /// Returns true if the block is continuous in host memory, false otherwise | ||
| 74 | bool IsBlockContinuous(GPUVAddr start, std::size_t size) const; | ||
| 75 | |||
| 76 | /** | 85 | /** |
| 77 | * ReadBlock and WriteBlock are full read and write operations over virtual | 86 | * ReadBlock and WriteBlock are full read and write operations over virtual |
| 78 | * GPU Memory. It's important to use these when GPU memory may not be continuous | 87 | * GPU Memory. It's important to use these when GPU memory may not be continuous |
| @@ -98,92 +107,43 @@ public: | |||
| 98 | void CopyBlockUnsafe(GPUVAddr gpu_dest_addr, GPUVAddr gpu_src_addr, std::size_t size); | 107 | void CopyBlockUnsafe(GPUVAddr gpu_dest_addr, GPUVAddr gpu_src_addr, std::size_t size); |
| 99 | 108 | ||
| 100 | /** | 109 | /** |
| 101 | * IsGranularRange checks if a gpu region can be simply read with a pointer | 110 | * IsGranularRange checks if a gpu region can be simply read with a pointer. |
| 102 | */ | 111 | */ |
| 103 | bool IsGranularRange(GPUVAddr gpu_addr, std::size_t size); | 112 | bool IsGranularRange(GPUVAddr gpu_addr, std::size_t size); |
| 104 | 113 | ||
| 105 | private: | 114 | GPUVAddr Map(VAddr cpu_addr, GPUVAddr gpu_addr, std::size_t size); |
| 106 | using VMAMap = std::map<GPUVAddr, VirtualMemoryArea>; | 115 | GPUVAddr MapAllocate(VAddr cpu_addr, std::size_t size, std::size_t align); |
| 107 | using VMAHandle = VMAMap::const_iterator; | 116 | std::optional<GPUVAddr> AllocateFixed(GPUVAddr gpu_addr, std::size_t size); |
| 108 | using VMAIter = VMAMap::iterator; | 117 | GPUVAddr Allocate(std::size_t size, std::size_t align); |
| 109 | 118 | void Unmap(GPUVAddr gpu_addr, std::size_t size); | |
| 110 | bool IsAddressValid(GPUVAddr addr) const; | ||
| 111 | void MapPages(GPUVAddr base, u64 size, u8* memory, Common::PageType type, | ||
| 112 | VAddr backing_addr = 0); | ||
| 113 | void MapMemoryRegion(GPUVAddr base, u64 size, u8* target, VAddr backing_addr); | ||
| 114 | void UnmapRegion(GPUVAddr base, u64 size); | ||
| 115 | |||
| 116 | /// Finds the VMA in which the given address is included in, or `vma_map.end()`. | ||
| 117 | VMAHandle FindVMA(GPUVAddr target) const; | ||
| 118 | |||
| 119 | VMAHandle AllocateMemory(GPUVAddr target, std::size_t offset, u64 size); | ||
| 120 | |||
| 121 | /** | ||
| 122 | * Maps an unmanaged host memory pointer at a given address. | ||
| 123 | * | ||
| 124 | * @param target The guest address to start the mapping at. | ||
| 125 | * @param memory The memory to be mapped. | ||
| 126 | * @param size Size of the mapping in bytes. | ||
| 127 | * @param backing_addr The base address of the range to back this mapping. | ||
| 128 | */ | ||
| 129 | VMAHandle MapBackingMemory(GPUVAddr target, u8* memory, u64 size, VAddr backing_addr); | ||
| 130 | |||
| 131 | /// Unmaps a range of addresses, splitting VMAs as necessary. | ||
| 132 | void UnmapRange(GPUVAddr target, u64 size); | ||
| 133 | |||
| 134 | /// Converts a VMAHandle to a mutable VMAIter. | ||
| 135 | VMAIter StripIterConstness(const VMAHandle& iter); | ||
| 136 | |||
| 137 | /// Marks as the specified VMA as allocated. | ||
| 138 | VMAIter Allocate(VMAIter vma); | ||
| 139 | |||
| 140 | /** | ||
| 141 | * Carves a VMA of a specific size at the specified address by splitting Free VMAs while doing | ||
| 142 | * the appropriate error checking. | ||
| 143 | */ | ||
| 144 | VMAIter CarveVMA(GPUVAddr base, u64 size); | ||
| 145 | |||
| 146 | /** | ||
| 147 | * Splits the edges of the given range of non-Free VMAs so that there is a VMA split at each | ||
| 148 | * end of the range. | ||
| 149 | */ | ||
| 150 | VMAIter CarveVMARange(GPUVAddr base, u64 size); | ||
| 151 | |||
| 152 | /** | ||
| 153 | * Splits a VMA in two, at the specified offset. | ||
| 154 | * @returns the right side of the split, with the original iterator becoming the left side. | ||
| 155 | */ | ||
| 156 | VMAIter SplitVMA(VMAIter vma, u64 offset_in_vma); | ||
| 157 | 119 | ||
| 158 | /** | 120 | private: |
| 159 | * Checks for and merges the specified VMA with adjacent ones if possible. | 121 | PageEntry GetPageEntry(GPUVAddr gpu_addr) const; |
| 160 | * @returns the merged VMA or the original if no merging was possible. | 122 | void SetPageEntry(GPUVAddr gpu_addr, PageEntry page_entry, std::size_t size = page_size); |
| 161 | */ | 123 | GPUVAddr UpdateRange(GPUVAddr gpu_addr, PageEntry page_entry, std::size_t size); |
| 162 | VMAIter MergeAdjacent(VMAIter vma); | 124 | std::optional<GPUVAddr> FindFreeRange(std::size_t size, std::size_t align) const; |
| 163 | 125 | ||
| 164 | /// Updates the pages corresponding to this VMA so they match the VMA's attributes. | 126 | void TryLockPage(PageEntry page_entry, std::size_t size); |
| 165 | void UpdatePageTableForVMA(const VirtualMemoryArea& vma); | 127 | void TryUnlockPage(PageEntry page_entry, std::size_t size); |
| 166 | 128 | ||
| 167 | /// Finds a free (unmapped region) of the specified size starting at the specified address. | 129 | static constexpr std::size_t PageEntryIndex(GPUVAddr gpu_addr) { |
| 168 | GPUVAddr FindFreeRegion(GPUVAddr region_start, u64 size) const; | 130 | return (gpu_addr >> page_bits) & page_table_mask; |
| 131 | } | ||
| 169 | 132 | ||
| 170 | private: | 133 | static constexpr u64 address_space_size = 1ULL << 40; |
| 134 | static constexpr u64 address_space_start = 1ULL << 32; | ||
| 171 | static constexpr u64 page_bits{16}; | 135 | static constexpr u64 page_bits{16}; |
| 172 | static constexpr u64 page_size{1 << page_bits}; | 136 | static constexpr u64 page_size{1 << page_bits}; |
| 173 | static constexpr u64 page_mask{page_size - 1}; | 137 | static constexpr u64 page_mask{page_size - 1}; |
| 138 | static constexpr u64 page_table_bits{24}; | ||
| 139 | static constexpr u64 page_table_size{1 << page_table_bits}; | ||
| 140 | static constexpr u64 page_table_mask{page_table_size - 1}; | ||
| 174 | 141 | ||
| 175 | /// Address space in bits, according to Tegra X1 TRM | 142 | Core::System& system; |
| 176 | static constexpr u32 address_space_width{40}; | ||
| 177 | /// Start address for mapping, this is fairly arbitrary but must be non-zero. | ||
| 178 | static constexpr GPUVAddr address_space_base{0x100000}; | ||
| 179 | /// End of address space, based on address space in bits. | ||
| 180 | static constexpr GPUVAddr address_space_end{1ULL << address_space_width}; | ||
| 181 | 143 | ||
| 182 | Common::PageTable page_table; | ||
| 183 | VMAMap vma_map; | ||
| 184 | VideoCore::RasterizerInterface& rasterizer; | 144 | VideoCore::RasterizerInterface& rasterizer; |
| 185 | 145 | ||
| 186 | Core::System& system; | 146 | std::vector<PageEntry> page_table; |
| 187 | }; | 147 | }; |
| 188 | 148 | ||
| 189 | } // namespace Tegra | 149 | } // namespace Tegra |
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.cpp b/src/video_core/renderer_opengl/gl_rasterizer.cpp index 03e82c599..cb284db77 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.cpp +++ b/src/video_core/renderer_opengl/gl_rasterizer.cpp | |||
| @@ -178,16 +178,11 @@ RasterizerOpenGL::RasterizerOpenGL(Core::System& system, Core::Frontend::EmuWind | |||
| 178 | 178 | ||
| 179 | if (device.UseAsynchronousShaders()) { | 179 | if (device.UseAsynchronousShaders()) { |
| 180 | // Max worker threads we should allow | 180 | // Max worker threads we should allow |
| 181 | constexpr auto MAX_THREADS = 2u; | 181 | constexpr u32 MAX_THREADS = 4; |
| 182 | // Amount of threads we should reserve for other parts of yuzu | 182 | // Deduce how many threads we can use |
| 183 | constexpr auto RESERVED_THREADS = 6u; | 183 | const u32 threads_used = std::thread::hardware_concurrency() / 4; |
| 184 | // Get the amount of threads we can use(this can return zero) | ||
| 185 | const auto cpu_thread_count = | ||
| 186 | std::max(RESERVED_THREADS, std::thread::hardware_concurrency()); | ||
| 187 | // Deduce how many "extra" threads we have to use. | ||
| 188 | const auto max_threads_unused = cpu_thread_count - RESERVED_THREADS; | ||
| 189 | // Always allow at least 1 thread regardless of our settings | 184 | // Always allow at least 1 thread regardless of our settings |
| 190 | const auto max_worker_count = std::max(1u, max_threads_unused); | 185 | const auto max_worker_count = std::max(1U, threads_used); |
| 191 | // Don't use more than MAX_THREADS | 186 | // Don't use more than MAX_THREADS |
| 192 | const auto worker_count = std::min(max_worker_count, MAX_THREADS); | 187 | const auto worker_count = std::min(max_worker_count, MAX_THREADS); |
| 193 | async_shaders.AllocateWorkers(worker_count); | 188 | async_shaders.AllocateWorkers(worker_count); |
diff --git a/src/video_core/renderer_vulkan/vk_blit_screen.cpp b/src/video_core/renderer_vulkan/vk_blit_screen.cpp index ce53e5a6b..a551e3de8 100644 --- a/src/video_core/renderer_vulkan/vk_blit_screen.cpp +++ b/src/video_core/renderer_vulkan/vk_blit_screen.cpp | |||
| @@ -696,6 +696,7 @@ void VKBlitScreen::CreateFramebuffers() { | |||
| 696 | .flags = 0, | 696 | .flags = 0, |
| 697 | .renderPass = *renderpass, | 697 | .renderPass = *renderpass, |
| 698 | .attachmentCount = 1, | 698 | .attachmentCount = 1, |
| 699 | .pAttachments = nullptr, | ||
| 699 | .width = size.width, | 700 | .width = size.width, |
| 700 | .height = size.height, | 701 | .height = size.height, |
| 701 | .layers = 1, | 702 | .layers = 1, |
diff --git a/src/video_core/renderer_vulkan/vk_device.cpp b/src/video_core/renderer_vulkan/vk_device.cpp index 6245e0d78..0c03e4d83 100644 --- a/src/video_core/renderer_vulkan/vk_device.cpp +++ b/src/video_core/renderer_vulkan/vk_device.cpp | |||
| @@ -771,8 +771,9 @@ std::vector<VkDeviceQueueCreateInfo> VKDevice::GetDeviceQueueCreateInfos() const | |||
| 771 | .pNext = nullptr, | 771 | .pNext = nullptr, |
| 772 | .flags = 0, | 772 | .flags = 0, |
| 773 | .queueFamilyIndex = queue_family, | 773 | .queueFamilyIndex = queue_family, |
| 774 | .queueCount = 1, | ||
| 775 | .pQueuePriorities = nullptr, | ||
| 774 | }); | 776 | }); |
| 775 | ci.queueCount = 1; | ||
| 776 | ci.pQueuePriorities = &QUEUE_PRIORITY; | 777 | ci.pQueuePriorities = &QUEUE_PRIORITY; |
| 777 | } | 778 | } |
| 778 | 779 | ||
diff --git a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp index 42b3a744c..418c62bc4 100644 --- a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp | |||
| @@ -261,8 +261,13 @@ VKComputePipeline& VKPipelineCache::GetComputePipeline(const ComputePipelineCach | |||
| 261 | } | 261 | } |
| 262 | 262 | ||
| 263 | const Specialization specialization{ | 263 | const Specialization specialization{ |
| 264 | .base_binding = 0, | ||
| 264 | .workgroup_size = key.workgroup_size, | 265 | .workgroup_size = key.workgroup_size, |
| 265 | .shared_memory_size = key.shared_memory_size, | 266 | .shared_memory_size = key.shared_memory_size, |
| 267 | .point_size = std::nullopt, | ||
| 268 | .enabled_attributes = {}, | ||
| 269 | .attribute_types = {}, | ||
| 270 | .ndc_minus_one_to_one = false, | ||
| 266 | }; | 271 | }; |
| 267 | const SPIRVShader spirv_shader{Decompile(device, shader->GetIR(), ShaderType::Compute, | 272 | const SPIRVShader spirv_shader{Decompile(device, shader->GetIR(), ShaderType::Compute, |
| 268 | shader->GetRegistry(), specialization), | 273 | shader->GetRegistry(), specialization), |
diff --git a/src/video_core/renderer_vulkan/vk_rasterizer.cpp b/src/video_core/renderer_vulkan/vk_rasterizer.cpp index 2ed2004f0..7500e8244 100644 --- a/src/video_core/renderer_vulkan/vk_rasterizer.cpp +++ b/src/video_core/renderer_vulkan/vk_rasterizer.cpp | |||
| @@ -815,8 +815,13 @@ bool RasterizerVulkan::WalkAttachmentOverlaps(const CachedSurfaceView& attachmen | |||
| 815 | 815 | ||
| 816 | std::tuple<VkFramebuffer, VkExtent2D> RasterizerVulkan::ConfigureFramebuffers( | 816 | std::tuple<VkFramebuffer, VkExtent2D> RasterizerVulkan::ConfigureFramebuffers( |
| 817 | VkRenderPass renderpass) { | 817 | VkRenderPass renderpass) { |
| 818 | FramebufferCacheKey key{renderpass, std::numeric_limits<u32>::max(), | 818 | FramebufferCacheKey key{ |
| 819 | std::numeric_limits<u32>::max(), std::numeric_limits<u32>::max()}; | 819 | .renderpass = renderpass, |
| 820 | .width = std::numeric_limits<u32>::max(), | ||
| 821 | .height = std::numeric_limits<u32>::max(), | ||
| 822 | .layers = std::numeric_limits<u32>::max(), | ||
| 823 | .views = {}, | ||
| 824 | }; | ||
| 820 | 825 | ||
| 821 | const auto try_push = [&key](const View& view) { | 826 | const auto try_push = [&key](const View& view) { |
| 822 | if (!view) { | 827 | if (!view) { |
diff --git a/src/video_core/renderer_vulkan/vk_sampler_cache.cpp b/src/video_core/renderer_vulkan/vk_sampler_cache.cpp index 2d5460776..b068888f9 100644 --- a/src/video_core/renderer_vulkan/vk_sampler_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_sampler_cache.cpp | |||
| @@ -47,6 +47,7 @@ vk::Sampler VKSamplerCache::CreateSampler(const Tegra::Texture::TSCEntry& tsc) c | |||
| 47 | VkSamplerCustomBorderColorCreateInfoEXT border{ | 47 | VkSamplerCustomBorderColorCreateInfoEXT border{ |
| 48 | .sType = VK_STRUCTURE_TYPE_SAMPLER_CUSTOM_BORDER_COLOR_CREATE_INFO_EXT, | 48 | .sType = VK_STRUCTURE_TYPE_SAMPLER_CUSTOM_BORDER_COLOR_CREATE_INFO_EXT, |
| 49 | .pNext = nullptr, | 49 | .pNext = nullptr, |
| 50 | .customBorderColor = {}, | ||
| 50 | .format = VK_FORMAT_UNDEFINED, | 51 | .format = VK_FORMAT_UNDEFINED, |
| 51 | }; | 52 | }; |
| 52 | std::memcpy(&border.customBorderColor, color.data(), sizeof(color)); | 53 | std::memcpy(&border.customBorderColor, color.data(), sizeof(color)); |
diff --git a/src/video_core/renderer_vulkan/vk_texture_cache.cpp b/src/video_core/renderer_vulkan/vk_texture_cache.cpp index efd4bb13b..2c6f54101 100644 --- a/src/video_core/renderer_vulkan/vk_texture_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_texture_cache.cpp | |||
| @@ -473,6 +473,8 @@ VkImageView CachedSurfaceView::GetAttachment() { | |||
| 473 | .aspectMask = aspect_mask, | 473 | .aspectMask = aspect_mask, |
| 474 | .baseMipLevel = base_level, | 474 | .baseMipLevel = base_level, |
| 475 | .levelCount = num_levels, | 475 | .levelCount = num_levels, |
| 476 | .baseArrayLayer = 0, | ||
| 477 | .layerCount = 0, | ||
| 476 | }, | 478 | }, |
| 477 | }; | 479 | }; |
| 478 | if (image_view_type == VK_IMAGE_VIEW_TYPE_3D) { | 480 | if (image_view_type == VK_IMAGE_VIEW_TYPE_3D) { |
diff --git a/src/video_core/texture_cache/surface_params.cpp b/src/video_core/texture_cache/surface_params.cpp index 9e5fe2374..9a98f0e98 100644 --- a/src/video_core/texture_cache/surface_params.cpp +++ b/src/video_core/texture_cache/surface_params.cpp | |||
| @@ -74,9 +74,9 @@ SurfaceParams SurfaceParams::CreateForTexture(const FormatLookupTable& lookup_ta | |||
| 74 | SurfaceParams params; | 74 | SurfaceParams params; |
| 75 | params.is_tiled = tic.IsTiled(); | 75 | params.is_tiled = tic.IsTiled(); |
| 76 | params.srgb_conversion = tic.IsSrgbConversionEnabled(); | 76 | params.srgb_conversion = tic.IsSrgbConversionEnabled(); |
| 77 | params.block_width = params.is_tiled ? tic.BlockWidth() : 0, | 77 | params.block_width = params.is_tiled ? tic.BlockWidth() : 0; |
| 78 | params.block_height = params.is_tiled ? tic.BlockHeight() : 0, | 78 | params.block_height = params.is_tiled ? tic.BlockHeight() : 0; |
| 79 | params.block_depth = params.is_tiled ? tic.BlockDepth() : 0, | 79 | params.block_depth = params.is_tiled ? tic.BlockDepth() : 0; |
| 80 | params.tile_width_spacing = params.is_tiled ? (1 << tic.tile_width_spacing.Value()) : 1; | 80 | params.tile_width_spacing = params.is_tiled ? (1 << tic.tile_width_spacing.Value()) : 1; |
| 81 | params.pixel_format = lookup_table.GetPixelFormat( | 81 | params.pixel_format = lookup_table.GetPixelFormat( |
| 82 | tic.format, params.srgb_conversion, tic.r_type, tic.g_type, tic.b_type, tic.a_type); | 82 | tic.format, params.srgb_conversion, tic.r_type, tic.g_type, tic.b_type, tic.a_type); |
| @@ -130,14 +130,13 @@ SurfaceParams SurfaceParams::CreateForImage(const FormatLookupTable& lookup_tabl | |||
| 130 | SurfaceParams params; | 130 | SurfaceParams params; |
| 131 | params.is_tiled = tic.IsTiled(); | 131 | params.is_tiled = tic.IsTiled(); |
| 132 | params.srgb_conversion = tic.IsSrgbConversionEnabled(); | 132 | params.srgb_conversion = tic.IsSrgbConversionEnabled(); |
| 133 | params.block_width = params.is_tiled ? tic.BlockWidth() : 0, | 133 | params.block_width = params.is_tiled ? tic.BlockWidth() : 0; |
| 134 | params.block_height = params.is_tiled ? tic.BlockHeight() : 0, | 134 | params.block_height = params.is_tiled ? tic.BlockHeight() : 0; |
| 135 | params.block_depth = params.is_tiled ? tic.BlockDepth() : 0, | 135 | params.block_depth = params.is_tiled ? tic.BlockDepth() : 0; |
| 136 | params.tile_width_spacing = params.is_tiled ? (1 << tic.tile_width_spacing.Value()) : 1; | 136 | params.tile_width_spacing = params.is_tiled ? (1 << tic.tile_width_spacing.Value()) : 1; |
| 137 | params.pixel_format = lookup_table.GetPixelFormat( | 137 | params.pixel_format = lookup_table.GetPixelFormat( |
| 138 | tic.format, params.srgb_conversion, tic.r_type, tic.g_type, tic.b_type, tic.a_type); | 138 | tic.format, params.srgb_conversion, tic.r_type, tic.g_type, tic.b_type, tic.a_type); |
| 139 | params.type = GetFormatType(params.pixel_format); | 139 | params.type = GetFormatType(params.pixel_format); |
| 140 | params.type = GetFormatType(params.pixel_format); | ||
| 141 | params.target = ImageTypeToSurfaceTarget(entry.type); | 140 | params.target = ImageTypeToSurfaceTarget(entry.type); |
| 142 | // TODO: on 1DBuffer we should use the tic info. | 141 | // TODO: on 1DBuffer we should use the tic info. |
| 143 | if (tic.IsBuffer()) { | 142 | if (tic.IsBuffer()) { |
| @@ -167,27 +166,30 @@ SurfaceParams SurfaceParams::CreateForImage(const FormatLookupTable& lookup_tabl | |||
| 167 | 166 | ||
| 168 | SurfaceParams SurfaceParams::CreateForDepthBuffer(Core::System& system) { | 167 | SurfaceParams SurfaceParams::CreateForDepthBuffer(Core::System& system) { |
| 169 | const auto& regs = system.GPU().Maxwell3D().regs; | 168 | const auto& regs = system.GPU().Maxwell3D().regs; |
| 170 | SurfaceParams params; | ||
| 171 | params.is_tiled = regs.zeta.memory_layout.type == | ||
| 172 | Tegra::Engines::Maxwell3D::Regs::InvMemoryLayout::BlockLinear; | ||
| 173 | params.srgb_conversion = false; | ||
| 174 | params.block_width = std::min(regs.zeta.memory_layout.block_width.Value(), 5U); | ||
| 175 | params.block_height = std::min(regs.zeta.memory_layout.block_height.Value(), 5U); | ||
| 176 | params.block_depth = std::min(regs.zeta.memory_layout.block_depth.Value(), 5U); | ||
| 177 | params.tile_width_spacing = 1; | ||
| 178 | params.pixel_format = PixelFormatFromDepthFormat(regs.zeta.format); | ||
| 179 | params.type = GetFormatType(params.pixel_format); | ||
| 180 | params.width = regs.zeta_width; | ||
| 181 | params.height = regs.zeta_height; | ||
| 182 | params.pitch = 0; | ||
| 183 | params.num_levels = 1; | ||
| 184 | params.emulated_levels = 1; | ||
| 185 | 169 | ||
| 186 | const bool is_layered = regs.zeta_layers > 1 && params.block_depth == 0; | 170 | const auto block_depth = std::min(regs.zeta.memory_layout.block_depth.Value(), 5U); |
| 187 | params.is_layered = is_layered; | 171 | const bool is_layered = regs.zeta_layers > 1 && block_depth == 0; |
| 188 | params.target = is_layered ? SurfaceTarget::Texture2DArray : SurfaceTarget::Texture2D; | 172 | const auto pixel_format = PixelFormatFromDepthFormat(regs.zeta.format); |
| 189 | params.depth = is_layered ? regs.zeta_layers.Value() : 1U; | 173 | |
| 190 | return params; | 174 | return { |
| 175 | .is_tiled = regs.zeta.memory_layout.type == | ||
| 176 | Tegra::Engines::Maxwell3D::Regs::InvMemoryLayout::BlockLinear, | ||
| 177 | .srgb_conversion = false, | ||
| 178 | .is_layered = is_layered, | ||
| 179 | .block_width = std::min(regs.zeta.memory_layout.block_width.Value(), 5U), | ||
| 180 | .block_height = std::min(regs.zeta.memory_layout.block_height.Value(), 5U), | ||
| 181 | .block_depth = block_depth, | ||
| 182 | .tile_width_spacing = 1, | ||
| 183 | .width = regs.zeta_width, | ||
| 184 | .height = regs.zeta_height, | ||
| 185 | .depth = is_layered ? regs.zeta_layers.Value() : 1U, | ||
| 186 | .pitch = 0, | ||
| 187 | .num_levels = 1, | ||
| 188 | .emulated_levels = 1, | ||
| 189 | .pixel_format = pixel_format, | ||
| 190 | .type = GetFormatType(pixel_format), | ||
| 191 | .target = is_layered ? SurfaceTarget::Texture2DArray : SurfaceTarget::Texture2D, | ||
| 192 | }; | ||
| 191 | } | 193 | } |
| 192 | 194 | ||
| 193 | SurfaceParams SurfaceParams::CreateForFramebuffer(Core::System& system, std::size_t index) { | 195 | SurfaceParams SurfaceParams::CreateForFramebuffer(Core::System& system, std::size_t index) { |
| @@ -233,24 +235,29 @@ SurfaceParams SurfaceParams::CreateForFramebuffer(Core::System& system, std::siz | |||
| 233 | 235 | ||
| 234 | SurfaceParams SurfaceParams::CreateForFermiCopySurface( | 236 | SurfaceParams SurfaceParams::CreateForFermiCopySurface( |
| 235 | const Tegra::Engines::Fermi2D::Regs::Surface& config) { | 237 | const Tegra::Engines::Fermi2D::Regs::Surface& config) { |
| 236 | SurfaceParams params{}; | 238 | const bool is_tiled = !config.linear; |
| 237 | params.is_tiled = !config.linear; | 239 | const auto pixel_format = PixelFormatFromRenderTargetFormat(config.format); |
| 238 | params.srgb_conversion = config.format == Tegra::RenderTargetFormat::B8G8R8A8_SRGB || | 240 | |
| 239 | config.format == Tegra::RenderTargetFormat::A8B8G8R8_SRGB; | 241 | SurfaceParams params{ |
| 240 | params.block_width = params.is_tiled ? std::min(config.BlockWidth(), 5U) : 0, | 242 | .is_tiled = is_tiled, |
| 241 | params.block_height = params.is_tiled ? std::min(config.BlockHeight(), 5U) : 0, | 243 | .srgb_conversion = config.format == Tegra::RenderTargetFormat::B8G8R8A8_SRGB || |
| 242 | params.block_depth = params.is_tiled ? std::min(config.BlockDepth(), 5U) : 0, | 244 | config.format == Tegra::RenderTargetFormat::A8B8G8R8_SRGB, |
| 243 | params.tile_width_spacing = 1; | 245 | .block_width = is_tiled ? std::min(config.BlockWidth(), 5U) : 0U, |
| 244 | params.pixel_format = PixelFormatFromRenderTargetFormat(config.format); | 246 | .block_height = is_tiled ? std::min(config.BlockHeight(), 5U) : 0U, |
| 245 | params.type = GetFormatType(params.pixel_format); | 247 | .block_depth = is_tiled ? std::min(config.BlockDepth(), 5U) : 0U, |
| 246 | params.width = config.width; | 248 | .tile_width_spacing = 1, |
| 247 | params.height = config.height; | 249 | .width = config.width, |
| 248 | params.pitch = config.pitch; | 250 | .height = config.height, |
| 249 | // TODO(Rodrigo): Try to guess texture arrays from parameters | 251 | .depth = 1, |
| 250 | params.target = SurfaceTarget::Texture2D; | 252 | .pitch = config.pitch, |
| 251 | params.depth = 1; | 253 | .num_levels = 1, |
| 252 | params.num_levels = 1; | 254 | .emulated_levels = 1, |
| 253 | params.emulated_levels = 1; | 255 | .pixel_format = pixel_format, |
| 256 | .type = GetFormatType(pixel_format), | ||
| 257 | // TODO(Rodrigo): Try to guess texture arrays from parameters | ||
| 258 | .target = SurfaceTarget::Texture2D, | ||
| 259 | }; | ||
| 260 | |||
| 254 | params.is_layered = params.IsLayered(); | 261 | params.is_layered = params.IsLayered(); |
| 255 | return params; | 262 | return params; |
| 256 | } | 263 | } |
diff --git a/src/yuzu/bootmanager.cpp b/src/yuzu/bootmanager.cpp index 5738787ac..8fc322b30 100644 --- a/src/yuzu/bootmanager.cpp +++ b/src/yuzu/bootmanager.cpp | |||
| @@ -567,7 +567,7 @@ void GRenderWindow::CaptureScreenshot(u32 res_scale, const QString& screenshot_p | |||
| 567 | screenshot_image = QImage(QSize(layout.width, layout.height), QImage::Format_RGB32); | 567 | screenshot_image = QImage(QSize(layout.width, layout.height), QImage::Format_RGB32); |
| 568 | renderer.RequestScreenshot( | 568 | renderer.RequestScreenshot( |
| 569 | screenshot_image.bits(), | 569 | screenshot_image.bits(), |
| 570 | [=] { | 570 | [=, this] { |
| 571 | const std::string std_screenshot_path = screenshot_path.toStdString(); | 571 | const std::string std_screenshot_path = screenshot_path.toStdString(); |
| 572 | if (screenshot_image.mirrored(false, true).save(screenshot_path)) { | 572 | if (screenshot_image.mirrored(false, true).save(screenshot_path)) { |
| 573 | LOG_INFO(Frontend, "Screenshot saved to \"{}\"", std_screenshot_path); | 573 | LOG_INFO(Frontend, "Screenshot saved to \"{}\"", std_screenshot_path); |
diff --git a/src/yuzu/configuration/config.cpp b/src/yuzu/configuration/config.cpp index 59a193edd..cb71b8d11 100644 --- a/src/yuzu/configuration/config.cpp +++ b/src/yuzu/configuration/config.cpp | |||
| @@ -578,7 +578,6 @@ void Config::ReadPathValues() { | |||
| 578 | 578 | ||
| 579 | UISettings::values.roms_path = ReadSetting(QStringLiteral("romsPath")).toString(); | 579 | UISettings::values.roms_path = ReadSetting(QStringLiteral("romsPath")).toString(); |
| 580 | UISettings::values.symbols_path = ReadSetting(QStringLiteral("symbolsPath")).toString(); | 580 | UISettings::values.symbols_path = ReadSetting(QStringLiteral("symbolsPath")).toString(); |
| 581 | UISettings::values.screenshot_path = ReadSetting(QStringLiteral("screenshotPath")).toString(); | ||
| 582 | UISettings::values.game_dir_deprecated = | 581 | UISettings::values.game_dir_deprecated = |
| 583 | ReadSetting(QStringLiteral("gameListRootDir"), QStringLiteral(".")).toString(); | 582 | ReadSetting(QStringLiteral("gameListRootDir"), QStringLiteral(".")).toString(); |
| 584 | UISettings::values.game_dir_deprecated_deepscan = | 583 | UISettings::values.game_dir_deprecated_deepscan = |
| @@ -666,8 +665,6 @@ void Config::ReadRendererValues() { | |||
| 666 | QStringLiteral("use_asynchronous_shaders"), false); | 665 | QStringLiteral("use_asynchronous_shaders"), false); |
| 667 | ReadSettingGlobal(Settings::values.use_fast_gpu_time, QStringLiteral("use_fast_gpu_time"), | 666 | ReadSettingGlobal(Settings::values.use_fast_gpu_time, QStringLiteral("use_fast_gpu_time"), |
| 668 | true); | 667 | true); |
| 669 | ReadSettingGlobal(Settings::values.force_30fps_mode, QStringLiteral("force_30fps_mode"), false); | ||
| 670 | |||
| 671 | ReadSettingGlobal(Settings::values.bg_red, QStringLiteral("bg_red"), 0.0); | 668 | ReadSettingGlobal(Settings::values.bg_red, QStringLiteral("bg_red"), 0.0); |
| 672 | ReadSettingGlobal(Settings::values.bg_green, QStringLiteral("bg_green"), 0.0); | 669 | ReadSettingGlobal(Settings::values.bg_green, QStringLiteral("bg_green"), 0.0); |
| 673 | ReadSettingGlobal(Settings::values.bg_blue, QStringLiteral("bg_blue"), 0.0); | 670 | ReadSettingGlobal(Settings::values.bg_blue, QStringLiteral("bg_blue"), 0.0); |
| @@ -675,6 +672,22 @@ void Config::ReadRendererValues() { | |||
| 675 | qt_config->endGroup(); | 672 | qt_config->endGroup(); |
| 676 | } | 673 | } |
| 677 | 674 | ||
| 675 | void Config::ReadScreenshotValues() { | ||
| 676 | qt_config->beginGroup(QStringLiteral("Screenshots")); | ||
| 677 | |||
| 678 | UISettings::values.enable_screenshot_save_as = | ||
| 679 | ReadSetting(QStringLiteral("enable_screenshot_save_as"), true).toBool(); | ||
| 680 | FileUtil::GetUserPath( | ||
| 681 | FileUtil::UserPath::ScreenshotsDir, | ||
| 682 | qt_config | ||
| 683 | ->value(QStringLiteral("screenshot_path"), QString::fromStdString(FileUtil::GetUserPath( | ||
| 684 | FileUtil::UserPath::ScreenshotsDir))) | ||
| 685 | .toString() | ||
| 686 | .toStdString()); | ||
| 687 | |||
| 688 | qt_config->endGroup(); | ||
| 689 | } | ||
| 690 | |||
| 678 | void Config::ReadShortcutValues() { | 691 | void Config::ReadShortcutValues() { |
| 679 | qt_config->beginGroup(QStringLiteral("Shortcuts")); | 692 | qt_config->beginGroup(QStringLiteral("Shortcuts")); |
| 680 | 693 | ||
| @@ -756,6 +769,7 @@ void Config::ReadUIValues() { | |||
| 756 | ReadUIGamelistValues(); | 769 | ReadUIGamelistValues(); |
| 757 | ReadUILayoutValues(); | 770 | ReadUILayoutValues(); |
| 758 | ReadPathValues(); | 771 | ReadPathValues(); |
| 772 | ReadScreenshotValues(); | ||
| 759 | ReadShortcutValues(); | 773 | ReadShortcutValues(); |
| 760 | 774 | ||
| 761 | UISettings::values.single_window_mode = | 775 | UISettings::values.single_window_mode = |
| @@ -1085,7 +1099,6 @@ void Config::SavePathValues() { | |||
| 1085 | 1099 | ||
| 1086 | WriteSetting(QStringLiteral("romsPath"), UISettings::values.roms_path); | 1100 | WriteSetting(QStringLiteral("romsPath"), UISettings::values.roms_path); |
| 1087 | WriteSetting(QStringLiteral("symbolsPath"), UISettings::values.symbols_path); | 1101 | WriteSetting(QStringLiteral("symbolsPath"), UISettings::values.symbols_path); |
| 1088 | WriteSetting(QStringLiteral("screenshotPath"), UISettings::values.screenshot_path); | ||
| 1089 | qt_config->beginWriteArray(QStringLiteral("gamedirs")); | 1102 | qt_config->beginWriteArray(QStringLiteral("gamedirs")); |
| 1090 | for (int i = 0; i < UISettings::values.game_dirs.size(); ++i) { | 1103 | for (int i = 0; i < UISettings::values.game_dirs.size(); ++i) { |
| 1091 | qt_config->setArrayIndex(i); | 1104 | qt_config->setArrayIndex(i); |
| @@ -1153,9 +1166,6 @@ void Config::SaveRendererValues() { | |||
| 1153 | Settings::values.use_asynchronous_shaders, false); | 1166 | Settings::values.use_asynchronous_shaders, false); |
| 1154 | WriteSettingGlobal(QStringLiteral("use_fast_gpu_time"), Settings::values.use_fast_gpu_time, | 1167 | WriteSettingGlobal(QStringLiteral("use_fast_gpu_time"), Settings::values.use_fast_gpu_time, |
| 1155 | true); | 1168 | true); |
| 1156 | WriteSettingGlobal(QStringLiteral("force_30fps_mode"), Settings::values.force_30fps_mode, | ||
| 1157 | false); | ||
| 1158 | |||
| 1159 | // Cast to double because Qt's written float values are not human-readable | 1169 | // Cast to double because Qt's written float values are not human-readable |
| 1160 | WriteSettingGlobal(QStringLiteral("bg_red"), Settings::values.bg_red, 0.0); | 1170 | WriteSettingGlobal(QStringLiteral("bg_red"), Settings::values.bg_red, 0.0); |
| 1161 | WriteSettingGlobal(QStringLiteral("bg_green"), Settings::values.bg_green, 0.0); | 1171 | WriteSettingGlobal(QStringLiteral("bg_green"), Settings::values.bg_green, 0.0); |
| @@ -1164,6 +1174,17 @@ void Config::SaveRendererValues() { | |||
| 1164 | qt_config->endGroup(); | 1174 | qt_config->endGroup(); |
| 1165 | } | 1175 | } |
| 1166 | 1176 | ||
| 1177 | void Config::SaveScreenshotValues() { | ||
| 1178 | qt_config->beginGroup(QStringLiteral("Screenshots")); | ||
| 1179 | |||
| 1180 | WriteSetting(QStringLiteral("enable_screenshot_save_as"), | ||
| 1181 | UISettings::values.enable_screenshot_save_as); | ||
| 1182 | WriteSetting(QStringLiteral("screenshot_path"), | ||
| 1183 | QString::fromStdString(FileUtil::GetUserPath(FileUtil::UserPath::ScreenshotsDir))); | ||
| 1184 | |||
| 1185 | qt_config->endGroup(); | ||
| 1186 | } | ||
| 1187 | |||
| 1167 | void Config::SaveShortcutValues() { | 1188 | void Config::SaveShortcutValues() { |
| 1168 | qt_config->beginGroup(QStringLiteral("Shortcuts")); | 1189 | qt_config->beginGroup(QStringLiteral("Shortcuts")); |
| 1169 | 1190 | ||
| @@ -1226,6 +1247,7 @@ void Config::SaveUIValues() { | |||
| 1226 | SaveUIGamelistValues(); | 1247 | SaveUIGamelistValues(); |
| 1227 | SaveUILayoutValues(); | 1248 | SaveUILayoutValues(); |
| 1228 | SavePathValues(); | 1249 | SavePathValues(); |
| 1250 | SaveScreenshotValues(); | ||
| 1229 | SaveShortcutValues(); | 1251 | SaveShortcutValues(); |
| 1230 | 1252 | ||
| 1231 | WriteSetting(QStringLiteral("singleWindowMode"), UISettings::values.single_window_mode, true); | 1253 | WriteSetting(QStringLiteral("singleWindowMode"), UISettings::values.single_window_mode, true); |
diff --git a/src/yuzu/configuration/config.h b/src/yuzu/configuration/config.h index 8e815f829..e5f39b040 100644 --- a/src/yuzu/configuration/config.h +++ b/src/yuzu/configuration/config.h | |||
| @@ -51,6 +51,7 @@ private: | |||
| 51 | void ReadPathValues(); | 51 | void ReadPathValues(); |
| 52 | void ReadCpuValues(); | 52 | void ReadCpuValues(); |
| 53 | void ReadRendererValues(); | 53 | void ReadRendererValues(); |
| 54 | void ReadScreenshotValues(); | ||
| 54 | void ReadShortcutValues(); | 55 | void ReadShortcutValues(); |
| 55 | void ReadSystemValues(); | 56 | void ReadSystemValues(); |
| 56 | void ReadUIValues(); | 57 | void ReadUIValues(); |
| @@ -76,6 +77,7 @@ private: | |||
| 76 | void SavePathValues(); | 77 | void SavePathValues(); |
| 77 | void SaveCpuValues(); | 78 | void SaveCpuValues(); |
| 78 | void SaveRendererValues(); | 79 | void SaveRendererValues(); |
| 80 | void SaveScreenshotValues(); | ||
| 79 | void SaveShortcutValues(); | 81 | void SaveShortcutValues(); |
| 80 | void SaveSystemValues(); | 82 | void SaveSystemValues(); |
| 81 | void SaveUIValues(); | 83 | void SaveUIValues(); |
diff --git a/src/yuzu/configuration/configure_graphics_advanced.cpp b/src/yuzu/configuration/configure_graphics_advanced.cpp index 8b9180811..c5d1a778c 100644 --- a/src/yuzu/configuration/configure_graphics_advanced.cpp +++ b/src/yuzu/configuration/configure_graphics_advanced.cpp | |||
| @@ -25,14 +25,12 @@ void ConfigureGraphicsAdvanced::SetConfiguration() { | |||
| 25 | ui->use_vsync->setEnabled(runtime_lock); | 25 | ui->use_vsync->setEnabled(runtime_lock); |
| 26 | ui->use_assembly_shaders->setEnabled(runtime_lock); | 26 | ui->use_assembly_shaders->setEnabled(runtime_lock); |
| 27 | ui->use_asynchronous_shaders->setEnabled(runtime_lock); | 27 | ui->use_asynchronous_shaders->setEnabled(runtime_lock); |
| 28 | ui->force_30fps_mode->setEnabled(runtime_lock); | ||
| 29 | ui->anisotropic_filtering_combobox->setEnabled(runtime_lock); | 28 | ui->anisotropic_filtering_combobox->setEnabled(runtime_lock); |
| 30 | 29 | ||
| 31 | ui->use_vsync->setChecked(Settings::values.use_vsync.GetValue()); | 30 | ui->use_vsync->setChecked(Settings::values.use_vsync.GetValue()); |
| 32 | ui->use_assembly_shaders->setChecked(Settings::values.use_assembly_shaders.GetValue()); | 31 | ui->use_assembly_shaders->setChecked(Settings::values.use_assembly_shaders.GetValue()); |
| 33 | ui->use_asynchronous_shaders->setChecked(Settings::values.use_asynchronous_shaders.GetValue()); | 32 | ui->use_asynchronous_shaders->setChecked(Settings::values.use_asynchronous_shaders.GetValue()); |
| 34 | ui->use_fast_gpu_time->setChecked(Settings::values.use_fast_gpu_time.GetValue()); | 33 | ui->use_fast_gpu_time->setChecked(Settings::values.use_fast_gpu_time.GetValue()); |
| 35 | ui->force_30fps_mode->setChecked(Settings::values.force_30fps_mode.GetValue()); | ||
| 36 | 34 | ||
| 37 | if (Settings::configuring_global) { | 35 | if (Settings::configuring_global) { |
| 38 | ui->gpu_accuracy->setCurrentIndex( | 36 | ui->gpu_accuracy->setCurrentIndex( |
| @@ -78,9 +76,6 @@ void ConfigureGraphicsAdvanced::ApplyConfiguration() { | |||
| 78 | if (Settings::values.use_fast_gpu_time.UsingGlobal()) { | 76 | if (Settings::values.use_fast_gpu_time.UsingGlobal()) { |
| 79 | Settings::values.use_fast_gpu_time.SetValue(ui->use_fast_gpu_time->isChecked()); | 77 | Settings::values.use_fast_gpu_time.SetValue(ui->use_fast_gpu_time->isChecked()); |
| 80 | } | 78 | } |
| 81 | if (Settings::values.force_30fps_mode.UsingGlobal()) { | ||
| 82 | Settings::values.force_30fps_mode.SetValue(ui->force_30fps_mode->isChecked()); | ||
| 83 | } | ||
| 84 | if (Settings::values.max_anisotropy.UsingGlobal()) { | 79 | if (Settings::values.max_anisotropy.UsingGlobal()) { |
| 85 | Settings::values.max_anisotropy.SetValue( | 80 | Settings::values.max_anisotropy.SetValue( |
| 86 | ui->anisotropic_filtering_combobox->currentIndex()); | 81 | ui->anisotropic_filtering_combobox->currentIndex()); |
| @@ -97,8 +92,6 @@ void ConfigureGraphicsAdvanced::ApplyConfiguration() { | |||
| 97 | use_asynchronous_shaders); | 92 | use_asynchronous_shaders); |
| 98 | ConfigurationShared::ApplyPerGameSetting(&Settings::values.use_fast_gpu_time, | 93 | ConfigurationShared::ApplyPerGameSetting(&Settings::values.use_fast_gpu_time, |
| 99 | ui->use_fast_gpu_time, use_fast_gpu_time); | 94 | ui->use_fast_gpu_time, use_fast_gpu_time); |
| 100 | ConfigurationShared::ApplyPerGameSetting(&Settings::values.force_30fps_mode, | ||
| 101 | ui->force_30fps_mode, force_30fps_mode); | ||
| 102 | ConfigurationShared::ApplyPerGameSetting(&Settings::values.max_anisotropy, | 95 | ConfigurationShared::ApplyPerGameSetting(&Settings::values.max_anisotropy, |
| 103 | ui->anisotropic_filtering_combobox); | 96 | ui->anisotropic_filtering_combobox); |
| 104 | 97 | ||
| @@ -132,7 +125,6 @@ void ConfigureGraphicsAdvanced::SetupPerGameUI() { | |||
| 132 | ui->use_asynchronous_shaders->setEnabled( | 125 | ui->use_asynchronous_shaders->setEnabled( |
| 133 | Settings::values.use_asynchronous_shaders.UsingGlobal()); | 126 | Settings::values.use_asynchronous_shaders.UsingGlobal()); |
| 134 | ui->use_fast_gpu_time->setEnabled(Settings::values.use_fast_gpu_time.UsingGlobal()); | 127 | ui->use_fast_gpu_time->setEnabled(Settings::values.use_fast_gpu_time.UsingGlobal()); |
| 135 | ui->force_30fps_mode->setEnabled(Settings::values.force_30fps_mode.UsingGlobal()); | ||
| 136 | ui->anisotropic_filtering_combobox->setEnabled( | 128 | ui->anisotropic_filtering_combobox->setEnabled( |
| 137 | Settings::values.max_anisotropy.UsingGlobal()); | 129 | Settings::values.max_anisotropy.UsingGlobal()); |
| 138 | 130 | ||
| @@ -149,8 +141,6 @@ void ConfigureGraphicsAdvanced::SetupPerGameUI() { | |||
| 149 | Settings::values.use_asynchronous_shaders, use_asynchronous_shaders); | 141 | Settings::values.use_asynchronous_shaders, use_asynchronous_shaders); |
| 150 | ConfigurationShared::SetColoredTristate(ui->use_fast_gpu_time, "use_fast_gpu_time", | 142 | ConfigurationShared::SetColoredTristate(ui->use_fast_gpu_time, "use_fast_gpu_time", |
| 151 | Settings::values.use_fast_gpu_time, use_fast_gpu_time); | 143 | Settings::values.use_fast_gpu_time, use_fast_gpu_time); |
| 152 | ConfigurationShared::SetColoredTristate(ui->force_30fps_mode, "force_30fps_mode", | ||
| 153 | Settings::values.force_30fps_mode, force_30fps_mode); | ||
| 154 | ConfigurationShared::SetColoredComboBox( | 144 | ConfigurationShared::SetColoredComboBox( |
| 155 | ui->gpu_accuracy, ui->label_gpu_accuracy, "label_gpu_accuracy", | 145 | ui->gpu_accuracy, ui->label_gpu_accuracy, "label_gpu_accuracy", |
| 156 | static_cast<int>(Settings::values.gpu_accuracy.GetValue(true))); | 146 | static_cast<int>(Settings::values.gpu_accuracy.GetValue(true))); |
diff --git a/src/yuzu/configuration/configure_graphics_advanced.h b/src/yuzu/configuration/configure_graphics_advanced.h index 3c4f6f7bb..e61b571c7 100644 --- a/src/yuzu/configuration/configure_graphics_advanced.h +++ b/src/yuzu/configuration/configure_graphics_advanced.h | |||
| @@ -38,5 +38,4 @@ private: | |||
| 38 | ConfigurationShared::CheckState use_assembly_shaders; | 38 | ConfigurationShared::CheckState use_assembly_shaders; |
| 39 | ConfigurationShared::CheckState use_asynchronous_shaders; | 39 | ConfigurationShared::CheckState use_asynchronous_shaders; |
| 40 | ConfigurationShared::CheckState use_fast_gpu_time; | 40 | ConfigurationShared::CheckState use_fast_gpu_time; |
| 41 | ConfigurationShared::CheckState force_30fps_mode; | ||
| 42 | }; | 41 | }; |
diff --git a/src/yuzu/configuration/configure_graphics_advanced.ui b/src/yuzu/configuration/configure_graphics_advanced.ui index 6a0d29c27..a793c803d 100644 --- a/src/yuzu/configuration/configure_graphics_advanced.ui +++ b/src/yuzu/configuration/configure_graphics_advanced.ui | |||
| @@ -97,13 +97,6 @@ | |||
| 97 | </widget> | 97 | </widget> |
| 98 | </item> | 98 | </item> |
| 99 | <item> | 99 | <item> |
| 100 | <widget class="QCheckBox" name="force_30fps_mode"> | ||
| 101 | <property name="text"> | ||
| 102 | <string>Force 30 FPS mode</string> | ||
| 103 | </property> | ||
| 104 | </widget> | ||
| 105 | </item> | ||
| 106 | <item> | ||
| 107 | <widget class="QCheckBox" name="use_fast_gpu_time"> | 100 | <widget class="QCheckBox" name="use_fast_gpu_time"> |
| 108 | <property name="text"> | 101 | <property name="text"> |
| 109 | <string>Use Fast GPU Time</string> | 102 | <string>Use Fast GPU Time</string> |
diff --git a/src/yuzu/configuration/configure_input_player.cpp b/src/yuzu/configuration/configure_input_player.cpp index 00433926d..b1850bc95 100644 --- a/src/yuzu/configuration/configure_input_player.cpp +++ b/src/yuzu/configuration/configure_input_player.cpp | |||
| @@ -280,9 +280,9 @@ ConfigureInputPlayer::ConfigureInputPlayer(QWidget* parent, std::size_t player_i | |||
| 280 | } | 280 | } |
| 281 | 281 | ||
| 282 | button->setContextMenuPolicy(Qt::CustomContextMenu); | 282 | button->setContextMenuPolicy(Qt::CustomContextMenu); |
| 283 | connect(button, &QPushButton::clicked, [=] { | 283 | connect(button, &QPushButton::clicked, [=, this] { |
| 284 | HandleClick(button_map[button_id], | 284 | HandleClick(button_map[button_id], |
| 285 | [=](Common::ParamPackage params) { | 285 | [=, this](Common::ParamPackage params) { |
| 286 | // Workaround for ZL & ZR for analog triggers like on XBOX controllors. | 286 | // Workaround for ZL & ZR for analog triggers like on XBOX controllors. |
| 287 | // Analog triggers (from controllers like the XBOX controller) would not | 287 | // Analog triggers (from controllers like the XBOX controller) would not |
| 288 | // work due to a different range of their signals (from 0 to 255 on | 288 | // work due to a different range of their signals (from 0 to 255 on |
| @@ -300,19 +300,20 @@ ConfigureInputPlayer::ConfigureInputPlayer(QWidget* parent, std::size_t player_i | |||
| 300 | }, | 300 | }, |
| 301 | InputCommon::Polling::DeviceType::Button); | 301 | InputCommon::Polling::DeviceType::Button); |
| 302 | }); | 302 | }); |
| 303 | connect(button, &QPushButton::customContextMenuRequested, [=](const QPoint& menu_location) { | 303 | connect(button, &QPushButton::customContextMenuRequested, |
| 304 | QMenu context_menu; | 304 | [=, this](const QPoint& menu_location) { |
| 305 | context_menu.addAction(tr("Clear"), [&] { | 305 | QMenu context_menu; |
| 306 | buttons_param[button_id].Clear(); | 306 | context_menu.addAction(tr("Clear"), [&] { |
| 307 | button_map[button_id]->setText(tr("[not set]")); | 307 | buttons_param[button_id].Clear(); |
| 308 | }); | 308 | button_map[button_id]->setText(tr("[not set]")); |
| 309 | context_menu.addAction(tr("Restore Default"), [&] { | 309 | }); |
| 310 | buttons_param[button_id] = Common::ParamPackage{ | 310 | context_menu.addAction(tr("Restore Default"), [&] { |
| 311 | InputCommon::GenerateKeyboardParam(Config::default_buttons[button_id])}; | 311 | buttons_param[button_id] = Common::ParamPackage{ |
| 312 | button_map[button_id]->setText(ButtonToText(buttons_param[button_id])); | 312 | InputCommon::GenerateKeyboardParam(Config::default_buttons[button_id])}; |
| 313 | }); | 313 | button_map[button_id]->setText(ButtonToText(buttons_param[button_id])); |
| 314 | context_menu.exec(button_map[button_id]->mapToGlobal(menu_location)); | 314 | }); |
| 315 | }); | 315 | context_menu.exec(button_map[button_id]->mapToGlobal(menu_location)); |
| 316 | }); | ||
| 316 | } | 317 | } |
| 317 | 318 | ||
| 318 | for (int analog_id = 0; analog_id < Settings::NativeAnalog::NumAnalogs; analog_id++) { | 319 | for (int analog_id = 0; analog_id < Settings::NativeAnalog::NumAnalogs; analog_id++) { |
| @@ -323,16 +324,16 @@ ConfigureInputPlayer::ConfigureInputPlayer(QWidget* parent, std::size_t player_i | |||
| 323 | } | 324 | } |
| 324 | 325 | ||
| 325 | analog_button->setContextMenuPolicy(Qt::CustomContextMenu); | 326 | analog_button->setContextMenuPolicy(Qt::CustomContextMenu); |
| 326 | connect(analog_button, &QPushButton::clicked, [=]() { | 327 | connect(analog_button, &QPushButton::clicked, [=, this] { |
| 327 | HandleClick(analog_map_buttons[analog_id][sub_button_id], | 328 | HandleClick(analog_map_buttons[analog_id][sub_button_id], |
| 328 | [=](const Common::ParamPackage& params) { | 329 | [=, this](const Common::ParamPackage& params) { |
| 329 | SetAnalogButton(params, analogs_param[analog_id], | 330 | SetAnalogButton(params, analogs_param[analog_id], |
| 330 | analog_sub_buttons[sub_button_id]); | 331 | analog_sub_buttons[sub_button_id]); |
| 331 | }, | 332 | }, |
| 332 | InputCommon::Polling::DeviceType::Button); | 333 | InputCommon::Polling::DeviceType::Button); |
| 333 | }); | 334 | }); |
| 334 | connect(analog_button, &QPushButton::customContextMenuRequested, | 335 | connect(analog_button, &QPushButton::customContextMenuRequested, |
| 335 | [=](const QPoint& menu_location) { | 336 | [=, this](const QPoint& menu_location) { |
| 336 | QMenu context_menu; | 337 | QMenu context_menu; |
| 337 | context_menu.addAction(tr("Clear"), [&] { | 338 | context_menu.addAction(tr("Clear"), [&] { |
| 338 | analogs_param[analog_id].Erase(analog_sub_buttons[sub_button_id]); | 339 | analogs_param[analog_id].Erase(analog_sub_buttons[sub_button_id]); |
| @@ -350,32 +351,35 @@ ConfigureInputPlayer::ConfigureInputPlayer(QWidget* parent, std::size_t player_i | |||
| 350 | menu_location)); | 351 | menu_location)); |
| 351 | }); | 352 | }); |
| 352 | } | 353 | } |
| 353 | connect(analog_map_stick[analog_id], &QPushButton::clicked, [=] { | 354 | connect(analog_map_stick[analog_id], &QPushButton::clicked, [=, this] { |
| 354 | if (QMessageBox::information( | 355 | if (QMessageBox::information( |
| 355 | this, tr("Information"), | 356 | this, tr("Information"), |
| 356 | tr("After pressing OK, first move your joystick horizontally, " | 357 | tr("After pressing OK, first move your joystick horizontally, " |
| 357 | "and then vertically."), | 358 | "and then vertically."), |
| 358 | QMessageBox::Ok | QMessageBox::Cancel) == QMessageBox::Ok) { | 359 | QMessageBox::Ok | QMessageBox::Cancel) == QMessageBox::Ok) { |
| 359 | HandleClick( | 360 | HandleClick(analog_map_stick[analog_id], |
| 360 | analog_map_stick[analog_id], | 361 | [=, this](const Common::ParamPackage& params) { |
| 361 | [=](const Common::ParamPackage& params) { analogs_param[analog_id] = params; }, | 362 | analogs_param[analog_id] = params; |
| 362 | InputCommon::Polling::DeviceType::Analog); | 363 | }, |
| 364 | InputCommon::Polling::DeviceType::Analog); | ||
| 363 | } | 365 | } |
| 364 | }); | 366 | }); |
| 365 | 367 | ||
| 366 | connect(analog_map_deadzone_and_modifier_slider[analog_id], &QSlider::valueChanged, [=] { | 368 | connect(analog_map_deadzone_and_modifier_slider[analog_id], &QSlider::valueChanged, |
| 367 | const float slider_value = analog_map_deadzone_and_modifier_slider[analog_id]->value(); | 369 | [=, this] { |
| 368 | if (analogs_param[analog_id].Get("engine", "") == "sdl" || | 370 | const float slider_value = |
| 369 | analogs_param[analog_id].Get("engine", "") == "gcpad") { | 371 | analog_map_deadzone_and_modifier_slider[analog_id]->value(); |
| 370 | analog_map_deadzone_and_modifier_slider_label[analog_id]->setText( | 372 | if (analogs_param[analog_id].Get("engine", "") == "sdl" || |
| 371 | tr("Deadzone: %1%").arg(slider_value)); | 373 | analogs_param[analog_id].Get("engine", "") == "gcpad") { |
| 372 | analogs_param[analog_id].Set("deadzone", slider_value / 100.0f); | 374 | analog_map_deadzone_and_modifier_slider_label[analog_id]->setText( |
| 373 | } else { | 375 | tr("Deadzone: %1%").arg(slider_value)); |
| 374 | analog_map_deadzone_and_modifier_slider_label[analog_id]->setText( | 376 | analogs_param[analog_id].Set("deadzone", slider_value / 100.0f); |
| 375 | tr("Modifier Scale: %1%").arg(slider_value)); | 377 | } else { |
| 376 | analogs_param[analog_id].Set("modifier_scale", slider_value / 100.0f); | 378 | analog_map_deadzone_and_modifier_slider_label[analog_id]->setText( |
| 377 | } | 379 | tr("Modifier Scale: %1%").arg(slider_value)); |
| 378 | }); | 380 | analogs_param[analog_id].Set("modifier_scale", slider_value / 100.0f); |
| 381 | } | ||
| 382 | }); | ||
| 379 | } | 383 | } |
| 380 | 384 | ||
| 381 | connect(ui->buttonClearAll, &QPushButton::clicked, [this] { ClearAll(); }); | 385 | connect(ui->buttonClearAll, &QPushButton::clicked, [this] { ClearAll(); }); |
diff --git a/src/yuzu/configuration/configure_mouse_advanced.cpp b/src/yuzu/configuration/configure_mouse_advanced.cpp index e0647ea5b..ea2549363 100644 --- a/src/yuzu/configuration/configure_mouse_advanced.cpp +++ b/src/yuzu/configuration/configure_mouse_advanced.cpp | |||
| @@ -83,25 +83,28 @@ ConfigureMouseAdvanced::ConfigureMouseAdvanced(QWidget* parent) | |||
| 83 | } | 83 | } |
| 84 | 84 | ||
| 85 | button->setContextMenuPolicy(Qt::CustomContextMenu); | 85 | button->setContextMenuPolicy(Qt::CustomContextMenu); |
| 86 | connect(button, &QPushButton::clicked, [=] { | 86 | connect(button, &QPushButton::clicked, [=, this] { |
| 87 | HandleClick( | 87 | HandleClick(button_map[button_id], |
| 88 | button_map[button_id], | 88 | [=, this](const Common::ParamPackage& params) { |
| 89 | [=](const Common::ParamPackage& params) { buttons_param[button_id] = params; }, | 89 | buttons_param[button_id] = params; |
| 90 | InputCommon::Polling::DeviceType::Button); | 90 | }, |
| 91 | }); | 91 | InputCommon::Polling::DeviceType::Button); |
| 92 | connect(button, &QPushButton::customContextMenuRequested, [=](const QPoint& menu_location) { | ||
| 93 | QMenu context_menu; | ||
| 94 | context_menu.addAction(tr("Clear"), [&] { | ||
| 95 | buttons_param[button_id].Clear(); | ||
| 96 | button_map[button_id]->setText(tr("[not set]")); | ||
| 97 | }); | ||
| 98 | context_menu.addAction(tr("Restore Default"), [&] { | ||
| 99 | buttons_param[button_id] = Common::ParamPackage{ | ||
| 100 | InputCommon::GenerateKeyboardParam(Config::default_mouse_buttons[button_id])}; | ||
| 101 | button_map[button_id]->setText(ButtonToText(buttons_param[button_id])); | ||
| 102 | }); | ||
| 103 | context_menu.exec(button_map[button_id]->mapToGlobal(menu_location)); | ||
| 104 | }); | 92 | }); |
| 93 | connect(button, &QPushButton::customContextMenuRequested, | ||
| 94 | [=, this](const QPoint& menu_location) { | ||
| 95 | QMenu context_menu; | ||
| 96 | context_menu.addAction(tr("Clear"), [&] { | ||
| 97 | buttons_param[button_id].Clear(); | ||
| 98 | button_map[button_id]->setText(tr("[not set]")); | ||
| 99 | }); | ||
| 100 | context_menu.addAction(tr("Restore Default"), [&] { | ||
| 101 | buttons_param[button_id] = | ||
| 102 | Common::ParamPackage{InputCommon::GenerateKeyboardParam( | ||
| 103 | Config::default_mouse_buttons[button_id])}; | ||
| 104 | button_map[button_id]->setText(ButtonToText(buttons_param[button_id])); | ||
| 105 | }); | ||
| 106 | context_menu.exec(button_map[button_id]->mapToGlobal(menu_location)); | ||
| 107 | }); | ||
| 105 | } | 108 | } |
| 106 | 109 | ||
| 107 | connect(ui->buttonClearAll, &QPushButton::clicked, [this] { ClearAll(); }); | 110 | connect(ui->buttonClearAll, &QPushButton::clicked, [this] { ClearAll(); }); |
diff --git a/src/yuzu/configuration/configure_ui.cpp b/src/yuzu/configuration/configure_ui.cpp index 24b6c5b72..2c20b68d0 100644 --- a/src/yuzu/configuration/configure_ui.cpp +++ b/src/yuzu/configuration/configure_ui.cpp | |||
| @@ -4,9 +4,11 @@ | |||
| 4 | 4 | ||
| 5 | #include <array> | 5 | #include <array> |
| 6 | #include <utility> | 6 | #include <utility> |
| 7 | #include <QFileDialog> | ||
| 7 | 8 | ||
| 8 | #include <QDirIterator> | 9 | #include <QDirIterator> |
| 9 | #include "common/common_types.h" | 10 | #include "common/common_types.h" |
| 11 | #include "common/file_util.h" | ||
| 10 | #include "core/settings.h" | 12 | #include "core/settings.h" |
| 11 | #include "ui_configure_ui.h" | 13 | #include "ui_configure_ui.h" |
| 12 | #include "yuzu/configuration/configure_ui.h" | 14 | #include "yuzu/configuration/configure_ui.h" |
| @@ -52,9 +54,21 @@ ConfigureUi::ConfigureUi(QWidget* parent) : QWidget(parent), ui(new Ui::Configur | |||
| 52 | 54 | ||
| 53 | // Update text ComboBoxes after user interaction. | 55 | // Update text ComboBoxes after user interaction. |
| 54 | connect(ui->row_1_text_combobox, QOverload<int>::of(&QComboBox::activated), | 56 | connect(ui->row_1_text_combobox, QOverload<int>::of(&QComboBox::activated), |
| 55 | [=]() { ConfigureUi::UpdateSecondRowComboBox(); }); | 57 | [this] { ConfigureUi::UpdateSecondRowComboBox(); }); |
| 56 | connect(ui->row_2_text_combobox, QOverload<int>::of(&QComboBox::activated), | 58 | connect(ui->row_2_text_combobox, QOverload<int>::of(&QComboBox::activated), |
| 57 | [=]() { ConfigureUi::UpdateFirstRowComboBox(); }); | 59 | [this] { ConfigureUi::UpdateFirstRowComboBox(); }); |
| 60 | |||
| 61 | // Set screenshot path to user specification. | ||
| 62 | connect(ui->screenshot_path_button, &QToolButton::pressed, this, [this] { | ||
| 63 | const QString& filename = | ||
| 64 | QFileDialog::getExistingDirectory( | ||
| 65 | this, tr("Select Screenshots Path..."), | ||
| 66 | QString::fromStdString(FileUtil::GetUserPath(FileUtil::UserPath::ScreenshotsDir))) + | ||
| 67 | QDir::separator(); | ||
| 68 | if (!filename.isEmpty()) { | ||
| 69 | ui->screenshot_path_edit->setText(filename); | ||
| 70 | } | ||
| 71 | }); | ||
| 58 | } | 72 | } |
| 59 | 73 | ||
| 60 | ConfigureUi::~ConfigureUi() = default; | 74 | ConfigureUi::~ConfigureUi() = default; |
| @@ -66,6 +80,10 @@ void ConfigureUi::ApplyConfiguration() { | |||
| 66 | UISettings::values.icon_size = ui->icon_size_combobox->currentData().toUInt(); | 80 | UISettings::values.icon_size = ui->icon_size_combobox->currentData().toUInt(); |
| 67 | UISettings::values.row_1_text_id = ui->row_1_text_combobox->currentData().toUInt(); | 81 | UISettings::values.row_1_text_id = ui->row_1_text_combobox->currentData().toUInt(); |
| 68 | UISettings::values.row_2_text_id = ui->row_2_text_combobox->currentData().toUInt(); | 82 | UISettings::values.row_2_text_id = ui->row_2_text_combobox->currentData().toUInt(); |
| 83 | |||
| 84 | UISettings::values.enable_screenshot_save_as = ui->enable_screenshot_save_as->isChecked(); | ||
| 85 | FileUtil::GetUserPath(FileUtil::UserPath::ScreenshotsDir, | ||
| 86 | ui->screenshot_path_edit->text().toStdString()); | ||
| 69 | Settings::Apply(); | 87 | Settings::Apply(); |
| 70 | } | 88 | } |
| 71 | 89 | ||
| @@ -80,6 +98,10 @@ void ConfigureUi::SetConfiguration() { | |||
| 80 | ui->show_add_ons->setChecked(UISettings::values.show_add_ons); | 98 | ui->show_add_ons->setChecked(UISettings::values.show_add_ons); |
| 81 | ui->icon_size_combobox->setCurrentIndex( | 99 | ui->icon_size_combobox->setCurrentIndex( |
| 82 | ui->icon_size_combobox->findData(UISettings::values.icon_size)); | 100 | ui->icon_size_combobox->findData(UISettings::values.icon_size)); |
| 101 | |||
| 102 | ui->enable_screenshot_save_as->setChecked(UISettings::values.enable_screenshot_save_as); | ||
| 103 | ui->screenshot_path_edit->setText( | ||
| 104 | QString::fromStdString(FileUtil::GetUserPath(FileUtil::UserPath::ScreenshotsDir))); | ||
| 83 | } | 105 | } |
| 84 | 106 | ||
| 85 | void ConfigureUi::changeEvent(QEvent* event) { | 107 | void ConfigureUi::changeEvent(QEvent* event) { |
diff --git a/src/yuzu/configuration/configure_ui.ui b/src/yuzu/configuration/configure_ui.ui index 0b81747d7..d895b799f 100644 --- a/src/yuzu/configuration/configure_ui.ui +++ b/src/yuzu/configuration/configure_ui.ui | |||
| @@ -6,8 +6,8 @@ | |||
| 6 | <rect> | 6 | <rect> |
| 7 | <x>0</x> | 7 | <x>0</x> |
| 8 | <y>0</y> | 8 | <y>0</y> |
| 9 | <width>300</width> | 9 | <width>363</width> |
| 10 | <height>377</height> | 10 | <height>391</height> |
| 11 | </rect> | 11 | </rect> |
| 12 | </property> | 12 | </property> |
| 13 | <property name="windowTitle"> | 13 | <property name="windowTitle"> |
| @@ -128,6 +128,47 @@ | |||
| 128 | </widget> | 128 | </widget> |
| 129 | </item> | 129 | </item> |
| 130 | <item> | 130 | <item> |
| 131 | <widget class="QGroupBox" name="screenshots_GroupBox"> | ||
| 132 | <property name="title"> | ||
| 133 | <string>Screenshots</string> | ||
| 134 | </property> | ||
| 135 | <layout class="QVBoxLayout" name="verticalLayout_4"> | ||
| 136 | <item> | ||
| 137 | <layout class="QVBoxLayout" name="verticalLayout_3"> | ||
| 138 | <item> | ||
| 139 | <widget class="QCheckBox" name="enable_screenshot_save_as"> | ||
| 140 | <property name="text"> | ||
| 141 | <string>Ask Where To Save Screenshots (Windows Only)</string> | ||
| 142 | </property> | ||
| 143 | </widget> | ||
| 144 | </item> | ||
| 145 | <item> | ||
| 146 | <layout class="QHBoxLayout" name="horizontalLayout_4"> | ||
| 147 | <item> | ||
| 148 | <widget class="QLabel" name="label"> | ||
| 149 | <property name="text"> | ||
| 150 | <string>Screenshots Path: </string> | ||
| 151 | </property> | ||
| 152 | </widget> | ||
| 153 | </item> | ||
| 154 | <item> | ||
| 155 | <widget class="QLineEdit" name="screenshot_path_edit"/> | ||
| 156 | </item> | ||
| 157 | <item> | ||
| 158 | <widget class="QToolButton" name="screenshot_path_button"> | ||
| 159 | <property name="text"> | ||
| 160 | <string>...</string> | ||
| 161 | </property> | ||
| 162 | </widget> | ||
| 163 | </item> | ||
| 164 | </layout> | ||
| 165 | </item> | ||
| 166 | </layout> | ||
| 167 | </item> | ||
| 168 | </layout> | ||
| 169 | </widget> | ||
| 170 | </item> | ||
| 171 | <item> | ||
| 131 | <spacer name="verticalSpacer"> | 172 | <spacer name="verticalSpacer"> |
| 132 | <property name="orientation"> | 173 | <property name="orientation"> |
| 133 | <enum>Qt::Vertical</enum> | 174 | <enum>Qt::Vertical</enum> |
diff --git a/src/yuzu/game_list.cpp b/src/yuzu/game_list.cpp index ab7fc7a24..62acc3720 100644 --- a/src/yuzu/game_list.cpp +++ b/src/yuzu/game_list.cpp | |||
| @@ -474,28 +474,56 @@ void GameList::PopupContextMenu(const QPoint& menu_location) { | |||
| 474 | 474 | ||
| 475 | void GameList::AddGamePopup(QMenu& context_menu, u64 program_id, std::string path) { | 475 | void GameList::AddGamePopup(QMenu& context_menu, u64 program_id, std::string path) { |
| 476 | QAction* open_save_location = context_menu.addAction(tr("Open Save Data Location")); | 476 | QAction* open_save_location = context_menu.addAction(tr("Open Save Data Location")); |
| 477 | QAction* open_lfs_location = context_menu.addAction(tr("Open Mod Data Location")); | 477 | QAction* open_mod_location = context_menu.addAction(tr("Open Mod Data Location")); |
| 478 | QAction* open_transferable_shader_cache = | 478 | QAction* open_transferable_shader_cache = |
| 479 | context_menu.addAction(tr("Open Transferable Shader Cache")); | 479 | context_menu.addAction(tr("Open Transferable Shader Cache")); |
| 480 | context_menu.addSeparator(); | 480 | context_menu.addSeparator(); |
| 481 | QMenu* remove_menu = context_menu.addMenu(tr("Remove")); | ||
| 482 | QAction* remove_update = remove_menu->addAction(tr("Remove Installed Update")); | ||
| 483 | QAction* remove_dlc = remove_menu->addAction(tr("Remove All Installed DLC")); | ||
| 484 | QAction* remove_shader_cache = remove_menu->addAction(tr("Remove Shader Cache")); | ||
| 485 | QAction* remove_custom_config = remove_menu->addAction(tr("Remove Custom Configuration")); | ||
| 486 | remove_menu->addSeparator(); | ||
| 487 | QAction* remove_all_content = remove_menu->addAction(tr("Remove All Installed Contents")); | ||
| 481 | QAction* dump_romfs = context_menu.addAction(tr("Dump RomFS")); | 488 | QAction* dump_romfs = context_menu.addAction(tr("Dump RomFS")); |
| 482 | QAction* copy_tid = context_menu.addAction(tr("Copy Title ID to Clipboard")); | 489 | QAction* copy_tid = context_menu.addAction(tr("Copy Title ID to Clipboard")); |
| 483 | QAction* navigate_to_gamedb_entry = context_menu.addAction(tr("Navigate to GameDB entry")); | 490 | QAction* navigate_to_gamedb_entry = context_menu.addAction(tr("Navigate to GameDB entry")); |
| 484 | context_menu.addSeparator(); | 491 | context_menu.addSeparator(); |
| 485 | QAction* properties = context_menu.addAction(tr("Properties")); | 492 | QAction* properties = context_menu.addAction(tr("Properties")); |
| 486 | 493 | ||
| 487 | open_save_location->setEnabled(program_id != 0); | 494 | open_save_location->setVisible(program_id != 0); |
| 495 | open_mod_location->setVisible(program_id != 0); | ||
| 496 | open_transferable_shader_cache->setVisible(program_id != 0); | ||
| 497 | remove_update->setVisible(program_id != 0); | ||
| 498 | remove_dlc->setVisible(program_id != 0); | ||
| 499 | remove_shader_cache->setVisible(program_id != 0); | ||
| 500 | remove_all_content->setVisible(program_id != 0); | ||
| 488 | auto it = FindMatchingCompatibilityEntry(compatibility_list, program_id); | 501 | auto it = FindMatchingCompatibilityEntry(compatibility_list, program_id); |
| 489 | navigate_to_gamedb_entry->setVisible(it != compatibility_list.end() && program_id != 0); | 502 | navigate_to_gamedb_entry->setVisible(it != compatibility_list.end() && program_id != 0); |
| 490 | 503 | ||
| 491 | connect(open_save_location, &QAction::triggered, [this, program_id, path]() { | 504 | connect(open_save_location, &QAction::triggered, [this, program_id, path]() { |
| 492 | emit OpenFolderRequested(GameListOpenTarget::SaveData, path); | 505 | emit OpenFolderRequested(GameListOpenTarget::SaveData, path); |
| 493 | }); | 506 | }); |
| 494 | connect(open_lfs_location, &QAction::triggered, [this, program_id, path]() { | 507 | connect(open_mod_location, &QAction::triggered, [this, program_id, path]() { |
| 495 | emit OpenFolderRequested(GameListOpenTarget::ModData, path); | 508 | emit OpenFolderRequested(GameListOpenTarget::ModData, path); |
| 496 | }); | 509 | }); |
| 497 | connect(open_transferable_shader_cache, &QAction::triggered, | 510 | connect(open_transferable_shader_cache, &QAction::triggered, |
| 498 | [this, program_id]() { emit OpenTransferableShaderCacheRequested(program_id); }); | 511 | [this, program_id]() { emit OpenTransferableShaderCacheRequested(program_id); }); |
| 512 | connect(remove_all_content, &QAction::triggered, [this, program_id]() { | ||
| 513 | emit RemoveInstalledEntryRequested(program_id, InstalledEntryType::Game); | ||
| 514 | }); | ||
| 515 | connect(remove_update, &QAction::triggered, [this, program_id]() { | ||
| 516 | emit RemoveInstalledEntryRequested(program_id, InstalledEntryType::Update); | ||
| 517 | }); | ||
| 518 | connect(remove_dlc, &QAction::triggered, [this, program_id]() { | ||
| 519 | emit RemoveInstalledEntryRequested(program_id, InstalledEntryType::AddOnContent); | ||
| 520 | }); | ||
| 521 | connect(remove_shader_cache, &QAction::triggered, [this, program_id]() { | ||
| 522 | emit RemoveFileRequested(program_id, GameListRemoveTarget::ShaderCache); | ||
| 523 | }); | ||
| 524 | connect(remove_custom_config, &QAction::triggered, [this, program_id]() { | ||
| 525 | emit RemoveFileRequested(program_id, GameListRemoveTarget::CustomConfiguration); | ||
| 526 | }); | ||
| 499 | connect(dump_romfs, &QAction::triggered, | 527 | connect(dump_romfs, &QAction::triggered, |
| 500 | [this, program_id, path]() { emit DumpRomFSRequested(program_id, path); }); | 528 | [this, program_id, path]() { emit DumpRomFSRequested(program_id, path); }); |
| 501 | connect(copy_tid, &QAction::triggered, | 529 | connect(copy_tid, &QAction::triggered, |
diff --git a/src/yuzu/game_list.h b/src/yuzu/game_list.h index a38cb2fc3..483835cce 100644 --- a/src/yuzu/game_list.h +++ b/src/yuzu/game_list.h | |||
| @@ -39,6 +39,17 @@ enum class GameListOpenTarget { | |||
| 39 | ModData, | 39 | ModData, |
| 40 | }; | 40 | }; |
| 41 | 41 | ||
| 42 | enum class GameListRemoveTarget { | ||
| 43 | ShaderCache, | ||
| 44 | CustomConfiguration, | ||
| 45 | }; | ||
| 46 | |||
| 47 | enum class InstalledEntryType { | ||
| 48 | Game, | ||
| 49 | Update, | ||
| 50 | AddOnContent, | ||
| 51 | }; | ||
| 52 | |||
| 42 | class GameList : public QWidget { | 53 | class GameList : public QWidget { |
| 43 | Q_OBJECT | 54 | Q_OBJECT |
| 44 | 55 | ||
| @@ -75,6 +86,8 @@ signals: | |||
| 75 | void ShouldCancelWorker(); | 86 | void ShouldCancelWorker(); |
| 76 | void OpenFolderRequested(GameListOpenTarget target, const std::string& game_path); | 87 | void OpenFolderRequested(GameListOpenTarget target, const std::string& game_path); |
| 77 | void OpenTransferableShaderCacheRequested(u64 program_id); | 88 | void OpenTransferableShaderCacheRequested(u64 program_id); |
| 89 | void RemoveInstalledEntryRequested(u64 program_id, InstalledEntryType type); | ||
| 90 | void RemoveFileRequested(u64 program_id, GameListRemoveTarget target); | ||
| 78 | void DumpRomFSRequested(u64 program_id, const std::string& game_path); | 91 | void DumpRomFSRequested(u64 program_id, const std::string& game_path); |
| 79 | void CopyTIDRequested(u64 program_id); | 92 | void CopyTIDRequested(u64 program_id); |
| 80 | void NavigateToGamedbEntryRequested(u64 program_id, | 93 | void NavigateToGamedbEntryRequested(u64 program_id, |
| @@ -117,8 +130,6 @@ private: | |||
| 117 | friend class GameListSearchField; | 130 | friend class GameListSearchField; |
| 118 | }; | 131 | }; |
| 119 | 132 | ||
| 120 | Q_DECLARE_METATYPE(GameListOpenTarget); | ||
| 121 | |||
| 122 | class GameListPlaceholder : public QWidget { | 133 | class GameListPlaceholder : public QWidget { |
| 123 | Q_OBJECT | 134 | Q_OBJECT |
| 124 | public: | 135 | public: |
diff --git a/src/yuzu/game_list_worker.cpp b/src/yuzu/game_list_worker.cpp index 2018150db..239016b94 100644 --- a/src/yuzu/game_list_worker.cpp +++ b/src/yuzu/game_list_worker.cpp | |||
| @@ -369,8 +369,8 @@ void GameListWorker::run() { | |||
| 369 | auto* const game_list_dir = new GameListDir(game_dir); | 369 | auto* const game_list_dir = new GameListDir(game_dir); |
| 370 | emit DirEntryReady(game_list_dir); | 370 | emit DirEntryReady(game_list_dir); |
| 371 | provider->ClearAllEntries(); | 371 | provider->ClearAllEntries(); |
| 372 | ScanFileSystem(ScanTarget::FillManualContentProvider, game_dir.path.toStdString(), 2, | 372 | ScanFileSystem(ScanTarget::FillManualContentProvider, game_dir.path.toStdString(), |
| 373 | game_list_dir); | 373 | game_dir.deep_scan ? 256 : 0, game_list_dir); |
| 374 | ScanFileSystem(ScanTarget::PopulateGameList, game_dir.path.toStdString(), | 374 | ScanFileSystem(ScanTarget::PopulateGameList, game_dir.path.toStdString(), |
| 375 | game_dir.deep_scan ? 256 : 0, game_list_dir); | 375 | game_dir.deep_scan ? 256 : 0, game_list_dir); |
| 376 | } | 376 | } |
diff --git a/src/yuzu/main.cpp b/src/yuzu/main.cpp index 31a635176..592993c36 100644 --- a/src/yuzu/main.cpp +++ b/src/yuzu/main.cpp | |||
| @@ -583,7 +583,7 @@ void GMainWindow::InitializeWidgets() { | |||
| 583 | renderer_status_button->setObjectName(QStringLiteral("RendererStatusBarButton")); | 583 | renderer_status_button->setObjectName(QStringLiteral("RendererStatusBarButton")); |
| 584 | renderer_status_button->setCheckable(true); | 584 | renderer_status_button->setCheckable(true); |
| 585 | renderer_status_button->setFocusPolicy(Qt::NoFocus); | 585 | renderer_status_button->setFocusPolicy(Qt::NoFocus); |
| 586 | connect(renderer_status_button, &QPushButton::toggled, [=](bool checked) { | 586 | connect(renderer_status_button, &QPushButton::toggled, [this](bool checked) { |
| 587 | renderer_status_button->setText(checked ? tr("VULKAN") : tr("OPENGL")); | 587 | renderer_status_button->setText(checked ? tr("VULKAN") : tr("OPENGL")); |
| 588 | }); | 588 | }); |
| 589 | renderer_status_button->toggle(); | 589 | renderer_status_button->toggle(); |
| @@ -595,7 +595,7 @@ void GMainWindow::InitializeWidgets() { | |||
| 595 | #else | 595 | #else |
| 596 | renderer_status_button->setChecked(Settings::values.renderer_backend.GetValue() == | 596 | renderer_status_button->setChecked(Settings::values.renderer_backend.GetValue() == |
| 597 | Settings::RendererBackend::Vulkan); | 597 | Settings::RendererBackend::Vulkan); |
| 598 | connect(renderer_status_button, &QPushButton::clicked, [=] { | 598 | connect(renderer_status_button, &QPushButton::clicked, [this] { |
| 599 | if (emulation_running) { | 599 | if (emulation_running) { |
| 600 | return; | 600 | return; |
| 601 | } | 601 | } |
| @@ -847,6 +847,9 @@ void GMainWindow::ConnectWidgetEvents() { | |||
| 847 | connect(game_list, &GameList::OpenFolderRequested, this, &GMainWindow::OnGameListOpenFolder); | 847 | connect(game_list, &GameList::OpenFolderRequested, this, &GMainWindow::OnGameListOpenFolder); |
| 848 | connect(game_list, &GameList::OpenTransferableShaderCacheRequested, this, | 848 | connect(game_list, &GameList::OpenTransferableShaderCacheRequested, this, |
| 849 | &GMainWindow::OnTransferableShaderCacheOpenFile); | 849 | &GMainWindow::OnTransferableShaderCacheOpenFile); |
| 850 | connect(game_list, &GameList::RemoveInstalledEntryRequested, this, | ||
| 851 | &GMainWindow::OnGameListRemoveInstalledEntry); | ||
| 852 | connect(game_list, &GameList::RemoveFileRequested, this, &GMainWindow::OnGameListRemoveFile); | ||
| 850 | connect(game_list, &GameList::DumpRomFSRequested, this, &GMainWindow::OnGameListDumpRomFS); | 853 | connect(game_list, &GameList::DumpRomFSRequested, this, &GMainWindow::OnGameListDumpRomFS); |
| 851 | connect(game_list, &GameList::CopyTIDRequested, this, &GMainWindow::OnGameListCopyTID); | 854 | connect(game_list, &GameList::CopyTIDRequested, this, &GMainWindow::OnGameListCopyTID); |
| 852 | connect(game_list, &GameList::NavigateToGamedbEntryRequested, this, | 855 | connect(game_list, &GameList::NavigateToGamedbEntryRequested, this, |
| @@ -1257,7 +1260,6 @@ void GMainWindow::OnGameListOpenFolder(GameListOpenTarget target, const std::str | |||
| 1257 | case GameListOpenTarget::SaveData: { | 1260 | case GameListOpenTarget::SaveData: { |
| 1258 | open_target = tr("Save Data"); | 1261 | open_target = tr("Save Data"); |
| 1259 | const std::string nand_dir = FileUtil::GetUserPath(FileUtil::UserPath::NANDDir); | 1262 | const std::string nand_dir = FileUtil::GetUserPath(FileUtil::UserPath::NANDDir); |
| 1260 | ASSERT(program_id != 0); | ||
| 1261 | 1263 | ||
| 1262 | if (has_user_save) { | 1264 | if (has_user_save) { |
| 1263 | // User save data | 1265 | // User save data |
| @@ -1322,14 +1324,12 @@ void GMainWindow::OnGameListOpenFolder(GameListOpenTarget target, const std::str | |||
| 1322 | } | 1324 | } |
| 1323 | 1325 | ||
| 1324 | void GMainWindow::OnTransferableShaderCacheOpenFile(u64 program_id) { | 1326 | void GMainWindow::OnTransferableShaderCacheOpenFile(u64 program_id) { |
| 1325 | ASSERT(program_id != 0); | ||
| 1326 | |||
| 1327 | const QString shader_dir = | 1327 | const QString shader_dir = |
| 1328 | QString::fromStdString(FileUtil::GetUserPath(FileUtil::UserPath::ShaderDir)); | 1328 | QString::fromStdString(FileUtil::GetUserPath(FileUtil::UserPath::ShaderDir)); |
| 1329 | const QString tranferable_shader_cache_folder_path = | 1329 | const QString transferable_shader_cache_folder_path = |
| 1330 | shader_dir + QStringLiteral("opengl") + QDir::separator() + QStringLiteral("transferable"); | 1330 | shader_dir + QStringLiteral("opengl") + QDir::separator() + QStringLiteral("transferable"); |
| 1331 | const QString transferable_shader_cache_file_path = | 1331 | const QString transferable_shader_cache_file_path = |
| 1332 | tranferable_shader_cache_folder_path + QDir::separator() + | 1332 | transferable_shader_cache_folder_path + QDir::separator() + |
| 1333 | QString::fromStdString(fmt::format("{:016X}.bin", program_id)); | 1333 | QString::fromStdString(fmt::format("{:016X}.bin", program_id)); |
| 1334 | 1334 | ||
| 1335 | if (!QFile::exists(transferable_shader_cache_file_path)) { | 1335 | if (!QFile::exists(transferable_shader_cache_file_path)) { |
| @@ -1350,7 +1350,7 @@ void GMainWindow::OnTransferableShaderCacheOpenFile(u64 program_id) { | |||
| 1350 | param << QDir::toNativeSeparators(transferable_shader_cache_file_path); | 1350 | param << QDir::toNativeSeparators(transferable_shader_cache_file_path); |
| 1351 | QProcess::startDetached(explorer, param); | 1351 | QProcess::startDetached(explorer, param); |
| 1352 | #else | 1352 | #else |
| 1353 | QDesktopServices::openUrl(QUrl::fromLocalFile(tranferable_shader_cache_folder_path)); | 1353 | QDesktopServices::openUrl(QUrl::fromLocalFile(transferable_shader_cache_folder_path)); |
| 1354 | #endif | 1354 | #endif |
| 1355 | } | 1355 | } |
| 1356 | 1356 | ||
| @@ -1394,6 +1394,174 @@ static bool RomFSRawCopy(QProgressDialog& dialog, const FileSys::VirtualDir& src | |||
| 1394 | return true; | 1394 | return true; |
| 1395 | } | 1395 | } |
| 1396 | 1396 | ||
| 1397 | void GMainWindow::OnGameListRemoveInstalledEntry(u64 program_id, InstalledEntryType type) { | ||
| 1398 | const QString entry_type = [this, type] { | ||
| 1399 | switch (type) { | ||
| 1400 | case InstalledEntryType::Game: | ||
| 1401 | return tr("Contents"); | ||
| 1402 | case InstalledEntryType::Update: | ||
| 1403 | return tr("Update"); | ||
| 1404 | case InstalledEntryType::AddOnContent: | ||
| 1405 | return tr("DLC"); | ||
| 1406 | default: | ||
| 1407 | return QString{}; | ||
| 1408 | } | ||
| 1409 | }(); | ||
| 1410 | |||
| 1411 | if (QMessageBox::question( | ||
| 1412 | this, tr("Remove Entry"), tr("Remove Installed Game %1?").arg(entry_type), | ||
| 1413 | QMessageBox::Yes | QMessageBox::No, QMessageBox::No) != QMessageBox::Yes) { | ||
| 1414 | return; | ||
| 1415 | } | ||
| 1416 | |||
| 1417 | switch (type) { | ||
| 1418 | case InstalledEntryType::Game: | ||
| 1419 | RemoveBaseContent(program_id, entry_type); | ||
| 1420 | [[fallthrough]]; | ||
| 1421 | case InstalledEntryType::Update: | ||
| 1422 | RemoveUpdateContent(program_id, entry_type); | ||
| 1423 | if (type != InstalledEntryType::Game) { | ||
| 1424 | break; | ||
| 1425 | } | ||
| 1426 | [[fallthrough]]; | ||
| 1427 | case InstalledEntryType::AddOnContent: | ||
| 1428 | RemoveAddOnContent(program_id, entry_type); | ||
| 1429 | break; | ||
| 1430 | } | ||
| 1431 | FileUtil::DeleteDirRecursively(FileUtil::GetUserPath(FileUtil::UserPath::CacheDir) + DIR_SEP + | ||
| 1432 | "game_list"); | ||
| 1433 | game_list->PopulateAsync(UISettings::values.game_dirs); | ||
| 1434 | } | ||
| 1435 | |||
| 1436 | void GMainWindow::RemoveBaseContent(u64 program_id, const QString& entry_type) { | ||
| 1437 | const auto& fs_controller = Core::System::GetInstance().GetFileSystemController(); | ||
| 1438 | const auto res = fs_controller.GetUserNANDContents()->RemoveExistingEntry(program_id) || | ||
| 1439 | fs_controller.GetSDMCContents()->RemoveExistingEntry(program_id); | ||
| 1440 | |||
| 1441 | if (res) { | ||
| 1442 | QMessageBox::information(this, tr("Successfully Removed"), | ||
| 1443 | tr("Successfully removed the installed base game.")); | ||
| 1444 | } else { | ||
| 1445 | QMessageBox::warning( | ||
| 1446 | this, tr("Error Removing %1").arg(entry_type), | ||
| 1447 | tr("The base game is not installed in the NAND and cannot be removed.")); | ||
| 1448 | } | ||
| 1449 | } | ||
| 1450 | |||
| 1451 | void GMainWindow::RemoveUpdateContent(u64 program_id, const QString& entry_type) { | ||
| 1452 | const auto update_id = program_id | 0x800; | ||
| 1453 | const auto& fs_controller = Core::System::GetInstance().GetFileSystemController(); | ||
| 1454 | const auto res = fs_controller.GetUserNANDContents()->RemoveExistingEntry(update_id) || | ||
| 1455 | fs_controller.GetSDMCContents()->RemoveExistingEntry(update_id); | ||
| 1456 | |||
| 1457 | if (res) { | ||
| 1458 | QMessageBox::information(this, tr("Successfully Removed"), | ||
| 1459 | tr("Successfully removed the installed update.")); | ||
| 1460 | } else { | ||
| 1461 | QMessageBox::warning(this, tr("Error Removing %1").arg(entry_type), | ||
| 1462 | tr("There is no update installed for this title.")); | ||
| 1463 | } | ||
| 1464 | } | ||
| 1465 | |||
| 1466 | void GMainWindow::RemoveAddOnContent(u64 program_id, const QString& entry_type) { | ||
| 1467 | u32 count{}; | ||
| 1468 | const auto& fs_controller = Core::System::GetInstance().GetFileSystemController(); | ||
| 1469 | const auto dlc_entries = Core::System::GetInstance().GetContentProvider().ListEntriesFilter( | ||
| 1470 | FileSys::TitleType::AOC, FileSys::ContentRecordType::Data); | ||
| 1471 | |||
| 1472 | for (const auto& entry : dlc_entries) { | ||
| 1473 | if ((entry.title_id & DLC_BASE_TITLE_ID_MASK) == program_id) { | ||
| 1474 | const auto res = | ||
| 1475 | fs_controller.GetUserNANDContents()->RemoveExistingEntry(entry.title_id) || | ||
| 1476 | fs_controller.GetSDMCContents()->RemoveExistingEntry(entry.title_id); | ||
| 1477 | if (res) { | ||
| 1478 | ++count; | ||
| 1479 | } | ||
| 1480 | } | ||
| 1481 | } | ||
| 1482 | |||
| 1483 | if (count == 0) { | ||
| 1484 | QMessageBox::warning(this, tr("Error Removing %1").arg(entry_type), | ||
| 1485 | tr("There are no DLC installed for this title.")); | ||
| 1486 | return; | ||
| 1487 | } | ||
| 1488 | |||
| 1489 | QMessageBox::information(this, tr("Successfully Removed"), | ||
| 1490 | tr("Successfully removed %1 installed DLC.").arg(count)); | ||
| 1491 | } | ||
| 1492 | |||
| 1493 | void GMainWindow::OnGameListRemoveFile(u64 program_id, GameListRemoveTarget target) { | ||
| 1494 | const QString question = [this, target] { | ||
| 1495 | switch (target) { | ||
| 1496 | case GameListRemoveTarget::ShaderCache: | ||
| 1497 | return tr("Delete Transferable Shader Cache?"); | ||
| 1498 | case GameListRemoveTarget::CustomConfiguration: | ||
| 1499 | return tr("Remove Custom Game Configuration?"); | ||
| 1500 | default: | ||
| 1501 | return QString{}; | ||
| 1502 | } | ||
| 1503 | }(); | ||
| 1504 | |||
| 1505 | if (QMessageBox::question(this, tr("Remove File"), question, QMessageBox::Yes | QMessageBox::No, | ||
| 1506 | QMessageBox::No) != QMessageBox::Yes) { | ||
| 1507 | return; | ||
| 1508 | } | ||
| 1509 | |||
| 1510 | switch (target) { | ||
| 1511 | case GameListRemoveTarget::ShaderCache: | ||
| 1512 | RemoveTransferableShaderCache(program_id); | ||
| 1513 | break; | ||
| 1514 | case GameListRemoveTarget::CustomConfiguration: | ||
| 1515 | RemoveCustomConfiguration(program_id); | ||
| 1516 | break; | ||
| 1517 | } | ||
| 1518 | } | ||
| 1519 | |||
| 1520 | void GMainWindow::RemoveTransferableShaderCache(u64 program_id) { | ||
| 1521 | const QString shader_dir = | ||
| 1522 | QString::fromStdString(FileUtil::GetUserPath(FileUtil::UserPath::ShaderDir)); | ||
| 1523 | const QString transferable_shader_cache_folder_path = | ||
| 1524 | shader_dir + QStringLiteral("opengl") + QDir::separator() + QStringLiteral("transferable"); | ||
| 1525 | const QString transferable_shader_cache_file_path = | ||
| 1526 | transferable_shader_cache_folder_path + QDir::separator() + | ||
| 1527 | QString::fromStdString(fmt::format("{:016X}.bin", program_id)); | ||
| 1528 | |||
| 1529 | if (!QFile::exists(transferable_shader_cache_file_path)) { | ||
| 1530 | QMessageBox::warning(this, tr("Error Removing Transferable Shader Cache"), | ||
| 1531 | tr("A shader cache for this title does not exist.")); | ||
| 1532 | return; | ||
| 1533 | } | ||
| 1534 | |||
| 1535 | if (QFile::remove(transferable_shader_cache_file_path)) { | ||
| 1536 | QMessageBox::information(this, tr("Successfully Removed"), | ||
| 1537 | tr("Successfully removed the transferable shader cache.")); | ||
| 1538 | } else { | ||
| 1539 | QMessageBox::warning(this, tr("Error Removing Transferable Shader Cache"), | ||
| 1540 | tr("Failed to remove the transferable shader cache.")); | ||
| 1541 | } | ||
| 1542 | } | ||
| 1543 | |||
| 1544 | void GMainWindow::RemoveCustomConfiguration(u64 program_id) { | ||
| 1545 | const QString config_dir = | ||
| 1546 | QString::fromStdString(FileUtil::GetUserPath(FileUtil::UserPath::ConfigDir)); | ||
| 1547 | const QString custom_config_file_path = | ||
| 1548 | config_dir + QString::fromStdString(fmt::format("{:016X}.ini", program_id)); | ||
| 1549 | |||
| 1550 | if (!QFile::exists(custom_config_file_path)) { | ||
| 1551 | QMessageBox::warning(this, tr("Error Removing Custom Configuration"), | ||
| 1552 | tr("A custom configuration for this title does not exist.")); | ||
| 1553 | return; | ||
| 1554 | } | ||
| 1555 | |||
| 1556 | if (QFile::remove(custom_config_file_path)) { | ||
| 1557 | QMessageBox::information(this, tr("Successfully Removed"), | ||
| 1558 | tr("Successfully removed the custom game configuration.")); | ||
| 1559 | } else { | ||
| 1560 | QMessageBox::warning(this, tr("Error Removing Custom Configuration"), | ||
| 1561 | tr("Failed to remove the custom game configuration.")); | ||
| 1562 | } | ||
| 1563 | } | ||
| 1564 | |||
| 1397 | void GMainWindow::OnGameListDumpRomFS(u64 program_id, const std::string& game_path) { | 1565 | void GMainWindow::OnGameListDumpRomFS(u64 program_id, const std::string& game_path) { |
| 1398 | const auto failed = [this] { | 1566 | const auto failed = [this] { |
| 1399 | QMessageBox::warning(this, tr("RomFS Extraction Failed!"), | 1567 | QMessageBox::warning(this, tr("RomFS Extraction Failed!"), |
| @@ -1655,7 +1823,7 @@ void GMainWindow::OnMenuInstallToNAND() { | |||
| 1655 | 1823 | ||
| 1656 | ui.action_Install_File_NAND->setEnabled(false); | 1824 | ui.action_Install_File_NAND->setEnabled(false); |
| 1657 | 1825 | ||
| 1658 | install_progress = new QProgressDialog(QStringLiteral(""), tr("Cancel"), 0, total_size, this); | 1826 | install_progress = new QProgressDialog(QString{}, tr("Cancel"), 0, total_size, this); |
| 1659 | install_progress->setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint & | 1827 | install_progress->setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint & |
| 1660 | ~Qt::WindowMaximizeButtonHint); | 1828 | ~Qt::WindowMaximizeButtonHint); |
| 1661 | install_progress->setAttribute(Qt::WA_DeleteOnClose, true); | 1829 | install_progress->setAttribute(Qt::WA_DeleteOnClose, true); |
| @@ -1705,18 +1873,18 @@ void GMainWindow::OnMenuInstallToNAND() { | |||
| 1705 | install_progress->close(); | 1873 | install_progress->close(); |
| 1706 | 1874 | ||
| 1707 | const QString install_results = | 1875 | const QString install_results = |
| 1708 | (new_files.isEmpty() ? QStringLiteral("") | 1876 | (new_files.isEmpty() ? QString{} |
| 1709 | : tr("%n file(s) were newly installed\n", "", new_files.size())) + | 1877 | : tr("%n file(s) were newly installed\n", "", new_files.size())) + |
| 1710 | (overwritten_files.isEmpty() | 1878 | (overwritten_files.isEmpty() |
| 1711 | ? QStringLiteral("") | 1879 | ? QString{} |
| 1712 | : tr("%n file(s) were overwritten\n", "", overwritten_files.size())) + | 1880 | : tr("%n file(s) were overwritten\n", "", overwritten_files.size())) + |
| 1713 | (failed_files.isEmpty() ? QStringLiteral("") | 1881 | (failed_files.isEmpty() ? QString{} |
| 1714 | : tr("%n file(s) failed to install\n", "", failed_files.size())); | 1882 | : tr("%n file(s) failed to install\n", "", failed_files.size())); |
| 1715 | 1883 | ||
| 1716 | QMessageBox::information(this, tr("Install Results"), install_results); | 1884 | QMessageBox::information(this, tr("Install Results"), install_results); |
| 1717 | game_list->PopulateAsync(UISettings::values.game_dirs); | ||
| 1718 | FileUtil::DeleteDirRecursively(FileUtil::GetUserPath(FileUtil::UserPath::CacheDir) + DIR_SEP + | 1885 | FileUtil::DeleteDirRecursively(FileUtil::GetUserPath(FileUtil::UserPath::CacheDir) + DIR_SEP + |
| 1719 | "game_list"); | 1886 | "game_list"); |
| 1887 | game_list->PopulateAsync(UISettings::values.game_dirs); | ||
| 1720 | ui.action_Install_File_NAND->setEnabled(true); | 1888 | ui.action_Install_File_NAND->setEnabled(true); |
| 1721 | } | 1889 | } |
| 1722 | 1890 | ||
| @@ -2153,17 +2321,28 @@ void GMainWindow::OnToggleFilterBar() { | |||
| 2153 | 2321 | ||
| 2154 | void GMainWindow::OnCaptureScreenshot() { | 2322 | void GMainWindow::OnCaptureScreenshot() { |
| 2155 | OnPauseGame(); | 2323 | OnPauseGame(); |
| 2156 | QFileDialog png_dialog(this, tr("Capture Screenshot"), UISettings::values.screenshot_path, | 2324 | |
| 2157 | tr("PNG Image (*.png)")); | 2325 | const u64 title_id = Core::System::GetInstance().CurrentProcess()->GetTitleID(); |
| 2158 | png_dialog.setAcceptMode(QFileDialog::AcceptSave); | 2326 | const auto screenshot_path = |
| 2159 | png_dialog.setDefaultSuffix(QStringLiteral("png")); | 2327 | QString::fromStdString(FileUtil::GetUserPath(FileUtil::UserPath::ScreenshotsDir)); |
| 2160 | if (png_dialog.exec()) { | 2328 | const auto date = |
| 2161 | const QString path = png_dialog.selectedFiles().first(); | 2329 | QDateTime::currentDateTime().toString(QStringLiteral("yyyy-MM-dd_hh-mm-ss-zzz")); |
| 2162 | if (!path.isEmpty()) { | 2330 | QString filename = QStringLiteral("%1%2_%3.png") |
| 2163 | UISettings::values.screenshot_path = QFileInfo(path).path(); | 2331 | .arg(screenshot_path) |
| 2164 | render_window->CaptureScreenshot(UISettings::values.screenshot_resolution_factor, path); | 2332 | .arg(title_id, 16, 16, QLatin1Char{'0'}) |
| 2333 | .arg(date); | ||
| 2334 | |||
| 2335 | #ifdef _WIN32 | ||
| 2336 | if (UISettings::values.enable_screenshot_save_as) { | ||
| 2337 | filename = QFileDialog::getSaveFileName(this, tr("Capture Screenshot"), filename, | ||
| 2338 | tr("PNG Image (*.png)")); | ||
| 2339 | if (filename.isEmpty()) { | ||
| 2340 | OnStartGame(); | ||
| 2341 | return; | ||
| 2165 | } | 2342 | } |
| 2166 | } | 2343 | } |
| 2344 | #endif | ||
| 2345 | render_window->CaptureScreenshot(UISettings::values.screenshot_resolution_factor, filename); | ||
| 2167 | OnStartGame(); | 2346 | OnStartGame(); |
| 2168 | } | 2347 | } |
| 2169 | 2348 | ||
| @@ -2202,8 +2381,7 @@ void GMainWindow::UpdateStatusBar() { | |||
| 2202 | 2381 | ||
| 2203 | if (shaders_building != 0) { | 2382 | if (shaders_building != 0) { |
| 2204 | shader_building_label->setText( | 2383 | shader_building_label->setText( |
| 2205 | tr("Building: %1 shader").arg(shaders_building) + | 2384 | tr("Building: %n shader(s)", "", static_cast<int>(shaders_building))); |
| 2206 | (shaders_building != 1 ? QString::fromStdString("s") : QString::fromStdString(""))); | ||
| 2207 | shader_building_label->setVisible(true); | 2385 | shader_building_label->setVisible(true); |
| 2208 | } else { | 2386 | } else { |
| 2209 | shader_building_label->setVisible(false); | 2387 | shader_building_label->setVisible(false); |
diff --git a/src/yuzu/main.h b/src/yuzu/main.h index db573d606..73a44a3bf 100644 --- a/src/yuzu/main.h +++ b/src/yuzu/main.h | |||
| @@ -32,6 +32,8 @@ class QPushButton; | |||
| 32 | class QProgressDialog; | 32 | class QProgressDialog; |
| 33 | class WaitTreeWidget; | 33 | class WaitTreeWidget; |
| 34 | enum class GameListOpenTarget; | 34 | enum class GameListOpenTarget; |
| 35 | enum class GameListRemoveTarget; | ||
| 36 | enum class InstalledEntryType; | ||
| 35 | class GameListPlaceholder; | 37 | class GameListPlaceholder; |
| 36 | 38 | ||
| 37 | namespace Core::Frontend { | 39 | namespace Core::Frontend { |
| @@ -198,6 +200,8 @@ private slots: | |||
| 198 | void OnGameListLoadFile(QString game_path); | 200 | void OnGameListLoadFile(QString game_path); |
| 199 | void OnGameListOpenFolder(GameListOpenTarget target, const std::string& game_path); | 201 | void OnGameListOpenFolder(GameListOpenTarget target, const std::string& game_path); |
| 200 | void OnTransferableShaderCacheOpenFile(u64 program_id); | 202 | void OnTransferableShaderCacheOpenFile(u64 program_id); |
| 203 | void OnGameListRemoveInstalledEntry(u64 program_id, InstalledEntryType type); | ||
| 204 | void OnGameListRemoveFile(u64 program_id, GameListRemoveTarget target); | ||
| 201 | void OnGameListDumpRomFS(u64 program_id, const std::string& game_path); | 205 | void OnGameListDumpRomFS(u64 program_id, const std::string& game_path); |
| 202 | void OnGameListCopyTID(u64 program_id); | 206 | void OnGameListCopyTID(u64 program_id); |
| 203 | void OnGameListNavigateToGamedbEntry(u64 program_id, | 207 | void OnGameListNavigateToGamedbEntry(u64 program_id, |
| @@ -229,6 +233,11 @@ private slots: | |||
| 229 | void OnLanguageChanged(const QString& locale); | 233 | void OnLanguageChanged(const QString& locale); |
| 230 | 234 | ||
| 231 | private: | 235 | private: |
| 236 | void RemoveBaseContent(u64 program_id, const QString& entry_type); | ||
| 237 | void RemoveUpdateContent(u64 program_id, const QString& entry_type); | ||
| 238 | void RemoveAddOnContent(u64 program_id, const QString& entry_type); | ||
| 239 | void RemoveTransferableShaderCache(u64 program_id); | ||
| 240 | void RemoveCustomConfiguration(u64 program_id); | ||
| 232 | std::optional<u64> SelectRomFSDumpTarget(const FileSys::ContentProvider&, u64 program_id); | 241 | std::optional<u64> SelectRomFSDumpTarget(const FileSys::ContentProvider&, u64 program_id); |
| 233 | InstallResult InstallNSPXCI(const QString& filename); | 242 | InstallResult InstallNSPXCI(const QString& filename); |
| 234 | InstallResult InstallNCA(const QString& filename); | 243 | InstallResult InstallNCA(const QString& filename); |
diff --git a/src/yuzu/uisettings.h b/src/yuzu/uisettings.h index ac7b9aef6..bbfeafc55 100644 --- a/src/yuzu/uisettings.h +++ b/src/yuzu/uisettings.h | |||
| @@ -66,11 +66,11 @@ struct Values { | |||
| 66 | // Discord RPC | 66 | // Discord RPC |
| 67 | bool enable_discord_presence; | 67 | bool enable_discord_presence; |
| 68 | 68 | ||
| 69 | bool enable_screenshot_save_as; | ||
| 69 | u16 screenshot_resolution_factor; | 70 | u16 screenshot_resolution_factor; |
| 70 | 71 | ||
| 71 | QString roms_path; | 72 | QString roms_path; |
| 72 | QString symbols_path; | 73 | QString symbols_path; |
| 73 | QString screenshot_path; | ||
| 74 | QString game_dir_deprecated; | 74 | QString game_dir_deprecated; |
| 75 | bool game_dir_deprecated_deepscan; | 75 | bool game_dir_deprecated_deepscan; |
| 76 | QVector<UISettings::GameDir> game_dirs; | 76 | QVector<UISettings::GameDir> game_dirs; |