summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/core/hw/gpu.cpp12
-rw-r--r--src/core/hw/gpu.h9
2 files changed, 16 insertions, 5 deletions
diff --git a/src/core/hw/gpu.cpp b/src/core/hw/gpu.cpp
index 07443616e..e6983a225 100644
--- a/src/core/hw/gpu.cpp
+++ b/src/core/hw/gpu.cpp
@@ -118,8 +118,14 @@ inline void Write(u32 addr, const T data) {
118 u8* src_pointer = Memory::GetPointer(Memory::PhysicalToVirtualAddress(config.GetPhysicalInputAddress())); 118 u8* src_pointer = Memory::GetPointer(Memory::PhysicalToVirtualAddress(config.GetPhysicalInputAddress()));
119 u8* dst_pointer = Memory::GetPointer(Memory::PhysicalToVirtualAddress(config.GetPhysicalOutputAddress())); 119 u8* dst_pointer = Memory::GetPointer(Memory::PhysicalToVirtualAddress(config.GetPhysicalOutputAddress()));
120 120
121 unsigned horizontal_scale = (config.scale_horizontally != 0) ? 2 : 1; 121 if (config.scaling > config.ScaleXY) {
122 unsigned vertical_scale = (config.scale_vertically != 0) ? 2 : 1; 122 LOG_CRITICAL(HW_GPU, "Unimplemented display transfer scaling mode %u", config.scaling.Value());
123 UNIMPLEMENTED();
124 break;
125 }
126
127 unsigned horizontal_scale = (config.scaling != config.NoScale) ? 2 : 1;
128 unsigned vertical_scale = (config.scaling == config.ScaleXY) ? 2 : 1;
123 129
124 u32 output_width = config.output_width / horizontal_scale; 130 u32 output_width = config.output_width / horizontal_scale;
125 u32 output_height = config.output_height / vertical_scale; 131 u32 output_height = config.output_height / vertical_scale;
@@ -140,7 +146,7 @@ inline void Write(u32 addr, const T data) {
140 break; 146 break;
141 } 147 }
142 148
143 // TODO(Subv): Blend the pixels when horizontal / vertical scaling is enabled, 149 // TODO(Subv): Implement the box filter when scaling is enabled
144 // right now we're just skipping the extra pixels. 150 // right now we're just skipping the extra pixels.
145 for (u32 y = 0; y < output_height; ++y) { 151 for (u32 y = 0; y < output_height; ++y) {
146 for (u32 x = 0; x < output_width; ++x) { 152 for (u32 x = 0; x < output_width; ++x) {
diff --git a/src/core/hw/gpu.h b/src/core/hw/gpu.h
index e8552d854..c8f884494 100644
--- a/src/core/hw/gpu.h
+++ b/src/core/hw/gpu.h
@@ -188,6 +188,12 @@ struct Regs {
188 BitField<16, 16, u32> input_height; 188 BitField<16, 16, u32> input_height;
189 }; 189 };
190 190
191 enum ScalingMode : u32 {
192 NoScale = 0, // Doesn't scale the image
193 ScaleX = 1, // Downscales the image in half in the X axis and applies a box filter
194 ScaleXY = 2, // Downscales the image in half in both the X and Y axes and applies a box filter
195 };
196
191 union { 197 union {
192 u32 flags; 198 u32 flags;
193 199
@@ -197,8 +203,7 @@ struct Regs {
197 BitField< 8, 3, PixelFormat> input_format; 203 BitField< 8, 3, PixelFormat> input_format;
198 BitField<12, 3, PixelFormat> output_format; 204 BitField<12, 3, PixelFormat> output_format;
199 205
200 BitField<24, 1, u32> scale_horizontally; 206 BitField<24, 2, ScalingMode> scaling; // Determines the scaling mode of the transfer
201 BitField<25, 1, u32> scale_vertically;
202 }; 207 };
203 208
204 INSERT_PADDING_WORDS(0x1); 209 INSERT_PADDING_WORDS(0x1);