diff options
6 files changed, 3 insertions, 22 deletions
diff --git a/src/video_core/buffer_cache/buffer_cache.h b/src/video_core/buffer_cache/buffer_cache.h index 627917ab6..06fd40851 100644 --- a/src/video_core/buffer_cache/buffer_cache.h +++ b/src/video_core/buffer_cache/buffer_cache.h | |||
| @@ -1938,21 +1938,14 @@ typename BufferCache<P>::Binding BufferCache<P>::StorageBufferBinding(GPUVAddr s | |||
| 1938 | bool is_written) const { | 1938 | bool is_written) const { |
| 1939 | const GPUVAddr gpu_addr = gpu_memory->Read<u64>(ssbo_addr); | 1939 | const GPUVAddr gpu_addr = gpu_memory->Read<u64>(ssbo_addr); |
| 1940 | const u32 size = gpu_memory->Read<u32>(ssbo_addr + 8); | 1940 | const u32 size = gpu_memory->Read<u32>(ssbo_addr + 8); |
| 1941 | const u32 alignment = runtime.GetStorageBufferAlignment(); | 1941 | const std::optional<VAddr> cpu_addr = gpu_memory->GpuToCpuAddress(gpu_addr); |
| 1942 | |||
| 1943 | const GPUVAddr aligned_gpu_addr = Common::AlignDown(gpu_addr, alignment); | ||
| 1944 | const u32 aligned_size = | ||
| 1945 | Common::AlignUp(static_cast<u32>(gpu_addr - aligned_gpu_addr) + size, alignment); | ||
| 1946 | |||
| 1947 | const std::optional<VAddr> cpu_addr = gpu_memory->GpuToCpuAddress(aligned_gpu_addr); | ||
| 1948 | if (!cpu_addr || size == 0) { | 1942 | if (!cpu_addr || size == 0) { |
| 1949 | return NULL_BINDING; | 1943 | return NULL_BINDING; |
| 1950 | } | 1944 | } |
| 1951 | 1945 | const VAddr cpu_end = Common::AlignUp(*cpu_addr + size, Core::Memory::YUZU_PAGESIZE); | |
| 1952 | const VAddr cpu_end = Common::AlignUp(*cpu_addr + aligned_size, Core::Memory::YUZU_PAGESIZE); | ||
| 1953 | const Binding binding{ | 1946 | const Binding binding{ |
| 1954 | .cpu_addr = *cpu_addr, | 1947 | .cpu_addr = *cpu_addr, |
| 1955 | .size = is_written ? aligned_size : static_cast<u32>(cpu_end - *cpu_addr), | 1948 | .size = is_written ? size : static_cast<u32>(cpu_end - *cpu_addr), |
| 1956 | .buffer_id = BufferId{}, | 1949 | .buffer_id = BufferId{}, |
| 1957 | }; | 1950 | }; |
| 1958 | return binding; | 1951 | return binding; |
diff --git a/src/video_core/renderer_opengl/gl_buffer_cache.h b/src/video_core/renderer_opengl/gl_buffer_cache.h index bb1962073..a8c3f8b67 100644 --- a/src/video_core/renderer_opengl/gl_buffer_cache.h +++ b/src/video_core/renderer_opengl/gl_buffer_cache.h | |||
| @@ -160,10 +160,6 @@ public: | |||
| 160 | return device.CanReportMemoryUsage(); | 160 | return device.CanReportMemoryUsage(); |
| 161 | } | 161 | } |
| 162 | 162 | ||
| 163 | u32 GetStorageBufferAlignment() const { | ||
| 164 | return static_cast<u32>(device.GetShaderStorageBufferAlignment()); | ||
| 165 | } | ||
| 166 | |||
| 167 | private: | 163 | private: |
| 168 | static constexpr std::array PABO_LUT{ | 164 | static constexpr std::array PABO_LUT{ |
| 169 | GL_VERTEX_PROGRAM_PARAMETER_BUFFER_NV, GL_TESS_CONTROL_PROGRAM_PARAMETER_BUFFER_NV, | 165 | GL_VERTEX_PROGRAM_PARAMETER_BUFFER_NV, GL_TESS_CONTROL_PROGRAM_PARAMETER_BUFFER_NV, |
diff --git a/src/video_core/renderer_opengl/gl_shader_cache.cpp b/src/video_core/renderer_opengl/gl_shader_cache.cpp index 7dd854e0f..9442193de 100644 --- a/src/video_core/renderer_opengl/gl_shader_cache.cpp +++ b/src/video_core/renderer_opengl/gl_shader_cache.cpp | |||
| @@ -236,7 +236,6 @@ ShaderCache::ShaderCache(RasterizerOpenGL& rasterizer_, Core::Frontend::EmuWindo | |||
| 236 | .needs_demote_reorder = device.IsAmd(), | 236 | .needs_demote_reorder = device.IsAmd(), |
| 237 | .support_snorm_render_buffer = false, | 237 | .support_snorm_render_buffer = false, |
| 238 | .support_viewport_index_layer = device.HasVertexViewportLayer(), | 238 | .support_viewport_index_layer = device.HasVertexViewportLayer(), |
| 239 | .min_ssbo_alignment = static_cast<u32>(device.GetShaderStorageBufferAlignment()), | ||
| 240 | .support_geometry_shader_passthrough = device.HasGeometryShaderPassthrough(), | 239 | .support_geometry_shader_passthrough = device.HasGeometryShaderPassthrough(), |
| 241 | } { | 240 | } { |
| 242 | if (use_asynchronous_shaders) { | 241 | if (use_asynchronous_shaders) { |
diff --git a/src/video_core/renderer_vulkan/vk_buffer_cache.cpp b/src/video_core/renderer_vulkan/vk_buffer_cache.cpp index 1cfb4c2ff..b0153a502 100644 --- a/src/video_core/renderer_vulkan/vk_buffer_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_buffer_cache.cpp | |||
| @@ -330,10 +330,6 @@ bool BufferCacheRuntime::CanReportMemoryUsage() const { | |||
| 330 | return device.CanReportMemoryUsage(); | 330 | return device.CanReportMemoryUsage(); |
| 331 | } | 331 | } |
| 332 | 332 | ||
| 333 | u32 BufferCacheRuntime::GetStorageBufferAlignment() const { | ||
| 334 | return static_cast<u32>(device.GetStorageBufferAlignment()); | ||
| 335 | } | ||
| 336 | |||
| 337 | void BufferCacheRuntime::Finish() { | 333 | void BufferCacheRuntime::Finish() { |
| 338 | scheduler.Finish(); | 334 | scheduler.Finish(); |
| 339 | } | 335 | } |
diff --git a/src/video_core/renderer_vulkan/vk_buffer_cache.h b/src/video_core/renderer_vulkan/vk_buffer_cache.h index 06539c733..183b33632 100644 --- a/src/video_core/renderer_vulkan/vk_buffer_cache.h +++ b/src/video_core/renderer_vulkan/vk_buffer_cache.h | |||
| @@ -73,8 +73,6 @@ public: | |||
| 73 | 73 | ||
| 74 | bool CanReportMemoryUsage() const; | 74 | bool CanReportMemoryUsage() const; |
| 75 | 75 | ||
| 76 | u32 GetStorageBufferAlignment() const; | ||
| 77 | |||
| 78 | [[nodiscard]] StagingBufferRef UploadStagingBuffer(size_t size); | 76 | [[nodiscard]] StagingBufferRef UploadStagingBuffer(size_t size); |
| 79 | 77 | ||
| 80 | [[nodiscard]] StagingBufferRef DownloadStagingBuffer(size_t size); | 78 | [[nodiscard]] StagingBufferRef DownloadStagingBuffer(size_t size); |
diff --git a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp index 7e69b11d8..0684cceed 100644 --- a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp | |||
| @@ -344,7 +344,6 @@ PipelineCache::PipelineCache(RasterizerVulkan& rasterizer_, const Device& device | |||
| 344 | driver_id == VK_DRIVER_ID_AMD_PROPRIETARY || driver_id == VK_DRIVER_ID_AMD_OPEN_SOURCE, | 344 | driver_id == VK_DRIVER_ID_AMD_PROPRIETARY || driver_id == VK_DRIVER_ID_AMD_OPEN_SOURCE, |
| 345 | .support_snorm_render_buffer = true, | 345 | .support_snorm_render_buffer = true, |
| 346 | .support_viewport_index_layer = device.IsExtShaderViewportIndexLayerSupported(), | 346 | .support_viewport_index_layer = device.IsExtShaderViewportIndexLayerSupported(), |
| 347 | .min_ssbo_alignment = static_cast<u32>(device.GetStorageBufferAlignment()), | ||
| 348 | .support_geometry_shader_passthrough = device.IsNvGeometryShaderPassthroughSupported(), | 347 | .support_geometry_shader_passthrough = device.IsNvGeometryShaderPassthroughSupported(), |
| 349 | }; | 348 | }; |
| 350 | 349 | ||