diff options
31 files changed, 642 insertions, 440 deletions
diff --git a/src/common/logging/backend.cpp b/src/common/logging/backend.cpp index 5753b871a..12f6d0114 100644 --- a/src/common/logging/backend.cpp +++ b/src/common/logging/backend.cpp | |||
| @@ -13,7 +13,7 @@ | |||
| 13 | #include <vector> | 13 | #include <vector> |
| 14 | #ifdef _WIN32 | 14 | #ifdef _WIN32 |
| 15 | #include <share.h> // For _SH_DENYWR | 15 | #include <share.h> // For _SH_DENYWR |
| 16 | #include <windows.h> // For OutputDebugStringA | 16 | #include <windows.h> // For OutputDebugStringW |
| 17 | #else | 17 | #else |
| 18 | #define _SH_DENYWR 0 | 18 | #define _SH_DENYWR 0 |
| 19 | #endif | 19 | #endif |
| @@ -148,7 +148,7 @@ void FileBackend::Write(const Entry& entry) { | |||
| 148 | 148 | ||
| 149 | void DebuggerBackend::Write(const Entry& entry) { | 149 | void DebuggerBackend::Write(const Entry& entry) { |
| 150 | #ifdef _WIN32 | 150 | #ifdef _WIN32 |
| 151 | ::OutputDebugStringA(FormatLogMessage(entry).append(1, '\n').c_str()); | 151 | ::OutputDebugStringW(Common::UTF8ToUTF16W(FormatLogMessage(entry).append(1, '\n')).c_str()); |
| 152 | #endif | 152 | #endif |
| 153 | } | 153 | } |
| 154 | 154 | ||
diff --git a/src/core/file_sys/system_archive/ng_word.cpp b/src/core/file_sys/system_archive/ng_word.cpp index d0acdbd49..f4443784d 100644 --- a/src/core/file_sys/system_archive/ng_word.cpp +++ b/src/core/file_sys/system_archive/ng_word.cpp | |||
| @@ -26,7 +26,7 @@ constexpr std::array<u8, 30> WORD_TXT{ | |||
| 26 | VirtualDir NgWord1() { | 26 | VirtualDir NgWord1() { |
| 27 | std::vector<VirtualFile> files(NgWord1Data::NUMBER_WORD_TXT_FILES); | 27 | std::vector<VirtualFile> files(NgWord1Data::NUMBER_WORD_TXT_FILES); |
| 28 | 28 | ||
| 29 | for (std::size_t i = 0; i < NgWord1Data::NUMBER_WORD_TXT_FILES; ++i) { | 29 | for (std::size_t i = 0; i < files.size(); ++i) { |
| 30 | files[i] = std::make_shared<ArrayVfsFile<NgWord1Data::WORD_TXT.size()>>( | 30 | files[i] = std::make_shared<ArrayVfsFile<NgWord1Data::WORD_TXT.size()>>( |
| 31 | NgWord1Data::WORD_TXT, fmt::format("{}.txt", i)); | 31 | NgWord1Data::WORD_TXT, fmt::format("{}.txt", i)); |
| 32 | } | 32 | } |
| @@ -39,4 +39,43 @@ VirtualDir NgWord1() { | |||
| 39 | return std::make_shared<VectorVfsDirectory>(files, std::vector<VirtualDir>{}, "data"); | 39 | return std::make_shared<VectorVfsDirectory>(files, std::vector<VirtualDir>{}, "data"); |
| 40 | } | 40 | } |
| 41 | 41 | ||
| 42 | namespace NgWord2Data { | ||
| 43 | |||
| 44 | constexpr std::size_t NUMBER_AC_NX_FILES = 0x10; | ||
| 45 | |||
| 46 | // Should this archive replacement mysteriously not work on a future game, consider updating. | ||
| 47 | constexpr std::array<u8, 4> VERSION_DAT{0x0, 0x0, 0x0, 0x15}; // 5.1.0 System Version | ||
| 48 | |||
| 49 | constexpr std::array<u8, 0x2C> AC_NX_DATA{ | ||
| 50 | 0x1F, 0x8B, 0x08, 0x08, 0xD5, 0x2C, 0x09, 0x5C, 0x04, 0x00, 0x61, 0x63, 0x72, 0x61, 0x77, | ||
| 51 | 0x00, 0xED, 0xC1, 0x01, 0x0D, 0x00, 0x00, 0x00, 0xC2, 0x20, 0xFB, 0xA7, 0xB6, 0xC7, 0x07, | ||
| 52 | 0x0C, 0x00, 0x00, 0x00, 0xC8, 0x3B, 0x11, 0x00, 0x1C, 0xC7, 0x00, 0x10, 0x00, 0x00, | ||
| 53 | }; // Deserializes to no bad words | ||
| 54 | |||
| 55 | } // namespace NgWord2Data | ||
| 56 | |||
| 57 | VirtualDir NgWord2() { | ||
| 58 | std::vector<VirtualFile> files(NgWord2Data::NUMBER_AC_NX_FILES * 3); | ||
| 59 | |||
| 60 | for (std::size_t i = 0; i < NgWord2Data::NUMBER_AC_NX_FILES; ++i) { | ||
| 61 | files[3 * i] = std::make_shared<ArrayVfsFile<NgWord2Data::AC_NX_DATA.size()>>( | ||
| 62 | NgWord2Data::AC_NX_DATA, fmt::format("ac_{}_b1_nx", i)); | ||
| 63 | files[3 * i + 1] = std::make_shared<ArrayVfsFile<NgWord2Data::AC_NX_DATA.size()>>( | ||
| 64 | NgWord2Data::AC_NX_DATA, fmt::format("ac_{}_b2_nx", i)); | ||
| 65 | files[3 * i + 2] = std::make_shared<ArrayVfsFile<NgWord2Data::AC_NX_DATA.size()>>( | ||
| 66 | NgWord2Data::AC_NX_DATA, fmt::format("ac_{}_not_b_nx", i)); | ||
| 67 | } | ||
| 68 | |||
| 69 | files.push_back(std::make_shared<ArrayVfsFile<NgWord2Data::AC_NX_DATA.size()>>( | ||
| 70 | NgWord2Data::AC_NX_DATA, "ac_common_b1_nx")); | ||
| 71 | files.push_back(std::make_shared<ArrayVfsFile<NgWord2Data::AC_NX_DATA.size()>>( | ||
| 72 | NgWord2Data::AC_NX_DATA, "ac_common_b2_nx")); | ||
| 73 | files.push_back(std::make_shared<ArrayVfsFile<NgWord2Data::AC_NX_DATA.size()>>( | ||
| 74 | NgWord2Data::AC_NX_DATA, "ac_common_not_b_nx")); | ||
| 75 | files.push_back(std::make_shared<ArrayVfsFile<NgWord2Data::VERSION_DAT.size()>>( | ||
| 76 | NgWord2Data::VERSION_DAT, "version.dat")); | ||
| 77 | |||
| 78 | return std::make_shared<VectorVfsDirectory>(files, std::vector<VirtualDir>{}, "data"); | ||
| 79 | } | ||
| 80 | |||
| 42 | } // namespace FileSys::SystemArchive | 81 | } // namespace FileSys::SystemArchive |
diff --git a/src/core/file_sys/system_archive/ng_word.h b/src/core/file_sys/system_archive/ng_word.h index f4bc67344..cd81e0abb 100644 --- a/src/core/file_sys/system_archive/ng_word.h +++ b/src/core/file_sys/system_archive/ng_word.h | |||
| @@ -9,5 +9,6 @@ | |||
| 9 | namespace FileSys::SystemArchive { | 9 | namespace FileSys::SystemArchive { |
| 10 | 10 | ||
| 11 | VirtualDir NgWord1(); | 11 | VirtualDir NgWord1(); |
| 12 | VirtualDir NgWord2(); | ||
| 12 | 13 | ||
| 13 | } // namespace FileSys::SystemArchive | 14 | } // namespace FileSys::SystemArchive |
diff --git a/src/core/file_sys/system_archive/system_archive.cpp b/src/core/file_sys/system_archive/system_archive.cpp index c9c40a07d..e3e79f40a 100644 --- a/src/core/file_sys/system_archive/system_archive.cpp +++ b/src/core/file_sys/system_archive/system_archive.cpp | |||
| @@ -2,7 +2,6 @@ | |||
| 2 | // Licensed under GPLv2 or any later version | 2 | // Licensed under GPLv2 or any later version |
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include <functional> | ||
| 6 | #include "common/logging/log.h" | 5 | #include "common/logging/log.h" |
| 7 | #include "core/file_sys/romfs.h" | 6 | #include "core/file_sys/romfs.h" |
| 8 | #include "core/file_sys/system_archive/ng_word.h" | 7 | #include "core/file_sys/system_archive/ng_word.h" |
| @@ -13,7 +12,7 @@ namespace FileSys::SystemArchive { | |||
| 13 | constexpr u64 SYSTEM_ARCHIVE_BASE_TITLE_ID = 0x0100000000000800; | 12 | constexpr u64 SYSTEM_ARCHIVE_BASE_TITLE_ID = 0x0100000000000800; |
| 14 | constexpr std::size_t SYSTEM_ARCHIVE_COUNT = 0x28; | 13 | constexpr std::size_t SYSTEM_ARCHIVE_COUNT = 0x28; |
| 15 | 14 | ||
| 16 | using SystemArchiveSupplier = std::function<VirtualDir()>; | 15 | using SystemArchiveSupplier = VirtualDir (*)(); |
| 17 | 16 | ||
| 18 | struct SystemArchiveDescriptor { | 17 | struct SystemArchiveDescriptor { |
| 19 | u64 title_id; | 18 | u64 title_id; |
| @@ -21,7 +20,7 @@ struct SystemArchiveDescriptor { | |||
| 21 | SystemArchiveSupplier supplier; | 20 | SystemArchiveSupplier supplier; |
| 22 | }; | 21 | }; |
| 23 | 22 | ||
| 24 | const std::array<SystemArchiveDescriptor, SYSTEM_ARCHIVE_COUNT> SYSTEM_ARCHIVES = {{ | 23 | constexpr std::array<SystemArchiveDescriptor, SYSTEM_ARCHIVE_COUNT> SYSTEM_ARCHIVES{{ |
| 25 | {0x0100000000000800, "CertStore", nullptr}, | 24 | {0x0100000000000800, "CertStore", nullptr}, |
| 26 | {0x0100000000000801, "ErrorMessage", nullptr}, | 25 | {0x0100000000000801, "ErrorMessage", nullptr}, |
| 27 | {0x0100000000000802, "MiiModel", nullptr}, | 26 | {0x0100000000000802, "MiiModel", nullptr}, |
| @@ -57,7 +56,7 @@ const std::array<SystemArchiveDescriptor, SYSTEM_ARCHIVE_COUNT> SYSTEM_ARCHIVES | |||
| 57 | {0x0100000000000820, "PlatformConfigCopper", nullptr}, | 56 | {0x0100000000000820, "PlatformConfigCopper", nullptr}, |
| 58 | {0x0100000000000821, "PlatformConfigHoag", nullptr}, | 57 | {0x0100000000000821, "PlatformConfigHoag", nullptr}, |
| 59 | {0x0100000000000822, "ControllerFirmware", nullptr}, | 58 | {0x0100000000000822, "ControllerFirmware", nullptr}, |
| 60 | {0x0100000000000823, "NgWord2", nullptr}, | 59 | {0x0100000000000823, "NgWord2", &NgWord2}, |
| 61 | {0x0100000000000824, "PlatformConfigIcosaMariko", nullptr}, | 60 | {0x0100000000000824, "PlatformConfigIcosaMariko", nullptr}, |
| 62 | {0x0100000000000825, "ApplicationBlackList", nullptr}, | 61 | {0x0100000000000825, "ApplicationBlackList", nullptr}, |
| 63 | {0x0100000000000826, "RebootlessSystemUpdateVersion", nullptr}, | 62 | {0x0100000000000826, "RebootlessSystemUpdateVersion", nullptr}, |
diff --git a/src/core/hle/kernel/object.cpp b/src/core/hle/kernel/object.cpp index bb1b68778..0ea851a74 100644 --- a/src/core/hle/kernel/object.cpp +++ b/src/core/hle/kernel/object.cpp | |||
| @@ -15,6 +15,7 @@ bool Object::IsWaitable() const { | |||
| 15 | switch (GetHandleType()) { | 15 | switch (GetHandleType()) { |
| 16 | case HandleType::ReadableEvent: | 16 | case HandleType::ReadableEvent: |
| 17 | case HandleType::Thread: | 17 | case HandleType::Thread: |
| 18 | case HandleType::Process: | ||
| 18 | case HandleType::Timer: | 19 | case HandleType::Timer: |
| 19 | case HandleType::ServerPort: | 20 | case HandleType::ServerPort: |
| 20 | case HandleType::ServerSession: | 21 | case HandleType::ServerSession: |
| @@ -23,7 +24,6 @@ bool Object::IsWaitable() const { | |||
| 23 | case HandleType::Unknown: | 24 | case HandleType::Unknown: |
| 24 | case HandleType::WritableEvent: | 25 | case HandleType::WritableEvent: |
| 25 | case HandleType::SharedMemory: | 26 | case HandleType::SharedMemory: |
| 26 | case HandleType::Process: | ||
| 27 | case HandleType::AddressArbiter: | 27 | case HandleType::AddressArbiter: |
| 28 | case HandleType::ResourceLimit: | 28 | case HandleType::ResourceLimit: |
| 29 | case HandleType::ClientPort: | 29 | case HandleType::ClientPort: |
diff --git a/src/core/hle/kernel/process.cpp b/src/core/hle/kernel/process.cpp index 4ecb8c926..211bf6686 100644 --- a/src/core/hle/kernel/process.cpp +++ b/src/core/hle/kernel/process.cpp | |||
| @@ -9,6 +9,7 @@ | |||
| 9 | #include "common/logging/log.h" | 9 | #include "common/logging/log.h" |
| 10 | #include "core/core.h" | 10 | #include "core/core.h" |
| 11 | #include "core/file_sys/program_metadata.h" | 11 | #include "core/file_sys/program_metadata.h" |
| 12 | #include "core/hle/kernel/errors.h" | ||
| 12 | #include "core/hle/kernel/kernel.h" | 13 | #include "core/hle/kernel/kernel.h" |
| 13 | #include "core/hle/kernel/process.h" | 14 | #include "core/hle/kernel/process.h" |
| 14 | #include "core/hle/kernel/resource_limit.h" | 15 | #include "core/hle/kernel/resource_limit.h" |
| @@ -48,6 +49,21 @@ SharedPtr<ResourceLimit> Process::GetResourceLimit() const { | |||
| 48 | return resource_limit; | 49 | return resource_limit; |
| 49 | } | 50 | } |
| 50 | 51 | ||
| 52 | ResultCode Process::ClearSignalState() { | ||
| 53 | if (status == ProcessStatus::Exited) { | ||
| 54 | LOG_ERROR(Kernel, "called on a terminated process instance."); | ||
| 55 | return ERR_INVALID_STATE; | ||
| 56 | } | ||
| 57 | |||
| 58 | if (!is_signaled) { | ||
| 59 | LOG_ERROR(Kernel, "called on a process instance that isn't signaled."); | ||
| 60 | return ERR_INVALID_STATE; | ||
| 61 | } | ||
| 62 | |||
| 63 | is_signaled = false; | ||
| 64 | return RESULT_SUCCESS; | ||
| 65 | } | ||
| 66 | |||
| 51 | void Process::LoadFromMetadata(const FileSys::ProgramMetadata& metadata) { | 67 | void Process::LoadFromMetadata(const FileSys::ProgramMetadata& metadata) { |
| 52 | program_id = metadata.GetTitleID(); | 68 | program_id = metadata.GetTitleID(); |
| 53 | is_64bit_process = metadata.Is64BitProgram(); | 69 | is_64bit_process = metadata.Is64BitProgram(); |
| @@ -137,13 +153,13 @@ void Process::Run(VAddr entry_point, s32 main_thread_priority, u32 stack_size) { | |||
| 137 | .Unwrap(); | 153 | .Unwrap(); |
| 138 | 154 | ||
| 139 | vm_manager.LogLayout(); | 155 | vm_manager.LogLayout(); |
| 140 | status = ProcessStatus::Running; | 156 | ChangeStatus(ProcessStatus::Running); |
| 141 | 157 | ||
| 142 | Kernel::SetupMainThread(kernel, entry_point, main_thread_priority, *this); | 158 | Kernel::SetupMainThread(kernel, entry_point, main_thread_priority, *this); |
| 143 | } | 159 | } |
| 144 | 160 | ||
| 145 | void Process::PrepareForTermination() { | 161 | void Process::PrepareForTermination() { |
| 146 | status = ProcessStatus::Exited; | 162 | ChangeStatus(ProcessStatus::Exiting); |
| 147 | 163 | ||
| 148 | const auto stop_threads = [this](const std::vector<SharedPtr<Thread>>& thread_list) { | 164 | const auto stop_threads = [this](const std::vector<SharedPtr<Thread>>& thread_list) { |
| 149 | for (auto& thread : thread_list) { | 165 | for (auto& thread : thread_list) { |
| @@ -167,6 +183,8 @@ void Process::PrepareForTermination() { | |||
| 167 | stop_threads(system.Scheduler(1).GetThreadList()); | 183 | stop_threads(system.Scheduler(1).GetThreadList()); |
| 168 | stop_threads(system.Scheduler(2).GetThreadList()); | 184 | stop_threads(system.Scheduler(2).GetThreadList()); |
| 169 | stop_threads(system.Scheduler(3).GetThreadList()); | 185 | stop_threads(system.Scheduler(3).GetThreadList()); |
| 186 | |||
| 187 | ChangeStatus(ProcessStatus::Exited); | ||
| 170 | } | 188 | } |
| 171 | 189 | ||
| 172 | /** | 190 | /** |
| @@ -265,7 +283,25 @@ ResultCode Process::UnmapMemory(VAddr dst_addr, VAddr /*src_addr*/, u64 size) { | |||
| 265 | return vm_manager.UnmapRange(dst_addr, size); | 283 | return vm_manager.UnmapRange(dst_addr, size); |
| 266 | } | 284 | } |
| 267 | 285 | ||
| 268 | Kernel::Process::Process(KernelCore& kernel) : Object{kernel} {} | 286 | Kernel::Process::Process(KernelCore& kernel) : WaitObject{kernel} {} |
| 269 | Kernel::Process::~Process() {} | 287 | Kernel::Process::~Process() {} |
| 270 | 288 | ||
| 289 | void Process::Acquire(Thread* thread) { | ||
| 290 | ASSERT_MSG(!ShouldWait(thread), "Object unavailable!"); | ||
| 291 | } | ||
| 292 | |||
| 293 | bool Process::ShouldWait(Thread* thread) const { | ||
| 294 | return !is_signaled; | ||
| 295 | } | ||
| 296 | |||
| 297 | void Process::ChangeStatus(ProcessStatus new_status) { | ||
| 298 | if (status == new_status) { | ||
| 299 | return; | ||
| 300 | } | ||
| 301 | |||
| 302 | status = new_status; | ||
| 303 | is_signaled = true; | ||
| 304 | WakeupAllWaitingThreads(); | ||
| 305 | } | ||
| 306 | |||
| 271 | } // namespace Kernel | 307 | } // namespace Kernel |
diff --git a/src/core/hle/kernel/process.h b/src/core/hle/kernel/process.h index 49345aa66..bcb9ac4b8 100644 --- a/src/core/hle/kernel/process.h +++ b/src/core/hle/kernel/process.h | |||
| @@ -14,9 +14,10 @@ | |||
| 14 | #include "common/bit_field.h" | 14 | #include "common/bit_field.h" |
| 15 | #include "common/common_types.h" | 15 | #include "common/common_types.h" |
| 16 | #include "core/hle/kernel/handle_table.h" | 16 | #include "core/hle/kernel/handle_table.h" |
| 17 | #include "core/hle/kernel/object.h" | ||
| 18 | #include "core/hle/kernel/thread.h" | 17 | #include "core/hle/kernel/thread.h" |
| 19 | #include "core/hle/kernel/vm_manager.h" | 18 | #include "core/hle/kernel/vm_manager.h" |
| 19 | #include "core/hle/kernel/wait_object.h" | ||
| 20 | #include "core/hle/result.h" | ||
| 20 | 21 | ||
| 21 | namespace FileSys { | 22 | namespace FileSys { |
| 22 | class ProgramMetadata; | 23 | class ProgramMetadata; |
| @@ -117,7 +118,7 @@ struct CodeSet final { | |||
| 117 | VAddr entrypoint = 0; | 118 | VAddr entrypoint = 0; |
| 118 | }; | 119 | }; |
| 119 | 120 | ||
| 120 | class Process final : public Object { | 121 | class Process final : public WaitObject { |
| 121 | public: | 122 | public: |
| 122 | static constexpr std::size_t RANDOM_ENTROPY_SIZE = 4; | 123 | static constexpr std::size_t RANDOM_ENTROPY_SIZE = 4; |
| 123 | 124 | ||
| @@ -212,6 +213,16 @@ public: | |||
| 212 | return random_entropy.at(index); | 213 | return random_entropy.at(index); |
| 213 | } | 214 | } |
| 214 | 215 | ||
| 216 | /// Clears the signaled state of the process if and only if it's signaled. | ||
| 217 | /// | ||
| 218 | /// @pre The process must not be already terminated. If this is called on a | ||
| 219 | /// terminated process, then ERR_INVALID_STATE will be returned. | ||
| 220 | /// | ||
| 221 | /// @pre The process must be in a signaled state. If this is called on a | ||
| 222 | /// process instance that is not signaled, ERR_INVALID_STATE will be | ||
| 223 | /// returned. | ||
| 224 | ResultCode ClearSignalState(); | ||
| 225 | |||
| 215 | /** | 226 | /** |
| 216 | * Loads process-specifics configuration info with metadata provided | 227 | * Loads process-specifics configuration info with metadata provided |
| 217 | * by an executable. | 228 | * by an executable. |
| @@ -260,6 +271,17 @@ private: | |||
| 260 | explicit Process(KernelCore& kernel); | 271 | explicit Process(KernelCore& kernel); |
| 261 | ~Process() override; | 272 | ~Process() override; |
| 262 | 273 | ||
| 274 | /// Checks if the specified thread should wait until this process is available. | ||
| 275 | bool ShouldWait(Thread* thread) const override; | ||
| 276 | |||
| 277 | /// Acquires/locks this process for the specified thread if it's available. | ||
| 278 | void Acquire(Thread* thread) override; | ||
| 279 | |||
| 280 | /// Changes the process status. If the status is different | ||
| 281 | /// from the current process status, then this will trigger | ||
| 282 | /// a process signal. | ||
| 283 | void ChangeStatus(ProcessStatus new_status); | ||
| 284 | |||
| 263 | /// Memory manager for this process. | 285 | /// Memory manager for this process. |
| 264 | Kernel::VMManager vm_manager; | 286 | Kernel::VMManager vm_manager; |
| 265 | 287 | ||
| @@ -305,6 +327,10 @@ private: | |||
| 305 | /// specified by metadata provided to the process during loading. | 327 | /// specified by metadata provided to the process during loading. |
| 306 | bool is_64bit_process = true; | 328 | bool is_64bit_process = true; |
| 307 | 329 | ||
| 330 | /// Whether or not this process is signaled. This occurs | ||
| 331 | /// upon the process changing to a different state. | ||
| 332 | bool is_signaled = false; | ||
| 333 | |||
| 308 | /// Total running time for the process in ticks. | 334 | /// Total running time for the process in ticks. |
| 309 | u64 total_process_running_time_ticks = 0; | 335 | u64 total_process_running_time_ticks = 0; |
| 310 | 336 | ||
diff --git a/src/core/hle/kernel/readable_event.cpp b/src/core/hle/kernel/readable_event.cpp index 92e16b4e6..ba01f495c 100644 --- a/src/core/hle/kernel/readable_event.cpp +++ b/src/core/hle/kernel/readable_event.cpp | |||
| @@ -4,10 +4,10 @@ | |||
| 4 | 4 | ||
| 5 | #include <algorithm> | 5 | #include <algorithm> |
| 6 | #include "common/assert.h" | 6 | #include "common/assert.h" |
| 7 | #include "core/hle/kernel/errors.h" | ||
| 7 | #include "core/hle/kernel/object.h" | 8 | #include "core/hle/kernel/object.h" |
| 8 | #include "core/hle/kernel/readable_event.h" | 9 | #include "core/hle/kernel/readable_event.h" |
| 9 | #include "core/hle/kernel/thread.h" | 10 | #include "core/hle/kernel/thread.h" |
| 10 | #include "core/hle/kernel/writable_event.h" | ||
| 11 | 11 | ||
| 12 | namespace Kernel { | 12 | namespace Kernel { |
| 13 | 13 | ||
| @@ -34,6 +34,16 @@ void ReadableEvent::Clear() { | |||
| 34 | signaled = false; | 34 | signaled = false; |
| 35 | } | 35 | } |
| 36 | 36 | ||
| 37 | ResultCode ReadableEvent::Reset() { | ||
| 38 | if (!signaled) { | ||
| 39 | return ERR_INVALID_STATE; | ||
| 40 | } | ||
| 41 | |||
| 42 | Clear(); | ||
| 43 | |||
| 44 | return RESULT_SUCCESS; | ||
| 45 | } | ||
| 46 | |||
| 37 | void ReadableEvent::WakeupAllWaitingThreads() { | 47 | void ReadableEvent::WakeupAllWaitingThreads() { |
| 38 | WaitObject::WakeupAllWaitingThreads(); | 48 | WaitObject::WakeupAllWaitingThreads(); |
| 39 | 49 | ||
diff --git a/src/core/hle/kernel/readable_event.h b/src/core/hle/kernel/readable_event.h index 867ff3051..80b3b0aba 100644 --- a/src/core/hle/kernel/readable_event.h +++ b/src/core/hle/kernel/readable_event.h | |||
| @@ -7,6 +7,8 @@ | |||
| 7 | #include "core/hle/kernel/object.h" | 7 | #include "core/hle/kernel/object.h" |
| 8 | #include "core/hle/kernel/wait_object.h" | 8 | #include "core/hle/kernel/wait_object.h" |
| 9 | 9 | ||
| 10 | union ResultCode; | ||
| 11 | |||
| 10 | namespace Kernel { | 12 | namespace Kernel { |
| 11 | 13 | ||
| 12 | class KernelCore; | 14 | class KernelCore; |
| @@ -39,8 +41,17 @@ public: | |||
| 39 | 41 | ||
| 40 | void WakeupAllWaitingThreads() override; | 42 | void WakeupAllWaitingThreads() override; |
| 41 | 43 | ||
| 44 | /// Unconditionally clears the readable event's state. | ||
| 42 | void Clear(); | 45 | void Clear(); |
| 43 | 46 | ||
| 47 | /// Clears the readable event's state if and only if it | ||
| 48 | /// has already been signaled. | ||
| 49 | /// | ||
| 50 | /// @pre The event must be in a signaled state. If this event | ||
| 51 | /// is in an unsignaled state and this function is called, | ||
| 52 | /// then ERR_INVALID_STATE will be returned. | ||
| 53 | ResultCode Reset(); | ||
| 54 | |||
| 44 | private: | 55 | private: |
| 45 | explicit ReadableEvent(KernelCore& kernel); | 56 | explicit ReadableEvent(KernelCore& kernel); |
| 46 | 57 | ||
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp index e6c77f9db..84df2040e 100644 --- a/src/core/hle/kernel/svc.cpp +++ b/src/core/hle/kernel/svc.cpp | |||
| @@ -1433,17 +1433,24 @@ static ResultCode CloseHandle(Handle handle) { | |||
| 1433 | return handle_table.Close(handle); | 1433 | return handle_table.Close(handle); |
| 1434 | } | 1434 | } |
| 1435 | 1435 | ||
| 1436 | /// Reset an event | 1436 | /// Clears the signaled state of an event or process. |
| 1437 | static ResultCode ResetSignal(Handle handle) { | 1437 | static ResultCode ResetSignal(Handle handle) { |
| 1438 | LOG_DEBUG(Kernel_SVC, "called handle 0x{:08X}", handle); | 1438 | LOG_DEBUG(Kernel_SVC, "called handle 0x{:08X}", handle); |
| 1439 | 1439 | ||
| 1440 | const auto& handle_table = Core::CurrentProcess()->GetHandleTable(); | 1440 | const auto& handle_table = Core::CurrentProcess()->GetHandleTable(); |
| 1441 | |||
| 1441 | auto event = handle_table.Get<ReadableEvent>(handle); | 1442 | auto event = handle_table.Get<ReadableEvent>(handle); |
| 1443 | if (event) { | ||
| 1444 | return event->Reset(); | ||
| 1445 | } | ||
| 1442 | 1446 | ||
| 1443 | ASSERT(event != nullptr); | 1447 | auto process = handle_table.Get<Process>(handle); |
| 1448 | if (process) { | ||
| 1449 | return process->ClearSignalState(); | ||
| 1450 | } | ||
| 1444 | 1451 | ||
| 1445 | event->Clear(); | 1452 | LOG_ERROR(Kernel_SVC, "Invalid handle (0x{:08X})", handle); |
| 1446 | return RESULT_SUCCESS; | 1453 | return ERR_INVALID_HANDLE; |
| 1447 | } | 1454 | } |
| 1448 | 1455 | ||
| 1449 | /// Creates a TransferMemory object | 1456 | /// Creates a TransferMemory object |
diff --git a/src/core/hle/service/ldr/ldr.cpp b/src/core/hle/service/ldr/ldr.cpp index a81699a5a..13bcefe07 100644 --- a/src/core/hle/service/ldr/ldr.cpp +++ b/src/core/hle/service/ldr/ldr.cpp | |||
| @@ -335,10 +335,7 @@ public: | |||
| 335 | vm_manager.ReprotectRange(*map_address + header.rw_offset, header.rw_size, | 335 | vm_manager.ReprotectRange(*map_address + header.rw_offset, header.rw_size, |
| 336 | Kernel::VMAPermission::ReadWrite); | 336 | Kernel::VMAPermission::ReadWrite); |
| 337 | 337 | ||
| 338 | Core::System::GetInstance().ArmInterface(0).ClearInstructionCache(); | 338 | Core::System::GetInstance().InvalidateCpuInstructionCaches(); |
| 339 | Core::System::GetInstance().ArmInterface(1).ClearInstructionCache(); | ||
| 340 | Core::System::GetInstance().ArmInterface(2).ClearInstructionCache(); | ||
| 341 | Core::System::GetInstance().ArmInterface(3).ClearInstructionCache(); | ||
| 342 | 339 | ||
| 343 | nro.insert_or_assign(*map_address, NROInfo{hash, nro_size + bss_size}); | 340 | nro.insert_or_assign(*map_address, NROInfo{hash, nro_size + bss_size}); |
| 344 | 341 | ||
| @@ -391,10 +388,7 @@ public: | |||
| 391 | Kernel::MemoryState::ModuleCodeStatic) == RESULT_SUCCESS); | 388 | Kernel::MemoryState::ModuleCodeStatic) == RESULT_SUCCESS); |
| 392 | ASSERT(process->UnmapMemory(mapped_addr, 0, nro_size) == RESULT_SUCCESS); | 389 | ASSERT(process->UnmapMemory(mapped_addr, 0, nro_size) == RESULT_SUCCESS); |
| 393 | 390 | ||
| 394 | Core::System::GetInstance().ArmInterface(0).ClearInstructionCache(); | 391 | Core::System::GetInstance().InvalidateCpuInstructionCaches(); |
| 395 | Core::System::GetInstance().ArmInterface(1).ClearInstructionCache(); | ||
| 396 | Core::System::GetInstance().ArmInterface(2).ClearInstructionCache(); | ||
| 397 | Core::System::GetInstance().ArmInterface(3).ClearInstructionCache(); | ||
| 398 | 392 | ||
| 399 | nro.erase(iter); | 393 | nro.erase(iter); |
| 400 | IPC::ResponseBuilder rb{ctx, 2}; | 394 | IPC::ResponseBuilder rb{ctx, 2}; |
diff --git a/src/core/hle/service/service.cpp b/src/core/hle/service/service.cpp index 1ec340466..d41df3732 100644 --- a/src/core/hle/service/service.cpp +++ b/src/core/hle/service/service.cpp | |||
| @@ -70,10 +70,6 @@ | |||
| 70 | #include "core/hle/service/vi/vi.h" | 70 | #include "core/hle/service/vi/vi.h" |
| 71 | #include "core/hle/service/wlan/wlan.h" | 71 | #include "core/hle/service/wlan/wlan.h" |
| 72 | 72 | ||
| 73 | using Kernel::ClientPort; | ||
| 74 | using Kernel::ServerPort; | ||
| 75 | using Kernel::SharedPtr; | ||
| 76 | |||
| 77 | namespace Service { | 73 | namespace Service { |
| 78 | 74 | ||
| 79 | /** | 75 | /** |
| @@ -110,10 +106,8 @@ void ServiceFrameworkBase::InstallAsNamedPort() { | |||
| 110 | ASSERT(port == nullptr); | 106 | ASSERT(port == nullptr); |
| 111 | 107 | ||
| 112 | auto& kernel = Core::System::GetInstance().Kernel(); | 108 | auto& kernel = Core::System::GetInstance().Kernel(); |
| 113 | SharedPtr<ServerPort> server_port; | 109 | auto [server_port, client_port] = |
| 114 | SharedPtr<ClientPort> client_port; | 110 | Kernel::ServerPort::CreatePortPair(kernel, max_sessions, service_name); |
| 115 | std::tie(server_port, client_port) = | ||
| 116 | ServerPort::CreatePortPair(kernel, max_sessions, service_name); | ||
| 117 | server_port->SetHleHandler(shared_from_this()); | 111 | server_port->SetHleHandler(shared_from_this()); |
| 118 | kernel.AddNamedPort(service_name, std::move(client_port)); | 112 | kernel.AddNamedPort(service_name, std::move(client_port)); |
| 119 | } | 113 | } |
| @@ -122,11 +116,9 @@ Kernel::SharedPtr<Kernel::ClientPort> ServiceFrameworkBase::CreatePort() { | |||
| 122 | ASSERT(port == nullptr); | 116 | ASSERT(port == nullptr); |
| 123 | 117 | ||
| 124 | auto& kernel = Core::System::GetInstance().Kernel(); | 118 | auto& kernel = Core::System::GetInstance().Kernel(); |
| 125 | Kernel::SharedPtr<Kernel::ServerPort> server_port; | 119 | auto [server_port, client_port] = |
| 126 | Kernel::SharedPtr<Kernel::ClientPort> client_port; | ||
| 127 | std::tie(server_port, client_port) = | ||
| 128 | Kernel::ServerPort::CreatePortPair(kernel, max_sessions, service_name); | 120 | Kernel::ServerPort::CreatePortPair(kernel, max_sessions, service_name); |
| 129 | port = MakeResult<Kernel::SharedPtr<Kernel::ServerPort>>(std::move(server_port)).Unwrap(); | 121 | port = MakeResult(std::move(server_port)).Unwrap(); |
| 130 | port->SetHleHandler(shared_from_this()); | 122 | port->SetHleHandler(shared_from_this()); |
| 131 | return client_port; | 123 | return client_port; |
| 132 | } | 124 | } |
| @@ -152,8 +144,7 @@ void ServiceFrameworkBase::ReportUnimplementedFunction(Kernel::HLERequestContext | |||
| 152 | } | 144 | } |
| 153 | buf.push_back('}'); | 145 | buf.push_back('}'); |
| 154 | 146 | ||
| 155 | LOG_ERROR(Service, "unknown / unimplemented {}", fmt::to_string(buf)); | 147 | UNIMPLEMENTED_MSG("Unknown / unimplemented {}", fmt::to_string(buf)); |
| 156 | UNIMPLEMENTED(); | ||
| 157 | } | 148 | } |
| 158 | 149 | ||
| 159 | void ServiceFrameworkBase::InvokeRequest(Kernel::HLERequestContext& ctx) { | 150 | void ServiceFrameworkBase::InvokeRequest(Kernel::HLERequestContext& ctx) { |
diff --git a/src/core/hle/service/sm/sm.cpp b/src/core/hle/service/sm/sm.cpp index 0d0f63a78..d73530086 100644 --- a/src/core/hle/service/sm/sm.cpp +++ b/src/core/hle/service/sm/sm.cpp | |||
| @@ -54,13 +54,11 @@ ResultVal<Kernel::SharedPtr<Kernel::ServerPort>> ServiceManager::RegisterService | |||
| 54 | return ERR_ALREADY_REGISTERED; | 54 | return ERR_ALREADY_REGISTERED; |
| 55 | 55 | ||
| 56 | auto& kernel = Core::System::GetInstance().Kernel(); | 56 | auto& kernel = Core::System::GetInstance().Kernel(); |
| 57 | Kernel::SharedPtr<Kernel::ServerPort> server_port; | 57 | auto [server_port, client_port] = |
| 58 | Kernel::SharedPtr<Kernel::ClientPort> client_port; | ||
| 59 | std::tie(server_port, client_port) = | ||
| 60 | Kernel::ServerPort::CreatePortPair(kernel, max_sessions, name); | 58 | Kernel::ServerPort::CreatePortPair(kernel, max_sessions, name); |
| 61 | 59 | ||
| 62 | registered_services.emplace(std::move(name), std::move(client_port)); | 60 | registered_services.emplace(std::move(name), std::move(client_port)); |
| 63 | return MakeResult<Kernel::SharedPtr<Kernel::ServerPort>>(std::move(server_port)); | 61 | return MakeResult(std::move(server_port)); |
| 64 | } | 62 | } |
| 65 | 63 | ||
| 66 | ResultCode ServiceManager::UnregisterService(const std::string& name) { | 64 | ResultCode ServiceManager::UnregisterService(const std::string& name) { |
| @@ -83,7 +81,7 @@ ResultVal<Kernel::SharedPtr<Kernel::ClientPort>> ServiceManager::GetServicePort( | |||
| 83 | return ERR_SERVICE_NOT_REGISTERED; | 81 | return ERR_SERVICE_NOT_REGISTERED; |
| 84 | } | 82 | } |
| 85 | 83 | ||
| 86 | return MakeResult<Kernel::SharedPtr<Kernel::ClientPort>>(it->second); | 84 | return MakeResult(it->second); |
| 87 | } | 85 | } |
| 88 | 86 | ||
| 89 | ResultVal<Kernel::SharedPtr<Kernel::ClientSession>> ServiceManager::ConnectToService( | 87 | ResultVal<Kernel::SharedPtr<Kernel::ClientSession>> ServiceManager::ConnectToService( |
diff --git a/src/core/loader/deconstructed_rom_directory.h b/src/core/loader/deconstructed_rom_directory.h index d109ed2b5..1615cb5a8 100644 --- a/src/core/loader/deconstructed_rom_directory.h +++ b/src/core/loader/deconstructed_rom_directory.h | |||
| @@ -33,7 +33,7 @@ public: | |||
| 33 | */ | 33 | */ |
| 34 | static FileType IdentifyType(const FileSys::VirtualFile& file); | 34 | static FileType IdentifyType(const FileSys::VirtualFile& file); |
| 35 | 35 | ||
| 36 | FileType GetFileType() override { | 36 | FileType GetFileType() const override { |
| 37 | return IdentifyType(file); | 37 | return IdentifyType(file); |
| 38 | } | 38 | } |
| 39 | 39 | ||
diff --git a/src/core/loader/elf.h b/src/core/loader/elf.h index 6af76441c..a2d33021c 100644 --- a/src/core/loader/elf.h +++ b/src/core/loader/elf.h | |||
| @@ -22,7 +22,7 @@ public: | |||
| 22 | */ | 22 | */ |
| 23 | static FileType IdentifyType(const FileSys::VirtualFile& file); | 23 | static FileType IdentifyType(const FileSys::VirtualFile& file); |
| 24 | 24 | ||
| 25 | FileType GetFileType() override { | 25 | FileType GetFileType() const override { |
| 26 | return IdentifyType(file); | 26 | return IdentifyType(file); |
| 27 | } | 27 | } |
| 28 | 28 | ||
diff --git a/src/core/loader/loader.h b/src/core/loader/loader.h index 7686634bf..5390ab9ee 100644 --- a/src/core/loader/loader.h +++ b/src/core/loader/loader.h | |||
| @@ -131,7 +131,7 @@ public: | |||
| 131 | * Returns the type of this file | 131 | * Returns the type of this file |
| 132 | * @return FileType corresponding to the loaded file | 132 | * @return FileType corresponding to the loaded file |
| 133 | */ | 133 | */ |
| 134 | virtual FileType GetFileType() = 0; | 134 | virtual FileType GetFileType() const = 0; |
| 135 | 135 | ||
| 136 | /** | 136 | /** |
| 137 | * Load the application and return the created Process instance | 137 | * Load the application and return the created Process instance |
diff --git a/src/core/loader/nax.cpp b/src/core/loader/nax.cpp index 42f4a777b..a093e3d36 100644 --- a/src/core/loader/nax.cpp +++ b/src/core/loader/nax.cpp | |||
| @@ -37,7 +37,7 @@ FileType AppLoader_NAX::IdentifyType(const FileSys::VirtualFile& file) { | |||
| 37 | return IdentifyTypeImpl(nax); | 37 | return IdentifyTypeImpl(nax); |
| 38 | } | 38 | } |
| 39 | 39 | ||
| 40 | FileType AppLoader_NAX::GetFileType() { | 40 | FileType AppLoader_NAX::GetFileType() const { |
| 41 | return IdentifyTypeImpl(*nax); | 41 | return IdentifyTypeImpl(*nax); |
| 42 | } | 42 | } |
| 43 | 43 | ||
diff --git a/src/core/loader/nax.h b/src/core/loader/nax.h index b4d93bd01..0a97511b8 100644 --- a/src/core/loader/nax.h +++ b/src/core/loader/nax.h | |||
| @@ -31,7 +31,7 @@ public: | |||
| 31 | */ | 31 | */ |
| 32 | static FileType IdentifyType(const FileSys::VirtualFile& file); | 32 | static FileType IdentifyType(const FileSys::VirtualFile& file); |
| 33 | 33 | ||
| 34 | FileType GetFileType() override; | 34 | FileType GetFileType() const override; |
| 35 | 35 | ||
| 36 | ResultStatus Load(Kernel::Process& process) override; | 36 | ResultStatus Load(Kernel::Process& process) override; |
| 37 | 37 | ||
diff --git a/src/core/loader/nca.h b/src/core/loader/nca.h index 95d9b73a1..cbbe701d2 100644 --- a/src/core/loader/nca.h +++ b/src/core/loader/nca.h | |||
| @@ -29,7 +29,7 @@ public: | |||
| 29 | */ | 29 | */ |
| 30 | static FileType IdentifyType(const FileSys::VirtualFile& file); | 30 | static FileType IdentifyType(const FileSys::VirtualFile& file); |
| 31 | 31 | ||
| 32 | FileType GetFileType() override { | 32 | FileType GetFileType() const override { |
| 33 | return IdentifyType(file); | 33 | return IdentifyType(file); |
| 34 | } | 34 | } |
| 35 | 35 | ||
diff --git a/src/core/loader/nro.h b/src/core/loader/nro.h index 6deff3a51..013d629c0 100644 --- a/src/core/loader/nro.h +++ b/src/core/loader/nro.h | |||
| @@ -33,7 +33,7 @@ public: | |||
| 33 | */ | 33 | */ |
| 34 | static FileType IdentifyType(const FileSys::VirtualFile& file); | 34 | static FileType IdentifyType(const FileSys::VirtualFile& file); |
| 35 | 35 | ||
| 36 | FileType GetFileType() override { | 36 | FileType GetFileType() const override { |
| 37 | return IdentifyType(file); | 37 | return IdentifyType(file); |
| 38 | } | 38 | } |
| 39 | 39 | ||
diff --git a/src/core/loader/nso.h b/src/core/loader/nso.h index 0c1defbb6..135b6ea5a 100644 --- a/src/core/loader/nso.h +++ b/src/core/loader/nso.h | |||
| @@ -37,7 +37,7 @@ public: | |||
| 37 | */ | 37 | */ |
| 38 | static FileType IdentifyType(const FileSys::VirtualFile& file); | 38 | static FileType IdentifyType(const FileSys::VirtualFile& file); |
| 39 | 39 | ||
| 40 | FileType GetFileType() override { | 40 | FileType GetFileType() const override { |
| 41 | return IdentifyType(file); | 41 | return IdentifyType(file); |
| 42 | } | 42 | } |
| 43 | 43 | ||
diff --git a/src/core/loader/nsp.h b/src/core/loader/nsp.h index db91cd01e..9ed8a59cf 100644 --- a/src/core/loader/nsp.h +++ b/src/core/loader/nsp.h | |||
| @@ -31,7 +31,7 @@ public: | |||
| 31 | */ | 31 | */ |
| 32 | static FileType IdentifyType(const FileSys::VirtualFile& file); | 32 | static FileType IdentifyType(const FileSys::VirtualFile& file); |
| 33 | 33 | ||
| 34 | FileType GetFileType() override { | 34 | FileType GetFileType() const override { |
| 35 | return IdentifyType(file); | 35 | return IdentifyType(file); |
| 36 | } | 36 | } |
| 37 | 37 | ||
diff --git a/src/core/loader/xci.h b/src/core/loader/xci.h index 46f8dfc9e..ded5bb88a 100644 --- a/src/core/loader/xci.h +++ b/src/core/loader/xci.h | |||
| @@ -31,7 +31,7 @@ public: | |||
| 31 | */ | 31 | */ |
| 32 | static FileType IdentifyType(const FileSys::VirtualFile& file); | 32 | static FileType IdentifyType(const FileSys::VirtualFile& file); |
| 33 | 33 | ||
| 34 | FileType GetFileType() override { | 34 | FileType GetFileType() const override { |
| 35 | return IdentifyType(file); | 35 | return IdentifyType(file); |
| 36 | } | 36 | } |
| 37 | 37 | ||
diff --git a/src/core/memory.cpp b/src/core/memory.cpp index 70abd856a..41fd2a6a0 100644 --- a/src/core/memory.cpp +++ b/src/core/memory.cpp | |||
| @@ -53,6 +53,14 @@ void PageTable::Resize(std::size_t address_space_width_in_bits) { | |||
| 53 | 53 | ||
| 54 | pointers.resize(num_page_table_entries); | 54 | pointers.resize(num_page_table_entries); |
| 55 | attributes.resize(num_page_table_entries); | 55 | attributes.resize(num_page_table_entries); |
| 56 | |||
| 57 | // The default is a 39-bit address space, which causes an initial 1GB allocation size. If the | ||
| 58 | // vector size is subsequently decreased (via resize), the vector might not automatically | ||
| 59 | // actually reallocate/resize its underlying allocation, which wastes up to ~800 MB for | ||
| 60 | // 36-bit titles. Call shrink_to_fit to reduce capacity to what's actually in use. | ||
| 61 | |||
| 62 | pointers.shrink_to_fit(); | ||
| 63 | attributes.shrink_to_fit(); | ||
| 56 | } | 64 | } |
| 57 | 65 | ||
| 58 | static void MapPages(PageTable& page_table, VAddr base, u64 size, u8* memory, PageType type) { | 66 | static void MapPages(PageTable& page_table, VAddr base, u64 size, u8* memory, PageType type) { |
diff --git a/src/video_core/engines/shader_bytecode.h b/src/video_core/engines/shader_bytecode.h index b9faaf8e0..5ea094e64 100644 --- a/src/video_core/engines/shader_bytecode.h +++ b/src/video_core/engines/shader_bytecode.h | |||
| @@ -1049,6 +1049,7 @@ union Instruction { | |||
| 1049 | BitField<49, 1, u64> nodep_flag; | 1049 | BitField<49, 1, u64> nodep_flag; |
| 1050 | BitField<50, 3, u64> component_mask_selector; | 1050 | BitField<50, 3, u64> component_mask_selector; |
| 1051 | BitField<53, 4, u64> texture_info; | 1051 | BitField<53, 4, u64> texture_info; |
| 1052 | BitField<60, 1, u64> fp32_flag; | ||
| 1052 | 1053 | ||
| 1053 | TextureType GetTextureType() const { | 1054 | TextureType GetTextureType() const { |
| 1054 | // The TEXS instruction has a weird encoding for the texture type. | 1055 | // The TEXS instruction has a weird encoding for the texture type. |
| @@ -1549,7 +1550,7 @@ private: | |||
| 1549 | INST("1110111011011---", Id::STG, Type::Memory, "STG"), | 1550 | INST("1110111011011---", Id::STG, Type::Memory, "STG"), |
| 1550 | INST("110000----111---", Id::TEX, Type::Memory, "TEX"), | 1551 | INST("110000----111---", Id::TEX, Type::Memory, "TEX"), |
| 1551 | INST("1101111101001---", Id::TXQ, Type::Memory, "TXQ"), | 1552 | INST("1101111101001---", Id::TXQ, Type::Memory, "TXQ"), |
| 1552 | INST("1101100---------", Id::TEXS, Type::Memory, "TEXS"), | 1553 | INST("1101-00---------", Id::TEXS, Type::Memory, "TEXS"), |
| 1553 | INST("1101101---------", Id::TLDS, Type::Memory, "TLDS"), | 1554 | INST("1101101---------", Id::TLDS, Type::Memory, "TLDS"), |
| 1554 | INST("110010----111---", Id::TLD4, Type::Memory, "TLD4"), | 1555 | INST("110010----111---", Id::TLD4, Type::Memory, "TLD4"), |
| 1555 | INST("1101111100------", Id::TLD4S, Type::Memory, "TLD4S"), | 1556 | INST("1101111100------", Id::TLD4S, Type::Memory, "TLD4S"), |
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.cpp b/src/video_core/renderer_opengl/gl_rasterizer.cpp index 9e93bd609..2b29fc45f 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.cpp +++ b/src/video_core/renderer_opengl/gl_rasterizer.cpp | |||
| @@ -79,6 +79,26 @@ struct DrawParameters { | |||
| 79 | } | 79 | } |
| 80 | }; | 80 | }; |
| 81 | 81 | ||
| 82 | struct FramebufferCacheKey { | ||
| 83 | bool is_single_buffer = false; | ||
| 84 | bool stencil_enable = false; | ||
| 85 | |||
| 86 | std::array<GLenum, Maxwell::NumRenderTargets> color_attachments{}; | ||
| 87 | std::array<GLuint, Tegra::Engines::Maxwell3D::Regs::NumRenderTargets> colors{}; | ||
| 88 | u32 colors_count = 0; | ||
| 89 | |||
| 90 | GLuint zeta = 0; | ||
| 91 | |||
| 92 | auto Tie() const { | ||
| 93 | return std::tie(is_single_buffer, stencil_enable, color_attachments, colors, colors_count, | ||
| 94 | zeta); | ||
| 95 | } | ||
| 96 | |||
| 97 | bool operator<(const FramebufferCacheKey& rhs) const { | ||
| 98 | return Tie() < rhs.Tie(); | ||
| 99 | } | ||
| 100 | }; | ||
| 101 | |||
| 82 | RasterizerOpenGL::RasterizerOpenGL(Core::Frontend::EmuWindow& window, ScreenInfo& info) | 102 | RasterizerOpenGL::RasterizerOpenGL(Core::Frontend::EmuWindow& window, ScreenInfo& info) |
| 83 | : res_cache{*this}, shader_cache{*this}, emu_window{window}, screen_info{info}, | 103 | : res_cache{*this}, shader_cache{*this}, emu_window{window}, screen_info{info}, |
| 84 | buffer_cache(*this, STREAM_BUFFER_SIZE) { | 104 | buffer_cache(*this, STREAM_BUFFER_SIZE) { |
| @@ -90,9 +110,6 @@ RasterizerOpenGL::RasterizerOpenGL(Core::Frontend::EmuWindow& window, ScreenInfo | |||
| 90 | 110 | ||
| 91 | OpenGLState::ApplyDefaultState(); | 111 | OpenGLState::ApplyDefaultState(); |
| 92 | 112 | ||
| 93 | // Create render framebuffer | ||
| 94 | framebuffer.Create(); | ||
| 95 | |||
| 96 | shader_program_manager = std::make_unique<GLShader::ProgramManager>(); | 113 | shader_program_manager = std::make_unique<GLShader::ProgramManager>(); |
| 97 | state.draw.shader_program = 0; | 114 | state.draw.shader_program = 0; |
| 98 | state.Apply(); | 115 | state.Apply(); |
| @@ -361,6 +378,44 @@ void RasterizerOpenGL::SetupShaders(GLenum primitive_mode) { | |||
| 361 | SyncClipEnabled(clip_distances); | 378 | SyncClipEnabled(clip_distances); |
| 362 | } | 379 | } |
| 363 | 380 | ||
| 381 | void RasterizerOpenGL::SetupCachedFramebuffer(const FramebufferCacheKey& fbkey, | ||
| 382 | OpenGLState& current_state) { | ||
| 383 | const auto [entry, is_cache_miss] = framebuffer_cache.try_emplace(fbkey); | ||
| 384 | auto& framebuffer = entry->second; | ||
| 385 | |||
| 386 | if (is_cache_miss) | ||
| 387 | framebuffer.Create(); | ||
| 388 | |||
| 389 | current_state.draw.draw_framebuffer = framebuffer.handle; | ||
| 390 | current_state.ApplyFramebufferState(); | ||
| 391 | |||
| 392 | if (!is_cache_miss) | ||
| 393 | return; | ||
| 394 | |||
| 395 | if (fbkey.is_single_buffer) { | ||
| 396 | if (fbkey.color_attachments[0] != GL_NONE) { | ||
| 397 | glFramebufferTexture(GL_DRAW_FRAMEBUFFER, fbkey.color_attachments[0], fbkey.colors[0], | ||
| 398 | 0); | ||
| 399 | } | ||
| 400 | glDrawBuffer(fbkey.color_attachments[0]); | ||
| 401 | } else { | ||
| 402 | for (std::size_t index = 0; index < Maxwell::NumRenderTargets; ++index) { | ||
| 403 | if (fbkey.colors[index]) { | ||
| 404 | glFramebufferTexture(GL_DRAW_FRAMEBUFFER, | ||
| 405 | GL_COLOR_ATTACHMENT0 + static_cast<GLenum>(index), | ||
| 406 | fbkey.colors[index], 0); | ||
| 407 | } | ||
| 408 | } | ||
| 409 | glDrawBuffers(fbkey.colors_count, fbkey.color_attachments.data()); | ||
| 410 | } | ||
| 411 | |||
| 412 | if (fbkey.zeta) { | ||
| 413 | GLenum zeta_attachment = | ||
| 414 | fbkey.stencil_enable ? GL_DEPTH_STENCIL_ATTACHMENT : GL_DEPTH_ATTACHMENT; | ||
| 415 | glFramebufferTexture(GL_DRAW_FRAMEBUFFER, zeta_attachment, fbkey.zeta, 0); | ||
| 416 | } | ||
| 417 | } | ||
| 418 | |||
| 364 | std::size_t RasterizerOpenGL::CalculateVertexArraysSize() const { | 419 | std::size_t RasterizerOpenGL::CalculateVertexArraysSize() const { |
| 365 | const auto& regs = Core::System::GetInstance().GPU().Maxwell3D().regs; | 420 | const auto& regs = Core::System::GetInstance().GPU().Maxwell3D().regs; |
| 366 | 421 | ||
| @@ -444,10 +499,10 @@ void RasterizerOpenGL::ConfigureFramebuffers(OpenGLState& current_state, bool us | |||
| 444 | UNIMPLEMENTED_IF(regs.rt_separate_frag_data != 0); | 499 | UNIMPLEMENTED_IF(regs.rt_separate_frag_data != 0); |
| 445 | 500 | ||
| 446 | // Bind the framebuffer surfaces | 501 | // Bind the framebuffer surfaces |
| 447 | current_state.draw.draw_framebuffer = framebuffer.handle; | ||
| 448 | current_state.ApplyFramebufferState(); | ||
| 449 | current_state.framebuffer_srgb.enabled = regs.framebuffer_srgb != 0; | 502 | current_state.framebuffer_srgb.enabled = regs.framebuffer_srgb != 0; |
| 450 | 503 | ||
| 504 | FramebufferCacheKey fbkey; | ||
| 505 | |||
| 451 | if (using_color_fb) { | 506 | if (using_color_fb) { |
| 452 | if (single_color_target) { | 507 | if (single_color_target) { |
| 453 | // Used when just a single color attachment is enabled, e.g. for clearing a color buffer | 508 | // Used when just a single color attachment is enabled, e.g. for clearing a color buffer |
| @@ -463,14 +518,12 @@ void RasterizerOpenGL::ConfigureFramebuffers(OpenGLState& current_state, bool us | |||
| 463 | state.framebuffer_srgb.enabled |= color_surface->GetSurfaceParams().srgb_conversion; | 518 | state.framebuffer_srgb.enabled |= color_surface->GetSurfaceParams().srgb_conversion; |
| 464 | } | 519 | } |
| 465 | 520 | ||
| 466 | glFramebufferTexture2D( | 521 | fbkey.is_single_buffer = true; |
| 467 | GL_DRAW_FRAMEBUFFER, | 522 | fbkey.color_attachments[0] = |
| 468 | GL_COLOR_ATTACHMENT0 + static_cast<GLenum>(*single_color_target), GL_TEXTURE_2D, | 523 | GL_COLOR_ATTACHMENT0 + static_cast<GLenum>(*single_color_target); |
| 469 | color_surface != nullptr ? color_surface->Texture().handle : 0, 0); | 524 | fbkey.colors[0] = color_surface != nullptr ? color_surface->Texture().handle : 0; |
| 470 | glDrawBuffer(GL_COLOR_ATTACHMENT0 + static_cast<GLenum>(*single_color_target)); | ||
| 471 | } else { | 525 | } else { |
| 472 | // Multiple color attachments are enabled | 526 | // Multiple color attachments are enabled |
| 473 | std::array<GLenum, Maxwell::NumRenderTargets> buffers; | ||
| 474 | for (std::size_t index = 0; index < Maxwell::NumRenderTargets; ++index) { | 527 | for (std::size_t index = 0; index < Maxwell::NumRenderTargets; ++index) { |
| 475 | Surface color_surface = res_cache.GetColorBufferSurface(index, preserve_contents); | 528 | Surface color_surface = res_cache.GetColorBufferSurface(index, preserve_contents); |
| 476 | 529 | ||
| @@ -485,22 +538,17 @@ void RasterizerOpenGL::ConfigureFramebuffers(OpenGLState& current_state, bool us | |||
| 485 | color_surface->GetSurfaceParams().srgb_conversion; | 538 | color_surface->GetSurfaceParams().srgb_conversion; |
| 486 | } | 539 | } |
| 487 | 540 | ||
| 488 | buffers[index] = GL_COLOR_ATTACHMENT0 + regs.rt_control.GetMap(index); | 541 | fbkey.color_attachments[index] = |
| 489 | glFramebufferTexture2D( | 542 | GL_COLOR_ATTACHMENT0 + regs.rt_control.GetMap(index); |
| 490 | GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT0 + static_cast<GLenum>(index), | 543 | fbkey.colors[index] = |
| 491 | GL_TEXTURE_2D, color_surface != nullptr ? color_surface->Texture().handle : 0, | 544 | color_surface != nullptr ? color_surface->Texture().handle : 0; |
| 492 | 0); | ||
| 493 | } | 545 | } |
| 494 | glDrawBuffers(regs.rt_control.count, buffers.data()); | 546 | fbkey.is_single_buffer = false; |
| 547 | fbkey.colors_count = regs.rt_control.count; | ||
| 495 | } | 548 | } |
| 496 | } else { | 549 | } else { |
| 497 | // No color attachments are enabled - zero out all of them | 550 | // No color attachments are enabled - leave them as zero |
| 498 | for (std::size_t index = 0; index < Maxwell::NumRenderTargets; ++index) { | 551 | fbkey.is_single_buffer = true; |
| 499 | glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, | ||
| 500 | GL_COLOR_ATTACHMENT0 + static_cast<GLenum>(index), GL_TEXTURE_2D, | ||
| 501 | 0, 0); | ||
| 502 | } | ||
| 503 | glDrawBuffer(GL_NONE); | ||
| 504 | } | 552 | } |
| 505 | 553 | ||
| 506 | if (depth_surface) { | 554 | if (depth_surface) { |
| @@ -508,22 +556,12 @@ void RasterizerOpenGL::ConfigureFramebuffers(OpenGLState& current_state, bool us | |||
| 508 | // the shader doesn't actually write to it. | 556 | // the shader doesn't actually write to it. |
| 509 | depth_surface->MarkAsModified(true, res_cache); | 557 | depth_surface->MarkAsModified(true, res_cache); |
| 510 | 558 | ||
| 511 | if (regs.stencil_enable) { | 559 | fbkey.zeta = depth_surface->Texture().handle; |
| 512 | // Attach both depth and stencil | 560 | fbkey.stencil_enable = regs.stencil_enable; |
| 513 | glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_DEPTH_STENCIL_ATTACHMENT, GL_TEXTURE_2D, | ||
| 514 | depth_surface->Texture().handle, 0); | ||
| 515 | } else { | ||
| 516 | // Attach depth | ||
| 517 | glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_TEXTURE_2D, | ||
| 518 | depth_surface->Texture().handle, 0); | ||
| 519 | // Clear stencil attachment | ||
| 520 | glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_STENCIL_ATTACHMENT, GL_TEXTURE_2D, 0, 0); | ||
| 521 | } | ||
| 522 | } else { | ||
| 523 | // Clear both depth and stencil attachment | ||
| 524 | glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_DEPTH_STENCIL_ATTACHMENT, GL_TEXTURE_2D, 0, | ||
| 525 | 0); | ||
| 526 | } | 561 | } |
| 562 | |||
| 563 | SetupCachedFramebuffer(fbkey, current_state); | ||
| 564 | |||
| 527 | SyncViewport(current_state); | 565 | SyncViewport(current_state); |
| 528 | } | 566 | } |
| 529 | 567 | ||
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.h b/src/video_core/renderer_opengl/gl_rasterizer.h index 988fa3e27..8a891ffc7 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.h +++ b/src/video_core/renderer_opengl/gl_rasterizer.h | |||
| @@ -40,6 +40,7 @@ namespace OpenGL { | |||
| 40 | 40 | ||
| 41 | struct ScreenInfo; | 41 | struct ScreenInfo; |
| 42 | struct DrawParameters; | 42 | struct DrawParameters; |
| 43 | struct FramebufferCacheKey; | ||
| 43 | 44 | ||
| 44 | class RasterizerOpenGL : public VideoCore::RasterizerInterface { | 45 | class RasterizerOpenGL : public VideoCore::RasterizerInterface { |
| 45 | public: | 46 | public: |
| @@ -195,11 +196,12 @@ private: | |||
| 195 | OGLVertexArray> | 196 | OGLVertexArray> |
| 196 | vertex_array_cache; | 197 | vertex_array_cache; |
| 197 | 198 | ||
| 199 | std::map<FramebufferCacheKey, OGLFramebuffer> framebuffer_cache; | ||
| 200 | |||
| 198 | std::array<SamplerInfo, Tegra::Engines::Maxwell3D::Regs::NumTextureSamplers> texture_samplers; | 201 | std::array<SamplerInfo, Tegra::Engines::Maxwell3D::Regs::NumTextureSamplers> texture_samplers; |
| 199 | 202 | ||
| 200 | static constexpr std::size_t STREAM_BUFFER_SIZE = 128 * 1024 * 1024; | 203 | static constexpr std::size_t STREAM_BUFFER_SIZE = 128 * 1024 * 1024; |
| 201 | OGLBufferCache buffer_cache; | 204 | OGLBufferCache buffer_cache; |
| 202 | OGLFramebuffer framebuffer; | ||
| 203 | PrimitiveAssembler primitive_assembler{buffer_cache}; | 205 | PrimitiveAssembler primitive_assembler{buffer_cache}; |
| 204 | GLint uniform_buffer_alignment; | 206 | GLint uniform_buffer_alignment; |
| 205 | 207 | ||
| @@ -214,6 +216,8 @@ private: | |||
| 214 | 216 | ||
| 215 | void SetupShaders(GLenum primitive_mode); | 217 | void SetupShaders(GLenum primitive_mode); |
| 216 | 218 | ||
| 219 | void SetupCachedFramebuffer(const FramebufferCacheKey& fbkey, OpenGLState& current_state); | ||
| 220 | |||
| 217 | enum class AccelDraw { Disabled, Arrays, Indexed }; | 221 | enum class AccelDraw { Disabled, Arrays, Indexed }; |
| 218 | AccelDraw accelerate_draw = AccelDraw::Disabled; | 222 | AccelDraw accelerate_draw = AccelDraw::Disabled; |
| 219 | 223 | ||
diff --git a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp index 8d68156bf..4fc09cac6 100644 --- a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp +++ b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp | |||
| @@ -50,6 +50,14 @@ public: | |||
| 50 | using std::runtime_error::runtime_error; | 50 | using std::runtime_error::runtime_error; |
| 51 | }; | 51 | }; |
| 52 | 52 | ||
| 53 | /// Generates code to use for a swizzle operation. | ||
| 54 | static std::string GetSwizzle(u64 elem) { | ||
| 55 | ASSERT(elem <= 3); | ||
| 56 | std::string swizzle = "."; | ||
| 57 | swizzle += "xyzw"[elem]; | ||
| 58 | return swizzle; | ||
| 59 | } | ||
| 60 | |||
| 53 | /// Translate topology | 61 | /// Translate topology |
| 54 | static std::string GetTopologyName(Tegra::Shader::OutputTopology topology) { | 62 | static std::string GetTopologyName(Tegra::Shader::OutputTopology topology) { |
| 55 | switch (topology) { | 63 | switch (topology) { |
| @@ -1004,14 +1012,6 @@ private: | |||
| 1004 | } | 1012 | } |
| 1005 | } | 1013 | } |
| 1006 | 1014 | ||
| 1007 | /// Generates code to use for a swizzle operation. | ||
| 1008 | static std::string GetSwizzle(u64 elem) { | ||
| 1009 | ASSERT(elem <= 3); | ||
| 1010 | std::string swizzle = "."; | ||
| 1011 | swizzle += "xyzw"[elem]; | ||
| 1012 | return swizzle; | ||
| 1013 | } | ||
| 1014 | |||
| 1015 | ShaderWriter& shader; | 1015 | ShaderWriter& shader; |
| 1016 | ShaderWriter& declarations; | 1016 | ShaderWriter& declarations; |
| 1017 | std::vector<GLSLRegister> regs; | 1017 | std::vector<GLSLRegister> regs; |
| @@ -1343,7 +1343,7 @@ private: | |||
| 1343 | regs.SetRegisterToInteger(dest, true, 0, result, 1, 1); | 1343 | regs.SetRegisterToInteger(dest, true, 0, result, 1, 1); |
| 1344 | } | 1344 | } |
| 1345 | 1345 | ||
| 1346 | void WriteTexsInstruction(const Instruction& instr, const std::string& texture) { | 1346 | void WriteTexsInstructionFloat(const Instruction& instr, const std::string& texture) { |
| 1347 | // TEXS has two destination registers and a swizzle. The first two elements in the swizzle | 1347 | // TEXS has two destination registers and a swizzle. The first two elements in the swizzle |
| 1348 | // go into gpr0+0 and gpr0+1, and the rest goes into gpr28+0 and gpr28+1 | 1348 | // go into gpr0+0 and gpr0+1, and the rest goes into gpr28+0 and gpr28+1 |
| 1349 | 1349 | ||
| @@ -1368,6 +1368,38 @@ private: | |||
| 1368 | } | 1368 | } |
| 1369 | } | 1369 | } |
| 1370 | 1370 | ||
| 1371 | void WriteTexsInstructionHalfFloat(const Instruction& instr, const std::string& texture) { | ||
| 1372 | // TEXS.F16 destionation registers are packed in two registers in pairs (just like any half | ||
| 1373 | // float instruction). | ||
| 1374 | |||
| 1375 | std::array<std::string, 4> components; | ||
| 1376 | u32 written_components = 0; | ||
| 1377 | |||
| 1378 | for (u32 component = 0; component < 4; ++component) { | ||
| 1379 | if (!instr.texs.IsComponentEnabled(component)) | ||
| 1380 | continue; | ||
| 1381 | components[written_components++] = texture + GetSwizzle(component); | ||
| 1382 | } | ||
| 1383 | if (written_components == 0) | ||
| 1384 | return; | ||
| 1385 | |||
| 1386 | const auto BuildComponent = [&](std::string low, std::string high, bool high_enabled) { | ||
| 1387 | return "vec2(" + low + ", " + (high_enabled ? high : "0") + ')'; | ||
| 1388 | }; | ||
| 1389 | |||
| 1390 | regs.SetRegisterToHalfFloat( | ||
| 1391 | instr.gpr0, 0, BuildComponent(components[0], components[1], written_components > 1), | ||
| 1392 | Tegra::Shader::HalfMerge::H0_H1, 1, 1); | ||
| 1393 | |||
| 1394 | if (written_components > 2) { | ||
| 1395 | ASSERT(instr.texs.HasTwoDestinations()); | ||
| 1396 | regs.SetRegisterToHalfFloat( | ||
| 1397 | instr.gpr28, 0, | ||
| 1398 | BuildComponent(components[2], components[3], written_components > 3), | ||
| 1399 | Tegra::Shader::HalfMerge::H0_H1, 1, 1); | ||
| 1400 | } | ||
| 1401 | } | ||
| 1402 | |||
| 1371 | static u32 TextureCoordinates(Tegra::Shader::TextureType texture_type) { | 1403 | static u32 TextureCoordinates(Tegra::Shader::TextureType texture_type) { |
| 1372 | switch (texture_type) { | 1404 | switch (texture_type) { |
| 1373 | case Tegra::Shader::TextureType::Texture1D: | 1405 | case Tegra::Shader::TextureType::Texture1D: |
| @@ -2766,24 +2798,27 @@ private: | |||
| 2766 | const bool depth_compare = | 2798 | const bool depth_compare = |
| 2767 | instr.texs.UsesMiscMode(Tegra::Shader::TextureMiscMode::DC); | 2799 | instr.texs.UsesMiscMode(Tegra::Shader::TextureMiscMode::DC); |
| 2768 | const auto process_mode = instr.texs.GetTextureProcessMode(); | 2800 | const auto process_mode = instr.texs.GetTextureProcessMode(); |
| 2801 | |||
| 2769 | UNIMPLEMENTED_IF_MSG(instr.texs.UsesMiscMode(Tegra::Shader::TextureMiscMode::NODEP), | 2802 | UNIMPLEMENTED_IF_MSG(instr.texs.UsesMiscMode(Tegra::Shader::TextureMiscMode::NODEP), |
| 2770 | "NODEP is not implemented"); | 2803 | "NODEP is not implemented"); |
| 2771 | 2804 | ||
| 2772 | const auto scope = shader.Scope(); | 2805 | const auto scope = shader.Scope(); |
| 2773 | 2806 | ||
| 2774 | const auto [coord, texture] = | 2807 | auto [coord, texture] = |
| 2775 | GetTEXSCode(instr, texture_type, process_mode, depth_compare, is_array); | 2808 | GetTEXSCode(instr, texture_type, process_mode, depth_compare, is_array); |
| 2776 | 2809 | ||
| 2777 | shader.AddLine(coord); | 2810 | shader.AddLine(coord); |
| 2778 | 2811 | ||
| 2779 | if (!depth_compare) { | 2812 | if (depth_compare) { |
| 2780 | shader.AddLine("vec4 texture_tmp = " + texture + ';'); | 2813 | texture = "vec4(" + texture + ')'; |
| 2814 | } | ||
| 2815 | shader.AddLine("vec4 texture_tmp = " + texture + ';'); | ||
| 2781 | 2816 | ||
| 2817 | if (instr.texs.fp32_flag) { | ||
| 2818 | WriteTexsInstructionFloat(instr, "texture_tmp"); | ||
| 2782 | } else { | 2819 | } else { |
| 2783 | shader.AddLine("vec4 texture_tmp = vec4(" + texture + ");"); | 2820 | WriteTexsInstructionHalfFloat(instr, "texture_tmp"); |
| 2784 | } | 2821 | } |
| 2785 | |||
| 2786 | WriteTexsInstruction(instr, "texture_tmp"); | ||
| 2787 | break; | 2822 | break; |
| 2788 | } | 2823 | } |
| 2789 | case OpCode::Id::TLDS: { | 2824 | case OpCode::Id::TLDS: { |
| @@ -2842,7 +2877,7 @@ private: | |||
| 2842 | } | 2877 | } |
| 2843 | }(); | 2878 | }(); |
| 2844 | 2879 | ||
| 2845 | WriteTexsInstruction(instr, texture); | 2880 | WriteTexsInstructionFloat(instr, texture); |
| 2846 | break; | 2881 | break; |
| 2847 | } | 2882 | } |
| 2848 | case OpCode::Id::TLD4: { | 2883 | case OpCode::Id::TLD4: { |
| @@ -2940,7 +2975,8 @@ private: | |||
| 2940 | if (depth_compare) { | 2975 | if (depth_compare) { |
| 2941 | texture = "vec4(" + texture + ')'; | 2976 | texture = "vec4(" + texture + ')'; |
| 2942 | } | 2977 | } |
| 2943 | WriteTexsInstruction(instr, texture); | 2978 | |
| 2979 | WriteTexsInstructionFloat(instr, texture); | ||
| 2944 | break; | 2980 | break; |
| 2945 | } | 2981 | } |
| 2946 | case OpCode::Id::TXQ: { | 2982 | case OpCode::Id::TXQ: { |
diff --git a/src/video_core/surface.h b/src/video_core/surface.h index 0dd3eb2e4..e23cfecbc 100644 --- a/src/video_core/surface.h +++ b/src/video_core/surface.h | |||
| @@ -125,6 +125,75 @@ enum class SurfaceTarget { | |||
| 125 | TextureCubeArray, | 125 | TextureCubeArray, |
| 126 | }; | 126 | }; |
| 127 | 127 | ||
| 128 | constexpr std::array<u32, MaxPixelFormat> compression_factor_table = {{ | ||
| 129 | 1, // ABGR8U | ||
| 130 | 1, // ABGR8S | ||
| 131 | 1, // ABGR8UI | ||
| 132 | 1, // B5G6R5U | ||
| 133 | 1, // A2B10G10R10U | ||
| 134 | 1, // A1B5G5R5U | ||
| 135 | 1, // R8U | ||
| 136 | 1, // R8UI | ||
| 137 | 1, // RGBA16F | ||
| 138 | 1, // RGBA16U | ||
| 139 | 1, // RGBA16UI | ||
| 140 | 1, // R11FG11FB10F | ||
| 141 | 1, // RGBA32UI | ||
| 142 | 4, // DXT1 | ||
| 143 | 4, // DXT23 | ||
| 144 | 4, // DXT45 | ||
| 145 | 4, // DXN1 | ||
| 146 | 4, // DXN2UNORM | ||
| 147 | 4, // DXN2SNORM | ||
| 148 | 4, // BC7U | ||
| 149 | 4, // BC6H_UF16 | ||
| 150 | 4, // BC6H_SF16 | ||
| 151 | 4, // ASTC_2D_4X4 | ||
| 152 | 1, // G8R8U | ||
| 153 | 1, // G8R8S | ||
| 154 | 1, // BGRA8 | ||
| 155 | 1, // RGBA32F | ||
| 156 | 1, // RG32F | ||
| 157 | 1, // R32F | ||
| 158 | 1, // R16F | ||
| 159 | 1, // R16U | ||
| 160 | 1, // R16S | ||
| 161 | 1, // R16UI | ||
| 162 | 1, // R16I | ||
| 163 | 1, // RG16 | ||
| 164 | 1, // RG16F | ||
| 165 | 1, // RG16UI | ||
| 166 | 1, // RG16I | ||
| 167 | 1, // RG16S | ||
| 168 | 1, // RGB32F | ||
| 169 | 1, // RGBA8_SRGB | ||
| 170 | 1, // RG8U | ||
| 171 | 1, // RG8S | ||
| 172 | 1, // RG32UI | ||
| 173 | 1, // R32UI | ||
| 174 | 4, // ASTC_2D_8X8 | ||
| 175 | 4, // ASTC_2D_8X5 | ||
| 176 | 4, // ASTC_2D_5X4 | ||
| 177 | 1, // BGRA8_SRGB | ||
| 178 | 4, // DXT1_SRGB | ||
| 179 | 4, // DXT23_SRGB | ||
| 180 | 4, // DXT45_SRGB | ||
| 181 | 4, // BC7U_SRGB | ||
| 182 | 4, // ASTC_2D_4X4_SRGB | ||
| 183 | 4, // ASTC_2D_8X8_SRGB | ||
| 184 | 4, // ASTC_2D_8X5_SRGB | ||
| 185 | 4, // ASTC_2D_5X4_SRGB | ||
| 186 | 4, // ASTC_2D_5X5 | ||
| 187 | 4, // ASTC_2D_5X5_SRGB | ||
| 188 | 4, // ASTC_2D_10X8 | ||
| 189 | 4, // ASTC_2D_10X8_SRGB | ||
| 190 | 1, // Z32F | ||
| 191 | 1, // Z16 | ||
| 192 | 1, // Z24S8 | ||
| 193 | 1, // S8Z24 | ||
| 194 | 1, // Z32FS8 | ||
| 195 | }}; | ||
| 196 | |||
| 128 | /** | 197 | /** |
| 129 | * Gets the compression factor for the specified PixelFormat. This applies to just the | 198 | * Gets the compression factor for the specified PixelFormat. This applies to just the |
| 130 | * "compressed width" and "compressed height", not the overall compression factor of a | 199 | * "compressed width" and "compressed height", not the overall compression factor of a |
| @@ -135,304 +204,237 @@ static constexpr u32 GetCompressionFactor(PixelFormat format) { | |||
| 135 | if (format == PixelFormat::Invalid) | 204 | if (format == PixelFormat::Invalid) |
| 136 | return 0; | 205 | return 0; |
| 137 | 206 | ||
| 138 | constexpr std::array<u32, MaxPixelFormat> compression_factor_table = {{ | ||
| 139 | 1, // ABGR8U | ||
| 140 | 1, // ABGR8S | ||
| 141 | 1, // ABGR8UI | ||
| 142 | 1, // B5G6R5U | ||
| 143 | 1, // A2B10G10R10U | ||
| 144 | 1, // A1B5G5R5U | ||
| 145 | 1, // R8U | ||
| 146 | 1, // R8UI | ||
| 147 | 1, // RGBA16F | ||
| 148 | 1, // RGBA16U | ||
| 149 | 1, // RGBA16UI | ||
| 150 | 1, // R11FG11FB10F | ||
| 151 | 1, // RGBA32UI | ||
| 152 | 4, // DXT1 | ||
| 153 | 4, // DXT23 | ||
| 154 | 4, // DXT45 | ||
| 155 | 4, // DXN1 | ||
| 156 | 4, // DXN2UNORM | ||
| 157 | 4, // DXN2SNORM | ||
| 158 | 4, // BC7U | ||
| 159 | 4, // BC6H_UF16 | ||
| 160 | 4, // BC6H_SF16 | ||
| 161 | 4, // ASTC_2D_4X4 | ||
| 162 | 1, // G8R8U | ||
| 163 | 1, // G8R8S | ||
| 164 | 1, // BGRA8 | ||
| 165 | 1, // RGBA32F | ||
| 166 | 1, // RG32F | ||
| 167 | 1, // R32F | ||
| 168 | 1, // R16F | ||
| 169 | 1, // R16U | ||
| 170 | 1, // R16S | ||
| 171 | 1, // R16UI | ||
| 172 | 1, // R16I | ||
| 173 | 1, // RG16 | ||
| 174 | 1, // RG16F | ||
| 175 | 1, // RG16UI | ||
| 176 | 1, // RG16I | ||
| 177 | 1, // RG16S | ||
| 178 | 1, // RGB32F | ||
| 179 | 1, // RGBA8_SRGB | ||
| 180 | 1, // RG8U | ||
| 181 | 1, // RG8S | ||
| 182 | 1, // RG32UI | ||
| 183 | 1, // R32UI | ||
| 184 | 4, // ASTC_2D_8X8 | ||
| 185 | 4, // ASTC_2D_8X5 | ||
| 186 | 4, // ASTC_2D_5X4 | ||
| 187 | 1, // BGRA8_SRGB | ||
| 188 | 4, // DXT1_SRGB | ||
| 189 | 4, // DXT23_SRGB | ||
| 190 | 4, // DXT45_SRGB | ||
| 191 | 4, // BC7U_SRGB | ||
| 192 | 4, // ASTC_2D_4X4_SRGB | ||
| 193 | 4, // ASTC_2D_8X8_SRGB | ||
| 194 | 4, // ASTC_2D_8X5_SRGB | ||
| 195 | 4, // ASTC_2D_5X4_SRGB | ||
| 196 | 4, // ASTC_2D_5X5 | ||
| 197 | 4, // ASTC_2D_5X5_SRGB | ||
| 198 | 4, // ASTC_2D_10X8 | ||
| 199 | 4, // ASTC_2D_10X8_SRGB | ||
| 200 | 1, // Z32F | ||
| 201 | 1, // Z16 | ||
| 202 | 1, // Z24S8 | ||
| 203 | 1, // S8Z24 | ||
| 204 | 1, // Z32FS8 | ||
| 205 | }}; | ||
| 206 | |||
| 207 | ASSERT(static_cast<std::size_t>(format) < compression_factor_table.size()); | 207 | ASSERT(static_cast<std::size_t>(format) < compression_factor_table.size()); |
| 208 | return compression_factor_table[static_cast<std::size_t>(format)]; | 208 | return compression_factor_table[static_cast<std::size_t>(format)]; |
| 209 | } | 209 | } |
| 210 | 210 | ||
| 211 | constexpr std::array<u32, MaxPixelFormat> block_width_table = {{ | ||
| 212 | 1, // ABGR8U | ||
| 213 | 1, // ABGR8S | ||
| 214 | 1, // ABGR8UI | ||
| 215 | 1, // B5G6R5U | ||
| 216 | 1, // A2B10G10R10U | ||
| 217 | 1, // A1B5G5R5U | ||
| 218 | 1, // R8U | ||
| 219 | 1, // R8UI | ||
| 220 | 1, // RGBA16F | ||
| 221 | 1, // RGBA16U | ||
| 222 | 1, // RGBA16UI | ||
| 223 | 1, // R11FG11FB10F | ||
| 224 | 1, // RGBA32UI | ||
| 225 | 4, // DXT1 | ||
| 226 | 4, // DXT23 | ||
| 227 | 4, // DXT45 | ||
| 228 | 4, // DXN1 | ||
| 229 | 4, // DXN2UNORM | ||
| 230 | 4, // DXN2SNORM | ||
| 231 | 4, // BC7U | ||
| 232 | 4, // BC6H_UF16 | ||
| 233 | 4, // BC6H_SF16 | ||
| 234 | 4, // ASTC_2D_4X4 | ||
| 235 | 1, // G8R8U | ||
| 236 | 1, // G8R8S | ||
| 237 | 1, // BGRA8 | ||
| 238 | 1, // RGBA32F | ||
| 239 | 1, // RG32F | ||
| 240 | 1, // R32F | ||
| 241 | 1, // R16F | ||
| 242 | 1, // R16U | ||
| 243 | 1, // R16S | ||
| 244 | 1, // R16UI | ||
| 245 | 1, // R16I | ||
| 246 | 1, // RG16 | ||
| 247 | 1, // RG16F | ||
| 248 | 1, // RG16UI | ||
| 249 | 1, // RG16I | ||
| 250 | 1, // RG16S | ||
| 251 | 1, // RGB32F | ||
| 252 | 1, // RGBA8_SRGB | ||
| 253 | 1, // RG8U | ||
| 254 | 1, // RG8S | ||
| 255 | 1, // RG32UI | ||
| 256 | 1, // R32UI | ||
| 257 | 8, // ASTC_2D_8X8 | ||
| 258 | 8, // ASTC_2D_8X5 | ||
| 259 | 5, // ASTC_2D_5X4 | ||
| 260 | 1, // BGRA8_SRGB | ||
| 261 | 4, // DXT1_SRGB | ||
| 262 | 4, // DXT23_SRGB | ||
| 263 | 4, // DXT45_SRGB | ||
| 264 | 4, // BC7U_SRGB | ||
| 265 | 4, // ASTC_2D_4X4_SRGB | ||
| 266 | 8, // ASTC_2D_8X8_SRGB | ||
| 267 | 8, // ASTC_2D_8X5_SRGB | ||
| 268 | 5, // ASTC_2D_5X4_SRGB | ||
| 269 | 5, // ASTC_2D_5X5 | ||
| 270 | 5, // ASTC_2D_5X5_SRGB | ||
| 271 | 10, // ASTC_2D_10X8 | ||
| 272 | 10, // ASTC_2D_10X8_SRGB | ||
| 273 | 1, // Z32F | ||
| 274 | 1, // Z16 | ||
| 275 | 1, // Z24S8 | ||
| 276 | 1, // S8Z24 | ||
| 277 | 1, // Z32FS8 | ||
| 278 | }}; | ||
| 279 | |||
| 211 | static constexpr u32 GetDefaultBlockWidth(PixelFormat format) { | 280 | static constexpr u32 GetDefaultBlockWidth(PixelFormat format) { |
| 212 | if (format == PixelFormat::Invalid) | 281 | if (format == PixelFormat::Invalid) |
| 213 | return 0; | 282 | return 0; |
| 214 | constexpr std::array<u32, MaxPixelFormat> block_width_table = {{ | 283 | |
| 215 | 1, // ABGR8U | ||
| 216 | 1, // ABGR8S | ||
| 217 | 1, // ABGR8UI | ||
| 218 | 1, // B5G6R5U | ||
| 219 | 1, // A2B10G10R10U | ||
| 220 | 1, // A1B5G5R5U | ||
| 221 | 1, // R8U | ||
| 222 | 1, // R8UI | ||
| 223 | 1, // RGBA16F | ||
| 224 | 1, // RGBA16U | ||
| 225 | 1, // RGBA16UI | ||
| 226 | 1, // R11FG11FB10F | ||
| 227 | 1, // RGBA32UI | ||
| 228 | 4, // DXT1 | ||
| 229 | 4, // DXT23 | ||
| 230 | 4, // DXT45 | ||
| 231 | 4, // DXN1 | ||
| 232 | 4, // DXN2UNORM | ||
| 233 | 4, // DXN2SNORM | ||
| 234 | 4, // BC7U | ||
| 235 | 4, // BC6H_UF16 | ||
| 236 | 4, // BC6H_SF16 | ||
| 237 | 4, // ASTC_2D_4X4 | ||
| 238 | 1, // G8R8U | ||
| 239 | 1, // G8R8S | ||
| 240 | 1, // BGRA8 | ||
| 241 | 1, // RGBA32F | ||
| 242 | 1, // RG32F | ||
| 243 | 1, // R32F | ||
| 244 | 1, // R16F | ||
| 245 | 1, // R16U | ||
| 246 | 1, // R16S | ||
| 247 | 1, // R16UI | ||
| 248 | 1, // R16I | ||
| 249 | 1, // RG16 | ||
| 250 | 1, // RG16F | ||
| 251 | 1, // RG16UI | ||
| 252 | 1, // RG16I | ||
| 253 | 1, // RG16S | ||
| 254 | 1, // RGB32F | ||
| 255 | 1, // RGBA8_SRGB | ||
| 256 | 1, // RG8U | ||
| 257 | 1, // RG8S | ||
| 258 | 1, // RG32UI | ||
| 259 | 1, // R32UI | ||
| 260 | 8, // ASTC_2D_8X8 | ||
| 261 | 8, // ASTC_2D_8X5 | ||
| 262 | 5, // ASTC_2D_5X4 | ||
| 263 | 1, // BGRA8_SRGB | ||
| 264 | 4, // DXT1_SRGB | ||
| 265 | 4, // DXT23_SRGB | ||
| 266 | 4, // DXT45_SRGB | ||
| 267 | 4, // BC7U_SRGB | ||
| 268 | 4, // ASTC_2D_4X4_SRGB | ||
| 269 | 8, // ASTC_2D_8X8_SRGB | ||
| 270 | 8, // ASTC_2D_8X5_SRGB | ||
| 271 | 5, // ASTC_2D_5X4_SRGB | ||
| 272 | 5, // ASTC_2D_5X5 | ||
| 273 | 5, // ASTC_2D_5X5_SRGB | ||
| 274 | 10, // ASTC_2D_10X8 | ||
| 275 | 10, // ASTC_2D_10X8_SRGB | ||
| 276 | 1, // Z32F | ||
| 277 | 1, // Z16 | ||
| 278 | 1, // Z24S8 | ||
| 279 | 1, // S8Z24 | ||
| 280 | 1, // Z32FS8 | ||
| 281 | }}; | ||
| 282 | ASSERT(static_cast<std::size_t>(format) < block_width_table.size()); | 284 | ASSERT(static_cast<std::size_t>(format) < block_width_table.size()); |
| 283 | return block_width_table[static_cast<std::size_t>(format)]; | 285 | return block_width_table[static_cast<std::size_t>(format)]; |
| 284 | } | 286 | } |
| 285 | 287 | ||
| 288 | constexpr std::array<u32, MaxPixelFormat> block_height_table = {{ | ||
| 289 | 1, // ABGR8U | ||
| 290 | 1, // ABGR8S | ||
| 291 | 1, // ABGR8UI | ||
| 292 | 1, // B5G6R5U | ||
| 293 | 1, // A2B10G10R10U | ||
| 294 | 1, // A1B5G5R5U | ||
| 295 | 1, // R8U | ||
| 296 | 1, // R8UI | ||
| 297 | 1, // RGBA16F | ||
| 298 | 1, // RGBA16U | ||
| 299 | 1, // RGBA16UI | ||
| 300 | 1, // R11FG11FB10F | ||
| 301 | 1, // RGBA32UI | ||
| 302 | 4, // DXT1 | ||
| 303 | 4, // DXT23 | ||
| 304 | 4, // DXT45 | ||
| 305 | 4, // DXN1 | ||
| 306 | 4, // DXN2UNORM | ||
| 307 | 4, // DXN2SNORM | ||
| 308 | 4, // BC7U | ||
| 309 | 4, // BC6H_UF16 | ||
| 310 | 4, // BC6H_SF16 | ||
| 311 | 4, // ASTC_2D_4X4 | ||
| 312 | 1, // G8R8U | ||
| 313 | 1, // G8R8S | ||
| 314 | 1, // BGRA8 | ||
| 315 | 1, // RGBA32F | ||
| 316 | 1, // RG32F | ||
| 317 | 1, // R32F | ||
| 318 | 1, // R16F | ||
| 319 | 1, // R16U | ||
| 320 | 1, // R16S | ||
| 321 | 1, // R16UI | ||
| 322 | 1, // R16I | ||
| 323 | 1, // RG16 | ||
| 324 | 1, // RG16F | ||
| 325 | 1, // RG16UI | ||
| 326 | 1, // RG16I | ||
| 327 | 1, // RG16S | ||
| 328 | 1, // RGB32F | ||
| 329 | 1, // RGBA8_SRGB | ||
| 330 | 1, // RG8U | ||
| 331 | 1, // RG8S | ||
| 332 | 1, // RG32UI | ||
| 333 | 1, // R32UI | ||
| 334 | 8, // ASTC_2D_8X8 | ||
| 335 | 5, // ASTC_2D_8X5 | ||
| 336 | 4, // ASTC_2D_5X4 | ||
| 337 | 1, // BGRA8_SRGB | ||
| 338 | 4, // DXT1_SRGB | ||
| 339 | 4, // DXT23_SRGB | ||
| 340 | 4, // DXT45_SRGB | ||
| 341 | 4, // BC7U_SRGB | ||
| 342 | 4, // ASTC_2D_4X4_SRGB | ||
| 343 | 8, // ASTC_2D_8X8_SRGB | ||
| 344 | 5, // ASTC_2D_8X5_SRGB | ||
| 345 | 4, // ASTC_2D_5X4_SRGB | ||
| 346 | 5, // ASTC_2D_5X5 | ||
| 347 | 5, // ASTC_2D_5X5_SRGB | ||
| 348 | 8, // ASTC_2D_10X8 | ||
| 349 | 8, // ASTC_2D_10X8_SRGB | ||
| 350 | 1, // Z32F | ||
| 351 | 1, // Z16 | ||
| 352 | 1, // Z24S8 | ||
| 353 | 1, // S8Z24 | ||
| 354 | 1, // Z32FS8 | ||
| 355 | }}; | ||
| 356 | |||
| 286 | static constexpr u32 GetDefaultBlockHeight(PixelFormat format) { | 357 | static constexpr u32 GetDefaultBlockHeight(PixelFormat format) { |
| 287 | if (format == PixelFormat::Invalid) | 358 | if (format == PixelFormat::Invalid) |
| 288 | return 0; | 359 | return 0; |
| 289 | 360 | ||
| 290 | constexpr std::array<u32, MaxPixelFormat> block_height_table = {{ | ||
| 291 | 1, // ABGR8U | ||
| 292 | 1, // ABGR8S | ||
| 293 | 1, // ABGR8UI | ||
| 294 | 1, // B5G6R5U | ||
| 295 | 1, // A2B10G10R10U | ||
| 296 | 1, // A1B5G5R5U | ||
| 297 | 1, // R8U | ||
| 298 | 1, // R8UI | ||
| 299 | 1, // RGBA16F | ||
| 300 | 1, // RGBA16U | ||
| 301 | 1, // RGBA16UI | ||
| 302 | 1, // R11FG11FB10F | ||
| 303 | 1, // RGBA32UI | ||
| 304 | 4, // DXT1 | ||
| 305 | 4, // DXT23 | ||
| 306 | 4, // DXT45 | ||
| 307 | 4, // DXN1 | ||
| 308 | 4, // DXN2UNORM | ||
| 309 | 4, // DXN2SNORM | ||
| 310 | 4, // BC7U | ||
| 311 | 4, // BC6H_UF16 | ||
| 312 | 4, // BC6H_SF16 | ||
| 313 | 4, // ASTC_2D_4X4 | ||
| 314 | 1, // G8R8U | ||
| 315 | 1, // G8R8S | ||
| 316 | 1, // BGRA8 | ||
| 317 | 1, // RGBA32F | ||
| 318 | 1, // RG32F | ||
| 319 | 1, // R32F | ||
| 320 | 1, // R16F | ||
| 321 | 1, // R16U | ||
| 322 | 1, // R16S | ||
| 323 | 1, // R16UI | ||
| 324 | 1, // R16I | ||
| 325 | 1, // RG16 | ||
| 326 | 1, // RG16F | ||
| 327 | 1, // RG16UI | ||
| 328 | 1, // RG16I | ||
| 329 | 1, // RG16S | ||
| 330 | 1, // RGB32F | ||
| 331 | 1, // RGBA8_SRGB | ||
| 332 | 1, // RG8U | ||
| 333 | 1, // RG8S | ||
| 334 | 1, // RG32UI | ||
| 335 | 1, // R32UI | ||
| 336 | 8, // ASTC_2D_8X8 | ||
| 337 | 5, // ASTC_2D_8X5 | ||
| 338 | 4, // ASTC_2D_5X4 | ||
| 339 | 1, // BGRA8_SRGB | ||
| 340 | 4, // DXT1_SRGB | ||
| 341 | 4, // DXT23_SRGB | ||
| 342 | 4, // DXT45_SRGB | ||
| 343 | 4, // BC7U_SRGB | ||
| 344 | 4, // ASTC_2D_4X4_SRGB | ||
| 345 | 8, // ASTC_2D_8X8_SRGB | ||
| 346 | 5, // ASTC_2D_8X5_SRGB | ||
| 347 | 4, // ASTC_2D_5X4_SRGB | ||
| 348 | 5, // ASTC_2D_5X5 | ||
| 349 | 5, // ASTC_2D_5X5_SRGB | ||
| 350 | 8, // ASTC_2D_10X8 | ||
| 351 | 8, // ASTC_2D_10X8_SRGB | ||
| 352 | 1, // Z32F | ||
| 353 | 1, // Z16 | ||
| 354 | 1, // Z24S8 | ||
| 355 | 1, // S8Z24 | ||
| 356 | 1, // Z32FS8 | ||
| 357 | }}; | ||
| 358 | |||
| 359 | ASSERT(static_cast<std::size_t>(format) < block_height_table.size()); | 361 | ASSERT(static_cast<std::size_t>(format) < block_height_table.size()); |
| 360 | return block_height_table[static_cast<std::size_t>(format)]; | 362 | return block_height_table[static_cast<std::size_t>(format)]; |
| 361 | } | 363 | } |
| 362 | 364 | ||
| 365 | constexpr std::array<u32, MaxPixelFormat> bpp_table = {{ | ||
| 366 | 32, // ABGR8U | ||
| 367 | 32, // ABGR8S | ||
| 368 | 32, // ABGR8UI | ||
| 369 | 16, // B5G6R5U | ||
| 370 | 32, // A2B10G10R10U | ||
| 371 | 16, // A1B5G5R5U | ||
| 372 | 8, // R8U | ||
| 373 | 8, // R8UI | ||
| 374 | 64, // RGBA16F | ||
| 375 | 64, // RGBA16U | ||
| 376 | 64, // RGBA16UI | ||
| 377 | 32, // R11FG11FB10F | ||
| 378 | 128, // RGBA32UI | ||
| 379 | 64, // DXT1 | ||
| 380 | 128, // DXT23 | ||
| 381 | 128, // DXT45 | ||
| 382 | 64, // DXN1 | ||
| 383 | 128, // DXN2UNORM | ||
| 384 | 128, // DXN2SNORM | ||
| 385 | 128, // BC7U | ||
| 386 | 128, // BC6H_UF16 | ||
| 387 | 128, // BC6H_SF16 | ||
| 388 | 128, // ASTC_2D_4X4 | ||
| 389 | 16, // G8R8U | ||
| 390 | 16, // G8R8S | ||
| 391 | 32, // BGRA8 | ||
| 392 | 128, // RGBA32F | ||
| 393 | 64, // RG32F | ||
| 394 | 32, // R32F | ||
| 395 | 16, // R16F | ||
| 396 | 16, // R16U | ||
| 397 | 16, // R16S | ||
| 398 | 16, // R16UI | ||
| 399 | 16, // R16I | ||
| 400 | 32, // RG16 | ||
| 401 | 32, // RG16F | ||
| 402 | 32, // RG16UI | ||
| 403 | 32, // RG16I | ||
| 404 | 32, // RG16S | ||
| 405 | 96, // RGB32F | ||
| 406 | 32, // RGBA8_SRGB | ||
| 407 | 16, // RG8U | ||
| 408 | 16, // RG8S | ||
| 409 | 64, // RG32UI | ||
| 410 | 32, // R32UI | ||
| 411 | 128, // ASTC_2D_8X8 | ||
| 412 | 128, // ASTC_2D_8X5 | ||
| 413 | 128, // ASTC_2D_5X4 | ||
| 414 | 32, // BGRA8_SRGB | ||
| 415 | 64, // DXT1_SRGB | ||
| 416 | 128, // DXT23_SRGB | ||
| 417 | 128, // DXT45_SRGB | ||
| 418 | 128, // BC7U | ||
| 419 | 128, // ASTC_2D_4X4_SRGB | ||
| 420 | 128, // ASTC_2D_8X8_SRGB | ||
| 421 | 128, // ASTC_2D_8X5_SRGB | ||
| 422 | 128, // ASTC_2D_5X4_SRGB | ||
| 423 | 128, // ASTC_2D_5X5 | ||
| 424 | 128, // ASTC_2D_5X5_SRGB | ||
| 425 | 128, // ASTC_2D_10X8 | ||
| 426 | 128, // ASTC_2D_10X8_SRGB | ||
| 427 | 32, // Z32F | ||
| 428 | 16, // Z16 | ||
| 429 | 32, // Z24S8 | ||
| 430 | 32, // S8Z24 | ||
| 431 | 64, // Z32FS8 | ||
| 432 | }}; | ||
| 433 | |||
| 363 | static constexpr u32 GetFormatBpp(PixelFormat format) { | 434 | static constexpr u32 GetFormatBpp(PixelFormat format) { |
| 364 | if (format == PixelFormat::Invalid) | 435 | if (format == PixelFormat::Invalid) |
| 365 | return 0; | 436 | return 0; |
| 366 | 437 | ||
| 367 | constexpr std::array<u32, MaxPixelFormat> bpp_table = {{ | ||
| 368 | 32, // ABGR8U | ||
| 369 | 32, // ABGR8S | ||
| 370 | 32, // ABGR8UI | ||
| 371 | 16, // B5G6R5U | ||
| 372 | 32, // A2B10G10R10U | ||
| 373 | 16, // A1B5G5R5U | ||
| 374 | 8, // R8U | ||
| 375 | 8, // R8UI | ||
| 376 | 64, // RGBA16F | ||
| 377 | 64, // RGBA16U | ||
| 378 | 64, // RGBA16UI | ||
| 379 | 32, // R11FG11FB10F | ||
| 380 | 128, // RGBA32UI | ||
| 381 | 64, // DXT1 | ||
| 382 | 128, // DXT23 | ||
| 383 | 128, // DXT45 | ||
| 384 | 64, // DXN1 | ||
| 385 | 128, // DXN2UNORM | ||
| 386 | 128, // DXN2SNORM | ||
| 387 | 128, // BC7U | ||
| 388 | 128, // BC6H_UF16 | ||
| 389 | 128, // BC6H_SF16 | ||
| 390 | 128, // ASTC_2D_4X4 | ||
| 391 | 16, // G8R8U | ||
| 392 | 16, // G8R8S | ||
| 393 | 32, // BGRA8 | ||
| 394 | 128, // RGBA32F | ||
| 395 | 64, // RG32F | ||
| 396 | 32, // R32F | ||
| 397 | 16, // R16F | ||
| 398 | 16, // R16U | ||
| 399 | 16, // R16S | ||
| 400 | 16, // R16UI | ||
| 401 | 16, // R16I | ||
| 402 | 32, // RG16 | ||
| 403 | 32, // RG16F | ||
| 404 | 32, // RG16UI | ||
| 405 | 32, // RG16I | ||
| 406 | 32, // RG16S | ||
| 407 | 96, // RGB32F | ||
| 408 | 32, // RGBA8_SRGB | ||
| 409 | 16, // RG8U | ||
| 410 | 16, // RG8S | ||
| 411 | 64, // RG32UI | ||
| 412 | 32, // R32UI | ||
| 413 | 128, // ASTC_2D_8X8 | ||
| 414 | 128, // ASTC_2D_8X5 | ||
| 415 | 128, // ASTC_2D_5X4 | ||
| 416 | 32, // BGRA8_SRGB | ||
| 417 | 64, // DXT1_SRGB | ||
| 418 | 128, // DXT23_SRGB | ||
| 419 | 128, // DXT45_SRGB | ||
| 420 | 128, // BC7U | ||
| 421 | 128, // ASTC_2D_4X4_SRGB | ||
| 422 | 128, // ASTC_2D_8X8_SRGB | ||
| 423 | 128, // ASTC_2D_8X5_SRGB | ||
| 424 | 128, // ASTC_2D_5X4_SRGB | ||
| 425 | 128, // ASTC_2D_5X5 | ||
| 426 | 128, // ASTC_2D_5X5_SRGB | ||
| 427 | 128, // ASTC_2D_10X8 | ||
| 428 | 128, // ASTC_2D_10X8_SRGB | ||
| 429 | 32, // Z32F | ||
| 430 | 16, // Z16 | ||
| 431 | 32, // Z24S8 | ||
| 432 | 32, // S8Z24 | ||
| 433 | 64, // Z32FS8 | ||
| 434 | }}; | ||
| 435 | |||
| 436 | ASSERT(static_cast<std::size_t>(format) < bpp_table.size()); | 438 | ASSERT(static_cast<std::size_t>(format) < bpp_table.size()); |
| 437 | return bpp_table[static_cast<std::size_t>(format)]; | 439 | return bpp_table[static_cast<std::size_t>(format)]; |
| 438 | } | 440 | } |
diff --git a/src/yuzu/configuration/config.cpp b/src/yuzu/configuration/config.cpp index 83ebbd1fe..c26161169 100644 --- a/src/yuzu/configuration/config.cpp +++ b/src/yuzu/configuration/config.cpp | |||
| @@ -206,60 +206,57 @@ const std::array<int, Settings::NativeKeyboard::NumKeyboardMods> Config::default | |||
| 206 | 206 | ||
| 207 | void Config::ReadPlayerValues() { | 207 | void Config::ReadPlayerValues() { |
| 208 | for (std::size_t p = 0; p < Settings::values.players.size(); ++p) { | 208 | for (std::size_t p = 0; p < Settings::values.players.size(); ++p) { |
| 209 | Settings::values.players[p].connected = | 209 | auto& player = Settings::values.players[p]; |
| 210 | qt_config->value(QString("player_%1_connected").arg(p), false).toBool(); | ||
| 211 | 210 | ||
| 212 | Settings::values.players[p].type = static_cast<Settings::ControllerType>( | 211 | player.connected = qt_config->value(QString("player_%1_connected").arg(p), false).toBool(); |
| 212 | |||
| 213 | player.type = static_cast<Settings::ControllerType>( | ||
| 213 | qt_config | 214 | qt_config |
| 214 | ->value(QString("player_%1_type").arg(p), | 215 | ->value(QString("player_%1_type").arg(p), |
| 215 | static_cast<u8>(Settings::ControllerType::DualJoycon)) | 216 | static_cast<u8>(Settings::ControllerType::DualJoycon)) |
| 216 | .toUInt()); | 217 | .toUInt()); |
| 217 | 218 | ||
| 218 | Settings::values.players[p].body_color_left = | 219 | player.body_color_left = qt_config |
| 219 | qt_config | 220 | ->value(QString("player_%1_body_color_left").arg(p), |
| 220 | ->value(QString("player_%1_body_color_left").arg(p), | 221 | Settings::JOYCON_BODY_NEON_BLUE) |
| 221 | Settings::JOYCON_BODY_NEON_BLUE) | 222 | .toUInt(); |
| 222 | .toUInt(); | 223 | player.body_color_right = qt_config |
| 223 | Settings::values.players[p].body_color_right = | 224 | ->value(QString("player_%1_body_color_right").arg(p), |
| 224 | qt_config | 225 | Settings::JOYCON_BODY_NEON_RED) |
| 225 | ->value(QString("player_%1_body_color_right").arg(p), | 226 | .toUInt(); |
| 226 | Settings::JOYCON_BODY_NEON_RED) | 227 | player.button_color_left = qt_config |
| 227 | .toUInt(); | 228 | ->value(QString("player_%1_button_color_left").arg(p), |
| 228 | Settings::values.players[p].button_color_left = | 229 | Settings::JOYCON_BUTTONS_NEON_BLUE) |
| 229 | qt_config | 230 | .toUInt(); |
| 230 | ->value(QString("player_%1_button_color_left").arg(p), | 231 | player.button_color_right = qt_config |
| 231 | Settings::JOYCON_BUTTONS_NEON_BLUE) | 232 | ->value(QString("player_%1_button_color_right").arg(p), |
| 232 | .toUInt(); | 233 | Settings::JOYCON_BUTTONS_NEON_RED) |
| 233 | Settings::values.players[p].button_color_right = | 234 | .toUInt(); |
| 234 | qt_config | ||
| 235 | ->value(QString("player_%1_button_color_right").arg(p), | ||
| 236 | Settings::JOYCON_BUTTONS_NEON_RED) | ||
| 237 | .toUInt(); | ||
| 238 | 235 | ||
| 239 | for (int i = 0; i < Settings::NativeButton::NumButtons; ++i) { | 236 | for (int i = 0; i < Settings::NativeButton::NumButtons; ++i) { |
| 240 | std::string default_param = InputCommon::GenerateKeyboardParam(default_buttons[i]); | 237 | std::string default_param = InputCommon::GenerateKeyboardParam(default_buttons[i]); |
| 241 | Settings::values.players[p].buttons[i] = | 238 | player.buttons[i] = |
| 242 | qt_config | 239 | qt_config |
| 243 | ->value(QString("player_%1_").arg(p) + Settings::NativeButton::mapping[i], | 240 | ->value(QString("player_%1_").arg(p) + Settings::NativeButton::mapping[i], |
| 244 | QString::fromStdString(default_param)) | 241 | QString::fromStdString(default_param)) |
| 245 | .toString() | 242 | .toString() |
| 246 | .toStdString(); | 243 | .toStdString(); |
| 247 | if (Settings::values.players[p].buttons[i].empty()) | 244 | if (player.buttons[i].empty()) |
| 248 | Settings::values.players[p].buttons[i] = default_param; | 245 | player.buttons[i] = default_param; |
| 249 | } | 246 | } |
| 250 | 247 | ||
| 251 | for (int i = 0; i < Settings::NativeAnalog::NumAnalogs; ++i) { | 248 | for (int i = 0; i < Settings::NativeAnalog::NumAnalogs; ++i) { |
| 252 | std::string default_param = InputCommon::GenerateAnalogParamFromKeys( | 249 | std::string default_param = InputCommon::GenerateAnalogParamFromKeys( |
| 253 | default_analogs[i][0], default_analogs[i][1], default_analogs[i][2], | 250 | default_analogs[i][0], default_analogs[i][1], default_analogs[i][2], |
| 254 | default_analogs[i][3], default_analogs[i][4], 0.5f); | 251 | default_analogs[i][3], default_analogs[i][4], 0.5f); |
| 255 | Settings::values.players[p].analogs[i] = | 252 | player.analogs[i] = |
| 256 | qt_config | 253 | qt_config |
| 257 | ->value(QString("player_%1_").arg(p) + Settings::NativeAnalog::mapping[i], | 254 | ->value(QString("player_%1_").arg(p) + Settings::NativeAnalog::mapping[i], |
| 258 | QString::fromStdString(default_param)) | 255 | QString::fromStdString(default_param)) |
| 259 | .toString() | 256 | .toString() |
| 260 | .toStdString(); | 257 | .toStdString(); |
| 261 | if (Settings::values.players[p].analogs[i].empty()) | 258 | if (player.analogs[i].empty()) |
| 262 | Settings::values.players[p].analogs[i] = default_param; | 259 | player.analogs[i] = default_param; |
| 263 | } | 260 | } |
| 264 | } | 261 | } |
| 265 | 262 | ||
| @@ -511,30 +508,28 @@ void Config::ReadValues() { | |||
| 511 | } | 508 | } |
| 512 | 509 | ||
| 513 | void Config::SavePlayerValues() { | 510 | void Config::SavePlayerValues() { |
| 514 | for (int p = 0; p < Settings::values.players.size(); ++p) { | 511 | for (std::size_t p = 0; p < Settings::values.players.size(); ++p) { |
| 515 | qt_config->setValue(QString("player_%1_connected").arg(p), | 512 | const auto& player = Settings::values.players[p]; |
| 516 | Settings::values.players[p].connected); | 513 | |
| 517 | qt_config->setValue(QString("player_%1_type").arg(p), | 514 | qt_config->setValue(QString("player_%1_connected").arg(p), player.connected); |
| 518 | static_cast<u8>(Settings::values.players[p].type)); | 515 | qt_config->setValue(QString("player_%1_type").arg(p), static_cast<u8>(player.type)); |
| 519 | 516 | ||
| 520 | qt_config->setValue(QString("player_%1_body_color_left").arg(p), | 517 | qt_config->setValue(QString("player_%1_body_color_left").arg(p), player.body_color_left); |
| 521 | Settings::values.players[p].body_color_left); | 518 | qt_config->setValue(QString("player_%1_body_color_right").arg(p), player.body_color_right); |
| 522 | qt_config->setValue(QString("player_%1_body_color_right").arg(p), | ||
| 523 | Settings::values.players[p].body_color_right); | ||
| 524 | qt_config->setValue(QString("player_%1_button_color_left").arg(p), | 519 | qt_config->setValue(QString("player_%1_button_color_left").arg(p), |
| 525 | Settings::values.players[p].button_color_left); | 520 | player.button_color_left); |
| 526 | qt_config->setValue(QString("player_%1_button_color_right").arg(p), | 521 | qt_config->setValue(QString("player_%1_button_color_right").arg(p), |
| 527 | Settings::values.players[p].button_color_right); | 522 | player.button_color_right); |
| 528 | 523 | ||
| 529 | for (int i = 0; i < Settings::NativeButton::NumButtons; ++i) { | 524 | for (int i = 0; i < Settings::NativeButton::NumButtons; ++i) { |
| 530 | qt_config->setValue(QString("player_%1_").arg(p) + | 525 | qt_config->setValue(QString("player_%1_").arg(p) + |
| 531 | QString::fromStdString(Settings::NativeButton::mapping[i]), | 526 | QString::fromStdString(Settings::NativeButton::mapping[i]), |
| 532 | QString::fromStdString(Settings::values.players[p].buttons[i])); | 527 | QString::fromStdString(player.buttons[i])); |
| 533 | } | 528 | } |
| 534 | for (int i = 0; i < Settings::NativeAnalog::NumAnalogs; ++i) { | 529 | for (int i = 0; i < Settings::NativeAnalog::NumAnalogs; ++i) { |
| 535 | qt_config->setValue(QString("player_%1_").arg(p) + | 530 | qt_config->setValue(QString("player_%1_").arg(p) + |
| 536 | QString::fromStdString(Settings::NativeAnalog::mapping[i]), | 531 | QString::fromStdString(Settings::NativeAnalog::mapping[i]), |
| 537 | QString::fromStdString(Settings::values.players[p].analogs[i])); | 532 | QString::fromStdString(player.analogs[i])); |
| 538 | } | 533 | } |
| 539 | } | 534 | } |
| 540 | } | 535 | } |
diff --git a/src/yuzu/game_list_worker.cpp b/src/yuzu/game_list_worker.cpp index 9fd074223..20f5e8798 100644 --- a/src/yuzu/game_list_worker.cpp +++ b/src/yuzu/game_list_worker.cpp | |||
| @@ -99,12 +99,14 @@ QList<QStandardItem*> MakeGameListEntry(const std::string& path, const std::stri | |||
| 99 | compatibility = it->second.first; | 99 | compatibility = it->second.first; |
| 100 | } | 100 | } |
| 101 | 101 | ||
| 102 | const auto file_type = loader.GetFileType(); | ||
| 103 | const auto file_type_string = QString::fromStdString(Loader::GetFileTypeString(file_type)); | ||
| 104 | |||
| 102 | QList<QStandardItem*> list{ | 105 | QList<QStandardItem*> list{ |
| 103 | new GameListItemPath( | 106 | new GameListItemPath(FormatGameName(path), icon, QString::fromStdString(name), |
| 104 | FormatGameName(path), icon, QString::fromStdString(name), | 107 | file_type_string, program_id), |
| 105 | QString::fromStdString(Loader::GetFileTypeString(loader.GetFileType())), program_id), | ||
| 106 | new GameListItemCompat(compatibility), | 108 | new GameListItemCompat(compatibility), |
| 107 | new GameListItem(QString::fromStdString(Loader::GetFileTypeString(loader.GetFileType()))), | 109 | new GameListItem(file_type_string), |
| 108 | new GameListItemSize(FileUtil::GetSize(path)), | 110 | new GameListItemSize(FileUtil::GetSize(path)), |
| 109 | }; | 111 | }; |
| 110 | 112 | ||
| @@ -196,12 +198,16 @@ void GameListWorker::AddFstEntriesToGameList(const std::string& dir_path, unsign | |||
| 196 | const bool is_dir = FileUtil::IsDirectory(physical_name); | 198 | const bool is_dir = FileUtil::IsDirectory(physical_name); |
| 197 | if (!is_dir && | 199 | if (!is_dir && |
| 198 | (HasSupportedFileExtension(physical_name) || IsExtractedNCAMain(physical_name))) { | 200 | (HasSupportedFileExtension(physical_name) || IsExtractedNCAMain(physical_name))) { |
| 199 | std::unique_ptr<Loader::AppLoader> loader = | 201 | auto loader = Loader::GetLoader(vfs->OpenFile(physical_name, FileSys::Mode::Read)); |
| 200 | Loader::GetLoader(vfs->OpenFile(physical_name, FileSys::Mode::Read)); | 202 | if (!loader) { |
| 201 | if (!loader || ((loader->GetFileType() == Loader::FileType::Unknown || | ||
| 202 | loader->GetFileType() == Loader::FileType::Error) && | ||
| 203 | !UISettings::values.show_unknown)) | ||
| 204 | return true; | 203 | return true; |
| 204 | } | ||
| 205 | |||
| 206 | const auto file_type = loader->GetFileType(); | ||
| 207 | if ((file_type == Loader::FileType::Unknown || file_type == Loader::FileType::Error) && | ||
| 208 | !UISettings::values.show_unknown) { | ||
| 209 | return true; | ||
| 210 | } | ||
| 205 | 211 | ||
| 206 | std::vector<u8> icon; | 212 | std::vector<u8> icon; |
| 207 | const auto res1 = loader->ReadIcon(icon); | 213 | const auto res1 = loader->ReadIcon(icon); |