summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/shader_recompiler/backend/spirv/emit_spirv.h6
-rw-r--r--src/shader_recompiler/backend/spirv/emit_spirv_integer.cpp21
-rw-r--r--src/shader_recompiler/frontend/maxwell/translate/impl/logic_operation.cpp14
3 files changed, 29 insertions, 12 deletions
diff --git a/src/shader_recompiler/backend/spirv/emit_spirv.h b/src/shader_recompiler/backend/spirv/emit_spirv.h
index 04340fa70..150477ff6 100644
--- a/src/shader_recompiler/backend/spirv/emit_spirv.h
+++ b/src/shader_recompiler/backend/spirv/emit_spirv.h
@@ -280,9 +280,9 @@ Id EmitShiftRightLogical32(EmitContext& ctx, Id base, Id shift);
280Id EmitShiftRightLogical64(EmitContext& ctx, Id base, Id shift); 280Id EmitShiftRightLogical64(EmitContext& ctx, Id base, Id shift);
281Id EmitShiftRightArithmetic32(EmitContext& ctx, Id base, Id shift); 281Id EmitShiftRightArithmetic32(EmitContext& ctx, Id base, Id shift);
282Id EmitShiftRightArithmetic64(EmitContext& ctx, Id base, Id shift); 282Id EmitShiftRightArithmetic64(EmitContext& ctx, Id base, Id shift);
283Id EmitBitwiseAnd32(EmitContext& ctx, Id a, Id b); 283Id EmitBitwiseAnd32(EmitContext& ctx, IR::Inst* inst, Id a, Id b);
284Id EmitBitwiseOr32(EmitContext& ctx, Id a, Id b); 284Id EmitBitwiseOr32(EmitContext& ctx, IR::Inst* inst, Id a, Id b);
285Id EmitBitwiseXor32(EmitContext& ctx, Id a, Id b); 285Id EmitBitwiseXor32(EmitContext& ctx, IR::Inst* inst, Id a, Id b);
286Id EmitBitFieldInsert(EmitContext& ctx, Id base, Id insert, Id offset, Id count); 286Id EmitBitFieldInsert(EmitContext& ctx, Id base, Id insert, Id offset, Id count);
287Id EmitBitFieldSExtract(EmitContext& ctx, IR::Inst* inst, Id base, Id offset, Id count); 287Id EmitBitFieldSExtract(EmitContext& ctx, IR::Inst* inst, Id base, Id offset, Id count);
288Id EmitBitFieldUExtract(EmitContext& ctx, IR::Inst* inst, Id base, Id offset, Id count); 288Id EmitBitFieldUExtract(EmitContext& ctx, IR::Inst* inst, Id base, Id offset, Id count);
diff --git a/src/shader_recompiler/backend/spirv/emit_spirv_integer.cpp b/src/shader_recompiler/backend/spirv/emit_spirv_integer.cpp
index 8bf43b91d..944f1e429 100644
--- a/src/shader_recompiler/backend/spirv/emit_spirv_integer.cpp
+++ b/src/shader_recompiler/backend/spirv/emit_spirv_integer.cpp
@@ -111,16 +111,25 @@ Id EmitShiftRightArithmetic64(EmitContext& ctx, Id base, Id shift) {
111 return ctx.OpShiftRightArithmetic(ctx.U64, base, shift); 111 return ctx.OpShiftRightArithmetic(ctx.U64, base, shift);
112} 112}
113 113
114Id EmitBitwiseAnd32(EmitContext& ctx, Id a, Id b) { 114Id EmitBitwiseAnd32(EmitContext& ctx, IR::Inst* inst, Id a, Id b) {
115 return ctx.OpBitwiseAnd(ctx.U32[1], a, b); 115 const Id result{ctx.OpBitwiseAnd(ctx.U32[1], a, b)};
116 SetZeroFlag(ctx, inst, result);
117 SetSignFlag(ctx, inst, result);
118 return result;
116} 119}
117 120
118Id EmitBitwiseOr32(EmitContext& ctx, Id a, Id b) { 121Id EmitBitwiseOr32(EmitContext& ctx, IR::Inst* inst, Id a, Id b) {
119 return ctx.OpBitwiseOr(ctx.U32[1], a, b); 122 const Id result{ctx.OpBitwiseOr(ctx.U32[1], a, b)};
123 SetZeroFlag(ctx, inst, result);
124 SetSignFlag(ctx, inst, result);
125 return result;
120} 126}
121 127
122Id EmitBitwiseXor32(EmitContext& ctx, Id a, Id b) { 128Id EmitBitwiseXor32(EmitContext& ctx, IR::Inst* inst, Id a, Id b) {
123 return ctx.OpBitwiseXor(ctx.U32[1], a, b); 129 const Id result{ctx.OpBitwiseXor(ctx.U32[1], a, b)};
130 SetZeroFlag(ctx, inst, result);
131 SetSignFlag(ctx, inst, result);
132 return result;
124} 133}
125 134
126Id EmitBitFieldInsert(EmitContext& ctx, Id base, Id insert, Id offset, Id count) { 135Id EmitBitFieldInsert(EmitContext& ctx, Id base, Id insert, Id offset, Id count) {
diff --git a/src/shader_recompiler/frontend/maxwell/translate/impl/logic_operation.cpp b/src/shader_recompiler/frontend/maxwell/translate/impl/logic_operation.cpp
index 89e5cd6de..92cd27ed4 100644
--- a/src/shader_recompiler/frontend/maxwell/translate/impl/logic_operation.cpp
+++ b/src/shader_recompiler/frontend/maxwell/translate/impl/logic_operation.cpp
@@ -44,9 +44,6 @@ void LOP(TranslatorVisitor& v, u64 insn, IR::U32 op_b, bool x, bool cc, bool inv
44 if (x) { 44 if (x) {
45 throw NotImplementedException("X"); 45 throw NotImplementedException("X");
46 } 46 }
47 if (cc) {
48 throw NotImplementedException("CC");
49 }
50 IR::U32 op_a{v.X(lop.src_reg)}; 47 IR::U32 op_a{v.X(lop.src_reg)};
51 if (inv_a != 0) { 48 if (inv_a != 0) {
52 op_a = v.ir.BitwiseNot(op_a); 49 op_a = v.ir.BitwiseNot(op_a);
@@ -60,6 +57,17 @@ void LOP(TranslatorVisitor& v, u64 insn, IR::U32 op_b, bool x, bool cc, bool inv
60 const IR::U1 pred_result{PredicateOperation(v.ir, result, *pred_op)}; 57 const IR::U1 pred_result{PredicateOperation(v.ir, result, *pred_op)};
61 v.ir.SetPred(dest_pred, pred_result); 58 v.ir.SetPred(dest_pred, pred_result);
62 } 59 }
60 if (cc) {
61 if (bit_op == LogicalOp::PASS_B) {
62 v.SetZFlag(v.ir.IEqual(result, v.ir.Imm32(0)));
63 v.SetSFlag(v.ir.ILessThan(result, v.ir.Imm32(0), true));
64 } else {
65 v.SetZFlag(v.ir.GetZeroFromOp(result));
66 v.SetSFlag(v.ir.GetSignFromOp(result));
67 }
68 v.ResetCFlag();
69 v.ResetOFlag();
70 }
63 v.X(lop.dest_reg, result); 71 v.X(lop.dest_reg, result);
64} 72}
65 73