diff options
| -rw-r--r-- | src/core/hle/service/fs/fs_user.cpp | 46 |
1 files changed, 24 insertions, 22 deletions
diff --git a/src/core/hle/service/fs/fs_user.cpp b/src/core/hle/service/fs/fs_user.cpp index 582591e40..00edc7622 100644 --- a/src/core/hle/service/fs/fs_user.cpp +++ b/src/core/hle/service/fs/fs_user.cpp | |||
| @@ -64,7 +64,7 @@ static void OpenFile(Service::Interface* self) { | |||
| 64 | u32 filename_ptr = cmd_buff[9]; | 64 | u32 filename_ptr = cmd_buff[9]; |
| 65 | FileSys::Path file_path(filename_type, filename_size, filename_ptr); | 65 | FileSys::Path file_path(filename_type, filename_size, filename_ptr); |
| 66 | 66 | ||
| 67 | LOG_DEBUG(Service_FS, "path=%s, mode=%d attrs=%u", file_path.DebugStr().c_str(), mode.hex, | 67 | LOG_DEBUG(Service_FS, "path=%s, mode=%u attrs=%u", file_path.DebugStr().c_str(), mode.hex, |
| 68 | attributes); | 68 | attributes); |
| 69 | 69 | ||
| 70 | ResultVal<SharedPtr<File>> file_res = OpenFileFromArchive(archive_handle, file_path, mode); | 70 | ResultVal<SharedPtr<File>> file_res = OpenFileFromArchive(archive_handle, file_path, mode); |
| @@ -112,15 +112,15 @@ static void OpenFileDirectly(Service::Interface* self) { | |||
| 112 | FileSys::Path archive_path(archivename_type, archivename_size, archivename_ptr); | 112 | FileSys::Path archive_path(archivename_type, archivename_size, archivename_ptr); |
| 113 | FileSys::Path file_path(filename_type, filename_size, filename_ptr); | 113 | FileSys::Path file_path(filename_type, filename_size, filename_ptr); |
| 114 | 114 | ||
| 115 | LOG_DEBUG(Service_FS, "archive_id=0x%08X archive_path=%s file_path=%s, mode=%u attributes=%d", | 115 | LOG_DEBUG(Service_FS, "archive_id=0x%08X archive_path=%s file_path=%s, mode=%u attributes=%u", |
| 116 | archive_id, archive_path.DebugStr().c_str(), file_path.DebugStr().c_str(), mode.hex, | 116 | static_cast<u32>(archive_id), archive_path.DebugStr().c_str(), |
| 117 | attributes); | 117 | file_path.DebugStr().c_str(), mode.hex, attributes); |
| 118 | 118 | ||
| 119 | ResultVal<ArchiveHandle> archive_handle = OpenArchive(archive_id, archive_path); | 119 | ResultVal<ArchiveHandle> archive_handle = OpenArchive(archive_id, archive_path); |
| 120 | if (archive_handle.Failed()) { | 120 | if (archive_handle.Failed()) { |
| 121 | LOG_ERROR(Service_FS, | 121 | LOG_ERROR(Service_FS, |
| 122 | "failed to get a handle for archive archive_id=0x%08X archive_path=%s", | 122 | "failed to get a handle for archive archive_id=0x%08X archive_path=%s", |
| 123 | archive_id, archive_path.DebugStr().c_str()); | 123 | static_cast<u32>(archive_id), archive_path.DebugStr().c_str()); |
| 124 | cmd_buff[1] = archive_handle.Code().raw; | 124 | cmd_buff[1] = archive_handle.Code().raw; |
| 125 | cmd_buff[3] = 0; | 125 | cmd_buff[3] = 0; |
| 126 | return; | 126 | return; |
| @@ -133,7 +133,7 @@ static void OpenFileDirectly(Service::Interface* self) { | |||
| 133 | cmd_buff[3] = Kernel::g_handle_table.Create(*file_res).MoveFrom(); | 133 | cmd_buff[3] = Kernel::g_handle_table.Create(*file_res).MoveFrom(); |
| 134 | } else { | 134 | } else { |
| 135 | cmd_buff[3] = 0; | 135 | cmd_buff[3] = 0; |
| 136 | LOG_ERROR(Service_FS, "failed to get a handle for file %s mode=%u attributes=%d", | 136 | LOG_ERROR(Service_FS, "failed to get a handle for file %s mode=%u attributes=%u", |
| 137 | file_path.DebugStr().c_str(), mode.hex, attributes); | 137 | file_path.DebugStr().c_str(), mode.hex, attributes); |
| 138 | } | 138 | } |
| 139 | } | 139 | } |
| @@ -159,7 +159,7 @@ static void DeleteFile(Service::Interface* self) { | |||
| 159 | 159 | ||
| 160 | FileSys::Path file_path(filename_type, filename_size, filename_ptr); | 160 | FileSys::Path file_path(filename_type, filename_size, filename_ptr); |
| 161 | 161 | ||
| 162 | LOG_DEBUG(Service_FS, "type=%d size=%d data=%s", filename_type, filename_size, | 162 | LOG_DEBUG(Service_FS, "type=%u size=%u data=%s", static_cast<u32>(filename_type), filename_size, |
| 163 | file_path.DebugStr().c_str()); | 163 | file_path.DebugStr().c_str()); |
| 164 | 164 | ||
| 165 | cmd_buff[1] = DeleteFileFromArchive(archive_handle, file_path).raw; | 165 | cmd_buff[1] = DeleteFileFromArchive(archive_handle, file_path).raw; |
| @@ -198,9 +198,10 @@ static void RenameFile(Service::Interface* self) { | |||
| 198 | FileSys::Path dest_file_path(dest_filename_type, dest_filename_size, dest_filename_ptr); | 198 | FileSys::Path dest_file_path(dest_filename_type, dest_filename_size, dest_filename_ptr); |
| 199 | 199 | ||
| 200 | LOG_DEBUG(Service_FS, | 200 | LOG_DEBUG(Service_FS, |
| 201 | "src_type=%d src_size=%d src_data=%s dest_type=%d dest_size=%d dest_data=%s", | 201 | "src_type=%u src_size=%u src_data=%s dest_type=%u dest_size=%u dest_data=%s", |
| 202 | src_filename_type, src_filename_size, src_file_path.DebugStr().c_str(), | 202 | static_cast<u32>(src_filename_type), src_filename_size, |
| 203 | dest_filename_type, dest_filename_size, dest_file_path.DebugStr().c_str()); | 203 | src_file_path.DebugStr().c_str(), static_cast<u32>(dest_filename_type), |
| 204 | dest_filename_size, dest_file_path.DebugStr().c_str()); | ||
| 204 | 205 | ||
| 205 | cmd_buff[1] = RenameFileBetweenArchives(src_archive_handle, src_file_path, dest_archive_handle, | 206 | cmd_buff[1] = RenameFileBetweenArchives(src_archive_handle, src_file_path, dest_archive_handle, |
| 206 | dest_file_path) | 207 | dest_file_path) |
| @@ -228,7 +229,7 @@ static void DeleteDirectory(Service::Interface* self) { | |||
| 228 | 229 | ||
| 229 | FileSys::Path dir_path(dirname_type, dirname_size, dirname_ptr); | 230 | FileSys::Path dir_path(dirname_type, dirname_size, dirname_ptr); |
| 230 | 231 | ||
| 231 | LOG_DEBUG(Service_FS, "type=%d size=%d data=%s", dirname_type, dirname_size, | 232 | LOG_DEBUG(Service_FS, "type=%u size=%u data=%s", static_cast<u32>(dirname_type), dirname_size, |
| 232 | dir_path.DebugStr().c_str()); | 233 | dir_path.DebugStr().c_str()); |
| 233 | 234 | ||
| 234 | cmd_buff[1] = DeleteDirectoryFromArchive(archive_handle, dir_path).raw; | 235 | cmd_buff[1] = DeleteDirectoryFromArchive(archive_handle, dir_path).raw; |
| @@ -257,7 +258,7 @@ static void DeleteDirectoryRecursively(Service::Interface* self) { | |||
| 257 | 258 | ||
| 258 | FileSys::Path dir_path(dirname_type, dirname_size, dirname_ptr); | 259 | FileSys::Path dir_path(dirname_type, dirname_size, dirname_ptr); |
| 259 | 260 | ||
| 260 | LOG_DEBUG(Service_FS, "type=%d size=%d data=%s", dirname_type, dirname_size, | 261 | LOG_DEBUG(Service_FS, "type=%u size=%u data=%s", static_cast<u32>(dirname_type), dirname_size, |
| 261 | dir_path.DebugStr().c_str()); | 262 | dir_path.DebugStr().c_str()); |
| 262 | 263 | ||
| 263 | cmd_buff[1] = DeleteDirectoryRecursivelyFromArchive(archive_handle, dir_path).raw; | 264 | cmd_buff[1] = DeleteDirectoryRecursivelyFromArchive(archive_handle, dir_path).raw; |
| @@ -287,7 +288,7 @@ static void CreateFile(Service::Interface* self) { | |||
| 287 | 288 | ||
| 288 | FileSys::Path file_path(filename_type, filename_size, filename_ptr); | 289 | FileSys::Path file_path(filename_type, filename_size, filename_ptr); |
| 289 | 290 | ||
| 290 | LOG_DEBUG(Service_FS, "type=%d size=%llu data=%s", filename_type, file_size, | 291 | LOG_DEBUG(Service_FS, "type=%u size=%llu data=%s", static_cast<u32>(filename_type), file_size, |
| 291 | file_path.DebugStr().c_str()); | 292 | file_path.DebugStr().c_str()); |
| 292 | 293 | ||
| 293 | cmd_buff[1] = CreateFileInArchive(archive_handle, file_path, file_size).raw; | 294 | cmd_buff[1] = CreateFileInArchive(archive_handle, file_path, file_size).raw; |
| @@ -314,7 +315,7 @@ static void CreateDirectory(Service::Interface* self) { | |||
| 314 | 315 | ||
| 315 | FileSys::Path dir_path(dirname_type, dirname_size, dirname_ptr); | 316 | FileSys::Path dir_path(dirname_type, dirname_size, dirname_ptr); |
| 316 | 317 | ||
| 317 | LOG_DEBUG(Service_FS, "type=%d size=%d data=%s", dirname_type, dirname_size, | 318 | LOG_DEBUG(Service_FS, "type=%u size=%d data=%s", static_cast<u32>(dirname_type), dirname_size, |
| 318 | dir_path.DebugStr().c_str()); | 319 | dir_path.DebugStr().c_str()); |
| 319 | 320 | ||
| 320 | cmd_buff[1] = CreateDirectoryFromArchive(archive_handle, dir_path).raw; | 321 | cmd_buff[1] = CreateDirectoryFromArchive(archive_handle, dir_path).raw; |
| @@ -351,10 +352,10 @@ static void RenameDirectory(Service::Interface* self) { | |||
| 351 | FileSys::Path src_dir_path(src_dirname_type, src_dirname_size, src_dirname_ptr); | 352 | FileSys::Path src_dir_path(src_dirname_type, src_dirname_size, src_dirname_ptr); |
| 352 | FileSys::Path dest_dir_path(dest_dirname_type, dest_dirname_size, dest_dirname_ptr); | 353 | FileSys::Path dest_dir_path(dest_dirname_type, dest_dirname_size, dest_dirname_ptr); |
| 353 | 354 | ||
| 354 | LOG_DEBUG(Service_FS, | 355 | LOG_DEBUG( |
| 355 | "src_type=%d src_size=%d src_data=%s dest_type=%d dest_size=%d dest_data=%s", | 356 | Service_FS, "src_type=%u src_size=%u src_data=%s dest_type=%u dest_size=%u dest_data=%s", |
| 356 | src_dirname_type, src_dirname_size, src_dir_path.DebugStr().c_str(), | 357 | static_cast<u32>(src_dirname_type), src_dirname_size, src_dir_path.DebugStr().c_str(), |
| 357 | dest_dirname_type, dest_dirname_size, dest_dir_path.DebugStr().c_str()); | 358 | static_cast<u32>(dest_dirname_type), dest_dirname_size, dest_dir_path.DebugStr().c_str()); |
| 358 | 359 | ||
| 359 | cmd_buff[1] = RenameDirectoryBetweenArchives(src_archive_handle, src_dir_path, | 360 | cmd_buff[1] = RenameDirectoryBetweenArchives(src_archive_handle, src_dir_path, |
| 360 | dest_archive_handle, dest_dir_path) | 361 | dest_archive_handle, dest_dir_path) |
| @@ -384,7 +385,7 @@ static void OpenDirectory(Service::Interface* self) { | |||
| 384 | 385 | ||
| 385 | FileSys::Path dir_path(dirname_type, dirname_size, dirname_ptr); | 386 | FileSys::Path dir_path(dirname_type, dirname_size, dirname_ptr); |
| 386 | 387 | ||
| 387 | LOG_DEBUG(Service_FS, "type=%d size=%d data=%s", dirname_type, dirname_size, | 388 | LOG_DEBUG(Service_FS, "type=%u size=%u data=%s", static_cast<u32>(dirname_type), dirname_size, |
| 388 | dir_path.DebugStr().c_str()); | 389 | dir_path.DebugStr().c_str()); |
| 389 | 390 | ||
| 390 | ResultVal<SharedPtr<Directory>> dir_res = OpenDirectoryFromArchive(archive_handle, dir_path); | 391 | ResultVal<SharedPtr<Directory>> dir_res = OpenDirectoryFromArchive(archive_handle, dir_path); |
| @@ -419,7 +420,7 @@ static void OpenArchive(Service::Interface* self) { | |||
| 419 | u32 archivename_ptr = cmd_buff[5]; | 420 | u32 archivename_ptr = cmd_buff[5]; |
| 420 | FileSys::Path archive_path(archivename_type, archivename_size, archivename_ptr); | 421 | FileSys::Path archive_path(archivename_type, archivename_size, archivename_ptr); |
| 421 | 422 | ||
| 422 | LOG_DEBUG(Service_FS, "archive_id=0x%08X archive_path=%s", archive_id, | 423 | LOG_DEBUG(Service_FS, "archive_id=0x%08X archive_path=%s", static_cast<u32>(archive_id), |
| 423 | archive_path.DebugStr().c_str()); | 424 | archive_path.DebugStr().c_str()); |
| 424 | 425 | ||
| 425 | ResultVal<ArchiveHandle> handle = OpenArchive(archive_id, archive_path); | 426 | ResultVal<ArchiveHandle> handle = OpenArchive(archive_id, archive_path); |
| @@ -431,7 +432,7 @@ static void OpenArchive(Service::Interface* self) { | |||
| 431 | cmd_buff[2] = cmd_buff[3] = 0; | 432 | cmd_buff[2] = cmd_buff[3] = 0; |
| 432 | LOG_ERROR(Service_FS, | 433 | LOG_ERROR(Service_FS, |
| 433 | "failed to get a handle for archive archive_id=0x%08X archive_path=%s", | 434 | "failed to get a handle for archive archive_id=0x%08X archive_path=%s", |
| 434 | archive_id, archive_path.DebugStr().c_str()); | 435 | static_cast<u32>(archive_id), archive_path.DebugStr().c_str()); |
| 435 | } | 436 | } |
| 436 | } | 437 | } |
| 437 | 438 | ||
| @@ -514,7 +515,8 @@ static void FormatSaveData(Service::Interface* self) { | |||
| 514 | LOG_DEBUG(Service_FS, "archive_path=%s", archive_path.DebugStr().c_str()); | 515 | LOG_DEBUG(Service_FS, "archive_path=%s", archive_path.DebugStr().c_str()); |
| 515 | 516 | ||
| 516 | if (archive_id != FS::ArchiveIdCode::SaveData) { | 517 | if (archive_id != FS::ArchiveIdCode::SaveData) { |
| 517 | LOG_ERROR(Service_FS, "tried to format an archive different than SaveData, %u", archive_id); | 518 | LOG_ERROR(Service_FS, "tried to format an archive different than SaveData, %u", |
| 519 | static_cast<u32>(archive_id)); | ||
| 518 | cmd_buff[1] = ResultCode(ErrorDescription::FS_InvalidPath, ErrorModule::FS, | 520 | cmd_buff[1] = ResultCode(ErrorDescription::FS_InvalidPath, ErrorModule::FS, |
| 519 | ErrorSummary::InvalidArgument, ErrorLevel::Usage) | 521 | ErrorSummary::InvalidArgument, ErrorLevel::Usage) |
| 520 | .raw; | 522 | .raw; |