summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--.ci/scripts/format/script.sh2
-rw-r--r--CMakeLists.txt4
-rw-r--r--src/common/alignment.h21
-rw-r--r--src/common/div_ceil.h8
-rw-r--r--src/common/intrusive_red_black_tree.h17
-rw-r--r--src/common/uuid.h7
-rw-r--r--src/common/vector_math.h4
-rw-r--r--src/core/core.cpp2
-rw-r--r--src/core/frontend/applets/profile_select.cpp3
-rw-r--r--src/core/hle/kernel/k_priority_queue.h27
-rw-r--r--src/core/hle/kernel/k_scheduler.h2
-rw-r--r--src/core/hle/kernel/k_scoped_lock.h15
-rw-r--r--src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h2
-rw-r--r--src/core/hle/service/acc/acc.cpp3
-rw-r--r--src/core/hle/service/acc/profile_manager.cpp9
-rw-r--r--src/core/hle/service/am/am.cpp4
-rw-r--r--src/core/hle/service/am/applets/applet_profile_select.cpp2
-rw-r--r--src/core/hle/service/audio/audctl.cpp8
-rw-r--r--src/core/hle/service/audio/audren_u.cpp3
-rw-r--r--src/core/hle/service/btdrv/btdrv.cpp4
-rw-r--r--src/core/hle/service/caps/caps_ss.cpp1
-rw-r--r--src/core/hle/service/es/es.cpp6
-rw-r--r--src/core/hle/service/hid/controllers/npad.h1
-rw-r--r--src/core/hle/service/hid/hid.cpp9
-rw-r--r--src/core/hle/service/npns/npns.cpp1
-rw-r--r--src/core/hle/service/sockets/bsd.cpp14
-rw-r--r--src/core/hle/service/sockets/bsd.h1
-rw-r--r--src/core/hle/service/usb/usb.cpp6
-rw-r--r--src/core/hle/service/vi/vi.cpp1
-rw-r--r--src/input_common/main.cpp4
-rw-r--r--src/shader_recompiler/object_pool.h6
-rw-r--r--src/video_core/renderer_vulkan/renderer_vulkan.cpp13
-rw-r--r--src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp5
-rw-r--r--src/video_core/renderer_vulkan/vk_scheduler.h2
-rw-r--r--src/video_core/texture_cache/slot_vector.h4
-rw-r--r--src/yuzu/configuration/configure_debug.ui181
-rw-r--r--src/yuzu/configuration/configure_tas.ui62
37 files changed, 213 insertions, 251 deletions
diff --git a/.ci/scripts/format/script.sh b/.ci/scripts/format/script.sh
index 969ab637c..c2550c966 100644
--- a/.ci/scripts/format/script.sh
+++ b/.ci/scripts/format/script.sh
@@ -7,7 +7,7 @@ if grep -nrI '\s$' src *.yml *.txt *.md Doxyfile .gitignore .gitmodules .ci* dis
7fi 7fi
8 8
9# Default clang-format points to default 3.5 version one 9# Default clang-format points to default 3.5 version one
10CLANG_FORMAT=clang-format-10 10CLANG_FORMAT=clang-format-12
11$CLANG_FORMAT --version 11$CLANG_FORMAT --version
12 12
13if [ "$TRAVIS_EVENT_TYPE" = "pull_request" ]; then 13if [ "$TRAVIS_EVENT_TYPE" = "pull_request" ]; then
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5df2ff3fa..b7ea86d8a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -135,7 +135,7 @@ endif()
135# boost asio's concept usage doesn't play nicely with some compilers yet. 135# boost asio's concept usage doesn't play nicely with some compilers yet.
136add_definitions(-DBOOST_ASIO_DISABLE_CONCEPTS) 136add_definitions(-DBOOST_ASIO_DISABLE_CONCEPTS)
137if (MSVC) 137if (MSVC)
138 add_compile_options(/std:c++latest) 138 add_compile_options($<$<COMPILE_LANGUAGE:CXX>:/std:c++latest>)
139 139
140 # cubeb and boost still make use of deprecated result_of. 140 # cubeb and boost still make use of deprecated result_of.
141 add_definitions(-D_HAS_DEPRECATED_RESULT_OF) 141 add_definitions(-D_HAS_DEPRECATED_RESULT_OF)
@@ -780,7 +780,7 @@ endif()
780# against all the src files. This should be used before making a pull request. 780# against all the src files. This should be used before making a pull request.
781# ======================================================================= 781# =======================================================================
782 782
783set(CLANG_FORMAT_POSTFIX "-10") 783set(CLANG_FORMAT_POSTFIX "-12")
784find_program(CLANG_FORMAT 784find_program(CLANG_FORMAT
785 NAMES clang-format${CLANG_FORMAT_POSTFIX} 785 NAMES clang-format${CLANG_FORMAT_POSTFIX}
786 clang-format 786 clang-format
diff --git a/src/common/alignment.h b/src/common/alignment.h
index 32d796ffa..1b56569d1 100644
--- a/src/common/alignment.h
+++ b/src/common/alignment.h
@@ -9,41 +9,48 @@
9namespace Common { 9namespace Common {
10 10
11template <typename T> 11template <typename T>
12requires std::is_unsigned_v<T>[[nodiscard]] constexpr T AlignUp(T value, size_t size) { 12requires std::is_unsigned_v<T>
13[[nodiscard]] constexpr T AlignUp(T value, size_t size) {
13 auto mod{static_cast<T>(value % size)}; 14 auto mod{static_cast<T>(value % size)};
14 value -= mod; 15 value -= mod;
15 return static_cast<T>(mod == T{0} ? value : value + size); 16 return static_cast<T>(mod == T{0} ? value : value + size);
16} 17}
17 18
18template <typename T> 19template <typename T>
19requires std::is_unsigned_v<T>[[nodiscard]] constexpr T AlignUpLog2(T value, size_t align_log2) { 20requires std::is_unsigned_v<T>
21[[nodiscard]] constexpr T AlignUpLog2(T value, size_t align_log2) {
20 return static_cast<T>((value + ((1ULL << align_log2) - 1)) >> align_log2 << align_log2); 22 return static_cast<T>((value + ((1ULL << align_log2) - 1)) >> align_log2 << align_log2);
21} 23}
22 24
23template <typename T> 25template <typename T>
24requires std::is_unsigned_v<T>[[nodiscard]] constexpr T AlignDown(T value, size_t size) { 26requires std::is_unsigned_v<T>
27[[nodiscard]] constexpr T AlignDown(T value, size_t size) {
25 return static_cast<T>(value - value % size); 28 return static_cast<T>(value - value % size);
26} 29}
27 30
28template <typename T> 31template <typename T>
29requires std::is_unsigned_v<T>[[nodiscard]] constexpr bool Is4KBAligned(T value) { 32requires std::is_unsigned_v<T>
33[[nodiscard]] constexpr bool Is4KBAligned(T value) {
30 return (value & 0xFFF) == 0; 34 return (value & 0xFFF) == 0;
31} 35}
32 36
33template <typename T> 37template <typename T>
34requires std::is_unsigned_v<T>[[nodiscard]] constexpr bool IsWordAligned(T value) { 38requires std::is_unsigned_v<T>
39[[nodiscard]] constexpr bool IsWordAligned(T value) {
35 return (value & 0b11) == 0; 40 return (value & 0b11) == 0;
36} 41}
37 42
38template <typename T> 43template <typename T>
39requires std::is_integral_v<T>[[nodiscard]] constexpr bool IsAligned(T value, size_t alignment) { 44requires std::is_integral_v<T>
45[[nodiscard]] constexpr bool IsAligned(T value, size_t alignment) {
40 using U = typename std::make_unsigned_t<T>; 46 using U = typename std::make_unsigned_t<T>;
41 const U mask = static_cast<U>(alignment - 1); 47 const U mask = static_cast<U>(alignment - 1);
42 return (value & mask) == 0; 48 return (value & mask) == 0;
43} 49}
44 50
45template <typename T, typename U> 51template <typename T, typename U>
46requires std::is_integral_v<T>[[nodiscard]] constexpr T DivideUp(T x, U y) { 52requires std::is_integral_v<T>
53[[nodiscard]] constexpr T DivideUp(T x, U y) {
47 return (x + (y - 1)) / y; 54 return (x + (y - 1)) / y;
48} 55}
49 56
diff --git a/src/common/div_ceil.h b/src/common/div_ceil.h
index 95e1489a9..e1db35464 100644
--- a/src/common/div_ceil.h
+++ b/src/common/div_ceil.h
@@ -11,15 +11,15 @@ namespace Common {
11 11
12/// Ceiled integer division. 12/// Ceiled integer division.
13template <typename N, typename D> 13template <typename N, typename D>
14requires std::is_integral_v<N>&& std::is_unsigned_v<D>[[nodiscard]] constexpr N DivCeil(N number, 14requires std::is_integral_v<N> && std::is_unsigned_v<D>
15 D divisor) { 15[[nodiscard]] constexpr N DivCeil(N number, D divisor) {
16 return static_cast<N>((static_cast<D>(number) + divisor - 1) / divisor); 16 return static_cast<N>((static_cast<D>(number) + divisor - 1) / divisor);
17} 17}
18 18
19/// Ceiled integer division with logarithmic divisor in base 2 19/// Ceiled integer division with logarithmic divisor in base 2
20template <typename N, typename D> 20template <typename N, typename D>
21requires std::is_integral_v<N>&& std::is_unsigned_v<D>[[nodiscard]] constexpr N DivCeilLog2( 21requires std::is_integral_v<N> && std::is_unsigned_v<D>
22 N value, D alignment_log2) { 22[[nodiscard]] constexpr N DivCeilLog2(N value, D alignment_log2) {
23 return static_cast<N>((static_cast<D>(value) + (D(1) << alignment_log2) - 1) >> alignment_log2); 23 return static_cast<N>((static_cast<D>(value) + (D(1) << alignment_log2) - 1) >> alignment_log2);
24} 24}
25 25
diff --git a/src/common/intrusive_red_black_tree.h b/src/common/intrusive_red_black_tree.h
index 1f696fe80..3173cc449 100644
--- a/src/common/intrusive_red_black_tree.h
+++ b/src/common/intrusive_red_black_tree.h
@@ -235,20 +235,19 @@ public:
235 235
236template <typename T> 236template <typename T>
237concept HasLightCompareType = requires { 237concept HasLightCompareType = requires {
238 { std::is_same<typename T::LightCompareType, void>::value } 238 { std::is_same<typename T::LightCompareType, void>::value } -> std::convertible_to<bool>;
239 ->std::convertible_to<bool>;
240}; 239};
241 240
242namespace impl { 241namespace impl {
243 242
244template <typename T, typename Default> 243 template <typename T, typename Default>
245consteval auto* GetLightCompareType() { 244 consteval auto* GetLightCompareType() {
246 if constexpr (HasLightCompareType<T>) { 245 if constexpr (HasLightCompareType<T>) {
247 return static_cast<typename T::LightCompareType*>(nullptr); 246 return static_cast<typename T::LightCompareType*>(nullptr);
248 } else { 247 } else {
249 return static_cast<Default*>(nullptr); 248 return static_cast<Default*>(nullptr);
249 }
250 } 250 }
251}
252 251
253} // namespace impl 252} // namespace impl
254 253
diff --git a/src/common/uuid.h b/src/common/uuid.h
index 2353179d8..8ea01f8da 100644
--- a/src/common/uuid.h
+++ b/src/common/uuid.h
@@ -58,6 +58,13 @@ struct UUID {
58 uuid = INVALID_UUID; 58 uuid = INVALID_UUID;
59 } 59 }
60 60
61 [[nodiscard]] constexpr bool IsInvalid() const {
62 return uuid == INVALID_UUID;
63 }
64 [[nodiscard]] constexpr bool IsValid() const {
65 return !IsInvalid();
66 }
67
61 // TODO(ogniK): Properly generate a Nintendo ID 68 // TODO(ogniK): Properly generate a Nintendo ID
62 [[nodiscard]] constexpr u64 GetNintendoID() const { 69 [[nodiscard]] constexpr u64 GetNintendoID() const {
63 return uuid[0]; 70 return uuid[0];
diff --git a/src/common/vector_math.h b/src/common/vector_math.h
index 22dba3c2d..ba7c363c1 100644
--- a/src/common/vector_math.h
+++ b/src/common/vector_math.h
@@ -667,8 +667,8 @@ template <typename T>
667 667
668// linear interpolation via float: 0.0=begin, 1.0=end 668// linear interpolation via float: 0.0=begin, 1.0=end
669template <typename X> 669template <typename X>
670[[nodiscard]] constexpr decltype(X{} * float{} + X{} * float{}) Lerp(const X& begin, const X& end, 670[[nodiscard]] constexpr decltype(X{} * float{} + X{} * float{})
671 const float t) { 671 Lerp(const X& begin, const X& end, const float t) {
672 return begin * (1.f - t) + end * t; 672 return begin * (1.f - t) + end * t;
673} 673}
674 674
diff --git a/src/core/core.cpp b/src/core/core.cpp
index 54ebed2c1..50d5dab4b 100644
--- a/src/core/core.cpp
+++ b/src/core/core.cpp
@@ -305,7 +305,6 @@ struct System::Impl {
305 is_powered_on = false; 305 is_powered_on = false;
306 exit_lock = false; 306 exit_lock = false;
307 307
308 gpu_core.reset();
309 services.reset(); 308 services.reset();
310 service_manager.reset(); 309 service_manager.reset();
311 cheat_engine.reset(); 310 cheat_engine.reset();
@@ -315,6 +314,7 @@ struct System::Impl {
315 core_timing.Shutdown(); 314 core_timing.Shutdown();
316 app_loader.reset(); 315 app_loader.reset();
317 perf_stats.reset(); 316 perf_stats.reset();
317 gpu_core.reset();
318 kernel.Shutdown(); 318 kernel.Shutdown();
319 memory.Reset(); 319 memory.Reset();
320 applet_manager.ClearAll(); 320 applet_manager.ClearAll();
diff --git a/src/core/frontend/applets/profile_select.cpp b/src/core/frontend/applets/profile_select.cpp
index 4c58c310f..3e4f90be2 100644
--- a/src/core/frontend/applets/profile_select.cpp
+++ b/src/core/frontend/applets/profile_select.cpp
@@ -13,7 +13,8 @@ ProfileSelectApplet::~ProfileSelectApplet() = default;
13void DefaultProfileSelectApplet::SelectProfile( 13void DefaultProfileSelectApplet::SelectProfile(
14 std::function<void(std::optional<Common::UUID>)> callback) const { 14 std::function<void(std::optional<Common::UUID>)> callback) const {
15 Service::Account::ProfileManager manager; 15 Service::Account::ProfileManager manager;
16 callback(manager.GetUser(Settings::values.current_user.GetValue()).value_or(Common::UUID{})); 16 callback(manager.GetUser(Settings::values.current_user.GetValue())
17 .value_or(Common::UUID{Common::INVALID_UUID}));
17 LOG_INFO(Service_ACC, "called, selecting current user instead of prompting..."); 18 LOG_INFO(Service_ACC, "called, selecting current user instead of prompting...");
18} 19}
19 20
diff --git a/src/core/hle/kernel/k_priority_queue.h b/src/core/hle/kernel/k_priority_queue.h
index 4aa669d95..f4d71ad7e 100644
--- a/src/core/hle/kernel/k_priority_queue.h
+++ b/src/core/hle/kernel/k_priority_queue.h
@@ -22,12 +22,10 @@ class KThread;
22 22
23template <typename T> 23template <typename T>
24concept KPriorityQueueAffinityMask = !std::is_reference_v<T> && requires(T & t) { 24concept KPriorityQueueAffinityMask = !std::is_reference_v<T> && requires(T & t) {
25 { t.GetAffinityMask() } 25 { t.GetAffinityMask() } -> Common::ConvertibleTo<u64>;
26 ->Common::ConvertibleTo<u64>;
27 {t.SetAffinityMask(0)}; 26 {t.SetAffinityMask(0)};
28 27
29 { t.GetAffinity(0) } 28 { t.GetAffinity(0) } -> std::same_as<bool>;
30 ->std::same_as<bool>;
31 {t.SetAffinity(0, false)}; 29 {t.SetAffinity(0, false)};
32 {t.SetAll()}; 30 {t.SetAll()};
33}; 31};
@@ -38,25 +36,20 @@ concept KPriorityQueueMember = !std::is_reference_v<T> && requires(T & t) {
38 {(typename T::QueueEntry()).Initialize()}; 36 {(typename T::QueueEntry()).Initialize()};
39 {(typename T::QueueEntry()).SetPrev(std::addressof(t))}; 37 {(typename T::QueueEntry()).SetPrev(std::addressof(t))};
40 {(typename T::QueueEntry()).SetNext(std::addressof(t))}; 38 {(typename T::QueueEntry()).SetNext(std::addressof(t))};
41 { (typename T::QueueEntry()).GetNext() } 39 { (typename T::QueueEntry()).GetNext() } -> std::same_as<T*>;
42 ->std::same_as<T*>; 40 { (typename T::QueueEntry()).GetPrev() } -> std::same_as<T*>;
43 { (typename T::QueueEntry()).GetPrev() } 41 { t.GetPriorityQueueEntry(0) } -> std::same_as<typename T::QueueEntry&>;
44 ->std::same_as<T*>;
45 { t.GetPriorityQueueEntry(0) }
46 ->std::same_as<typename T::QueueEntry&>;
47 42
48 {t.GetAffinityMask()}; 43 {t.GetAffinityMask()};
49 { std::remove_cvref_t<decltype(t.GetAffinityMask())>() } 44 { std::remove_cvref_t<decltype(t.GetAffinityMask())>() } -> KPriorityQueueAffinityMask;
50 ->KPriorityQueueAffinityMask;
51 45
52 { t.GetActiveCore() } 46 { t.GetActiveCore() } -> Common::ConvertibleTo<s32>;
53 ->Common::ConvertibleTo<s32>; 47 { t.GetPriority() } -> Common::ConvertibleTo<s32>;
54 { t.GetPriority() }
55 ->Common::ConvertibleTo<s32>;
56}; 48};
57 49
58template <typename Member, size_t NumCores_, int LowestPriority, int HighestPriority> 50template <typename Member, size_t NumCores_, int LowestPriority, int HighestPriority>
59requires KPriorityQueueMember<Member> class KPriorityQueue { 51requires KPriorityQueueMember<Member>
52class KPriorityQueue {
60public: 53public:
61 using AffinityMaskType = std::remove_cv_t< 54 using AffinityMaskType = std::remove_cv_t<
62 std::remove_reference_t<decltype(std::declval<Member>().GetAffinityMask())>>; 55 std::remove_reference_t<decltype(std::declval<Member>().GetAffinityMask())>>;
diff --git a/src/core/hle/kernel/k_scheduler.h b/src/core/hle/kernel/k_scheduler.h
index 12cfae919..c8ccc1ae4 100644
--- a/src/core/hle/kernel/k_scheduler.h
+++ b/src/core/hle/kernel/k_scheduler.h
@@ -197,7 +197,7 @@ private:
197 197
198class [[nodiscard]] KScopedSchedulerLock : KScopedLock<GlobalSchedulerContext::LockType> { 198class [[nodiscard]] KScopedSchedulerLock : KScopedLock<GlobalSchedulerContext::LockType> {
199public: 199public:
200 explicit KScopedSchedulerLock(KernelCore & kernel); 200 explicit KScopedSchedulerLock(KernelCore& kernel);
201 ~KScopedSchedulerLock(); 201 ~KScopedSchedulerLock();
202}; 202};
203 203
diff --git a/src/core/hle/kernel/k_scoped_lock.h b/src/core/hle/kernel/k_scoped_lock.h
index 72c3b0252..4fb180fc6 100644
--- a/src/core/hle/kernel/k_scoped_lock.h
+++ b/src/core/hle/kernel/k_scoped_lock.h
@@ -13,19 +13,18 @@ namespace Kernel {
13 13
14template <typename T> 14template <typename T>
15concept KLockable = !std::is_reference_v<T> && requires(T & t) { 15concept KLockable = !std::is_reference_v<T> && requires(T & t) {
16 { t.Lock() } 16 { t.Lock() } -> std::same_as<void>;
17 ->std::same_as<void>; 17 { t.Unlock() } -> std::same_as<void>;
18 { t.Unlock() }
19 ->std::same_as<void>;
20}; 18};
21 19
22template <typename T> 20template <typename T>
23requires KLockable<T> class [[nodiscard]] KScopedLock { 21requires KLockable<T>
22class [[nodiscard]] KScopedLock {
24public: 23public:
25 explicit KScopedLock(T * l) : lock_ptr(l) { 24 explicit KScopedLock(T* l) : lock_ptr(l) {
26 this->lock_ptr->Lock(); 25 this->lock_ptr->Lock();
27 } 26 }
28 explicit KScopedLock(T & l) : KScopedLock(std::addressof(l)) {} 27 explicit KScopedLock(T& l) : KScopedLock(std::addressof(l)) {}
29 28
30 ~KScopedLock() { 29 ~KScopedLock() {
31 this->lock_ptr->Unlock(); 30 this->lock_ptr->Unlock();
@@ -34,7 +33,7 @@ public:
34 KScopedLock(const KScopedLock&) = delete; 33 KScopedLock(const KScopedLock&) = delete;
35 KScopedLock& operator=(const KScopedLock&) = delete; 34 KScopedLock& operator=(const KScopedLock&) = delete;
36 35
37 KScopedLock(KScopedLock &&) = delete; 36 KScopedLock(KScopedLock&&) = delete;
38 KScopedLock& operator=(KScopedLock&&) = delete; 37 KScopedLock& operator=(KScopedLock&&) = delete;
39 38
40private: 39private:
diff --git a/src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h b/src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h
index a86af56dd..f6c75f2d9 100644
--- a/src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h
+++ b/src/core/hle/kernel/k_scoped_scheduler_lock_and_sleep.h
@@ -17,7 +17,7 @@ namespace Kernel {
17 17
18class [[nodiscard]] KScopedSchedulerLockAndSleep { 18class [[nodiscard]] KScopedSchedulerLockAndSleep {
19public: 19public:
20 explicit KScopedSchedulerLockAndSleep(KernelCore & kernel_, KThread * t, s64 timeout) 20 explicit KScopedSchedulerLockAndSleep(KernelCore& kernel_, KThread* t, s64 timeout)
21 : kernel(kernel_), thread(t), timeout_tick(timeout) { 21 : kernel(kernel_), thread(t), timeout_tick(timeout) {
22 // Lock the scheduler. 22 // Lock the scheduler.
23 kernel.GlobalSchedulerContext().scheduler_lock.Lock(); 23 kernel.GlobalSchedulerContext().scheduler_lock.Lock();
diff --git a/src/core/hle/service/acc/acc.cpp b/src/core/hle/service/acc/acc.cpp
index 6d9ec0a8a..689b36056 100644
--- a/src/core/hle/service/acc/acc.cpp
+++ b/src/core/hle/service/acc/acc.cpp
@@ -929,8 +929,7 @@ void Module::Interface::TrySelectUserWithoutInteraction(Kernel::HLERequestContex
929 } 929 }
930 930
931 const auto user_list = profile_manager->GetAllUsers(); 931 const auto user_list = profile_manager->GetAllUsers();
932 if (std::all_of(user_list.begin(), user_list.end(), 932 if (std::ranges::all_of(user_list, [](const auto& user) { return user.IsInvalid(); })) {
933 [](const auto& user) { return user.uuid == Common::INVALID_UUID; })) {
934 rb.Push(ResultUnknown); // TODO(ogniK): Find the correct error code 933 rb.Push(ResultUnknown); // TODO(ogniK): Find the correct error code
935 rb.PushRaw<u128>(Common::INVALID_UUID); 934 rb.PushRaw<u128>(Common::INVALID_UUID);
936 return; 935 return;
diff --git a/src/core/hle/service/acc/profile_manager.cpp b/src/core/hle/service/acc/profile_manager.cpp
index 24a1c9157..568303ced 100644
--- a/src/core/hle/service/acc/profile_manager.cpp
+++ b/src/core/hle/service/acc/profile_manager.cpp
@@ -208,9 +208,10 @@ bool ProfileManager::UserExists(UUID uuid) const {
208} 208}
209 209
210bool ProfileManager::UserExistsIndex(std::size_t index) const { 210bool ProfileManager::UserExistsIndex(std::size_t index) const {
211 if (index >= MAX_USERS) 211 if (index >= MAX_USERS) {
212 return false; 212 return false;
213 return profiles[index].user_uuid.uuid != Common::INVALID_UUID; 213 }
214 return profiles[index].user_uuid.IsValid();
214} 215}
215 216
216/// Opens a specific user 217/// Opens a specific user
@@ -304,7 +305,7 @@ bool ProfileManager::RemoveUser(UUID uuid) {
304 305
305bool ProfileManager::SetProfileBase(UUID uuid, const ProfileBase& profile_new) { 306bool ProfileManager::SetProfileBase(UUID uuid, const ProfileBase& profile_new) {
306 const auto index = GetUserIndex(uuid); 307 const auto index = GetUserIndex(uuid);
307 if (!index || profile_new.user_uuid == UUID(Common::INVALID_UUID)) { 308 if (!index || profile_new.user_uuid.IsInvalid()) {
308 return false; 309 return false;
309 } 310 }
310 311
@@ -346,7 +347,7 @@ void ProfileManager::ParseUserSaveFile() {
346 } 347 }
347 348
348 for (const auto& user : data.users) { 349 for (const auto& user : data.users) {
349 if (user.uuid == UUID(Common::INVALID_UUID)) { 350 if (user.uuid.IsInvalid()) {
350 continue; 351 continue;
351 } 352 }
352 353
diff --git a/src/core/hle/service/am/am.cpp b/src/core/hle/service/am/am.cpp
index c3ac73131..8c2e2f920 100644
--- a/src/core/hle/service/am/am.cpp
+++ b/src/core/hle/service/am/am.cpp
@@ -275,12 +275,14 @@ ISelfController::ISelfController(Core::System& system_, NVFlinger::NVFlinger& nv
275 {18, nullptr, "SetRequiresCaptureButtonShortPressedMessage"}, 275 {18, nullptr, "SetRequiresCaptureButtonShortPressedMessage"},
276 {19, &ISelfController::SetAlbumImageOrientation, "SetAlbumImageOrientation"}, 276 {19, &ISelfController::SetAlbumImageOrientation, "SetAlbumImageOrientation"},
277 {20, nullptr, "SetDesirableKeyboardLayout"}, 277 {20, nullptr, "SetDesirableKeyboardLayout"},
278 {21, nullptr, "GetScreenShotProgramId"},
278 {40, &ISelfController::CreateManagedDisplayLayer, "CreateManagedDisplayLayer"}, 279 {40, &ISelfController::CreateManagedDisplayLayer, "CreateManagedDisplayLayer"},
279 {41, nullptr, "IsSystemBufferSharingEnabled"}, 280 {41, nullptr, "IsSystemBufferSharingEnabled"},
280 {42, nullptr, "GetSystemSharedLayerHandle"}, 281 {42, nullptr, "GetSystemSharedLayerHandle"},
281 {43, nullptr, "GetSystemSharedBufferHandle"}, 282 {43, nullptr, "GetSystemSharedBufferHandle"},
282 {44, &ISelfController::CreateManagedDisplaySeparableLayer, "CreateManagedDisplaySeparableLayer"}, 283 {44, &ISelfController::CreateManagedDisplaySeparableLayer, "CreateManagedDisplaySeparableLayer"},
283 {45, nullptr, "SetManagedDisplayLayerSeparationMode"}, 284 {45, nullptr, "SetManagedDisplayLayerSeparationMode"},
285 {46, nullptr, "SetRecordingLayerCompositionEnabled"},
284 {50, &ISelfController::SetHandlesRequestToDisplay, "SetHandlesRequestToDisplay"}, 286 {50, &ISelfController::SetHandlesRequestToDisplay, "SetHandlesRequestToDisplay"},
285 {51, nullptr, "ApproveToDisplay"}, 287 {51, nullptr, "ApproveToDisplay"},
286 {60, nullptr, "OverrideAutoSleepTimeAndDimmingTime"}, 288 {60, nullptr, "OverrideAutoSleepTimeAndDimmingTime"},
@@ -302,6 +304,7 @@ ISelfController::ISelfController(Core::System& system_, NVFlinger::NVFlinger& nv
302 {100, &ISelfController::SetAlbumImageTakenNotificationEnabled, "SetAlbumImageTakenNotificationEnabled"}, 304 {100, &ISelfController::SetAlbumImageTakenNotificationEnabled, "SetAlbumImageTakenNotificationEnabled"},
303 {110, nullptr, "SetApplicationAlbumUserData"}, 305 {110, nullptr, "SetApplicationAlbumUserData"},
304 {120, nullptr, "SaveCurrentScreenshot"}, 306 {120, nullptr, "SaveCurrentScreenshot"},
307 {130, nullptr, "SetRecordVolumeMuted"},
305 {1000, nullptr, "GetDebugStorageChannel"}, 308 {1000, nullptr, "GetDebugStorageChannel"},
306 }; 309 };
307 // clang-format on 310 // clang-format on
@@ -683,6 +686,7 @@ ICommonStateGetter::ICommonStateGetter(Core::System& system_,
683 {91, nullptr, "GetCurrentPerformanceConfiguration"}, 686 {91, nullptr, "GetCurrentPerformanceConfiguration"},
684 {100, nullptr, "SetHandlingHomeButtonShortPressedEnabled"}, 687 {100, nullptr, "SetHandlingHomeButtonShortPressedEnabled"},
685 {110, nullptr, "OpenMyGpuErrorHandler"}, 688 {110, nullptr, "OpenMyGpuErrorHandler"},
689 {120, nullptr, "GetAppletLaunchedHistory"},
686 {200, nullptr, "GetOperationModeSystemInfo"}, 690 {200, nullptr, "GetOperationModeSystemInfo"},
687 {300, nullptr, "GetSettingsPlatformRegion"}, 691 {300, nullptr, "GetSettingsPlatformRegion"},
688 {400, nullptr, "ActivateMigrationService"}, 692 {400, nullptr, "ActivateMigrationService"},
diff --git a/src/core/hle/service/am/applets/applet_profile_select.cpp b/src/core/hle/service/am/applets/applet_profile_select.cpp
index bdc21778e..a6e891944 100644
--- a/src/core/hle/service/am/applets/applet_profile_select.cpp
+++ b/src/core/hle/service/am/applets/applet_profile_select.cpp
@@ -60,7 +60,7 @@ void ProfileSelect::Execute() {
60void ProfileSelect::SelectionComplete(std::optional<Common::UUID> uuid) { 60void ProfileSelect::SelectionComplete(std::optional<Common::UUID> uuid) {
61 UserSelectionOutput output{}; 61 UserSelectionOutput output{};
62 62
63 if (uuid.has_value() && uuid->uuid != Common::INVALID_UUID) { 63 if (uuid.has_value() && uuid->IsValid()) {
64 output.result = 0; 64 output.result = 0;
65 output.uuid_selected = uuid->uuid; 65 output.uuid_selected = uuid->uuid;
66 } else { 66 } else {
diff --git a/src/core/hle/service/audio/audctl.cpp b/src/core/hle/service/audio/audctl.cpp
index 8c4c49b85..2e46e7161 100644
--- a/src/core/hle/service/audio/audctl.cpp
+++ b/src/core/hle/service/audio/audctl.cpp
@@ -41,6 +41,14 @@ AudCtl::AudCtl(Core::System& system_) : ServiceFramework{system_, "audctl"} {
41 {27, nullptr, "SetVolumeMappingTableForDev"}, 41 {27, nullptr, "SetVolumeMappingTableForDev"},
42 {28, nullptr, "GetAudioOutputChannelCountForPlayReport"}, 42 {28, nullptr, "GetAudioOutputChannelCountForPlayReport"},
43 {29, nullptr, "BindAudioOutputChannelCountUpdateEventForPlayReport"}, 43 {29, nullptr, "BindAudioOutputChannelCountUpdateEventForPlayReport"},
44 {30, nullptr, "Unknown30"},
45 {31, nullptr, "Unknown31"},
46 {32, nullptr, "Unknown32"},
47 {33, nullptr, "Unknown33"},
48 {34, nullptr, "Unknown34"},
49 {10000, nullptr, "Unknown10000"},
50 {10001, nullptr, "Unknown10001"},
51 {10002, nullptr, "Unknown10002"},
44 }; 52 };
45 // clang-format on 53 // clang-format on
46 54
diff --git a/src/core/hle/service/audio/audren_u.cpp b/src/core/hle/service/audio/audren_u.cpp
index b769fe959..1a91719f5 100644
--- a/src/core/hle/service/audio/audren_u.cpp
+++ b/src/core/hle/service/audio/audren_u.cpp
@@ -187,7 +187,8 @@ public:
187 {10, &IAudioDevice::GetActiveAudioDeviceName, "GetActiveAudioDeviceNameAuto"}, 187 {10, &IAudioDevice::GetActiveAudioDeviceName, "GetActiveAudioDeviceNameAuto"},
188 {11, &IAudioDevice::QueryAudioDeviceInputEvent, "QueryAudioDeviceInputEvent"}, 188 {11, &IAudioDevice::QueryAudioDeviceInputEvent, "QueryAudioDeviceInputEvent"},
189 {12, &IAudioDevice::QueryAudioDeviceOutputEvent, "QueryAudioDeviceOutputEvent"}, 189 {12, &IAudioDevice::QueryAudioDeviceOutputEvent, "QueryAudioDeviceOutputEvent"},
190 {13, nullptr, "GetAudioSystemMasterVolumeSetting"}, 190 {13, nullptr, "GetActiveAudioOutputDeviceName"},
191 {14, nullptr, "ListAudioOutputDeviceName"},
191 }; 192 };
192 RegisterHandlers(functions); 193 RegisterHandlers(functions);
193 } 194 }
diff --git a/src/core/hle/service/btdrv/btdrv.cpp b/src/core/hle/service/btdrv/btdrv.cpp
index 46da438ef..acf791de2 100644
--- a/src/core/hle/service/btdrv/btdrv.cpp
+++ b/src/core/hle/service/btdrv/btdrv.cpp
@@ -175,6 +175,10 @@ public:
175 {143, nullptr, "GetAudioControlInputState"}, 175 {143, nullptr, "GetAudioControlInputState"},
176 {144, nullptr, "AcquireAudioConnectionStateChangedEvent"}, 176 {144, nullptr, "AcquireAudioConnectionStateChangedEvent"},
177 {145, nullptr, "GetConnectedAudioDevice"}, 177 {145, nullptr, "GetConnectedAudioDevice"},
178 {146, nullptr, "CloseAudioControlInput"},
179 {147, nullptr, "RegisterAudioControlNotification"},
180 {148, nullptr, "SendAudioControlPassthroughCommand"},
181 {149, nullptr, "SendAudioControlSetAbsoluteVolumeCommand"},
178 {256, nullptr, "IsManufacturingMode"}, 182 {256, nullptr, "IsManufacturingMode"},
179 {257, nullptr, "EmulateBluetoothCrash"}, 183 {257, nullptr, "EmulateBluetoothCrash"},
180 {258, nullptr, "GetBleChannelMap"}, 184 {258, nullptr, "GetBleChannelMap"},
diff --git a/src/core/hle/service/caps/caps_ss.cpp b/src/core/hle/service/caps/caps_ss.cpp
index 2b5314691..33a976ddf 100644
--- a/src/core/hle/service/caps/caps_ss.cpp
+++ b/src/core/hle/service/caps/caps_ss.cpp
@@ -15,6 +15,7 @@ CAPS_SS::CAPS_SS(Core::System& system_) : ServiceFramework{system_, "caps:ss"} {
15 {204, nullptr, "SaveEditedScreenShotEx0"}, 15 {204, nullptr, "SaveEditedScreenShotEx0"},
16 {206, nullptr, "Unknown206"}, 16 {206, nullptr, "Unknown206"},
17 {208, nullptr, "SaveScreenShotOfMovieEx1"}, 17 {208, nullptr, "SaveScreenShotOfMovieEx1"},
18 {1000, nullptr, "Unknown1000"},
18 }; 19 };
19 // clang-format on 20 // clang-format on
20 21
diff --git a/src/core/hle/service/es/es.cpp b/src/core/hle/service/es/es.cpp
index 110c7cb1c..f6184acc9 100644
--- a/src/core/hle/service/es/es.cpp
+++ b/src/core/hle/service/es/es.cpp
@@ -55,6 +55,8 @@ public:
55 {36, nullptr, "DeleteAllInactiveELicenseRequiredPersonalizedTicket"}, 55 {36, nullptr, "DeleteAllInactiveELicenseRequiredPersonalizedTicket"},
56 {37, nullptr, "OwnTicket2"}, 56 {37, nullptr, "OwnTicket2"},
57 {38, nullptr, "OwnTicket3"}, 57 {38, nullptr, "OwnTicket3"},
58 {39, nullptr, "DeleteAllInactivePersonalizedTicket"},
59 {40, nullptr, "DeletePrepurchaseRecordByNintendoAccountId"},
58 {501, nullptr, "Unknown501"}, 60 {501, nullptr, "Unknown501"},
59 {502, nullptr, "Unknown502"}, 61 {502, nullptr, "Unknown502"},
60 {503, nullptr, "GetTitleKey"}, 62 {503, nullptr, "GetTitleKey"},
@@ -88,11 +90,15 @@ public:
88 {1503, nullptr, "Unknown1503"}, 90 {1503, nullptr, "Unknown1503"},
89 {1504, nullptr, "Unknown1504"}, 91 {1504, nullptr, "Unknown1504"},
90 {1505, nullptr, "Unknown1505"}, 92 {1505, nullptr, "Unknown1505"},
93 {1506, nullptr, "Unknown1506"},
91 {2000, nullptr, "Unknown2000"}, 94 {2000, nullptr, "Unknown2000"},
92 {2001, nullptr, "Unknown2001"}, 95 {2001, nullptr, "Unknown2001"},
96 {2002, nullptr, "Unknown2002"},
97 {2003, nullptr, "Unknown2003"},
93 {2100, nullptr, "Unknown2100"}, 98 {2100, nullptr, "Unknown2100"},
94 {2501, nullptr, "Unknown2501"}, 99 {2501, nullptr, "Unknown2501"},
95 {2502, nullptr, "Unknown2502"}, 100 {2502, nullptr, "Unknown2502"},
101 {2601, nullptr, "Unknown2601"},
96 {3001, nullptr, "Unknown3001"}, 102 {3001, nullptr, "Unknown3001"},
97 {3002, nullptr, "Unknown3002"}, 103 {3002, nullptr, "Unknown3002"},
98 }; 104 };
diff --git a/src/core/hle/service/hid/controllers/npad.h b/src/core/hle/service/hid/controllers/npad.h
index 4fcc6f93a..9ee146caf 100644
--- a/src/core/hle/service/hid/controllers/npad.h
+++ b/src/core/hle/service/hid/controllers/npad.h
@@ -507,6 +507,7 @@ private:
507 LarkNesRight = 18, 507 LarkNesRight = 18,
508 Lucia = 19, 508 Lucia = 19,
509 Verification = 20, 509 Verification = 20,
510 Lagon = 21,
510 }; 511 };
511 512
512 struct NPadEntry { 513 struct NPadEntry {
diff --git a/src/core/hle/service/hid/hid.cpp b/src/core/hle/service/hid/hid.cpp
index a1707a72a..c930996ab 100644
--- a/src/core/hle/service/hid/hid.cpp
+++ b/src/core/hle/service/hid/hid.cpp
@@ -239,6 +239,12 @@ Hid::Hid(Core::System& system_)
239 {81, &Hid::ResetGyroscopeZeroDriftMode, "ResetGyroscopeZeroDriftMode"}, 239 {81, &Hid::ResetGyroscopeZeroDriftMode, "ResetGyroscopeZeroDriftMode"},
240 {82, &Hid::IsSixAxisSensorAtRest, "IsSixAxisSensorAtRest"}, 240 {82, &Hid::IsSixAxisSensorAtRest, "IsSixAxisSensorAtRest"},
241 {83, &Hid::IsFirmwareUpdateAvailableForSixAxisSensor, "IsFirmwareUpdateAvailableForSixAxisSensor"}, 241 {83, &Hid::IsFirmwareUpdateAvailableForSixAxisSensor, "IsFirmwareUpdateAvailableForSixAxisSensor"},
242 {84, nullptr, "EnableSixAxisSensorUnalteredPassthrough"},
243 {85, nullptr, "IsSixAxisSensorUnalteredPassthroughEnabled"},
244 {86, nullptr, "StoreSixAxisSensorCalibrationParameter"},
245 {87, nullptr, "LoadSixAxisSensorCalibrationParameter"},
246 {88, nullptr, "GetSixAxisSensorIcInformation"},
247 {89, nullptr, "ResetIsSixAxisSensorDeviceNewlyAssigned"},
242 {91, &Hid::ActivateGesture, "ActivateGesture"}, 248 {91, &Hid::ActivateGesture, "ActivateGesture"},
243 {100, &Hid::SetSupportedNpadStyleSet, "SetSupportedNpadStyleSet"}, 249 {100, &Hid::SetSupportedNpadStyleSet, "SetSupportedNpadStyleSet"},
244 {101, &Hid::GetSupportedNpadStyleSet, "GetSupportedNpadStyleSet"}, 250 {101, &Hid::GetSupportedNpadStyleSet, "GetSupportedNpadStyleSet"},
@@ -1656,6 +1662,9 @@ public:
1656 {12, nullptr, "UnsetTouchScreenAutoPilotState"}, 1662 {12, nullptr, "UnsetTouchScreenAutoPilotState"},
1657 {13, nullptr, "GetTouchScreenConfiguration"}, 1663 {13, nullptr, "GetTouchScreenConfiguration"},
1658 {14, nullptr, "ProcessTouchScreenAutoTune"}, 1664 {14, nullptr, "ProcessTouchScreenAutoTune"},
1665 {15, nullptr, "ForceStopTouchScreenManagement"},
1666 {16, nullptr, "ForceRestartTouchScreenManagement"},
1667 {17, nullptr, "IsTouchScreenManaged"},
1659 {20, nullptr, "DeactivateMouse"}, 1668 {20, nullptr, "DeactivateMouse"},
1660 {21, nullptr, "SetMouseAutoPilotState"}, 1669 {21, nullptr, "SetMouseAutoPilotState"},
1661 {22, nullptr, "UnsetMouseAutoPilotState"}, 1670 {22, nullptr, "UnsetMouseAutoPilotState"},
diff --git a/src/core/hle/service/npns/npns.cpp b/src/core/hle/service/npns/npns.cpp
index e4c703da4..32533cd94 100644
--- a/src/core/hle/service/npns/npns.cpp
+++ b/src/core/hle/service/npns/npns.cpp
@@ -31,6 +31,7 @@ public:
31 {24, nullptr, "DestroyTokenWithApplicationId"}, 31 {24, nullptr, "DestroyTokenWithApplicationId"},
32 {25, nullptr, "QueryIsTokenValid"}, 32 {25, nullptr, "QueryIsTokenValid"},
33 {26, nullptr, "ListenToMyApplicationId"}, 33 {26, nullptr, "ListenToMyApplicationId"},
34 {27, nullptr, "DestroyTokenAll"},
34 {31, nullptr, "UploadTokenToBaaS"}, 35 {31, nullptr, "UploadTokenToBaaS"},
35 {32, nullptr, "DestroyTokenForBaaS"}, 36 {32, nullptr, "DestroyTokenForBaaS"},
36 {33, nullptr, "CreateTokenForBaaS"}, 37 {33, nullptr, "CreateTokenForBaaS"},
diff --git a/src/core/hle/service/sockets/bsd.cpp b/src/core/hle/service/sockets/bsd.cpp
index 7d85ecb6a..b9e765f1d 100644
--- a/src/core/hle/service/sockets/bsd.cpp
+++ b/src/core/hle/service/sockets/bsd.cpp
@@ -415,6 +415,18 @@ void BSD::Write(Kernel::HLERequestContext& ctx) {
415 }); 415 });
416} 416}
417 417
418void BSD::Read(Kernel::HLERequestContext& ctx) {
419 IPC::RequestParser rp{ctx};
420 const s32 fd = rp.Pop<s32>();
421
422 LOG_WARNING(Service, "(STUBBED) called. fd={} len={}", fd, ctx.GetWriteBufferSize());
423
424 IPC::ResponseBuilder rb{ctx, 4};
425 rb.Push(ResultSuccess);
426 rb.Push<u32>(0); // ret
427 rb.Push<u32>(0); // bsd errno
428}
429
418void BSD::Close(Kernel::HLERequestContext& ctx) { 430void BSD::Close(Kernel::HLERequestContext& ctx) {
419 IPC::RequestParser rp{ctx}; 431 IPC::RequestParser rp{ctx};
420 const s32 fd = rp.Pop<s32>(); 432 const s32 fd = rp.Pop<s32>();
@@ -855,7 +867,7 @@ BSD::BSD(Core::System& system_, const char* name) : ServiceFramework{system_, na
855 {22, &BSD::Shutdown, "Shutdown"}, 867 {22, &BSD::Shutdown, "Shutdown"},
856 {23, nullptr, "ShutdownAllSockets"}, 868 {23, nullptr, "ShutdownAllSockets"},
857 {24, &BSD::Write, "Write"}, 869 {24, &BSD::Write, "Write"},
858 {25, nullptr, "Read"}, 870 {25, &BSD::Read, "Read"},
859 {26, &BSD::Close, "Close"}, 871 {26, &BSD::Close, "Close"},
860 {27, nullptr, "DuplicateSocket"}, 872 {27, nullptr, "DuplicateSocket"},
861 {28, nullptr, "GetResourceStatistics"}, 873 {28, nullptr, "GetResourceStatistics"},
diff --git a/src/core/hle/service/sockets/bsd.h b/src/core/hle/service/sockets/bsd.h
index 1d2df9c61..d68beef5c 100644
--- a/src/core/hle/service/sockets/bsd.h
+++ b/src/core/hle/service/sockets/bsd.h
@@ -135,6 +135,7 @@ private:
135 void Send(Kernel::HLERequestContext& ctx); 135 void Send(Kernel::HLERequestContext& ctx);
136 void SendTo(Kernel::HLERequestContext& ctx); 136 void SendTo(Kernel::HLERequestContext& ctx);
137 void Write(Kernel::HLERequestContext& ctx); 137 void Write(Kernel::HLERequestContext& ctx);
138 void Read(Kernel::HLERequestContext& ctx);
138 void Close(Kernel::HLERequestContext& ctx); 139 void Close(Kernel::HLERequestContext& ctx);
139 void EventFd(Kernel::HLERequestContext& ctx); 140 void EventFd(Kernel::HLERequestContext& ctx);
140 141
diff --git a/src/core/hle/service/usb/usb.cpp b/src/core/hle/service/usb/usb.cpp
index 7f436c3bb..2ee103b37 100644
--- a/src/core/hle/service/usb/usb.cpp
+++ b/src/core/hle/service/usb/usb.cpp
@@ -97,7 +97,7 @@ public:
97 {3, nullptr, "GetAlternateInterface"}, 97 {3, nullptr, "GetAlternateInterface"},
98 {4, nullptr, "GetCurrentFrame"}, 98 {4, nullptr, "GetCurrentFrame"},
99 {5, nullptr, "CtrlXferAsync"}, 99 {5, nullptr, "CtrlXferAsync"},
100 {6, nullptr, "Unknown6"}, 100 {6, nullptr, "GetCtrlXferCompletionEvent"},
101 {7, nullptr, "GetCtrlXferReport"}, 101 {7, nullptr, "GetCtrlXferReport"},
102 {8, nullptr, "ResetDevice"}, 102 {8, nullptr, "ResetDevice"},
103 {9, nullptr, "OpenUsbEp"}, 103 {9, nullptr, "OpenUsbEp"},
@@ -183,8 +183,8 @@ public:
183 {4, nullptr, "GetHostPdcFirmwareRevision"}, 183 {4, nullptr, "GetHostPdcFirmwareRevision"},
184 {5, nullptr, "GetHostPdcManufactureId"}, 184 {5, nullptr, "GetHostPdcManufactureId"},
185 {6, nullptr, "GetHostPdcDeviceId"}, 185 {6, nullptr, "GetHostPdcDeviceId"},
186 {7, nullptr, "AwakeCradle"}, 186 {7, nullptr, "EnableCradleRecovery"},
187 {8, nullptr, "SleepCradle"}, 187 {8, nullptr, "DisableCradleRecovery"},
188 }; 188 };
189 // clang-format on 189 // clang-format on
190 190
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp
index 8e8fc40ca..be3d52d54 100644
--- a/src/core/hle/service/vi/vi.cpp
+++ b/src/core/hle/service/vi/vi.cpp
@@ -831,6 +831,7 @@ public:
831 {6010, nullptr, "GetLayerPresentationAllFencesExpiredEvent"}, 831 {6010, nullptr, "GetLayerPresentationAllFencesExpiredEvent"},
832 {6011, nullptr, "EnableLayerAutoClearTransitionBuffer"}, 832 {6011, nullptr, "EnableLayerAutoClearTransitionBuffer"},
833 {6012, nullptr, "DisableLayerAutoClearTransitionBuffer"}, 833 {6012, nullptr, "DisableLayerAutoClearTransitionBuffer"},
834 {6013, nullptr, "SetLayerOpacity"},
834 {7000, nullptr, "SetContentVisibility"}, 835 {7000, nullptr, "SetContentVisibility"},
835 {8000, nullptr, "SetConductorLayer"}, 836 {8000, nullptr, "SetConductorLayer"},
836 {8001, nullptr, "SetTimestampTracking"}, 837 {8001, nullptr, "SetTimestampTracking"},
diff --git a/src/input_common/main.cpp b/src/input_common/main.cpp
index 18d7d8817..f3907c65a 100644
--- a/src/input_common/main.cpp
+++ b/src/input_common/main.cpp
@@ -346,8 +346,8 @@ void InputSubsystem::ReloadInputDevices() {
346 impl->udp->ReloadSockets(); 346 impl->udp->ReloadSockets();
347} 347}
348 348
349std::vector<std::unique_ptr<Polling::DevicePoller>> InputSubsystem::GetPollers([ 349std::vector<std::unique_ptr<Polling::DevicePoller>> InputSubsystem::GetPollers(
350 [maybe_unused]] Polling::DeviceType type) const { 350 [[maybe_unused]] Polling::DeviceType type) const {
351#ifdef HAVE_SDL2 351#ifdef HAVE_SDL2
352 return impl->sdl->GetPollers(type); 352 return impl->sdl->GetPollers(type);
353#else 353#else
diff --git a/src/shader_recompiler/object_pool.h b/src/shader_recompiler/object_pool.h
index f3b12d04b..a12ddcc8f 100644
--- a/src/shader_recompiler/object_pool.h
+++ b/src/shader_recompiler/object_pool.h
@@ -11,14 +11,16 @@
11namespace Shader { 11namespace Shader {
12 12
13template <typename T> 13template <typename T>
14requires std::is_destructible_v<T> class ObjectPool { 14requires std::is_destructible_v<T>
15class ObjectPool {
15public: 16public:
16 explicit ObjectPool(size_t chunk_size = 8192) : new_chunk_size{chunk_size} { 17 explicit ObjectPool(size_t chunk_size = 8192) : new_chunk_size{chunk_size} {
17 node = &chunks.emplace_back(new_chunk_size); 18 node = &chunks.emplace_back(new_chunk_size);
18 } 19 }
19 20
20 template <typename... Args> 21 template <typename... Args>
21 requires std::is_constructible_v<T, Args...>[[nodiscard]] T* Create(Args&&... args) { 22 requires std::is_constructible_v<T, Args...>
23 [[nodiscard]] T* Create(Args&&... args) {
22 return std::construct_at(Memory(), std::forward<Args>(args)...); 24 return std::construct_at(Memory(), std::forward<Args>(args)...);
23 } 25 }
24 26
diff --git a/src/video_core/renderer_vulkan/renderer_vulkan.cpp b/src/video_core/renderer_vulkan/renderer_vulkan.cpp
index adb6b7a3b..74822814d 100644
--- a/src/video_core/renderer_vulkan/renderer_vulkan.cpp
+++ b/src/video_core/renderer_vulkan/renderer_vulkan.cpp
@@ -97,19 +97,14 @@ RendererVulkan::RendererVulkan(Core::TelemetrySession& telemetry_session_,
97 Core::Frontend::EmuWindow& emu_window, 97 Core::Frontend::EmuWindow& emu_window,
98 Core::Memory::Memory& cpu_memory_, Tegra::GPU& gpu_, 98 Core::Memory::Memory& cpu_memory_, Tegra::GPU& gpu_,
99 std::unique_ptr<Core::Frontend::GraphicsContext> context_) try 99 std::unique_ptr<Core::Frontend::GraphicsContext> context_) try
100 : RendererBase(emu_window, std::move(context_)), 100 : RendererBase(emu_window, std::move(context_)), telemetry_session(telemetry_session_),
101 telemetry_session(telemetry_session_), 101 cpu_memory(cpu_memory_), gpu(gpu_), library(OpenLibrary()),
102 cpu_memory(cpu_memory_),
103 gpu(gpu_),
104 library(OpenLibrary()),
105 instance(CreateInstance(library, dld, VK_API_VERSION_1_1, render_window.GetWindowInfo().type, 102 instance(CreateInstance(library, dld, VK_API_VERSION_1_1, render_window.GetWindowInfo().type,
106 true, Settings::values.renderer_debug.GetValue())), 103 true, Settings::values.renderer_debug.GetValue())),
107 debug_callback(Settings::values.renderer_debug ? CreateDebugCallback(instance) : nullptr), 104 debug_callback(Settings::values.renderer_debug ? CreateDebugCallback(instance) : nullptr),
108 surface(CreateSurface(instance, render_window)), 105 surface(CreateSurface(instance, render_window)),
109 device(CreateDevice(instance, dld, *surface)), 106 device(CreateDevice(instance, dld, *surface)), memory_allocator(device, false),
110 memory_allocator(device, false), 107 state_tracker(gpu), scheduler(device, state_tracker),
111 state_tracker(gpu),
112 scheduler(device, state_tracker),
113 swapchain(*surface, device, scheduler, render_window.GetFramebufferLayout().width, 108 swapchain(*surface, device, scheduler, render_window.GetFramebufferLayout().width,
114 render_window.GetFramebufferLayout().height, false), 109 render_window.GetFramebufferLayout().height, false),
115 blit_screen(cpu_memory, render_window, device, memory_allocator, swapchain, scheduler, 110 blit_screen(cpu_memory, render_window, device, memory_allocator, swapchain, scheduler,
diff --git a/src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp b/src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp
index 7c0f91007..11cd41ad7 100644
--- a/src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp
+++ b/src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp
@@ -507,8 +507,9 @@ void GraphicsPipeline::MakePipeline(VkRenderPass render_pass) {
507 vertex_attributes.push_back({ 507 vertex_attributes.push_back({
508 .location = static_cast<u32>(index), 508 .location = static_cast<u32>(index),
509 .binding = 0, 509 .binding = 0,
510 .format = type == 1 ? VK_FORMAT_R32_SFLOAT 510 .format = type == 1 ? VK_FORMAT_R32_SFLOAT
511 : type == 2 ? VK_FORMAT_R32_SINT : VK_FORMAT_R32_UINT, 511 : type == 2 ? VK_FORMAT_R32_SINT
512 : VK_FORMAT_R32_UINT,
512 .offset = 0, 513 .offset = 0,
513 }); 514 });
514 } 515 }
diff --git a/src/video_core/renderer_vulkan/vk_scheduler.h b/src/video_core/renderer_vulkan/vk_scheduler.h
index bd22e4e83..85fc1712f 100644
--- a/src/video_core/renderer_vulkan/vk_scheduler.h
+++ b/src/video_core/renderer_vulkan/vk_scheduler.h
@@ -212,7 +212,6 @@ private:
212 vk::CommandBuffer current_cmdbuf; 212 vk::CommandBuffer current_cmdbuf;
213 213
214 std::unique_ptr<CommandChunk> chunk; 214 std::unique_ptr<CommandChunk> chunk;
215 std::jthread worker_thread;
216 215
217 State state; 216 State state;
218 217
@@ -226,6 +225,7 @@ private:
226 std::mutex work_mutex; 225 std::mutex work_mutex;
227 std::condition_variable_any work_cv; 226 std::condition_variable_any work_cv;
228 std::condition_variable wait_cv; 227 std::condition_variable wait_cv;
228 std::jthread worker_thread;
229}; 229};
230 230
231} // namespace Vulkan 231} // namespace Vulkan
diff --git a/src/video_core/texture_cache/slot_vector.h b/src/video_core/texture_cache/slot_vector.h
index 74cd3c9d8..50df06409 100644
--- a/src/video_core/texture_cache/slot_vector.h
+++ b/src/video_core/texture_cache/slot_vector.h
@@ -31,8 +31,8 @@ struct SlotId {
31}; 31};
32 32
33template <class T> 33template <class T>
34requires std::is_nothrow_move_assignable_v<T>&& 34requires std::is_nothrow_move_assignable_v<T> && std::is_nothrow_move_constructible_v<T>
35 std::is_nothrow_move_constructible_v<T> class SlotVector { 35class SlotVector {
36public: 36public:
37 class Iterator { 37 class Iterator {
38 friend SlotVector<T>; 38 friend SlotVector<T>;
diff --git a/src/yuzu/configuration/configure_debug.ui b/src/yuzu/configuration/configure_debug.ui
index 3fe9ff7de..b884a56b0 100644
--- a/src/yuzu/configuration/configure_debug.ui
+++ b/src/yuzu/configuration/configure_debug.ui
@@ -2,85 +2,55 @@
2<ui version="4.0"> 2<ui version="4.0">
3 <class>ConfigureDebug</class> 3 <class>ConfigureDebug</class>
4 <widget class="QWidget" name="ConfigureDebug"> 4 <widget class="QWidget" name="ConfigureDebug">
5 <property name="geometry">
6 <rect>
7 <x>0</x>
8 <y>0</y>
9 <width>400</width>
10 <height>777</height>
11 </rect>
12 </property>
13 <property name="windowTitle">
14 <string>Form</string>
15 </property>
16 <layout class="QVBoxLayout" name="verticalLayout_1"> 5 <layout class="QVBoxLayout" name="verticalLayout_1">
17 <item> 6 <item>
18 <widget class="QGroupBox" name="groupBox_2"> 7 <widget class="QGroupBox" name="groupBox_2">
19 <property name="title"> 8 <property name="title">
20 <string>Logging</string> 9 <string>Logging</string>
21 </property> 10 </property>
22 <layout class="QVBoxLayout" name="verticalLayout_4"> 11 <layout class="QGridLayout" name="gridLayout_1">
23 <item> 12 <item row="0" column="0" colspan="2">
24 <layout class="QHBoxLayout" name="horizontalLayout_2"> 13 <layout class="QHBoxLayout" name="horizontalLayout_1">
25 <item> 14 <item>
26 <widget class="QLabel" name="label_1"> 15 <widget class="QLabel" name="label_1">
27 <property name="text"> 16 <property name="text">
28 <string>Global Log Filter</string> 17 <string>Global Log Filter</string>
18 </property>
19 </widget>
20 </item>
21 <item>
22 <widget class="QLineEdit" name="log_filter_edit"/>
23 </item>
24 </layout>
25 </item>
26 <item row="1" column="0">
27 <widget class="QCheckBox" name="toggle_console">
28 <property name="text">
29 <string>Show Log in Console</string>
30 </property>
31 </widget>
32 </item>
33 <item row="1" column="1">
34 <widget class="QPushButton" name="open_log_button">
35 <property name="text">
36 <string>Open Log Location</string>
37 </property>
38 </widget>
39 </item>
40 <item row="2" column="0">
41 <widget class="QCheckBox" name="extended_logging">
42 <property name="enabled">
43 <bool>true</bool>
29 </property> 44 </property>
30 </widget> 45 <property name="toolTip">
31 </item> 46 <string>When checked, the max size of the log increases from 100 MB to 1 GB</string>
32 <item>
33 <widget class="QLineEdit" name="log_filter_edit"/>
34 </item>
35 </layout>
36 </item>
37 <item>
38 <layout class="QHBoxLayout" name="horizontalLayout_3">
39 <item>
40 <widget class="QCheckBox" name="toggle_console">
41 <property name="text">
42 <string>Show Log in Console</string>
43 </property> 47 </property>
44 </widget>
45 </item>
46 <item>
47 <widget class="QPushButton" name="open_log_button">
48 <property name="text"> 48 <property name="text">
49 <string>Open Log Location</string> 49 <string>Enable Extended Logging**</string>
50 </property> 50 </property>
51 </widget> 51 </widget>
52 </item> 52 </item>
53 </layout> 53 </layout>
54 </item>
55 <item>
56 <widget class="QCheckBox" name="extended_logging">
57 <property name="enabled">
58 <bool>true</bool>
59 </property>
60 <property name="toolTip">
61 <string>When checked, the max size of the log increases from 100 MB to 1 GB</string>
62 </property>
63 <property name="text">
64 <string>Enable Extended Logging</string>
65 </property>
66 </widget>
67 </item>
68 <item>
69 <widget class="QLabel" name="label_2">
70 <property name="font">
71 <font>
72 <italic>true</italic>
73 </font>
74 </property>
75 <property name="text">
76 <string>This will be reset automatically when yuzu closes.</string>
77 </property>
78 <property name="indent">
79 <number>20</number>
80 </property>
81 </widget>
82 </item>
83 </layout>
84 </widget> 54 </widget>
85 </item> 55 </item>
86 <item> 56 <item>
@@ -111,7 +81,7 @@
111 <property name="title"> 81 <property name="title">
112 <string>Graphics</string> 82 <string>Graphics</string>
113 </property> 83 </property>
114 <layout class="QGridLayout" name="gridLayout_3"> 84 <layout class="QGridLayout" name="gridLayout_2">
115 <item row="0" column="0"> 85 <item row="0" column="0">
116 <widget class="QCheckBox" name="enable_graphics_debugging"> 86 <widget class="QCheckBox" name="enable_graphics_debugging">
117 <property name="enabled"> 87 <property name="enabled">
@@ -176,33 +146,18 @@
176 <property name="title"> 146 <property name="title">
177 <string>Debugging</string> 147 <string>Debugging</string>
178 </property> 148 </property>
179 <layout class="QVBoxLayout" name="verticalLayout_7"> 149 <layout class="QGridLayout" name="gridLayout_3">
180 <item> 150 <item row="0" column="0">
181 <widget class="QCheckBox" name="fs_access_log"> 151 <widget class="QCheckBox" name="fs_access_log">
182 <property name="text"> 152 <property name="text">
183 <string>Enable FS Access Log</string> 153 <string>Enable FS Access Log</string>
184 </property> 154 </property>
185 </widget> 155 </widget>
186 </item> 156 </item>
187 <item> 157 <item row="1" column="0">
188 <widget class="QCheckBox" name="reporting_services"> 158 <widget class="QCheckBox" name="reporting_services">
189 <property name="text"> 159 <property name="text">
190 <string>Enable Verbose Reporting Services</string> 160 <string>Enable Verbose Reporting Services**</string>
191 </property>
192 </widget>
193 </item>
194 <item>
195 <widget class="QLabel" name="label_4">
196 <property name="font">
197 <font>
198 <italic>true</italic>
199 </font>
200 </property>
201 <property name="text">
202 <string>This will be reset automatically when yuzu closes.</string>
203 </property>
204 <property name="indent">
205 <number>20</number>
206 </property> 161 </property>
207 </widget> 162 </widget>
208 </item> 163 </item>
@@ -214,47 +169,32 @@
214 <property name="title"> 169 <property name="title">
215 <string>Advanced</string> 170 <string>Advanced</string>
216 </property> 171 </property>
217 <layout class="QVBoxLayout" name="verticalLayout_8"> 172 <layout class="QGridLayout" name="gridLayout_4">
218 <item> 173 <item> row="0" column="0">
219 <widget class="QCheckBox" name="quest_flag"> 174 <widget class="QCheckBox" name="quest_flag">
220 <property name="text"> 175 <property name="text">
221 <string>Kiosk (Quest) Mode</string> 176 <string>Kiosk (Quest) Mode</string>
222 </property> 177 </property>
223 </widget> 178 </widget>
224 </item> 179 </item>
225 <item> 180 <item row="1" column="0">
226 <widget class="QCheckBox" name="enable_cpu_debugging"> 181 <widget class="QCheckBox" name="enable_cpu_debugging">
227 <property name="text"> 182 <property name="text">
228 <string>Enable CPU Debugging</string> 183 <string>Enable CPU Debugging</string>
229 </property> 184 </property>
230 </widget> 185 </widget>
231 </item> 186 </item>
232 <item> 187 <item row="2" column="0">
233 <widget class="QCheckBox" name="use_debug_asserts"> 188 <widget class="QCheckBox" name="use_debug_asserts">
234 <property name="text"> 189 <property name="text">
235 <string>Enable Debug Asserts</string> 190 <string>Enable Debug Asserts</string>
236 </property> 191 </property>
237 </widget> 192 </widget>
238 </item> 193 </item>
239 <item> 194 <item row="0" column="1">
240 <widget class="QCheckBox" name="use_auto_stub"> 195 <widget class="QCheckBox" name="use_auto_stub">
241 <property name="text"> 196 <property name="text">
242 <string>Enable Auto-Stub</string> 197 <string>Enable Auto-Stub**</string>
243 </property>
244 </widget>
245 </item>
246 <item>
247 <widget class="QLabel" name="label_5">
248 <property name="font">
249 <font>
250 <italic>true</italic>
251 </font>
252 </property>
253 <property name="text">
254 <string>This will be reset automatically when yuzu closes.</string>
255 </property>
256 <property name="indent">
257 <number>20</number>
258 </property> 198 </property>
259 </widget> 199 </widget>
260 </item> 200 </item>
@@ -262,20 +202,19 @@
262 </widget> 202 </widget>
263 </item> 203 </item>
264 <item> 204 <item>
265 <spacer name="verticalSpacer"> 205 <widget class="QLabel" name="label_5">
266 <property name="orientation"> 206 <property name="font">
267 <enum>Qt::Vertical</enum> 207 <font>
208 <italic>true</italic>
209 </font>
268 </property> 210 </property>
269 <property name="sizeType"> 211 <property name="text">
270 <enum>QSizePolicy::Expanding</enum> 212 <string>**This will be reset automatically when yuzu closes.</string>
271 </property> 213 </property>
272 <property name="sizeHint" stdset="0"> 214 <property name="indent">
273 <size> 215 <number>20</number>
274 <width>20</width>
275 <height>40</height>
276 </size>
277 </property> 216 </property>
278 </spacer> 217 </widget>
279 </item> 218 </item>
280 </layout> 219 </layout>
281 </widget> 220 </widget>
diff --git a/src/yuzu/configuration/configure_tas.ui b/src/yuzu/configuration/configure_tas.ui
index 8a3ecb834..95575ed9d 100644
--- a/src/yuzu/configuration/configure_tas.ui
+++ b/src/yuzu/configuration/configure_tas.ui
@@ -2,37 +2,23 @@
2<ui version="4.0"> 2<ui version="4.0">
3 <class>ConfigureTas</class> 3 <class>ConfigureTas</class>
4 <widget class="QDialog" name="ConfigureTas"> 4 <widget class="QDialog" name="ConfigureTas">
5 <property name="geometry">
6 <rect>
7 <x>0</x>
8 <y>0</y>
9 <width>800</width>
10 <height>300</height>
11 </rect>
12 </property>
13 <property name="windowTitle">
14 <string>Dialog</string>
15 </property>
16 <layout class="QVBoxLayout" name="verticalLayout_1"> 5 <layout class="QVBoxLayout" name="verticalLayout_1">
17 <item> 6 <item>
18 <layout class="QHBoxLayout" name="horizontalLayout"> 7 <layout class="QHBoxLayout" name="horizontalLayout_1">
19 <item> 8 <item>
20 <widget class="QGroupBox" name="groupBox"> 9 <widget class="QGroupBox" name="groupBox_1">
21 <property name="title"> 10 <property name="title">
22 <string>TAS</string> 11 <string>TAS</string>
23 </property> 12 </property>
24 <layout class="QGridLayout" name="gridLayout"> 13 <layout class="QGridLayout" name="gridLayout_1">
25 <item row="0" column="0" colspan="1"> 14 <item row="0" column="0" colspan="4">
26 <widget class="QLabel" name="label_1"> 15 <widget class="QLabel" name="label_1">
27 <property name="text"> 16 <property name="text">
28 <string>Reads controller input from scripts in the same format as TAS-nx scripts. For a more detailed explanation please consult the FAQ on the yuzu website.</string> 17 <string>Reads controller input from scripts in the same format as TAS-nx scripts.&lt;br/&gt;For a more detailed explanation please consult the FAQ on the yuzu website.</string>
29 </property>
30 <property name="wordWrap">
31 <bool>true</bool>
32 </property> 18 </property>
33 </widget> 19 </widget>
34 </item> 20 </item>
35 <item row="1" column="0" colspan="1"> 21 <item row="1" column="0" colspan="4">
36 <widget class="QLabel" name="label_2"> 22 <widget class="QLabel" name="label_2">
37 <property name="text"> 23 <property name="text">
38 <string>To check which hotkeys control the playback/recording, please refer to the Hotkey settings (General -> Hotkeys).</string> 24 <string>To check which hotkeys control the playback/recording, please refer to the Hotkey settings (General -> Hotkeys).</string>
@@ -42,10 +28,10 @@
42 </property> 28 </property>
43 </widget> 29 </widget>
44 </item> 30 </item>
45 <item row="2" column="0" colspan="1"> 31 <item row="2" column="0" colspan="4">
46 <widget class="QLabel" name="label_2"> 32 <widget class="QLabel" name="label_3">
47 <property name="text"> 33 <property name="text">
48 <string>WARNING: This is an experimental feature. It will not play back scripts frame perfectly with the current, imperfect syncing method.</string> 34 <string>WARNING: This is an experimental feature.&lt;br/&gt;It will not play back scripts frame perfectly with the current, imperfect syncing method.</string>
49 </property> 35 </property>
50 <property name="wordWrap"> 36 <property name="wordWrap">
51 <bool>true</bool> 37 <bool>true</bool>
@@ -58,13 +44,13 @@
58 </layout> 44 </layout>
59 </item> 45 </item>
60 <item> 46 <item>
61 <layout class="QHBoxLayout" name="horizontalLayout"> 47 <layout class="QHBoxLayout" name="horizontalLayout_2">
62 <item> 48 <item>
63 <widget class="QGroupBox" name="groupBox"> 49 <widget class="QGroupBox" name="groupBox_2">
64 <property name="title"> 50 <property name="title">
65 <string>Settings</string> 51 <string>Settings</string>
66 </property> 52 </property>
67 <layout class="QGridLayout" name="gridLayout"> 53 <layout class="QGridLayout" name="gridLayout_2">
68 <item row="0" column="0" colspan="4"> 54 <item row="0" column="0" colspan="4">
69 <widget class="QCheckBox" name="tas_enable"> 55 <widget class="QCheckBox" name="tas_enable">
70 <property name="text"> 56 <property name="text">
@@ -102,15 +88,15 @@
102 </layout> 88 </layout>
103 </item> 89 </item>
104 <item> 90 <item>
105 <layout class="QHBoxLayout" name="horizontalLayout"> 91 <layout class="QHBoxLayout" name="horizontalLayout_3">
106 <item> 92 <item>
107 <widget class="QGroupBox" name="groupBox"> 93 <widget class="QGroupBox" name="groupBox_3">
108 <property name="title"> 94 <property name="title">
109 <string>Script Directory</string> 95 <string>Script Directory</string>
110 </property> 96 </property>
111 <layout class="QGridLayout" name="gridLayout"> 97 <layout class="QGridLayout" name="gridLayout_3">
112 <item row="0" column="0"> 98 <item row="0" column="0">
113 <widget class="QLabel" name="label"> 99 <widget class="QLabel" name="label_4">
114 <property name="text"> 100 <property name="text">
115 <string>Path</string> 101 <string>Path</string>
116 </property> 102 </property>
@@ -126,22 +112,6 @@
126 <item row="0" column="2"> 112 <item row="0" column="2">
127 <widget class="QLineEdit" name="tas_path_edit"/> 113 <widget class="QLineEdit" name="tas_path_edit"/>
128 </item> 114 </item>
129 <item row="0" column="1">
130 <spacer name="horizontalSpacer">
131 <property name="orientation">
132 <enum>Qt::Horizontal</enum>
133 </property>
134 <property name="sizeType">
135 <enum>QSizePolicy::Maximum</enum>
136 </property>
137 <property name="sizeHint" stdset="0">
138 <size>
139 <width>60</width>
140 <height>20</height>
141 </size>
142 </property>
143 </spacer>
144 </item>
145 </layout> 115 </layout>
146 </widget> 116 </widget>
147 </item> 117 </item>