summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/common/assert.h5
-rw-r--r--src/common/file_util.cpp18
-rw-r--r--src/common/logging/filter.cpp2
-rw-r--r--src/core/arm/dynarmic/arm_dynarmic.cpp2
-rw-r--r--src/core/core.cpp4
-rw-r--r--src/core/file_sys/partition_filesystem.cpp4
-rw-r--r--src/core/file_sys/program_metadata.cpp2
-rw-r--r--src/core/file_sys/romfs_filesystem.cpp12
-rw-r--r--src/core/gdbstub/gdbstub.cpp17
-rw-r--r--src/core/hle/kernel/hle_ipc.cpp2
-rw-r--r--src/core/hle/kernel/server_session.cpp2
-rw-r--r--src/core/hle/kernel/shared_memory.cpp4
-rw-r--r--src/core/hle/kernel/svc.cpp53
-rw-r--r--src/core/hle/kernel/thread.cpp2
-rw-r--r--src/core/hle/kernel/vm_manager.cpp10
-rw-r--r--src/core/hle/service/apm/interface.cpp2
-rw-r--r--src/core/hle/service/filesystem/filesystem.cpp4
-rw-r--r--src/core/hle/service/nvdrv/devices/nvdisp_disp0.cpp4
-rw-r--r--src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp16
-rw-r--r--src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp8
-rw-r--r--src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp4
-rw-r--r--src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp20
-rw-r--r--src/core/hle/service/nvdrv/devices/nvhost_nvdec.cpp2
-rw-r--r--src/core/hle/service/sm/sm.cpp3
-rw-r--r--src/core/hle/service/sockets/bsd.cpp3
-rw-r--r--src/core/hle/service/vi/vi.cpp6
-rw-r--r--src/core/loader/elf.cpp10
-rw-r--r--src/core/memory.cpp24
-rw-r--r--src/video_core/command_processor.cpp6
-rw-r--r--src/video_core/engines/fermi_2d.cpp2
-rw-r--r--src/video_core/engines/maxwell_3d.cpp4
-rw-r--r--src/video_core/renderer_opengl/gl_rasterizer.cpp10
-rw-r--r--src/video_core/renderer_opengl/gl_shader_decompiler.cpp12
-rw-r--r--src/video_core/renderer_opengl/maxwell_to_gl.h5
-rw-r--r--src/video_core/renderer_opengl/renderer_opengl.cpp2
-rw-r--r--src/yuzu/game_list.cpp3
-rw-r--r--src/yuzu_cmd/yuzu.cpp6
37 files changed, 141 insertions, 154 deletions
diff --git a/src/common/assert.h b/src/common/assert.h
index fbe87273b..655446f34 100644
--- a/src/common/assert.h
+++ b/src/common/assert.h
@@ -30,15 +30,14 @@ __declspec(noinline, noreturn)
30#define ASSERT(_a_) \ 30#define ASSERT(_a_) \
31 do \ 31 do \
32 if (!(_a_)) { \ 32 if (!(_a_)) { \
33 assert_noinline_call([] { LOG_CRITICAL(Debug, "Assertion Failed!"); }); \ 33 assert_noinline_call([] { LOG_CRITICAL(Debug, "Assertion Failed!"); }); \
34 } \ 34 } \
35 while (0) 35 while (0)
36 36
37#define ASSERT_MSG(_a_, ...) \ 37#define ASSERT_MSG(_a_, ...) \
38 do \ 38 do \
39 if (!(_a_)) { \ 39 if (!(_a_)) { \
40 assert_noinline_call( \ 40 assert_noinline_call([&] { LOG_CRITICAL(Debug, "Assertion Failed!\n" __VA_ARGS__); }); \
41 [&] { LOG_CRITICAL(Debug, "Assertion Failed!\n" __VA_ARGS__); }); \
42 } \ 41 } \
43 while (0) 42 while (0)
44 43
diff --git a/src/common/file_util.cpp b/src/common/file_util.cpp
index 40b633092..2152e3fea 100644
--- a/src/common/file_util.cpp
+++ b/src/common/file_util.cpp
@@ -257,7 +257,7 @@ bool Rename(const std::string& srcFilename, const std::string& destFilename) {
257 return true; 257 return true;
258#endif 258#endif
259 LOG_ERROR(Common_Filesystem, "failed {} --> {}: {}", srcFilename, destFilename, 259 LOG_ERROR(Common_Filesystem, "failed {} --> {}: {}", srcFilename, destFilename,
260 GetLastErrorMsg()); 260 GetLastErrorMsg());
261 return false; 261 return false;
262} 262}
263 263
@@ -270,7 +270,7 @@ bool Copy(const std::string& srcFilename, const std::string& destFilename) {
270 return true; 270 return true;
271 271
272 LOG_ERROR(Common_Filesystem, "failed {} --> {}: {}", srcFilename, destFilename, 272 LOG_ERROR(Common_Filesystem, "failed {} --> {}: {}", srcFilename, destFilename,
273 GetLastErrorMsg()); 273 GetLastErrorMsg());
274 return false; 274 return false;
275#else 275#else
276 276
@@ -283,7 +283,7 @@ bool Copy(const std::string& srcFilename, const std::string& destFilename) {
283 FILE* input = fopen(srcFilename.c_str(), "rb"); 283 FILE* input = fopen(srcFilename.c_str(), "rb");
284 if (!input) { 284 if (!input) {
285 LOG_ERROR(Common_Filesystem, "opening input failed {} --> {}: {}", srcFilename, 285 LOG_ERROR(Common_Filesystem, "opening input failed {} --> {}: {}", srcFilename,
286 destFilename, GetLastErrorMsg()); 286 destFilename, GetLastErrorMsg());
287 return false; 287 return false;
288 } 288 }
289 289
@@ -292,7 +292,7 @@ bool Copy(const std::string& srcFilename, const std::string& destFilename) {
292 if (!output) { 292 if (!output) {
293 fclose(input); 293 fclose(input);
294 LOG_ERROR(Common_Filesystem, "opening output failed {} --> {}: {}", srcFilename, 294 LOG_ERROR(Common_Filesystem, "opening output failed {} --> {}: {}", srcFilename,
295 destFilename, GetLastErrorMsg()); 295 destFilename, GetLastErrorMsg());
296 return false; 296 return false;
297 } 297 }
298 298
@@ -303,7 +303,7 @@ bool Copy(const std::string& srcFilename, const std::string& destFilename) {
303 if (rnum != BSIZE) { 303 if (rnum != BSIZE) {
304 if (ferror(input) != 0) { 304 if (ferror(input) != 0) {
305 LOG_ERROR(Common_Filesystem, "failed reading from source, {} --> {}: {}", 305 LOG_ERROR(Common_Filesystem, "failed reading from source, {} --> {}: {}",
306 srcFilename, destFilename, GetLastErrorMsg()); 306 srcFilename, destFilename, GetLastErrorMsg());
307 goto bail; 307 goto bail;
308 } 308 }
309 } 309 }
@@ -312,7 +312,7 @@ bool Copy(const std::string& srcFilename, const std::string& destFilename) {
312 size_t wnum = fwrite(buffer, sizeof(char), rnum, output); 312 size_t wnum = fwrite(buffer, sizeof(char), rnum, output);
313 if (wnum != rnum) { 313 if (wnum != rnum) {
314 LOG_ERROR(Common_Filesystem, "failed writing to output, {} --> {}: {}", srcFilename, 314 LOG_ERROR(Common_Filesystem, "failed writing to output, {} --> {}: {}", srcFilename,
315 destFilename, GetLastErrorMsg()); 315 destFilename, GetLastErrorMsg());
316 goto bail; 316 goto bail;
317 } 317 }
318 } 318 }
@@ -371,14 +371,12 @@ u64 GetSize(FILE* f) {
371 // can't use off_t here because it can be 32-bit 371 // can't use off_t here because it can be 32-bit
372 u64 pos = ftello(f); 372 u64 pos = ftello(f);
373 if (fseeko(f, 0, SEEK_END) != 0) { 373 if (fseeko(f, 0, SEEK_END) != 0) {
374 LOG_ERROR(Common_Filesystem, "GetSize: seek failed {}: {}", fmt::ptr(f), 374 LOG_ERROR(Common_Filesystem, "GetSize: seek failed {}: {}", fmt::ptr(f), GetLastErrorMsg());
375 GetLastErrorMsg());
376 return 0; 375 return 0;
377 } 376 }
378 u64 size = ftello(f); 377 u64 size = ftello(f);
379 if ((size != pos) && (fseeko(f, pos, SEEK_SET) != 0)) { 378 if ((size != pos) && (fseeko(f, pos, SEEK_SET) != 0)) {
380 LOG_ERROR(Common_Filesystem, "GetSize: seek failed {}: {}", fmt::ptr(f), 379 LOG_ERROR(Common_Filesystem, "GetSize: seek failed {}: {}", fmt::ptr(f), GetLastErrorMsg());
381 GetLastErrorMsg());
382 return 0; 380 return 0;
383 } 381 }
384 return size; 382 return size;
diff --git a/src/common/logging/filter.cpp b/src/common/logging/filter.cpp
index fdfb66696..733247b51 100644
--- a/src/common/logging/filter.cpp
+++ b/src/common/logging/filter.cpp
@@ -66,7 +66,7 @@ bool Filter::ParseFilterRule(const std::string::const_iterator begin,
66 auto level_separator = std::find(begin, end, ':'); 66 auto level_separator = std::find(begin, end, ':');
67 if (level_separator == end) { 67 if (level_separator == end) {
68 LOG_ERROR(Log, "Invalid log filter. Must specify a log level after `:`: %s", 68 LOG_ERROR(Log, "Invalid log filter. Must specify a log level after `:`: %s",
69 std::string(begin, end).c_str()); 69 std::string(begin, end).c_str());
70 return false; 70 return false;
71 } 71 }
72 72
diff --git a/src/core/arm/dynarmic/arm_dynarmic.cpp b/src/core/arm/dynarmic/arm_dynarmic.cpp
index 975ac6e3f..42605374b 100644
--- a/src/core/arm/dynarmic/arm_dynarmic.cpp
+++ b/src/core/arm/dynarmic/arm_dynarmic.cpp
@@ -56,7 +56,7 @@ public:
56 56
57 void InterpreterFallback(u64 pc, size_t num_instructions) override { 57 void InterpreterFallback(u64 pc, size_t num_instructions) override {
58 LOG_INFO(Core_ARM, "Unicorn fallback @ 0x{:X} for {} instructions (instr = {:08X})", pc, 58 LOG_INFO(Core_ARM, "Unicorn fallback @ 0x{:X} for {} instructions (instr = {:08X})", pc,
59 num_instructions, MemoryReadCode(pc)); 59 num_instructions, MemoryReadCode(pc));
60 60
61 ARM_Interface::ThreadContext ctx; 61 ARM_Interface::ThreadContext ctx;
62 parent.SaveContext(ctx); 62 parent.SaveContext(ctx);
diff --git a/src/core/core.cpp b/src/core/core.cpp
index 8c2977522..8335d502e 100644
--- a/src/core/core.cpp
+++ b/src/core/core.cpp
@@ -95,7 +95,7 @@ System::ResultStatus System::Load(EmuWindow* emu_window, const std::string& file
95 95
96 if (system_mode.second != Loader::ResultStatus::Success) { 96 if (system_mode.second != Loader::ResultStatus::Success) {
97 LOG_CRITICAL(Core, "Failed to determine system mode (Error {})!", 97 LOG_CRITICAL(Core, "Failed to determine system mode (Error {})!",
98 static_cast<int>(system_mode.second)); 98 static_cast<int>(system_mode.second));
99 99
100 switch (system_mode.second) { 100 switch (system_mode.second) {
101 case Loader::ResultStatus::ErrorEncrypted: 101 case Loader::ResultStatus::ErrorEncrypted:
@@ -112,7 +112,7 @@ System::ResultStatus System::Load(EmuWindow* emu_window, const std::string& file
112 ResultStatus init_result{Init(emu_window, system_mode.first.get())}; 112 ResultStatus init_result{Init(emu_window, system_mode.first.get())};
113 if (init_result != ResultStatus::Success) { 113 if (init_result != ResultStatus::Success) {
114 LOG_CRITICAL(Core, "Failed to initialize system (Error {})!", 114 LOG_CRITICAL(Core, "Failed to initialize system (Error {})!",
115 static_cast<int>(init_result)); 115 static_cast<int>(init_result));
116 System::Shutdown(); 116 System::Shutdown();
117 return init_result; 117 return init_result;
118 } 118 }
diff --git a/src/core/file_sys/partition_filesystem.cpp b/src/core/file_sys/partition_filesystem.cpp
index ebbc0b252..46d438aca 100644
--- a/src/core/file_sys/partition_filesystem.cpp
+++ b/src/core/file_sys/partition_filesystem.cpp
@@ -129,8 +129,8 @@ void PartitionFilesystem::Print() const {
129 LOG_DEBUG(Service_FS, "Files: {}", pfs_header.num_entries); 129 LOG_DEBUG(Service_FS, "Files: {}", pfs_header.num_entries);
130 for (u32 i = 0; i < pfs_header.num_entries; i++) { 130 for (u32 i = 0; i < pfs_header.num_entries; i++) {
131 LOG_DEBUG(Service_FS, " > File {}: {} (0x{:X} bytes, at 0x{:X})", i, 131 LOG_DEBUG(Service_FS, " > File {}: {} (0x{:X} bytes, at 0x{:X})", i,
132 pfs_entries[i].name.c_str(), pfs_entries[i].fs_entry.size, 132 pfs_entries[i].name.c_str(), pfs_entries[i].fs_entry.size,
133 GetFileOffset(pfs_entries[i].name)); 133 GetFileOffset(pfs_entries[i].name));
134 } 134 }
135} 135}
136} // namespace FileSys 136} // namespace FileSys
diff --git a/src/core/file_sys/program_metadata.cpp b/src/core/file_sys/program_metadata.cpp
index a17268b2c..226811115 100644
--- a/src/core/file_sys/program_metadata.cpp
+++ b/src/core/file_sys/program_metadata.cpp
@@ -83,7 +83,7 @@ void ProgramMetadata::Print() const {
83 LOG_DEBUG(Service_FS, "Process category: {}", npdm_header.process_category); 83 LOG_DEBUG(Service_FS, "Process category: {}", npdm_header.process_category);
84 LOG_DEBUG(Service_FS, "Flags: 0x{:02X}", npdm_header.flags); 84 LOG_DEBUG(Service_FS, "Flags: 0x{:02X}", npdm_header.flags);
85 LOG_DEBUG(Service_FS, " > 64-bit instructions: {}", 85 LOG_DEBUG(Service_FS, " > 64-bit instructions: {}",
86 npdm_header.has_64_bit_instructions ? "YES" : "NO"); 86 npdm_header.has_64_bit_instructions ? "YES" : "NO");
87 87
88 auto address_space = "Unknown"; 88 auto address_space = "Unknown";
89 switch (npdm_header.address_space_type) { 89 switch (npdm_header.address_space_type) {
diff --git a/src/core/file_sys/romfs_filesystem.cpp b/src/core/file_sys/romfs_filesystem.cpp
index 4dbd6a786..83162622b 100644
--- a/src/core/file_sys/romfs_filesystem.cpp
+++ b/src/core/file_sys/romfs_filesystem.cpp
@@ -28,22 +28,21 @@ ResultCode RomFS_FileSystem::DeleteFile(const std::string& path) const {
28 28
29ResultCode RomFS_FileSystem::RenameFile(const std::string& src_path, 29ResultCode RomFS_FileSystem::RenameFile(const std::string& src_path,
30 const std::string& dest_path) const { 30 const std::string& dest_path) const {
31 LOG_CRITICAL(Service_FS, "Attempted to rename a file within an ROMFS archive ({}).", 31 LOG_CRITICAL(Service_FS, "Attempted to rename a file within an ROMFS archive ({}).", GetName());
32 GetName());
33 // TODO(wwylele): Use correct error code 32 // TODO(wwylele): Use correct error code
34 return ResultCode(-1); 33 return ResultCode(-1);
35} 34}
36 35
37ResultCode RomFS_FileSystem::DeleteDirectory(const Path& path) const { 36ResultCode RomFS_FileSystem::DeleteDirectory(const Path& path) const {
38 LOG_CRITICAL(Service_FS, "Attempted to delete a directory from an ROMFS archive ({}).", 37 LOG_CRITICAL(Service_FS, "Attempted to delete a directory from an ROMFS archive ({}).",
39 GetName()); 38 GetName());
40 // TODO(wwylele): Use correct error code 39 // TODO(wwylele): Use correct error code
41 return ResultCode(-1); 40 return ResultCode(-1);
42} 41}
43 42
44ResultCode RomFS_FileSystem::DeleteDirectoryRecursively(const Path& path) const { 43ResultCode RomFS_FileSystem::DeleteDirectoryRecursively(const Path& path) const {
45 LOG_CRITICAL(Service_FS, "Attempted to delete a directory from an ROMFS archive ({}).", 44 LOG_CRITICAL(Service_FS, "Attempted to delete a directory from an ROMFS archive ({}).",
46 GetName()); 45 GetName());
47 // TODO(wwylele): Use correct error code 46 // TODO(wwylele): Use correct error code
48 return ResultCode(-1); 47 return ResultCode(-1);
49} 48}
@@ -56,14 +55,13 @@ ResultCode RomFS_FileSystem::CreateFile(const std::string& path, u64 size) const
56 55
57ResultCode RomFS_FileSystem::CreateDirectory(const std::string& path) const { 56ResultCode RomFS_FileSystem::CreateDirectory(const std::string& path) const {
58 LOG_CRITICAL(Service_FS, "Attempted to create a directory in an ROMFS archive ({}).", 57 LOG_CRITICAL(Service_FS, "Attempted to create a directory in an ROMFS archive ({}).",
59 GetName()); 58 GetName());
60 // TODO(wwylele): Use correct error code 59 // TODO(wwylele): Use correct error code
61 return ResultCode(-1); 60 return ResultCode(-1);
62} 61}
63 62
64ResultCode RomFS_FileSystem::RenameDirectory(const Path& src_path, const Path& dest_path) const { 63ResultCode RomFS_FileSystem::RenameDirectory(const Path& src_path, const Path& dest_path) const {
65 LOG_CRITICAL(Service_FS, "Attempted to rename a file within an ROMFS archive ({}).", 64 LOG_CRITICAL(Service_FS, "Attempted to rename a file within an ROMFS archive ({}).", GetName());
66 GetName());
67 // TODO(wwylele): Use correct error code 65 // TODO(wwylele): Use correct error code
68 return ResultCode(-1); 66 return ResultCode(-1);
69} 67}
diff --git a/src/core/gdbstub/gdbstub.cpp b/src/core/gdbstub/gdbstub.cpp
index 500734f2d..938852a1a 100644
--- a/src/core/gdbstub/gdbstub.cpp
+++ b/src/core/gdbstub/gdbstub.cpp
@@ -414,7 +414,7 @@ static void RemoveBreakpoint(BreakpointType type, PAddr addr) {
414 auto bp = p.find(static_cast<u64>(addr)); 414 auto bp = p.find(static_cast<u64>(addr));
415 if (bp != p.end()) { 415 if (bp != p.end()) {
416 LOG_DEBUG(Debug_GDBStub, "gdb: removed a breakpoint: {:016X} bytes at {:016X} of type {}", 416 LOG_DEBUG(Debug_GDBStub, "gdb: removed a breakpoint: {:016X} bytes at {:016X} of type {}",
417 bp->second.len, bp->second.addr, static_cast<int>(type)); 417 bp->second.len, bp->second.addr, static_cast<int>(type));
418 p.erase(static_cast<u64>(addr)); 418 p.erase(static_cast<u64>(addr));
419 } 419 }
420} 420}
@@ -460,9 +460,9 @@ bool CheckBreakpoint(PAddr addr, BreakpointType type) {
460 460
461 if (bp->second.active && (addr >= bp->second.addr && addr < bp->second.addr + len)) { 461 if (bp->second.active && (addr >= bp->second.addr && addr < bp->second.addr + len)) {
462 LOG_DEBUG(Debug_GDBStub, 462 LOG_DEBUG(Debug_GDBStub,
463 "Found breakpoint type {} @ {:016X}, range: {:016X}" 463 "Found breakpoint type {} @ {:016X}, range: {:016X}"
464 " - {:016X} ({:X} bytes)", 464 " - {:016X} ({:X} bytes)",
465 static_cast<int>(type), addr, bp->second.addr, bp->second.addr + len, len); 465 static_cast<int>(type), addr, bp->second.addr, bp->second.addr + len, len);
466 return true; 466 return true;
467 } 467 }
468 } 468 }
@@ -658,10 +658,9 @@ static void ReadCommand() {
658 u8 checksum_calculated = CalculateChecksum(command_buffer, command_length); 658 u8 checksum_calculated = CalculateChecksum(command_buffer, command_length);
659 659
660 if (checksum_received != checksum_calculated) { 660 if (checksum_received != checksum_calculated) {
661 LOG_ERROR( 661 LOG_ERROR(Debug_GDBStub,
662 Debug_GDBStub, 662 "gdb: invalid checksum: calculated {:02X} and read {:02X} for ${}# (length: {})",
663 "gdb: invalid checksum: calculated {:02X} and read {:02X} for ${}# (length: {})", 663 checksum_calculated, checksum_received, command_buffer, command_length);
664 checksum_calculated, checksum_received, command_buffer, command_length);
665 664
666 command_length = 0; 665 command_length = 0;
667 666
@@ -889,7 +888,7 @@ static bool CommitBreakpoint(BreakpointType type, PAddr addr, u64 len) {
889 p.insert({addr, breakpoint}); 888 p.insert({addr, breakpoint});
890 889
891 LOG_DEBUG(Debug_GDBStub, "gdb: added {} breakpoint: {:016X} bytes at {:016X}", 890 LOG_DEBUG(Debug_GDBStub, "gdb: added {} breakpoint: {:016X} bytes at {:016X}",
892 static_cast<int>(type), breakpoint.len, breakpoint.addr); 891 static_cast<int>(type), breakpoint.len, breakpoint.addr);
893 892
894 return true; 893 return true;
895} 894}
diff --git a/src/core/hle/kernel/hle_ipc.cpp b/src/core/hle/kernel/hle_ipc.cpp
index 5ac3227d1..609cdbff2 100644
--- a/src/core/hle/kernel/hle_ipc.cpp
+++ b/src/core/hle/kernel/hle_ipc.cpp
@@ -280,7 +280,7 @@ size_t HLERequestContext::WriteBuffer(const void* buffer, size_t size, int buffe
280 const size_t buffer_size{GetWriteBufferSize(buffer_index)}; 280 const size_t buffer_size{GetWriteBufferSize(buffer_index)};
281 if (size > buffer_size) { 281 if (size > buffer_size) {
282 LOG_CRITICAL(Core, "size ({:016X}) is greater than buffer_size ({:016X})", size, 282 LOG_CRITICAL(Core, "size ({:016X}) is greater than buffer_size ({:016X})", size,
283 buffer_size); 283 buffer_size);
284 size = buffer_size; // TODO(bunnei): This needs to be HW tested 284 size = buffer_size; // TODO(bunnei): This needs to be HW tested
285 } 285 }
286 286
diff --git a/src/core/hle/kernel/server_session.cpp b/src/core/hle/kernel/server_session.cpp
index 29fecef20..0d5cba1d9 100644
--- a/src/core/hle/kernel/server_session.cpp
+++ b/src/core/hle/kernel/server_session.cpp
@@ -82,7 +82,7 @@ ResultCode ServerSession::HandleDomainSyncRequest(Kernel::HLERequestContext& con
82 } 82 }
83 83
84 LOG_CRITICAL(IPC, "Unknown domain command={}", 84 LOG_CRITICAL(IPC, "Unknown domain command={}",
85 static_cast<int>(domain_message_header->command.Value())); 85 static_cast<int>(domain_message_header->command.Value()));
86 ASSERT(false); 86 ASSERT(false);
87 } 87 }
88 88
diff --git a/src/core/hle/kernel/shared_memory.cpp b/src/core/hle/kernel/shared_memory.cpp
index 80fa81abd..93f7f2772 100644
--- a/src/core/hle/kernel/shared_memory.cpp
+++ b/src/core/hle/kernel/shared_memory.cpp
@@ -108,7 +108,7 @@ ResultCode SharedMemory::Map(Process* target_process, VAddr address, MemoryPermi
108 // Error out if the requested permissions don't match what the creator process allows. 108 // Error out if the requested permissions don't match what the creator process allows.
109 if (static_cast<u32>(permissions) & ~static_cast<u32>(own_other_permissions)) { 109 if (static_cast<u32>(permissions) & ~static_cast<u32>(own_other_permissions)) {
110 LOG_ERROR(Kernel, "cannot map id={}, address=0x{:X} name={}, permissions don't match", 110 LOG_ERROR(Kernel, "cannot map id={}, address=0x{:X} name={}, permissions don't match",
111 GetObjectId(), address, name); 111 GetObjectId(), address, name);
112 return ERR_INVALID_COMBINATION; 112 return ERR_INVALID_COMBINATION;
113 } 113 }
114 114
@@ -116,7 +116,7 @@ ResultCode SharedMemory::Map(Process* target_process, VAddr address, MemoryPermi
116 if (other_permissions != MemoryPermission::DontCare && 116 if (other_permissions != MemoryPermission::DontCare &&
117 static_cast<u32>(this->permissions) & ~static_cast<u32>(other_permissions)) { 117 static_cast<u32>(this->permissions) & ~static_cast<u32>(other_permissions)) {
118 LOG_ERROR(Kernel, "cannot map id={}, address=0x{:X} name={}, permissions don't match", 118 LOG_ERROR(Kernel, "cannot map id={}, address=0x{:X} name={}, permissions don't match",
119 GetObjectId(), address, name); 119 GetObjectId(), address, name);
120 return ERR_WRONG_PERMISSION; 120 return ERR_WRONG_PERMISSION;
121 } 121 }
122 122
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp
index 843fffd7e..5ad923fe7 100644
--- a/src/core/hle/kernel/svc.cpp
+++ b/src/core/hle/kernel/svc.cpp
@@ -47,14 +47,14 @@ static ResultCode SetMemoryAttribute(VAddr addr, u64 size, u32 state0, u32 state
47/// Maps a memory range into a different range. 47/// Maps a memory range into a different range.
48static ResultCode MapMemory(VAddr dst_addr, VAddr src_addr, u64 size) { 48static ResultCode MapMemory(VAddr dst_addr, VAddr src_addr, u64 size) {
49 LOG_TRACE(Kernel_SVC, "called, dst_addr=0x{:X}, src_addr=0x{:X}, size=0x{:X}", dst_addr, 49 LOG_TRACE(Kernel_SVC, "called, dst_addr=0x{:X}, src_addr=0x{:X}, size=0x{:X}", dst_addr,
50 src_addr, size); 50 src_addr, size);
51 return Core::CurrentProcess()->MirrorMemory(dst_addr, src_addr, size); 51 return Core::CurrentProcess()->MirrorMemory(dst_addr, src_addr, size);
52} 52}
53 53
54/// Unmaps a region that was previously mapped with svcMapMemory 54/// Unmaps a region that was previously mapped with svcMapMemory
55static ResultCode UnmapMemory(VAddr dst_addr, VAddr src_addr, u64 size) { 55static ResultCode UnmapMemory(VAddr dst_addr, VAddr src_addr, u64 size) {
56 LOG_TRACE(Kernel_SVC, "called, dst_addr=0x{:X}, src_addr=0x{:X}, size=0x{:X}", dst_addr, 56 LOG_TRACE(Kernel_SVC, "called, dst_addr=0x{:X}, src_addr=0x{:X}, size=0x{:X}", dst_addr,
57 src_addr, size); 57 src_addr, size);
58 return Core::CurrentProcess()->UnmapMemory(dst_addr, src_addr, size); 58 return Core::CurrentProcess()->UnmapMemory(dst_addr, src_addr, size);
59} 59}
60 60
@@ -150,7 +150,7 @@ static bool DefaultThreadWakeupCallback(ThreadWakeupReason reason, SharedPtr<Thr
150static ResultCode WaitSynchronization(Handle* index, VAddr handles_address, u64 handle_count, 150static ResultCode WaitSynchronization(Handle* index, VAddr handles_address, u64 handle_count,
151 s64 nano_seconds) { 151 s64 nano_seconds) {
152 LOG_TRACE(Kernel_SVC, "called handles_address=0x{:X}, handle_count={}, nano_seconds={}", 152 LOG_TRACE(Kernel_SVC, "called handles_address=0x{:X}, handle_count={}, nano_seconds={}",
153 handles_address, handle_count, nano_seconds); 153 handles_address, handle_count, nano_seconds);
154 154
155 if (!Memory::IsValidVirtualAddress(handles_address)) 155 if (!Memory::IsValidVirtualAddress(handles_address))
156 return ERR_INVALID_POINTER; 156 return ERR_INVALID_POINTER;
@@ -228,9 +228,9 @@ static ResultCode CancelSynchronization(Handle thread_handle) {
228static ResultCode ArbitrateLock(Handle holding_thread_handle, VAddr mutex_addr, 228static ResultCode ArbitrateLock(Handle holding_thread_handle, VAddr mutex_addr,
229 Handle requesting_thread_handle) { 229 Handle requesting_thread_handle) {
230 LOG_TRACE(Kernel_SVC, 230 LOG_TRACE(Kernel_SVC,
231 "called holding_thread_handle=0x{:08X}, mutex_addr=0x{:X}, " 231 "called holding_thread_handle=0x{:08X}, mutex_addr=0x{:X}, "
232 "requesting_current_thread_handle=0x{:08X}", 232 "requesting_current_thread_handle=0x{:08X}",
233 holding_thread_handle, mutex_addr, requesting_thread_handle); 233 holding_thread_handle, mutex_addr, requesting_thread_handle);
234 234
235 return Mutex::TryAcquire(mutex_addr, holding_thread_handle, requesting_thread_handle); 235 return Mutex::TryAcquire(mutex_addr, holding_thread_handle, requesting_thread_handle);
236} 236}
@@ -258,7 +258,7 @@ static void OutputDebugString(VAddr address, s32 len) {
258/// Gets system/memory information for the current process 258/// Gets system/memory information for the current process
259static ResultCode GetInfo(u64* result, u64 info_id, u64 handle, u64 info_sub_id) { 259static ResultCode GetInfo(u64* result, u64 info_id, u64 handle, u64 info_sub_id) {
260 LOG_TRACE(Kernel_SVC, "called info_id=0x{:X}, info_sub_id=0x{:X}, handle=0x{:08X}", info_id, 260 LOG_TRACE(Kernel_SVC, "called info_id=0x{:X}, info_sub_id=0x{:X}, handle=0x{:08X}", info_id,
261 info_sub_id, handle); 261 info_sub_id, handle);
262 262
263 auto& vm_manager = Core::CurrentProcess()->vm_manager; 263 auto& vm_manager = Core::CurrentProcess()->vm_manager;
264 264
@@ -314,12 +314,12 @@ static ResultCode GetInfo(u64* result, u64 info_id, u64 handle, u64 info_sub_id)
314 break; 314 break;
315 case GetInfoType::PrivilegedProcessId: 315 case GetInfoType::PrivilegedProcessId:
316 LOG_WARNING(Kernel_SVC, 316 LOG_WARNING(Kernel_SVC,
317 "(STUBBED) Attempted to query privileged process id bounds, returned 0"); 317 "(STUBBED) Attempted to query privileged process id bounds, returned 0");
318 *result = 0; 318 *result = 0;
319 break; 319 break;
320 case GetInfoType::UserExceptionContextAddr: 320 case GetInfoType::UserExceptionContextAddr:
321 LOG_WARNING(Kernel_SVC, 321 LOG_WARNING(Kernel_SVC,
322 "(STUBBED) Attempted to query user exception context address, returned 0"); 322 "(STUBBED) Attempted to query user exception context address, returned 0");
323 *result = 0; 323 *result = 0;
324 break; 324 break;
325 default: 325 default:
@@ -331,8 +331,7 @@ static ResultCode GetInfo(u64* result, u64 info_id, u64 handle, u64 info_sub_id)
331 331
332/// Sets the thread activity 332/// Sets the thread activity
333static ResultCode SetThreadActivity(Handle handle, u32 unknown) { 333static ResultCode SetThreadActivity(Handle handle, u32 unknown) {
334 LOG_WARNING(Kernel_SVC, "(STUBBED) called, handle=0x{:08X}, unknown=0x{:08X}", handle, 334 LOG_WARNING(Kernel_SVC, "(STUBBED) called, handle=0x{:08X}, unknown=0x{:08X}", handle, unknown);
335 unknown);
336 return RESULT_SUCCESS; 335 return RESULT_SUCCESS;
337} 336}
338 337
@@ -383,10 +382,9 @@ static u32 GetCurrentProcessorNumber() {
383 382
384static ResultCode MapSharedMemory(Handle shared_memory_handle, VAddr addr, u64 size, 383static ResultCode MapSharedMemory(Handle shared_memory_handle, VAddr addr, u64 size,
385 u32 permissions) { 384 u32 permissions) {
386 LOG_TRACE( 385 LOG_TRACE(Kernel_SVC,
387 Kernel_SVC, 386 "called, shared_memory_handle=0x{:X}, addr=0x{:X}, size=0x{:X}, permissions=0x{:08X}",
388 "called, shared_memory_handle=0x{:X}, addr=0x{:X}, size=0x{:X}, permissions=0x{:08X}", 387 shared_memory_handle, addr, size, permissions);
389 shared_memory_handle, addr, size, permissions);
390 388
391 SharedPtr<SharedMemory> shared_memory = g_handle_table.Get<SharedMemory>(shared_memory_handle); 389 SharedPtr<SharedMemory> shared_memory = g_handle_table.Get<SharedMemory>(shared_memory_handle);
392 if (!shared_memory) { 390 if (!shared_memory) {
@@ -414,7 +412,7 @@ static ResultCode MapSharedMemory(Handle shared_memory_handle, VAddr addr, u64 s
414 412
415static ResultCode UnmapSharedMemory(Handle shared_memory_handle, VAddr addr, u64 size) { 413static ResultCode UnmapSharedMemory(Handle shared_memory_handle, VAddr addr, u64 size) {
416 LOG_WARNING(Kernel_SVC, "called, shared_memory_handle=0x{:08X}, addr=0x{:X}, size=0x{:X}", 414 LOG_WARNING(Kernel_SVC, "called, shared_memory_handle=0x{:08X}, addr=0x{:X}, size=0x{:X}",
417 shared_memory_handle, addr, size); 415 shared_memory_handle, addr, size);
418 416
419 SharedPtr<SharedMemory> shared_memory = g_handle_table.Get<SharedMemory>(shared_memory_handle); 417 SharedPtr<SharedMemory> shared_memory = g_handle_table.Get<SharedMemory>(shared_memory_handle);
420 418
@@ -531,9 +529,9 @@ static ResultCode CreateThread(Handle* out_handle, VAddr entry_point, u64 arg, V
531 Core::System::GetInstance().CpuCore(thread->processor_id).PrepareReschedule(); 529 Core::System::GetInstance().CpuCore(thread->processor_id).PrepareReschedule();
532 530
533 LOG_TRACE(Kernel_SVC, 531 LOG_TRACE(Kernel_SVC,
534 "called entrypoint=0x{:08X} ({}), arg=0x{:08X}, stacktop=0x{:08X}, " 532 "called entrypoint=0x{:08X} ({}), arg=0x{:08X}, stacktop=0x{:08X}, "
535 "threadpriority=0x{:08X}, processorid=0x{:08X} : created handle=0x{:08X}", 533 "threadpriority=0x{:08X}, processorid=0x{:08X} : created handle=0x{:08X}",
536 entry_point, name, arg, stack_top, priority, processor_id, *out_handle); 534 entry_point, name, arg, stack_top, priority, processor_id, *out_handle);
537 535
538 return RESULT_SUCCESS; 536 return RESULT_SUCCESS;
539} 537}
@@ -612,7 +610,7 @@ static ResultCode WaitProcessWideKeyAtomic(VAddr mutex_addr, VAddr condition_var
612/// Signal process wide key 610/// Signal process wide key
613static ResultCode SignalProcessWideKey(VAddr condition_variable_addr, s32 target) { 611static ResultCode SignalProcessWideKey(VAddr condition_variable_addr, s32 target) {
614 LOG_TRACE(Kernel_SVC, "called, condition_variable_addr=0x{:X}, target=0x{:08X}", 612 LOG_TRACE(Kernel_SVC, "called, condition_variable_addr=0x{:X}, target=0x{:08X}",
615 condition_variable_addr, target); 613 condition_variable_addr, target);
616 614
617 auto RetrieveWaitingThreads = 615 auto RetrieveWaitingThreads =
618 [](size_t core_index, std::vector<SharedPtr<Thread>>& waiting_threads, VAddr condvar_addr) { 616 [](size_t core_index, std::vector<SharedPtr<Thread>>& waiting_threads, VAddr condvar_addr) {
@@ -693,7 +691,7 @@ static ResultCode SignalProcessWideKey(VAddr condition_variable_addr, s32 target
693// Wait for an address (via Address Arbiter) 691// Wait for an address (via Address Arbiter)
694static ResultCode WaitForAddress(VAddr address, u32 type, s32 value, s64 timeout) { 692static ResultCode WaitForAddress(VAddr address, u32 type, s32 value, s64 timeout) {
695 LOG_WARNING(Kernel_SVC, "called, address=0x{:X}, type=0x{:X}, value=0x{:X}, timeout={}", 693 LOG_WARNING(Kernel_SVC, "called, address=0x{:X}, type=0x{:X}, value=0x{:X}, timeout={}",
696 address, type, value, timeout); 694 address, type, value, timeout);
697 // If the passed address is a kernel virtual address, return invalid memory state. 695 // If the passed address is a kernel virtual address, return invalid memory state.
698 if (Memory::IsKernelVirtualAddress(address)) { 696 if (Memory::IsKernelVirtualAddress(address)) {
699 return ERR_INVALID_ADDRESS_STATE; 697 return ERR_INVALID_ADDRESS_STATE;
@@ -717,9 +715,8 @@ static ResultCode WaitForAddress(VAddr address, u32 type, s32 value, s64 timeout
717 715
718// Signals to an address (via Address Arbiter) 716// Signals to an address (via Address Arbiter)
719static ResultCode SignalToAddress(VAddr address, u32 type, s32 value, s32 num_to_wake) { 717static ResultCode SignalToAddress(VAddr address, u32 type, s32 value, s32 num_to_wake) {
720 LOG_WARNING(Kernel_SVC, 718 LOG_WARNING(Kernel_SVC, "called, address=0x{:X}, type=0x{:X}, value=0x{:X}, num_to_wake=0x{:X}",
721 "called, address=0x{:X}, type=0x{:X}, value=0x{:X}, num_to_wake=0x{:X}", address, 719 address, type, value, num_to_wake);
722 type, value, num_to_wake);
723 // If the passed address is a kernel virtual address, return invalid memory state. 720 // If the passed address is a kernel virtual address, return invalid memory state.
724 if (Memory::IsKernelVirtualAddress(address)) { 721 if (Memory::IsKernelVirtualAddress(address)) {
725 return ERR_INVALID_ADDRESS_STATE; 722 return ERR_INVALID_ADDRESS_STATE;
@@ -769,8 +766,8 @@ static ResultCode ResetSignal(Handle handle) {
769 766
770/// Creates a TransferMemory object 767/// Creates a TransferMemory object
771static ResultCode CreateTransferMemory(Handle* handle, VAddr addr, u64 size, u32 permissions) { 768static ResultCode CreateTransferMemory(Handle* handle, VAddr addr, u64 size, u32 permissions) {
772 LOG_WARNING(Kernel_SVC, "(STUBBED) called addr=0x{:X}, size=0x{:X}, perms=0x{:08X}", addr, 769 LOG_WARNING(Kernel_SVC, "(STUBBED) called addr=0x{:X}, size=0x{:X}, perms=0x{:08X}", addr, size,
773 size, permissions); 770 permissions);
774 *handle = 0; 771 *handle = 0;
775 return RESULT_SUCCESS; 772 return RESULT_SUCCESS;
776} 773}
@@ -791,7 +788,7 @@ static ResultCode GetThreadCoreMask(Handle thread_handle, u32* core, u64* mask)
791 788
792static ResultCode SetThreadCoreMask(Handle thread_handle, u32 core, u64 mask) { 789static ResultCode SetThreadCoreMask(Handle thread_handle, u32 core, u64 mask) {
793 LOG_DEBUG(Kernel_SVC, "called, handle=0x{:08X}, mask=0x{:16X}, core=0x{:X}", thread_handle, 790 LOG_DEBUG(Kernel_SVC, "called, handle=0x{:08X}, mask=0x{:16X}, core=0x{:X}", thread_handle,
794 mask, core); 791 mask, core);
795 792
796 const SharedPtr<Thread> thread = g_handle_table.Get<Thread>(thread_handle); 793 const SharedPtr<Thread> thread = g_handle_table.Get<Thread>(thread_handle);
797 if (!thread) { 794 if (!thread) {
@@ -831,7 +828,7 @@ static ResultCode SetThreadCoreMask(Handle thread_handle, u32 core, u64 mask) {
831static ResultCode CreateSharedMemory(Handle* handle, u64 size, u32 local_permissions, 828static ResultCode CreateSharedMemory(Handle* handle, u64 size, u32 local_permissions,
832 u32 remote_permissions) { 829 u32 remote_permissions) {
833 LOG_TRACE(Kernel_SVC, "called, size=0x{:X}, localPerms=0x{:08X}, remotePerms=0x{:08X}", size, 830 LOG_TRACE(Kernel_SVC, "called, size=0x{:X}, localPerms=0x{:08X}, remotePerms=0x{:08X}", size,
834 local_permissions, remote_permissions); 831 local_permissions, remote_permissions);
835 auto sharedMemHandle = 832 auto sharedMemHandle =
836 SharedMemory::Create(g_handle_table.Get<Process>(KernelHandle::CurrentProcess), size, 833 SharedMemory::Create(g_handle_table.Get<Process>(KernelHandle::CurrentProcess), size,
837 static_cast<MemoryPermission>(local_permissions), 834 static_cast<MemoryPermission>(local_permissions),
diff --git a/src/core/hle/kernel/thread.cpp b/src/core/hle/kernel/thread.cpp
index 01c346520..9a9746585 100644
--- a/src/core/hle/kernel/thread.cpp
+++ b/src/core/hle/kernel/thread.cpp
@@ -344,7 +344,7 @@ ResultVal<SharedPtr<Thread>> Thread::Create(std::string name, VAddr entry_point,
344 344
345 if (linheap_memory->size() + Memory::PAGE_SIZE > memory_region->size) { 345 if (linheap_memory->size() + Memory::PAGE_SIZE > memory_region->size) {
346 LOG_ERROR(Kernel_SVC, 346 LOG_ERROR(Kernel_SVC,
347 "Not enough space in region to allocate a new TLS page for thread"); 347 "Not enough space in region to allocate a new TLS page for thread");
348 return ERR_OUT_OF_MEMORY; 348 return ERR_OUT_OF_MEMORY;
349 } 349 }
350 350
diff --git a/src/core/hle/kernel/vm_manager.cpp b/src/core/hle/kernel/vm_manager.cpp
index e05aa5931..034dd490e 100644
--- a/src/core/hle/kernel/vm_manager.cpp
+++ b/src/core/hle/kernel/vm_manager.cpp
@@ -243,11 +243,11 @@ void VMManager::LogLayout() const {
243 for (const auto& p : vma_map) { 243 for (const auto& p : vma_map) {
244 const VirtualMemoryArea& vma = p.second; 244 const VirtualMemoryArea& vma = p.second;
245 LOG_DEBUG(Kernel, "{:016X} - {:016X} size: {:016X} {}{}{} {}", vma.base, 245 LOG_DEBUG(Kernel, "{:016X} - {:016X} size: {:016X} {}{}{} {}", vma.base,
246 vma.base + vma.size, vma.size, 246 vma.base + vma.size, vma.size,
247 (u8)vma.permissions & (u8)VMAPermission::Read ? 'R' : '-', 247 (u8)vma.permissions & (u8)VMAPermission::Read ? 'R' : '-',
248 (u8)vma.permissions & (u8)VMAPermission::Write ? 'W' : '-', 248 (u8)vma.permissions & (u8)VMAPermission::Write ? 'W' : '-',
249 (u8)vma.permissions & (u8)VMAPermission::Execute ? 'X' : '-', 249 (u8)vma.permissions & (u8)VMAPermission::Execute ? 'X' : '-',
250 GetMemoryStateName(vma.meminfo_state)); 250 GetMemoryStateName(vma.meminfo_state));
251 } 251 }
252} 252}
253 253
diff --git a/src/core/hle/service/apm/interface.cpp b/src/core/hle/service/apm/interface.cpp
index cf43949ec..751d73f8d 100644
--- a/src/core/hle/service/apm/interface.cpp
+++ b/src/core/hle/service/apm/interface.cpp
@@ -30,7 +30,7 @@ private:
30 rb.Push(RESULT_SUCCESS); 30 rb.Push(RESULT_SUCCESS);
31 31
32 LOG_WARNING(Service_APM, "(STUBBED) called mode={} config={}", static_cast<u32>(mode), 32 LOG_WARNING(Service_APM, "(STUBBED) called mode={} config={}", static_cast<u32>(mode),
33 config); 33 config);
34 } 34 }
35 35
36 void GetPerformanceConfiguration(Kernel::HLERequestContext& ctx) { 36 void GetPerformanceConfiguration(Kernel::HLERequestContext& ctx) {
diff --git a/src/core/hle/service/filesystem/filesystem.cpp b/src/core/hle/service/filesystem/filesystem.cpp
index 8046aa5de..f58b518b6 100644
--- a/src/core/hle/service/filesystem/filesystem.cpp
+++ b/src/core/hle/service/filesystem/filesystem.cpp
@@ -25,8 +25,8 @@ ResultCode RegisterFileSystem(std::unique_ptr<FileSys::FileSystemFactory>&& fact
25 ASSERT_MSG(inserted, "Tried to register more than one system with same id code"); 25 ASSERT_MSG(inserted, "Tried to register more than one system with same id code");
26 26
27 auto& filesystem = result.first->second; 27 auto& filesystem = result.first->second;
28 LOG_DEBUG(Service_FS, "Registered file system {} with id code 0x{:08X}", 28 LOG_DEBUG(Service_FS, "Registered file system {} with id code 0x{:08X}", filesystem->GetName(),
29 filesystem->GetName(), static_cast<u32>(type)); 29 static_cast<u32>(type));
30 return RESULT_SUCCESS; 30 return RESULT_SUCCESS;
31} 31}
32 32
diff --git a/src/core/hle/service/nvdrv/devices/nvdisp_disp0.cpp b/src/core/hle/service/nvdrv/devices/nvdisp_disp0.cpp
index af216e521..c39d5a164 100644
--- a/src/core/hle/service/nvdrv/devices/nvdisp_disp0.cpp
+++ b/src/core/hle/service/nvdrv/devices/nvdisp_disp0.cpp
@@ -21,8 +21,8 @@ void nvdisp_disp0::flip(u32 buffer_handle, u32 offset, u32 format, u32 width, u3
21 u32 stride, NVFlinger::BufferQueue::BufferTransformFlags transform) { 21 u32 stride, NVFlinger::BufferQueue::BufferTransformFlags transform) {
22 VAddr addr = nvmap_dev->GetObjectAddress(buffer_handle); 22 VAddr addr = nvmap_dev->GetObjectAddress(buffer_handle);
23 LOG_WARNING(Service, 23 LOG_WARNING(Service,
24 "Drawing from address {:X} offset {:08X} Width {} Height {} Stride {} Format {}", 24 "Drawing from address {:X} offset {:08X} Width {} Height {} Stride {} Format {}",
25 addr, offset, width, height, stride, format); 25 addr, offset, width, height, stride, format);
26 26
27 using PixelFormat = Tegra::FramebufferConfig::PixelFormat; 27 using PixelFormat = Tegra::FramebufferConfig::PixelFormat;
28 const Tegra::FramebufferConfig framebuffer{ 28 const Tegra::FramebufferConfig framebuffer{
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp
index 6b9a4f7c1..57b128b40 100644
--- a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp
+++ b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp
@@ -15,7 +15,7 @@ namespace Service::Nvidia::Devices {
15 15
16u32 nvhost_as_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) { 16u32 nvhost_as_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) {
17 LOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}", 17 LOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}",
18 command.raw, input.size(), output.size()); 18 command.raw, input.size(), output.size());
19 19
20 switch (static_cast<IoctlCommand>(command.raw)) { 20 switch (static_cast<IoctlCommand>(command.raw)) {
21 case IoctlCommand::IocInitalizeExCommand: 21 case IoctlCommand::IocInitalizeExCommand:
@@ -50,7 +50,7 @@ u32 nvhost_as_gpu::AllocateSpace(const std::vector<u8>& input, std::vector<u8>&
50 IoctlAllocSpace params{}; 50 IoctlAllocSpace params{};
51 std::memcpy(&params, input.data(), input.size()); 51 std::memcpy(&params, input.data(), input.size());
52 LOG_DEBUG(Service_NVDRV, "called, pages={:X}, page_size={:X}, flags={:X}", params.pages, 52 LOG_DEBUG(Service_NVDRV, "called, pages={:X}, page_size={:X}, flags={:X}", params.pages,
53 params.page_size, params.flags); 53 params.page_size, params.flags);
54 54
55 auto& gpu = Core::System::GetInstance().GPU(); 55 auto& gpu = Core::System::GetInstance().GPU();
56 const u64 size{static_cast<u64>(params.pages) * static_cast<u64>(params.page_size)}; 56 const u64 size{static_cast<u64>(params.pages) * static_cast<u64>(params.page_size)};
@@ -76,7 +76,7 @@ u32 nvhost_as_gpu::Remap(const std::vector<u8>& input, std::vector<u8>& output)
76 76
77 for (const auto& entry : entries) { 77 for (const auto& entry : entries) {
78 LOG_WARNING(Service_NVDRV, "remap entry, offset=0x{:X} handle=0x{:X} pages=0x{:X}", 78 LOG_WARNING(Service_NVDRV, "remap entry, offset=0x{:X} handle=0x{:X} pages=0x{:X}",
79 entry.offset, entry.nvmap_handle, entry.pages); 79 entry.offset, entry.nvmap_handle, entry.pages);
80 Tegra::GPUVAddr offset = static_cast<Tegra::GPUVAddr>(entry.offset) << 0x10; 80 Tegra::GPUVAddr offset = static_cast<Tegra::GPUVAddr>(entry.offset) << 0x10;
81 81
82 auto object = nvmap_dev->GetObject(entry.nvmap_handle); 82 auto object = nvmap_dev->GetObject(entry.nvmap_handle);
@@ -99,10 +99,10 @@ u32 nvhost_as_gpu::MapBufferEx(const std::vector<u8>& input, std::vector<u8>& ou
99 std::memcpy(&params, input.data(), input.size()); 99 std::memcpy(&params, input.data(), input.size());
100 100
101 LOG_DEBUG(Service_NVDRV, 101 LOG_DEBUG(Service_NVDRV,
102 "called, flags={:X}, nvmap_handle={:X}, buffer_offset={}, mapping_size={}" 102 "called, flags={:X}, nvmap_handle={:X}, buffer_offset={}, mapping_size={}"
103 ", offset={}", 103 ", offset={}",
104 params.flags, params.nvmap_handle, params.buffer_offset, params.mapping_size, 104 params.flags, params.nvmap_handle, params.buffer_offset, params.mapping_size,
105 params.offset); 105 params.offset);
106 106
107 if (!params.nvmap_handle) { 107 if (!params.nvmap_handle) {
108 return 0; 108 return 0;
@@ -179,7 +179,7 @@ u32 nvhost_as_gpu::GetVARegions(const std::vector<u8>& input, std::vector<u8>& o
179 IoctlGetVaRegions params{}; 179 IoctlGetVaRegions params{};
180 std::memcpy(&params, input.data(), input.size()); 180 std::memcpy(&params, input.data(), input.size());
181 LOG_WARNING(Service_NVDRV, "(STUBBED) called, buf_addr={:X}, buf_size={:X}", params.buf_addr, 181 LOG_WARNING(Service_NVDRV, "(STUBBED) called, buf_addr={:X}, buf_size={:X}", params.buf_addr,
182 params.buf_size); 182 params.buf_size);
183 183
184 params.buf_size = 0x30; 184 params.buf_size = 0x30;
185 params.regions[0].offset = 0x04000000; 185 params.regions[0].offset = 0x04000000;
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp b/src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp
index b7d8233ad..303acdcb3 100644
--- a/src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp
+++ b/src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp
@@ -10,7 +10,7 @@ namespace Service::Nvidia::Devices {
10 10
11u32 nvhost_ctrl::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) { 11u32 nvhost_ctrl::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) {
12 LOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}", 12 LOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}",
13 command.raw, input.size(), output.size()); 13 command.raw, input.size(), output.size());
14 14
15 switch (static_cast<IoctlCommand>(command.raw)) { 15 switch (static_cast<IoctlCommand>(command.raw)) {
16 case IoctlCommand::IocGetConfigCommand: 16 case IoctlCommand::IocGetConfigCommand:
@@ -30,7 +30,7 @@ u32 nvhost_ctrl::NvOsGetConfigU32(const std::vector<u8>& input, std::vector<u8>&
30 IocGetConfigParams params{}; 30 IocGetConfigParams params{};
31 std::memcpy(&params, input.data(), sizeof(params)); 31 std::memcpy(&params, input.data(), sizeof(params));
32 LOG_DEBUG(Service_NVDRV, "called, setting={}!{}", params.domain_str.data(), 32 LOG_DEBUG(Service_NVDRV, "called, setting={}!{}", params.domain_str.data(),
33 params.param_str.data()); 33 params.param_str.data());
34 34
35 if (!strcmp(params.domain_str.data(), "nv")) { 35 if (!strcmp(params.domain_str.data(), "nv")) {
36 if (!strcmp(params.param_str.data(), "NV_MEMORY_PROFILER")) { 36 if (!strcmp(params.param_str.data(), "NV_MEMORY_PROFILER")) {
@@ -54,8 +54,8 @@ u32 nvhost_ctrl::IocCtrlEventWait(const std::vector<u8>& input, std::vector<u8>&
54 IocCtrlEventWaitParams params{}; 54 IocCtrlEventWaitParams params{};
55 std::memcpy(&params, input.data(), sizeof(params)); 55 std::memcpy(&params, input.data(), sizeof(params));
56 LOG_WARNING(Service_NVDRV, 56 LOG_WARNING(Service_NVDRV,
57 "(STUBBED) called, syncpt_id={}, threshold={}, timeout={}, is_async={}", 57 "(STUBBED) called, syncpt_id={}, threshold={}, timeout={}, is_async={}",
58 params.syncpt_id, params.threshold, params.timeout, is_async); 58 params.syncpt_id, params.threshold, params.timeout, is_async);
59 59
60 // TODO(Subv): Implement actual syncpt waiting. 60 // TODO(Subv): Implement actual syncpt waiting.
61 params.value = 0; 61 params.value = 0;
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp b/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp
index b595d6e83..44e062f50 100644
--- a/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp
+++ b/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp
@@ -11,7 +11,7 @@ namespace Service::Nvidia::Devices {
11 11
12u32 nvhost_ctrl_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) { 12u32 nvhost_ctrl_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) {
13 LOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}", 13 LOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}",
14 command.raw, input.size(), output.size()); 14 command.raw, input.size(), output.size());
15 15
16 switch (static_cast<IoctlCommand>(command.raw)) { 16 switch (static_cast<IoctlCommand>(command.raw)) {
17 case IoctlCommand::IocGetCharacteristicsCommand: 17 case IoctlCommand::IocGetCharacteristicsCommand:
@@ -84,7 +84,7 @@ u32 nvhost_ctrl_gpu::GetTPCMasks(const std::vector<u8>& input, std::vector<u8>&
84 IoctlGpuGetTpcMasksArgs params{}; 84 IoctlGpuGetTpcMasksArgs params{};
85 std::memcpy(&params, input.data(), input.size()); 85 std::memcpy(&params, input.data(), input.size());
86 LOG_INFO(Service_NVDRV, "called, mask=0x{:X}, mask_buf_addr=0x{:X}", params.mask_buf_size, 86 LOG_INFO(Service_NVDRV, "called, mask=0x{:X}, mask_buf_addr=0x{:X}", params.mask_buf_size,
87 params.mask_buf_addr); 87 params.mask_buf_addr);
88 // TODO(ogniK): Confirm value on hardware 88 // TODO(ogniK): Confirm value on hardware
89 if (params.mask_buf_size) 89 if (params.mask_buf_size)
90 params.tpc_mask_size = 4 * 1; // 4 * num_gpc 90 params.tpc_mask_size = 4 * 1; // 4 * num_gpc
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp b/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp
index 2812e029e..8de870596 100644
--- a/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp
+++ b/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp
@@ -13,7 +13,7 @@ namespace Service::Nvidia::Devices {
13 13
14u32 nvhost_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) { 14u32 nvhost_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) {
15 LOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}", 15 LOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}",
16 command.raw, input.size(), output.size()); 16 command.raw, input.size(), output.size());
17 17
18 switch (static_cast<IoctlCommand>(command.raw)) { 18 switch (static_cast<IoctlCommand>(command.raw)) {
19 case IoctlCommand::IocSetNVMAPfdCommand: 19 case IoctlCommand::IocSetNVMAPfdCommand:
@@ -76,7 +76,7 @@ u32 nvhost_gpu::GetClientData(const std::vector<u8>& input, std::vector<u8>& out
76u32 nvhost_gpu::ZCullBind(const std::vector<u8>& input, std::vector<u8>& output) { 76u32 nvhost_gpu::ZCullBind(const std::vector<u8>& input, std::vector<u8>& output) {
77 std::memcpy(&zcull_params, input.data(), input.size()); 77 std::memcpy(&zcull_params, input.data(), input.size());
78 LOG_DEBUG(Service_NVDRV, "called, gpu_va={:X}, mode={:X}", zcull_params.gpu_va, 78 LOG_DEBUG(Service_NVDRV, "called, gpu_va={:X}, mode={:X}", zcull_params.gpu_va,
79 zcull_params.mode); 79 zcull_params.mode);
80 std::memcpy(output.data(), &zcull_params, output.size()); 80 std::memcpy(output.data(), &zcull_params, output.size());
81 return 0; 81 return 0;
82} 82}
@@ -84,8 +84,8 @@ u32 nvhost_gpu::ZCullBind(const std::vector<u8>& input, std::vector<u8>& output)
84u32 nvhost_gpu::SetErrorNotifier(const std::vector<u8>& input, std::vector<u8>& output) { 84u32 nvhost_gpu::SetErrorNotifier(const std::vector<u8>& input, std::vector<u8>& output) {
85 IoctlSetErrorNotifier params{}; 85 IoctlSetErrorNotifier params{};
86 std::memcpy(&params, input.data(), input.size()); 86 std::memcpy(&params, input.data(), input.size());
87 LOG_WARNING(Service_NVDRV, "(STUBBED) called, offset={:X}, size={:X}, mem={:X}", 87 LOG_WARNING(Service_NVDRV, "(STUBBED) called, offset={:X}, size={:X}, mem={:X}", params.offset,
88 params.offset, params.size, params.mem); 88 params.size, params.mem);
89 std::memcpy(output.data(), &params, output.size()); 89 std::memcpy(output.data(), &params, output.size());
90 return 0; 90 return 0;
91} 91}
@@ -100,10 +100,10 @@ u32 nvhost_gpu::AllocGPFIFOEx2(const std::vector<u8>& input, std::vector<u8>& ou
100 IoctlAllocGpfifoEx2 params{}; 100 IoctlAllocGpfifoEx2 params{};
101 std::memcpy(&params, input.data(), input.size()); 101 std::memcpy(&params, input.data(), input.size());
102 LOG_WARNING(Service_NVDRV, 102 LOG_WARNING(Service_NVDRV,
103 "(STUBBED) called, num_entries={:X}, flags={:X}, unk0={:X}, " 103 "(STUBBED) called, num_entries={:X}, flags={:X}, unk0={:X}, "
104 "unk1={:X}, unk2={:X}, unk3={:X}", 104 "unk1={:X}, unk2={:X}, unk3={:X}",
105 params.num_entries, params.flags, params.unk0, params.unk1, params.unk2, 105 params.num_entries, params.flags, params.unk0, params.unk1, params.unk2,
106 params.unk3); 106 params.unk3);
107 params.fence_out.id = 0; 107 params.fence_out.id = 0;
108 params.fence_out.value = 0; 108 params.fence_out.value = 0;
109 std::memcpy(output.data(), &params, output.size()); 109 std::memcpy(output.data(), &params, output.size());
@@ -114,7 +114,7 @@ u32 nvhost_gpu::AllocateObjectContext(const std::vector<u8>& input, std::vector<
114 IoctlAllocObjCtx params{}; 114 IoctlAllocObjCtx params{};
115 std::memcpy(&params, input.data(), input.size()); 115 std::memcpy(&params, input.data(), input.size());
116 LOG_WARNING(Service_NVDRV, "(STUBBED) called, class_num={:X}, flags={:X}", params.class_num, 116 LOG_WARNING(Service_NVDRV, "(STUBBED) called, class_num={:X}, flags={:X}", params.class_num,
117 params.flags); 117 params.flags);
118 params.obj_id = 0x0; 118 params.obj_id = 0x0;
119 std::memcpy(output.data(), &params, output.size()); 119 std::memcpy(output.data(), &params, output.size());
120 return 0; 120 return 0;
@@ -127,7 +127,7 @@ u32 nvhost_gpu::SubmitGPFIFO(const std::vector<u8>& input, std::vector<u8>& outp
127 IoctlSubmitGpfifo params{}; 127 IoctlSubmitGpfifo params{};
128 std::memcpy(&params, input.data(), sizeof(IoctlSubmitGpfifo)); 128 std::memcpy(&params, input.data(), sizeof(IoctlSubmitGpfifo));
129 LOG_WARNING(Service_NVDRV, "(STUBBED) called, gpfifo={:X}, num_entries={:X}, flags={:X}", 129 LOG_WARNING(Service_NVDRV, "(STUBBED) called, gpfifo={:X}, num_entries={:X}, flags={:X}",
130 params.gpfifo, params.num_entries, params.flags); 130 params.gpfifo, params.num_entries, params.flags);
131 131
132 auto entries = std::vector<IoctlGpfifoEntry>(); 132 auto entries = std::vector<IoctlGpfifoEntry>();
133 entries.resize(params.num_entries); 133 entries.resize(params.num_entries);
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_nvdec.cpp b/src/core/hle/service/nvdrv/devices/nvhost_nvdec.cpp
index 313c50ef5..b51c73ee8 100644
--- a/src/core/hle/service/nvdrv/devices/nvhost_nvdec.cpp
+++ b/src/core/hle/service/nvdrv/devices/nvhost_nvdec.cpp
@@ -10,7 +10,7 @@ namespace Service::Nvidia::Devices {
10 10
11u32 nvhost_nvdec::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) { 11u32 nvhost_nvdec::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) {
12 LOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}", 12 LOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}",
13 command.raw, input.size(), output.size()); 13 command.raw, input.size(), output.size());
14 14
15 switch (static_cast<IoctlCommand>(command.raw)) { 15 switch (static_cast<IoctlCommand>(command.raw)) {
16 case IoctlCommand::IocSetNVMAPfdCommand: 16 case IoctlCommand::IocSetNVMAPfdCommand:
diff --git a/src/core/hle/service/sm/sm.cpp b/src/core/hle/service/sm/sm.cpp
index ae4d4d32c..f22a2a79f 100644
--- a/src/core/hle/service/sm/sm.cpp
+++ b/src/core/hle/service/sm/sm.cpp
@@ -102,8 +102,7 @@ void SM::GetService(Kernel::HLERequestContext& ctx) {
102 if (client_port.Failed()) { 102 if (client_port.Failed()) {
103 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0); 103 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0);
104 rb.Push(client_port.Code()); 104 rb.Push(client_port.Code());
105 LOG_ERROR(Service_SM, "called service={} -> error 0x{:08X}", name, 105 LOG_ERROR(Service_SM, "called service={} -> error 0x{:08X}", name, client_port.Code().raw);
106 client_port.Code().raw);
107 if (name.length() == 0) 106 if (name.length() == 0)
108 return; // LibNX Fix 107 return; // LibNX Fix
109 UNIMPLEMENTED(); 108 UNIMPLEMENTED();
diff --git a/src/core/hle/service/sockets/bsd.cpp b/src/core/hle/service/sockets/bsd.cpp
index f03666089..32648bdd9 100644
--- a/src/core/hle/service/sockets/bsd.cpp
+++ b/src/core/hle/service/sockets/bsd.cpp
@@ -32,8 +32,7 @@ void BSD::Socket(Kernel::HLERequestContext& ctx) {
32 u32 type = rp.Pop<u32>(); 32 u32 type = rp.Pop<u32>();
33 u32 protocol = rp.Pop<u32>(); 33 u32 protocol = rp.Pop<u32>();
34 34
35 LOG_WARNING(Service, "(STUBBED) called domain={} type={} protocol={}", domain, type, 35 LOG_WARNING(Service, "(STUBBED) called domain={} type={} protocol={}", domain, type, protocol);
36 protocol);
37 36
38 u32 fd = next_fd++; 37 u32 fd = next_fd++;
39 38
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp
index dbd09d07d..f3765b555 100644
--- a/src/core/hle/service/vi/vi.cpp
+++ b/src/core/hle/service/vi/vi.cpp
@@ -548,7 +548,7 @@ private:
548 u32 type = rp.Pop<u32>(); 548 u32 type = rp.Pop<u32>();
549 549
550 LOG_WARNING(Service_VI, "(STUBBED) called id={}, addval={:08X}, type={:08X}", id, addval, 550 LOG_WARNING(Service_VI, "(STUBBED) called id={}, addval={:08X}, type={:08X}", id, addval,
551 type); 551 type);
552 IPC::ResponseBuilder rb{ctx, 2}; 552 IPC::ResponseBuilder rb{ctx, 2};
553 rb.Push(RESULT_SUCCESS); 553 rb.Push(RESULT_SUCCESS);
554 } 554 }
@@ -641,7 +641,7 @@ private:
641 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0); 641 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0);
642 rb.Push(RESULT_SUCCESS); 642 rb.Push(RESULT_SUCCESS);
643 LOG_WARNING(Service_VI, "(STUBBED) called, layer_id=0x{:08X}, visibility={}", layer_id, 643 LOG_WARNING(Service_VI, "(STUBBED) called, layer_id=0x{:08X}, visibility={}", layer_id,
644 visibility); 644 visibility);
645 } 645 }
646}; 646};
647 647
@@ -763,7 +763,7 @@ private:
763 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0); 763 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0);
764 rb.Push(RESULT_SUCCESS); 764 rb.Push(RESULT_SUCCESS);
765 LOG_WARNING(Service_VI, "(STUBBED) called, layer_id=0x{:X}, visibility={}", layer_id, 765 LOG_WARNING(Service_VI, "(STUBBED) called, layer_id=0x{:X}, visibility={}", layer_id,
766 visibility); 766 visibility);
767 } 767 }
768 768
769 std::shared_ptr<NVFlinger::NVFlinger> nv_flinger; 769 std::shared_ptr<NVFlinger::NVFlinger> nv_flinger;
diff --git a/src/core/loader/elf.cpp b/src/core/loader/elf.cpp
index c984ef852..b69e5c6ef 100644
--- a/src/core/loader/elf.cpp
+++ b/src/core/loader/elf.cpp
@@ -305,7 +305,7 @@ SharedPtr<CodeSet> ElfReader::LoadInto(u32 vaddr) {
305 for (unsigned int i = 0; i < header->e_phnum; ++i) { 305 for (unsigned int i = 0; i < header->e_phnum; ++i) {
306 Elf32_Phdr* p = &segments[i]; 306 Elf32_Phdr* p = &segments[i];
307 LOG_DEBUG(Loader, "Type: {} Vaddr: {:08X} Filesz: {:08X} Memsz: {:08X} ", p->p_type, 307 LOG_DEBUG(Loader, "Type: {} Vaddr: {:08X} Filesz: {:08X} Memsz: {:08X} ", p->p_type,
308 p->p_vaddr, p->p_filesz, p->p_memsz); 308 p->p_vaddr, p->p_filesz, p->p_memsz);
309 309
310 if (p->p_type == PT_LOAD) { 310 if (p->p_type == PT_LOAD) {
311 CodeSet::Segment* codeset_segment; 311 CodeSet::Segment* codeset_segment;
@@ -318,15 +318,15 @@ SharedPtr<CodeSet> ElfReader::LoadInto(u32 vaddr) {
318 codeset_segment = &codeset->data; 318 codeset_segment = &codeset->data;
319 } else { 319 } else {
320 LOG_ERROR(Loader, "Unexpected ELF PT_LOAD segment id {} with flags {:X}", i, 320 LOG_ERROR(Loader, "Unexpected ELF PT_LOAD segment id {} with flags {:X}", i,
321 p->p_flags); 321 p->p_flags);
322 continue; 322 continue;
323 } 323 }
324 324
325 if (codeset_segment->size != 0) { 325 if (codeset_segment->size != 0) {
326 LOG_ERROR(Loader, 326 LOG_ERROR(Loader,
327 "ELF has more than one segment of the same type. Skipping extra " 327 "ELF has more than one segment of the same type. Skipping extra "
328 "segment (id {})", 328 "segment (id {})",
329 i); 329 i);
330 continue; 330 continue;
331 } 331 }
332 332
diff --git a/src/core/memory.cpp b/src/core/memory.cpp
index 103ff0b77..190ccc25c 100644
--- a/src/core/memory.cpp
+++ b/src/core/memory.cpp
@@ -44,7 +44,7 @@ PageTable* GetCurrentPageTable() {
44 44
45static void MapPages(PageTable& page_table, VAddr base, u64 size, u8* memory, PageType type) { 45static void MapPages(PageTable& page_table, VAddr base, u64 size, u8* memory, PageType type) {
46 LOG_DEBUG(HW_Memory, "Mapping {} onto {:016X}-{:016X}", fmt::ptr(memory), base * PAGE_SIZE, 46 LOG_DEBUG(HW_Memory, "Mapping {} onto {:016X}-{:016X}", fmt::ptr(memory), base * PAGE_SIZE,
47 (base + size) * PAGE_SIZE); 47 (base + size) * PAGE_SIZE);
48 48
49 RasterizerFlushVirtualRegion(base << PAGE_BITS, size * PAGE_SIZE, 49 RasterizerFlushVirtualRegion(base << PAGE_BITS, size * PAGE_SIZE,
50 FlushMode::FlushAndInvalidate); 50 FlushMode::FlushAndInvalidate);
@@ -206,7 +206,7 @@ void Write(const VAddr vaddr, const T data) {
206 switch (type) { 206 switch (type) {
207 case PageType::Unmapped: 207 case PageType::Unmapped:
208 LOG_ERROR(HW_Memory, "Unmapped Write{} 0x{:08X} @ 0x{:016X}", sizeof(data) * 8, 208 LOG_ERROR(HW_Memory, "Unmapped Write{} 0x{:08X} @ 0x{:016X}", sizeof(data) * 8,
209 static_cast<u32>(data), vaddr); 209 static_cast<u32>(data), vaddr);
210 return; 210 return;
211 case PageType::Memory: 211 case PageType::Memory:
212 ASSERT_MSG(false, "Mapped memory page without a pointer @ {:016X}", vaddr); 212 ASSERT_MSG(false, "Mapped memory page without a pointer @ {:016X}", vaddr);
@@ -349,8 +349,8 @@ void RasterizerMarkRegionCached(Tegra::GPUVAddr gpu_addr, u64 size, bool cached)
349 // The GPU <-> CPU virtual memory mapping is not 1:1 349 // The GPU <-> CPU virtual memory mapping is not 1:1
350 if (!maybe_vaddr) { 350 if (!maybe_vaddr) {
351 LOG_ERROR(HW_Memory, 351 LOG_ERROR(HW_Memory,
352 "Trying to flush a cached region to an invalid physical address {:016X}", 352 "Trying to flush a cached region to an invalid physical address {:016X}",
353 gpu_addr); 353 gpu_addr);
354 continue; 354 continue;
355 } 355 }
356 VAddr vaddr = *maybe_vaddr; 356 VAddr vaddr = *maybe_vaddr;
@@ -485,8 +485,8 @@ void ReadBlock(const Kernel::Process& process, const VAddr src_addr, void* dest_
485 switch (page_table.attributes[page_index]) { 485 switch (page_table.attributes[page_index]) {
486 case PageType::Unmapped: { 486 case PageType::Unmapped: {
487 LOG_ERROR(HW_Memory, 487 LOG_ERROR(HW_Memory,
488 "Unmapped ReadBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})", 488 "Unmapped ReadBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})",
489 current_vaddr, src_addr, size); 489 current_vaddr, src_addr, size);
490 std::memset(dest_buffer, 0, copy_amount); 490 std::memset(dest_buffer, 0, copy_amount);
491 break; 491 break;
492 } 492 }
@@ -549,8 +549,8 @@ void WriteBlock(const Kernel::Process& process, const VAddr dest_addr, const voi
549 switch (page_table.attributes[page_index]) { 549 switch (page_table.attributes[page_index]) {
550 case PageType::Unmapped: { 550 case PageType::Unmapped: {
551 LOG_ERROR(HW_Memory, 551 LOG_ERROR(HW_Memory,
552 "Unmapped WriteBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})", 552 "Unmapped WriteBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})",
553 current_vaddr, dest_addr, size); 553 current_vaddr, dest_addr, size);
554 break; 554 break;
555 } 555 }
556 case PageType::Memory: { 556 case PageType::Memory: {
@@ -597,8 +597,8 @@ void ZeroBlock(const Kernel::Process& process, const VAddr dest_addr, const size
597 switch (page_table.attributes[page_index]) { 597 switch (page_table.attributes[page_index]) {
598 case PageType::Unmapped: { 598 case PageType::Unmapped: {
599 LOG_ERROR(HW_Memory, 599 LOG_ERROR(HW_Memory,
600 "Unmapped ZeroBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})", 600 "Unmapped ZeroBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})",
601 current_vaddr, dest_addr, size); 601 current_vaddr, dest_addr, size);
602 break; 602 break;
603 } 603 }
604 case PageType::Memory: { 604 case PageType::Memory: {
@@ -638,8 +638,8 @@ void CopyBlock(const Kernel::Process& process, VAddr dest_addr, VAddr src_addr,
638 switch (page_table.attributes[page_index]) { 638 switch (page_table.attributes[page_index]) {
639 case PageType::Unmapped: { 639 case PageType::Unmapped: {
640 LOG_ERROR(HW_Memory, 640 LOG_ERROR(HW_Memory,
641 "Unmapped CopyBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})", 641 "Unmapped CopyBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})",
642 current_vaddr, src_addr, size); 642 current_vaddr, src_addr, size);
643 ZeroBlock(process, dest_addr, copy_amount); 643 ZeroBlock(process, dest_addr, copy_amount);
644 break; 644 break;
645 } 645 }
diff --git a/src/video_core/command_processor.cpp b/src/video_core/command_processor.cpp
index 98b33c201..31ea3adad 100644
--- a/src/video_core/command_processor.cpp
+++ b/src/video_core/command_processor.cpp
@@ -30,9 +30,9 @@ enum class BufferMethods {
30 30
31void GPU::WriteReg(u32 method, u32 subchannel, u32 value, u32 remaining_params) { 31void GPU::WriteReg(u32 method, u32 subchannel, u32 value, u32 remaining_params) {
32 LOG_WARNING(HW_GPU, 32 LOG_WARNING(HW_GPU,
33 "Processing method {:08X} on subchannel {} value " 33 "Processing method {:08X} on subchannel {} value "
34 "{:08X} remaining params {}", 34 "{:08X} remaining params {}",
35 method, subchannel, value, remaining_params); 35 method, subchannel, value, remaining_params);
36 36
37 if (method == static_cast<u32>(BufferMethods::BindObject)) { 37 if (method == static_cast<u32>(BufferMethods::BindObject)) {
38 // Bind the current subchannel to the desired engine id. 38 // Bind the current subchannel to the desired engine id.
diff --git a/src/video_core/engines/fermi_2d.cpp b/src/video_core/engines/fermi_2d.cpp
index f9cbab8e2..34053e393 100644
--- a/src/video_core/engines/fermi_2d.cpp
+++ b/src/video_core/engines/fermi_2d.cpp
@@ -27,7 +27,7 @@ void Fermi2D::WriteReg(u32 method, u32 value) {
27 27
28void Fermi2D::HandleSurfaceCopy() { 28void Fermi2D::HandleSurfaceCopy() {
29 LOG_WARNING(HW_GPU, "Requested a surface copy with operation {}", 29 LOG_WARNING(HW_GPU, "Requested a surface copy with operation {}",
30 static_cast<u32>(regs.operation)); 30 static_cast<u32>(regs.operation));
31 31
32 const GPUVAddr source = regs.src.Address(); 32 const GPUVAddr source = regs.src.Address();
33 const GPUVAddr dest = regs.dst.Address(); 33 const GPUVAddr dest = regs.dst.Address();
diff --git a/src/video_core/engines/maxwell_3d.cpp b/src/video_core/engines/maxwell_3d.cpp
index bbd34f060..9b209a49e 100644
--- a/src/video_core/engines/maxwell_3d.cpp
+++ b/src/video_core/engines/maxwell_3d.cpp
@@ -207,8 +207,8 @@ void Maxwell3D::ProcessQueryGet() {
207} 207}
208 208
209void Maxwell3D::DrawArrays() { 209void Maxwell3D::DrawArrays() {
210 LOG_DEBUG(HW_GPU, "called, topology={}, count={}", 210 LOG_DEBUG(HW_GPU, "called, topology={}, count={}", static_cast<u32>(regs.draw.topology.Value()),
211 static_cast<u32>(regs.draw.topology.Value()), regs.vertex_buffer.count); 211 regs.vertex_buffer.count);
212 ASSERT_MSG(!(regs.index_array.count && regs.vertex_buffer.count), "Both indexed and direct?"); 212 ASSERT_MSG(!(regs.index_array.count && regs.vertex_buffer.count), "Both indexed and direct?");
213 213
214 auto debug_context = Core::System::GetInstance().GetGPUDebugContext(); 214 auto debug_context = Core::System::GetInstance().GetGPUDebugContext();
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.cpp b/src/video_core/renderer_opengl/gl_rasterizer.cpp
index 99282dac3..7c71f890b 100644
--- a/src/video_core/renderer_opengl/gl_rasterizer.cpp
+++ b/src/video_core/renderer_opengl/gl_rasterizer.cpp
@@ -166,8 +166,8 @@ std::pair<u8*, GLintptr> RasterizerOpenGL::SetupVertexArrays(u8* array_ptr,
166 for (unsigned index = 0; index < 16; ++index) { 166 for (unsigned index = 0; index < 16; ++index) {
167 auto& attrib = regs.vertex_attrib_format[index]; 167 auto& attrib = regs.vertex_attrib_format[index];
168 LOG_DEBUG(HW_GPU, "vertex attrib {}, count={}, size={}, type={}, offset={}, normalize={}", 168 LOG_DEBUG(HW_GPU, "vertex attrib {}, count={}, size={}, type={}, offset={}, normalize={}",
169 index, attrib.ComponentCount(), attrib.SizeString(), attrib.TypeString(), 169 index, attrib.ComponentCount(), attrib.SizeString(), attrib.TypeString(),
170 attrib.offset.Value(), attrib.IsNormalized()); 170 attrib.offset.Value(), attrib.IsNormalized());
171 171
172 auto& buffer = regs.vertex_array[attrib.buffer]; 172 auto& buffer = regs.vertex_array[attrib.buffer];
173 ASSERT(buffer.IsEnabled()); 173 ASSERT(buffer.IsEnabled());
@@ -251,8 +251,8 @@ void RasterizerOpenGL::SetupShaders(u8* buffer_ptr, GLintptr buffer_offset) {
251 break; 251 break;
252 } 252 }
253 default: 253 default:
254 LOG_CRITICAL(HW_GPU, "Unimplemented shader index={}, enable={}, offset=0x{:08X}", 254 LOG_CRITICAL(HW_GPU, "Unimplemented shader index={}, enable={}, offset=0x{:08X}", index,
255 index, shader_config.enable.Value(), shader_config.offset); 255 shader_config.enable.Value(), shader_config.offset);
256 UNREACHABLE(); 256 UNREACHABLE();
257 } 257 }
258 258
@@ -588,7 +588,7 @@ u32 RasterizerOpenGL::SetupConstBuffers(Maxwell::ShaderStage stage, GLuint progr
588 588
589 if (size > MaxConstbufferSize) { 589 if (size > MaxConstbufferSize) {
590 LOG_ERROR(HW_GPU, "indirect constbuffer size {} exceeds maximum {}", size, 590 LOG_ERROR(HW_GPU, "indirect constbuffer size {} exceeds maximum {}", size,
591 MaxConstbufferSize); 591 MaxConstbufferSize);
592 size = MaxConstbufferSize; 592 size = MaxConstbufferSize;
593 } 593 }
594 } else { 594 } else {
diff --git a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp
index 2e801cdf6..2901280a1 100644
--- a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp
+++ b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp
@@ -919,7 +919,7 @@ private:
919 break; 919 break;
920 default: 920 default:
921 LOG_CRITICAL(HW_GPU, "Unhandled MUFU sub op: {0:x}", 921 LOG_CRITICAL(HW_GPU, "Unhandled MUFU sub op: {0:x}",
922 static_cast<unsigned>(instr.sub_op.Value())); 922 static_cast<unsigned>(instr.sub_op.Value()));
923 UNREACHABLE(); 923 UNREACHABLE();
924 } 924 }
925 break; 925 break;
@@ -1059,7 +1059,7 @@ private:
1059 } 1059 }
1060 default: { 1060 default: {
1061 LOG_CRITICAL(HW_GPU, "Unhandled ArithmeticIntegerImmediate instruction: {}", 1061 LOG_CRITICAL(HW_GPU, "Unhandled ArithmeticIntegerImmediate instruction: {}",
1062 opcode->GetName()); 1062 opcode->GetName());
1063 UNREACHABLE(); 1063 UNREACHABLE();
1064 } 1064 }
1065 } 1065 }
@@ -1125,7 +1125,7 @@ private:
1125 } 1125 }
1126 default: { 1126 default: {
1127 LOG_CRITICAL(HW_GPU, "Unhandled ArithmeticInteger instruction: {}", 1127 LOG_CRITICAL(HW_GPU, "Unhandled ArithmeticInteger instruction: {}",
1128 opcode->GetName()); 1128 opcode->GetName());
1129 UNREACHABLE(); 1129 UNREACHABLE();
1130 } 1130 }
1131 } 1131 }
@@ -1220,7 +1220,7 @@ private:
1220 break; 1220 break;
1221 default: 1221 default:
1222 LOG_CRITICAL(HW_GPU, "Unimplemented f2f rounding mode {}", 1222 LOG_CRITICAL(HW_GPU, "Unimplemented f2f rounding mode {}",
1223 static_cast<u32>(instr.conversion.f2f.rounding.Value())); 1223 static_cast<u32>(instr.conversion.f2f.rounding.Value()));
1224 UNREACHABLE(); 1224 UNREACHABLE();
1225 break; 1225 break;
1226 } 1226 }
@@ -1254,7 +1254,7 @@ private:
1254 break; 1254 break;
1255 default: 1255 default:
1256 LOG_CRITICAL(HW_GPU, "Unimplemented f2i rounding mode {}", 1256 LOG_CRITICAL(HW_GPU, "Unimplemented f2i rounding mode {}",
1257 static_cast<u32>(instr.conversion.f2i.rounding.Value())); 1257 static_cast<u32>(instr.conversion.f2i.rounding.Value()));
1258 UNREACHABLE(); 1258 UNREACHABLE();
1259 break; 1259 break;
1260 } 1260 }
@@ -1306,7 +1306,7 @@ private:
1306 1306
1307 default: 1307 default:
1308 LOG_CRITICAL(HW_GPU, "Unhandled type: {}", 1308 LOG_CRITICAL(HW_GPU, "Unhandled type: {}",
1309 static_cast<unsigned>(instr.ld_c.type.Value())); 1309 static_cast<unsigned>(instr.ld_c.type.Value()));
1310 UNREACHABLE(); 1310 UNREACHABLE();
1311 } 1311 }
1312 break; 1312 break;
diff --git a/src/video_core/renderer_opengl/maxwell_to_gl.h b/src/video_core/renderer_opengl/maxwell_to_gl.h
index 1913397e4..6b9bb3df1 100644
--- a/src/video_core/renderer_opengl/maxwell_to_gl.h
+++ b/src/video_core/renderer_opengl/maxwell_to_gl.h
@@ -91,7 +91,7 @@ inline GLenum TextureFilterMode(Tegra::Texture::TextureFilter filter_mode) {
91 return GL_NEAREST; 91 return GL_NEAREST;
92 } 92 }
93 LOG_CRITICAL(Render_OpenGL, "Unimplemented texture filter mode={}", 93 LOG_CRITICAL(Render_OpenGL, "Unimplemented texture filter mode={}",
94 static_cast<u32>(filter_mode)); 94 static_cast<u32>(filter_mode));
95 UNREACHABLE(); 95 UNREACHABLE();
96 return {}; 96 return {};
97} 97}
@@ -110,8 +110,7 @@ inline GLenum WrapMode(Tegra::Texture::WrapMode wrap_mode) {
110 // manually mix them. However the shader part of this is not yet implemented. 110 // manually mix them. However the shader part of this is not yet implemented.
111 return GL_CLAMP_TO_BORDER; 111 return GL_CLAMP_TO_BORDER;
112 } 112 }
113 LOG_CRITICAL(Render_OpenGL, "Unimplemented texture wrap mode={}", 113 LOG_CRITICAL(Render_OpenGL, "Unimplemented texture wrap mode={}", static_cast<u32>(wrap_mode));
114 static_cast<u32>(wrap_mode));
115 UNREACHABLE(); 114 UNREACHABLE();
116 return {}; 115 return {};
117} 116}
diff --git a/src/video_core/renderer_opengl/renderer_opengl.cpp b/src/video_core/renderer_opengl/renderer_opengl.cpp
index af5b480a3..00841e937 100644
--- a/src/video_core/renderer_opengl/renderer_opengl.cpp
+++ b/src/video_core/renderer_opengl/renderer_opengl.cpp
@@ -302,7 +302,7 @@ void RendererOpenGL::DrawScreenTriangles(const ScreenInfo& screen_info, float x,
302 } else { 302 } else {
303 // Other transformations are unsupported 303 // Other transformations are unsupported
304 LOG_CRITICAL(Render_OpenGL, "Unsupported framebuffer_transform_flags={}", 304 LOG_CRITICAL(Render_OpenGL, "Unsupported framebuffer_transform_flags={}",
305 static_cast<u32>(framebuffer_transform_flags)); 305 static_cast<u32>(framebuffer_transform_flags));
306 UNIMPLEMENTED(); 306 UNIMPLEMENTED();
307 } 307 }
308 } 308 }
diff --git a/src/yuzu/game_list.cpp b/src/yuzu/game_list.cpp
index 6f53b63c1..5a708dc73 100644
--- a/src/yuzu/game_list.cpp
+++ b/src/yuzu/game_list.cpp
@@ -325,8 +325,7 @@ void GameList::PopupContextMenu(const QPoint& menu_location) {
325void GameList::PopulateAsync(const QString& dir_path, bool deep_scan) { 325void GameList::PopulateAsync(const QString& dir_path, bool deep_scan) {
326 if (!FileUtil::Exists(dir_path.toStdString()) || 326 if (!FileUtil::Exists(dir_path.toStdString()) ||
327 !FileUtil::IsDirectory(dir_path.toStdString())) { 327 !FileUtil::IsDirectory(dir_path.toStdString())) {
328 LOG_ERROR(Frontend, "Could not find game list folder at {}", 328 LOG_ERROR(Frontend, "Could not find game list folder at {}", dir_path.toLocal8Bit().data());
329 dir_path.toLocal8Bit().data());
330 search_field->setFilterResult(0, 0); 329 search_field->setFilterResult(0, 0);
331 return; 330 return;
332 } 331 }
diff --git a/src/yuzu_cmd/yuzu.cpp b/src/yuzu_cmd/yuzu.cpp
index 91b024819..079f93736 100644
--- a/src/yuzu_cmd/yuzu.cpp
+++ b/src/yuzu_cmd/yuzu.cpp
@@ -160,9 +160,9 @@ int main(int argc, char** argv) {
160 return -1; 160 return -1;
161 case Core::System::ResultStatus::ErrorLoader_ErrorEncrypted: 161 case Core::System::ResultStatus::ErrorLoader_ErrorEncrypted:
162 LOG_CRITICAL(Frontend, "The game that you are trying to load must be decrypted before " 162 LOG_CRITICAL(Frontend, "The game that you are trying to load must be decrypted before "
163 "being used with yuzu. \n\n For more information on dumping and " 163 "being used with yuzu. \n\n For more information on dumping and "
164 "decrypting games, please refer to: " 164 "decrypting games, please refer to: "
165 "https://yuzu-emu.org/wiki/dumping-game-cartridges/"); 165 "https://yuzu-emu.org/wiki/dumping-game-cartridges/");
166 return -1; 166 return -1;
167 case Core::System::ResultStatus::ErrorLoader_ErrorInvalidFormat: 167 case Core::System::ResultStatus::ErrorLoader_ErrorInvalidFormat:
168 LOG_CRITICAL(Frontend, "Error while loading ROM: The ROM format is not supported."); 168 LOG_CRITICAL(Frontend, "Error while loading ROM: The ROM format is not supported.");