summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--CONTRIBUTING.md8
-rw-r--r--README.md2
-rw-r--r--src/core/arm/disassembler/arm_disasm.cpp18
-rw-r--r--src/video_core/command_processor.cpp3
4 files changed, 20 insertions, 11 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 28b8b4031..c2735f564 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -1,3 +1,11 @@
1# Reporting Issues
2
3**The issue tracker is not a support forum.** Unless you can provide precise *technical information* regarding an issue, you *should not post in it*. If you need support, first read the [FAQ](https://github.com/citra-emu/citra/wiki/FAQ) and then either visit our IRC channel or ask in a general emulation forum such as [/r/emulation](https://www.reddit.com/r/emulation/). If you post support questions, generic messages to the developers or vague reports without technical details, they will be closed and locked.
4
5If you believe you have a valid issue report, please post text or a screenshot from the log (the console window that opens alongside Citra) and build version (hex string visible in the titlebar and zip filename), as well as your hardware and software information if applicable.
6
7While issues about specific games not booting are valid bugs, we are currently not interested in them unless you have several games which fail with the same or similar messages. (In which case please file only a single issue about it.) There are too many non-working games right now to file individual issues for every one of them.
8
1# Contributing 9# Contributing
2Citra is a brand new project, so we have a great opportunity to keep things clean and well organized early on. As such, coding style is very important when making commits. They aren't very strict rules since we want to be flexible and we understand that under certain circumstances some of them can be counterproductive. Just try to follow as many of them as possible: 10Citra is a brand new project, so we have a great opportunity to keep things clean and well organized early on. As such, coding style is very important when making commits. They aren't very strict rules since we want to be flexible and we understand that under certain circumstances some of them can be counterproductive. Just try to follow as many of them as possible:
3 11
diff --git a/README.md b/README.md
index 0d9e52396..c1e0092dd 100644
--- a/README.md
+++ b/README.md
@@ -1,3 +1,5 @@
1**BEFORE FILING AN ISSUE, READ THE RELEVANT SECTION IN THE [CONTRIBUTING](https://github.com/citra-emu/citra/blob/master/CONTRIBUTING.md#reporting-issues) FILE!!!**
2
1Citra Emulator 3Citra Emulator
2============== 4==============
3[![Travis CI Build Status](https://travis-ci.org/citra-emu/citra.svg)](https://travis-ci.org/citra-emu/citra) 5[![Travis CI Build Status](https://travis-ci.org/citra-emu/citra.svg)](https://travis-ci.org/citra-emu/citra)
diff --git a/src/core/arm/disassembler/arm_disasm.cpp b/src/core/arm/disassembler/arm_disasm.cpp
index 76408e9fa..5ad1f1c29 100644
--- a/src/core/arm/disassembler/arm_disasm.cpp
+++ b/src/core/arm/disassembler/arm_disasm.cpp
@@ -738,23 +738,23 @@ std::string ARM_Disasm::DisassembleMemHalf(u32 insn)
738 if (is_immed) { 738 if (is_immed) {
739 if (is_pre) { 739 if (is_pre) {
740 if (offset == 0) { 740 if (offset == 0) {
741 return Common::StringFromFormat("%s%sh\tr%d, [r%d]", opname, cond_to_str(cond), rd, rn); 741 return Common::StringFromFormat("%s%s%s\tr%d, [r%d]", opname, cond_to_str(cond), width, rd, rn);
742 } else { 742 } else {
743 return Common::StringFromFormat("%s%sh\tr%d, [r%d, #%s%u]%s", 743 return Common::StringFromFormat("%s%s%s\tr%d, [r%d, #%s%u]%s",
744 opname, cond_to_str(cond), rd, rn, minus, offset, bang); 744 opname, cond_to_str(cond), width, rd, rn, minus, offset, bang);
745 } 745 }
746 } else { 746 } else {
747 return Common::StringFromFormat("%s%sh\tr%d, [r%d], #%s%u", 747 return Common::StringFromFormat("%s%s%s\tr%d, [r%d], #%s%u",
748 opname, cond_to_str(cond), rd, rn, minus, offset); 748 opname, cond_to_str(cond), width, rd, rn, minus, offset);
749 } 749 }
750 } 750 }
751 751
752 if (is_pre) { 752 if (is_pre) {
753 return Common::StringFromFormat("%s%sh\tr%d, [r%d, %sr%d]%s", 753 return Common::StringFromFormat("%s%s%s\tr%d, [r%d, %sr%d]%s",
754 opname, cond_to_str(cond), rd, rn, minus, rm, bang); 754 opname, cond_to_str(cond), width, rd, rn, minus, rm, bang);
755 } else { 755 } else {
756 return Common::StringFromFormat("%s%sh\tr%d, [r%d], %sr%d", 756 return Common::StringFromFormat("%s%s%s\tr%d, [r%d], %sr%d",
757 opname, cond_to_str(cond), rd, rn, minus, rm); 757 opname, cond_to_str(cond), width, rd, rn, minus, rm);
758 } 758 }
759} 759}
760 760
diff --git a/src/video_core/command_processor.cpp b/src/video_core/command_processor.cpp
index 35b976c60..59c75042c 100644
--- a/src/video_core/command_processor.cpp
+++ b/src/video_core/command_processor.cpp
@@ -486,9 +486,8 @@ void ProcessCommandList(const u32* list, u32 size) {
486 486
487 u32 value = *g_state.cmd_list.current_ptr++; 487 u32 value = *g_state.cmd_list.current_ptr++;
488 const CommandHeader header = { *g_state.cmd_list.current_ptr++ }; 488 const CommandHeader header = { *g_state.cmd_list.current_ptr++ };
489 u32 cmd = header.cmd_id;
490 489
491 WritePicaReg(cmd, value, header.parameter_mask); 490 WritePicaReg(header.cmd_id, value, header.parameter_mask);
492 491
493 for (unsigned i = 0; i < header.extra_data_length; ++i) { 492 for (unsigned i = 0; i < header.extra_data_length; ++i) {
494 u32 cmd = header.cmd_id + (header.group_commands ? i + 1 : 0); 493 u32 cmd = header.cmd_id + (header.group_commands ? i + 1 : 0);