diff options
Diffstat (limited to '')
| -rw-r--r-- | src/core/memory.cpp | 2 | ||||
| -rw-r--r-- | src/video_core/memory_manager.cpp | 40 | ||||
| -rw-r--r-- | src/video_core/memory_manager.h | 3 |
3 files changed, 11 insertions, 34 deletions
diff --git a/src/core/memory.cpp b/src/core/memory.cpp index 4e605fae4..af9660b55 100644 --- a/src/core/memory.cpp +++ b/src/core/memory.cpp | |||
| @@ -440,7 +440,7 @@ struct Memory::Impl { | |||
| 440 | } | 440 | } |
| 441 | 441 | ||
| 442 | if (Settings::IsFastmemEnabled()) { | 442 | if (Settings::IsFastmemEnabled()) { |
| 443 | const bool is_read_enable = !Settings::IsGPULevelExtreme() || !cached; | 443 | const bool is_read_enable = Settings::IsGPULevelHigh() || !cached; |
| 444 | system.DeviceMemory().buffer.Protect(vaddr, size, is_read_enable, !cached); | 444 | system.DeviceMemory().buffer.Protect(vaddr, size, is_read_enable, !cached); |
| 445 | } | 445 | } |
| 446 | 446 | ||
diff --git a/src/video_core/memory_manager.cpp b/src/video_core/memory_manager.cpp index 3bcae3503..83924475b 100644 --- a/src/video_core/memory_manager.cpp +++ b/src/video_core/memory_manager.cpp | |||
| @@ -6,7 +6,6 @@ | |||
| 6 | #include "common/alignment.h" | 6 | #include "common/alignment.h" |
| 7 | #include "common/assert.h" | 7 | #include "common/assert.h" |
| 8 | #include "common/logging/log.h" | 8 | #include "common/logging/log.h" |
| 9 | #include "common/settings.h" | ||
| 10 | #include "core/core.h" | 9 | #include "core/core.h" |
| 11 | #include "core/device_memory.h" | 10 | #include "core/device_memory.h" |
| 12 | #include "core/hle/kernel/k_page_table.h" | 11 | #include "core/hle/kernel/k_page_table.h" |
| @@ -46,11 +45,6 @@ MemoryManager::MemoryManager(Core::System& system_, u64 address_space_bits_, u64 | |||
| 46 | big_page_table_cpu.resize(big_page_table_size); | 45 | big_page_table_cpu.resize(big_page_table_size); |
| 47 | big_page_continous.resize(big_page_table_size / continous_bits, 0); | 46 | big_page_continous.resize(big_page_table_size / continous_bits, 0); |
| 48 | entries.resize(page_table_size / 32, 0); | 47 | entries.resize(page_table_size / 32, 0); |
| 49 | if (!Settings::IsGPULevelExtreme() && Settings::IsFastmemEnabled()) { | ||
| 50 | fastmem_arena = system.DeviceMemory().buffer.VirtualBasePointer(); | ||
| 51 | } else { | ||
| 52 | fastmem_arena = nullptr; | ||
| 53 | } | ||
| 54 | } | 48 | } |
| 55 | 49 | ||
| 56 | MemoryManager::~MemoryManager() = default; | 50 | MemoryManager::~MemoryManager() = default; |
| @@ -360,7 +354,7 @@ inline void MemoryManager::MemoryOperation(GPUVAddr gpu_src_addr, std::size_t si | |||
| 360 | } | 354 | } |
| 361 | } | 355 | } |
| 362 | 356 | ||
| 363 | template <bool is_safe, bool use_fastmem> | 357 | template <bool is_safe> |
| 364 | void MemoryManager::ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size, | 358 | void MemoryManager::ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size, |
| 365 | [[maybe_unused]] VideoCommon::CacheType which) const { | 359 | [[maybe_unused]] VideoCommon::CacheType which) const { |
| 366 | auto set_to_zero = [&]([[maybe_unused]] std::size_t page_index, | 360 | auto set_to_zero = [&]([[maybe_unused]] std::size_t page_index, |
| @@ -374,12 +368,8 @@ void MemoryManager::ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std: | |||
| 374 | if constexpr (is_safe) { | 368 | if constexpr (is_safe) { |
| 375 | rasterizer->FlushRegion(cpu_addr_base, copy_amount, which); | 369 | rasterizer->FlushRegion(cpu_addr_base, copy_amount, which); |
| 376 | } | 370 | } |
| 377 | if constexpr (use_fastmem) { | 371 | u8* physical = memory.GetPointer(cpu_addr_base); |
| 378 | std::memcpy(dest_buffer, &fastmem_arena[cpu_addr_base], copy_amount); | 372 | std::memcpy(dest_buffer, physical, copy_amount); |
| 379 | } else { | ||
| 380 | u8* physical = memory.GetPointer(cpu_addr_base); | ||
| 381 | std::memcpy(dest_buffer, physical, copy_amount); | ||
| 382 | } | ||
| 383 | dest_buffer = static_cast<u8*>(dest_buffer) + copy_amount; | 373 | dest_buffer = static_cast<u8*>(dest_buffer) + copy_amount; |
| 384 | }; | 374 | }; |
| 385 | auto mapped_big = [&](std::size_t page_index, std::size_t offset, std::size_t copy_amount) { | 375 | auto mapped_big = [&](std::size_t page_index, std::size_t offset, std::size_t copy_amount) { |
| @@ -388,15 +378,11 @@ void MemoryManager::ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std: | |||
| 388 | if constexpr (is_safe) { | 378 | if constexpr (is_safe) { |
| 389 | rasterizer->FlushRegion(cpu_addr_base, copy_amount, which); | 379 | rasterizer->FlushRegion(cpu_addr_base, copy_amount, which); |
| 390 | } | 380 | } |
| 391 | if constexpr (use_fastmem) { | 381 | if (!IsBigPageContinous(page_index)) [[unlikely]] { |
| 392 | std::memcpy(dest_buffer, &fastmem_arena[cpu_addr_base], copy_amount); | 382 | memory.ReadBlockUnsafe(cpu_addr_base, dest_buffer, copy_amount); |
| 393 | } else { | 383 | } else { |
| 394 | if (!IsBigPageContinous(page_index)) [[unlikely]] { | 384 | u8* physical = memory.GetPointer(cpu_addr_base); |
| 395 | memory.ReadBlockUnsafe(cpu_addr_base, dest_buffer, copy_amount); | 385 | std::memcpy(dest_buffer, physical, copy_amount); |
| 396 | } else { | ||
| 397 | u8* physical = memory.GetPointer(cpu_addr_base); | ||
| 398 | std::memcpy(dest_buffer, physical, copy_amount); | ||
| 399 | } | ||
| 400 | } | 386 | } |
| 401 | dest_buffer = static_cast<u8*>(dest_buffer) + copy_amount; | 387 | dest_buffer = static_cast<u8*>(dest_buffer) + copy_amount; |
| 402 | }; | 388 | }; |
| @@ -410,20 +396,12 @@ void MemoryManager::ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std: | |||
| 410 | 396 | ||
| 411 | void MemoryManager::ReadBlock(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size, | 397 | void MemoryManager::ReadBlock(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size, |
| 412 | VideoCommon::CacheType which) const { | 398 | VideoCommon::CacheType which) const { |
| 413 | if (fastmem_arena) [[likely]] { | 399 | ReadBlockImpl<true>(gpu_src_addr, dest_buffer, size, which); |
| 414 | ReadBlockImpl<true, true>(gpu_src_addr, dest_buffer, size, which); | ||
| 415 | return; | ||
| 416 | } | ||
| 417 | ReadBlockImpl<true, false>(gpu_src_addr, dest_buffer, size, which); | ||
| 418 | } | 400 | } |
| 419 | 401 | ||
| 420 | void MemoryManager::ReadBlockUnsafe(GPUVAddr gpu_src_addr, void* dest_buffer, | 402 | void MemoryManager::ReadBlockUnsafe(GPUVAddr gpu_src_addr, void* dest_buffer, |
| 421 | const std::size_t size) const { | 403 | const std::size_t size) const { |
| 422 | if (fastmem_arena) [[likely]] { | 404 | ReadBlockImpl<false>(gpu_src_addr, dest_buffer, size, VideoCommon::CacheType::None); |
| 423 | ReadBlockImpl<false, true>(gpu_src_addr, dest_buffer, size, VideoCommon::CacheType::None); | ||
| 424 | return; | ||
| 425 | } | ||
| 426 | ReadBlockImpl<false, false>(gpu_src_addr, dest_buffer, size, VideoCommon::CacheType::None); | ||
| 427 | } | 405 | } |
| 428 | 406 | ||
| 429 | template <bool is_safe> | 407 | template <bool is_safe> |
diff --git a/src/video_core/memory_manager.h b/src/video_core/memory_manager.h index 2936364f0..9ebfb6179 100644 --- a/src/video_core/memory_manager.h +++ b/src/video_core/memory_manager.h | |||
| @@ -141,7 +141,7 @@ private: | |||
| 141 | inline void MemoryOperation(GPUVAddr gpu_src_addr, std::size_t size, FuncMapped&& func_mapped, | 141 | inline void MemoryOperation(GPUVAddr gpu_src_addr, std::size_t size, FuncMapped&& func_mapped, |
| 142 | FuncReserved&& func_reserved, FuncUnmapped&& func_unmapped) const; | 142 | FuncReserved&& func_reserved, FuncUnmapped&& func_unmapped) const; |
| 143 | 143 | ||
| 144 | template <bool is_safe, bool use_fastmem> | 144 | template <bool is_safe> |
| 145 | void ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size, | 145 | void ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size, |
| 146 | VideoCommon::CacheType which) const; | 146 | VideoCommon::CacheType which) const; |
| 147 | 147 | ||
| @@ -215,7 +215,6 @@ private: | |||
| 215 | 215 | ||
| 216 | std::vector<u64> big_page_continous; | 216 | std::vector<u64> big_page_continous; |
| 217 | std::vector<std::pair<VAddr, std::size_t>> page_stash{}; | 217 | std::vector<std::pair<VAddr, std::size_t>> page_stash{}; |
| 218 | u8* fastmem_arena{}; | ||
| 219 | 218 | ||
| 220 | constexpr static size_t continous_bits = 64; | 219 | constexpr static size_t continous_bits = 64; |
| 221 | 220 | ||