diff options
Diffstat (limited to '')
| -rw-r--r-- | src/core/hle/kernel/thread.cpp | 10 | ||||
| -rw-r--r-- | src/core/hle/svc.cpp | 12 |
2 files changed, 9 insertions, 13 deletions
diff --git a/src/core/hle/kernel/thread.cpp b/src/core/hle/kernel/thread.cpp index 5ba9abf29..3b7555d87 100644 --- a/src/core/hle/kernel/thread.cpp +++ b/src/core/hle/kernel/thread.cpp | |||
| @@ -353,14 +353,8 @@ static void ResetThreadContext(ARM_Interface::ThreadContext& context, u32 stack_ | |||
| 353 | 353 | ||
| 354 | ResultVal<SharedPtr<Thread>> Thread::Create(std::string name, VAddr entry_point, s32 priority, | 354 | ResultVal<SharedPtr<Thread>> Thread::Create(std::string name, VAddr entry_point, s32 priority, |
| 355 | u32 arg, s32 processor_id, VAddr stack_top) { | 355 | u32 arg, s32 processor_id, VAddr stack_top) { |
| 356 | if (priority < THREADPRIO_HIGHEST || priority > THREADPRIO_LOWEST) { | 356 | ASSERT_MSG(priority >= THREADPRIO_HIGHEST && priority <= THREADPRIO_LOWEST, |
| 357 | s32 new_priority = MathUtil::Clamp<s32>(priority, THREADPRIO_HIGHEST, THREADPRIO_LOWEST); | 357 | "Invalid thread priority"); |
| 358 | LOG_WARNING(Kernel_SVC, "(name=%s): invalid priority=%d, clamping to %d", name.c_str(), | ||
| 359 | priority, new_priority); | ||
| 360 | // TODO(bunnei): Clamping to a valid priority is not necessarily correct behavior... Confirm | ||
| 361 | // validity of this | ||
| 362 | priority = new_priority; | ||
| 363 | } | ||
| 364 | 358 | ||
| 365 | if (!Memory::IsValidVirtualAddress(entry_point)) { | 359 | if (!Memory::IsValidVirtualAddress(entry_point)) { |
| 366 | LOG_ERROR(Kernel_SVC, "(name=%s): invalid entry %08x", name.c_str(), entry_point); | 360 | LOG_ERROR(Kernel_SVC, "(name=%s): invalid entry %08x", name.c_str(), entry_point); |
diff --git a/src/core/hle/svc.cpp b/src/core/hle/svc.cpp index 8cb6a1c94..96db39ad9 100644 --- a/src/core/hle/svc.cpp +++ b/src/core/hle/svc.cpp | |||
| @@ -532,16 +532,18 @@ static ResultCode CreateThread(Kernel::Handle* out_handle, s32 priority, u32 ent | |||
| 532 | name = Common::StringFromFormat("unknown-%08x", entry_point); | 532 | name = Common::StringFromFormat("unknown-%08x", entry_point); |
| 533 | } | 533 | } |
| 534 | 534 | ||
| 535 | // TODO(bunnei): Implement resource limits to return an error code instead of the below assert. | ||
| 536 | // The error code should be: Description::NotAuthorized, Module::OS, Summary::WrongArgument, | ||
| 537 | // Level::Permanent | ||
| 538 | ASSERT_MSG(priority >= THREADPRIO_USERLAND_MAX, "Unexpected thread priority!"); | ||
| 539 | |||
| 540 | if (priority > THREADPRIO_LOWEST) { | 535 | if (priority > THREADPRIO_LOWEST) { |
| 541 | return ResultCode(ErrorDescription::OutOfRange, ErrorModule::OS, | 536 | return ResultCode(ErrorDescription::OutOfRange, ErrorModule::OS, |
| 542 | ErrorSummary::InvalidArgument, ErrorLevel::Usage); | 537 | ErrorSummary::InvalidArgument, ErrorLevel::Usage); |
| 543 | } | 538 | } |
| 544 | 539 | ||
| 540 | using Kernel::ResourceLimit; | ||
| 541 | Kernel::SharedPtr<ResourceLimit>& resource_limit = Kernel::g_current_process->resource_limit; | ||
| 542 | if (resource_limit->GetMaxResourceValue(Kernel::ResourceTypes::PRIORITY) > priority) { | ||
| 543 | return ResultCode(ErrorDescription::NotAuthorized, ErrorModule::OS, | ||
| 544 | ErrorSummary::WrongArgument, ErrorLevel::Permanent); | ||
| 545 | } | ||
| 546 | |||
| 545 | switch (processor_id) { | 547 | switch (processor_id) { |
| 546 | case THREADPROCESSORID_ALL: | 548 | case THREADPROCESSORID_ALL: |
| 547 | case THREADPROCESSORID_DEFAULT: | 549 | case THREADPROCESSORID_DEFAULT: |