diff options
| author | 2020-08-29 14:30:49 -0400 | |
|---|---|---|
| committer | 2020-08-29 14:30:49 -0400 | |
| commit | fae65d8a72e9d1a987797d910fb63b76d5590856 (patch) | |
| tree | 5942b4ad372132ba6d10fa298b8df80ddd74fa7a /src | |
| parent | game_list_p: Mark some constants as constexpr (diff) | |
| download | yuzu-fae65d8a72e9d1a987797d910fb63b76d5590856.tar.gz yuzu-fae65d8a72e9d1a987797d910fb63b76d5590856.tar.xz yuzu-fae65d8a72e9d1a987797d910fb63b76d5590856.zip | |
game_list_p: Avoid string churn in GameListItemPath data()
Diffstat (limited to 'src')
| -rw-r--r-- | src/yuzu/game_list_p.h | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/src/yuzu/game_list_p.h b/src/yuzu/game_list_p.h index eb1bf0775..92779a9c7 100644 --- a/src/yuzu/game_list_p.h +++ b/src/yuzu/game_list_p.h | |||
| @@ -110,18 +110,22 @@ public: | |||
| 110 | const auto& row1 = row_data.at(UISettings::values.row_1_text_id); | 110 | const auto& row1 = row_data.at(UISettings::values.row_1_text_id); |
| 111 | const int row2_id = UISettings::values.row_2_text_id; | 111 | const int row2_id = UISettings::values.row_2_text_id; |
| 112 | 112 | ||
| 113 | if (role == SortRole) | 113 | if (role == SortRole) { |
| 114 | return row1.toLower(); | 114 | return row1.toLower(); |
| 115 | } | ||
| 115 | 116 | ||
| 116 | if (row2_id == 4) // None | 117 | // None |
| 118 | if (row2_id == 4) { | ||
| 117 | return row1; | 119 | return row1; |
| 120 | } | ||
| 118 | 121 | ||
| 119 | const auto& row2 = row_data.at(row2_id); | 122 | const auto& row2 = row_data.at(row2_id); |
| 120 | 123 | ||
| 121 | if (row1 == row2) | 124 | if (row1 == row2) { |
| 122 | return row1; | 125 | return row1; |
| 126 | } | ||
| 123 | 127 | ||
| 124 | return QString(row1 + QStringLiteral("\n ") + row2); | 128 | return QStringLiteral("%1\n %2").arg(row1, row2); |
| 125 | } | 129 | } |
| 126 | 130 | ||
| 127 | return GameListItem::data(role); | 131 | return GameListItem::data(role); |