summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorGravatar Lioncash2018-12-02 14:06:39 -0500
committerGravatar Lioncash2018-12-02 14:18:26 -0500
commitf3253d0f1432eb290f2753c187121f874b106a8e (patch)
tree3dea580db0aef3d32e6cf8581c55066f52d69531 /src
parentMerge pull request #1827 from ReinUsesLisp/clip-and-shader (diff)
downloadyuzu-f3253d0f1432eb290f2753c187121f874b106a8e.tar.gz
yuzu-f3253d0f1432eb290f2753c187121f874b106a8e.tar.xz
yuzu-f3253d0f1432eb290f2753c187121f874b106a8e.zip
yuzu/configuration/configure_input: Default destructor in the cpp file
The previous code could potentially be a compilation issue waiting to occur, given we forward declare the type for a std::unique_ptr. If the complete definition of the forward declared type isn't visible in a translation unit that the class is used in, then it would fail to compile. Defaulting the destructor in a cpp file ensures the std::unique_ptr's destructor is only invoked where its complete type is known.
Diffstat (limited to 'src')
-rw-r--r--src/yuzu/configuration/configure_input.cpp2
-rw-r--r--src/yuzu/configuration/configure_input.h1
2 files changed, 3 insertions, 0 deletions
diff --git a/src/yuzu/configuration/configure_input.cpp b/src/yuzu/configuration/configure_input.cpp
index 0527d098c..830d26115 100644
--- a/src/yuzu/configuration/configure_input.cpp
+++ b/src/yuzu/configuration/configure_input.cpp
@@ -88,6 +88,8 @@ ConfigureInput::ConfigureInput(QWidget* parent)
88 [this] { CallConfigureDialog<ConfigureTouchscreenAdvanced>(*this); }); 88 [this] { CallConfigureDialog<ConfigureTouchscreenAdvanced>(*this); });
89} 89}
90 90
91ConfigureInput::~ConfigureInput() = default;
92
91void ConfigureInput::OnDockedModeChanged(bool last_state, bool new_state) { 93void ConfigureInput::OnDockedModeChanged(bool last_state, bool new_state) {
92 if (ui->use_docked_mode->isChecked() && ui->handheld_connected->isChecked()) { 94 if (ui->use_docked_mode->isChecked() && ui->handheld_connected->isChecked()) {
93 ui->handheld_connected->setChecked(false); 95 ui->handheld_connected->setChecked(false);
diff --git a/src/yuzu/configuration/configure_input.h b/src/yuzu/configuration/configure_input.h
index e8723dfcb..1649e4c0b 100644
--- a/src/yuzu/configuration/configure_input.h
+++ b/src/yuzu/configuration/configure_input.h
@@ -25,6 +25,7 @@ class ConfigureInput : public QWidget {
25 25
26public: 26public:
27 explicit ConfigureInput(QWidget* parent = nullptr); 27 explicit ConfigureInput(QWidget* parent = nullptr);
28 ~ConfigureInput() override;
28 29
29 /// Save all button configurations to settings file 30 /// Save all button configurations to settings file
30 void applyConfiguration(); 31 void applyConfiguration();