summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorGravatar liamwhite2022-12-06 11:26:53 -0500
committerGravatar GitHub2022-12-06 11:26:53 -0500
commitd8534ea140a0e07fa010fe58fae068ed926c1dbc (patch)
tree176afc9e7d481b7b48f5a61a21b5184bf33cef62 /src
parentMerge pull request #9389 from lioncash/emumove (diff)
parentapplets/controller: Use aliases for callbacks (diff)
downloadyuzu-d8534ea140a0e07fa010fe58fae068ed926c1dbc.tar.gz
yuzu-d8534ea140a0e07fa010fe58fae068ed926c1dbc.tar.xz
yuzu-d8534ea140a0e07fa010fe58fae068ed926c1dbc.zip
Merge pull request #9390 from lioncash/keyboard
applets: Extract callback types into aliases
Diffstat (limited to 'src')
-rw-r--r--src/core/frontend/applets/controller.cpp2
-rw-r--r--src/core/frontend/applets/controller.h6
-rw-r--r--src/core/frontend/applets/error.cpp6
-rw-r--r--src/core/frontend/applets/error.h14
-rw-r--r--src/core/frontend/applets/mii_edit.cpp2
-rw-r--r--src/core/frontend/applets/mii_edit.h6
-rw-r--r--src/core/frontend/applets/profile_select.cpp3
-rw-r--r--src/core/frontend/applets/profile_select.h6
-rw-r--r--src/core/frontend/applets/software_keyboard.cpp5
-rw-r--r--src/core/frontend/applets/software_keyboard.h32
-rw-r--r--src/core/frontend/applets/web_browser.cpp11
-rw-r--r--src/core/frontend/applets/web_browser.h24
-rw-r--r--src/yuzu/applets/qt_controller.cpp2
-rw-r--r--src/yuzu/applets/qt_controller.h4
-rw-r--r--src/yuzu/applets/qt_error.cpp6
-rw-r--r--src/yuzu/applets/qt_error.h8
-rw-r--r--src/yuzu/applets/qt_profile_select.cpp3
-rw-r--r--src/yuzu/applets/qt_profile_select.h4
-rw-r--r--src/yuzu/applets/qt_software_keyboard.cpp5
-rw-r--r--src/yuzu/applets/qt_software_keyboard.h16
-rw-r--r--src/yuzu/applets/qt_web_browser.cpp11
-rw-r--r--src/yuzu/applets/qt_web_browser.h13
22 files changed, 89 insertions, 100 deletions
diff --git a/src/core/frontend/applets/controller.cpp b/src/core/frontend/applets/controller.cpp
index 6c230f619..52919484e 100644
--- a/src/core/frontend/applets/controller.cpp
+++ b/src/core/frontend/applets/controller.cpp
@@ -16,7 +16,7 @@ DefaultControllerApplet::DefaultControllerApplet(HID::HIDCore& hid_core_) : hid_
16 16
17DefaultControllerApplet::~DefaultControllerApplet() = default; 17DefaultControllerApplet::~DefaultControllerApplet() = default;
18 18
19void DefaultControllerApplet::ReconfigureControllers(std::function<void()> callback, 19void DefaultControllerApplet::ReconfigureControllers(ReconfigureCallback callback,
20 const ControllerParameters& parameters) const { 20 const ControllerParameters& parameters) const {
21 LOG_INFO(Service_HID, "called, deducing the best configuration based on the given parameters!"); 21 LOG_INFO(Service_HID, "called, deducing the best configuration based on the given parameters!");
22 22
diff --git a/src/core/frontend/applets/controller.h b/src/core/frontend/applets/controller.h
index 71698df74..adb2feefd 100644
--- a/src/core/frontend/applets/controller.h
+++ b/src/core/frontend/applets/controller.h
@@ -36,9 +36,11 @@ struct ControllerParameters {
36 36
37class ControllerApplet { 37class ControllerApplet {
38public: 38public:
39 using ReconfigureCallback = std::function<void()>;
40
39 virtual ~ControllerApplet(); 41 virtual ~ControllerApplet();
40 42
41 virtual void ReconfigureControllers(std::function<void()> callback, 43 virtual void ReconfigureControllers(ReconfigureCallback callback,
42 const ControllerParameters& parameters) const = 0; 44 const ControllerParameters& parameters) const = 0;
43}; 45};
44 46
@@ -47,7 +49,7 @@ public:
47 explicit DefaultControllerApplet(HID::HIDCore& hid_core_); 49 explicit DefaultControllerApplet(HID::HIDCore& hid_core_);
48 ~DefaultControllerApplet() override; 50 ~DefaultControllerApplet() override;
49 51
50 void ReconfigureControllers(std::function<void()> callback, 52 void ReconfigureControllers(ReconfigureCallback callback,
51 const ControllerParameters& parameters) const override; 53 const ControllerParameters& parameters) const override;
52 54
53private: 55private:
diff --git a/src/core/frontend/applets/error.cpp b/src/core/frontend/applets/error.cpp
index f8b961098..69c2b2b4d 100644
--- a/src/core/frontend/applets/error.cpp
+++ b/src/core/frontend/applets/error.cpp
@@ -8,13 +8,13 @@ namespace Core::Frontend {
8 8
9ErrorApplet::~ErrorApplet() = default; 9ErrorApplet::~ErrorApplet() = default;
10 10
11void DefaultErrorApplet::ShowError(Result error, std::function<void()> finished) const { 11void DefaultErrorApplet::ShowError(Result error, FinishedCallback finished) const {
12 LOG_CRITICAL(Service_Fatal, "Application requested error display: {:04}-{:04} (raw={:08X})", 12 LOG_CRITICAL(Service_Fatal, "Application requested error display: {:04}-{:04} (raw={:08X})",
13 error.module.Value(), error.description.Value(), error.raw); 13 error.module.Value(), error.description.Value(), error.raw);
14} 14}
15 15
16void DefaultErrorApplet::ShowErrorWithTimestamp(Result error, std::chrono::seconds time, 16void DefaultErrorApplet::ShowErrorWithTimestamp(Result error, std::chrono::seconds time,
17 std::function<void()> finished) const { 17 FinishedCallback finished) const {
18 LOG_CRITICAL( 18 LOG_CRITICAL(
19 Service_Fatal, 19 Service_Fatal,
20 "Application requested error display: {:04X}-{:04X} (raw={:08X}) with timestamp={:016X}", 20 "Application requested error display: {:04X}-{:04X} (raw={:08X}) with timestamp={:016X}",
@@ -23,7 +23,7 @@ void DefaultErrorApplet::ShowErrorWithTimestamp(Result error, std::chrono::secon
23 23
24void DefaultErrorApplet::ShowCustomErrorText(Result error, std::string main_text, 24void DefaultErrorApplet::ShowCustomErrorText(Result error, std::string main_text,
25 std::string detail_text, 25 std::string detail_text,
26 std::function<void()> finished) const { 26 FinishedCallback finished) const {
27 LOG_CRITICAL(Service_Fatal, 27 LOG_CRITICAL(Service_Fatal,
28 "Application requested custom error with error_code={:04X}-{:04X} (raw={:08X})", 28 "Application requested custom error with error_code={:04X}-{:04X} (raw={:08X})",
29 error.module.Value(), error.description.Value(), error.raw); 29 error.module.Value(), error.description.Value(), error.raw);
diff --git a/src/core/frontend/applets/error.h b/src/core/frontend/applets/error.h
index f378f8805..884f2f653 100644
--- a/src/core/frontend/applets/error.h
+++ b/src/core/frontend/applets/error.h
@@ -12,25 +12,27 @@ namespace Core::Frontend {
12 12
13class ErrorApplet { 13class ErrorApplet {
14public: 14public:
15 using FinishedCallback = std::function<void()>;
16
15 virtual ~ErrorApplet(); 17 virtual ~ErrorApplet();
16 18
17 virtual void ShowError(Result error, std::function<void()> finished) const = 0; 19 virtual void ShowError(Result error, FinishedCallback finished) const = 0;
18 20
19 virtual void ShowErrorWithTimestamp(Result error, std::chrono::seconds time, 21 virtual void ShowErrorWithTimestamp(Result error, std::chrono::seconds time,
20 std::function<void()> finished) const = 0; 22 FinishedCallback finished) const = 0;
21 23
22 virtual void ShowCustomErrorText(Result error, std::string dialog_text, 24 virtual void ShowCustomErrorText(Result error, std::string dialog_text,
23 std::string fullscreen_text, 25 std::string fullscreen_text,
24 std::function<void()> finished) const = 0; 26 FinishedCallback finished) const = 0;
25}; 27};
26 28
27class DefaultErrorApplet final : public ErrorApplet { 29class DefaultErrorApplet final : public ErrorApplet {
28public: 30public:
29 void ShowError(Result error, std::function<void()> finished) const override; 31 void ShowError(Result error, FinishedCallback finished) const override;
30 void ShowErrorWithTimestamp(Result error, std::chrono::seconds time, 32 void ShowErrorWithTimestamp(Result error, std::chrono::seconds time,
31 std::function<void()> finished) const override; 33 FinishedCallback finished) const override;
32 void ShowCustomErrorText(Result error, std::string main_text, std::string detail_text, 34 void ShowCustomErrorText(Result error, std::string main_text, std::string detail_text,
33 std::function<void()> finished) const override; 35 FinishedCallback finished) const override;
34}; 36};
35 37
36} // namespace Core::Frontend 38} // namespace Core::Frontend
diff --git a/src/core/frontend/applets/mii_edit.cpp b/src/core/frontend/applets/mii_edit.cpp
index d37b5368a..bc8c57067 100644
--- a/src/core/frontend/applets/mii_edit.cpp
+++ b/src/core/frontend/applets/mii_edit.cpp
@@ -8,7 +8,7 @@ namespace Core::Frontend {
8 8
9MiiEditApplet::~MiiEditApplet() = default; 9MiiEditApplet::~MiiEditApplet() = default;
10 10
11void DefaultMiiEditApplet::ShowMiiEdit(const std::function<void()>& callback) const { 11void DefaultMiiEditApplet::ShowMiiEdit(const MiiEditCallback& callback) const {
12 LOG_WARNING(Service_AM, "(STUBBED) called"); 12 LOG_WARNING(Service_AM, "(STUBBED) called");
13 13
14 callback(); 14 callback();
diff --git a/src/core/frontend/applets/mii_edit.h b/src/core/frontend/applets/mii_edit.h
index 58fa2039b..d828f06ec 100644
--- a/src/core/frontend/applets/mii_edit.h
+++ b/src/core/frontend/applets/mii_edit.h
@@ -9,14 +9,16 @@ namespace Core::Frontend {
9 9
10class MiiEditApplet { 10class MiiEditApplet {
11public: 11public:
12 using MiiEditCallback = std::function<void()>;
13
12 virtual ~MiiEditApplet(); 14 virtual ~MiiEditApplet();
13 15
14 virtual void ShowMiiEdit(const std::function<void()>& callback) const = 0; 16 virtual void ShowMiiEdit(const MiiEditCallback& callback) const = 0;
15}; 17};
16 18
17class DefaultMiiEditApplet final : public MiiEditApplet { 19class DefaultMiiEditApplet final : public MiiEditApplet {
18public: 20public:
19 void ShowMiiEdit(const std::function<void()>& callback) const override; 21 void ShowMiiEdit(const MiiEditCallback& callback) const override;
20}; 22};
21 23
22} // namespace Core::Frontend 24} // namespace Core::Frontend
diff --git a/src/core/frontend/applets/profile_select.cpp b/src/core/frontend/applets/profile_select.cpp
index d11fbce0a..da4cfbf87 100644
--- a/src/core/frontend/applets/profile_select.cpp
+++ b/src/core/frontend/applets/profile_select.cpp
@@ -9,8 +9,7 @@ namespace Core::Frontend {
9 9
10ProfileSelectApplet::~ProfileSelectApplet() = default; 10ProfileSelectApplet::~ProfileSelectApplet() = default;
11 11
12void DefaultProfileSelectApplet::SelectProfile( 12void DefaultProfileSelectApplet::SelectProfile(SelectProfileCallback callback) const {
13 std::function<void(std::optional<Common::UUID>)> callback) const {
14 Service::Account::ProfileManager manager; 13 Service::Account::ProfileManager manager;
15 callback(manager.GetUser(Settings::values.current_user.GetValue()).value_or(Common::UUID{})); 14 callback(manager.GetUser(Settings::values.current_user.GetValue()).value_or(Common::UUID{}));
16 LOG_INFO(Service_ACC, "called, selecting current user instead of prompting..."); 15 LOG_INFO(Service_ACC, "called, selecting current user instead of prompting...");
diff --git a/src/core/frontend/applets/profile_select.h b/src/core/frontend/applets/profile_select.h
index 8d6ee5279..138429533 100644
--- a/src/core/frontend/applets/profile_select.h
+++ b/src/core/frontend/applets/profile_select.h
@@ -11,14 +11,16 @@ namespace Core::Frontend {
11 11
12class ProfileSelectApplet { 12class ProfileSelectApplet {
13public: 13public:
14 using SelectProfileCallback = std::function<void(std::optional<Common::UUID>)>;
15
14 virtual ~ProfileSelectApplet(); 16 virtual ~ProfileSelectApplet();
15 17
16 virtual void SelectProfile(std::function<void(std::optional<Common::UUID>)> callback) const = 0; 18 virtual void SelectProfile(SelectProfileCallback callback) const = 0;
17}; 19};
18 20
19class DefaultProfileSelectApplet final : public ProfileSelectApplet { 21class DefaultProfileSelectApplet final : public ProfileSelectApplet {
20public: 22public:
21 void SelectProfile(std::function<void(std::optional<Common::UUID>)> callback) const override; 23 void SelectProfile(SelectProfileCallback callback) const override;
22}; 24};
23 25
24} // namespace Core::Frontend 26} // namespace Core::Frontend
diff --git a/src/core/frontend/applets/software_keyboard.cpp b/src/core/frontend/applets/software_keyboard.cpp
index 020c7fa5e..a3720f4d7 100644
--- a/src/core/frontend/applets/software_keyboard.cpp
+++ b/src/core/frontend/applets/software_keyboard.cpp
@@ -15,10 +15,7 @@ DefaultSoftwareKeyboardApplet::~DefaultSoftwareKeyboardApplet() = default;
15 15
16void DefaultSoftwareKeyboardApplet::InitializeKeyboard( 16void DefaultSoftwareKeyboardApplet::InitializeKeyboard(
17 bool is_inline, KeyboardInitializeParameters initialize_parameters, 17 bool is_inline, KeyboardInitializeParameters initialize_parameters,
18 std::function<void(Service::AM::Applets::SwkbdResult, std::u16string, bool)> 18 SubmitNormalCallback submit_normal_callback_, SubmitInlineCallback submit_inline_callback_) {
19 submit_normal_callback_,
20 std::function<void(Service::AM::Applets::SwkbdReplyType, std::u16string, s32)>
21 submit_inline_callback_) {
22 if (is_inline) { 19 if (is_inline) {
23 LOG_WARNING( 20 LOG_WARNING(
24 Service_AM, 21 Service_AM,
diff --git a/src/core/frontend/applets/software_keyboard.h b/src/core/frontend/applets/software_keyboard.h
index 094d1e713..8aef103d3 100644
--- a/src/core/frontend/applets/software_keyboard.h
+++ b/src/core/frontend/applets/software_keyboard.h
@@ -54,14 +54,17 @@ struct InlineTextParameters {
54 54
55class SoftwareKeyboardApplet { 55class SoftwareKeyboardApplet {
56public: 56public:
57 using SubmitInlineCallback =
58 std::function<void(Service::AM::Applets::SwkbdReplyType, std::u16string, s32)>;
59 using SubmitNormalCallback =
60 std::function<void(Service::AM::Applets::SwkbdResult, std::u16string, bool)>;
61
57 virtual ~SoftwareKeyboardApplet(); 62 virtual ~SoftwareKeyboardApplet();
58 63
59 virtual void InitializeKeyboard( 64 virtual void InitializeKeyboard(bool is_inline,
60 bool is_inline, KeyboardInitializeParameters initialize_parameters, 65 KeyboardInitializeParameters initialize_parameters,
61 std::function<void(Service::AM::Applets::SwkbdResult, std::u16string, bool)> 66 SubmitNormalCallback submit_normal_callback_,
62 submit_normal_callback_, 67 SubmitInlineCallback submit_inline_callback_) = 0;
63 std::function<void(Service::AM::Applets::SwkbdReplyType, std::u16string, s32)>
64 submit_inline_callback_) = 0;
65 68
66 virtual void ShowNormalKeyboard() const = 0; 69 virtual void ShowNormalKeyboard() const = 0;
67 70
@@ -81,12 +84,9 @@ class DefaultSoftwareKeyboardApplet final : public SoftwareKeyboardApplet {
81public: 84public:
82 ~DefaultSoftwareKeyboardApplet() override; 85 ~DefaultSoftwareKeyboardApplet() override;
83 86
84 void InitializeKeyboard( 87 void InitializeKeyboard(bool is_inline, KeyboardInitializeParameters initialize_parameters,
85 bool is_inline, KeyboardInitializeParameters initialize_parameters, 88 SubmitNormalCallback submit_normal_callback_,
86 std::function<void(Service::AM::Applets::SwkbdResult, std::u16string, bool)> 89 SubmitInlineCallback submit_inline_callback_) override;
87 submit_normal_callback_,
88 std::function<void(Service::AM::Applets::SwkbdReplyType, std::u16string, s32)>
89 submit_inline_callback_) override;
90 90
91 void ShowNormalKeyboard() const override; 91 void ShowNormalKeyboard() const override;
92 92
@@ -105,12 +105,10 @@ private:
105 void SubmitNormalText(std::u16string text) const; 105 void SubmitNormalText(std::u16string text) const;
106 void SubmitInlineText(std::u16string_view text) const; 106 void SubmitInlineText(std::u16string_view text) const;
107 107
108 KeyboardInitializeParameters parameters; 108 KeyboardInitializeParameters parameters{};
109 109
110 mutable std::function<void(Service::AM::Applets::SwkbdResult, std::u16string, bool)> 110 mutable SubmitNormalCallback submit_normal_callback;
111 submit_normal_callback; 111 mutable SubmitInlineCallback submit_inline_callback;
112 mutable std::function<void(Service::AM::Applets::SwkbdReplyType, std::u16string, s32)>
113 submit_inline_callback;
114}; 112};
115 113
116} // namespace Core::Frontend 114} // namespace Core::Frontend
diff --git a/src/core/frontend/applets/web_browser.cpp b/src/core/frontend/applets/web_browser.cpp
index 27c7086be..b09cb7102 100644
--- a/src/core/frontend/applets/web_browser.cpp
+++ b/src/core/frontend/applets/web_browser.cpp
@@ -10,18 +10,17 @@ WebBrowserApplet::~WebBrowserApplet() = default;
10 10
11DefaultWebBrowserApplet::~DefaultWebBrowserApplet() = default; 11DefaultWebBrowserApplet::~DefaultWebBrowserApplet() = default;
12 12
13void DefaultWebBrowserApplet::OpenLocalWebPage( 13void DefaultWebBrowserApplet::OpenLocalWebPage(const std::string& local_url,
14 const std::string& local_url, std::function<void()> extract_romfs_callback, 14 ExtractROMFSCallback extract_romfs_callback,
15 std::function<void(Service::AM::Applets::WebExitReason, std::string)> callback) const { 15 OpenWebPageCallback callback) const {
16 LOG_WARNING(Service_AM, "(STUBBED) called, backend requested to open local web page at {}", 16 LOG_WARNING(Service_AM, "(STUBBED) called, backend requested to open local web page at {}",
17 local_url); 17 local_url);
18 18
19 callback(Service::AM::Applets::WebExitReason::WindowClosed, "http://localhost/"); 19 callback(Service::AM::Applets::WebExitReason::WindowClosed, "http://localhost/");
20} 20}
21 21
22void DefaultWebBrowserApplet::OpenExternalWebPage( 22void DefaultWebBrowserApplet::OpenExternalWebPage(const std::string& external_url,
23 const std::string& external_url, 23 OpenWebPageCallback callback) const {
24 std::function<void(Service::AM::Applets::WebExitReason, std::string)> callback) const {
25 LOG_WARNING(Service_AM, "(STUBBED) called, backend requested to open external web page at {}", 24 LOG_WARNING(Service_AM, "(STUBBED) called, backend requested to open external web page at {}",
26 external_url); 25 external_url);
27 26
diff --git a/src/core/frontend/applets/web_browser.h b/src/core/frontend/applets/web_browser.h
index 1411274f8..4f72284ad 100644
--- a/src/core/frontend/applets/web_browser.h
+++ b/src/core/frontend/applets/web_browser.h
@@ -11,29 +11,29 @@ namespace Core::Frontend {
11 11
12class WebBrowserApplet { 12class WebBrowserApplet {
13public: 13public:
14 using ExtractROMFSCallback = std::function<void()>;
15 using OpenWebPageCallback =
16 std::function<void(Service::AM::Applets::WebExitReason, std::string)>;
17
14 virtual ~WebBrowserApplet(); 18 virtual ~WebBrowserApplet();
15 19
16 virtual void OpenLocalWebPage( 20 virtual void OpenLocalWebPage(const std::string& local_url,
17 const std::string& local_url, std::function<void()> extract_romfs_callback, 21 ExtractROMFSCallback extract_romfs_callback,
18 std::function<void(Service::AM::Applets::WebExitReason, std::string)> callback) const = 0; 22 OpenWebPageCallback callback) const = 0;
19 23
20 virtual void OpenExternalWebPage( 24 virtual void OpenExternalWebPage(const std::string& external_url,
21 const std::string& external_url, 25 OpenWebPageCallback callback) const = 0;
22 std::function<void(Service::AM::Applets::WebExitReason, std::string)> callback) const = 0;
23}; 26};
24 27
25class DefaultWebBrowserApplet final : public WebBrowserApplet { 28class DefaultWebBrowserApplet final : public WebBrowserApplet {
26public: 29public:
27 ~DefaultWebBrowserApplet() override; 30 ~DefaultWebBrowserApplet() override;
28 31
29 void OpenLocalWebPage(const std::string& local_url, 32 void OpenLocalWebPage(const std::string& local_url, ExtractROMFSCallback extract_romfs_callback,
30 std::function<void()> extract_romfs_callback, 33 OpenWebPageCallback callback) const override;
31 std::function<void(Service::AM::Applets::WebExitReason, std::string)>
32 callback) const override;
33 34
34 void OpenExternalWebPage(const std::string& external_url, 35 void OpenExternalWebPage(const std::string& external_url,
35 std::function<void(Service::AM::Applets::WebExitReason, std::string)> 36 OpenWebPageCallback callback) const override;
36 callback) const override;
37}; 37};
38 38
39} // namespace Core::Frontend 39} // namespace Core::Frontend
diff --git a/src/yuzu/applets/qt_controller.cpp b/src/yuzu/applets/qt_controller.cpp
index 12efdc216..c30b54499 100644
--- a/src/yuzu/applets/qt_controller.cpp
+++ b/src/yuzu/applets/qt_controller.cpp
@@ -685,7 +685,7 @@ QtControllerSelector::QtControllerSelector(GMainWindow& parent) {
685QtControllerSelector::~QtControllerSelector() = default; 685QtControllerSelector::~QtControllerSelector() = default;
686 686
687void QtControllerSelector::ReconfigureControllers( 687void QtControllerSelector::ReconfigureControllers(
688 std::function<void()> callback_, const Core::Frontend::ControllerParameters& parameters) const { 688 ReconfigureCallback callback_, const Core::Frontend::ControllerParameters& parameters) const {
689 callback = std::move(callback_); 689 callback = std::move(callback_);
690 emit MainWindowReconfigureControllers(parameters); 690 emit MainWindowReconfigureControllers(parameters);
691} 691}
diff --git a/src/yuzu/applets/qt_controller.h b/src/yuzu/applets/qt_controller.h
index cf948d2b5..16e99f507 100644
--- a/src/yuzu/applets/qt_controller.h
+++ b/src/yuzu/applets/qt_controller.h
@@ -157,7 +157,7 @@ public:
157 ~QtControllerSelector() override; 157 ~QtControllerSelector() override;
158 158
159 void ReconfigureControllers( 159 void ReconfigureControllers(
160 std::function<void()> callback_, 160 ReconfigureCallback callback_,
161 const Core::Frontend::ControllerParameters& parameters) const override; 161 const Core::Frontend::ControllerParameters& parameters) const override;
162 162
163signals: 163signals:
@@ -167,5 +167,5 @@ signals:
167private: 167private:
168 void MainWindowReconfigureFinished(); 168 void MainWindowReconfigureFinished();
169 169
170 mutable std::function<void()> callback; 170 mutable ReconfigureCallback callback;
171}; 171};
diff --git a/src/yuzu/applets/qt_error.cpp b/src/yuzu/applets/qt_error.cpp
index 367d5352d..e0190a979 100644
--- a/src/yuzu/applets/qt_error.cpp
+++ b/src/yuzu/applets/qt_error.cpp
@@ -14,7 +14,7 @@ QtErrorDisplay::QtErrorDisplay(GMainWindow& parent) {
14 14
15QtErrorDisplay::~QtErrorDisplay() = default; 15QtErrorDisplay::~QtErrorDisplay() = default;
16 16
17void QtErrorDisplay::ShowError(Result error, std::function<void()> finished) const { 17void QtErrorDisplay::ShowError(Result error, FinishedCallback finished) const {
18 callback = std::move(finished); 18 callback = std::move(finished);
19 emit MainWindowDisplayError( 19 emit MainWindowDisplayError(
20 tr("Error Code: %1-%2 (0x%3)") 20 tr("Error Code: %1-%2 (0x%3)")
@@ -25,7 +25,7 @@ void QtErrorDisplay::ShowError(Result error, std::function<void()> finished) con
25} 25}
26 26
27void QtErrorDisplay::ShowErrorWithTimestamp(Result error, std::chrono::seconds time, 27void QtErrorDisplay::ShowErrorWithTimestamp(Result error, std::chrono::seconds time,
28 std::function<void()> finished) const { 28 FinishedCallback finished) const {
29 callback = std::move(finished); 29 callback = std::move(finished);
30 30
31 const QDateTime date_time = QDateTime::fromSecsSinceEpoch(time.count()); 31 const QDateTime date_time = QDateTime::fromSecsSinceEpoch(time.count());
@@ -42,7 +42,7 @@ void QtErrorDisplay::ShowErrorWithTimestamp(Result error, std::chrono::seconds t
42 42
43void QtErrorDisplay::ShowCustomErrorText(Result error, std::string dialog_text, 43void QtErrorDisplay::ShowCustomErrorText(Result error, std::string dialog_text,
44 std::string fullscreen_text, 44 std::string fullscreen_text,
45 std::function<void()> finished) const { 45 FinishedCallback finished) const {
46 callback = std::move(finished); 46 callback = std::move(finished);
47 emit MainWindowDisplayError( 47 emit MainWindowDisplayError(
48 tr("Error Code: %1-%2 (0x%3)") 48 tr("Error Code: %1-%2 (0x%3)")
diff --git a/src/yuzu/applets/qt_error.h b/src/yuzu/applets/qt_error.h
index eb4107c7e..e4e174721 100644
--- a/src/yuzu/applets/qt_error.h
+++ b/src/yuzu/applets/qt_error.h
@@ -16,11 +16,11 @@ public:
16 explicit QtErrorDisplay(GMainWindow& parent); 16 explicit QtErrorDisplay(GMainWindow& parent);
17 ~QtErrorDisplay() override; 17 ~QtErrorDisplay() override;
18 18
19 void ShowError(Result error, std::function<void()> finished) const override; 19 void ShowError(Result error, FinishedCallback finished) const override;
20 void ShowErrorWithTimestamp(Result error, std::chrono::seconds time, 20 void ShowErrorWithTimestamp(Result error, std::chrono::seconds time,
21 std::function<void()> finished) const override; 21 FinishedCallback finished) const override;
22 void ShowCustomErrorText(Result error, std::string dialog_text, std::string fullscreen_text, 22 void ShowCustomErrorText(Result error, std::string dialog_text, std::string fullscreen_text,
23 std::function<void()> finished) const override; 23 FinishedCallback finished) const override;
24 24
25signals: 25signals:
26 void MainWindowDisplayError(QString error_code, QString error_text) const; 26 void MainWindowDisplayError(QString error_code, QString error_text) const;
@@ -28,5 +28,5 @@ signals:
28private: 28private:
29 void MainWindowFinishedError(); 29 void MainWindowFinishedError();
30 30
31 mutable std::function<void()> callback; 31 mutable FinishedCallback callback;
32}; 32};
diff --git a/src/yuzu/applets/qt_profile_select.cpp b/src/yuzu/applets/qt_profile_select.cpp
index c8bcfb223..4145c5299 100644
--- a/src/yuzu/applets/qt_profile_select.cpp
+++ b/src/yuzu/applets/qt_profile_select.cpp
@@ -163,8 +163,7 @@ QtProfileSelector::QtProfileSelector(GMainWindow& parent) {
163 163
164QtProfileSelector::~QtProfileSelector() = default; 164QtProfileSelector::~QtProfileSelector() = default;
165 165
166void QtProfileSelector::SelectProfile( 166void QtProfileSelector::SelectProfile(SelectProfileCallback callback_) const {
167 std::function<void(std::optional<Common::UUID>)> callback_) const {
168 callback = std::move(callback_); 167 callback = std::move(callback_);
169 emit MainWindowSelectProfile(); 168 emit MainWindowSelectProfile();
170} 169}
diff --git a/src/yuzu/applets/qt_profile_select.h b/src/yuzu/applets/qt_profile_select.h
index 124f2cdbd..637a3bda2 100644
--- a/src/yuzu/applets/qt_profile_select.h
+++ b/src/yuzu/applets/qt_profile_select.h
@@ -65,7 +65,7 @@ public:
65 explicit QtProfileSelector(GMainWindow& parent); 65 explicit QtProfileSelector(GMainWindow& parent);
66 ~QtProfileSelector() override; 66 ~QtProfileSelector() override;
67 67
68 void SelectProfile(std::function<void(std::optional<Common::UUID>)> callback_) const override; 68 void SelectProfile(SelectProfileCallback callback_) const override;
69 69
70signals: 70signals:
71 void MainWindowSelectProfile() const; 71 void MainWindowSelectProfile() const;
@@ -73,5 +73,5 @@ signals:
73private: 73private:
74 void MainWindowFinishedSelection(std::optional<Common::UUID> uuid); 74 void MainWindowFinishedSelection(std::optional<Common::UUID> uuid);
75 75
76 mutable std::function<void(std::optional<Common::UUID>)> callback; 76 mutable SelectProfileCallback callback;
77}; 77};
diff --git a/src/yuzu/applets/qt_software_keyboard.cpp b/src/yuzu/applets/qt_software_keyboard.cpp
index e60506197..734b0ea40 100644
--- a/src/yuzu/applets/qt_software_keyboard.cpp
+++ b/src/yuzu/applets/qt_software_keyboard.cpp
@@ -1566,10 +1566,7 @@ QtSoftwareKeyboard::~QtSoftwareKeyboard() = default;
1566 1566
1567void QtSoftwareKeyboard::InitializeKeyboard( 1567void QtSoftwareKeyboard::InitializeKeyboard(
1568 bool is_inline, Core::Frontend::KeyboardInitializeParameters initialize_parameters, 1568 bool is_inline, Core::Frontend::KeyboardInitializeParameters initialize_parameters,
1569 std::function<void(Service::AM::Applets::SwkbdResult, std::u16string, bool)> 1569 SubmitNormalCallback submit_normal_callback_, SubmitInlineCallback submit_inline_callback_) {
1570 submit_normal_callback_,
1571 std::function<void(Service::AM::Applets::SwkbdReplyType, std::u16string, s32)>
1572 submit_inline_callback_) {
1573 if (is_inline) { 1570 if (is_inline) {
1574 submit_inline_callback = std::move(submit_inline_callback_); 1571 submit_inline_callback = std::move(submit_inline_callback_);
1575 } else { 1572 } else {
diff --git a/src/yuzu/applets/qt_software_keyboard.h b/src/yuzu/applets/qt_software_keyboard.h
index 35d4ee2ef..30ac8ecf6 100644
--- a/src/yuzu/applets/qt_software_keyboard.h
+++ b/src/yuzu/applets/qt_software_keyboard.h
@@ -233,12 +233,10 @@ public:
233 explicit QtSoftwareKeyboard(GMainWindow& parent); 233 explicit QtSoftwareKeyboard(GMainWindow& parent);
234 ~QtSoftwareKeyboard() override; 234 ~QtSoftwareKeyboard() override;
235 235
236 void InitializeKeyboard( 236 void InitializeKeyboard(bool is_inline,
237 bool is_inline, Core::Frontend::KeyboardInitializeParameters initialize_parameters, 237 Core::Frontend::KeyboardInitializeParameters initialize_parameters,
238 std::function<void(Service::AM::Applets::SwkbdResult, std::u16string, bool)> 238 SubmitNormalCallback submit_normal_callback_,
239 submit_normal_callback_, 239 SubmitInlineCallback submit_inline_callback_) override;
240 std::function<void(Service::AM::Applets::SwkbdReplyType, std::u16string, s32)>
241 submit_inline_callback_) override;
242 240
243 void ShowNormalKeyboard() const override; 241 void ShowNormalKeyboard() const override;
244 242
@@ -279,8 +277,6 @@ private:
279 void SubmitInlineText(Service::AM::Applets::SwkbdReplyType reply_type, 277 void SubmitInlineText(Service::AM::Applets::SwkbdReplyType reply_type,
280 std::u16string submitted_text, s32 cursor_position) const; 278 std::u16string submitted_text, s32 cursor_position) const;
281 279
282 mutable std::function<void(Service::AM::Applets::SwkbdResult, std::u16string, bool)> 280 mutable SubmitNormalCallback submit_normal_callback;
283 submit_normal_callback; 281 mutable SubmitInlineCallback submit_inline_callback;
284 mutable std::function<void(Service::AM::Applets::SwkbdReplyType, std::u16string, s32)>
285 submit_inline_callback;
286}; 282};
diff --git a/src/yuzu/applets/qt_web_browser.cpp b/src/yuzu/applets/qt_web_browser.cpp
index 89bd482e0..0a5912326 100644
--- a/src/yuzu/applets/qt_web_browser.cpp
+++ b/src/yuzu/applets/qt_web_browser.cpp
@@ -401,9 +401,9 @@ QtWebBrowser::QtWebBrowser(GMainWindow& main_window) {
401 401
402QtWebBrowser::~QtWebBrowser() = default; 402QtWebBrowser::~QtWebBrowser() = default;
403 403
404void QtWebBrowser::OpenLocalWebPage( 404void QtWebBrowser::OpenLocalWebPage(const std::string& local_url,
405 const std::string& local_url, std::function<void()> extract_romfs_callback_, 405 ExtractROMFSCallback extract_romfs_callback_,
406 std::function<void(Service::AM::Applets::WebExitReason, std::string)> callback_) const { 406 OpenWebPageCallback callback_) const {
407 extract_romfs_callback = std::move(extract_romfs_callback_); 407 extract_romfs_callback = std::move(extract_romfs_callback_);
408 callback = std::move(callback_); 408 callback = std::move(callback_);
409 409
@@ -416,9 +416,8 @@ void QtWebBrowser::OpenLocalWebPage(
416 } 416 }
417} 417}
418 418
419void QtWebBrowser::OpenExternalWebPage( 419void QtWebBrowser::OpenExternalWebPage(const std::string& external_url,
420 const std::string& external_url, 420 OpenWebPageCallback callback_) const {
421 std::function<void(Service::AM::Applets::WebExitReason, std::string)> callback_) const {
422 callback = std::move(callback_); 421 callback = std::move(callback_);
423 422
424 const auto index = external_url.find('?'); 423 const auto index = external_url.find('?');
diff --git a/src/yuzu/applets/qt_web_browser.h b/src/yuzu/applets/qt_web_browser.h
index 043800853..e8fe511ed 100644
--- a/src/yuzu/applets/qt_web_browser.h
+++ b/src/yuzu/applets/qt_web_browser.h
@@ -197,13 +197,11 @@ public:
197 ~QtWebBrowser() override; 197 ~QtWebBrowser() override;
198 198
199 void OpenLocalWebPage(const std::string& local_url, 199 void OpenLocalWebPage(const std::string& local_url,
200 std::function<void()> extract_romfs_callback_, 200 ExtractROMFSCallback extract_romfs_callback_,
201 std::function<void(Service::AM::Applets::WebExitReason, std::string)> 201 OpenWebPageCallback callback_) const override;
202 callback_) const override;
203 202
204 void OpenExternalWebPage(const std::string& external_url, 203 void OpenExternalWebPage(const std::string& external_url,
205 std::function<void(Service::AM::Applets::WebExitReason, std::string)> 204 OpenWebPageCallback callback_) const override;
206 callback_) const override;
207 205
208signals: 206signals:
209 void MainWindowOpenWebPage(const std::string& main_url, const std::string& additional_args, 207 void MainWindowOpenWebPage(const std::string& main_url, const std::string& additional_args,
@@ -215,7 +213,6 @@ private:
215 void MainWindowWebBrowserClosed(Service::AM::Applets::WebExitReason exit_reason, 213 void MainWindowWebBrowserClosed(Service::AM::Applets::WebExitReason exit_reason,
216 std::string last_url); 214 std::string last_url);
217 215
218 mutable std::function<void()> extract_romfs_callback; 216 mutable ExtractROMFSCallback extract_romfs_callback;
219 217 mutable OpenWebPageCallback callback;
220 mutable std::function<void(Service::AM::Applets::WebExitReason, std::string)> callback;
221}; 218};