diff options
| author | 2018-09-19 20:04:45 +0200 | |
|---|---|---|
| committer | 2018-10-02 15:30:48 +0200 | |
| commit | aa484688623db59df3ef334a63eff98d98e362f3 (patch) | |
| tree | 23c2ccdbe5e562e281e1e96d306036f724856461 /src | |
| parent | web_backend: protect jwt cache with a mutex (diff) | |
| download | yuzu-aa484688623db59df3ef334a63eff98d98e362f3.tar.gz yuzu-aa484688623db59df3ef334a63eff98d98e362f3.tar.xz yuzu-aa484688623db59df3ef334a63eff98d98e362f3.zip | |
Review comments - part 3
Diffstat (limited to 'src')
| -rw-r--r-- | src/web_service/json.h | 18 | ||||
| -rw-r--r-- | src/web_service/telemetry_json.h | 2 | ||||
| -rw-r--r-- | src/web_service/verify_login.cpp | 2 | ||||
| -rw-r--r-- | src/yuzu/configuration/configure_web.cpp | 6 | ||||
| -rw-r--r-- | src/yuzu/main.cpp | 2 | ||||
| -rw-r--r-- | src/yuzu_cmd/default_ini.h | 2 |
6 files changed, 7 insertions, 25 deletions
diff --git a/src/web_service/json.h b/src/web_service/json.h deleted file mode 100644 index 88b31501e..000000000 --- a/src/web_service/json.h +++ /dev/null | |||
| @@ -1,18 +0,0 @@ | |||
| 1 | // Copyright 2018 Citra Emulator Project | ||
| 2 | // Licensed under GPLv2 or any later version | ||
| 3 | // Refer to the license.txt file included. | ||
| 4 | |||
| 5 | #pragma once | ||
| 6 | |||
| 7 | // This hack is needed to support json.hpp on platforms where the C++17 stdlib | ||
| 8 | // lacks std::string_view. See https://github.com/nlohmann/json/issues/735. | ||
| 9 | // clang-format off | ||
| 10 | #if !__has_include(<string_view>) && __has_include(<experimental/string_view>) | ||
| 11 | # include <experimental/string_view> | ||
| 12 | # define string_view experimental::string_view | ||
| 13 | # include <json.hpp> | ||
| 14 | # undef string_view | ||
| 15 | #else | ||
| 16 | # include <json.hpp> | ||
| 17 | #endif | ||
| 18 | // clang-format on | ||
diff --git a/src/web_service/telemetry_json.h b/src/web_service/telemetry_json.h index 29d565964..0fe6f9a3e 100644 --- a/src/web_service/telemetry_json.h +++ b/src/web_service/telemetry_json.h | |||
| @@ -6,9 +6,9 @@ | |||
| 6 | 6 | ||
| 7 | #include <array> | 7 | #include <array> |
| 8 | #include <string> | 8 | #include <string> |
| 9 | #include <json.hpp> | ||
| 9 | #include "common/telemetry.h" | 10 | #include "common/telemetry.h" |
| 10 | #include "common/web_result.h" | 11 | #include "common/web_result.h" |
| 11 | #include "web_service/json.h" | ||
| 12 | 12 | ||
| 13 | namespace WebService { | 13 | namespace WebService { |
| 14 | 14 | ||
diff --git a/src/web_service/verify_login.cpp b/src/web_service/verify_login.cpp index 02e1b74f3..124aa3863 100644 --- a/src/web_service/verify_login.cpp +++ b/src/web_service/verify_login.cpp | |||
| @@ -2,7 +2,7 @@ | |||
| 2 | // Licensed under GPLv2 or any later version | 2 | // Licensed under GPLv2 or any later version |
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include "web_service/json.h" | 5 | #include <json.hpp> |
| 6 | #include "web_service/verify_login.h" | 6 | #include "web_service/verify_login.h" |
| 7 | #include "web_service/web_backend.h" | 7 | #include "web_service/web_backend.h" |
| 8 | 8 | ||
diff --git a/src/yuzu/configuration/configure_web.cpp b/src/yuzu/configuration/configure_web.cpp index 4b5c39e26..d6bd3d309 100644 --- a/src/yuzu/configuration/configure_web.cpp +++ b/src/yuzu/configuration/configure_web.cpp | |||
| @@ -31,18 +31,18 @@ void ConfigureWeb::setConfiguration() { | |||
| 31 | ui->web_credentials_disclaimer->setWordWrap(true); | 31 | ui->web_credentials_disclaimer->setWordWrap(true); |
| 32 | ui->telemetry_learn_more->setOpenExternalLinks(true); | 32 | ui->telemetry_learn_more->setOpenExternalLinks(true); |
| 33 | ui->telemetry_learn_more->setText(tr("<a " | 33 | ui->telemetry_learn_more->setText(tr("<a " |
| 34 | "href='https://citra-emu.org/entry/" | 34 | "href='https://yuzu-emu.org/entry/" |
| 35 | "telemetry-and-why-thats-a-good-thing/'><span " | 35 | "telemetry-and-why-thats-a-good-thing/'><span " |
| 36 | "style=\"text-decoration: underline; " | 36 | "style=\"text-decoration: underline; " |
| 37 | "color:#039be5;\">Learn more</span></a>")); | 37 | "color:#039be5;\">Learn more</span></a>")); |
| 38 | 38 | ||
| 39 | ui->web_signup_link->setOpenExternalLinks(true); | 39 | ui->web_signup_link->setOpenExternalLinks(true); |
| 40 | ui->web_signup_link->setText( | 40 | ui->web_signup_link->setText( |
| 41 | tr("<a href='https://services.citra-emu.org/'><span style=\"text-decoration: underline; " | 41 | tr("<a href='https://profile.yuzu-emu.org/'><span style=\"text-decoration: underline; " |
| 42 | "color:#039be5;\">Sign up</span></a>")); | 42 | "color:#039be5;\">Sign up</span></a>")); |
| 43 | ui->web_token_info_link->setOpenExternalLinks(true); | 43 | ui->web_token_info_link->setOpenExternalLinks(true); |
| 44 | ui->web_token_info_link->setText( | 44 | ui->web_token_info_link->setText( |
| 45 | tr("<a href='https://citra-emu.org/wiki/citra-web-service/'><span style=\"text-decoration: " | 45 | tr("<a href='https://yuzu-emu.org/wiki/yuzu-web-service/'><span style=\"text-decoration: " |
| 46 | "underline; color:#039be5;\">What is my token?</span></a>")); | 46 | "underline; color:#039be5;\">What is my token?</span></a>")); |
| 47 | 47 | ||
| 48 | ui->toggle_telemetry->setChecked(Settings::values.enable_telemetry); | 48 | ui->toggle_telemetry->setChecked(Settings::values.enable_telemetry); |
diff --git a/src/yuzu/main.cpp b/src/yuzu/main.cpp index f236c63c5..52743aefd 100644 --- a/src/yuzu/main.cpp +++ b/src/yuzu/main.cpp | |||
| @@ -116,7 +116,7 @@ void GMainWindow::ShowTelemetryCallout() { | |||
| 116 | 116 | ||
| 117 | UISettings::values.callout_flags |= static_cast<uint32_t>(CalloutFlag::Telemetry); | 117 | UISettings::values.callout_flags |= static_cast<uint32_t>(CalloutFlag::Telemetry); |
| 118 | const QString telemetry_message = | 118 | const QString telemetry_message = |
| 119 | tr("<a href='https://citra-emu.org/entry/telemetry-and-why-thats-a-good-thing/'>Anonymous " | 119 | tr("<a href='https://yuzu-emu.org/entry/telemetry-and-why-thats-a-good-thing/'>Anonymous " |
| 120 | "data is collected</a> to help improve yuzu. " | 120 | "data is collected</a> to help improve yuzu. " |
| 121 | "<br/><br/>Would you like to share your usage data with us?"); | 121 | "<br/><br/>Would you like to share your usage data with us?"); |
| 122 | if (QMessageBox::question(this, tr("Telemetry"), telemetry_message) != QMessageBox::Yes) { | 122 | if (QMessageBox::question(this, tr("Telemetry"), telemetry_message) != QMessageBox::Yes) { |
diff --git a/src/yuzu_cmd/default_ini.h b/src/yuzu_cmd/default_ini.h index eaa64da39..762396e3b 100644 --- a/src/yuzu_cmd/default_ini.h +++ b/src/yuzu_cmd/default_ini.h | |||
| @@ -205,7 +205,7 @@ enable_telemetry = | |||
| 205 | # URL for Web API | 205 | # URL for Web API |
| 206 | web_api_url = https://api.yuzu-emu.org | 206 | web_api_url = https://api.yuzu-emu.org |
| 207 | # Username and token for yuzu Web Service | 207 | # Username and token for yuzu Web Service |
| 208 | # See https://services.citra-emu.org/ for more info | 208 | # See https://profile.yuzu-emu.org/ for more info |
| 209 | yuzu_username = | 209 | yuzu_username = |
| 210 | yuzu_token = | 210 | yuzu_token = |
| 211 | )"; | 211 | )"; |