summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorGravatar Lioncash2018-10-10 20:59:25 -0400
committerGravatar Lioncash2018-10-10 20:59:28 -0400
commit881bb2295d40c50a401cd05fff8eeb822ec577e9 (patch)
tree87f5ed2f86168d9c8a181323f60e9d4f104bfca8 /src
parenttelemetry_json: Remove unnecessary includes (diff)
downloadyuzu-881bb2295d40c50a401cd05fff8eeb822ec577e9.tar.gz
yuzu-881bb2295d40c50a401cd05fff8eeb822ec577e9.tar.xz
yuzu-881bb2295d40c50a401cd05fff8eeb822ec577e9.zip
telemetry_json: Take std::string parameters by value
Taking them by const reference isn't advisable here, because it means the std::move calls were doing nothing and we were always copying the std::string instances.
Diffstat (limited to 'src')
-rw-r--r--src/web_service/telemetry_json.cpp3
-rw-r--r--src/web_service/telemetry_json.h2
2 files changed, 2 insertions, 3 deletions
diff --git a/src/web_service/telemetry_json.cpp b/src/web_service/telemetry_json.cpp
index e77950aa3..b24e806a8 100644
--- a/src/web_service/telemetry_json.cpp
+++ b/src/web_service/telemetry_json.cpp
@@ -8,8 +8,7 @@
8 8
9namespace WebService { 9namespace WebService {
10 10
11TelemetryJson::TelemetryJson(const std::string& host, const std::string& username, 11TelemetryJson::TelemetryJson(std::string host, std::string username, std::string token)
12 const std::string& token)
13 : host(std::move(host)), username(std::move(username)), token(std::move(token)) {} 12 : host(std::move(host)), username(std::move(username)), token(std::move(token)) {}
14TelemetryJson::~TelemetryJson() = default; 13TelemetryJson::~TelemetryJson() = default;
15 14
diff --git a/src/web_service/telemetry_json.h b/src/web_service/telemetry_json.h
index 72627a416..92ead9856 100644
--- a/src/web_service/telemetry_json.h
+++ b/src/web_service/telemetry_json.h
@@ -18,7 +18,7 @@ namespace WebService {
18 */ 18 */
19class TelemetryJson : public Telemetry::VisitorInterface { 19class TelemetryJson : public Telemetry::VisitorInterface {
20public: 20public:
21 TelemetryJson(const std::string& host, const std::string& username, const std::string& token); 21 TelemetryJson(std::string host, std::string username, std::string token);
22 ~TelemetryJson(); 22 ~TelemetryJson();
23 23
24 void Visit(const Telemetry::Field<bool>& field) override; 24 void Visit(const Telemetry::Field<bool>& field) override;