summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorGravatar Lioncash2018-05-02 09:14:28 -0400
committerGravatar Lioncash2018-05-02 09:49:36 -0400
commit7c9644646f595605036b9fe9e51c44716ee60fa3 (patch)
tree20f8f60d78ed7db5c76629d452ed196d43dc3e78 /src
parentMerge pull request #429 from Subv/ioctl_corruption (diff)
downloadyuzu-7c9644646f595605036b9fe9e51c44716ee60fa3.tar.gz
yuzu-7c9644646f595605036b9fe9e51c44716ee60fa3.tar.xz
yuzu-7c9644646f595605036b9fe9e51c44716ee60fa3.zip
general: Make formatting of logged hex values more straightforward
This makes the formatting expectations more obvious (e.g. any zero padding specified is padding that's entirely dedicated to the value being printed, not any pretty-printing that also gets tacked on).
Diffstat (limited to 'src')
-rw-r--r--src/core/arm/dynarmic/arm_dynarmic.cpp2
-rw-r--r--src/core/arm/unicorn/arm_unicorn.cpp2
-rw-r--r--src/core/file_sys/program_metadata.cpp18
-rw-r--r--src/core/hle/kernel/object_address_table.cpp4
-rw-r--r--src/core/hle/kernel/process.cpp2
-rw-r--r--src/core/hle/kernel/server_session.cpp2
-rw-r--r--src/core/hle/kernel/shared_memory.cpp6
-rw-r--r--src/core/hle/kernel/svc.cpp77
-rw-r--r--src/core/hle/kernel/vm_manager.cpp8
-rw-r--r--src/core/hle/service/am/am.cpp2
-rw-r--r--src/core/hle/service/fatal/fatal.cpp2
-rw-r--r--src/core/hle/service/filesystem/filesystem.cpp2
-rw-r--r--src/core/hle/service/filesystem/fsp_srv.cpp10
-rw-r--r--src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp4
-rw-r--r--src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp2
-rw-r--r--src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp4
-rw-r--r--src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp2
-rw-r--r--src/core/hle/service/nvdrv/devices/nvmap.cpp2
-rw-r--r--src/core/hle/service/nvdrv/interface.cpp2
-rw-r--r--src/core/hle/service/service.cpp8
-rw-r--r--src/core/hle/service/sm/sm.cpp2
-rw-r--r--src/core/hle/service/time/time.cpp2
-rw-r--r--src/core/hle/service/vi/vi.cpp4
-rw-r--r--src/core/hw/hw.cpp4
-rw-r--r--src/core/hw/lcd.cpp4
-rw-r--r--src/core/loader/deconstructed_rom_directory.cpp6
-rw-r--r--src/core/loader/nso.cpp2
-rw-r--r--src/core/memory.cpp22
-rw-r--r--src/video_core/renderer_opengl/gl_rasterizer.cpp2
29 files changed, 105 insertions, 104 deletions
diff --git a/src/core/arm/dynarmic/arm_dynarmic.cpp b/src/core/arm/dynarmic/arm_dynarmic.cpp
index 984ad853d..b5db47667 100644
--- a/src/core/arm/dynarmic/arm_dynarmic.cpp
+++ b/src/core/arm/dynarmic/arm_dynarmic.cpp
@@ -55,7 +55,7 @@ public:
55 } 55 }
56 56
57 void InterpreterFallback(u64 pc, size_t num_instructions) override { 57 void InterpreterFallback(u64 pc, size_t num_instructions) override {
58 NGLOG_INFO(Core_ARM, "Unicorn fallback @ {:#X} for {} instructions (instr = {:08X})", pc, 58 NGLOG_INFO(Core_ARM, "Unicorn fallback @ 0x{:X} for {} instructions (instr = {:08X})", pc,
59 num_instructions, MemoryReadCode(pc)); 59 num_instructions, MemoryReadCode(pc));
60 60
61 ARM_Interface::ThreadContext ctx; 61 ARM_Interface::ThreadContext ctx;
diff --git a/src/core/arm/unicorn/arm_unicorn.cpp b/src/core/arm/unicorn/arm_unicorn.cpp
index 4b121edb3..574922130 100644
--- a/src/core/arm/unicorn/arm_unicorn.cpp
+++ b/src/core/arm/unicorn/arm_unicorn.cpp
@@ -53,7 +53,7 @@ static bool UnmappedMemoryHook(uc_engine* uc, uc_mem_type type, u64 addr, int si
53 void* user_data) { 53 void* user_data) {
54 ARM_Interface::ThreadContext ctx{}; 54 ARM_Interface::ThreadContext ctx{};
55 Core::CPU().SaveContext(ctx); 55 Core::CPU().SaveContext(ctx);
56 ASSERT_MSG(false, "Attempted to read from unmapped memory: {:#X}, pc={:#X}, lr={:#X}", addr, 56 ASSERT_MSG(false, "Attempted to read from unmapped memory: 0x{:X}, pc=0x{:X}, lr=0x{:X}", addr,
57 ctx.pc, ctx.cpu_registers[30]); 57 ctx.pc, ctx.cpu_registers[30]);
58 return {}; 58 return {};
59} 59}
diff --git a/src/core/file_sys/program_metadata.cpp b/src/core/file_sys/program_metadata.cpp
index 1f5ded514..25a822891 100644
--- a/src/core/file_sys/program_metadata.cpp
+++ b/src/core/file_sys/program_metadata.cpp
@@ -77,11 +77,11 @@ u64 ProgramMetadata::GetFilesystemPermissions() const {
77 77
78void ProgramMetadata::Print() const { 78void ProgramMetadata::Print() const {
79 NGLOG_DEBUG(Service_FS, "Magic: {:.4}", npdm_header.magic.data()); 79 NGLOG_DEBUG(Service_FS, "Magic: {:.4}", npdm_header.magic.data());
80 NGLOG_DEBUG(Service_FS, "Main thread priority: {:#04X}", npdm_header.main_thread_priority); 80 NGLOG_DEBUG(Service_FS, "Main thread priority: 0x{:02X}", npdm_header.main_thread_priority);
81 NGLOG_DEBUG(Service_FS, "Main thread core: {}", npdm_header.main_thread_cpu); 81 NGLOG_DEBUG(Service_FS, "Main thread core: {}", npdm_header.main_thread_cpu);
82 NGLOG_DEBUG(Service_FS, "Main thread stack size: {:#X} bytes", npdm_header.main_stack_size); 82 NGLOG_DEBUG(Service_FS, "Main thread stack size: 0x{:X} bytes", npdm_header.main_stack_size);
83 NGLOG_DEBUG(Service_FS, "Process category: {}", npdm_header.process_category); 83 NGLOG_DEBUG(Service_FS, "Process category: {}", npdm_header.process_category);
84 NGLOG_DEBUG(Service_FS, "Flags: {:02X}", npdm_header.flags); 84 NGLOG_DEBUG(Service_FS, "Flags: 0x{:02X}", npdm_header.flags);
85 NGLOG_DEBUG(Service_FS, " > 64-bit instructions: {}", 85 NGLOG_DEBUG(Service_FS, " > 64-bit instructions: {}",
86 npdm_header.has_64_bit_instructions ? "YES" : "NO"); 86 npdm_header.has_64_bit_instructions ? "YES" : "NO");
87 87
@@ -99,15 +99,15 @@ void ProgramMetadata::Print() const {
99 99
100 // Begin ACID printing (potential perms, signed) 100 // Begin ACID printing (potential perms, signed)
101 NGLOG_DEBUG(Service_FS, "Magic: {:.4}", acid_header.magic.data()); 101 NGLOG_DEBUG(Service_FS, "Magic: {:.4}", acid_header.magic.data());
102 NGLOG_DEBUG(Service_FS, "Flags: {:02X}", acid_header.flags); 102 NGLOG_DEBUG(Service_FS, "Flags: 0x{:02X}", acid_header.flags);
103 NGLOG_DEBUG(Service_FS, " > Is Retail: {}", acid_header.is_retail ? "YES" : "NO"); 103 NGLOG_DEBUG(Service_FS, " > Is Retail: {}", acid_header.is_retail ? "YES" : "NO");
104 NGLOG_DEBUG(Service_FS, "Title ID Min: {:016X}", acid_header.title_id_min); 104 NGLOG_DEBUG(Service_FS, "Title ID Min: 0x{:016X}", acid_header.title_id_min);
105 NGLOG_DEBUG(Service_FS, "Title ID Max: {:016X}", acid_header.title_id_max); 105 NGLOG_DEBUG(Service_FS, "Title ID Max: 0x{:016X}", acid_header.title_id_max);
106 NGLOG_DEBUG(Service_FS, "Filesystem Access: {:016X}\n", acid_file_access.permissions); 106 NGLOG_DEBUG(Service_FS, "Filesystem Access: 0x{:016X}\n", acid_file_access.permissions);
107 107
108 // Begin ACI0 printing (actual perms, unsigned) 108 // Begin ACI0 printing (actual perms, unsigned)
109 NGLOG_DEBUG(Service_FS, "Magic: {:.4}", aci_header.magic.data()); 109 NGLOG_DEBUG(Service_FS, "Magic: {:.4}", aci_header.magic.data());
110 NGLOG_DEBUG(Service_FS, "Title ID: {:016X}", aci_header.title_id); 110 NGLOG_DEBUG(Service_FS, "Title ID: 0x{:016X}", aci_header.title_id);
111 NGLOG_DEBUG(Service_FS, "Filesystem Access: {:016X}\n", aci_file_access.permissions); 111 NGLOG_DEBUG(Service_FS, "Filesystem Access: 0x{:016X}\n", aci_file_access.permissions);
112} 112}
113} // namespace FileSys 113} // namespace FileSys
diff --git a/src/core/hle/kernel/object_address_table.cpp b/src/core/hle/kernel/object_address_table.cpp
index b88a90f24..ec97f6f8e 100644
--- a/src/core/hle/kernel/object_address_table.cpp
+++ b/src/core/hle/kernel/object_address_table.cpp
@@ -10,12 +10,12 @@ namespace Kernel {
10ObjectAddressTable g_object_address_table; 10ObjectAddressTable g_object_address_table;
11 11
12void ObjectAddressTable::Insert(VAddr addr, SharedPtr<Object> obj) { 12void ObjectAddressTable::Insert(VAddr addr, SharedPtr<Object> obj) {
13 ASSERT_MSG(objects.find(addr) == objects.end(), "Object already exists with addr={:#X}", addr); 13 ASSERT_MSG(objects.find(addr) == objects.end(), "Object already exists with addr=0x{:X}", addr);
14 objects[addr] = obj; 14 objects[addr] = obj;
15} 15}
16 16
17void ObjectAddressTable::Close(VAddr addr) { 17void ObjectAddressTable::Close(VAddr addr) {
18 ASSERT_MSG(objects.find(addr) != objects.end(), "Object does not exist with addr={:#X}", addr); 18 ASSERT_MSG(objects.find(addr) != objects.end(), "Object does not exist with addr=0x{:X}", addr);
19 objects.erase(addr); 19 objects.erase(addr);
20} 20}
21 21
diff --git a/src/core/hle/kernel/process.cpp b/src/core/hle/kernel/process.cpp
index b423a3477..651d932d3 100644
--- a/src/core/hle/kernel/process.cpp
+++ b/src/core/hle/kernel/process.cpp
@@ -111,7 +111,7 @@ void Process::ParseKernelCaps(const u32* kernel_caps, size_t len) {
111 int major = (kernel_version >> 8) & 0xFF; 111 int major = (kernel_version >> 8) & 0xFF;
112 NGLOG_INFO(Loader, "ExHeader kernel version: {}.{}", major, minor); 112 NGLOG_INFO(Loader, "ExHeader kernel version: {}.{}", major, minor);
113 } else { 113 } else {
114 NGLOG_ERROR(Loader, "Unhandled kernel caps descriptor: {:#010X}", descriptor); 114 NGLOG_ERROR(Loader, "Unhandled kernel caps descriptor: 0x{:08X}", descriptor);
115 } 115 }
116 } 116 }
117} 117}
diff --git a/src/core/hle/kernel/server_session.cpp b/src/core/hle/kernel/server_session.cpp
index b1f8e771c..ad47ff9df 100644
--- a/src/core/hle/kernel/server_session.cpp
+++ b/src/core/hle/kernel/server_session.cpp
@@ -68,7 +68,7 @@ ResultCode ServerSession::HandleDomainSyncRequest(Kernel::HLERequestContext& con
68 return domain_request_handlers[object_id - 1]->HandleSyncRequest(context); 68 return domain_request_handlers[object_id - 1]->HandleSyncRequest(context);
69 69
70 case IPC::DomainMessageHeader::CommandType::CloseVirtualHandle: { 70 case IPC::DomainMessageHeader::CommandType::CloseVirtualHandle: {
71 NGLOG_DEBUG(IPC, "CloseVirtualHandle, object_id={:#010X}", object_id); 71 NGLOG_DEBUG(IPC, "CloseVirtualHandle, object_id=0x{:08X}", object_id);
72 72
73 domain_request_handlers[object_id - 1] = nullptr; 73 domain_request_handlers[object_id - 1] = nullptr;
74 74
diff --git a/src/core/hle/kernel/shared_memory.cpp b/src/core/hle/kernel/shared_memory.cpp
index f0b65c73d..ac4921298 100644
--- a/src/core/hle/kernel/shared_memory.cpp
+++ b/src/core/hle/kernel/shared_memory.cpp
@@ -107,7 +107,7 @@ ResultCode SharedMemory::Map(Process* target_process, VAddr address, MemoryPermi
107 107
108 // Error out if the requested permissions don't match what the creator process allows. 108 // Error out if the requested permissions don't match what the creator process allows.
109 if (static_cast<u32>(permissions) & ~static_cast<u32>(own_other_permissions)) { 109 if (static_cast<u32>(permissions) & ~static_cast<u32>(own_other_permissions)) {
110 NGLOG_ERROR(Kernel, "cannot map id={}, address={:#X} name={}, permissions don't match", 110 NGLOG_ERROR(Kernel, "cannot map id={}, address=0x{:X} name={}, permissions don't match",
111 GetObjectId(), address, name); 111 GetObjectId(), address, name);
112 return ERR_INVALID_COMBINATION; 112 return ERR_INVALID_COMBINATION;
113 } 113 }
@@ -115,7 +115,7 @@ ResultCode SharedMemory::Map(Process* target_process, VAddr address, MemoryPermi
115 // Error out if the provided permissions are not compatible with what the creator process needs. 115 // Error out if the provided permissions are not compatible with what the creator process needs.
116 if (other_permissions != MemoryPermission::DontCare && 116 if (other_permissions != MemoryPermission::DontCare &&
117 static_cast<u32>(this->permissions) & ~static_cast<u32>(other_permissions)) { 117 static_cast<u32>(this->permissions) & ~static_cast<u32>(other_permissions)) {
118 NGLOG_ERROR(Kernel, "cannot map id={}, address={:#X} name={}, permissions don't match", 118 NGLOG_ERROR(Kernel, "cannot map id={}, address=0x{:X} name={}, permissions don't match",
119 GetObjectId(), address, name); 119 GetObjectId(), address, name);
120 return ERR_WRONG_PERMISSION; 120 return ERR_WRONG_PERMISSION;
121 } 121 }
@@ -133,7 +133,7 @@ ResultCode SharedMemory::Map(Process* target_process, VAddr address, MemoryPermi
133 if (result.Failed()) { 133 if (result.Failed()) {
134 NGLOG_ERROR( 134 NGLOG_ERROR(
135 Kernel, 135 Kernel,
136 "cannot map id={}, target_address={:#X} name={}, error mapping to virtual memory", 136 "cannot map id={}, target_address=0x{:X} name={}, error mapping to virtual memory",
137 GetObjectId(), target_address, name); 137 GetObjectId(), target_address, name);
138 return result.Code(); 138 return result.Code();
139 } 139 }
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp
index e2da68227..72b5c05f2 100644
--- a/src/core/hle/kernel/svc.cpp
+++ b/src/core/hle/kernel/svc.cpp
@@ -31,7 +31,7 @@ namespace Kernel {
31 31
32/// Set the process heap to a given Size. It can both extend and shrink the heap. 32/// Set the process heap to a given Size. It can both extend and shrink the heap.
33static ResultCode SetHeapSize(VAddr* heap_addr, u64 heap_size) { 33static ResultCode SetHeapSize(VAddr* heap_addr, u64 heap_size) {
34 NGLOG_TRACE(Kernel_SVC, "called, heap_size={:#X}", heap_size); 34 NGLOG_TRACE(Kernel_SVC, "called, heap_size=0x{:X}", heap_size);
35 auto& process = *Core::CurrentProcess(); 35 auto& process = *Core::CurrentProcess();
36 CASCADE_RESULT(*heap_addr, 36 CASCADE_RESULT(*heap_addr,
37 process.HeapAllocate(Memory::HEAP_VADDR, heap_size, VMAPermission::ReadWrite)); 37 process.HeapAllocate(Memory::HEAP_VADDR, heap_size, VMAPermission::ReadWrite));
@@ -39,20 +39,20 @@ static ResultCode SetHeapSize(VAddr* heap_addr, u64 heap_size) {
39} 39}
40 40
41static ResultCode SetMemoryAttribute(VAddr addr, u64 size, u32 state0, u32 state1) { 41static ResultCode SetMemoryAttribute(VAddr addr, u64 size, u32 state0, u32 state1) {
42 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called, addr={:#X}", addr); 42 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called, addr=0x{:X}", addr);
43 return RESULT_SUCCESS; 43 return RESULT_SUCCESS;
44} 44}
45 45
46/// Maps a memory range into a different range. 46/// Maps a memory range into a different range.
47static ResultCode MapMemory(VAddr dst_addr, VAddr src_addr, u64 size) { 47static ResultCode MapMemory(VAddr dst_addr, VAddr src_addr, u64 size) {
48 NGLOG_TRACE(Kernel_SVC, "called, dst_addr={:#X}, src_addr={:#X}, size={:#X}", dst_addr, 48 NGLOG_TRACE(Kernel_SVC, "called, dst_addr=0x{:X}, src_addr=0x{:X}, size=0x{:X}", dst_addr,
49 src_addr, size); 49 src_addr, size);
50 return Core::CurrentProcess()->MirrorMemory(dst_addr, src_addr, size); 50 return Core::CurrentProcess()->MirrorMemory(dst_addr, src_addr, size);
51} 51}
52 52
53/// Unmaps a region that was previously mapped with svcMapMemory 53/// Unmaps a region that was previously mapped with svcMapMemory
54static ResultCode UnmapMemory(VAddr dst_addr, VAddr src_addr, u64 size) { 54static ResultCode UnmapMemory(VAddr dst_addr, VAddr src_addr, u64 size) {
55 NGLOG_TRACE(Kernel_SVC, "called, dst_addr={:#X}, src_addr={:#X}, size={:#X}", dst_addr, 55 NGLOG_TRACE(Kernel_SVC, "called, dst_addr=0x{:X}, src_addr=0x{:X}, size=0x{:X}", dst_addr,
56 src_addr, size); 56 src_addr, size);
57 return Core::CurrentProcess()->UnmapMemory(dst_addr, src_addr, size); 57 return Core::CurrentProcess()->UnmapMemory(dst_addr, src_addr, size);
58} 58}
@@ -90,11 +90,11 @@ static ResultCode ConnectToNamedPort(Handle* out_handle, VAddr port_name_address
90static ResultCode SendSyncRequest(Handle handle) { 90static ResultCode SendSyncRequest(Handle handle) {
91 SharedPtr<ClientSession> session = g_handle_table.Get<ClientSession>(handle); 91 SharedPtr<ClientSession> session = g_handle_table.Get<ClientSession>(handle);
92 if (!session) { 92 if (!session) {
93 NGLOG_ERROR(Kernel_SVC, "called with invalid handle={:#010X}", handle); 93 NGLOG_ERROR(Kernel_SVC, "called with invalid handle=0x{:08X}", handle);
94 return ERR_INVALID_HANDLE; 94 return ERR_INVALID_HANDLE;
95 } 95 }
96 96
97 NGLOG_TRACE(Kernel_SVC, "called handle={:#010X}({})", handle, session->GetName()); 97 NGLOG_TRACE(Kernel_SVC, "called handle=0x{:08X}({})", handle, session->GetName());
98 98
99 Core::System::GetInstance().PrepareReschedule(); 99 Core::System::GetInstance().PrepareReschedule();
100 100
@@ -105,7 +105,7 @@ static ResultCode SendSyncRequest(Handle handle) {
105 105
106/// Get the ID for the specified thread. 106/// Get the ID for the specified thread.
107static ResultCode GetThreadId(u32* thread_id, Handle thread_handle) { 107static ResultCode GetThreadId(u32* thread_id, Handle thread_handle) {
108 NGLOG_TRACE(Kernel_SVC, "called thread={:#010X}", thread_handle); 108 NGLOG_TRACE(Kernel_SVC, "called thread=0x{:08X}", thread_handle);
109 109
110 const SharedPtr<Thread> thread = g_handle_table.Get<Thread>(thread_handle); 110 const SharedPtr<Thread> thread = g_handle_table.Get<Thread>(thread_handle);
111 if (!thread) { 111 if (!thread) {
@@ -118,7 +118,7 @@ static ResultCode GetThreadId(u32* thread_id, Handle thread_handle) {
118 118
119/// Get the ID of the specified process 119/// Get the ID of the specified process
120static ResultCode GetProcessId(u32* process_id, Handle process_handle) { 120static ResultCode GetProcessId(u32* process_id, Handle process_handle) {
121 NGLOG_TRACE(Kernel_SVC, "called process={:#010X}", process_handle); 121 NGLOG_TRACE(Kernel_SVC, "called process=0x{:08X}", process_handle);
122 122
123 const SharedPtr<Process> process = g_handle_table.Get<Process>(process_handle); 123 const SharedPtr<Process> process = g_handle_table.Get<Process>(process_handle);
124 if (!process) { 124 if (!process) {
@@ -178,7 +178,7 @@ static ResultCode WaitSynchronization1(
178/// Wait for the given handles to synchronize, timeout after the specified nanoseconds 178/// Wait for the given handles to synchronize, timeout after the specified nanoseconds
179static ResultCode WaitSynchronization(Handle* index, VAddr handles_address, u64 handle_count, 179static ResultCode WaitSynchronization(Handle* index, VAddr handles_address, u64 handle_count,
180 s64 nano_seconds) { 180 s64 nano_seconds) {
181 NGLOG_TRACE(Kernel_SVC, "called handles_address={:#X}, handle_count={}, nano_seconds={}", 181 NGLOG_TRACE(Kernel_SVC, "called handles_address=0x{:X}, handle_count={}, nano_seconds={}",
182 handles_address, handle_count, nano_seconds); 182 handles_address, handle_count, nano_seconds);
183 183
184 if (!Memory::IsValidVirtualAddress(handles_address)) 184 if (!Memory::IsValidVirtualAddress(handles_address))
@@ -239,7 +239,7 @@ static ResultCode WaitSynchronization(Handle* index, VAddr handles_address, u64
239 239
240/// Resumes a thread waiting on WaitSynchronization 240/// Resumes a thread waiting on WaitSynchronization
241static ResultCode CancelSynchronization(Handle thread_handle) { 241static ResultCode CancelSynchronization(Handle thread_handle) {
242 NGLOG_TRACE(Kernel_SVC, "called thread={:#X}", thread_handle); 242 NGLOG_TRACE(Kernel_SVC, "called thread=0x{:X}", thread_handle);
243 243
244 const SharedPtr<Thread> thread = g_handle_table.Get<Thread>(thread_handle); 244 const SharedPtr<Thread> thread = g_handle_table.Get<Thread>(thread_handle);
245 if (!thread) { 245 if (!thread) {
@@ -257,8 +257,8 @@ static ResultCode CancelSynchronization(Handle thread_handle) {
257static ResultCode ArbitrateLock(Handle holding_thread_handle, VAddr mutex_addr, 257static ResultCode ArbitrateLock(Handle holding_thread_handle, VAddr mutex_addr,
258 Handle requesting_thread_handle) { 258 Handle requesting_thread_handle) {
259 NGLOG_TRACE(Kernel_SVC, 259 NGLOG_TRACE(Kernel_SVC,
260 "called holding_thread_handle={:#010X}, mutex_addr={:#X}, " 260 "called holding_thread_handle=0x{:08X}, mutex_addr=0x{:X}, "
261 "requesting_current_thread_handle={:#010X}", 261 "requesting_current_thread_handle=0x{:08X}",
262 holding_thread_handle, mutex_addr, requesting_thread_handle); 262 holding_thread_handle, mutex_addr, requesting_thread_handle);
263 263
264 return Mutex::TryAcquire(mutex_addr, holding_thread_handle, requesting_thread_handle); 264 return Mutex::TryAcquire(mutex_addr, holding_thread_handle, requesting_thread_handle);
@@ -266,7 +266,7 @@ static ResultCode ArbitrateLock(Handle holding_thread_handle, VAddr mutex_addr,
266 266
267/// Unlock a mutex 267/// Unlock a mutex
268static ResultCode ArbitrateUnlock(VAddr mutex_addr) { 268static ResultCode ArbitrateUnlock(VAddr mutex_addr) {
269 NGLOG_TRACE(Kernel_SVC, "called mutex_addr={:#X}", mutex_addr); 269 NGLOG_TRACE(Kernel_SVC, "called mutex_addr=0x{:X}", mutex_addr);
270 270
271 return Mutex::Release(mutex_addr); 271 return Mutex::Release(mutex_addr);
272} 272}
@@ -286,7 +286,7 @@ static void OutputDebugString(VAddr address, s32 len) {
286 286
287/// Gets system/memory information for the current process 287/// Gets system/memory information for the current process
288static ResultCode GetInfo(u64* result, u64 info_id, u64 handle, u64 info_sub_id) { 288static ResultCode GetInfo(u64* result, u64 info_id, u64 handle, u64 info_sub_id) {
289 NGLOG_TRACE(Kernel_SVC, "called info_id={:#X}, info_sub_id={:#X}, handle={:#010X}", info_id, 289 NGLOG_TRACE(Kernel_SVC, "called info_id=0x{:X}, info_sub_id=0x{:X}, handle=0x{:08X}", info_id,
290 info_sub_id, handle); 290 info_sub_id, handle);
291 291
292 auto& vm_manager = Core::CurrentProcess()->vm_manager; 292 auto& vm_manager = Core::CurrentProcess()->vm_manager;
@@ -355,14 +355,14 @@ static ResultCode GetInfo(u64* result, u64 info_id, u64 handle, u64 info_sub_id)
355 355
356/// Sets the thread activity 356/// Sets the thread activity
357static ResultCode SetThreadActivity(Handle handle, u32 unknown) { 357static ResultCode SetThreadActivity(Handle handle, u32 unknown) {
358 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called, handle={:#010X}, unknown={:#010X}", handle, 358 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called, handle=0x{:08X}, unknown=0x{:08X}", handle,
359 unknown); 359 unknown);
360 return RESULT_SUCCESS; 360 return RESULT_SUCCESS;
361} 361}
362 362
363/// Gets the thread context 363/// Gets the thread context
364static ResultCode GetThreadContext(Handle handle, VAddr addr) { 364static ResultCode GetThreadContext(Handle handle, VAddr addr) {
365 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called, handle={:#010X}, addr={:#X}", handle, addr); 365 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called, handle=0x{:08X}, addr=0x{:X}", handle, addr);
366 return RESULT_SUCCESS; 366 return RESULT_SUCCESS;
367} 367}
368 368
@@ -407,9 +407,10 @@ static u32 GetCurrentProcessorNumber() {
407 407
408static ResultCode MapSharedMemory(Handle shared_memory_handle, VAddr addr, u64 size, 408static ResultCode MapSharedMemory(Handle shared_memory_handle, VAddr addr, u64 size,
409 u32 permissions) { 409 u32 permissions) {
410 NGLOG_TRACE(Kernel_SVC, 410 NGLOG_TRACE(
411 "called, shared_memory_handle={:#X}, addr={:#X}, size={:#X}, permissions={:#010X}", 411 Kernel_SVC,
412 shared_memory_handle, addr, size, permissions); 412 "called, shared_memory_handle=0x{:X}, addr=0x{:X}, size=0x{:X}, permissions=0x{:08X}",
413 shared_memory_handle, addr, size, permissions);
413 414
414 SharedPtr<SharedMemory> shared_memory = g_handle_table.Get<SharedMemory>(shared_memory_handle); 415 SharedPtr<SharedMemory> shared_memory = g_handle_table.Get<SharedMemory>(shared_memory_handle);
415 if (!shared_memory) { 416 if (!shared_memory) {
@@ -429,14 +430,14 @@ static ResultCode MapSharedMemory(Handle shared_memory_handle, VAddr addr, u64 s
429 return shared_memory->Map(Core::CurrentProcess().get(), addr, permissions_type, 430 return shared_memory->Map(Core::CurrentProcess().get(), addr, permissions_type,
430 MemoryPermission::DontCare); 431 MemoryPermission::DontCare);
431 default: 432 default:
432 NGLOG_ERROR(Kernel_SVC, "unknown permissions={:#010X}", permissions); 433 NGLOG_ERROR(Kernel_SVC, "unknown permissions=0x{:08X}", permissions);
433 } 434 }
434 435
435 return RESULT_SUCCESS; 436 return RESULT_SUCCESS;
436} 437}
437 438
438static ResultCode UnmapSharedMemory(Handle shared_memory_handle, VAddr addr, u64 size) { 439static ResultCode UnmapSharedMemory(Handle shared_memory_handle, VAddr addr, u64 size) {
439 NGLOG_WARNING(Kernel_SVC, "called, shared_memory_handle={:#010X}, addr={:#X}, size={:#X}", 440 NGLOG_WARNING(Kernel_SVC, "called, shared_memory_handle=0x{:08X}, addr=0x{:X}, size=0x{:X}",
440 shared_memory_handle, addr, size); 441 shared_memory_handle, addr, size);
441 442
442 SharedPtr<SharedMemory> shared_memory = g_handle_table.Get<SharedMemory>(shared_memory_handle); 443 SharedPtr<SharedMemory> shared_memory = g_handle_table.Get<SharedMemory>(shared_memory_handle);
@@ -465,7 +466,7 @@ static ResultCode QueryProcessMemory(MemoryInfo* memory_info, PageInfo* /*page_i
465 memory_info->type = static_cast<u32>(vma->second.meminfo_state); 466 memory_info->type = static_cast<u32>(vma->second.meminfo_state);
466 } 467 }
467 468
468 NGLOG_TRACE(Kernel_SVC, "called process={:#010X} addr={:X}", process_handle, addr); 469 NGLOG_TRACE(Kernel_SVC, "called process=0x{:08X} addr={:X}", process_handle, addr);
469 return RESULT_SUCCESS; 470 return RESULT_SUCCESS;
470} 471}
471 472
@@ -552,8 +553,8 @@ static ResultCode CreateThread(Handle* out_handle, VAddr entry_point, u64 arg, V
552 Core::System::GetInstance().PrepareReschedule(); 553 Core::System::GetInstance().PrepareReschedule();
553 554
554 NGLOG_TRACE(Kernel_SVC, 555 NGLOG_TRACE(Kernel_SVC,
555 "called entrypoint={:#010X} ({}), arg={:#010X}, stacktop={:#010X}, " 556 "called entrypoint=0x{:08X} ({}), arg=0x{:08X}, stacktop=0x{:08X}, "
556 "threadpriority={:#010X}, processorid={:#010X} : created handle={:#010X}", 557 "threadpriority=0x{:08X}, processorid=0x{:08X} : created handle=0x{:08X}",
557 entry_point, name, arg, stack_top, priority, processor_id, *out_handle); 558 entry_point, name, arg, stack_top, priority, processor_id, *out_handle);
558 559
559 return RESULT_SUCCESS; 560 return RESULT_SUCCESS;
@@ -561,7 +562,7 @@ static ResultCode CreateThread(Handle* out_handle, VAddr entry_point, u64 arg, V
561 562
562/// Starts the thread for the provided handle 563/// Starts the thread for the provided handle
563static ResultCode StartThread(Handle thread_handle) { 564static ResultCode StartThread(Handle thread_handle) {
564 NGLOG_TRACE(Kernel_SVC, "called thread={:#010X}", thread_handle); 565 NGLOG_TRACE(Kernel_SVC, "called thread=0x{:08X}", thread_handle);
565 566
566 const SharedPtr<Thread> thread = g_handle_table.Get<Thread>(thread_handle); 567 const SharedPtr<Thread> thread = g_handle_table.Get<Thread>(thread_handle);
567 if (!thread) { 568 if (!thread) {
@@ -575,7 +576,7 @@ static ResultCode StartThread(Handle thread_handle) {
575 576
576/// Called when a thread exits 577/// Called when a thread exits
577static void ExitThread() { 578static void ExitThread() {
578 NGLOG_TRACE(Kernel_SVC, "called, pc={:#010X}", Core::CPU().GetPC()); 579 NGLOG_TRACE(Kernel_SVC, "called, pc=0x{:08X}", Core::CPU().GetPC());
579 580
580 ExitCurrentThread(); 581 ExitCurrentThread();
581 Core::System::GetInstance().PrepareReschedule(); 582 Core::System::GetInstance().PrepareReschedule();
@@ -604,7 +605,7 @@ static ResultCode WaitProcessWideKeyAtomic(VAddr mutex_addr, VAddr condition_var
604 Handle thread_handle, s64 nano_seconds) { 605 Handle thread_handle, s64 nano_seconds) {
605 NGLOG_TRACE( 606 NGLOG_TRACE(
606 Kernel_SVC, 607 Kernel_SVC,
607 "called mutex_addr={:X}, condition_variable_addr={:X}, thread_handle={:#010X}, timeout={}", 608 "called mutex_addr={:X}, condition_variable_addr={:X}, thread_handle=0x{:08X}, timeout={}",
608 mutex_addr, condition_variable_addr, thread_handle, nano_seconds); 609 mutex_addr, condition_variable_addr, thread_handle, nano_seconds);
609 610
610 SharedPtr<Thread> thread = g_handle_table.Get<Thread>(thread_handle); 611 SharedPtr<Thread> thread = g_handle_table.Get<Thread>(thread_handle);
@@ -629,7 +630,7 @@ static ResultCode WaitProcessWideKeyAtomic(VAddr mutex_addr, VAddr condition_var
629 630
630/// Signal process wide key 631/// Signal process wide key
631static ResultCode SignalProcessWideKey(VAddr condition_variable_addr, s32 target) { 632static ResultCode SignalProcessWideKey(VAddr condition_variable_addr, s32 target) {
632 NGLOG_TRACE(Kernel_SVC, "called, condition_variable_addr={:#X}, target={:#010X}", 633 NGLOG_TRACE(Kernel_SVC, "called, condition_variable_addr=0x{:X}, target=0x{:08X}",
633 condition_variable_addr, target); 634 condition_variable_addr, target);
634 635
635 u32 processed = 0; 636 u32 processed = 0;
@@ -696,13 +697,13 @@ static u64 GetSystemTick() {
696 697
697/// Close a handle 698/// Close a handle
698static ResultCode CloseHandle(Handle handle) { 699static ResultCode CloseHandle(Handle handle) {
699 NGLOG_TRACE(Kernel_SVC, "Closing handle {:#010X}", handle); 700 NGLOG_TRACE(Kernel_SVC, "Closing handle 0x{:08X}", handle);
700 return g_handle_table.Close(handle); 701 return g_handle_table.Close(handle);
701} 702}
702 703
703/// Reset an event 704/// Reset an event
704static ResultCode ResetSignal(Handle handle) { 705static ResultCode ResetSignal(Handle handle) {
705 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called handle {:#010X}", handle); 706 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called handle 0x{:08X}", handle);
706 auto event = g_handle_table.Get<Event>(handle); 707 auto event = g_handle_table.Get<Event>(handle);
707 ASSERT(event != nullptr); 708 ASSERT(event != nullptr);
708 event->Clear(); 709 event->Clear();
@@ -711,28 +712,28 @@ static ResultCode ResetSignal(Handle handle) {
711 712
712/// Creates a TransferMemory object 713/// Creates a TransferMemory object
713static ResultCode CreateTransferMemory(Handle* handle, VAddr addr, u64 size, u32 permissions) { 714static ResultCode CreateTransferMemory(Handle* handle, VAddr addr, u64 size, u32 permissions) {
714 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called addr={:#X}, size={:#X}, perms={:010X}", addr, size, 715 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called addr=0x{:X}, size=0x{:X}, perms=0x{:08X}", addr,
715 permissions); 716 size, permissions);
716 *handle = 0; 717 *handle = 0;
717 return RESULT_SUCCESS; 718 return RESULT_SUCCESS;
718} 719}
719 720
720static ResultCode GetThreadCoreMask(Handle handle, u32* mask, u64* unknown) { 721static ResultCode GetThreadCoreMask(Handle handle, u32* mask, u64* unknown) {
721 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called, handle={:010X}", handle); 722 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called, handle=0x{:08X}", handle);
722 *mask = 0x0; 723 *mask = 0x0;
723 *unknown = 0xf; 724 *unknown = 0xf;
724 return RESULT_SUCCESS; 725 return RESULT_SUCCESS;
725} 726}
726 727
727static ResultCode SetThreadCoreMask(Handle handle, u32 mask, u64 unknown) { 728static ResultCode SetThreadCoreMask(Handle handle, u32 mask, u64 unknown) {
728 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called, handle={:#010X}, mask={:#010X}, unknown={:#X}", 729 NGLOG_WARNING(Kernel_SVC, "(STUBBED) called, handle=0x{:08X}, mask=0x{:08X}, unknown=0x{:X}",
729 handle, mask, unknown); 730 handle, mask, unknown);
730 return RESULT_SUCCESS; 731 return RESULT_SUCCESS;
731} 732}
732 733
733static ResultCode CreateSharedMemory(Handle* handle, u64 size, u32 local_permissions, 734static ResultCode CreateSharedMemory(Handle* handle, u64 size, u32 local_permissions,
734 u32 remote_permissions) { 735 u32 remote_permissions) {
735 NGLOG_TRACE(Kernel_SVC, "called, size={:#X}, localPerms={:#010X}, remotePerms={:#010X}", size, 736 NGLOG_TRACE(Kernel_SVC, "called, size=0x{:X}, localPerms=0x{:08X}, remotePerms=0x{:08X}", size,
736 local_permissions, remote_permissions); 737 local_permissions, remote_permissions);
737 auto sharedMemHandle = 738 auto sharedMemHandle =
738 SharedMemory::Create(g_handle_table.Get<Process>(KernelHandle::CurrentProcess), size, 739 SharedMemory::Create(g_handle_table.Get<Process>(KernelHandle::CurrentProcess), size,
@@ -744,7 +745,7 @@ static ResultCode CreateSharedMemory(Handle* handle, u64 size, u32 local_permiss
744} 745}
745 746
746static ResultCode ClearEvent(Handle handle) { 747static ResultCode ClearEvent(Handle handle) {
747 NGLOG_TRACE(Kernel_SVC, "called, event={:010X}", handle); 748 NGLOG_TRACE(Kernel_SVC, "called, event=0x{:08X}", handle);
748 749
749 SharedPtr<Event> evt = g_handle_table.Get<Event>(handle); 750 SharedPtr<Event> evt = g_handle_table.Get<Event>(handle);
750 if (evt == nullptr) 751 if (evt == nullptr)
@@ -896,7 +897,7 @@ static const FunctionDef SVC_Table[] = {
896 897
897static const FunctionDef* GetSVCInfo(u32 func_num) { 898static const FunctionDef* GetSVCInfo(u32 func_num) {
898 if (func_num >= std::size(SVC_Table)) { 899 if (func_num >= std::size(SVC_Table)) {
899 NGLOG_ERROR(Kernel_SVC, "Unknown svc={:#04X}", func_num); 900 NGLOG_ERROR(Kernel_SVC, "Unknown svc=0x{:02X}", func_num);
900 return nullptr; 901 return nullptr;
901 } 902 }
902 return &SVC_Table[func_num]; 903 return &SVC_Table[func_num];
@@ -918,7 +919,7 @@ void CallSVC(u32 immediate) {
918 NGLOG_CRITICAL(Kernel_SVC, "Unimplemented SVC function {}(..)", info->name); 919 NGLOG_CRITICAL(Kernel_SVC, "Unimplemented SVC function {}(..)", info->name);
919 } 920 }
920 } else { 921 } else {
921 NGLOG_CRITICAL(Kernel_SVC, "Unknown SVC function {:#X}", immediate); 922 NGLOG_CRITICAL(Kernel_SVC, "Unknown SVC function 0x{:X}", immediate);
922 } 923 }
923} 924}
924 925
diff --git a/src/core/hle/kernel/vm_manager.cpp b/src/core/hle/kernel/vm_manager.cpp
index 06f143fb1..2f0044c11 100644
--- a/src/core/hle/kernel/vm_manager.cpp
+++ b/src/core/hle/kernel/vm_manager.cpp
@@ -243,8 +243,8 @@ VMManager::VMAIter VMManager::StripIterConstness(const VMAHandle& iter) {
243} 243}
244 244
245ResultVal<VMManager::VMAIter> VMManager::CarveVMA(VAddr base, u64 size) { 245ResultVal<VMManager::VMAIter> VMManager::CarveVMA(VAddr base, u64 size) {
246 ASSERT_MSG((size & Memory::PAGE_MASK) == 0, "non-page aligned size: {:#018X}", size); 246 ASSERT_MSG((size & Memory::PAGE_MASK) == 0, "non-page aligned size: 0x{:016X}", size);
247 ASSERT_MSG((base & Memory::PAGE_MASK) == 0, "non-page aligned base: {:#018X}", base); 247 ASSERT_MSG((base & Memory::PAGE_MASK) == 0, "non-page aligned base: 0x{:016X}", base);
248 248
249 VMAIter vma_handle = StripIterConstness(FindVMA(base)); 249 VMAIter vma_handle = StripIterConstness(FindVMA(base));
250 if (vma_handle == vma_map.end()) { 250 if (vma_handle == vma_map.end()) {
@@ -279,8 +279,8 @@ ResultVal<VMManager::VMAIter> VMManager::CarveVMA(VAddr base, u64 size) {
279} 279}
280 280
281ResultVal<VMManager::VMAIter> VMManager::CarveVMARange(VAddr target, u64 size) { 281ResultVal<VMManager::VMAIter> VMManager::CarveVMARange(VAddr target, u64 size) {
282 ASSERT_MSG((size & Memory::PAGE_MASK) == 0, "non-page aligned size: {:#018X}", size); 282 ASSERT_MSG((size & Memory::PAGE_MASK) == 0, "non-page aligned size: 0x{:016X}", size);
283 ASSERT_MSG((target & Memory::PAGE_MASK) == 0, "non-page aligned base: {:#018X}", target); 283 ASSERT_MSG((target & Memory::PAGE_MASK) == 0, "non-page aligned base: 0x{:016X}", target);
284 284
285 VAddr target_end = target + size; 285 VAddr target_end = target + size;
286 ASSERT(target_end >= target); 286 ASSERT(target_end >= target);
diff --git a/src/core/hle/service/am/am.cpp b/src/core/hle/service/am/am.cpp
index c123e7809..d93afbed7 100644
--- a/src/core/hle/service/am/am.cpp
+++ b/src/core/hle/service/am/am.cpp
@@ -534,7 +534,7 @@ void IApplicationFunctions::SetTerminateResult(Kernel::HLERequestContext& ctx) {
534 IPC::ResponseBuilder rb{ctx, 2}; 534 IPC::ResponseBuilder rb{ctx, 2};
535 rb.Push(RESULT_SUCCESS); 535 rb.Push(RESULT_SUCCESS);
536 536
537 NGLOG_WARNING(Service_AM, "(STUBBED) called, result={:#010}", result); 537 NGLOG_WARNING(Service_AM, "(STUBBED) called, result=0x{:08X}", result);
538} 538}
539 539
540void IApplicationFunctions::GetDesiredLanguage(Kernel::HLERequestContext& ctx) { 540void IApplicationFunctions::GetDesiredLanguage(Kernel::HLERequestContext& ctx) {
diff --git a/src/core/hle/service/fatal/fatal.cpp b/src/core/hle/service/fatal/fatal.cpp
index d7ad0600a..bb75e7314 100644
--- a/src/core/hle/service/fatal/fatal.cpp
+++ b/src/core/hle/service/fatal/fatal.cpp
@@ -16,7 +16,7 @@ Module::Interface::Interface(std::shared_ptr<Module> module, const char* name)
16void Module::Interface::FatalSimple(Kernel::HLERequestContext& ctx) { 16void Module::Interface::FatalSimple(Kernel::HLERequestContext& ctx) {
17 IPC::RequestParser rp(ctx); 17 IPC::RequestParser rp(ctx);
18 u32 error_code = rp.Pop<u32>(); 18 u32 error_code = rp.Pop<u32>();
19 NGLOG_WARNING(Service_Fatal, "(STUBBED) called, error_code={:#X}", error_code); 19 NGLOG_WARNING(Service_Fatal, "(STUBBED) called, error_code=0x{:X}", error_code);
20 IPC::ResponseBuilder rb{ctx, 2}; 20 IPC::ResponseBuilder rb{ctx, 2};
21 rb.Push(RESULT_SUCCESS); 21 rb.Push(RESULT_SUCCESS);
22} 22}
diff --git a/src/core/hle/service/filesystem/filesystem.cpp b/src/core/hle/service/filesystem/filesystem.cpp
index c2951c560..68d1c90a5 100644
--- a/src/core/hle/service/filesystem/filesystem.cpp
+++ b/src/core/hle/service/filesystem/filesystem.cpp
@@ -25,7 +25,7 @@ ResultCode RegisterFileSystem(std::unique_ptr<FileSys::FileSystemFactory>&& fact
25 ASSERT_MSG(inserted, "Tried to register more than one system with same id code"); 25 ASSERT_MSG(inserted, "Tried to register more than one system with same id code");
26 26
27 auto& filesystem = result.first->second; 27 auto& filesystem = result.first->second;
28 NGLOG_DEBUG(Service_FS, "Registered file system {} with id code {:#010X}", 28 NGLOG_DEBUG(Service_FS, "Registered file system {} with id code 0x{:08X}",
29 filesystem->GetName(), static_cast<u32>(type)); 29 filesystem->GetName(), static_cast<u32>(type));
30 return RESULT_SUCCESS; 30 return RESULT_SUCCESS;
31} 31}
diff --git a/src/core/hle/service/filesystem/fsp_srv.cpp b/src/core/hle/service/filesystem/fsp_srv.cpp
index ed9f2ef72..8a47bb7af 100644
--- a/src/core/hle/service/filesystem/fsp_srv.cpp
+++ b/src/core/hle/service/filesystem/fsp_srv.cpp
@@ -35,7 +35,7 @@ private:
35 const s64 offset = rp.Pop<s64>(); 35 const s64 offset = rp.Pop<s64>();
36 const s64 length = rp.Pop<s64>(); 36 const s64 length = rp.Pop<s64>();
37 37
38 NGLOG_DEBUG(Service_FS, "called, offset={:#X}, length={}", offset, length); 38 NGLOG_DEBUG(Service_FS, "called, offset=0x{:X}, length={}", offset, length);
39 39
40 // Error checking 40 // Error checking
41 if (length < 0) { 41 if (length < 0) {
@@ -87,7 +87,7 @@ private:
87 const s64 offset = rp.Pop<s64>(); 87 const s64 offset = rp.Pop<s64>();
88 const s64 length = rp.Pop<s64>(); 88 const s64 length = rp.Pop<s64>();
89 89
90 NGLOG_DEBUG(Service_FS, "called, offset={:#X}, length={}", offset, length); 90 NGLOG_DEBUG(Service_FS, "called, offset=0x{:X}, length={}", offset, length);
91 91
92 // Error checking 92 // Error checking
93 if (length < 0) { 93 if (length < 0) {
@@ -124,7 +124,7 @@ private:
124 const s64 offset = rp.Pop<s64>(); 124 const s64 offset = rp.Pop<s64>();
125 const s64 length = rp.Pop<s64>(); 125 const s64 length = rp.Pop<s64>();
126 126
127 NGLOG_DEBUG(Service_FS, "called, offset={:#X}, length={}", offset, length); 127 NGLOG_DEBUG(Service_FS, "called, offset=0x{:X}, length={}", offset, length);
128 128
129 // Error checking 129 // Error checking
130 if (length < 0) { 130 if (length < 0) {
@@ -197,7 +197,7 @@ private:
197 IPC::RequestParser rp{ctx}; 197 IPC::RequestParser rp{ctx};
198 const u64 unk = rp.Pop<u64>(); 198 const u64 unk = rp.Pop<u64>();
199 199
200 NGLOG_DEBUG(Service_FS, "called, unk={:#X}", unk); 200 NGLOG_DEBUG(Service_FS, "called, unk=0x{:X}", unk);
201 201
202 // Calculate how many entries we can fit in the output buffer 202 // Calculate how many entries we can fit in the output buffer
203 u64 count_entries = ctx.GetWriteBufferSize() / sizeof(FileSys::Entry); 203 u64 count_entries = ctx.GetWriteBufferSize() / sizeof(FileSys::Entry);
@@ -265,7 +265,7 @@ public:
265 u64 mode = rp.Pop<u64>(); 265 u64 mode = rp.Pop<u64>();
266 u32 size = rp.Pop<u32>(); 266 u32 size = rp.Pop<u32>();
267 267
268 NGLOG_DEBUG(Service_FS, "called file {} mode {:#X} size {:#010X}", name, mode, size); 268 NGLOG_DEBUG(Service_FS, "called file {} mode 0x{:X} size 0x{:08X}", name, mode, size);
269 269
270 IPC::ResponseBuilder rb{ctx, 2}; 270 IPC::ResponseBuilder rb{ctx, 2};
271 rb.Push(backend->CreateFile(name, size)); 271 rb.Push(backend->CreateFile(name, size));
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp
index a7097bd23..cb4913b07 100644
--- a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp
+++ b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp
@@ -12,7 +12,7 @@
12namespace Service::Nvidia::Devices { 12namespace Service::Nvidia::Devices {
13 13
14u32 nvhost_as_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) { 14u32 nvhost_as_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) {
15 NGLOG_DEBUG(Service_NVDRV, "called, command={:#010X}, input_size={:#X}, output_size={:#X}", 15 NGLOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}",
16 command.raw, input.size(), output.size()); 16 command.raw, input.size(), output.size());
17 17
18 switch (static_cast<IoctlCommand>(command.raw)) { 18 switch (static_cast<IoctlCommand>(command.raw)) {
@@ -38,7 +38,7 @@ u32 nvhost_as_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vecto
38u32 nvhost_as_gpu::InitalizeEx(const std::vector<u8>& input, std::vector<u8>& output) { 38u32 nvhost_as_gpu::InitalizeEx(const std::vector<u8>& input, std::vector<u8>& output) {
39 IoctlInitalizeEx params{}; 39 IoctlInitalizeEx params{};
40 std::memcpy(&params, input.data(), input.size()); 40 std::memcpy(&params, input.data(), input.size());
41 NGLOG_WARNING(Service_NVDRV, "(STUBBED) called, big_page_size={:#X}", params.big_page_size); 41 NGLOG_WARNING(Service_NVDRV, "(STUBBED) called, big_page_size=0x{:X}", params.big_page_size);
42 return 0; 42 return 0;
43} 43}
44 44
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp b/src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp
index 46f0b6862..edd3f8538 100644
--- a/src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp
+++ b/src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp
@@ -9,7 +9,7 @@
9namespace Service::Nvidia::Devices { 9namespace Service::Nvidia::Devices {
10 10
11u32 nvhost_ctrl::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) { 11u32 nvhost_ctrl::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) {
12 NGLOG_DEBUG(Service_NVDRV, "called, command={:#010X}, input_size={:#X}, output_size={:#X}", 12 NGLOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}",
13 command.raw, input.size(), output.size()); 13 command.raw, input.size(), output.size());
14 14
15 switch (static_cast<IoctlCommand>(command.raw)) { 15 switch (static_cast<IoctlCommand>(command.raw)) {
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp b/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp
index 3c78ecaea..d5558f29f 100644
--- a/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp
+++ b/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp
@@ -10,7 +10,7 @@
10namespace Service::Nvidia::Devices { 10namespace Service::Nvidia::Devices {
11 11
12u32 nvhost_ctrl_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) { 12u32 nvhost_ctrl_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) {
13 NGLOG_DEBUG(Service_NVDRV, "called, command={:#010X}, input_size={:#X}, output_size={:#X}", 13 NGLOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}",
14 command.raw, input.size(), output.size()); 14 command.raw, input.size(), output.size());
15 15
16 switch (static_cast<IoctlCommand>(command.raw)) { 16 switch (static_cast<IoctlCommand>(command.raw)) {
@@ -77,7 +77,7 @@ u32 nvhost_ctrl_gpu::GetCharacteristics(const std::vector<u8>& input, std::vecto
77u32 nvhost_ctrl_gpu::GetTPCMasks(const std::vector<u8>& input, std::vector<u8>& output) { 77u32 nvhost_ctrl_gpu::GetTPCMasks(const std::vector<u8>& input, std::vector<u8>& output) {
78 IoctlGpuGetTpcMasksArgs params{}; 78 IoctlGpuGetTpcMasksArgs params{};
79 std::memcpy(&params, input.data(), input.size()); 79 std::memcpy(&params, input.data(), input.size());
80 NGLOG_WARNING(Service_NVDRV, "(STUBBED) called, mask={:#X}, mask_buf_addr={:#X}", 80 NGLOG_WARNING(Service_NVDRV, "(STUBBED) called, mask=0x{:X}, mask_buf_addr=0x{:X}",
81 params.mask_buf_size, params.mask_buf_addr); 81 params.mask_buf_size, params.mask_buf_addr);
82 params.unk = 0xcafe; // TODO(ogniK): Needs to be non 0, what does this actually do? 82 params.unk = 0xcafe; // TODO(ogniK): Needs to be non 0, what does this actually do?
83 std::memcpy(output.data(), &params, sizeof(params)); 83 std::memcpy(output.data(), &params, sizeof(params));
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp b/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp
index 9fee7d564..25e3ccef6 100644
--- a/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp
+++ b/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp
@@ -12,7 +12,7 @@
12namespace Service::Nvidia::Devices { 12namespace Service::Nvidia::Devices {
13 13
14u32 nvhost_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) { 14u32 nvhost_gpu::ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) {
15 NGLOG_DEBUG(Service_NVDRV, "called, command={:#010X}, input_size={:#X}, output_size={:#X}", 15 NGLOG_DEBUG(Service_NVDRV, "called, command=0x{:08X}, input_size=0x{:X}, output_size=0x{:X}",
16 command.raw, input.size(), output.size()); 16 command.raw, input.size(), output.size());
17 17
18 switch (static_cast<IoctlCommand>(command.raw)) { 18 switch (static_cast<IoctlCommand>(command.raw)) {
diff --git a/src/core/hle/service/nvdrv/devices/nvmap.cpp b/src/core/hle/service/nvdrv/devices/nvmap.cpp
index 11df8849d..8d883209f 100644
--- a/src/core/hle/service/nvdrv/devices/nvmap.cpp
+++ b/src/core/hle/service/nvdrv/devices/nvmap.cpp
@@ -49,7 +49,7 @@ u32 nvmap::IocCreate(const std::vector<u8>& input, std::vector<u8>& output) {
49 u32 handle = next_handle++; 49 u32 handle = next_handle++;
50 handles[handle] = std::move(object); 50 handles[handle] = std::move(object);
51 51
52 NGLOG_DEBUG(Service_NVDRV, "size={:#010X}", params.size); 52 NGLOG_DEBUG(Service_NVDRV, "size=0x{:08X}", params.size);
53 53
54 params.handle = handle; 54 params.handle = handle;
55 55
diff --git a/src/core/hle/service/nvdrv/interface.cpp b/src/core/hle/service/nvdrv/interface.cpp
index 38b3a9a84..45d2862ef 100644
--- a/src/core/hle/service/nvdrv/interface.cpp
+++ b/src/core/hle/service/nvdrv/interface.cpp
@@ -75,7 +75,7 @@ void NVDRV::SetClientPID(Kernel::HLERequestContext& ctx) {
75 IPC::RequestParser rp{ctx}; 75 IPC::RequestParser rp{ctx};
76 pid = rp.Pop<u64>(); 76 pid = rp.Pop<u64>();
77 77
78 NGLOG_WARNING(Service_NVDRV, "(STUBBED) called, pid={:#X}", pid); 78 NGLOG_WARNING(Service_NVDRV, "(STUBBED) called, pid=0x{:X}", pid);
79 IPC::ResponseBuilder rb{ctx, 3}; 79 IPC::ResponseBuilder rb{ctx, 3};
80 rb.Push(RESULT_SUCCESS); 80 rb.Push(RESULT_SUCCESS);
81 rb.Push<u32>(0); 81 rb.Push<u32>(0);
diff --git a/src/core/hle/service/service.cpp b/src/core/hle/service/service.cpp
index 7a5f08b24..dc30702c6 100644
--- a/src/core/hle/service/service.cpp
+++ b/src/core/hle/service/service.cpp
@@ -60,7 +60,7 @@ static std::string MakeFunctionString(const char* name, const char* port_name,
60 60
61 std::string function_string = fmt::format("function '{}': port={}", name, port_name); 61 std::string function_string = fmt::format("function '{}': port={}", name, port_name);
62 for (int i = 1; i <= num_params; ++i) { 62 for (int i = 1; i <= num_params; ++i) {
63 function_string += fmt::format(", cmd_buff[{}]={:#X}", i, cmd_buff[i]); 63 function_string += fmt::format(", cmd_buff[{}]=0x{:X}", i, cmd_buff[i]);
64 } 64 }
65 return function_string; 65 return function_string;
66} 66}
@@ -113,10 +113,10 @@ void ServiceFrameworkBase::ReportUnimplementedFunction(Kernel::HLERequestContext
113 std::string function_name = info == nullptr ? fmt::format("{}", ctx.GetCommand()) : info->name; 113 std::string function_name = info == nullptr ? fmt::format("{}", ctx.GetCommand()) : info->name;
114 114
115 fmt::memory_buffer buf; 115 fmt::memory_buffer buf;
116 fmt::format_to(buf, "function '{}': port='{}' cmd_buf={{[0]={:#x}", function_name, service_name, 116 fmt::format_to(buf, "function '{}': port='{}' cmd_buf={{[0]=0x{:X}", function_name,
117 cmd_buf[0]); 117 service_name, cmd_buf[0]);
118 for (int i = 1; i <= 8; ++i) { 118 for (int i = 1; i <= 8; ++i) {
119 fmt::format_to(buf, ", [{}]={:#x}", i, cmd_buf[i]); 119 fmt::format_to(buf, ", [{}]=0x{:X}", i, cmd_buf[i]);
120 } 120 }
121 buf.push_back('}'); 121 buf.push_back('}');
122 122
diff --git a/src/core/hle/service/sm/sm.cpp b/src/core/hle/service/sm/sm.cpp
index 073277ade..bded8421f 100644
--- a/src/core/hle/service/sm/sm.cpp
+++ b/src/core/hle/service/sm/sm.cpp
@@ -102,7 +102,7 @@ void SM::GetService(Kernel::HLERequestContext& ctx) {
102 if (client_port.Failed()) { 102 if (client_port.Failed()) {
103 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0); 103 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0);
104 rb.Push(client_port.Code()); 104 rb.Push(client_port.Code());
105 NGLOG_ERROR(Service_SM, "called service={} -> error {:#010X}", name, 105 NGLOG_ERROR(Service_SM, "called service={} -> error 0x{:08X}", name,
106 client_port.Code().raw); 106 client_port.Code().raw);
107 if (name.length() == 0) 107 if (name.length() == 0)
108 return; // LibNX Fix 108 return; // LibNX Fix
diff --git a/src/core/hle/service/time/time.cpp b/src/core/hle/service/time/time.cpp
index e50680356..2eb37fb42 100644
--- a/src/core/hle/service/time/time.cpp
+++ b/src/core/hle/service/time/time.cpp
@@ -111,7 +111,7 @@ private:
111 IPC::RequestParser rp{ctx}; 111 IPC::RequestParser rp{ctx};
112 u64 posix_time = rp.Pop<u64>(); 112 u64 posix_time = rp.Pop<u64>();
113 113
114 NGLOG_WARNING(Service_Time, "(STUBBED) called, posix_time={:#018X}", posix_time); 114 NGLOG_WARNING(Service_Time, "(STUBBED) called, posix_time=0x{:016X}", posix_time);
115 115
116 CalendarTime calendar_time{2018, 1, 1, 0, 0, 0}; 116 CalendarTime calendar_time{2018, 1, 1, 0, 0, 0};
117 CalendarAdditionalInfo additional_info{}; 117 CalendarAdditionalInfo additional_info{};
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp
index 45f3568d2..e86556671 100644
--- a/src/core/hle/service/vi/vi.cpp
+++ b/src/core/hle/service/vi/vi.cpp
@@ -640,7 +640,7 @@ private:
640 bool visibility = rp.Pop<bool>(); 640 bool visibility = rp.Pop<bool>();
641 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0); 641 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0);
642 rb.Push(RESULT_SUCCESS); 642 rb.Push(RESULT_SUCCESS);
643 NGLOG_WARNING(Service_VI, "(STUBBED) called, layer_id={:#010X}, visibility={}", layer_id, 643 NGLOG_WARNING(Service_VI, "(STUBBED) called, layer_id=0x{:08X}, visibility={}", layer_id,
644 visibility); 644 visibility);
645 } 645 }
646}; 646};
@@ -762,7 +762,7 @@ private:
762 bool visibility = rp.Pop<bool>(); 762 bool visibility = rp.Pop<bool>();
763 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0); 763 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0);
764 rb.Push(RESULT_SUCCESS); 764 rb.Push(RESULT_SUCCESS);
765 NGLOG_WARNING(Service_VI, "(STUBBED) called, layer_id={:#X}, visibility={}", layer_id, 765 NGLOG_WARNING(Service_VI, "(STUBBED) called, layer_id=0x{:X}, visibility={}", layer_id,
766 visibility); 766 visibility);
767 } 767 }
768 768
diff --git a/src/core/hw/hw.cpp b/src/core/hw/hw.cpp
index f8a40390a..8fc91dc9c 100644
--- a/src/core/hw/hw.cpp
+++ b/src/core/hw/hw.cpp
@@ -33,7 +33,7 @@ inline void Read(T& var, const u32 addr) {
33 LCD::Read(var, addr); 33 LCD::Read(var, addr);
34 break; 34 break;
35 default: 35 default:
36 NGLOG_ERROR(HW_Memory, "Unknown Read{} @ {:#010X}", sizeof(var) * 8, addr); 36 NGLOG_ERROR(HW_Memory, "Unknown Read{} @ 0x{:08X}", sizeof(var) * 8, addr);
37 break; 37 break;
38 } 38 }
39} 39}
@@ -62,7 +62,7 @@ inline void Write(u32 addr, const T data) {
62 LCD::Write(addr, data); 62 LCD::Write(addr, data);
63 break; 63 break;
64 default: 64 default:
65 NGLOG_ERROR(HW_Memory, "Unknown Write{} {:#010X} @ {:#010X}", sizeof(data) * 8, data, addr); 65 NGLOG_ERROR(HW_Memory, "Unknown Write{} 0x{:08X} @ 0x{:08X}", sizeof(data) * 8, data, addr);
66 break; 66 break;
67 } 67 }
68} 68}
diff --git a/src/core/hw/lcd.cpp b/src/core/hw/lcd.cpp
index 7d0046bf3..e8525efde 100644
--- a/src/core/hw/lcd.cpp
+++ b/src/core/hw/lcd.cpp
@@ -20,7 +20,7 @@ inline void Read(T& var, const u32 raw_addr) {
20 20
21 // Reads other than u32 are untested, so I'd rather have them abort than silently fail 21 // Reads other than u32 are untested, so I'd rather have them abort than silently fail
22 if (index >= 0x400 || !std::is_same<T, u32>::value) { 22 if (index >= 0x400 || !std::is_same<T, u32>::value) {
23 NGLOG_ERROR(HW_LCD, "Unknown Read{} @ {:#010X}", sizeof(var) * 8, addr); 23 NGLOG_ERROR(HW_LCD, "Unknown Read{} @ 0x{:08X}", sizeof(var) * 8, addr);
24 return; 24 return;
25 } 25 }
26 26
@@ -34,7 +34,7 @@ inline void Write(u32 addr, const T data) {
34 34
35 // Writes other than u32 are untested, so I'd rather have them abort than silently fail 35 // Writes other than u32 are untested, so I'd rather have them abort than silently fail
36 if (index >= 0x400 || !std::is_same<T, u32>::value) { 36 if (index >= 0x400 || !std::is_same<T, u32>::value) {
37 NGLOG_ERROR(HW_LCD, "Unknown Write{} {:#010X} @ {:#010X}", sizeof(data) * 8, data, addr); 37 NGLOG_ERROR(HW_LCD, "Unknown Write{} 0x{:08X} @ 0x{:08X}", sizeof(data) * 8, data, addr);
38 return; 38 return;
39 } 39 }
40 40
diff --git a/src/core/loader/deconstructed_rom_directory.cpp b/src/core/loader/deconstructed_rom_directory.cpp
index 40a81025f..b01b2caf6 100644
--- a/src/core/loader/deconstructed_rom_directory.cpp
+++ b/src/core/loader/deconstructed_rom_directory.cpp
@@ -132,7 +132,7 @@ ResultStatus AppLoader_DeconstructedRomDirectory::Load(
132 const VAddr load_addr = next_load_addr; 132 const VAddr load_addr = next_load_addr;
133 next_load_addr = AppLoader_NSO::LoadModule(path, load_addr); 133 next_load_addr = AppLoader_NSO::LoadModule(path, load_addr);
134 if (next_load_addr) { 134 if (next_load_addr) {
135 NGLOG_DEBUG(Loader, "loaded module {} @ {:#X}", module, load_addr); 135 NGLOG_DEBUG(Loader, "loaded module {} @ 0x{:X}", module, load_addr);
136 } else { 136 } else {
137 next_load_addr = load_addr; 137 next_load_addr = load_addr;
138 } 138 }
@@ -176,8 +176,8 @@ ResultStatus AppLoader_DeconstructedRomDirectory::ReadRomFS(
176 offset = 0; 176 offset = 0;
177 size = romfs_file->GetSize(); 177 size = romfs_file->GetSize();
178 178
179 NGLOG_DEBUG(Loader, "RomFS offset: {:#018X}", offset); 179 NGLOG_DEBUG(Loader, "RomFS offset: 0x{:016X}", offset);
180 NGLOG_DEBUG(Loader, "RomFS size: {:#018X}", size); 180 NGLOG_DEBUG(Loader, "RomFS size: 0x{:016X}", size);
181 181
182 // Reset read pointer 182 // Reset read pointer
183 file.Seek(0, SEEK_SET); 183 file.Seek(0, SEEK_SET);
diff --git a/src/core/loader/nso.cpp b/src/core/loader/nso.cpp
index 138883cc9..01be9e217 100644
--- a/src/core/loader/nso.cpp
+++ b/src/core/loader/nso.cpp
@@ -158,7 +158,7 @@ ResultStatus AppLoader_NSO::Load(Kernel::SharedPtr<Kernel::Process>& process) {
158 158
159 // Load module 159 // Load module
160 LoadModule(filepath, Memory::PROCESS_IMAGE_VADDR); 160 LoadModule(filepath, Memory::PROCESS_IMAGE_VADDR);
161 NGLOG_DEBUG(Loader, "loaded module {} @ {:#X}", filepath, Memory::PROCESS_IMAGE_VADDR); 161 NGLOG_DEBUG(Loader, "loaded module {} @ 0x{:X}", filepath, Memory::PROCESS_IMAGE_VADDR);
162 162
163 process->svc_access_mask.set(); 163 process->svc_access_mask.set();
164 process->address_mappings = default_address_mappings; 164 process->address_mappings = default_address_mappings;
diff --git a/src/core/memory.cpp b/src/core/memory.cpp
index 5a27fa902..db8211463 100644
--- a/src/core/memory.cpp
+++ b/src/core/memory.cpp
@@ -168,7 +168,7 @@ T Read(const VAddr vaddr) {
168 PageType type = current_page_table->attributes[vaddr >> PAGE_BITS]; 168 PageType type = current_page_table->attributes[vaddr >> PAGE_BITS];
169 switch (type) { 169 switch (type) {
170 case PageType::Unmapped: 170 case PageType::Unmapped:
171 NGLOG_ERROR(HW_Memory, "Unmapped Read{} @ {:#010X}", sizeof(T) * 8, vaddr); 171 NGLOG_ERROR(HW_Memory, "Unmapped Read{} @ 0x{:08X}", sizeof(T) * 8, vaddr);
172 return 0; 172 return 0;
173 case PageType::Memory: 173 case PageType::Memory:
174 ASSERT_MSG(false, "Mapped memory page without a pointer @ {:016X}", vaddr); 174 ASSERT_MSG(false, "Mapped memory page without a pointer @ {:016X}", vaddr);
@@ -200,8 +200,8 @@ void Write(const VAddr vaddr, const T data) {
200 PageType type = current_page_table->attributes[vaddr >> PAGE_BITS]; 200 PageType type = current_page_table->attributes[vaddr >> PAGE_BITS];
201 switch (type) { 201 switch (type) {
202 case PageType::Unmapped: 202 case PageType::Unmapped:
203 NGLOG_ERROR(HW_Memory, "Unmapped Write{} {:#010X} @ {:#018X}", sizeof(data) * 8, (u32)data, 203 NGLOG_ERROR(HW_Memory, "Unmapped Write{} 0x{:08X} @ 0x{:016X}", sizeof(data) * 8,
204 vaddr); 204 static_cast<u32>(data), vaddr);
205 return; 205 return;
206 case PageType::Memory: 206 case PageType::Memory:
207 ASSERT_MSG(false, "Mapped memory page without a pointer @ {:016X}", vaddr); 207 ASSERT_MSG(false, "Mapped memory page without a pointer @ {:016X}", vaddr);
@@ -250,7 +250,7 @@ u8* GetPointer(const VAddr vaddr) {
250 return GetPointerFromVMA(vaddr); 250 return GetPointerFromVMA(vaddr);
251 } 251 }
252 252
253 NGLOG_ERROR(HW_Memory, "Unknown GetPointer @ {:#018X}", vaddr); 253 NGLOG_ERROR(HW_Memory, "Unknown GetPointer @ 0x{:016X}", vaddr);
254 return nullptr; 254 return nullptr;
255} 255}
256 256
@@ -287,12 +287,12 @@ u8* GetPhysicalPointer(PAddr address) {
287 }); 287 });
288 288
289 if (area == std::end(memory_areas)) { 289 if (area == std::end(memory_areas)) {
290 NGLOG_ERROR(HW_Memory, "Unknown GetPhysicalPointer @ {:#018X}", address); 290 NGLOG_ERROR(HW_Memory, "Unknown GetPhysicalPointer @ 0x{:016X}", address);
291 return nullptr; 291 return nullptr;
292 } 292 }
293 293
294 if (area->paddr_base == IO_AREA_PADDR) { 294 if (area->paddr_base == IO_AREA_PADDR) {
295 NGLOG_ERROR(HW_Memory, "MMIO mappings are not supported yet. phys_addr={:018X}", address); 295 NGLOG_ERROR(HW_Memory, "MMIO mappings are not supported yet. phys_addr={:016X}", address);
296 return nullptr; 296 return nullptr;
297 } 297 }
298 298
@@ -476,7 +476,7 @@ void ReadBlock(const Kernel::Process& process, const VAddr src_addr, void* dest_
476 switch (page_table.attributes[page_index]) { 476 switch (page_table.attributes[page_index]) {
477 case PageType::Unmapped: { 477 case PageType::Unmapped: {
478 NGLOG_ERROR(HW_Memory, 478 NGLOG_ERROR(HW_Memory,
479 "Unmapped ReadBlock @ {:#018X} (start address = {:#018X}, size = {})", 479 "Unmapped ReadBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})",
480 current_vaddr, src_addr, size); 480 current_vaddr, src_addr, size);
481 std::memset(dest_buffer, 0, copy_amount); 481 std::memset(dest_buffer, 0, copy_amount);
482 break; 482 break;
@@ -540,7 +540,7 @@ void WriteBlock(const Kernel::Process& process, const VAddr dest_addr, const voi
540 switch (page_table.attributes[page_index]) { 540 switch (page_table.attributes[page_index]) {
541 case PageType::Unmapped: { 541 case PageType::Unmapped: {
542 NGLOG_ERROR(HW_Memory, 542 NGLOG_ERROR(HW_Memory,
543 "Unmapped WriteBlock @ {:#018X} (start address = {:#018X}, size = {})", 543 "Unmapped WriteBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})",
544 current_vaddr, dest_addr, size); 544 current_vaddr, dest_addr, size);
545 break; 545 break;
546 } 546 }
@@ -588,7 +588,7 @@ void ZeroBlock(const Kernel::Process& process, const VAddr dest_addr, const size
588 switch (page_table.attributes[page_index]) { 588 switch (page_table.attributes[page_index]) {
589 case PageType::Unmapped: { 589 case PageType::Unmapped: {
590 NGLOG_ERROR(HW_Memory, 590 NGLOG_ERROR(HW_Memory,
591 "Unmapped ZeroBlock @ {:#018X} (start address = {#:018X}, size = {})", 591 "Unmapped ZeroBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})",
592 current_vaddr, dest_addr, size); 592 current_vaddr, dest_addr, size);
593 break; 593 break;
594 } 594 }
@@ -629,7 +629,7 @@ void CopyBlock(const Kernel::Process& process, VAddr dest_addr, VAddr src_addr,
629 switch (page_table.attributes[page_index]) { 629 switch (page_table.attributes[page_index]) {
630 case PageType::Unmapped: { 630 case PageType::Unmapped: {
631 NGLOG_ERROR(HW_Memory, 631 NGLOG_ERROR(HW_Memory,
632 "Unmapped CopyBlock @ {:#018X} (start address = {:#018X}, size = {})", 632 "Unmapped CopyBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})",
633 current_vaddr, src_addr, size); 633 current_vaddr, src_addr, size);
634 ZeroBlock(process, dest_addr, copy_amount); 634 ZeroBlock(process, dest_addr, copy_amount);
635 break; 635 break;
@@ -683,7 +683,7 @@ boost::optional<PAddr> TryVirtualToPhysicalAddress(const VAddr addr) {
683PAddr VirtualToPhysicalAddress(const VAddr addr) { 683PAddr VirtualToPhysicalAddress(const VAddr addr) {
684 auto paddr = TryVirtualToPhysicalAddress(addr); 684 auto paddr = TryVirtualToPhysicalAddress(addr);
685 if (!paddr) { 685 if (!paddr) {
686 NGLOG_ERROR(HW_Memory, "Unknown virtual address @ {:#018X}", addr); 686 NGLOG_ERROR(HW_Memory, "Unknown virtual address @ 0x{:016X}", addr);
687 // To help with debugging, set bit on address so that it's obviously invalid. 687 // To help with debugging, set bit on address so that it's obviously invalid.
688 return addr | 0x80000000; 688 return addr | 0x80000000;
689 } 689 }
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.cpp b/src/video_core/renderer_opengl/gl_rasterizer.cpp
index 9b3542e10..907236136 100644
--- a/src/video_core/renderer_opengl/gl_rasterizer.cpp
+++ b/src/video_core/renderer_opengl/gl_rasterizer.cpp
@@ -252,7 +252,7 @@ void RasterizerOpenGL::SetupShaders(u8* buffer_ptr, GLintptr buffer_offset) {
252 break; 252 break;
253 } 253 }
254 default: 254 default:
255 NGLOG_CRITICAL(HW_GPU, "Unimplemented shader index={}, enable={}, offset={:#010X}", 255 NGLOG_CRITICAL(HW_GPU, "Unimplemented shader index={}, enable={}, offset=0x{:08X}",
256 index, shader_config.enable.Value(), shader_config.offset); 256 index, shader_config.enable.Value(), shader_config.offset);
257 UNREACHABLE(); 257 UNREACHABLE();
258 } 258 }