summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorGravatar Lioncash2019-06-05 15:47:42 -0400
committerGravatar Lioncash2019-06-05 15:49:23 -0400
commit5b932901834b4d81d414b1845e2977a58984ecab (patch)
treee66a1775c2c4c23191896e2036abb46b26e38a19 /src
parentyuzu/CMakeLists: Disable implicit type narrowing in connect() calls (diff)
downloadyuzu-5b932901834b4d81d414b1845e2977a58984ecab.tar.gz
yuzu-5b932901834b4d81d414b1845e2977a58984ecab.tar.xz
yuzu-5b932901834b4d81d414b1845e2977a58984ecab.zip
yuzu/CMakeLists: Disable unsafe overloads of QProcess' start() function
Other overloads of start() are considerably much safer to use if we ever need this in the future and need to pass arguments to the program, given it contains separate parameters for the program path and the arguments themselves, whereas this unsafe overload contains both as a single string. Given the alternatives are much safer, we can disable this.
Diffstat (limited to 'src')
-rw-r--r--src/yuzu/CMakeLists.txt3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/yuzu/CMakeLists.txt b/src/yuzu/CMakeLists.txt
index ec969a9a7..37394be37 100644
--- a/src/yuzu/CMakeLists.txt
+++ b/src/yuzu/CMakeLists.txt
@@ -162,6 +162,9 @@ target_compile_definitions(yuzu PRIVATE
162 162
163 # Disable implicit type narrowing in signal/slot connect() calls. 163 # Disable implicit type narrowing in signal/slot connect() calls.
164 -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT 164 -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT
165
166 # Disable unsafe overloads of QProcess' start() function.
167 -DQT_NO_PROCESS_COMBINED_ARGUMENT_START
165) 168)
166 169
167if (YUZU_ENABLE_COMPATIBILITY_REPORTING) 170if (YUZU_ENABLE_COMPATIBILITY_REPORTING)